date:20110927

[webkit-changes] [96071] trunk/Tools

2011-09-27 Thread ossy

Title: [96071] trunk/Tools








Revision 96071
Author o...@webkit.org
Date 2011-09-26 23:15:20 -0700 (Mon, 26 Sep 2011)


Log Message
[Qt][WK2] Unreviewed buildfix after r96005.

* WebKitTestRunner/qt/TestInvocationQt.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/qt/TestInvocationQt.cpp




Diff

Modified: trunk/Tools/ChangeLog (96070 => 96071)

--- trunk/Tools/ChangeLog	2011-09-27 05:50:02 UTC (rev 96070)
+++ trunk/Tools/ChangeLog	2011-09-27 06:15:20 UTC (rev 96071)
@@ -1,3 +1,10 @@
+2011-09-26  Csaba Osztrogonác  o...@webkit.org
+
+[Qt][WK2] Unreviewed buildfix after r96005.
+
+* WebKitTestRunner/qt/TestInvocationQt.cpp:
+(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
+
 2011-09-26  Dimitri Glazkov  dglaz...@chromium.org
 
 garden-o-matic should be pretty in Open Sans.


Modified: trunk/Tools/WebKitTestRunner/qt/TestInvocationQt.cpp (96070 => 96071)

--- trunk/Tools/WebKitTestRunner/qt/TestInvocationQt.cpp	2011-09-27 05:50:02 UTC (rev 96070)
+++ trunk/Tools/WebKitTestRunner/qt/TestInvocationQt.cpp	2011-09-27 06:15:20 UTC (rev 96071)
@@ -59,8 +59,11 @@
 fflush(stdout);
 }
 
-void TestInvocation::dumpPixelsAndCompareWithExpected(WKImageRef imageRef)
+void TestInvocation::dumpPixelsAndCompareWithExpected(WKImageRef imageRef, WKArrayRef repaintRects)
 {
+//FIXME: https://bugs.webkit.org/show_bug.cgi?id=68870
+UNUSED_PARAM(repaintRects);
+
 QImage image = WKImageCreateQImage(imageRef);
 QCryptographicHash hash(QCryptographicHash::Md5);
 for (unsigned row = 0; row  image.height(); ++row)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96072] trunk/Tools

2011-09-27 Thread ossy

Title: [96072] trunk/Tools








Revision 96072
Author o...@webkit.org
Date 2011-09-26 23:26:14 -0700 (Mon, 26 Sep 2011)


Log Message
[Qt][WK2] One more unreviewed buildfix after r96005.

* WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/qt/TestInvocationQt.cpp




Diff

Modified: trunk/Tools/ChangeLog (96071 => 96072)

--- trunk/Tools/ChangeLog	2011-09-27 06:15:20 UTC (rev 96071)
+++ trunk/Tools/ChangeLog	2011-09-27 06:26:14 UTC (rev 96072)
@@ -1,5 +1,11 @@
 2011-09-26  Csaba Osztrogonác  o...@webkit.org
 
+[Qt][WK2] One more unreviewed buildfix after r96005.
+
+* WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
+
+2011-09-26  Csaba Osztrogonác  o...@webkit.org
+
 [Qt][WK2] Unreviewed buildfix after r96005.
 
 * WebKitTestRunner/qt/TestInvocationQt.cpp:


Modified: trunk/Tools/WebKitTestRunner/qt/TestInvocationQt.cpp (96071 => 96072)

--- trunk/Tools/WebKitTestRunner/qt/TestInvocationQt.cpp	2011-09-27 06:15:20 UTC (rev 96071)
+++ trunk/Tools/WebKitTestRunner/qt/TestInvocationQt.cpp	2011-09-27 06:26:14 UTC (rev 96072)
@@ -30,6 +30,7 @@
 #include QCryptographicHash
 #include WebKit2/WKImageQt.h
 #include stdio.h
+#include UnusedParam.h
 
 namespace WTR {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96073] trunk

2011-09-27 Thread commit-queue

Title: [96073] trunk








Revision 96073
Author commit-qu...@webkit.org
Date 2011-09-26 23:27:02 -0700 (Mon, 26 Sep 2011)


Log Message
Implement PopStateEvent.state with SerializedScriptValue and ScriptValue
https://bugs.webkit.org/show_bug.cgi?id=68345

Patch by Kentaro Hara hara...@chromium.org on 2011-09-26
Reviewed by Adam Barth.

Source/WebCore:

Previously, the following test cases fail or crash:

- shouldBe(new PopStateEvent('eventType', { state: object1 }).state, object1) - FAIL
- new PopStateEvent('eventType', { state: document }).state - CRASH in DRT

This is because PopStateEvent.state is implemented not as ScriptValue but as SerializedScriptValue.
However, we cannot simply change the type of PopStateEvent.state to ScriptValue,
since PopStateEvent can be constructed in the context that does not know ScriptValue.
For example, Document.cpp calls PopStateEvent::create() with SerializedScriptValue
popped from HistoryItem, but we cannot deserialize the SerializedScriptValue into
the corresponding ScriptValue here because the deserialization requires ExecState.
In other words, although we want to store PopStateEvent.state by ScriptValue internally,
PopStateEvent still needs to provide an API to construct it with SerializedScriptValue.
With these observations, this patch makes the following changes:

- If PopStateEvent is constructed with ScriptValue, it is stored as ScriptValue internally.
When PopStateEvent.state is called, the ScriptValue is returned.
- If PopStateEvent is constructed with SerializedScriptValue, it is stored as
SerializedScriptValue internally (since we cannot deserialize it into ScriptValue
at this point). When PopStateEvent.state is called, the SerializedScriptValue is
deserialized into the corresponding ScriptValue, and the ScriptValue is returned.

Tests: fast/events/constructors/pop-state-event-constructor.html
   fast/events/fire-popstate-event.html

* GNUmakefile.list.am: Added JSPopStateEventCustom.cpp.
* UseJSC.cmake: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/js/JSBindingsAllInOne.cpp: Ditto.
* bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::state): Custom getter for PopStateEvent.state.
* bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter): Custom getter for PopStateEvent.state.
* dom/PopStateEvent.cpp:
(WebCore::PopStateEventInit::PopStateEventInit): Added initialization code for PopStateEvent.m_state.
(WebCore::PopStateEvent::PopStateEvent): Ditto.
(WebCore::PopStateEvent::create): Ditto.
(WebCore::PopStateEvent::initPopStateEvent): Ditto.
* dom/PopStateEvent.h:
(WebCore::PopStateEvent::serializedState): Getter.
(WebCore::PopStateEvent::state): Getter.
* dom/PopStateEvent.idl: Change the type of 'stateArg' and 'state' to DOMObject. Added [CustomGetter] to 'state'.

LayoutTests:

* fast/events/constructors/pop-state-event-constructor-expected.txt:
* fast/events/constructors/pop-state-event-constructor.html: Removed failures and crashes. Added one test case.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/constructors/pop-state-event-constructor-expected.txt
trunk/LayoutTests/fast/events/constructors/pop-state-event-constructor.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/UseJSC.cmake
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.pro
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp
trunk/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp
trunk/Source/WebCore/dom/PopStateEvent.cpp
trunk/Source/WebCore/dom/PopStateEvent.h
trunk/Source/WebCore/dom/PopStateEvent.idl


Added Paths

trunk/Source/WebCore/bindings/js/JSPopStateEventCustom.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (96072 => 96073)

--- trunk/LayoutTests/ChangeLog	2011-09-27 06:26:14 UTC (rev 96072)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 06:27:02 UTC (rev 96073)
@@ -1,3 +1,13 @@
+2011-09-26  Kentaro Hara  hara...@chromium.org
+
+Implement PopStateEvent.state with SerializedScriptValue and ScriptValue
+https://bugs.webkit.org/show_bug.cgi?id=68345
+
+Reviewed by Adam Barth.
+
+* fast/events/constructors/pop-state-event-constructor-expected.txt:
+* fast/events/constructors/pop-state-event-constructor.html: Removed failures and crashes. Added one test case.
+
 2011-09-09  Simon Fraser  simon.fra...@apple.com
 
 Translucent scrollbars on composited layers render incorrectly


Modified: trunk/LayoutTests/fast/events/constructors/pop-state-event-constructor-expected.txt (96072 => 96073)

--- trunk/LayoutTests/fast/events/constructors/pop-state-event-constructor-expected.txt	2011-09-27 06:26:14 UTC (rev 96072)
+++ trunk/LayoutTests/fast/events/constructors/pop-state-event-constructor-expected.txt	2011-09-27 06:27:02 UTC (rev 96073)
@@ -10,21 +10,23 @@
 PASS new

[webkit-changes] [96074] trunk/Tools

2011-09-27 Thread dglazkov

Title: [96074] trunk/Tools








Revision 96074
Author dglaz...@chromium.org
Date 2011-09-26 23:32:10 -0700 (Mon, 26 Sep 2011)


Log Message
garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
https://bugs.webkit.org/show_bug.cgi?id=68864

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js (96073 => 96074)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js	2011-09-27 06:27:02 UTC (rev 96073)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js	2011-09-27 06:32:10 UTC (rev 96074)
@@ -123,7 +123,7 @@
 failingTestsSummary.addCommitData({
 time: minutesAgo(currentMinutesAgo++),
 revision: currentRevision++,
-title: bugTitles.cycle(),
+summary: bugTitles.cycle(),
 author: people.cycle(),
 reviewer: people.cycle()
 });


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js (96073 => 96074)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js	2011-09-27 06:27:02 UTC (rev 96073)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js	2011-09-27 06:32:10 UTC (rev 96074)
@@ -108,24 +108,25 @@
 {
 this._revision = commitData.revision;
 var linkToRevision = this._description.appendChild(document.createElement('a'));
+this._details = this._description.appendChild(document.createElement('span'));
 linkToRevision.href = ""
 linkToRevision.target = '_blank';
 linkToRevision.textContent = commitData.revision;
-this._addDescriptionPart('summary', commitData);
-this._addDescriptionPart('author', commitData);
-this._addDescriptionPart('reviewer', commitData);
+this._addDetail('summary', commitData);
+this._addDetail('author', commitData);
+this._addDetail('reviewer', commitData);
 },
 hasRevision: function(revision)
 {
 return this._revision == revision;
 },
-_addDescriptionPart: function(part, commitData)
+_addDetail: function(part, commitData)
 {
 var content = commitData[part];
 if (!content)
 return;
 
-var span = this._description.appendChild(document.createElement('span'));
+var span = this._details.appendChild(document.createElement('span'));
 span.className = part;
 span.textContent = content;
 }


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (96073 => 96074)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js	2011-09-27 06:27:02 UTC (rev 96073)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js	2011-09-27 06:32:10 UTC (rev 96074)
@@ -88,9 +88,11 @@
 equal(suspiciousCommit.innerHTML,
 'div class=description' +
 'a href="" target=_blank1/a' +
-'span class=summarysummary/span' +
-'span class=authorauthor/span' +
-'span class=reviewerreviewer/span' +
+'span' +
+'span class=summarysummary/span' +
+'span class=authorauthor/span' +
+'span class=reviewerreviewer/span' +
+'/span' +
 '/div' +
 'ul class=actions' +
 'libutton class=action title=Blames this failure on this revision.Blame/button/li' +
@@ -195,9 +197,11 @@
 'li' +
 'div class=description' +
 'a href=""

[webkit-changes] [96075] trunk/LayoutTests

2011-09-27 Thread reni

Title: [96075] trunk/LayoutTests








Revision 96075
Author r...@webkit.org
Date 2011-09-26 23:43:27 -0700 (Mon, 26 Sep 2011)


Log Message
[Qt] Skip two tests because they are failing after r96070.

Unreviewed gardening.

* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (96074 => 96075)

--- trunk/LayoutTests/ChangeLog	2011-09-27 06:32:10 UTC (rev 96074)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 06:43:27 UTC (rev 96075)
@@ -1,3 +1,11 @@
+2011-09-26  Renata Hodovan  r...@webkit.org
+
+[Qt] Skip two tests because they are failing after r96070.
+
+Unreviewed gardening.
+
+* platform/qt/Skipped:
+
 2011-09-26  Kentaro Hara  hara...@chromium.org
 
 Implement PopStateEvent.state with SerializedScriptValue and ScriptValue


Modified: trunk/LayoutTests/platform/qt/Skipped (96074 => 96075)

--- trunk/LayoutTests/platform/qt/Skipped	2011-09-27 06:32:10 UTC (rev 96074)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-09-27 06:43:27 UTC (rev 96075)
@@ -2377,3 +2377,9 @@
 # editing/selection/select-bidi-run.html fails on Qt
 # https://bugs.webkit.org/show_bug.cgi?id=68854
 editing/selection/select-bidi-run.html
+
+# Two tests fail after r96070
+# https://bugs.webkit.org/show_bug.cgi?id=68872
+fast/loader/stateobjects/pushstate-clears-forward-history.html
+fast/frames/frame-dead-region.html
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96077] trunk/LayoutTests

2011-09-27 Thread reni

Title: [96077] trunk/LayoutTests








Revision 96077
Author r...@webkit.org
Date 2011-09-27 00:05:21 -0700 (Tue, 27 Sep 2011)


Log Message
[Qt] Add missing test expecteds after r95924.

Unreviewed gardening.

* platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
* platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.png
trunk/LayoutTests/platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96076 => 96077)

--- trunk/LayoutTests/ChangeLog	2011-09-27 06:55:34 UTC (rev 96076)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 07:05:21 UTC (rev 96077)
@@ -1,3 +1,12 @@
+2011-09-27  Renata Hodovan  r...@webkit.org
+
+[Qt] Add missing test expecteds after r95924.
+
+Unreviewed gardening.
+
+* platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
+* platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Added.
+
 2011-09-26  Ryosuke Niwa  rn...@webkit.org
 
 dump-as-markup conversion: editing/deleting/delete-to-end-of-paragraph.html


Added: trunk/LayoutTests/platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt (0 => 96077)

--- trunk/LayoutTests/platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt	2011-09-27 07:05:21 UTC (rev 96077)
@@ -0,0 +1,20 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x32
+  RenderBlock {HTML} at (0,0) size 800x32
+RenderBody {BODY} at (8,8) size 784x16
+  RenderRuby (inline) {RUBY} at (0,0) size 64x17
+RenderRubyRun (anonymous) at (0,0) size 64x16
+  RenderRubyBase (anonymous) at (0,0) size 64x16
+RenderBlock (anonymous) at (0,0) size 64x16
+  RenderText {#text} at (0,0) size 64x17
+text run at (0,0) width 64: PASS
+  RenderInline {I} at (0,0) size 0x0
+RenderText {#text} at (0,0) size 0x0
+RenderBlock (anonymous) at (0,16) size 64x0
+  RenderInline {SPAN} at (0,0) size 0x0
+RenderInline {SPAN} at (0,0) size 0x0
+  RenderText {#text} at (0,0) size 0x0
+  RenderText {#text} at (0,0) size 0x0
+RenderBlock (anonymous) at (0,16) size 64x0
+  RenderInline {I} at (0,0) size 0x0






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96083] trunk/LayoutTests

2011-09-27 Thread hamaji

Title: [96083] trunk/LayoutTests








Revision 96083
Author ham...@chromium.org
Date 2011-09-27 01:56:26 -0700 (Tue, 27 Sep 2011)


Log Message
[Chromium] Layout Test canvas/philip/tests/toDataURL.jpeg.*.html is failing on Mac 10.5 CG
https://bugs.webkit.org/show_bug.cgi?id=68879

Unreviewed test_expectations.txt update.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96082 => 96083)

--- trunk/LayoutTests/ChangeLog	2011-09-27 08:33:21 UTC (rev 96082)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 08:56:26 UTC (rev 96083)
@@ -1,3 +1,12 @@
+2011-09-27  Shinichiro Hamaji  ham...@chromium.org
+
+[Chromium] Layout Test canvas/philip/tests/toDataURL.jpeg.*.html is failing on Mac 10.5 CG
+https://bugs.webkit.org/show_bug.cgi?id=68879
+
+Unreviewed test_expectations.txt update.
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-27  Arun Patole  bmf...@motorola.com
 
 Audio element doesn't emit the 'playing' event every time it starts playing, after it has finished playing.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96082 => 96083)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 08:33:21 UTC (rev 96082)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 08:56:26 UTC (rev 96083)
@@ -3775,3 +3775,7 @@
 BUGCR97657 MAC CPU DEBUG : media/audio-repaint.html = TIMEOUT IMAGE PASS
 
 BUGWK68858 : svg/filters/animate-fill.svg = IMAGE
+
+BUGWK68879 MAC CPU-CG : canvas/philip/tests/toDataURL.jpeg.alpha.html = TEXT
+BUGWK68879 MAC CPU-CG : canvas/philip/tests/toDataURL.jpeg.primarycolours.html = TEXT
+BUGWK68879 MAC CPU-CG : canvas/philip/tests/toDataURL.jpeg.quality.basic.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96085] trunk/LayoutTests

2011-09-27 Thread philn

Title: [96085] trunk/LayoutTests








Revision 96085
Author ph...@webkit.org
Date 2011-09-27 02:24:24 -0700 (Tue, 27 Sep 2011)


Log Message
Unreviewed, GTK gardening

* platform/gtk/Skipped: Skip svg/filters/animate-fill.svg failing
in 32-Bits Release.
* platform/gtk/test_expectations.txt: Mark
media/video-timeupdate-reverse-play.html as flaky because of bug 67407.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/gtk/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96084 => 96085)

--- trunk/LayoutTests/ChangeLog	2011-09-27 09:00:08 UTC (rev 96084)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 09:24:24 UTC (rev 96085)
@@ -1,3 +1,12 @@
+2011-09-27  Philippe Normand  pnorm...@igalia.com
+
+Unreviewed, GTK gardening
+
+* platform/gtk/Skipped: Skip svg/filters/animate-fill.svg failing
+in 32-Bits Release.
+* platform/gtk/test_expectations.txt: Mark
+media/video-timeupdate-reverse-play.html as flaky because of bug 67407.
+
 2011-09-27  Shinichiro Hamaji  ham...@chromium.org
 
 [Chromium] Layout Test canvas/philip/tests/toDataURL.jpeg.*.html is failing on Mac 10.5 CG


Modified: trunk/LayoutTests/platform/gtk/Skipped (96084 => 96085)

--- trunk/LayoutTests/platform/gtk/Skipped	2011-09-27 09:00:08 UTC (rev 96084)
+++ trunk/LayoutTests/platform/gtk/Skipped	2011-09-27 09:24:24 UTC (rev 96085)
@@ -1017,6 +1017,7 @@
 svg/W3C-SVG-1.1/animate-elem-30-t.svg
 svg/W3C-SVG-1.1/animate-elem-03-t.svg
 svg/W3C-SVG-1.1/animate-elem-33-t.svg
+svg/filters/animate-fill.svg
 # Fail on 32-bits Debug
 svg/W3C-SVG-1.1/animate-elem-46-t.svg
 svg/W3C-SVG-1.1/animate-elem-82-t.svg


Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (96084 => 96085)

--- trunk/LayoutTests/platform/gtk/test_expectations.txt	2011-09-27 09:00:08 UTC (rev 96084)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt	2011-09-27 09:24:24 UTC (rev 96085)
@@ -11,6 +11,7 @@
 
 BUGWK68536 : media/media-blocked-by-beforeload.html = PASS TEXT
 BUGWK68878 : media/video-playing-and-pause.html = PASS TEXT
+BUGWK67407 : media/video-timeupdate-reverse-play.html = PASS TEXT
 
 BUGWK68523 : svg/zoom/page/zoom-svg-through-object-with-auto-size.html = PASS TEXT
 BUGWK68523 : svg/zoom/page/zoom-svg-through-object-with-override-size.html = PASS TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96086] trunk/LayoutTests

2011-09-27 Thread hamaji

Title: [96086] trunk/LayoutTests








Revision 96086
Author ham...@chromium.org
Date 2011-09-27 02:31:07 -0700 (Tue, 27 Sep 2011)


Log Message
[Crhomium] Layout Test svg/text/selection-(background-color|styles).xhtml is failing
https://bugs.webkit.org/show_bug.cgi?id=68881

Unreviewed test_expectations.txt update.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96085 => 96086)

--- trunk/LayoutTests/ChangeLog	2011-09-27 09:24:24 UTC (rev 96085)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 09:31:07 UTC (rev 96086)
@@ -1,3 +1,12 @@
+2011-09-27  Shinichiro Hamaji  ham...@chromium.org
+
+[Crhomium] Layout Test svg/text/selection-(background-color|styles).xhtml is failing
+https://bugs.webkit.org/show_bug.cgi?id=68881
+
+Unreviewed test_expectations.txt update.
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-27  Philippe Normand  pnorm...@igalia.com
 
 Unreviewed, GTK gardening


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96085 => 96086)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 09:24:24 UTC (rev 96085)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 09:31:07 UTC (rev 96086)
@@ -3779,3 +3779,6 @@
 BUGWK68879 MAC CPU-CG : canvas/philip/tests/toDataURL.jpeg.alpha.html = TEXT
 BUGWK68879 MAC CPU-CG : canvas/philip/tests/toDataURL.jpeg.primarycolours.html = TEXT
 BUGWK68879 MAC CPU-CG : canvas/philip/tests/toDataURL.jpeg.quality.basic.html = TEXT
+
+BUGWK68881 DEBUG : svg/text/selection-background-color.xhtml = CRASH
+BUGWK68881 DEBUG : svg/text/selection-styles.xhtml = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96087] trunk

2011-09-27 Thread carlosgc

Title: [96087] trunk








Revision 96087
Author carlo...@webkit.org
Date 2011-09-27 02:35:55 -0700 (Tue, 27 Sep 2011)


Log Message
[GTK] Reorganize header files
https://bugs.webkit.org/show_bug.cgi?id=65616

Reviewed by Martin Robinson.

.:

* GNUmakefile.am: Initialize $libwebkitgtkincludedir to
$(prefix)/include/webkitgtk-api-version

Source/_javascript_Core:

Install header files under $libwebkitgtkincludedir/_javascript_Core.

* GNUmakefile.am: Use $libwebkitgtkincludedir.
* _javascript_coregtk.pc.in: Use webkitgtk-api-version as include dir.

Source/WebKit/gtk:

Install header files under $libwebkitgtkincludedir/webkit.

* GNUmakefile.am: Use $libwebkitgtkincludedir.
* webkit.pc.in: Use webkitgtk-api-version as include dir.

Modified Paths

trunk/ChangeLog
trunk/GNUmakefile.am
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/GNUmakefile.am
trunk/Source/_javascript_Core/_javascript_coregtk.pc.in
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/GNUmakefile.am
trunk/Source/WebKit/gtk/webkit.pc.in




Diff

Modified: trunk/ChangeLog (96086 => 96087)

--- trunk/ChangeLog	2011-09-27 09:31:07 UTC (rev 96086)
+++ trunk/ChangeLog	2011-09-27 09:35:55 UTC (rev 96087)
@@ -1,3 +1,13 @@
+2011-09-27  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Reorganize header files
+https://bugs.webkit.org/show_bug.cgi?id=65616
+
+Reviewed by Martin Robinson.
+
+* GNUmakefile.am: Initialize $libwebkitgtkincludedir to
+$(prefix)/include/webkitgtk-api-version
+
 2011-09-26  Raphael Kubo da Costa  k...@profusion.mobi
 
 [CMake] Remove FindFreetype.cmake


Modified: trunk/GNUmakefile.am (96086 => 96087)

--- trunk/GNUmakefile.am	2011-09-27 09:31:07 UTC (rev 96086)
+++ trunk/GNUmakefile.am	2011-09-27 09:35:55 UTC (rev 96087)
@@ -41,6 +41,7 @@
 WebKit := $(srcdir)/Source/WebKit/gtk
 WebKit2 := $(srcdir)/Source/WebKit2
 pkgconfigdir := $(libdir)/pkgconfig
+libwebkitgtkincludedir := $(prefix)/include/webkitgtk-@WEBKITGTK_API_VERSION@
 
 # Libraries and support components
 bin_PROGRAMS :=


Modified: trunk/Source/_javascript_Core/ChangeLog (96086 => 96087)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-27 09:31:07 UTC (rev 96086)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-27 09:35:55 UTC (rev 96087)
@@ -1,3 +1,15 @@
+2011-09-27  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Reorganize header files
+https://bugs.webkit.org/show_bug.cgi?id=65616
+
+Reviewed by Martin Robinson.
+
+Install header files under $libwebkitgtkincludedir/_javascript_Core.
+
+* GNUmakefile.am: Use $libwebkitgtkincludedir.
+* _javascript_coregtk.pc.in: Use webkitgtk-api-version as include dir.
+
 2011-09-26  Geoffrey Garen  gga...@apple.com
 
 REGRESSION (r95912): Conservative marking doesn't filter out pointers to


Modified: trunk/Source/_javascript_Core/GNUmakefile.am (96086 => 96087)

--- trunk/Source/_javascript_Core/GNUmakefile.am	2011-09-27 09:31:07 UTC (rev 96086)
+++ trunk/Source/_javascript_Core/GNUmakefile.am	2011-09-27 09:35:55 UTC (rev 96087)
@@ -16,7 +16,7 @@
 nodist_libjavascriptcoregtk_@WEBKITGTK_API_MAJOR_VERSION@_@WEBKITGTK_API_MINOR_VERSION@_la_SOURCES = \
 	$(_javascript_core_built_sources)
 
-libjavascriptcoregtk_@WEBKITGTK_API_MAJOR_VERSION@_@WEBKITGTK_API_MINOR_VERSION@_ladir = $(prefix)/include/webkit-@WEBKITGTK_API_VERSION@/_javascript_Core
+libjavascriptcoregtk_@WEBKITGTK_API_MAJOR_VERSION@_@WEBKITGTK_API_MINOR_VERSION@_ladir = $(libwebkitgtkincludedir)/_javascript_Core
 libjavascriptcoregtk_@WEBKITGTK_API_MAJOR_VERSION@_@WEBKITGTK_API_MINOR_VERSION@_la_HEADERS = $(_javascript_core_h_api)
 
 libjavascriptcoregtk_@WEBKITGTK_API_MAJOR_VERSION@_@WEBKITGTK_API_MINOR_VERSION@_la_SOURCES = \


Modified: trunk/Source/_javascript_Core/_javascript_coregtk.pc.in (96086 => 96087)

--- trunk/Source/_javascript_Core/_javascript_coregtk.pc.in	2011-09-27 09:31:07 UTC (rev 96086)
+++ trunk/Source/_javascript_Core/_javascript_coregtk.pc.in	2011-09-27 09:35:55 UTC (rev 96087)
@@ -8,4 +8,4 @@
 Version: @VERSION@
 Requires: glib-2.0
 Libs: -L${libdir} -ljavascriptcoregtk-@WEBKITGTK_API_VERSION@
-Cflags: -I${includedir}/webkit-@WEBKITGTK_API_VERSION@
+Cflags: -I${includedir}/webkitgtk-@WEBKITGTK_API_VERSION@


Modified: trunk/Source/WebKit/gtk/ChangeLog (96086 => 96087)

--- trunk/Source/WebKit/gtk/ChangeLog	2011-09-27 09:31:07 UTC (rev 96086)
+++ trunk/Source/WebKit/gtk/ChangeLog	2011-09-27 09:35:55 UTC (rev 96087)
@@ -1,3 +1,15 @@
+2011-09-27  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Reorganize header files
+https://bugs.webkit.org/show_bug.cgi?id=65616
+
+Reviewed by Martin Robinson.
+
+Install header files under $libwebkitgtkincludedir/webkit.
+
+* GNUmakefile.am: Use $libwebkitgtkincludedir.
+* webkit.pc.in: Use webkitgtk-api-version as include dir.
+
 2011-09-26  Gustavo Noronha Silva  gustavo.noro...@collabora.com
 
 Fix

[webkit-changes] [96088] trunk/LayoutTests

2011-09-27 Thread hamaji

Title: [96088] trunk/LayoutTests








Revision 96088
Author ham...@chromium.org
Date 2011-09-27 02:51:51 -0700 (Tue, 27 Sep 2011)


Log Message
[Crhomium] Layout Test compositing/video-page-visibility.html is failing on GPU linux
https://bugs.webkit.org/show_bug.cgi?id=68882

Unreviewed test_expectations.txt update.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96087 => 96088)

--- trunk/LayoutTests/ChangeLog	2011-09-27 09:35:55 UTC (rev 96087)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 09:51:51 UTC (rev 96088)
@@ -1,5 +1,14 @@
 2011-09-27  Shinichiro Hamaji  ham...@chromium.org
 
+[Crhomium] Layout Test compositing/video-page-visibility.html is failing on GPU linux
+https://bugs.webkit.org/show_bug.cgi?id=68882
+
+Unreviewed test_expectations.txt update.
+
+* platform/chromium/test_expectations.txt:
+
+2011-09-27  Shinichiro Hamaji  ham...@chromium.org
+
 [Crhomium] Layout Test svg/text/selection-(background-color|styles).xhtml is failing
 https://bugs.webkit.org/show_bug.cgi?id=68881
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96087 => 96088)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 09:35:55 UTC (rev 96087)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 09:51:51 UTC (rev 96088)
@@ -3782,3 +3782,5 @@
 
 BUGWK68881 DEBUG : svg/text/selection-background-color.xhtml = CRASH
 BUGWK68881 DEBUG : svg/text/selection-styles.xhtml = CRASH
+
+BUGWK68882 LINUX GPU : compositing/video-page-visibility.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96090] trunk/LayoutTests

2011-09-27 Thread hamaji

Title: [96090] trunk/LayoutTests








Revision 96090
Author ham...@chromium.org
Date 2011-09-27 03:06:08 -0700 (Tue, 27 Sep 2011)


Log Message
[Chromium] Layout Test fast/canvas/webgl/premultiplyalpha-test.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68885

Unreviewed test_expectations.txt update.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96089 => 96090)

--- trunk/LayoutTests/ChangeLog	2011-09-27 09:56:27 UTC (rev 96089)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 10:06:08 UTC (rev 96090)
@@ -1,5 +1,14 @@
 2011-09-27  Shinichiro Hamaji  ham...@chromium.org
 
+[Chromium] Layout Test fast/canvas/webgl/premultiplyalpha-test.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=68885
+
+Unreviewed test_expectations.txt update.
+
+* platform/chromium/test_expectations.txt:
+
+2011-09-27  Shinichiro Hamaji  ham...@chromium.org
+
 Layout Test platform/chromium/compositing/zoom-animator-scale-test.html is failing
 https://bugs.webkit.org/show_bug.cgi?id=68852
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96089 => 96090)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 09:56:27 UTC (rev 96089)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 10:06:08 UTC (rev 96090)
@@ -3784,3 +3784,5 @@
 BUGWK68881 DEBUG : svg/text/selection-styles.xhtml = CRASH
 
 BUGWK68882 LINUX GPU : compositing/video-page-visibility.html = IMAGE
+
+BUGWK68885 MAC CPU-CG : ast/canvas/webgl/premultiplyalpha-test.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96092] trunk/Source/WebKit/chromium

2011-09-27 Thread commit-queue

Title: [96092] trunk/Source/WebKit/chromium








Revision 96092
Author commit-qu...@webkit.org
Date 2011-09-27 03:22:19 -0700 (Tue, 27 Sep 2011)


Log Message
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot webkit.review@gmail.com on 2011-09-27

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (96091 => 96092)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-09-27 10:15:46 UTC (rev 96091)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-09-27 10:22:19 UTC (rev 96092)
@@ -1,3 +1,9 @@
+2011-09-27  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed.  Rolled DEPS.
+
+* DEPS:
+
 2011-09-26  Nat Duca  nd...@chromium.org
 
 [chromium] Make CCThreadProxy draw


Modified: trunk/Source/WebKit/chromium/DEPS (96091 => 96092)

--- trunk/Source/WebKit/chromium/DEPS	2011-09-27 10:15:46 UTC (rev 96091)
+++ trunk/Source/WebKit/chromium/DEPS	2011-09-27 10:22:19 UTC (rev 96092)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '102721'
+  'chromium_rev': '102890'
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96093] trunk/Source/WebCore

2011-09-27 Thread xan

Title: [96093] trunk/Source/WebCore








Revision 96093
Author x...@webkit.org
Date 2011-09-27 03:28:00 -0700 (Tue, 27 Sep 2011)


Log Message
[GTK] Add compatibility methods for DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=68884

Reviewed by Philippe Normand.

Add compatibility methods for our DOM bindings.

* bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_blob_slice): alias to the new method name.
(webkit_dom_html_form_element_dispatch_form_change): this was
removed from WebCore, so just print a warning about it.
(webkit_dom_html_form_element_dispatch_form_input): ditto.
* bindings/gobject/WebKitDOMCustom.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp
trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (96092 => 96093)

--- trunk/Source/WebCore/ChangeLog	2011-09-27 10:22:19 UTC (rev 96092)
+++ trunk/Source/WebCore/ChangeLog	2011-09-27 10:28:00 UTC (rev 96093)
@@ -1,3 +1,19 @@
+2011-09-27  Xan Lopez  xlo...@igalia.com
+
+[GTK] Add compatibility methods for DOM bindings
+https://bugs.webkit.org/show_bug.cgi?id=68884
+
+Reviewed by Philippe Normand.
+
+Add compatibility methods for our DOM bindings.
+
+* bindings/gobject/WebKitDOMCustom.cpp:
+(webkit_dom_blob_slice): alias to the new method name.
+(webkit_dom_html_form_element_dispatch_form_change): this was
+removed from WebCore, so just print a warning about it.
+(webkit_dom_html_form_element_dispatch_form_input): ditto.
+* bindings/gobject/WebKitDOMCustom.h:
+
 2011-09-27  Ryosuke Niwa  rn...@webkit.org
 
 Encapsulate m_firstNodeInserted and m_lastLeafInserted in node insertion logic


Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp (96092 => 96093)

--- trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp	2011-09-27 10:22:19 UTC (rev 96092)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp	2011-09-27 10:28:00 UTC (rev 96093)
@@ -19,6 +19,8 @@
 #include config.h
 #include WebKitDOMCustom.h
 
+#include WebKitDOMBlob.h
+#include WebKitDOMHTMLFormElement.h
 #include WebKitDOMHTMLInputElement.h
 #include WebKitDOMHTMLInputElementPrivate.h
 #include WebKitDOMHTMLTextAreaElement.h
@@ -40,3 +42,23 @@
 return core(input)-lastChangeWasUserEdit();
 }
 
+/* Compatibility */
+WebKitDOMBlob*
+webkit_dom_blob_slice(WebKitDOMBlob* self, gint64 start, gint64 end, const gchar* content_type)
+{
+return webkit_dom_blob_webkit_slice(self, start, end, content_type);
+}
+
+void
+webkit_dom_html_form_element_dispatch_form_change(WebKitDOMHTMLFormElement* self)
+{
+g_warning(The onformchange functionality has been removed from the DOM spec, this function does nothing.);
+}
+
+void
+webkit_dom_html_form_element_dispatch_form_input(WebKitDOMHTMLFormElement* self)
+{
+g_warning(The onforminput functionality has been removed from the DOM spec, this function does nothing.);
+}
+
+


Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h (96092 => 96093)

--- trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h	2011-09-27 10:22:19 UTC (rev 96092)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h	2011-09-27 10:28:00 UTC (rev 96093)
@@ -28,6 +28,11 @@
 WEBKIT_API gboolean webkit_dom_html_text_area_element_is_edited(WebKitDOMHTMLTextAreaElement*);
 WEBKIT_API gboolean webkit_dom_html_input_element_is_edited(WebKitDOMHTMLInputElement*);
 
+/* Compatibility */
+WEBKIT_API WebKitDOMBlob* webkit_dom_blob_slice(WebKitDOMBlob* self, gint64 start, gint64 end, const gchar* content_type);
+WEBKIT_API void webkit_dom_html_form_element_dispatch_form_change(WebKitDOMHTMLFormElement* self);
+WEBKIT_API void webkit_dom_html_form_element_dispatch_form_input(WebKitDOMHTMLFormElement* self);
+
 G_END_DECLS
 
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96094] releases/WebKitGTK/webkit-1.6/Source/WebCore

2011-09-27 Thread alex

Title: [96094] releases/WebKitGTK/webkit-1.6/Source/WebCore








Revision 96094
Author a...@webkit.org
Date 2011-09-27 03:33:43 -0700 (Tue, 27 Sep 2011)


Log Message
Merging http://trac.webkit.org/changeset/96093

Modified Paths

releases/WebKitGTK/webkit-1.6/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.6/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp
releases/WebKitGTK/webkit-1.6/Source/WebCore/bindings/gobject/WebKitDOMCustom.h




Diff

Modified: releases/WebKitGTK/webkit-1.6/Source/WebCore/ChangeLog (96093 => 96094)

--- releases/WebKitGTK/webkit-1.6/Source/WebCore/ChangeLog	2011-09-27 10:28:00 UTC (rev 96093)
+++ releases/WebKitGTK/webkit-1.6/Source/WebCore/ChangeLog	2011-09-27 10:33:43 UTC (rev 96094)
@@ -1,3 +1,19 @@
+2011-09-27  Xan Lopez  xlo...@igalia.com
+
+[GTK] Add compatibility methods for DOM bindings
+https://bugs.webkit.org/show_bug.cgi?id=68884
+
+Reviewed by Philippe Normand.
+
+Add compatibility methods for our DOM bindings.
+
+* bindings/gobject/WebKitDOMCustom.cpp:
+(webkit_dom_blob_slice): alias to the new method name.
+(webkit_dom_html_form_element_dispatch_form_change): this was
+removed from WebCore, so just print a warning about it.
+(webkit_dom_html_form_element_dispatch_form_input): ditto.
+* bindings/gobject/WebKitDOMCustom.h:
+
 2011-09-26  Xan Lopez  xlo...@igalia.com
 
 [GTK] Do not ignore 'Replaceable' attributes in the DOM bindings


Modified: releases/WebKitGTK/webkit-1.6/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp (96093 => 96094)

--- releases/WebKitGTK/webkit-1.6/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp	2011-09-27 10:28:00 UTC (rev 96093)
+++ releases/WebKitGTK/webkit-1.6/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp	2011-09-27 10:33:43 UTC (rev 96094)
@@ -19,6 +19,8 @@
 #include config.h
 #include WebKitDOMCustom.h
 
+#include WebKitDOMBlob.h
+#include WebKitDOMHTMLFormElement.h
 #include WebKitDOMHTMLInputElement.h
 #include WebKitDOMHTMLInputElementPrivate.h
 #include WebKitDOMHTMLTextAreaElement.h
@@ -40,3 +42,23 @@
 return core(input)-lastChangeWasUserEdit();
 }
 
+/* Compatibility */
+WebKitDOMBlob*
+webkit_dom_blob_slice(WebKitDOMBlob* self, gint64 start, gint64 end, const gchar* content_type)
+{
+return webkit_dom_blob_webkit_slice(self, start, end, content_type);
+}
+
+void
+webkit_dom_html_form_element_dispatch_form_change(WebKitDOMHTMLFormElement* self)
+{
+g_warning(The onformchange functionality has been removed from the DOM spec, this function does nothing.);
+}
+
+void
+webkit_dom_html_form_element_dispatch_form_input(WebKitDOMHTMLFormElement* self)
+{
+g_warning(The onforminput functionality has been removed from the DOM spec, this function does nothing.);
+}
+
+


Modified: releases/WebKitGTK/webkit-1.6/Source/WebCore/bindings/gobject/WebKitDOMCustom.h (96093 => 96094)

--- releases/WebKitGTK/webkit-1.6/Source/WebCore/bindings/gobject/WebKitDOMCustom.h	2011-09-27 10:28:00 UTC (rev 96093)
+++ releases/WebKitGTK/webkit-1.6/Source/WebCore/bindings/gobject/WebKitDOMCustom.h	2011-09-27 10:33:43 UTC (rev 96094)
@@ -28,6 +28,11 @@
 WEBKIT_API gboolean webkit_dom_html_text_area_element_is_edited(WebKitDOMHTMLTextAreaElement*);
 WEBKIT_API gboolean webkit_dom_html_input_element_is_edited(WebKitDOMHTMLInputElement*);
 
+/* Compatibility */
+WEBKIT_API WebKitDOMBlob* webkit_dom_blob_slice(WebKitDOMBlob* self, gint64 start, gint64 end, const gchar* content_type);
+WEBKIT_API void webkit_dom_html_form_element_dispatch_form_change(WebKitDOMHTMLFormElement* self);
+WEBKIT_API void webkit_dom_html_form_element_dispatch_form_input(WebKitDOMHTMLFormElement* self);
+
 G_END_DECLS
 
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96095] releases/WebKitGTK/webkit-1.6

2011-09-27 Thread alex

Title: [96095] releases/WebKitGTK/webkit-1.6








Revision 96095
Author a...@webkit.org
Date 2011-09-27 03:43:19 -0700 (Tue, 27 Sep 2011)


Log Message
Bump the release number to 1.6.1 and add the NEWS information

Modified Paths

releases/WebKitGTK/webkit-1.6/Source/WebKit/gtk/NEWS
releases/WebKitGTK/webkit-1.6/configure.ac




Diff

Modified: releases/WebKitGTK/webkit-1.6/Source/WebKit/gtk/NEWS (96094 => 96095)

--- releases/WebKitGTK/webkit-1.6/Source/WebKit/gtk/NEWS	2011-09-27 10:33:43 UTC (rev 96094)
+++ releases/WebKitGTK/webkit-1.6/Source/WebKit/gtk/NEWS	2011-09-27 10:43:19 UTC (rev 96095)
@@ -1,4 +1,12 @@
 
+WebKitGTK+ 1.6.1
+
+
+What's new in WebKitGTK+ 1.6.1?
+
+  - Bug 68884 - [GTK] Add compatibility methods for DOM bindings
+
+
 WebKitGTK+ 1.6.0
 
 


Modified: releases/WebKitGTK/webkit-1.6/configure.ac (96094 => 96095)

--- releases/WebKitGTK/webkit-1.6/configure.ac	2011-09-27 10:33:43 UTC (rev 96094)
+++ releases/WebKitGTK/webkit-1.6/configure.ac	2011-09-27 10:43:19 UTC (rev 96095)
@@ -2,7 +2,7 @@
 
 m4_define([webkit_major_version], [1])
 m4_define([webkit_minor_version], [6])
-m4_define([webkit_micro_version], [0])
+m4_define([webkit_micro_version], [1])
 
 # This is the version we'll be using as part of our User-Agent string
 # e.g., AppleWebKit/$(webkit_user_agent_version) ...
@@ -35,7 +35,7 @@
 
 dnl # Libtool library version, not to confuse with API version
 dnl # see http://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html
-LIBWEBKITGTK_VERSION=10:0:10
+LIBWEBKITGTK_VERSION=11:0:11
 AC_SUBST([LIBWEBKITGTK_VERSION])
 
 AM_INIT_AUTOMAKE([foreign subdir-objects tar-ustar])






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96096] trunk

2011-09-27 Thread commit-queue

Title: [96096] trunk








Revision 96096
Author commit-qu...@webkit.org
Date 2011-09-27 04:20:34 -0700 (Tue, 27 Sep 2011)


Log Message
wrap attribute of textarea element cannot be accessed by _javascript_.
https://bugs.webkit.org/show_bug.cgi?id=68592

Patch by Vineet Chaudhary vineet.chaudh...@motorola.com on 2011-09-27
Reviewed by Kent Tamura.

Source/WebCore:

Added JS interface for wrap attribute to HTMLTextAreaElement.idl.

Test: fast/forms/textarea-wrap-attribute.html

* html/HTMLTextAreaElement.idl:

LayoutTests:

Added test cases to check accessibility to wrap attribute by JS.

* fast/forms/textarea-wrap-attribute-expected.txt: Added.
* fast/forms/textarea-wrap-attribute.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLTextAreaElement.idl


Added Paths

trunk/LayoutTests/fast/forms/textarea-wrap-attribute-expected.txt
trunk/LayoutTests/fast/forms/textarea-wrap-attribute.html




Diff

Modified: trunk/LayoutTests/ChangeLog (96095 => 96096)

--- trunk/LayoutTests/ChangeLog	2011-09-27 10:43:19 UTC (rev 96095)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 11:20:34 UTC (rev 96096)
@@ -1,3 +1,15 @@
+2011-09-27  Vineet Chaudhary  vineet.chaudh...@motorola.com
+
+wrap attribute of textarea element cannot be accessed by _javascript_.
+https://bugs.webkit.org/show_bug.cgi?id=68592
+
+Reviewed by Kent Tamura.
+
+Added test cases to check accessibility to wrap attribute by JS.
+
+* fast/forms/textarea-wrap-attribute-expected.txt: Added.
+* fast/forms/textarea-wrap-attribute.html: Added.
+
 2011-09-27  Shinichiro Hamaji  ham...@chromium.org
 
 [Chromium] Layout Test fast compositing/geometry/limit-layer-bounds-transformed-overflow.html is failing


Added: trunk/LayoutTests/fast/forms/textarea-wrap-attribute-expected.txt (0 => 96096)

--- trunk/LayoutTests/fast/forms/textarea-wrap-attribute-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/textarea-wrap-attribute-expected.txt	2011-09-27 11:20:34 UTC (rev 96096)
@@ -0,0 +1,25 @@
+HTMLTextAreaElement.wrap reflects the wrap= attribute.
+It is not limited to only known values, and it is a DOMString attribute which means it just returns the content attributes's value directly.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+If wrap attribute is not specified it sould be empty String.
+PASS textArea.wrap is ''
+
+Check if it sets warpAttr value hard, should return hard.
+PASS textArea.wrap is 'hard'
+
+Check if it sets warpAttr value as soft, should return soft.
+PASS textArea.wrap is 'soft'
+
+Check if warpAttr present but no keyVal specified, should return empty String.
+PASS textArea.wrap is ''
+
+Check if it sets warpAttr invaild value, should return foo.
+PASS textArea.wrap is 'foo'
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/forms/textarea-wrap-attribute.html (0 => 96096)

--- trunk/LayoutTests/fast/forms/textarea-wrap-attribute.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/textarea-wrap-attribute.html	2011-09-27 11:20:34 UTC (rev 96096)
@@ -0,0 +1,49 @@
+!DOCTYPE HTML
+html
+head
+link rel=stylesheet href=""
+script src=""
+/head
+body
+p id=description/p
+div id=console/div
+script
+description('HTMLTextAreaElement.wrap reflects the wrap= attribute.brIt is not limited to only known values, and it is a DOMString attribute which means it just returns the content attributes\'s value directly.');
+
+
+var textArea = document.createElement('textarea');
+document.body.appendChild(textArea);
+
+debug('If wrap attribute is not specified it sould be empty String.');
+shouldBe('textArea.wrap', '');
+
+debug('');
+debug('Check if it sets warpAttr value hard, should return hard.');
+textArea.wrap = hard;
+shouldBe('textArea.wrap', 'hard');
+
+debug('');
+debug('Check if it sets warpAttr value as soft, should return soft.');
+textArea.wrap = soft;
+shouldBe('textArea.wrap', 'soft');
+
+debug('');
+debug('Check if warpAttr present but no keyVal specified, should return empty String.');
+textArea.wrap = ;
+shouldBe('textArea.wrap', '');
+
+debug('');
+debug('Check if it sets warpAttr invaild value, should return foo.');
+textArea.wrap = foo;
+shouldBe('textArea.wrap', 'foo');
+
+debug('');
+var successfullyParsed = true;
+/script
+script src=""
+/body
+/html
+
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (96095 => 96096)

--- trunk/Source/WebCore/ChangeLog	2011-09-27 10:43:19 UTC (rev 96095)
+++ trunk/Source/WebCore/ChangeLog	2011-09-27 11:20:34 UTC (rev 96096)
@@ -1,3 +1,16 @@
+2011-09-27  Vineet Chaudhary  vineet.chaudh...@motorola.com
+
+wrap attribute of textarea element cannot be accessed by _javascript_.
+https://bugs.webkit.org/show_bug.cgi?id=68592
+
+Reviewed by Kent Tamura.
+
+Added JS interface for wrap attribute to HTMLTextAreaElement.idl.
+
+Test:

[webkit-changes] [96097] trunk

2011-09-27 Thread podivilov

Title: [96097] trunk








Revision 96097
Author podivi...@chromium.org
Date 2011-09-27 05:06:28 -0700 (Tue, 27 Sep 2011)


Log Message
Web Inspector: migrate RawSourceCode clients to SourceMapping class.
https://bugs.webkit.org/show_bug.cgi?id=68524

Source/WebCore:

Clients should use uiSourceCode(), rawLocationToUILocation(), uiLocationToRawLocation() methods of SourceMapping class.
Initially, RawSourceCode may not have associated SourceMapping, so it is natural to extract this methods and associated state to a separate class.

Reviewed by Yury Semikhatsky.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._updateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._restoreConsoleMessages):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._createPresentationMessage):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.PresentationCallFrame.prototype.get url):
(WebInspector.PresentationCallFrame.prototype.sourceLine.sourceMappingUpdated):
(WebInspector.PresentationCallFrame.prototype.sourceLine):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype.get sourceMapping):

LayoutTests:

Reviewed by Yury Semikhatsky.

* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/raw-source-code.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/breakpoint-manager.html
trunk/LayoutTests/inspector/debugger/raw-source-code.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/BreakpointManager.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/SourceFile.js




Diff

Modified: trunk/LayoutTests/ChangeLog (96096 => 96097)

--- trunk/LayoutTests/ChangeLog	2011-09-27 11:20:34 UTC (rev 96096)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 12:06:28 UTC (rev 96097)
@@ -1,3 +1,13 @@
+2011-09-21  Pavel Podivilov  podivi...@chromium.org
+
+Web Inspector: migrate RawSourceCode clients to SourceMapping class.
+https://bugs.webkit.org/show_bug.cgi?id=68524
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/breakpoint-manager.html:
+* inspector/debugger/raw-source-code.html:
+
 2011-09-27  Vineet Chaudhary  vineet.chaudh...@motorola.com
 
 wrap attribute of textarea element cannot be accessed by _javascript_.


Modified: trunk/LayoutTests/inspector/debugger/breakpoint-manager.html (96096 => 96097)

--- trunk/LayoutTests/inspector/debugger/breakpoint-manager.html	2011-09-27 11:20:34 UTC (rev 96096)
+++ trunk/LayoutTests/inspector/debugger/breakpoint-manager.html	2011-09-27 12:06:28 UTC (rev 96097)
@@ -58,23 +58,22 @@
 serializedBreakpoints.push(createBreakpoint(a.js, 20, , false));
 serializedBreakpoints.push(createBreakpoint(b.js, 3, , true));
 
-var uiSourceCodeA = {
-id: a.js,
-url: a.js,
-rawSourceCode: {
-rawLocationToUILocation: function(rawLocation) { return rawLocation; },
-uiLocationToRawLocation: function(lineNumber, columnNumber) { return { scriptId: a.js, lineNumber: lineNumber, columnNumber: columnNumber }; }
-}
-};
-var uiSourceCodeB = {
-id: b.js,
-url: b.js,
-rawSourceCode: {
-rawLocationToUILocation: function(rawLocation) { return rawLocation; },
-uiLocationToRawLocation: function(lineNumber, columnNumber) { return { scriptId: b.js, lineNumber: lineNumber, columnNumber: columnNumber }; }
-}
+function createUISourceCode(id, url, rawLocationToUILocation, uiLocationToRawLocation)
+{
+return {
+id: id,
+url: url,
+rawSourceCode: { sourceMapping : { rawLocationToUILocation: rawLocationToUILocation, uiLocationToRawLocation: uiLocationToRawLocation } }
+};
 }
 
+var uiSourceCodeA = createUISourceCode(a.js, a.js,
+function(rawLocation) { return rawLocation; },
+function(lineNumber, columnNumber) { return { scriptId: a.js, lineNumber: lineNumber, columnNumber: columnNumber }; });
+var uiSourceCodeB = createUISourceCode(b.js, b.js,
+function(rawLocation) { return rawLocation; },
+

[webkit-changes] [96098] trunk/Source/WebCore

2011-09-27 Thread caseq

Title: [96098] trunk/Source/WebCore








Revision 96098
Author ca...@chromium.org
Date 2011-09-27 05:21:24 -0700 (Tue, 27 Sep 2011)


Log Message
Web Inspector: JS exception upon clicking on Word Wrap checkbox in Settings screen
https://bugs.webkit.org/show_bug.cgi?id=6

Reviewed by Pavel Feldman.

* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ElementsPanel.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (96097 => 96098)

--- trunk/Source/WebCore/ChangeLog	2011-09-27 12:06:28 UTC (rev 96097)
+++ trunk/Source/WebCore/ChangeLog	2011-09-27 12:21:24 UTC (rev 96098)
@@ -1,3 +1,13 @@
+2011-09-27  Andrey Kosyakov  ca...@chromium.org
+
+Web Inspector: JS exception upon clicking on Word Wrap checkbox in Settings screen
+https://bugs.webkit.org/show_bug.cgi?id=6
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/ElementsPanel.js:
+(WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged):
+
 2011-09-21  Pavel Podivilov  podivi...@chromium.org
 
 Web Inspector: migrate RawSourceCode clients to SourceMapping class.


Modified: trunk/Source/WebCore/inspector/front-end/ElementsPanel.js (96097 => 96098)

--- trunk/Source/WebCore/inspector/front-end/ElementsPanel.js	2011-09-27 12:06:28 UTC (rev 96097)
+++ trunk/Source/WebCore/inspector/front-end/ElementsPanel.js	2011-09-27 12:21:24 UTC (rev 96098)
@@ -288,7 +288,11 @@
 else
 this.contentElement.addStyleClass(nowrap);
 
-var treeElement = this.treeOutline.findTreeElement(this.selectedDOMNode());
+var selectedNode = this.selectedDOMNode();
+if (!selectedNode)
+return;
+
+var treeElement = this.treeOutline.findTreeElement(selectedNode);
 if (treeElement)
 treeElement.updateSelection(); // Recalculate selection highlight dimensions.
 },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96099] trunk/LayoutTests

2011-09-27 Thread hamaji

Title: [96099] trunk/LayoutTests








Revision 96099
Author ham...@chromium.org
Date 2011-09-27 05:34:42 -0700 (Tue, 27 Sep 2011)


Log Message
[Chromium] Layout Test fast/canvas/webgl/premultiplyalpha-test.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68885

Unreviewed typo fix.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96098 => 96099)

--- trunk/LayoutTests/ChangeLog	2011-09-27 12:21:24 UTC (rev 96098)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 12:34:42 UTC (rev 96099)
@@ -1,3 +1,12 @@
+2011-09-27  Shinichiro Hamaji  ham...@chromium.org
+
+[Chromium] Layout Test fast/canvas/webgl/premultiplyalpha-test.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=68885
+
+Unreviewed typo fix.
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-21  Pavel Podivilov  podivi...@chromium.org
 
 Web Inspector: migrate RawSourceCode clients to SourceMapping class.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96098 => 96099)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 12:21:24 UTC (rev 96098)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 12:34:42 UTC (rev 96099)
@@ -3785,6 +3785,6 @@
 
 BUGWK68882 LINUX GPU : compositing/video-page-visibility.html = IMAGE
 
-BUGWK68885 MAC CPU-CG : ast/canvas/webgl/premultiplyalpha-test.html = TEXT
+BUGWK68885 MAC CPU-CG : fast/canvas/webgl/premultiplyalpha-test.html = TEXT
 
 BUGWK68886 MAC GPU-CG : compositing/geometry/limit-layer-bounds-transformed-overflow.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96100] trunk/Source/WebKit/chromium

2011-09-27 Thread yurys

Title: [96100] trunk/Source/WebKit/chromium








Revision 96100
Author yu...@chromium.org
Date 2011-09-27 05:39:16 -0700 (Tue, 27 Sep 2011)


Log Message
[Chromium] Web Inspector: Bug with console.log and popstate/hashchange events
https://bugs.webkit.org/show_bug.cgi?id=67732

Added WebKit part of a new interactive UI test for the bug with duplicated console messages after navigation back.

Reviewed by Pavel Feldman.

* src/js/Tests.js:
(.TestSuite.prototype.testConsoleOnNavigateBack.firstConsoleMessageReceived):
(.TestSuite.prototype.testConsoleOnNavigateBack.didClickLink):
(.TestSuite.prototype.testConsoleOnNavigateBack.didNavigateBack):
(.TestSuite.prototype.testConsoleOnNavigateBack.didCompleteNavigation):
(.TestSuite.prototype.testConsoleOnNavigateBack):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/js/Tests.js




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (96099 => 96100)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-09-27 12:34:42 UTC (rev 96099)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-09-27 12:39:16 UTC (rev 96100)
@@ -1,3 +1,19 @@
+2011-09-27  Yury Semikhatsky  yu...@chromium.org
+
+[Chromium] Web Inspector: Bug with console.log and popstate/hashchange events
+https://bugs.webkit.org/show_bug.cgi?id=67732
+
+Added WebKit part of a new interactive UI test for the bug with duplicated console messages after navigation back.
+
+Reviewed by Pavel Feldman.
+
+* src/js/Tests.js:
+(.TestSuite.prototype.testConsoleOnNavigateBack.firstConsoleMessageReceived):
+(.TestSuite.prototype.testConsoleOnNavigateBack.didClickLink):
+(.TestSuite.prototype.testConsoleOnNavigateBack.didNavigateBack):
+(.TestSuite.prototype.testConsoleOnNavigateBack.didCompleteNavigation):
+(.TestSuite.prototype.testConsoleOnNavigateBack):
+
 2011-09-27  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed.  Rolled DEPS.


Modified: trunk/Source/WebKit/chromium/src/js/Tests.js (96099 => 96100)

--- trunk/Source/WebKit/chromium/src/js/Tests.js	2011-09-27 12:34:42 UTC (rev 96099)
+++ trunk/Source/WebKit/chromium/src/js/Tests.js	2011-09-27 12:39:16 UTC (rev 96100)
@@ -536,6 +536,40 @@
 };
 
 
+TestSuite.prototype.testConsoleOnNavigateBack = function()
+{
+if (WebInspector.console.messages.length === 1)
+firstConsoleMessageReceived.call(this);
+else
+WebInspector.console.addEventListener(WebInspector.ConsoleModel.Events.MessageAdded, firstConsoleMessageReceived, this);
+
+function firstConsoleMessageReceived() {
+this.evaluateInConsole_(clickLink();, didClickLink.bind(this));
+}
+
+function didClickLink() {
+// Check that there are no new messages(command is not a message).
+this.assertEquals(1, WebInspector.console.messages.length);
+this.assertEquals(1, WebInspector.console.messages[0].totalRepeatCount);
+this.evaluateInConsole_(history.back();, didNavigateBack.bind(this));
+}
+
+function didNavigateBack()
+{
+// Make sure navigation completed and possible console messages were pushed.
+this.evaluateInConsole_(void 0;, didCompleteNavigation.bind(this));
+}
+
+function didCompleteNavigation() {
+this.assertEquals(1, WebInspector.console.messages.length);
+this.assertEquals(1, WebInspector.console.messages[0].totalRepeatCount);
+this.releaseControl();
+}
+
+this.takeControl();
+};
+
+
 TestSuite.prototype.testSharedWorker = function()
 {
 function didEvaluateInConsole(resultText) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96101] trunk/Source/WebKit2

2011-09-27 Thread alexis . menard

Title: [96101] trunk/Source/WebKit2








Revision 96101
Author alexis.men...@openbossa.org
Date 2011-09-27 05:58:02 -0700 (Tue, 27 Sep 2011)


Log Message
[Qt][WK2] API fixes for QML, the signal parameters needs to be named.
https://bugs.webkit.org/show_bug.cgi?id=68889

Reviewed by Andreas Kling.

Signal parameters needs to be explicitly named in QML to be accessible.
This patch fix this problem.

* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qtouchwebpage.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h
trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (96100 => 96101)

--- trunk/Source/WebKit2/ChangeLog	2011-09-27 12:39:16 UTC (rev 96100)
+++ trunk/Source/WebKit2/ChangeLog	2011-09-27 12:58:02 UTC (rev 96101)
@@ -1,5 +1,18 @@
 2011-09-27  Alexis Menard  alexis.men...@openbossa.org
 
+[Qt][WK2] API fixes for QML, the signal parameters needs to be named.
+https://bugs.webkit.org/show_bug.cgi?id=68889
+
+Reviewed by Andreas Kling.
+
+Signal parameters needs to be explicitly named in QML to be accessible.
+This patch fix this problem.
+
+* UIProcess/API/qt/qdesktopwebview.h:
+* UIProcess/API/qt/qtouchwebpage.h:
+
+2011-09-27  Alexis Menard  alexis.men...@openbossa.org
+
 [Qt][WK2] Mark FINAL properties which can't be overridden by a subclass.
 https://bugs.webkit.org/show_bug.cgi?id=68848
 


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h (96100 => 96101)

--- trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h	2011-09-27 12:39:16 UTC (rev 96100)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h	2011-09-27 12:58:02 UTC (rev 96101)
@@ -81,13 +81,13 @@
  void load(const QUrl);
 
 Q_SIGNALS:
-void titleChanged(const QString);
-void statusBarMessageChanged(const QString);
+void titleChanged(const QString title);
+void statusBarMessageChanged(const QString message);
 void loadStarted();
 void loadSucceeded();
 void loadFailed(QDesktopWebView::ErrorType errorType, int errorCode, const QUrl url);
 void loadProgressChanged(int progress);
-void urlChanged(const QUrl);
+void urlChanged(const QUrl url);
 
 protected:
 virtual void keyPressEvent(QKeyEvent*);


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h (96100 => 96101)

--- trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h	2011-09-27 12:39:16 UTC (rev 96100)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h	2011-09-27 12:58:02 UTC (rev 96101)
@@ -65,8 +65,8 @@
 virtual bool event(QEvent*);
 
 Q_SIGNALS:
-void urlChanged(const QUrl);
-void titleChanged(const QString);
+void urlChanged(const QUrl url);
+void titleChanged(const QString title);
 void loadStarted();
 void loadSucceeded();
 void loadFailed(QTouchWebPage::ErrorType errorType, int errorCode, const QUrl url);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96102] trunk

2011-09-27 Thread commit-queue

Title: [96102] trunk








Revision 96102
Author commit-qu...@webkit.org
Date 2011-09-27 06:00:21 -0700 (Tue, 27 Sep 2011)


Log Message
Unreviewed, rolling out r96070 and r96075.
http://trac.webkit.org/changeset/96070
http://trac.webkit.org/changeset/96075
https://bugs.webkit.org/show_bug.cgi?id=68893

WK2 tests started crashing after r96070 for SL and Qt
(Requested by torarne on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2011-09-27

Source/WebCore:

* page/FrameView.cpp:
(WebCore::FrameView::updateScrollCorner):
* platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
(WebCore::ScrollView::updateScrollbars):
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::invalidateScrollCorner):
* platform/ScrollableArea.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::destroyRootLayer):
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::imageChanged):

LayoutTests:

* compositing/iframes/repaint-after-losing-scrollbars-expected.png:
* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/compositing/iframes/repaint-after-losing-scrollbars-expected.png
trunk/LayoutTests/platform/qt/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/platform/ScrollView.cpp
trunk/Source/WebCore/platform/ScrollableArea.cpp
trunk/Source/WebCore/platform/ScrollableArea.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderScrollbarPart.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (96101 => 96102)

--- trunk/LayoutTests/ChangeLog	2011-09-27 12:58:02 UTC (rev 96101)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 13:00:21 UTC (rev 96102)
@@ -1,3 +1,16 @@
+2011-09-27  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r96070 and r96075.
+http://trac.webkit.org/changeset/96070
+http://trac.webkit.org/changeset/96075
+https://bugs.webkit.org/show_bug.cgi?id=68893
+
+WK2 tests started crashing after r96070 for SL and Qt
+(Requested by torarne on #webkit).
+
+* compositing/iframes/repaint-after-losing-scrollbars-expected.png:
+* platform/qt/Skipped:
+
 2011-09-27  Shinichiro Hamaji  ham...@chromium.org
 
 [Chromium] Layout Test fast/canvas/webgl/premultiplyalpha-test.html is failing


Modified: trunk/LayoutTests/compositing/iframes/repaint-after-losing-scrollbars-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/qt/Skipped (96101 => 96102)

--- trunk/LayoutTests/platform/qt/Skipped	2011-09-27 12:58:02 UTC (rev 96101)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-09-27 13:00:21 UTC (rev 96102)
@@ -2377,9 +2377,3 @@
 # editing/selection/select-bidi-run.html fails on Qt
 # https://bugs.webkit.org/show_bug.cgi?id=68854
 editing/selection/select-bidi-run.html
-
-# Two tests fail after r96070
-# https://bugs.webkit.org/show_bug.cgi?id=68872
-fast/loader/stateobjects/pushstate-clears-forward-history.html
-fast/frames/frame-dead-region.html
-


Modified: trunk/Source/WebCore/ChangeLog (96101 => 96102)

--- trunk/Source/WebCore/ChangeLog	2011-09-27 12:58:02 UTC (rev 96101)
+++ trunk/Source/WebCore/ChangeLog	2011-09-27 13:00:21 UTC (rev 96102)
@@ -1,3 +1,27 @@
+2011-09-27  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r96070 and r96075.
+http://trac.webkit.org/changeset/96070
+http://trac.webkit.org/changeset/96075
+https://bugs.webkit.org/show_bug.cgi?id=68893
+
+WK2 tests started crashing after r96070 for SL and Qt
+(Requested by torarne on #webkit).
+
+* page/FrameView.cpp:
+(WebCore::FrameView::updateScrollCorner):
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::setHasHorizontalScrollbar):
+(WebCore::ScrollView::setHasVerticalScrollbar):
+(WebCore::ScrollView::updateScrollbars):
+* platform/ScrollableArea.cpp:
+(WebCore::ScrollableArea::invalidateScrollCorner):
+* platform/ScrollableArea.h:
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::destroyRootLayer):
+* rendering/RenderScrollbarPart.cpp:
+(WebCore::RenderScrollbarPart::imageChanged):
+
 2011-09-27  Andrey Kosyakov  ca...@chromium.org
 
 Web Inspector: JS exception upon clicking on Word Wrap checkbox in Settings screen


Modified: trunk/Source/WebCore/page/FrameView.cpp (96101 => 96102)

--- trunk/Source/WebCore/page/FrameView.cpp	2011-09-27 12:58:02 UTC (rev 96101)
+++ trunk/Source/WebCore/page/FrameView.cpp	2011-09-27 13:00:21 UTC (rev 96102)
@@ -2467,9 +2467,8 @@
 {
 RenderObject* renderer = 0;
 RefPtrRenderStyle cornerStyle;
-IntRect cornerRect = scrollCornerRect();
 
-if (!cornerRect.isEmpty()) {
+if (!scrollCornerRect().isEmpty()) {
 // Try the body element first as a scroll corner

[webkit-changes] [96103] trunk/LayoutTests

2011-09-27 Thread hamaji

Title: [96103] trunk/LayoutTests








Revision 96103
Author ham...@chromium.org
Date 2011-09-27 06:12:20 -0700 (Tue, 27 Sep 2011)


Log Message
[Chromium] Layout Test fast/canvas/canvas-composite-transformclip.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68895

Unreviewed test_expectations.txt update.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96102 => 96103)

--- trunk/LayoutTests/ChangeLog	2011-09-27 13:00:21 UTC (rev 96102)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 13:12:20 UTC (rev 96103)
@@ -1,3 +1,12 @@
+2011-09-27  Shinichiro Hamaji  ham...@chromium.org
+
+[Chromium] Layout Test fast/canvas/canvas-composite-transformclip.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=68895
+
+Unreviewed test_expectations.txt update.
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-27  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r96070 and r96075.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96102 => 96103)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 13:00:21 UTC (rev 96102)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 13:12:20 UTC (rev 96103)
@@ -3788,3 +3788,6 @@
 BUGWK68885 MAC CPU-CG : fast/canvas/webgl/premultiplyalpha-test.html = TEXT
 
 BUGWK68886 MAC GPU-CG : compositing/geometry/limit-layer-bounds-transformed-overflow.html = TEXT
+
+BUGWK68895 MAC WIN GPU : fast/canvas/canvas-composite-transformclip.html = IMAGE
+BUGWK68895 MAC WIN GPU : fast/canvas/canvas-composite.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96104] trunk/Source/WebKit/chromium

2011-09-27 Thread commit-queue

Title: [96104] trunk/Source/WebKit/chromium








Revision 96104
Author commit-qu...@webkit.org
Date 2011-09-27 06:23:49 -0700 (Tue, 27 Sep 2011)


Log Message
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot webkit.review@gmail.com on 2011-09-27

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (96103 => 96104)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-09-27 13:12:20 UTC (rev 96103)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-09-27 13:23:49 UTC (rev 96104)
@@ -1,3 +1,9 @@
+2011-09-27  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed.  Rolled DEPS.
+
+* DEPS:
+
 2011-09-27  Yury Semikhatsky  yu...@chromium.org
 
 [Chromium] Web Inspector: Bug with console.log and popstate/hashchange events


Modified: trunk/Source/WebKit/chromium/DEPS (96103 => 96104)

--- trunk/Source/WebKit/chromium/DEPS	2011-09-27 13:12:20 UTC (rev 96103)
+++ trunk/Source/WebKit/chromium/DEPS	2011-09-27 13:23:49 UTC (rev 96104)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '102890'
+  'chromium_rev': '102910'
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96105] trunk

2011-09-27 Thread caio . oliveira

Title: [96105] trunk








Revision 96105
Author caio.olive...@openbossa.org
Date 2011-09-27 07:09:00 -0700 (Tue, 27 Sep 2011)


Log Message
[Qt][WK2] Add support for hover API in Qt WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68369

Reviewed by Andreas Kling.

Source/WebKit2:

Based on the patch from Igor Oliveira in the same bug.

Expose a linkHovered() signal in QDesktopWebView, that passes the QUrl and the
QString corresponding to the link title. I left textContent out because was
unsure of its use case.

In QDesktopWebView we store the last URL and title emitted to make sure we send
the signal only if either value changes. Tests were added to the QML element to
check: if values are correctly emitted and if we don't emit more signals than
necessary.

* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::didMouseMoveOverElement):
* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qdesktopwebview_p.h:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml: Added.
* UIProcess/API/qt/tests/qmltests/common/test2.html:
* UIProcess/API/qt/tests/qmltests/qmltests.pro:
* UIProcess/qt/ClientImpl.cpp:
(qt_wk_mouseDidMoveOverElement):
* UIProcess/qt/ClientImpl.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::init):
* UIProcess/qt/TouchViewInterface.h:
(WebKit::TouchViewInterface::didMouseMoveOverElement):
* UIProcess/qt/ViewInterface.h:

Tools:

Change the statusbar to show the link URL when hovering links in
MiniBrowser using QDesktopWebView.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::onLinkHovered):
* MiniBrowser/qt/BrowserWindow.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h
trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/test2.html
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro
trunk/Source/WebKit2/UIProcess/qt/ClientImpl.cpp
trunk/Source/WebKit2/UIProcess/qt/ClientImpl.h
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/qt/TouchViewInterface.h
trunk/Source/WebKit2/UIProcess/qt/ViewInterface.h
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp
trunk/Tools/MiniBrowser/qt/BrowserWindow.h


Added Paths

trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml




Diff

Modified: trunk/Source/WebKit2/ChangeLog (96104 => 96105)

--- trunk/Source/WebKit2/ChangeLog	2011-09-27 13:23:49 UTC (rev 96104)
+++ trunk/Source/WebKit2/ChangeLog	2011-09-27 14:09:00 UTC (rev 96105)
@@ -1,3 +1,37 @@
+2011-09-26  Caio Marcelo de Oliveira Filho  caio.olive...@openbossa.org
+
+[Qt][WK2] Add support for hover API in Qt WebKit2
+https://bugs.webkit.org/show_bug.cgi?id=68369
+
+Reviewed by Andreas Kling.
+
+Based on the patch from Igor Oliveira in the same bug.
+
+Expose a linkHovered() signal in QDesktopWebView, that passes the QUrl and the
+QString corresponding to the link title. I left textContent out because was
+unsure of its use case.
+
+In QDesktopWebView we store the last URL and title emitted to make sure we send
+the signal only if either value changes. Tests were added to the QML element to
+check: if values are correctly emitted and if we don't emit more signals than
+necessary.
+
+* UIProcess/API/qt/qdesktopwebview.cpp:
+(QDesktopWebViewPrivate::didMouseMoveOverElement):
+* UIProcess/API/qt/qdesktopwebview.h:
+* UIProcess/API/qt/qdesktopwebview_p.h:
+* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml: Added.
+* UIProcess/API/qt/tests/qmltests/common/test2.html:
+* UIProcess/API/qt/tests/qmltests/qmltests.pro:
+* UIProcess/qt/ClientImpl.cpp:
+(qt_wk_mouseDidMoveOverElement):
+* UIProcess/qt/ClientImpl.h:
+* UIProcess/qt/QtWebPageProxy.cpp:
+(QtWebPageProxy::init):
+* UIProcess/qt/TouchViewInterface.h:
+(WebKit::TouchViewInterface::didMouseMoveOverElement):
+* UIProcess/qt/ViewInterface.h:
+
 2011-09-27  Alexis Menard  alexis.men...@openbossa.org
 
 [Qt][WK2] API fixes for QML, the signal parameters needs to be named.


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp (96104 => 96105)

--- trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp	2011-09-27 13:23:49 UTC (rev 96104)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp	2011-09-27 14:09:00 UTC (rev 96105)
@@ -431,6 +431,15 @@
 fileDialog = 0;
 }
 
+void QDesktopWebViewPrivate::didMouseMoveOverElement(const QUrl linkURL, const QString linkTitle)
+{
+if (linkURL == lastHoveredURL  linkTitle == lastHoveredTitle)
+return;
+lastHoveredURL = linkURL;
+lastHoveredTitle = linkTitle;
+emit

[webkit-changes] [96106] trunk

2011-09-27 Thread pfeldman

Title: [96106] trunk








Revision 96106
Author pfeld...@chromium.org
Date 2011-09-27 07:13:07 -0700 (Tue, 27 Sep 2011)


Log Message
Source/WebCore: Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved.
Send attribute name and value within the event.
https://bugs.webkit.org/show_bug.cgi?id=68613

Reviewed by Yury Semikhatsky.

* dom/Element.cpp:
(WebCore::Element::setAttribute):
(WebCore::Element::removeAttribute):
* inspector/Inspector.draft-01.json:
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didModifyDOMAttr):
(WebCore::InspectorDOMAgent::didRemoveDOMAttr):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMAttrImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didModifyDOMAttr):
(WebCore::InspectorInstrumentation::didRemoveDOMAttr):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype._addAttribute):
(WebInspector.DOMNode.prototype._setAttribute):
(WebInspector.DOMNode.prototype._removeAttribute):
(WebInspector.DOMAgent.prototype._attributeModified):
(WebInspector.DOMAgent.prototype._attributeRemoved):
(WebInspector.DOMAgent.prototype._inlineStyleInvalidated):
(WebInspector.DOMAgent.prototype._loadNodeAttributes):
(WebInspector.DOMDispatcher.prototype.attributeModified):
(WebInspector.DOMDispatcher.prototype.attributeRemoved):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._attributesUpdated):
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane):
(WebInspector.MetricsSidebarPane.prototype._attributesUpdated):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._attributesModified):
(WebInspector.StylesSidebarPane.prototype._attributesRemoved):
(WebInspector.StylesSidebarPane.prototype._styleInvalidated):
(WebInspector.StylePropertyTreeElement.prototype.event):
(WebInspector.StylePropertyTreeElement.prototype):
* inspector/validate-protocol-compatibility:

LayoutTests: Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved. Send attribute name and value within the event.
https://bugs.webkit.org/show_bug.cgi?id=68613

Reviewed by Yury Semikhatsky.

* inspector/elements/mutate-unknown-node.html-disabled:
* inspector/elements/set-attribute.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/elements/mutate-unknown-node.html-disabled
trunk/LayoutTests/inspector/elements/set-attribute.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/inspector/Inspector.draft-01.json
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp
trunk/Source/WebCore/inspector/InspectorDOMAgent.h
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/front-end/DOMAgent.js
trunk/Source/WebCore/inspector/front-end/ElementsPanel.js
trunk/Source/WebCore/inspector/front-end/MetricsSidebarPane.js
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js
trunk/Source/WebCore/inspector/validate-protocol-compatibility




Diff

Modified: trunk/LayoutTests/ChangeLog (96105 => 96106)

--- trunk/LayoutTests/ChangeLog	2011-09-27 14:09:00 UTC (rev 96105)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 14:13:07 UTC (rev 96106)
@@ -1,3 +1,13 @@
+2011-09-27  Pavel Feldman  pfeld...@google.com
+
+Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved. Send attribute name and value within the event.
+https://bugs.webkit.org/show_bug.cgi?id=68613
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/elements/mutate-unknown-node.html-disabled:
+* inspector/elements/set-attribute.html:
+
 2011-09-27  Shinichiro Hamaji  ham...@chromium.org
 
 [Chromium] Layout Test fast/canvas/canvas-composite-transformclip.html is failing


Modified: trunk/LayoutTests/inspector/elements/mutate-unknown-node.html-disabled (96105 => 96106)

--- trunk/LayoutTests/inspector/elements/mutate-unknown-node.html-disabled	2011-09-27 14:09:00 UTC (rev 96105)
+++ trunk/LayoutTests/inspector/elements/mutate-unknown-node.html-disabled	2011-09-27 14:13:07 UTC (rev 96106)
@@ -28,6 +28,7 @@
 {
 function listener(type, event)
 {
+node = event.data.node || event.data;
 InspectorTest.addResult(DOMAgent event fired. Should only happen once for output node:  + type +   + event.data.nodeName() + # + event.data.getAttribute(id));
 }
 


Modified: trunk/LayoutTests/inspector/elements/set-attribute.html (96105 => 96106)

--- trunk/LayoutTests/inspector/elements/set-attribute.html	2011-09-27 14:09:00 UTC (rev 96105)
+++

[webkit-changes] [96107] trunk/LayoutTests

2011-09-27 Thread commit-queue

Title: [96107] trunk/LayoutTests








Revision 96107
Author commit-qu...@webkit.org
Date 2011-09-27 07:49:25 -0700 (Tue, 27 Sep 2011)


Log Message
Clipped high quality blur in skia has been fixed. Rebaseline layout tests.
https://bugs.webkit.org/show_bug.cgi?id=68577

Patch by Ben Wagner bunge...@chromium.org on 2011-09-27
Reviewed by Kenneth Russell.

* platform/chromium-linux-x86/fast/box-shadow: Removed.
* platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
* platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png:
* platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
* platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png:
* platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
* platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
* platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png
trunk/LayoutTests/platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png
trunk/LayoutTests/platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (96106 => 96107)

--- trunk/LayoutTests/ChangeLog	2011-09-27 14:13:07 UTC (rev 96106)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 14:49:25 UTC (rev 96107)
@@ -1,3 +1,20 @@
+2011-09-27  Ben Wagner  bunge...@chromium.org
+
+Clipped high quality blur in skia has been fixed. Rebaseline layout tests.
+https://bugs.webkit.org/show_bug.cgi?id=68577
+
+Reviewed by Kenneth Russell.
+
+* platform/chromium-linux-x86/fast/box-shadow: Removed.
+* platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
+* platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png:
+* platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
+* platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png:
+* platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
+* platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
+* platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
+* platform/chromium/test_expectations.txt:
+
 2011-09-27  Pavel Feldman  pfeld...@google.com
 
 Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved. Send attribute name and value within the event.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96106 => 96107)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 14:13:07 UTC (rev 96106)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 14:49:25 UTC (rev 96107)
@@ -104,11 +104,6 @@
 // fails for other platforms...
 BUGCR20404 : editing/execCommand/copy-without-selection.html = TEXT
 
-// Skia clipped blur change in progress.
-BUGWK67724 : fast/box-shadow/shadow-buffer-partial.html = PASS FAIL
-BUGWK67849 : fast/box-shadow/inset-box-shadow-radius.html = PASS FAIL
-BUGWK67849 : fast/box-shadow/inset-box-shadows.html = PASS FAIL
-
 // -
 // WONTFIX TESTS
 // -


Modified: trunk/LayoutTests/platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96109] trunk/LayoutTests

2011-09-27 Thread wjmaclean

Title: [96109] trunk/LayoutTests








Revision 96109
Author wjmacl...@chromium.org
Date 2011-09-27 08:17:53 -0700 (Tue, 27 Sep 2011)


Log Message
Layout Test platform/chromium/compositing/zoom-animator-scale-test.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=68852

Rebaseline GPU tests for Mac, Win.

Reviewed by Shinichiro Hamaji.

* platform/chromium-gpu-cg-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
* platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/chromium-gpu-cg-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png
trunk/LayoutTests/platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png
trunk/LayoutTests/platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (96108 => 96109)

--- trunk/LayoutTests/ChangeLog	2011-09-27 15:11:11 UTC (rev 96108)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 15:17:53 UTC (rev 96109)
@@ -1,3 +1,17 @@
+2011-09-27  W. James MacLean  wjmacl...@chromium.org
+
+Layout Test platform/chromium/compositing/zoom-animator-scale-test.html is failing.
+https://bugs.webkit.org/show_bug.cgi?id=68852
+
+Rebaseline GPU tests for Mac, Win.
+
+Reviewed by Shinichiro Hamaji.
+
+* platform/chromium-gpu-cg-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
+* platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
+* platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
+* platform/chromium/test_expectations.txt:
+
 2011-09-27  Ben Wagner  bunge...@chromium.org
 
 Clipped high quality blur in skia has been fixed. Rebaseline layout tests.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96108 => 96109)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 15:11:11 UTC (rev 96108)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 15:17:53 UTC (rev 96109)
@@ -2665,8 +2665,6 @@
 BUGWK58587 LINUX GPU DEBUG : media/video-controls-rendering.html = IMAGE
 BUGCR97686 LINUX GPU RELEASE : media/video-controls-rendering.html = IMAGE
 
-BUGWK68852 MAC WIN GPU GPU-CG : platform/chromium/compositing/zoom-animator-scale-test.html = IMAGE
-
 BUGCR72223 : media/video-frame-accurate-seek.html = PASS IMAGE
 
 BUGWK53868 : fast/notifications/notifications-document-close-crash.html = PASS TEXT


Modified: trunk/LayoutTests/platform/chromium-gpu-cg-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96110] trunk

2011-09-27 Thread loislo

Title: [96110] trunk








Revision 96110
Author loi...@chromium.org
Date 2011-09-27 08:26:34 -0700 (Tue, 27 Sep 2011)


Log Message
Web Inspector: UI performance: introduce heap size tracking stats.
https://bugs.webkit.org/show_bug.cgi?id=68901

It is interesting how much the heap memory is used by Inspector in order of running the test.

Reviewed by Yury Semikhatsky.

Tools:

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::showDevTools):
(TestShell::closeDevTools):

LayoutTests:

* inspector/performance/resources/network-append-30-requests.html:
* inspector/performance/resources/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._getJSHeapSize):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/performance/resources/network-append-30-requests.html
trunk/LayoutTests/inspector/performance/resources/performance-test.js
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (96109 => 96110)

--- trunk/LayoutTests/ChangeLog	2011-09-27 15:17:53 UTC (rev 96109)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 15:26:34 UTC (rev 96110)
@@ -1,3 +1,19 @@
+2011-09-27  Ilya Tikhonovsky  loi...@chromium.org
+
+Web Inspector: UI performance: introduce heap size tracking stats.
+https://bugs.webkit.org/show_bug.cgi?id=68901
+
+It is interesting how much the heap memory is used by Inspector in order of running the test.
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/performance/resources/network-append-30-requests.html:
+* inspector/performance/resources/performance-test.js:
+(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer):
+(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._getJSHeapSize):
+(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
+(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
+
 2011-09-27  W. James MacLean  wjmacl...@chromium.org
 
 Layout Test platform/chromium/compositing/zoom-animator-scale-test.html is failing.


Modified: trunk/LayoutTests/inspector/performance/resources/network-append-30-requests.html (96109 => 96110)

--- trunk/LayoutTests/inspector/performance/resources/network-append-30-requests.html	2011-09-27 15:17:53 UTC (rev 96109)
+++ trunk/LayoutTests/inspector/performance/resources/network-append-30-requests.html	2011-09-27 15:26:34 UTC (rev 96110)
@@ -8,7 +8,7 @@
 {
 for (var i = 0; i  count; ++i) {
 var xhr = new XMLHttpRequest();
-xhr.open(GET, document.url, true);
+xhr.open(GET, document.URL, true);
 xhr.send();
 }
 }


Modified: trunk/LayoutTests/inspector/performance/resources/performance-test.js (96109 => 96110)

--- trunk/LayoutTests/inspector/performance/resources/performance-test.js	2011-09-27 15:17:53 UTC (rev 96109)
+++ trunk/LayoutTests/inspector/performance/resources/performance-test.js	2011-09-27 15:26:34 UTC (rev 96110)
@@ -8,6 +8,8 @@
 this._test = test;
 this._times = {};
 this._testStartTime = new Date();
+this._heapSizeDeltas = [];
+this._jsHeapSize = this._getJSHeapSize();
 }
 
 Timer.prototype = {
@@ -24,8 +26,18 @@
 this._times[cookie.name].push(endTime - cookie.startTime);
 },
 
+_getJSHeapSize: function()
+{
+window.gc();
+window.gc();
+return console.memory.usedJSHeapSize;
+},
+
 done: function()
 {
+this._heapSizeDeltas.push(console.memory.usedJSHeapSize - this._jsHeapSize);
+this._jsHeapSize = this._getJSHeapSize();
+
 var time = new Date();
 if (time - this._testStartTime  executeTime)
 this._runTest();
@@ -53,16 +65,25 @@
 
 _dump: function()
 {
-for (var testName in this._times) {
-var samples = this._times[testName];
-var stripNResults = Math.floor(samples.length / 10);
-samples.sort(function(a, b) { return a - b; });
-var sum = 0;
-for (var i = stripNResults; i  samples.length - stripNResults; ++i)
-sum += samples[i];
-InspectorTest.addResult(*  + testName + :  + Math.floor(sum / (samples.length - stripNResults * 2)));
-InspectorTest.addResult(testName +  min/max/count:  + samples[0] + / + samples[samples.length-1] + / + samples.length);
-}
+for (var testName in this._times)
+this._dumpTestStats(testName, this._times[testName]);
+
+var url = ""
+var regExp

[webkit-changes] [96111] trunk/Source/WebKit2

2011-09-27 Thread vestbo

Title: [96111] trunk/Source/WebKit2








Revision 96111
Author ves...@webkit.org
Date 2011-09-27 08:29:22 -0700 (Tue, 27 Sep 2011)


Log Message
[Qt] Fix build of WebKit2 unit-tests after r96108

Reviewed by Andreas Kling.

* UIProcess/API/qt/tests/tests.pri:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/tests/tests.pri




Diff

Modified: trunk/Source/WebKit2/ChangeLog (96110 => 96111)

--- trunk/Source/WebKit2/ChangeLog	2011-09-27 15:26:34 UTC (rev 96110)
+++ trunk/Source/WebKit2/ChangeLog	2011-09-27 15:29:22 UTC (rev 96111)
@@ -1,3 +1,11 @@
+2011-09-27  Tor Arne Vestbø  tor.arne.ves...@nokia.com
+
+[Qt] Fix build of WebKit2 unit-tests after r96108
+
+Reviewed by Andreas Kling.
+
+* UIProcess/API/qt/tests/tests.pri:
+
 2011-09-23  Tor Arne Vestbø  tor.arne.ves...@nokia.com
 
 [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi


Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/tests.pri (96110 => 96111)

--- trunk/Source/WebKit2/UIProcess/API/qt/tests/tests.pri	2011-09-27 15:26:34 UTC (rev 96110)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/tests.pri	2011-09-27 15:29:22 UTC (rev 96111)
@@ -11,7 +11,7 @@
 INCLUDEPATH += $$PWD
 
 include(../../../../../WebKit.pri)
-QT += testlib declarative
+QT += testlib declarative widgets
 
 QMAKE_RPATHDIR = $$OUTPUT_DIR/lib $$QMAKE_RPATHDIR
 DEFINES += TESTS_SOURCE_DIR=\\\$$PWD\\\ \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96112] trunk/Tools

2011-09-27 Thread levin

Title: [96112] trunk/Tools








Revision 96112
Author le...@chromium.org
Date 2011-09-27 08:35:49 -0700 (Tue, 27 Sep 2011)


Log Message
watchlist: Break out the diff boilerplate to allow for re-use.
https://bugs.webkit.org/show_bug.cgi?id=68871

Reviewed by Eric Seidel.

* Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
Break out the diff into a new file.
* Scripts/webkitpy/common/checkout/diff_test_data.py: Added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py


Added Paths

trunk/Tools/Scripts/webkitpy/common/checkout/diff_test_data.py




Diff

Modified: trunk/Tools/ChangeLog (96111 => 96112)

--- trunk/Tools/ChangeLog	2011-09-27 15:29:22 UTC (rev 96111)
+++ trunk/Tools/ChangeLog	2011-09-27 15:35:49 UTC (rev 96112)
@@ -1,3 +1,14 @@
+2011-09-27  David Levin  le...@chromium.org
+
+watchlist: Break out the diff boilerplate to allow for re-use.
+https://bugs.webkit.org/show_bug.cgi?id=68871
+
+Reviewed by Eric Seidel.
+
+* Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
+Break out the diff into a new file.
+* Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
+
 2011-09-27  Ilya Tikhonovsky  loi...@chromium.org
 
 Web Inspector: UI performance: introduce heap size tracking stats.


Modified: trunk/Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py (96111 => 96112)

--- trunk/Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py	2011-09-27 15:29:22 UTC (rev 96111)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py	2011-09-27 15:35:49 UTC (rev 96112)
@@ -30,64 +30,12 @@
 import diff_parser
 import re
 
+from webkitpy.common.checkout.diff_test_data import DIFF_TEST_DATA
 
 class DiffParserTest(unittest.TestCase):
-
-_PATCH = '''diff --git a/WebCore/rendering/style/StyleFlexibleBoxData.h b/WebCore/rendering/style/StyleFlexibleBoxData.h
-index f5d5e74..3b6aa92 100644
 a/WebCore/rendering/style/StyleFlexibleBoxData.h
-+++ b/WebCore/rendering/style/StyleFlexibleBoxData.h
-@@ -47,7 +47,6 @@ public:
- 
- unsigned align : 3; // EBoxAlignment
- unsigned pack: 3; // EBoxAlignment
--unsigned orient: 1; // EBoxOrient
- unsigned lines : 1; // EBoxLines
- 
- private:
-diff --git a/WebCore/rendering/style/StyleRareInheritedData.cpp b/WebCore/rendering/style/StyleRareInheritedData.cpp
-index ce21720..324929e 100644
 a/WebCore/rendering/style/StyleRareInheritedData.cpp
-+++ b/WebCore/rendering/style/StyleRareInheritedData.cpp
-@@ -39,6 +39,7 @@ StyleRareInheritedData::StyleRareInheritedData()
- , textSizeAdjust(RenderStyle::initialTextSizeAdjust())
- , resize(RenderStyle::initialResize())
- , userSelect(RenderStyle::initialUserSelect())
-+, boxOrient(RenderStyle::initialBoxOrient())
- {
- }
- 
-@@ -58,6 +59,7 @@ StyleRareInheritedData::StyleRareInheritedData(const StyleRareInheritedData o)
- , textSizeAdjust(o.textSizeAdjust)
- , resize(o.resize)
- , userSelect(o.userSelect)
-+, boxOrient(o.boxOrient)
- {
- }
- 
-@@ -81,7 +83,8 @@ bool StyleRareInheritedData::operator==(const StyleRareInheritedData o) const
-  khtmlLineBreak == o.khtmlLineBreak
-  textSizeAdjust == o.textSizeAdjust
-  resize == o.resize
-- userSelect == o.userSelect;
-+ userSelect == o.userSelect
-+ boxOrient == o.boxOrient;
- }
- 
- bool StyleRareInheritedData::shadowDataEquivalent(const StyleRareInheritedData o) const
-diff --git a/LayoutTests/platform/mac/fast/flexbox/box-orient-button-expected.checksum b/LayoutTests/platform/mac/fast/flexbox/box-orient-button-expected.checksum
-new file mode 100644
-index 000..6db26bd
 /dev/null
-+++ b/LayoutTests/platform/mac/fast/flexbox/box-orient-button-expected.checksum
-@@ -0,0 +1 @@
-+61a373ee739673a9dcd7bac62b9f182e
-\ No newline at end of file
-'''
-
 def test_diff_parser(self, parser = None):
 if not parser:
-parser = diff_parser.DiffParser(self._PATCH.splitlines())
+parser = diff_parser.DiffParser(DIFF_TEST_DATA.splitlines())
 self.assertEquals(3, len(parser.files))
 
 self.assertTrue('WebCore/rendering/style/StyleFlexibleBoxData.h' in parser.files)
@@ -139,7 +87,7 @@
 ]
 
 for prefix in prefixes:
-patch = p.sub(lambda x:  %s/ % prefix[x.group(1)], self._PATCH)
+patch = p.sub(lambda x:  %s/ % prefix[x.group(1)], DIFF_TEST_DATA)
 self.test_diff_parser(diff_parser.DiffParser(patch.splitlines()))
 
 if __name__ == '__main__':


Added: trunk/Tools/Scripts/webkitpy/common/checkout/diff_test_data.py (0 => 96112)

--- trunk/Tools/Scripts/webkitpy/common/checkout/diff_test_data.py	(rev 0)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/diff_test_data.py	2011-09-27 15:35:49 UTC (rev 96112)
@@ -0,0 +1,80 @@
+# Copyright (C) 2011 Google Inc. All rights reserved.
+#
+# Redistribution and use

[webkit-changes] [96114] trunk/LayoutTests

2011-09-27 Thread loislo

Title: [96114] trunk/LayoutTests








Revision 96114
Author loi...@chromium.org
Date 2011-09-27 08:50:42 -0700 (Tue, 27 Sep 2011)


Log Message
Unreviewed followupfix for r96110.
This is a small adjustment of the heap size delta calculation.

* inspector/performance/resources/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/performance/resources/performance-test.js




Diff

Modified: trunk/LayoutTests/ChangeLog (96113 => 96114)

--- trunk/LayoutTests/ChangeLog	2011-09-27 15:36:39 UTC (rev 96113)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 15:50:42 UTC (rev 96114)
@@ -1,5 +1,13 @@
 2011-09-27  Ilya Tikhonovsky  loi...@chromium.org
 
+Unreviewed followupfix for r96110.
+This is a small adjustment of the heap size delta calculation.
+
+* inspector/performance/resources/performance-test.js:
+(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
+
+2011-09-27  Ilya Tikhonovsky  loi...@chromium.org
+
 Web Inspector: UI performance: introduce heap size tracking stats.
 https://bugs.webkit.org/show_bug.cgi?id=68901
 


Modified: trunk/LayoutTests/inspector/performance/resources/performance-test.js (96113 => 96114)

--- trunk/LayoutTests/inspector/performance/resources/performance-test.js	2011-09-27 15:36:39 UTC (rev 96113)
+++ trunk/LayoutTests/inspector/performance/resources/performance-test.js	2011-09-27 15:50:42 UTC (rev 96114)
@@ -35,8 +35,9 @@
 
 done: function()
 {
-this._heapSizeDeltas.push(console.memory.usedJSHeapSize - this._jsHeapSize);
-this._jsHeapSize = this._getJSHeapSize();
+var newJSHeapSize = this._getJSHeapSize();
+this._heapSizeDeltas.push(newJSHeapSize - this._jsHeapSize);
+this._jsHeapSize = newJSHeapSize;
 
 var time = new Date();
 if (time - this._testStartTime  executeTime)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96115] trunk/Tools

2011-09-27 Thread levin

Title: [96115] trunk/Tools








Revision 96115
Author le...@chromium.org
Date 2011-09-27 08:52:14 -0700 (Tue, 27 Sep 2011)


Log Message
watchlist: Change watchlistparser.py to be class based.
https://bugs.webkit.org/show_bug.cgi?id=68869

Reviewed by Eric Seidel.

* Scripts/webkitpy/common/watchlist/watchlistparser.py:
* Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py
trunk/Tools/Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (96114 => 96115)

--- trunk/Tools/ChangeLog	2011-09-27 15:50:42 UTC (rev 96114)
+++ trunk/Tools/ChangeLog	2011-09-27 15:52:14 UTC (rev 96115)
@@ -1,5 +1,15 @@
 2011-09-27  David Levin  le...@chromium.org
 
+watchlist: Change watchlistparser.py to be class based.
+https://bugs.webkit.org/show_bug.cgi?id=68869
+
+Reviewed by Eric Seidel.
+
+* Scripts/webkitpy/common/watchlist/watchlistparser.py:
+* Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
+
+2011-09-27  David Levin  le...@chromium.org
+
 watchlist: Break out the diff boilerplate to allow for re-use.
 https://bugs.webkit.org/show_bug.cgi?id=68871
 


Modified: trunk/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py (96114 => 96115)

--- trunk/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py	2011-09-27 15:50:42 UTC (rev 96114)
+++ trunk/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py	2011-09-27 15:52:14 UTC (rev 96115)
@@ -29,48 +29,47 @@
 import re
 from webkitpy.common.watchlist.watchlist import WatchList
 
-_DEFINITIONS = 'DEFINITIONS'
-_INVALID_DEFINITION_NAME_REGEX = r'\|'
 
+class WatchListParser(object):
+_DEFINITIONS = 'DEFINITIONS'
+_INVALID_DEFINITION_NAME_REGEX = r'\|'
 
-def _eval_watch_list(watch_list_contents):
-return eval(watch_list_contents, {'__builtins__': None}, None)
+def __init__(self):
+self._section_parsers = {self._DEFINITIONS: self._parse_definition_section, }
+self._definition_pattern_parsers = {}
 
-_DEFINITION_MATCH_PARSER = {}
+def parse(self, watch_list_contents):
+watch_list = WatchList()
 
+# Change the watch list text into a dictionary.
+dictionary = self._eval_watch_list(watch_list_contents)
 
-def _parse_definition_section(definition_section, watch_list):
-definitions = {}
-for name in definition_section:
-invalid_character = re.search(_INVALID_DEFINITION_NAME_REGEX, name)
-if invalid_character:
-raise Exception('Invalid character %s in definition %s.' % (invalid_character.group(0), name))
+# Parse the top level sections in the watch list.
+for section in dictionary:
+parser = self._section_parsers.get(section)
+if not parser:
+raise Exception('Unknown section %s in watch list.' % section)
+parser(dictionary[section], watch_list)
 
-definition = definition_section[name]
-definitions[name] = []
-for pattern_type in definition:
-pattern_parser = _DEFINITION_MATCH_PARSER.get(pattern_type)
-if not pattern_parser:
-raise Exception('Invalid pattern type %s in definition %s.' % (pattern_type, name))
+return watch_list
 
-pattern = pattern_parser(definition[pattern_type])
-definitions[name].append(pattern)
-watch_list.set_definitions(definitions)
+def _eval_watch_list(self, watch_list_contents):
+return eval(watch_list_contents, {'__builtins__': None}, None)
 
-_SECTION_PARSERS = {_DEFINITIONS: _parse_definition_section, }
+def _parse_definition_section(self, definition_section, watch_list):
+definitions = {}
+for name in definition_section:
+invalid_character = re.search(self._INVALID_DEFINITION_NAME_REGEX, name)
+if invalid_character:
+raise Exception('Invalid character %s in definition %s.' % (invalid_character.group(0), name))
 
+definition = definition_section[name]
+definitions[name] = []
+for pattern_type in definition:
+pattern_parser = self._definition_pattern_parsers.get(pattern_type)
+if not pattern_parser:
+raise Exception('Invalid pattern type %s in definition %s.' % (pattern_type, name))
 
-def parse_watch_list(watch_list_contents):
-watch_list = WatchList()
-
-# Change the watch list text into a dictionary.
-dictionary = _eval_watch_list(watch_list_contents)
-
-# Parse the top level sections in the watch list.
-for section in dictionary:
-parser = _SECTION_PARSERS.get(section)
-if not parser:
-raise Exception('Unknown section %s in watch list.' % section)
-parser(dictionary[section], watch_list)
-
-return watch_list
+

[webkit-changes] [96116] trunk

2011-09-27 Thread ossy

Title: [96116] trunk








Revision 96116
Author o...@webkit.org
Date 2011-09-27 09:12:20 -0700 (Tue, 27 Sep 2011)


Log Message
[Qt][WK2] Buildfix after r96108.

Rubber-stamped by Andreas Kling.

Source/WebKit/qt:

* tests/tests.pri:

Tools:

* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
* WebKitTestRunner/qt/WebKitTestRunner.pro:

Modified Paths

trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/tests/tests.pri
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro
trunk/Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp
trunk/Tools/WebKitTestRunner/qt/WebKitTestRunner.pro




Diff

Modified: trunk/Source/WebKit/qt/ChangeLog (96115 => 96116)

--- trunk/Source/WebKit/qt/ChangeLog	2011-09-27 15:52:14 UTC (rev 96115)
+++ trunk/Source/WebKit/qt/ChangeLog	2011-09-27 16:12:20 UTC (rev 96116)
@@ -1,3 +1,11 @@
+2011-09-27  Csaba Osztrogonác  o...@webkit.org
+
+[Qt][WK2] Buildfix after r96108.
+
+Rubber-stamped by Andreas Kling.
+
+* tests/tests.pri:
+
 2011-09-27  Tor Arne Vestbø  tor.arne.ves...@nokia.com
 
 [Qt] Fix build of declarative plugin against Qt5


Modified: trunk/Source/WebKit/qt/tests/tests.pri (96115 => 96116)

--- trunk/Source/WebKit/qt/tests/tests.pri	2011-09-27 15:52:14 UTC (rev 96115)
+++ trunk/Source/WebKit/qt/tests/tests.pri	2011-09-27 16:12:20 UTC (rev 96116)
@@ -21,6 +21,7 @@
 
 include(../../../WebKit.pri)
 QT += testlib network
+greaterThan(QT_MAJOR_VERSION, 4): QT += widgets
 
 lessThan(QT_MAJOR_VERSION, 5) {
 contains(QT_CONFIG, declarative): QT += declarative


Modified: trunk/Tools/ChangeLog (96115 => 96116)

--- trunk/Tools/ChangeLog	2011-09-27 15:52:14 UTC (rev 96115)
+++ trunk/Tools/ChangeLog	2011-09-27 16:12:20 UTC (rev 96116)
@@ -1,3 +1,13 @@
+2011-09-27  Csaba Osztrogonác  o...@webkit.org
+
+[Qt][WK2] Buildfix after r96108.
+
+Rubber-stamped by Andreas Kling.
+
+* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
+* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
+* WebKitTestRunner/qt/WebKitTestRunner.pro:
+
 2011-09-27  David Levin  le...@chromium.org
 
 watchlist: Change watchlistparser.py to be class based.


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro (96115 => 96116)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro	2011-09-27 15:52:14 UTC (rev 96115)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro	2011-09-27 16:12:20 UTC (rev 96116)
@@ -9,6 +9,7 @@
 }
 
 QT += declarative
+greaterThan(QT_MAJOR_VERSION, 4): QT += widgets
 
 GENERATED_SOURCES_DIR = ../../generated
 


Modified: trunk/Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp (96115 => 96116)

--- trunk/Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp	2011-09-27 15:52:14 UTC (rev 96115)
+++ trunk/Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp	2011-09-27 16:12:20 UTC (rev 96116)
@@ -28,6 +28,7 @@
 
 #include PlatformWebView.h
 #include TestController.h
+#include QGraphicsSceneMouseEvent
 #include QKeyEvent
 #include QtTest/QtTest
 #include WebKit2/WKPagePrivate.h


Modified: trunk/Tools/WebKitTestRunner/qt/WebKitTestRunner.pro (96115 => 96116)

--- trunk/Tools/WebKitTestRunner/qt/WebKitTestRunner.pro	2011-09-27 15:52:14 UTC (rev 96115)
+++ trunk/Tools/WebKitTestRunner/qt/WebKitTestRunner.pro	2011-09-27 16:12:20 UTC (rev 96116)
@@ -32,6 +32,7 @@
 }
 
 QT = core gui network declarative testlib
+greaterThan(QT_MAJOR_VERSION, 4): QT += widgets
 
 HEADERS = \
 $$BASEDIR/EventSenderProxy.h \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96117] branches/chromium/874

2011-09-27 Thread inferno

Title: [96117] branches/chromium/874








Revision 96117
Author infe...@chromium.org
Date 2011-09-27 09:21:37 -0700 (Tue, 27 Sep 2011)


Log Message
Merge 95926 - rdar://problem/10156263 ASSERT in WebCore::FrameView::scheduleRelayoutOfSubtree
BUG=97952
Review URL: http://codereview.chromium.org/8052011

Modified Paths

branches/chromium/874/Source/WebCore/rendering/RenderObject.cpp


Added Paths

branches/chromium/874/LayoutTests/fast/dynamic/subtree-unrooted-expected.txt
branches/chromium/874/LayoutTests/fast/dynamic/subtree-unrooted.html




Diff

Copied: branches/chromium/874/LayoutTests/fast/dynamic/subtree-unrooted-expected.txt (from rev 95926, trunk/LayoutTests/fast/dynamic/subtree-unrooted-expected.txt) (0 => 96117)

--- branches/chromium/874/LayoutTests/fast/dynamic/subtree-unrooted-expected.txt	(rev 0)
+++ branches/chromium/874/LayoutTests/fast/dynamic/subtree-unrooted-expected.txt	2011-09-27 16:21:37 UTC (rev 96117)
@@ -0,0 +1,5 @@
+Test for rdar://problem/10156263 ASSERT in WebCore::FrameView::scheduleRelayoutOfSubtree at developer.gnome.org.
+
+The test passes if, in a debug build, it does not cause an assertion failure.
+
+


Copied: branches/chromium/874/LayoutTests/fast/dynamic/subtree-unrooted.html (from rev 95926, trunk/LayoutTests/fast/dynamic/subtree-unrooted.html) (0 => 96117)

--- branches/chromium/874/LayoutTests/fast/dynamic/subtree-unrooted.html	(rev 0)
+++ branches/chromium/874/LayoutTests/fast/dynamic/subtree-unrooted.html	2011-09-27 16:21:37 UTC (rev 96117)
@@ -0,0 +1,24 @@
+style
+#target:before {
+content: ' ';
+display: block;
+overflow: hidden;
+width: 0;
+height: 0;
+}
+/style
+body
+p
+Test for ia href=""
+ASSERT in WebCore::FrameView::scheduleRelayoutOfSubtree at developer.gnome.org/i.
+/p
+p
+The test passes if, in a debug build, it does not cause an assertion failure.
+/p
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+document.body.offsetTop;
+/script
+div id=target/div
+/body


Modified: branches/chromium/874/Source/WebCore/rendering/RenderObject.cpp (96116 => 96117)

--- branches/chromium/874/Source/WebCore/rendering/RenderObject.cpp	2011-09-27 16:12:20 UTC (rev 96116)
+++ branches/chromium/874/Source/WebCore/rendering/RenderObject.cpp	2011-09-27 16:21:37 UTC (rev 96117)
@@ -2249,10 +2249,12 @@
 FrameView* view = toRenderView(this)-frameView();
 if (view)
 view-scheduleRelayout();
-} else if (parent()) {
-FrameView* v = view() ? view()-frameView() : 0;
-if (v)
-v-scheduleRelayoutOfSubtree(this);
+} else {
+RenderView* renderView;
+if (isRooted(renderView)) {
+if (FrameView* frameView = renderView-frameView())
+frameView-scheduleRelayoutOfSubtree(this);
+}
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96119] branches/chromium/874/Source/WebCore/webaudio/ OfflineAudioDestinationNode.cpp

2011-09-27 Thread inferno

Title: [96119] branches/chromium/874/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp








Revision 96119
Author infe...@chromium.org
Date 2011-09-27 09:28:18 -0700 (Tue, 27 Sep 2011)


Log Message
Merge 96020 - OfflineAudioDestinationNode must wait for thread completion in uninitialize()
BUG=96149
Review URL: http://codereview.chromium.org/8055019

Modified Paths

branches/chromium/874/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp




Diff

Modified: branches/chromium/874/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp (96118 => 96119)

--- branches/chromium/874/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp	2011-09-27 16:28:17 UTC (rev 96118)
+++ branches/chromium/874/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp	2011-09-27 16:28:18 UTC (rev 96119)
@@ -69,6 +69,11 @@
 if (!isInitialized())
 return;
 
+if (m_renderThread) {
+waitForThreadCompletion(m_renderThread, 0);
+m_renderThread = 0;
+}
+
 AudioNode::uninitialize();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96118] trunk/Source/WebCore

2011-09-27 Thread noam . rosenthal

Title: [96118] trunk/Source/WebCore








Revision 96118
Author noam.rosent...@nokia.com
Date 2011-09-27 09:28:17 -0700 (Tue, 27 Sep 2011)


Log Message
[Texmap][Qt] Refactor texture-upload to allow direct chunk update
https://bugs.webkit.org/show_bug.cgi?id=68808

Add a function to BitmapTexture for direct pixel updates.
Modify BitmapTextureGL::endPaint to use that function. Since the BGRA
to RGBA swizzling is done inside that function, there's no need for the
RGBA32PremultipliedBuffer class to contain such function. Also,
RGBA32PremultipliedBuffer was renamed to BGRA32PremultipliedBuffer, correcting
an old mistake.

Reviewed by Andreas Kling.

No new tests. Existing tests in LayoutTests/compositing test this.

* platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::beginPaint):
(WebCore::BitmapTextureGL::endPaint):
(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::updateContents):
* platform/graphics/opengl/TextureMapperGL.h:
(WebCore::BGRA32PremultimpliedBuffer::~BGRA32PremultimpliedBuffer):
* platform/graphics/qt/TextureMapperQt.cpp:
(WebCore::BitmapTextureQt::updateContents):
(WebCore::BGRA32PremultimpliedBufferQt::data):
(WebCore::BGRA32PremultimpliedBuffer::create):
* platform/graphics/qt/TextureMapperQt.h:
* platform/graphics/texmap/TextureMapper.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp
trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.h
trunk/Source/WebCore/platform/graphics/qt/TextureMapperQt.cpp
trunk/Source/WebCore/platform/graphics/qt/TextureMapperQt.h
trunk/Source/WebCore/platform/graphics/texmap/TextureMapper.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (96117 => 96118)

--- trunk/Source/WebCore/ChangeLog	2011-09-27 16:21:37 UTC (rev 96117)
+++ trunk/Source/WebCore/ChangeLog	2011-09-27 16:28:17 UTC (rev 96118)
@@ -1,3 +1,33 @@
+2011-09-27  No'am Rosenthal  noam.rosent...@nokia.com
+
+[Texmap][Qt] Refactor texture-upload to allow direct chunk update
+https://bugs.webkit.org/show_bug.cgi?id=68808
+
+Add a function to BitmapTexture for direct pixel updates.
+Modify BitmapTextureGL::endPaint to use that function. Since the BGRA
+to RGBA swizzling is done inside that function, there's no need for the 
+RGBA32PremultipliedBuffer class to contain such function. Also,
+RGBA32PremultipliedBuffer was renamed to BGRA32PremultipliedBuffer, correcting
+an old mistake.
+
+Reviewed by Andreas Kling.
+
+No new tests. Existing tests in LayoutTests/compositing test this.
+
+* platform/graphics/opengl/TextureMapperGL.cpp:
+(WebCore::BitmapTextureGL::beginPaint):
+(WebCore::BitmapTextureGL::endPaint):
+(WebCore::swizzleBGRAToRGBA):
+(WebCore::BitmapTextureGL::updateContents):
+* platform/graphics/opengl/TextureMapperGL.h:
+(WebCore::BGRA32PremultimpliedBuffer::~BGRA32PremultimpliedBuffer):
+* platform/graphics/qt/TextureMapperQt.cpp:
+(WebCore::BitmapTextureQt::updateContents):
+(WebCore::BGRA32PremultimpliedBufferQt::data):
+(WebCore::BGRA32PremultimpliedBuffer::create):
+* platform/graphics/qt/TextureMapperQt.h:
+* platform/graphics/texmap/TextureMapper.h:
+
 2011-09-23  Tor Arne Vestbø  tor.arne.ves...@nokia.com
 
 [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi


Modified: trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp (96117 => 96118)

--- trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp	2011-09-27 16:21:37 UTC (rev 96117)
+++ trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp	2011-09-27 16:28:17 UTC (rev 96118)
@@ -238,6 +238,7 @@
 inline FloatSize relativeSize() const { return m_relativeSize; }
 void setTextureMapper(TextureMapperGL* texmap) { m_textureMapper = texmap; }
 
+void updateContents(PixelFormat, const IntRect, void*);
 void pack()
 {
 // This is currently a stub.
@@ -265,7 +266,7 @@
 FloatSize m_relativeSize;
 bool m_opaque;
 IntSize m_textureSize;
-RefPtrRGBA32PremultimpliedBuffer m_buffer;
+OwnPtrBGRA32PremultimpliedBuffer m_buffer;
 IntRect m_dirtyRect;
 GLuint m_fbo;
 GLuint m_rbo;
@@ -523,7 +524,7 @@
 
 PlatformGraphicsContext* BitmapTextureGL::beginPaint(const IntRect dirtyRect)
 {
-m_buffer = RGBA32PremultimpliedBuffer::create();
+m_buffer = BGRA32PremultimpliedBuffer::create();
 m_dirtyRect = dirtyRect;
 return m_buffer-beginPaint(dirtyRect, m_opaque);
 }
@@ -533,15 +534,62 @@
 if (!m_buffer)
 return;
 m_buffer-endPaint();
+updateContents(BGRAFormat, m_dirtyRect, m_buffer-data());
 GL_CMD(glBindTexture(GL_TEXTURE_2D, m_id))
+m_buffer.clear();
+}
+
 #ifdef TEXMAP_OPENGL_ES_2
-// FIXME: use shaders for RGBA-BGRA swap if this becomes a performance issue.
-m_buffer-swapRGB();
-

[webkit-changes] [96120] trunk/Source/WebCore

2011-09-27 Thread noam . rosenthal

Title: [96120] trunk/Source/WebCore








Revision 96120
Author noam.rosent...@nokia.com
Date 2011-09-27 09:38:19 -0700 (Tue, 27 Sep 2011)


Log Message
[Texmap] Code cleanup: remove unused boundingRect/visibleRect calculations
https://bugs.webkit.org/show_bug.cgi?id=68897

Reviewed by Andreas Kling.

No new functionality so no new tests.

* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::computeAllTransforms):
(WebCore::TextureMapperNode::computeTiles):
(WebCore::TextureMapperNode::syncCompositingState):
* platform/graphics/texmap/TextureMapperNode.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperNode.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (96119 => 96120)

--- trunk/Source/WebCore/ChangeLog	2011-09-27 16:28:18 UTC (rev 96119)
+++ trunk/Source/WebCore/ChangeLog	2011-09-27 16:38:19 UTC (rev 96120)
@@ -1,5 +1,20 @@
 2011-09-27  No'am Rosenthal  noam.rosent...@nokia.com
 
+[Texmap] Code cleanup: remove unused boundingRect/visibleRect calculations
+https://bugs.webkit.org/show_bug.cgi?id=68897
+
+Reviewed by Andreas Kling.
+
+No new functionality so no new tests.
+
+* platform/graphics/texmap/TextureMapperNode.cpp:
+(WebCore::TextureMapperNode::computeAllTransforms):
+(WebCore::TextureMapperNode::computeTiles):
+(WebCore::TextureMapperNode::syncCompositingState):
+* platform/graphics/texmap/TextureMapperNode.h:
+
+2011-09-27  No'am Rosenthal  noam.rosent...@nokia.com
+
 [Texmap][Qt] Refactor texture-upload to allow direct chunk update
 https://bugs.webkit.org/show_bug.cgi?id=68808
 


Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp (96119 => 96120)

--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp	2011-09-27 16:28:18 UTC (rev 96119)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp	2011-09-27 16:38:19 UTC (rev 96120)
@@ -136,20 +136,6 @@
 .translate3d(-originX, -originY, -m_state.anchorPoint.z());
 }
 
-bool TextureMapperNode::needsToComputeBoundingRect() const
-{
-if (m_size.width()  gTileDimension || m_size.height()  gTileDimension)
-return true;
-if (!m_state.masksToBounds)
-return false;
-
-for (size_t i = 0; i  m_children.size(); ++i)
-if (m_children[i]-needsToComputeBoundingRect())
-return true;
-
-return false;
-}
-
 void TextureMapperNode::computeAllTransforms()
 {
 if (m_size.isEmpty()  m_state.masksToBounds)
@@ -160,7 +146,6 @@
 computePerspectiveTransformIfNeeded();
 
 m_transforms.target = TransformationMatrix(m_parent ? m_parent-m_transforms.forDescendants : TransformationMatrix()).multiply(m_transforms.local);
-m_transforms.targetBoundingRect = FloatRect(m_transforms.target.mapRect(targetRect()));
 
 m_state.visible = m_state.backfaceVisibility || m_transforms.target.inverse().m33() = 0;
 if (!m_state.visible)
@@ -186,28 +171,6 @@
 m_transforms.forDescendants.multiply(m_transforms.perspective);
 }
 
-void TextureMapperNode::computeBoundingRectFromRootIfNeeded()
-{
-if (!needsToComputeBoundingRect())
-return;
-if (!m_parent) {
-m_transforms.boundingRectFromRoot = m_transforms.boundingRectFromRootForDescendants = IntRect(0, 0, -1, -1);
-return;
-}
-
-const FloatRect targetRectInRootCoordinates = m_transforms.target.mapRect(targetRect());
-
-const FloatRect parentBoundingRect = m_parent-m_transforms.boundingRectFromRootForDescendants;
-if (parentBoundingRect.width()  0)
-m_transforms.boundingRectFromRoot = targetRectInRootCoordinates;
-else {
-m_transforms.boundingRectFromRootForDescendants = m_transforms.boundingRectFromRoot = parentBoundingRect;
-m_transforms.boundingRectFromRoot.intersect(targetRectInRootCoordinates);
-}
-if (m_state.masksToBounds)
-m_transforms.boundingRectFromRootForDescendants.intersect(m_transforms.boundingRectFromRoot);
-}
-
 void TextureMapperNode::computeTiles()
 {
 if (m_currentContent.contentType == HTMLContentType  !m_state.drawsContent) {
@@ -227,10 +190,7 @@
 FloatRect tileRectInRootCoordinates = tileRect;
 tileRectInRootCoordinates.scale(1.0 / m_state.contentScale);
 tileRectInRootCoordinates = m_transforms.target.mapRect(tileRectInRootCoordinates);
-static bool sDiscardHiddenTiles = false;
-// FIXME: discard hidden tiles.
-if (!sDiscardHiddenTiles || !needsToComputeBoundingRect() || tileRectInRootCoordinates.intersects(m_state.visibleRect))
-tilesToAdd.append(tileRect);
+tilesToAdd.append(tileRect);
 }
 }
 
@@ -271,21 +231,6 @@
 m_tiles.remove(tilesToRemove[i]);
 }
 
-void TextureMapperNode::computeVisibleRectIfNeeded()
-{
-if

[webkit-changes] [96121] trunk

2011-09-27 Thread carlosgc

Title: [96121] trunk








Revision 96121
Author carlo...@webkit.org
Date 2011-09-27 09:40:03 -0700 (Tue, 27 Sep 2011)


Log Message
[GTK] Rename WebKit2 GTK+ API main header as webkit2.h
https://bugs.webkit.org/show_bug.cgi?id=65178

Reviewed by Martin Robinson.

Source/WebKit2:

* GNUmakefile.am: Add webkit2.h.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/webkit2.h: Renamed from Source/WebKit2/UIProcess/API/gtk/webkit/webkit.h.
* webkit2gtk.pc.in: Use webkitgtk-api-version as include dir.

Tools:

* GNUmakefile.am:
* GtkLauncher/main.c: Include webkit2/webkit2.h.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h
trunk/Source/WebKit2/webkit2gtk.pc.in
trunk/Tools/ChangeLog
trunk/Tools/GNUmakefile.am
trunk/Tools/GtkLauncher/main.c


Added Paths

trunk/Source/WebKit2/UIProcess/API/gtk/webkit2.h


Removed Paths

trunk/Source/WebKit2/UIProcess/API/gtk/webkit/webkit.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (96120 => 96121)

--- trunk/Source/WebKit2/ChangeLog	2011-09-27 16:38:19 UTC (rev 96120)
+++ trunk/Source/WebKit2/ChangeLog	2011-09-27 16:40:03 UTC (rev 96121)
@@ -1,3 +1,15 @@
+2011-09-27  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Rename WebKit2 GTK+ API main header as webkit2.h
+https://bugs.webkit.org/show_bug.cgi?id=65178
+
+Reviewed by Martin Robinson.
+
+* GNUmakefile.am: Add webkit2.h.
+* UIProcess/API/gtk/WebKitWebView.h:
+* UIProcess/API/gtk/webkit2.h: Renamed from Source/WebKit2/UIProcess/API/gtk/webkit/webkit.h.
+* webkit2gtk.pc.in: Use webkitgtk-api-version as include dir.
+
 2011-09-27  Tor Arne Vestbø  tor.arne.ves...@nokia.com
 
 [Qt] Fix build of WebKit2 unit-tests after r96108


Modified: trunk/Source/WebKit2/GNUmakefile.am (96120 => 96121)

--- trunk/Source/WebKit2/GNUmakefile.am	2011-09-27 16:38:19 UTC (rev 96120)
+++ trunk/Source/WebKit2/GNUmakefile.am	2011-09-27 16:40:03 UTC (rev 96121)
@@ -65,10 +65,13 @@
 	$(WebKit2)/UIProcess/API/C/WKProtectionSpace.h \
 	$(WebKit2)/UIProcess/API/C/WKProtectionSpaceTypes.h \
 	$(WebKit2)/UIProcess/API/C/WKResourceCacheManager.h \
-	$(WebKit2)/UIProcess/API/cpp/WKRetainPtr.h \
+	$(WebKit2)/UIProcess/API/cpp/WKRetainPtr.h
+
+libwebkit2gtkincludedir = $(libwebkitgtkincludedir)/webkit2
+libwebkit2gtkinclude_HEADERS = \
 	$(WebKit2)/UIProcess/API/gtk/WebKitWebView.h \
 	$(WebKit2)/UIProcess/API/gtk/WebKitWebViewBase.h \
-	$(WebKit2)/UIProcess/API/gtk/webkit/webkit.h
+	$(WebKit2)/UIProcess/API/gtk/webkit2.h
 
 webkit2_built_sources += \
 	DerivedSources/WebKit2/AuthenticationManagerMessageReceiver.cpp \
@@ -454,7 +457,7 @@
 	Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.h \
 	Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp \
 	Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h \
-	Source/WebKit2/UIProcess/API/gtk/webkit/webkit.h \
+	Source/WebKit2/UIProcess/API/gtk/webkit2.h \
 	Source/WebKit2/UIProcess/Authentication/AuthenticationChallengeProxy.cpp \
 	Source/WebKit2/UIProcess/Authentication/AuthenticationChallengeProxy.h \
 	Source/WebKit2/UIProcess/Authentication/AuthenticationDecisionListener.cpp \
@@ -849,6 +852,7 @@
 	-I$(srcdir)/Source/WebKit2/WebProcess/WebPage/gtk \
 	-I$(top_builddir)/DerivedSources/WebKit2 \
 	-I$(top_builddir)/DerivedSources/WebKit2/include \
+	-I$(top_builddir)/DerivedSources/WebKit2/include/webkit2gtk \
 	-I$(top_builddir)/DerivedSources/WebKit2/include/_javascript_Core \
 	-I$(top_builddir)/DerivedSources/WebKit2/include/WebCore \
 	-I$(top_builddir)/DerivedSources/WebKit2/include/WebKit2 \
@@ -874,7 +878,7 @@
 	libwebkit2gtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la
 
 libwebkit2gtk_@WEBKITGTK_API_MAJOR_VERSION@_@WEBKITGTK_API_MINOR_VERSION@_ladir = \
-	$(prefix)/include/webkit2-@WEBKITGTK_API_VERSION@/WebKit2
+	$(libwebkit2gtkincludedir)/WebKit2
 
 # For the Gtk port we want to use XP_UNIX both in X11 and Mac
 if !TARGET_WIN32
@@ -923,9 +927,16 @@
 forwarding_headers := $(GENSOURCES_WEBKIT2)/include
 generate-webkit2-forwarding-headers: $(WebKit2)/Scripts/generate-forwarding-headers.pl $(libWebKit2_la_SOURCES)
 	$(AM_V_GEN)$(PERL) $ $(WebKit2) $(forwarding_headers) gtk
-	$(AM_V_GEN)$(PERL) $ $(WebKit2) $(forwarding_headers) soup 
+	$(AM_V_GEN)$(PERL) $ $(WebKit2) $(forwarding_headers) soup
+
 BUILT_SOURCES += generate-webkit2-forwarding-headers
 
+$(GENSOURCES_WEBKIT2)/include/webkit2gtk/webkit2: $(libwebkit2gtkinclude_HEADERS)
+	$(AM_V_GEN)mkdir -p $(GENSOURCES_WEBKIT2)/include/webkit2gtk \
+	 ln -s -f ${shell pwd}/$(WebKit2)/UIProcess/API/gtk $@
+
+BUILT_SOURCES += $(GENSOURCES_WEBKIT2)/include/webkit2gtk/webkit2
+
 vpath %.messages.in = \
 	$(WebKit2)/PluginProcess \
 	$(WebKit2)/Shared/Plugins \


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h (96120 => 96121)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h	2011-09-27 16:38:19 UTC (rev 96120)
+++

[webkit-changes] [96122] trunk

2011-09-27 Thread jchaffraix

Title: [96122] trunk








Revision 96122
Author jchaffr...@webkit.org
Date 2011-09-27 09:55:59 -0700 (Tue, 27 Sep 2011)


Log Message
Crash because CSSPrimitiveValue::computeLengthDouble assumes fontMetrics are available
https://bugs.webkit.org/show_bug.cgi?id=66291

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/canvas/crash-set-font.html

This is Yet Another Missing updateFont (similar to bug 57756 and likely others). Here the issue is that
applying one of the font properties could mutate the parent style's font if m_parentStyle == m_style.
We would then query the newly created font when applying CSSPropertyFontSize, which has no font fallback
list as Font::update was never called.

The right fix would be to refactor of how we handle fonts to avoid such manual updates (see bug 62390).
Until this happens, it is better not to crash.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Added updateFont() here as the fonts could have been
mutated by the previous property change. Also added a comment explaining why it is safe to do it
this way.

LayoutTests:

* fast/canvas/crash-set-font-expected.txt: Added.
* fast/canvas/crash-set-font.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp


Added Paths

trunk/LayoutTests/fast/canvas/crash-set-font-expected.txt
trunk/LayoutTests/fast/canvas/crash-set-font.html




Diff

Modified: trunk/LayoutTests/ChangeLog (96121 => 96122)

--- trunk/LayoutTests/ChangeLog	2011-09-27 16:40:03 UTC (rev 96121)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 16:55:59 UTC (rev 96122)
@@ -1,3 +1,13 @@
+2011-09-27  Julien Chaffraix  jchaffr...@webkit.org
+
+Crash because CSSPrimitiveValue::computeLengthDouble assumes fontMetrics are available
+https://bugs.webkit.org/show_bug.cgi?id=66291
+
+Reviewed by Darin Adler.
+
+* fast/canvas/crash-set-font-expected.txt: Added.
+* fast/canvas/crash-set-font.html: Added.
+
 2011-09-27  Ilya Tikhonovsky  loi...@chromium.org
 
 Unreviewed followupfix for r96110.


Added: trunk/LayoutTests/fast/canvas/crash-set-font-expected.txt (0 => 96122)

--- trunk/LayoutTests/fast/canvas/crash-set-font-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/canvas/crash-set-font-expected.txt	2011-09-27 16:55:59 UTC (rev 96122)
@@ -0,0 +1,3 @@
+Test for bug 66291: Crash because CSSPrimitiveValue::computeLengthDouble assumes fontMetrics are available
+
+This test passed as it did not crash.


Added: trunk/LayoutTests/fast/canvas/crash-set-font.html (0 => 96122)

--- trunk/LayoutTests/fast/canvas/crash-set-font.html	(rev 0)
+++ trunk/LayoutTests/fast/canvas/crash-set-font.html	2011-09-27 16:55:59 UTC (rev 96122)
@@ -0,0 +1,16 @@
+!DOCTYPE html
+html
+head
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+oContext2d = document.getCSSCanvasContext(2d,,0);
+oContext2d.font = small-caps .0ex G;
+oContext2d.font = italic .0ex G;
+oContext2d.font = italic 400 .0ex G;
+/script
+/head
+body
+pTest for bug a href="" Crash because CSSPrimitiveValue::computeLengthDouble assumes fontMetrics are available/p
+pThis test passed as it did not crash./p


Modified: trunk/Source/WebCore/ChangeLog (96121 => 96122)

--- trunk/Source/WebCore/ChangeLog	2011-09-27 16:40:03 UTC (rev 96121)
+++ trunk/Source/WebCore/ChangeLog	2011-09-27 16:55:59 UTC (rev 96122)
@@ -1,3 +1,25 @@
+2011-09-27  Julien Chaffraix  jchaffr...@webkit.org
+
+Crash because CSSPrimitiveValue::computeLengthDouble assumes fontMetrics are available
+https://bugs.webkit.org/show_bug.cgi?id=66291
+
+Reviewed by Darin Adler.
+
+Test: fast/canvas/crash-set-font.html
+
+This is Yet Another Missing updateFont (similar to bug 57756 and likely others). Here the issue is that
+applying one of the font properties could mutate the parent style's font if m_parentStyle == m_style.
+We would then query the newly created font when applying CSSPropertyFontSize, which has no font fallback
+list as Font::update was never called.
+
+The right fix would be to refactor of how we handle fonts to avoid such manual updates (see bug 62390).
+Until this happens, it is better not to crash.
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::applyProperty): Added updateFont() here as the fonts could have been
+mutated by the previous property change. Also added a comment explaining why it is safe to do it
+this way.
+
 2011-09-27  No'am Rosenthal  noam.rosent...@nokia.com
 
 [Texmap] Code cleanup: remove unused boundingRect/visibleRect calculations


Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (96121 => 96122)

--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-09-27 16:40:03 UTC (rev 96121)
+++

[webkit-changes] [96123] trunk/Source/WebCore

2011-09-27 Thread ossy

Title: [96123] trunk/Source/WebCore








Revision 96123
Author o...@webkit.org
Date 2011-09-27 10:06:26 -0700 (Tue, 27 Sep 2011)


Log Message
Fix ENABLE(SQL_DATABASE)=0 build after r95919
https://bugs.webkit.org/show_bug.cgi?id=68902

r95919 enabled OFFLINE_WEB_APPLICATIONS by default and
it needs SQLite stuff even if ENABLE_SQL_DATABASE=0.

Reviewed by Adam Barth.

* platform/sql/SQLiteAuthorizer.cpp:
* platform/sql/SQLiteDatabase.cpp:
* platform/sql/SQLiteFileSystem.cpp:
* platform/sql/SQLiteStatement.cpp:
* platform/sql/SQLiteTransaction.cpp:
* storage/DatabaseAuthorizer.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/sql/SQLiteAuthorizer.cpp
trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp
trunk/Source/WebCore/platform/sql/SQLiteFileSystem.cpp
trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp
trunk/Source/WebCore/platform/sql/SQLiteTransaction.cpp
trunk/Source/WebCore/storage/DatabaseAuthorizer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (96122 => 96123)

--- trunk/Source/WebCore/ChangeLog	2011-09-27 16:55:59 UTC (rev 96122)
+++ trunk/Source/WebCore/ChangeLog	2011-09-27 17:06:26 UTC (rev 96123)
@@ -1,3 +1,20 @@
+2011-09-27  Csaba Osztrogonác  o...@webkit.org
+
+Fix ENABLE(SQL_DATABASE)=0 build after r95919
+https://bugs.webkit.org/show_bug.cgi?id=68902
+
+r95919 enabled OFFLINE_WEB_APPLICATIONS by default and
+it needs SQLite stuff even if ENABLE_SQL_DATABASE=0.
+
+Reviewed by Adam Barth.
+
+* platform/sql/SQLiteAuthorizer.cpp:
+* platform/sql/SQLiteDatabase.cpp:
+* platform/sql/SQLiteFileSystem.cpp:
+* platform/sql/SQLiteStatement.cpp:
+* platform/sql/SQLiteTransaction.cpp:
+* storage/DatabaseAuthorizer.cpp:
+
 2011-09-27  Julien Chaffraix  jchaffr...@webkit.org
 
 Crash because CSSPrimitiveValue::computeLengthDouble assumes fontMetrics are available


Modified: trunk/Source/WebCore/platform/sql/SQLiteAuthorizer.cpp (96122 => 96123)

--- trunk/Source/WebCore/platform/sql/SQLiteAuthorizer.cpp	2011-09-27 16:55:59 UTC (rev 96122)
+++ trunk/Source/WebCore/platform/sql/SQLiteAuthorizer.cpp	2011-09-27 17:06:26 UTC (rev 96123)
@@ -29,8 +29,6 @@
 #include config.h
 #include DatabaseAuthorizer.h
 
-#if ENABLE(SQL_DATABASE)
-
 #include sqlite3.h
 
 namespace WebCore {
@@ -40,5 +38,3 @@
 const int SQLAuthDeny = SQLITE_DENY;
 
 } // namespace WebCore
-
-#endif // ENABLE(SQL_DATABASE)


Modified: trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp (96122 => 96123)

--- trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp	2011-09-27 16:55:59 UTC (rev 96122)
+++ trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp	2011-09-27 17:06:26 UTC (rev 96123)
@@ -27,8 +27,6 @@
 #include config.h
 #include SQLiteDatabase.h
 
-#if ENABLE(SQL_DATABASE)
-
 #include DatabaseAuthorizer.h
 #include Logging.h
 #include SQLiteFileSystem.h
@@ -471,5 +469,3 @@
 }
 
 } // namespace WebCore
-
-#endif // ENABLE(SQL_DATABASE)


Modified: trunk/Source/WebCore/platform/sql/SQLiteFileSystem.cpp (96122 => 96123)

--- trunk/Source/WebCore/platform/sql/SQLiteFileSystem.cpp	2011-09-27 16:55:59 UTC (rev 96122)
+++ trunk/Source/WebCore/platform/sql/SQLiteFileSystem.cpp	2011-09-27 17:06:26 UTC (rev 96123)
@@ -32,8 +32,6 @@
 #include config.h
 #include SQLiteFileSystem.h
 
-#if ENABLE(SQL_DATABASE)
-
 #include FileSystem.h
 #include SQLiteDatabase.h
 #include SQLiteStatement.h
@@ -125,5 +123,3 @@
 }
 
 } // namespace WebCore
-
-#endif // ENABLE(SQL_DATABASE)


Modified: trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp (96122 => 96123)

--- trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp	2011-09-27 16:55:59 UTC (rev 96122)
+++ trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp	2011-09-27 17:06:26 UTC (rev 96123)
@@ -26,8 +26,6 @@
 #include config.h
 #include SQLiteStatement.h
 
-#if ENABLE(SQL_DATABASE)
-
 #include Logging.h
 #include SQLValue.h
 #include sqlite3.h
@@ -545,5 +543,3 @@
 }
 
 } // namespace WebCore
-
-#endif // ENABLE(SQL_DATABASE)


Modified: trunk/Source/WebCore/platform/sql/SQLiteTransaction.cpp (96122 => 96123)

--- trunk/Source/WebCore/platform/sql/SQLiteTransaction.cpp	2011-09-27 16:55:59 UTC (rev 96122)
+++ trunk/Source/WebCore/platform/sql/SQLiteTransaction.cpp	2011-09-27 17:06:26 UTC (rev 96123)
@@ -26,8 +26,6 @@
 #include config.h
 #include SQLiteTransaction.h
 
-#if ENABLE(SQL_DATABASE)
-
 #include SQLiteDatabase.h
 
 namespace WebCore {
@@ -103,5 +101,3 @@
 }
 
 } // namespace WebCore
-
-#endif // ENABLE(SQL_DATABASE)


Modified: trunk/Source/WebCore/storage/DatabaseAuthorizer.cpp (96122 => 96123)

--- trunk/Source/WebCore/storage/DatabaseAuthorizer.cpp	2011-09-27 16:55:59 UTC (rev 96122)
+++ trunk/Source/WebCore/storage/DatabaseAuthorizer.cpp	2011-09-27 17:06:26 UTC (rev 96123)
@@ -29,8 +29,6 @@
 #include config.h
 #include DatabaseAuthorizer.h
 
-#if ENABLE(SQL_DATABASE)
-
 #include PlatformString.h
 #include wtf/PassRefPtr.h
 
@@ -434,5 +432,3 @@
 }
 
 }

[webkit-changes] [96124] trunk/LayoutTests

2011-09-27 Thread jchaffraix

Title: [96124] trunk/LayoutTests








Revision 96124
Author jchaffr...@webkit.org
Date 2011-09-27 10:18:06 -0700 (Tue, 27 Sep 2011)


Log Message
Crash in WebCore::HTMLParser::createHead
https://bugs.webkit.org/show_bug.cgi?id=32426

Reviewed by Darin Adler.

The crash was fixed some time ago but the test was not landed which kept the bug open.

* fast/parser/crash-HTMLParser-createHead.html: Added.
Tweaked the test case as we now throw an exception (DOM Exception 12).

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/parser/crash-HTMLParser-createHead-expected.txt
trunk/LayoutTests/fast/parser/crash-HTMLParser-createHead.html




Diff

Modified: trunk/LayoutTests/ChangeLog (96123 => 96124)

--- trunk/LayoutTests/ChangeLog	2011-09-27 17:06:26 UTC (rev 96123)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 17:18:06 UTC (rev 96124)
@@ -1,5 +1,17 @@
 2011-09-27  Julien Chaffraix  jchaffr...@webkit.org
 
+Crash in WebCore::HTMLParser::createHead
+https://bugs.webkit.org/show_bug.cgi?id=32426
+
+Reviewed by Darin Adler.
+
+The crash was fixed some time ago but the test was not landed which kept the bug open.
+
+* fast/parser/crash-HTMLParser-createHead.html: Added.
+Tweaked the test case as we now throw an exception (DOM Exception 12).
+
+2011-09-27  Julien Chaffraix  jchaffr...@webkit.org
+
 Crash because CSSPrimitiveValue::computeLengthDouble assumes fontMetrics are available
 https://bugs.webkit.org/show_bug.cgi?id=66291
 


Added: trunk/LayoutTests/fast/parser/crash-HTMLParser-createHead-expected.txt (0 => 96124)

--- trunk/LayoutTests/fast/parser/crash-HTMLParser-createHead-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/parser/crash-HTMLParser-createHead-expected.txt	2011-09-27 17:18:06 UTC (rev 96124)
@@ -0,0 +1,3 @@
+Test for bug 32426: Crash in WebCore::HTMLParser::createHead
+
+This test PASSED as it did not CRASH nor ASSERTED.


Added: trunk/LayoutTests/fast/parser/crash-HTMLParser-createHead.html (0 => 96124)

--- trunk/LayoutTests/fast/parser/crash-HTMLParser-createHead.html	(rev 0)
+++ trunk/LayoutTests/fast/parser/crash-HTMLParser-createHead.html	2011-09-27 17:18:06 UTC (rev 96124)
@@ -0,0 +1,15 @@
+body _onload_=go();/body
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function go() {
+document.open();
+try {
+new Image().insertAdjacentHTML(0,xmeta);
+} catch (e) {
+}
+document.write('pTest for bug a href="" Crash in WebCore::HTMLParser::createHead/p');
+document.write('pThis test PASSED as it did not CRASH nor ASSERTED./p');
+}
+/script






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96127] trunk

2011-09-27 Thread commit-queue

Title: [96127] trunk








Revision 96127
Author commit-qu...@webkit.org
Date 2011-09-27 10:29:46 -0700 (Tue, 27 Sep 2011)


Log Message
AXObjectCache cleared unnecessarily when non-top Document is detached.
https://bugs.webkit.org/show_bug.cgi?id=68636

Patch by Dominic Mazzoni dmazz...@google.com on 2011-09-27
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/deleting-iframe-destroys-axcache.html

* dom/Document.cpp:
(WebCore::Document::attach):
(WebCore::Document::detach):

LayoutTests:

* accessibility/deleting-iframe-destroys-axcache.html: Added.
* platform/mac/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp


Added Paths

trunk/LayoutTests/accessibility/deleting-iframe-destroys-axcache.html
trunk/LayoutTests/platform/mac/accessibility/deleting-iframe-destroys-axcache-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96126 => 96127)

--- trunk/LayoutTests/ChangeLog	2011-09-27 17:27:12 UTC (rev 96126)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 17:29:46 UTC (rev 96127)
@@ -1,3 +1,13 @@
+2011-09-27  Dominic Mazzoni  dmazz...@google.com
+
+AXObjectCache cleared unnecessarily when non-top Document is detached.
+https://bugs.webkit.org/show_bug.cgi?id=68636
+
+Reviewed by Chris Fleizach.
+
+* accessibility/deleting-iframe-destroys-axcache.html: Added.
+* platform/mac/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
+
 2011-09-26  Ryosuke Niwa  rn...@webkit.org
 
 dump-as-markup conversion: editing/pasteboard/merge-end-list.html and merge-end-table.html


Added: trunk/LayoutTests/accessibility/deleting-iframe-destroys-axcache.html (0 => 96127)

--- trunk/LayoutTests/accessibility/deleting-iframe-destroys-axcache.html	(rev 0)
+++ trunk/LayoutTests/accessibility/deleting-iframe-destroys-axcache.html	2011-09-27 17:29:46 UTC (rev 96127)
@@ -0,0 +1,107 @@
+html
+head
+link rel=stylesheet href=""
+script src=""
+
+  script
+if (window.layoutTestController)
+layoutTestController.waitUntilDone();
+
+function buildAccessibilityTree(accessibilityObject, indent) {
+var str = ;
+for (var i = 0; i  indent; i++)
+str += ;
+str += accessibilityObject.role;
+str +=   + accessibilityObject.stringValue;
+
+if (accessibilityObject.role == '')
+str += accessibilityObject.allAttributes();
+
+str += \n;
+document.getElementById(console).innerText += str;
+
+if (accessibilityObject.stringValue.indexOf('End of test') = 0)
+return false;
+
+var count = accessibilityObject.childrenCount;
+for (var i = 0; i  count; ++i) {
+if (!buildAccessibilityTree(accessibilityObject.childAtIndex(i), indent + 1))
+return false;
+}
+
+return true;
+}
+
+function runTest()
+{
+description(This tests that deleting an iframe doesn't cause the accessibility cache to be destroyed and recreated.);
+
+if (window.accessibilityController) {
+window.root = accessibilityController.rootElement;
+window.body = root.childAtIndex(0);
+window.before = body.childAtIndex(0).childAtIndex(0);
+window.iframe = body.childAtIndex(1).childAtIndex(0);
+window.after = body.childAtIndex(2).childAtIndex(0);
+
+window.frameBody = window.iframe.childAtIndex(0);
+window.frameBodyRole = window.frameBody.role;
+window.frameGroup = window.frameBody.childAtIndex(0);
+window.frameGroupRole = window.frameGroup.role;
+window.frameButton = window.frameGroup.childAtIndex(0);
+window.frameButtonRole = window.frameButton.role;
+
+document.getElementById(console).innerText += \nBefore:\n;
+buildAccessibilityTree(root, 0);
+
+// Remove the iframe.
+document.body.removeChild(document.getElementById(iframe));
+
+window.newRoot = accessibilityController.rootElement;
+window.newBody = newRoot.childAtIndex(0);
+window.newBefore = newBody.childAtIndex(0).childAtIndex(0);
+window.newAfter = newBody.childAtIndex(1).childAtIndex(0);
+
+document.getElementById(console).innerText += \nAfter:\n;
+buildAccessibilityTree(newRoot, 0);
+document.getElementById(console).innerText += \n;
+
+// Make sure that the accessibility objects from the iframe's nodes
+// are now invalid by checking that their role is changed - this
+// is because they've been deleted.
+shouldBeFalse(frameBodyRole == frameBody.role);
+shouldBeFalse(frameGroupRole == frameGroup.role);
+shouldBeFalse(frameButtonRole == frameButton.role);
+
+//

[webkit-changes] [96128] trunk/LayoutTests

2011-09-27 Thread enne

Title: [96128] trunk/LayoutTests








Revision 96128
Author e...@google.com
Date 2011-09-27 10:38:52 -0700 (Tue, 27 Sep 2011)


Log Message
[Chromium] Layout Test compositing/video-page-visibility.html is failing on GPU linux
https://bugs.webkit.org/show_bug.cgi?id=68882

	Unreviewed rebaseline.

* platform/chromium-gpu-linux/compositing/video-page-visibility-expected.png: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium-gpu-linux/compositing/video-page-visibility-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (96127 => 96128)

--- trunk/LayoutTests/ChangeLog	2011-09-27 17:29:46 UTC (rev 96127)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 17:38:52 UTC (rev 96128)
@@ -1,3 +1,13 @@
+2011-09-27  Adrienne Walker  e...@google.com
+
+[Chromium] Layout Test compositing/video-page-visibility.html is failing on GPU linux
+https://bugs.webkit.org/show_bug.cgi?id=68882
+
+	Unreviewed rebaseline.
+
+* platform/chromium-gpu-linux/compositing/video-page-visibility-expected.png: Added.
+* platform/chromium/test_expectations.txt:
+
 2011-09-27  Dominic Mazzoni  dmazz...@google.com
 
 AXObjectCache cleared unnecessarily when non-top Document is detached.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96127 => 96128)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 17:29:46 UTC (rev 96127)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 17:38:52 UTC (rev 96128)
@@ -3776,8 +3776,6 @@
 BUGWK68881 DEBUG : svg/text/selection-background-color.xhtml = CRASH
 BUGWK68881 DEBUG : svg/text/selection-styles.xhtml = CRASH
 
-BUGWK68882 LINUX GPU : compositing/video-page-visibility.html = IMAGE
-
 BUGWK68885 MAC CPU-CG : fast/canvas/webgl/premultiplyalpha-test.html = TEXT
 
 BUGWK68886 MAC GPU-CG : compositing/geometry/limit-layer-bounds-transformed-overflow.html = TEXT


Added: trunk/LayoutTests/platform/chromium-gpu-linux/compositing/video-page-visibility-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-gpu-linux/compositing/video-page-visibility-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96130] trunk/Source/WebCore

2011-09-27 Thread simon . fraser

Title: [96130] trunk/Source/WebCore








Revision 96130
Author simon.fra...@apple.com
Date 2011-09-27 10:55:02 -0700 (Tue, 27 Sep 2011)


Log Message
Clean up how FrameView accesses the RenderView
https://bugs.webkit.org/show_bug.cgi?id=68914

Reviewed by Sam Weinig.

Clean up how FrameView accesses the content renderer of its
frame. Previously, this was done in several different ways,
only some of which did null-checking.

Use an inline method to avoid having to expose Frame
in the header.

Standardize the terminology to use 'root' for this RenderView.

* page/FrameView.cpp:
(WebCore::rootRenderer):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::updateCompositingLayers):
(WebCore::FrameView::clearBackingStores):
(WebCore::FrameView::restoreBackingStores):
(WebCore::FrameView::layerForHorizontalScrollbar):
(WebCore::FrameView::layerForVerticalScrollbar):
(WebCore::FrameView::layerForScrollCorner):
(WebCore::FrameView::layerForOverhangAreas):
(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::hasCompositedContent):
(WebCore::FrameView::enterCompositingMode):
(WebCore::FrameView::isSoftwareRenderable):
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::layout):
(WebCore::FrameView::embeddedContentBox):
(WebCore::FrameView::contentsInCompositedLayer):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::maintainScrollPositionAtAnchor):
(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore::FrameView::visibleContentsResized):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::needsLayout):
(WebCore::FrameView::setNeedsLayout):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::updateControlTints):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::adjustPageHeightDeprecated):
(WebCore::FrameView::isVerticalDocument):
(WebCore::FrameView::isFlippedDocument):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (96129 => 96130)

--- trunk/Source/WebCore/ChangeLog	2011-09-27 17:53:32 UTC (rev 96129)
+++ trunk/Source/WebCore/ChangeLog	2011-09-27 17:55:02 UTC (rev 96130)
@@ -1,3 +1,56 @@
+2011-09-27  Simon Fraser  simon.fra...@apple.com
+
+Clean up how FrameView accesses the RenderView
+https://bugs.webkit.org/show_bug.cgi?id=68914
+
+Reviewed by Sam Weinig.
+
+Clean up how FrameView accesses the content renderer of its
+frame. Previously, this was done in several different ways,
+only some of which did null-checking.
+
+Use an inline method to avoid having to expose Frame
+in the header.
+
+Standardize the terminology to use 'root' for this RenderView.
+
+* page/FrameView.cpp:
+(WebCore::rootRenderer):
+(WebCore::FrameView::setFrameRect):
+(WebCore::FrameView::adjustViewSize):
+(WebCore::FrameView::updateCompositingLayers):
+(WebCore::FrameView::clearBackingStores):
+(WebCore::FrameView::restoreBackingStores):
+(WebCore::FrameView::layerForHorizontalScrollbar):
+(WebCore::FrameView::layerForVerticalScrollbar):
+(WebCore::FrameView::layerForScrollCorner):
+(WebCore::FrameView::layerForOverhangAreas):
+(WebCore::FrameView::syncCompositingStateForThisFrame):
+(WebCore::FrameView::hasCompositedContent):
+(WebCore::FrameView::enterCompositingMode):
+(WebCore::FrameView::isSoftwareRenderable):
+(WebCore::FrameView::didMoveOnscreen):
+(WebCore::FrameView::willMoveOffscreen):
+(WebCore::FrameView::layout):
+(WebCore::FrameView::embeddedContentBox):
+(WebCore::FrameView::contentsInCompositedLayer):
+(WebCore::FrameView::scrollContentsFastPath):
+(WebCore::FrameView::scrollContentsSlowPath):
+(WebCore::FrameView::maintainScrollPositionAtAnchor):
+(WebCore::FrameView::scrollPositionChanged):
+(WebCore::FrameView::repaintFixedElementsAfterScrolling):
+(WebCore::FrameView::visibleContentsResized):
+(WebCore::FrameView::scheduleRelayoutOfSubtree):
+(WebCore::FrameView::needsLayout):
+(WebCore::FrameView::setNeedsLayout):
+(WebCore::FrameView::performPostLayoutTasks):
+(WebCore::FrameView::updateControlTints):
+(WebCore::FrameView::paintContents):
+(WebCore::FrameView::forceLayoutForPagination):
+(WebCore::FrameView::adjustPageHeightDeprecated):
+(WebCore::FrameView::isVerticalDocument):
+(WebCore::FrameView::isFlippedDocument):
+
 2011-09-27  Dominic Mazzoni  dmazz...@google.com
 
 AXObjectCache cleared unnecessarily when non-top

[webkit-changes] [96129] trunk/Tools

2011-09-27 Thread abarth

Title: [96129] trunk/Tools








Revision 96129
Author aba...@webkit.org
Date 2011-09-27 10:53:32 -0700 (Tue, 27 Sep 2011)


Log Message
garden-o-matic results view should sort test and builder names
https://bugs.webkit.org/show_bug.cgi?id=68488

Reviewed by Andy Estes.

Previously, the test and builder names were displayed in an arbitrary
order that changed from time to time.  That confused one user study
participant.  This patch sorts the lists so that they occur in a
predictable order.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js (96128 => 96129)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js	2011-09-27 17:38:52 UTC (rev 96128)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js	2011-09-27 17:53:32 UTC (rev 96129)
@@ -169,7 +169,7 @@
 this._delegate = delegate;
 this._length = 0;
 
-Object.keys(resultsByTest).forEach(function (testName) {
+Object.keys(resultsByTest).sort().forEach(function(testName) {
 var link = document.createElement('a');
 $(link).attr('href', '#').text(testName);
 
@@ -245,7 +245,7 @@
 
 var tabStrip = this.appendChild(document.createElement('ul'));
 
-Object.keys(resultsByBuilder).forEach(function(builderName) {
+Object.keys(resultsByBuilder).sort().forEach(function(builderName) {
 var builderDirectory = results.directoryForBuilder(builderName);
 
 var link = document.createElement('a');


Modified: trunk/Tools/ChangeLog (96128 => 96129)

--- trunk/Tools/ChangeLog	2011-09-27 17:38:52 UTC (rev 96128)
+++ trunk/Tools/ChangeLog	2011-09-27 17:53:32 UTC (rev 96129)
@@ -1,3 +1,17 @@
+2011-09-27  Adam Barth  aba...@webkit.org
+
+garden-o-matic results view should sort test and builder names
+https://bugs.webkit.org/show_bug.cgi?id=68488
+
+Reviewed by Andy Estes.
+
+Previously, the test and builder names were displayed in an arbitrary
+order that changed from time to time.  That confused one user study
+participant.  This patch sorts the lists so that they occur in a
+predictable order.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
+
 2011-09-27  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r96108, r96111, r96113, and r96116.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96131] trunk

2011-09-27 Thread commit-queue

Title: [96131] trunk








Revision 96131
Author commit-qu...@webkit.org
Date 2011-09-27 10:58:55 -0700 (Tue, 27 Sep 2011)


Log Message
Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994

Patch by Juan Carlos Montemayor Elosua j.m...@me.com on 2011-09-27
Reviewed by Oliver Hunt.

Source/_javascript_Core:

This patch utilizes topCallFrame to create a stack trace when
an error is thrown. Users will also be able to use the stack()
command in jsc to get arrays with stack trace information.

* _javascript_Core.exp:
* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
* interpreter/Interpreter.cpp:
(JSC::getCallerLine):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
* interpreter/Interpreter.h:
(JSC::StackFrame::toString):
* jsc.cpp:
(GlobalObject::finishCreation):
(functionJSCStack):
* parser/Parser.h:
(JSC::Parser::parse):
* runtime/CommonIdentifiers.h:
* runtime/Error.cpp:
(JSC::addErrorInfo):
* runtime/Error.h:

LayoutTests:

Unit tests that contain both normal and special cases for stack trace
generation.

* fast/js/exception-properties-expected.txt:
* fast/js/script-tests/exception-properties.js:
* fast/js/script-tests/stack-trace.js: Added.
(printStack):
(hostThrower):
(callbacker):
(outer):
(inner):
(evaler):
(normalOuter):
(normalInner):
(scripterInner):
(scripterOuter):
* fast/js/stack-trace-expected.txt: Added.
* fast/js/stack-trace.html: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/exception-properties-expected.txt
trunk/LayoutTests/fast/js/script-tests/exception-properties.js
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.exp
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
trunk/Source/_javascript_Core/interpreter/Interpreter.h
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/_javascript_Core/parser/Parser.h
trunk/Source/_javascript_Core/runtime/CommonIdentifiers.h
trunk/Source/_javascript_Core/runtime/Error.cpp
trunk/Source/_javascript_Core/runtime/Error.h


Added Paths

trunk/LayoutTests/fast/js/script-tests/stack-trace.js
trunk/LayoutTests/fast/js/stack-trace-expected.txt
trunk/LayoutTests/fast/js/stack-trace.html




Diff

Modified: trunk/LayoutTests/ChangeLog (96130 => 96131)

--- trunk/LayoutTests/ChangeLog	2011-09-27 17:55:02 UTC (rev 96130)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 17:58:55 UTC (rev 96131)
@@ -1,3 +1,30 @@
+2011-09-27  Juan Carlos Montemayor Elosua  j.m...@me.com
+
+Implement Error.stack
+https://bugs.webkit.org/show_bug.cgi?id=66994
+
+Reviewed by Oliver Hunt.
+
+Unit tests that contain both normal and special cases for stack trace
+generation.
+
+* fast/js/exception-properties-expected.txt:
+* fast/js/script-tests/exception-properties.js:
+* fast/js/script-tests/stack-trace.js: Added.
+(printStack):
+(hostThrower):
+(callbacker):
+(outer):
+(inner):
+(evaler):
+(normalOuter):
+(normalInner):
+(scripterInner):
+(scripterOuter):
+* fast/js/stack-trace-expected.txt: Added.
+* fast/js/stack-trace.html: Added.
+* platform/chromium/test_expectations.txt:
+
 2011-09-27  Adrienne Walker  e...@google.com
 
 [Chromium] Layout Test compositing/video-page-visibility.html is failing on GPU linux


Modified: trunk/LayoutTests/fast/js/exception-properties-expected.txt (96130 => 96131)

--- trunk/LayoutTests/fast/js/exception-properties-expected.txt	2011-09-27 17:55:02 UTC (rev 96130)
+++ trunk/LayoutTests/fast/js/exception-properties-expected.txt	2011-09-27 17:58:55 UTC (rev 96131)
@@ -4,7 +4,7 @@
 
 
 PASS enumerableProperties(error) is []
-PASS enumerableProperties(nativeError) is [line, sourceId, sourceURL]
+PASS enumerableProperties(nativeError) is [line, sourceId, sourceURL, jscStack]
 PASS Object.getPrototypeOf(nativeError).name is RangeError
 PASS Object.getPrototypeOf(nativeError).message is 
 PASS successfullyParsed is true


Modified: trunk/LayoutTests/fast/js/script-tests/exception-properties.js (96130 => 96131)

--- trunk/LayoutTests/fast/js/script-tests/exception-properties.js	2011-09-27 17:55:02 UTC (rev 96130)
+++ trunk/LayoutTests/fast/js/script-tests/exception-properties.js	2011-09-27 17:58:55 UTC (rev 96131)
@@ -16,7 +16,7 @@
 var error = new Error(message);
 
 shouldBe('enumerableProperties(error)', '[]');
-shouldBe('enumerableProperties(nativeError)', '[line, sourceId, sourceURL]');
+shouldBe('enumerableProperties(nativeError)', '[line, sourceId, sourceURL, jscStack]');
 
 shouldBe('Object.getPrototypeOf(nativeError).name', 'RangeError');

[webkit-changes] [96133] trunk/Source/WebKit2

2011-09-27 Thread carlosgc

Title: [96133] trunk/Source/WebKit2








Revision 96133
Author carlo...@webkit.org
Date 2011-09-27 11:06:06 -0700 (Tue, 27 Sep 2011)


Log Message
[GTK] Add WebKitWebContext to GTK API
https://bugs.webkit.org/show_bug.cgi?id=67931

Reviewed by Philippe Normand.

Initial implementation of WebKitWebContext for WebKit2 GTK API.

* GNUmakefile.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitWebContext.cpp: Added.
(webkitWebContextFinalize):
(webkit_web_context_init):
(webkit_web_context_class_init):
(createDefaultWebContext):
(webkit_web_context_get_default):
* UIProcess/API/gtk/WebKitWebContext.h: Added.
* UIProcess/API/gtk/tests/testwebcontext.c:
(testWebContextDefault):
(main):
* UIProcess/API/gtk/webkit2.h: Add webkit2/WebKitWebContext.h.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/Source/WebKit2/UIProcess/API/gtk/webkit2.h


Added Paths

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h
trunk/Source/WebKit2/UIProcess/API/gtk/tests/
trunk/Source/WebKit2/UIProcess/API/gtk/tests/testwebcontext.c




Diff

Modified: trunk/Source/WebKit2/ChangeLog (96132 => 96133)

--- trunk/Source/WebKit2/ChangeLog	2011-09-27 18:04:01 UTC (rev 96132)
+++ trunk/Source/WebKit2/ChangeLog	2011-09-27 18:06:06 UTC (rev 96133)
@@ -1,3 +1,26 @@
+2011-09-27  Carlos Garcia Campos  cgar...@igalia.com
+
+
+[GTK] Add WebKitWebContext to GTK API
+https://bugs.webkit.org/show_bug.cgi?id=67931
+
+Reviewed by Philippe Normand.
+
+Initial implementation of WebKitWebContext for WebKit2 GTK API.
+
+* GNUmakefile.am: Add new files to compilation.
+* UIProcess/API/gtk/WebKitWebContext.cpp: Added.
+(webkitWebContextFinalize):
+(webkit_web_context_init):
+(webkit_web_context_class_init):
+(createDefaultWebContext):
+(webkit_web_context_get_default):
+* UIProcess/API/gtk/WebKitWebContext.h: Added.
+* UIProcess/API/gtk/tests/testwebcontext.c:
+(testWebContextDefault):
+(main):
+* UIProcess/API/gtk/webkit2.h: Add webkit2/WebKitWebContext.h.
+
 2011-09-27  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r96108, r96111, r96113, and r96116.


Modified: trunk/Source/WebKit2/GNUmakefile.am (96132 => 96133)

--- trunk/Source/WebKit2/GNUmakefile.am	2011-09-27 18:04:01 UTC (rev 96132)
+++ trunk/Source/WebKit2/GNUmakefile.am	2011-09-27 18:06:06 UTC (rev 96133)
@@ -69,6 +69,7 @@
 
 libwebkit2gtkincludedir = $(libwebkitgtkincludedir)/webkit2
 libwebkit2gtkinclude_HEADERS = \
+	$(WebKit2)/UIProcess/API/gtk/WebKitWebContext.h \
 	$(WebKit2)/UIProcess/API/gtk/WebKitWebView.h \
 	$(WebKit2)/UIProcess/API/gtk/WebKitWebViewBase.h \
 	$(WebKit2)/UIProcess/API/gtk/webkit2.h
@@ -452,6 +453,8 @@
 	Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h \
 	Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h \
 	Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp \
+	Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h \
+	Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp \
 	Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h \
 	Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp \
 	Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.h \
@@ -982,6 +985,39 @@
 DISTCLEANFILES += \
 	$(top_builddir)/WebKit2/webkit2gtk-@WEBKITGTK_API_VERSION@.pc
 
+# Unit tests
+TEST_PROGS += \
+	Programs/unittests/webkit2/testwebcontext
+
+noinst_PROGRAMS += $(TEST_PROGS)
+webkit2_tests_cflags = \
+	-I$(srcdir)/Source \
+	-I$(srcdir)/Source/WebKit2 \
+	-I$(top_builddir)/DerivedSources/WebKit2/include \
+	-I$(top_builddir)/DerivedSources/WebKit2/include/webkit2gtk \
+	-I$(srcdir)/Source/WebKit2/UIProcess/API/gtk \
+	$(global_cflags) \
+	$(global_cppflags) \
+	$(GLIB_CFLAGS) \
+	$(GTK_CFLAGS) \
+	$(LIBSOUP_CFLAGS)
+
+webkit2_tests_ldadd = \
+	libjavascriptcoregtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la \
+	libwebkit2gtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la \
+	$(GLIB_LIBS) \
+	$(GTK_LIBS) \
+	$(LIBSOUP_LIBS)
+
+webkit2_tests_ldflags = \
+	-no-install \
+	-no-fast-install
+
+Programs_unittests_webkit2_testwebcontext_SOURCES = Source/WebKit2/UIProcess/API/gtk/tests/testwebcontext.c
+Programs_unittests_webkit2_testwebcontext_CFLAGS = $(webkit2_tests_cflags)
+Programs_unittests_webkit2_testwebcontext_LDADD = $(webkit2_tests_ldadd)
+Programs_unittests_webkit2_testwebcontext_LDFLAGS = $(webkit2_tests_ldflags)
+
 # WebKitWebProcess
 libexec_PROGRAMS += \
 	Programs/WebKitWebProcess


Added: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp (0 => 96133)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp	(rev 0)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp	2011-09-27 18:06:06 UTC (rev 96133)
@@ -0,0 +1,77 @@
+/*
+ * Copyright (C) 2011 Igalia S.L.
+ *
+ * This library is free software; you can redistribute it and/or
+ *

[webkit-changes] [96134] trunk

2011-09-27 Thread commit-queue

Title: [96134] trunk








Revision 96134
Author commit-qu...@webkit.org
Date 2011-09-27 11:17:32 -0700 (Tue, 27 Sep 2011)


Log Message
Autofocus on readonly inputs does not focus the element.
https://bugs.webkit.org/show_bug.cgi?id=24092

Patch by Kaustubh Atrawalkar kaust...@motorola.com on 2011-09-27
Reviewed by Ryosuke Niwa.

Source/WebCore:

Readonly input elements should be autofocusable. Removed the check.

Tests: fast/forms/autofocus-readonly-attribute.html

* html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):

LayoutTests:

* fast/forms/autofocus-readonly-attribute-expected.txt: Added.
* fast/forms/autofocus-readonly-attribute.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLFormControlElement.cpp


Added Paths

trunk/LayoutTests/fast/forms/autofocus-readonly-attribute-expected.txt
trunk/LayoutTests/fast/forms/autofocus-readonly-attribute.html




Diff

Modified: trunk/LayoutTests/ChangeLog (96133 => 96134)

--- trunk/LayoutTests/ChangeLog	2011-09-27 18:06:06 UTC (rev 96133)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 18:17:32 UTC (rev 96134)
@@ -1,3 +1,13 @@
+2011-09-27  Kaustubh Atrawalkar  kaust...@motorola.com
+
+Autofocus on readonly inputs does not focus the element.
+https://bugs.webkit.org/show_bug.cgi?id=24092
+
+Reviewed by Ryosuke Niwa.
+
+* fast/forms/autofocus-readonly-attribute-expected.txt: Added.
+* fast/forms/autofocus-readonly-attribute.html: Added.
+
 2011-09-27  Mihai Parparita  mih...@chromium.org
 
 Remove duplicate of fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html


Added: trunk/LayoutTests/fast/forms/autofocus-readonly-attribute-expected.txt (0 => 96134)

--- trunk/LayoutTests/fast/forms/autofocus-readonly-attribute-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/autofocus-readonly-attribute-expected.txt	2011-09-27 18:17:32 UTC (rev 96134)
@@ -0,0 +1,4 @@
+The text box should have focus console should print PASS
+
+PASS
+


Added: trunk/LayoutTests/fast/forms/autofocus-readonly-attribute.html (0 => 96134)

--- trunk/LayoutTests/fast/forms/autofocus-readonly-attribute.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/autofocus-readonly-attribute.html	2011-09-27 18:17:32 UTC (rev 96134)
@@ -0,0 +1,19 @@
+!DOCYTPE html
+html
+head
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function log(msg) {
+var console = document.getElementById(console);
+console.innerText = msg;
+}
+/script
+/head
+body
+pThe text box should have focus console should print PASS/p
+div id=console/div
+pinput type=text name=test id=test readonly autofocus _onfocus_='log(PASS)'/p
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (96133 => 96134)

--- trunk/Source/WebCore/ChangeLog	2011-09-27 18:06:06 UTC (rev 96133)
+++ trunk/Source/WebCore/ChangeLog	2011-09-27 18:17:32 UTC (rev 96134)
@@ -1,3 +1,17 @@
+2011-09-27  Kaustubh Atrawalkar  kaust...@motorola.com
+
+Autofocus on readonly inputs does not focus the element.
+https://bugs.webkit.org/show_bug.cgi?id=24092
+
+Reviewed by Ryosuke Niwa.
+
+Readonly input elements should be autofocusable. Removed the check.
+
+Tests: fast/forms/autofocus-readonly-attribute.html
+
+* html/HTMLFormControlElement.cpp:
+(WebCore::shouldAutofocus):
+
 2011-09-27  Simon Fraser  simon.fra...@apple.com
 
 Clean up how FrameView accesses the RenderView


Modified: trunk/Source/WebCore/html/HTMLFormControlElement.cpp (96133 => 96134)

--- trunk/Source/WebCore/html/HTMLFormControlElement.cpp	2011-09-27 18:06:06 UTC (rev 96133)
+++ trunk/Source/WebCore/html/HTMLFormControlElement.cpp	2011-09-27 18:17:32 UTC (rev 96134)
@@ -128,8 +128,6 @@
 return false;
 if (element-document()-ignoreAutofocus())
 return false;
-if (element-isReadOnlyFormControl())
-return false;
 if (element-hasAutofocused())
 return false;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96135] trunk

2011-09-27 Thread commit-queue

Title: [96135] trunk








Revision 96135
Author commit-qu...@webkit.org
Date 2011-09-27 11:19:01 -0700 (Tue, 27 Sep 2011)


Log Message
[v8] Code calling the typed array optimization script is fragile, depends on typed array hierarchy.

Install the flag, which indicates whether or not the optimization
script was executed, on the global object.

https://bugs.webkit.org/show_bug.cgi?id=68890

Patch by Ulan Degenbaev u...@chromium.org on 2011-09-27
Reviewed by Kenneth Russell.

* Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp




Diff

Modified: trunk/ChangeLog (96134 => 96135)

--- trunk/ChangeLog	2011-09-27 18:17:32 UTC (rev 96134)
+++ trunk/ChangeLog	2011-09-27 18:19:01 UTC (rev 96135)
@@ -1,3 +1,16 @@
+2011-09-27  Ulan Degenbaev  u...@chromium.org
+
+[v8] Code calling the typed array optimization script is fragile, depends on typed array hierarchy.
+
+Install the flag, which indicates whether or not the optimization
+script was executed, on the global object.
+
+https://bugs.webkit.org/show_bug.cgi?id=68890
+
+Reviewed by Kenneth Russell.
+
+* Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
+
 2011-09-27  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r96108, r96111, r96113, and r96116.


Modified: trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp (96134 => 96135)

--- trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp	2011-09-27 18:17:32 UTC (rev 96134)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp	2011-09-27 18:19:01 UTC (rev 96135)
@@ -32,25 +32,24 @@
 
 namespace WebCore {
 
-const char fastSetFlagName[] = webgl::FastSetFlag;
+// The random suffix helps to avoid name collision.
+const char fastSetFlagName[] = TypedArray::FastSet::8NkZVq;
 
 bool fastSetInstalled(v8::Handlev8::Object array)
 {
-// Use a hidden flag in the common prototype (ArrayBufferView) of all typed
-// arrays as an indicator of whether the fast 'set' is installed or not.
-v8::Handlev8::Object prototype = array-GetPrototype().Asv8::Object();
-v8::Handlev8::Object arrayBufferView = prototype-GetPrototype().Asv8::Object();
+// Use a hidden flag in the global object an indicator of whether the fast
+// 'set' is installed or not.
+v8::Handlev8::Object global = array-CreationContext()-Global();
 v8::Handlev8::String key = v8::String::New(fastSetFlagName);
-v8::Handlev8::Value fastSetFlag = arrayBufferView-GetHiddenValue(key);
+v8::Handlev8::Value fastSetFlag = global-GetHiddenValue(key);
 return !fastSetFlag.IsEmpty();
 }
 
 void installFastSet(v8::Handlev8::Object array)
 {
-v8::Handlev8::Object prototype = array-GetPrototype().Asv8::Object();
-v8::Handlev8::Object arrayBufferView = prototype-GetPrototype().Asv8::Object();
+v8::Handlev8::Object global = array-CreationContext()-Global();
 v8::Handlev8::String key = v8::String::New(fastSetFlagName);
-arrayBufferView-SetHiddenValue(key, v8::Boolean::New(true));
+global-SetHiddenValue(key, v8::Boolean::New(true));
 
 String source(reinterpret_castconst char*(V8ArrayBufferViewCustomScript_js),
   sizeof(V8ArrayBufferViewCustomScript_js));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96136] trunk/Source/WebKit2

2011-09-27 Thread carlosgc

Title: [96136] trunk/Source/WebKit2








Revision 96136
Author carlo...@webkit.org
Date 2011-09-27 11:32:55 -0700 (Tue, 27 Sep 2011)


Log Message
[GTK] Use WebKitWebContext in WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=67990

Reviewed by Martin Robinson.

Use webkit_web_context_get_default() instead of
WKContextGetSharedProcessContext() and add API to create a view
with a given web context and to return the current context
associated to the view.

* GNUmakefile.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitPrivate.h: Added.
* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextGetWKContext): Private API to get the WKContext
wrapped by the WebKitWebContext.
* UIProcess/API/gtk/WebKitWebContextPrivate.h: Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Create the webpage using the web
context of the view.
(webkitWebViewSetProperty):
(webkitWebViewGetProperty):
(webkit_web_view_init):
(webkit_web_view_class_init):
(webkit_web_view_new): Create a new view with the default context.
(webkit_web_view_new_with_context): Create a new view with the
given context.
(webkit_web_view_get_context): Return the context.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/tests/testwebview.c: Added.
(testWebViewDefaultContext):
(main):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h


Added Paths

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContextPrivate.h
trunk/Source/WebKit2/UIProcess/API/gtk/tests/testwebview.c




Diff

Modified: trunk/Source/WebKit2/ChangeLog (96135 => 96136)

--- trunk/Source/WebKit2/ChangeLog	2011-09-27 18:19:01 UTC (rev 96135)
+++ trunk/Source/WebKit2/ChangeLog	2011-09-27 18:32:55 UTC (rev 96136)
@@ -1,6 +1,40 @@
 2011-09-27  Carlos Garcia Campos  cgar...@igalia.com
 
+[GTK] Use WebKitWebContext in WebKitWebView
+https://bugs.webkit.org/show_bug.cgi?id=67990
 
+Reviewed by Martin Robinson.
+
+Use webkit_web_context_get_default() instead of
+WKContextGetSharedProcessContext() and add API to create a view
+with a given web context and to return the current context
+associated to the view.
+
+* GNUmakefile.am: Add new files to compilation.
+* UIProcess/API/gtk/WebKitPrivate.h: Added.
+* UIProcess/API/gtk/WebKitWebContext.cpp:
+(webkitWebContextGetWKContext): Private API to get the WKContext
+wrapped by the WebKitWebContext.
+* UIProcess/API/gtk/WebKitWebContextPrivate.h: Added.
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkitWebViewConstructed): Create the webpage using the web
+context of the view.
+(webkitWebViewSetProperty):
+(webkitWebViewGetProperty):
+(webkit_web_view_init):
+(webkit_web_view_class_init):
+(webkit_web_view_new): Create a new view with the default context.
+(webkit_web_view_new_with_context): Create a new view with the
+given context.
+(webkit_web_view_get_context): Return the context.
+* UIProcess/API/gtk/WebKitWebView.h:
+* UIProcess/API/gtk/tests/testwebview.c: Added.
+(testWebViewDefaultContext):
+(main):
+
+2011-09-27  Carlos Garcia Campos  cgar...@igalia.com
+
+
 [GTK] Add WebKitWebContext to GTK API
 https://bugs.webkit.org/show_bug.cgi?id=67931
 


Modified: trunk/Source/WebKit2/GNUmakefile.am (96135 => 96136)

--- trunk/Source/WebKit2/GNUmakefile.am	2011-09-27 18:19:01 UTC (rev 96135)
+++ trunk/Source/WebKit2/GNUmakefile.am	2011-09-27 18:32:55 UTC (rev 96136)
@@ -453,8 +453,10 @@
 	Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h \
 	Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h \
 	Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp \
+	Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h \
 	Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h \
 	Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp \
+	Source/WebKit2/UIProcess/API/gtk/WebKitWebContextPrivate.h \
 	Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h \
 	Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp \
 	Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.h \
@@ -987,7 +989,8 @@
 
 # Unit tests
 TEST_PROGS += \
-	Programs/unittests/webkit2/testwebcontext
+	Programs/unittests/webkit2/testwebcontext \
+	Programs/unittests/webkit2/testwebview
 
 noinst_PROGRAMS += $(TEST_PROGS)
 webkit2_tests_cflags = \
@@ -1018,6 +1021,11 @@
 Programs_unittests_webkit2_testwebcontext_LDADD = $(webkit2_tests_ldadd)
 Programs_unittests_webkit2_testwebcontext_LDFLAGS = $(webkit2_tests_ldflags)
 
+Programs_unittests_webkit2_testwebview_SOURCES = Source/WebKit2/UIProcess/API/gtk/tests/testwebview.c
+Programs_unittests_webkit2_testwebview_CFLAGS =

[webkit-changes] [96137] trunk/Source/WebCore

2011-09-27 Thread mihaip

Title: [96137] trunk/Source/WebCore








Revision 96137
Author mih...@chromium.org
Date 2011-09-27 11:44:15 -0700 (Tue, 27 Sep 2011)


Log Message
Fix Chromium Mac build after r96130.

* page/FrameView.cpp:
(WebCore::FrameView::layerForOverhangAreas):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (96136 => 96137)

--- trunk/Source/WebCore/ChangeLog	2011-09-27 18:32:55 UTC (rev 96136)
+++ trunk/Source/WebCore/ChangeLog	2011-09-27 18:44:15 UTC (rev 96137)
@@ -1,3 +1,10 @@
+2011-09-27  Mihai Parparita  mih...@chromium.org
+
+Fix Chromium Mac build after r96130.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::layerForOverhangAreas):
+
 2011-09-27  Kaustubh Atrawalkar  kaust...@motorola.com
 
 Autofocus on readonly inputs does not focus the element.


Modified: trunk/Source/WebCore/page/FrameView.cpp (96136 => 96137)

--- trunk/Source/WebCore/page/FrameView.cpp	2011-09-27 18:32:55 UTC (rev 96136)
+++ trunk/Source/WebCore/page/FrameView.cpp	2011-09-27 18:44:15 UTC (rev 96137)
@@ -697,9 +697,9 @@
 GraphicsLayer* FrameView::layerForOverhangAreas() const
 {
 RenderView* root = rootRenderer(this);
-if (!view)
+if (!root)
 return 0;
-return view-compositor()-layerForOverhangAreas();
+return root-compositor()-layerForOverhangAreas();
 }
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96138] trunk

2011-09-27 Thread simon . fraser

Title: [96138] trunk








Revision 96138
Author simon.fra...@apple.com
Date 2011-09-27 12:00:56 -0700 (Tue, 27 Sep 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=67858

Roll r96070 back in now that the crash has been fixed in r96130.

Source/WebCore:

Reviewed by Darin Adler.

When non-overlay scrollbars are hidden on a composited iframe, nothing invalidated
the scrollbar areas or the scroll corner, so the scrollbars appear to remain.

Fix by invalidating the scrollbars and scroll corner when they are removed. Invalidation
on scrollbar creation appears to happen via updating the scrollbar style.

Tested by compositing/iframes/repaint-after-losing-scrollbars.html which no longer shows
stale scrollbars when run manually, even though the green squares are missing from the
pixel result (bug 67878).

* page/FrameView.cpp:
(WebCore::FrameView::updateScrollCorner): Pass the corner rect into invalidateScrollCorner().
* platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar): Invalidate the scrollbar area if hiding it.
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
(WebCore::ScrollView::updateScrollbars): In the case where both scrollbars are going away,
compute the scroll corner rect while we still have scrollbars, and then invalidate it
explicitly. (updateScrollCorner() doesn't, because it doesn't have access to the old corner
rect.)
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::invalidateScrollCorner): Pass the rect in, because we can't
compute it in the case where the scrollbars are going away.
* platform/ScrollableArea.h: Pass in a rect to invalidateScrollCorner(), which matches
invalidateScrollbar().
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::destroyRootLayer): Pass the corner rect into invalidateScrollCorner().
* rendering/RenderScrollbarPart.cpp: Ditto.
(WebCore::RenderScrollbarPart::imageChanged): Ditto.

LayoutTests:

* compositing/iframes/repaint-after-losing-scrollbars-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/compositing/iframes/repaint-after-losing-scrollbars-expected.png
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/platform/ScrollView.cpp
trunk/Source/WebCore/platform/ScrollableArea.cpp
trunk/Source/WebCore/platform/ScrollableArea.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderScrollbarPart.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (96137 => 96138)

--- trunk/LayoutTests/ChangeLog	2011-09-27 18:44:15 UTC (rev 96137)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 19:00:56 UTC (rev 96138)
@@ -1,3 +1,11 @@
+2011-09-27  Simon Fraser  simon.fra...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=67858
+
+Roll r96070 back in now that the crash has been fixed in r96130.
+
+* compositing/iframes/repaint-after-losing-scrollbars-expected.png:
+
 2011-09-27  Kaustubh Atrawalkar  kaust...@motorola.com
 
 Autofocus on readonly inputs does not focus the element.


Modified: trunk/LayoutTests/compositing/iframes/repaint-after-losing-scrollbars-expected.png

(Binary files differ)


Modified: trunk/Source/WebCore/ChangeLog (96137 => 96138)

--- trunk/Source/WebCore/ChangeLog	2011-09-27 18:44:15 UTC (rev 96137)
+++ trunk/Source/WebCore/ChangeLog	2011-09-27 19:00:56 UTC (rev 96138)
@@ -1,3 +1,40 @@
+2011-09-27  Simon Fraser  simon.fra...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=67858
+
+Roll r96070 back in now that the crash has been fixed in r96130.
+
+Reviewed by Darin Adler.
+
+When non-overlay scrollbars are hidden on a composited iframe, nothing invalidated
+the scrollbar areas or the scroll corner, so the scrollbars appear to remain.
+
+Fix by invalidating the scrollbars and scroll corner when they are removed. Invalidation
+on scrollbar creation appears to happen via updating the scrollbar style.
+
+Tested by compositing/iframes/repaint-after-losing-scrollbars.html which no longer shows
+stale scrollbars when run manually, even though the green squares are missing from the
+pixel result (bug 67878).
+
+* page/FrameView.cpp:
+(WebCore::FrameView::updateScrollCorner): Pass the corner rect into invalidateScrollCorner().
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::setHasHorizontalScrollbar): Invalidate the scrollbar area if hiding it.
+(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
+(WebCore::ScrollView::updateScrollbars): In the case where both scrollbars are going away,
+compute the scroll corner rect while we still have scrollbars, and then invalidate it
+explicitly. (updateScrollCorner() doesn't, because it doesn't have access to the old corner
+rect.)
+* platform/ScrollableArea.cpp:
+(WebCore::ScrollableArea::invalidateScrollCorner): Pass the rect in,

[webkit-changes] [96140] trunk/Source/WebKit/efl

2011-09-27 Thread commit-queue

Title: [96140] trunk/Source/WebKit/efl








Revision 96140
Author commit-qu...@webkit.org
Date 2011-09-27 12:34:35 -0700 (Tue, 27 Sep 2011)


Log Message
[EFL] Make ewk_view emit the load,document,finished signal.
https://bugs.webkit.org/show_bug.cgi?id=66782

Patch by Raphael Kubo da Costa k...@profusion.mobi on 2011-09-27
Reviewed by Antonio Gomes.

Currently, only ewk_frame emits the load,document,finished signal
when FrameLoaderClientEfl::dispatchDidFinishDocumentLoad() calls
ewk_frame_load_document_finished().

However, in some cases it is not even possible to connect to the
frame,created signal to properly monitor the
load,document,finished signal, as the former is not emitted.
fast/frames/frame-unload-crash.html, for example, has a page with an
iframe inside an iframe, and this innermost iframe does not seem to be
loaded via FrameLoaderClientEfl::createFrame (which calls all the
machinery which then emits the frame,created signal).

We now make ewk_frame_load_document_finished() call the newly-created
ewk_view_load_document_finished() function, whose job is to emit the
load,document,signal with the frame as its parameter. This way, one
can just connect to the view and make sure all the signals will get
delivered.

* ewk/ewk_frame.cpp:
(ewk_frame_load_document_finished):
* ewk/ewk_private.h:
* ewk/ewk_view.cpp:
(ewk_view_load_document_finished):
* ewk/ewk_view.h:

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_frame.cpp
trunk/Source/WebKit/efl/ewk/ewk_private.h
trunk/Source/WebKit/efl/ewk/ewk_view.cpp
trunk/Source/WebKit/efl/ewk/ewk_view.h




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (96139 => 96140)

--- trunk/Source/WebKit/efl/ChangeLog	2011-09-27 19:31:31 UTC (rev 96139)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-09-27 19:34:35 UTC (rev 96140)
@@ -1,3 +1,35 @@
+2011-09-27  Raphael Kubo da Costa  k...@profusion.mobi
+
+[EFL] Make ewk_view emit the load,document,finished signal.
+https://bugs.webkit.org/show_bug.cgi?id=66782
+
+Reviewed by Antonio Gomes.
+
+Currently, only ewk_frame emits the load,document,finished signal
+when FrameLoaderClientEfl::dispatchDidFinishDocumentLoad() calls
+ewk_frame_load_document_finished().
+
+However, in some cases it is not even possible to connect to the
+frame,created signal to properly monitor the
+load,document,finished signal, as the former is not emitted.
+fast/frames/frame-unload-crash.html, for example, has a page with an
+iframe inside an iframe, and this innermost iframe does not seem to be
+loaded via FrameLoaderClientEfl::createFrame (which calls all the
+machinery which then emits the frame,created signal).
+
+We now make ewk_frame_load_document_finished() call the newly-created
+ewk_view_load_document_finished() function, whose job is to emit the
+load,document,signal with the frame as its parameter. This way, one
+can just connect to the view and make sure all the signals will get
+delivered.
+
+* ewk/ewk_frame.cpp:
+(ewk_frame_load_document_finished):
+* ewk/ewk_private.h:
+* ewk/ewk_view.cpp:
+(ewk_view_load_document_finished):
+* ewk/ewk_view.h:
+
 2011-09-26  Raphael Kubo da Costa  k...@profusion.mobi
 
 [CMake] Remove FindFreetype.cmake


Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.cpp (96139 => 96140)

--- trunk/Source/WebKit/efl/ewk/ewk_frame.cpp	2011-09-27 19:31:31 UTC (rev 96139)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.cpp	2011-09-27 19:34:35 UTC (rev 96140)
@@ -1339,6 +1339,8 @@
 void ewk_frame_load_document_finished(Evas_Object* o)
 {
 evas_object_smart_callback_call(o, load,document,finished, 0);
+EWK_FRAME_SD_GET_OR_RETURN(o, sd);
+ewk_view_load_document_finished(sd-view, o);
 }
 
 /**


Modified: trunk/Source/WebKit/efl/ewk/ewk_private.h (96139 => 96140)

--- trunk/Source/WebKit/efl/ewk/ewk_private.h	2011-09-27 19:31:31 UTC (rev 96139)
+++ trunk/Source/WebKit/efl/ewk/ewk_private.h	2011-09-27 19:34:35 UTC (rev 96140)
@@ -81,6 +81,7 @@
 void ewk_view_input_method_state_set(Evas_Object* o, Eina_Bool active);
 void ewk_view_title_set(Evas_Object* o, const char* title);
 void ewk_view_uri_changed(Evas_Object* o);
+void ewk_view_load_document_finished(Evas_Object* o, Evas_Object* frame);
 void ewk_view_load_started(Evas_Object* o);
 void ewk_view_load_provisional(Evas_Object* o);
 void ewk_view_frame_main_load_started(Evas_Object* o);


Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (96139 => 96140)

--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2011-09-27 19:31:31 UTC (rev 96139)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2011-09-27 19:34:35 UTC (rev 96140)
@@ -2702,6 +2702,20 @@
 
 /**
  * @internal
+ * Reports that a DOM document object has finished loading for @p frame.
+ *
+ * @param o View which contains the frame.
+ * @param frame The frame whose load has triggered the

[webkit-changes] [96143] trunk/Source/JavaScriptCore

2011-09-27 Thread mhahnenberg

Title: [96143] trunk/Source/_javascript_Core








Revision 96143
Author mhahnenb...@apple.com
Date 2011-09-27 12:53:49 -0700 (Tue, 27 Sep 2011)


Log Message
De-virtualize JSCell::getPrimitiveNumber
https://bugs.webkit.org/show_bug.cgi?id=68851

Reviewed by Darin Adler.

* _javascript_Core.exp:
* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:

Changed JSCell::getPrimitiveNumber to manually handle the dispatch for 
JSCells (JSObject and JSString in this case).
* runtime/JSCell.cpp:
(JSC::JSCell::getPrimitiveNumber):
* runtime/JSCell.h:

Removed JSNotAnObject::getPrimitiveNumber since its return value doesn't 
matter and it already implements defaultValue, so JSObject::getPrimitiveNumber
can cover the case for JSNotAnObject.
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:

De-virtualized JSObject::getPrimitiveNumber and JSString::getPrimitiveNumber 
and changed them to be const.  Also made JSString::getPrimitiveNumber public 
because it needs to be called from JSCell::getPrimitiveNumber and also since it's 
no longer virtual, we want people who have a more specific pointer (JSString* 
instead of JSCell*) to not have to pay the cost of a virtual method call.
* runtime/JSObject.cpp:
(JSC::JSObject::getPrimitiveNumber):
* runtime/JSObject.h:
* runtime/JSString.cpp:
(JSC::JSString::getPrimitiveNumber):
* runtime/JSString.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.exp
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def
trunk/Source/_javascript_Core/runtime/JSCell.cpp
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/JSNotAnObject.cpp
trunk/Source/_javascript_Core/runtime/JSNotAnObject.h
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/runtime/JSObject.h
trunk/Source/_javascript_Core/runtime/JSString.cpp
trunk/Source/_javascript_Core/runtime/JSString.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (96142 => 96143)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-27 19:49:09 UTC (rev 96142)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-27 19:53:49 UTC (rev 96143)
@@ -1,3 +1,37 @@
+2011-09-27  Mark Hahnenberg  mhahnenb...@apple.com
+
+De-virtualize JSCell::getPrimitiveNumber
+https://bugs.webkit.org/show_bug.cgi?id=68851
+
+Reviewed by Darin Adler.
+
+* _javascript_Core.exp:
+* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
+
+Changed JSCell::getPrimitiveNumber to manually handle the dispatch for 
+JSCells (JSObject and JSString in this case).
+* runtime/JSCell.cpp:
+(JSC::JSCell::getPrimitiveNumber):
+* runtime/JSCell.h:
+
+Removed JSNotAnObject::getPrimitiveNumber since its return value doesn't 
+matter and it already implements defaultValue, so JSObject::getPrimitiveNumber
+can cover the case for JSNotAnObject.
+* runtime/JSNotAnObject.cpp:
+* runtime/JSNotAnObject.h:
+
+De-virtualized JSObject::getPrimitiveNumber and JSString::getPrimitiveNumber 
+and changed them to be const.  Also made JSString::getPrimitiveNumber public 
+because it needs to be called from JSCell::getPrimitiveNumber and also since it's 
+no longer virtual, we want people who have a more specific pointer (JSString* 
+instead of JSCell*) to not have to pay the cost of a virtual method call.
+* runtime/JSObject.cpp:
+(JSC::JSObject::getPrimitiveNumber):
+* runtime/JSObject.h:
+* runtime/JSString.cpp:
+(JSC::JSString::getPrimitiveNumber):
+* runtime/JSString.h:
+
 2011-09-27  Juan Carlos Montemayor Elosua  j.m...@me.com
 
 Implement Error.stack


Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (96142 => 96143)

--- trunk/Source/_javascript_Core/_javascript_Core.exp	2011-09-27 19:49:09 UTC (rev 96142)
+++ trunk/Source/_javascript_Core/_javascript_Core.exp	2011-09-27 19:53:49 UTC (rev 96143)
@@ -259,7 +259,6 @@
 __ZN3JSC6JSCell16getConstructDataERNS_13ConstructDataE
 __ZN3JSC6JSCell18getOwnPropertySlotEPNS_9ExecStateERKNS_10IdentifierERNS_12PropertySlotE
 __ZN3JSC6JSCell18getOwnPropertySlotEPNS_9ExecStateEjRNS_12PropertySlotE
-__ZN3JSC6JSCell18getPrimitiveNumberEPNS_9ExecStateERdRNS_7JSValueE
 __ZN3JSC6JSCell3putEPNS_9ExecStateERKNS_10IdentifierENS_7JSValueERNS_15PutPropertySlotE
 __ZN3JSC6JSCell3putEPNS_9ExecStateEjNS_7JSValueE  
 __ZN3JSC6JSCell9getObjectEv
@@ -322,7 +321,6 @@
 __ZN3JSC8JSObject17putWithAttributesEPNS_9ExecStateERKNS_10IdentifierENS_7JSValueEjbRNS_15PutPropertySlotE
 __ZN3JSC8JSObject17putWithAttributesEPNS_9ExecStateEjNS_7JSValueEj
 __ZN3JSC8JSObject18getOwnPropertySlotEPNS_9ExecStateEjRNS_12PropertySlotE
-__ZN3JSC8JSObject18getPrimitiveNumberEPNS_9ExecStateERdRNS_7JSValueE

[webkit-changes] [96144] trunk/Tools

2011-09-27 Thread levin

Title: [96144] trunk/Tools








Revision 96144
Author le...@chromium.org
Date 2011-09-27 12:55:27 -0700 (Tue, 27 Sep 2011)


Log Message
watchlist: Add the filename pattern for definitions.
https://bugs.webkit.org/show_bug.cgi?id=68917

Reviewed by Adam Barth.

* Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
* Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
* Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
for definitions.
* Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
* Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/watchlist/watchlist.py
trunk/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py
trunk/Tools/Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py


Added Paths

trunk/Tools/Scripts/webkitpy/common/watchlist/filenamepattern.py
trunk/Tools/Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py
trunk/Tools/Scripts/webkitpy/common/watchlist/watchlist_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (96143 => 96144)

--- trunk/Tools/ChangeLog	2011-09-27 19:53:49 UTC (rev 96143)
+++ trunk/Tools/ChangeLog	2011-09-27 19:55:27 UTC (rev 96144)
@@ -1,3 +1,17 @@
+2011-09-27  David Levin  le...@chromium.org
+
+watchlist: Add the filename pattern for definitions.
+https://bugs.webkit.org/show_bug.cgi?id=68917
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
+* Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
+* Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
+for definitions.
+* Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
+* Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.
+
 2011-09-27  Adam Barth  aba...@webkit.org
 
 garden-o-matic results view should sort test and builder names


Copied: trunk/Tools/Scripts/webkitpy/common/watchlist/filenamepattern.py (from rev 96142, trunk/Tools/Scripts/webkitpy/common/watchlist/watchlist.py) (0 => 96144)

--- trunk/Tools/Scripts/webkitpy/common/watchlist/filenamepattern.py	(rev 0)
+++ trunk/Tools/Scripts/webkitpy/common/watchlist/filenamepattern.py	2011-09-27 19:55:27 UTC (rev 96144)
@@ -0,0 +1,37 @@
+# Copyright (C) 2011 Google Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+# * Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# * Redistributions in binary form must reproduce the above
+# copyright notice, this list of conditions and the following disclaimer
+# in the documentation and/or other materials provided with the
+# distribution.
+# * Neither the name of Google Inc. nor the names of its
+# contributors may be used to endorse or promote products derived from
+# this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import re
+
+
+class FilenamePattern:
+def __init__(self, regex):
+self._regex = re.compile(regex + '$')
+
+def match(self, path, diff_file):
+return self._regex.match(path)


Copied: trunk/Tools/Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py (from rev 96142, trunk/Tools/Scripts/webkitpy/common/watchlist/watchlist.py) (0 => 96144)

--- trunk/Tools/Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py	(rev 0)
+++ trunk/Tools/Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py	2011-09-27 19:55:27 UTC (rev 96144)
@@ -0,0 +1,49 @@
+# Copyright (C) 2011 Google Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+# * Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# * Redistributions in binary

[webkit-changes] [96150] trunk/Source/WebCore

2011-09-27 Thread rniwa

Title: [96150] trunk/Source/WebCore








Revision 96150
Author rn...@webkit.org
Date 2011-09-27 13:51:24 -0700 (Tue, 27 Sep 2011)


Log Message
CompositeEditCommand::prune should remove subtree at once
https://bugs.webkit.org/show_bug.cgi?id=68866

Reviewed by Darin Adler.

Extracted the logic to find the highest ancestor to remove as highestNodeToRemoveInPruning from prune.
This reduces the number of node removals from O(n) to O(1) where n is the depth of the tree.

* editing/CompositeEditCommand.cpp:
(WebCore::hasARenderedDescendant): Takes excludedNode in addition to node. excludedNode is used to ignore
the child node from which we climbed up the tree in highestNodeToRemoveInPruning.
(WebCore::highestNodeToRemoveInPruning): Extracted from prune.
(WebCore::CompositeEditCommand::prune):
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/CompositeEditCommand.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (96149 => 96150)

--- trunk/Source/WebCore/ChangeLog	2011-09-27 20:39:57 UTC (rev 96149)
+++ trunk/Source/WebCore/ChangeLog	2011-09-27 20:51:24 UTC (rev 96150)
@@ -1,3 +1,20 @@
+2011-09-27  Ryosuke Niwa  rn...@webkit.org
+
+CompositeEditCommand::prune should remove subtree at once
+https://bugs.webkit.org/show_bug.cgi?id=68866
+
+Reviewed by Darin Adler.
+
+Extracted the logic to find the highest ancestor to remove as highestNodeToRemoveInPruning from prune.
+This reduces the number of node removals from O(n) to O(1) where n is the depth of the tree.
+
+* editing/CompositeEditCommand.cpp:
+(WebCore::hasARenderedDescendant): Takes excludedNode in addition to node. excludedNode is used to ignore
+the child node from which we climbed up the tree in highestNodeToRemoveInPruning.
+(WebCore::highestNodeToRemoveInPruning): Extracted from prune.
+(WebCore::CompositeEditCommand::prune):
+(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
+
 2011-09-27  David Hyatt  hy...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=68922


Modified: trunk/Source/WebCore/editing/CompositeEditCommand.cpp (96149 => 96150)

--- trunk/Source/WebCore/editing/CompositeEditCommand.cpp	2011-09-27 20:39:57 UTC (rev 96149)
+++ trunk/Source/WebCore/editing/CompositeEditCommand.cpp	2011-09-27 20:51:24 UTC (rev 96150)
@@ -247,10 +247,13 @@
 return command-spanElement();
 }
 
-static bool hasARenderedDescendant(Node* node)
+static bool hasARenderedDescendant(Node* node, Node* excludedNode)
 {
-Node* n = node-firstChild();
-while (n) {
+for (Node* n = node-firstChild(); n;) {
+if (n == excludedNode) {
+n = n-traverseNextSibling(node);
+continue;
+}
 if (n-renderer())
 return true;
 n = n-traverseNextNode(node);
@@ -258,22 +261,26 @@
 return false;
 }
 
-void CompositeEditCommand::prune(PassRefPtrNode prpNode)
+static Node* highestNodeToRemoveInPruning(Node* node)
 {
-RefPtrNode node = prpNode;
-
-while (node) {
-// If you change this rule you may have to add an updateLayout() here.
-RenderObject* renderer = node-renderer();
-if (renderer  (!renderer-canHaveChildren() || hasARenderedDescendant(node.get()) || node-rootEditableElement() == node))
-return;
-
-RefPtrContainerNode next = node-parentNode();
-removeNode(node);
-node = next;
+Node* previousNode = 0;
+Node* rootEditableElement = node ? node-rootEditableElement() : 0;
+for (; node; node = node-parentNode()) {
+if (RenderObject* renderer = node-renderer()) {
+if (!renderer-canHaveChildren() || hasARenderedDescendant(node, previousNode) || rootEditableElement == node)
+return previousNode;
+}
+previousNode = node;
 }
+return 0;
 }
 
+void CompositeEditCommand::prune(PassRefPtrNode node)
+{
+if (RefPtrNode highestNodeToRemove = highestNodeToRemoveInPruning(node.get()))
+removeNode(highestNodeToRemove.release());
+}
+
 void CompositeEditCommand::splitTextNode(PassRefPtrText node, unsigned offset)
 {
 applyCommandToComposite(SplitTextNodeCommand::create(node, offset));
@@ -1165,11 +1172,9 @@
 // A line break is either a br or a preserved newline.
 ASSERT(caretPos.deprecatedNode()-hasTagName(brTag) || (caretPos.deprecatedNode()-isTextNode()  caretPos.deprecatedNode()-renderer()-style()-preserveNewline()));
 
-if (caretPos.deprecatedNode()-hasTagName(brTag)) {
-Position beforeBR(positionInParentBeforeNode(caretPos.deprecatedNode()));
-removeNode(caretPos.deprecatedNode());
-prune(beforeBR.deprecatedNode());
-} else if (caretPos.deprecatedNode()-isTextNode()) {
+if (caretPos.deprecatedNode()-hasTagName(brTag))
+

[webkit-changes] [96151] trunk

2011-09-27 Thread timothy_horton

Title: [96151] trunk








Revision 96151
Author timothy_hor...@apple.com
Date 2011-09-27 13:54:16 -0700 (Tue, 27 Sep 2011)


Log Message
Rapidly refreshing a feMorphology[erode] with r=0 can sometimes cause display corruption
https://bugs.webkit.org/show_bug.cgi?id=68816
rdar://problem/10186468

Reviewed by Simon Fraser.

If a filter returns without writing into its result buffer, make sure to return an cleared buffer.

Test: svg/filters/feMorphology-zero-radius.svg

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/ByteArray.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/filters/FEMorphology.cpp
trunk/Source/WebCore/platform/graphics/filters/FETurbulence.cpp


Added Paths

trunk/LayoutTests/svg/filters/feMorphology-zero-radius-expected.png
trunk/LayoutTests/svg/filters/feMorphology-zero-radius-expected.txt
trunk/LayoutTests/svg/filters/feMorphology-zero-radius.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (96150 => 96151)

--- trunk/LayoutTests/ChangeLog	2011-09-27 20:51:24 UTC (rev 96150)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 20:54:16 UTC (rev 96151)
@@ -1,3 +1,17 @@
+2011-09-27  Tim Horton  timothy_hor...@apple.com
+
+Rapidly refreshing a feMorphology[erode] with r=0 can sometimes cause display corruption
+https://bugs.webkit.org/show_bug.cgi?id=68816
+rdar://problem/10186468
+
+Reviewed by Simon Fraser.
+
+Add a test which ensures that a zero-radius feMorphology filter returns cleared memory.
+
+* svg/filters/feMorphology-zero-radius-expected.png: Added.
+* svg/filters/feMorphology-zero-radius-expected.txt: Added.
+* svg/filters/feMorphology-zero-radius.svg: Added.
+
 2011-09-27  David Hyatt  hy...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=68922


Added: trunk/LayoutTests/svg/filters/feMorphology-zero-radius-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/svg/filters/feMorphology-zero-radius-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/svg/filters/feMorphology-zero-radius-expected.txt (0 => 96151)

--- trunk/LayoutTests/svg/filters/feMorphology-zero-radius-expected.txt	(rev 0)
+++ trunk/LayoutTests/svg/filters/feMorphology-zero-radius-expected.txt	2011-09-27 20:54:16 UTC (rev 96151)
@@ -0,0 +1 @@
+


Added: trunk/LayoutTests/svg/filters/feMorphology-zero-radius.svg (0 => 96151)

--- trunk/LayoutTests/svg/filters/feMorphology-zero-radius.svg	(rev 0)
+++ trunk/LayoutTests/svg/filters/feMorphology-zero-radius.svg	2011-09-27 20:54:16 UTC (rev 96151)
@@ -0,0 +1,30 @@
+svg id=svg width=100% height=100% xmlns=http://www.w3.org/2000/svg
+titleThe entire image should be white./title
+defs
+filter id=morph
+feMorphology operator=erode radius=0/
+/filter
+/defs
+script
+![CDATA[
+for(var i = 0; i  100; i+=5)
+{
+for(var j = 0; j  100; j+=5)
+{
+var rect = document.createElementNS(http://www.w3.org/2000/svg, rect);
+rect.setAttribute(x, i);
+rect.setAttribute(y, j);
+rect.setAttribute(width, 5);
+rect.setAttribute(height, 5);
+rect.setAttribute(filter, url(#morph));
+
+document.getElementById(svg).appendChild(rect);
+}
+}
+
+if (window.layoutTestController)
+window.layoutTestController.dumpAsText();
+]]
+/script
+
+/svg


Modified: trunk/Source/_javascript_Core/ChangeLog (96150 => 96151)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-27 20:51:24 UTC (rev 96150)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-27 20:54:16 UTC (rev 96151)
@@ -1,3 +1,16 @@
+2011-09-27  Tim Horton  timothy_hor...@apple.com
+
+Rapidly refreshing a feMorphology[erode] with r=0 can sometimes cause display corruption
+https://bugs.webkit.org/show_bug.cgi?id=68816
+rdar://problem/10186468
+
+Reviewed by Simon Fraser.
+
+Add ByteArray::clear, which zeros the memory in the ByteArray.
+
+* wtf/ByteArray.h:
+(WTF::ByteArray::clear): Added.
+
 2011-09-27  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r96131.


Modified: trunk/Source/_javascript_Core/wtf/ByteArray.h (96150 => 96151)

--- trunk/Source/_javascript_Core/wtf/ByteArray.h	2011-09-27 20:51:24 UTC (rev 96150)
+++ trunk/Source/_javascript_Core/wtf/ByteArray.h	2011-09-27 20:54:16 UTC (rev 96151)
@@ -70,6 +70,8 @@
 
 unsigned char* data() { return m_data; }
 
+void clear() { memset(m_data, 0, m_size); }
+
 void deref()
 {
 if (derefBase()) {


Modified: trunk/Source/WebCore/ChangeLog (96150 => 96151)

--- trunk/Source/WebCore/ChangeLog	2011-09-27 20:51:24 UTC (rev 96150)
+++ trunk/Source/WebCore/ChangeLog	2011-09-27 20:54:16 UTC (rev

[webkit-changes] [96152] trunk

2011-09-27 Thread ojan

Title: [96152] trunk








Revision 96152
Author o...@chromium.org
Date 2011-09-27 13:55:00 -0700 (Tue, 27 Sep 2011)


Log Message
offsetTop/offsetLeft return the wrong values for horizontal-bt/vertical-rl writing modes
https://bugs.webkit.org/show_bug.cgi?id=68304

Reviewed by David Hyatt.

Source/WebCore:

When grabbing the x/y values of the RenderBox, we need to take writing mode
flipping into account.

Test: fast/dom/offset-position-writing-modes.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::locationIncludingFlipping):
* rendering/RenderBox.h:
(WebCore::RenderBox::yFlippedForWritingMode):
(WebCore::RenderBox::xFlippedForWritingMode):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::offsetLeft):
(WebCore::RenderBoxModelObject::offsetTop):

LayoutTests:

* css3/flexbox/writing-modes-expected.txt:
* css3/flexbox/writing-modes.html:
* fast/dom/offset-position-writing-modes-expected.txt: Added.
* fast/dom/offset-position-writing-modes.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/flexbox/writing-modes-expected.txt
trunk/LayoutTests/css3/flexbox/writing-modes.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp


Added Paths

trunk/LayoutTests/fast/dom/offset-position-writing-modes-expected.txt
trunk/LayoutTests/fast/dom/offset-position-writing-modes.html




Diff

Modified: trunk/LayoutTests/ChangeLog (96151 => 96152)

--- trunk/LayoutTests/ChangeLog	2011-09-27 20:54:16 UTC (rev 96151)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 20:55:00 UTC (rev 96152)
@@ -1,3 +1,15 @@
+2011-09-27  Ojan Vafai  o...@chromium.org
+
+offsetTop/offsetLeft return the wrong values for horizontal-bt/vertical-rl writing modes
+https://bugs.webkit.org/show_bug.cgi?id=68304
+
+Reviewed by David Hyatt.
+
+* css3/flexbox/writing-modes-expected.txt:
+* css3/flexbox/writing-modes.html:
+* fast/dom/offset-position-writing-modes-expected.txt: Added.
+* fast/dom/offset-position-writing-modes.html: Added.
+
 2011-09-27  Tim Horton  timothy_hor...@apple.com
 
 Rapidly refreshing a feMorphology[erode] with r=0 can sometimes cause display corruption


Modified: trunk/LayoutTests/css3/flexbox/writing-modes-expected.txt (96151 => 96152)

--- trunk/LayoutTests/css3/flexbox/writing-modes-expected.txt	2011-09-27 20:54:16 UTC (rev 96151)
+++ trunk/LayoutTests/css3/flexbox/writing-modes-expected.txt	2011-09-27 20:55:00 UTC (rev 96152)
@@ -12,6 +12,6 @@
 PASS
 PASS
 PASS
-Expected 580 for offsetLeft, but got 0. Expected 580 for offsetLeft, but got 0. Expected 580 for offsetLeft, but got 0.
-Expected 580 for offsetLeft, but got 0. Expected 180 for offsetTop, but got 0. Expected 580 for offsetLeft, but got 150. Expected 180 for offsetTop, but got 0. Expected 580 for offsetLeft, but got 450. Expected 180 for offsetTop, but got 0.
+PASS
+PASS
 


Modified: trunk/LayoutTests/css3/flexbox/writing-modes.html (96151 => 96152)

--- trunk/LayoutTests/css3/flexbox/writing-modes.html	2011-09-27 20:54:16 UTC (rev 96151)
+++ trunk/LayoutTests/css3/flexbox/writing-modes.html	2011-09-27 20:55:00 UTC (rev 96152)
@@ -158,7 +158,6 @@
   div data-expected-height=250 style=height: -webkit-flex(1 1 400px);/div
 /div
 
-!-- FIXME: There's a bug where offsetLeft reports the wrong value in vertical-rl writing-mode.--
 div style=position:relative
 div class=flexbox vertical-rl
   div data-expected-height=150 data-offset-y=0 data-offset-x=580 style=height: -webkit-flex(1 0 0);/div
@@ -167,12 +166,11 @@
 /div
 /div
 
-!-- FIXME: There's a bug where offsetTop reports the wrong value in horizontal-bt writing-mode.--
 div style=position:relative
 div class=flexbox bt style=height:200px
-  div data-offset-y=180 data-offset-x=580 style=width: -webkit-flex(1 0 0);/div
-  div data-offset-y=180 data-offset-x=580 style=width: -webkit-flex(2 0 0);/div
-  div data-offset-y=180 data-offset-x=580 style=width: -webkit-flex(1 0 0);/div
+  div data-expected-width=150 data-offset-y=180 data-offset-x=0 style=width: -webkit-flex(1 0 0);/div
+  div data-expected-width=300 data-offset-y=180 data-offset-x=150 style=width: -webkit-flex(2 0 0);/div
+  div data-expected-width=150 data-offset-y=180 data-offset-x=450 style=width: -webkit-flex(1 0 0);/div
 /div
 /div
 


Added: trunk/LayoutTests/fast/dom/offset-position-writing-modes-expected.txt (0 => 96152)

--- trunk/LayoutTests/fast/dom/offset-position-writing-modes-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/offset-position-writing-modes-expected.txt	2011-09-27 20:55:00 UTC (rev 96152)
@@ -0,0 +1,6 @@
+PASS document.getElementById(vertical).offsetLeft is 65
+PASS document.getElementById(horizontal).offsetTop is 65
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Property changes on:

[webkit-changes] [96153] trunk/Tools

2011-09-27 Thread abarth

Title: [96153] trunk/Tools








Revision 96153
Author aba...@webkit.org
Date 2011-09-27 14:02:34 -0700 (Tue, 27 Sep 2011)


Log Message
garden-o-matic examine buttons shows both expected and unexpected failures
https://bugs.webkit.org/show_bug.cgi?id=68918

Reviewed by Dimitri Glazkov.

This was a copy/paste error when I refactored this classes to share
more code.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js
trunk/Tools/ChangeLog


Added Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html (96152 => 96153)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html	2011-09-27 20:55:00 UTC (rev 96152)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html	2011-09-27 21:02:34 UTC (rev 96153)
@@ -65,6 +65,7 @@
 script src=""
 script src=""
 script src=""
+script src=""
 
 !-- FIXME: We should have tests for these files! --
 script src=""


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js (96152 => 96153)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js	2011-09-27 20:55:00 UTC (rev 96152)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js	2011-09-27 21:02:34 UTC (rev 96153)
@@ -100,9 +100,11 @@
 _keyFor: function(failureAnalysis) { throw Not implemented!; },
 _createFailureView: function(failureAnalysis) { throw Not implemented!; },
 
-init: function(view)
+init: function(model, view, delegate)
 {
+this._model = model;
 this._view = view;
+this._delegate = delegate;
 this._testFailures = new base.UpdateTracker();
 },
 update: function(failureAnalysis)
@@ -139,18 +141,13 @@
 
 var testNameList = failures.testNameList();
 var failuresByTest = base.filterDictionary(
-this._resultsFilter(model.state.resultsByBuilder),
+this._resultsFilter(this._model.resultsByBuilder),
 function(key) {
 return testNameList.indexOf(key) != -1;
 });
 
 var controller = new controllers.ResultsDetails(resultsView, failuresByTest);
-
-// FIXME: This doesn't belong here.
-var _onebar_ = $('#onebar')[0];
-var resultsContainer = onebar.results();
-$(resultsContainer).empty().append(resultsView);
-onebar.select('results');
+this._delegate.showResults(resultsView);
 },
 _toFailureInfoList: function(failures)
 {
@@ -167,7 +164,7 @@
 });
 
 controllers.UnexpectedFailures = base.extends(FailureStreamController, {
-_resultsFilter: results.expectedOrUnexpectedFailuresByTest,
+_resultsFilter: results.unexpectedFailuresByTest,
 
 _impliedFirstFailingRevision: function(failureAnalysis)
 {


Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js (0 => 96153)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js	(rev 0)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js	2011-09-27 21:02:34 UTC (rev 96153)
@@ -0,0 +1,69 @@
+/*
+ * Copyright (C) 2011 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING,

[webkit-changes] [96154] trunk

2011-09-27 Thread mitz

Title: [96154] trunk








Revision 96154
Author m...@apple.com
Date 2011-09-27 14:04:04 -0700 (Tue, 27 Sep 2011)


Log Message
rdar://problem/10098679 Assertion failure in RenderLayer::paintPaginatedChildLayer()

Reviewed by Simon Fraser.

Source/WebCore: 

Test: fast/dynamic/layer-no-longer-paginated.html

FrameView::layout() calls adjustViewSize() before calling RenderLayer::updateLayerPositions().
The former may trigger painting with a layer tree that is not entirely up-to-date. Specifically,
the isPaginated() state of a layer may be incorrect, leading to the assertion in this bug. Instead
of asserting, return early and count on the upcoming updateLayerPositions() to repaint as needed.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintPaginatedChildLayer): Replaced the assertion with an early return.

LayoutTests: 

* fast/dynamic/layer-no-longer-paginated-expected.txt: Added.
* fast/dynamic/layer-no-longer-paginated.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp


Added Paths

trunk/LayoutTests/fast/dynamic/layer-no-longer-paginated-expected.txt
trunk/LayoutTests/fast/dynamic/layer-no-longer-paginated.html




Diff

Modified: trunk/LayoutTests/ChangeLog (96153 => 96154)

--- trunk/LayoutTests/ChangeLog	2011-09-27 21:02:34 UTC (rev 96153)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 21:04:04 UTC (rev 96154)
@@ -1,3 +1,12 @@
+2011-09-27  Dan Bernstein  m...@apple.com
+
+rdar://problem/10098679 Assertion failure in RenderLayer::paintPaginatedChildLayer()
+
+Reviewed by Simon Fraser.
+
+* fast/dynamic/layer-no-longer-paginated-expected.txt: Added.
+* fast/dynamic/layer-no-longer-paginated.html: Added.
+
 2011-09-27  Ojan Vafai  o...@chromium.org
 
 offsetTop/offsetLeft return the wrong values for horizontal-bt/vertical-rl writing modes


Added: trunk/LayoutTests/fast/dynamic/layer-no-longer-paginated-expected.txt (0 => 96154)

--- trunk/LayoutTests/fast/dynamic/layer-no-longer-paginated-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dynamic/layer-no-longer-paginated-expected.txt	2011-09-27 21:04:04 UTC (rev 96154)
@@ -0,0 +1,5 @@
+Test for rdar://problem/10098679 Assertion failure in RenderLayer::paintPaginatedChildLayer().
+
+The test passes if it does not cause an assertion failure or a crash.
+
+


Added: trunk/LayoutTests/fast/dynamic/layer-no-longer-paginated.html (0 => 96154)

--- trunk/LayoutTests/fast/dynamic/layer-no-longer-paginated.html	(rev 0)
+++ trunk/LayoutTests/fast/dynamic/layer-no-longer-paginated.html	2011-09-27 21:04:04 UTC (rev 96154)
@@ -0,0 +1,32 @@
+body style=overflow: hidden;
+p
+Test for ia href=""
+Assertion failure in ttRenderLayer::paintPaginatedChildLayer()/tt/i.
+/p
+p
+The test passes if it does not cause an assertion failure or a crash.
+/p
+!-- specifying opacity  1 so that the transition from having columns
+ to not having columns does not cause the layer to go away --
+div id=target style=-webkit-column-count: 2; opacity: 0.5; height: 20px;
+div style=position:relative;/div
+/div
+div id=widener style=height: 10px; width: 200%;/div
+script
+function test()
+{
+document.getElementById(widener).style.removeProperty(width);
+document.getElementById(target).style.removeProperty(-webkit-column-count);
+}
+ 
+   window.scrollBy(1, 0);
+
+if (window.layoutTestController) {
+layoutTestController.display();
+layoutTestController.dumpAsText();
+test();
+} else
+setTimeout(test, 500);
+
+/script
+/body


Modified: trunk/Source/WebCore/ChangeLog (96153 => 96154)

--- trunk/Source/WebCore/ChangeLog	2011-09-27 21:02:34 UTC (rev 96153)
+++ trunk/Source/WebCore/ChangeLog	2011-09-27 21:04:04 UTC (rev 96154)
@@ -1,3 +1,19 @@
+2011-09-27  Dan Bernstein  m...@apple.com
+
+rdar://problem/10098679 Assertion failure in RenderLayer::paintPaginatedChildLayer()
+
+Reviewed by Simon Fraser.
+
+Test: fast/dynamic/layer-no-longer-paginated.html
+
+FrameView::layout() calls adjustViewSize() before calling RenderLayer::updateLayerPositions().
+The former may trigger painting with a layer tree that is not entirely up-to-date. Specifically,
+the isPaginated() state of a layer may be incorrect, leading to the assertion in this bug. Instead
+of asserting, return early and count on the upcoming updateLayerPositions() to repaint as needed.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::paintPaginatedChildLayer): Replaced the assertion with an early return.
+
 2011-09-27  Ojan Vafai  o...@chromium.org
 
 offsetTop/offsetLeft return the wrong values for horizontal-bt/vertical-rl writing modes


Modified:

[webkit-changes] [96155] trunk

2011-09-27 Thread timothy_horton

Title: [96155] trunk








Revision 96155
Author timothy_hor...@apple.com
Date 2011-09-27 14:06:17 -0700 (Tue, 27 Sep 2011)


Log Message
REGRESSION(65665): Pattern size being clamped to SVG size can prevent transformed elements from being fully covered by userSpaceOnUse patterns
https://bugs.webkit.org/show_bug.cgi?id=67700
rdar://problem/10125102

Reviewed by Darin Adler.

Clamp all resources to the same size, 4096x4096 (arbitrarily chosen), instead of to the size
of the svg element. This fixes the case where a transformed element displays part of a resource
outside of the size of the svg element.

When drawing an oversized pattern into its tile image, scale the content down to fit. When drawing
the tile image to the screen, scale it back up to fit the expected area. This will cause pixelation
when patterns are over the 4k limit.

Tests: svg/custom/transformed-pattern-clamp-svg-root.svg, svg/custom/oversized-pattern-scale.svg

* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
* rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::createMaskAndSwapContextForTextGradient):
(WebCore::clipToTextMask):
* rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
(WebCore::RenderSVGResourcePattern::createTileImage):
* rendering/svg/RenderSVGResourcePattern.h:
* rendering/svg/SVGImageBufferTools.cpp:
(WebCore::SVGImageBufferTools::clampedAbsoluteTargetRect):
* rendering/svg/SVGImageBufferTools.h:

pattern-excessive-malloc is so excessive that it runs into the floating point precision barrier
when determining the scale to draw the pattern at; drop the size two orders of magnitude, which is 
still very excessive but easier to draw with.

Add a test (transformed-pattern-clamp-svg-root.svg) that ensures that patterns on transformed
elements are displayed correctly, instead of being clamped to the size of the svg element.

Add a test (oversized-pattern-scale.svg) that ensures that oversized patterns are correctly drawn
into the pattern tile scaled down and then are scaled back up when drawn to the screen.

* platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
* platform/mac/svg/custom/pattern-excessive-malloc-expected.txt:
* platform/qt/svg/custom/pattern-excessive-malloc-expected.txt:
* svg/custom/pattern-excessive-malloc-expected.txt:
* svg/custom/pattern-excessive-malloc.svg:
* svg/custom/oversized-pattern-scale-expected.png: Added.
* svg/custom/oversized-pattern-scale-expected.txt: Added.
* svg/custom/oversized-pattern-scale.svg: Added.
* svg/custom/transformed-pattern-clamp-svg-root.svg: Added.
* svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
* svg/custom/transformed-pattern-clamp-svg-root-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png
trunk/LayoutTests/platform/mac/svg/custom/pattern-excessive-malloc-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/pattern-excessive-malloc-expected.txt
trunk/LayoutTests/svg/custom/pattern-excessive-malloc-expected.txt
trunk/LayoutTests/svg/custom/pattern-excessive-malloc.svg
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.h
trunk/Source/WebCore/rendering/svg/SVGImageBufferTools.cpp
trunk/Source/WebCore/rendering/svg/SVGImageBufferTools.h


Added Paths

trunk/LayoutTests/svg/custom/oversized-pattern-scale-expected.png
trunk/LayoutTests/svg/custom/oversized-pattern-scale-expected.txt
trunk/LayoutTests/svg/custom/oversized-pattern-scale.svg
trunk/LayoutTests/svg/custom/transformed-pattern-clamp-svg-root-expected.png
trunk/LayoutTests/svg/custom/transformed-pattern-clamp-svg-root-expected.txt
trunk/LayoutTests/svg/custom/transformed-pattern-clamp-svg-root.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (96154 => 96155)

--- trunk/LayoutTests/ChangeLog	2011-09-27 21:04:04 UTC (rev 96154)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 21:06:17 UTC (rev 96155)
@@ -1,3 +1,33 @@
+2011-09-27  Tim Horton  timothy_hor...@apple.com
+
+REGRESSION(65665): Pattern size being clamped to SVG size can prevent transformed elements from being fully covered by userSpaceOnUse patterns
+https://bugs.webkit.org/show_bug.cgi?id=67700
+rdar://problem/10125102
+
+Reviewed by Darin Adler.
+
+pattern-excessive-malloc is so excessive that it runs into the floating point precision barrier
+when determining the scale to draw the pattern at; drop the size two orders of magnitude, which is 
+still very excessive but

[webkit-changes] [96157] trunk

2011-09-27 Thread commit-queue

Title: [96157] trunk








Revision 96157
Author commit-qu...@webkit.org
Date 2011-09-27 14:19:16 -0700 (Tue, 27 Sep 2011)


Log Message
Unreviewed, rolling out r96139.
http://trac.webkit.org/changeset/96139
https://bugs.webkit.org/show_bug.cgi?id=68933

Broke table-percent-height.html on Mac bots (Requested by
mwenge2 on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2011-09-27

Source/WebCore:

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
* rendering/RenderBox.h:

LayoutTests:

* fast/replaced/table-percent-width-expected.txt: Removed.
* fast/replaced/table-percent-width.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h


Removed Paths

trunk/LayoutTests/fast/replaced/table-percent-width-expected.txt
trunk/LayoutTests/fast/replaced/table-percent-width.html




Diff

Modified: trunk/LayoutTests/ChangeLog (96156 => 96157)

--- trunk/LayoutTests/ChangeLog	2011-09-27 21:12:28 UTC (rev 96156)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 21:19:16 UTC (rev 96157)
@@ -1,3 +1,15 @@
+2011-09-27  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r96139.
+http://trac.webkit.org/changeset/96139
+https://bugs.webkit.org/show_bug.cgi?id=68933
+
+Broke table-percent-height.html on Mac bots (Requested by
+mwenge2 on #webkit).
+
+* fast/replaced/table-percent-width-expected.txt: Removed.
+* fast/replaced/table-percent-width.html: Removed.
+
 2011-09-27  Mike Reed  r...@google.com
 
 need to rebseline these once new aa-gdi-text code lands in skia


Deleted: trunk/LayoutTests/fast/replaced/table-percent-width-expected.txt (96156 => 96157)

--- trunk/LayoutTests/fast/replaced/table-percent-width-expected.txt	2011-09-27 21:12:28 UTC (rev 96156)
+++ trunk/LayoutTests/fast/replaced/table-percent-width-expected.txt	2011-09-27 21:19:16 UTC (rev 96157)
@@ -1,25 +0,0 @@
-
-
-
-
-
-This test checks that a replaced element with percentage width (and no height specified) within a table cell is squeezed to the dimensions of the table cell.
-See bug #29447.
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-
-PASS getWidth('img-1') is '105px'
-PASS getHeight('img-1') is '105px'
-PASS getWidth('img-2') is '98px'
-PASS getHeight('img-2') is '98px'
-PASS getWidth('img-3') is '40px'
-PASS getHeight('img-3') is '40px'
-PASS getWidth('img-4') is '36px'
-PASS getHeight('img-4') is '36px'
-PASS getWidth('img-5') is '40px'
-PASS getHeight('img-5') is '36px'
-PASS successfullyParsed is true
-
-TEST COMPLETE
-


Deleted: trunk/LayoutTests/fast/replaced/table-percent-width.html (96156 => 96157)

--- trunk/LayoutTests/fast/replaced/table-percent-width.html	2011-09-27 21:12:28 UTC (rev 96156)
+++ trunk/LayoutTests/fast/replaced/table-percent-width.html	2011-09-27 21:19:16 UTC (rev 96157)
@@ -1,115 +0,0 @@
-html
-head
-title webkit.org/b/29447: Replaced elements squeezed when width is specified as percentage inside a table with Auto layout/title
-link rel=stylesheet href=""
-script src=""
-script src=""
-script
-if (window.layoutTestController) {
-layoutTestController.waitUntilDone();
-layoutTestController.dumpAsText();
-}
-
-function getComputedStyleForElement(element, cssPropertyName)
-{
-if (!element) {
-return null;
-}
-if (window.getComputedStyle) {
-return window.getComputedStyle(element, '').getPropertyValue(cssPropertyName.replace(/([A-Z])/g, -$1).toLowerCase());
-}
-if (element.currentStyle) {
-return element.currentStyle[cssPropertyName];
-}
-return null;
-}
-
-function getWidth(id)
-{
-return getComputedStyleForElement(document.getElementById(id), 'width');
-}
-
-function getHeight(id)
-{
-return getComputedStyleForElement(document.getElementById(id), 'height');
-}
-
-function parsePixelValue(str)
-{
-if (typeof str != string || str.length  3 || str.substr(str.length - 2) != px) {
-testFailed(str +  is unparsable.);
-return -1;
-}
-return parseFloat(str);
-}
-
-function test()
-{
-description(This test checks that a replaced element with percentage width (and no height specified) within a table cell is squeezed to the dimensions of the table cell.brSee bug #29447.);
-
-shouldBe(getWidth('img-1'), '105px');
-shouldBe(getHeight('img-1'), '105px');
-shouldBe(getWidth('img-2'), '98px');
-shouldBe(getHeight('img-2'), '98px');
-shouldBe(getWidth('img-3'), '40px');
-shouldBe(getHeight('img-3'), '40px');
-shouldBe(getWidth('img-4'), '36px');
-shouldBe(getHeight('img-4'), '36px');
-shouldBe(getWidth('img-5'), '40px');
-shouldBe(getHeight('img-5'), '36px');
-
-isSuccessfullyParsed();
-
-if (window.layoutTestController) {
-

[webkit-changes] [96158] trunk/LayoutTests

2011-09-27 Thread mihaip

Title: [96158] trunk/LayoutTests








Revision 96158
Author mih...@chromium.org
Date 2011-09-27 14:25:17 -0700 (Tue, 27 Sep 2011)


Log Message
Chromium test expectations update.

Make new fast/canvas/canvas-composite.html GPU expectation more specific,
since on Leopard it was conflicting with an older one.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96157 => 96158)

--- trunk/LayoutTests/ChangeLog	2011-09-27 21:19:16 UTC (rev 96157)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 21:25:17 UTC (rev 96158)
@@ -1,3 +1,12 @@
+2011-09-27  Mihai Parparita  mih...@chromium.org
+
+Chromium test expectations update.
+
+Make new fast/canvas/canvas-composite.html GPU expectation more specific,
+since on Leopard it was conflicting with an older one.
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-27  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r96139.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96157 => 96158)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 21:19:16 UTC (rev 96157)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 21:25:17 UTC (rev 96158)
@@ -3794,4 +3794,4 @@
 BUGWK68886 MAC GPU-CG : compositing/geometry/limit-layer-bounds-transformed-overflow.html = TEXT
 
 BUGWK68895 MAC WIN GPU : fast/canvas/canvas-composite-transformclip.html = IMAGE
-BUGWK68895 MAC WIN GPU : fast/canvas/canvas-composite.html = IMAGE
+BUGWK68895 SNOWLEOPARD WIN GPU : fast/canvas/canvas-composite.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96160] trunk

2011-09-27 Thread commit-queue

Title: [96160] trunk








Revision 96160
Author commit-qu...@webkit.org
Date 2011-09-27 14:47:30 -0700 (Tue, 27 Sep 2011)


Log Message
Add a mechanism to test for the compositing tree mutated during painting
https://bugs.webkit.org/show_bug.cgi?id=68738

Patch by James Robinson jam...@chromium.org on 2011-09-27
Reviewed by Adam Barth.

Source/WebCore:

Sets a static bool during GraphicsLayer::paintGraphicsLayerContents and ASSERT()s that we never create or
destroy a GraphicsLayer inside this function. Painting should never mutate the GraphicsLayer tree.

Test: compositing/video/video-with-invalid-source.html

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::~GraphicsLayer):
(WebCore::GraphicsLayer::paintGraphicsLayerContents):

LayoutTests:

Adds a test that caused compositing to be disabled during painting before r95863 due to a video load failing.

* compositing/video/video-with-invalid-source-expected.txt: Added.
* compositing/video/video-with-invalid-source.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp


Added Paths

trunk/LayoutTests/compositing/video/video-with-invalid-source-expected.txt
trunk/LayoutTests/compositing/video/video-with-invalid-source.html




Diff

Modified: trunk/LayoutTests/ChangeLog (96159 => 96160)

--- trunk/LayoutTests/ChangeLog	2011-09-27 21:45:54 UTC (rev 96159)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 21:47:30 UTC (rev 96160)
@@ -1,3 +1,15 @@
+2011-09-27  James Robinson  jam...@chromium.org
+
+Add a mechanism to test for the compositing tree mutated during painting
+https://bugs.webkit.org/show_bug.cgi?id=68738
+
+Reviewed by Adam Barth.
+
+Adds a test that caused compositing to be disabled during painting before r95863 due to a video load failing.
+
+* compositing/video/video-with-invalid-source-expected.txt: Added.
+* compositing/video/video-with-invalid-source.html: Added.
+
 2011-09-27  Ojan Vafai  o...@chromium.org
 
 take padding/border on flexbox into account with direction:rtl


Added: trunk/LayoutTests/compositing/video/video-with-invalid-source-expected.txt (0 => 96160)

--- trunk/LayoutTests/compositing/video/video-with-invalid-source-expected.txt	(rev 0)
+++ trunk/LayoutTests/compositing/video/video-with-invalid-source-expected.txt	2011-09-27 21:47:30 UTC (rev 96160)
@@ -0,0 +1 @@
+PASS


Added: trunk/LayoutTests/compositing/video/video-with-invalid-source.html (0 => 96160)

--- trunk/LayoutTests/compositing/video/video-with-invalid-source.html	(rev 0)
+++ trunk/LayoutTests/compositing/video/video-with-invalid-source.html	2011-09-27 21:47:30 UTC (rev 96160)
@@ -0,0 +1,25 @@
+!DOCTYPE html
+script
+if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
+layoutTestController.dumpAsText();
+}
+
+function test() {
+var v = document.createElement(video);
+document.body.appendChild(v);
+var src = ""
+src.src = ""
+v.appendChild(src);
+src.addEventListener(error, function() {
+   if (window.layoutTestController) {
+layoutTestController.display();
+// If we didn't crash here, yay!  Test is a success
+document.body.appendChild(document.createTextNode(PASS));
+layoutTestController.notifyDone();
+}
+}, false);
+}
+/script
+body _onload_=test()
+/body


Modified: trunk/Source/WebCore/ChangeLog (96159 => 96160)

--- trunk/Source/WebCore/ChangeLog	2011-09-27 21:45:54 UTC (rev 96159)
+++ trunk/Source/WebCore/ChangeLog	2011-09-27 21:47:30 UTC (rev 96160)
@@ -1,3 +1,20 @@
+2011-09-27  James Robinson  jam...@chromium.org
+
+Add a mechanism to test for the compositing tree mutated during painting
+https://bugs.webkit.org/show_bug.cgi?id=68738
+
+Reviewed by Adam Barth.
+
+Sets a static bool during GraphicsLayer::paintGraphicsLayerContents and ASSERT()s that we never create or
+destroy a GraphicsLayer inside this function. Painting should never mutate the GraphicsLayer tree.
+
+Test: compositing/video/video-with-invalid-source.html
+
+* platform/graphics/GraphicsLayer.cpp:
+(WebCore::GraphicsLayer::GraphicsLayer):
+(WebCore::GraphicsLayer::~GraphicsLayer):
+(WebCore::GraphicsLayer::paintGraphicsLayerContents):
+
 2011-09-27  Ojan Vafai  o...@chromium.org
 
 take padding/border on flexbox into account with direction:rtl


Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp (96159 => 96160)

--- trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp	2011-09-27 21:45:54 UTC (rev 96159)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp	2011-09-27 21:47:30 UTC (rev 96160)
@@ -61,6 +61,10 @@
 m_values.append(value);
 }
 
+#ifndef NDEBUG
+static bool s_inPaintContents = false;
+#endif
+

[webkit-changes] [96162] trunk

2011-09-27 Thread hyatt

Title: [96162] trunk








Revision 96162
Author hy...@apple.com
Date 2011-09-27 15:11:41 -0700 (Tue, 27 Sep 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=68940

Narrow the float/lines pagination heuristic to only kick in if
the previous line broke cleanly and if the floats are occurring
at the start of the line.

Reviewed by Dan Bernstein.

Source/WebCore: 

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::positionNewFloatOnLine):

LayoutTests: 

* fast/regions/webkit-flow-float-pushed-to-last-region.html:
* platform/mac/fast/multicol/float-paginate-empty-lines-expected.txt: Added.
* platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/regions/webkit-flow-float-pushed-to-last-region.html
trunk/LayoutTests/platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp


Added Paths

trunk/LayoutTests/platform/mac/fast/multicol/float-paginate-empty-lines-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96161 => 96162)

--- trunk/LayoutTests/ChangeLog	2011-09-27 22:04:21 UTC (rev 96161)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 22:11:41 UTC (rev 96162)
@@ -1,3 +1,17 @@
+2011-09-27  David Hyatt  hy...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=68940
+
+Narrow the float/lines pagination heuristic to only kick in if
+the previous line broke cleanly and if the floats are occurring
+at the start of the line.
+
+Reviewed by Dan Bernstein.
+
+* fast/regions/webkit-flow-float-pushed-to-last-region.html:
+* platform/mac/fast/multicol/float-paginate-empty-lines-expected.txt: Added.
+* platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt:
+
 2011-09-27  James Robinson  jam...@chromium.org
 
 Add a mechanism to test for the compositing tree mutated during painting


Modified: trunk/LayoutTests/fast/regions/webkit-flow-float-pushed-to-last-region.html (96161 => 96162)

--- trunk/LayoutTests/fast/regions/webkit-flow-float-pushed-to-last-region.html	2011-09-27 22:04:21 UTC (rev 96161)
+++ trunk/LayoutTests/fast/regions/webkit-flow-float-pushed-to-last-region.html	2011-09-27 22:11:41 UTC (rev 96162)
@@ -47,7 +47,7 @@
 div id=content
 div id=first-box
 div id=second-box
-pThis line of text img id=float1 should not get out of the  region. This line of text should not get out of the region. This line of text should not get out of the region. This line of text should not get out of the region./p
+p img id=float1 This line of text should not get out of the  region. This line of text should not get out of the region. This line of text should not get out of the region. This line of text should not get out of the region./p
 pThis line of text should not get out of the region. This line of text should not get out of the region. This line of text should not get out of the region. This line of text should not get out of the region./p
 pThis line of text should not get out of the region./p
 /div


Added: trunk/LayoutTests/platform/mac/fast/multicol/float-paginate-empty-lines-expected.txt (0 => 96162)

--- trunk/LayoutTests/platform/mac/fast/multicol/float-paginate-empty-lines-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/fast/multicol/float-paginate-empty-lines-expected.txt	2011-09-27 22:11:41 UTC (rev 96162)
@@ -0,0 +1,51 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+  RenderBlock {P} at (0,0) size 784x54
+RenderText {#text} at (0,0) size 764x54
+  text run at (0,0) width 764: This test is ensuring we don't grow the height of a block improperly when a float has no line association (e.g., when it's at
+  text run at (0,18) width 741: the end of a block). The complete dashed border should be in the first column, with none of it appearing in the second
+  text run at (0,36) width 51: column.
+layer at (8,78) size 784x400
+  RenderBlock {DIV} at (0,70) size 784x400
+RenderBlock {DIV} at (0,0) size 384x236 [border: (10px dashed #80)]
+  RenderText {#text} at (10,10) size 110x18
+text run at (10,10) width 110: This is some text.
+  RenderBR {BR} at (120,24) size 0x0
+  RenderText {#text} at (10,28) size 110x18
+text run at (10,28) width 110: This is some text.
+  RenderBR {BR} at (120,42) size 0x0
+  RenderText {#text} at (10,46) size 110x18
+text run at (10,46) width 110: This is some text.
+  RenderBR {BR} at (120,60) size 0x0
+  RenderText {#text} at (10,64) size 110x18
+text run at (10,64) width 110: This is some text.
+  RenderBR {BR} at (120,78)

[webkit-changes] [96165] trunk/LayoutTests

2011-09-27 Thread mihaip

Title: [96165] trunk/LayoutTests








Revision 96165
Author mih...@chromium.org
Date 2011-09-27 15:53:56 -0700 (Tue, 27 Sep 2011)


Log Message
Chromium rebaseline after r96155.

* platform/chromium-cg-mac/svg/custom/pattern-excessive-malloc-expected.png: Added.
* platform/chromium-linux/svg/custom/oversized-pattern-scale-expected.png: Added.
* platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
* platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png: Added.
* platform/chromium-win/svg/custom/pattern-excessive-malloc-expected.png:
* platform/chromium-win/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
* platform/chromium/svg/custom/oversized-pattern-scale-expected.png: Added.
* platform/mac/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
* platform/qt/svg/custom/pattern-excessive-malloc-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win/svg/custom/pattern-excessive-malloc-expected.png


Added Paths

trunk/LayoutTests/platform/chromium/svg/custom/oversized-pattern-scale-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/pattern-excessive-malloc-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/custom/oversized-pattern-scale-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png
trunk/LayoutTests/platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png
trunk/LayoutTests/platform/chromium-win/svg/custom/transformed-pattern-clamp-svg-root-expected.png


Removed Paths

trunk/LayoutTests/platform/mac/svg/custom/pattern-excessive-malloc-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/pattern-excessive-malloc-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96164 => 96165)

--- trunk/LayoutTests/ChangeLog	2011-09-27 22:46:51 UTC (rev 96164)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 22:53:56 UTC (rev 96165)
@@ -1,3 +1,17 @@
+2011-09-27  Mihai Parparita  mih...@chromium.org
+
+Chromium rebaseline after r96155.
+
+* platform/chromium-cg-mac/svg/custom/pattern-excessive-malloc-expected.png: Added.
+* platform/chromium-linux/svg/custom/oversized-pattern-scale-expected.png: Added.
+* platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
+* platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png: Added.
+* platform/chromium-win/svg/custom/pattern-excessive-malloc-expected.png:
+* platform/chromium-win/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
+* platform/chromium/svg/custom/oversized-pattern-scale-expected.png: Added.
+* platform/mac/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
+* platform/qt/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
+
 2011-09-27  David Hyatt  hy...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=68940


Added: trunk/LayoutTests/platform/chromium/svg/custom/oversized-pattern-scale-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium/svg/custom/oversized-pattern-scale-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/pattern-excessive-malloc-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/pattern-excessive-malloc-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-linux/svg/custom/oversized-pattern-scale-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-linux/svg/custom/oversized-pattern-scale-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png
___

Added: svn:mime-type

Modified: trunk/LayoutTests/platform/chromium-win/svg/custom/pattern-excessive-malloc-expected.png

(Binary files differ)


Added: trunk/LayoutTests/platform/chromium-win/svg/custom/transformed-pattern-clamp-svg-root-expected.png

(Binary files differ)

Property changes on:

[webkit-changes] [96169] trunk/Source/JavaScriptCore

2011-09-27 Thread barraclough

Title: [96169] trunk/Source/_javascript_Core








Revision 96169
Author barraclo...@apple.com
Date 2011-09-27 16:32:23 -0700 (Tue, 27 Sep 2011)


Log Message
Macro assembler branch8  16 methods vary in treatment of upper bits
https://bugs.webkit.org/show_bug.cgi?id=68301

Reviewed by Sam Weinig.

Fix for branch16 - remove it!
No performance impact.

* assembler/MacroAssembler.h:
* assembler/MacroAssemblerARM.h:
* assembler/MacroAssemblerARMv7.h:
* assembler/MacroAssemblerMIPS.h:
* assembler/MacroAssemblerSH4.h:
* assembler/MacroAssemblerX86Common.h:
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssembler.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h
trunk/Source/_javascript_Core/yarr/YarrJIT.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (96168 => 96169)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-27 23:24:53 UTC (rev 96168)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-27 23:32:23 UTC (rev 96169)
@@ -1,3 +1,26 @@
+2011-09-24  Gavin Barraclough  barraclo...@apple.com
+
+Macro assembler branch8  16 methods vary in treatment of upper bits
+https://bugs.webkit.org/show_bug.cgi?id=68301
+
+Reviewed by Sam Weinig.
+
+Fix for branch16 - remove it!
+No performance impact.
+
+* assembler/MacroAssembler.h:
+* assembler/MacroAssemblerARM.h:
+* assembler/MacroAssemblerARMv7.h:
+* assembler/MacroAssemblerMIPS.h:
+* assembler/MacroAssemblerSH4.h:
+* assembler/MacroAssemblerX86Common.h:
+* yarr/YarrJIT.cpp:
+(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
+(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
+(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
+(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
+(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
+
 2011-09-27  Mark Hahnenberg  mhahnenb...@apple.com
 
 Add static version of JSCell::getCallData


Modified: trunk/Source/_javascript_Core/assembler/MacroAssembler.h (96168 => 96169)

--- trunk/Source/_javascript_Core/assembler/MacroAssembler.h	2011-09-27 23:24:53 UTC (rev 96168)
+++ trunk/Source/_javascript_Core/assembler/MacroAssembler.h	2011-09-27 23:32:23 UTC (rev 96169)
@@ -69,7 +69,6 @@
 using MacroAssemblerBase::pop;
 using MacroAssemblerBase::jump;
 using MacroAssemblerBase::branch32;
-using MacroAssemblerBase::branch16;
 #if CPU(X86_64)
 using MacroAssemblerBase::branchPtr;
 using MacroAssemblerBase::branchTestPtr;
@@ -130,11 +129,6 @@
 return branch32(commute(cond), right, left);
 }
 
-void branch16(RelationalCondition cond, BaseIndex left, RegisterID right, Label target)
-{
-branch16(cond, left, right).linkTo(target, this);
-}
-
 void branchTestPtr(ResultCondition cond, RegisterID reg, Label target)
 {
 branchTestPtr(cond, reg).linkTo(target, this);


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (96168 => 96169)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2011-09-27 23:24:53 UTC (rev 96168)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2011-09-27 23:32:23 UTC (rev 96169)
@@ -426,15 +426,6 @@
 return branch32(cond, ARMRegisters::S1, right);
 }
 
-Jump branch16(RelationalCondition cond, RegisterID left, TrustedImm32 right)
-{
-ASSERT(!(right.m_value  0x));
-right.m_value = 16;
-m_assembler.mov_r(ARMRegisters::S1, left);
-lshift32(TrustedImm32(16), ARMRegisters::S1);
-return branch32(cond, ARMRegisters::S1, right);
-}
-
 Jump branch32(RelationalCondition cond, RegisterID left, RegisterID right, int useConstantPool = 0)
 {
 m_assembler.cmp_r(left, right);
@@ -486,23 +477,6 @@
 return branch32(cond, ARMRegisters::S1, right);
 }
 
-Jump branch16(RelationalCondition cond, BaseIndex left, RegisterID right)
-{
-UNUSED_PARAM(cond);
-UNUSED_PARAM(left);
-UNUSED_PARAM(right);
-ASSERT_NOT_REACHED();
-return jump();
-}
-
-Jump branch16(RelationalCondition cond, BaseIndex left, TrustedImm32 right)
-{
-load16(left, ARMRegisters::S0);
-move(right, ARMRegisters::S1);
-m_assembler.cmp_r(ARMRegisters::S0,

[webkit-changes] [96170] trunk/Tools

2011-09-27 Thread levin

Title: [96170] trunk/Tools








Revision 96170
Author le...@chromium.org
Date 2011-09-27 16:42:12 -0700 (Tue, 27 Sep 2011)


Log Message
watchlist: Add support for cc and message rules.
https://bugs.webkit.org/show_bug.cgi?id=68950

Reviewed by Adam Barth.

* Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
the cc's and messages for a patch.
* Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
* Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
for the rules.
* Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
A generic encapsulation of either a message list or a cc list.
* Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/watchlist/watchlist.py
trunk/Tools/Scripts/webkitpy/common/watchlist/watchlist_unittest.py
trunk/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py


Added Paths

trunk/Tools/Scripts/webkitpy/common/watchlist/watchlistrule.py
trunk/Tools/Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (96169 => 96170)

--- trunk/Tools/ChangeLog	2011-09-27 23:32:23 UTC (rev 96169)
+++ trunk/Tools/ChangeLog	2011-09-27 23:42:12 UTC (rev 96170)
@@ -1,3 +1,19 @@
+2011-09-27  David Levin  le...@chromium.org
+
+watchlist: Add support for cc and message rules.
+https://bugs.webkit.org/show_bug.cgi?id=68950
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
+the cc's and messages for a patch.
+* Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
+* Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
+for the rules.
+* Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
+A generic encapsulation of either a message list or a cc list.
+* Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
+
 2011-09-27  Tom Zakrajsek  t...@codeaurora.org
 
 webkit-patch doesn't like UTF-8 characters in reviewers names


Modified: trunk/Tools/Scripts/webkitpy/common/watchlist/watchlist.py (96169 => 96170)

--- trunk/Tools/Scripts/webkitpy/common/watchlist/watchlist.py	2011-09-27 23:32:23 UTC (rev 96169)
+++ trunk/Tools/Scripts/webkitpy/common/watchlist/watchlist.py	2011-09-27 23:42:12 UTC (rev 96170)
@@ -28,13 +28,22 @@
 
 from webkitpy.common.checkout.diff_parser import DiffParser
 
+
 class WatchList(object):
 def __init__(self):
 self._definitions = {}
+self._cc_rules = set()
+self._message_rules = set()
 
 def set_definitions(self, definitions):
 self._definitions = definitions
 
+def set_cc_rules(self, cc_rules):
+self._cc_rules = cc_rules
+
+def set_message_rules(self, message_rules):
+self._message_rules = message_rules
+
 def find_matching_definitions(self, diff):
 matching_definitions = set()
 patch_files = DiffParser(diff.splitlines()).files
@@ -52,3 +61,23 @@
 else:
 matching_definitions.add(definition)
 return matching_definitions
+
+def _determine_instructions(self, matching_definitions, rules):
+instructions = set()
+for rule in rules:
+if rule.match(matching_definitions):
+instructions.update(rule.instructions())
+return instructions
+
+def determine_cc_set(self, matching_definitions):
+return self._determine_instructions(matching_definitions, self._cc_rules)
+
+def determine_messages(self, matching_definitions):
+return self._determine_instructions(matching_definitions, self._message_rules)
+
+def determine_cc_set_and_messages(self, diff):
+definitions = self.find_matching_definitions(diff)
+return {
+'cc_set': self.determine_cc_set(definitions),
+'messages':  self.determine_messages(definitions),
+}


Modified: trunk/Tools/Scripts/webkitpy/common/watchlist/watchlist_unittest.py (96169 => 96170)

--- trunk/Tools/Scripts/webkitpy/common/watchlist/watchlist_unittest.py	2011-09-27 23:32:23 UTC (rev 96169)
+++ trunk/Tools/Scripts/webkitpy/common/watchlist/watchlist_unittest.py	2011-09-27 23:42:12 UTC (rev 96170)
@@ -34,7 +34,7 @@
 from webkitpy.common.watchlist.watchlistparser import WatchListParser
 
 
-class WatchListParserTest(unittest.TestCase):
+class WatchListTest(unittest.TestCase):
 def setUp(self):
 self._watch_list_parser = WatchListParser()
 
@@ -59,3 +59,83 @@
 ' },'
 '}')
 self.assertEquals(set(['WatchList1']),

[webkit-changes] [96171] trunk/Source/JavaScriptCore

2011-09-27 Thread barraclough

Title: [96171] trunk/Source/_javascript_Core








Revision 96171
Author barraclo...@apple.com
Date 2011-09-27 16:48:49 -0700 (Tue, 27 Sep 2011)


Log Message
Bug fixes for GetById, PutById, and GetByOffset in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68755

Patch by Yuqiang Xian yuqiang.x...@intel.com on 2011-09-27
Reviewed by Gavin Barraclough.

We need to load/store and repatch both tag and payload of a property
for GetById/PutById. Also reorder the loads of tag and payload for
GetByOffset as the result tag GPR could reuse the storage GPR.

* bytecode/StructureStubInfo.h:
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchByIdSelfAccess):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.h
trunk/Source/_javascript_Core/dfg/DFGJITCompiler32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGRepatch.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (96170 => 96171)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-27 23:42:12 UTC (rev 96170)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-27 23:48:49 UTC (rev 96171)
@@ -1,3 +1,28 @@
+2011-09-27  Yuqiang Xian  yuqiang.x...@intel.com
+
+Bug fixes for GetById, PutById, and GetByOffset in JSVALUE32_64 DFG JIT
+https://bugs.webkit.org/show_bug.cgi?id=68755
+
+Reviewed by Gavin Barraclough.
+
+We need to load/store and repatch both tag and payload of a property
+for GetById/PutById. Also reorder the loads of tag and payload for
+GetByOffset as the result tag GPR could reuse the storage GPR.
+
+* bytecode/StructureStubInfo.h:
+* dfg/DFGJITCodeGenerator32_64.cpp:
+(JSC::DFG::JITCodeGenerator::cachedGetById):
+(JSC::DFG::JITCodeGenerator::cachedPutById):
+* dfg/DFGJITCompiler.h:
+(JSC::DFG::JITCompiler::addPropertyAccess):
+(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
+* dfg/DFGJITCompiler32_64.cpp:
+(JSC::DFG::JITCompiler::link):
+* dfg/DFGRepatch.cpp:
+(JSC::DFG::dfgRepatchByIdSelfAccess):
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
 2011-09-24  Gavin Barraclough  barraclo...@apple.com
 
 Macro assembler branch8  16 methods vary in treatment of upper bits


Modified: trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h (96170 => 96171)

--- trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h	2011-09-27 23:42:12 UTC (rev 96170)
+++ trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h	2011-09-27 23:48:49 UTC (rev 96171)
@@ -147,7 +147,12 @@
 union {
 struct {
 int16_t deltaCheckImmToCall;
+#if USE(JSVALUE64)
 int16_t deltaCallToLoadOrStore;
+#elif USE(JSVALUE32_64)
+int16_t deltaCallToTagLoadOrStore;
+int16_t deltaCallToPayloadLoadOrStore;
+#endif
 } unset;
 struct {
 WriteBarrierBaseStructure baseObjectStructure;


Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp (96170 => 96171)

--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp	2011-09-27 23:42:12 UTC (rev 96170)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp	2011-09-27 23:48:49 UTC (rev 96171)
@@ -1175,8 +1175,8 @@
 JITCompiler::Jump structureCheck = m_jit.branchPtrWithPatch(JITCompiler::NotEqual, JITCompiler::Address(basePayloadGPR, JSCell::structureOffset()), structureToCompare, JITCompiler::TrustedImmPtr(reinterpret_castvoid*(-1)));
 
 m_jit.loadPtr(JITCompiler::Address(basePayloadGPR, JSObject::offsetOfPropertyStorage()), resultPayloadGPR);
-JITCompiler::DataLabelCompact loadWithPatch = m_jit.loadPtrWithCompactAddressOffsetPatch(JITCompiler::Address(resultPayloadGPR, 0), resultPayloadGPR);
-m_jit.move(TrustedImm32(JSValue::CellTag), resultTagGPR);
+JITCompiler::DataLabelCompact tagLoadWithPatch = m_jit.load32WithCompactAddressOffsetPatch(JITCompiler::Address(resultPayloadGPR, OBJECT_OFFSETOF(EncodedValueDescriptor, asBits.tag)), resultTagGPR);
+JITCompiler::DataLabelCompact payloadLoadWithPatch = m_jit.load32WithCompactAddressOffsetPatch(JITCompiler::Address(resultPayloadGPR, OBJECT_OFFSETOF(EncodedValueDescriptor, asBits.payload)), resultPayloadGPR);
 
 JITCompiler::Jump done = m_jit.jump();
 
@@ -1215,11

[webkit-changes] [96184] trunk/Source/JavaScriptCore

2011-09-27 Thread fpizlo

Title: [96184] trunk/Source/_javascript_Core








Revision 96184
Author fpi...@apple.com
Date 2011-09-27 20:39:36 -0700 (Tue, 27 Sep 2011)


Log Message
DFG JIT should speculate more aggressively on reads of array.length
https://bugs.webkit.org/show_bug.cgi?id=68932

Reviewed by Oliver Hunt.

This is a 2% speed-up on Kraken, neutral elsewhere.

* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGNode.h
trunk/Source/_javascript_Core/dfg/DFGPropagator.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (96183 => 96184)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-28 03:37:23 UTC (rev 96183)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-28 03:39:36 UTC (rev 96184)
@@ -1,3 +1,20 @@
+2011-09-27  Filip Pizlo  fpi...@apple.com
+
+DFG JIT should speculate more aggressively on reads of array.length
+https://bugs.webkit.org/show_bug.cgi?id=68932
+
+Reviewed by Oliver Hunt.
+
+This is a 2% speed-up on Kraken, neutral elsewhere.
+
+* dfg/DFGNode.h:
+* dfg/DFGPropagator.cpp:
+(JSC::DFG::Propagator::propagateNodePredictions):
+(JSC::DFG::Propagator::fixupNode):
+(JSC::DFG::Propagator::performNodeCSE):
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
 2011-09-27  Gavin Barraclough  barraclo...@apple.com
 
 DFG JIT - merge changes between 95905 - 96175


Modified: trunk/Source/_javascript_Core/dfg/DFGNode.h (96183 => 96184)

--- trunk/Source/_javascript_Core/dfg/DFGNode.h	2011-09-28 03:37:23 UTC (rev 96183)
+++ trunk/Source/_javascript_Core/dfg/DFGNode.h	2011-09-28 03:39:36 UTC (rev 96184)
@@ -266,6 +266,7 @@
 macro(PutByIdDirect, NodeMustGenerate | NodeClobbersWorld) \
 macro(CheckStructure, NodeResultStorage | NodeMustGenerate) \
 macro(GetByOffset, NodeResultJS) \
+macro(GetArrayLength, NodeResultInt32) \
 macro(GetMethod, NodeResultJS | NodeMustGenerate) \
 macro(CheckMethod, NodeResultJS | NodeMustGenerate) \
 macro(GetScopeChain, NodeResultJS) \


Modified: trunk/Source/_javascript_Core/dfg/DFGPropagator.cpp (96183 => 96184)

--- trunk/Source/_javascript_Core/dfg/DFGPropagator.cpp	2011-09-28 03:37:23 UTC (rev 96183)
+++ trunk/Source/_javascript_Core/dfg/DFGPropagator.cpp	2011-09-28 03:39:36 UTC (rev 96184)
@@ -375,13 +375,6 @@
 break;
 }
 
-case ValueToDouble: {
-// This node should never be visible at this stage of compilation. It is
-// inserted by fixup(), which follows this phase.
-ASSERT_NOT_REACHED();
-break;
-}
-
 case ValueAdd: {
 PredictedType left = m_predictions[node.child1()];
 PredictedType right = m_predictions[node.child2()];
@@ -546,6 +539,14 @@
 break;
 }
 
+case ValueToDouble:
+case GetArrayLength: {
+// This node should never be visible at this stage of compilation. It is
+// inserted by fixup(), which follows this phase.
+ASSERT_NOT_REACHED();
+break;
+}
+
 #ifndef NDEBUG
 // These get ignored because they don't return anything.
 case PutScopedVar:
@@ -681,6 +682,21 @@
 break;
 }
 
+case GetById: {
+if (!isArrayPrediction(m_predictions[node.child1()]))
+break;
+if (!isInt32Prediction(m_predictions[m_compileIndex]))
+break;
+if (m_codeBlock-identifier(node.identifierNumber()) != m_globalData.propertyNames-length)
+break;
+
+#if ENABLE(DFG_DEBUG_PROPAGATION_VERBOSE)
+printf(  @%u - GetArrayLength, nodeIndex);
+#endif
+node.op = GetArrayLength;
+break;
+}
+
 default:
 break;
 }
@@ -1044,6 +1060,7 @@
 case ArithMax:
 case ArithSqrt:
 case GetCallee:
+case GetArrayLength:
 setReplacement(pureCSE(node));
 break;
 


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (96183 => 96184)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2011-09-28 03:37:23 UTC (rev 96183)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2011-09-28 03:39:36 UTC (rev 96184)
@@ -1831,6 +1831,26 @@
 jsValueResult(resultGPR, m_compileIndex, UseChildrenCalledExplicitly);
 break;
 }
+
+case GetArrayLength: {
+Node baseNode = m_jit.graph()[node.child1()];
+SpeculateCellOperand base(this, node.child1());
+

[webkit-changes] [96185] trunk/Source/WebCore

2011-09-27 Thread commit-queue

Title: [96185] trunk/Source/WebCore








Revision 96185
Author commit-qu...@webkit.org
Date 2011-09-27 21:03:24 -0700 (Tue, 27 Sep 2011)


Log Message
[chromium] Only initiate the beginFrameAndCommit sequence if a commit has been requested
https://bugs.webkit.org/show_bug.cgi?id=68967

Patch by James Robinson jam...@chromium.org on 2011-09-27
Reviewed by Kenneth Russell.

When updating the scheduler state, we should only initiate a new commit flow if a commit has been requested (as
opposed to only a redraw).

Covered by the unit test CCLayerTreeHostTestSetNeedsRedraw with USE(THREADED_COMPOSITING) set to true.

* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (96184 => 96185)

--- trunk/Source/WebCore/ChangeLog	2011-09-28 03:39:36 UTC (rev 96184)
+++ trunk/Source/WebCore/ChangeLog	2011-09-28 04:03:24 UTC (rev 96185)
@@ -1,3 +1,18 @@
+2011-09-27  James Robinson  jam...@chromium.org
+
+[chromium] Only initiate the beginFrameAndCommit sequence if a commit has been requested
+https://bugs.webkit.org/show_bug.cgi?id=68967
+
+Reviewed by Kenneth Russell.
+
+When updating the scheduler state, we should only initiate a new commit flow if a commit has been requested (as
+opposed to only a redraw).
+
+Covered by the unit test CCLayerTreeHostTestSetNeedsRedraw with USE(THREADED_COMPOSITING) set to true.
+
+* platform/graphics/chromium/cc/CCThreadProxy.cpp:
+(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):
+
 2011-09-27  Kentaro Hara  hara...@chromium.com
 
 Implement a PageTransitionEvent constructor for V8


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp (96184 => 96185)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp	2011-09-28 03:39:36 UTC (rev 96184)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp	2011-09-28 04:03:24 UTC (rev 96185)
@@ -397,7 +397,7 @@
 // FIXME: use CCScheduler to decide when to manage the conversion of this
 // commit request into an actual createBeginFrameAndCommitTaskOnCCThread call.
 m_redrawRequestedOnCCThread |= redrawRequested;
-if (!m_beginFrameAndCommitPendingOnCCThread) {
+if (commitRequested  !m_beginFrameAndCommitPendingOnCCThread) {
 CCMainThread::postTask(createBeginFrameAndCommitTaskOnCCThread());
 return;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96187] trunk/Source/WebCore

2011-09-27 Thread rniwa

Title: [96187] trunk/Source/WebCore








Revision 96187
Author rn...@webkit.org
Date 2011-09-27 22:04:20 -0700 (Tue, 27 Sep 2011)


Log Message
Simplify ReplaceSelectionCommand::positionAtStartOfInsertedContent
https://bugs.webkit.org/show_bug.cgi?id=68939

Reviewed by Darin Adler.

Simplified ReplaceSelectionCommand::positionAtStartOfInsertedContent.

This change revealed a bug in removeUnrenderedTextNodesAtEnds that text nodes without any visible
text at ends are not removed when it has a render object. Fixed the bug by checking the length of
the rendered text. (Tested by editing/pasteboard/pasting-word-in-div-extra-line.html)

This further revealed that caretMaxRenderedOffset doesn't return an offset and caretMaxRenderedOffset
on InlineBox, InlineTextBox, RenderObject, RenderBR, RenderPlaced are never called. To address this
issue, renamed caretMaxRenderedOffset to renderedTextLength for RenderText and removed the rest.

* dom/Position.cpp:
(WebCore::Position::rendersInDifferentPosition):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::nodeHasVisibleRenderText): Added.
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): Calls nodeHasVisibleRenderText.
(WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Simplified.
* editing/visible_units.cpp:
(WebCore::startOfParagraph): Calls renderedTextLength.
(WebCore::endOfParagraph): Ditto.
* rendering/InlineBox.cpp: Removed caretMaxRenderedOffset.
* rendering/InlineBox.h: Ditto.
* rendering/InlineTextBox.cpp: Ditto.
* rendering/InlineTextBox.h: Ditto.
* rendering/RenderBR.cpp: Ditto.
* rendering/RenderBR.h: Ditto.
* rendering/RenderObject.cpp: Ditto.
* rendering/RenderObject.h: Ditto.
* rendering/RenderReplaced.cpp: Ditto.
* rendering/RenderReplaced.h: Ditto.
* rendering/RenderText.cpp:
(WebCore::RenderText::renderedTextLength): Renamed from caretMaxRenderedOffset.
* rendering/RenderText.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Position.cpp
trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp
trunk/Source/WebCore/editing/visible_units.cpp
trunk/Source/WebCore/rendering/InlineBox.cpp
trunk/Source/WebCore/rendering/InlineBox.h
trunk/Source/WebCore/rendering/InlineTextBox.cpp
trunk/Source/WebCore/rendering/InlineTextBox.h
trunk/Source/WebCore/rendering/RenderBR.cpp
trunk/Source/WebCore/rendering/RenderBR.h
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/RenderReplaced.cpp
trunk/Source/WebCore/rendering/RenderReplaced.h
trunk/Source/WebCore/rendering/RenderText.cpp
trunk/Source/WebCore/rendering/RenderText.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (96186 => 96187)

--- trunk/Source/WebCore/ChangeLog	2011-09-28 04:56:31 UTC (rev 96186)
+++ trunk/Source/WebCore/ChangeLog	2011-09-28 05:04:20 UTC (rev 96187)
@@ -1,3 +1,43 @@
+2011-09-27  Ryosuke Niwa  rn...@webkit.org
+
+Simplify ReplaceSelectionCommand::positionAtStartOfInsertedContent
+https://bugs.webkit.org/show_bug.cgi?id=68939
+
+Reviewed by Darin Adler.
+
+Simplified ReplaceSelectionCommand::positionAtStartOfInsertedContent.
+
+This change revealed a bug in removeUnrenderedTextNodesAtEnds that text nodes without any visible
+text at ends are not removed when it has a render object. Fixed the bug by checking the length of
+the rendered text. (Tested by editing/pasteboard/pasting-word-in-div-extra-line.html)
+
+This further revealed that caretMaxRenderedOffset doesn't return an offset and caretMaxRenderedOffset
+on InlineBox, InlineTextBox, RenderObject, RenderBR, RenderPlaced are never called. To address this
+issue, renamed caretMaxRenderedOffset to renderedTextLength for RenderText and removed the rest.
+
+* dom/Position.cpp:
+(WebCore::Position::rendersInDifferentPosition):
+* editing/ReplaceSelectionCommand.cpp:
+(WebCore::nodeHasVisibleRenderText): Added.
+(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): Calls nodeHasVisibleRenderText.
+(WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Simplified.
+* editing/visible_units.cpp:
+(WebCore::startOfParagraph): Calls renderedTextLength.
+(WebCore::endOfParagraph): Ditto.
+* rendering/InlineBox.cpp: Removed caretMaxRenderedOffset.
+* rendering/InlineBox.h: Ditto.
+* rendering/InlineTextBox.cpp: Ditto.
+* rendering/InlineTextBox.h: Ditto.
+* rendering/RenderBR.cpp: Ditto.
+* rendering/RenderBR.h: Ditto.
+* rendering/RenderObject.cpp: Ditto.
+* rendering/RenderObject.h: Ditto.
+* rendering/RenderReplaced.cpp: Ditto.
+* rendering/RenderReplaced.h: Ditto.
+* rendering/RenderText.cpp:
+(WebCore::RenderText::renderedTextLength): Renamed from caretMaxRenderedOffset.
+* rendering/RenderText.h:
+
 2011-09-27  James

[webkit-changes] [96189] trunk/Source/JavaScriptCore

2011-09-27 Thread fpizlo

Title: [96189] trunk/Source/_javascript_Core








Revision 96189
Author fpi...@apple.com
Date 2011-09-27 22:33:21 -0700 (Tue, 27 Sep 2011)


Log Message
DFG JIT cannot compile op_new_object, op_new_array,
op_new_array_buffer, or op_new_regexp
https://bugs.webkit.org/show_bug.cgi?id=68580

Reviewed by Oliver Hunt.

This implements all four opcodes, but has op_new_regexp turns off
by default because it unveils some bad speculation logic when
compiling string-validate-input.

With op_new_regexp turned off, this is a 5% win on Kraken and a
0.7% speed-up on V8. Neutral on SunSpider.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasConstantBuffer):
(JSC::DFG::Node::startConstant):
(JSC::DFG::Node::numConstants):
(JSC::DFG::Node::hasRegexpIndex):
(JSC::DFG::Node::regexpIndex):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isKnownArray):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGCapabilities.h
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h
trunk/Source/_javascript_Core/dfg/DFGNode.h
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGPropagator.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (96188 => 96189)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-28 05:23:51 UTC (rev 96188)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-28 05:33:21 UTC (rev 96189)
@@ -1,5 +1,42 @@
 2011-09-27  Filip Pizlo  fpi...@apple.com
 
+DFG JIT cannot compile op_new_object, op_new_array,
+op_new_array_buffer, or op_new_regexp
+https://bugs.webkit.org/show_bug.cgi?id=68580
+
+Reviewed by Oliver Hunt.
+
+This implements all four opcodes, but has op_new_regexp turns off
+by default because it unveils some bad speculation logic when
+compiling string-validate-input.
+
+With op_new_regexp turned off, this is a 5% win on Kraken and a
+0.7% speed-up on V8. Neutral on SunSpider.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::parseBlock):
+* dfg/DFGCapabilities.h:
+(JSC::DFG::canCompileOpcode):
+* dfg/DFGJITCodeGenerator.h:
+(JSC::DFG::callOperation):
+* dfg/DFGNode.h:
+(JSC::DFG::Node::hasConstantBuffer):
+(JSC::DFG::Node::startConstant):
+(JSC::DFG::Node::numConstants):
+(JSC::DFG::Node::hasRegexpIndex):
+(JSC::DFG::Node::regexpIndex):
+* dfg/DFGOperations.cpp:
+* dfg/DFGOperations.h:
+* dfg/DFGPropagator.cpp:
+(JSC::DFG::Propagator::propagateNodePredictions):
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT.h:
+(JSC::DFG::SpeculativeJIT::isKnownArray):
+
+2011-09-27  Filip Pizlo  fpi...@apple.com
+
 DFG JIT should speculate more aggressively on reads of array.length
 https://bugs.webkit.org/show_bug.cgi?id=68932
 


Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (96188 => 96189)

--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2011-09-28 05:23:51 UTC (rev 96188)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2011-09-28 05:33:21 UTC (rev 96189)
@@ -724,6 +724,32 @@
 NEXT_OPCODE(op_create_this);
 }
 
+case op_new_object: {
+set(currentInstruction[1].u.operand, addToGraph(NewObject));
+NEXT_OPCODE(op_new_object);
+}
+
+case op_new_array: {
+int startOperand = currentInstruction[2].u.operand;
+int numOperands = currentInstruction[3].u.operand;
+for (int operandIdx = startOperand; operandIdx  startOperand + numOperands; ++operandIdx)
+addVarArgChild(get(operandIdx));
+set(currentInstruction[1].u.operand, addToGraph(Node::VarArg, NewArray, OpInfo(0), OpInfo(0)));
+NEXT_OPCODE(op_new_array);
+}
+
+case op_new_array_buffer: {
+int startConstant = currentInstruction[2].u.operand;
+int numConstants = currentInstruction[3].u.operand;
+set(currentInstruction[1].u.operand, addToGraph(NewArrayBuffer, OpInfo(startConstant),

75 matches

Mail list logo