[webkit-changes] [99541] trunk/Source/WebCore
Title: [99541] trunk/Source/WebCore Revision 99541 Author vse...@chromium.org Date 2011-11-08 03:22:27 -0800 (Tue, 08 Nov 2011) Log Message Web Inspector: Console should be scrolled to bottom when shown for the first time. https://bugs.webkit.org/show_bug.cgi?id=71781 Reviewed by Pavel Feldman. * inspector/front-end/ConsoleView.js: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/ConsoleView.js Diff Modified: trunk/Source/WebCore/ChangeLog (99540 => 99541) --- trunk/Source/WebCore/ChangeLog 2011-11-08 09:34:04 UTC (rev 99540) +++ trunk/Source/WebCore/ChangeLog 2011-11-08 11:22:27 UTC (rev 99541) @@ -1,3 +1,12 @@ +2011-11-08 Vsevolod Vlasov vse...@chromium.org + +Web Inspector: Console should be scrolled to bottom when shown for the first time. +https://bugs.webkit.org/show_bug.cgi?id=71781 + +Reviewed by Pavel Feldman. + +* inspector/front-end/ConsoleView.js: + 2011-11-08 Nikolas Zimmermann nzimmerm...@rim.com Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (99540 => 99541) --- trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-08 09:34:04 UTC (rev 99540) +++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-08 11:22:27 UTC (rev 99541) @@ -56,6 +56,7 @@ this.messagesElement.className = monospace; this.messagesElement.addEventListener(click, this._messagesClicked.bind(this), true); this.element.appendChild(this.messagesElement); +this._scrolledToBottom = true; this.promptElement = document.createElement(div); this.promptElement.id = console-prompt; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99545] trunk/LayoutTests
Title: [99545] trunk/LayoutTests Revision 99545 Author yu...@chromium.org Date 2011-11-08 03:58:16 -0800 (Tue, 08 Nov 2011) Log Message [Chromium] Unreviewed, trying to update test_expectations.txt for the tests which started to fail after r99539. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (99544 => 99545) --- trunk/LayoutTests/ChangeLog 2011-11-08 11:54:55 UTC (rev 99544) +++ trunk/LayoutTests/ChangeLog 2011-11-08 11:58:16 UTC (rev 99545) @@ -1,3 +1,10 @@ +2011-11-08 Yuta Kitamura yu...@chromium.org + +[Chromium] Unreviewed, trying to update test_expectations.txt for the tests which +started to fail after r99539. + +* platform/chromium/test_expectations.txt: + 2011-11-08 Nikolas Zimmermann nzimmerm...@rim.com Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99544 => 99545) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-08 11:54:55 UTC (rev 99544) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-08 11:58:16 UTC (rev 99545) @@ -3214,7 +3214,7 @@ // Appears to be a configuration error in the Mac 10.6 deps // Has been going on for at least a few weeks (as of 20/5/2011) BUGCR83426 MAC : svg/as-border-image/svg-as-border-image-2.html = PASS IMAGE -BUGCR83426 MAC : svg/as-border-image/svg-as-border-image.html = PASS IMAGE +// BUGCR83426 MAC : svg/as-border-image/svg-as-border-image.html = PASS IMAGE BUGCR83426 MAC : svg/W3C-SVG-1.1/filters-color-01-b.svg = PASS IMAGE BUGCR83426 MAC : svg/W3C-SVG-1.1/filters-specular-01-f.svg = PASS IMAGE BUGCR83426 MAC : svg/W3C-SVG-1.1/filters-turb-01-f.svg = PASS IMAGE @@ -3847,7 +3847,7 @@ BUGWK71215 SNOWLEOPARD DEBUG : animations/change-keyframes.html = TEXT BUGWK71673 MAC : svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html = IMAGE+TEXT -BUGWK71673 WIN LINUX : svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html = PASS IMAGE+TEXT +// BUGWK71673 WIN LINUX : svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html = PASS IMAGE+TEXT BUGWK71278 SLOW WIN RELEASE : fast/events/dispatch-message-string-data.html = PASS @@ -3893,3 +3893,35 @@ BUGWK65939 : svg/custom/getBBox-path.svg = TEXT BUGWK67019 : fast/text/international/locale-sensitive-fonts.html = MISSING FAIL + +// SVG failures after r99539. +BUGWK71793 : css2.1/20110323/background-intrinsic-004.htm = IMAGE +BUGWK71793 : css2.1/20110323/background-intrinsic-005.htm = IMAGE +BUGWK71793 : fast/backgrounds/animated-svg-as-mask.html = IMAGE +BUGWK71793 : svg/as-background-image/animated-svg-as-background.html = IMAGE +BUGWK71793 : svg/as-background-image/background-image-preserveaspectRatio-support.html = IMAGE +BUGWK71793 : svg/as-background-image/svg-as-background-2.html = IMAGE +BUGWK71793 : svg/as-background-image/svg-as-background-4.html = IMAGE +BUGWK71793 : svg/as-background-image/svg-as-background-with-relative-size.html = IMAGE +BUGWK71793 : svg/as-background-image/svg-background-partial-redraw.html = IMAGE +BUGWK71793 : svg/as-image/animated-svg-as-image.html = IMAGE +BUGWK71793 : svg/as-image/img-preserveAspectRatio-support-1.html = IMAGE +BUGWK71793 : svg/as-image/img-preserveAspectRatio-support-2.html = IMAGE +BUGWK71793 : svg/as-image/same-image-two-instances.html = IMAGE +BUGWK71793 : svg/as-image/svg-image-change-content-size.xhtml = IMAGE +BUGWK71793 : svg/wicd/test-scalable-background-image1.xhtml = IMAGE +BUGWK71793 : svg/wicd/test-scalable-background-image2.xhtml = IMAGE +BUGWK71793 : svg/zoom/page/zoom-background-images.html = IMAGE +BUGWK71793 : svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html = IMAGE +BUGWK71793 : svg/zoom/page/zoom-svg-as-background-with-relative-size.html = IMAGE +BUGWK71793 : fast/backgrounds/size/contain-and-cover-zoomed.html = IMAGE+TEXT +BUGWK71793 WIN LINUX : svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html = IMAGE+TEXT +BUGWK71793 MAC : svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html = IMAGE +BUGWK71793 WIN LINUX : svg/as-image/animated-svg-as-image-same-image.html = IMAGE+TEXT +BUGWK71793 MAC : svg/as-image/animated-svg-as-image-same-image.html = IMAGE +BUGWK71793 : svg/zoom/page/zoom-coords-viewattr-01-b.svg = IMAGE+TEXT +BUGWK71793 : svg/as-background-image/svg-as-background-1.html = IMAGE +BUGWK71793 : svg/as-background-image/svg-as-background-3.html = IMAGE +// Uncomment the above results when you remove any of the following lines. +BUGWK71793 BUGCR83426 : svg/as-border-image/svg-as-border-image.html = IMAGE +BUGWK71793 BUGWK71673 WIN LINUX : svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html = PASS IMAGE IMAGE+TEXT ___ webkit-changes mailing list
[webkit-changes] [99547] trunk/Tools
Title: [99547] trunk/Tools Revision 99547 Author ves...@webkit.org Date 2011-11-08 04:14:55 -0800 (Tue, 08 Nov 2011) Log Message [Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES Reviewed by Simon Hausmann. Modified Paths trunk/Tools/ChangeLog trunk/Tools/qmake/mkspecs/features/default_post.prf Diff Modified: trunk/Tools/ChangeLog (99546 => 99547) --- trunk/Tools/ChangeLog 2011-11-08 12:00:26 UTC (rev 99546) +++ trunk/Tools/ChangeLog 2011-11-08 12:14:55 UTC (rev 99547) @@ -1,3 +1,11 @@ +2011-11-08 Tor Arne Vestbø tor.arne.ves...@nokia.com + +[Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES + +Reviewed by Simon Hausmann. + +* qmake/mkspecs/features/default_post.prf: + 2011-11-07 Zeno Albisser zeno.albis...@nokia.com [Qt][WK2] MiniBrowser should use urlFromUserInput() Modified: trunk/Tools/qmake/mkspecs/features/default_post.prf (99546 => 99547) --- trunk/Tools/qmake/mkspecs/features/default_post.prf 2011-11-08 12:00:26 UTC (rev 99546) +++ trunk/Tools/qmake/mkspecs/features/default_post.prf 2011-11-08 12:14:55 UTC (rev 99547) @@ -192,6 +192,10 @@ unset(OBJECTS_DIR) } +# Remove duplicated sources +SOURCES = $$unique(SOURCES) +OBJECTIVE_SOURCES = $$unique(OBJECTIVE_SOURCES) + # Someone might remove a header from the tree without touching # the corresponding project file, for example if the project # file never had the header in HEADERS. In that case we don't ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99548] trunk/Source/WebCore
Title: [99548] trunk/Source/WebCore
Revision 99548
Author apav...@chromium.org
Date 2011-11-08 04:22:13 -0800 (Tue, 08 Nov 2011)
Log Message
Web Inspector: Avoid automatic Console suggestions with empty _expression_
https://bugs.webkit.org/show_bug.cgi?id=71783
Reviewed by Yury Semikhatsky.
* inspector/front-end/ConsoleView.js:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ConsoleView.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (99547 => 99548)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 12:14:55 UTC (rev 99547)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 12:22:13 UTC (rev 99548)
@@ -1,3 +1,12 @@
+2011-11-08 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: Avoid automatic Console suggestions with empty _expression_
+https://bugs.webkit.org/show_bug.cgi?id=71783
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/ConsoleView.js:
+
2011-11-08 Nikolas Zimmermann nzimmerm...@rim.com
Not reviewed. Fix build, by removing an unused variable.
Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (99547 => 99548)
--- trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-08 12:14:55 UTC (rev 99547)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-08 12:22:13 UTC (rev 99548)
@@ -360,6 +360,11 @@
return;
}
+if (!prefix !expressionString !force) {
+completionsReadyCallback([]);
+return;
+}
+
if (!expressionString WebInspector.debuggerPresentationModel.paused)
WebInspector.debuggerPresentationModel.getSelectedCallFrameVariables(receivedPropertyNames.bind(this));
else
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99549] trunk/Source/WebCore
Title: [99549] trunk/Source/WebCore Revision 99549 Author zimmerm...@webkit.org Date 2011-11-08 04:29:38 -0800 (Tue, 08 Nov 2011) Log Message 2011-11-08 Nikolas Zimmermann nzimmerm...@rim.com Fold ImageBySizeCache again into CSSImageGeneratorValue https://bugs.webkit.org/show_bug.cgi?id=71785 Reviewed by Zoltan Herczeg. Remove ImageBySizeCache, and fold it into CSSImageGeneratorValue, as it used to be. CachedImage has switched to SVGImageCache and no longer needs it. * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::addClient): (WebCore::CSSImageGeneratorValue::removeClient): (WebCore::CSSImageGeneratorValue::getImage): (WebCore::CSSImageGeneratorValue::putImage): * css/CSSImageGeneratorValue.h: (WebCore::SizeAndCount::SizeAndCount): (WebCore::CSSImageGeneratorValue::clients): * rendering/ImageBySizeCache.cpp: Removed. * rendering/ImageBySizeCache.h: Removed. Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/css/CSSImageGeneratorValue.cpp trunk/Source/WebCore/css/CSSImageGeneratorValue.h Removed Paths trunk/Source/WebCore/rendering/ImageBySizeCache.cpp trunk/Source/WebCore/rendering/ImageBySizeCache.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (99548 => 99549) --- trunk/Source/WebCore/CMakeLists.txt 2011-11-08 12:22:13 UTC (rev 99548) +++ trunk/Source/WebCore/CMakeLists.txt 2011-11-08 12:29:38 UTC (rev 99549) @@ -1217,7 +1217,6 @@ rendering/FixedTableLayout.cpp rendering/HitTestingTransformState.cpp rendering/HitTestResult.cpp -rendering/ImageBySizeCache.cpp rendering/InlineBox.cpp rendering/InlineFlowBox.cpp rendering/InlineTextBox.cpp Modified: trunk/Source/WebCore/ChangeLog (99548 => 99549) --- trunk/Source/WebCore/ChangeLog 2011-11-08 12:22:13 UTC (rev 99548) +++ trunk/Source/WebCore/ChangeLog 2011-11-08 12:29:38 UTC (rev 99549) @@ -1,3 +1,30 @@ +2011-11-08 Nikolas Zimmermann nzimmerm...@rim.com + +Fold ImageBySizeCache again into CSSImageGeneratorValue +https://bugs.webkit.org/show_bug.cgi?id=71785 + +Reviewed by Zoltan Herczeg. + +Remove ImageBySizeCache, and fold it into CSSImageGeneratorValue, as it used to be. +CachedImage has switched to SVGImageCache and no longer needs it. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* Target.pri: +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* css/CSSImageGeneratorValue.cpp: +(WebCore::CSSImageGeneratorValue::addClient): +(WebCore::CSSImageGeneratorValue::removeClient): +(WebCore::CSSImageGeneratorValue::getImage): +(WebCore::CSSImageGeneratorValue::putImage): +* css/CSSImageGeneratorValue.h: +(WebCore::SizeAndCount::SizeAndCount): +(WebCore::CSSImageGeneratorValue::clients): +* rendering/ImageBySizeCache.cpp: Removed. +* rendering/ImageBySizeCache.h: Removed. + 2011-11-08 Alexander Pavlov apav...@chromium.org Web Inspector: Avoid automatic Console suggestions with empty _expression_ Modified: trunk/Source/WebCore/GNUmakefile.list.am (99548 => 99549) --- trunk/Source/WebCore/GNUmakefile.list.am 2011-11-08 12:22:13 UTC (rev 99548) +++ trunk/Source/WebCore/GNUmakefile.list.am 2011-11-08 12:29:38 UTC (rev 99549) @@ -3025,8 +3025,6 @@ Source/WebCore/rendering/HitTestingTransformState.h \ Source/WebCore/rendering/HitTestResult.cpp \ Source/WebCore/rendering/HitTestResult.h \ - Source/WebCore/rendering/ImageBySizeCache.cpp \ - Source/WebCore/rendering/ImageBySizeCache.h \ Source/WebCore/rendering/InlineBox.cpp \ Source/WebCore/rendering/InlineBox.h \ Source/WebCore/rendering/InlineFlowBox.cpp \ Modified: trunk/Source/WebCore/Target.pri (99548 => 99549) --- trunk/Source/WebCore/Target.pri 2011-11-08 12:22:13 UTC (rev 99548) +++ trunk/Source/WebCore/Target.pri 2011-11-08 12:29:38 UTC (rev 99549) @@ -1169,7 +1169,6 @@ rendering/FixedTableLayout.cpp \ rendering/HitTestingTransformState.cpp \ rendering/HitTestResult.cpp \ -rendering/ImageBySizeCache.cpp \ rendering/InlineBox.cpp \ rendering/InlineFlowBox.cpp \ rendering/InlineTextBox.cpp \ @@ -2269,7 +2268,6 @@ rendering/FixedTableLayout.h \ rendering/HitTestingTransformState.h \ rendering/HitTestResult.h \ -rendering/ImageBySizeCache.h \ rendering/InlineBox.h \
[webkit-changes] [99555] trunk/Source/WebCore
Title: [99555] trunk/Source/WebCore
Revision 99555
Author andreas.kl...@nokia.com
Date 2011-11-08 05:22:03 -0800 (Tue, 08 Nov 2011)
Log Message
CSSCanvasValue: Remove inheritance from CanvasObserver.
http://webkit.org/b/71796
Reviewed by Antti Koivisto.
To completely devirtualize all the CSSValues, we need to remove
CSSCanvasValue's inheritance from CanvasObserver, as that is forcing
a vptr into the class.
Use the same approach as CSSImportRule and make a simple proxying
CanvasObserver subclass and put that as a member variable of the value.
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::~CSSCanvasValue):
(WebCore::CSSCanvasValue::element):
* css/CSSCanvasValue.h:
(WebCore::CSSCanvasValue::CSSCanvasValue):
(WebCore::CSSCanvasValue::CanvasObserverProxy::CanvasObserverProxy):
(WebCore::CSSCanvasValue::CanvasObserverProxy::~CanvasObserverProxy):
(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasChanged):
(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasResized):
(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasDestroyed):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSCanvasValue.cpp
trunk/Source/WebCore/css/CSSCanvasValue.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99554 => 99555)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 13:06:11 UTC (rev 99554)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 13:22:03 UTC (rev 99555)
@@ -1,3 +1,28 @@
+2011-11-08 Andreas Kling kl...@webkit.org
+
+CSSCanvasValue: Remove inheritance from CanvasObserver.
+http://webkit.org/b/71796
+
+Reviewed by Antti Koivisto.
+
+To completely devirtualize all the CSSValues, we need to remove
+CSSCanvasValue's inheritance from CanvasObserver, as that is forcing
+a vptr into the class.
+
+Use the same approach as CSSImportRule and make a simple proxying
+CanvasObserver subclass and put that as a member variable of the value.
+
+* css/CSSCanvasValue.cpp:
+(WebCore::CSSCanvasValue::~CSSCanvasValue):
+(WebCore::CSSCanvasValue::element):
+* css/CSSCanvasValue.h:
+(WebCore::CSSCanvasValue::CSSCanvasValue):
+(WebCore::CSSCanvasValue::CanvasObserverProxy::CanvasObserverProxy):
+(WebCore::CSSCanvasValue::CanvasObserverProxy::~CanvasObserverProxy):
+(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasChanged):
+(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasResized):
+(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasDestroyed):
+
2011-11-08 Yury Semikhatsky yu...@chromium.org
Web Inspector: display notification in the front-end when inspected worker terminates
Modified: trunk/Source/WebCore/css/CSSCanvasValue.cpp (99554 => 99555)
--- trunk/Source/WebCore/css/CSSCanvasValue.cpp 2011-11-08 13:06:11 UTC (rev 99554)
+++ trunk/Source/WebCore/css/CSSCanvasValue.cpp 2011-11-08 13:22:03 UTC (rev 99555)
@@ -34,7 +34,7 @@
CSSCanvasValue::~CSSCanvasValue()
{
if (m_element)
-m_element-removeObserver(this);
+m_element-removeObserver(m_canvasObserver);
}
String CSSCanvasValue::cssText() const
@@ -78,7 +78,7 @@
m_element = document-getCSSCanvasElement(m_name);
if (!m_element)
return 0;
-m_element-addObserver(this);
+m_element-addObserver(m_canvasObserver);
}
return m_element;
}
Modified: trunk/Source/WebCore/css/CSSCanvasValue.h (99554 => 99555)
--- trunk/Source/WebCore/css/CSSCanvasValue.h 2011-11-08 13:06:11 UTC (rev 99554)
+++ trunk/Source/WebCore/css/CSSCanvasValue.h 2011-11-08 13:22:03 UTC (rev 99555)
@@ -33,7 +33,7 @@
class Document;
-class CSSCanvasValue : public CSSImageGeneratorValue, private CanvasObserver {
+class CSSCanvasValue : public CSSImageGeneratorValue {
public:
static PassRefPtrCSSCanvasValue create() { return adoptRef(new CSSCanvasValue); }
virtual ~CSSCanvasValue();
@@ -49,16 +49,41 @@
private:
CSSCanvasValue()
: CSSImageGeneratorValue(CanvasClass)
+, m_canvasObserver(this)
, m_element(0)
{
}
-virtual void canvasChanged(HTMLCanvasElement*, const FloatRect changedRect);
-virtual void canvasResized(HTMLCanvasElement*);
-virtual void canvasDestroyed(HTMLCanvasElement*);
+// NOTE: We put the CanvasObserver in a member instead of inheriting from it
+// to avoid adding a vptr to CSSCanvasValue.
+class CanvasObserverProxy : public CanvasObserver {
+public:
+CanvasObserverProxy(CSSCanvasValue* ownerValue) : m_ownerValue(ownerValue) { }
+virtual ~CanvasObserverProxy() { }
+virtual void canvasChanged(HTMLCanvasElement* canvas, const FloatRect changedRect)
+{
+m_ownerValue-canvasChanged(canvas, changedRect);
+}
+virtual void canvasResized(HTMLCanvasElement* canvas)
+{
+m_ownerValue-canvasResized(canvas);
+}
+virtual void
[webkit-changes] [99556] trunk/Source/WebCore
Title: [99556] trunk/Source/WebCore
Revision 99556
Author andreas.kl...@nokia.com
Date 2011-11-08 05:23:24 -0800 (Tue, 08 Nov 2011)
Log Message
CSSGradientValue: Devirtualize createGradient().
http://webkit.org/b/71800
Reviewed by Antti Koivisto.
Make createGradient() non-virtual and call the appropriate subclass
implementation in image() based on is{Linear,Radial}Gradient().
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
* css/CSSGradientValue.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGradientValue.cpp
trunk/Source/WebCore/css/CSSGradientValue.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99555 => 99556)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 13:22:03 UTC (rev 99555)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 13:23:24 UTC (rev 99556)
@@ -1,5 +1,19 @@
2011-11-08 Andreas Kling kl...@webkit.org
+CSSGradientValue: Devirtualize createGradient().
+http://webkit.org/b/71800
+
+Reviewed by Antti Koivisto.
+
+Make createGradient() non-virtual and call the appropriate subclass
+implementation in image() based on is{Linear,Radial}Gradient().
+
+* css/CSSGradientValue.cpp:
+(WebCore::CSSGradientValue::image):
+* css/CSSGradientValue.h:
+
+2011-11-08 Andreas Kling kl...@webkit.org
+
CSSCanvasValue: Remove inheritance from CanvasObserver.
http://webkit.org/b/71796
Modified: trunk/Source/WebCore/css/CSSGradientValue.cpp (99555 => 99556)
--- trunk/Source/WebCore/css/CSSGradientValue.cpp 2011-11-08 13:22:03 UTC (rev 99555)
+++ trunk/Source/WebCore/css/CSSGradientValue.cpp 2011-11-08 13:23:24 UTC (rev 99556)
@@ -58,7 +58,16 @@
}
// We need to create an image.
-RefPtrImage newImage = GeneratedImage::create(createGradient(renderer, size), size);
+RefPtrGradient gradient;
+
+if (isLinearGradient())
+gradient = static_castCSSLinearGradientValue*(this)-createGradient(renderer, size);
+else {
+ASSERT(isRadialGradient());
+gradient = static_castCSSRadialGradientValue*(this)-createGradient(renderer, size);
+}
+
+RefPtrImage newImage = GeneratedImage::create(gradient, size);
if (cacheable)
putImage(size, newImage);
Modified: trunk/Source/WebCore/css/CSSGradientValue.h (99555 => 99556)
--- trunk/Source/WebCore/css/CSSGradientValue.h 2011-11-08 13:22:03 UTC (rev 99555)
+++ trunk/Source/WebCore/css/CSSGradientValue.h 2011-11-08 13:23:24 UTC (rev 99556)
@@ -77,9 +77,6 @@
void addStops(Gradient*, RenderObject*, RenderStyle* rootStyle, float maxLengthForRepeat = 0);
-// Create the gradient for a given size.
-virtual PassRefPtrGradient createGradient(RenderObject*, const IntSize) = 0;
-
// Resolve points/radii to front end values.
FloatPoint computeEndPoint(CSSPrimitiveValue*, CSSPrimitiveValue*, RenderStyle*, RenderStyle* rootStyle, const IntSize);
@@ -111,15 +108,15 @@
virtual String cssText() const;
+// Create the gradient for a given size.
+PassRefPtrGradient createGradient(RenderObject*, const IntSize);
+
private:
CSSLinearGradientValue(CSSGradientRepeat repeat, bool deprecatedType = false)
: CSSGradientValue(LinearGradientClass, repeat, deprecatedType)
{
}
-// Create the gradient for a given size.
-virtual PassRefPtrGradient createGradient(RenderObject*, const IntSize);
-
RefPtrCSSPrimitiveValue m_angle; // may be null.
};
@@ -141,15 +138,15 @@
void setEndHorizontalSize(PassRefPtrCSSPrimitiveValue val) { m_endHorizontalSize = val; }
void setEndVerticalSize(PassRefPtrCSSPrimitiveValue val) { m_endVerticalSize = val; }
+// Create the gradient for a given size.
+PassRefPtrGradient createGradient(RenderObject*, const IntSize);
+
private:
CSSRadialGradientValue(CSSGradientRepeat repeat, bool deprecatedType = false)
: CSSGradientValue(RadialGradientClass, repeat, deprecatedType)
{
}
-// Create the gradient for a given size.
-virtual PassRefPtrGradient createGradient(RenderObject*, const IntSize);
-
// Resolve points/radii to front end values.
float resolveRadius(CSSPrimitiveValue*, RenderStyle*, RenderStyle* rootStyle, float* widthOrHeight = 0);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99557] trunk/Source/WebCore
Title: [99557] trunk/Source/WebCore
Revision 99557
Author apav...@chromium.org
Date 2011-11-08 05:34:38 -0800 (Tue, 08 Nov 2011)
Log Message
Web Inspector: Do not hide SuggestBox if typed-in string in the middle of input equals one of suggestions
https://bugs.webkit.org/show_bug.cgi?id=71797
Reviewed by Yury Semikhatsky.
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.complete):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TextPrompt.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (99556 => 99557)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 13:23:24 UTC (rev 99556)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 13:34:38 UTC (rev 99557)
@@ -1,3 +1,14 @@
+2011-11-08 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: Do not hide SuggestBox if typed-in string in the middle of input equals one of suggestions
+https://bugs.webkit.org/show_bug.cgi?id=71797
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/TextPrompt.js:
+(WebInspector.TextPrompt.prototype.onKeyDown):
+(WebInspector.TextPrompt.prototype.complete):
+
2011-11-08 Andreas Kling kl...@webkit.org
CSSGradientValue: Devirtualize createGradient().
Modified: trunk/Source/WebCore/inspector/front-end/TextPrompt.js (99556 => 99557)
--- trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-08 13:23:24 UTC (rev 99556)
+++ trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-08 13:34:38 UTC (rev 99557)
@@ -228,7 +228,7 @@
break;
case Right:
case End:
-if (this.isSuggestBoxVisible())
+if (this.isSuggestBoxVisible() this.isCaretAtEndOfPrompt())
handled = this._suggestBox.tabKeyPressed(event);
else {
handled = this.acceptAutoComplete();
@@ -359,7 +359,7 @@
shouldExit = true;
if (!auto !isEmptyInput !selectionRange.commonAncestorContainer.isDescendant(this._element))
shouldExit = true;
-if (auto !this.isCaretAtEndOfPrompt() !force)
+if (auto !this.isCaretAtEndOfPrompt() !this._suggestBox !force)
shouldExit = true;
if (shouldExit) {
if (this.isSuggestBoxVisible())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99560] trunk/Source/WebCore
Title: [99560] trunk/Source/WebCore
Revision 99560
Author andreas.kl...@nokia.com
Date 2011-11-08 06:01:27 -0800 (Tue, 08 Nov 2011)
Log Message
CSSValue: Devirtualize addSubresourceStyleURLs().
http://webkit.org/b/71805
Reviewed by Antti Koivisto.
Make addSubresourceStyleURLs() non-virtual and call the appropriate
subclass implementation based on the subclass type info.
* css/CSSBorderImageValue.h:
* css/CSSFontFaceSrcValue.h:
* css/CSSPrimitiveValue.h:
* css/CSSReflectValue.h:
* css/CSSValue.cpp:
(WebCore::CSSValue::addSubresourceStyleURLs):
* css/CSSValue.h:
(WebCore::CSSValue::addSubresourceStyleURLs):
* css/CSSValueList.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSBorderImageValue.h
trunk/Source/WebCore/css/CSSFontFaceSrcValue.h
trunk/Source/WebCore/css/CSSPrimitiveValue.h
trunk/Source/WebCore/css/CSSReflectValue.h
trunk/Source/WebCore/css/CSSValue.cpp
trunk/Source/WebCore/css/CSSValue.h
trunk/Source/WebCore/css/CSSValueList.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99559 => 99560)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 13:46:50 UTC (rev 99559)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 14:01:27 UTC (rev 99560)
@@ -1,3 +1,23 @@
+2011-11-08 Andreas Kling kl...@webkit.org
+
+CSSValue: Devirtualize addSubresourceStyleURLs().
+http://webkit.org/b/71805
+
+Reviewed by Antti Koivisto.
+
+Make addSubresourceStyleURLs() non-virtual and call the appropriate
+subclass implementation based on the subclass type info.
+
+* css/CSSBorderImageValue.h:
+* css/CSSFontFaceSrcValue.h:
+* css/CSSPrimitiveValue.h:
+* css/CSSReflectValue.h:
+* css/CSSValue.cpp:
+(WebCore::CSSValue::addSubresourceStyleURLs):
+* css/CSSValue.h:
+(WebCore::CSSValue::addSubresourceStyleURLs):
+* css/CSSValueList.h:
+
2011-11-08 Andrey Kosyakov ca...@chromium.org
Web Inspector: do not show object popover when selection is active
Modified: trunk/Source/WebCore/css/CSSBorderImageValue.h (99559 => 99560)
--- trunk/Source/WebCore/css/CSSBorderImageValue.h 2011-11-08 13:46:50 UTC (rev 99559)
+++ trunk/Source/WebCore/css/CSSBorderImageValue.h 2011-11-08 14:01:27 UTC (rev 99560)
@@ -42,7 +42,7 @@
CSSValue* imageValue() const { return m_image.get(); }
-virtual void addSubresourceStyleURLs(ListHashSetKURL, const CSSStyleSheet*);
+void addSubresourceStyleURLs(ListHashSetKURL, const CSSStyleSheet*);
// The border image.
RefPtrCSSValue m_image;
Modified: trunk/Source/WebCore/css/CSSFontFaceSrcValue.h (99559 => 99560)
--- trunk/Source/WebCore/css/CSSFontFaceSrcValue.h 2011-11-08 13:46:50 UTC (rev 99559)
+++ trunk/Source/WebCore/css/CSSFontFaceSrcValue.h 2011-11-08 14:01:27 UTC (rev 99560)
@@ -64,7 +64,7 @@
virtual String cssText() const;
-virtual void addSubresourceStyleURLs(ListHashSetKURL, const CSSStyleSheet*);
+void addSubresourceStyleURLs(ListHashSetKURL, const CSSStyleSheet*);
private:
CSSFontFaceSrcValue(const String resource, bool local)
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.h (99559 => 99560)
--- trunk/Source/WebCore/css/CSSPrimitiveValue.h 2011-11-08 13:46:50 UTC (rev 99559)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.h 2011-11-08 14:01:27 UTC (rev 99560)
@@ -211,7 +211,7 @@
bool isQuirkValue() { return m_isQuirkValue; }
-virtual void addSubresourceStyleURLs(ListHashSetKURL, const CSSStyleSheet*);
+void addSubresourceStyleURLs(ListHashSetKURL, const CSSStyleSheet*);
protected:
CSSPrimitiveValue(ClassType, int ident);
Modified: trunk/Source/WebCore/css/CSSReflectValue.h (99559 => 99560)
--- trunk/Source/WebCore/css/CSSReflectValue.h 2011-11-08 13:46:50 UTC (rev 99559)
+++ trunk/Source/WebCore/css/CSSReflectValue.h 2011-11-08 14:01:27 UTC (rev 99560)
@@ -49,7 +49,7 @@
virtual String cssText() const;
-virtual void addSubresourceStyleURLs(ListHashSetKURL, const CSSStyleSheet*);
+void addSubresourceStyleURLs(ListHashSetKURL, const CSSStyleSheet*);
private:
CSSReflectValue(CSSReflectionDirection direction, PassRefPtrCSSPrimitiveValue offset, PassRefPtrCSSValue mask)
Modified: trunk/Source/WebCore/css/CSSValue.cpp (99559 => 99560)
--- trunk/Source/WebCore/css/CSSValue.cpp 2011-11-08 13:46:50 UTC (rev 99559)
+++ trunk/Source/WebCore/css/CSSValue.cpp 2011-11-08 14:01:27 UTC (rev 99560)
@@ -27,6 +27,12 @@
#include config.h
#include CSSValue.h
+#include CSSBorderImageValue.h
+#include CSSFontFaceSrcValue.h
+#include CSSPrimitiveValue.h
+#include CSSReflectValue.h
+#include CSSValueList.h
+
namespace WebCore {
CSSValue::Type CSSValue::cssValueType() const
@@ -42,4 +48,18 @@
return CSS_CUSTOM;
}
+void CSSValue::addSubresourceStyleURLs(ListHashSetKURL urls, const CSSStyleSheet* styleSheet)
+{
+if (isPrimitiveValue())
+static_castCSSPrimitiveValue*(this)-addSubresourceStyleURLs(urls, styleSheet);
+else
[webkit-changes] [99562] trunk/LayoutTests
Title: [99562] trunk/LayoutTests Revision 99562 Author zimmerm...@webkit.org Date 2011-11-08 06:19:40 -0800 (Tue, 08 Nov 2011) Log Message 2011-11-08 Nikolas Zimmermann nzimmerm...@rim.com [Chromium] SVG test failures after r99539 https://bugs.webkit.org/show_bug.cgi?id=71793 Reviewed by Zoltan Herczeg. It turns out that some of these tests are flakey. Replace animate elements with set. That still tests repaint, but there's no need to run a 100ms animation, and then sample it after 400ms. That cries for problems if the machine is slow or loaded. I left the 400ms sample snapshot for now, we can still relax it later. * fast/backgrounds/resources/animated-rect-relative-size.svg: * svg/as-background-image/resources/animated-rect-relative-size.svg: * svg/as-image/resources/animated-rect-fixed-size.svg: * svg/as-image/resources/animated-rect-relative-size.svg: * svg/as-image/resources/animated-rect-same-image.svg: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/backgrounds/resources/animated-rect-relative-size.svg trunk/LayoutTests/svg/as-background-image/resources/animated-rect-relative-size.svg trunk/LayoutTests/svg/as-image/resources/animated-rect-fixed-size.svg trunk/LayoutTests/svg/as-image/resources/animated-rect-relative-size.svg trunk/LayoutTests/svg/as-image/resources/animated-rect-same-image.svg Diff Modified: trunk/LayoutTests/ChangeLog (99561 => 99562) --- trunk/LayoutTests/ChangeLog 2011-11-08 14:14:35 UTC (rev 99561) +++ trunk/LayoutTests/ChangeLog 2011-11-08 14:19:40 UTC (rev 99562) @@ -1,3 +1,22 @@ +2011-11-08 Nikolas Zimmermann nzimmerm...@rim.com + +[Chromium] SVG test failures after r99539 +https://bugs.webkit.org/show_bug.cgi?id=71793 + +Reviewed by Zoltan Herczeg. + +It turns out that some of these tests are flakey. Replace animate elements with set. +That still tests repaint, but there's no need to run a 100ms animation, and then sample it after 400ms. +That cries for problems if the machine is slow or loaded. + +I left the 400ms sample snapshot for now, we can still relax it later. + +* fast/backgrounds/resources/animated-rect-relative-size.svg: +* svg/as-background-image/resources/animated-rect-relative-size.svg: +* svg/as-image/resources/animated-rect-fixed-size.svg: +* svg/as-image/resources/animated-rect-relative-size.svg: +* svg/as-image/resources/animated-rect-same-image.svg: + 2011-11-08 Yuta Kitamura yu...@chromium.org [Chromium] Unreviewed, add three more CG-only failures. Modified: trunk/LayoutTests/fast/backgrounds/resources/animated-rect-relative-size.svg (99561 => 99562) --- trunk/LayoutTests/fast/backgrounds/resources/animated-rect-relative-size.svg 2011-11-08 14:14:35 UTC (rev 99561) +++ trunk/LayoutTests/fast/backgrounds/resources/animated-rect-relative-size.svg 2011-11-08 14:19:40 UTC (rev 99562) @@ -21,7 +21,7 @@ text font-size=36 x=20 y=1406/text line x1=30 y1=0 x2=30 y2=100 fill=none stroke=#88 / rect x=0 y=0 width=300 height=80 fill=#44AAFF stroke=#880088 stroke-width=4 - animate attributeName=width calcMode=discrete values=300;30 keyTimes=0;.6 begin=0s dur=100ms fill=freeze/ + set attributeName=width to=30 begin=0s fill=freeze/ /rect /g /g Modified: trunk/LayoutTests/svg/as-background-image/resources/animated-rect-relative-size.svg (99561 => 99562) --- trunk/LayoutTests/svg/as-background-image/resources/animated-rect-relative-size.svg 2011-11-08 14:14:35 UTC (rev 99561) +++ trunk/LayoutTests/svg/as-background-image/resources/animated-rect-relative-size.svg 2011-11-08 14:19:40 UTC (rev 99562) @@ -21,7 +21,7 @@ text font-size=36 x=20 y=1406/text line x1=30 y1=0 x2=30 y2=100 fill=none stroke=#88 / rect x=0 y=0 width=300 height=80 fill=#44AAFF stroke=#880088 stroke-width=4 - animate attributeName=width calcMode=discrete values=300;30 keyTimes=0;.6 begin=0s dur=100ms fill=freeze/ + set attributeName=width to=30 begin=0s fill=freeze/ /rect /g /g Modified: trunk/LayoutTests/svg/as-image/resources/animated-rect-fixed-size.svg (99561 => 99562) --- trunk/LayoutTests/svg/as-image/resources/animated-rect-fixed-size.svg 2011-11-08 14:14:35 UTC (rev 99561) +++ trunk/LayoutTests/svg/as-image/resources/animated-rect-fixed-size.svg 2011-11-08 14:19:40 UTC (rev 99562) @@ -21,7 +21,7 @@ text font-size=36 x=20 y=1406/text line x1=30 y1=0 x2=30 y2=100 fill=none stroke=#88 / rect x=0 y=0 width=300 height=80 fill=#44AAFF stroke=#880088 stroke-width=4 - animate attributeName=width calcMode=discrete values=300;30 keyTimes=0;.6 begin=0s dur=100ms fill=freeze/ + set
[webkit-changes] [99563] trunk/Source/WebCore
Title: [99563] trunk/Source/WebCore
Revision 99563
Author pfeld...@chromium.org
Date 2011-11-08 06:36:47 -0800 (Tue, 08 Nov 2011)
Log Message
Web Inspector: add _javascript_ keywords to the autocomplete.
https://bugs.webkit.org/show_bug.cgi?id=71782
Reviewed by Yury Semikhatsky.
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._completions.receivedPropertyNames):
(WebInspector.ConsoleView.prototype._completions):
(WebInspector.ConsoleView.prototype._reportCompletions):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ConsoleView.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (99562 => 99563)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 14:19:40 UTC (rev 99562)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 14:36:47 UTC (rev 99563)
@@ -1,3 +1,15 @@
+2011-11-08 Pavel Feldman pfeld...@google.com
+
+Web Inspector: add _javascript_ keywords to the autocomplete.
+https://bugs.webkit.org/show_bug.cgi?id=71782
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/ConsoleView.js:
+(WebInspector.ConsoleView.prototype._completions.receivedPropertyNames):
+(WebInspector.ConsoleView.prototype._completions):
+(WebInspector.ConsoleView.prototype._reportCompletions):
+
2011-11-08 Nikolas Zimmermann nzimmerm...@rim.com
Introduce SVGLengthContext, to allow to resolve relative units to arbitary viewports
Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (99562 => 99563)
--- trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-08 14:19:40 UTC (rev 99562)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-08 14:36:47 UTC (rev 99563)
@@ -428,11 +428,11 @@
for (var i = 0; i commandLineAPI.length; ++i)
propertyNames[commandLineAPI[i]] = true;
}
-this._reportCompletions(completionsReadyCallback, dotNotation, bracketNotation, prefix, Object.keys(propertyNames));
+this._reportCompletions(completionsReadyCallback, dotNotation, bracketNotation, expressionString, prefix, Object.keys(propertyNames));
}
},
-_reportCompletions: function(completionsReadyCallback, dotNotation, bracketNotation, prefix, properties) {
+_reportCompletions: function(completionsReadyCallback, dotNotation, bracketNotation, expressionString, prefix, properties) {
if (bracketNotation) {
if (prefix.length prefix[0] === ')
var quoteUsed = ';
@@ -441,6 +441,13 @@
}
var results = [];
+
+if (!expressionString) {
+const keywords = [break, case, catch, continue, default, delete, do, else, finally, for, function, if, in,
+ instanceof, new, return, switch, this, throw, try, typeof, var, void, while, with];
+properties = properties.concat(keywords);
+}
+
properties.sort();
for (var i = 0; i properties.length; ++i) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99564] trunk
Title: [99564] trunk
Revision 99564
Author ves...@webkit.org
Date 2011-11-08 06:40:46 -0800 (Tue, 08 Nov 2011)
Log Message
[Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
If a pro file needs to access the OBJECTS_DIR it should use the
form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
after defaults_post has been processed.
Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
the command line will override whatever we set in defaults_pre.
Reviewed by Simon Hausmann.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/default_post.prf
trunk/Tools/qmake/mkspecs/features/default_pre.prf
Diff
Modified: trunk/Source/WebCore/ChangeLog (99563 => 99564)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 14:36:47 UTC (rev 99563)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 14:40:46 UTC (rev 99564)
@@ -1,3 +1,18 @@
+2011-11-08 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
+[Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
+
+If a pro file needs to access the OBJECTS_DIR it should use the
+form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
+after defaults_post has been processed.
+
+Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
+the command line will override whatever we set in defaults_pre.
+
+Reviewed by Simon Hausmann.
+
+* Target.pri:
+
2011-11-08 Pavel Feldman pfeld...@google.com
Web Inspector: add _javascript_ keywords to the autocomplete.
Modified: trunk/Source/WebCore/Target.pri (99563 => 99564)
--- trunk/Source/WebCore/Target.pri 2011-11-08 14:36:47 UTC (rev 99563)
+++ trunk/Source/WebCore/Target.pri 2011-11-08 14:40:46 UTC (rev 99564)
@@ -3787,7 +3787,7 @@
ANGLE_CFLAGS += -Wno-reorder
angle_cxx.commands = $$QMAKE_CXX -c $(CXXFLAGS) $$ANGLE_CFLAGS $(INCPATH) ${QMAKE_FILE_IN} -o ${QMAKE_FILE_OUT}
-angle_cxx.output = $$OBJECTS_DIR/${QMAKE_FILE_BASE}$$QMAKE_EXT_OBJ
+angle_cxx.output = ${QMAKE_VAR_OBJECTS_DIR}${QMAKE_FILE_BASE}$$QMAKE_EXT_OBJ
anglc_cxx.dependency_type = TYPE_C
angle_cxx.depends = $$ANGLE_HEADERS
angle_cxx.input = ANGLE_SOURCES
Modified: trunk/Tools/ChangeLog (99563 => 99564)
--- trunk/Tools/ChangeLog 2011-11-08 14:36:47 UTC (rev 99563)
+++ trunk/Tools/ChangeLog 2011-11-08 14:40:46 UTC (rev 99564)
@@ -1,5 +1,21 @@
2011-11-08 Tor Arne Vestbø tor.arne.ves...@nokia.com
+[Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
+
+If a pro file needs to access the OBJECTS_DIR it should use the
+form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
+after defaults_post has been processed.
+
+Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
+the command line will override whatever we set in defaults_pre.
+
+Reviewed by Simon Hausmann.
+
+* qmake/mkspecs/features/default_post.prf:
+* qmake/mkspecs/features/default_pre.prf:
+
+2011-11-08 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
[Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
Reviewed by Simon Hausmann.
Modified: trunk/Tools/qmake/mkspecs/features/default_post.prf (99563 => 99564)
--- trunk/Tools/qmake/mkspecs/features/default_post.prf 2011-11-08 14:36:47 UTC (rev 99563)
+++ trunk/Tools/qmake/mkspecs/features/default_post.prf 2011-11-08 14:40:46 UTC (rev 99564)
@@ -19,10 +19,19 @@
}
}
+# Help keep the build tree clean
+MOC_DIR = moc
+RCC_DIR = rcc
+
+!CONFIG(release, debug|release): OBJECTS_DIR = obj/debug
+else: OBJECTS_DIR = obj/release
+
# General default build tweaks
DEFINES += \
BUILDING_QT__=1
+CONFIG(release, debug|release): DEFINES *= NDEBUG
+
CONFIG += depend_includepath
DEPENDPATH += $$OUT_PWD
Modified: trunk/Tools/qmake/mkspecs/features/default_pre.prf (99563 => 99564)
--- trunk/Tools/qmake/mkspecs/features/default_pre.prf 2011-11-08 14:36:47 UTC (rev 99563)
+++ trunk/Tools/qmake/mkspecs/features/default_pre.prf 2011-11-08 14:40:46 UTC (rev 99564)
@@ -103,14 +103,3 @@
CONFIG += include_webinspector
*sh4*: CONFIG += disable_uitools
-
-# Help keep the build tree clean
-MOC_DIR = moc
-RCC_DIR = rcc
-
-!CONFIG(release, debug|release) {
-OBJECTS_DIR = obj/debug
-} else { # Release
-OBJECTS_DIR = obj/release
-DEFINES *= NDEBUG
-}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99565] trunk
Title: [99565] trunk
Revision 99565
Author gav...@chromium.org
Date 2011-11-08 06:42:25 -0800 (Tue, 08 Nov 2011)
Log Message
Fix width of m_type in CachedResource
https://bugs.webkit.org/show_bug.cgi?id=71727
Reviewed by Nate Chapin.
Source/WebCore:
Test: fast/dom/HTMLLinkElement/cachedresource-types.html
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
* loader/cache/CachedResource.h:
LayoutTests:
* fast/dom/HTMLLinkElement/cachedresource-types-expected.txt: Added.
* fast/dom/HTMLLinkElement/cachedresource-types.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedResource.cpp
trunk/Source/WebCore/loader/cache/CachedResource.h
Added Paths
trunk/LayoutTests/fast/dom/HTMLLinkElement/cachedresource-types-expected.txt
trunk/LayoutTests/fast/dom/HTMLLinkElement/cachedresource-types.html
Diff
Modified: trunk/LayoutTests/ChangeLog (99564 => 99565)
--- trunk/LayoutTests/ChangeLog 2011-11-08 14:40:46 UTC (rev 99564)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 14:42:25 UTC (rev 99565)
@@ -1,3 +1,13 @@
+2011-11-08 Gavin Peters gav...@chromium.org
+
+Fix width of m_type in CachedResource
+https://bugs.webkit.org/show_bug.cgi?id=71727
+
+Reviewed by Nate Chapin.
+
+* fast/dom/HTMLLinkElement/cachedresource-types-expected.txt: Added.
+* fast/dom/HTMLLinkElement/cachedresource-types.html: Added.
+
2011-11-08 Nikolas Zimmermann nzimmerm...@rim.com
[Chromium] SVG test failures after r99539
Added: trunk/LayoutTests/fast/dom/HTMLLinkElement/cachedresource-types-expected.txt (0 => 99565)
--- trunk/LayoutTests/fast/dom/HTMLLinkElement/cachedresource-types-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLLinkElement/cachedresource-types-expected.txt 2011-11-08 14:42:25 UTC (rev 99565)
@@ -0,0 +1 @@
+ This test passes if it does not crash.
Added: trunk/LayoutTests/fast/dom/HTMLLinkElement/cachedresource-types.html (0 => 99565)
--- trunk/LayoutTests/fast/dom/HTMLLinkElement/cachedresource-types.html (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLLinkElement/cachedresource-types.html 2011-11-08 14:42:25 UTC (rev 99565)
@@ -0,0 +1,9 @@
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+/script
+link rel=subresource href=""
+img src=""
+
+This test passes if it does not crash.
Modified: trunk/Source/WebCore/ChangeLog (99564 => 99565)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 14:40:46 UTC (rev 99564)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 14:42:25 UTC (rev 99565)
@@ -1,3 +1,16 @@
+2011-11-08 Gavin Peters gav...@chromium.org
+
+Fix width of m_type in CachedResource
+https://bugs.webkit.org/show_bug.cgi?id=71727
+
+Reviewed by Nate Chapin.
+
+Test: fast/dom/HTMLLinkElement/cachedresource-types.html
+
+* loader/cache/CachedResource.cpp:
+(WebCore::CachedResource::CachedResource):
+* loader/cache/CachedResource.h:
+
2011-11-08 Tor Arne Vestbø tor.arne.ves...@nokia.com
[Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
Modified: trunk/Source/WebCore/loader/cache/CachedResource.cpp (99564 => 99565)
--- trunk/Source/WebCore/loader/cache/CachedResource.cpp 2011-11-08 14:40:46 UTC (rev 99564)
+++ trunk/Source/WebCore/loader/cache/CachedResource.cpp 2011-11-08 14:42:25 UTC (rev 99565)
@@ -112,6 +112,7 @@
, m_resourceToRevalidate(0)
, m_proxyResource(0)
{
+ASSERT(m_type == unsigned(type)); // m_type is a bitfield, so this tests careless updates of the enum.
#ifndef NDEBUG
cachedResourceLeakCounter.increment();
#endif
Modified: trunk/Source/WebCore/loader/cache/CachedResource.h (99564 => 99565)
--- trunk/Source/WebCore/loader/cache/CachedResource.h 2011-11-08 14:40:46 UTC (rev 99564)
+++ trunk/Source/WebCore/loader/cache/CachedResource.h 2011-11-08 14:42:25 UTC (rev 99565)
@@ -290,7 +290,7 @@
bool m_inCache : 1;
bool m_loading : 1;
-unsigned m_type : 3; // Type
+unsigned m_type : 4; // Type
unsigned m_status : 3; // Status
#ifndef NDEBUG
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99566] trunk/LayoutTests
Title: [99566] trunk/LayoutTests
Revision 99566
Author zimmerm...@webkit.org
Date 2011-11-08 07:16:16 -0800 (Tue, 08 Nov 2011)
Log Message
2011-11-08 Nikolas Zimmermann nzimmerm...@rim.com
[Qt] 4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253
Reviewed by Rob Buis.
Address some problems seen on Qt/Chromium:
- Remove the scaled png which is the source of the problem in zoom-background-images.html, we really only want to test zooming in the SVGImage there.
- Don't zoom out more than three times, otherwise its ignored on Mac/DRT, where the minimum zoom factor is clamped to 0.5f.
Qt doesn't have this limit, and currently zooms more than Mac does. There's no need to zoom out that often, three times is enough.
* platform/mac/svg/zoom/page/zoom-background-images-expected.png: Updated.
* platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Update.
* svg/zoom/page/zoom-background-image-tiled.html: Don't set shouldZoomOut to false, it's the default.
* svg/zoom/page/zoom-background-images.html: Don't zoom out more than three times.
* svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm: Ditto.
* svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Ditto.
* svg/zoom/page/zoom-svg-as-image.html: There is no shouldZoomIn, just remove it, zooming in is the default.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/svg/zoom/page/zoom-background-images-expected.png
trunk/LayoutTests/platform/mac/svg/zoom/page/zoom-background-images-expected.txt
trunk/LayoutTests/svg/zoom/page/zoom-background-image-tiled.html
trunk/LayoutTests/svg/zoom/page/zoom-background-images.html
trunk/LayoutTests/svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm
trunk/LayoutTests/svg/zoom/page/zoom-svg-as-background-with-relative-size.html
trunk/LayoutTests/svg/zoom/page/zoom-svg-as-image.html
Diff
Modified: trunk/LayoutTests/ChangeLog (99565 => 99566)
--- trunk/LayoutTests/ChangeLog 2011-11-08 14:42:25 UTC (rev 99565)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 15:16:16 UTC (rev 99566)
@@ -1,3 +1,23 @@
+2011-11-08 Nikolas Zimmermann nzimmerm...@rim.com
+
+[Qt] 4 new tests fail introduced in r98852
+https://bugs.webkit.org/show_bug.cgi?id=71253
+
+Reviewed by Rob Buis.
+
+Address some problems seen on Qt/Chromium:
+- Remove the scaled png which is the source of the problem in zoom-background-images.html, we really only want to test zooming in the SVGImage there.
+- Don't zoom out more than three times, otherwise its ignored on Mac/DRT, where the minimum zoom factor is clamped to 0.5f.
+ Qt doesn't have this limit, and currently zooms more than Mac does. There's no need to zoom out that often, three times is enough.
+
+* platform/mac/svg/zoom/page/zoom-background-images-expected.png: Updated.
+* platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Update.
+* svg/zoom/page/zoom-background-image-tiled.html: Don't set shouldZoomOut to false, it's the default.
+* svg/zoom/page/zoom-background-images.html: Don't zoom out more than three times.
+* svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm: Ditto.
+* svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Ditto.
+* svg/zoom/page/zoom-svg-as-image.html: There is no shouldZoomIn, just remove it, zooming in is the default.
+
2011-11-08 Gavin Peters gav...@chromium.org
Fix width of m_type in CachedResource
Modified: trunk/LayoutTests/platform/mac/svg/zoom/page/zoom-background-images-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/mac/svg/zoom/page/zoom-background-images-expected.txt (99565 => 99566)
--- trunk/LayoutTests/platform/mac/svg/zoom/page/zoom-background-images-expected.txt 2011-11-08 14:42:25 UTC (rev 99565)
+++ trunk/LayoutTests/platform/mac/svg/zoom/page/zoom-background-images-expected.txt 2011-11-08 15:16:16 UTC (rev 99566)
@@ -13,9 +13,6 @@
RenderText {#text} at (457,143) size 2x10
text run at (457,143) width 2:
RenderImage {IMG} at (470,11) size 129x129 [border: (1px solid #00)]
- RenderText {#text} at (610,143) size 2x10
-text run at (610,143) width 2:
- RenderImage {IMG} at (623,11) size 129x129 [border: (1px solid #00)]
RenderText {#text} at (0,0) size 0x0
RenderText {#text} at (0,0) size 0x0
RenderText {#text} at (0,0) size 0x0
Modified: trunk/LayoutTests/svg/zoom/page/zoom-background-image-tiled.html (99565 => 99566)
--- trunk/LayoutTests/svg/zoom/page/zoom-background-image-tiled.html 2011-11-08 14:42:25 UTC (rev 99565)
+++ trunk/LayoutTests/svg/zoom/page/zoom-background-image-tiled.html 2011-11-08 15:16:16 UTC (rev 99566)
@@ -17,7 +17,7 @@
body
div/div
-scriptvar zoomCount = 4; window.shouldZoomOut = false;/script
[webkit-changes] [99568] trunk/Source/WebKit2
Title: [99568] trunk/Source/WebKit2
Revision 99568
Author kenn...@webkit.org
Date 2011-11-08 07:34:07 -0800 (Tue, 08 Nov 2011)
Log Message
Clean up QtViewportInteractionEngine
Reviewed by Simon Hausmann.
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
Rename the method to make it more obvious what it does. Avoid implicit
conversion to/from QVariant.
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::itemSizeChanged):
Only call this method on item size changes, and not for every interaction
with the viewport item. Before this change it was even being called during
animations.
* UIProcess/qt/QtViewportInteractionEngine.h:
(WebKit::QtViewportInteractionEngine::scaleAnimationValueChanged):
Rename to make it clean that this is called from the animator.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (99567 => 99568)
--- trunk/Source/WebKit2/ChangeLog 2011-11-08 15:29:58 UTC (rev 99567)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-08 15:34:07 UTC (rev 99568)
@@ -1,5 +1,31 @@
2011-11-08 Kenneth Rohde Christiansen kenn...@webkit.org
+Clean up QtViewportInteractionEngine
+
+Reviewed by Simon Hausmann.
+
+* UIProcess/qt/QtViewportInteractionEngine.cpp:
+(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
+(WebKit::QtViewportInteractionEngine::setItemRectVisible):
+
+Rename the method to make it more obvious what it does. Avoid implicit
+conversion to/from QVariant.
+
+(WebKit::QtViewportInteractionEngine::pagePositionRequest):
+(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
+(WebKit::QtViewportInteractionEngine::itemSizeChanged):
+
+Only call this method on item size changes, and not for every interaction
+with the viewport item. Before this change it was even being called during
+animations.
+
+* UIProcess/qt/QtViewportInteractionEngine.h:
+(WebKit::QtViewportInteractionEngine::scaleAnimationValueChanged):
+
+Rename to make it clean that this is called from the animator.
+
+2011-11-08 Kenneth Rohde Christiansen kenn...@webkit.org
+
[Qt] Improve the animation time constant
https://bugs.webkit.org/show_bug.cgi?id=71790
Modified: trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp (99567 => 99568)
--- trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp 2011-11-08 15:29:58 UTC (rev 99567)
+++ trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp 2011-11-08 15:34:07 UTC (rev 99568)
@@ -100,14 +100,14 @@
, m_pinchStartScale(1.f)
{
reset();
-connect(m_content, SIGNAL(xChanged()), this, SLOT(contentViewportChanged()), Qt::DirectConnection);
-connect(m_content, SIGNAL(yChanged()), this, SLOT(contentViewportChanged()), Qt::DirectConnection);
-connect(m_content, SIGNAL(widthChanged()), this, SLOT(contentViewportChanged()), Qt::DirectConnection);
-connect(m_content, SIGNAL(heightChanged()), this, SLOT(contentViewportChanged()), Qt::DirectConnection);
-connect(m_content, SIGNAL(scaleChanged()), this, SLOT(contentViewportChanged()), Qt::DirectConnection);
-connect(m_scaleAnimation, SIGNAL(valueChanged(QVariant)), SLOT(updateVisibleRect(QVariant)), Qt::DirectConnection);
-connect(m_scaleAnimation, SIGNAL(stateChanged(QAbstractAnimation::State, QAbstractAnimation::State))
-, SLOT(scaleAnimationStateChanged(QAbstractAnimation::State, QAbstractAnimation::State)), Qt::DirectConnection);
+
+connect(m_content, SIGNAL(widthChanged()), this, SLOT(itemSizeChanged()), Qt::DirectConnection);
+connect(m_content, SIGNAL(heightChanged()), this, SLOT(itemSizeChanged()), Qt::DirectConnection);
+
+connect(m_scaleAnimation, SIGNAL(valueChanged(QVariant)),
+SLOT(scaleAnimationValueChanged(QVariant)), Qt::DirectConnection);
+connect(m_scaleAnimation, SIGNAL(stateChanged(QAbstractAnimation::State, QAbstractAnimation::State)),
+SLOT(scaleAnimationStateChanged(QAbstractAnimation::State, QAbstractAnimation::State)), Qt::DirectConnection);
}
QtViewportInteractionEngine::~QtViewportInteractionEngine()
@@ -130,18 +130,17 @@
return innerBoundedCSSScale(cssScale);
}
-void QtViewportInteractionEngine::updateVisibleRect(QVariant rect)
+void QtViewportInteractionEngine::setItemRectVisible(const QRectF itemRect)
{
ViewportUpdateGuard guard(this);
-QRectF visibleRect = rect.toRectF();
-qreal itemScale = m_viewport-width()
[webkit-changes] [99569] trunk/Tools
Title: [99569] trunk/Tools Revision 99569 Author o...@webkit.org Date 2011-11-08 07:40:33 -0800 (Tue, 08 Nov 2011) Log Message [Qt] Unreviewed trivial fix after build system refactoring. * Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-qtwebkit-tests Diff Modified: trunk/Tools/ChangeLog (99568 => 99569) --- trunk/Tools/ChangeLog 2011-11-08 15:34:07 UTC (rev 99568) +++ trunk/Tools/ChangeLog 2011-11-08 15:40:33 UTC (rev 99569) @@ -1,3 +1,9 @@ +2011-11-08 Csaba Osztrogonác o...@webkit.org + +[Qt] Unreviewed trivial fix after build system refactoring. + +* Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests. + 2011-11-08 Tor Arne Vestbø tor.arne.ves...@nokia.com [Qt] Don't set OBJECTS_DIR and DEFINES in default_pre Modified: trunk/Tools/Scripts/run-qtwebkit-tests (99568 => 99569) --- trunk/Tools/Scripts/run-qtwebkit-tests 2011-11-08 15:34:07 UTC (rev 99568) +++ trunk/Tools/Scripts/run-qtwebkit-tests 2011-11-08 15:40:33 UTC (rev 99569) @@ -213,7 +213,7 @@ qml_import_path += : + self._options.path + ../../../../../../imports os.putenv(QML_IMPORT_PATH, qml_import_path) path = os.getenv(PATH) -path += : + self._options.path + ../../../../../bin +path += : + self._options.path + ../../../../../../bin os.putenv(PATH, path) self.debug(Searching executables...) tests_executables = self.find_tests_paths(self._options.path) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99570] trunk/Source/WebKit2
Title: [99570] trunk/Source/WebKit2
Revision 99570
Author caio.olive...@openbossa.org
Date 2011-11-08 08:21:26 -0800 (Tue, 08 Nov 2011)
Log Message
[Qt] Workaround some problems in QML API tests
https://bugs.webkit.org/show_bug.cgi?id=71818
Reviewed by Tor Arne Vestbø.
This commit workaround the issue of QML's QtTest crashing when we run tests after
windowShown. We delay to the next run of the mainloop. This workaround is not
pretty but shouldn't affect the semantics of the tests. And we benefit more from
having working tests right now.
This patch also improves Download to: wait for the load before emitting click, and
properly identifying the succeeded signal of the downloadItem object.
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml
Diff
Modified: trunk/Source/WebKit2/ChangeLog (99569 => 99570)
--- trunk/Source/WebKit2/ChangeLog 2011-11-08 15:40:33 UTC (rev 99569)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-08 16:21:26 UTC (rev 99570)
@@ -1,3 +1,22 @@
+2011-11-08 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org
+
+[Qt] Workaround some problems in QML API tests
+https://bugs.webkit.org/show_bug.cgi?id=71818
+
+Reviewed by Tor Arne Vestbø.
+
+This commit workaround the issue of QML's QtTest crashing when we run tests after
+windowShown. We delay to the next run of the mainloop. This workaround is not
+pretty but shouldn't affect the semantics of the tests. And we benefit more from
+having working tests right now.
+
+This patch also improves Download to: wait for the load before emitting click, and
+properly identifying the succeeded signal of the downloadItem object.
+
+* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml:
+* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
+* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml:
+
2011-11-08 Kenneth Rohde Christiansen kenn...@webkit.org
Clean up QtViewportInteractionEngine
Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml (99569 => 99570)
--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml 2011-11-08 15:40:33 UTC (rev 99569)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml 2011-11-08 16:21:26 UTC (rev 99570)
@@ -7,10 +7,17 @@
width: 200
height: 400
-property int expectedLength : 0
-property int totalBytes : 0
+property int expectedLength: 0
+property bool downloadFinished: false
+property int totalBytes: 0
SignalSpy {
+id: loadSpy
+target: webView
+signalName: loadSucceeded
+}
+
+SignalSpy {
id: spy
target: webView
signalName: downloadRequested
@@ -26,32 +33,45 @@
Connections {
id: download
ignoreUnknownSignals: true
-onSucceeded: { totalBytes = download.target.totalBytesReceived }
+onSucceeded: {
+downloadFinished = true
+totalBytes = download.target.totalBytesReceived
+}
}
-SignalSpy {
-id: otherSpy
-target: download
-signalName: succeeded
-}
-
TestCase {
name: DesktopWebViewDownload
-when: windowShown
+// Delayed windowShown to workaround problems with Qt5 in debug mode.
+when: false
+Timer {
+running: parent.windowShown
+repeat: false
+interval: 1
+onTriggered: parent.when = true
+}
+
+function init() {
+spy.clear()
+loadSpy.clear()
+expectedLength = 0
+downloadFinished = false
+totalBytes = 0
+}
+
function test_downloadRequest() {
-spy.clear()
compare(spy.count, 0)
webView.load(Qt.resolvedUrl(../common/download.html))
+loadSpy.wait()
mouseClick(webView, 100, 100, Qt.LeftButton)
spy.wait()
compare(spy.count, 1)
}
function test_expectedLength() {
-spy.clear()
compare(spy.count, 0)
webView.load(Qt.resolvedUrl(../common/download.html))
+loadSpy.wait()
mouseClick(webView, 100, 100, Qt.LeftButton)
spy.wait()
compare(spy.count, 1)
@@ -59,16 +79,13 @@
}
[webkit-changes] [99571] trunk
Title: [99571] trunk
Revision 99571
Author ves...@webkit.org
Date 2011-11-08 08:22:16 -0800 (Tue, 08 Nov 2011)
Log Message
[Qt] Use qmake's builtin rules for copying framework headers on Mac OS
Now that we generate the forwarding headers eiher as part of QtWebKit.pro
(for Qt 4.8), or as part of the root project file (for Qt 5), we can assume
that the files are there and use $$files() to list the files to be copied.
Reviewed by Csaba Osztrogonác.
Modified Paths
trunk/ChangeLog
trunk/Source/api.pri
Diff
Modified: trunk/ChangeLog (99570 => 99571)
--- trunk/ChangeLog 2011-11-08 16:21:26 UTC (rev 99570)
+++ trunk/ChangeLog 2011-11-08 16:22:16 UTC (rev 99571)
@@ -1,3 +1,15 @@
+2011-11-08 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
+[Qt] Use qmake's builtin rules for copying framework headers on Mac OS
+
+Now that we generate the forwarding headers eiher as part of QtWebKit.pro
+(for Qt 4.8), or as part of the root project file (for Qt 5), we can assume
+that the files are there and use $$files() to list the files to be copied.
+
+Reviewed by Csaba Osztrogonác.
+
+* Source/api.pri:
+
2011-11-08 Yuqiang Xian yuqiang.x...@intel.com
Enable DFG JIT by default on X86 Linux and Mac platforms
Modified: trunk/Source/api.pri (99570 => 99571)
--- trunk/Source/api.pri 2011-11-08 16:21:26 UTC (rev 99570)
+++ trunk/Source/api.pri 2011-11-08 16:22:16 UTC (rev 99571)
@@ -200,23 +200,9 @@
CONFIG += lib_bundle qt_no_framework_direct_includes qt_framework
FRAMEWORK_HEADERS.version = Versions
-FRAMEWORK_HEADERS.files = $$dirname(headers.files)/QtWebKit
+FRAMEWORK_HEADERS.files = $$files($$headers.files, false)
FRAMEWORK_HEADERS.path = Headers
QMAKE_BUNDLE_DATA += FRAMEWORK_HEADERS
-
-# No-op to satisfy the dependency for FRAMEWORK_HEADERS
-module_include.target = $$dirname(headers.files)/QtWebKit
-module_include.commands = $${MAKEFILE_NOOP_COMMAND}
-contains(QMAKE_EXTRA_TARGETS, fwheader_generator): module_include.depends += fwheader_generator
-QMAKE_EXTRA_TARGETS += module_include
-
-# Qmake assumes that FRAMEWORK_HEADERS.files is a list of files, but we dont' know that
-# until the forwarding headers have been generated, so we have to copy them manually.
-copy_framework_headers.commands = $(COPY_DIR) $$headers.files $${DESTDIR}/$${TARGET}.framework/$${FRAMEWORK_HEADERS.path}/
-contains(QMAKE_EXTRA_TARGETS, fwheader_generator): copy_framework_headers.depends += fwheader_generator
-copy_framework_headers.depends += all
-QMAKE_EXTRA_TARGETS += copy_framework_headers
-DEFAULT_TARGETS += copy_framework_headers
}
QMAKE_LFLAGS_SONAME = $${QMAKE_LFLAGS_SONAME}$${DESTDIR}$${QMAKE_DIR_SEP}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99572] trunk/LayoutTests
Title: [99572] trunk/LayoutTests
Revision 99572
Author zimmerm...@webkit.org
Date 2011-11-08 08:26:26 -0800 (Tue, 08 Nov 2011)
Log Message
2011-11-08 Nikolas Zimmermann nzimmerm...@rim.com
Not reviewed. Rebaseline qt results after the recent SVGImage changes.
* platform/qt/Skipped:
* platform/qt/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
* platform/qt/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-background-images-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-background-images-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt
Added Paths
trunk/LayoutTests/platform/qt/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt
trunk/LayoutTests/platform/qt/svg/as-image/animated-svg-as-image-same-image-expected.txt
trunk/LayoutTests/platform/qt/svg/zoom/page/zoom-background-images-expected.png
trunk/LayoutTests/platform/qt/svg/zoom/page/zoom-background-images-expected.txt
trunk/LayoutTests/platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png
trunk/LayoutTests/platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (99571 => 99572)
--- trunk/LayoutTests/ChangeLog 2011-11-08 16:22:16 UTC (rev 99571)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 16:26:26 UTC (rev 99572)
@@ -1,5 +1,18 @@
2011-11-08 Nikolas Zimmermann nzimmerm...@rim.com
+Not reviewed. Rebaseline qt results after the recent SVGImage changes.
+
+* platform/qt/Skipped:
+* platform/qt/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
+* platform/qt/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
+* platform/qt/svg/zoom/page/zoom-background-images-expected.png: Added.
+* platform/qt/svg/zoom/page/zoom-background-images-expected.txt: Added.
+* platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
+* platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
+* platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
+
+2011-11-08 Nikolas Zimmermann nzimmerm...@rim.com
+
[Qt] 4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253
Modified: trunk/LayoutTests/platform/qt/Skipped (99571 => 99572)
--- trunk/LayoutTests/platform/qt/Skipped 2011-11-08 16:22:16 UTC (rev 99571)
+++ trunk/LayoutTests/platform/qt/Skipped 2011-11-08 16:26:26 UTC (rev 99572)
@@ -2473,9 +2473,7 @@
# [Qt] 4 new tests fail introduced in r98852
# https://bugs.webkit.org/show_bug.cgi?id=71253
-svg/zoom/page/zoom-background-images.html
svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html
-svg/zoom/page/zoom-svg-as-background-with-relative-size.html
fast/backgrounds/size/contain-and-cover-zoomed.html
# new bug revealed by r99071
Added: trunk/LayoutTests/platform/qt/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt (0 => 99572)
--- trunk/LayoutTests/platform/qt/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt 2011-11-08 16:26:26 UTC (rev 99572)
@@ -0,0 +1,11 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x21
+RenderText {#text} at (0,0) size 411x21
+ text run at (0,0) width 411: Images should redraw correctly when SVG animation runs
+ RenderBlock (anonymous) at (0,37) size 784x500
+RenderImage {IMG} at (10,10) size 480x480
+RenderText {#text} at (0,0) size 0x0
Added: trunk/LayoutTests/platform/qt/svg/as-image/animated-svg-as-image-same-image-expected.txt (0 => 99572)
--- trunk/LayoutTests/platform/qt/svg/as-image/animated-svg-as-image-same-image-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/svg/as-image/animated-svg-as-image-same-image-expected.txt 2011-11-08 16:26:26 UTC (rev 99572)
@@ -0,0 +1,13 @@
+layer at (0,0) size 784x601
+ RenderView at (0,0) size 784x600
+layer at (0,0) size 784x601
+ RenderBlock {HTML} at (0,0) size 784x601
+RenderBody {BODY} at (8,8) size 768x585
+ RenderBlock
[webkit-changes] [99573] trunk/Source/WebCore
Title: [99573] trunk/Source/WebCore
Revision 99573
Author ca...@chromium.org
Date 2011-11-08 08:38:04 -0800 (Tue, 08 Nov 2011)
Log Message
Web Inspector: add Evaluate in console as a shortcut and context menu items to scripts panel
https://bugs.webkit.org/show_bug.cgi?id=71817
Reviewed by Pavel Feldman.
* English.lproj/localizedStrings.js:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.evaluate):
(WebInspector.ConsoleView.prototype._enterKeyPressed):
* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame.prototype.populateTextAreaContextMenu):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._evaluateSelectionInConsole):
* inspector/front-end/ShortcutsScreen.js:
(WebInspector.ShortcutsSection.prototype.addRelatedKeys):
(WebInspector.ShortcutsSection.prototype.addAlternateKeys):
* inspector/front-end/externs.js:
(WebInspector.evaluateInConsole):
* inspector/front-end/inspector.js:
(WebInspector.evaluateInConsole):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/ConsoleView.js
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/ShortcutsScreen.js
trunk/Source/WebCore/inspector/front-end/externs.js
trunk/Source/WebCore/inspector/front-end/inspector.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (99572 => 99573)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 16:26:26 UTC (rev 99572)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 16:38:04 UTC (rev 99573)
@@ -1,3 +1,26 @@
+2011-11-08 Andrey Kosyakov ca...@chromium.org
+
+Web Inspector: add Evaluate in console as a shortcut and context menu items to scripts panel
+https://bugs.webkit.org/show_bug.cgi?id=71817
+
+Reviewed by Pavel Feldman.
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/ConsoleView.js:
+(WebInspector.ConsoleView.prototype.evaluate):
+(WebInspector.ConsoleView.prototype._enterKeyPressed):
+* inspector/front-end/_javascript_SourceFrame.js:
+(WebInspector._javascript_SourceFrame.prototype.populateTextAreaContextMenu):
+* inspector/front-end/ScriptsPanel.js:
+(WebInspector.ScriptsPanel.prototype._evaluateSelectionInConsole):
+* inspector/front-end/ShortcutsScreen.js:
+(WebInspector.ShortcutsSection.prototype.addRelatedKeys):
+(WebInspector.ShortcutsSection.prototype.addAlternateKeys):
+* inspector/front-end/externs.js:
+(WebInspector.evaluateInConsole):
+* inspector/front-end/inspector.js:
+(WebInspector.evaluateInConsole):
+
2011-11-08 Andreas Kling kl...@webkit.org
CSSValue: Devirtualize cssText().
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js
(Binary files differ)
Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (99572 => 99573)
--- trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-08 16:26:26 UTC (rev 99572)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-08 16:38:04 UTC (rev 99573)
@@ -608,6 +608,11 @@
RuntimeAgent.evaluate(_expression_, objectGroup, includeCommandLineAPI, doNotPauseOnExceptions, this._currentEvaluationContextId(), returnByValue, evalCallback);
},
+evaluateUsingTextPrompt: function(_expression_)
+{
+this._appendCommand(_expression_, this.prompt.text);
+},
+
_enterKeyPressed: function(event)
{
if (event.altKey || event.ctrlKey || event.shiftKey)
@@ -621,8 +626,12 @@
var str = this.prompt.text;
if (!str.length)
return;
+this._appendCommand(str, );
+},
-var commandMessage = new WebInspector.ConsoleCommand(str);
+_appendCommand: function(text, newPromptText)
+{
+var commandMessage = new WebInspector.ConsoleCommand(text);
WebInspector.console.interruptRepeatCount();
this._appendConsoleMessage(commandMessage);
@@ -631,14 +640,14 @@
if (!result)
return;
-this.prompt.pushHistoryItem(str);
-this.prompt.text = ;
+this.prompt.pushHistoryItem(text);
+this.prompt.text = newPromptText;
WebInspector.settings.consoleHistory.set(this.prompt.historyData.slice(-30));
this._appendConsoleMessage(new WebInspector.ConsoleCommandResult(result, wasThrown, commandMessage, this._linkifier));
}
-this.evalInInspectedWindow(str, console, true, false, false, printResult.bind(this));
+this.evalInInspectedWindow(text, console, true, false, false, printResult.bind(this));
WebInspector.userMetrics.ConsoleEvaluated.record();
},
Modified: trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js (99572 =>
[webkit-changes] [99574] trunk/Source/WebCore
Title: [99574] trunk/Source/WebCore
Revision 99574
Author andreas.kl...@nokia.com
Date 2011-11-08 08:46:15 -0800 (Tue, 08 Nov 2011)
Log Message
CSSImageValue: Devirtualize cachedImage(CachedResourceLoader*).
http://webkit.org/b/71814
Reviewed by Antti Koivisto.
Defer to CSSCursorImageValue (the only CSSImageValue subclass)
when appropriate in CSSImageValue::cachedImage(CachedResourceLoader*).
* css/CSSCursorImageValue.h:
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
* css/CSSImageValue.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSCursorImageValue.h
trunk/Source/WebCore/css/CSSImageValue.cpp
trunk/Source/WebCore/css/CSSImageValue.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99573 => 99574)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 16:38:04 UTC (rev 99573)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 16:46:15 UTC (rev 99574)
@@ -1,3 +1,18 @@
+2011-11-08 Andreas Kling kl...@webkit.org
+
+CSSImageValue: Devirtualize cachedImage(CachedResourceLoader*).
+http://webkit.org/b/71814
+
+Reviewed by Antti Koivisto.
+
+Defer to CSSCursorImageValue (the only CSSImageValue subclass)
+when appropriate in CSSImageValue::cachedImage(CachedResourceLoader*).
+
+* css/CSSCursorImageValue.h:
+* css/CSSImageValue.cpp:
+(WebCore::CSSImageValue::cachedImage):
+* css/CSSImageValue.h:
+
2011-11-08 Andrey Kosyakov ca...@chromium.org
Web Inspector: add Evaluate in console as a shortcut and context menu items to scripts panel
Modified: trunk/Source/WebCore/css/CSSCursorImageValue.h (99573 => 99574)
--- trunk/Source/WebCore/css/CSSCursorImageValue.h 2011-11-08 16:38:04 UTC (rev 99573)
+++ trunk/Source/WebCore/css/CSSCursorImageValue.h 2011-11-08 16:46:15 UTC (rev 99574)
@@ -42,7 +42,7 @@
IntPoint hotSpot() const { return m_hotSpot; }
bool updateIfSVGCursorIsUsed(Element*);
-virtual StyleCachedImage* cachedImage(CachedResourceLoader*);
+StyleCachedImage* cachedImage(CachedResourceLoader*);
#if ENABLE(SVG)
void removeReferencedElement(SVGElement*);
Modified: trunk/Source/WebCore/css/CSSImageValue.cpp (99573 => 99574)
--- trunk/Source/WebCore/css/CSSImageValue.cpp 2011-11-08 16:38:04 UTC (rev 99573)
+++ trunk/Source/WebCore/css/CSSImageValue.cpp 2011-11-08 16:46:15 UTC (rev 99574)
@@ -21,6 +21,7 @@
#include config.h
#include CSSImageValue.h
+#include CSSCursorImageValue.h
#include CSSValueKeywords.h
#include Document.h
#include MemoryCache.h
@@ -66,6 +67,8 @@
StyleCachedImage* CSSImageValue::cachedImage(CachedResourceLoader* loader)
{
+if (isCursorImageValue())
+return static_castCSSCursorImageValue*(this)-cachedImage(loader);
return cachedImage(loader, getStringValue());
}
Modified: trunk/Source/WebCore/css/CSSImageValue.h (99573 => 99574)
--- trunk/Source/WebCore/css/CSSImageValue.h 2011-11-08 16:38:04 UTC (rev 99573)
+++ trunk/Source/WebCore/css/CSSImageValue.h 2011-11-08 16:46:15 UTC (rev 99574)
@@ -37,7 +37,7 @@
static PassRefPtrCSSImageValue create(const String url) { return adoptRef(new CSSImageValue(url)); }
virtual ~CSSImageValue();
-virtual StyleCachedImage* cachedImage(CachedResourceLoader*);
+StyleCachedImage* cachedImage(CachedResourceLoader*);
// Returns a StyleCachedImage if the image is cached already, otherwise a StylePendingImage.
StyleImage* cachedOrPendingImage();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99575] trunk/Source/WebCore
Title: [99575] trunk/Source/WebCore
Revision 99575
Author ca...@chromium.org
Date 2011-11-08 09:06:33 -0800 (Tue, 08 Nov 2011)
Log Message
Web Inspector: [Extension API][Chromium] injected extension API needs to return an object
https://bugs.webkit.org/show_bug.cgi?id=71822
Reviewed by Pavel Feldman.
* inspector/front-end/ExtensionAPI.js:
(buildExtensionAPIInjectedScript):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (99574 => 99575)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 16:46:15 UTC (rev 99574)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 17:06:33 UTC (rev 99575)
@@ -1,3 +1,13 @@
+2011-11-08 Andrey Kosyakov ca...@chromium.org
+
+Web Inspector: [Extension API][Chromium] injected extension API needs to return an object
+https://bugs.webkit.org/show_bug.cgi?id=71822
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/ExtensionAPI.js:
+(buildExtensionAPIInjectedScript):
+
2011-11-08 Andreas Kling kl...@webkit.org
CSSImageValue: Devirtualize cachedImage(CachedResourceLoader*).
Modified: trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js (99574 => 99575)
--- trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js 2011-11-08 16:46:15 UTC (rev 99574)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js 2011-11-08 17:06:33 UTC (rev 99575)
@@ -722,6 +722,7 @@
defineCommonExtensionSymbols.toString() + ; +
injectedExtensionAPI.toString() + ; +
injectedExtensionAPI(injectedScriptId); +
-(platformAPI || ) +
+(platformAPI || ) + ; +
+return {}; +
});
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99576] trunk/LayoutTests
Title: [99576] trunk/LayoutTests
Revision 99576
Author commit-qu...@webkit.org
Date 2011-11-08 09:09:17 -0800 (Tue, 08 Nov 2011)
Log Message
[GTK] fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=71774
Patch by Philippe Normand pnorm...@igalia.com on 2011-11-08
Reviewed by Martin Robinson.
* fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
Trigger the test when the iframe loaded to avoid potential
flakyness.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html
Diff
Modified: trunk/LayoutTests/ChangeLog (99575 => 99576)
--- trunk/LayoutTests/ChangeLog 2011-11-08 17:06:33 UTC (rev 99575)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 17:09:17 UTC (rev 99576)
@@ -1,3 +1,14 @@
+2011-11-08 Philippe Normand pnorm...@igalia.com
+
+[GTK] fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=71774
+
+Reviewed by Martin Robinson.
+
+* fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
+Trigger the test when the iframe loaded to avoid potential
+flakyness.
+
2011-11-08 Nikolas Zimmermann nzimmerm...@rim.com
Not reviewed. Rebaseline qt results after the recent SVGImage changes.
Modified: trunk/LayoutTests/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html (99575 => 99576)
--- trunk/LayoutTests/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html 2011-11-08 17:06:33 UTC (rev 99575)
+++ trunk/LayoutTests/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html 2011-11-08 17:09:17 UTC (rev 99576)
@@ -15,13 +15,13 @@
}
/script
/head
-body _onload_=test()
+body
stylebody { background-color: green; }/style
pTest for iframe flattening. The flattening only works inside the DRT.
pThis inner frame should be 200px in each direction, disregarding the
border, and it must not be scrollable or have scrollbars.
-piframe width=200px height=200px scrolling=no src=""
+piframe _onload_=test() width=200px height=200px scrolling=no src=""
stylebody { background-color: red; }/style
body
div style='position: absolute; width: 400px; height: 400px; left: 0; top: 0px;'/div
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99577] trunk/Source/WebCore
Title: [99577] trunk/Source/WebCore
Revision 99577
Author andreas.kl...@nokia.com
Date 2011-11-08 09:33:07 -0800 (Tue, 08 Nov 2011)
Log Message
CSSImageGeneratorValue: Devirtualize image(), isFixedSize() and fixedSize().
http://webkit.org/b/71824
Reviewed by Darin Adler.
Redirect the calls to the appropriate subclass in CSSImageGeneratorValue.cpp.
* css/CSSCanvasValue.h:
(WebCore::CSSCanvasValue::isFixedSize):
* css/CSSCrossfadeValue.h:
(WebCore::CSSCrossfadeValue::isFixedSize):
* css/CSSGradientValue.h:
(WebCore::CSSGradientValue::isFixedSize):
(WebCore::CSSGradientValue::fixedSize):
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::isFixedSize):
(WebCore::CSSImageGeneratorValue::fixedSize):
* css/CSSImageGeneratorValue.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSCanvasValue.h
trunk/Source/WebCore/css/CSSCrossfadeValue.h
trunk/Source/WebCore/css/CSSGradientValue.h
trunk/Source/WebCore/css/CSSImageGeneratorValue.cpp
trunk/Source/WebCore/css/CSSImageGeneratorValue.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99576 => 99577)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 17:09:17 UTC (rev 99576)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 17:33:07 UTC (rev 99577)
@@ -1,3 +1,25 @@
+2011-11-08 Andreas Kling kl...@webkit.org
+
+CSSImageGeneratorValue: Devirtualize image(), isFixedSize() and fixedSize().
+http://webkit.org/b/71824
+
+Reviewed by Darin Adler.
+
+Redirect the calls to the appropriate subclass in CSSImageGeneratorValue.cpp.
+
+* css/CSSCanvasValue.h:
+(WebCore::CSSCanvasValue::isFixedSize):
+* css/CSSCrossfadeValue.h:
+(WebCore::CSSCrossfadeValue::isFixedSize):
+* css/CSSGradientValue.h:
+(WebCore::CSSGradientValue::isFixedSize):
+(WebCore::CSSGradientValue::fixedSize):
+* css/CSSImageGeneratorValue.cpp:
+(WebCore::CSSImageGeneratorValue::image):
+(WebCore::CSSImageGeneratorValue::isFixedSize):
+(WebCore::CSSImageGeneratorValue::fixedSize):
+* css/CSSImageGeneratorValue.h:
+
2011-11-08 Andrey Kosyakov ca...@chromium.org
Web Inspector: [Extension API][Chromium] injected extension API needs to return an object
Modified: trunk/Source/WebCore/css/CSSCanvasValue.h (99576 => 99577)
--- trunk/Source/WebCore/css/CSSCanvasValue.h 2011-11-08 17:09:17 UTC (rev 99576)
+++ trunk/Source/WebCore/css/CSSCanvasValue.h 2011-11-08 17:33:07 UTC (rev 99577)
@@ -40,9 +40,9 @@
String customCssText() const;
-virtual PassRefPtrImage image(RenderObject*, const IntSize);
-virtual bool isFixedSize() const { return true; }
-virtual IntSize fixedSize(const RenderObject*);
+PassRefPtrImage image(RenderObject*, const IntSize);
+bool isFixedSize() const { return true; }
+IntSize fixedSize(const RenderObject*);
void setName(const String name) { m_name = name; }
Modified: trunk/Source/WebCore/css/CSSCrossfadeValue.h (99576 => 99577)
--- trunk/Source/WebCore/css/CSSCrossfadeValue.h 2011-11-08 17:09:17 UTC (rev 99576)
+++ trunk/Source/WebCore/css/CSSCrossfadeValue.h 2011-11-08 17:33:07 UTC (rev 99577)
@@ -42,9 +42,9 @@
String customCssText() const;
-virtual PassRefPtrImage image(RenderObject*, const IntSize) OVERRIDE;
-virtual bool isFixedSize() const OVERRIDE { return false; }
-virtual IntSize fixedSize(const RenderObject*) OVERRIDE;
+PassRefPtrImage image(RenderObject*, const IntSize);
+bool isFixedSize() const { return false; }
+IntSize fixedSize(const RenderObject*);
void setPercentage(PassRefPtrCSSPrimitiveValue percentage) { m_percentage = percentage; }
Modified: trunk/Source/WebCore/css/CSSGradientValue.h (99576 => 99577)
--- trunk/Source/WebCore/css/CSSGradientValue.h 2011-11-08 17:09:17 UTC (rev 99576)
+++ trunk/Source/WebCore/css/CSSGradientValue.h 2011-11-08 17:33:07 UTC (rev 99577)
@@ -46,7 +46,7 @@
class CSSGradientValue : public CSSImageGeneratorValue {
public:
-virtual PassRefPtrImage image(RenderObject*, const IntSize);
+PassRefPtrImage image(RenderObject*, const IntSize);
void setFirstX(PassRefPtrCSSPrimitiveValue val) { m_firstX = val; }
void setFirstY(PassRefPtrCSSPrimitiveValue val) { m_firstY = val; }
@@ -66,6 +66,9 @@
bool deprecatedType() const { return m_deprecatedType; } // came from -webkit-gradient
+bool isFixedSize() const { return false; }
+IntSize fixedSize(const RenderObject*) const { return IntSize(); }
+
protected:
CSSGradientValue(ClassType classType, CSSGradientRepeat repeat, bool deprecatedType = false)
: CSSImageGeneratorValue(classType)
Modified: trunk/Source/WebCore/css/CSSImageGeneratorValue.cpp (99576 => 99577)
--- trunk/Source/WebCore/css/CSSImageGeneratorValue.cpp 2011-11-08 17:09:17 UTC (rev 99576)
+++ trunk/Source/WebCore/css/CSSImageGeneratorValue.cpp 2011-11-08 17:33:07 UTC (rev
[webkit-changes] [99578] trunk/Source/WebKit/gtk
Title: [99578] trunk/Source/WebKit/gtk Revision 99578 Author commit-qu...@webkit.org Date 2011-11-08 09:36:04 -0800 (Tue, 08 Nov 2011) Log Message [WK][GTK] Application cache directory is incorrectly set https://bugs.webkit.org/show_bug.cgi?id=71769 Patch by Zan Dobersek zandober...@gmail.com on 2011-11-08 Reviewed by Martin Robinson. Set the application cache directory to be placed in current user's cache directory and update documentation for webkit_application_cache_get_database_directory_path after these changes and changes in r80715; * webkit/webkitapplicationcache.cpp: * webkit/webkitglobals.cpp: (webkitInit): Switch one string formation to use GOwnPtrgchar. Modified Paths trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/webkit/webkitapplicationcache.cpp trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp Diff Modified: trunk/Source/WebKit/gtk/ChangeLog (99577 => 99578) --- trunk/Source/WebKit/gtk/ChangeLog 2011-11-08 17:33:07 UTC (rev 99577) +++ trunk/Source/WebKit/gtk/ChangeLog 2011-11-08 17:36:04 UTC (rev 99578) @@ -1,3 +1,19 @@ +2011-11-08 Zan Dobersek zandober...@gmail.com + +[WK][GTK] Application cache directory is incorrectly set +https://bugs.webkit.org/show_bug.cgi?id=71769 + +Reviewed by Martin Robinson. + +Set the application cache directory to be placed in current user's +cache directory and update documentation for +webkit_application_cache_get_database_directory_path after these +changes and changes in r80715; + +* webkit/webkitapplicationcache.cpp: +* webkit/webkitglobals.cpp: +(webkitInit): Switch one string formation to use GOwnPtrgchar. + 2011-11-03 Darin Adler da...@apple.com Change remaining callers of releaseRef to call leakRef Modified: trunk/Source/WebKit/gtk/webkit/webkitapplicationcache.cpp (99577 => 99578) --- trunk/Source/WebKit/gtk/webkit/webkitapplicationcache.cpp 2011-11-08 17:33:07 UTC (rev 99577) +++ trunk/Source/WebKit/gtk/webkit/webkitapplicationcache.cpp 2011-11-08 17:36:04 UTC (rev 99578) @@ -65,13 +65,13 @@ } /** - * webkit_spplication_cache_get_database_directory_path: + * webkit_application_cache_get_database_directory_path: * - * Returns the current path to the directory WebKit will write web application - * cache databases. By default this path is set to $XDG_DATA_HOME/webkit/databases - * with webkit_application_cache_set_database_directory_path + * Returns the path to the directory WebKit will write web application + * cache databases to. By default this path is set to + * $XDG_CACHE_HOME/webkitgtk/applications and cannot be modified. * - * Returns: the current application cache database directory path + * Returns: the application cache database directory path * * Since: 1.3.13 **/ Modified: trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp (99577 => 99578) --- trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp 2011-11-08 17:33:07 UTC (rev 99577) +++ trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp 2011-11-08 17:36:04 UTC (rev 99578) @@ -316,11 +316,11 @@ // that may only be done by the main thread. atomicCanonicalTextEncodingName(UTF-8); -gchar* databaseDirectory = g_build_filename(g_get_user_data_dir(), webkit, databases, NULL); -webkit_set_web_database_directory_path(databaseDirectory); -WebCore::cacheStorage().setCacheDirectory(databaseDirectory); +GOwnPtrgchar databaseDirectory(g_build_filename(g_get_user_data_dir(), webkit, databases, NULL)); +webkit_set_web_database_directory_path(databaseDirectory.get()); -g_free(databaseDirectory); +GOwnPtrgchar cacheDirectory(g_build_filename(g_get_user_cache_dir(), webkitgtk, applications, NULL)); +WebCore::cacheStorage().setCacheDirectory(cacheDirectory.get()); PageGroup::setShouldTrackVisitedLinks(true); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99579] trunk
Title: [99579] trunk
Revision 99579
Author jsc...@chromium.org
Date 2011-11-08 09:42:29 -0800 (Tue, 08 Nov 2011)
Log Message
Document::loader should use documentLoader(), not activeDocumentLoader()
https://bugs.webkit.org/show_bug.cgi?id=65895
Reviewed by Brady Eidson.
Source/WebCore:
Test: fast/loader/stateobjects/replacestate-in-onunload.html
* dom/Document.cpp:
(WebCore::Document::loader):
LayoutTests:
* fast/loader/stateobjects/replacestate-in-onunload-expected.txt: Added.
* fast/loader/stateobjects/replacestate-in-onunload.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
Added Paths
trunk/LayoutTests/fast/loader/stateobjects/replacestate-in-onunload-expected.txt
trunk/LayoutTests/fast/loader/stateobjects/replacestate-in-onunload.html
Diff
Modified: trunk/LayoutTests/ChangeLog (99578 => 99579)
--- trunk/LayoutTests/ChangeLog 2011-11-08 17:36:04 UTC (rev 99578)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 17:42:29 UTC (rev 99579)
@@ -1,3 +1,13 @@
+2011-11-08 Justin Schuh jsc...@chromium.org
+
+Document::loader should use documentLoader(), not activeDocumentLoader()
+https://bugs.webkit.org/show_bug.cgi?id=65895
+
+Reviewed by Brady Eidson.
+
+* fast/loader/stateobjects/replacestate-in-onunload-expected.txt: Added.
+* fast/loader/stateobjects/replacestate-in-onunload.html: Added.
+
2011-11-08 Philippe Normand pnorm...@igalia.com
[GTK] fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html is flaky
Added: trunk/LayoutTests/fast/loader/stateobjects/replacestate-in-onunload-expected.txt (0 => 99579)
--- trunk/LayoutTests/fast/loader/stateobjects/replacestate-in-onunload-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/loader/stateobjects/replacestate-in-onunload-expected.txt 2011-11-08 17:42:29 UTC (rev 99579)
@@ -0,0 +1,4 @@
+This test calls replaceState during the onload handler to verify that the correct document's state is modified. If the test succeeds the URL and text below will show a success message.
+
+PASS
+
Added: trunk/LayoutTests/fast/loader/stateobjects/replacestate-in-onunload.html (0 => 99579)
--- trunk/LayoutTests/fast/loader/stateobjects/replacestate-in-onunload.html (rev 0)
+++ trunk/LayoutTests/fast/loader/stateobjects/replacestate-in-onunload.html 2011-11-08 17:42:29 UTC (rev 99579)
@@ -0,0 +1,36 @@
+html
+head
+script
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+function log(txt)
+{
+document.getElementById(logger).innerText += txt + \n;
+}
+
+
+window._onload_ = function()
+{
+if (!window.location.search) {
+window._onunload_ = function() { history.replaceState({}, '', '?FAIL') }
+window.location = window.location.href + ?PASS;
+} else {
+log(window.location.search.slice(1));
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+}
+
+/script
+body
+p
+This test calls replaceState during the onload handler to verify that the correct document's state is modified.
+If the test succeeds the URL and text below will show a success message.
+/p
+pre id=logger/pre
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (99578 => 99579)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 17:36:04 UTC (rev 99578)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 17:42:29 UTC (rev 99579)
@@ -1,3 +1,15 @@
+2011-11-08 Justin Schuh jsc...@chromium.org
+
+Document::loader should use documentLoader(), not activeDocumentLoader()
+https://bugs.webkit.org/show_bug.cgi?id=65895
+
+Reviewed by Brady Eidson.
+
+Test: fast/loader/stateobjects/replacestate-in-onunload.html
+
+* dom/Document.cpp:
+(WebCore::Document::loader):
+
2011-11-08 Andreas Kling kl...@webkit.org
CSSImageGeneratorValue: Devirtualize image(), isFixedSize() and fixedSize().
Modified: trunk/Source/WebCore/dom/Document.cpp (99578 => 99579)
--- trunk/Source/WebCore/dom/Document.cpp 2011-11-08 17:36:04 UTC (rev 99578)
+++ trunk/Source/WebCore/dom/Document.cpp 2011-11-08 17:42:29 UTC (rev 99579)
@@ -5066,7 +5066,7 @@
if (!m_frame)
return 0;
-DocumentLoader* loader = m_frame-loader()-activeDocumentLoader();
+DocumentLoader* loader = m_frame-loader()-documentLoader();
if (!loader)
return 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99580] trunk/Tools
Title: [99580] trunk/Tools Revision 99580 Author commit-qu...@webkit.org Date 2011-11-08 09:49:37 -0800 (Tue, 08 Nov 2011) Log Message Skip some ECMAScript tests that fail on Linux in some time zones. https://bugs.webkit.org/show_bug.cgi?id=71371 Patch by Andy Wingo wi...@igalia.com on 2011-11-08 Reviewed by Martin Robinson. * Scripts/run-_javascript_core-tests: Skip some more tests. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-_javascript_core-tests Diff Modified: trunk/Tools/ChangeLog (99579 => 99580) --- trunk/Tools/ChangeLog 2011-11-08 17:42:29 UTC (rev 99579) +++ trunk/Tools/ChangeLog 2011-11-08 17:49:37 UTC (rev 99580) @@ -1,3 +1,12 @@ +2011-11-08 Andy Wingo wi...@igalia.com + +Skip some ECMAScript tests that fail on Linux in some time zones. +https://bugs.webkit.org/show_bug.cgi?id=71371 + +Reviewed by Martin Robinson. + +* Scripts/run-_javascript_core-tests: Skip some more tests. + 2011-11-08 Csaba Osztrogonác o...@webkit.org [Qt] Unreviewed trivial fix after build system refactoring. Modified: trunk/Tools/Scripts/run-_javascript_core-tests (99579 => 99580) --- trunk/Tools/Scripts/run-_javascript_core-tests 2011-11-08 17:42:29 UTC (rev 99579) +++ trunk/Tools/Scripts/run-_javascript_core-tests 2011-11-08 17:49:37 UTC (rev 99580) @@ -51,6 +51,11 @@ ecma/Date/15.9.2.2-6.js, # ecma_3/Date/15.9.5.7.js fails on Mac (but not Windows) https://bugs.webkit.org/show_bug.cgi?id=25161 ecma_3/Date/15.9.5.7.js, +# These three fail on Linux in certain time zones, at certain times +# of the year (!): https://bugs.webkit.org/show_bug.cgi?id=71371 +ecma/Date/15.9.5.14.js, +ecma/Date/15.9.5.31-1.js, +ecma/Date/15.9.5.34-1.js, ); my $jsDriverArgs = -L . join( , @testsToSkip); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99581] trunk
Title: [99581] trunk
Revision 99581
Author h...@chromium.org
Date 2011-11-08 09:51:06 -0800 (Tue, 08 Nov 2011)
Log Message
IndexedDB: Start using the onSuccessWithContinuation() callback
https://bugs.webkit.org/show_bug.cgi?id=71565
Reviewed by Tony Chang.
Source/WebCore:
This is a follow-up to r99169 where we start using this new
callback for cursors.
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::setCursor):
LayoutTests:
The cursor-inconsistency.html test now passes completely.
* storage/indexeddb/cursor-inconsistency-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/cursor-inconsistency-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/IDBCursorBackendImpl.cpp
trunk/Source/WebCore/storage/IDBRequest.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (99580 => 99581)
--- trunk/LayoutTests/ChangeLog 2011-11-08 17:49:37 UTC (rev 99580)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 17:51:06 UTC (rev 99581)
@@ -1,3 +1,14 @@
+2011-11-08 Hans Wennborg h...@chromium.org
+
+IndexedDB: Start using the onSuccessWithContinuation() callback
+https://bugs.webkit.org/show_bug.cgi?id=71565
+
+Reviewed by Tony Chang.
+
+The cursor-inconsistency.html test now passes completely.
+
+* storage/indexeddb/cursor-inconsistency-expected.txt:
+
2011-11-08 Justin Schuh jsc...@chromium.org
Document::loader should use documentLoader(), not activeDocumentLoader()
Modified: trunk/LayoutTests/storage/indexeddb/cursor-inconsistency-expected.txt (99580 => 99581)
--- trunk/LayoutTests/storage/indexeddb/cursor-inconsistency-expected.txt 2011-11-08 17:49:37 UTC (rev 99580)
+++ trunk/LayoutTests/storage/indexeddb/cursor-inconsistency-expected.txt 2011-11-08 17:51:06 UTC (rev 99581)
@@ -30,7 +30,7 @@
event.target.result.continue()
checkCursor()
-FAIL storedCursor === event.target.result should be true. Was false.
+PASS storedCursor === event.target.result is true
PASS storedCursor.key is someKey2
PASS event.target.result.key is someKey2
PASS storedCursor.value is someValue2
@@ -38,7 +38,7 @@
event.target.result.continue()
checkCursor()
-FAIL storedCursor === event.target.result should be true. Was false.
+PASS storedCursor === event.target.result is true
PASS storedCursor.key is someKey3
PASS event.target.result.key is someKey3
PASS storedCursor.value is someValue3
@@ -46,7 +46,7 @@
event.target.result.continue()
checkCursor()
-FAIL storedCursor === event.target.result should be true. Was false.
+PASS storedCursor === event.target.result is true
PASS storedCursor.key is someKey4
PASS event.target.result.key is someKey4
PASS storedCursor.value is someValue4
Modified: trunk/Source/WebCore/ChangeLog (99580 => 99581)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 17:49:37 UTC (rev 99580)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 17:51:06 UTC (rev 99581)
@@ -1,3 +1,18 @@
+2011-11-08 Hans Wennborg h...@chromium.org
+
+IndexedDB: Start using the onSuccessWithContinuation() callback
+https://bugs.webkit.org/show_bug.cgi?id=71565
+
+Reviewed by Tony Chang.
+
+This is a follow-up to r99169 where we start using this new
+callback for cursors.
+
+* storage/IDBCursorBackendImpl.cpp:
+(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
+* storage/IDBRequest.cpp:
+(WebCore::IDBRequest::setCursor):
+
2011-11-08 Justin Schuh jsc...@chromium.org
Document::loader should use documentLoader(), not activeDocumentLoader()
Modified: trunk/Source/WebCore/storage/IDBCursorBackendImpl.cpp (99580 => 99581)
--- trunk/Source/WebCore/storage/IDBCursorBackendImpl.cpp 2011-11-08 17:49:37 UTC (rev 99580)
+++ trunk/Source/WebCore/storage/IDBCursorBackendImpl.cpp 2011-11-08 17:51:06 UTC (rev 99581)
@@ -110,7 +110,7 @@
return;
}
-callbacks-onSuccess(cursor.get()); // FIXME: After Chromium side is ready, this should be callbacks-onSuccessWithContinuation();
+callbacks-onSuccessWithContinuation();
}
void IDBCursorBackendImpl::deleteFunction(PassRefPtrIDBCallbacks prpCallbacks, ExceptionCode ec)
Modified: trunk/Source/WebCore/storage/IDBRequest.cpp (99580 => 99581)
--- trunk/Source/WebCore/storage/IDBRequest.cpp 2011-11-08 17:49:37 UTC (rev 99580)
+++ trunk/Source/WebCore/storage/IDBRequest.cpp 2011-11-08 17:51:06 UTC (rev 99581)
@@ -173,7 +173,7 @@
void IDBRequest::setCursor(PassRefPtrIDBCursor cursor)
{
-// FIXME: Assert !m_cursor when the new onSuccessCursorContinue() callback is used.
+ASSERT(!m_cursor);
m_cursor = cursor;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99582] trunk/LayoutTests
Title: [99582] trunk/LayoutTests
Revision 99582
Author commit-qu...@webkit.org
Date 2011-11-08 10:04:11 -0800 (Tue, 08 Nov 2011)
Log Message
Autofocus inputs don't always honor selector input:focus.
https://bugs.webkit.org/show_bug.cgi?id=24093
Already fixed and works on TOT. Adding layout test case for the same.
Patch by Kaustubh Atrawalkar kaust...@motorola.com on 2011-11-08
Reviewed by Kent Tamura.
* fast/forms/autofocus-input-css-style-change-expected.txt: Added.
* fast/forms/autofocus-input-css-style-change.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/fast/forms/autofocus-input-css-style-change-expected.txt
trunk/LayoutTests/fast/forms/autofocus-input-css-style-change.html
Diff
Modified: trunk/LayoutTests/ChangeLog (99581 => 99582)
--- trunk/LayoutTests/ChangeLog 2011-11-08 17:51:06 UTC (rev 99581)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 18:04:11 UTC (rev 99582)
@@ -1,3 +1,15 @@
+2011-11-08 Kaustubh Atrawalkar kaust...@motorola.com
+
+Autofocus inputs don't always honor selector input:focus.
+https://bugs.webkit.org/show_bug.cgi?id=24093
+
+Already fixed and works on TOT. Adding layout test case for the same.
+
+Reviewed by Kent Tamura.
+
+* fast/forms/autofocus-input-css-style-change-expected.txt: Added.
+* fast/forms/autofocus-input-css-style-change.html: Added.
+
2011-11-08 Hans Wennborg h...@chromium.org
IndexedDB: Start using the onSuccessWithContinuation() callback
Added: trunk/LayoutTests/fast/forms/autofocus-input-css-style-change-expected.txt (0 => 99582)
--- trunk/LayoutTests/fast/forms/autofocus-input-css-style-change-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/autofocus-input-css-style-change-expected.txt 2011-11-08 18:04:11 UTC (rev 99582)
@@ -0,0 +1,4 @@
+The following text box should have focus and should be green.
+
+
+PASS
Added: trunk/LayoutTests/fast/forms/autofocus-input-css-style-change.html (0 => 99582)
--- trunk/LayoutTests/fast/forms/autofocus-input-css-style-change.html (rev 0)
+++ trunk/LayoutTests/fast/forms/autofocus-input-css-style-change.html 2011-11-08 18:04:11 UTC (rev 99582)
@@ -0,0 +1,21 @@
+!DOCYTPE html
+html
+style
+input { background: red; }
+input:focus { background: green; }
+/style
+body
+pThe following text box should have focus and should be green./p
+input type=text id=test autofocus
+div id=resultFAIL/div
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+}
+
+var test = document.getElementById(test);
+if (document.defaultView.getComputedStyle(test, null).getPropertyValue('background-color') == rgb(0, 128, 0))
+result.innerHTML = PASS;
+/script
+/body
+/html
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99584] branches/safari-534.52-branch/Source/WebCore
Title: [99584] branches/safari-534.52-branch/Source/WebCore
Revision 99584
Author lforsch...@apple.com
Date 2011-11-08 10:10:56 -0800 (Tue, 08 Nov 2011)
Log Message
Merged r99508.
Modified Paths
branches/safari-534.52-branch/Source/WebCore/ChangeLog
branches/safari-534.52-branch/Source/WebCore/page/FrameView.cpp
Diff
Modified: branches/safari-534.52-branch/Source/WebCore/ChangeLog (99583 => 99584)
--- branches/safari-534.52-branch/Source/WebCore/ChangeLog 2011-11-08 18:10:31 UTC (rev 99583)
+++ branches/safari-534.52-branch/Source/WebCore/ChangeLog 2011-11-08 18:10:56 UTC (rev 99584)
@@ -1,3 +1,17 @@
+2011-11-08 Lucas Forschler lforsch...@apple.com
+
+Merge 99508
+
+2011-11-07 Dan Bernstein m...@apple.com
+
+rdar://problem/10405215 REGRESSION (r98178): World of Warcraft Launcher crashes in FrameView::isOnActivePage()
+https://bugs.webkit.org/show_bug.cgi?id=71743
+
+Reviewed by Beth Dakin.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::isOnActivePage): Added a check for a null m_frame.
+
2011-10-31 Lucas Forschler lforsch...@apple.com
Merge 98936
Modified: branches/safari-534.52-branch/Source/WebCore/page/FrameView.cpp (99583 => 99584)
--- branches/safari-534.52-branch/Source/WebCore/page/FrameView.cpp 2011-11-08 18:10:31 UTC (rev 99583)
+++ branches/safari-534.52-branch/Source/WebCore/page/FrameView.cpp 2011-11-08 18:10:56 UTC (rev 99584)
@@ -2234,6 +2234,8 @@
bool FrameView::isOnActivePage() const
{
+if (!m_frame)
+return false;
if (m_frame-view() != this)
return false;
if (Document* document = m_frame-document())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99585] branches/safari-534.52-branch/Source
Title: [99585] branches/safari-534.52-branch/Source Revision 99585 Author lforsch...@apple.com Date 2011-11-08 10:13:05 -0800 (Tue, 08 Nov 2011) Log Message Versioning. Modified Paths branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig (99584 => 99585) --- branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-11-08 18:10:56 UTC (rev 99584) +++ branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-11-08 18:13:05 UTC (rev 99585) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 9; +TINY_VERSION = 10; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (99584 => 99585) --- branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-11-08 18:10:56 UTC (rev 99584) +++ branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-11-08 18:13:05 UTC (rev 99585) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 9; +TINY_VERSION = 10; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig (99584 => 99585) --- branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig 2011-11-08 18:10:56 UTC (rev 99584) +++ branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig 2011-11-08 18:13:05 UTC (rev 99585) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 9; +TINY_VERSION = 10; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig (99584 => 99585) --- branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-11-08 18:10:56 UTC (rev 99584) +++ branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-11-08 18:13:05 UTC (rev 99585) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 9; +TINY_VERSION = 10; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig (99584 => 99585) --- branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-11-08 18:10:56 UTC (rev 99584) +++ branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-11-08 18:13:05 UTC (rev 99585) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 9; +TINY_VERSION = 10; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99586] tags/Safari-534.52.10/
Title: [99586] tags/Safari-534.52.10/ Revision 99586 Author lforsch...@apple.com Date 2011-11-08 10:13:31 -0800 (Tue, 08 Nov 2011) Log Message New tag. Added Paths tags/Safari-534.52.10/ Diff Property changes: tags/Safari-534.52.10 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99587] trunk/LayoutTests
Title: [99587] trunk/LayoutTests Revision 99587 Author t...@chromium.org Date 2011-11-08 10:17:47 -0800 (Tue, 08 Nov 2011) Log Message [chromium] broaden test failure for zoom-animator-scale-test2.html to include cg-gpu. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (99586 => 99587) --- trunk/LayoutTests/ChangeLog 2011-11-08 18:13:31 UTC (rev 99586) +++ trunk/LayoutTests/ChangeLog 2011-11-08 18:17:47 UTC (rev 99587) @@ -1,3 +1,9 @@ +2011-11-08 Tony Chang t...@chromium.org + +[chromium] broaden test failure for zoom-animator-scale-test2.html to include cg-gpu. + +* platform/chromium/test_expectations.txt: + 2011-11-08 Ojan Vafai o...@chromium.org New tests results after r99539. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99586 => 99587) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-08 18:13:31 UTC (rev 99586) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-08 18:17:47 UTC (rev 99587) @@ -3870,7 +3870,7 @@ BUGENNE GPU : compositing/overflow/fixed-position-ancestor-clip.html = FAIL BUGENNE GPU : compositing/scaling/tiled-layer-recursion.html = FAIL // Uncomment the above results for this when removing. -BUGENNE GPU : platform/chromium/compositing/zoom-animator-scale-test2.html = FAIL TIMEOUT +BUGENNE GPU GPU-CG : platform/chromium/compositing/zoom-animator-scale-test2.html = FAIL TIMEOUT // This test sometimes exceeds 60-second time limit (for SLOW tests) on // win/linux debug. Since setting both SLOW and TIMEOUT is not allowed, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99588] trunk/Source/WebCore
Title: [99588] trunk/Source/WebCore
Revision 99588
Author tha...@chromium.org
Date 2011-11-08 10:20:18 -0800 (Tue, 08 Nov 2011)
Log Message
[chromium] Remove 6 exit time destructors and 6 static initializers
https://bugs.webkit.org/show_bug.cgi?id=71760
Reviewed by Nate Chapin.
Do this by moving global statics into function-local statics, and using
DEFINE_LOCAL_STATIC to leak them. Since this code is accessed on a single
thread, this is a safe change to make.
No behavior change, so no new tests.
* bindings/v8/ScriptGCEvent.cpp:
(WebCore::sEventListeners):
(WebCore::ScriptGCEvent::addEventListener):
(WebCore::ScriptGCEvent::removeEventListener):
(WebCore::ScriptGCEvent::gcEpilogueCallback):
* bindings/v8/ScriptGCEvent.h:
* bindings/v8/V8NPObject.cpp:
(WebCore::staticTemplateMap):
(WebCore::weakTemplateCallback):
(WebCore::npObjectGetProperty):
(WebCore::staticNPObjectMap):
(WebCore::weakNPObjectCallback):
(WebCore::createV8ObjectForNPObject):
(WebCore::forgetV8ObjectForNPObject):
* bindings/v8/V8Proxy.cpp:
(WebCore::staticExtensionsList):
(WebCore::V8Proxy::registeredExtensionWithV8):
(WebCore::V8Proxy::registerExtension):
(WebCore::V8Proxy::extensions):
* bindings/v8/V8Proxy.h:
* bindings/v8/npruntime.cpp:
* plugins/chromium/PluginDataChromium.cpp:
(WebCore::pluginCache):
(WebCore::PluginData::initPlugins):
(WebCore::PluginData::refresh):
(WebCore::getPluginMimeTypeFromExtension):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/ScriptGCEvent.cpp
trunk/Source/WebCore/bindings/v8/ScriptGCEvent.h
trunk/Source/WebCore/bindings/v8/V8NPObject.cpp
trunk/Source/WebCore/bindings/v8/V8Proxy.cpp
trunk/Source/WebCore/bindings/v8/V8Proxy.h
trunk/Source/WebCore/bindings/v8/npruntime.cpp
trunk/Source/WebCore/plugins/chromium/PluginDataChromium.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (99587 => 99588)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 18:17:47 UTC (rev 99587)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 18:20:18 UTC (rev 99588)
@@ -1,3 +1,43 @@
+2011-11-08 Nico Weber tha...@chromium.org
+
+[chromium] Remove 6 exit time destructors and 6 static initializers
+https://bugs.webkit.org/show_bug.cgi?id=71760
+
+Reviewed by Nate Chapin.
+
+Do this by moving global statics into function-local statics, and using
+DEFINE_LOCAL_STATIC to leak them. Since this code is accessed on a single
+thread, this is a safe change to make.
+
+No behavior change, so no new tests.
+
+* bindings/v8/ScriptGCEvent.cpp:
+(WebCore::sEventListeners):
+(WebCore::ScriptGCEvent::addEventListener):
+(WebCore::ScriptGCEvent::removeEventListener):
+(WebCore::ScriptGCEvent::gcEpilogueCallback):
+* bindings/v8/ScriptGCEvent.h:
+* bindings/v8/V8NPObject.cpp:
+(WebCore::staticTemplateMap):
+(WebCore::weakTemplateCallback):
+(WebCore::npObjectGetProperty):
+(WebCore::staticNPObjectMap):
+(WebCore::weakNPObjectCallback):
+(WebCore::createV8ObjectForNPObject):
+(WebCore::forgetV8ObjectForNPObject):
+* bindings/v8/V8Proxy.cpp:
+(WebCore::staticExtensionsList):
+(WebCore::V8Proxy::registeredExtensionWithV8):
+(WebCore::V8Proxy::registerExtension):
+(WebCore::V8Proxy::extensions):
+* bindings/v8/V8Proxy.h:
+* bindings/v8/npruntime.cpp:
+* plugins/chromium/PluginDataChromium.cpp:
+(WebCore::pluginCache):
+(WebCore::PluginData::initPlugins):
+(WebCore::PluginData::refresh):
+(WebCore::getPluginMimeTypeFromExtension):
+
2011-11-08 Hans Wennborg h...@chromium.org
IndexedDB: Start using the onSuccessWithContinuation() callback
Modified: trunk/Source/WebCore/bindings/v8/ScriptGCEvent.cpp (99587 => 99588)
--- trunk/Source/WebCore/bindings/v8/ScriptGCEvent.cpp 2011-11-08 18:17:47 UTC (rev 99587)
+++ trunk/Source/WebCore/bindings/v8/ScriptGCEvent.cpp 2011-11-08 18:20:18 UTC (rev 99588)
@@ -39,28 +39,34 @@
namespace WebCore {
-ScriptGCEvent::GCEventListeners ScriptGCEvent::s_eventListeners;
+typedef VectorScriptGCEventListener* GCEventListeners;
+static GCEventListeners eventListeners()
+{
+DEFINE_STATIC_LOCAL(GCEventListeners, listeners, ());
+return listeners;
+}
+
double ScriptGCEvent::s_startTime = 0.0;
size_t ScriptGCEvent::s_usedHeapSize = 0;
void ScriptGCEvent::addEventListener(ScriptGCEventListener* eventListener)
{
ASSERT(eventListener);
-if (s_eventListeners.isEmpty()) {
+if (eventListeners().isEmpty()) {
v8::V8::AddGCPrologueCallback(ScriptGCEvent::gcPrologueCallback);
v8::V8::AddGCEpilogueCallback(ScriptGCEvent::gcEpilogueCallback);
}
-s_eventListeners.append(eventListener);
+eventListeners().append(eventListener);
}
void ScriptGCEvent::removeEventListener(ScriptGCEventListener* eventListener)
{
ASSERT(eventListener);
-
[webkit-changes] [99589] trunk/Source/WebCore
Title: [99589] trunk/Source/WebCore
Revision 99589
Author commit-qu...@webkit.org
Date 2011-11-08 10:23:30 -0800 (Tue, 08 Nov 2011)
Log Message
Unreviewed, rolling out r95720.
http://trac.webkit.org/changeset/95720
https://bugs.webkit.org/show_bug.cgi?id=71831
This has made the menulists on WebKit patch reviews much less
usable (Requested by mrobinson on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-11-08
* platform/gtk/GtkPopupMenu.cpp:
(WebCore::GtkPopupMenu::menuPositionFunction):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/GtkPopupMenu.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (99588 => 99589)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 18:20:18 UTC (rev 99588)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 18:23:30 UTC (rev 99589)
@@ -1,3 +1,15 @@
+2011-11-08 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r95720.
+http://trac.webkit.org/changeset/95720
+https://bugs.webkit.org/show_bug.cgi?id=71831
+
+This has made the menulists on WebKit patch reviews much less
+usable (Requested by mrobinson on #webkit).
+
+* platform/gtk/GtkPopupMenu.cpp:
+(WebCore::GtkPopupMenu::menuPositionFunction):
+
2011-11-08 Nico Weber tha...@chromium.org
[chromium] Remove 6 exit time destructors and 6 static initializers
Modified: trunk/Source/WebCore/platform/gtk/GtkPopupMenu.cpp (99588 => 99589)
--- trunk/Source/WebCore/platform/gtk/GtkPopupMenu.cpp 2011-11-08 18:20:18 UTC (rev 99588)
+++ trunk/Source/WebCore/platform/gtk/GtkPopupMenu.cpp 2011-11-08 18:23:30 UTC (rev 99589)
@@ -6,7 +6,6 @@
* Copyright (C) 2008 Collabora Ltd.
* Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
* Copyright (C) 2010-2011 Igalia S.L.
- * Portions Copyright (c) 2010 Motorola Mobility, Inc. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
@@ -146,7 +145,7 @@
{
*x = popupMenu-m_menuPosition.x();
*y = popupMenu-m_menuPosition.y();
-*pushIn = false;
+*pushIn = true;
}
void GtkPopupMenu::resetTypeAheadFindState()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99592] trunk/Source/WebCore
Title: [99592] trunk/Source/WebCore Revision 99592 Author andreas.kl...@nokia.com Date 2011-11-08 10:27:07 -0800 (Tue, 08 Nov 2011) Log Message Devirtualize CSSValue. http://webkit.org/b/71666 Reviewed by Antti Koivisto. Make the CSSValue destructor non-virtual (along with all the subclasses.) This removes the vtables, and the pointers thereto in each value instance, shrinking each object by one CPU word (4 or 8 bytes.) We use the same trick as CSSRule to implement destruction; providing our own deref() instead of RefCounted's, and performing a statically typed delete in a destroy() method called when the ref count reaches 0. Also made all the empty subclass destructors inline. * css/CSSAspectRatioValue.cpp: * css/CSSAspectRatioValue.h: (WebCore::CSSAspectRatioValue::~CSSAspectRatioValue): * css/CSSBorderImageSliceValue.cpp: * css/CSSBorderImageSliceValue.h: (WebCore::CSSBorderImageSliceValue::~CSSBorderImageSliceValue): * css/CSSBorderImageValue.cpp: * css/CSSBorderImageValue.h: (WebCore::CSSBorderImageValue::~CSSBorderImageValue): * css/CSSCanvasValue.h: * css/CSSCrossfadeValue.cpp: * css/CSSCrossfadeValue.h: (WebCore::CSSCrossfadeValue::~CSSCrossfadeValue): * css/CSSCursorImageValue.h: * css/CSSFlexValue.cpp: * css/CSSFlexValue.h: (WebCore::CSSFlexValue::~CSSFlexValue): * css/CSSFontFaceSrcValue.cpp: * css/CSSFontFaceSrcValue.h: (WebCore::CSSFontFaceSrcValue::~CSSFontFaceSrcValue): * css/CSSFunctionValue.cpp: * css/CSSFunctionValue.h: (WebCore::CSSFunctionValue::~CSSFunctionValue): * css/CSSImageGeneratorValue.h: * css/CSSImageValue.h: * css/CSSMutableValue.h: (WebCore::CSSMutableValue::~CSSMutableValue): * css/CSSParserValues.h: * css/CSSPrimitiveValue.h: * css/CSSUnicodeRangeValue.cpp: * css/CSSUnicodeRangeValue.h: (WebCore::CSSUnicodeRangeValue::~CSSUnicodeRangeValue): * css/CSSValue.cpp: (WebCore::CSSValue::destroy): * css/CSSValue.h: (WebCore::CSSValue::deref): (WebCore::CSSValue::~CSSValue): * css/CSSValueList.cpp: * css/CSSValueList.h: (WebCore::CSSValueList::~CSSValueList): * css/WebKitCSSFilterValue.cpp: * css/WebKitCSSFilterValue.h: (WebCore::WebKitCSSFilterValue::~WebKitCSSFilterValue): * css/WebKitCSSTransformValue.cpp: * css/WebKitCSSTransformValue.h: (WebCore::WebKitCSSTransformValue::~WebKitCSSTransformValue): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSAspectRatioValue.cpp trunk/Source/WebCore/css/CSSAspectRatioValue.h trunk/Source/WebCore/css/CSSBorderImageSliceValue.cpp trunk/Source/WebCore/css/CSSBorderImageSliceValue.h trunk/Source/WebCore/css/CSSBorderImageValue.cpp trunk/Source/WebCore/css/CSSBorderImageValue.h trunk/Source/WebCore/css/CSSCanvasValue.h trunk/Source/WebCore/css/CSSCrossfadeValue.cpp trunk/Source/WebCore/css/CSSCrossfadeValue.h trunk/Source/WebCore/css/CSSCursorImageValue.h trunk/Source/WebCore/css/CSSFlexValue.cpp trunk/Source/WebCore/css/CSSFlexValue.h trunk/Source/WebCore/css/CSSFontFaceSrcValue.cpp trunk/Source/WebCore/css/CSSFontFaceSrcValue.h trunk/Source/WebCore/css/CSSFunctionValue.cpp trunk/Source/WebCore/css/CSSFunctionValue.h trunk/Source/WebCore/css/CSSImageGeneratorValue.h trunk/Source/WebCore/css/CSSImageValue.h trunk/Source/WebCore/css/CSSMutableValue.h trunk/Source/WebCore/css/CSSParserValues.h trunk/Source/WebCore/css/CSSPrimitiveValue.h trunk/Source/WebCore/css/CSSUnicodeRangeValue.cpp trunk/Source/WebCore/css/CSSUnicodeRangeValue.h trunk/Source/WebCore/css/CSSValue.cpp trunk/Source/WebCore/css/CSSValue.h trunk/Source/WebCore/css/CSSValueList.cpp trunk/Source/WebCore/css/CSSValueList.h trunk/Source/WebCore/css/WebKitCSSFilterValue.cpp trunk/Source/WebCore/css/WebKitCSSFilterValue.h trunk/Source/WebCore/css/WebKitCSSTransformValue.cpp trunk/Source/WebCore/css/WebKitCSSTransformValue.h trunk/Source/WebCore/svg/SVGColor.h Diff Modified: trunk/Source/WebCore/ChangeLog (99591 => 99592) --- trunk/Source/WebCore/ChangeLog 2011-11-08 18:25:31 UTC (rev 99591) +++ trunk/Source/WebCore/ChangeLog 2011-11-08 18:27:07 UTC (rev 99592) @@ -1,3 +1,67 @@ +2011-11-08 Andreas Kling kl...@webkit.org + +Devirtualize CSSValue. +http://webkit.org/b/71666 + +Reviewed by Antti Koivisto. + +Make the CSSValue destructor non-virtual (along with all the subclasses.) +This removes the vtables, and the pointers thereto in each value instance, +shrinking each object by one CPU word (4 or 8 bytes.) + +We use the same trick as CSSRule to implement destruction; providing our +own deref() instead of RefCounted's, and performing a statically typed +delete in a destroy() method called when the ref count reaches 0. + +Also made all the empty subclass destructors inline. + +* css/CSSAspectRatioValue.cpp: +* css/CSSAspectRatioValue.h: +(WebCore::CSSAspectRatioValue::~CSSAspectRatioValue): +* css/CSSBorderImageSliceValue.cpp: +* css/CSSBorderImageSliceValue.h: +
[webkit-changes] [99593] trunk
Title: [99593] trunk
Revision 99593
Author ad...@chromium.org
Date 2011-11-08 10:29:54 -0800 (Tue, 08 Nov 2011)
Log Message
Only walk up the tree in search of MutationObservers if one has been added
https://bugs.webkit.org/show_bug.cgi?id=71499
Reviewed by Ojan Vafai.
Source/WebCore:
Analogous to m_listenerTypes, added an m_subtreeMutationObserverTypes field
to Document that keeps track of which observer types have been added.
This allows us to avoid doing any extra work if MutationObservers are
not attached to a document.
This could be improved upon to keep a count of each type, as removing
an observer currently has no effect on m_subtreeMutationObserverTypes.
But that would require a more complex implementation: one counter per
mutation type. And it would be easier to get wrong: if the counter
gets out of sync with the actual state of the DOM, we could start
dropping mutation notifications.
Test: fast/mutation/cross-document.html
* dom/Document.h:
(WebCore::Document::hasSubtreeMutationObserverOfType):
(WebCore::Document::hasSubtreeMutationObserver):
(WebCore::Document::addSubtreeMutationObserverTypes):
* dom/MutationObserverRegistration.h:
(WebCore::MutationObserverRegistration::isSubtree):
(WebCore::MutationObserverRegistration::deliveryOptions):
(WebCore::MutationObserverRegistration::mutationTypes):
* dom/Node.cpp:
(WebCore::Node::didMoveToNewOwnerDocument): Update mutationObserverTypes when a Node is moved to a new document.
(WebCore::Node::getRegisteredMutationObserversOfType): Exit early if it's known that no observers of |type| are registered.
(WebCore::Node::notifyMutationObserversNodeWillDetach): Exit early if it's known no subtree observers of any type are registered.
* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::observe): Update mutationObserverTypes when an observation occurs.
* dom/WebKitMutationObserver.h: Add WebKitMutationObserver::AllMutationTypes to enum
LayoutTests:
Created a basic test showing that MutationObservers
are preserved when a Node switches documents.
* fast/mutation/cross-document-expected.txt: Added.
* fast/mutation/cross-document.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/MutationObserverRegistration.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/WebKitMutationObserver.cpp
trunk/Source/WebCore/dom/WebKitMutationObserver.h
Added Paths
trunk/LayoutTests/fast/mutation/cross-document-expected.txt
trunk/LayoutTests/fast/mutation/cross-document.html
Diff
Modified: trunk/LayoutTests/ChangeLog (99592 => 99593)
--- trunk/LayoutTests/ChangeLog 2011-11-08 18:27:07 UTC (rev 99592)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 18:29:54 UTC (rev 99593)
@@ -1,3 +1,16 @@
+2011-11-08 Adam Klein ad...@chromium.org
+
+Only walk up the tree in search of MutationObservers if one has been added
+https://bugs.webkit.org/show_bug.cgi?id=71499
+
+Reviewed by Ojan Vafai.
+
+Created a basic test showing that MutationObservers
+are preserved when a Node switches documents.
+
+* fast/mutation/cross-document-expected.txt: Added.
+* fast/mutation/cross-document.html: Added.
+
2011-11-08 Ojan Vafai o...@chromium.org
Move regressions from V8 roll to from the downstream expectations file.
Added: trunk/LayoutTests/fast/mutation/cross-document-expected.txt (0 => 99593)
--- trunk/LayoutTests/fast/mutation/cross-document-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/mutation/cross-document-expected.txt 2011-11-08 18:29:54 UTC (rev 99593)
@@ -0,0 +1,23 @@
+Test that MutationObservers move correctly across documents
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+Testing basic aspects of cross-document observation.
+PASS mutations.length is 1
+PASS mutations[0].type is attributes
+PASS mutations[0].target is div
+PASS mutations[0].attributeName is id
+PASS mutations[0].attributeNamespace is null
+
+Testing that subtree observation works after node is moved.
+PASS mutations.length is 1
+PASS mutations[0].type is attributes
+PASS mutations[0].target is subDiv
+PASS mutations[0].attributeName is id
+PASS mutations[0].attributeNamespace is null
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/mutation/cross-document.html (0 => 99593)
--- trunk/LayoutTests/fast/mutation/cross-document.html (rev 0)
+++ trunk/LayoutTests/fast/mutation/cross-document.html 2011-11-08 18:29:54 UTC (rev 99593)
@@ -0,0 +1,100 @@
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body
+script
+
+window.jsTestIsAsync = true;
+var mutations;
+var div, subDiv;
+
+function testBasic() {
+var observer;
+
+function start() {
+debug('Testing basic aspects of cross-document observation.');
+
+mutations = null;
+div =
[webkit-changes] [99594] trunk
Title: [99594] trunk
Revision 99594
Author rn...@webkit.org
Date 2011-11-08 10:39:49 -0800 (Tue, 08 Nov 2011)
Log Message
Indent command can insert block quote in non editable content
https://bugs.webkit.org/show_bug.cgi?id=71754
Reviewed by Enrica Casucci.
Source/WebCore:
The bug was caused by IndentOutdentCommand's incorrectly using deprecatedNode to determine the outer block,
not updating the start after inserting the targetBlockquote, and cloneParagraphUnderNewElement's cloning
outerNode even if it was body. Fixed those bugs.
Test: editing/execCommand/indent-images.html
editing/execCommand/indent-images-2.html
editing/execCommand/indent-images-3.html
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::indentIntoBlockquote):
LayoutTests:
Add tests to indent two images in a document.
* editing/execCommand/indent-images-expected.txt: Added.
* editing/execCommand/indent-images.html: Added.
* editing/execCommand/indent-images-2-expected.txt: Added.
* editing/execCommand/indent-images-2.html: Added.
* editing/execCommand/indent-images-3-expected.txt: Added.
* editing/execCommand/indent-images-3.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/CompositeEditCommand.cpp
trunk/Source/WebCore/editing/IndentOutdentCommand.cpp
Added Paths
trunk/LayoutTests/editing/execCommand/indent-images-2-expected.txt
trunk/LayoutTests/editing/execCommand/indent-images-2.html
trunk/LayoutTests/editing/execCommand/indent-images-3-expected.txt
trunk/LayoutTests/editing/execCommand/indent-images-3.html
trunk/LayoutTests/editing/execCommand/indent-images-expected.txt
trunk/LayoutTests/editing/execCommand/indent-images.html
Diff
Modified: trunk/LayoutTests/ChangeLog (99593 => 99594)
--- trunk/LayoutTests/ChangeLog 2011-11-08 18:29:54 UTC (rev 99593)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 18:39:49 UTC (rev 99594)
@@ -1,3 +1,19 @@
+2011-11-07 Ryosuke Niwa rn...@webkit.org
+
+Indent command can insert block quote in non editable content
+https://bugs.webkit.org/show_bug.cgi?id=71754
+
+Reviewed by Enrica Casucci.
+
+Add tests to indent two images in a document.
+
+* editing/execCommand/indent-images-expected.txt: Added.
+* editing/execCommand/indent-images.html: Added.
+* editing/execCommand/indent-images-2-expected.txt: Added.
+* editing/execCommand/indent-images-2.html: Added.
+* editing/execCommand/indent-images-3-expected.txt: Added.
+* editing/execCommand/indent-images-3.html: Added.
+
2011-11-08 Adam Klein ad...@chromium.org
Only walk up the tree in search of MutationObservers if one has been added
Added: trunk/LayoutTests/editing/execCommand/indent-images-2-expected.txt (0 => 99594)
--- trunk/LayoutTests/editing/execCommand/indent-images-2-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/execCommand/indent-images-2-expected.txt 2011-11-08 18:39:49 UTC (rev 99594)
@@ -0,0 +1,12 @@
+This test indents insides a document with exactly two image elements.
+| div
+| contenteditable=
+| blockquote
+| style=margin: 0 0 0 40px; border: none; padding: 0px;
+| img
+| img
+| #selection-caret
+|
+
+|
+
Added: trunk/LayoutTests/editing/execCommand/indent-images-2.html (0 => 99594)
--- trunk/LayoutTests/editing/execCommand/indent-images-2.html (rev 0)
+++ trunk/LayoutTests/editing/execCommand/indent-images-2.html 2011-11-08 18:39:49 UTC (rev 99594)
@@ -0,0 +1,21 @@
+!DOCTYPE html
+html
+bodydiv contenteditableimgimg/div
+script src=""
+script
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+while (script = document.querySelector('script'))
+script.parentNode.removeChild(script);
+
+getSelection().setPosition(document.getElementsByTagName('div')[0], 2);
+document.execCommand('indent');
+
+Markup.description('This test indents insides a document with exactly two image elements.');
+Markup.dump(document.body);
+
+/script
+/body
+/html
Added: trunk/LayoutTests/editing/execCommand/indent-images-3-expected.txt (0 => 99594)
--- trunk/LayoutTests/editing/execCommand/indent-images-3-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/execCommand/indent-images-3-expected.txt 2011-11-08 18:39:49 UTC (rev 99594)
@@ -0,0 +1,10 @@
+This test indents insides a document with exactly two image elements.
+Indentation should fail because the root editable element is inline.
+| span
+| contenteditable=
+| img
+| img
+|
+
+|
+
Added: trunk/LayoutTests/editing/execCommand/indent-images-3.html (0 => 99594)
--- trunk/LayoutTests/editing/execCommand/indent-images-3.html (rev 0)
+++ trunk/LayoutTests/editing/execCommand/indent-images-3.html 2011-11-08 18:39:49 UTC (rev 99594)
@@
[webkit-changes] [99595] trunk/Source/WebCore
Title: [99595] trunk/Source/WebCore
Revision 99595
Author rolandstei...@chromium.org
Date 2011-11-08 11:04:43 -0800 (Tue, 08 Nov 2011)
Log Message
Rename CSS document() - findDocument(), to indicate tree climbing
https://bugs.webkit.org/show_bug.cgi?id=71764
Renamed document() to findDocument(), styleSheetOwnerNode() to findStyleSheetOwnerNode().
Reviewed by Darin Adler.
No new tests. (simple refactoring)
* css/CSSGrammar.y:
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::setCSSStyleSheet):
(WebCore::CSSImportRule::requestStyleSheet):
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
* css/CSSParser.cpp:
(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::findDocument):
(WebCore::CSSParser::parseAttr):
* css/CSSParser.h:
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::cssRules):
(WebCore::CSSStyleSheet::findStyleSheetOwnerNode):
(WebCore::CSSStyleSheet::findDocument):
(WebCore::CSSStyleSheet::styleSheetChanged):
* css/CSSStyleSheet.h:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::bindStyleSheet):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::ownerDocument):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeCSSStyleSheet):
(WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y
trunk/Source/WebCore/css/CSSImportRule.cpp
trunk/Source/WebCore/css/CSSMutableStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSParser.h
trunk/Source/WebCore/css/CSSStyleRule.cpp
trunk/Source/WebCore/css/CSSStyleSheet.cpp
trunk/Source/WebCore/css/CSSStyleSheet.h
trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp
trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp
trunk/Source/WebCore/page/PageSerializer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (99594 => 99595)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 18:39:49 UTC (rev 99594)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 19:04:43 UTC (rev 99595)
@@ -1,3 +1,43 @@
+2011-11-08 Roland Steiner rolandstei...@chromium.org
+
+Rename CSS document() - findDocument(), to indicate tree climbing
+https://bugs.webkit.org/show_bug.cgi?id=71764
+
+Renamed document() to findDocument(), styleSheetOwnerNode() to findStyleSheetOwnerNode().
+
+Reviewed by Darin Adler.
+
+No new tests. (simple refactoring)
+
+* css/CSSGrammar.y:
+* css/CSSImportRule.cpp:
+(WebCore::CSSImportRule::setCSSStyleSheet):
+(WebCore::CSSImportRule::requestStyleSheet):
+* css/CSSMutableStyleDeclaration.cpp:
+(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
+* css/CSSParser.cpp:
+(WebCore::parseColorValue):
+(WebCore::parseSimpleLengthValue):
+(WebCore::CSSParser::setStyleSheet):
+(WebCore::CSSParser::findDocument):
+(WebCore::CSSParser::parseAttr):
+* css/CSSParser.h:
+* css/CSSStyleRule.cpp:
+(WebCore::CSSStyleRule::setSelectorText):
+* css/CSSStyleSheet.cpp:
+(WebCore::CSSStyleSheet::cssRules):
+(WebCore::CSSStyleSheet::findStyleSheetOwnerNode):
+(WebCore::CSSStyleSheet::findDocument):
+(WebCore::CSSStyleSheet::styleSheetChanged):
+* css/CSSStyleSheet.h:
+* inspector/InspectorCSSAgent.cpp:
+(WebCore::InspectorCSSAgent::bindStyleSheet):
+* inspector/InspectorStyleSheet.cpp:
+(WebCore::InspectorStyleSheet::ownerDocument):
+* page/PageSerializer.cpp:
+(WebCore::PageSerializer::serializeCSSStyleSheet):
+(WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):
+
2011-11-07 Ryosuke Niwa rn...@webkit.org
Indent command can insert block quote in non editable content
Modified: trunk/Source/WebCore/css/CSSGrammar.y (99594 => 99595)
--- trunk/Source/WebCore/css/CSSGrammar.y 2011-11-08 18:39:49 UTC (rev 99594)
+++ trunk/Source/WebCore/css/CSSGrammar.y 2011-11-08 19:04:43 UTC (rev 99595)
@@ -985,7 +985,7 @@
IDENT {
CSSParserString str = $1;
CSSParser* p = static_castCSSParser*(parser);
-Document* doc = p-document();
+Document* doc = p-findDocument();
if (doc doc-isHTMLDocument())
str.lower();
$$ = str;
@@ -1053,7 +1053,7 @@
IDENT maybe_space {
CSSParserString str = $1;
CSSParser* p = static_castCSSParser*(parser);
-Document* doc = p-document();
+Document* doc = p-findDocument();
if (doc doc-isHTMLDocument())
str.lower();
$$ = str;
@@ -1465,7 +1465,7 @@
$$.fValue = $1;
$$.unit = CSSPrimitiveValue::CSS_REMS;
CSSParser* p = static_castCSSParser*(parser);
- if (Document* doc =
[webkit-changes] [99596] trunk/Source/WebCore
Title: [99596] trunk/Source/WebCore
Revision 99596
Author dba...@webkit.org
Date 2011-11-08 11:13:22 -0800 (Tue, 08 Nov 2011)
Log Message
Remove get() defined in CredentialStorageSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=71825
Reviewed by Martin Robinson.
CredentialStorage::get() is implemented in CredentialStorage.cpp. And CredentialStorage.cpp
provides the base implementation for each platform. We shouldn't re-define
CredentialStorage::get() in CredentialStorageSoup.cpp.
* GNUmakefile.list.am: Add source file CredentialStorage.cpp.
* platform/network/soup/CredentialStorageSoup.cpp: Remove re-definition of CredentialStorage::get().
CredentialStorage::get() is defined in CredentialStorage.cpp.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/platform/network/soup/CredentialStorageSoup.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (99595 => 99596)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 19:04:43 UTC (rev 99595)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 19:13:22 UTC (rev 99596)
@@ -1,3 +1,18 @@
+2011-11-08 Daniel Bates dba...@webkit.org
+
+Remove get() defined in CredentialStorageSoup.cpp
+https://bugs.webkit.org/show_bug.cgi?id=71825
+
+Reviewed by Martin Robinson.
+
+CredentialStorage::get() is implemented in CredentialStorage.cpp. And CredentialStorage.cpp
+provides the base implementation for each platform. We shouldn't re-define
+CredentialStorage::get() in CredentialStorageSoup.cpp.
+
+* GNUmakefile.list.am: Add source file CredentialStorage.cpp.
+* platform/network/soup/CredentialStorageSoup.cpp: Remove re-definition of CredentialStorage::get().
+CredentialStorage::get() is defined in CredentialStorage.cpp.
+
2011-11-08 Roland Steiner rolandstei...@chromium.org
Rename CSS document() - findDocument(), to indicate tree climbing
Modified: trunk/Source/WebCore/GNUmakefile.list.am (99595 => 99596)
--- trunk/Source/WebCore/GNUmakefile.list.am 2011-11-08 19:04:43 UTC (rev 99595)
+++ trunk/Source/WebCore/GNUmakefile.list.am 2011-11-08 19:13:22 UTC (rev 99596)
@@ -2789,6 +2789,7 @@
Source/WebCore/platform/network/CookieStorage.h \
Source/WebCore/platform/network/Credential.cpp \
Source/WebCore/platform/network/Credential.h \
+ Source/WebCore/platform/network/CredentialStorage.cpp \
Source/WebCore/platform/network/CredentialStorage.h \
Source/WebCore/platform/network/DNS.h \
Source/WebCore/platform/network/FormDataBuilder.cpp \
Modified: trunk/Source/WebCore/platform/network/soup/CredentialStorageSoup.cpp (99595 => 99596)
--- trunk/Source/WebCore/platform/network/soup/CredentialStorageSoup.cpp 2011-11-08 19:04:43 UTC (rev 99595)
+++ trunk/Source/WebCore/platform/network/soup/CredentialStorageSoup.cpp 2011-11-08 19:13:22 UTC (rev 99596)
@@ -35,9 +35,4 @@
return Credential();
}
-Credential CredentialStorage::get(const ProtectionSpace)
-{
-return Credential();
-}
-
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99597] trunk/LayoutTests
Title: [99597] trunk/LayoutTests Revision 99597 Author o...@chromium.org Date 2011-11-08 11:19:35 -0800 (Tue, 08 Nov 2011) Log Message Fix expectations mixup. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (99596 => 99597) --- trunk/LayoutTests/ChangeLog 2011-11-08 19:13:22 UTC (rev 99596) +++ trunk/LayoutTests/ChangeLog 2011-11-08 19:19:35 UTC (rev 99597) @@ -1,3 +1,8 @@ +2011-11-08 Ojan Vafai o...@chromium.org + +Fix expectations mixup. +* platform/chromium/test_expectations.txt: + 2011-11-07 Ryosuke Niwa rn...@webkit.org Indent command can insert block quote in non editable content Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99596 => 99597) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-08 19:13:22 UTC (rev 99596) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-08 19:19:35 UTC (rev 99597) @@ -3288,7 +3288,7 @@ BUGWK66320 DEBUG : svg/wicd/test-rightsizing-a.xhtml = PASS IMAGE IMAGE+TEXT // After r87526, these all have extra scrollbars where the platform/mac expectations do not. -BUGWK61664 LINUX : svg/zoom/page/relative-sized-document-scrollbars.svg = IMAGE +BUGWK61664 LINUX : svg/zoom/page/relative-sized-document-scrollbars.svg = IMAGE+TEXT BUGABARTH LINUX : svg/text/scaling-font-with-geometric-precision.html = PASS IMAGE @@ -3930,8 +3930,8 @@ BUGWK71793 BUG_ABARTH : svg/as-background-image/svg-as-background-1.html = IMAGE BUGWK71793 BUG_ABARTH : svg/as-background-image/svg-as-background-3.html = IMAGE -BUGWK71830 : svg/zoom/page/zoom-svg-as-relative-image.html = IMAGE+TEXT -BUGWK71830 WIN MAC : svg/zoom/page/relative-sized-document-scrollbars.svg = IMAGE +BUGWK71830 : svg/zoom/page/zoom-svg-as-relative-image.html = IMAGE +BUGWK71830 WIN MAC : svg/zoom/page/relative-sized-document-scrollbars.svg = IMAGE+TEXT BUGRICOW : fast/js/array-functions-non-arrays.html = TEXT BUGRICOW : fast/js/eval-cross-window.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99598] trunk/Tools
Title: [99598] trunk/Tools Revision 99598 Author zeno.albis...@nokia.com Date 2011-11-08 11:29:58 -0800 (Tue, 08 Nov 2011) Log Message Added myself as a committer. * Scripts/webkitpy/common/config/committers.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (99597 => 99598) --- trunk/Tools/ChangeLog 2011-11-08 19:19:35 UTC (rev 99597) +++ trunk/Tools/ChangeLog 2011-11-08 19:29:58 UTC (rev 99598) @@ -1,3 +1,9 @@ +2011-11-08 Zeno Albisser z...@webkit.org + +Added myself as a committer. + +* Scripts/webkitpy/common/config/committers.py: + 2011-11-08 Andy Wingo wi...@igalia.com Skip some ECMAScript tests that fail on Linux in some time zones. Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (99597 => 99598) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-11-08 19:19:35 UTC (rev 99597) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-11-08 19:29:58 UTC (rev 99598) @@ -315,6 +315,7 @@ Committer(Yi Shen, [yi.4.s...@nokia.com, shenyi2...@gmail.com]), Committer(Yuta Kitamura, yu...@chromium.org, yutak), Committer(Yuzo Fujishima, y...@google.com, yuzo), +Committer(Zeno Albisser, [z...@webkit.org, zeno.albis...@nokia.com], zalbisser), Committer(Zhenyao Mo, z...@google.com, zhenyao), Committer(Zoltan Horvath, [zol...@webkit.org, hzol...@inf.u-szeged.hu, horvath.zolta...@stud.u-szeged.hu], zoltan), Committer(Naoki Takano, [hon...@chromium.org, takano.na...@gmail.com], honten), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99599] trunk
Title: [99599] trunk
Revision 99599
Author commit-qu...@webkit.org
Date 2011-11-08 11:41:41 -0800 (Tue, 08 Nov 2011)
Log Message
IndexedDB: reference cycle between IDBDatabase and IDBTransaction
https://bugs.webkit.org/show_bug.cgi?id=71749
Patch by Joshua Bell jsb...@chromium.org on 2011-11-08
Reviewed by Tony Chang.
Source/WebCore:
Break a cyclic reference leak following a setVersion call.
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::setVersionChangeTransaction):
(WebCore::IDBDatabase::clearVersionChangeTransaction):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
* storage/IDBDatabase.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::create):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
LayoutTests:
Add test case to verify that creating/deleting a store outside
a transaction throws same error if store exists. Also fix
the test to actually try removing stores.
* storage/indexeddb/create-and-remove-object-store-expected.txt:
* storage/indexeddb/create-and-remove-object-store.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/create-and-remove-object-store-expected.txt
trunk/LayoutTests/storage/indexeddb/create-and-remove-object-store.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/IDBDatabase.cpp
trunk/Source/WebCore/storage/IDBDatabase.h
trunk/Source/WebCore/storage/IDBRequest.cpp
trunk/Source/WebCore/storage/IDBTransaction.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (99598 => 99599)
--- trunk/LayoutTests/ChangeLog 2011-11-08 19:29:58 UTC (rev 99598)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 19:41:41 UTC (rev 99599)
@@ -1,3 +1,17 @@
+2011-11-08 Joshua Bell jsb...@chromium.org
+
+IndexedDB: reference cycle between IDBDatabase and IDBTransaction
+https://bugs.webkit.org/show_bug.cgi?id=71749
+
+Reviewed by Tony Chang.
+
+Add test case to verify that creating/deleting a store outside
+a transaction throws same error if store exists. Also fix
+the test to actually try removing stores.
+
+* storage/indexeddb/create-and-remove-object-store-expected.txt:
+* storage/indexeddb/create-and-remove-object-store.html:
+
2011-11-08 Ojan Vafai o...@chromium.org
Fix expectations mixup.
Modified: trunk/LayoutTests/storage/indexeddb/create-and-remove-object-store-expected.txt (99598 => 99599)
--- trunk/LayoutTests/storage/indexeddb/create-and-remove-object-store-expected.txt 2011-11-08 19:29:58 UTC (rev 99598)
+++ trunk/LayoutTests/storage/indexeddb/create-and-remove-object-store-expected.txt 2011-11-08 19:41:41 UTC (rev 99599)
@@ -11,7 +11,7 @@
PASS Exception was thrown.
PASS code is webkitIDBDatabaseException.NOT_ALLOWED_ERR
Trying remove
-Expecting exception from db.createObjectStore(some os)
+Expecting exception from db.deleteObjectStore(some os)
PASS Exception was thrown.
PASS code is webkitIDBDatabaseException.NOT_ALLOWED_ERR
result = db.setVersion('version 1')
@@ -20,7 +20,7 @@
PASS Exception was thrown.
PASS code is webkitIDBDatabaseException.NOT_ALLOWED_ERR
Trying remove
-Expecting exception from db.createObjectStore(some os)
+Expecting exception from db.deleteObjectStore(some os)
PASS Exception was thrown.
PASS code is webkitIDBDatabaseException.NOT_ALLOWED_ERR
Deleted all object stores.
@@ -36,9 +36,17 @@
PASS Exception was thrown.
PASS code is webkitIDBDatabaseException.NOT_ALLOWED_ERR
Trying remove
-Expecting exception from db.createObjectStore(some os)
+Expecting exception from db.deleteObjectStore(some os)
PASS Exception was thrown.
PASS code is webkitIDBDatabaseException.NOT_ALLOWED_ERR
+Trying create with store that already exists
+Expecting exception from db.createObjectStore('tmp')
+PASS Exception was thrown.
+PASS code is webkitIDBDatabaseException.NOT_ALLOWED_ERR
+Trying remove with store that already exists
+Expecting exception from db.deleteObjectStore('tmp')
+PASS Exception was thrown.
+PASS code is webkitIDBDatabaseException.NOT_ALLOWED_ERR
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/storage/indexeddb/create-and-remove-object-store.html (99598 => 99599)
--- trunk/LayoutTests/storage/indexeddb/create-and-remove-object-store.html 2011-11-08 19:29:58 UTC (rev 99598)
+++ trunk/LayoutTests/storage/indexeddb/create-and-remove-object-store.html 2011-11-08 19:41:41 UTC (rev 99599)
@@ -35,7 +35,7 @@
debug(Trying create);
evalAndExpectException('db.createObjectStore(some os)', webkitIDBDatabaseException.NOT_ALLOWED_ERR);
debug(Trying remove);
-evalAndExpectException('db.createObjectStore(some os)', webkitIDBDatabaseException.NOT_ALLOWED_ERR);
+evalAndExpectException('db.deleteObjectStore(some os)', webkitIDBDatabaseException.NOT_ALLOWED_ERR);
}
function cleanDatabase()
@@ -57,6 +57,11 @@
testCreateAndRemove();
+
[webkit-changes] [99600] branches/safari-534.53-branch/Source/WebCore
Title: [99600] branches/safari-534.53-branch/Source/WebCore
Revision 99600
Author lforsch...@apple.com
Date 2011-11-08 12:00:53 -0800 (Tue, 08 Nov 2011)
Log Message
Merged r99508.
Modified Paths
branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/page/FrameView.cpp
Diff
Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (99599 => 99600)
--- branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-08 19:41:41 UTC (rev 99599)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-08 20:00:53 UTC (rev 99600)
@@ -1,3 +1,17 @@
+2011-11-08 Lucas Forschler lforsch...@apple.com
+
+Merge 99508
+
+2011-11-07 Dan Bernstein m...@apple.com
+
+rdar://problem/10405215 REGRESSION (r98178): World of Warcraft Launcher crashes in FrameView::isOnActivePage()
+https://bugs.webkit.org/show_bug.cgi?id=71743
+
+Reviewed by Beth Dakin.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::isOnActivePage): Added a check for a null m_frame.
+
2011-10-31 Lucas Forschler lforsch...@apple.com
Merge 98936
Modified: branches/safari-534.53-branch/Source/WebCore/page/FrameView.cpp (99599 => 99600)
--- branches/safari-534.53-branch/Source/WebCore/page/FrameView.cpp 2011-11-08 19:41:41 UTC (rev 99599)
+++ branches/safari-534.53-branch/Source/WebCore/page/FrameView.cpp 2011-11-08 20:00:53 UTC (rev 99600)
@@ -2234,6 +2234,8 @@
bool FrameView::isOnActivePage() const
{
+if (!m_frame)
+return false;
if (m_frame-view() != this)
return false;
if (Document* document = m_frame-document())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99601] branches/safari-534.53-branch/Source
Title: [99601] branches/safari-534.53-branch/Source Revision 99601 Author lforsch...@apple.com Date 2011-11-08 12:02:40 -0800 (Tue, 08 Nov 2011) Log Message Versioning. Modified Paths branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig (99600 => 99601) --- branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-11-08 20:00:53 UTC (rev 99600) +++ branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-11-08 20:02:40 UTC (rev 99601) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 53; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (99600 => 99601) --- branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-11-08 20:00:53 UTC (rev 99600) +++ branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-11-08 20:02:40 UTC (rev 99601) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 53; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig (99600 => 99601) --- branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig 2011-11-08 20:00:53 UTC (rev 99600) +++ branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig 2011-11-08 20:02:40 UTC (rev 99601) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 53; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig (99600 => 99601) --- branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-11-08 20:00:53 UTC (rev 99600) +++ branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-11-08 20:02:40 UTC (rev 99601) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 53; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig (99600 => 99601) --- branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-11-08 20:00:53 UTC (rev 99600) +++ branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-11-08 20:02:40 UTC (rev 99601) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 53; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99602] tags/Safari-534.53.2/
Title: [99602] tags/Safari-534.53.2/ Revision 99602 Author lforsch...@apple.com Date 2011-11-08 12:08:51 -0800 (Tue, 08 Nov 2011) Log Message New tag. Added Paths tags/Safari-534.53.2/ Diff Property changes: tags/Safari-534.53.2 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99603] trunk/Source/WebKit2
Title: [99603] trunk/Source/WebKit2
Revision 99603
Author commit-qu...@webkit.org
Date 2011-11-08 12:10:44 -0800 (Tue, 08 Nov 2011)
Log Message
[WK2][GTK] The default database local storage directory names should note they exist for Gtk port's needs
https://bugs.webkit.org/show_bug.cgi?id=71837
Patch by Zan Dobersek zandober...@gmail.com on 2011-11-08
Reviewed by Martin Robinson.
Ensure that directories for databases and local storage are in a 'webkitgtk'
directory in current user's data directory, noting they originate from the Gtk port.
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultDatabaseDirectory):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (99602 => 99603)
--- trunk/Source/WebKit2/ChangeLog 2011-11-08 20:08:51 UTC (rev 99602)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-08 20:10:44 UTC (rev 99603)
@@ -1,3 +1,17 @@
+2011-11-08 Zan Dobersek zandober...@gmail.com
+
+[WK2][GTK] The default database local storage directory names should note they exist for Gtk port's needs
+https://bugs.webkit.org/show_bug.cgi?id=71837
+
+Reviewed by Martin Robinson.
+
+Ensure that directories for databases and local storage are in a 'webkitgtk'
+directory in current user's data directory, noting they originate from the Gtk port.
+
+* UIProcess/gtk/WebContextGtk.cpp:
+(WebKit::WebContext::platformDefaultDatabaseDirectory):
+(WebKit::WebContext::platformDefaultLocalStorageDirectory):
+
2011-11-08 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org
[Qt] Workaround some problems in QML API tests
Modified: trunk/Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp (99602 => 99603)
--- trunk/Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp 2011-11-08 20:08:51 UTC (rev 99602)
+++ trunk/Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp 2011-11-08 20:10:44 UTC (rev 99603)
@@ -47,7 +47,7 @@
String WebContext::platformDefaultDatabaseDirectory() const
{
-GOwnPtrgchar databaseDirectory(g_build_filename(g_get_user_data_dir(), webkit, databases, NULL));
+GOwnPtrgchar databaseDirectory(g_build_filename(g_get_user_data_dir(), webkitgtk, databases, NULL));
return WebCore::filenameToString(databaseDirectory.get());
}
@@ -59,7 +59,7 @@
String WebContext::platformDefaultLocalStorageDirectory() const
{
-GOwnPtrgchar storageDirectory(g_build_filename(g_get_user_data_dir(), webkit, localstorage, NULL));
+GOwnPtrgchar storageDirectory(g_build_filename(g_get_user_data_dir(), webkitgtk, localstorage, NULL));
return WebCore::filenameToString(storageDirectory.get());
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99604] trunk/Tools/WebKitTestRunner/TestController.cpp
Title: [99604] trunk/Tools/WebKitTestRunner/TestController.cpp Revision 99604 Author hy...@apple.com Date 2011-11-08 12:14:32 -0800 (Tue, 08 Nov 2011) Log Message Fix build bustage. Modified Paths trunk/Tools/WebKitTestRunner/TestController.cpp Diff Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (99603 => 99604) --- trunk/Tools/WebKitTestRunner/TestController.cpp 2011-11-08 20:10:44 UTC (rev 99603) +++ trunk/Tools/WebKitTestRunner/TestController.cpp 2011-11-08 20:14:32 UTC (rev 99604) @@ -387,7 +387,6 @@ 0, // didChangeBackForwardList 0, // shouldGoToBackForwardListItem 0, // didRunInsecureContentForFrame -0, // didDetectXSSForFrame }; WKPageSetPageLoaderClient(m_mainWebView-page(), pageLoaderClient); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99605] trunk/Tools/MiniBrowser/mac/BrowserWindowController.m
Title: [99605] trunk/Tools/MiniBrowser/mac/BrowserWindowController.m
Revision 99605
Author hy...@apple.com
Date 2011-11-08 12:20:08 -0800 (Tue, 08 Nov 2011)
Log Message
Fix more build bustage.
Modified Paths
trunk/Tools/MiniBrowser/mac/BrowserWindowController.m
Diff
Modified: trunk/Tools/MiniBrowser/mac/BrowserWindowController.m (99604 => 99605)
--- trunk/Tools/MiniBrowser/mac/BrowserWindowController.m 2011-11-08 20:14:32 UTC (rev 99604)
+++ trunk/Tools/MiniBrowser/mac/BrowserWindowController.m 2011-11-08 20:20:08 UTC (rev 99605)
@@ -325,11 +325,6 @@
LOG(@didRunInsecureContentForFrame);
}
-static void didDetectXSSForFrame(WKPageRef page, WKFrameRef frame, WKTypeRef userData, const void *clientInfo)
-{
-LOG(@didDetectXSSForFrame);
-}
-
static void didStartProgress(WKPageRef page, const void *clientInfo)
{
[(BrowserWindowController *)clientInfo didStartProgress];
@@ -609,7 +604,6 @@
didChangeBackForwardList,
0, // shouldGoToBackForwardItem
0, // didFailToInitializePlugin
-didDetectXSSForFrame,
};
WKPageSetPageLoaderClient(_webView.pageRef, loadClient);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99606] trunk/Source/WebKit2
Title: [99606] trunk/Source/WebKit2
Revision 99606
Author jon...@apple.com
Date 2011-11-08 12:31:25 -0800 (Tue, 08 Nov 2011)
Log Message
[WK2] Expose acceptMIMETypes for file inputs
https://bugs.webkit.org/show_bug.cgi?id=71836
rdar://problem/10407367
Reviewed by Anders Carlsson.
* Shared/WebOpenPanelParameters.cpp:
(WebKit::WebOpenPanelParameters::acceptMIMETypes):
* Shared/WebOpenPanelParameters.h:
* UIProcess/API/C/WKOpenPanelParameters.cpp:
(WKOpenPanelParametersCopyAcceptedMIMETypes):
* UIProcess/API/C/WKOpenPanelParameters.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebOpenPanelParameters.cpp
trunk/Source/WebKit2/Shared/WebOpenPanelParameters.h
trunk/Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (99605 => 99606)
--- trunk/Source/WebKit2/ChangeLog 2011-11-08 20:20:08 UTC (rev 99605)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-08 20:31:25 UTC (rev 99606)
@@ -1,3 +1,18 @@
+2011-11-08 Jon Lee jon...@apple.com
+
+[WK2] Expose acceptMIMETypes for file inputs
+https://bugs.webkit.org/show_bug.cgi?id=71836
+rdar://problem/10407367
+
+Reviewed by Anders Carlsson.
+
+* Shared/WebOpenPanelParameters.cpp:
+(WebKit::WebOpenPanelParameters::acceptMIMETypes):
+* Shared/WebOpenPanelParameters.h:
+* UIProcess/API/C/WKOpenPanelParameters.cpp:
+(WKOpenPanelParametersCopyAcceptedMIMETypes):
+* UIProcess/API/C/WKOpenPanelParameters.h:
+
2011-11-08 Zan Dobersek zandober...@gmail.com
[WK2][GTK] The default database local storage directory names should note they exist for Gtk port's needs
Modified: trunk/Source/WebKit2/Shared/WebOpenPanelParameters.cpp (99605 => 99606)
--- trunk/Source/WebKit2/Shared/WebOpenPanelParameters.cpp 2011-11-08 20:20:08 UTC (rev 99605)
+++ trunk/Source/WebKit2/Shared/WebOpenPanelParameters.cpp 2011-11-08 20:31:25 UTC (rev 99606)
@@ -26,6 +26,10 @@
#include config.h
#include WebOpenPanelParameters.h
+#include ImmutableArray.h
+#include WebString.h
+#include wtf/Vector.h
+
using namespace WebCore;
namespace WebKit {
@@ -44,4 +48,16 @@
{
}
+PassRefPtrImmutableArray WebOpenPanelParameters::acceptMIMETypes() const
+{
+size_t size = m_settings.acceptMIMETypes.size();
+
+VectorRefPtrAPIObject vector;
+vector.reserveInitialCapacity(size);
+
+for (size_t i = 0; i size; ++i)
+vector.uncheckedAppend(WebString::create(m_settings.acceptMIMETypes[i]));
+return ImmutableArray::adopt(vector);
+}
+
} // namespace WebCore
Modified: trunk/Source/WebKit2/Shared/WebOpenPanelParameters.h (99605 => 99606)
--- trunk/Source/WebKit2/Shared/WebOpenPanelParameters.h 2011-11-08 20:20:08 UTC (rev 99605)
+++ trunk/Source/WebKit2/Shared/WebOpenPanelParameters.h 2011-11-08 20:31:25 UTC (rev 99606)
@@ -33,6 +33,8 @@
namespace WebKit {
+class ImmutableArray;
+
class WebOpenPanelParameters : public APIObject {
public:
static const Type APIType = TypeOpenPanelParameters;
@@ -41,6 +43,7 @@
~WebOpenPanelParameters();
bool allowMultipleFiles() const { return m_settings.allowsMultipleFiles; }
+PassRefPtrImmutableArray acceptMIMETypes() const;
VectorString selectedFileNames() const { return m_settings.selectedFiles; }
private:
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.cpp (99605 => 99606)
--- trunk/Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.cpp 2011-11-08 20:20:08 UTC (rev 99605)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.cpp 2011-11-08 20:31:25 UTC (rev 99606)
@@ -26,6 +26,7 @@
#include config.h
#include WKOpenPanelParameters.h
+#include ImmutableArray.h
#include WKAPICast.h
#include WebOpenPanelParameters.h
@@ -40,3 +41,8 @@
{
return toImpl(parametersRef)-allowMultipleFiles();
}
+
+WKArrayRef WKOpenPanelParametersCopyAcceptedMIMETypes(WKOpenPanelParametersRef parametersRef)
+{
+return toAPI(toImpl(parametersRef)-acceptMIMETypes().leakRef());
+}
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.h (99605 => 99606)
--- trunk/Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.h 2011-11-08 20:20:08 UTC (rev 99605)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.h 2011-11-08 20:31:25 UTC (rev 99606)
@@ -40,6 +40,8 @@
WK_EXPORT bool WKOpenPanelParametersGetAllowsMultipleFiles(WKOpenPanelParametersRef parameters);
+WK_EXPORT WKArrayRef WKOpenPanelParametersCopyAcceptedMIMETypes(WKOpenPanelParametersRef parameters);
+
#ifdef __cplusplus
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99607] trunk/Source/WebCore
Title: [99607] trunk/Source/WebCore
Revision 99607
Author dba...@webkit.org
Date 2011-11-08 12:33:30 -0800 (Tue, 08 Nov 2011)
Log Message
Remove get() defined in CredentialStorageQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=71829
Reviewed by Andreas Kling.
CredentialStorage::get() is implemented in CredentialStorage.cpp. And CredentialStorage.cpp
provides the base implementation for each platform. We shouldn't re-define
CredentialStorage::get() in CredentialStorageQt.cpp.
* Target.pri: Add files CredentialStorage.{cpp, h}.
* platform/network/qt/CredentialStorageQt.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/platform/network/qt/CredentialStorageQt.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (99606 => 99607)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 20:31:25 UTC (rev 99606)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 20:33:30 UTC (rev 99607)
@@ -1,3 +1,17 @@
+2011-11-08 Daniel Bates dba...@webkit.org
+
+Remove get() defined in CredentialStorageQt.cpp
+https://bugs.webkit.org/show_bug.cgi?id=71829
+
+Reviewed by Andreas Kling.
+
+CredentialStorage::get() is implemented in CredentialStorage.cpp. And CredentialStorage.cpp
+provides the base implementation for each platform. We shouldn't re-define
+CredentialStorage::get() in CredentialStorageQt.cpp.
+
+* Target.pri: Add files CredentialStorage.{cpp, h}.
+* platform/network/qt/CredentialStorageQt.cpp:
+
2011-11-08 Joshua Bell jsb...@chromium.org
IndexedDB: reference cycle between IDBDatabase and IDBTransaction
Modified: trunk/Source/WebCore/Target.pri (99606 => 99607)
--- trunk/Source/WebCore/Target.pri 2011-11-08 20:31:25 UTC (rev 99606)
+++ trunk/Source/WebCore/Target.pri 2011-11-08 20:33:30 UTC (rev 99607)
@@ -1103,6 +1103,7 @@
platform/network/BlobRegistryImpl.cpp \
platform/network/BlobResourceHandle.cpp \
platform/network/Credential.cpp \
+platform/network/CredentialStorage.cpp \
platform/network/FormData.cpp \
platform/network/FormDataBuilder.cpp \
platform/network/HTTPHeaderMap.cpp \
@@ -2178,6 +2179,7 @@
platform/network/BlobStorageData.h \
platform/network/CookieStorage.h \
platform/network/Credential.h \
+platform/network/CredentialStorage.h \
platform/network/FormDataBuilder.h \
platform/network/FormData.h \
platform/network/HTTPHeaderMap.h \
Modified: trunk/Source/WebCore/platform/network/qt/CredentialStorageQt.cpp (99606 => 99607)
--- trunk/Source/WebCore/platform/network/qt/CredentialStorageQt.cpp 2011-11-08 20:31:25 UTC (rev 99606)
+++ trunk/Source/WebCore/platform/network/qt/CredentialStorageQt.cpp 2011-11-08 20:33:30 UTC (rev 99607)
@@ -35,9 +35,4 @@
return Credential();
}
-Credential CredentialStorage::get(const ProtectionSpace)
-{
-return Credential();
-}
-
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99608] trunk/Source/JavaScriptCore
Title: [99608] trunk/Source/_javascript_Core
Revision 99608
Author msab...@apple.com
Date 2011-11-08 12:37:52 -0800 (Tue, 08 Nov 2011)
Log Message
JSC::Parser::Parser leaks Lexer member
https://bugs.webkit.org/show_bug.cgi?id=71847
Changed m_lexer member of Parser to be OwnPtr to fix a memory leak.
Reviewed by Oliver Hunt.
* parser/Parser.cpp:
(JSC::Parser::Parser):
(JSC::Parser::parseFunctionBody):
* parser/Parser.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Parser.cpp
trunk/Source/_javascript_Core/parser/Parser.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99607 => 99608)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-08 20:33:30 UTC (rev 99607)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-08 20:37:52 UTC (rev 99608)
@@ -1,3 +1,17 @@
+2011-11-08 Michael Saboff msab...@apple.com
+
+JSC::Parser::Parser leaks Lexer member
+https://bugs.webkit.org/show_bug.cgi?id=71847
+
+Changed m_lexer member of Parser to be OwnPtr to fix a memory leak.
+
+Reviewed by Oliver Hunt.
+
+* parser/Parser.cpp:
+(JSC::Parser::Parser):
+(JSC::Parser::parseFunctionBody):
+* parser/Parser.h:
+
2011-11-08 Yuqiang Xian yuqiang.x...@intel.com
Enable DFG JIT by default on X86 Linux and Mac platforms
Modified: trunk/Source/_javascript_Core/parser/Parser.cpp (99607 => 99608)
--- trunk/Source/_javascript_Core/parser/Parser.cpp 2011-11-08 20:33:30 UTC (rev 99607)
+++ trunk/Source/_javascript_Core/parser/Parser.cpp 2011-11-08 20:37:52 UTC (rev 99608)
@@ -57,7 +57,7 @@
, m_lastIdentifier(0)
, m_sourceElements(0)
{
-m_lexer = new LexerUChar(globalData);
+m_lexer = adoptPtr(new LexerUChar(globalData));
m_arena = m_globalData-parserArena;
m_lexer-setCode(source, m_arena);
@@ -740,7 +740,7 @@
return context.createFunctionBody(m_lexer-lastLineNumber(), strictMode());
DepthManager statementDepth(m_statementDepth);
m_statementDepth = 0;
-typename TreeBuilder::FunctionBodyBuilder bodyBuilder(const_castJSGlobalData*(m_globalData), m_lexer);
+typename TreeBuilder::FunctionBodyBuilder bodyBuilder(const_castJSGlobalData*(m_globalData), m_lexer.get());
failIfFalse(parseSourceElementsCheckForStrictMode(bodyBuilder));
return context.createFunctionBody(m_lexer-lastLineNumber(), strictMode());
}
Modified: trunk/Source/_javascript_Core/parser/Parser.h (99607 => 99608)
--- trunk/Source/_javascript_Core/parser/Parser.h 2011-11-08 20:33:30 UTC (rev 99607)
+++ trunk/Source/_javascript_Core/parser/Parser.h 2011-11-08 20:37:52 UTC (rev 99608)
@@ -920,7 +920,7 @@
mutable const JSGlobalData* m_globalData;
const SourceCode* m_source;
ParserArena* m_arena;
-LexerUChar* m_lexer;
+OwnPtr LexerUChar m_lexer;
StackBounds m_stack;
bool m_error;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99610] trunk/Tools
Title: [99610] trunk/Tools
Revision 99610
Author hy...@apple.com
Date 2011-11-08 12:53:55 -0800 (Tue, 08 Nov 2011)
Log Message
Revert check-in. My mistake.
Modified Paths
trunk/Tools/MiniBrowser/mac/BrowserWindowController.m
trunk/Tools/WebKitTestRunner/TestController.cpp
Diff
Modified: trunk/Tools/MiniBrowser/mac/BrowserWindowController.m (99609 => 99610)
--- trunk/Tools/MiniBrowser/mac/BrowserWindowController.m 2011-11-08 20:51:14 UTC (rev 99609)
+++ trunk/Tools/MiniBrowser/mac/BrowserWindowController.m 2011-11-08 20:53:55 UTC (rev 99610)
@@ -325,6 +325,11 @@
LOG(@didRunInsecureContentForFrame);
}
+static void didDetectXSSForFrame(WKPageRef page, WKFrameRef frame, WKTypeRef userData, const void *clientInfo)
+{
+LOG(@didDetectXSSForFrame);
+}
+
static void didStartProgress(WKPageRef page, const void *clientInfo)
{
[(BrowserWindowController *)clientInfo didStartProgress];
@@ -604,6 +609,7 @@
didChangeBackForwardList,
0, // shouldGoToBackForwardItem
0, // didFailToInitializePlugin
+didDetectXSSForFrame,
};
WKPageSetPageLoaderClient(_webView.pageRef, loadClient);
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (99609 => 99610)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2011-11-08 20:51:14 UTC (rev 99609)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2011-11-08 20:53:55 UTC (rev 99610)
@@ -387,6 +387,7 @@
0, // didChangeBackForwardList
0, // shouldGoToBackForwardListItem
0, // didRunInsecureContentForFrame
+0 // didDetectXSSForFrame
};
WKPageSetPageLoaderClient(m_mainWebView-page(), pageLoaderClient);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99611] trunk
Title: [99611] trunk
Revision 99611
Author ad...@chromium.org
Date 2011-11-08 12:59:47 -0800 (Tue, 08 Nov 2011)
Log Message
WebKitMutationObserver.observe should raise a DOMException if passed invalid arguments
https://bugs.webkit.org/show_bug.cgi?id=71596
Reviewed by Ryosuke Niwa.
Source/WebCore:
Adds two cases where WebKitMutationObserver.observe throws an exception:
- When passed a null Node*.
- When passed options that don't make sense, e.g.,
'attributeOldValue' but not 'attributes'.
* bindings/js/JSWebKitMutationObserverCustom.cpp:
(WebCore::JSWebKitMutationObserver::observe):
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::observeCallback):
* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::validateOptions):
(WebCore::WebKitMutationObserver::observe):
* dom/WebKitMutationObserver.h:
* dom/WebKitMutationObserver.idl:
LayoutTests:
* fast/mutation/observe-exceptions-expected.txt:
* fast/mutation/observe-exceptions.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mutation/observe-exceptions-expected.txt
trunk/LayoutTests/fast/mutation/observe-exceptions.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSWebKitMutationObserverCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8WebKitMutationObserverCustom.cpp
trunk/Source/WebCore/dom/WebKitMutationObserver.cpp
trunk/Source/WebCore/dom/WebKitMutationObserver.h
trunk/Source/WebCore/dom/WebKitMutationObserver.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (99610 => 99611)
--- trunk/LayoutTests/ChangeLog 2011-11-08 20:53:55 UTC (rev 99610)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 20:59:47 UTC (rev 99611)
@@ -1,3 +1,13 @@
+2011-11-08 Adam Klein ad...@chromium.org
+
+WebKitMutationObserver.observe should raise a DOMException if passed invalid arguments
+https://bugs.webkit.org/show_bug.cgi?id=71596
+
+Reviewed by Ryosuke Niwa.
+
+* fast/mutation/observe-exceptions-expected.txt:
+* fast/mutation/observe-exceptions.html:
+
2011-11-08 Joshua Bell jsb...@chromium.org
IndexedDB: implement compound (array) key support
Modified: trunk/LayoutTests/fast/mutation/observe-exceptions-expected.txt (99610 => 99611)
--- trunk/LayoutTests/fast/mutation/observe-exceptions-expected.txt 2011-11-08 20:53:55 UTC (rev 99610)
+++ trunk/LayoutTests/fast/mutation/observe-exceptions-expected.txt 2011-11-08 20:59:47 UTC (rev 99611)
@@ -9,6 +9,11 @@
PASS observer.observe(document.body) threw exception TypeError: Not enough arguments.
PASS observer.observe(document.body, null) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
PASS observer.observe(document.body, undefined) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
+PASS observer.observe(null, {attributes: true}) threw exception Error: NOT_FOUND_ERR: DOM Exception 8.
+PASS observer.observe(undefined, {attributes: true}) threw exception Error: NOT_FOUND_ERR: DOM Exception 8.
+PASS observer.observe(document.body, {subtree: true}) threw exception Error: SYNTAX_ERR: DOM Exception 12.
+PASS observer.observe(document.body, {childList: true, attributeOldValue: true}) threw exception Error: SYNTAX_ERR: DOM Exception 12.
+PASS observer.observe(document.body, {attributes: true, characterDataOldValue: true}) threw exception Error: SYNTAX_ERR: DOM Exception 12.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/mutation/observe-exceptions.html (99610 => 99611)
--- trunk/LayoutTests/fast/mutation/observe-exceptions.html 2011-11-08 20:53:55 UTC (rev 99610)
+++ trunk/LayoutTests/fast/mutation/observe-exceptions.html 2011-11-08 20:59:47 UTC (rev 99611)
@@ -18,6 +18,13 @@
shouldThrow('observer.observe(document.body)');
shouldThrow('observer.observe(document.body, null)');
shouldThrow('observer.observe(document.body, undefined)');
+shouldThrow('observer.observe(null, {attributes: true})');
+shouldThrow('observer.observe(undefined, {attributes: true})');
+shouldThrow('observer.observe(document.body, {subtree: true})');
+shouldThrow('observer.observe(document.body, {childList: true, attributeOldValue: true})');
+shouldThrow('observer.observe(document.body, {attributes: true, characterDataOldValue: true})');
+// FIXME: Uncomment the below when attributeFilter is supported.
+//shouldThrow('observer.observe(document.body, {characterData: true, attributeFilter: [id]})');
}
description('Test that WebKitMutationObserver.observe throws exceptions appropriately');
Modified: trunk/Source/WebCore/ChangeLog (99610 => 99611)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 20:53:55 UTC (rev 99610)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 20:59:47 UTC (rev 99611)
@@ -1,3 +1,25 @@
+2011-11-08 Adam Klein ad...@chromium.org
+
+WebKitMutationObserver.observe should raise a DOMException if passed invalid arguments
+
[webkit-changes] [99612] trunk
Title: [99612] trunk
Revision 99612
Author commit-qu...@webkit.org
Date 2011-11-08 13:02:00 -0800 (Tue, 08 Nov 2011)
Log Message
Document.importNode's 'deep' argument should default to true.
https://bugs.webkit.org/show_bug.cgi?id=71190
Patch by Vineet Chaudhary vineet.chaudh...@motorola.com on 2011-11-08
Reviewed by Adam Barth.
Source/WebCore:
As new specification says deep argument of importNode should be default to true.
Test: fast/dom/document-importNode-arguments.html
* dom/Document.h: Added supportive method.
(WebCore::Document::importNode):
* dom/Document.idl: Modified deep argument as optional.
LayoutTests:
Added test to check document.importNode with No deep argument,
deep argument true and false.
* fast/dom/document-importNode-arguments-expected.txt: Added.
* fast/dom/document-importNode-arguments.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/Document.idl
Added Paths
trunk/LayoutTests/fast/dom/document-importNode-arguments-expected.txt
trunk/LayoutTests/fast/dom/document-importNode-arguments.html
Diff
Modified: trunk/LayoutTests/ChangeLog (99611 => 99612)
--- trunk/LayoutTests/ChangeLog 2011-11-08 20:59:47 UTC (rev 99611)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 21:02:00 UTC (rev 99612)
@@ -1,3 +1,16 @@
+2011-11-08 Vineet Chaudhary vineet.chaudh...@motorola.com
+
+Document.importNode's 'deep' argument should default to true.
+https://bugs.webkit.org/show_bug.cgi?id=71190
+
+Reviewed by Adam Barth.
+
+Added test to check document.importNode with No deep argument,
+deep argument true and false.
+
+* fast/dom/document-importNode-arguments-expected.txt: Added.
+* fast/dom/document-importNode-arguments.html: Added.
+
2011-11-08 Adam Klein ad...@chromium.org
WebKitMutationObserver.observe should raise a DOMException if passed invalid arguments
Added: trunk/LayoutTests/fast/dom/document-importNode-arguments-expected.txt (0 => 99612)
--- trunk/LayoutTests/fast/dom/document-importNode-arguments-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/document-importNode-arguments-expected.txt 2011-11-08 21:02:00 UTC (rev 99612)
@@ -0,0 +1,9 @@
+This page tests calling document.importNode.
+
+PASS imported.childNodes.length is 2
+PASS imported.textContent == 'hello world' is true
+PASS imported.childNodes.length is 2
+PASS imported.textContent == 'hello world' is true
+PASS imported.childNodes.length is 0
+PASS imported.textContent == '' is true
+
Added: trunk/LayoutTests/fast/dom/document-importNode-arguments.html (0 => 99612)
--- trunk/LayoutTests/fast/dom/document-importNode-arguments.html (rev 0)
+++ trunk/LayoutTests/fast/dom/document-importNode-arguments.html 2011-11-08 21:02:00 UTC (rev 99612)
@@ -0,0 +1,31 @@
+html
+head
+script src=""
+/head
+body
+pThis page tests calling document.importNode./p
+div id='console'/div
+script
+var imported;
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+var d = document.createElement(div);
+d.innerHTML = spanhello /spanspanworld/span;
+
+imported = document.importNode(d);
+shouldBe('imported.childNodes.length','2');
+shouldBeTrue(imported.textContent == 'hello world');
+
+imported = document.importNode(d, true);
+shouldBe('imported.childNodes.length','2');
+shouldBeTrue(imported.textContent == 'hello world');
+
+imported = document.importNode(d, false);
+shouldBe('imported.childNodes.length','0');
+shouldBeTrue(imported.textContent == '');
+
+/script
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (99611 => 99612)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 20:59:47 UTC (rev 99611)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 21:02:00 UTC (rev 99612)
@@ -1,3 +1,18 @@
+2011-11-08 Vineet Chaudhary vineet.chaudh...@motorola.com
+
+Document.importNode's 'deep' argument should default to true.
+https://bugs.webkit.org/show_bug.cgi?id=71190
+
+Reviewed by Adam Barth.
+
+As new specification says deep argument of importNode should be default to true.
+
+Test: fast/dom/document-importNode-arguments.html
+
+* dom/Document.h: Added supportive method.
+(WebCore::Document::importNode):
+* dom/Document.idl: Modified deep argument as optional.
+
2011-11-08 Adam Klein ad...@chromium.org
WebKitMutationObserver.observe should raise a DOMException if passed invalid arguments
Modified: trunk/Source/WebCore/dom/Document.h (99611 => 99612)
--- trunk/Source/WebCore/dom/Document.h 2011-11-08 20:59:47 UTC (rev 99611)
+++ trunk/Source/WebCore/dom/Document.h 2011-11-08 21:02:00 UTC (rev 99612)
@@ -343,6 +343,7 @@
PassRefPtrAttr createAttribute(const String name, ExceptionCode);
PassRefPtrAttr createAttributeNS(const String namespaceURI, const String qualifiedName, ExceptionCode, bool
[webkit-changes] [99614] trunk/Source/JavaScriptCore
Title: [99614] trunk/Source/_javascript_Core
Revision 99614
Author barraclo...@apple.com
Date 2011-11-08 13:57:16 -0800 (Tue, 08 Nov 2011)
Log Message
DFG JIT calculation of OSR entry points is not THUMB2 safe
https://bugs.webkit.org/show_bug.cgi?id=71852
Reviewed by Oliver Hunt.
Executable addresses are tagged with a low bit set to distinguish
between THUMB2 and traditional ARM.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* jit/JITCode.h:
(JSC::JITCode::executableAddressAtOffset):
(JSC::JITCode::start):
(JSC::JITCode::size):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCompiler32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGOSREntry.cpp
trunk/Source/_javascript_Core/jit/JITCode.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99613 => 99614)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-08 21:14:55 UTC (rev 99613)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-08 21:57:16 UTC (rev 99614)
@@ -1,3 +1,24 @@
+2011-11-08 Gavin Barraclough barraclo...@apple.com
+
+DFG JIT calculation of OSR entry points is not THUMB2 safe
+https://bugs.webkit.org/show_bug.cgi?id=71852
+
+Reviewed by Oliver Hunt.
+
+Executable addresses are tagged with a low bit set to distinguish
+between THUMB2 and traditional ARM.
+
+* dfg/DFGJITCompiler.cpp:
+(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
+* dfg/DFGJITCompiler32_64.cpp:
+(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
+* dfg/DFGOSREntry.cpp:
+(JSC::DFG::prepareOSREntry):
+* jit/JITCode.h:
+(JSC::JITCode::executableAddressAtOffset):
+(JSC::JITCode::start):
+(JSC::JITCode::size):
+
2011-11-08 Michael Saboff msab...@apple.com
JSC::Parser::Parser leaks Lexer member
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp (99613 => 99614)
--- trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp 2011-11-08 21:14:55 UTC (rev 99613)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp 2011-11-08 21:57:16 UTC (rev 99614)
@@ -756,7 +756,7 @@
ASSERT(mapping);
ASSERT(mapping-m_bytecodeIndex == returnBytecodeIndex);
-void* jumpTarget = reinterpret_castvoid*(reinterpret_castuintptr_t(baselineCodeBlockForCaller-getJITCode().start()) + mapping-m_machineCodeOffset);
+void* jumpTarget = baselineCodeBlockForCaller-getJITCode().executableAddressAtOffset(mapping-m_machineCodeOffset);
GPRReg callerFrameGPR;
if (inlineCallFrame-caller.inlineCallFrame) {
@@ -786,7 +786,7 @@
ASSERT(mapping);
ASSERT(mapping-m_bytecodeIndex == exit.m_codeOrigin.bytecodeIndex);
-void* jumpTarget = reinterpret_castvoid*(reinterpret_castuintptr_t(baselineCodeBlock-getJITCode().start()) + mapping-m_machineCodeOffset);
+void* jumpTarget = baselineCodeBlock-getJITCode().executableAddressAtOffset(mapping-m_machineCodeOffset);
ASSERT(GPRInfo::regT1 != GPRInfo::cachedResultRegister);
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCompiler32_64.cpp (99613 => 99614)
--- trunk/Source/_javascript_Core/dfg/DFGJITCompiler32_64.cpp 2011-11-08 21:14:55 UTC (rev 99613)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCompiler32_64.cpp 2011-11-08 21:57:16 UTC (rev 99614)
@@ -512,7 +512,7 @@
ASSERT(mapping);
ASSERT(mapping-m_bytecodeIndex == returnBytecodeIndex);
-void* jumpTarget = reinterpret_castvoid*(reinterpret_castuintptr_t(baselineCodeBlockForCaller-getJITCode().start()) + mapping-m_machineCodeOffset);
+void* jumpTarget = baselineCodeBlockForCaller-getJITCode().executableAddressAtOffset(mapping-m_machineCodeOffset);
GPRReg callerFrameGPR;
if (inlineCallFrame-caller.inlineCallFrame) {
@@ -546,7 +546,7 @@
ASSERT(mapping);
ASSERT(mapping-m_bytecodeIndex == exit.m_codeOrigin.bytecodeIndex);
-void* jumpTarget = reinterpret_castvoid*(reinterpret_castuintptr_t(baselineCodeBlock-getJITCode().start()) + mapping-m_machineCodeOffset);
+void* jumpTarget = baselineCodeBlock-getJITCode().executableAddressAtOffset(mapping-m_machineCodeOffset);
ASSERT(GPRInfo::regT2 != GPRInfo::cachedResultRegister GPRInfo::regT2 != GPRInfo::cachedResultRegister2);
Modified: trunk/Source/_javascript_Core/dfg/DFGOSREntry.cpp (99613 => 99614)
--- trunk/Source/_javascript_Core/dfg/DFGOSREntry.cpp 2011-11-08 21:14:55 UTC (rev 99613)
+++ trunk/Source/_javascript_Core/dfg/DFGOSREntry.cpp 2011-11-08 21:57:16 UTC (rev 99614)
@@ -138,7 +138,7 @@
// 4) Find and return the destination machine code address.
-void* result =
[webkit-changes] [99615] trunk/Source/WebKit2
Title: [99615] trunk/Source/WebKit2 Revision 99615 Author ander...@apple.com Date 2011-11-08 14:01:16 -0800 (Tue, 08 Nov 2011) Log Message Add a basic layer hierarchy to the Core Animation drawing area https://bugs.webkit.org/show_bug.cgi?id=71838 Reviewed by Sam Weinig. * UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]): Return early if we're using a tiled drawing area. (-[WKView initWithFrame:contextRef:pageGroupRef:]): If we're using a tiled drawing area, make the WKView layer backed and set its layer to a simple CALayer with a white background and set the view's content redraw policy to never to avoid ever calling drawRect. * UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::didUpdateGeometry): * UIProcess/DrawingAreaProxy.messages.in: Add a new didUpdateGeometry message. * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h: * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm: (WebKit::TiledCoreAnimationDrawingAreaProxy::TiledCoreAnimationDrawingAreaProxy): Initialize m_isWaitingForDidUpdateGeometry. (WebKit::TiledCoreAnimationDrawingAreaProxy::sizeDidChange): Send an UpdateGeometry message to the web process and wait for a reply. (WebKit::TiledCoreAnimationDrawingAreaProxy::enterAcceleratedCompositingMode): Tell the web page proxy to enter accelerated compositing mode. (WebKit::TiledCoreAnimationDrawingAreaProxy::exitAcceleratedCompositingMode): Assert that this function is never called. (WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry): Send another UpdateGeometry message if needed. (WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry): Add helper function to actually send the UpdateGeometry message. * WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::updateGeometry): * WebProcess/WebPage/DrawingArea.messages.in: Add UpdateGeometry message. * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h: * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea): Create a red root layer and a remote layer client that hosts it. (WebKit::TiledCoreAnimationDrawingArea::updateGeometry): Resize the root layer and tell the UI process that we've updated the geometry. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.h trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.messages.in trunk/Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h trunk/Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.h trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.messages.in trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (99614 => 99615) --- trunk/Source/WebKit2/ChangeLog 2011-11-08 21:57:16 UTC (rev 99614) +++ trunk/Source/WebKit2/ChangeLog 2011-11-08 22:01:16 UTC (rev 99615) @@ -1,3 +1,57 @@ +2011-11-08 Anders Carlsson ander...@apple.com + +Add a basic layer hierarchy to the Core Animation drawing area +https://bugs.webkit.org/show_bug.cgi?id=71838 + +Reviewed by Sam Weinig. + +* UIProcess/API/mac/WKView.mm: +(-[WKView drawRect:]): +Return early if we're using a tiled drawing area. + +(-[WKView initWithFrame:contextRef:pageGroupRef:]): +If we're using a tiled drawing area, make the WKView layer backed and set its layer +to a simple CALayer with a white background and set the view's content redraw policy +to never to avoid ever calling drawRect. + +* UIProcess/DrawingAreaProxy.h: +(WebKit::DrawingAreaProxy::didUpdateGeometry): +* UIProcess/DrawingAreaProxy.messages.in: +Add a new didUpdateGeometry message. + +* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h: +* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm: +(WebKit::TiledCoreAnimationDrawingAreaProxy::TiledCoreAnimationDrawingAreaProxy): +Initialize m_isWaitingForDidUpdateGeometry. + +(WebKit::TiledCoreAnimationDrawingAreaProxy::sizeDidChange): +Send an UpdateGeometry message to the web process and wait for a reply. + +(WebKit::TiledCoreAnimationDrawingAreaProxy::enterAcceleratedCompositingMode): +Tell the web page proxy to enter accelerated compositing mode. + +(WebKit::TiledCoreAnimationDrawingAreaProxy::exitAcceleratedCompositingMode): +Assert that this function is never called. + +(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry): +Send another UpdateGeometry message if needed. + +(WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry): +Add helper function to actually send the UpdateGeometry message. + +* WebProcess/WebPage/DrawingArea.h: +
[webkit-changes] [99616] trunk
Title: [99616] trunk
Revision 99616
Author x...@chromium.org
Date 2011-11-08 14:22:24 -0800 (Tue, 08 Nov 2011)
Log Message
REGRESSION: rtl horizontal scrollbar / resize bug - Body shifts on resize when scrolled all the way to the left
https://bugs.webkit.org/show_bug.cgi?id=70395
Reviewed by Tony Chang.
Source/WebCore:
Change the condition to perform immediate scolling inside ScrollView::updateScrollbars()
to be correct for RTL page as well, which is checking either the scroll position change or
the m_scrollOrigin changes (such as in window resize in which scroll position might remain the same).
And remove condition checking inside ScrollableArea::scrollToOffsetWithoutAnimation() since
the pass-in offset is adjusted within the current scroll range, it could be the same as
m_currentPos when m_currentPos is (0, 0) and current scroll range is smaller than old
scroll range, but scolling is still needed when page resize and scroll range changes.
Test: fast/dom/rtl-scroll-to-leftmost-and-resize.html
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation): Remove condition checking.
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars): Change condition to perform immediate scrolling to be
correct for RTL pages as well.
* platform/ScrollableArea.cpp: Update m_scrollOriginChanged.
(WebCore::ScrollableArea::ScrollableArea):
(WebCore::ScrollableArea::setScrollOrigin):
(WebCore::ScrollableArea::setScrollOriginX):
(WebCore::ScrollableArea::setScrollOriginY):
* platform/ScrollableArea.h: Add m_scrollOriginChanged.
(WebCore::ScrollableArea::scrollOriginChanged):
(WebCore::ScrollableArea::resetScrollOriginChanged):
LayoutTests:
* fast/dom/rtl-scroll-to-leftmost-and-resize.html: Added.
* platform/chromium/test_expectations.txt:
* platform/mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
* platform/mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollAnimator.cpp
trunk/Source/WebCore/platform/ScrollView.cpp
trunk/Source/WebCore/platform/ScrollableArea.cpp
trunk/Source/WebCore/platform/ScrollableArea.h
Added Paths
trunk/LayoutTests/fast/dom/rtl-scroll-to-leftmost-and-resize.html
trunk/LayoutTests/platform/mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png
trunk/LayoutTests/platform/mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (99615 => 99616)
--- trunk/LayoutTests/ChangeLog 2011-11-08 22:01:16 UTC (rev 99615)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 22:22:24 UTC (rev 99616)
@@ -1,3 +1,15 @@
+2011-11-08 Xiaomei Ji x...@chromium.org
+
+REGRESSION: rtl horizontal scrollbar / resize bug - Body shifts on resize when scrolled all the way to the left
+https://bugs.webkit.org/show_bug.cgi?id=70395
+
+Reviewed by Tony Chang.
+
+* fast/dom/rtl-scroll-to-leftmost-and-resize.html: Added.
+* platform/chromium/test_expectations.txt:
+* platform/mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
+* platform/mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
+
2011-11-08 Dan Bernstein m...@apple.com
rdar://problem/10262225 Allow RenderView to have columns
Added: trunk/LayoutTests/fast/dom/rtl-scroll-to-leftmost-and-resize.html (0 => 99616)
--- trunk/LayoutTests/fast/dom/rtl-scroll-to-leftmost-and-resize.html (rev 0)
+++ trunk/LayoutTests/fast/dom/rtl-scroll-to-leftmost-and-resize.html 2011-11-08 22:22:24 UTC (rev 99616)
@@ -0,0 +1,19 @@
+!DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0 Transitional//EN http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd
+html
+head
+script type=text/_javascript_
+_onload_ = function()
+{
+window.resizeTo(250, window.innerHeight);
+window.scrollTo(-10, 0);
+window.resizeTo(350, window.innerHeight);
+}
+/script
+/head
+body style=direction: rtl
+div style=whitespace:nowrap; width: 1000px; height: 4000px; border: 1px solid red;
+BEGINEND
+/div
+/body
+/html
+
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99615 => 99616)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-08 22:01:16 UTC (rev 99615)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-08 22:22:24 UTC (rev 99616)
@@ -3939,3 +3939,6 @@
BUGRICOW : fast/js/toString-overrides.html = TEXT
BUGRICOW : fast/js/toString-recursion.html = TEXT
BUGRICOW : http/tests/security/xss-eval.html = TEXT
+
+// Need rebaseline.
+BUGXJI
[webkit-changes] [99617] trunk/Source
Title: [99617] trunk/Source
Revision 99617
Author bda...@apple.com
Date 2011-11-08 14:44:17 -0800 (Tue, 08 Nov 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=71856
WebKit should use new NSWindowDidChangeBackingPropertiesNotification instead of
old NSWindowDidChangeResolutionNotification
-and corresponding-
rdar://problem/10317253
Reviewed by Tim Hatcher.
Source/WebKit/mac:
* WebView/WebView.mm:
(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):
We have to check that the backing scale factor actually changed since this
notification can also be used to signify other changes.
(-[WebView _windowDidChangeBackingProperties:]):
Source/WebKit2:
* UIProcess/API/mac/WKView.mm:
(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):
We have to check that the backing scale factor actually changed since this
notification can also be used to signify other changes.
(-[WKView _windowDidChangeBackingProperties:]):
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (99616 => 99617)
--- trunk/Source/WebKit/mac/ChangeLog 2011-11-08 22:22:24 UTC (rev 99616)
+++ trunk/Source/WebKit/mac/ChangeLog 2011-11-08 22:44:17 UTC (rev 99617)
@@ -1,3 +1,21 @@
+2011-11-08 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=71856
+WebKit should use new NSWindowDidChangeBackingPropertiesNotification instead of
+old NSWindowDidChangeResolutionNotification
+-and corresponding-
+rdar://problem/10317253
+
+Reviewed by Tim Hatcher.
+
+* WebView/WebView.mm:
+(-[WebView addWindowObserversForWindow:]):
+(-[WebView removeWindowObservers]):
+
+We have to check that the backing scale factor actually changed since this
+notification can also be used to signify other changes.
+(-[WebView _windowDidChangeBackingProperties:]):
+
2011-11-07 Adam Barth aba...@webkit.org
Move DomainRelaxationForbidden scheme registry to SchemeRegistry
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (99616 => 99617)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2011-11-08 22:22:24 UTC (rev 99616)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2011-11-08 22:44:17 UTC (rev 99617)
@@ -3223,8 +3223,9 @@
return _private-shouldCloseWithWindow;
}
-// FIXME: Use an AppKit constant for this once one is available.
-static NSString * const windowDidChangeResolutionNotification = @NSWindowDidChangeResolutionNotification;
+// FIXME: Use AppKit constants for these when they are available.
+static NSString * const windowDidChangeBackingPropertiesNotification = @NSWindowDidChangeBackingPropertiesNotification;
+static NSString * const backingPropertyOldScaleFactorKey = @NSBackingPropertyOldScaleFactorKey;
- (void)addWindowObserversForWindow:(NSWindow *)window
{
@@ -3237,8 +3238,8 @@
name:WKWindowWillOrderOnScreenNotification() object:window];
[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_windowWillOrderOffScreen:)
name:WKWindowWillOrderOffScreenNotification() object:window];
-[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_windowDidChangeResolution:)
-name:windowDidChangeResolutionNotification object:window];
+[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_windowDidChangeBackingProperties:)
+name:windowDidChangeBackingPropertiesNotification object:window];
[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_windowDidChangeScreen:)
name:NSWindowDidChangeScreenNotification object:window];
}
@@ -3257,7 +3258,7 @@
[[NSNotificationCenter defaultCenter] removeObserver:self
name:WKWindowWillOrderOffScreenNotification() object:window];
[[NSNotificationCenter defaultCenter] removeObserver:self
-name:windowDidChangeResolutionNotification object:window];
+name:windowDidChangeBackingPropertiesNotification object:window];
[[NSNotificationCenter defaultCenter] removeObserver:self
name:NSWindowDidChangeScreenNotification object:window];
}
@@ -3371,9 +3372,14 @@
[self close];
}
-- (void)_windowDidChangeResolution:(NSNotification *)notification
+- (void)_windowDidChangeBackingProperties:(NSNotification *)notification
{
-_private-page-setDeviceScaleFactor([self _deviceScaleFactor]);
+CGFloat oldBackingScaleFactor = [[notification.userInfo objectForKey:backingPropertyOldScaleFactorKey] doubleValue];
+CGFloat newBackingScaleFactor = [self _deviceScaleFactor];
+if (oldBackingScaleFactor == newBackingScaleFactor)
+return;
+
+
[webkit-changes] [99619] trunk/Source/WebKit2
Title: [99619] trunk/Source/WebKit2 Revision 99619 Author bfulg...@webkit.org Date 2011-11-08 15:17:01 -0800 (Tue, 08 Nov 2011) Log Message [WinCairo] Unreviewed build fix after r98624 and r99613. * win/WebKit2CFLite.def: Add missing exports. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/win/WebKit2CFLite.def Diff Modified: trunk/Source/WebKit2/ChangeLog (99618 => 99619) --- trunk/Source/WebKit2/ChangeLog 2011-11-08 22:49:27 UTC (rev 99618) +++ trunk/Source/WebKit2/ChangeLog 2011-11-08 23:17:01 UTC (rev 99619) @@ -1,3 +1,9 @@ +2011-11-08 Brent Fulgham bfulg...@webkit.org + +[WinCairo] Unreviewed build fix after r98624 and r99613. + +* win/WebKit2CFLite.def: Add missing exports. + 2011-11-08 Beth Dakin bda...@apple.com https://bugs.webkit.org/show_bug.cgi?id=71856 Modified: trunk/Source/WebKit2/win/WebKit2CFLite.def (99618 => 99619) --- trunk/Source/WebKit2/win/WebKit2CFLite.def 2011-11-08 22:49:27 UTC (rev 99618) +++ trunk/Source/WebKit2/win/WebKit2CFLite.def 2011-11-08 23:17:01 UTC (rev 99619) @@ -139,15 +139,17 @@ ?absoluteBoundingBoxRect@RenderObject@WebCore@@QBE?AVIntRect@2@_N@Z ?absoluteBoundingBoxRectIgnoringTransforms@RenderObject@WebCore@@QBE?AVIntRect@2@XZ ?add@AtomicString@WTF@@CA?AV?$PassRefPtr@VStringImpl@WTF@@@2@PBD@Z +?add@AtomicString@WTF@@CA?AV?$PassRefPtr@VStringImpl@WTF@@@2@PBE@Z ?addSlowCase@AtomicString@WTF@@CA?AV?$PassRefPtr@VStringImpl@WTF@@@2@PAVStringImpl@2@@Z ?cacheDOMStructure@WebCore@@YAPAVStructure@JSC@@PAVJSDOMGlobalObject@1@PAV23@PBUClassInfo@3@@Z ?create@Range@WebCore@@SA?AV?$PassRefPtr@VRange@WebCore@@@WTF@@V?$PassRefPtr@VDocument@WebCore@@@4@V?$PassRefPtr@VNode@WebCore@@@4@H1H@Z ?create@ShadowContentElement@WebCore@@SA?AV?$PassRefPtr@VShadowContentElement@WebCore@@@WTF@@PAVDocument@2@@Z ?createWrapper@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNode@1@@Z ?ensureShadowRoot@Element@WebCore@@QAEPAVShadowRoot@2@XZ -?equal@WTF@@YA_NPBVStringImpl@1@PBD@Z +?equal@WTF@@YA_NPBVStringImpl@1@PBE@Z ?externalRepresentation@WebCore@@YA?AVString@WTF@@PAVElement@1@I@Z ?getCachedDOMStructure@WebCore@@YAPAVStructure@JSC@@PAVJSDOMGlobalObject@1@PBUClassInfo@3@@Z +?getData16SlowCase@StringImpl@WTF@@ABEPB_WXZ ?getElementById@TreeScope@WebCore@@QBEPAVElement@2@ABVAtomicString@WTF@@@Z ?getLocationAndLengthFromRange@TextIterator@WebCore@@SA_NPAVElement@2@PBVRange@2@AAI2@Z ?isPreloaded@CachedResourceLoader@WebCore@@QBE_NABVString@WTF@@@Z ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99620] trunk/Tools
Title: [99620] trunk/Tools Revision 99620 Author jchaffr...@webkit.org Date 2011-11-08 15:42:43 -0800 (Tue, 08 Nov 2011) Log Message Moved myself to the reviewer list (yay!). * Scripts/webkitpy/common/config/committers.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (99619 => 99620) --- trunk/Tools/ChangeLog 2011-11-08 23:17:01 UTC (rev 99619) +++ trunk/Tools/ChangeLog 2011-11-08 23:42:43 UTC (rev 99620) @@ -1,3 +1,9 @@ +2011-11-08 Julien Chaffraix jchaffr...@webkit.org + +Moved myself to the reviewer list (yay!). + +* Scripts/webkitpy/common/config/committers.py: + 2011-11-08 Zeno Albisser z...@webkit.org Added myself as a committer. Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (99619 => 99620) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-11-08 23:17:01 UTC (rev 99619) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-11-08 23:42:43 UTC (rev 99620) @@ -230,7 +230,6 @@ Committer(Joone Hur, [joone@collabora.co.uk, jo...@kldp.org, jo...@webkit.org], joone), Committer(Joost de Valk, [jo...@webkit.org, webkit-...@joostdevalk.nl], Altha), Committer(Julie Parent, [jpar...@google.com, jpar...@chromium.org], jparent), -Committer(Julien Chaffraix, [jchaffr...@webkit.org, julien.chaffr...@gmail.com, jchaffr...@google.com, jchaffr...@codeaurora.org], jchaffraix), Committer(Jungshik Shin, js...@chromium.org), Committer(Justin Schuh, jsc...@chromium.org, jschuh), Committer(Keishi Hattori, kei...@webkit.org, keishi), @@ -386,6 +385,7 @@ Reviewer(John Sullivan, sulli...@apple.com, sullivan), Reviewer(Jon Honeycutt, jhoneyc...@apple.com, jhoneycutt), Reviewer(Joseph Pecoraro, [joep...@webkit.org, pecor...@apple.com], JoePeck), +Reviewer(Julien Chaffraix, [jchaffr...@webkit.org, julien.chaffr...@gmail.com, jchaffr...@google.com, jchaffr...@codeaurora.org], jchaffraix), Reviewer(Justin Garcia, justin.gar...@apple.com, justing), Reviewer(Ken Kocienda, kocie...@apple.com), Reviewer(Kenneth Rohde Christiansen, [kenn...@webkit.org, kenneth.christian...@openbossa.org, kenneth.christian...@gmail.com], [kenne, kenneth]), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99622] trunk/Source/JavaScriptCore
Title: [99622] trunk/Source/_javascript_Core
Revision 99622
Author barraclo...@apple.com
Date 2011-11-08 15:45:05 -0800 (Tue, 08 Nov 2011)
Log Message
Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type
https://bugs.webkit.org/show_bug.cgi?id=71761
Templatized Parser based on LexerT. Moved two enums,
SourceElementsMode and FunctionRequirements out of Parser definition
to work around a clang compiler defect.
Cleaned up SourceCode data() to return StringImpl* and eliminated
the recently added stringData() virtual method.
To keep code in Parser.cpp and keep Parser.h small, the two flavors
of Parser are explicitly instantiated at the end of Parser.cpp.
Patch by Michael Saboff msab...@apple.com on 2011-11-08
Reviewed by Gavin Barraclough.
* interpreter/Interpreter.cpp:
(JSC::appendSourceToError):
* parser/Lexer.cpp:
(JSCsetCode):
(JSCsourceCode):
* parser/Parser.cpp:
(JSCParser):
(JSC~Parser):
(JSCparseInner):
(JSCdidFinishParsing):
(JSCallowAutomaticSemicolon):
(JSCparseSourceElements):
(JSCparseVarDeclaration):
(JSCparseConstDeclaration):
(JSCparseDoWhileStatement):
(JSCparseWhileStatement):
(JSCparseVarDeclarationList):
(JSCparseConstDeclarationList):
(JSCparseForStatement):
(JSCparseBreakStatement):
(JSCparseContinueStatement):
(JSCparseReturnStatement):
(JSCparseThrowStatement):
(JSCparseWithStatement):
(JSCparseSwitchStatement):
(JSCparseSwitchClauses):
(JSCparseSwitchDefaultClause):
(JSCparseTryStatement):
(JSCparseDebuggerStatement):
(JSCparseBlockStatement):
(JSCparseStatement):
(JSCparseFormalParameters):
(JSCparseFunctionBody):
(JSCparseFunctionInfo):
(JSCparseFunctionDeclaration):
(JSCparseExpressionOrLabelStatement):
(JSCparseExpressionStatement):
(JSCparseIfStatement):
(JSCparseExpression):
(JSCparseAssignmentExpression):
(JSCparseConditionalExpression):
(JSCisBinaryOperator):
(JSCparseBinaryExpression):
(JSCparseProperty):
(JSCparseObjectLiteral):
(JSCparseStrictObjectLiteral):
(JSCparseArrayLiteral):
(JSCparsePrimaryExpression):
(JSCparseArguments):
(JSCparseMemberExpression):
(JSCparseUnaryExpression):
* parser/Parser.h:
(JSCparse):
(JSC::parse):
* parser/SourceCode.h:
(JSC::SourceCode::data):
(JSC::SourceCode::subExpression):
* parser/SourceProvider.h:
(JSC::UStringSourceProvider::data):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h
trunk/Source/_javascript_Core/assembler/LinkBuffer.h
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator64.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99621 => 99622)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-08 23:44:56 UTC (rev 99621)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-08 23:45:05 UTC (rev 99622)
@@ -77,6 +77,32 @@
2011-11-08 Gavin Barraclough barraclo...@apple.com
+Fix PropertyAccessRecords in DFG JIT to take account of branch compaction.
+https://bugs.webkit.org/show_bug.cgi?id=71855
+
+Reviewed by Filip Pizlo.
+
+The DFG JIT presently calculates a set of offsets early, before branches have been compacted.
+This won't work on ARMv7.
+
+* assembler/AbstractMacroAssembler.h:
+(JSC::AbstractMacroAssembler::differenceBetweenCodePtr):
+* assembler/LinkBuffer.h:
+(JSC::LinkBuffer::locationOf):
+* dfg/DFGJITCodeGenerator32_64.cpp:
+(JSC::DFG::JITCodeGenerator::cachedGetById):
+(JSC::DFG::JITCodeGenerator::cachedPutById):
+* dfg/DFGJITCodeGenerator64.cpp:
+(JSC::DFG::JITCodeGenerator::cachedGetById):
+(JSC::DFG::JITCodeGenerator::cachedPutById):
+* dfg/DFGJITCompiler.cpp:
+(JSC::DFG::JITCompiler::link):
+* dfg/DFGJITCompiler.h:
+(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
+(JSC::DFG::JITCompiler::addPropertyAccess):
+
+2011-11-08 Gavin Barraclough barraclo...@apple.com
+
DFG JIT calculation of OSR entry points is not THUMB2 safe
https://bugs.webkit.org/show_bug.cgi?id=71852
Modified: trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h (99621 => 99622)
--- trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2011-11-08 23:44:56 UTC (rev 99621)
+++ trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2011-11-08 23:45:05 UTC (rev 99622)
@@ -525,6 +525,11 @@
return AssemblerType::getDifferenceBetweenLabels(from.m_label, to.m_label);
}
+static ptrdiff_t differenceBetweenCodePtr(const MacroAssemblerCodePtr a, const MacroAssemblerCodePtr b)
+{
+return reinterpret_castptrdiff_t(b.executableAddress()) -
[webkit-changes] [99621] trunk/LayoutTests
Title: [99621] trunk/LayoutTests Revision 99621 Author o...@chromium.org Date 2011-11-08 15:44:56 -0800 (Tue, 08 Nov 2011) Log Message Rebaselines and expectations after r99609 and r99616 and r99613. * platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-bt-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-tb-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-vertical-lr-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-vertical-rl-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-horizontal-bt-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-horizontal-tb-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-vertical-lr-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-vertical-rl-expected.png: Added. * platform/chromium-linux-x86/fast/multicol/pagination-h-horizontal-bt-expected.png: Added. * platform/chromium-linux-x86/fast/multicol/pagination-h-horizontal-tb-expected.png: Added. * platform/chromium-linux-x86/fast/multicol/pagination-h-vertical-lr-expected.png: Added. * platform/chromium-linux-x86/fast/multicol/pagination-h-vertical-rl-expected.png: Added. * platform/chromium-linux-x86/fast/multicol/pagination-v-horizontal-bt-expected.png: Added. * platform/chromium-linux-x86/fast/multicol/pagination-v-horizontal-tb-expected.png: Added. * platform/chromium-linux-x86/fast/multicol/pagination-v-vertical-lr-expected.png: Added. * platform/chromium-linux-x86/fast/multicol/pagination-v-vertical-rl-expected.png: Added. * platform/chromium-linux/fast/multicol/pagination-h-horizontal-bt-expected.png: Added. * platform/chromium-linux/fast/multicol/pagination-h-horizontal-tb-expected.png: Added. * platform/chromium-linux/fast/multicol/pagination-h-vertical-lr-expected.png: Added. * platform/chromium-linux/fast/multicol/pagination-h-vertical-rl-expected.png: Added. * platform/chromium-linux/fast/multicol/pagination-v-horizontal-bt-expected.png: Added. * platform/chromium-linux/fast/multicol/pagination-v-horizontal-tb-expected.png: Added. * platform/chromium-linux/fast/multicol/pagination-v-vertical-lr-expected.png: Added. * platform/chromium-linux/fast/multicol/pagination-v-vertical-rl-expected.png: Added. * platform/chromium-win-vista/fast/multicol/pagination-h-horizontal-bt-expected.png: Added. * platform/chromium-win-vista/fast/multicol/pagination-h-horizontal-tb-expected.png: Added. * platform/chromium-win-vista/fast/multicol/pagination-h-vertical-lr-expected.png: Added. * platform/chromium-win-vista/fast/multicol/pagination-h-vertical-rl-expected.png: Added. * platform/chromium-win-vista/fast/multicol/pagination-v-horizontal-bt-expected.png: Added. * platform/chromium-win-vista/fast/multicol/pagination-v-horizontal-tb-expected.png: Added. * platform/chromium-win-vista/fast/multicol/pagination-v-vertical-lr-expected.png: Added. * platform/chromium-win-vista/fast/multicol/pagination-v-vertical-rl-expected.png: Added. * platform/chromium-win-xp/fast/multicol/pagination-h-horizontal-bt-expected.png: Added. * platform/chromium-win-xp/fast/multicol/pagination-h-horizontal-tb-expected.png: Added. * platform/chromium-win-xp/fast/multicol/pagination-h-vertical-lr-expected.png: Added. * platform/chromium-win-xp/fast/multicol/pagination-h-vertical-rl-expected.png: Added. * platform/chromium-win-xp/fast/multicol/pagination-v-horizontal-bt-expected.png: Added. * platform/chromium-win-xp/fast/multicol/pagination-v-horizontal-tb-expected.png: Added. * platform/chromium-win-xp/fast/multicol/pagination-v-vertical-lr-expected.png: Added. * platform/chromium-win-xp/fast/multicol/pagination-v-vertical-rl-expected.png: Added. * platform/chromium-win/fast/multicol/pagination-h-horizontal-bt-expected.png: Added. * platform/chromium-win/fast/multicol/pagination-h-horizontal-tb-expected.png: Added. * platform/chromium-win/fast/multicol/pagination-h-vertical-lr-expected.png: Added. * platform/chromium-win/fast/multicol/pagination-h-vertical-rl-expected.png: Added. * platform/chromium-win/fast/multicol/pagination-v-horizontal-bt-expected.png: Added. * platform/chromium-win/fast/multicol/pagination-v-horizontal-tb-expected.png: Added. * platform/chromium-win/fast/multicol/pagination-v-vertical-lr-expected.png: Added. * platform/chromium-win/fast/multicol/pagination-v-vertical-rl-expected.png: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-bt-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-tb-expected.png
[webkit-changes] [99624] trunk/Source/WebKit/chromium
Title: [99624] trunk/Source/WebKit/chromium
Revision 99624
Author fsam...@chromium.org
Date 2011-11-08 15:49:44 -0800 (Tue, 08 Nov 2011)
Log Message
Delete WebViewimpl::scalePage
https://bugs.webkit.org/show_bug.cgi?id=71711
Reviewed by Darin Fisher.
Once this patch lands: http://codereview.chromium.org/8477033
WebViewImpl::scalePage will no longer be used in Chromium and
can safely be deleted.
* public/WebView.h:
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebView.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (99623 => 99624)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-08 23:48:53 UTC (rev 99623)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-08 23:49:44 UTC (rev 99624)
@@ -1,3 +1,19 @@
+2011-11-08 Fady Samuel fsam...@chromium.org
+
+Delete WebViewimpl::scalePage
+https://bugs.webkit.org/show_bug.cgi?id=71711
+
+Reviewed by Darin Fisher.
+
+Once this patch lands: http://codereview.chromium.org/8477033
+
+WebViewImpl::scalePage will no longer be used in Chromium and
+can safely be deleted.
+
+* public/WebView.h:
+* src/WebViewImpl.cpp:
+* src/WebViewImpl.h:
+
2011-11-08 Joshua Bell jsb...@chromium.org
IndexedDB: implement compound (array) key support
Modified: trunk/Source/WebKit/chromium/public/WebView.h (99623 => 99624)
--- trunk/Source/WebKit/chromium/public/WebView.h 2011-11-08 23:48:53 UTC (rev 99623)
+++ trunk/Source/WebKit/chromium/public/WebView.h 2011-11-08 23:49:44 UTC (rev 99624)
@@ -211,9 +211,6 @@
// is scaled up, 1.0 is scaled down.
virtual float pageScaleFactor() const = 0;
-// FIXME: Delete this once Chromium side has been updated.
-virtual void scalePage(float scaleFactor, const WebPoint origin) = 0;
-
// Scales a page by a factor of scaleFactor and then sets a scroll position to (x, y).
// setPageScaleFactor() magnifies and shrinks a page without affecting layout.
// On the other hand, zooming affects layout of the page.
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (99623 => 99624)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-11-08 23:48:53 UTC (rev 99623)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-11-08 23:49:44 UTC (rev 99624)
@@ -1847,11 +1847,6 @@
return page()-pageScaleFactor();
}
-void WebViewImpl::scalePage(float scaleFactor, const WebPoint origin)
-{
-setPageScaleFactor(scaleFactor, origin);
-}
-
void WebViewImpl::setPageScaleFactor(float scaleFactor, const WebPoint origin)
{
if (!page())
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (99623 => 99624)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-11-08 23:48:53 UTC (rev 99623)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-11-08 23:49:44 UTC (rev 99624)
@@ -158,7 +158,6 @@
virtual void zoomLimitsChanged(double minimumZoomLevel,
double maximumZoomLevel);
virtual float pageScaleFactor() const;
-virtual void scalePage(float scaleFactor, const WebPoint origin);
virtual void setPageScaleFactor(float scaleFactor, const WebPoint origin);
virtual float deviceScaleFactor() const;
virtual void setDeviceScaleFactor(float);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99625] trunk/Source/WebKit2
Title: [99625] trunk/Source/WebKit2 Revision 99625 Author bfulg...@webkit.org Date 2011-11-08 15:52:36 -0800 (Tue, 08 Nov 2011) Log Message [WinCairo] Unreviewed build fix after r99613. * win/WebKit2CFLite.def: Add missing export. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/win/WebKit2CFLite.def Diff Modified: trunk/Source/WebKit2/ChangeLog (99624 => 99625) --- trunk/Source/WebKit2/ChangeLog 2011-11-08 23:49:44 UTC (rev 99624) +++ trunk/Source/WebKit2/ChangeLog 2011-11-08 23:52:36 UTC (rev 99625) @@ -1,5 +1,11 @@ 2011-11-08 Brent Fulgham bfulg...@webkit.org +[WinCairo] Unreviewed build fix after r99613. + +* win/WebKit2CFLite.def: Add missing export. + +2011-11-08 Brent Fulgham bfulg...@webkit.org + [WinCairo] Unreviewed build fix after r98624 and r99613. * win/WebKit2CFLite.def: Add missing exports. Modified: trunk/Source/WebKit2/win/WebKit2CFLite.def (99624 => 99625) --- trunk/Source/WebKit2/win/WebKit2CFLite.def 2011-11-08 23:49:44 UTC (rev 99624) +++ trunk/Source/WebKit2/win/WebKit2CFLite.def 2011-11-08 23:52:36 UTC (rev 99625) @@ -162,6 +162,7 @@ ?removeShadowRoot@Element@WebCore@@QAEXXZ ?scrollElementToRect@FrameView@WebCore@@QAEXPAVElement@2@ABVIntRect@2@@Z ?setDOMException@WebCore@@YAXPAVExecState@JSC@@H@Z +?setPagination@Page@WebCore@@QAEXABUPagination@12@@Z ?setResourcesDataSizeLimitsFromInternals@InspectorController@WebCore@@QAEXHH@Z ?setScrollbarsSuppressed@ScrollView@WebCore@@QAEX_N0@Z ?setScrollOffsetFromInternals@ScrollableArea@WebCore@@QAEXABVIntPoint@2@@Z ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99626] trunk/Tools
Title: [99626] trunk/Tools Revision 99626 Author commit-qu...@webkit.org Date 2011-11-08 15:57:23 -0800 (Tue, 08 Nov 2011) Log Message [Mac] Disable C++ exceptions from DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=71834 Patch by Benjamin Poulain bpoul...@apple.com on 2011-11-08 Reviewed by Darin Adler. DumpRenderTree Mac does not handle C++ exceptions. When such exception happens, it tends to cause the AutoReleasePool stack to be corrupted, which leads to crashes long after the exception was raised. This patch disabled C++ exceptions in order to catch the problems where they happen when a C++ exception is raised. * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig Diff Modified: trunk/Tools/ChangeLog (99625 => 99626) --- trunk/Tools/ChangeLog 2011-11-08 23:52:36 UTC (rev 99625) +++ trunk/Tools/ChangeLog 2011-11-08 23:57:23 UTC (rev 99626) @@ -1,3 +1,19 @@ +2011-11-08 Benjamin Poulain bpoul...@apple.com + +[Mac] Disable C++ exceptions from DumpRenderTree +https://bugs.webkit.org/show_bug.cgi?id=71834 + +Reviewed by Darin Adler. + +DumpRenderTree Mac does not handle C++ exceptions. When such exception +happens, it tends to cause the AutoReleasePool stack to be corrupted, +which leads to crashes long after the exception was raised. + +This patch disabled C++ exceptions in order to catch the problems where +they happen when a C++ exception is raised. + +* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: + 2011-11-08 Julien Chaffraix jchaffr...@webkit.org Moved myself to the reviewer list (yay!). Modified: trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig (99625 => 99626) --- trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig 2011-11-08 23:52:36 UTC (rev 99625) +++ trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig 2011-11-08 23:57:23 UTC (rev 99626) @@ -24,5 +24,6 @@ OTHER_LDFLAGS = -sectcreate __DATA Ahem qt/fonts/AHEM.TTF -sectcreate __DATA WeightWatcher100 fonts/WebKitWeightWatcher100.ttf -sectcreate __DATA WeightWatcher200 fonts/WebKitWeightWatcher200.ttf -sectcreate __DATA WeightWatcher300 fonts/WebKitWeightWatcher300.ttf -sectcreate __DATA WeightWatcher400 fonts/WebKitWeightWatcher400.ttf -sectcreate __DATA WeightWatcher500 fonts/WebKitWeightWatcher500.ttf -sectcreate __DATA WeightWatcher600 fonts/WebKitWeightWatcher600.ttf -sectcreate __DATA WeightWatcher700 fonts/WebKitWeightWatcher700.ttf -sectcreate __DATA WeightWatcher800 fonts/WebKitWeightWatcher800.ttf -sectcreate __DATA WeightWatcher900 fonts/WebKitWeightWatcher900.ttf LD_RUNPATH_SEARCH_PATHS = @loader_path/.; PRODUCT_NAME = DumpRenderTree +GCC_ENABLE_CPP_EXCEPTIONS = NO GCC_ENABLE_OBJC_EXCEPTIONS = YES GCC_PREFIX_HEADER = DumpRenderTreePrefix.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99627] trunk/Source/JavaScriptCore
Title: [99627] trunk/Source/_javascript_Core
Revision 99627
Author fpi...@apple.com
Date 2011-11-08 16:12:35 -0800 (Tue, 08 Nov 2011)
Log Message
Basic DFG definitions should be moved out of DFGNode.h
https://bugs.webkit.org/show_bug.cgi?id=71861
Rubber-stamped by Gavin Barraclough.
* _javascript_Core.xcodeproj/project.pbxproj:
* dfg/DFGCommon.h: Added.
(JSC::DFG::NodeIndexTraits::defaultValue):
* dfg/DFGNode.h:
* dfg/DFGOSRExit.h:
* dfg/DFGRegisterBank.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/dfg/DFGNode.h
trunk/Source/_javascript_Core/dfg/DFGOSRExit.h
trunk/Source/_javascript_Core/dfg/DFGRegisterBank.h
Added Paths
trunk/Source/_javascript_Core/dfg/DFGCommon.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99626 => 99627)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-08 23:57:23 UTC (rev 99626)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 00:12:35 UTC (rev 99627)
@@ -1,3 +1,17 @@
+2011-11-08 Filip Pizlo fpi...@apple.com
+
+Basic DFG definitions should be moved out of DFGNode.h
+https://bugs.webkit.org/show_bug.cgi?id=71861
+
+Rubber-stamped by Gavin Barraclough.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+* dfg/DFGCommon.h: Added.
+(JSC::DFG::NodeIndexTraits::defaultValue):
+* dfg/DFGNode.h:
+* dfg/DFGOSRExit.h:
+* dfg/DFGRegisterBank.h:
+
2011-11-08 Michael Saboff msab...@apple.com
Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (99626 => 99627)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2011-11-08 23:57:23 UTC (rev 99626)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2011-11-09 00:12:35 UTC (rev 99627)
@@ -839,6 +839,7 @@
0FC097681468A6EF00CF2442 /* DFGOSRExit.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = DFGOSRExit.h; path = dfg/DFGOSRExit.h; sourceTree = group; };
0FC0976B1468AB4A00CF2442 /* DFGAssemblyHelpers.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = DFGAssemblyHelpers.cpp; path = dfg/DFGAssemblyHelpers.cpp; sourceTree = group; };
0FC0976C1468AB4A00CF2442 /* DFGAssemblyHelpers.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = DFGAssemblyHelpers.h; path = dfg/DFGAssemblyHelpers.h; sourceTree = group; };
+ 0FC0977E1469EBC400CF2442 /* DFGCommon.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = DFGCommon.h; path = dfg/DFGCommon.h; sourceTree = group; };
0FC8150814043BCA00CFA603 /* WriteBarrierSupport.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WriteBarrierSupport.cpp; sourceTree = group; };
0FC8150914043BD200CFA603 /* WriteBarrierSupport.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WriteBarrierSupport.h; sourceTree = group; };
0FC815121405118600CFA603 /* VTableSpectrum.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = VTableSpectrum.cpp; sourceTree = group; };
@@ -2298,6 +2299,7 @@
86EC9DB31328DF44002B2AD7 /* dfg */ = {
isa = PBXGroup;
children = (
+0FC0977E1469EBC400CF2442 /* DFGCommon.h */,
0FC0976B1468AB4A00CF2442 /* DFGAssemblyHelpers.cpp */,
0FC0976C1468AB4A00CF2442 /* DFGAssemblyHelpers.h */,
0FC097681468A6EF00CF2442 /* DFGOSRExit.h */,
Added: trunk/Source/_javascript_Core/dfg/DFGCommon.h (0 => 99627)
--- trunk/Source/_javascript_Core/dfg/DFGCommon.h (rev 0)
+++ trunk/Source/_javascript_Core/dfg/DFGCommon.h 2011-11-09 00:12:35 UTC (rev 99627)
@@ -0,0 +1,91 @@
+/*
+ * Copyright (C) 2011 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE
[webkit-changes] [99628] trunk/Source/WebKit/mac
Title: [99628] trunk/Source/WebKit/mac
Revision 99628
Author commit-qu...@webkit.org
Date 2011-11-08 16:13:13 -0800 (Tue, 08 Nov 2011)
Log Message
Move NSRange / DOMRange functions back to WebFrameInternal
https://bugs.webkit.org/show_bug.cgi?id=71844
Patch by Joseph Pecoraro pecor...@apple.com on 2011-11-08
Reviewed by Alexey Proskuryakov.
* WebView/WebFrame.mm:
(-[WebFrame _convertNSRangeToDOMRange:]):
(-[WebFrame _convertDOMRangeToNSRange:]):
* WebView/WebFrameInternal.h:
* WebView/WebFramePrivate.h:
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebFrame.mm
trunk/Source/WebKit/mac/WebView/WebFrameInternal.h
trunk/Source/WebKit/mac/WebView/WebFramePrivate.h
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (99627 => 99628)
--- trunk/Source/WebKit/mac/ChangeLog 2011-11-09 00:12:35 UTC (rev 99627)
+++ trunk/Source/WebKit/mac/ChangeLog 2011-11-09 00:13:13 UTC (rev 99628)
@@ -1,3 +1,16 @@
+2011-11-08 Joseph Pecoraro pecor...@apple.com
+
+Move NSRange / DOMRange functions back to WebFrameInternal
+https://bugs.webkit.org/show_bug.cgi?id=71844
+
+Reviewed by Alexey Proskuryakov.
+
+* WebView/WebFrame.mm:
+(-[WebFrame _convertNSRangeToDOMRange:]):
+(-[WebFrame _convertDOMRangeToNSRange:]):
+* WebView/WebFrameInternal.h:
+* WebView/WebFramePrivate.h:
+
2011-11-08 Michael Saboff msab...@apple.com
Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type
Modified: trunk/Source/WebKit/mac/WebView/WebFrame.mm (99627 => 99628)
--- trunk/Source/WebKit/mac/WebView/WebFrame.mm 2011-11-09 00:12:35 UTC (rev 99627)
+++ trunk/Source/WebKit/mac/WebView/WebFrame.mm 2011-11-09 00:13:13 UTC (rev 99628)
@@ -688,6 +688,16 @@
return TextIterator::rangeFromLocationAndLength(_private-coreFrame-selection()-rootEditableElementOrDocumentElement(), nsrange.location, nsrange.length);
}
+- (DOMRange *)_convertNSRangeToDOMRange:(NSRange)nsrange
+{
+return kit([self _convertToDOMRange:nsrange].get());
+}
+
+- (NSRange)_convertDOMRangeToNSRange:(DOMRange *)range
+{
+return [self _convertToNSRange:core(range)];
+}
+
- (DOMRange *)_markDOMRange
{
return kit(_private-coreFrame-editor()-mark().toNormalizedRange().get());
@@ -903,16 +913,6 @@
_private-coreFrame-selection()-setSelection(VisibleSelection(domRange.get(), SEL_DEFAULT_AFFINITY));
}
-- (DOMRange *)_convertNSRangeToDOMRange:(NSRange)nsrange
-{
-return kit([self _convertToDOMRange:nsrange].get());
-}
-
-- (NSRange)_convertDOMRangeToNSRange:(DOMRange *)range
-{
-return [self _convertToNSRange:core(range)];
-}
-
- (BOOL)_isDisplayingStandaloneImage
{
Document* document = _private-coreFrame-document();
Modified: trunk/Source/WebKit/mac/WebView/WebFrameInternal.h (99627 => 99628)
--- trunk/Source/WebKit/mac/WebView/WebFrameInternal.h 2011-11-09 00:12:35 UTC (rev 99627)
+++ trunk/Source/WebKit/mac/WebView/WebFrameInternal.h 2011-11-09 00:13:13 UTC (rev 99628)
@@ -130,6 +130,9 @@
- (NSString *)_selectedString;
- (NSString *)_stringForRange:(DOMRange *)range;
+- (DOMRange *)_convertNSRangeToDOMRange:(NSRange)range;
+- (NSRange)_convertDOMRangeToNSRange:(DOMRange *)range;
+
- (NSString *)_markupStringFromRange:(DOMRange *)range nodes:(NSArray **)nodes;
- (NSRect)_caretRectAtPosition:(const WebCore::Position)pos affinity:(NSSelectionAffinity)affinity;
Modified: trunk/Source/WebKit/mac/WebView/WebFramePrivate.h (99627 => 99628)
--- trunk/Source/WebKit/mac/WebView/WebFramePrivate.h 2011-11-09 00:12:35 UTC (rev 99627)
+++ trunk/Source/WebKit/mac/WebView/WebFramePrivate.h 2011-11-09 00:13:13 UTC (rev 99628)
@@ -83,9 +83,6 @@
- (NSRange)_selectedNSRange;
- (void)_selectNSRange:(NSRange)range;
-- (DOMRange *)_convertNSRangeToDOMRange:(NSRange)range;
-- (NSRange)_convertDOMRangeToNSRange:(DOMRange *)range;
-
- (BOOL)_isDisplayingStandaloneImage;
- (unsigned)_pendingFrameUnloadEventCount;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99630] trunk/Source/WebCore
Title: [99630] trunk/Source/WebCore
Revision 99630
Author m...@apple.com
Date 2011-11-08 16:24:46 -0800 (Tue, 08 Nov 2011)
Log Message
REGRESSION (r99613): Incomplete painting of the root element background in flipped blocks writing mode
https://bugs.webkit.org/show_bug.cgi?id=71863
Reviewed by Anders Carlsson.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintRootBoxFillLayers): Instead of unconditionally flipping the background
rect here...
* rendering/RenderView.cpp:
(WebCore::RenderView::backgroundRect): ...flip it only in column mode here.
* rendering/RenderView.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99629 => 99630)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 00:21:11 UTC (rev 99629)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 00:24:46 UTC (rev 99630)
@@ -1,3 +1,17 @@
+2011-11-08 Dan Bernstein m...@apple.com
+
+REGRESSION (r99613): Incomplete painting of the root element background in flipped blocks writing mode
+https://bugs.webkit.org/show_bug.cgi?id=71863
+
+Reviewed by Anders Carlsson.
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::paintRootBoxFillLayers): Instead of unconditionally flipping the background
+rect here...
+* rendering/RenderView.cpp:
+(WebCore::RenderView::backgroundRect): ...flip it only in column mode here.
+* rendering/RenderView.h:
+
2011-11-08 Michael Saboff msab...@apple.com
Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (99629 => 99630)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2011-11-09 00:21:11 UTC (rev 99629)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2011-11-09 00:24:46 UTC (rev 99630)
@@ -872,10 +872,7 @@
}
}
-RenderView* view = this-view();
-LayoutRect backgroundRect = view-backgroundRect();
-flipForWritingMode(backgroundRect);
-paintFillLayers(paintInfo, bgColor, bgLayer, backgroundRect, BackgroundBleedNone, CompositeSourceOver, bodyObject);
+paintFillLayers(paintInfo, bgColor, bgLayer, view()-backgroundRect(this), BackgroundBleedNone, CompositeSourceOver, bodyObject);
}
BackgroundBleedAvoidance RenderBox::determineBackgroundBleedAvoidance(GraphicsContext* context) const
Modified: trunk/Source/WebCore/rendering/RenderView.cpp (99629 => 99630)
--- trunk/Source/WebCore/rendering/RenderView.cpp 2011-11-09 00:21:11 UTC (rev 99629)
+++ trunk/Source/WebCore/rendering/RenderView.cpp 2011-11-09 00:24:46 UTC (rev 99630)
@@ -692,7 +692,7 @@
return overflowRect;
}
-LayoutRect RenderView::backgroundRect() const
+LayoutRect RenderView::backgroundRect(RenderBox* backgroundRenderer) const
{
if (!hasColumns())
return unscaledDocumentRect();
@@ -701,6 +701,8 @@
LayoutRect backgroundRect(0, 0, columnInfo-desiredColumnWidth(), columnInfo-columnHeight() * columnInfo-columnCount());
if (!isHorizontalWritingMode())
backgroundRect = backgroundRect.transposedRect();
+backgroundRenderer-flipForWritingMode(backgroundRect);
+
return backgroundRect;
}
Modified: trunk/Source/WebCore/rendering/RenderView.h (99629 => 99630)
--- trunk/Source/WebCore/rendering/RenderView.h 2011-11-09 00:21:11 UTC (rev 99629)
+++ trunk/Source/WebCore/rendering/RenderView.h 2011-11-09 00:24:46 UTC (rev 99630)
@@ -167,7 +167,7 @@
#endif
IntRect unscaledDocumentRect() const;
-LayoutRect backgroundRect() const;
+LayoutRect backgroundRect(RenderBox* backgroundRenderer) const;
IntRect documentRect() const;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99631] trunk/LayoutTests
Title: [99631] trunk/LayoutTests Revision 99631 Author o...@chromium.org Date 2011-11-08 16:27:58 -0800 (Tue, 08 Nov 2011) Log Message Update the expectations. This test appears to also fail on the chromium mac bots. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (99630 => 99631) --- trunk/LayoutTests/ChangeLog 2011-11-09 00:24:46 UTC (rev 99630) +++ trunk/LayoutTests/ChangeLog 2011-11-09 00:27:58 UTC (rev 99631) @@ -1,5 +1,10 @@ 2011-11-08 Ojan Vafai o...@chromium.org +Update the expectations. This test appears to also fail on the chromium mac bots. +* platform/chromium/test_expectations.txt: + +2011-11-08 Ojan Vafai o...@chromium.org + Rebaseline test failing due to subtle antialiasing differences. Garden-o-matic claims it broke at r99613. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99630 => 99631) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-09 00:24:46 UTC (rev 99630) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-09 00:27:58 UTC (rev 99631) @@ -3948,5 +3948,4 @@ BUGRICOW : fast/js/toString-recursion.html = TEXT BUGRICOW : http/tests/security/xss-eval.html = TEXT -// Need rebaseline. -BUGXJI WIN LINUX : fast/dom/rtl-scroll-to-leftmost-and-resize.html = IMAGE+TEXT MISSING +BUGXJI : fast/dom/rtl-scroll-to-leftmost-and-resize.html = IMAGE+TEXT MISSING ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99632] trunk/Source/WebCore
Title: [99632] trunk/Source/WebCore
Revision 99632
Author commit-qu...@webkit.org
Date 2011-11-08 16:43:07 -0800 (Tue, 08 Nov 2011)
Log Message
Add support for arrays of numbers to IDL bindings code generator
https://bugs.webkit.org/show_bug.cgi?id=71763
Adds support for float[] and double[] to IDL. Support for other types
appears to be more complicated (or at least more copy-paste) so not
doing that for now for lack of need.
Patch by Scott Graham scot...@chromium.org on 2011-11-08
Reviewed by Adam Barth.
Tests added to TestObj.idl.
* bindings/scripts/CodeGeneratorV8.pm:
(IsRefPtrType):
(GetNativeType):
(JSValueToNative):
(NativeToJSValue):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::floatArrayAttrGetter):
(WebCore::TestObjInternal::floatArrayAttrSetter):
(WebCore::TestObjInternal::doubleArrayAttrGetter):
(WebCore::TestObjInternal::doubleArrayAttrSetter):
* bindings/v8/V8Binding.h:
(WebCore::v8NumberArray):
(WebCore::v8NumberArrayToVector):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99631 => 99632)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 00:27:58 UTC (rev 99631)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 00:43:07 UTC (rev 99632)
@@ -1,3 +1,31 @@
+2011-11-08 Scott Graham scot...@chromium.org
+
+Add support for arrays of numbers to IDL bindings code generator
+https://bugs.webkit.org/show_bug.cgi?id=71763
+
+Adds support for float[] and double[] to IDL. Support for other types
+appears to be more complicated (or at least more copy-paste) so not
+doing that for now for lack of need.
+
+Reviewed by Adam Barth.
+
+Tests added to TestObj.idl.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(IsRefPtrType):
+(GetNativeType):
+(JSValueToNative):
+(NativeToJSValue):
+* bindings/scripts/test/TestObj.idl:
+* bindings/scripts/test/V8/V8TestObj.cpp:
+(WebCore::TestObjInternal::floatArrayAttrGetter):
+(WebCore::TestObjInternal::floatArrayAttrSetter):
+(WebCore::TestObjInternal::doubleArrayAttrGetter):
+(WebCore::TestObjInternal::doubleArrayAttrSetter):
+* bindings/v8/V8Binding.h:
+(WebCore::v8NumberArray):
+(WebCore::v8NumberArrayToVector):
+
2011-11-08 Dan Bernstein m...@apple.com
REGRESSION (r99613): Incomplete painting of the root element background in flipped blocks writing mode
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (99631 => 99632)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-11-09 00:27:58 UTC (rev 99631)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-11-09 00:43:07 UTC (rev 99632)
@@ -3079,6 +3079,8 @@
return 0 if $type eq unsigned;
return 0 if $type eq unsigned long;
return 0 if $type eq unsigned short;
+return 0 if $type eq float[];
+return 0 if $type eq double[];
return 1;
}
@@ -3134,8 +3136,10 @@
return RefPtrMediaQueryListListener if $type eq MediaQueryListListener;
+# FIXME: Support T[], T[]?, sequenceT generically
+return Vectorfloat if $type eq float[];
+return Vectordouble if $type eq double[];
return RefPtrDOMStringList if $type eq DOMStringList;
-# FIXME: Add proper support for T[], T[]?, sequenceT.
return RefPtrDOMStringList if $type eq DOMString[];
# Default, assume native type is a pointer with same type name as idl type
@@ -3192,6 +3196,14 @@
return v8ValueToWebCoreDOMStringList($value) if $type eq DOMStringList;
# FIXME: Add proper support for T[], T[]? and sequenceT.
return v8ValueToWebCoreDOMStringList($value) if $type eq DOMString[];
+if ($type eq float[]) {
+AddToImplIncludes(wtf/Vector.h);
+return v8NumberArrayToVectorfloat($value);
+}
+if ($type eq double[]) {
+AddToImplIncludes(wtf/Vector.h);
+return v8NumberArrayToVectordouble($value);
+}
if ($type eq DOMString or $type eq DOMUserData) {
return $value;
@@ -3342,6 +3354,8 @@
'boolean' = 1,
'long long' = 1,
'unsigned long long' = 1,
+'float[]' = 1,
+'double[]' = 1,
'DOMString' = 1,
'CompareHow' = 1,
'SerializedScriptValue' = 1,
@@ -3432,6 +3446,9 @@
return v8::Number::New($value) if $codeGenerator-IsPrimitiveType($type);
return $value.v8Value() if $nativeType eq ScriptValue;
+return v8NumberArray($value) if $type eq float[];
+return v8NumberArray($value) if $type eq double[];
+
if ($codeGenerator-IsStringType($type)) {
my $conv = $signature-extendedAttributes-{ConvertNullStringTo};
if (defined $conv) {
Modified:
[webkit-changes] [99633] trunk/Source/JavaScriptCore
Title: [99633] trunk/Source/_javascript_Core
Revision 99633
Author barraclo...@apple.com
Date 2011-11-08 16:43:15 -0800 (Tue, 08 Nov 2011)
Log Message
Fix OSR entry points to calculate offsets correctly WRT to branch compaction.
https://bugs.webkit.org/show_bug.cgi?id=71864
Reviewed by Filip Pizlo.
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::offsetOf):
- We use this to return the offsets into the code of the entry points.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- Move the construction of the speculative JIT outside of
compileBody, such that it is still available to link the
OSR entry points at the point we are linking.
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
- Pass the label of the block linkbuffer into noticeOSREntry.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::linkOSREntries):
- Moved call to noticeOSREntry until we we linking.
* dfg/DFGSpeculativeJIT.h:
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
- Moved calculation of entries until we we linking.
* jit/JIT.h:
- Removed some members.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/LinkBuffer.h
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/jit/JIT.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99632 => 99633)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-09 00:43:07 UTC (rev 99632)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 00:43:15 UTC (rev 99633)
@@ -1,3 +1,37 @@
+2011-11-08 Gavin Barraclough barraclo...@apple.com
+
+Fix OSR entry points to calculate offsets correctly WRT to branch compaction.
+https://bugs.webkit.org/show_bug.cgi?id=71864
+
+Reviewed by Filip Pizlo.
+
+* assembler/LinkBuffer.h:
+(JSC::LinkBuffer::offsetOf):
+- We use this to return the offsets into the code of the entry points.
+* dfg/DFGJITCompiler.cpp:
+(JSC::DFG::JITCompiler::compileEntry):
+(JSC::DFG::JITCompiler::compileBody):
+(JSC::DFG::JITCompiler::compile):
+(JSC::DFG::JITCompiler::compileFunction):
+- Move the construction of the speculative JIT outside of
+ compileBody, such that it is still available to link the
+ OSR entry points at the point we are linking.
+* dfg/DFGJITCompiler.h:
+(JSC::DFG::JITCompiler::noticeOSREntry):
+- Pass the label of the block linkbuffer into noticeOSREntry.
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+(JSC::DFG::SpeculativeJIT::linkOSREntries):
+- Moved call to noticeOSREntry until we we linking.
+* dfg/DFGSpeculativeJIT.h:
+* jit/JIT.cpp:
+(JSC::JIT::privateCompileMainPass):
+(JSC::JIT::privateCompileSlowCases):
+(JSC::JIT::privateCompile):
+- Moved calculation of entries until we we linking.
+* jit/JIT.h:
+- Removed some members.
+
2011-11-08 Filip Pizlo fpi...@apple.com
DFG OSR exit code should be generated by a separate compiler, not
Modified: trunk/Source/_javascript_Core/assembler/LinkBuffer.h (99632 => 99633)
--- trunk/Source/_javascript_Core/assembler/LinkBuffer.h 2011-11-09 00:43:07 UTC (rev 99632)
+++ trunk/Source/_javascript_Core/assembler/LinkBuffer.h 2011-11-09 00:43:15 UTC (rev 99633)
@@ -168,6 +168,11 @@
return MacroAssembler::getLinkerCallReturnOffset(call);
}
+uint32_t offsetOf(Label label)
+{
+return applyOffset(label.m_label).m_offset;
+}
+
// Upon completion of all patching either 'finalizeCode()' or 'finalizeCodeAddendum()' should be called
// once to complete generation of the code. 'finalizeCode()' is suited to situations
// where the executable pool must also be retained, the lighter-weight 'finalizeCodeAddendum()' is
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp (99632 => 99633)
--- trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp 2011-11-09 00:43:07 UTC (rev 99632)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp 2011-11-09 00:43:15 UTC (rev 99633)
@@ -55,8 +55,6 @@
void JITCompiler::compileEntry()
{
-m_startOfCode = label();
-
// This code currently matches the old JIT. In the function header we need to
// pop the return address (since we do not allow any recursion on the machine
// stack), and perform a fast register file check.
@@ -68,7 +66,7 @@
[webkit-changes] [99634] trunk/Source/JavaScriptCore
Title: [99634] trunk/Source/_javascript_Core
Revision 99634
Author barraclo...@apple.com
Date 2011-11-08 16:47:52 -0800 (Tue, 08 Nov 2011)
Log Message
Remove an unused method.
Rubber stamped by Geoff Garen.
* assembler/AbstractMacroAssembler.h:
* assembler/AssemblerBuffer.h:
- removed rewindToLabel.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h
trunk/Source/_javascript_Core/assembler/AssemblerBuffer.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99633 => 99634)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-09 00:43:15 UTC (rev 99633)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 00:47:52 UTC (rev 99634)
@@ -1,5 +1,15 @@
2011-11-08 Gavin Barraclough barraclo...@apple.com
+Remove an unused method.
+
+Rubber stamped by Geoff Garen.
+
+* assembler/AbstractMacroAssembler.h:
+* assembler/AssemblerBuffer.h:
+- removed rewindToLabel.
+
+2011-11-08 Gavin Barraclough barraclo...@apple.com
+
Fix OSR entry points to calculate offsets correctly WRT to branch compaction.
https://bugs.webkit.org/show_bug.cgi?id=71864
Modified: trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h (99633 => 99634)
--- trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2011-11-09 00:43:15 UTC (rev 99633)
+++ trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2011-11-09 00:47:52 UTC (rev 99634)
@@ -530,11 +530,6 @@
return reinterpret_castptrdiff_t(b.executableAddress()) - reinterpret_castptrdiff_t(a.executableAddress());
}
-// Temporary interface; likely to be removed, since may be hard to port to all architectures.
-#if CPU(X86) || CPU(X86_64)
-void rewindToLabel(Label rewindTo) { m_assembler.rewindToLabel(rewindTo.m_label); }
-#endif
-
void beginUninterruptedSequence() { }
void endUninterruptedSequence() { }
Modified: trunk/Source/_javascript_Core/assembler/AssemblerBuffer.h (99633 => 99634)
--- trunk/Source/_javascript_Core/assembler/AssemblerBuffer.h 2011-11-09 00:43:15 UTC (rev 99633)
+++ trunk/Source/_javascript_Core/assembler/AssemblerBuffer.h 2011-11-09 00:47:52 UTC (rev 99634)
@@ -146,11 +146,6 @@
return result.release();
}
-void rewindToLabel(AssemblerLabel label)
-{
-m_index = label.m_offset;
-}
-
#ifndef NDEBUG
unsigned debugOffset() { return m_index; }
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99635] trunk/Source/JavaScriptCore
Title: [99635] trunk/Source/_javascript_Core
Revision 99635
Author barraclo...@apple.com
Date 2011-11-08 16:56:45 -0800 (Tue, 08 Nov 2011)
Log Message
Errrk, failed to commit this in last change.
* assembler/X86Assembler.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/X86Assembler.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99634 => 99635)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-09 00:47:52 UTC (rev 99634)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 00:56:45 UTC (rev 99635)
@@ -1,5 +1,11 @@
2011-11-08 Gavin Barraclough barraclo...@apple.com
+Errrk, failed to commit this in last change.
+
+* assembler/X86Assembler.h:
+
+2011-11-08 Gavin Barraclough barraclo...@apple.com
+
Remove an unused method.
Rubber stamped by Geoff Garen.
Modified: trunk/Source/_javascript_Core/assembler/X86Assembler.h (99634 => 99635)
--- trunk/Source/_javascript_Core/assembler/X86Assembler.h 2011-11-09 00:47:52 UTC (rev 99634)
+++ trunk/Source/_javascript_Core/assembler/X86Assembler.h 2011-11-09 00:56:45 UTC (rev 99635)
@@ -1721,8 +1721,6 @@
return m_formatter.executableCopy(globalData);
}
-void rewindToLabel(AssemblerLabel rewindTo) { m_formatter.rewindToLabel(rewindTo); }
-
#ifndef NDEBUG
unsigned debugOffset() { return m_formatter.debugOffset(); }
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99636] trunk/Source/JavaScriptCore
Title: [99636] trunk/Source/_javascript_Core
Revision 99636
Author barraclo...@apple.com
Date 2011-11-08 16:58:22 -0800 (Tue, 08 Nov 2011)
Log Message
Build fix.
* assembler/X86Assembler.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/X86Assembler.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99635 => 99636)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-09 00:56:45 UTC (rev 99635)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 00:58:22 UTC (rev 99636)
@@ -1,5 +1,11 @@
2011-11-08 Gavin Barraclough barraclo...@apple.com
+Build fix.
+
+* assembler/X86Assembler.h:
+
+2011-11-08 Gavin Barraclough barraclo...@apple.com
+
Errrk, failed to commit this in last change.
* assembler/X86Assembler.h:
Modified: trunk/Source/_javascript_Core/assembler/X86Assembler.h (99635 => 99636)
--- trunk/Source/_javascript_Core/assembler/X86Assembler.h 2011-11-09 00:56:45 UTC (rev 99635)
+++ trunk/Source/_javascript_Core/assembler/X86Assembler.h 2011-11-09 00:58:22 UTC (rev 99636)
@@ -2071,8 +2071,6 @@
return m_buffer.executableCopy(globalData);
}
-void rewindToLabel(AssemblerLabel rewindTo) { m_buffer.rewindToLabel(rewindTo); }
-
#ifndef NDEBUG
unsigned debugOffset() { return m_buffer.debugOffset(); }
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99637] trunk/Source/JavaScriptCore
Title: [99637] trunk/Source/_javascript_Core Revision 99637 Author fpi...@apple.com Date 2011-11-08 17:01:19 -0800 (Tue, 08 Nov 2011) Log Message Unreviewed build fix for GTK. * GNUmakefile.list.am: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/GNUmakefile.list.am Diff Modified: trunk/Source/_javascript_Core/ChangeLog (99636 => 99637) --- trunk/Source/_javascript_Core/ChangeLog 2011-11-09 00:58:22 UTC (rev 99636) +++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 01:01:19 UTC (rev 99637) @@ -1,3 +1,9 @@ +2011-11-08 Filip Pizlo fpi...@apple.com + +Unreviewed build fix for GTK. + +* GNUmakefile.list.am: + 2011-11-08 Gavin Barraclough barraclo...@apple.com Build fix. Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (99636 => 99637) --- trunk/Source/_javascript_Core/GNUmakefile.list.am 2011-11-09 00:58:22 UTC (rev 99636) +++ trunk/Source/_javascript_Core/GNUmakefile.list.am 2011-11-09 01:01:19 UTC (rev 99637) @@ -127,7 +127,6 @@ Source/_javascript_Core/dfg/DFGJITCodeGenerator64.cpp \ Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp \ Source/_javascript_Core/dfg/DFGJITCodeGenerator.h \ - Source/_javascript_Core/dfg/DFGJITCompiler32_64.cpp \ Source/_javascript_Core/dfg/DFGJITCompiler.cpp \ Source/_javascript_Core/dfg/DFGJITCompiler.h \ Source/_javascript_Core/dfg/DFGJITCompilerInlineMethods.h \ @@ -137,6 +136,9 @@ Source/_javascript_Core/dfg/DFGOperations.h \ Source/_javascript_Core/dfg/DFGOSREntry.cpp \ Source/_javascript_Core/dfg/DFGOSREntry.h \ + Source/_javascript_Core/dfg/DFGOSRExitCompiler32_64.cpp \ + Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp \ + Source/_javascript_Core/dfg/DFGOSRExitCompiler.h \ Source/_javascript_Core/dfg/DFGOSRExit.h \ Source/_javascript_Core/dfg/DFGPropagator.cpp \ Source/_javascript_Core/dfg/DFGPropagator.h \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99638] trunk
Title: [99638] trunk
Revision 99638
Author commit-qu...@webkit.org
Date 2011-11-08 17:02:53 -0800 (Tue, 08 Nov 2011)
Log Message
fix REGRESSION: SVG feColorMatrix causes crash
https://bugs.webkit.org/show_bug.cgi?id=71287
Patch by Philip Rogers p...@google.com on 2011-11-08
Reviewed by Simon Fraser.
Source/WebCore:
Test: svg/filters/feColorMatrix-invalid-animation.svg
* svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):
LayoutTests:
* svg/filters/feColorMatrix-invalid-animation-expected.png: Added.
* svg/filters/feColorMatrix-invalid-animation-expected.txt: Added.
* svg/filters/feColorMatrix-invalid-animation.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGAnimatedNumberList.cpp
Added Paths
trunk/LayoutTests/svg/filters/feColorMatrix-invalid-animation-expected.png
trunk/LayoutTests/svg/filters/feColorMatrix-invalid-animation-expected.txt
trunk/LayoutTests/svg/filters/feColorMatrix-invalid-animation.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (99637 => 99638)
--- trunk/LayoutTests/ChangeLog 2011-11-09 01:01:19 UTC (rev 99637)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 01:02:53 UTC (rev 99638)
@@ -1,3 +1,14 @@
+2011-11-08 Philip Rogers p...@google.com
+
+fix REGRESSION: SVG feColorMatrix causes crash
+https://bugs.webkit.org/show_bug.cgi?id=71287
+
+Reviewed by Simon Fraser.
+
+* svg/filters/feColorMatrix-invalid-animation-expected.png: Added.
+* svg/filters/feColorMatrix-invalid-animation-expected.txt: Added.
+* svg/filters/feColorMatrix-invalid-animation.svg: Added.
+
2011-11-08 Ojan Vafai o...@chromium.org
Update the expectations. This test appears to also fail on the chromium mac bots.
Added: trunk/LayoutTests/svg/filters/feColorMatrix-invalid-animation-expected.png (0 => 99638)
--- trunk/LayoutTests/svg/filters/feColorMatrix-invalid-animation-expected.png (rev 0)
+++ trunk/LayoutTests/svg/filters/feColorMatrix-invalid-animation-expected.png 2011-11-09 01:02:53 UTC (rev 99638)
@@ -0,0 +1,7 @@
+\x89PNG
+
+
+IHDR X ' )tEXtchecksum 778803df0a824ed8f2c7dfa07c56832eh\x9F\xBD\xAC
+\xB7IDATx\x9C\xED\xD8\xC1 \x80@A\xCF\xC45\xF35
+\x87R\xC1\x9BY\xC7}\xF0\xD2\\xB3{ \xF0\xE7\xEE #\xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b
[webkit-changes] [99639] trunk/Tools
Title: [99639] trunk/Tools Revision 99639 Author commit-qu...@webkit.org Date 2011-11-08 17:05:54 -0800 (Tue, 08 Nov 2011) Log Message Unreviewed, rolling out r99626. http://trac.webkit.org/changeset/99626 https://bugs.webkit.org/show_bug.cgi?id=71866 C++ exceptions cannot be disabled without influencing the Objective-C exceptions (Requested by benjaminp on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2011-11-08 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig Diff Modified: trunk/Tools/ChangeLog (99638 => 99639) --- trunk/Tools/ChangeLog 2011-11-09 01:02:53 UTC (rev 99638) +++ trunk/Tools/ChangeLog 2011-11-09 01:05:54 UTC (rev 99639) @@ -1,3 +1,14 @@ +2011-11-08 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r99626. +http://trac.webkit.org/changeset/99626 +https://bugs.webkit.org/show_bug.cgi?id=71866 + +C++ exceptions cannot be disabled without influencing the +Objective-C exceptions (Requested by benjaminp on #webkit). + +* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: + 2011-11-08 Benjamin Poulain bpoul...@apple.com [Mac] Disable C++ exceptions from DumpRenderTree Modified: trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig (99638 => 99639) --- trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig 2011-11-09 01:02:53 UTC (rev 99638) +++ trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig 2011-11-09 01:05:54 UTC (rev 99639) @@ -24,6 +24,5 @@ OTHER_LDFLAGS = -sectcreate __DATA Ahem qt/fonts/AHEM.TTF -sectcreate __DATA WeightWatcher100 fonts/WebKitWeightWatcher100.ttf -sectcreate __DATA WeightWatcher200 fonts/WebKitWeightWatcher200.ttf -sectcreate __DATA WeightWatcher300 fonts/WebKitWeightWatcher300.ttf -sectcreate __DATA WeightWatcher400 fonts/WebKitWeightWatcher400.ttf -sectcreate __DATA WeightWatcher500 fonts/WebKitWeightWatcher500.ttf -sectcreate __DATA WeightWatcher600 fonts/WebKitWeightWatcher600.ttf -sectcreate __DATA WeightWatcher700 fonts/WebKitWeightWatcher700.ttf -sectcreate __DATA WeightWatcher800 fonts/WebKitWeightWatcher800.ttf -sectcreate __DATA WeightWatcher900 fonts/WebKitWeightWatcher900.ttf LD_RUNPATH_SEARCH_PATHS = @loader_path/.; PRODUCT_NAME = DumpRenderTree -GCC_ENABLE_CPP_EXCEPTIONS = NO GCC_ENABLE_OBJC_EXCEPTIONS = YES GCC_PREFIX_HEADER = DumpRenderTreePrefix.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99640] trunk/Source/JavaScriptCore
Title: [99640] trunk/Source/_javascript_Core
Revision 99640
Author barraclo...@apple.com
Date 2011-11-08 17:11:57 -0800 (Tue, 08 Nov 2011)
Log Message
Move code to handle 8bit regs from X86Assembler to MacroAssembler
https://bugs.webkit.org/show_bug.cgi?id=71867
Reviewed by Oliver Hunt.
This code is fine, but is in the wrong place really. X86 assembler should
basically just format up exactly the instruction you request - not expand
out to a set of instructions (that is what the macro assembler layer is
for!). For other 8-bit ops, on X86 we don't guard against clients accessing
the XH registers.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::store8):
* assembler/X86Assembler.h:
(JSC::X86Assembler::movb_rm):
- moved some code.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h
trunk/Source/_javascript_Core/assembler/X86Assembler.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99639 => 99640)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-09 01:05:54 UTC (rev 99639)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 01:11:57 UTC (rev 99640)
@@ -1,3 +1,22 @@
+2011-11-08 Gavin Barraclough barraclo...@apple.com
+
+Move code to handle 8bit regs from X86Assembler to MacroAssembler
+https://bugs.webkit.org/show_bug.cgi?id=71867
+
+Reviewed by Oliver Hunt.
+
+This code is fine, but is in the wrong place really. X86 assembler should
+basically just format up exactly the instruction you request - not expand
+out to a set of instructions (that is what the macro assembler layer is
+for!). For other 8-bit ops, on X86 we don't guard against clients accessing
+the XH registers.
+
+* assembler/MacroAssemblerX86Common.h:
+(JSC::MacroAssemblerX86Common::store8):
+* assembler/X86Assembler.h:
+(JSC::X86Assembler::movb_rm):
+- moved some code.
+
2011-11-08 Filip Pizlo fpi...@apple.com
Unreviewed build fix for GTK.
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h (99639 => 99640)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h 2011-11-09 01:05:54 UTC (rev 99639)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h 2011-11-09 01:11:57 UTC (rev 99640)
@@ -536,6 +536,28 @@
void store8(RegisterID src, BaseIndex address)
{
+#if CPU(X86)
+// On 32-bit x86 we can only store from the first 4 registers;
+// esp..edi are mapped to the 'h' registers!
+if (src = 4) {
+// Pick a temporary register.
+RegisterID temp;
+if (address.base != X86Registers::eax address.index != X86Registers::eax)
+temp = X86Registers::eax;
+else if (address.base != X86Registers::ebx address.index != X86Registers::ebx)
+temp = X86Registers::ebx;
+else {
+ASSERT(address.base != X86Registers::ecx address.index != X86Registers::ecx);
+temp = X86Registers::ecx;
+}
+
+// Swap to the temporary register to perform the store.
+swap(src, temp);
+m_assembler.movb_rm(temp, address.offset, address.base, address.index, address.scale);
+swap(src, temp);
+return;
+}
+#endif
m_assembler.movb_rm(src, address.offset, address.base, address.index, address.scale);
}
Modified: trunk/Source/_javascript_Core/assembler/X86Assembler.h (99639 => 99640)
--- trunk/Source/_javascript_Core/assembler/X86Assembler.h 2011-11-09 01:05:54 UTC (rev 99639)
+++ trunk/Source/_javascript_Core/assembler/X86Assembler.h 2011-11-09 01:11:57 UTC (rev 99640)
@@ -1095,24 +1095,6 @@
void movb_rm(RegisterID src, int offset, RegisterID base, RegisterID index, int scale)
{
-#if CPU(X86)
-// On 32-bit x86 we can only set the first 4 registers;
-// esp..edi are mapped to the 'h' registers!
-if (src = 4) {
-RegisterID originalSrc = src;
-xchgl_rr(src, X86Registers::eax);
-if (base == X86Registers::eax)
-base = src;
-else if (index == X86Registers::eax)
-index = src;
-src = ""
-
-m_formatter.oneByteOp8(OP_MOV_EbGb, src, base, index, scale, offset);
-
-xchgl_rr(originalSrc, X86Registers::eax);
-return;
-}
-#endif
m_formatter.oneByteOp8(OP_MOV_EbGb, src, base, index, scale, offset);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99642] trunk/LayoutTests
Title: [99642] trunk/LayoutTests Revision 99642 Author bfulg...@webkit.org Date 2011-11-08 17:15:00 -0800 (Tue, 08 Nov 2011) Log Message [WinCairo] Unreviewed skiplist update to match main Windows build, and to skip a few failures. * platform/wincairo/Skipped: Updated. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wincairo/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (99641 => 99642) --- trunk/LayoutTests/ChangeLog 2011-11-09 01:14:58 UTC (rev 99641) +++ trunk/LayoutTests/ChangeLog 2011-11-09 01:15:00 UTC (rev 99642) @@ -1,3 +1,10 @@ +2011-11-08 Brent Fulgham bfulg...@webkit.org + +[WinCairo] Unreviewed skiplist update to match main Windows +build, and to skip a few failures. + +* platform/wincairo/Skipped: Updated. + 2011-11-08 Philip Rogers p...@google.com fix REGRESSION: SVG feColorMatrix causes crash Modified: trunk/LayoutTests/platform/wincairo/Skipped (99641 => 99642) --- trunk/LayoutTests/platform/wincairo/Skipped 2011-11-09 01:14:58 UTC (rev 99641) +++ trunk/LayoutTests/platform/wincairo/Skipped 2011-11-09 01:15:00 UTC (rev 99642) @@ -177,7 +177,9 @@ fast/box-sizing/panels-two.html fast/box-sizing/percentage-height.html fast/canvas/DrawImageSinglePixelStretch.html -fast/canvas/canvas-bg.html +fast/canvas/canvas-bg.html +fast/canvas/canvas-composite-canvas.html +fast/canvas/canvas-composite-image.html fast/canvas/canvas-drawImage-incomplete.html fast/canvas/canvas-fillPath-shadow.html fast/canvas/canvas-size-change-after-layout.html @@ -236,7 +238,7 @@ fast/dom/onerror-img.html fast/dom/outerText.html fast/dom/prototype-inheritance-2.html -fast/dom/row-inner-text.html +fast/dom/row-inner-text.html fast/dom/scroll-reveal-left-overflow.html fast/dom/scroll-reveal-top-overflow.html fast/dom/vertical-scrollbar-in-rtl.html @@ -437,6 +439,7 @@ security/block-test-no-port.html sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent/S11.5.3_A4_T6.html +sputnik/Implementation_Diagnostics svg/W3C-I18N svg/W3C-SVG-1.1-SE @@ -1737,6 +1740,7 @@ plugins/iframe-shims.html # Requires WebP support. +fast/canvas/canvas-toDataURL-webp.html fast/images/webp-image-decoding.html # Missing layoutTestController.findString() http://webkit.org/b/50234 @@ -1914,70 +1918,44 @@ # MutationObservers are net yet enabled. http://webkit.org/b/68729 fast/mutation -# Tests for track. Feature is not yet functional. +# The win port has no support for track # https://bugs.webkit.org/show_bug.cgi?id=43668 -media/track/track-mutable.html -media/track/track-text-track-cue-list.html -media/track/track-text-track.html -media/track/track-webvtt-tc000-empty.html -media/track/track-webvtt-tc001-utf8.html -media/track/track-webvtt-tc002-bom.html -media/track/track-webvtt-tc003-newlines.html -media/track/track-webvtt-tc004-magic-header.html -media/track/track-webvtt-tc005-header-comment.html -media/track/track-webvtt-tc006-cue-identifiers.html -media/track/track-webvtt-tc007-cue-no-id.html -media/track/track-webvtt-tc008-timings-no-hours.html -media/track/track-webvtt-tc009-timings-hour.html -media/track/track-webvtt-tc010-no-timings.html -media/track/track-webvtt-tc011-blank-lines.html -media/track/track-webvtt-tc012-out-of-order.html -media/track/track-webvtt-tc013-settings.html -media/track/track-webvtt-tc014-alignment.html -media/track/track-webvtt-tc015-positioning.html -media/track/track-webvtt-tc016-align-positioning.html -media/track/track-webvtt-tc017-line-position.html -media/track/track-webvtt-tc018-align-text-line-position.html -media/track/track-webvtt-tc019-cue-size.html -media/track/track-webvtt-tc020-cue-size-align.html -media/track/track-webvtt-tc021-valign.html -media/track/track-webvtt-tc022-entities.html -media/track/track-webvtt-tc023-markup.html -media/track/track-webvtt-tc024-timestamp.html -media/track/track-webvtt-tc025-class-markup.html -media/track/track-webvtt-tc026-voice.html -media/track/track-webvtt-tc027-empty-cue.html -media/track/track-webvtt-tc028-unsupported-markup.html +media/track +fast/events/constructors/track-event-constructor.html # Tests for MediaSource API. Feature is not yet functional. # https://bugs.webkit.org/show_bug.cgi?id=64731 http/tests/media/media-source/ -# Microdata DOM API is not yet enabled. -fast/dom/MicroData - # Font feature settings is not implemented. css3/font-feature-settings-rendering.html # This test verifies that a mismatch reftest will fail as intended if both results are same. fast/harness/sample-fail-mismatch-reftest.html -# editing/selection/caret-at-bidi-boundary.html timing out on Windows since it was added -# https://bugs.webkit.org/show_bug.cgi?id=66551 -editing/selection/caret-at-bidi-boundary.html - # Need DRT change: https://bugs.webkit.org/show_bug.cgi?id=66620 editing/spelling/spelling-insert-html.html # https://bugs.webkit.org/show_bug.cgi?id=66773
[webkit-changes] [99643] trunk/Source/JavaScriptCore
Title: [99643] trunk/Source/_javascript_Core
Revision 99643
Author barraclo...@apple.com
Date 2011-11-08 17:40:51 -0800 (Tue, 08 Nov 2011)
Log Message
Move duplicates of SYMBOL_STRING* macros to the single location
https://bugs.webkit.org/show_bug.cgi?id=71456
Reviewed by Sam Weinig.
* _javascript_Core.xcodeproj/project.pbxproj:
* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
* wtf/InlineASM.h: Added.
- Moved asm related macros.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/jit/JITStubs.cpp
Added Paths
trunk/Source/_javascript_Core/wtf/InlineASM.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99642 => 99643)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-09 01:15:00 UTC (rev 99642)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 01:40:51 UTC (rev 99643)
@@ -1,5 +1,18 @@
2011-11-08 Gavin Barraclough barraclo...@apple.com
+Move duplicates of SYMBOL_STRING* macros to the single location
+https://bugs.webkit.org/show_bug.cgi?id=71456
+
+Reviewed by Sam Weinig.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+* dfg/DFGOperations.cpp:
+* jit/JITStubs.cpp:
+* wtf/InlineASM.h: Added.
+- Moved asm related macros.
+
+2011-11-08 Gavin Barraclough barraclo...@apple.com
+
Move code to handle 8bit regs from X86Assembler to MacroAssembler
https://bugs.webkit.org/show_bug.cgi?id=71867
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (99642 => 99643)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2011-11-09 01:15:00 UTC (rev 99642)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2011-11-09 01:40:51 UTC (rev 99643)
@@ -1120,6 +1120,7 @@
868BFA16117CF19900B908B1 /* WTFString.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = WTFString.h; path = text/WTFString.h; sourceTree = group; };
868BFA5F117D048200B908B1 /* StaticConstructors.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StaticConstructors.h; sourceTree = group; };
8690231412092D5C00630AF9 /* PageReservation.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PageReservation.h; sourceTree = group; };
+ 8699AA60146A0E2B00E23A73 /* InlineASM.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InlineASM.h; sourceTree = group; };
869D04AE1193B54D00803475 /* CachedTranscendentalFunction.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CachedTranscendentalFunction.h; sourceTree = group; };
869EBCB60E8C6D4A008722CC /* ResultType.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ResultType.h; sourceTree = group; };
86A90ECF0EE7D51F00AB350D /* JITArithmetic.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JITArithmetic.cpp; sourceTree = group; };
@@ -1868,11 +1869,6 @@
65162EF108E6A21C007556CD /* wtf */ = {
isa = PBXGroup;
children = (
-0F2E5BF5146357D2003EB2EB /* Spectrum.h */,
-0FD52AAC1430359D0026DC9F /* UnionFind.h */,
-0F636D9F142D27D200B2E66A /* PackedIntVector.h */,
-0F16D724142C39A200CF784A /* BitVector.cpp */,
-0FD82F491428069200179C94 /* BitVector.h */,
C22C524813FAF6EF00B7DC0D /* dtoa */,
06D358A00DAAD9C4003B174E /* mac */,
8656573E115BE35200291F40 /* text */,
@@ -1885,6 +1881,8 @@
65E217B708E7EECC0023E5F6 /* Assertions.h */,
BC5F7BBB11823B590052C02C /* Atomics.h */,
E1A596370DE3E1C300C17E37 /* AVLTree.h */,
+0F16D724142C39A200CF784A /* BitVector.cpp */,
+0FD82F491428069200179C94 /* BitVector.h */,
DD377CBB12072C18006A2517 /* Bitmap.h */,
A7C40C07130B057D00D002A1 /* BlockStack.h */,
E4D8CE9B12FC42E100BC9F5A /* BloomFilter.h */,
@@ -1927,6 +1925,7 @@
65DFC92E08EA173A00F7300B /* HashTable.h */,
65DFC92F08EA173A00F7300B /* HashTraits.h */,
7186A6E813100B57004479E1 /* HexNumber.h */,
+8699AA60146A0E2B00E23A73 /* InlineASM.h */,
657EB7450B708F540063461B /* ListHashSet.h */,
148A1626095D16BB00666D0D /* ListRefPtr.h */,
E1EE79270D6C964500FEA3BA /* Locker.h */,
@@ -1953,6 +1952,7 @@
0BDFFAD10FC616EC00D69EF4 /* OwnFastMallocPtr.h */,
9303F567099118FA00AD71B8 /* OwnPtr.h */,
440B7AED0FAF7FCB0073323E /* OwnPtrCommon.h */,
+0F636D9F142D27D200B2E66A /* PackedIntVector.h */,
8627E5EA11F1281900A313B5 /* PageAllocation.h */,
14FFF98A12BFFF7500795BB8 /* PageAllocationAligned.cpp */,
14FFF98B12BFFF7500795BB8 /* PageAllocationAligned.h */,
@@ -1986,6 +1986,7 @@
76FB9F0E12E851860051A2EB /* SHA1.h */,
[webkit-changes] [99647] trunk/Source/JavaScriptCore
Title: [99647] trunk/Source/_javascript_Core Revision 99647 Author barraclo...@apple.com Date 2011-11-08 19:02:14 -0800 (Tue, 08 Nov 2011) Log Message Better abstract 'abs' operation through the MacroAssembler. https://bugs.webkit.org/show_bug.cgi?id=71873 Reviewed by Geoff Garen. Currently the x86 specific instruction sequence to perform a double abs is duplicated throughout the JITs / thunk generators. * assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::supportsFloatingPoint): (JSC::MacroAssemblerARM::supportsFloatingPointTruncate): (JSC::MacroAssemblerARM::supportsFloatingPointSqrt): (JSC::MacroAssemblerARM::supportsFloatingPointAbs): (JSC::MacroAssemblerARM::absDouble): - Renamed supportsFloatingPointAbs, make these methods static so that we can check the JIT's capabilites before we begin compilation. * assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsFloatingPoint): (JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate): (JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt): (JSC::MacroAssemblerARMv7::supportsFloatingPointAbs): - Renamed supportsFloatingPointAbs, make these methods static so that we can check the JIT's capabilites before we begin compilation. * assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::absDouble): (JSC::MacroAssemblerMIPS::supportsFloatingPoint): (JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate): (JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt): (JSC::MacroAssemblerMIPS::supportsFloatingPointAbs): - Renamed supportsFloatingPointAbs, make these methods static so that we can check the JIT's capabilites before we begin compilation. * assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::supportsFloatingPoint): (JSC::MacroAssemblerSH4::supportsFloatingPointTruncate): (JSC::MacroAssemblerSH4::supportsFloatingPointSqrt): (JSC::MacroAssemblerSH4::supportsFloatingPointAbs): (JSC::MacroAssemblerSH4::absDouble): - Renamed supportsFloatingPointAbs, make these methods static so that we can check the JIT's capabilites before we begin compilation. * assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::absDouble): (JSC::MacroAssemblerX86::supportsFloatingPoint): (JSC::MacroAssemblerX86::supportsFloatingPointTruncate): (JSC::MacroAssemblerX86::supportsFloatingPointSqrt): (JSC::MacroAssemblerX86::supportsFloatingPointAbs): - Made supports* methods static so that we can check the JIT's capabilites before we begin compilation. Added absDouble. * assembler/MacroAssemblerX86Common.h: - Removed andnotDouble, added s_maskSignBit. * assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::absDouble): (JSC::MacroAssemblerX86_64::supportsFloatingPoint): (JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate): (JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt): (JSC::MacroAssemblerX86_64::supportsFloatingPointAbs): - Made supports* methods static so that we can check the JIT's capabilites before we begin compilation. Added absDouble. * assembler/X86Assembler.h: (JSC::X86Assembler::andpd_rr): (JSC::X86Assembler::andpd_mr): - Added support for andpd instruction. * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::handleIntrinsic): - Added checks for supportsFloatingPointAbs, supportsFloatingPointSqrt. * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): - Switched to use doubleAbs, we can now also reuse the operand register for the result. * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): - Switched to use doubleAbs, we can now also reuse the operand register for the result. * jit/ThunkGenerators.cpp: - Switched to use doubleAbs. (JSC::absThunkGenerator): * runtime/JSGlobalData.cpp: - Declared MacroAssemblerX86Common::s_maskSignBit here. This is a little ugly, but it doesn't seem worth adding a whole extra .cpp to the compile for just one constant. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h trunk/Source/_javascript_Core/assembler/X86Assembler.h trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (99646 => 99647) --- trunk/Source/_javascript_Core/ChangeLog 2011-11-09 02:50:47 UTC (rev 99646) +++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 03:02:14 UTC (rev
[webkit-changes] [99648] trunk/Source/WebKit/chromium
Title: [99648] trunk/Source/WebKit/chromium
Revision 99648
Author nd...@chromium.org
Date 2011-11-08 20:03:39 -0800 (Tue, 08 Nov 2011)
Log Message
[chromium] When GC3DPrivate::initializExtensions fails, dont keep retrying
https://bugs.webkit.org/show_bug.cgi?id=71637
Reviewed by Kenneth Russell.
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::initializeExtensions):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (99647 => 99648)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-09 03:02:14 UTC (rev 99647)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-09 04:03:39 UTC (rev 99648)
@@ -1,3 +1,13 @@
+2011-11-08 Nat Duca nd...@chromium.org
+
+[chromium] When GC3DPrivate::initializExtensions fails, dont keep retrying
+https://bugs.webkit.org/show_bug.cgi?id=71637
+
+Reviewed by Kenneth Russell.
+
+* src/GraphicsContext3DChromium.cpp:
+(WebCore::GraphicsContext3DPrivate::initializeExtensions):
+
2011-11-08 Adam Klein ad...@chromium.org
Use a typedef for ExceptionCode in all header files instead of including ExceptionCode.h
Modified: trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp (99647 => 99648)
--- trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp 2011-11-09 03:02:14 UTC (rev 99647)
+++ trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp 2011-11-09 04:03:39 UTC (rev 99648)
@@ -826,17 +826,20 @@
void GraphicsContext3DPrivate::initializeExtensions()
{
+if (m_initializedAvailableExtensions)
+return;
+
+m_initializedAvailableExtensions = true;
bool success = makeContextCurrent();
ASSERT(success);
-if (success !m_initializedAvailableExtensions) {
-String extensionsString = getString(GraphicsContext3D::EXTENSIONS);
-splitStringHelper(extensionsString, m_enabledExtensions);
+if (!success)
+return;
-String requestableExtensionsString = m_impl-getRequestableExtensionsCHROMIUM();
-splitStringHelper(requestableExtensionsString, m_requestableExtensions);
+String extensionsString = getString(GraphicsContext3D::EXTENSIONS);
+splitStringHelper(extensionsString, m_enabledExtensions);
-m_initializedAvailableExtensions = true;
-}
+String requestableExtensionsString = m_impl-getRequestableExtensionsCHROMIUM();
+splitStringHelper(requestableExtensionsString, m_requestableExtensions);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99649] trunk
Title: [99649] trunk
Revision 99649
Author cev...@google.com
Date 2011-11-08 20:17:42 -0800 (Tue, 08 Nov 2011)
Log Message
Crash accessing font fact rule parent
https://bugs.webkit.org/show_bug.cgi?id=71860
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/css/css-fontface-rule-crash.html
* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::~CSSFontFaceRule): tell our child rule when we are going away.
LayoutTests:
* fast/css/css-fontface-rule-crash-expected.txt: Added.
* fast/css/css-fontface-rule-crash.html: Added.
* resources/gc.js: Added. Add a re-usable best-of-breed gc().
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontFaceRule.cpp
Added Paths
trunk/LayoutTests/fast/css/css-fontface-rule-crash-expected.txt
trunk/LayoutTests/fast/css/css-fontface-rule-crash.html
trunk/LayoutTests/resources/gc.js
Diff
Modified: trunk/LayoutTests/ChangeLog (99648 => 99649)
--- trunk/LayoutTests/ChangeLog 2011-11-09 04:03:39 UTC (rev 99648)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 04:17:42 UTC (rev 99649)
@@ -1,3 +1,14 @@
+2011-11-08 Chris Evans cev...@google.com
+
+Crash accessing font fact rule parent
+https://bugs.webkit.org/show_bug.cgi?id=71860
+
+Reviewed by Adam Barth.
+
+* fast/css/css-fontface-rule-crash-expected.txt: Added.
+* fast/css/css-fontface-rule-crash.html: Added.
+* resources/gc.js: Added. Add a re-usable best-of-breed gc().
+
2011-11-08 Brent Fulgham bfulg...@webkit.org
[WinCairo] Unreviewed skiplist update to match main Windows
Added: trunk/LayoutTests/fast/css/css-fontface-rule-crash-expected.txt (0 => 99649)
--- trunk/LayoutTests/fast/css/css-fontface-rule-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/css-fontface-rule-crash-expected.txt 2011-11-09 04:17:42 UTC (rev 99649)
@@ -0,0 +1 @@
+PASS
Added: trunk/LayoutTests/fast/css/css-fontface-rule-crash.html (0 => 99649)
--- trunk/LayoutTests/fast/css/css-fontface-rule-crash.html (rev 0)
+++ trunk/LayoutTests/fast/css/css-fontface-rule-crash.html 2011-11-09 04:17:42 UTC (rev 99649)
@@ -0,0 +1,37 @@
+html
+head
+script src=""
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+function load()
+{
+style = document.createElement('style');
+style.textContent = '@font-face { font-family: A; }';
+document.head.appendChild(style);
+rulestyle = document.styleSheets[0].cssRules[0].style;
+document.head.removeChild(style);
+style = null;
+setTimeout(crash, 0);
+}
+
+function crash()
+{
+gc();
+obj = rulestyle.parentRule;
+// If the gc() actually successfully reaps everything it can, then obj
+// will end up null (post-fix). gc() is not guaranteed to reap the font-face
+// rule, however, particularly in the browser context.
+if (obj)
+obj = obj.foo;
+document.body.innerText = 'PASS';
+if (window.layoutTestController)
+layoutTestController.notifyDone()
+}
+/script
+/head
+body _onload_=load()/body
+/html
Added: trunk/LayoutTests/resources/gc.js (0 => 99649)
--- trunk/LayoutTests/resources/gc.js (rev 0)
+++ trunk/LayoutTests/resources/gc.js 2011-11-09 04:17:42 UTC (rev 99649)
@@ -0,0 +1,20 @@
+// If there is no window.gc() already defined, define one using the best
+// method we can find.
+// The slow fallback should not hit in the actual test environment.
+if (!window.gc)
+{
+window.gc = function()
+{
+if (window.GCController)
+return GCController.collect();
+function gcRec(n) {
+if (n 1)
+return {};
+var temp = {i: ab + i + (i / 10)};
+temp += foo;
+gcRec(n-1);
+}
+for (var i = 0; i 1; i++)
+gcRec(10);
+}
+}
Modified: trunk/Source/WebCore/ChangeLog (99648 => 99649)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 04:03:39 UTC (rev 99648)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 04:17:42 UTC (rev 99649)
@@ -1,3 +1,15 @@
+2011-11-08 Chris Evans cev...@google.com
+
+Crash accessing font fact rule parent
+https://bugs.webkit.org/show_bug.cgi?id=71860
+
+Reviewed by Adam Barth.
+
+Test: fast/css/css-fontface-rule-crash.html
+
+* css/CSSFontFaceRule.cpp:
+(WebCore::CSSFontFaceRule::~CSSFontFaceRule): tell our child rule when we are going away.
+
2011-11-08 Adam Klein ad...@chromium.org
Use a typedef for ExceptionCode in all header files instead of including ExceptionCode.h
Modified: trunk/Source/WebCore/css/CSSFontFaceRule.cpp (99648 => 99649)
--- trunk/Source/WebCore/css/CSSFontFaceRule.cpp 2011-11-09 04:03:39 UTC (rev 99648)
+++ trunk/Source/WebCore/css/CSSFontFaceRule.cpp 2011-11-09 04:17:42 UTC (rev 99649)
@@ -33,6 +33,8 @@
[webkit-changes] [99651] trunk/Tools
Title: [99651] trunk/Tools Revision 99651 Author hay...@chromium.org Date 2011-11-08 21:44:47 -0800 (Tue, 08 Nov 2011) Log Message [NRWT] Make single_test_runner aware of reference filename of test_input. https://bugs.webkit.org/show_bug.cgi?id=71567 Reviewed by Ryosuke Niwa. Make single_test_runner honor a reference filename of given test_input so that we can use any file as reference html, instead of depending on implicit naming convention. The typical use case is to support w3c reftests. No tests since no functional changes until there is a client. Test should be easily written with future clients. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: * Scripts/webkitpy/layout_tests/models/test_failures.py: * Scripts/webkitpy/layout_tests/models/test_input.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py trunk/Tools/Scripts/webkitpy/layout_tests/models/test_input.py Diff Modified: trunk/Tools/ChangeLog (99650 => 99651) --- trunk/Tools/ChangeLog 2011-11-09 04:20:52 UTC (rev 99650) +++ trunk/Tools/ChangeLog 2011-11-09 05:44:47 UTC (rev 99651) @@ -1,3 +1,22 @@ +2011-11-08 Hayato Ito hay...@chromium.org + +[NRWT] Make single_test_runner aware of reference filename of test_input. +https://bugs.webkit.org/show_bug.cgi?id=71567 + +Reviewed by Ryosuke Niwa. + +Make single_test_runner honor a reference filename of given test_input so that +we can use any file as reference html, instead of depending on implicit naming convention. +The typical use case is to support w3c reftests. + +No tests since no functional changes until there is a client. +Test should be easily written with future clients. + +* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: +* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: +* Scripts/webkitpy/layout_tests/models/test_failures.py: +* Scripts/webkitpy/layout_tests/models/test_input.py: + 2011-11-08 Lucas Forschler lforsch...@apple.com https://bugs.webkit.org/show_bug.cgi?id=71839 Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (99650 => 99651) --- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2011-11-09 04:20:52 UTC (rev 99650) +++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2011-11-09 05:44:47 UTC (rev 99651) @@ -61,6 +61,12 @@ self._reference_filename = None fs = port._filesystem +if test_input.ref_file: +self._is_reftest = True +self._reference_filename = fs.join(self._port.layout_tests_dir(), test_input.ref_file) +self._is_mismatch_reftest = test_input.is_mismatch_reftest +return + reftest_expected_filename = port.reftest_expected_filename(self._test_name) if fs.exists(reftest_expected_filename): self._is_reftest = True @@ -304,7 +310,7 @@ if self._is_mismatch_reftest: if driver_output1.image_hash == driver_output2.image_hash: -failures.append(test_failures.FailureReftestMismatchDidNotOccur()) +failures.append(test_failures.FailureReftestMismatchDidNotOccur(self._reference_filename)) elif driver_output1.image_hash != driver_output2.image_hash: -failures.append(test_failures.FailureReftestMismatch()) +failures.append(test_failures.FailureReftestMismatch(self._reference_filename)) return TestResult(self._test_name, failures, total_test_time, has_stderr) Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py (99650 => 99651) --- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py 2011-11-09 04:20:52 UTC (rev 99650) +++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py 2011-11-09 05:44:47 UTC (rev 99651) @@ -73,10 +73,10 @@ image_diff = port.diff_image(driver_output.image, expected_driver_output.image)[0] if image_diff: writer.write_image_diff_files(image_diff) -writer.copy_file(port.reftest_expected_filename(test_name), '-expected.html') +writer.copy_file(failure.reference_filename) elif isinstance(failure, test_failures.FailureReftestMismatchDidNotOccur): writer.write_image_files(driver_output.image, expected_image=None) -writer.copy_file(port.reftest_expected_mismatch_filename(test_name), '-expected-mismatch.html') +writer.copy_file(failure.reference_filename) else: assert isinstance(failure,
[webkit-changes] [99652] trunk/Source/JavaScriptCore
Title: [99652] trunk/Source/_javascript_Core Revision 99652 Author o...@webkit.org Date 2011-11-08 22:41:55 -0800 (Tue, 08 Nov 2011) Log Message Unreviewed, rolling out r99647. http://trac.webkit.org/changeset/99647 https://bugs.webkit.org/show_bug.cgi?id=71876 It broke jsc and layout tests on all bot (Requested by Ossy_night on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2011-11-08 * assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::supportsFloatingPoint): (JSC::MacroAssemblerARM::supportsFloatingPointTruncate): (JSC::MacroAssemblerARM::supportsFloatingPointSqrt): (JSC::MacroAssemblerARM::supportsDoubleBitops): (JSC::MacroAssemblerARM::andnotDouble): * assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsFloatingPoint): (JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate): (JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt): (JSC::MacroAssemblerARMv7::supportsDoubleBitops): * assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::andnotDouble): (JSC::MacroAssemblerMIPS::supportsFloatingPoint): (JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate): (JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt): (JSC::MacroAssemblerMIPS::supportsDoubleBitops): * assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::supportsFloatingPoint): (JSC::MacroAssemblerSH4::supportsFloatingPointTruncate): (JSC::MacroAssemblerSH4::supportsFloatingPointSqrt): (JSC::MacroAssemblerSH4::supportsDoubleBitops): (JSC::MacroAssemblerSH4::andnotDouble): * assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::MacroAssemblerX86): (JSC::MacroAssemblerX86::supportsFloatingPoint): (JSC::MacroAssemblerX86::supportsFloatingPointTruncate): (JSC::MacroAssemblerX86::supportsFloatingPointSqrt): (JSC::MacroAssemblerX86::supportsDoubleBitops): * assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::andnotDouble): * assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::supportsFloatingPoint): (JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate): (JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt): (JSC::MacroAssemblerX86_64::supportsDoubleBitops): * assembler/X86Assembler.h: * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::handleIntrinsic): * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): * jit/ThunkGenerators.cpp: (JSC::absThunkGenerator): * runtime/JSGlobalData.cpp: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h trunk/Source/_javascript_Core/assembler/X86Assembler.h trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (99651 => 99652) --- trunk/Source/_javascript_Core/ChangeLog 2011-11-09 05:44:47 UTC (rev 99651) +++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 06:41:55 UTC (rev 99652) @@ -1,3 +1,59 @@ +2011-11-08 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r99647. +http://trac.webkit.org/changeset/99647 +https://bugs.webkit.org/show_bug.cgi?id=71876 + +It broke jsc and layout tests on all bot (Requested by +Ossy_night on #webkit). + +* assembler/MacroAssemblerARM.h: +(JSC::MacroAssemblerARM::supportsFloatingPoint): +(JSC::MacroAssemblerARM::supportsFloatingPointTruncate): +(JSC::MacroAssemblerARM::supportsFloatingPointSqrt): +(JSC::MacroAssemblerARM::supportsDoubleBitops): +(JSC::MacroAssemblerARM::andnotDouble): +* assembler/MacroAssemblerARMv7.h: +(JSC::MacroAssemblerARMv7::supportsFloatingPoint): +(JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate): +(JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt): +(JSC::MacroAssemblerARMv7::supportsDoubleBitops): +* assembler/MacroAssemblerMIPS.h: +(JSC::MacroAssemblerMIPS::andnotDouble): +(JSC::MacroAssemblerMIPS::supportsFloatingPoint): +(JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate): +(JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt): +(JSC::MacroAssemblerMIPS::supportsDoubleBitops): +* assembler/MacroAssemblerSH4.h: +(JSC::MacroAssemblerSH4::supportsFloatingPoint): +(JSC::MacroAssemblerSH4::supportsFloatingPointTruncate): +
[webkit-changes] [99653] trunk
Title: [99653] trunk
Revision 99653
Author commit-qu...@webkit.org
Date 2011-11-08 23:11:27 -0800 (Tue, 08 Nov 2011)
Log Message
Default select multiple expands up to 10 items instead of showing 4.
https://bugs.webkit.org/show_bug.cgi?id=70765
Patch by Antaryami Pandia antaryami.pan...@motorola.com on 2011-11-08
Reviewed by Darin Adler.
Source/WebCore:
Tests: fast/forms/select-clientheight-large-size.html
fast/forms/select-clientheight-with-multiple-attr.html
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::size):
LayoutTests:
* fast/forms/select-clientheight-large-size-expected.txt: Added.
* fast/forms/select-clientheight-large-size.html: Added.
* fast/forms/select-clientheight-with-multiple-attr-expected.txt: Added.
* fast/forms/select-clientheight-with-multiple-attr.html: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/forms/listbox-clip-expected.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/gtk/fast/forms/listbox-clip-expected.txt
trunk/LayoutTests/platform/mac/test_expectations.txt
trunk/LayoutTests/platform/qt/test_expectations.txt
trunk/LayoutTests/platform/win/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderListBox.cpp
Added Paths
trunk/LayoutTests/fast/forms/select-clientheight-large-size-expected.txt
trunk/LayoutTests/fast/forms/select-clientheight-large-size.html
trunk/LayoutTests/fast/forms/select-clientheight-with-multiple-attr-expected.txt
trunk/LayoutTests/fast/forms/select-clientheight-with-multiple-attr.html
Diff
Modified: trunk/LayoutTests/ChangeLog (99652 => 99653)
--- trunk/LayoutTests/ChangeLog 2011-11-09 06:41:55 UTC (rev 99652)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 07:11:27 UTC (rev 99653)
@@ -1,3 +1,20 @@
+2011-11-08 Antaryami Pandia antaryami.pan...@motorola.com
+
+Default select multiple expands up to 10 items instead of showing 4.
+https://bugs.webkit.org/show_bug.cgi?id=70765
+
+Reviewed by Darin Adler.
+
+* fast/forms/select-clientheight-large-size-expected.txt: Added.
+* fast/forms/select-clientheight-large-size.html: Added.
+* fast/forms/select-clientheight-with-multiple-attr-expected.txt: Added.
+* fast/forms/select-clientheight-with-multiple-attr.html: Added.
+* platform/chromium/test_expectations.txt:
+* platform/gtk/fast/forms/listbox-clip-expected.txt:
+* platform/mac/test_expectations.txt:
+* platform/qt/test_expectations.txt:
+* platform/win/test_expectations.txt:
+
2011-11-08 Chris Evans cev...@google.com
Crash accessing font fact rule parent
Added: trunk/LayoutTests/fast/forms/select-clientheight-large-size-expected.txt (0 => 99653)
--- trunk/LayoutTests/fast/forms/select-clientheight-large-size-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/select-clientheight-large-size-expected.txt 2011-11-09 07:11:27 UTC (rev 99653)
@@ -0,0 +1,14 @@
+HTMLSelectElement multiple attribute test when no size is specified
+
+PASS clientHeight('select2') is clientHeight('select1')
+PASS getElemById('select2').setAttribute('size', '4'); clientHeight('select2') == clientHeight('select1') is true
+PASS getElemById('select2').setAttribute('size', '5'); clientHeight('select2') clientHeight('select1') is true
+PASS getElemById('select2').setAttribute('size', '8'); clientHeight('select2') == multipleOfElement('select1', 2) is true
+PASS getElemById('select2').setAttribute('size', '12'); clientHeight('select2') == multipleOfElement('select1', 3) is true
+PASS getElemById('select2').setAttribute('size', '16'); clientHeight('select2') == multipleOfElement('select1', 4) is true
+PASS getElemById('select2').setAttribute('size', '400'); clientHeight('select2') == multipleOfElement('select1', 100) is true
+PASS getElemById('select2').setAttribute('size', '4000'); clientHeight('select2') == multipleOfElement('select1', 1000) is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/forms/select-clientheight-large-size.html (0 => 99653)
--- trunk/LayoutTests/fast/forms/select-clientheight-large-size.html (rev 0)
+++ trunk/LayoutTests/fast/forms/select-clientheight-large-size.html 2011-11-09 07:11:27 UTC (rev 99653)
@@ -0,0 +1,67 @@
+html
+head
+script src=""
+/head
+body
+pHTMLSelectElement multiple attribute test when no size is specified/p
+div id=console/div
+
+select multiple id=select1
+option value=00/option
+option value=11/option
+option value=22/option
+option value=33/option
+option value=44/option
+option value=55/option
+option value=66/option
+option value=77/option
+option value=88/option
+option value=99/option
+/select
+
+select
[webkit-changes] [99655] trunk/LayoutTests
Title: [99655] trunk/LayoutTests
Revision 99655
Author ph...@webkit.org
Date 2011-11-08 23:22:27 -0800 (Tue, 08 Nov 2011)
Log Message
Unreviewed, GTK rebaseline after r99539.
* platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
* platform/gtk/svg/zoom/page/zoom-background-images-expected.txt:
* platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt
trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-background-images-expected.txt
trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt
trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (99654 => 99655)
--- trunk/LayoutTests/ChangeLog 2011-11-09 07:18:29 UTC (rev 99654)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 07:22:27 UTC (rev 99655)
@@ -1,3 +1,12 @@
+2011-11-08 Philippe Normand pnorm...@igalia.com
+
+Unreviewed, GTK rebaseline after r99539.
+
+* platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
+* platform/gtk/svg/zoom/page/zoom-background-images-expected.txt:
+* platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
+* platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
+
2011-11-08 Csaba Osztrogonác o...@webkit.org
[Qt] Unreviewed morning gardening. Update platform specific expected results.
Modified: trunk/LayoutTests/platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt (99654 => 99655)
--- trunk/LayoutTests/platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt 2011-11-09 07:18:29 UTC (rev 99654)
+++ trunk/LayoutTests/platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt 2011-11-09 07:22:27 UTC (rev 99655)
@@ -1,6 +1,6 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
layer at (0,0) size 800x600
- RenderSVGRoot {svg} at (6,3) size 788x594
-RenderSVGPath {rect} at (6,3) size 788x594 [stroke={[type=SOLID] [color=#00]}] [x=4.63] [y=3.47] [width=453.70] [height=340.28]
+ RenderSVGRoot {svg} at (12,8) size 788x592
+RenderSVGPath {rect} at (12,8) size 788x592 [stroke={[type=SOLID] [color=#00]}] [x=8.00] [y=6.00] [width=784.00] [height=588.00]
RenderSVGHiddenContainer {defs} at (0,0) size 0x0
Modified: trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-background-images-expected.txt (99654 => 99655)
--- trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-background-images-expected.txt 2011-11-09 07:18:29 UTC (rev 99654)
+++ trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-background-images-expected.txt 2011-11-09 07:22:27 UTC (rev 99655)
@@ -1,21 +1,18 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x114
- RenderBlock {HTML} at (0,0) size 800x114
-RenderBody {BODY} at (3,3) size 794x108
- RenderBlock {DIV} at (8,8) size 90x90 [border: (1px solid #00)]
- RenderText {#text} at (106,100) size 2x8
-text run at (106,100) width 2:
- RenderBlock {DIV} at (116,8) size 90x90 [border: (1px solid #00)]
- RenderText {#text} at (214,100) size 2x8
-text run at (214,100) width 2:
- RenderBlock {DIV} at (224,8) size 90x90 [border: (1px solid #00)]
- RenderText {#text} at (322,100) size 2x8
-text run at (322,100) width 2:
- RenderImage {IMG} at (332,8) size 90x90 [border: (1px solid #00)]
- RenderText {#text} at (430,100) size 2x8
-text run at (430,100) width 2:
- RenderImage {IMG} at (440,8) size 90x90 [border: (1px solid #00)]
+layer at (0,0) size 800x161
+ RenderBlock {HTML} at (0,0) size 800x161
+RenderBody {BODY} at (4,4) size 792x153
+ RenderBlock {DIV} at (11,11) size 129x129 [border: (1px solid #00)]
+ RenderText {#text} at (151,142) size 2x11
+text run at (151,142) width 2:
+ RenderBlock {DIV} at (164,11) size 129x129 [border: (1px solid #00)]
+ RenderText {#text} at (304,142) size 2x11
+text run at (304,142) width 2:
+ RenderBlock {DIV} at (317,11) size 129x129 [border: (1px solid #00)]
+ RenderText {#text} at (457,142) size 2x11
+text run at (457,142) width 2:
+ RenderImage {IMG} at (470,11) size 129x129 [border: (1px solid #00)]
RenderText {#text} at (0,0) size 0x0
RenderText {#text} at (0,0) size 0x0
RenderText {#text} at (0,0) size 0x0
Modified: trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt (99654 => 99655)
--- trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt 2011-11-09
[webkit-changes] [99656] trunk/LayoutTests
Title: [99656] trunk/LayoutTests Revision 99656 Author o...@webkit.org Date 2011-11-08 23:23:08 -0800 (Tue, 08 Nov 2011) Log Message [Qt] Unreviewed morning gardening. Update platform specific expected results. * platform/qt/fast/forms/listbox-clip-expected.png: * platform/qt/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/fast/forms/listbox-clip-expected.png trunk/LayoutTests/platform/qt/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (99655 => 99656) --- trunk/LayoutTests/ChangeLog 2011-11-09 07:22:27 UTC (rev 99655) +++ trunk/LayoutTests/ChangeLog 2011-11-09 07:23:08 UTC (rev 99656) @@ -11,6 +11,13 @@ [Qt] Unreviewed morning gardening. Update platform specific expected results. +* platform/qt/fast/forms/listbox-clip-expected.png: +* platform/qt/test_expectations.txt: + +2011-11-08 Csaba Osztrogonác o...@webkit.org + +[Qt] Unreviewed morning gardening. Update platform specific expected results. + * platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.png: * platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: * platform/qt/svg/zoom/page/zoom-background-images-expected.png: Modified: trunk/LayoutTests/platform/qt/fast/forms/listbox-clip-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/qt/test_expectations.txt (99655 => 99656) --- trunk/LayoutTests/platform/qt/test_expectations.txt 2011-11-09 07:22:27 UTC (rev 99655) +++ trunk/LayoutTests/platform/qt/test_expectations.txt 2011-11-09 07:23:08 UTC (rev 99656) @@ -16,7 +16,4 @@ BUGWK67007 DEBUG : fast/ruby/generated-after-counter-doesnt-crash.html = CRASH BUGWK67007 DEBUG : fast/ruby/generated-before-and-after-counter-doesnt-crash.html = CRASH -// Need rebaseline -BUGWK70765 : fast/forms/listbox-clip.html = TEXT - BUGWK62662 DEBUG : inspector/cookie-parser.html = CRASH PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99657] trunk/LayoutTests
Title: [99657] trunk/LayoutTests Revision 99657 Author yu...@chromium.org Date 2011-11-08 23:41:25 -0800 (Tue, 08 Nov 2011) Log Message [Chromium] Unreviewed, fix expectation conflict in test_expectations.txt. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (99656 => 99657) --- trunk/LayoutTests/ChangeLog 2011-11-09 07:23:08 UTC (rev 99656) +++ trunk/LayoutTests/ChangeLog 2011-11-09 07:41:25 UTC (rev 99657) @@ -1,3 +1,9 @@ +2011-11-08 Yuta Kitamura yu...@chromium.org + +[Chromium] Unreviewed, fix expectation conflict in test_expectations.txt. + +* platform/chromium/test_expectations.txt: + 2011-11-08 Philippe Normand pnorm...@igalia.com Unreviewed, GTK rebaseline after r99539. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99656 => 99657) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-09 07:23:08 UTC (rev 99656) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-09 07:41:25 UTC (rev 99657) @@ -1969,7 +1969,7 @@ BUGCR42875 SKIP WONTFIX : sputnik = TEXT // Need rebaseline -BUGWK70765 : fast/forms/listbox-clip.html = TEXT +BUGWK70765 WIN : fast/forms/listbox-clip.html = TEXT BUGWK38705 : http/tests/security/sandbox-inherit-to-initial-document-2.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99658] trunk/LayoutTests
Title: [99658] trunk/LayoutTests Revision 99658 Author yu...@chromium.org Date 2011-11-08 23:55:27 -0800 (Tue, 08 Nov 2011) Log Message [Chromium] Unreviewed, land correct expectations for Kusa-Makura-background-canvas.html. The background color of this test should be white, not transparent. * platform/chromium-cg-mac-leopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: * platform/chromium-cg-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: * platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (99657 => 99658) --- trunk/LayoutTests/ChangeLog 2011-11-09 07:41:25 UTC (rev 99657) +++ trunk/LayoutTests/ChangeLog 2011-11-09 07:55:27 UTC (rev 99658) @@ -1,5 +1,14 @@ 2011-11-08 Yuta Kitamura yu...@chromium.org +[Chromium] Unreviewed, land correct expectations for Kusa-Makura-background-canvas.html. +The background color of this test should be white, not transparent. + +* platform/chromium-cg-mac-leopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: +* platform/chromium-cg-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: +* platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: + +2011-11-08 Yuta Kitamura yu...@chromium.org + [Chromium] Unreviewed, fix expectation conflict in test_expectations.txt. * platform/chromium/test_expectations.txt: Modified: trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
