[webkit-changes] [100979] trunk/LayoutTests
Title: [100979] trunk/LayoutTests
Revision 100979
Author ma...@webkit.org
Date 2011-11-22 00:30:42 -0800 (Tue, 22 Nov 2011)
Log Message
[GTK] platform/gtk/accessibility/name-from-label.html fails
https://bugs.webkit.org/show_bug.cgi?id=71665
Reviewed by Philippe Normand.
Fix layout test to properly consider 'form' accessibility objects.
* platform/gtk/Skipped: Unskip name-from-label.html.
* platform/gtk/accessibility/name-from-label.html: Re-write layout
test to properly take into account the accessibility hierarchy.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/gtk/accessibility/name-from-label.html
Diff
Modified: trunk/LayoutTests/ChangeLog (100978 => 100979)
--- trunk/LayoutTests/ChangeLog 2011-11-22 03:38:58 UTC (rev 100978)
+++ trunk/LayoutTests/ChangeLog 2011-11-22 08:30:42 UTC (rev 100979)
@@ -1,3 +1,16 @@
+2011-11-22 Mario Sanchez Prada msanc...@igalia.com
+
+[GTK] platform/gtk/accessibility/name-from-label.html fails
+https://bugs.webkit.org/show_bug.cgi?id=71665
+
+Reviewed by Philippe Normand.
+
+Fix layout test to properly consider 'form' accessibility objects.
+
+* platform/gtk/Skipped: Unskip name-from-label.html.
+* platform/gtk/accessibility/name-from-label.html: Re-write layout
+ test to properly take into account the accessibility hierarchy.
+
2011-11-21 Yuta Kitamura yu...@chromium.org
[GTK] Enable WebSocket hybi tests
Modified: trunk/LayoutTests/platform/gtk/Skipped (100978 => 100979)
--- trunk/LayoutTests/platform/gtk/Skipped 2011-11-22 03:38:58 UTC (rev 100978)
+++ trunk/LayoutTests/platform/gtk/Skipped 2011-11-22 08:30:42 UTC (rev 100979)
@@ -1498,9 +1498,6 @@
platform/gtk/accessibility/combo-box-collapsed-selection-changed.html
platform/gtk/accessibility/document-reload-events.html
-# https://bugs.webkit.org/show_bug.cgi?id=71665
-platform/gtk/accessibility/name-from-label.html
-
# https://bugs.webkit.org/show_bug.cgi?id=67713
accessibility/textbox-role-reports-selection.html
Modified: trunk/LayoutTests/platform/gtk/accessibility/name-from-label.html (100978 => 100979)
--- trunk/LayoutTests/platform/gtk/accessibility/name-from-label.html 2011-11-22 03:38:58 UTC (rev 100978)
+++ trunk/LayoutTests/platform/gtk/accessibility/name-from-label.html 2011-11-22 08:30:42 UTC (rev 100979)
@@ -12,12 +12,13 @@
div id=console/div
script
var webArea;
- var child;
+ var form;
function checkResults() {
// Actually check the results
-shouldBe(child.role, 'AXRole: entry');
-shouldBe(child.title, 'AXTitle: Full Name:');
+entry = form.childAtIndex(1);
+shouldBe(entry.role, 'AXRole: entry');
+shouldBe(entry.title, 'AXTitle: Full Name:');
finishJSTest();
}
@@ -30,7 +31,7 @@
document.getElementById(body).focus();
webArea = accessibilityController.focusedElement;
-child = webArea.childAtIndex(1);
+form = webArea.childAtIndex(0);
// Check results on idle to ensure layout() is done
window.setTimeout(checkResults(), 0);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100980] trunk/LayoutTests
Title: [100980] trunk/LayoutTests Revision 100980 Author r...@webkit.org Date 2011-11-22 00:50:59 -0800 (Tue, 22 Nov 2011) Log Message [Qt] inspector/extensions/extensions-events.html crashing after r100926 https://bugs.webkit.org/show_bug.cgi?id=72932 Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100979 => 100980) --- trunk/LayoutTests/ChangeLog 2011-11-22 08:30:42 UTC (rev 100979) +++ trunk/LayoutTests/ChangeLog 2011-11-22 08:50:59 UTC (rev 100980) @@ -1,3 +1,12 @@ +2011-11-22 Renata Hodovan r...@webkit.org + +[Qt] inspector/extensions/extensions-events.html crashing after r100926 +https://bugs.webkit.org/show_bug.cgi?id=72932 + +Unreviewed gardening. + +* platform/qt/Skipped: + 2011-11-22 Mario Sanchez Prada msanc...@igalia.com [GTK] platform/gtk/accessibility/name-from-label.html fails Modified: trunk/LayoutTests/platform/qt/Skipped (100979 => 100980) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-22 08:30:42 UTC (rev 100979) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-22 08:50:59 UTC (rev 100980) @@ -2477,3 +2477,7 @@ # [Qt] fast/canvas/canvas-lineWidth.html timeouts intermittently on 64 bit # https://bugs.webkit.org/show_bug.cgi?id=72694 fast/canvas/canvas-lineWidth.html + +# [Qt] inspector/extensions/extensions-events.html crashing after r100926 +# https://bugs.webkit.org/show_bug.cgi?id=72932 +inspector/extensions/extensions-events.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100981] trunk/Source/WebCore
Title: [100981] trunk/Source/WebCore
Revision 100981
Author apav...@chromium.org
Date 2011-11-22 01:18:46 -0800 (Tue, 22 Nov 2011)
Log Message
Web Inspector: Design of the autocomplete suggest
https://bugs.webkit.org/show_bug.cgi?id=72798
Reviewed by Pavel Feldman.
Implemented a combination of grayed text for the first/only completion and hid
the suggest box for a single suggestion (the grayed text is displayed instead.)
Drive-by fix for the trailing spaces in the prompt issue
(got regressed when the suggest box was introduced for the first time.)
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView): Fix the trailing spaces issue
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.renderAsBlock): Fix the trailing spaces issue
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.acceptAutoComplete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.applySuggestion):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ConsoleView.js
trunk/Source/WebCore/inspector/front-end/TextPrompt.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (100980 => 100981)
--- trunk/Source/WebCore/ChangeLog 2011-11-22 08:50:59 UTC (rev 100980)
+++ trunk/Source/WebCore/ChangeLog 2011-11-22 09:18:46 UTC (rev 100981)
@@ -1,3 +1,27 @@
+2011-11-22 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: Design of the autocomplete suggest
+https://bugs.webkit.org/show_bug.cgi?id=72798
+
+Reviewed by Pavel Feldman.
+
+Implemented a combination of grayed text for the first/only completion and hid
+the suggest box for a single suggestion (the grayed text is displayed instead.)
+Drive-by fix for the trailing spaces in the prompt issue
+(got regressed when the suggest box was introduced for the first time.)
+
+* inspector/front-end/ConsoleView.js:
+(WebInspector.ConsoleView): Fix the trailing spaces issue
+* inspector/front-end/TextPrompt.js:
+(WebInspector.TextPrompt):
+(WebInspector.TextPrompt.prototype.renderAsBlock): Fix the trailing spaces issue
+(WebInspector.TextPrompt.prototype._attachInternal):
+(WebInspector.TextPrompt.prototype.acceptAutoComplete):
+(WebInspector.TextPrompt.prototype._completionsReady):
+(WebInspector.TextPrompt.prototype.applySuggestion):
+(WebInspector.TextPrompt.prototype.acceptSuggestion):
+(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
+
2011-11-21 David Barr davidb...@chromium.org
REGRESSION(r98542): Chromium: CSS text is rendered on page
Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (100980 => 100981)
--- trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-22 08:50:59 UTC (rev 100980)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-22 09:18:46 UTC (rev 100981)
@@ -113,6 +113,7 @@
this.prompt = new WebInspector.TextPromptWithHistory(this.completions.bind(this), ExpressionStopCharacters + .);
this.prompt.setSuggestBoxEnabled(generic-suggest);
+this.prompt.renderAsBlock();
this.prompt.attach(this.promptElement);
this.prompt.proxyElement.addEventListener(keydown, this._promptKeyDown.bind(this), false);
this.prompt.setHistoryData(WebInspector.settings.consoleHistory.get());
Modified: trunk/Source/WebCore/inspector/front-end/TextPrompt.js (100980 => 100981)
--- trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-22 08:50:59 UTC (rev 100980)
+++ trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-22 09:18:46 UTC (rev 100981)
@@ -39,6 +39,7 @@
* @type {Element|undefined}
*/
this._proxyElement;
+this._proxyElementDisplay = inline-block;
this._loadCompletions = completions;
this._completionStopCharacters = stopCharacters;
this._suggestForceable = true;
@@ -65,6 +66,11 @@
this._suggestBoxClassName = className;
},
+renderAsBlock: function()
+{
+this._proxyElementDisplay = block;
+},
+
/**
* Clients should never attach any event listeners to the |element|. Instead,
* they should use the result of this method to attach listeners for bubbling events.
@@ -101,7 +107,7 @@
this._boundOnKeyDown = this.onKeyDown.bind(this);
this._boundSelectStart = this._selectStart.bind(this);
this._proxyElement = element.ownerDocument.createElement(span);
-this._proxyElement.style.display = inline-block;
+this._proxyElement.style.display = this._proxyElementDisplay;
element.parentElement.insertBefore(this.proxyElement, element);
this.proxyElement.appendChild(element);
[webkit-changes] [100982] trunk/LayoutTests
Title: [100982] trunk/LayoutTests
Revision 100982
Author r...@webkit.org
Date 2011-11-22 01:19:17 -0800 (Tue, 22 Nov 2011)
Log Message
Unreviewed gardening. Reset test results.
Patch by Feher Zsolt fehe...@inf.u-szeged.hu on 2011-11-22
* platform/qt-5.0/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
* platform/qt-5.0/css2.1/20110323/table-caption-002-expected.txt: Added.
* platform/qt-5.0/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
* platform/qt-5.0/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
* platform/qt-5.0/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
* platform/qt-5.0/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
* platform/qt-5.0/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
* platform/qt-5.0/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
* platform/qt-5.0/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
* platform/qt-5.0/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/border-spacing-applies-to-015-expected.txt
trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/table-caption-002-expected.txt
trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt
trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/table-caption-optional-001-expected.txt
trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/table-caption-optional-002-expected.txt
trunk/LayoutTests/platform/qt-5.0/fast/multicol/pagination-h-horizontal-bt-expected.txt
trunk/LayoutTests/platform/qt-5.0/fast/multicol/pagination-h-horizontal-tb-expected.txt
trunk/LayoutTests/platform/qt-5.0/fast/multicol/pagination-h-vertical-rl-expected.txt
trunk/LayoutTests/platform/qt-5.0/fast/multicol/pagination-v-horizontal-bt-expected.txt
trunk/LayoutTests/platform/qt-5.0/fast/multicol/pagination-v-vertical-lr-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (100981 => 100982)
--- trunk/LayoutTests/ChangeLog 2011-11-22 09:18:46 UTC (rev 100981)
+++ trunk/LayoutTests/ChangeLog 2011-11-22 09:19:17 UTC (rev 100982)
@@ -1,3 +1,18 @@
+2011-11-22 Feher Zsolt fehe...@inf.u-szeged.hu
+
+Unreviewed gardening. Reset test results.
+
+* platform/qt-5.0/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
+* platform/qt-5.0/css2.1/20110323/table-caption-002-expected.txt: Added.
+* platform/qt-5.0/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
+* platform/qt-5.0/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
+* platform/qt-5.0/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
+* platform/qt-5.0/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
+* platform/qt-5.0/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
+* platform/qt-5.0/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
+* platform/qt-5.0/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
+* platform/qt-5.0/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
+
2011-11-22 Renata Hodovan r...@webkit.org
[Qt] inspector/extensions/extensions-events.html crashing after r100926
Added: trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/border-spacing-applies-to-015-expected.txt (0 => 100982)
--- trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/border-spacing-applies-to-015-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/border-spacing-applies-to-015-expected.txt 2011-11-22 09:19:17 UTC (rev 100982)
@@ -0,0 +1,12 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x318
+ RenderBlock {HTML} at (0,0) size 800x318
+RenderBody {BODY} at (8,16) size 784x294
+ RenderBlock {P} at (0,0) size 784x38
+RenderText {#text} at (0,0) size 741x38
+ text run at (0,0) width 741: Test passes if there is a blue and orange square below and there is no vertical gap between the
+ text run at (0,19) width 68: squares.
+ RenderTable {DIV} at (0,54) size 120x240
+RenderBlock {DIV} at (0,0) size 120x120 [border: (10px solid #FF)]
+RenderBlock {DIV} at (0,120) size 120x120 [border: (10px solid #FFA500)]
Added: trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/table-caption-002-expected.txt (0 => 100982)
--- trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/table-caption-002-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/table-caption-002-expected.txt 2011-11-22 09:19:17 UTC (rev 100982)
@@ -0,0 +1,34 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x168
+ RenderBlock {HTML} at (0,0) size 800x168
+RenderTable {BODY} at (8,8) size 784x152
+
[webkit-changes] [100983] trunk/Source/WebKit2
Title: [100983] trunk/Source/WebKit2 Revision 100983 Author commit-qu...@webkit.org Date 2011-11-22 01:32:08 -0800 (Tue, 22 Nov 2011) Log Message [WK2] Modify EFL port's WebEventFactory to use EflKeyboardUtilities's keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName(). https://bugs.webkit.org/show_bug.cgi?id=72850 Patch by Eunmi Lee eunmi15@samsung.com on 2011-11-22 Reviewed by Anders Carlsson. The EflKeyboardUtilities has been added, so we can use keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName() for EFL port's WebEventFactory. * Shared/efl/WebEventFactory.cpp: (WebKit::WebEventFactory::createWebKeyboardEvent): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/efl/WebEventFactory.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (100982 => 100983) --- trunk/Source/WebKit2/ChangeLog 2011-11-22 09:19:17 UTC (rev 100982) +++ trunk/Source/WebKit2/ChangeLog 2011-11-22 09:32:08 UTC (rev 100983) @@ -1,3 +1,17 @@ +2011-11-22 Eunmi Lee eunmi15@samsung.com + +[WK2] Modify EFL port's WebEventFactory to use EflKeyboardUtilities's +keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName(). +https://bugs.webkit.org/show_bug.cgi?id=72850 + +Reviewed by Anders Carlsson. + +The EflKeyboardUtilities has been added, so we can use keyIdentifierForEvasKeyName() and +windowsKeyCodeForEvasKeyName() for EFL port's WebEventFactory. + +* Shared/efl/WebEventFactory.cpp: +(WebKit::WebEventFactory::createWebKeyboardEvent): + 2011-11-21 Alexis Menard alexis.men...@openbossa.org [Qt][WK2] REGRESSION(100483): It made 2 API tests fail Modified: trunk/Source/WebKit2/Shared/efl/WebEventFactory.cpp (100982 => 100983) --- trunk/Source/WebKit2/Shared/efl/WebEventFactory.cpp 2011-11-22 09:19:17 UTC (rev 100982) +++ trunk/Source/WebKit2/Shared/efl/WebEventFactory.cpp 2011-11-22 09:32:08 UTC (rev 100983) @@ -26,8 +26,7 @@ #include config.h #include WebEventFactory.h -#include WebCore/NotImplemented.h -#include WebCore/PlatformKeyboardEvent.h +#include EflKeyboardUtilities.h #include WebCore/Scrollbar.h using namespace WebCore; @@ -163,8 +162,8 @@ return WebKeyboardEvent(WebEvent::KeyDown, String::fromUTF8(event-string), String::fromUTF8(event-string), -PlatformKeyboardEvent::keyIdentifierForEvasKeyName(keyName), -PlatformKeyboardEvent::windowsKeyCodeForEvasKeyName(keyName), +keyIdentifierForEvasKeyName(keyName), +windowsKeyCodeForEvasKeyName(keyName), 0 /* FIXME: nativeVirtualKeyCode */, 0 /* macCharCode */, false /* FIXME: isAutoRepeat */, @@ -180,8 +179,8 @@ return WebKeyboardEvent(WebEvent::KeyUp, String::fromUTF8(event-string), String::fromUTF8(event-string), -PlatformKeyboardEvent::keyIdentifierForEvasKeyName(keyName), -PlatformKeyboardEvent::windowsKeyCodeForEvasKeyName(keyName), +keyIdentifierForEvasKeyName(keyName), +windowsKeyCodeForEvasKeyName(keyName), 0 /* FIXME: nativeVirtualKeyCode */, 0 /* macCharCode */, false /* FIXME: isAutoRepeat */, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100985] trunk/Source
Title: [100985] trunk/Source Revision 100985 Author pfeld...@chromium.org Date 2011-11-22 01:52:10 -0800 (Tue, 22 Nov 2011) Log Message Web Inspector: strip unused InspectorController methods. https://bugs.webkit.org/show_bug.cgi?id=72886 Source/WebCore: This is a follow up to the https://bugs.webkit.org/show_bug.cgi?id=63009. I am now able to remove following InspectorController methods: ::startUserInitiatedProfiling, ::isRecordingUserInitiatedProfile, ::stopUserInitiatedProfiling, ::showAndEnableDebugger, ::debuggerEnabled, ::disableDebugger, ::startTimelineProfiler, ::stopTimelineProfiler, ::timelineProfilerEnabled, ::showConsole. Reviewed by Yury Semikhatsky. * WebCore.exp.in: * WebCore.order: * inspector/Inspector.json: * inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::setFrontend): * inspector/InspectorAgent.h: * inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::connectFrontend): * inspector/InspectorController.h: * inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::enable): (WebCore::InspectorDebuggerAgent::disable): * inspector/InspectorDebuggerAgent.h: * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCommitLoadImpl): * inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetState): (WebCore::InspectorProfilerAgent::clearFrontend): (WebCore::InspectorProfilerAgent::restore): (WebCore::InspectorProfilerAgent::start): (WebCore::InspectorProfilerAgent::stop): * inspector/InspectorProfilerAgent.h: * inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::start): (WebCore::InspectorTimelineAgent::stop): * inspector/InspectorTimelineAgent.h: * inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.enableDebugger): (WebInspector.DebuggerModel.prototype.disableDebugger): * inspector/front-end/TimelineManager.js: (WebInspector.TimelineManager.prototype.start): (WebInspector.TimelineManager.prototype.stop): (WebInspector.TimelineManager.prototype._started): (WebInspector.TimelineManager.prototype._stopped): * inspector/front-end/inspector.js: Source/WebKit/gtk: Reviewed by Yury Semikhatsky. * webkit/webkitwebinspector.cpp: (webkit_web_inspector_set_property): (webkit_web_inspector_get_property): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/WebCore.order trunk/Source/WebCore/inspector/Inspector.json trunk/Source/WebCore/inspector/InspectorAgent.cpp trunk/Source/WebCore/inspector/InspectorAgent.h trunk/Source/WebCore/inspector/InspectorController.cpp trunk/Source/WebCore/inspector/InspectorController.h trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp trunk/Source/WebCore/inspector/InspectorProfilerAgent.h trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp trunk/Source/WebCore/inspector/InspectorTimelineAgent.h trunk/Source/WebCore/inspector/front-end/DebuggerModel.js trunk/Source/WebCore/inspector/front-end/TimelineManager.js trunk/Source/WebCore/inspector/front-end/inspector.js trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/webkit/webkitwebinspector.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (100984 => 100985) --- trunk/Source/WebCore/ChangeLog 2011-11-22 09:34:01 UTC (rev 100984) +++ trunk/Source/WebCore/ChangeLog 2011-11-22 09:52:10 UTC (rev 100985) @@ -1,3 +1,60 @@ +2011-11-22 Pavel Feldman pfeld...@google.com + +Web Inspector: strip unused InspectorController methods. +https://bugs.webkit.org/show_bug.cgi?id=72886 + +This is a follow up to the https://bugs.webkit.org/show_bug.cgi?id=63009. +I am now able to remove following InspectorController methods: +::startUserInitiatedProfiling, +::isRecordingUserInitiatedProfile, +::stopUserInitiatedProfiling, +::showAndEnableDebugger, +::debuggerEnabled, +::disableDebugger, +::startTimelineProfiler, +::stopTimelineProfiler, +::timelineProfilerEnabled, +::showConsole. + +Reviewed by Yury Semikhatsky. + +* WebCore.exp.in: +* WebCore.order: +* inspector/Inspector.json: +* inspector/InspectorAgent.cpp: +(WebCore::InspectorAgent::setFrontend): +* inspector/InspectorAgent.h: +* inspector/InspectorController.cpp: +(WebCore::InspectorController::InspectorController): +(WebCore::InspectorController::connectFrontend): +* inspector/InspectorController.h: +* inspector/InspectorDebuggerAgent.cpp: +(WebCore::InspectorDebuggerAgent::enable): +(WebCore::InspectorDebuggerAgent::disable): +* inspector/InspectorDebuggerAgent.h: +* inspector/InspectorInstrumentation.cpp: +
[webkit-changes] [100986] trunk/LayoutTests
Title: [100986] trunk/LayoutTests Revision 100986 Author ph...@webkit.org Date 2011-11-22 01:57:31 -0800 (Tue, 22 Nov 2011) Log Message Unreviewed, GTK rebaseline after r100979. * platform/gtk/accessibility/name-from-label-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/accessibility/name-from-label-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (100985 => 100986) --- trunk/LayoutTests/ChangeLog 2011-11-22 09:52:10 UTC (rev 100985) +++ trunk/LayoutTests/ChangeLog 2011-11-22 09:57:31 UTC (rev 100986) @@ -1,3 +1,9 @@ +2011-11-22 Philippe Normand pnorm...@igalia.com + +Unreviewed, GTK rebaseline after r100979. + +* platform/gtk/accessibility/name-from-label-expected.txt: + 2011-11-22 Feher Zsolt fehe...@inf.u-szeged.hu Unreviewed gardening. Reset test results. Modified: trunk/LayoutTests/platform/gtk/accessibility/name-from-label-expected.txt (100985 => 100986) --- trunk/LayoutTests/platform/gtk/accessibility/name-from-label-expected.txt 2011-11-22 09:52:10 UTC (rev 100985) +++ trunk/LayoutTests/platform/gtk/accessibility/name-from-label-expected.txt 2011-11-22 09:57:31 UTC (rev 100986) @@ -4,8 +4,8 @@ On success, you will see a series of PASS messages, followed by TEST COMPLETE. -PASS child.role is 'AXRole: entry' -PASS child.title is 'AXTitle: Full Name:' +PASS entry.role is 'AXRole: entry' +PASS entry.title is 'AXTitle: Full Name:' PASS successfullyParsed is true TEST COMPLETE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100987] trunk
Title: [100987] trunk
Revision 100987
Author apav...@chromium.org
Date 2011-11-22 03:14:54 -0800 (Tue, 22 Nov 2011)
Log Message
Web Inspector: [protocol] actual JSON messages do not conform to Inspector.json in CSS
https://bugs.webkit.org/show_bug.cgi?id=72733
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::buildArrayForComputedStyle):
* inspector/InspectorStyleSheet.h:
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleDeclaration.parseComputedStylePayload):
LayoutTests:
* inspector/styles/styles-new-API.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/styles/styles-new-API.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp
trunk/Source/WebCore/inspector/InspectorCSSAgent.h
trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp
trunk/Source/WebCore/inspector/InspectorStyleSheet.h
trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js
Diff
Modified: trunk/LayoutTests/ChangeLog (100986 => 100987)
--- trunk/LayoutTests/ChangeLog 2011-11-22 09:57:31 UTC (rev 100986)
+++ trunk/LayoutTests/ChangeLog 2011-11-22 11:14:54 UTC (rev 100987)
@@ -1,3 +1,12 @@
+2011-11-22 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: [protocol] actual JSON messages do not conform to Inspector.json in CSS
+https://bugs.webkit.org/show_bug.cgi?id=72733
+
+Reviewed by Pavel Feldman.
+
+* inspector/styles/styles-new-API.html:
+
2011-11-22 Philippe Normand pnorm...@igalia.com
Unreviewed, GTK rebaseline after r100979.
Modified: trunk/LayoutTests/inspector/styles/styles-new-API.html (100986 => 100987)
--- trunk/LayoutTests/inspector/styles/styles-new-API.html 2011-11-22 09:57:31 UTC (rev 100986)
+++ trunk/LayoutTests/inspector/styles/styles-new-API.html 2011-11-22 11:14:54 UTC (rev 100987)
@@ -20,7 +20,7 @@
{
InspectorTest.addResult();
InspectorTest.addResult(=== Computed style property count for body ===);
-var propCount = styles.computedStyle.cssProperties.length;
+var propCount = styles.computedStyle.length;
InspectorTest.addResult(propCount 200 ? OK : FAIL ( + propCount + ));
InspectorTest.addResult();
Modified: trunk/Source/WebCore/ChangeLog (100986 => 100987)
--- trunk/Source/WebCore/ChangeLog 2011-11-22 09:57:31 UTC (rev 100986)
+++ trunk/Source/WebCore/ChangeLog 2011-11-22 11:14:54 UTC (rev 100987)
@@ -1,3 +1,21 @@
+2011-11-22 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: [protocol] actual JSON messages do not conform to Inspector.json in CSS
+https://bugs.webkit.org/show_bug.cgi?id=72733
+
+Reviewed by Pavel Feldman.
+
+* inspector/Inspector.json:
+* inspector/InspectorCSSAgent.cpp:
+(WebCore::InspectorCSSAgent::getComputedStyleForNode):
+* inspector/InspectorCSSAgent.h:
+* inspector/InspectorStyleSheet.cpp:
+(WebCore::InspectorStyle::buildArrayForComputedStyle):
+* inspector/InspectorStyleSheet.h:
+* inspector/front-end/CSSStyleModel.js:
+(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
+(WebInspector.CSSStyleDeclaration.parseComputedStylePayload):
+
2011-11-22 Pavel Feldman pfeld...@google.com
Web Inspector: strip unused InspectorController methods.
Modified: trunk/Source/WebCore/inspector/Inspector.json (100986 => 100987)
--- trunk/Source/WebCore/inspector/Inspector.json 2011-11-22 09:57:31 UTC (rev 100986)
+++ trunk/Source/WebCore/inspector/Inspector.json 2011-11-22 11:14:54 UTC (rev 100987)
@@ -1473,7 +1473,7 @@
id: CSSRule,
type: object,
properties: [
-{ name: ruleId, $ref: CSSRuleId, description: The CSS rule identifier.},
+{ name: ruleId, $ref: CSSRuleId, optional: true, description: The CSS rule identifier (absent for user agent stylesheet and user-specified stylesheet rules).},
{ name: selectorText, type: string, description: Rule selector.},
{ name: sourceURL, type: string, optional: true, description: Parent stylesheet resource URL (for regular rules).},
{ name: sourceLine, type: integer, description: Line ordinal of the rule selector start character in the resource.},
@@ -1498,20 +1498,24 @@
type: object
},
{
-id: CSSComputedStyle,
-type: object
+id: CSSComputedStyleProperty,
+type: object,
+properties: [
+{ name: name,
[webkit-changes] [100988] trunk/Source
Title: [100988] trunk/Source Revision 100988 Author kbal...@webkit.org Date 2011-11-22 03:42:00 -0800 (Tue, 22 Nov 2011) Log Message Enable ParallelJobs by default https://bugs.webkit.org/show_bug.cgi?id=70032 Reviewed by Zoltan Herczeg. Source/_javascript_Core: According to measurements on Mac and Linux it is a considerable speedup for SVG on multicore. Remove the ENABLE(PARALLEL_JOBS) guard. Fix build on Windows and Chromium. * _javascript_Core.gypi: Add the files to the build. It was missing for the gyp build system. * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: Export symbols. * wtf/ParallelJobs.h: * wtf/ParallelJobsGeneric.cpp: (WTF::ParallelEnvironment::ParallelEnvironment): (WTF::ParallelEnvironment::execute): Deinline these to avoid exporting a lot of symbols. These are non-trivial and called only once on a given object so it doesn't seems to be worthwile to inline them. Additionally fix a signed-unsigned comparison in the constructor. * wtf/ParallelJobsGeneric.h: * wtf/Platform.h: Source/WebCore: Covered by existing tests. According to measurements on Mac and Linux it is a considerable speedup for SVG on multicore. Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build by qualifying ParallelJobs with the WTF namespace (otherwise MSVC believes it belongs to WebCore which is likely a compiler bug). * platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::setInteriorPixelsWorker): (WebCore::FEConvolveMatrix::platformApplySoftware): * platform/graphics/filters/FEConvolveMatrix.h: * platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::platformApplyWorker): (WebCore::FEGaussianBlur::platformApply): * platform/graphics/filters/FEGaussianBlur.h: * platform/graphics/filters/FELighting.cpp: (WebCore::FELighting::platformApplyGenericWorker): (WebCore::FELighting::platformApplyGeneric): * platform/graphics/filters/FELighting.h: * platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::platformApplyWorker): (WebCore::FEMorphology::platformApply): * platform/graphics/filters/FEMorphology.h: * platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::fillRegionWorker): (WebCore::FETurbulence::platformApplySoftware): * platform/graphics/filters/FETurbulence.h: * platform/graphics/filters/arm/FELightingNEON.cpp: (WebCore::FELighting::platformApplyNeonWorker): * platform/graphics/filters/arm/FELightingNEON.h: (WebCore::FELighting::platformApplyNeon): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.gypi trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def trunk/Source/_javascript_Core/wtf/ParallelJobs.h trunk/Source/_javascript_Core/wtf/ParallelJobsGeneric.cpp trunk/Source/_javascript_Core/wtf/ParallelJobsGeneric.h trunk/Source/_javascript_Core/wtf/Platform.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp trunk/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h trunk/Source/WebCore/platform/graphics/filters/FELighting.cpp trunk/Source/WebCore/platform/graphics/filters/FELighting.h trunk/Source/WebCore/platform/graphics/filters/FEMorphology.cpp trunk/Source/WebCore/platform/graphics/filters/FEMorphology.h trunk/Source/WebCore/platform/graphics/filters/FETurbulence.cpp trunk/Source/WebCore/platform/graphics/filters/FETurbulence.h trunk/Source/WebCore/platform/graphics/filters/arm/FELightingNEON.cpp trunk/Source/WebCore/platform/graphics/filters/arm/FELightingNEON.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (100987 => 100988) --- trunk/Source/_javascript_Core/ChangeLog 2011-11-22 11:14:54 UTC (rev 100987) +++ trunk/Source/_javascript_Core/ChangeLog 2011-11-22 11:42:00 UTC (rev 100988) @@ -1,3 +1,31 @@ +2011-11-21 Balazs Kelemen kbal...@webkit.org + +Enable ParallelJobs by default +https://bugs.webkit.org/show_bug.cgi?id=70032 + +Reviewed by Zoltan Herczeg. + +According to measurements on Mac and Linux it is a +considerable speedup for SVG on multicore. + +Remove the ENABLE(PARALLEL_JOBS) guard. +Fix build on Windows and Chromium. + +* _javascript_Core.gypi: Add the files to the build. It was +missing for the gyp build system. +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: +Export symbols. +* wtf/ParallelJobs.h: +* wtf/ParallelJobsGeneric.cpp: +(WTF::ParallelEnvironment::ParallelEnvironment): +(WTF::ParallelEnvironment::execute): +Deinline these to avoid exporting a lot of symbols. +These are non-trivial and called only once on a given object +so it doesn't seems to be worthwile to inline them. +Additionally fix a signed-unsigned comparison
[webkit-changes] [100989] trunk/Source
Title: [100989] trunk/Source Revision 100989 Author kbal...@webkit.org Date 2011-11-22 04:58:20 -0800 (Tue, 22 Nov 2011) Log Message Unreviewed, rolling out r100988. http://trac.webkit.org/changeset/100988 https://bugs.webkit.org/show_bug.cgi?id=72941 Broke pixel tests on Chromium-Linux (Requested by kbalazs on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2011-11-22 Source/_javascript_Core: * _javascript_Core.gypi: * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: * wtf/ParallelJobs.h: * wtf/ParallelJobsGeneric.cpp: * wtf/ParallelJobsGeneric.h: (WTF::ParallelEnvironment::ParallelEnvironment): (WTF::ParallelEnvironment::execute): * wtf/Platform.h: Source/WebCore: * platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::platformApplySoftware): * platform/graphics/filters/FEConvolveMatrix.h: * platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::platformApply): * platform/graphics/filters/FEGaussianBlur.h: * platform/graphics/filters/FELighting.cpp: (WebCore::FELighting::platformApplyGeneric): * platform/graphics/filters/FELighting.h: * platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::platformApply): * platform/graphics/filters/FEMorphology.h: * platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::platformApplySoftware): * platform/graphics/filters/FETurbulence.h: * platform/graphics/filters/arm/FELightingNEON.cpp: * platform/graphics/filters/arm/FELightingNEON.h: (WebCore::FELighting::platformApplyNeon): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.gypi trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def trunk/Source/_javascript_Core/wtf/ParallelJobs.h trunk/Source/_javascript_Core/wtf/ParallelJobsGeneric.cpp trunk/Source/_javascript_Core/wtf/ParallelJobsGeneric.h trunk/Source/_javascript_Core/wtf/Platform.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp trunk/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h trunk/Source/WebCore/platform/graphics/filters/FELighting.cpp trunk/Source/WebCore/platform/graphics/filters/FELighting.h trunk/Source/WebCore/platform/graphics/filters/FEMorphology.cpp trunk/Source/WebCore/platform/graphics/filters/FEMorphology.h trunk/Source/WebCore/platform/graphics/filters/FETurbulence.cpp trunk/Source/WebCore/platform/graphics/filters/FETurbulence.h trunk/Source/WebCore/platform/graphics/filters/arm/FELightingNEON.cpp trunk/Source/WebCore/platform/graphics/filters/arm/FELightingNEON.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (100988 => 100989) --- trunk/Source/_javascript_Core/ChangeLog 2011-11-22 11:42:00 UTC (rev 100988) +++ trunk/Source/_javascript_Core/ChangeLog 2011-11-22 12:58:20 UTC (rev 100989) @@ -1,3 +1,21 @@ +2011-11-22 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r100988. +http://trac.webkit.org/changeset/100988 +https://bugs.webkit.org/show_bug.cgi?id=72941 + +Broke pixel tests on Chromium-Linux (Requested by kbalazs on +#webkit). + +* _javascript_Core.gypi: +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: +* wtf/ParallelJobs.h: +* wtf/ParallelJobsGeneric.cpp: +* wtf/ParallelJobsGeneric.h: +(WTF::ParallelEnvironment::ParallelEnvironment): +(WTF::ParallelEnvironment::execute): +* wtf/Platform.h: + 2011-11-21 Balazs Kelemen kbal...@webkit.org Enable ParallelJobs by default Modified: trunk/Source/_javascript_Core/_javascript_Core.gypi (100988 => 100989) --- trunk/Source/_javascript_Core/_javascript_Core.gypi 2011-11-22 11:42:00 UTC (rev 100988) +++ trunk/Source/_javascript_Core/_javascript_Core.gypi 2011-11-22 12:58:20 UTC (rev 100989) @@ -565,11 +565,6 @@ 'wtf/OSRandomSource.h', 'wtf/PageAllocationAligned.cpp', 'wtf/PageBlock.cpp', -'wtf/ParallelJobs.h', -'wtf/ParallelJobsGeneric.cpp', -'wtf/ParallelJobsGeneric.h', -'wtf/ParallelJobsLibdispatch.h', -'wtf/ParallelJobsOpenMP.h', 'wtf/RandomNumber.cpp', 'wtf/RandomNumberSeed.h', 'wtf/RefCountedLeakCounter.cpp', Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (100988 => 100989) --- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-11-22 11:42:00 UTC (rev 100988) +++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-11-22 12:58:20 UTC (rev 100989) @@ -13,7 +13,6 @@ ??0JSLock@JSC@@QAE@PAVExecState@1@@Z ??0MD5@WTF@@QAE@XZ ??0Mutex@WTF@@QAE@XZ -
[webkit-changes] [100990] trunk/Source/WebKit2
Title: [100990] trunk/Source/WebKit2 Revision 100990 Author caio.olive...@openbossa.org Date 2011-11-22 05:21:18 -0800 (Tue, 22 Nov 2011) Log Message [Qt] [WK2] Move PageUIClient related code to QtWebPageUIClient https://bugs.webkit.org/show_bug.cgi?id=72910 Reviewed by Andreas Kling. Split PageUIClient related code from QtWebPageProxy/ClientImpl. The new QtWebPageUIClient registers itself with WKPageRef and it's owned by the QQuickWebViewPrivate. This is a move to clean up QtWebPageProxy object. * Target.pri: * UIProcess/API/qt/qquickwebview.cpp: (QQuickWebViewPrivate::QQuickWebViewPrivate): (QQuickWebViewPrivate::chooseFiles): * UIProcess/API/qt/qquickwebview_p.h: * UIProcess/API/qt/qquickwebview_p_p.h: * UIProcess/qt/ClientImpl.cpp: * UIProcess/qt/ClientImpl.h: * UIProcess/qt/QtWebPageProxy.cpp: (QtWebPageProxy::init): * UIProcess/qt/QtWebPageProxy.h: * UIProcess/qt/QtWebPageUIClient.cpp: Added. (QtWebPageUIClient::QtWebPageUIClient): (QtWebPageUIClient::runJavaScriptAlert): (QtWebPageUIClient::runJavaScriptConfirm): (QtWebPageUIClient::runJavaScriptPrompt): (QtWebPageUIClient::runOpenPanel): (QtWebPageUIClient::setStatusText): (QtWebPageUIClient::mouseDidMoveOverElement): (toQtWebPageUIClient): (createNullWKString): * UIProcess/qt/QtWebPageUIClient.h: Added. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Target.pri trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h trunk/Source/WebKit2/UIProcess/qt/ClientImpl.cpp trunk/Source/WebKit2/UIProcess/qt/ClientImpl.h trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h Added Paths trunk/Source/WebKit2/UIProcess/qt/QtWebPageUIClient.cpp trunk/Source/WebKit2/UIProcess/qt/QtWebPageUIClient.h Diff Modified: trunk/Source/WebKit2/ChangeLog (100989 => 100990) --- trunk/Source/WebKit2/ChangeLog 2011-11-22 12:58:20 UTC (rev 100989) +++ trunk/Source/WebKit2/ChangeLog 2011-11-22 13:21:18 UTC (rev 100990) @@ -1,3 +1,37 @@ +2011-11-22 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org + +[Qt] [WK2] Move PageUIClient related code to QtWebPageUIClient +https://bugs.webkit.org/show_bug.cgi?id=72910 + +Reviewed by Andreas Kling. + +Split PageUIClient related code from QtWebPageProxy/ClientImpl. The new +QtWebPageUIClient registers itself with WKPageRef and it's owned by the +QQuickWebViewPrivate. This is a move to clean up QtWebPageProxy object. + +* Target.pri: +* UIProcess/API/qt/qquickwebview.cpp: +(QQuickWebViewPrivate::QQuickWebViewPrivate): +(QQuickWebViewPrivate::chooseFiles): +* UIProcess/API/qt/qquickwebview_p.h: +* UIProcess/API/qt/qquickwebview_p_p.h: +* UIProcess/qt/ClientImpl.cpp: +* UIProcess/qt/ClientImpl.h: +* UIProcess/qt/QtWebPageProxy.cpp: +(QtWebPageProxy::init): +* UIProcess/qt/QtWebPageProxy.h: +* UIProcess/qt/QtWebPageUIClient.cpp: Added. +(QtWebPageUIClient::QtWebPageUIClient): +(QtWebPageUIClient::runJavaScriptAlert): +(QtWebPageUIClient::runJavaScriptConfirm): +(QtWebPageUIClient::runJavaScriptPrompt): +(QtWebPageUIClient::runOpenPanel): +(QtWebPageUIClient::setStatusText): +(QtWebPageUIClient::mouseDidMoveOverElement): +(toQtWebPageUIClient): +(createNullWKString): +* UIProcess/qt/QtWebPageUIClient.h: Added. + 2011-11-22 Eunmi Lee eunmi15@samsung.com [WK2] Modify EFL port's WebEventFactory to use EflKeyboardUtilities's Modified: trunk/Source/WebKit2/Target.pri (100989 => 100990) --- trunk/Source/WebKit2/Target.pri 2011-11-22 12:58:20 UTC (rev 100989) +++ trunk/Source/WebKit2/Target.pri 2011-11-22 13:21:18 UTC (rev 100990) @@ -323,6 +323,7 @@ UIProcess/qt/QtDialogRunner.h \ UIProcess/qt/QtDownloadManager.h \ UIProcess/qt/QtWebPageProxy.h \ +UIProcess/qt/QtWebPageUIClient.h \ UIProcess/qt/qwkhistory.h \ UIProcess/qt/qwkhistory_p.h \ UIProcess/qt/QtSGUpdateQueue.h \ @@ -628,6 +629,7 @@ UIProcess/qt/QtDialogRunner.cpp \ UIProcess/qt/QtDownloadManager.cpp \ UIProcess/qt/QtWebPageProxy.cpp \ +UIProcess/qt/QtWebPageUIClient.cpp \ UIProcess/qt/qwkhistory.cpp \ UIProcess/qt/QtSGUpdateQueue.cpp \ UIProcess/qt/QtSGTileNode.cpp \ Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (100989 => 100990) --- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2011-11-22 12:58:20 UTC (rev 100989) +++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2011-11-22 13:21:18 UTC (rev 100990) @@ -58,6 +58,8 @@ pageProxy-init(); QObject::connect(pageProxy.data(), SIGNAL(updateNavigationState()), q_ptr, SIGNAL(navigationStateChanged())); + +pageUIClient.reset(new QtWebPageUIClient(pageProxy-pageRef(),
[webkit-changes] [100993] trunk/Source/WebCore
Title: [100993] trunk/Source/WebCore
Revision 100993
Author zol...@webkit.org
Date 2011-11-22 05:38:51 -0800 (Tue, 22 Nov 2011)
Log Message
[Qt] Build fix for MHTML support
* Target.pri: Add missing includepath.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri
Diff
Modified: trunk/Source/WebCore/ChangeLog (100992 => 100993)
--- trunk/Source/WebCore/ChangeLog 2011-11-22 13:38:40 UTC (rev 100992)
+++ trunk/Source/WebCore/ChangeLog 2011-11-22 13:38:51 UTC (rev 100993)
@@ -1,3 +1,9 @@
+2011-11-22 Zoltan Horvath zol...@webkit.org
+
+[Qt] Build fix for MHTML support
+
+* Target.pri: Add missing includepath.
+
2011-11-22 Vsevolod Vlasov vse...@chromium.org
Web Inspector: Extract SplitView from Panel.createSidebar() method and reuse in Elements and Scripts panels.
Modified: trunk/Source/WebCore/Target.pri (100992 => 100993)
--- trunk/Source/WebCore/Target.pri 2011-11-22 13:38:40 UTC (rev 100992)
+++ trunk/Source/WebCore/Target.pri 2011-11-22 13:38:51 UTC (rev 100993)
@@ -3817,6 +3817,9 @@
}
contains(DEFINES, ENABLE_MHTML=1) {
+
+INCLUDEPATH += $$PWD/loader/archive/mhtml
+
HEADERS += \
loader/archive/Archive.h \
page/PageSerializer.h
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100992] trunk/Source/WebKit2
Title: [100992] trunk/Source/WebKit2 Revision 100992 Author caio.olive...@openbossa.org Date 2011-11-22 05:38:40 -0800 (Tue, 22 Nov 2011) Log Message [Qt] [WK2] Move PageLoadClient related code to QtWebPageLoadClient https://bugs.webkit.org/show_bug.cgi?id=72928 Reviewed by Andreas Kling. Split PageLoadClient related code from QtWebPageProxy/ClientImpl. The new QtWebPageLoadClient registers itself with WKPageRef and it's owned by the QQuickWebViewPrivate. This is a move to clean up QtWebPageProxy object. * Target.pri: * UIProcess/API/qt/qquickwebview.cpp: (QQuickWebViewPrivate::QQuickWebViewPrivate): (QQuickWebView::loadProgress): * UIProcess/API/qt/qquickwebview_p.h: * UIProcess/API/qt/qquickwebview_p_p.h: * UIProcess/qt/ClientImpl.cpp: * UIProcess/qt/ClientImpl.h: * UIProcess/qt/QtWebPageLoadClient.cpp: Added. (QtWebPageLoadClient::QtWebPageLoadClient): (QtWebPageLoadClient::didStartProvisionalLoadForFrame): (QtWebPageLoadClient::didCommitLoadForFrame): (QtWebPageLoadClient::didSameDocumentNavigationForFrame): (QtWebPageLoadClient::didReceiveTitleForFrame): (QtWebPageLoadClient::didFirstVisuallyNonEmptyLayoutForFrame): (QtWebPageLoadClient::dispatchLoadSucceeded): (QtWebPageLoadClient::dispatchLoadFailed): (QtWebPageLoadClient::setLoadProgress): (toQtWebPageLoadClient): (QtWebPageLoadClient::didFailProvisionalLoadWithErrorForFrame): (QtWebPageLoadClient::didFinishLoadForFrame): (QtWebPageLoadClient::didFailLoadWithErrorForFrame): (QtWebPageLoadClient::didStartProgress): (QtWebPageLoadClient::didChangeProgress): (QtWebPageLoadClient::didFinishProgress): * UIProcess/qt/QtWebPageLoadClient.h: Added. (QtWebPageLoadClient::loadProgress): * UIProcess/qt/QtWebPageProxy.cpp: (QtWebPageProxy::QtWebPageProxy): (QtWebPageProxy::init): (QtWebPageProxy::updateNavigationState): * UIProcess/qt/QtWebPageProxy.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Target.pri trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h trunk/Source/WebKit2/UIProcess/qt/ClientImpl.cpp trunk/Source/WebKit2/UIProcess/qt/ClientImpl.h trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h Added Paths trunk/Source/WebKit2/UIProcess/qt/QtWebPageLoadClient.cpp trunk/Source/WebKit2/UIProcess/qt/QtWebPageLoadClient.h Diff Modified: trunk/Source/WebKit2/ChangeLog (100991 => 100992) --- trunk/Source/WebKit2/ChangeLog 2011-11-22 13:24:48 UTC (rev 100991) +++ trunk/Source/WebKit2/ChangeLog 2011-11-22 13:38:40 UTC (rev 100992) @@ -1,5 +1,49 @@ 2011-11-22 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org +[Qt] [WK2] Move PageLoadClient related code to QtWebPageLoadClient +https://bugs.webkit.org/show_bug.cgi?id=72928 + +Reviewed by Andreas Kling. + +Split PageLoadClient related code from QtWebPageProxy/ClientImpl. The new +QtWebPageLoadClient registers itself with WKPageRef and it's owned by the +QQuickWebViewPrivate. This is a move to clean up QtWebPageProxy object. + +* Target.pri: +* UIProcess/API/qt/qquickwebview.cpp: +(QQuickWebViewPrivate::QQuickWebViewPrivate): +(QQuickWebView::loadProgress): +* UIProcess/API/qt/qquickwebview_p.h: +* UIProcess/API/qt/qquickwebview_p_p.h: +* UIProcess/qt/ClientImpl.cpp: +* UIProcess/qt/ClientImpl.h: +* UIProcess/qt/QtWebPageLoadClient.cpp: Added. +(QtWebPageLoadClient::QtWebPageLoadClient): +(QtWebPageLoadClient::didStartProvisionalLoadForFrame): +(QtWebPageLoadClient::didCommitLoadForFrame): +(QtWebPageLoadClient::didSameDocumentNavigationForFrame): +(QtWebPageLoadClient::didReceiveTitleForFrame): +(QtWebPageLoadClient::didFirstVisuallyNonEmptyLayoutForFrame): +(QtWebPageLoadClient::dispatchLoadSucceeded): +(QtWebPageLoadClient::dispatchLoadFailed): +(QtWebPageLoadClient::setLoadProgress): +(toQtWebPageLoadClient): +(QtWebPageLoadClient::didFailProvisionalLoadWithErrorForFrame): +(QtWebPageLoadClient::didFinishLoadForFrame): +(QtWebPageLoadClient::didFailLoadWithErrorForFrame): +(QtWebPageLoadClient::didStartProgress): +(QtWebPageLoadClient::didChangeProgress): +(QtWebPageLoadClient::didFinishProgress): +* UIProcess/qt/QtWebPageLoadClient.h: Added. +(QtWebPageLoadClient::loadProgress): +* UIProcess/qt/QtWebPageProxy.cpp: +(QtWebPageProxy::QtWebPageProxy): +(QtWebPageProxy::init): +(QtWebPageProxy::updateNavigationState): +* UIProcess/qt/QtWebPageProxy.h: + +2011-11-22 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org + [Qt] [WK2] Move PageUIClient related code to QtWebPageUIClient https://bugs.webkit.org/show_bug.cgi?id=72910 Modified:
[webkit-changes] [100994] trunk/Source/WebCore
Title: [100994] trunk/Source/WebCore
Revision 100994
Author ca...@chromium.org
Date 2011-11-22 05:40:41 -0800 (Tue, 22 Nov 2011)
Log Message
Web Inspector: [Extensions API][refactoring] remove dependencies on the ExtensionsServer from most of the insepctor
https://bugs.webkit.org/show_bug.cgi?id=72899
Reviewed by Pavel Feldman.
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._notifyResourceContentCommitted):
(WebInspector.ExtensionServer.prototype._notifyElementsSelectionChanged):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.addRevision):
* inspector/front-end/externs.js:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ElementsPanel.js
trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js
trunk/Source/WebCore/inspector/front-end/ExtensionServer.js
trunk/Source/WebCore/inspector/front-end/Resource.js
trunk/Source/WebCore/inspector/front-end/ResourceTreeModel.js
trunk/Source/WebCore/inspector/front-end/externs.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (100993 => 100994)
--- trunk/Source/WebCore/ChangeLog 2011-11-22 13:38:51 UTC (rev 100993)
+++ trunk/Source/WebCore/ChangeLog 2011-11-22 13:40:41 UTC (rev 100994)
@@ -1,3 +1,19 @@
+2011-11-21 Andrey Kosyakov ca...@chromium.org
+
+Web Inspector: [Extensions API][refactoring] remove dependencies on the ExtensionsServer from most of the insepctor
+https://bugs.webkit.org/show_bug.cgi?id=72899
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/ElementsPanel.js:
+(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
+* inspector/front-end/ExtensionServer.js:
+(WebInspector.ExtensionServer.prototype._notifyResourceContentCommitted):
+(WebInspector.ExtensionServer.prototype._notifyElementsSelectionChanged):
+* inspector/front-end/Resource.js:
+(WebInspector.Resource.prototype.addRevision):
+* inspector/front-end/externs.js:
+
2011-11-22 Zoltan Horvath zol...@webkit.org
[Qt] Build fix for MHTML support
Modified: trunk/Source/WebCore/inspector/front-end/ElementsPanel.js (100993 => 100994)
--- trunk/Source/WebCore/inspector/front-end/ElementsPanel.js 2011-11-22 13:38:51 UTC (rev 100993)
+++ trunk/Source/WebCore/inspector/front-end/ElementsPanel.js 2011-11-22 13:40:41 UTC (rev 100994)
@@ -177,7 +177,6 @@
if (selectedNode) {
ConsoleAgent.addInspectedNode(selectedNode.id);
-WebInspector.extensionServer.notifyObjectSelected(this.name);
this._lastValidSelectedNode = selectedNode;
}
},
Modified: trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js (100993 => 100994)
--- trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js 2011-11-22 13:38:51 UTC (rev 100993)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js 2011-11-22 13:40:41 UTC (rev 100994)
@@ -48,6 +48,47 @@
Warning: warning,
Error: error
};
+apiPrivate.Events = {
+AuditStarted: audit-started-,
+ButtonClicked: button-clicked-,
+ConsoleMessageAdded: console-message-added,
+ElementsPanelObjectSelected: panel-objectSelected-elements,
+NetworkRequestFinished: network-request-finished,
+Reset: reset,
+OpenResource: open-resource,
+PanelSearch: panel-search-,
+Reload: Reload,
+ResourceAdded: resource-added,
+ResourceContentCommitted: resource-content-committed,
+TimelineEventRecorded: timeline-event-recorded,
+ViewShown: view-shown-,
+ViewHidden: view-hidden-
+};
+apiPrivate.Commands = {
+AddAuditCategory: addAuditCategory,
+AddAuditResult: addAuditResult,
+AddConsoleMessage: addConsoleMessage,
+AddRequestHeaders: addRequestHeaders,
+CreatePanel: createPanel,
+CreateSidebarPane: createSidebarPane,
+CreateStatusBarButton: createStatusBarButton,
+EvaluateOnInspectedPage: evaluateOnInspectedPage,
+GetConsoleMessages: getConsoleMessages,
+GetHAR: getHAR,
+GetPageResources: getPageResources,
+GetRequestContent: getRequestContent,
+GetResourceContent: getResourceContent,
+Subscribe: subscribe,
+SetOpenResourceHandler: setOpenResourceHandler,
+SetResourceContent: setResourceContent,
+SetSidebarContent: setSidebarContent,
+SetSidebarHeight: setSidebarHeight,
+SetSidebarPage: setSidebarPage,
+StopAuditCategoryRun: stopAuditCategoryRun,
+Unsubscribe: unsubscribe,
+UpdateButton: updateButton,
+InspectedURLChanged: inspectedURLChanged
+};
}
function injectedExtensionAPI(injectedScriptId)
@@ -57,6 +98,9 @@
defineCommonExtensionSymbols(apiPrivate);
+var commands =
[webkit-changes] [100995] trunk/Source
Title: [100995] trunk/Source Revision 100995 Author pfeld...@chromium.org Date 2011-11-22 06:11:46 -0800 (Tue, 22 Nov 2011) Log Message Web Inspector: remove Inspector::bringToFront from the protocol. https://bugs.webkit.org/show_bug.cgi?id=72937 Source/WebCore: Inspector::bringToFront protocol method is currently used on the backend in order to reveal the front-end window. We should do that by means of the inspector client interface instead. Reviewed by Yury Semikhatsky. * inspector/Inspector.json: * inspector/InspectorClient.h: * inspector/InspectorController.cpp: (WebCore::InspectorController::show): * loader/EmptyClients.h: (WebCore::EmptyInspectorClient::bringFrontendToFront): Source/WebKit/chromium: Reviewed by Yury Semikhatsky. * src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::bringFrontendToFront): * src/InspectorClientImpl.h: * src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::bringFrontendToFront): * src/WebDevToolsAgentImpl.h: Source/WebKit/efl: Reviewed by Yury Semikhatsky. * WebCoreSupport/InspectorClientEfl.cpp: (WebCore::InspectorClientEfl::bringFrontendToFront): * WebCoreSupport/InspectorClientEfl.h: Source/WebKit/gtk: Reviewed by Yury Semikhatsky. * WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::bringFrontendToFront): * WebCoreSupport/InspectorClientGtk.h: Source/WebKit/mac: Reviewed by Yury Semikhatsky. * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::openInspectorFrontend): (WebInspectorClient::bringFrontendToFront): Source/WebKit/qt: Reviewed by Yury Semikhatsky. * WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::bringFrontendToFront): * WebCoreSupport/InspectorClientQt.h: Source/WebKit/win: Reviewed by Yury Semikhatsky. * WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::bringFrontendToFront): * WebCoreSupport/WebInspectorClient.h: Source/WebKit/wince: Reviewed by Yury Semikhatsky. * WebCoreSupport/InspectorClientWinCE.cpp: (WebKit::InspectorClientWinCE::bringFrontendToFront): * WebCoreSupport/InspectorClientWinCE.h: Source/WebKit/wx: Reviewed by Yury Semikhatsky. * WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClientWx::bringFrontendToFront): * WebKitSupport/InspectorClientWx.h: Source/WebKit2: Reviewed by Yury Semikhatsky. * WebProcess/WebCoreSupport/WebInspectorClient.cpp: (WebKit::WebInspectorClient::openInspectorFrontend): (WebKit::WebInspectorClient::bringFrontendToFront): * WebProcess/WebCoreSupport/WebInspectorClient.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/Inspector.json trunk/Source/WebCore/inspector/InspectorClient.h trunk/Source/WebCore/inspector/InspectorController.cpp trunk/Source/WebCore/inspector/front-end/inspector.js trunk/Source/WebCore/loader/EmptyClients.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp trunk/Source/WebKit/chromium/src/InspectorClientImpl.h trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h trunk/Source/WebKit/efl/ChangeLog trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm trunk/Source/WebKit/qt/ChangeLog trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h trunk/Source/WebKit/win/ChangeLog trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h trunk/Source/WebKit/wince/ChangeLog trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.cpp trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h trunk/Source/WebKit/wx/ChangeLog trunk/Source/WebKit/wx/WebKitSupport/InspectorClientWx.cpp trunk/Source/WebKit/wx/WebKitSupport/InspectorClientWx.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h Diff Modified: trunk/Source/WebCore/ChangeLog (100994 => 100995) --- trunk/Source/WebCore/ChangeLog 2011-11-22 13:40:41 UTC (rev 100994) +++ trunk/Source/WebCore/ChangeLog 2011-11-22 14:11:46 UTC (rev 100995) @@ -1,3 +1,21 @@ +2011-11-22 Pavel Feldman pfeld...@google.com + +Web Inspector: remove Inspector::bringToFront from the protocol. +https://bugs.webkit.org/show_bug.cgi?id=72937 + +Inspector::bringToFront protocol method is currently used on the backend +in order to reveal the front-end window. We should do that by means of +the inspector client interface
[webkit-changes] [100996] trunk/Source/WebKit2
Title: [100996] trunk/Source/WebKit2
Revision 100996
Author commit-qu...@webkit.org
Date 2011-11-22 06:14:17 -0800 (Tue, 22 Nov 2011)
Log Message
[Qt][WK2] Fix and unskip loadHtml api test
https://bugs.webkit.org/show_bug.cgi?id=72916
Patch by Jesus Sanchez-Palencia jesus.palen...@openbossa.org on 2011-11-22
Reviewed by Andreas Kling.
Now that linkHovered events are working again we can fix and unskip this
loadHtml test.
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml
Diff
Modified: trunk/Source/WebKit2/ChangeLog (100995 => 100996)
--- trunk/Source/WebKit2/ChangeLog 2011-11-22 14:11:46 UTC (rev 100995)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-22 14:14:17 UTC (rev 100996)
@@ -1,3 +1,15 @@
+2011-11-22 Jesus Sanchez-Palencia jesus.palen...@openbossa.org
+
+[Qt][WK2] Fix and unskip loadHtml api test
+https://bugs.webkit.org/show_bug.cgi?id=72916
+
+Reviewed by Andreas Kling.
+
+Now that linkHovered events are working again we can fix and unskip this
+loadHtml test.
+
+* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
+
2011-11-22 Pavel Feldman pfeld...@google.com
Web Inspector: remove Inspector::bringToFront from the protocol.
Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml (100995 => 100996)
--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml 2011-11-22 14:11:46 UTC (rev 100995)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml 2011-11-22 14:14:17 UTC (rev 100996)
@@ -7,6 +7,7 @@
id: webView
width: 200
height: 400
+focus: true
property string lastUrl
@@ -29,6 +30,15 @@
TestCase {
name: DesktopWebViewLoadHtml
+// Delayed windowShown to workaround problems with Qt5 in debug mode.
+when: false
+Timer {
+running: parent.windowShown
+repeat: false
+interval: 1
+onTriggered: parent.when = true
+}
+
function init() {
webView.lastUrl =
linkHoveredSpy.clear()
@@ -36,7 +46,6 @@
}
function test_baseUrlAfterLoadHtml() {
-skip(Link Hovered is currently not working)
loadSpy.clear()
linkHoveredSpy.clear()
compare(linkHoveredSpy.count, 0)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100999] trunk/Source/WebCore
Title: [100999] trunk/Source/WebCore
Revision 100999
Author pfeld...@chromium.org
Date 2011-11-22 06:37:41 -0800 (Tue, 22 Nov 2011)
Log Message
2011-11-22 Pavel Feldman pfeld...@google.com
Not reviewed: fix inspector front-end compilation.
* inspector/front-end/externs.js:
(WebInspector.showPanel):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/externs.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (100998 => 100999)
--- trunk/Source/WebCore/ChangeLog 2011-11-22 14:35:04 UTC (rev 100998)
+++ trunk/Source/WebCore/ChangeLog 2011-11-22 14:37:41 UTC (rev 100999)
@@ -1,3 +1,10 @@
+2011-11-22 Pavel Feldman pfeld...@google.com
+
+Not reviewed: fix inspector front-end compilation.
+
+* inspector/front-end/externs.js:
+(WebInspector.showPanel):
+
2011-11-22 Adam Bergkvist adam.bergkv...@ericsson.com
Add WebCore platform interface needed by updated MediaStream API design
Modified: trunk/Source/WebCore/inspector/front-end/externs.js (100998 => 100999)
--- trunk/Source/WebCore/inspector/front-end/externs.js 2011-11-22 14:35:04 UTC (rev 100998)
+++ trunk/Source/WebCore/inspector/front-end/externs.js 2011-11-22 14:37:41 UTC (rev 100999)
@@ -175,3 +175,7 @@
WebInspector.showPanelForAnchorNavigation = function(panel)
{
}
+
+WebInspector.showPanel = function(panel)
+{
+}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101000] trunk/Source/WebCore
Title: [101000] trunk/Source/WebCore
Revision 101000
Author apav...@chromium.org
Date 2011-11-22 06:43:00 -0800 (Tue, 22 Nov 2011)
Log Message
Web Inspector: [SuggestBox] Grayed prompt displayed with non-collapsed selection in place
https://bugs.webkit.org/show_bug.cgi?id=72951
Reviewed by Pavel Feldman.
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.complete):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TextPrompt.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (100999 => 101000)
--- trunk/Source/WebCore/ChangeLog 2011-11-22 14:37:41 UTC (rev 100999)
+++ trunk/Source/WebCore/ChangeLog 2011-11-22 14:43:00 UTC (rev 101000)
@@ -1,3 +1,13 @@
+2011-11-22 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: [SuggestBox] Grayed prompt displayed with non-collapsed selection in place
+https://bugs.webkit.org/show_bug.cgi?id=72951
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/TextPrompt.js:
+(WebInspector.TextPrompt.prototype.complete):
+
2011-11-22 Pavel Feldman pfeld...@google.com
Not reviewed: fix inspector front-end compilation.
Modified: trunk/Source/WebCore/inspector/front-end/TextPrompt.js (100999 => 101000)
--- trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-22 14:37:41 UTC (rev 100999)
+++ trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-22 14:43:00 UTC (rev 101000)
@@ -350,6 +350,8 @@
shouldExit = true;
else if (auto !this._suggestBox !force !this.isCaretAtEndOfPrompt())
shouldExit = true;
+else if (!selection.isCollapsed)
+shouldExit = true;
else if (!force) {
// BUG72018: Do not show suggest box if caret is followed by a non-stop character.
var wordSuffixRange = selectionRange.startContainer.rangeOfWord(selectionRange.endOffset, this._completionStopCharacters, this._element, forward);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101001] trunk/Source/WebKit2
Title: [101001] trunk/Source/WebKit2
Revision 101001
Author pfeld...@chromium.org
Date 2011-11-22 07:18:02 -0800 (Tue, 22 Nov 2011)
Log Message
cvel Feldman pfeld...@google.com
Not reviewed: moving inspector frontend creation out of assert in WebKit2.
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::openInspectorFrontend):lean
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (101000 => 101001)
--- trunk/Source/WebKit2/ChangeLog 2011-11-22 14:43:00 UTC (rev 101000)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-22 15:18:02 UTC (rev 101001)
@@ -1,3 +1,10 @@
+2011-11-22 Pavel Feldman pfeld...@google.com
+
+Not reviewed: moving inspector frontend creation out of assert in WebKit2.
+
+* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
+(WebKit::WebInspectorClient::openInspectorFrontend):
+
2011-11-22 Jesus Sanchez-Palencia jesus.palen...@openbossa.org
[Qt][WK2] Fix and unskip loadHtml api test
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp (101000 => 101001)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp 2011-11-22 14:43:00 UTC (rev 101000)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp 2011-11-22 15:18:02 UTC (rev 101001)
@@ -44,7 +44,8 @@
void WebInspectorClient::openInspectorFrontend(InspectorController*)
{
-ASSERT(m_page-inspector()-createInspectorPage());
+WebPage* inspectorPage = m_page-inspector()-createInspectorPage();
+ASSERT(inspectorPage);
}
void WebInspectorClient::bringFrontendToFront()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101002] trunk
Title: [101002] trunk
Revision 101002
Author commit-qu...@webkit.org
Date 2011-11-22 07:39:57 -0800 (Tue, 22 Nov 2011)
Log Message
Source/WebCore: Spellcheck should be able to run asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=71991
Patch by Shinya Kawanaka shin...@google.com on 2011-11-22
Reviewed by Hajime Morita.
Run asynchronous spell checker if both asynchronous flag and unified text checker flag are ON.
When multiple asynchronous spellchecking are requested, only the first request will be processed.
Test: editing/spelling/spellcheck-async.html
* editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
Uses asynchronous spell checker if asynchronous flag is ON.
LayoutTests: Spellcheck should be able to run asynchronously
https://bugs.webkit.org/show_bug.cgi?id=71991
Patch by Shinya Kawanaka shin...@google.com on 2011-11-22
Reviewed by Hajime Morita.
Added asynchronouse spell checking tests.
Fixed tests that fails tearing down.
* editing/spelling/script-tests/spellcheck-paste.js: Fixed tearing down.
* editing/spelling/spellcheck-async-expected.txt: Added.
* editing/spelling/spellcheck-async.html: Added.
* editing/spelling/spelling-unified-emulation.html: Fixed tearing down.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/spelling/script-tests/spellcheck-paste.js
trunk/LayoutTests/editing/spelling/spelling-unified-emulation.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
Added Paths
trunk/LayoutTests/editing/spelling/spellcheck-async-expected.txt
trunk/LayoutTests/editing/spelling/spellcheck-async.html
Diff
Modified: trunk/LayoutTests/ChangeLog (101001 => 101002)
--- trunk/LayoutTests/ChangeLog 2011-11-22 15:18:02 UTC (rev 101001)
+++ trunk/LayoutTests/ChangeLog 2011-11-22 15:39:57 UTC (rev 101002)
@@ -1,3 +1,18 @@
+2011-11-22 Shinya Kawanaka shin...@google.com
+
+Spellcheck should be able to run asynchronously
+https://bugs.webkit.org/show_bug.cgi?id=71991
+
+Reviewed by Hajime Morita.
+
+Added asynchronouse spell checking tests.
+Fixed tests that fails tearing down.
+
+* editing/spelling/script-tests/spellcheck-paste.js: Fixed tearing down.
+* editing/spelling/spellcheck-async-expected.txt: Added.
+* editing/spelling/spellcheck-async.html: Added.
+* editing/spelling/spelling-unified-emulation.html: Fixed tearing down.
+
2011-11-22 Vsevolod Vlasov vse...@chromium.org
Web Inspector: Extract SplitView from Panel.createSidebar() method and reuse in Elements and Scripts panels.
Modified: trunk/LayoutTests/editing/spelling/script-tests/spellcheck-paste.js (101001 => 101002)
--- trunk/LayoutTests/editing/spelling/script-tests/spellcheck-paste.js 2011-11-22 15:18:02 UTC (rev 101001)
+++ trunk/LayoutTests/editing/spelling/script-tests/spellcheck-paste.js 2011-11-22 15:39:57 UTC (rev 101002)
@@ -39,6 +39,8 @@
if (next)
return window.setTimeout(next, 0);
testRoot.style.display = none;
+
+layoutTestController.setAsynchronousSpellCheckingEnabled(false);
layoutTestController.notifyDone();
}
Added: trunk/LayoutTests/editing/spelling/spellcheck-async-expected.txt (0 => 101002)
--- trunk/LayoutTests/editing/spelling/spellcheck-async-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/spelling/spellcheck-async-expected.txt 2011-11-22 15:39:57 UTC (rev 101002)
@@ -0,0 +1,18 @@
+Test for Unified Spell Checker Async Spell Checker.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS text : zz has markers: [zz]
+PASS text : apple,zz,orange has markers: [zz]
+PASS text : zz,zz has markers: [zz,zz]
+PASS text : zz zz zz has markers: [zz,zz,zz]
+PASS text : zz zz zz has markers: [zz,zz,zz]
+PASS text : zz apple orange has markers: [zz]
+PASS text : apple zz orange has markers: [zz]
+PASS text : apple orange zz has markers: [zz]
+PASS text : zzz has markers: []
+PASS text : I would like to sleep, zzz has markers: []
+
Added: trunk/LayoutTests/editing/spelling/spellcheck-async.html (0 => 101002)
--- trunk/LayoutTests/editing/spelling/spellcheck-async.html (rev 0)
+++ trunk/LayoutTests/editing/spelling/spellcheck-async.html 2011-11-22 15:39:57 UTC (rev 101002)
@@ -0,0 +1,136 @@
+!DOCTYPE html
+html
+head
+link rel=stylesheet href=""
+script src=""
+script src=""
+style
+.editing {
+border: 2px solid red;
+padding: 6px;
+font-size: 18px;
+}
+/style
+/head
+body
+pre id=description/pre
+pre id=console/pre
+div id=container/div
+
+script
+description(Test for Unified Spell Checker Async Spell Checker.);
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.setAsynchronousSpellCheckingEnabled(true);
+layoutTestController.waitUntilDone();
+}
+
+if (window.internals)
+
[webkit-changes] [101003] trunk/Source/WebKit2
Title: [101003] trunk/Source/WebKit2
Revision 101003
Author o...@webkit.org
Date 2011-11-22 07:40:52 -0800 (Tue, 22 Nov 2011)
Log Message
Unreviewed buildfix after r101001.
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::openInspectorFrontend): Use ASSERT_UNUSED instead of ASSERT.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (101002 => 101003)
--- trunk/Source/WebKit2/ChangeLog 2011-11-22 15:39:57 UTC (rev 101002)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-22 15:40:52 UTC (rev 101003)
@@ -1,3 +1,10 @@
+2011-11-22 Csaba Osztrogonác o...@webkit.org
+
+Unreviewed buildfix after r101001.
+
+* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
+(WebKit::WebInspectorClient::openInspectorFrontend): Use ASSERT_UNUSED instead of ASSERT.
+
2011-11-22 Pavel Feldman pfeld...@google.com
Not reviewed: moving inspector frontend creation out of assert in WebKit2.
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp (101002 => 101003)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp 2011-11-22 15:39:57 UTC (rev 101002)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp 2011-11-22 15:40:52 UTC (rev 101003)
@@ -45,7 +45,7 @@
void WebInspectorClient::openInspectorFrontend(InspectorController*)
{
WebPage* inspectorPage = m_page-inspector()-createInspectorPage();
-ASSERT(inspectorPage);
+ASSERT_UNUSED(inspectorPage, inspectorPage);
}
void WebInspectorClient::bringFrontendToFront()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101004] trunk/Source/WebKit2
Title: [101004] trunk/Source/WebKit2
Revision 101004
Author carlo...@webkit.org
Date 2011-11-22 08:43:21 -0800 (Tue, 22 Nov 2011)
Log Message
Ensure web process before starting a download
https://bugs.webkit.org/show_bug.cgi?id=72499
Reviewed by Anders Carlsson.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::download): Call ensureWebProcess().
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebContext.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (101003 => 101004)
--- trunk/Source/WebKit2/ChangeLog 2011-11-22 15:40:52 UTC (rev 101003)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-22 16:43:21 UTC (rev 101004)
@@ -1,3 +1,13 @@
+2011-11-22 Carlos Garcia Campos cgar...@igalia.com
+
+Ensure web process before starting a download
+https://bugs.webkit.org/show_bug.cgi?id=72499
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::download): Call ensureWebProcess().
+
2011-11-22 Csaba Osztrogonác o...@webkit.org
Unreviewed buildfix after r101001.
Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (101003 => 101004)
--- trunk/Source/WebKit2/UIProcess/WebContext.cpp 2011-11-22 15:40:52 UTC (rev 101003)
+++ trunk/Source/WebKit2/UIProcess/WebContext.cpp 2011-11-22 16:43:21 UTC (rev 101004)
@@ -401,6 +401,8 @@
DownloadProxy* WebContext::download(WebPageProxy* initiatingPage, const ResourceRequest request)
{
+ensureWebProcess();
+
DownloadProxy* download = createDownloadProxy();
uint64_t initiatingPageID = initiatingPage ? initiatingPage-pageID() : 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101005] trunk/Tools
Title: [101005] trunk/Tools
Revision 101005
Author aro...@apple.com
Date 2011-11-22 08:52:44 -0800 (Tue, 22 Nov 2011)
Log Message
Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files
Fixes http://webkit.org/b/57008 prepare-ChangeLog doesn't find names of modified
classes/methods in Python source files
Reviewed by Dan Bates.
* Scripts/prepare-ChangeLog:
(get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
or that use python as their interpreter. Modified the code that extracts the interpreter to
ignore a leading /usr/bin/env in the interpreter line, as is common for our Python
scripts.
(get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
for class/def lines and generate ranges based on them.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/prepare-ChangeLog
Diff
Modified: trunk/Tools/ChangeLog (101004 => 101005)
--- trunk/Tools/ChangeLog 2011-11-22 16:43:21 UTC (rev 101004)
+++ trunk/Tools/ChangeLog 2011-11-22 16:52:44 UTC (rev 101005)
@@ -1,3 +1,20 @@
+2011-11-22 Adam Roben aro...@apple.com
+
+Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files
+
+Fixes http://webkit.org/b/57008 prepare-ChangeLog doesn't find names of modified
+classes/methods in Python source files
+
+Reviewed by Dan Bates.
+
+* Scripts/prepare-ChangeLog:
+(get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
+or that use python as their interpreter. Modified the code that extracts the interpreter to
+ignore a leading /usr/bin/env in the interpreter line, as is common for our Python
+scripts.
+(get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
+for class/def lines and generate ranges based on them.
+
2011-11-21 Yuta Kitamura yu...@chromium.org
[GTK] Enable WebSocket hybi tests
Modified: trunk/Tools/Scripts/prepare-ChangeLog (101004 => 101005)
--- trunk/Tools/Scripts/prepare-ChangeLog 2011-11-22 16:43:21 UTC (rev 101004)
+++ trunk/Tools/Scripts/prepare-ChangeLog 2011-11-22 16:52:44 UTC (rev 101005)
@@ -499,16 +499,18 @@
return get_function_line_ranges_for_javascript($file_handle, $file_name) if $file_name =~ /\.js$/;
return get_selector_line_ranges_for_css($file_handle, $file_name) if $file_name =~ /\.css$/;
return get_function_line_ranges_for_perl($file_handle, $file_name) if $file_name =~ /\.p[lm]$/;
+return get_function_line_ranges_for_python($file_handle, $file_name) if $file_name =~ /\.py$/;
# Try to determine the source language based on the script interpreter.
my $first_line = $file_handle;
seek($file_handle, 0, 0);
-return () unless $first_line =~ /^#!(\S+)/;
+return () unless $first_line =~ m|^#!(?:/usr/bin/env\s+)?(\S+)|;
my $interpreter = $1;
return get_function_line_ranges_for_perl($file_handle, $file_name) if $interpreter =~ /perl$/;
+return get_function_line_ranges_for_python($file_handle, $file_name) if $interpreter =~ /python$/;
return ();
}
@@ -1246,6 +1248,62 @@
return @ranges;
}
+# Read a file and get all the line ranges of the things that look like Python classes, methods, or functions.
+#
+# FIXME: Maybe we should use Python's ast module to do the parsing for us?
+#
+# Result is a list of triples: [ start_line, end_line, function ].
+
+sub get_function_line_ranges_for_python($$)
+{
+my ($fileHandle, $fileName) = @_;
+
+my @ranges;
+
+my @scopeStack = ({ line = 0, indent = -1, name = undef });
+while ($fileHandle) {
+next unless /^(\s*)(\S.*)$/;
+my $indent = length $1;
+my $rest = $2;
+
+my $scope = $scopeStack[-1];
+
+if ($indent = $scope-{indent}) {
+# Find all the scopes that we have just exited.
+my $i = 0;
+for (; $i @scopeStack; ++$i) {
+last if $indent = $scopeStack[$i]-{indent};
+}
+my @poppedScopes = splice @scopeStack, $i;
+
+# For each scope that was just exited, add a range that goes from the start of that
+# scope to the start of the next nested scope, or to the line just before this one for
+# the innermost scope.
+for ($i = 0; $i @poppedScopes; ++$i) {
+my $lineAfterEnd = $i + 1 == @poppedScopes ? $. : $poppedScopes[$i + 1]-{line};
+push @ranges, [$poppedScopes[$i]-{line}, $lineAfterEnd - 1, $poppedScopes[$i]-{name}];
+}
+@scopeStack or warn Popped off last scope at $fileName:$.\n;
+
+# Set the now-current scope to start at the current line. Any lines within this scope
+# before this point should already have been added to @ranges.
+$scope = $scopeStack[-1];
+$scope-{line} = $.;
+}
+
[webkit-changes] [101006] trunk/Tools
Title: [101006] trunk/Tools
Revision 101006
Author aro...@apple.com
Date 2011-11-22 09:03:17 -0800 (Tue, 22 Nov 2011)
Log Message
Remove some debugging code I accidentally left in r101005
* Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_python):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/prepare-ChangeLog
Diff
Modified: trunk/Tools/ChangeLog (101005 => 101006)
--- trunk/Tools/ChangeLog 2011-11-22 16:52:44 UTC (rev 101005)
+++ trunk/Tools/ChangeLog 2011-11-22 17:03:17 UTC (rev 101006)
@@ -1,5 +1,12 @@
2011-11-22 Adam Roben aro...@apple.com
+Remove some debugging code I accidentally left in r101005
+
+* Scripts/prepare-ChangeLog:
+(get_function_line_ranges_for_python):
+
+2011-11-22 Adam Roben aro...@apple.com
+
Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files
Fixes http://webkit.org/b/57008 prepare-ChangeLog doesn't find names of modified
Modified: trunk/Tools/Scripts/prepare-ChangeLog (101005 => 101006)
--- trunk/Tools/Scripts/prepare-ChangeLog 2011-11-22 16:52:44 UTC (rev 101005)
+++ trunk/Tools/Scripts/prepare-ChangeLog 2011-11-22 17:03:17 UTC (rev 101006)
@@ -1298,9 +1298,6 @@
push @scopeStack, { line = $., indent = $indent, name = $fullName };
}
-foreach my $range (@ranges) {
-printf %3d:%3d %s\n, $range-[0], $range-[1], $range-[2];
-}
return @ranges;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101007] trunk/Source/WebCore
Title: [101007] trunk/Source/WebCore
Revision 101007
Author commit-qu...@webkit.org
Date 2011-11-22 09:39:54 -0800 (Tue, 22 Nov 2011)
Log Message
CSSStyleDeclaration: Kill FIXME in setProperty().
http://webkit.org/b/72958
Patch by Andreas Kling kl...@webkit.org on 2011-11-22
Reviewed by Antonio Gomes.
Remove FIXME about possibly throwing an exception when setProperty()
is called with an invalid property name. CSSOM specifies that the
method should simply return in this case.
Spec: http://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-setproperty
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::setProperty):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleDeclaration.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (101006 => 101007)
--- trunk/Source/WebCore/ChangeLog 2011-11-22 17:03:17 UTC (rev 101006)
+++ trunk/Source/WebCore/ChangeLog 2011-11-22 17:39:54 UTC (rev 101007)
@@ -1,3 +1,19 @@
+2011-11-22 Andreas Kling kl...@webkit.org
+
+CSSStyleDeclaration: Kill FIXME in setProperty().
+http://webkit.org/b/72958
+
+Reviewed by Antonio Gomes.
+
+Remove FIXME about possibly throwing an exception when setProperty()
+is called with an invalid property name. CSSOM specifies that the
+method should simply return in this case.
+
+Spec: http://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-setproperty
+
+* css/CSSStyleDeclaration.cpp:
+(WebCore::CSSStyleDeclaration::setProperty):
+
2011-11-22 Shinya Kawanaka shin...@google.com
Spellcheck should be able to run asynchronously.
Modified: trunk/Source/WebCore/css/CSSStyleDeclaration.cpp (101006 => 101007)
--- trunk/Source/WebCore/css/CSSStyleDeclaration.cpp 2011-11-22 17:03:17 UTC (rev 101006)
+++ trunk/Source/WebCore/css/CSSStyleDeclaration.cpp 2011-11-22 17:39:54 UTC (rev 101007)
@@ -107,10 +107,8 @@
void CSSStyleDeclaration::setProperty(const String propertyName, const String value, const String priority, ExceptionCode ec)
{
int propID = cssPropertyID(propertyName);
-if (!propID) {
-// FIXME: Should we raise an exception here?
+if (!propID)
return;
-}
bool important = priority.find(important, 0, false) != notFound;
setProperty(propID, value, important, ec);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101008] trunk/Source/WebCore
Title: [101008] trunk/Source/WebCore
Revision 101008
Author commit-qu...@webkit.org
Date 2011-11-22 09:42:42 -0800 (Tue, 22 Nov 2011)
Log Message
CSSProperty: Remove unnecessary operator overloads.
http://webkit.org/b/72953
Patch by Andreas Kling kl...@webkit.org on 2011-11-22
Reviewed by Antti Koivisto.
* css/CSSProperty.cpp:
* css/CSSProperty.h:
Remove operator= and operator== from CSSProperty. They were neither
implemented correctly nor used anywhere.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSProperty.cpp
trunk/Source/WebCore/css/CSSProperty.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (101007 => 101008)
--- trunk/Source/WebCore/ChangeLog 2011-11-22 17:39:54 UTC (rev 101007)
+++ trunk/Source/WebCore/ChangeLog 2011-11-22 17:42:42 UTC (rev 101008)
@@ -1,5 +1,18 @@
2011-11-22 Andreas Kling kl...@webkit.org
+CSSProperty: Remove unnecessary operator overloads.
+http://webkit.org/b/72953
+
+Reviewed by Antti Koivisto.
+
+* css/CSSProperty.cpp:
+* css/CSSProperty.h:
+
+Remove operator= and operator== from CSSProperty. They were neither
+implemented correctly nor used anywhere.
+
+2011-11-22 Andreas Kling kl...@webkit.org
+
CSSStyleDeclaration: Kill FIXME in setProperty().
http://webkit.org/b/72958
Modified: trunk/Source/WebCore/css/CSSProperty.cpp (101007 => 101008)
--- trunk/Source/WebCore/css/CSSProperty.cpp 2011-11-22 17:39:54 UTC (rev 101007)
+++ trunk/Source/WebCore/css/CSSProperty.cpp 2011-11-22 17:42:42 UTC (rev 101008)
@@ -32,11 +32,6 @@
return String(getPropertyName(static_castCSSPropertyID(id( + : + m_value-cssText() + (isImportant() ? !important : ) + ; ;
}
-bool operator==(const CSSProperty a, const CSSProperty b)
-{
-return a.m_id == b.m_id a.m_important == b.m_important a.m_value == b.m_value;
-}
-
enum LogicalBoxSide { BeforeSide, EndSide, AfterSide, StartSide };
enum PhysicalBoxSide { TopSide, RightSide, BottomSide, LeftSide };
Modified: trunk/Source/WebCore/css/CSSProperty.h (101007 => 101008)
--- trunk/Source/WebCore/css/CSSProperty.h 2011-11-22 17:39:54 UTC (rev 101007)
+++ trunk/Source/WebCore/css/CSSProperty.h 2011-11-22 17:42:42 UTC (rev 101008)
@@ -42,16 +42,6 @@
{
}
-CSSProperty operator=(const CSSProperty other)
-{
-m_id = other.m_id;
-m_shorthandID = other.m_shorthandID;
-m_important = other.m_important;
-m_implicit = other.m_implicit;
-m_value = other.m_value;
-return *this;
-}
-
int id() const { return m_id; }
int shorthandID() const { return m_shorthandID; }
@@ -66,8 +56,6 @@
static int resolveDirectionAwareProperty(int propertyID, TextDirection, WritingMode);
static bool isInheritedProperty(unsigned propertyID);
-friend bool operator==(const CSSProperty, const CSSProperty);
-
// Make sure the following fits in 4 bytes. Really.
unsigned m_id : 14;
unsigned m_shorthandID : 14; // If this property was set as part of a shorthand, gives the shorthand.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101010] trunk/LayoutTests
Title: [101010] trunk/LayoutTests Revision 101010 Author ad...@chromium.org Date 2011-11-22 10:10:47 -0800 (Tue, 22 Nov 2011) Log Message Layout Test inspector/extensions/extensions-events.html is timing out https://bugs.webkit.org/show_bug.cgi?id=72966 Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (101009 => 101010) --- trunk/LayoutTests/ChangeLog 2011-11-22 17:55:43 UTC (rev 101009) +++ trunk/LayoutTests/ChangeLog 2011-11-22 18:10:47 UTC (rev 101010) @@ -1,5 +1,14 @@ 2011-11-22 Adam Klein ad...@chromium.org +Layout Test inspector/extensions/extensions-events.html is timing out +https://bugs.webkit.org/show_bug.cgi?id=72966 + +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + +2011-11-22 Adam Klein ad...@chromium.org + Rebaselines after Skia roll (http://crrev.com/51). Unreviewed gardening. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101009 => 101010) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-22 17:55:43 UTC (rev 101009) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-22 18:10:47 UTC (rev 101010) @@ -3712,6 +3712,7 @@ BUGWK71282 WIN DEBUG : http/tests/inspector/extensions-headers.html = CRASH PASS TIMEOUT BUGWK71282 WIN DEBUG : http/tests/inspector/extensions-network-redirect.html = CRASH PASS TIMEOUT BUGWK71282 WIN DEBUG : http/tests/inspector/extensions-useragent.html = CRASH PASS TIMEOUT +BUGWK72966 WIN LINUX RELEASE : inspector/extensions/extensions-events.html = TIMEOUT BUGWK71084 WIN DEBUG SLOW : http/tests/inspector/extensions-ignore-cache.html = PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101011] trunk/Source/WebKit/chromium
Title: [101011] trunk/Source/WebKit/chromium
Revision 101011
Author dpra...@chromium.org
Date 2011-11-22 10:30:20 -0800 (Tue, 22 Nov 2011)
Log Message
Roll Chromium DEPS to r110960 and set the disable_nacl flag.
https://bugs.webkit.org/show_bug.cgi?id=72911
Unreviewed, build fix.
ppapi starts to depend on the NaCl gyp files as of r109739, so
we need to pass disable_nacl when running gyp to avoid pulling
in too much of NaCl.
* DEPS:
* gyp_webkit:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
trunk/Source/WebKit/chromium/gyp_webkit
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (101010 => 101011)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-22 18:10:47 UTC (rev 101010)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-22 18:30:20 UTC (rev 101011)
@@ -1,3 +1,17 @@
+2011-11-22 Dirk Pranke dpra...@chromium.org
+
+Roll Chromium DEPS to r110960 and set the disable_nacl flag.
+https://bugs.webkit.org/show_bug.cgi?id=72911
+
+Unreviewed, build fix.
+
+ppapi starts to depend on the NaCl gyp files as of r109739, so
+we need to pass disable_nacl when running gyp to avoid pulling
+in too much of NaCl.
+
+* DEPS:
+* gyp_webkit:
+
2011-11-22 Pavel Feldman pfeld...@google.com
Web Inspector: [chromium] fix internactive ui test for scripts panel.
Modified: trunk/Source/WebKit/chromium/DEPS (101010 => 101011)
--- trunk/Source/WebKit/chromium/DEPS 2011-11-22 18:10:47 UTC (rev 101010)
+++ trunk/Source/WebKit/chromium/DEPS 2011-11-22 18:30:20 UTC (rev 101011)
@@ -32,7 +32,9 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '109696'
+ 'chromium_rev': '110359',
+ 'nacl_svn': 'http://src.chromium.org/native_client/trunk',
+ 'nacl_rev': '7169',
}
deps = {
@@ -93,6 +95,8 @@
Var('chromium_svn')+'/ipc@'+Var('chromium_rev'),
'media':
Var('chromium_svn')+'/media@'+Var('chromium_rev'),
+ 'native_client/build':
+Var('nacl_svn')+'/src/native_client/build@'+Var('nacl_rev'),
'printing':
Var('chromium_svn')+'/printing@'+Var('chromium_rev'),
'ppapi':
Modified: trunk/Source/WebKit/chromium/gyp_webkit (101010 => 101011)
--- trunk/Source/WebKit/chromium/gyp_webkit 2011-11-22 18:10:47 UTC (rev 101010)
+++ trunk/Source/WebKit/chromium/gyp_webkit 2011-11-22 18:30:20 UTC (rev 101011)
@@ -119,6 +119,7 @@
'-Dinside_chromium_build=0',
'-Dv8_use_snapshot=false',
'-Dmsvs_use_common_release=0',
+ '-Ddisable_nacl=1',
# WebKit doesn't use the chromium style checker.
'-Dmake_clang_dir=Source/WebKit/chromium/third_party/llvm-build/Release+Asserts',
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101012] trunk/Source/WebCore
Title: [101012] trunk/Source/WebCore Revision 101012 Author ad...@chromium.org Date 2011-11-22 10:33:03 -0800 (Tue, 22 Nov 2011) Log Message Move splitView.css (added in r100991) to the correct target. * WebCore.gypi: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi Diff Modified: trunk/Source/WebCore/ChangeLog (101011 => 101012) --- trunk/Source/WebCore/ChangeLog 2011-11-22 18:30:20 UTC (rev 101011) +++ trunk/Source/WebCore/ChangeLog 2011-11-22 18:33:03 UTC (rev 101012) @@ -1,3 +1,9 @@ +2011-11-22 Adam Klein ad...@chromium.org + +Move splitView.css (added in r100991) to the correct target. + +* WebCore.gypi: + 2011-11-22 Andreas Kling kl...@webkit.org CSSProperty: Remove unnecessary operator overloads. Modified: trunk/Source/WebCore/WebCore.gypi (101011 => 101012) --- trunk/Source/WebCore/WebCore.gypi 2011-11-22 18:30:20 UTC (rev 101011) +++ trunk/Source/WebCore/WebCore.gypi 2011-11-22 18:33:03 UTC (rev 101012) @@ -6414,7 +6414,6 @@ 'inspector/front-end/SplitView.js', 'inspector/front-end/StatusBarButton.js', 'inspector/front-end/StylesSidebarPane.js', -'inspector/front-end/splitView.css', 'inspector/front-end/TabbedPane.js', 'inspector/front-end/TestController.js', 'inspector/front-end/TextEditorHighlighter.js', @@ -6459,6 +6458,7 @@ 'inspector/front-end/resourceView.css', 'inspector/front-end/resourcesPanel.css', 'inspector/front-end/scriptsPanel.css', +'inspector/front-end/splitView.css', 'inspector/front-end/textPrompt.css', 'inspector/front-end/textViewer.css', 'inspector/front-end/timelinePanel.css', ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101013] trunk
Title: [101013] trunk Revision 101013 Author commit-qu...@webkit.org Date 2011-11-22 10:35:41 -0800 (Tue, 22 Nov 2011) Log Message Fix .dir-locals.el to only apply to specific modes https://bugs.webkit.org/show_bug.cgi?id=72963 Patch by Andy Wingo wi...@igalia.com on 2011-11-22 Reviewed by Xan Lopez. * .dir-locals.el: Remove `nil' block, as it was causing makefile-mode not to insert tabs. Modified Paths trunk/.dir-locals.el trunk/ChangeLog Diff Modified: trunk/.dir-locals.el (101012 => 101013) --- trunk/.dir-locals.el 2011-11-22 18:33:03 UTC (rev 101012) +++ trunk/.dir-locals.el 2011-11-22 18:35:41 UTC (rev 101013) @@ -2,12 +2,9 @@ ;; Syntax: ((MODE (VAR . VAL) ...) ...) ;; MODE is a symbol like `c-mode', or `nil' for all modes. -((nil +((c-mode (indent-tabs-mode . nil) (c-basic-offset . 4)) - (c-mode - (indent-tabs-mode . nil) - (c-basic-offset . 4)) (c++-mode (indent-tabs-mode . nil) (c-basic-offset . 4)) Modified: trunk/ChangeLog (101012 => 101013) --- trunk/ChangeLog 2011-11-22 18:33:03 UTC (rev 101012) +++ trunk/ChangeLog 2011-11-22 18:35:41 UTC (rev 101013) @@ -1,3 +1,13 @@ +2011-11-22 Andy Wingo wi...@igalia.com + +Fix .dir-locals.el to only apply to specific modes +https://bugs.webkit.org/show_bug.cgi?id=72963 + +Reviewed by Xan Lopez. + +* .dir-locals.el: Remove `nil' block, as it was causing +makefile-mode not to insert tabs. + 2011-11-21 Adam Klein ad...@chromium.org Add GYP-generated WTF.xcodeproj to .gitignore after r100851. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101014] trunk
Title: [101014] trunk
Revision 101014
Author ca...@chromium.org
Date 2011-11-22 10:37:53 -0800 (Tue, 22 Nov 2011)
Log Message
Layout Test inspector/extensions/extensions-events.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=72966
Reviewed by Pavel Feldman.
- always bind to {add,remove}EventListener() of event target, not WebInspector.Object
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._registerAutosubscriptionHandler):
Modified Paths
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ExtensionServer.js
Diff
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101013 => 101014)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-22 18:35:41 UTC (rev 101013)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-22 18:37:53 UTC (rev 101014)
@@ -3712,7 +3712,6 @@
BUGWK71282 WIN DEBUG : http/tests/inspector/extensions-headers.html = CRASH PASS TIMEOUT
BUGWK71282 WIN DEBUG : http/tests/inspector/extensions-network-redirect.html = CRASH PASS TIMEOUT
BUGWK71282 WIN DEBUG : http/tests/inspector/extensions-useragent.html = CRASH PASS TIMEOUT
-BUGWK72966 WIN LINUX RELEASE : inspector/extensions/extensions-events.html = TIMEOUT
BUGWK71084 WIN DEBUG SLOW : http/tests/inspector/extensions-ignore-cache.html = PASS
Modified: trunk/Source/WebCore/ChangeLog (101013 => 101014)
--- trunk/Source/WebCore/ChangeLog 2011-11-22 18:35:41 UTC (rev 101013)
+++ trunk/Source/WebCore/ChangeLog 2011-11-22 18:37:53 UTC (rev 101014)
@@ -1,3 +1,15 @@
+2011-11-22 Andrey Kosyakov ca...@chromium.org
+
+Layout Test inspector/extensions/extensions-events.html is timing out
+https://bugs.webkit.org/show_bug.cgi?id=72966
+
+Reviewed by Pavel Feldman.
+
+- always bind to {add,remove}EventListener() of event target, not WebInspector.Object
+
+* inspector/front-end/ExtensionServer.js:
+(WebInspector.ExtensionServer.prototype._registerAutosubscriptionHandler):
+
2011-11-22 Adam Klein ad...@chromium.org
Move splitView.css (added in r100991) to the correct target.
Modified: trunk/Source/WebCore/inspector/front-end/ExtensionServer.js (101013 => 101014)
--- trunk/Source/WebCore/inspector/front-end/ExtensionServer.js 2011-11-22 18:35:41 UTC (rev 101013)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionServer.js 2011-11-22 18:37:53 UTC (rev 101014)
@@ -672,8 +672,8 @@
_registerAutosubscriptionHandler: function(eventTopic, eventTarget, frontendEventType, handler)
{
this._registerSubscriptionHandler(eventTopic,
-WebInspector.Object.prototype.addEventListener.bind(eventTarget, frontendEventType, handler, this),
-WebInspector.Object.prototype.removeEventListener.bind(eventTarget, frontendEventType, handler, this));
+eventTarget.addEventListener.bind(eventTarget, frontendEventType, handler, this),
+eventTarget.removeEventListener.bind(eventTarget, frontendEventType, handler, this));
},
_expandResourcePath: function(extensionPath, resourcePath)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101015] trunk/LayoutTests
Title: [101015] trunk/LayoutTests Revision 101015 Author ad...@chromium.org Date 2011-11-22 10:55:34 -0800 (Tue, 22 Nov 2011) Log Message Mark some tests as passing after Skia roll in http://crrev.com/51. Unreviewed gardening. * platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.alpha-expected.txt: Removed. * platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.basic-expected.txt: Removed. * platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.transparent.2-expected.txt: Removed. * platform/chromium-mac/canvas/philip/tests/2d.shadow.image.alpha-expected.txt: Removed. * platform/chromium-mac/canvas/philip/tests/2d.shadow.image.basic-expected.txt: Removed. * platform/chromium-mac/canvas/philip/tests/2d.shadow.image.scale-expected.txt: Removed. * platform/chromium-mac/canvas/philip/tests/2d.shadow.image.transparent.2-expected.txt: Removed. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Removed Paths trunk/LayoutTests/platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.alpha-expected.txt trunk/LayoutTests/platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.basic-expected.txt trunk/LayoutTests/platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.transparent.2-expected.txt trunk/LayoutTests/platform/chromium-mac/canvas/philip/tests/2d.shadow.image.alpha-expected.txt trunk/LayoutTests/platform/chromium-mac/canvas/philip/tests/2d.shadow.image.basic-expected.txt trunk/LayoutTests/platform/chromium-mac/canvas/philip/tests/2d.shadow.image.scale-expected.txt trunk/LayoutTests/platform/chromium-mac/canvas/philip/tests/2d.shadow.image.transparent.2-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (101014 => 101015) --- trunk/LayoutTests/ChangeLog 2011-11-22 18:37:53 UTC (rev 101014) +++ trunk/LayoutTests/ChangeLog 2011-11-22 18:55:34 UTC (rev 101015) @@ -1,5 +1,20 @@ 2011-11-22 Adam Klein ad...@chromium.org +Mark some tests as passing after Skia roll in http://crrev.com/51. + +Unreviewed gardening. + +* platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.alpha-expected.txt: Removed. +* platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.basic-expected.txt: Removed. +* platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.transparent.2-expected.txt: Removed. +* platform/chromium-mac/canvas/philip/tests/2d.shadow.image.alpha-expected.txt: Removed. +* platform/chromium-mac/canvas/philip/tests/2d.shadow.image.basic-expected.txt: Removed. +* platform/chromium-mac/canvas/philip/tests/2d.shadow.image.scale-expected.txt: Removed. +* platform/chromium-mac/canvas/philip/tests/2d.shadow.image.transparent.2-expected.txt: Removed. +* platform/chromium/test_expectations.txt: + +2011-11-22 Adam Klein ad...@chromium.org + Layout Test inspector/extensions/extensions-events.html is timing out https://bugs.webkit.org/show_bug.cgi?id=72966 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101014 => 101015) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-22 18:37:53 UTC (rev 101014) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-22 18:55:34 UTC (rev 101015) @@ -2032,13 +2032,7 @@ BUGWK45991 LINUX WIN : canvas/philip/tests/2d.pattern.paint.norepeat.coord3.html = TEXT BUGWK45991 LINUX WIN : canvas/philip/tests/2d.pattern.paint.repeatx.coord1.html = TEXT BUGWK45991 LINUX WIN : canvas/philip/tests/2d.pattern.paint.repeaty.coord1.html = TEXT -BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.canvas.basic.html = TEXT -BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.canvas.transparent.2.html = TEXT BUGWK45991 LINUX WIN CPU : canvas/philip/tests/2d.shadow.enable.blur.html = TEXT -BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.image.alpha.html = TEXT -BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.image.basic.html = TEXT -BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.image.scale.html = TEXT -BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.image.transparent.2.html = TEXT BUGWK45991 LINUX WIN CPU : canvas/philip/tests/2d.transformation.setTransform.skewed.html = TEXT BUGWK45991 LINUX WIN CPU : canvas/philip/tests/2d.transformation.transform.skewed.html = TEXT @@ -3457,8 +3451,6 @@ // We don't seem to load this glyph on windows BUGJAMESR WIN : fast/text/fallback-traits-fixup.html = IMAGE+TEXT -BUGWK67515 LINUX WIN : canvas/philip/tests/2d.shadow.canvas.alpha.html = TEXT - BUGCR54348 LINUX RELEASE : http/tests/security/xssAuditor/dom-write-innerHTML.html = PASS TEXT BUGWK67538 DEBUG : http/tests/security/xssAuditor/dom-write-innerHTML.html = PASS TEXT Deleted: trunk/LayoutTests/platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.alpha-expected.txt (101014 => 101015) ---
[webkit-changes] [101016] trunk/LayoutTests
Title: [101016] trunk/LayoutTests Revision 101016 Author ad...@chromium.org Date 2011-11-22 11:02:39 -0800 (Tue, 22 Nov 2011) Log Message Mark file-writer-abort.html as flakily crashing on Mac Debug. Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (101015 => 101016) --- trunk/LayoutTests/ChangeLog 2011-11-22 18:55:34 UTC (rev 101015) +++ trunk/LayoutTests/ChangeLog 2011-11-22 19:02:39 UTC (rev 101016) @@ -1,5 +1,12 @@ 2011-11-22 Adam Klein ad...@chromium.org +Mark file-writer-abort.html as flakily crashing on Mac Debug. +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + +2011-11-22 Adam Klein ad...@chromium.org + Mark some tests as passing after Skia roll in http://crrev.com/51. Unreviewed gardening. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101015 => 101016) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-22 18:55:34 UTC (rev 101015) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-22 19:02:39 UTC (rev 101016) @@ -3840,6 +3840,7 @@ BUGWK72622 WIN DEBUG : http/tests/inspector/resource-tree/resource-tree-no-xhrs.html = MISSING PASS TEXT BUGWK72631 LINUX : fast/filesystem/file-writer-abort.html = CRASH PASS +BUGWK72631 MAC DEBUG : fast/filesystem/file-writer-abort.html = CRASH PASS BUGWK72631 WIN DEBUG : fast/filesystem/file-writer-abort-depth.html = CRASH PASS BUGWK72651 LINUX DEBUG : http/tests/inspector/styles/styles-redirected-css.html = CRASH PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101017] trunk/LayoutTests
Title: [101017] trunk/LayoutTests Revision 101017 Author ad...@chromium.org Date 2011-11-22 11:08:13 -0800 (Tue, 22 Nov 2011) Log Message Expand MISSING expectation for form-associated-element-crash3.html. Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (101016 => 101017) --- trunk/LayoutTests/ChangeLog 2011-11-22 19:02:39 UTC (rev 101016) +++ trunk/LayoutTests/ChangeLog 2011-11-22 19:08:13 UTC (rev 101017) @@ -1,5 +1,12 @@ 2011-11-22 Adam Klein ad...@chromium.org +Expand MISSING expectation for form-associated-element-crash3.html. +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + +2011-11-22 Adam Klein ad...@chromium.org + Mark file-writer-abort.html as flakily crashing on Mac Debug. Unreviewed gardening. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101016 => 101017) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-22 19:02:39 UTC (rev 101016) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-22 19:08:13 UTC (rev 101017) @@ -3663,7 +3663,7 @@ BUGWK70866 LINUX DEBUG : fast/forms/form-associated-element-crash3.html = TIMEOUT BUGWK72039 LINUX RELEASE : fast/forms/form-associated-element-crash.html = MISSING PASS -BUGWK72039 LINUX RELEASE : fast/forms/form-associated-element-crash3.html = MISSING PASS +BUGWK72039 RELEASE : fast/forms/form-associated-element-crash3.html = MISSING PASS BUGWK72039 LINUX RELEASE : fast/forms/form-attribute-elements.html = MISSING PASS BUGWK72039 LINUX RELEASE : fast/forms/form-attribute-elements-order.html = MISSING PASS BUGWK72039 LINUX RELEASE : fast/forms/form-attribute-elements-order2.html = MISSING PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101018] trunk/Source/WebKit/chromium
Title: [101018] trunk/Source/WebKit/chromium
Revision 101018
Author dpra...@chromium.org
Date 2011-11-22 11:10:05 -0800 (Tue, 22 Nov 2011)
Log Message
Roll Chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=72972
Add dbus in Chromium as pulled dep and update to HEAD.
Patch by Scott Graham scot...@chromium.org on 2011-11-22
Reviewed by Dirk Pranke.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (101017 => 101018)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-22 19:08:13 UTC (rev 101017)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-22 19:10:05 UTC (rev 101018)
@@ -1,3 +1,14 @@
+2011-11-22 Scott Graham scot...@chromium.org
+
+Roll Chromium DEPS
+https://bugs.webkit.org/show_bug.cgi?id=72972
+
+Add dbus in Chromium as pulled dep and update to HEAD.
+
+Reviewed by Dirk Pranke.
+
+* DEPS:
+
2011-11-22 Dirk Pranke dpra...@chromium.org
Roll Chromium DEPS to r110960 and set the disable_nacl flag.
Modified: trunk/Source/WebKit/chromium/DEPS (101017 => 101018)
--- trunk/Source/WebKit/chromium/DEPS 2011-11-22 19:08:13 UTC (rev 101017)
+++ trunk/Source/WebKit/chromium/DEPS 2011-11-22 19:10:05 UTC (rev 101018)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '110359',
+ 'chromium_rev': '78',
'nacl_svn': 'http://src.chromium.org/native_client/trunk',
'nacl_rev': '7169',
}
@@ -79,6 +79,8 @@
Var('chromium_svn')+'/net@'+Var('chromium_rev'),
'crypto':
Var('chromium_svn')+'/crypto@'+Var('chromium_rev'),
+ 'dbus':
+Var('chromium_svn')+'/dbus@'+Var('chromium_rev'),
'sdch':
Var('chromium_svn')+'/sdch@'+Var('chromium_rev'),
'sdch/open-vcdiff':
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101019] trunk/Tools
Title: [101019] trunk/Tools Revision 101019 Author commit-qu...@webkit.org Date 2011-11-22 11:13:38 -0800 (Tue, 22 Nov 2011) Log Message Update flakiness dashboard for new Chromium builders and tests https://bugs.webkit.org/show_bug.cgi?id=72931 Patch by Ryan Sleevi rsle...@chromium.org on 2011-11-22 Reviewed by Ojan Vafai. * TestResultServer/static-dashboards/builders.js: * TestResultServer/static-dashboards/dashboard_base.js: Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestResultServer/static-dashboards/builders.js trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js Diff Modified: trunk/Tools/ChangeLog (101018 => 101019) --- trunk/Tools/ChangeLog 2011-11-22 19:10:05 UTC (rev 101018) +++ trunk/Tools/ChangeLog 2011-11-22 19:13:38 UTC (rev 101019) @@ -1,3 +1,13 @@ +2011-11-22 Ryan Sleevi rsle...@chromium.org + +Update flakiness dashboard for new Chromium builders and tests +https://bugs.webkit.org/show_bug.cgi?id=72931 + +Reviewed by Ojan Vafai. + +* TestResultServer/static-dashboards/builders.js: +* TestResultServer/static-dashboards/dashboard_base.js: + 2011-11-22 Adam Roben aro...@apple.com Remove some debugging code I accidentally left in r101005 Modified: trunk/Tools/TestResultServer/static-dashboards/builders.js (101018 => 101019) --- trunk/Tools/TestResultServer/static-dashboards/builders.js 2011-11-22 19:10:05 UTC (rev 101018) +++ trunk/Tools/TestResultServer/static-dashboards/builders.js 2011-11-22 19:13:38 UTC (rev 101019) @@ -204,6 +204,9 @@ ['Vista Tests (1)'], ['Vista Tests (2)'], ['Vista Tests (3)'], +['Win7 Tests (1)'], +['Win7 Tests (2)'], +['Win7 Tests (3)'], ['Win7 Sync'], ['XP Tests (dbg)(1)'], ['XP Tests (dbg)(2)'], @@ -211,13 +214,14 @@ ['XP Tests (dbg)(4)'], ['XP Tests (dbg)(5)'], ['XP Tests (dbg)(6)'], -['Vista Tests (dbg)(1)'], -['Vista Tests (dbg)(2)'], -['Vista Tests (dbg)(3)'], -['Vista Tests (dbg)(4)'], -['Vista Tests (dbg)(5)'], -['Vista Tests (dbg)(6)'], +['Win7 Tests (dbg)(1)'], +['Win7 Tests (dbg)(2)'], +['Win7 Tests (dbg)(3)'], +['Win7 Tests (dbg)(4)'], +['Win7 Tests (dbg)(5)'], +['Win7 Tests (dbg)(6)'], ['Interactive Tests (dbg)'], +['Win Aura'], ['Mac10.5 Tests (1)'], ['Mac10.5 Tests (2)'], ['Mac10.5 Tests (3)'], @@ -234,20 +238,11 @@ ['Mac 10.6 Tests (dbg)(3)'], ['Mac 10.6 Tests (dbg)(4)'], ['Linux Tests x64'], +['Linux Sync'], ['Linux Tests (dbg)(1)'], ['Linux Tests (dbg)(2)'], ['Linux Tests (dbg)(shared)'], -['Linux Sync'], -['Linux Builder (ChromiumOS)'], -['Linux Builder (ChromiumOS dbg)'], -['Linux Tests (ChromiumOS dbg)(1)'], -['Linux Tests (ChromiumOS dbg)(2)'], -['Linux Tests (ChromiumOS dbg)(3)'], -['Linux Builder (ChromiumOS dbg)'], -['Linux Builder (Views dbg)'], -['Linux Tests (Views dbg)(1)'], -['Linux Tests (Views dbg)(2)'], -['Linux Tests (Views dbg)(3)'], +['Linux Tests (Aura dbg)'], ]; associateBuildersWithMaster(G_TESTS_BUILDERS, CHROMIUM_BUILDER_MASTER); Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (101018 => 101019) --- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2011-11-22 19:10:05 UTC (rev 101018) +++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2011-11-22 19:13:38 UTC (rev 101019) @@ -112,15 +112,39 @@ // These should match the testtype uploaded to test-results.appspot.com. // See http://test-results.appspot.com/testfile. -var TEST_TYPES = ['app_unittests', 'base_unittests', 'browser_tests', -'cache_invalidation_unittests', 'courgette_unittests', -'crypto_unittests', 'googleurl_unittests', 'gpu_unittests', -'installer_util_unittests', 'interactive_ui_tests', 'ipc_tests', -'jingle_unittests', 'layout-tests', 'media_unittests', -'mini_installer_test', 'nacl_ui_tests', 'net_unittests', -'printing_unittests', 'remoting_unittests', 'safe_browsing_tests', -'sync_unit_tests', 'sync_integration_tests', -'test_shell_tests', 'ui_tests', 'unit_tests']; +var TEST_TYPES = [ +'aura_unittests', +'aura_shell_unittests', +'base_unittests', +'browser_tests', +'cacheinvalidation_unittests', +'compositor_unittests', +'content_unittests', +'courgette_unittests', +'crypto_unittests', +'googleurl_unittests', +'gfx_unittests', +'gpu_unittests', +'installer_util_unittests', +'interactive_ui_tests', +'ipc_tests', +'jingle_unittests', +'layout-tests', +'media_unittests', +'mini_installer_test', +'nacl_ui_tests', +'net_unittests', +'printing_unittests', +'remoting_unittests', +'sql_unittests', +'safe_browsing_tests', +'sync_unit_tests', +'sync_integration_tests', +'test_shell_tests', +'ui_tests', +'unit_tests', +
[webkit-changes] [101020] trunk/LayoutTests
Title: [101020] trunk/LayoutTests
Revision 101020
Author ad...@chromium.org
Date 2011-11-22 11:39:02 -0800 (Tue, 22 Nov 2011)
Log Message
More rebaselines from Skia roll.
Unreviewed gardening.
* platform/chromium-cg-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
* platform/chromium-win-xp/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
* platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt:
* platform/chromium/fast/repaint/moving-shadow-on-path-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/repaint/moving-shadow-on-path-expected.txt.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt
Added Paths
trunk/LayoutTests/platform/chromium/fast/repaint/moving-shadow-on-path-expected.txt
Removed Paths
trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/moving-shadow-on-path-expected.txt
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.txt
trunk/LayoutTests/platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.txt
trunk/LayoutTests/platform/chromium-win-xp/fast/repaint/moving-shadow-on-path-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (101019 => 101020)
--- trunk/LayoutTests/ChangeLog 2011-11-22 19:13:38 UTC (rev 101019)
+++ trunk/LayoutTests/ChangeLog 2011-11-22 19:39:02 UTC (rev 101020)
@@ -1,5 +1,16 @@
2011-11-22 Adam Klein ad...@chromium.org
+More rebaselines from Skia roll.
+Unreviewed gardening.
+
+* platform/chromium-cg-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
+* platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
+* platform/chromium-win-xp/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
+* platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt:
+* platform/chromium/fast/repaint/moving-shadow-on-path-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/repaint/moving-shadow-on-path-expected.txt.
+
+2011-11-22 Adam Klein ad...@chromium.org
+
Expand MISSING expectation for form-associated-element-crash3.html.
Unreviewed gardening.
Copied: trunk/LayoutTests/platform/chromium/fast/repaint/moving-shadow-on-path-expected.txt (from rev 101017, trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/moving-shadow-on-path-expected.txt) (0 => 101020)
--- trunk/LayoutTests/platform/chromium/fast/repaint/moving-shadow-on-path-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/repaint/moving-shadow-on-path-expected.txt 2011-11-22 19:39:02 UTC (rev 101020)
@@ -0,0 +1,9 @@
+layer at (0,0) size 785x616
+ RenderView at (0,0) size 785x600
+layer at (0,0) size 785x616
+ RenderBlock {HTML} at (0,0) size 785x616
+RenderBody {BODY} at (8,8) size 769x600
+ RenderSVGRoot {svg} at (8,8) size 458x163
+RenderSVGPath {path} at (8,8) size 88x78 [stroke={[type=SOLID] [color=#00] [stroke width=10.00]}] [fill={[type=SOLID] [color=#99]}] [data="" 1.83697e-15 30 L -35.2671 48.541 L -28.5317 9.27051 L -57.0634 -18.541 L -17.6336 -24.2705 L -1.10215e-14 -60 L 17.6336 -24.2705 L 57.0634 -18.541 L 28.5317 9.27051 L 35.2671 48.541 Z]
+RenderSVGPath {path} at (200,46) size 138x135 [transform={m=((1.00,0.00)(0.00,1.00)) t=(250.00,100.00)}] [stroke={[type=SOLID] [color=#00] [stroke width=10.00] [dash array={20.00}]}] [fill={[type=SOLID] [color=#99]}] [data="" 1.83697e-15 30 L -35.2671 48.541 L -28.5317 9.27051 L -57.0634 -18.541 L -17.6336 -24.2705 L -1.10215e-14 -60 L 17.6336 -24.2705 L 57.0634 -18.541 L 28.5317 9.27051 L 35.2671 48.541 Z]
+RenderSVGPath {path} at (349,46) size 127x132 [transform={m=((1.00,0.00)(0.00,1.00)) t=(400.00,100.00)}] [stroke={[type=SOLID] [color=#00] [stroke width=10.00] [dash array={20.00}]}] [fill={[type=SOLID] [color=#99]}] [data="" 1.53081e-15 25 L -29.3893 40.4509 L -23.7764 7.72542 L -47.5528 -15.4508 L -14.6946 -20.2254 L -9.18455e-15 -50 L 14.6946 -20.2254 L 47.5528 -15.4508 L 23.7764 7.72542 L 29.3893 40.4509 Z]
Property changes: trunk/LayoutTests/platform/chromium/fast/repaint/moving-shadow-on-path-expected.txt
Added: svn:eol-style
Deleted: trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/moving-shadow-on-path-expected.txt (101019 => 101020)
--- trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/moving-shadow-on-path-expected.txt 2011-11-22 19:13:38 UTC (rev 101019)
+++ trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/moving-shadow-on-path-expected.txt 2011-11-22 19:39:02 UTC (rev 101020)
@@ -1,9 +0,0 @@
-layer at (0,0) size 785x616
- RenderView at (0,0) size 785x600
-layer at (0,0) size 785x616
- RenderBlock {HTML} at (0,0) size 785x616
-RenderBody {BODY} at (8,8)
[webkit-changes] [101021] trunk/Source/WebKit/chromium
Title: [101021] trunk/Source/WebKit/chromium
Revision 101021
Author commit-qu...@webkit.org
Date 2011-11-22 11:45:27 -0800 (Tue, 22 Nov 2011)
Log Message
Empty API for web intents
https://bugs.webkit.org/show_bug.cgi?id=69870
Patch by Greg Billock gbill...@google.com on 2011-11-22
Reviewed by Darin Fisher.
* WebKit.gyp:
* public/WebIntent.h: Added.
* public/WebIntentServiceInfo.h: Added.
* public/WebFrame.h:
* public/WebFrameClient.h:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/public/WebFrame.h
trunk/Source/WebKit/chromium/public/WebFrameClient.h
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
trunk/Source/WebKit/chromium/src/WebFrameImpl.h
Added Paths
trunk/Source/WebKit/chromium/public/WebIntent.h
trunk/Source/WebKit/chromium/public/WebIntentServiceInfo.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (101020 => 101021)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-22 19:39:02 UTC (rev 101020)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-22 19:45:27 UTC (rev 101021)
@@ -1,3 +1,16 @@
+2011-11-22 Greg Billock gbill...@google.com
+
+Empty API for web intents
+https://bugs.webkit.org/show_bug.cgi?id=69870
+
+Reviewed by Darin Fisher.
+
+* WebKit.gyp:
+* public/WebIntent.h: Added.
+* public/WebIntentServiceInfo.h: Added.
+* public/WebFrame.h:
+* public/WebFrameClient.h:
+
2011-11-22 Scott Graham scot...@chromium.org
Roll Chromium DEPS
Modified: trunk/Source/WebKit/chromium/WebKit.gyp (101020 => 101021)
--- trunk/Source/WebKit/chromium/WebKit.gyp 2011-11-22 19:39:02 UTC (rev 101020)
+++ trunk/Source/WebKit/chromium/WebKit.gyp 2011-11-22 19:45:27 UTC (rev 101021)
@@ -226,6 +226,8 @@
'public/WebIDBTransactionCallbacks.h',
'public/WebInputElement.h',
'public/WebInputEvent.h',
+'public/WebIntent.h',
+'public/WebIntentServiceInfo.h',
'public/WebKit.h',
'public/WebKitPlatformSupport.h',
'public/WebLabelElement.h',
Modified: trunk/Source/WebKit/chromium/public/WebFrame.h (101020 => 101021)
--- trunk/Source/WebKit/chromium/public/WebFrame.h 2011-11-22 19:39:02 UTC (rev 101020)
+++ trunk/Source/WebKit/chromium/public/WebFrame.h 2011-11-22 19:45:27 UTC (rev 101021)
@@ -544,6 +544,20 @@
virtual void resetMatchCount() = 0;
+// Web Intents -
+
+// Forwards a web intents reply from the invoked activity back to the
+// appropriate registered _javascript_ callback. The |intentIdentifier| is
+// the WebIntent parameter received from the dispatchIntent method.
+virtual void handleIntentResult(int intentIdentifier, const WebString) = 0;
+
+// Forwards a web intents failure notification from the invoked activity
+// or intervening browser logic back to the appropriate registered
+// _javascript_ callback. The |intentIdentifier| is the WebIntent parameter
+// received from the dispatchIntent method.
+virtual void handleIntentFailure(int intentIdentifier, const WebString) = 0;
+
+
// Utility -
// Returns the contents of this frame as a string. If the text is
Modified: trunk/Source/WebKit/chromium/public/WebFrameClient.h (101020 => 101021)
--- trunk/Source/WebKit/chromium/public/WebFrameClient.h 2011-11-22 19:39:02 UTC (rev 101020)
+++ trunk/Source/WebKit/chromium/public/WebFrameClient.h 2011-11-22 19:45:27 UTC (rev 101021)
@@ -52,6 +52,8 @@
class WebDataSource;
class WebFormElement;
class WebFrame;
+class WebIntentServiceInfo;
+class WebIntent;
class WebMediaPlayer;
class WebMediaPlayerClient;
class WebNode;
@@ -381,6 +383,15 @@
unsigned long long newQuotaInBytes,
WebStorageQuotaCallbacks*) { }
+// Web Intents ---
+
+// Register a service to handle Web Intents.
+virtual void registerIntentService(WebFrame*, const WebIntentServiceInfo) { }
+
+// Start a Web Intents activity. Replies to this request should be sent to
+// the WebFrame starting the activity.
+virtual void dispatchIntent(WebFrame*, const WebIntent) { }
+
protected:
~WebFrameClient() { }
};
Added: trunk/Source/WebKit/chromium/public/WebIntent.h (0 => 101021)
--- trunk/Source/WebKit/chromium/public/WebIntent.h (rev 0)
+++ trunk/Source/WebKit/chromium/public/WebIntent.h 2011-11-22 19:45:27 UTC (rev 101021)
@@ -0,0 +1,60 @@
+/*
+ * Copyright (C) 2011 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice,
[webkit-changes] [101022] trunk
Title: [101022] trunk Revision 101022 Author ad...@chromium.org Date 2011-11-22 12:28:49 -0800 (Tue, 22 Nov 2011) Log Message Ignore more gyp-generated build files in WTF.gyp. * .gitignore: Modified Paths trunk/.gitignore trunk/ChangeLog Diff Modified: trunk/.gitignore (101021 => 101022) --- trunk/.gitignore 2011-11-22 19:45:27 UTC (rev 101021) +++ trunk/.gitignore 2011-11-22 20:28:49 UTC (rev 101022) @@ -32,6 +32,11 @@ Source/ThirdParty/glu/*.sln Source/ThirdParty/glu/*.vcproj Source/ThirdParty/glu/glu.xcodeproj +Source/WTF/WTF.gyp/*.Makefile +Source/WTF/WTF.gyp/*.mk +Source/WTF/WTF.gyp/*.ninja +Source/WTF/WTF.gyp/*.sln +Source/WTF/WTF.gyp/*.vcproj* Source/WTF/WTF.gyp/WTF.xcodeproj Source/WebCore/WebCore.gyp/*.Makefile Source/WebCore/WebCore.gyp/*.mk Modified: trunk/ChangeLog (101021 => 101022) --- trunk/ChangeLog 2011-11-22 19:45:27 UTC (rev 101021) +++ trunk/ChangeLog 2011-11-22 20:28:49 UTC (rev 101022) @@ -1,3 +1,9 @@ +2011-11-22 Adam Klein ad...@chromium.org + +Ignore more gyp-generated build files in WTF.gyp. + +* .gitignore: + 2011-11-22 Andy Wingo wi...@igalia.com Fix .dir-locals.el to only apply to specific modes ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101023] trunk/LayoutTests
Title: [101023] trunk/LayoutTests Revision 101023 Author ad...@chromium.org Date 2011-11-22 12:30:36 -0800 (Tue, 22 Nov 2011) Log Message Expand slowness of dispatch-message-string-data.html to debug builds. Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (101022 => 101023) --- trunk/LayoutTests/ChangeLog 2011-11-22 20:28:49 UTC (rev 101022) +++ trunk/LayoutTests/ChangeLog 2011-11-22 20:30:36 UTC (rev 101023) @@ -1,5 +1,12 @@ 2011-11-22 Adam Klein ad...@chromium.org +Expand slowness of dispatch-message-string-data.html to debug builds. +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + +2011-11-22 Adam Klein ad...@chromium.org + More rebaselines from Skia roll. Unreviewed gardening. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101022 => 101023) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-22 20:28:49 UTC (rev 101022) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-22 20:30:36 UTC (rev 101023) @@ -3698,7 +3698,7 @@ BUGWK71673 MAC : svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html = TEXT IMAGE IMAGE+TEXT BUGWK71673 WIN LINUX : svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html = PASS IMAGE IMAGE+TEXT -BUGWK71278 SLOW WIN RELEASE : fast/events/dispatch-message-string-data.html = PASS +BUGWK71278 SLOW WIN : fast/events/dispatch-message-string-data.html = PASS BUGWK71282 WIN DEBUG : inspector/extensions = CRASH PASS TIMEOUT BUGWK71282 WIN DEBUG : http/tests/inspector/extensions-headers.html = CRASH PASS TIMEOUT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101024] trunk/LayoutTests
Title: [101024] trunk/LayoutTests Revision 101024 Author ad...@chromium.org Date 2011-11-22 12:39:54 -0800 (Tue, 22 Nov 2011) Log Message Unreviewed gardening, remove expectations for now-passing tests. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (101023 => 101024) --- trunk/LayoutTests/ChangeLog 2011-11-22 20:30:36 UTC (rev 101023) +++ trunk/LayoutTests/ChangeLog 2011-11-22 20:39:54 UTC (rev 101024) @@ -1,5 +1,11 @@ 2011-11-22 Adam Klein ad...@chromium.org +Unreviewed gardening, remove expectations for now-passing tests. + +* platform/chromium/test_expectations.txt: + +2011-11-22 Adam Klein ad...@chromium.org + Expand slowness of dispatch-message-string-data.html to debug builds. Unreviewed gardening. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101023 => 101024) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-22 20:30:36 UTC (rev 101023) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-22 20:39:54 UTC (rev 101024) @@ -3741,9 +3741,6 @@ // Introduced due to BUGWK53512, fails under Skia right now BUGWK65939 : svg/custom/getBBox-path.svg = TEXT -BUGWK71830 : svg/zoom/page/zoom-svg-as-relative-image.html = IMAGE -BUGWK71830 WIN MAC : svg/zoom/page/relative-sized-document-scrollbars.svg = IMAGE+TEXT - BUGWK72037 : storage/indexeddb/factory-deletedatabase-interactions.html = TEXT TIMEOUT PASS BUGRICOW : fast/js/array-functions-non-arrays.html = TEXT @@ -3758,8 +3755,6 @@ BUGWK70395 MAC : fast/dom/rtl-scroll-to-leftmost-and-resize.html = IMAGE+TEXT -BUGWK72189 WIN : accessibility/adjacent-continuations-cause-assertion-failure.html = TEXT - BUGWK72264 MAC : inspector/debugger/script-formatter.html = TIMEOUT // Fixed ES5 bugs during the V8 roll, upstream in progress. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101025] trunk
Title: [101025] trunk Revision 101025 Author sch...@chromium.org Date 2011-11-22 13:41:13 -0800 (Tue, 22 Nov 2011) Log Message Pointer Lock: Initial Tests for navigator.webkitPonter https://bugs.webkit.org/show_bug.cgi?id=72659 Reviewed by Darin Fisher. Tools: * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Enabling PointerLock in TestShell LayoutTests: * platform/efl/Skipped: * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: * platform/win/Skipped: * platform/wincairo/Skipped: * pointer-lock/mouse-event-api-expected.txt: * pointer-lock/mouse-event-api.html: * pointer-lock/pointer-lock-api-expected.txt: * pointer-lock/pointer-lock-api.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt trunk/LayoutTests/platform/efl/Skipped trunk/LayoutTests/platform/gtk/Skipped trunk/LayoutTests/platform/mac/Skipped trunk/LayoutTests/platform/qt/Skipped trunk/LayoutTests/platform/win/Skipped trunk/LayoutTests/platform/wincairo/Skipped trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestShell.cpp Added Paths trunk/LayoutTests/pointer-lock/ trunk/LayoutTests/pointer-lock/mouse-event-api-expected.txt trunk/LayoutTests/pointer-lock/mouse-event-api.html trunk/LayoutTests/pointer-lock/pointer-lock-api-expected.txt trunk/LayoutTests/pointer-lock/pointer-lock-api.html Diff Modified: trunk/LayoutTests/ChangeLog (101024 => 101025) --- trunk/LayoutTests/ChangeLog 2011-11-22 20:39:54 UTC (rev 101024) +++ trunk/LayoutTests/ChangeLog 2011-11-22 21:41:13 UTC (rev 101025) @@ -1,3 +1,21 @@ +2011-11-17 Vincent Scheib sch...@chromium.org + +Pointer Lock: Initial Tests for navigator.webkitPonter +https://bugs.webkit.org/show_bug.cgi?id=72659 + +Reviewed by Darin Fisher. + +* platform/efl/Skipped: +* platform/gtk/Skipped: +* platform/mac/Skipped: +* platform/qt/Skipped: +* platform/win/Skipped: +* platform/wincairo/Skipped: +* pointer-lock/mouse-event-api-expected.txt: +* pointer-lock/mouse-event-api.html: +* pointer-lock/pointer-lock-api-expected.txt: +* pointer-lock/pointer-lock-api.html: + 2011-11-22 Adam Klein ad...@chromium.org Unreviewed gardening, remove expectations for now-passing tests. Modified: trunk/LayoutTests/platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt (101024 => 101025) --- trunk/LayoutTests/platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt 2011-11-22 20:39:54 UTC (rev 101024) +++ trunk/LayoutTests/platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt 2011-11-22 21:41:13 UTC (rev 101025) @@ -18,6 +18,7 @@ navigator.vendor is OK navigator.vendorSub is OK navigator.webkitGamepads is OK +navigator.webkitPointer is OK navigator.appCodeName is OK navigator.appName is OK navigator.appVersion is OK @@ -36,4 +37,5 @@ navigator.vendor is OK navigator.vendorSub is OK navigator.webkitGamepads is OK +navigator.webkitPointer is OK Modified: trunk/LayoutTests/platform/efl/Skipped (101024 => 101025) --- trunk/LayoutTests/platform/efl/Skipped 2011-11-22 20:39:54 UTC (rev 101024) +++ trunk/LayoutTests/platform/efl/Skipped 2011-11-22 21:41:13 UTC (rev 101025) @@ -1921,6 +1921,9 @@ # Microdata DOM API is not yet enabled. fast/dom/MicroData +# Pointer Lock is not implemented. +pointer-lock/ + # Tests for MediaSource API. Feature is not yet functional. # https://bugs.webkit.org/show_bug.cgi?id=64731 http/tests/media/media-source/ Modified: trunk/LayoutTests/platform/gtk/Skipped (101024 => 101025) --- trunk/LayoutTests/platform/gtk/Skipped 2011-11-22 20:39:54 UTC (rev 101024) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-11-22 21:41:13 UTC (rev 101025) @@ -1591,6 +1591,9 @@ # https://bugs.webkit.org/show_bug.cgi?id=72248 editing/spelling/spelling-unified-emulation.html +# Pointer Lock is not implemented. +pointer-lock/ + # fast/dom/Window/window-postmessage-arrays.html fails on JSC platforms # https://bugs.webkit.org/show_bug.cgi?id=72363 fast/dom/Window/window-postmessage-arrays.html Modified: trunk/LayoutTests/platform/mac/Skipped (101024 => 101025) --- trunk/LayoutTests/platform/mac/Skipped 2011-11-22 20:39:54 UTC (rev 101024) +++ trunk/LayoutTests/platform/mac/Skipped 2011-11-22 21:41:13 UTC (rev 101025) @@ -487,6 +487,9 @@ # DRT doesn't support overridePreference(WebKit*FontMap...) fast/text/international/locale-sensitive-fonts.html +# Pointer Lock is not implemented. +pointer-lock/ + # https://bugs.webkit.org/show_bug.cgi?id=72435 fast/dom/Window/window-postmessage-arrays.html Modified: trunk/LayoutTests/platform/qt/Skipped (101024 => 101025) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-22 20:39:54 UTC (rev 101024) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-22 21:41:13 UTC (rev 101025) @@ -2470,6 +2470,9 @@ #
[webkit-changes] [101029] trunk/LayoutTests
Title: [101029] trunk/LayoutTests Revision 101029 Author ad...@chromium.org Date 2011-11-22 16:12:50 -0800 (Tue, 22 Nov 2011) Log Message One more video-zoom-controls rebaseline for Linux GPU. * platform/chromium-gpu-linux/media/video-zoom-controls-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-gpu-linux/media/video-zoom-controls-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (101028 => 101029) --- trunk/LayoutTests/ChangeLog 2011-11-22 23:09:35 UTC (rev 101028) +++ trunk/LayoutTests/ChangeLog 2011-11-23 00:12:50 UTC (rev 101029) @@ -1,5 +1,11 @@ 2011-11-22 Adam Klein ad...@chromium.org +One more video-zoom-controls rebaseline for Linux GPU. + +* platform/chromium-gpu-linux/media/video-zoom-controls-expected.png: + +2011-11-22 Adam Klein ad...@chromium.org + svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky https://bugs.webkit.org/show_bug.cgi?id=63186 Modified: trunk/LayoutTests/platform/chromium-gpu-linux/media/video-zoom-controls-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101030] trunk/LayoutTests
Title: [101030] trunk/LayoutTests Revision 101030 Author ad...@chromium.org Date 2011-11-22 16:24:41 -0800 (Tue, 22 Nov 2011) Log Message Make two accessibility tests as PASS TIMEOUT on Windows. Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (101029 => 101030) --- trunk/LayoutTests/ChangeLog 2011-11-23 00:12:50 UTC (rev 101029) +++ trunk/LayoutTests/ChangeLog 2011-11-23 00:24:41 UTC (rev 101030) @@ -1,5 +1,12 @@ 2011-11-22 Adam Klein ad...@chromium.org +Make two accessibility tests as PASS TIMEOUT on Windows. +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + +2011-11-22 Adam Klein ad...@chromium.org + One more video-zoom-controls rebaseline for Linux GPU. * platform/chromium-gpu-linux/media/video-zoom-controls-expected.png: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101029 => 101030) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-23 00:12:50 UTC (rev 101029) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-23 00:24:41 UTC (rev 101030) @@ -3832,8 +3832,8 @@ BUGWK72728 LEOPARD CPU-CG : canvas/philip/tests/2d.imageData.put.unchanged.html = TEXT BUGWK72728 LEOPARD CPU-CG : fast/canvas/canvas-alphaImageData-behavior.html = TEXT -BUGWK72747 SLOW WIN DEBUG : accessibility/loading-iframe-sends-notification.html = PASS - +BUGWK72747 WIN : accessibility/loading-iframe-sends-notification.html = PASS TIMEOUT +BUGWK72990 WIN : accessibility/loading-iframe-updates-axtree.html = PASS TIMEOUT BUGWK72761 : accessibility/anonymous-render-block-in-continuation-causes-crash.html = PASS TIMEOUT BUGWK72904 XP : http/tests/media/video-served-as-text.html = PASS TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101031] trunk/Source
Title: [101031] trunk/Source
Revision 101031
Author dch...@chromium.org
Date 2011-11-22 16:39:29 -0800 (Tue, 22 Nov 2011)
Log Message
[chromium] Fix plumbing for differentiating between clipboard/selection pastes.
https://bugs.webkit.org/show_bug.cgi?id=72056
Reviewed by t...@chromium.org.
Source/WebCore:
Add a buffer parameter when retrieving the clipboard sequence number and fix several call
sites that incorrectly assume use of the standard buffer in pastes.
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::containsFilenames):
* platform/chromium/ChromiumDataObject.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::ClipboardChromium):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::platformClipboardChanged):
* platform/chromium/ClipboardUtilitiesChromium.cpp:
(WebCore::currentPasteboardBuffer):
* platform/chromium/ClipboardUtilitiesChromium.h:
* platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::getAsString):
* platform/chromium/PlatformSupport.h:
Source/WebKit/chromium:
Add a buffer parameter when retrieving the clipboard sequence number.
* public/WebClipboard.h:
(WebKit::WebClipboard::sequenceNumber):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::clipboardSequenceNumber):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/ChromiumDataObject.cpp
trunk/Source/WebCore/platform/chromium/ChromiumDataObject.h
trunk/Source/WebCore/platform/chromium/ClipboardChromium.cpp
trunk/Source/WebCore/platform/chromium/ClipboardUtilitiesChromium.cpp
trunk/Source/WebCore/platform/chromium/ClipboardUtilitiesChromium.h
trunk/Source/WebCore/platform/chromium/DataTransferItemChromium.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebClipboard.h
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (101030 => 101031)
--- trunk/Source/WebCore/ChangeLog 2011-11-23 00:24:41 UTC (rev 101030)
+++ trunk/Source/WebCore/ChangeLog 2011-11-23 00:39:29 UTC (rev 101031)
@@ -1,3 +1,29 @@
+2011-11-22 Daniel Cheng dch...@chromium.org
+
+[chromium] Fix plumbing for differentiating between clipboard/selection pastes.
+https://bugs.webkit.org/show_bug.cgi?id=72056
+
+Reviewed by t...@chromium.org.
+
+Add a buffer parameter when retrieving the clipboard sequence number and fix several call
+sites that incorrectly assume use of the standard buffer in pastes.
+
+* platform/chromium/ChromiumDataObject.cpp:
+(WebCore::ChromiumDataObject::types):
+(WebCore::ChromiumDataObject::getData):
+(WebCore::ChromiumDataObject::containsFilenames):
+* platform/chromium/ChromiumDataObject.h:
+* platform/chromium/ClipboardChromium.cpp:
+(WebCore::ClipboardChromium::ClipboardChromium):
+(WebCore::ClipboardChromium::getData):
+(WebCore::ClipboardChromium::platformClipboardChanged):
+* platform/chromium/ClipboardUtilitiesChromium.cpp:
+(WebCore::currentPasteboardBuffer):
+* platform/chromium/ClipboardUtilitiesChromium.h:
+* platform/chromium/DataTransferItemChromium.cpp:
+(WebCore::DataTransferItemChromium::getAsString):
+* platform/chromium/PlatformSupport.h:
+
2011-11-22 Andrey Kosyakov ca...@chromium.org
Layout Test inspector/extensions/extensions-events.html is timing out
Modified: trunk/Source/WebCore/platform/chromium/ChromiumDataObject.cpp (101030 => 101031)
--- trunk/Source/WebCore/platform/chromium/ChromiumDataObject.cpp 2011-11-23 00:24:41 UTC (rev 101030)
+++ trunk/Source/WebCore/platform/chromium/ChromiumDataObject.cpp 2011-11-23 00:39:29 UTC (rev 101031)
@@ -32,6 +32,7 @@
#include ChromiumDataObject.h
#include ClipboardMimeTypes.h
+#include ClipboardUtilitiesChromium.h
#include Pasteboard.h
#include PlatformSupport.h
@@ -103,8 +104,8 @@
{
if (m_storageMode == Pasteboard) {
bool ignoredContainsFilenames;
-return PlatformSupport::clipboardReadAvailableTypes(PasteboardPrivate::StandardBuffer,
- ignoredContainsFilenames);
+return PlatformSupport::clipboardReadAvailableTypes(currentPasteboardBuffer(),
+ignoredContainsFilenames);
}
HashSetString results;
@@ -130,11 +131,7 @@
{
if (type == mimeTypeTextPlain) {
if (m_storageMode == Pasteboard) {
-PasteboardPrivate::ClipboardBuffer buffer =
-Pasteboard::generalPasteboard()-isSelectionMode() ?
-PasteboardPrivate::SelectionBuffer :
-PasteboardPrivate::StandardBuffer;
-String text =
[webkit-changes] [101032] trunk/LayoutTests
Title: [101032] trunk/LayoutTests Revision 101032 Author ad...@chromium.org Date 2011-11-22 16:44:36 -0800 (Tue, 22 Nov 2011) Log Message Remove some flaky expectations added by me five months ago. Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (101031 => 101032) --- trunk/LayoutTests/ChangeLog 2011-11-23 00:39:29 UTC (rev 101031) +++ trunk/LayoutTests/ChangeLog 2011-11-23 00:44:36 UTC (rev 101032) @@ -1,5 +1,12 @@ 2011-11-22 Adam Klein ad...@chromium.org +Remove some flaky expectations added by me five months ago. +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + +2011-11-22 Adam Klein ad...@chromium.org + Make two accessibility tests as PASS TIMEOUT on Windows. Unreviewed gardening. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101031 => 101032) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-23 00:39:29 UTC (rev 101031) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-23 00:44:36 UTC (rev 101032) @@ -3178,12 +3178,6 @@ BUGCR84093 VISTA : http/tests/history/redirect-200-refresh-2-seconds.pl = PASS TIMEOUT BUGCR84095 VISTA : svg/custom/use-detach.svg = PASS TIMEOUT -// Flaky for a long time with no obvious cause. -BUGADAMK VISTA : http/tests/history/redirect-301.html = PASS TIMEOUT - -// Weird failures only on debug bots after r87526. -BUGADAMK DEBUG : svg/custom/object-sizing-explicit-height.xhtml = PASS IMAGE+TEXT -BUGADAMK DEBUG : svg/custom/object-sizing-explicit-width.xhtml = PASS IMAGE+TEXT BUGWK66320 SNOWLEOPARD RELEASE : svg/wicd/test-rightsizing-a.xhtml = PASS IMAGE+TEXT BUGWK66320 DEBUG : svg/wicd/test-rightsizing-a.xhtml = PASS IMAGE IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101033] trunk/Source/WebCore/ChangeLog
Title: [101033] trunk/Source/WebCore/ChangeLog Revision 101033 Author dch...@chromium.org Date 2011-11-22 16:44:43 -0800 (Tue, 22 Nov 2011) Log Message Unreviewed. Fix ChangeLog typo in r101031. Modified Paths trunk/Source/WebCore/ChangeLog Diff Modified: trunk/Source/WebCore/ChangeLog (101032 => 101033) --- trunk/Source/WebCore/ChangeLog 2011-11-23 00:44:36 UTC (rev 101032) +++ trunk/Source/WebCore/ChangeLog 2011-11-23 00:44:43 UTC (rev 101033) @@ -3,7 +3,7 @@ [chromium] Fix plumbing for differentiating between clipboard/selection pastes. https://bugs.webkit.org/show_bug.cgi?id=72056 -Reviewed by t...@chromium.org. +Reviewed by Tony Chang. Add a buffer parameter when retrieving the clipboard sequence number and fix several call sites that incorrectly assume use of the standard buffer in pastes. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101034] branches/chromium/912
Title: [101034] branches/chromium/912
Revision 101034
Author cev...@google.com
Date 2011-11-22 17:58:18 -0800 (Tue, 22 Nov 2011)
Log Message
Merge 100827
BUG=103921
Review URL: http://codereview.chromium.org/8666014
Modified Paths
branches/chromium/912/Source/WebCore/dom/RangeBoundaryPoint.h
Added Paths
branches/chromium/912/LayoutTests/fast/dom/move-detached-child-in-range-expected.txt
branches/chromium/912/LayoutTests/fast/dom/move-detached-child-in-range.html
Diff
Copied: branches/chromium/912/LayoutTests/fast/dom/move-detached-child-in-range-expected.txt (from rev 100827, trunk/LayoutTests/fast/dom/move-detached-child-in-range-expected.txt) (0 => 101034)
--- branches/chromium/912/LayoutTests/fast/dom/move-detached-child-in-range-expected.txt (rev 0)
+++ branches/chromium/912/LayoutTests/fast/dom/move-detached-child-in-range-expected.txt 2011-11-23 01:58:18 UTC (rev 101034)
@@ -0,0 +1 @@
+Final end container, offset: [object HTMLHeadingElement], 1
Copied: branches/chromium/912/LayoutTests/fast/dom/move-detached-child-in-range.html (from rev 100827, trunk/LayoutTests/fast/dom/move-detached-child-in-range.html) (0 => 101034)
--- branches/chromium/912/LayoutTests/fast/dom/move-detached-child-in-range.html (rev 0)
+++ branches/chromium/912/LayoutTests/fast/dom/move-detached-child-in-range.html 2011-11-23 01:58:18 UTC (rev 101034)
@@ -0,0 +1,33 @@
+html
+head
+script src=""
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+function go() {
+ frame = document.getElementById('frame');
+ node2 = document.createElement('b');
+ node1 = document.createElement('h1');
+ node1.appendChild(node2);
+ range = document.createRange();
+ range.selectNodeContents(node1);
+
+ frame.contentDocument.body.appendChild(node1);
+
+ node1.removeChild(node2);
+ delete node2;
+ gc();
+ document.body.innerText = 'Final end container, offset: ' + range.endContainer + ', ' + range.endOffset;
+ if (window.layoutTestController)
+layoutTestController.notifyDone()
+}
+/script
+/head
+body _onload_=go()
+FAIL
+iframe id=frame/iframe
+/body
+/html
Modified: branches/chromium/912/Source/WebCore/dom/RangeBoundaryPoint.h (101033 => 101034)
--- branches/chromium/912/Source/WebCore/dom/RangeBoundaryPoint.h 2011-11-23 00:44:43 UTC (rev 101033)
+++ branches/chromium/912/Source/WebCore/dom/RangeBoundaryPoint.h 2011-11-23 01:58:18 UTC (rev 101034)
@@ -59,7 +59,7 @@
RefPtrNode m_containerNode;
mutable int m_offsetInContainer;
-Node* m_childBeforeBoundary;
+RefPtrNode m_childBeforeBoundary;
};
inline RangeBoundaryPoint::RangeBoundaryPoint(PassRefPtrNode container)
@@ -77,7 +77,7 @@
inline Node* RangeBoundaryPoint::childBefore() const
{
-return m_childBeforeBoundary;
+return m_childBeforeBoundary.get();
}
inline void RangeBoundaryPoint::ensureOffsetIsValid() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101035] trunk/Source
Title: [101035] trunk/Source Revision 101035 Author k...@google.com Date 2011-11-22 18:01:07 -0800 (Tue, 22 Nov 2011) Log Message [chromium] Support Core Animation plugins in compositor https://bugs.webkit.org/show_bug.cgi?id=72921 Reviewed by Stephen White. Source/WebCore: Added support to PluginLayerChromium and CCPluginLayerImpl for using an IOSurface as the backing store for a plugin. Added minimal ARB_texture_rectangle support to Extensions3D.h and a Chromium- specific extension for binding an IOSurface to a texture. These changes themselves do not have any effect. A follow-on Chromium CL will make the switch to this new code path. Tested manually both with and without the Chromium side changes; Chromium's DumpRenderTree port does not support Core Animation plugins. Ran video and Stage3D in Flash, and Unity 3D content, to verify. * platform/graphics/Extensions3D.h: * platform/graphics/chromium/Extensions3DChromium.h: * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::initialize): (WebCore::LayerRendererChromium::pluginLayerTexRectProgram): (WebCore::LayerRendererChromium::pluginLayerTexRectProgramFlip): * platform/graphics/chromium/LayerRendererChromium.h: * platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::PluginLayerChromium): (WebCore::PluginLayerChromium::setIOSurfaceProperties): (WebCore::PluginLayerChromium::getIOSurfaceId): (WebCore::PluginLayerChromium::pushPropertiesTo): * platform/graphics/chromium/PluginLayerChromium.h: * platform/graphics/chromium/ShaderChromium.cpp: (WebCore::FragmentShaderRGBATexRectFlipAlpha::getShaderString): (WebCore::FragmentShaderRGBATexRectAlpha::getShaderString): * platform/graphics/chromium/ShaderChromium.h: * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: (PluginProgramBinding::TexStretchPluginProgramBinding::set): (PluginProgramBinding::TexTransformPluginProgramBinding::set): (WebCore::CCPluginLayerImpl::CCPluginLayerImpl): (WebCore::CCPluginLayerImpl::~CCPluginLayerImpl): (WebCore::CCPluginLayerImpl::draw): (WebCore::CCPluginLayerImpl::setIOSurfaceProperties): (WebCore::CCPluginLayerImpl::cleanupResources): * platform/graphics/chromium/cc/CCPluginLayerImpl.h: Source/WebKit/chromium: Added IOSurface support to WebPluginContainer. This code path is used only on Mac OS X, but is defined in the header on all platforms for simplicity. * public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::texImageIOSurface2DCHROMIUM): * public/WebPluginContainer.h: * src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM): * src/GraphicsContext3DChromium.cpp: * src/GraphicsContext3DPrivate.h: * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): (WebKit::WebPluginContainerImpl::platformLayer): (WebKit::WebPluginContainerImpl::handleKeyboardEvent): * src/WebPluginContainerImpl.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/Extensions3D.h trunk/Source/WebCore/platform/graphics/chromium/Extensions3DChromium.h trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h trunk/Source/WebCore/platform/graphics/chromium/PluginLayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/ShaderChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/ShaderChromium.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h trunk/Source/WebKit/chromium/public/WebPluginContainer.h trunk/Source/WebKit/chromium/src/Extensions3DChromium.cpp trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp trunk/Source/WebKit/chromium/src/GraphicsContext3DPrivate.h trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.h Diff Modified: trunk/Source/WebCore/ChangeLog (101034 => 101035) --- trunk/Source/WebCore/ChangeLog 2011-11-23 01:58:18 UTC (rev 101034) +++ trunk/Source/WebCore/ChangeLog 2011-11-23 02:01:07 UTC (rev 101035) @@ -1,3 +1,50 @@ +2011-11-22 Kenneth Russell k...@google.com + +[chromium] Support Core Animation plugins in compositor +https://bugs.webkit.org/show_bug.cgi?id=72921 + +Reviewed by Stephen White. + +Added support to PluginLayerChromium and CCPluginLayerImpl for +using an IOSurface as the backing store for a plugin. Added minimal +ARB_texture_rectangle support to Extensions3D.h and a Chromium- +specific extension for binding an IOSurface to a texture. + +These changes themselves do not have any effect. A follow-on +Chromium CL will make the switch to this new code path. + +
[webkit-changes] [101036] trunk
Title: [101036] trunk Revision 101036 Author ad...@chromium.org Date 2011-11-22 18:15:40 -0800 (Tue, 22 Nov 2011) Log Message Add new WebKit/chromium/dbus directory to .gitignore. * .gitignore: Modified Paths trunk/.gitignore trunk/ChangeLog Diff Modified: trunk/.gitignore (101035 => 101036) --- trunk/.gitignore 2011-11-23 02:01:07 UTC (rev 101035) +++ trunk/.gitignore 2011-11-23 02:15:40 UTC (rev 101036) @@ -65,6 +65,7 @@ Source/WebKit/chromium/chromium_deps/ Source/WebKit/chromium/crypto/ Source/WebKit/chromium/depot_tools/ +Source/WebKit/chromium/dbus/ Source/WebKit/chromium/gfx/ Source/WebKit/chromium/googleurl/ Source/WebKit/chromium/gpu/ Modified: trunk/ChangeLog (101035 => 101036) --- trunk/ChangeLog 2011-11-23 02:01:07 UTC (rev 101035) +++ trunk/ChangeLog 2011-11-23 02:15:40 UTC (rev 101036) @@ -1,5 +1,11 @@ 2011-11-22 Adam Klein ad...@chromium.org +Add new WebKit/chromium/dbus directory to .gitignore. + +* .gitignore: + +2011-11-22 Adam Klein ad...@chromium.org + Ignore more gyp-generated build files in WTF.gyp. * .gitignore: ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101037] branches/chromium/912
Title: [101037] branches/chromium/912
Revision 101037
Author cev...@google.com
Date 2011-11-22 18:51:03 -0800 (Tue, 22 Nov 2011)
Log Message
Merge 100630
BUG=101065
Review URL: http://codereview.chromium.org/8666016
Modified Paths
branches/chromium/912/Source/WebCore/rendering/RenderBlock.cpp
branches/chromium/912/Source/WebCore/rendering/RenderObject.cpp
branches/chromium/912/Source/WebCore/rendering/RenderObject.h
branches/chromium/912/Source/WebCore/rendering/RenderObjectChildList.cpp
branches/chromium/912/Source/WebCore/rendering/RenderTable.cpp
branches/chromium/912/Source/WebCore/rendering/RenderTableRow.cpp
branches/chromium/912/Source/WebCore/rendering/RenderTableSection.cpp
Added Paths
branches/chromium/912/LayoutTests/fast/css-generated-content/nested-tables-with-before-after-content-crash.html
branches/chromium/912/LayoutTests/platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png
branches/chromium/912/LayoutTests/platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt
branches/chromium/912/LayoutTests/platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png
branches/chromium/912/LayoutTests/platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt
Diff
Copied: branches/chromium/912/LayoutTests/fast/css-generated-content/nested-tables-with-before-after-content-crash.html (from rev 100630, trunk/LayoutTests/fast/css-generated-content/nested-tables-with-before-after-content-crash.html) (0 => 101037)
--- branches/chromium/912/LayoutTests/fast/css-generated-content/nested-tables-with-before-after-content-crash.html (rev 0)
+++ branches/chromium/912/LayoutTests/fast/css-generated-content/nested-tables-with-before-after-content-crash.html 2011-11-23 02:51:03 UTC (rev 101037)
@@ -0,0 +1,18 @@
+!DOCTYPE
+html style=font: 1em/1 Ahem, sans-serif;
+style type=text/css
+.c1 { display: inline-table; color: blue}
+.c1:before { overflow: hidden; content: counter(section); color: red}
+.c1:nth-child(2n) { text-decoration: overline; }
+/style
+body
+div class=c1 id=div1q style=display:inline-table/q/div
+/body
+script
+function runTest() {
+document.getElementById('div1').setAttribute('class', 'c1');
+document.body.offsetTop;
+}
+window._onload_ = runTest;
+/script
+/html
Copied: branches/chromium/912/LayoutTests/platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png (from rev 100630, trunk/LayoutTests/platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png)
(Binary files differ)
Copied: branches/chromium/912/LayoutTests/platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt (from rev 100630, trunk/LayoutTests/platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt) (0 => 101037)
--- branches/chromium/912/LayoutTests/platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt (rev 0)
+++ branches/chromium/912/LayoutTests/platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt 2011-11-23 02:51:03 UTC (rev 101037)
@@ -0,0 +1,24 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderTable {DIV} at (0,0) size 48x19 [color=#FF]
+RenderTableSection (anonymous) at (0,0) size 48x19
+ RenderTableRow (anonymous) at (0,0) size 48x19
+RenderTableCell (anonymous) at (0,0) size 48x19 [r=0 c=0 rs=1 cs=1]
+ RenderInline (generated) at (0,0) size 16x16 [color=#FF]
+RenderCounter at (0,3) size 16x16
+ text run at (0,3) width 16: 0
+ RenderTable {Q} at (16,0) size 32x16
+RenderTableSection (anonymous) at (0,0) size 32x16
+ RenderTableRow (anonymous) at (0,0) size 32x16
+RenderTableCell (anonymous) at (0,0) size 32x16 [r=0 c=0 rs=1 cs=1]
+ RenderInline (generated) at (0,0) size 16x16
+RenderQuote at (0,0) size 16x16
+ text run at (0,0) width 16: \
+ RenderInline (generated) at (0,0) size 16x16
+RenderQuote at (16,0) size 16x16
+ text run at (16,0) width 16: \
+ RenderText {#text} at (0,0) size 0x0
+ RenderText {#text} at (0,0) size 0x0
Copied: branches/chromium/912/LayoutTests/platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png (from rev 100630,
[webkit-changes] [101039] branches/chromium/912
Title: [101039] branches/chromium/912
Revision 101039
Author cev...@google.com
Date 2011-11-22 19:08:07 -0800 (Tue, 22 Nov 2011)
Log Message
Merge 100677
BUG=100958
Review URL: http://codereview.chromium.org/8674006
Modified Paths
branches/chromium/912/Source/WebCore/rendering/RenderBlock.cpp
Added Paths
branches/chromium/912/LayoutTests/fast/css-generated-content/positioned-generated-content-under-run-in-crash-expected.txt
branches/chromium/912/LayoutTests/fast/css-generated-content/positioned-generated-content-under-run-in-crash.html
Diff
Copied: branches/chromium/912/LayoutTests/fast/css-generated-content/positioned-generated-content-under-run-in-crash-expected.txt (from rev 100677, trunk/LayoutTests/fast/css-generated-content/positioned-generated-content-under-run-in-crash-expected.txt) (0 => 101039)
--- branches/chromium/912/LayoutTests/fast/css-generated-content/positioned-generated-content-under-run-in-crash-expected.txt (rev 0)
+++ branches/chromium/912/LayoutTests/fast/css-generated-content/positioned-generated-content-under-run-in-crash-expected.txt 2011-11-23 03:08:07 UTC (rev 101039)
@@ -0,0 +1,2 @@
+PASS, if no exceptions or crash observed
+
Copied: branches/chromium/912/LayoutTests/fast/css-generated-content/positioned-generated-content-under-run-in-crash.html (from rev 100677, trunk/LayoutTests/fast/css-generated-content/positioned-generated-content-under-run-in-crash.html) (0 => 101039)
--- branches/chromium/912/LayoutTests/fast/css-generated-content/positioned-generated-content-under-run-in-crash.html (rev 0)
+++ branches/chromium/912/LayoutTests/fast/css-generated-content/positioned-generated-content-under-run-in-crash.html 2011-11-23 03:08:07 UTC (rev 101039)
@@ -0,0 +1,22 @@
+style
+.testclass::before { position: absolute; content: ; }
+.testclass { display: run-in; }
+/style
+PASS, if no exceptions or crash observed
+script
+function runTest()
+{
+test1 = document.createElement('div');
+test1.setAttribute('class', 'testclass');
+document.documentElement.appendChild(test1);
+test2 = document.createElement('b');
+test2.setAttribute('class', 'testclass');
+document.documentElement.appendChild(test2);
+test3 = document.createElement('div');
+document.documentElement.appendChild(test3);
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+}
+window._onload_ = runTest;
+/script
+
Modified: branches/chromium/912/Source/WebCore/rendering/RenderBlock.cpp (101038 => 101039)
--- branches/chromium/912/Source/WebCore/rendering/RenderBlock.cpp 2011-11-23 02:58:26 UTC (rev 101038)
+++ branches/chromium/912/Source/WebCore/rendering/RenderBlock.cpp 2011-11-23 03:08:07 UTC (rev 101039)
@@ -1595,6 +1595,16 @@
RenderBlock* currBlock = toRenderBlock(curr);
+// First we destroy any :before/:after content. It will be regenerated by the new inline.
+// Exception is if the run-in itself is generated.
+if (child-style()-styleType() != BEFORE child-style()-styleType() != AFTER) {
+RenderObject* generatedContent;
+if (child-getCachedPseudoStyle(BEFORE) (generatedContent = child-beforePseudoElementRenderer()))
+generatedContent-destroy();
+if (child-getCachedPseudoStyle(AFTER) (generatedContent = child-afterPseudoElementRenderer()))
+generatedContent-destroy();
+}
+
// Remove the old child.
children()-removeChildNode(this, blockRunIn);
@@ -1603,16 +1613,11 @@
RenderInline* inlineRunIn = new (renderArena()) RenderInline(runInNode ? runInNode : document());
inlineRunIn-setStyle(blockRunIn-style());
-bool runInIsGenerated = child-style()-styleType() == BEFORE || child-style()-styleType() == AFTER;
-
-// Move the nodes from the old child to the new child, but skip any :before/:after content. It has already
-// been regenerated by the new inline.
+// Move the nodes from the old child to the new child
for (RenderObject* runInChild = blockRunIn-firstChild(); runInChild;) {
RenderObject* nextSibling = runInChild-nextSibling();
-if (runInIsGenerated || (runInChild-style()-styleType() != BEFORE runInChild-style()-styleType() != AFTER)) {
-blockRunIn-children()-removeChildNode(blockRunIn, runInChild, false);
-inlineRunIn-addChild(runInChild); // Use addChild instead of appendChildNode since it handles correct placement of the children relative to :after-generated content.
-}
+blockRunIn-children()-removeChildNode(blockRunIn, runInChild, false);
+inlineRunIn-addChild(runInChild); // Use addChild instead of appendChildNode since it handles correct placement of the children relative to :after-generated content.
runInChild = nextSibling;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [101040] branches/chromium/912
Title: [101040] branches/chromium/912
Revision 101040
Author cev...@google.com
Date 2011-11-22 19:16:00 -0800 (Tue, 22 Nov 2011)
Log Message
Merge 100203
BUG=105143
Review URL: http://codereview.chromium.org/8673010
Modified Paths
branches/chromium/912/LayoutTests/editing/pasteboard/drag-drop-dead-frame.html
branches/chromium/912/Source/WebCore/page/SecurityOrigin.cpp
Added Paths
branches/chromium/912/LayoutTests/editing/pasteboard/drag-drop-to-data-url-expected.txt
branches/chromium/912/LayoutTests/editing/pasteboard/drag-drop-to-data-url.html
branches/chromium/912/LayoutTests/editing/pasteboard/resources/editable-iframe.html
Diff
Modified: branches/chromium/912/LayoutTests/editing/pasteboard/drag-drop-dead-frame.html (101039 => 101040)
--- branches/chromium/912/LayoutTests/editing/pasteboard/drag-drop-dead-frame.html 2011-11-23 03:08:07 UTC (rev 101039)
+++ branches/chromium/912/LayoutTests/editing/pasteboard/drag-drop-dead-frame.html 2011-11-23 03:16:00 UTC (rev 101040)
@@ -74,7 +74,7 @@
pCheck you don't crash when your previous drag target frame is deleted lt;rdar://problem/5049842gt;/p
divspan id=dragmehello/span/div
-iframe id=targetframe src=""
+iframe id=targetframe src=""
scriptrunEditingTest();/script
/body
/html
Copied: branches/chromium/912/LayoutTests/editing/pasteboard/drag-drop-to-data-url-expected.txt (from rev 100203, trunk/LayoutTests/editing/pasteboard/drag-drop-to-data-url-expected.txt) (0 => 101040)
--- branches/chromium/912/LayoutTests/editing/pasteboard/drag-drop-to-data-url-expected.txt (rev 0)
+++ branches/chromium/912/LayoutTests/editing/pasteboard/drag-drop-to-data-url-expected.txt 2011-11-23 03:16:00 UTC (rev 101040)
@@ -0,0 +1,5 @@
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+Check you can't drag into a data URL
+
+hello
+
Copied: branches/chromium/912/LayoutTests/editing/pasteboard/drag-drop-to-data-url.html (from rev 100203, trunk/LayoutTests/editing/pasteboard/drag-drop-to-data-url.html) (0 => 101040)
--- branches/chromium/912/LayoutTests/editing/pasteboard/drag-drop-to-data-url.html (rev 0)
+++ branches/chromium/912/LayoutTests/editing/pasteboard/drag-drop-to-data-url.html 2011-11-23 03:16:00 UTC (rev 101040)
@@ -0,0 +1,60 @@
+html
+head
+script src="" type=text/_javascript_/script
+script
+
+var framex;
+var framey;
+
+function editingTest() {
+
+if (!window.layoutTestController) {
+alert('This test requires layoutTestController to run!');
+return;
+}
+
+layoutTestController.waitUntilDone();
+layoutTestController.dumpAsText();
+
+var t = document.getElementById(targetframe);
+framex = t.offsetLeft + 10;
+framey = t.offsetTop + t.offsetHeight / 2;
+
+// Drag 'hello'
+dragDropIt();
+}
+
+
+function dragDropIt() {
+var e = document.getElementById(dragme);
+window.getSelection().setBaseAndExtent(e, 0, e, 4);
+x = e.offsetLeft + 10;
+y = e.offsetTop + e.offsetHeight / 2;
+eventSender.mouseMoveTo(x, y);
+eventSender.mouseDown();
+
+eventSender.leapForward(500);
+eventSender.mouseMoveTo(framex, framey);
+setTimeout(dropIt, 100);
+}
+
+function dropIt() {
+
+// Drop it off to the frame
+eventSender.mouseUp();
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+
+/script
+titleCheck you can't drag into a data URL/title
+/head
+body
+
+pCheck you can't drag into a data URL/p
+divspan id=dragmehello/span/div
+iframe id=targetframe src=""
+scriptrunEditingTest();/script
+/body
+/html
Copied: branches/chromium/912/LayoutTests/editing/pasteboard/resources/editable-iframe.html (from rev 100203, trunk/LayoutTests/editing/pasteboard/resources/editable-iframe.html) (0 => 101040)
--- branches/chromium/912/LayoutTests/editing/pasteboard/resources/editable-iframe.html (rev 0)
+++ branches/chromium/912/LayoutTests/editing/pasteboard/resources/editable-iframe.html 2011-11-23 03:16:00 UTC (rev 101040)
@@ -0,0 +1 @@
+body contentEditable=true
Modified: branches/chromium/912/Source/WebCore/page/SecurityOrigin.cpp (101039 => 101040)
--- branches/chromium/912/Source/WebCore/page/SecurityOrigin.cpp 2011-11-23 03:08:07 UTC (rev 101039)
+++ branches/chromium/912/Source/WebCore/page/SecurityOrigin.cpp 2011-11-23 03:16:00 UTC (rev 101040)
@@ -305,13 +305,6 @@
if (this == dragInitiator)
return true;
-// FIXME: Currently we treat data URLs as having a unique origin, contrary to the
-// current (9/19/2009) draft of the HTML5 specification. We still want to allow
-// drop across data URLs, so we special case data URLs below. If we change to
-// match HTML5 w.r.t. data URL security, then we can remove this check.
-if (m_protocol == data)
-return true;
-
return canAccess(dragInitiator);
}
___
webkit-changes mailing list
[webkit-changes] [101041] trunk/Source/JavaScriptCore
Title: [101041] trunk/Source/_javascript_Core
Revision 101041
Author dba...@webkit.org
Date 2011-11-22 19:30:34 -0800 (Tue, 22 Nov 2011)
Log Message
Add WTF infrastructure for the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=72970
Reviewed by Antonio Gomes.
* wtf/Assertions.cpp: Added BlackBerry-specific logging directive.
* wtf/MathExtras.h:
(abs): Added; stdlib doesn't contain abs() on QNX.
* wtf/Platform.h: Define WTF_PLATFORM_BLACKBERRY and enable some platform features.
* wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator): For the BlackBerry port, we initialize
the bad pseudo random number generator using time(3) before initializing the
Mersenne Twister random number generator.
* wtf/ThreadingPthreads.cpp:
(WTF::createThreadInternal): Added.
* wtf/blackberry: Added.
* wtf/blackberry/MainThreadBlackBerry.cpp: Added.
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
* wtf/text/WTFString.h: Added constructor and conversion operator for
BlackBerry WebString string object.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Assertions.cpp
trunk/Source/_javascript_Core/wtf/MathExtras.h
trunk/Source/_javascript_Core/wtf/Platform.h
trunk/Source/_javascript_Core/wtf/RandomNumberSeed.h
trunk/Source/_javascript_Core/wtf/ThreadingPthreads.cpp
trunk/Source/_javascript_Core/wtf/text/WTFString.h
Added Paths
trunk/Source/_javascript_Core/wtf/blackberry/
trunk/Source/_javascript_Core/wtf/blackberry/MainThreadBlackBerry.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (101040 => 101041)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-23 03:16:00 UTC (rev 101040)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-23 03:30:34 UTC (rev 101041)
@@ -1,3 +1,27 @@
+2011-11-22 Daniel Bates dba...@rim.com
+
+Add WTF infrastructure for the BlackBerry port
+https://bugs.webkit.org/show_bug.cgi?id=72970
+
+Reviewed by Antonio Gomes.
+
+* wtf/Assertions.cpp: Added BlackBerry-specific logging directive.
+* wtf/MathExtras.h:
+(abs): Added; stdlib doesn't contain abs() on QNX.
+* wtf/Platform.h: Define WTF_PLATFORM_BLACKBERRY and enable some platform features.
+* wtf/RandomNumberSeed.h:
+(WTF::initializeRandomNumberGenerator): For the BlackBerry port, we initialize
+the bad pseudo random number generator using time(3) before initializing the
+Mersenne Twister random number generator.
+* wtf/ThreadingPthreads.cpp:
+(WTF::createThreadInternal): Added.
+* wtf/blackberry: Added.
+* wtf/blackberry/MainThreadBlackBerry.cpp: Added.
+(WTF::initializeMainThreadPlatform):
+(WTF::scheduleDispatchFunctionsOnMainThread):
+* wtf/text/WTFString.h: Added constructor and conversion operator for
+BlackBerry WebString string object.
+
2011-11-22 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r100988.
Modified: trunk/Source/_javascript_Core/wtf/Assertions.cpp (101040 => 101041)
--- trunk/Source/_javascript_Core/wtf/Assertions.cpp 2011-11-23 03:16:00 UTC (rev 101040)
+++ trunk/Source/_javascript_Core/wtf/Assertions.cpp 2011-11-23 03:30:34 UTC (rev 101041)
@@ -55,6 +55,10 @@
#include execinfo.h
#endif
+#if PLATFORM(BLACKBERRY)
+#include BlackBerryPlatformMisc.h
+#endif
+
extern C {
WTF_ATTRIBUTE_PRINTF(1, 0)
@@ -77,7 +81,8 @@
CFRelease(cfFormat);
return;
}
-
+#elif PLATFORM(BLACKBERRY)
+BlackBerry::Platform::logV(BlackBerry::Platform::LogLevelInfo, format, args);
#elif HAVE(ISDEBUGGERPRESENT)
if (IsDebuggerPresent()) {
size_t size = 1024;
Modified: trunk/Source/_javascript_Core/wtf/MathExtras.h (101040 => 101041)
--- trunk/Source/_javascript_Core/wtf/MathExtras.h 2011-11-23 03:16:00 UTC (rev 101040)
+++ trunk/Source/_javascript_Core/wtf/MathExtras.h 2011-11-23 03:30:34 UTC (rev 101041)
@@ -50,6 +50,13 @@
#include limits
#endif
+#if OS(QNX)
+// FIXME: Look into a way to have cmath import its functions into both the standard and global
+// namespace. For now, we include math.h since the QNX cmath header only imports its functions
+// into the standard namespace.
+#include math.h
+#endif
+
#ifndef M_PI
const double piDouble = 3.14159265358979323846;
const float piFloat = 3.14159265358979323846f;
@@ -133,6 +140,11 @@
#endif
+#if COMPILER(GCC) OS(QNX)
+// The stdlib on QNX doesn't contain long abs(long). See PR #104666.
+inline long long abs(long num) { return labs(num); }
+#endif
+
#if COMPILER(MSVC)
// The 64bit version of abs() is already defined in stdlib.h which comes with VC10
#if COMPILER(MSVC9_OR_LOWER)
Modified: trunk/Source/_javascript_Core/wtf/Platform.h (101040 => 101041)
--- trunk/Source/_javascript_Core/wtf/Platform.h 2011-11-23 03:16:00 UTC (rev 101040)
+++ trunk/Source/_javascript_Core/wtf/Platform.h 2011-11-23 03:30:34 UTC (rev 101041)
@@ -1,7 +1,7 @@
/*
*
[webkit-changes] [101043] trunk/LayoutTests
Title: [101043] trunk/LayoutTests Revision 101043 Author o...@webkit.org Date 2011-11-22 23:09:25 -0800 (Tue, 22 Nov 2011) Log Message [Qt][GTK] editing/spelling/spellcheck-async.html fails https://bugs.webkit.org/show_bug.cgi?id=73003 Unreviewed morning gardening. * platform/qt/Skipped: Skip editing/spelling/spellcheck-async.html. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (101042 => 101043) --- trunk/LayoutTests/ChangeLog 2011-11-23 04:08:49 UTC (rev 101042) +++ trunk/LayoutTests/ChangeLog 2011-11-23 07:09:25 UTC (rev 101043) @@ -1,3 +1,12 @@ +2011-11-22 Csaba Osztrogonác o...@webkit.org + +[Qt][GTK] editing/spelling/spellcheck-async.html fails +https://bugs.webkit.org/show_bug.cgi?id=73003 + +Unreviewed morning gardening. + +* platform/qt/Skipped: Skip editing/spelling/spellcheck-async.html. + 2011-11-22 Adam Klein ad...@chromium.org Remove some flaky expectations added by me five months ago. Modified: trunk/LayoutTests/platform/qt/Skipped (101042 => 101043) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-23 04:08:49 UTC (rev 101042) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-23 07:09:25 UTC (rev 101043) @@ -1006,6 +1006,10 @@ # EditorClient::requestCheckingOfString() is not implemented editing/spelling/spellcheck-paste.html +# [Qt][GTK] editing/spelling/spellcheck-async.html fails +# https://bugs.webkit.org/show_bug.cgi?id=73003 +editing/spelling/spellcheck-async.html + # = # # failing editing/style tests # = # ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101044] trunk/Source/WebKit/chromium
Title: [101044] trunk/Source/WebKit/chromium
Revision 101044
Author dpra...@chromium.org
Date 2011-11-22 23:12:57 -0800 (Tue, 22 Nov 2011)
Log Message
Roll DEPS to r111325 to fix an issue with the linux build
https://bugs.webkit.org/show_bug.cgi?id=73004
Unreviewed, build fix.
There appears to be a bug in the Makefile generator for gyp
that is causing make to not rebuild DRT on Linux.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (101043 => 101044)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-23 07:09:25 UTC (rev 101043)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-23 07:12:57 UTC (rev 101044)
@@ -1,3 +1,16 @@
+2011-11-22 Dirk Pranke dpra...@chromium.org
+
+Roll DEPS to r111325 to fix an issue with the linux build
+
+https://bugs.webkit.org/show_bug.cgi?id=73004
+
+Unreviewed, build fix.
+
+There appears to be a bug in the Makefile generator for gyp
+that is causing make to not rebuild DRT on Linux.
+
+* DEPS:
+
2011-11-22 Kenneth Russell k...@google.com
[chromium] Support Core Animation plugins in compositor
Modified: trunk/Source/WebKit/chromium/DEPS (101043 => 101044)
--- trunk/Source/WebKit/chromium/DEPS 2011-11-23 07:09:25 UTC (rev 101043)
+++ trunk/Source/WebKit/chromium/DEPS 2011-11-23 07:12:57 UTC (rev 101044)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '78',
+ 'chromium_rev': '111325',
'nacl_svn': 'http://src.chromium.org/native_client/trunk',
'nacl_rev': '7169',
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
