[webkit-changes] [111653] trunk

[yurys]

Title: [111653] trunk








Revision 111653
Author yu...@chromium.org
Date 2012-03-21 23:17:24 -0700 (Wed, 21 Mar 2012)


Log Message
Web Inspector: event listeners section is broken for about:blank page
https://bugs.webkit.org/show_bug.cgi?id=81795

Source/WebCore:

Parse about:blank as a valid URL.

Reviewed by Pavel Feldman.

Test: inspector/elements/event-listeners-about-blank.html

* inspector/front-end/utilities.js:
(String.prototype.asParsedURL):

LayoutTests:

Reviewed by Pavel Feldman.

* inspector/elements/event-listeners-about-blank-expected.txt: Added.
* inspector/elements/event-listeners-about-blank.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/utilities.js


Added Paths

trunk/LayoutTests/inspector/elements/event-listeners-about-blank-expected.txt
trunk/LayoutTests/inspector/elements/event-listeners-about-blank.html




Diff

Modified: trunk/LayoutTests/ChangeLog (111652 => 111653)

--- trunk/LayoutTests/ChangeLog	2012-03-22 04:58:22 UTC (rev 111652)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 06:17:24 UTC (rev 111653)
@@ -1,3 +1,13 @@
+2012-03-21  Yury Semikhatsky  yu...@chromium.org
+
+Web Inspector: event listeners section is broken for about:blank page
+https://bugs.webkit.org/show_bug.cgi?id=81795
+
+Reviewed by Pavel Feldman.
+
+* inspector/elements/event-listeners-about-blank-expected.txt: Added.
+* inspector/elements/event-listeners-about-blank.html: Added.
+
 2012-03-21  Raphael Kubo da Costa  rak...@freebsd.org
 
 [EFL] Unreviewed gardening.


Added: trunk/LayoutTests/inspector/elements/event-listeners-about-blank-expected.txt (0 => 111653)

--- trunk/LayoutTests/inspector/elements/event-listeners-about-blank-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/elements/event-listeners-about-blank-expected.txt	2012-03-22 06:17:24 UTC (rev 111653)
@@ -0,0 +1,24 @@
+Tests event listeners output in the Elements sidebar panel when the listeners are added on an element in about:blank page.
+
+
+
+ click 
+[expanded] body event-listeners-about-blank.html:9
+isAttribute: false
+lineNumber: 9
+listenerBody: function f() {}
+node: HTMLBodyElement
+sourceName: [clipped-for-test]/LayoutTests/inspector/elements/event-listeners-about-blank.html
+type: click
+useCapture: true
+
+ hover 
+[expanded] div#div-in-iframe event-listeners-about-blank.html:9
+isAttribute: false
+lineNumber: 9
+listenerBody: function f() {}
+node: HTMLDivElement
+sourceName: [clipped-for-test]/LayoutTests/inspector/elements/event-listeners-about-blank.html
+type: hover
+useCapture: true
+
Property changes on: trunk/LayoutTests/inspector/elements/event-listeners-about-blank-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/inspector/elements/event-listeners-about-blank.html (0 => 111653)

--- trunk/LayoutTests/inspector/elements/event-listeners-about-blank.html	(rev 0)
+++ trunk/LayoutTests/inspector/elements/event-listeners-about-blank.html	2012-03-22 06:17:24 UTC (rev 111653)
@@ -0,0 +1,46 @@
+html
+head
+script src=""
+script src=""
+script
+
+function setupEventListeners()
+{
+function f() {}
+var frame = document.getElementById(myframe);
+var body = frame.contentDocument.body;
+body.addEventListener(click, f, true);
+var div = frame.contentDocument.createElement(div);
+div.id = div-in-iframe;
+div.addEventListener(hover, f, true);
+body.appendChild(div);
+}
+
+function test()
+{
+WebInspector.settings.eventListenersFilter.set(all);
+InspectorTest.selectNodeWithId(div-in-iframe, step1);
+
+function step1()
+{
+InspectorTest.expandAndDumpSelectedElementEventListeners(InspectorTest.completeTest);
+}
+}
+
+function onloadHandler()
+{
+setupEventListeners();
+runTest();
+}
+/script
+/head
+
+body _onload_=onloadHandler()
+p
+Tests event listeners output in the Elements sidebar panel when the listeners are added on an element in about:blank page.
+/p
+
+iframe id=myframe/iframe
+
+/body
+/html
Property changes on: trunk/LayoutTests/inspector/elements/event-listeners-about-blank.html
___


Added: svn:eol-style

Modified: trunk/Source/WebCore/ChangeLog (111652 => 111653)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 04:58:22 UTC (rev 111652)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 06:17:24 UTC (rev 111653)
@@ -1,3 +1,17 @@
+2012-03-21  Yury Semikhatsky  yu...@chromium.org
+
+Web Inspector: event listeners section is broken for about:blank page
+https://bugs.webkit.org/show_bug.cgi?id=81795
+
+Parse about:blank as a valid URL.
+
+Reviewed by Pavel Feldman.
+
+Test: 

[webkit-changes] [111654] trunk/Source/WebCore

[vsevik]

Title: [111654] trunk/Source/WebCore








Revision 111654
Author vse...@chromium.org
Date 2012-03-21 23:53:07 -0700 (Wed, 21 Mar 2012)


Log Message
Web Inspector: IndexedDB transaction is not closed when requesting data.
https://bugs.webkit.org/show_bug.cgi?id=81837

Reviewed by Pavel Feldman.

* inspector/InspectorIndexedDBAgent.cpp: Added missing IDBCursorBackendInterface::postSuccessHandlerCallback() call.
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (111653 => 111654)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 06:17:24 UTC (rev 111653)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 06:53:07 UTC (rev 111654)
@@ -1,3 +1,13 @@
+2012-03-21  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: IndexedDB transaction is not closed when requesting data.
+https://bugs.webkit.org/show_bug.cgi?id=81837
+
+Reviewed by Pavel Feldman.
+
+* inspector/InspectorIndexedDBAgent.cpp: Added missing IDBCursorBackendInterface::postSuccessHandlerCallback() call.
+(WebCore):
+
 2012-03-21  Yury Semikhatsky  yu...@chromium.org
 
 Web Inspector: event listeners section is broken for about:blank page


Modified: trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp (111653 => 111654)

--- trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp	2012-03-22 06:17:24 UTC (rev 111653)
+++ trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp	2012-03-22 06:53:07 UTC (rev 111654)
@@ -456,6 +456,7 @@
 {
 ExceptionCode ec = 0;
 m_idbCursor-continueFunction(0, this, ec);
+m_idbCursor-postSuccessHandlerCallback();
 m_idbTransaction-didCompleteTaskEvents();
 }
 
@@ -464,6 +465,7 @@
 if (!m_frontendProvider-frontend())
 return;
 
+m_idbCursor-postSuccessHandlerCallback();
 m_idbTransaction-didCompleteTaskEvents();
 
 switch (m_cursorType) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111656] trunk/Source/WebKit/chromium

[bashi]

Title: [111656] trunk/Source/WebKit/chromium








Revision 111656
Author ba...@chromium.org
Date 2012-03-22 00:25:45 -0700 (Thu, 22 Mar 2012)


Log Message
[Chromium] Should check m_socket in SocketStreamHandleInternal::close()
https://bugs.webkit.org/show_bug.cgi?id=81860

Reviewed by Kent Tamura.

m_socket could be NULL if WebSocket::resume() is called after SocketStreamHandle::didClose() is called.
This could happen when the page shows a popup dialog (by using alert()) immediately after closing an WebSocket object.

* src/SocketStreamHandle.cpp:
(WebCore::SocketStreamHandleInternal::close): Ensures m_socket is not NULL.

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (111655 => 111656)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-03-22 07:15:18 UTC (rev 111655)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-03-22 07:25:45 UTC (rev 111656)
@@ -1,3 +1,16 @@
+2012-03-22  Kenichi Ishibashi  ba...@chromium.org
+
+[Chromium] Should check m_socket in SocketStreamHandleInternal::close()
+https://bugs.webkit.org/show_bug.cgi?id=81860
+
+Reviewed by Kent Tamura.
+
+m_socket could be NULL if WebSocket::resume() is called after SocketStreamHandle::didClose() is called.
+This could happen when the page shows a popup dialog (by using alert()) immediately after closing an WebSocket object.
+
+* src/SocketStreamHandle.cpp:
+(WebCore::SocketStreamHandleInternal::close): Ensures m_socket is not NULL.
+
 2012-03-21  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r111616.


Modified: trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp (111655 => 111656)

--- trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp	2012-03-22 07:15:18 UTC (rev 111655)
+++ trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp	2012-03-22 07:25:45 UTC (rev 111656)
@@ -92,7 +92,8 @@
 void SocketStreamHandleInternal::close()
 {
 LOG(Network, close);
-m_socket-close();
+if (m_socket)
+m_socket-close();
 }
 
 void SocketStreamHandleInternal::didOpenStream(WebSocketStreamHandle* socketHandle, int maxPendingSendAllowed)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111657] trunk/LayoutTests

[keishi]

Title: [111657] trunk/LayoutTests








Revision 111657
Author kei...@webkit.org
Date 2012-03-22 00:47:21 -0700 (Thu, 22 Mar 2012)


Log Message
[chromium] Unreviewed gardening.

Left over rebaseline from r111621.

* platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (111656 => 111657)

--- trunk/LayoutTests/ChangeLog	2012-03-22 07:25:45 UTC (rev 111656)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 07:47:21 UTC (rev 111657)
@@ -1,3 +1,11 @@
+2012-03-22  Keishi Hattori  kei...@webkit.org
+
+[chromium] Unreviewed gardening.
+
+Left over rebaseline from r111621.
+
+* platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png:
+
 2012-03-21  Pavel Podivilov  podivi...@chromium.org
 
 Web Inspector: rename ClosureCompilerSourceMapping to SourceMapParser and move it to CompilerScriptMapping.js.


Modified: trunk/LayoutTests/platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png (111656 => 111657)

--- trunk/LayoutTests/platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png	2012-03-22 07:25:45 UTC (rev 111656)
+++ trunk/LayoutTests/platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png	2012-03-22 07:47:21 UTC (rev 111657)
@@ -1,7 +1,7 @@
 \x89PNG
 
 
-IHDR X')tEXtchecksum79a58fb9b0d270b9515be76b94cd60d7.CϹ IDATx\x9C\xEC\xBDy\x90$\xD7}\xDF\xF9\xC9;\xEB\xE8\xBBgz\xBA\xE7œ\xC0038\x86\xC0^\x80h\xA4PEY\xB1\x92\xBCCkGر\x96%{\xB5k\xC4D\xD8k[\xD2:,\x87Ġ\xE5ݥMҖM\x91\x94@\x91H\x82/\xD7`\x80\x99\xC1\x9C\xDD=\xD3\xDD\xD3g\xDDy\xBC\xFD\xA3\x8E\xAE\xAA\xCC\x{1EAEA7}{ \xBFQ\xD1]\x95/3++3\xBF/\xBF\xEF\xF7\xFB\xBD\xDFOB\x90 A\x82	$H\x90`\xED\xA0_\xEFH\x90 A\x82	$x\xA7!X	$H\x90 A\x82k\x8CD`%H\x90 A\x82	\xAC1\x81\x95 A\x82	$H\xB0\xC6HV\x82	$H\x90 \xC1#X	$H\x90 A\x82k\x8CD`%H\x90 A\x82	\xAC1\x81\x95 A\x82	$H\xB0\xC60\xAF\xF7
$H\x90 A\x82\xEF|\xF6\xF0\xD1\xE6\x8F\xFE\xE2\xD7\xEBH\_$+A\x82	$X%\xFE\xC9\xE1\xA3\xF0\xAF\xF7a$\xB8
\x91\xAC	$H\x90\xA0+\xFC\x93V\xEBT\xC1\xB5?\x8E7\x81\x95 A\x82	\xC4\xE0h]NP\x94\xAC# )\xE8\x9B \x89\xC0J\x90 A\x82	\xF8\x93\xC3G\x97$M
+IHDR X')tEXtchecksum42cb6ff83b10f5a1e77af41257a786ed\x92vC\x81 IDATx\x9C\xEC\xBDy\x90$\xD7}\xDF\xF9\xC9;\xEB\xE8\xBBgz\xBA\xE7œ\xC0038\x86\xC0^\x80h\xA4PEY\xB1\x92\xBCCkGر\x96%{\xB5k\xC4D\xD8k[\xD2:,\x87Ġ\xE5ݥMҖM\x91\x94@\x91H\x82/\xD7`\x80\x99\xC1\x9C\xDD=\xD3\xDD\xD3g\xDDy\xBC\xFD\xA3\x8E\xAE\xAA\xCC\x{1EAEA7}{ \xBFQ\xD1]\x95/3++3\xBF/\xBF\xEF\xF7\xFB\xBD\xDFOB\x90 A\x82	$H\x90`\xED\xA0_\xEFH\x90 A\x82	$x\xA7!X	$H\x90 A\x82k\x8CD`%H\x90 A\x82	\xAC1\x81\x95 A\x82	$H\xB0\xC6HV\x82	$H\x90 \xC1#X	$H\x90 A\x82k\x8CD`%H\x90 A\x82	\xAC1\x81\x95 A\x82	$H\xB0\xC60\xAF\xF7
$H\x90 A\x82\xEF|\xF6\xF0\xD1\xE6\x8F\xFE\xE2\xD7\xEBH\_$+A\x82	$X%\xFE\xC9\xE1\xA3\xF0\xAF\xF7a$\xB8
\x91\xAC	$H\x90\xA0+\xFC\x93V\xEBT\xC1\xB5?\x8E7\x81\x95 A\x82	\xC4\xE0h]NP\x94\xAC# )\xE8\x9B \x89\xC0J\x90 A\x82	\xF8\x93\xC3G\x97$M
 Ub\xBEJ C\xB0$H\x90 \xC1\xBBq\xF6\x85\xF2\x95W\xD7D\xE1\xFE\xEEF\xB0$H\x90 \xC1;\x9Fo\x92S(ŭ\xB3:3Ub\xC1J C\xB0$H\x90 \xC1;
 Y\x97Sq\xAD\xB2\x8A\x99\x80\x8A(\xABD`%\x90!X	$H\x90\xE0Ʒ\xF5 Y.L2I\xB4\xD2\xE5U\xA8]\x84	\xDE\xCDHV\x82	$\xB8i\xF0\xC2\xE1\xA3\xF3\x91\x85^ܚ\xB1\x91\x9B\xA3d\xCB*1_%P X7
 \xAA\xC9\x93\x88\xC8	\xDEI\xD04
@@ -150,22 +150,23 @@
 2\x84\xD1\xF03\x8E@VR\x9A\xF0u\xF9\xC1\xDF\xEBز\xBCϐ\x89X\xC0\xED\xAFǙ\x9D\x9E\xC7\xF9Sɠ\xE1\xE1\xBA,3\xF5\Շ\x86\xF6\xAF(7[\xC2\xD0.\xA0_@{.m\xBCX\xF2r\x82\H\xB3\xF5˶\xED\xB5X\xB2J\xCF
 \xF4\xF5
 |\xE0\xFD\xEF\xABꪶ\xCDue\xB59\xC30\xEE\x9Eh\xCAP\xA7B\xAAD\xAAH\xAA\xC4K\xF6q\xB9\x84:\xD1\xD3\xE1\xDEߟ\xB5\xD4\xEB\xF4\x8F\x{DDDE}v\x{1BEBEC}\xE5\xFC\xAA\x9C\xB2\x8E͙\xC7\xE6\x9A\xA7\xDEj\xBD\xFAFW\xBCt\xC6R̲\xF8\x9B\xF4k\xF7\x95w\xDC_ޡ^\xAD\x9F\xA1\xDF]w_\xAA
XU\xECm\xED3\xDF\\xC9~\xB6N
 \xA0R\xF3\xABw
-Y\x97\xAC\xCB\x93\x83s,e\xC9e\x97s\xF9E\xC7^4\xB5\x83\H\xC5ں\x90[\xB0\x84\xF8\xFFۻ\xDB\xBB\xEA;\xB1\xE3\xBF\xFB43w\xE3\xB1M0\xD8$66\xB6C\x9C\x90\x84M\xA5TL\xD3\xABdW\xEAVM7j_T]\xF5Q+u#T\xAD6\xD5v[\xB5վ\xE8\x8B\xE6\xC5J]EQ\xB7ݴi\xAA\xD0\xC5iL
\xB1
0\xC4`\xB6\xB1=\xF6xOw\xE6޾\xF0ӌ\xE7\x9C3~a!\xFA|d!Ͻg\xFB\xBF\xF7;\xE7\xFC\xCF\xFF\xBC\x9D\x84:\xFF\xA9\xD5\xF9\xCBJۃ\xB5r\xE5Ȏ\xF7澭\xB1\xEC\xAA\x97\x89kF\xCCG\xCCDL_\xFC\xB3\xC0\xC6v\xEC+\xAC}\x83͘,\x9F\xC9\xD2\xDF\xDC\xD8n*\xB9HE\xB7Q\xEB\xB4\xAF\xFEaw\xD3О\xD8Wz\x8D\x8E\x88\xF9zs_\xCC\xDE]\xBEAD\xC4Ms?\xDCЩ-\xF3\x9B\xDCO\x86\x9E\xFA\xD4̍E\x98\x89x\xF2ݘpi\xD6R\xEB\xA3\xF4

[webkit-changes] [111658] trunk/Tools

[ossy]

Title: [111658] trunk/Tools








Revision 111658
Author o...@webkit.org
Date 2012-03-22 00:51:06 -0700 (Thu, 22 Mar 2012)


Log Message
[Qt] Add full platforms to Qt buildslaves
https://bugs.webkit.org/show_bug.cgi?id=81877

Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/build.webkit.org-config/config.json:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (111657 => 111658)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2012-03-22 07:47:21 UTC (rev 111657)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2012-03-22 07:51:06 UTC (rev 111658)
@@ -37,16 +37,16 @@
 { name: gtk-linux-slave-2, platform: gtk},
 { name: gtk-linux-slave-3, platform: gtk},
 
-{ name: szeged-linux-1, platform: qt},
-{ name: szeged-linux-2, platform: qt},
-{ name: szeged-linux-3, platform: qt},
-{ name: szeged-linux-4, platform: qt},
-{ name: szeged-linux-5, platform: qt},
+{ name: szeged-linux-1, platform: qt-4.8},
+{ name: szeged-linux-2, platform: qt-4.8},
+{ name: szeged-linux-3, platform: qt-5.0-wk1},
+{ name: szeged-linux-4, platform: qt-arm},
+{ name: szeged-linux-5, platform: qt-5.0-wk2},
 
-{ name: szeged-windows-1, platform: qt},
-{ name: szeged-windows-2, platform: qt},
+{ name: szeged-windows-1, platform: qt-win},
+{ name: szeged-windows-2, platform: qt-win},
 
-{ name: indt-snowleopard, platform: qt},
+{ name: indt-snowleopard, platform: qt-mac},
 
 { name: google-windows-1, platform: chromium-win },
 { name: google-windows-2, platform: chromium-win },
@@ -176,42 +176,42 @@
 },
 {
   name: Qt Linux Release, type: BuildAndTest, builddir: qt-linux-release,
-  platform: qt, configuration: release, architectures: [i386],
+  platform: qt-4.8, configuration: release, architectures: [i386],
   slavenames: [szeged-linux-1]
 },
 {
   name: Qt Linux Release minimal, type: Build, builddir: qt-linux-release-minimal,
-  platform: qt, configuration: release, architectures: [i386],
+  platform: qt-4.8, configuration: release, architectures: [i386],
   slavenames: [szeged-linux-2]
 },
 {
   name: Qt Linux 64-bit Release (Perf), type: BuildAndPerfTest, builddir: qt-linux-64-release-perf-tests,
-  platform: qt, configuration: release, architectures: [x86_64],
+  platform: qt-5.0-wk1, configuration: release, architectures: [x86_64],
   slavenames: [szeged-linux-3]
 },
 {
   name: Qt Linux 64-bit Release (WebKit2 Perf), type: BuildAndPerfTestWebKit2, builddir: qt-linux-64-release-wk2-perf-tests,
-  platform: qt, configuration: release, architectures: [x86_64],
+  platform: qt-5.0-wk2, configuration: release, architectures: [x86_64],
   slavenames: [szeged-linux-5]
 },
 {
   name: Qt Linux ARMv7 Release, type: Build, builddir: qt-linux-armv7-release,
-  platform: qt, configuration: release, architectures: [armv7],
+  platform: qt-arm, configuration: release, architectures: [armv7],
   slavenames: [szeged-linux-4]
 },
 {
   name: Qt Windows 32-bit Release, type: Build, builddir: qt-windows-32bit-release,
-  platform: qt, configuration: release, architectures: [i386],
+  platform: qt-win, configuration: release, architectures: [i386],
   slavenames: [szeged-windows-1]
 },
 {
   name: Qt Windows 32-bit Debug, type: Build, builddir: qt-windows-32bit-debug,
-  platform: qt, configuration: debug, architectures: [i386],
+  platform: qt-win, configuration: debug, architectures: [i386],
   slavenames: [szeged-windows-2]
 },
 {
   name: Qt SnowLeopard Release, type: Build, builddir: qt-snowleopard-release,
-  platform: qt, configuration: release, architectures: [x86_64],

[webkit-changes] [111659] trunk

[commit-queue]

Title: [111659] trunk








Revision 111659
Author commit-qu...@webkit.org
Date 2012-03-22 01:04:11 -0700 (Thu, 22 Mar 2012)


Log Message
[Forms] The option element should not be form associated element.
https://bugs.webkit.org/show_bug.cgi?id=79764

Patch by Yoshifumi Inoue yo...@chromium.org on 2012-03-22
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes base class of HTMLOptionELement to HTMLElement
from HTMLFormControlElement for saving memory space and iteration
time of extra option elements in HTMLFormElement::m_formAssociatedElements
and matching the HTML5 specification for ease of maintenance.

This patch changes behavior of handling of CSS pseudo classes invalid
and valid. The option elements no longer use these CSS pseudo classes
as HTML5 specification. This bug was filed in https://bugs.webkit.org/show_bug.cgi?id=80088

Changes of TextIterator is lead by usage of isFormControlElement. This
changes will be replaced with more meaningful predicate as part of
https://bugs.webkit.org/show_bug.cgi?id=80381

No new tests but updated select-live-pseudo-selectors.html test.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement): Added checking of the option element and returns false as HTMLFormControlElement.
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Removed isFormControlElement for PseudoDisabled and PseudoChecked.
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement): Removed form parameter of call site of HTMLOptionElement::create.
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::HTMLOptionElement): Removed form parameter which no longer needed. Changed base class in initialization list. Added m_disabled initialization.
(WebCore::HTMLOptionElement::create): Removed form parameter which no longer needed.
(WebCore::HTMLOptionElement::attach): Changeid base class.
(WebCore::HTMLOptionElement::detach): Changed base class.
(WebCore::HTMLOptionElement::parseAttribute): Changed base class. Added disabled attribute handling.
(WebCore::HTMLOptionElement::childrenChanged): Changed base class.
(WebCore::HTMLOptionElement::insertedIntoTree): Changed base class.
* html/HTMLOptionElement.h:
(HTMLOptionElement): Added new member variable m_disabled which was in HTMLFormControlElement.
(WebCore::HTMLOptionElement::ownElementDisabled): Changed for using m_disabled.
* html/HTMLTagNames.in: Removed constructorNeedsFormElement for the option element, which was used for passing form parameter to create function.

LayoutTests:

This patch fixes a bug in select-live-pseudo-selectors.js, adds
assertions to improve coverage, and updates test expectation for
behavior changes (makes the option element uses CSS pseudo class
:valid.)

* fast/forms/resources/select-live-pseudo-selectors.js:
(mouseDownOnSelect): Copied from listbox-selection.html for replacing broken simulateClick which used position and size of the option element, but these values are zero. Note: five files use mouseDownOnSelect. We'll share this function in future tracked by https://bugs.webkit.org/show_bug.cgi?id=81496.
(backgroundOf): Added String parameter support for ease of writing test case.
* fast/forms/select-live-pseudo-selectors-expected.txt: Added check fo background color of the selection element. Changed expected color of the option element because the option element doesn't support CSS pseudo class :valid. This also covers bug 80088.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/resources/select-live-pseudo-selectors.js
trunk/LayoutTests/fast/forms/select-live-pseudo-selectors-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/css/SelectorChecker.cpp
trunk/Source/WebCore/html/HTMLKeygenElement.cpp
trunk/Source/WebCore/html/HTMLOptionElement.cpp
trunk/Source/WebCore/html/HTMLOptionElement.h
trunk/Source/WebCore/html/HTMLTagNames.in




Diff

Modified: trunk/LayoutTests/ChangeLog (111658 => 111659)

--- trunk/LayoutTests/ChangeLog	2012-03-22 07:51:06 UTC (rev 111658)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 08:04:11 UTC (rev 111659)
@@ -1,3 +1,20 @@
+2012-03-22  Yoshifumi Inoue  yo...@chromium.org
+
+[Forms] The option element should not be form associated element.
+https://bugs.webkit.org/show_bug.cgi?id=79764
+
+Reviewed by Kent Tamura.
+
+This patch fixes a bug in select-live-pseudo-selectors.js, adds
+assertions to improve coverage, and updates test expectation for
+behavior changes (makes the option element uses CSS pseudo class
+:valid.)
+
+* fast/forms/resources/select-live-pseudo-selectors.js:
+(mouseDownOnSelect): Copied from listbox-selection.html for replacing broken simulateClick which used position and size of the option element, but these values are zero. Note: five files use mouseDownOnSelect. We'll share this function in future tracked by 

[webkit-changes] [111660] trunk/Source/WebCore

[tkent]

Title: [111660] trunk/Source/WebCore








Revision 111660
Author tk...@chromium.org
Date 2012-03-22 01:06:37 -0700 (Thu, 22 Mar 2012)


Log Message
Expand RenderTextControlSingleLine::controlClipRect() to contain contentRect().
https://bugs.webkit.org/show_bug.cgi?id=81866

Reviewed by Hajime Morita.

We need to expand the controlClipRect because the existing shadow
tree of a text field can be wrapped by another shadow tree. e.g.

A current situation:

input
  ┗ ShadowRoot
 ┗ container element
┌┐input's border box
│┌──┐│
││container box   ││
│└──┘│
└┘

Wrapped by another ShadowRoot:

input
  ┗ New ShadowRoot
 ┣ shadow represents the existing shadow tree
 ┃  ┗ container element
 ┗ D: an additional decoration element
┌┐input's border box
│┌───┬──┐│
││container box │ D  ││
│└───┴──┘│
└┘
In this case, if we clip child renderers by container box, D is not
drawn. We should clip by the content box of the input.

A search field has an exceptional behavior. It can have the container
box of which height is taller than the content box height. The
controlClipRect should contain both of the container box and the content
box in this case. In other cases, the container box is equivalent to the
content box. So the code always unites them.

No new tests. This won't make any behavior change for now.

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::controlClipRect):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (111659 => 111660)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 08:04:11 UTC (rev 111659)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 08:06:37 UTC (rev 111660)
@@ -1,3 +1,50 @@
+2012-03-22  Kent Tamura  tk...@chromium.org
+
+Expand RenderTextControlSingleLine::controlClipRect() to contain contentRect().
+https://bugs.webkit.org/show_bug.cgi?id=81866
+
+Reviewed by Hajime Morita.
+
+We need to expand the controlClipRect because the existing shadow
+tree of a text field can be wrapped by another shadow tree. e.g.
+
+A current situation:
+
+input
+  ┗ ShadowRoot
+ ┗ container element
+┌┐input's border box
+│┌──┐│
+││container box   ││
+│└──┘│
+└┘
+
+Wrapped by another ShadowRoot:
+
+input
+  ┗ New ShadowRoot
+ ┣ shadow represents the existing shadow tree
+ ┃  ┗ container element
+ ┗ D: an additional decoration element
+┌┐input's border box
+│┌───┬──┐│
+││container box │ D  ││
+│└───┴──┘│
+└┘
+In this case, if we clip child renderers by container box, D is not
+drawn. We should clip by the content box of the input.
+
+A search field has an exceptional behavior. It can have the container
+box of which height is taller than the content box height. The
+controlClipRect should contain both of the container box and the content
+box in this case. In other cases, the container box is equivalent to the
+content box. So the code always unites them.
+
+No new tests. This won't make any behavior change for now.
+
+* rendering/RenderTextControlSingleLine.cpp:
+(WebCore::RenderTextControlSingleLine::controlClipRect):
+
 2012-03-22  Yoshifumi Inoue  yo...@chromium.org
 
 [Forms] The option element should not be form associated element.


Modified: trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp (111659 => 111660)

--- trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp	2012-03-22 08:04:11 UTC (rev 111659)
+++ trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp	2012-03-22 08:06:37 UTC (rev 111660)
@@ -370,7 +370,7 @@
 LayoutRect RenderTextControlSingleLine::controlClipRect(const LayoutPoint additionalOffset) const
 {
 ASSERT(hasControlClip());
-LayoutRect clipRect = LayoutRect(containerElement()-renderBox()-frameRect());
+LayoutRect clipRect = unionRect(contentBoxRect(), containerElement()-renderBox()-frameRect());
 clipRect.moveBy(additionalOffset);
 return clipRect;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111661] trunk/Tools

[ossy]

Title: [111661] trunk/Tools








Revision 111661
Author o...@webkit.org
Date 2012-03-22 01:18:39 -0700 (Thu, 22 Mar 2012)


Log Message
webkitpy: clean up actually getting crash logs from DRT/WTR crashes
https://bugs.webkit.org/show_bug.cgi?id=81603

Unreviewed rolling out r111609 and part of r111615,
because it broke NRWT on Qt-WK2 platform.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._handle_error):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
(TestResultWriter.write_crash_report):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.is_crash_reporter):
(Port._driver_class):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.run_test):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_crashed_process_name):
* Scripts/webkitpy/layout_tests/port/driver.py:
(DriverOutput.__init__):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort):
(MacPort.is_crash_reporter):
(MacPort.release_http_lock):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestDriver.run_test):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.__init__):
(WebKitDriver._start):
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver.run_test):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py




Diff

Modified: trunk/Tools/ChangeLog (111660 => 111661)

--- trunk/Tools/ChangeLog	2012-03-22 08:06:37 UTC (rev 111660)
+++ trunk/Tools/ChangeLog	2012-03-22 08:18:39 UTC (rev 111661)
@@ -1,5 +1,40 @@
 2012-03-22  Csaba Osztrogonác  o...@webkit.org
 
+webkitpy: clean up actually getting crash logs from DRT/WTR crashes
+https://bugs.webkit.org/show_bug.cgi?id=81603
+
+Unreviewed rolling out r111609 and part of r111615,
+because it broke NRWT on Qt-WK2 platform.
+
+* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
+(SingleTestRunner._handle_error):
+* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
+(write_test_result):
+(TestResultWriter.write_crash_report):
+* Scripts/webkitpy/layout_tests/port/base.py:
+(Port.is_crash_reporter):
+(Port._driver_class):
+* Scripts/webkitpy/layout_tests/port/chromium.py:
+(ChromiumDriver.run_test):
+* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
+(ChromiumDriverTest.test_crashed_process_name):
+* Scripts/webkitpy/layout_tests/port/driver.py:
+(DriverOutput.__init__):
+* Scripts/webkitpy/layout_tests/port/mac.py:
+(MacPort):
+(MacPort.is_crash_reporter):
+(MacPort.release_http_lock):
+* Scripts/webkitpy/layout_tests/port/test.py:
+(TestDriver.run_test):
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitDriver.__init__):
+(WebKitDriver._start):
+(WebKitDriver.has_crashed):
+(WebKitDriver._check_for_driver_crash):
+(WebKitDriver.run_test):
+
+2012-03-22  Csaba Osztrogonác  o...@webkit.org
+
 [Qt] Add full platforms to Qt buildslaves
 https://bugs.webkit.org/show_bug.cgi?id=81877
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (111660 => 111661)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py	2012-03-22 08:06:37 UTC (rev 111660)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py	2012-03-22 08:18:39 UTC (rev 111661)
@@ -198,9 +198,7 @@
 testname = self._test_name
 
 if driver_output.crash:
-failures.append(test_failures.FailureCrash(bool(reference_filename),
-   driver_output.crashed_process_name,
-   driver_output.crashed_pid))
+failures.append(test_failures.FailureCrash(bool(reference_filename)))
 if driver_output.error:
 _log.debug(%s %s crashed, stack trace: % (self._worker_name, testname))
 else:


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py (111660 => 111661)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py	2012-03-22 08:06:37 UTC (rev 111660)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py	2012-03-22 08:18:39 UTC 

[webkit-changes] [111662] trunk/Tools

[philn]

Title: [111662] trunk/Tools








Revision 111662
Author ph...@webkit.org
Date 2012-03-22 01:44:47 -0700 (Thu, 22 Mar 2012)


Log Message
Unreviewed, test-webkitpy fix after r111642.

* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.setUp):
(ChromiumDriverTest.test_two_drivers):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (111661 => 111662)

--- trunk/Tools/ChangeLog	2012-03-22 08:18:39 UTC (rev 111661)
+++ trunk/Tools/ChangeLog	2012-03-22 08:44:47 UTC (rev 111662)
@@ -1,3 +1,11 @@
+2012-03-22  Philippe Normand  pnorm...@igalia.com
+
+Unreviewed, test-webkitpy fix after r111642.
+
+* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
+(ChromiumDriverTest.setUp):
+(ChromiumDriverTest.test_two_drivers):
+
 2012-03-22  Csaba Osztrogonác  o...@webkit.org
 
 webkitpy: clean up actually getting crash logs from DRT/WTR crashes


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py (111661 => 111662)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py	2012-03-22 08:18:39 UTC (rev 111661)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py	2012-03-22 08:44:47 UTC (rev 111662)
@@ -52,6 +52,7 @@
 class ChromiumDriverTest(unittest.TestCase):
 def setUp(self):
 mock_port = Mock()  # FIXME: This should use a tighter mock.
+mock_port.default_test_timeout_ms = lambda: 1000
 self.driver = chromium.ChromiumDriver(mock_port, worker_number=0, pixel_tests=True)
 
 def test_test_shell_command(self):
@@ -143,6 +144,7 @@
 
 # get_option is used to get the timeout (ms) for a process before we kill it.
 mock_port.get_option = lambda name: 60 * 1000
+mock_port.default_test_timeout_ms = lambda: 1000
 driver1 = MockDriver()
 driver1._start(False, [])
 driver2 = MockDriver()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111663] trunk/Tools

[philn]

Title: [111663] trunk/Tools








Revision 111663
Author ph...@webkit.org
Date 2012-03-22 02:34:41 -0700 (Thu, 22 Mar 2012)


Log Message
Unreviewed, test-webkitpy fix after r111661.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_crash_log):
(MainTest.test_web_process_crash_log):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py




Diff

Modified: trunk/Tools/ChangeLog (111662 => 111663)

--- trunk/Tools/ChangeLog	2012-03-22 08:44:47 UTC (rev 111662)
+++ trunk/Tools/ChangeLog	2012-03-22 09:34:41 UTC (rev 111663)
@@ -1,5 +1,13 @@
 2012-03-22  Philippe Normand  pnorm...@igalia.com
 
+Unreviewed, test-webkitpy fix after r111661.
+
+* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
+(MainTest.test_crash_log):
+(MainTest.test_web_process_crash_log):
+
+2012-03-22  Philippe Normand  pnorm...@igalia.com
+
 Unreviewed, test-webkitpy fix after r111642.
 
 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py (111662 => 111663)

--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py	2012-03-22 08:44:47 UTC (rev 111662)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py	2012-03-22 09:34:41 UTC (rev 111663)
@@ -584,6 +584,9 @@
 
 def test_crash_log(self):
 # FIXME: Need to rewrite these tests to not be mac-specific, or move them elsewhere.
+# Currently CrashLog uploading only works on Darwin.
+if sys.platform != darwin:
+return
 mock_crash_report = make_mock_crash_report_darwin('DumpRenderTree', 12345)
 host = MockHost()
 host.filesystem.write_text_file('/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06-13-150719_quadzen.crash', mock_crash_report)
@@ -594,13 +597,13 @@
 record_results=True,
 host=host)
 expected_crash_log = mock_crash_report
-# Currently CrashLog uploading only works on Darwin.
-if sys.platform != darwin:
-expected_crash_log = 
 self.assertEquals(host.filesystem.read_text_file('/tmp/layout-test-results/failures/unexpected/crash-with-stderr-crash-log.txt'), expected_crash_log)
 
 def test_web_process_crash_log(self):
 # FIXME: Need to rewrite these tests to not be mac-specific, or move them elsewhere.
+# Currently CrashLog uploading only works on Darwin.
+if sys.platform != darwin:
+return
 mock_crash_report = make_mock_crash_report_darwin('WebProcess', 12345)
 host = MockHost()
 host.filesystem.write_text_file('/Users/mock/Library/Logs/DiagnosticReports/WebProcess_2011-06-13-150719_quadzen.crash', mock_crash_report)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111665] branches/subpixellayout/Source/WebCore

[leviw]

Title: [111665] branches/subpixellayout/Source/WebCore








Revision 111665
Author le...@chromium.org
Date 2012-03-22 02:43:46 -0700 (Thu, 22 Mar 2012)


Log Message
Removing unnecessary exposure of LayoutUnits from Accessibility and Frame. Reverting unnecessary LayoutUnits in RenderBlockLineLayout.

Modified Paths

branches/subpixellayout/Source/WebCore/WebCore.exp.in
branches/subpixellayout/Source/WebCore/accessibility/AccessibilityObject.cpp
branches/subpixellayout/Source/WebCore/accessibility/AccessibilityObject.h
branches/subpixellayout/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
branches/subpixellayout/Source/WebCore/accessibility/AccessibilityRenderObject.h
branches/subpixellayout/Source/WebCore/accessibility/AccessibilityScrollView.cpp
branches/subpixellayout/Source/WebCore/accessibility/AccessibilityScrollView.h
branches/subpixellayout/Source/WebCore/editing/Editor.cpp
branches/subpixellayout/Source/WebCore/editing/VisiblePosition.cpp
branches/subpixellayout/Source/WebCore/page/Frame.cpp
branches/subpixellayout/Source/WebCore/page/Frame.h
branches/subpixellayout/Source/WebCore/rendering/RenderBlockLineLayout.cpp




Diff

Modified: branches/subpixellayout/Source/WebCore/WebCore.exp.in (111664 => 111665)

--- branches/subpixellayout/Source/WebCore/WebCore.exp.in	2012-03-22 09:35:14 UTC (rev 111664)
+++ branches/subpixellayout/Source/WebCore/WebCore.exp.in	2012-03-22 09:43:46 UTC (rev 111665)
@@ -823,12 +823,12 @@
 __ZN7WebCore5Color11transparentE
 __ZN7WebCore5Color5whiteE
 __ZN7WebCore5Frame10createViewERKNS_7IntSizeERKNS_5ColorEbS3_bNS_13ScrollbarModeEbS7_b
-__ZN7WebCore5Frame13rangeForPointERKNS_21FractionalLayoutPointE
+__ZN7WebCore5Frame13rangeForPointERKNS_8IntPointE
 __ZN7WebCore5Frame14frameForWidgetEPKNS_6WidgetE
 __ZN7WebCore5Frame17setPageZoomFactorEf
 __ZN7WebCore5Frame17setTextZoomFactorEf
 __ZN7WebCore5Frame24searchForLabelsAboveCellEPNS_17RegularExpressionEPNS_20HTMLTableCellElementEPm
-__ZN7WebCore5Frame23visiblePositionForPointERKNS_21FractionalLayoutPointE
+__ZN7WebCore5Frame23visiblePositionForPointERKNS_8IntPointE
 __ZN7WebCore5Frame25setPageAndTextZoomFactorsEff
 __ZN7WebCore5Frame27resizePageRectsKeepingRatioERKNS_9FloatSizeES3_
 __ZN7WebCore5Frame6createEPNS_4PageEPNS_21HTMLFrameOwnerElementEPNS_17FrameLoaderClientE


Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilityObject.cpp (111664 => 111665)

--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilityObject.cpp	2012-03-22 09:35:14 UTC (rev 111664)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilityObject.cpp	2012-03-22 09:43:46 UTC (rev 111665)
@@ -495,17 +495,17 @@
 return roundedIntPoint(LayoutPoint(rect.x() + rect.width() / 2, rect.y() + rect.height() / 2));
 }
 
-LayoutRect AccessibilityObject::boundingBoxForQuads(RenderObject* obj, const VectorFloatQuad quads)
+IntRect AccessibilityObject::boundingBoxForQuads(RenderObject* obj, const VectorFloatQuad quads)
 {
 ASSERT(obj);
 if (!obj)
-return LayoutRect();
+return IntRect();
 
 size_t count = quads.size();
 if (!count)
-return LayoutRect();
+return IntRect();
 
-LayoutRect result;
+IntRect result;
 for (size_t i = 0; i  count; ++i) {
 IntRect r = quads[i].enclosingBoundingBox();
 if (!r.isEmpty()) {
@@ -1466,14 +1466,14 @@
 return equalIgnoringCase(liveRegion, polite) || equalIgnoringCase(liveRegion, assertive);
 }
 
-AccessibilityObject* AccessibilityObject::elementAccessibilityHitTest(const LayoutPoint point) const
+AccessibilityObject* AccessibilityObject::elementAccessibilityHitTest(const IntPoint point) const
 { 
 // Send the hit test back into the sub-frame if necessary.
 if (isAttachment()) {
 Widget* widget = widgetForAttachmentView();
 // Normalize the point for the widget's bounds.
 if (widget  widget-isFrameView())
-return axObjectCache()-getOrCreate(widget)-accessibilityHitTest(toLayoutPoint(point - widget-frameRect().location()));
+return axObjectCache()-getOrCreate(widget)-accessibilityHitTest(toPoint(point - widget-frameRect().location()));
 }
 
 // Check if there are any mock elements that need to be handled.
@@ -1620,7 +1620,7 @@
 void AccessibilityObject::scrollToMakeVisible() const
 {
 IntRect objectRect = pixelSnappedIntRect(boundingBoxRect());
-objectRect.move(-objectRect.x(), -objectRect.y());
+objectRect.setLocation(IntPoint());
 scrollToMakeVisibleWithSubFocus(objectRect);
 }
 


Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilityObject.h (111664 => 111665)

--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilityObject.h	2012-03-22 09:35:14 UTC (rev 111664)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilityObject.h	2012-03-22 09:43:46 UTC (rev 111665)
@@ -461,9 +461,9 @@
 virtual void determineARIADropEffects(VectorString) { }
 
  

[webkit-changes] [111667] trunk/LayoutTests

[commit-queue]

Title: [111667] trunk/LayoutTests








Revision 111667
Author commit-qu...@webkit.org
Date 2012-03-22 03:45:51 -0700 (Thu, 22 Mar 2012)


Log Message
[CSSRegions] Add region styling test for region css rules specificity/position
https://bugs.webkit.org/show_bug.cgi?id=76537

Patch by Mihai Balan miba...@adobe.com on 2012-03-22
Reviewed by Andreas Kling.

* fast/regions/region-style-rule-specificity-expected.html: Added.
* fast/regions/region-style-rule-specificity.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/regions/region-style-rule-specificity-expected.html
trunk/LayoutTests/fast/regions/region-style-rule-specificity.html




Diff

Modified: trunk/LayoutTests/ChangeLog (111666 => 111667)

--- trunk/LayoutTests/ChangeLog	2012-03-22 09:54:27 UTC (rev 111666)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 10:45:51 UTC (rev 111667)
@@ -1,3 +1,13 @@
+2012-03-22  Mihai Balan  miba...@adobe.com
+
+[CSSRegions] Add region styling test for region css rules specificity/position
+https://bugs.webkit.org/show_bug.cgi?id=76537
+
+Reviewed by Andreas Kling.
+
+* fast/regions/region-style-rule-specificity-expected.html: Added.
+* fast/regions/region-style-rule-specificity.html: Added.
+
 2012-03-22  Kristóf Kosztyó  kkris...@inf.u-szeged.hu
 
 Unreviewed gardening after r111595.


Added: trunk/LayoutTests/fast/regions/region-style-rule-specificity-expected.html (0 => 111667)

--- trunk/LayoutTests/fast/regions/region-style-rule-specificity-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/region-style-rule-specificity-expected.html	2012-03-22 10:45:51 UTC (rev 111667)
@@ -0,0 +1,57 @@
+!doctype html
+html
+	head
+		style
+		body {
+			font-family: monospace;
+			font-size: 1em;
+		}
+		p {
+			margin: 0;
+			line-height: 1em;
+		}
+		.container {
+			background-color: lightgray;
+			width: 15em;
+			height: 5em;
+		}
+		.light {
+			background-color: lightgreen;
+		}
+		.lime {
+			background-color: lime;
+		}
+		.green {
+			background-color: green;
+		}
+		/style
+	/head
+	body
+		h1Testing CSS selectors specificity/position is respected when using @region styling/h1
+
+		Selector specificity in @region rule
+		div class='container' id='r1'
+			p class='light'Plain paragraph/p
+			p class='lime'Styled with class/p
+			p class='green'Styled with ID/p
+		/div
+		Selector position in @region rule
+		div class='container' id='r2'
+			p class='light'Plain paragraph/p
+			p class='lime'Styled with class/p
+			p class='green'Styled with ID/p
+		/div
+		More specific selector in flowed content
+		div class='container' id='r3'
+			p class='lime'Class in content/p
+			p class='lime'ID in content/p
+			p class='lime'ID in content/p
+		/div
+		Style attribute in flowed content
+		div class='container' id='r4'
+			p class='lime'Element style in region/p
+			p class='lime'ID style in region/p
+			p class='lime'Class in region/p
+		/div
+	/body
+/html
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/region-style-rule-specificity.html (0 => 111667)

--- trunk/LayoutTests/fast/regions/region-style-rule-specificity.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/region-style-rule-specificity.html	2012-03-22 10:45:51 UTC (rev 111667)
@@ -0,0 +1,143 @@
+!doctype html
+html
+	head
+		style
+		body {
+			font-family: monospace;
+			font-size: 1em;
+		}
+		p {
+			margin: 0;
+			line-height: 1em;
+		}
+		.container {
+			background-color: lightgray;
+			width: 15em;
+			height: 5em;
+		}
+		/* selector specificity
+		#id = 100
+		.class = 10
+		element = 1
+		*/
+		/*
+		selector position
+		in style= attribute
+		in style/ element / external file
+		*/
+
+		/* Testing selector specificity is respected in @region style blocks */
+		#f1 {
+			-webkit-flow-into: flow1;
+		}
+		#r1 {
+			-webkit-flow-from: flow1;
+		}
+		@-webkit-region #r1 {
+			* {
+background-color: yellow;
+			}
+			p {
+background-color: lightgreen;
+			}
+			.cr1 {
+background-color: lime;
+			}
+			#p1 {
+background-color: green;
+			}
+		}
+
+		/* Testing selector position is respected in @region style blocks */
+		#f2 {
+			-webkit-flow-into: flow2;
+		}
+		#r2 {
+			-webkit-flow-from: flow2;
+		}
+		@-webkit-region #r2 {
+			p, .cr21, #p2 {
+background-color: red;
+			}
+		}
+		@-webkit-region #r2 {
+			p {
+background-color: lightgreen;
+			}
+			.cr22 {
+background-color: lime;
+			}
+			#p2 {
+background-color: green;
+			}
+		}
+
+		/* More specific selector in flowed content than in @region style */
+		.c3 {
+			background-color: lime;
+		}
+		#p31, #p32 {
+			background-color: lime;
+		}
+		#f3 {
+			-webkit-flow-into: flow3;
+		}
+		#r3 {
+			-webkit-flow-from: flow3;
+		}
+		@-webkit-region #r3 {
+			p, .cr3 {
+background-color: red;
+			}
+		}
+
+		/* Flowed content has style attribute */
+		#f4 {
+			-webkit-flow-into: flow4;
+		}
+		#r4 {
+			

[webkit-changes] [111668] trunk/Tools

[carlosgc]

Title: [111668] trunk/Tools








Revision 111668
Author carlo...@webkit.org
Date 2012-03-22 03:50:32 -0700 (Thu, 22 Mar 2012)


Log Message
[GTK] Allow to run any jhbuild command with jhbuild-wrapper script
https://bugs.webkit.org/show_bug.cgi?id=81888

Reviewed by Philippe Normand.

* Scripts/update-webkit-libs-jhbuild:
(runJhbuild): Helper function to run jhbuild with a given command.
Instead of running jhbuild directly, use the jhbuild-wrapper, so
that we don't need to run it first to check whether jhbuild is
installed or not.
* efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
* gtk/run-with-jhbuild: Ditto.
* jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,
not only run.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/update-webkit-libs-jhbuild
trunk/Tools/efl/run-with-jhbuild
trunk/Tools/gtk/run-with-jhbuild
trunk/Tools/jhbuild/jhbuild-wrapper




Diff

Modified: trunk/Tools/ChangeLog (111667 => 111668)

--- trunk/Tools/ChangeLog	2012-03-22 10:45:51 UTC (rev 111667)
+++ trunk/Tools/ChangeLog	2012-03-22 10:50:32 UTC (rev 111668)
@@ -1,3 +1,20 @@
+2012-03-22  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Allow to run any jhbuild command with jhbuild-wrapper script
+https://bugs.webkit.org/show_bug.cgi?id=81888
+
+Reviewed by Philippe Normand.
+
+* Scripts/update-webkit-libs-jhbuild:
+(runJhbuild): Helper function to run jhbuild with a given command.
+Instead of running jhbuild directly, use the jhbuild-wrapper, so
+that we don't need to run it first to check whether jhbuild is
+installed or not.
+* efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
+* gtk/run-with-jhbuild: Ditto.
+* jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,
+not only run.
+
 2012-03-22  Philippe Normand  pnorm...@igalia.com
 
 Unreviewed, test-webkitpy fix after r111661.


Modified: trunk/Tools/Scripts/update-webkit-libs-jhbuild (111667 => 111668)

--- trunk/Tools/Scripts/update-webkit-libs-jhbuild	2012-03-22 10:45:51 UTC (rev 111667)
+++ trunk/Tools/Scripts/update-webkit-libs-jhbuild	2012-03-22 10:50:32 UTC (rev 111668)
@@ -41,21 +41,18 @@
 }
 }
 
+sub runJhbuild
+{
+my $command = shift;
+my @jhbuildArgs = (./jhbuild-wrapper, --.$platform, $command);
+push(@jhbuildArgs, @ARGV[2..-1]);
+system(@jhbuildArgs) == 0 or die Running jhbuild-wrapper  . $command .  failed.\n;
+}
+
 delete $ENV{AR_FLAGS} if exists $ENV{AR_FLAGS};
 
 chdir(relativeScriptsDir() . /../jhbuild) or die $!;
 
-my @ensureJhbuildArgs = (./jhbuild-wrapper, --.$platform, echo, Ensured jhbuild setup.);
-if (system(@ensureJhbuildArgs) != 0) {
-die Failed to ensure jhbuild installed.\n;
-}
-
-chdir(relativeScriptsDir() . /../.$platform) or die $!;
-
 my %prettyPlatform = ( efl = EFL, gtk = GTK+ );
 print Updating  . $prettyPlatform{$platform} .  port dependencies using jhbuild...\n;
-my @jhbuildArgs = (../../WebKitBuild/Dependencies/Root/bin/jhbuild, --no-interact, -f, jhbuildrc);
-push(@jhbuildArgs, @ARGV[2..-1]);
-if (system(@jhbuildArgs) != 0) {
-die Running jhbuild failed.\n
-}
+runJhbuild(build);


Modified: trunk/Tools/efl/run-with-jhbuild (111667 => 111668)

--- trunk/Tools/efl/run-with-jhbuild	2012-03-22 10:45:51 UTC (rev 111667)
+++ trunk/Tools/efl/run-with-jhbuild	2012-03-22 10:50:32 UTC (rev 111668)
@@ -21,6 +21,6 @@
 import sys
 
 jhbuild_wrapper = common.top_level_path('Tools', 'jhbuild', 'jhbuild-wrapper')
-process = subprocess.Popen([jhbuild_wrapper, '--efl'] + sys.argv[1:])
+process = subprocess.Popen([jhbuild_wrapper, '--efl', 'run'] + sys.argv[1:])
 process.wait()
 sys.exit(process.returncode)


Modified: trunk/Tools/gtk/run-with-jhbuild (111667 => 111668)

--- trunk/Tools/gtk/run-with-jhbuild	2012-03-22 10:45:51 UTC (rev 111667)
+++ trunk/Tools/gtk/run-with-jhbuild	2012-03-22 10:50:32 UTC (rev 111668)
@@ -22,6 +22,6 @@
 import sys
 
 jhbuild_wrapper = common.top_level_path('Tools', 'jhbuild', 'jhbuild-wrapper')
-process = subprocess.Popen([jhbuild_wrapper, '--gtk'] + sys.argv[1:])
+process = subprocess.Popen([jhbuild_wrapper, '--gtk', 'run'] + sys.argv[1:])
 process.wait()
 sys.exit(process.returncode)


Modified: trunk/Tools/jhbuild/jhbuild-wrapper (111667 => 111668)

--- trunk/Tools/jhbuild/jhbuild-wrapper	2012-03-22 10:45:51 UTC (rev 111667)
+++ trunk/Tools/jhbuild/jhbuild-wrapper	2012-03-22 10:50:32 UTC (rev 111668)
@@ -135,6 +135,6 @@
 sys.exit(e)
 ensure_jhbuild()
 
-process = subprocess.Popen([jhbuild_path, '--no-interact', '-f', top_level_path('Tools', platform, 'jhbuildrc'), 'run'] + sys.argv[2:])
+process = subprocess.Popen([jhbuild_path, '--no-interact', '-f', top_level_path('Tools', platform, 'jhbuildrc')] + sys.argv[2:])
 process.wait()
 sys.exit(process.returncode)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111669] trunk/Source/WebCore

[commit-queue]

Title: [111669] trunk/Source/WebCore








Revision 111669
Author commit-qu...@webkit.org
Date 2012-03-22 04:17:35 -0700 (Thu, 22 Mar 2012)


Log Message
[GTK] Fix the only remaining coding style issue in GTK accessibility code
https://bugs.webkit.org/show_bug.cgi?id=81885

Patch by Mario Sanchez Prada msanc...@igalia.com on 2012-03-22
Reviewed by Xan Lopez.

Add needed extra line and remove an unneeded one.

* accessibility/gtk/AccessibilityObjectAtk.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (111668 => 111669)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 10:50:32 UTC (rev 111668)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 11:17:35 UTC (rev 111669)
@@ -1,3 +1,14 @@
+2012-03-22  Mario Sanchez Prada  msanc...@igalia.com
+
+[GTK] Fix the only remaining coding style issue in GTK accessibility code
+https://bugs.webkit.org/show_bug.cgi?id=81885
+
+Reviewed by Xan Lopez.
+
+Add needed extra line and remove an unneeded one.
+
+* accessibility/gtk/AccessibilityObjectAtk.cpp:
+
 2012-03-22  Kent Tamura  tk...@chromium.org
 
 Expand RenderTextControlSingleLine::controlClipRect() to contain contentRect().


Modified: trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp (111668 => 111669)

--- trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp	2012-03-22 10:50:32 UTC (rev 111668)
+++ trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp	2012-03-22 11:17:35 UTC (rev 111669)
@@ -20,9 +20,9 @@
 
 #include config.h
 #include AccessibilityObject.h
+
 #include RenderObject.h
 #include RenderText.h
-
 #include glib-object.h
 
 #if HAVE(ACCESSIBILITY)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111670] trunk

[vsevik]

Title: [111670] trunk








Revision 111670
Author vse...@chromium.org
Date 2012-03-22 05:27:39 -0700 (Thu, 22 Mar 2012)


Log Message
Web Inspector: RawSourceCode does not need uiSourceCode lists because it never has more than one.
https://bugs.webkit.org/show_bug.cgi?id=81894

Source/WebCore:

RawSourceCode never has more than one uiSourceCode, uiSourceCodeList
are just remains of older implementation. This patch switches RawSourceCode
and SourceMappings from uiSourceCodeList to uiSourceCode.

Reviewed by Pavel Feldman.

* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype.uiSourceCode):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
(WebInspector.RawSourceCode.SourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.SourceMapping.prototype.uiSourceCode):
(WebInspector.RawSourceCode.PlainSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiSourceCode):
(WebInspector.RawSourceCode.FormattedSourceMapping):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiSourceCode):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.uiSourceCodeList):
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype.reset):

LayoutTests:

Reviewed by Pavel Feldman.

* inspector/debugger/raw-source-code.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/raw-source-code.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
trunk/Source/WebCore/inspector/front-end/ResourceScriptMapping.js




Diff

Modified: trunk/LayoutTests/ChangeLog (111669 => 111670)

--- trunk/LayoutTests/ChangeLog	2012-03-22 11:17:35 UTC (rev 111669)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 12:27:39 UTC (rev 111670)
@@ -1,3 +1,12 @@
+2012-03-22  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: RawSourceCode does not need uiSourceCode lists because it never has more than one.
+https://bugs.webkit.org/show_bug.cgi?id=81894
+
+Reviewed by Pavel Feldman.
+
+* inspector/debugger/raw-source-code.html:
+
 2012-03-22  Mihai Balan  miba...@adobe.com
 
 [CSSRegions] Add region styling test for region css rules specificity/position


Modified: trunk/LayoutTests/inspector/debugger/raw-source-code.html (111669 => 111670)

--- trunk/LayoutTests/inspector/debugger/raw-source-code.html	2012-03-22 11:17:35 UTC (rev 111669)
+++ trunk/LayoutTests/inspector/debugger/raw-source-code.html	2012-03-22 12:27:39 UTC (rev 111670)
@@ -37,25 +37,25 @@
 function createRawSourceCode(script, resource, formatted, compilerSourceMapping)
 {
 var rawSourceCode = new WebInspector.RawSourceCode(id, script, resource, createScriptFormatterMock(), !!formatted, compilerSourceMapping);
-rawSourceCode.addEventListener(WebInspector.RawSourceCode.Events.UISourceCodeListChanged, defaultUISourceCodeListChangedHandler);
+rawSourceCode.addEventListener(WebInspector.RawSourceCode.Events.UISourceCodeChanged, defaultUISourceCodeChangedHandler);
 return rawSourceCode;
 }
 
-function waitForUISourceCodeListChangedEvent(rawSourceCode, callback)
+function waitForUISourceCodeChangedEvent(rawSourceCode, callback)
 {
-rawSourceCode.removeEventListener(WebInspector.RawSourceCode.Events.UISourceCodeListChanged, defaultUISourceCodeListChangedHandler);
-rawSourceCode.addEventListener(WebInspector.RawSourceCode.Events.UISourceCodeListChanged, uiSourceCodeListChanged);
-function uiSourceCodeListChanged(event)
+rawSourceCode.removeEventListener(WebInspector.RawSourceCode.Events.UISourceCodeChanged, defaultUISourceCodeChangedHandler);
+rawSourceCode.addEventListener(WebInspector.RawSourceCode.Events.UISourceCodeChanged, uiSourceCodeChanged);
+function uiSourceCodeChanged(event)
 {
-rawSourceCode.removeEventListener(WebInspector.RawSourceCode.Events.UISourceCodeListChanged, uiSourceCodeListChanged);
-rawSourceCode.addEventListener(WebInspector.RawSourceCode.Events.UISourceCodeListChanged, defaultUISourceCodeListChangedHandler);
+rawSourceCode.removeEventListener(WebInspector.RawSourceCode.Events.UISourceCodeChanged, uiSourceCodeChanged);
+rawSourceCode.addEventListener(WebInspector.RawSourceCode.Events.UISourceCodeChanged, defaultUISourceCodeChangedHandler);
 callback(event);

[webkit-changes] [111671] branches/subpixellayout/Source

[leviw]

Title: [111671] branches/subpixellayout/Source








Revision 111671
Author le...@chromium.org
Date 2012-03-22 05:28:47 -0700 (Thu, 22 Mar 2012)


Log Message
Correcting elementAccessibilityHitTest to IntPoints and fixing a build error after reverting rangeForPoint to ints as well.

Modified Paths

branches/subpixellayout/Source/WebCore/accessibility/AccessibilityListBox.cpp
branches/subpixellayout/Source/WebCore/accessibility/AccessibilityListBox.h
branches/subpixellayout/Source/WebCore/accessibility/AccessibilityObject.h
branches/subpixellayout/Source/WebCore/accessibility/AccessibilitySlider.cpp
branches/subpixellayout/Source/WebCore/accessibility/AccessibilitySlider.h
branches/subpixellayout/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm




Diff

Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilityListBox.cpp (111670 => 111671)

--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilityListBox.cpp	2012-03-22 12:27:39 UTC (rev 111670)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilityListBox.cpp	2012-03-22 12:28:47 UTC (rev 111671)
@@ -163,7 +163,7 @@
 return false;
 }
 
-AccessibilityObject* AccessibilityListBox::elementAccessibilityHitTest(const LayoutPoint point) const
+AccessibilityObject* AccessibilityListBox::elementAccessibilityHitTest(const IntPoint point) const
 {
 // the internal HTMLSelectElement methods for returning a listbox option at a point
 // ignore optgroup elements.


Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilityListBox.h (111670 => 111671)

--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilityListBox.h	2012-03-22 12:27:39 UTC (rev 111670)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilityListBox.h	2012-03-22 12:28:47 UTC (rev 111671)
@@ -56,7 +56,7 @@
 private:
 AccessibilityObject* listBoxOptionAccessibilityObject(HTMLElement*) const;
 virtual bool accessibilityIsIgnored() const;
-virtual AccessibilityObject* elementAccessibilityHitTest(const LayoutPoint) const;
+virtual AccessibilityObject* elementAccessibilityHitTest(const IntPoint) const;
 };
 
 } // namespace WebCore


Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilityObject.h (111670 => 111671)

--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilityObject.h	2012-03-22 12:27:39 UTC (rev 111670)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilityObject.h	2012-03-22 12:28:47 UTC (rev 111671)
@@ -592,7 +592,7 @@
 int lengthForVisiblePositionRange(const VisiblePositionRange) const;
 virtual void setSelectedVisiblePositionRange(const VisiblePositionRange) const { }
 
-virtual VisiblePosition visiblePositionForPoint(const LayoutPoint) const { return VisiblePosition(); }
+virtual VisiblePosition visiblePositionForPoint(const IntPoint) const { return VisiblePosition(); }
 VisiblePosition nextVisiblePosition(const VisiblePosition visiblePos) const { return visiblePos.next(); }
 VisiblePosition previousVisiblePosition(const VisiblePosition visiblePos) const { return visiblePos.previous(); }
 VisiblePosition nextWordEnd(const VisiblePosition) const;


Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilitySlider.cpp (111670 => 111671)

--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilitySlider.cpp	2012-03-22 12:27:39 UTC (rev 111670)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilitySlider.cpp	2012-03-22 12:28:47 UTC (rev 111671)
@@ -102,7 +102,7 @@
 return element()-getAttribute(attribute);
 }
 
-AccessibilityObject* AccessibilitySlider::elementAccessibilityHitTest(const LayoutPoint point) const
+AccessibilityObject* AccessibilitySlider::elementAccessibilityHitTest(const IntPoint point) const
 {
 if (m_children.size()) {
 ASSERT(m_children.size() == 1);


Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilitySlider.h (111670 => 111671)

--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilitySlider.h	2012-03-22 12:27:39 UTC (rev 111670)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilitySlider.h	2012-03-22 12:28:47 UTC (rev 111671)
@@ -48,7 +48,7 @@
 private:
 HTMLInputElement* element() const;
 virtual bool accessibilityIsIgnored() const;
-virtual AccessibilityObject* elementAccessibilityHitTest(const LayoutPoint) const;
+virtual AccessibilityObject* elementAccessibilityHitTest(const IntPoint) const;
 
 virtual AccessibilityRole roleValue() const { return SliderRole; }
 virtual bool isSlider() const { return true; }


Modified: branches/subpixellayout/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm (111670 => 111671)

--- branches/subpixellayout/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm	2012-03-22 12:27:39 UTC (rev 111670)
+++ branches/subpixellayout/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm	

[webkit-changes] [111676] trunk/Source/WebCore

[pfeldman]

Title: [111676] trunk/Source/WebCore








Revision 111676
Author pfeld...@chromium.org
Date 2012-03-22 05:54:32 -0700 (Thu, 22 Mar 2012)


Log Message
Web Inspector: allow on-hover popover while in edit mode.
https://bugs.webkit.org/show_bug.cgi?id=81898

Reviewed by Vsevolod Vlasov.

This change allows popover while in-edit mode, hides it upon Esc. It also introduces anchorOverride
concept in ObjectPopoverHelper that allows dynamically switching the anchor (say if we want to highlight anchor itself).

* inspector/front-end/DetailedHeapshotView.js:
* inspector/front-end/ElementsPanel.js:
* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame.prototype._resolveObjectForPopover.showObjectPopover):
(WebInspector._javascript_SourceFrame.prototype._resolveObjectForPopover):
(WebInspector._javascript_SourceFrame.prototype._onKeyDown):
* inspector/front-end/NetworkPanel.js:
* inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
* inspector/front-end/Popover.js:
(WebInspector.PopoverHelper.prototype.isPopoverVisible):
* inspector/front-end/TimelinePanel.js:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js
trunk/Source/WebCore/inspector/front-end/ElementsPanel.js
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
trunk/Source/WebCore/inspector/front-end/ObjectPopoverHelper.js
trunk/Source/WebCore/inspector/front-end/Popover.js
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (111675 => 111676)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 12:52:35 UTC (rev 111675)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 12:54:32 UTC (rev 111676)
@@ -1,5 +1,29 @@
 2012-03-22  Pavel Feldman  pfeld...@chromium.org
 
+Web Inspector: allow on-hover popover while in edit mode.
+https://bugs.webkit.org/show_bug.cgi?id=81898
+
+Reviewed by Vsevolod Vlasov.
+
+This change allows popover while in-edit mode, hides it upon Esc. It also introduces anchorOverride
+concept in ObjectPopoverHelper that allows dynamically switching the anchor (say if we want to highlight anchor itself).
+
+* inspector/front-end/DetailedHeapshotView.js:
+* inspector/front-end/ElementsPanel.js:
+* inspector/front-end/_javascript_SourceFrame.js:
+(WebInspector._javascript_SourceFrame.prototype._resolveObjectForPopover.showObjectPopover):
+(WebInspector._javascript_SourceFrame.prototype._resolveObjectForPopover):
+(WebInspector._javascript_SourceFrame.prototype._onKeyDown):
+* inspector/front-end/NetworkPanel.js:
+* inspector/front-end/ObjectPopoverHelper.js:
+(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.):
+(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
+* inspector/front-end/Popover.js:
+(WebInspector.PopoverHelper.prototype.isPopoverVisible):
+* inspector/front-end/TimelinePanel.js:
+
+2012-03-22  Pavel Feldman  pfeld...@chromium.org
+
 Web Inspector: breakpoints should shift when line break is inserted in the middle of the line.
 https://bugs.webkit.org/show_bug.cgi?id=81896
 


Modified: trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js (111675 => 111676)

--- trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js	2012-03-22 12:52:35 UTC (rev 111675)
+++ trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js	2012-03-22 12:54:32 UTC (rev 111676)
@@ -527,7 +527,7 @@
 this.helpButton = new WebInspector.StatusBarButton(, heapshot-help-status-bar-item status-bar-item);
 this.helpButton.addEventListener(click, this._helpClicked.bind(this), false);
 
-this._popoverHelper = new WebInspector.ObjectPopoverHelper(this.element, this._getHoverAnchor.bind(this), this._resolveObjectForPopover.bind(this), null, true);
+this._popoverHelper = new WebInspector.ObjectPopoverHelper(this.element, this._getHoverAnchor.bind(this), this._resolveObjectForPopover.bind(this), undefined, true);
 
 this._loadProfile(this._profileUid, profileCallback.bind(this));
 


Modified: trunk/Source/WebCore/inspector/front-end/ElementsPanel.js (111675 => 111676)

--- trunk/Source/WebCore/inspector/front-end/ElementsPanel.js	2012-03-22 12:52:35 UTC (rev 111675)
+++ trunk/Source/WebCore/inspector/front-end/ElementsPanel.js	2012-03-22 12:54:32 UTC (rev 111676)
@@ -391,6 +391,10 @@
 }
 },
 
+/**
+ * @param {Element} anchor
+ * @param {WebInspector.Popover} popover
+ */
 _showPopover: function(anchor, popover)
 {
 var listItem = anchor.enclosingNodeOrSelfWithNodeNameInArray([li]);


Modified: 

[webkit-changes] [111677] trunk

[pfeldman]

Title: [111677] trunk








Revision 111677
Author pfeld...@chromium.org
Date 2012-03-22 05:56:47 -0700 (Thu, 22 Mar 2012)


Log Message
Source/WebCore: Web Inspector: dispatch styleSheetChanged event synchronously.
https://bugs.webkit.org/show_bug.cgi?id=81892

Reviewed by Vsevolod Vlasov.

Today, backend generates stylesheet change event synchronously from within set* command.
But CSSStyleModel defers its dispatching until the stylesheet content is available. This
prevents us from ignoring update events from within commands that initiated those updates.

This change makes stylesheet change event dispatch synchronously and delegates stylesheet
content fetching to the event client.

* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
(WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._innerSetContent.callbackWrapper):
(WebInspector.CSSStyleModelResourceBinding.prototype._innerSetContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged.callback):
(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged):
(WebInspector.CSSStyleModelResourceBinding.prototype._innerStyleSheetChanged):

Source/WebKit/chromium: [chromium] timing functions are getting incorrectly applied for accelerated css transitions
https://bugs.webkit.org/show_bug.cgi?id=81692

Patch by Ian Vollick voll...@chromium.org on 2012-03-21
Reviewed by Adrienne Walker.

* tests/CCAnimationTestCommon.cpp:
(WebCore::addOpacityTransition):
(WebKitTests::addOpacityTransitionToController):
(WebKitTests::addOpacityTransitionToLayer):
* tests/CCAnimationTestCommon.h:
(WebKitTests):
* tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::TEST):
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::dispatchAddInstantAnimation):
(WTF::CCLayerTreeHostTest::dispatchAddAnimation):
(WTF::TEST_F):
(WTF):
(CCLayerTreeHostTestAddAnimationWithTimingFunction):
(WTF::CCLayerTreeHostTestAddAnimationWithTimingFunction::CCLayerTreeHostTestAddAnimationWithTimingFunction):
(WTF::CCLayerTreeHostTestAddAnimationWithTimingFunction::beginTest):
(WTF::CCLayerTreeHostTestAddAnimationWithTimingFunction::animateLayers):
(WTF::CCLayerTreeHostTestAddAnimationWithTimingFunction::afterTest):

LayoutTests: Web Inspector: dispatch styleSheetChanged event synchronously.
https://bugs.webkit.org/show_bug.cgi?id=81892

Reviewed by Vsevolod Vlasov.

* http/tests/inspector/resources-test.js:
(initialize_ResourceTest.InspectorTest.showResource.callbackWrapper):
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback.visit):
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback):
(initialize_ResourceTest.InspectorTest.showResource):
(initialize_ResourceTest):
* inspector/styles/styles-history.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/resources-test.js
trunk/LayoutTests/inspector/styles/styles-history-expected.txt
trunk/LayoutTests/inspector/styles/styles-history.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js
trunk/Source/WebKit/chromium/ChangeLog




Diff

Modified: trunk/LayoutTests/ChangeLog (111676 => 111677)

--- trunk/LayoutTests/ChangeLog	2012-03-22 12:54:32 UTC (rev 111676)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 12:56:47 UTC (rev 111677)
@@ -1,3 +1,18 @@
+2012-03-22  Pavel Feldman  pfeld...@chromium.org
+
+Web Inspector: dispatch styleSheetChanged event synchronously.
+https://bugs.webkit.org/show_bug.cgi?id=81892
+
+Reviewed by Vsevolod Vlasov.
+
+* http/tests/inspector/resources-test.js:
+(initialize_ResourceTest.InspectorTest.showResource.callbackWrapper):
+(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback.visit):
+(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback):
+(initialize_ResourceTest.InspectorTest.showResource):
+(initialize_ResourceTest):
+* inspector/styles/styles-history.html:
+
 2012-03-22  Kaustubh Atrawalkar  kaust...@motorola.com
 
 blur() on shadow host should work when a shadow host contains a focused element in its shadow DOM subtrees


Modified: trunk/LayoutTests/http/tests/inspector/resources-test.js (111676 => 111677)

--- trunk/LayoutTests/http/tests/inspector/resources-test.js	2012-03-22 12:54:32 UTC (rev 111676)
+++ trunk/LayoutTests/http/tests/inspector/resources-test.js	2012-03-22 12:56:47 UTC (rev 111677)
@@ -61,6 +61,15 @@
 
 InspectorTest.showResource = function(resourceURL, callback)
 {
+var reported = false;
+function callbackWrapper(sourceFrame)
+{
+if (reported)
+return;
+callback(sourceFrame);
+reported = true;
+}
+
 function showResourceCallback()
 {
 

[webkit-changes] [111678] trunk/Tools

[kubo]

Title: [111678] trunk/Tools








Revision 111678
Author k...@profusion.mobi
Date 2012-03-22 06:06:05 -0700 (Thu, 22 Mar 2012)


Log Message
[EFL] DRT: Do not pass a relative path to DOWNLOADED_FONTS_DIR.
https://bugs.webkit.org/show_bug.cgi?id=81900

Reviewed by Gustavo Noronha Silva.

r111598 added the DOWNLOADED_FONTS_DIR define, but it used a relative
path which assumed a certain directory structure for the build
directory which may noy be true.

Instead, hardcode the path to the downloaded fonts starting from the
top-level source directory. While this solution is also far from
perfect, it makes it more consistent and reliable, and easier to
tackle at once with the rest of bug 81475.

* DumpRenderTree/efl/CMakeLists.txt:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/CMakeLists.txt




Diff

Modified: trunk/Tools/ChangeLog (111677 => 111678)

--- trunk/Tools/ChangeLog	2012-03-22 12:56:47 UTC (rev 111677)
+++ trunk/Tools/ChangeLog	2012-03-22 13:06:05 UTC (rev 111678)
@@ -1,3 +1,21 @@
+2012-03-22  Raphael Kubo da Costa  rak...@freebsd.org
+
+[EFL] DRT: Do not pass a relative path to DOWNLOADED_FONTS_DIR.
+https://bugs.webkit.org/show_bug.cgi?id=81900
+
+Reviewed by Gustavo Noronha Silva.
+
+r111598 added the DOWNLOADED_FONTS_DIR define, but it used a relative
+path which assumed a certain directory structure for the build
+directory which may noy be true.
+
+Instead, hardcode the path to the downloaded fonts starting from the
+top-level source directory. While this solution is also far from
+perfect, it makes it more consistent and reliable, and easier to
+tackle at once with the rest of bug 81475.
+
+* DumpRenderTree/efl/CMakeLists.txt:
+
 2012-03-22  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Allow to run any jhbuild command with jhbuild-wrapper script


Modified: trunk/Tools/DumpRenderTree/efl/CMakeLists.txt (111677 => 111678)

--- trunk/Tools/DumpRenderTree/efl/CMakeLists.txt	2012-03-22 12:56:47 UTC (rev 111677)
+++ trunk/Tools/DumpRenderTree/efl/CMakeLists.txt	2012-03-22 13:06:05 UTC (rev 111678)
@@ -108,8 +108,10 @@
 ${LIBSOUP24_LDFLAGS}
 )
 
+# FIXME: DOWNLOADED_FONTS_DIR should not hardcode the directory
+# structure. See https://bugs.webkit.org/show_bug.cgi?id=81475.
 ADD_DEFINITIONS(-DFONTS_CONF_DIR=${TOOLS_DIR}/DumpRenderTree/gtk/fonts
--DDOWNLOADED_FONTS_DIR=${CMAKE_BINARY_DIR}/../Dependencies/Source/webkitgtk-test-fonts-0.0.1
+-DDOWNLOADED_FONTS_DIR=${CMAKE_SOURCE_DIR}/WebKitBuild/Dependencies/Source/webkitgtk-test-fonts-0.0.1
 -DDATA_DIR=${THEME_BINARY_DIR})
 
 INCLUDE_DIRECTORIES(${DumpRenderTree_INCLUDE_DIRECTORIES})






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111680] trunk/LayoutTests

[kubo]

Title: [111680] trunk/LayoutTests








Revision 111680
Author k...@profusion.mobi
Date 2012-03-22 06:18:57 -0700 (Thu, 22 Mar 2012)


Log Message
[EFL] Unreviewed gardening.

Update expectations for some fast/forms tests which were rendering
placeholders with the wrong colors.

* platform/efl/fast/forms/input-placeholder-text-indent-expected.png: Added.
* platform/efl/fast/forms/isindex-placeholder-expected.png: Added.
* platform/efl/fast/forms/placeholder-with-positioned-element-expected.png: Added.
* platform/efl/fast/forms/textarea-placeholder-wrapping-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/efl/fast/forms/input-placeholder-text-indent-expected.png
trunk/LayoutTests/platform/efl/fast/forms/isindex-placeholder-expected.png
trunk/LayoutTests/platform/efl/fast/forms/placeholder-with-positioned-element-expected.png
trunk/LayoutTests/platform/efl/fast/forms/textarea-placeholder-wrapping-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (111679 => 111680)

--- trunk/LayoutTests/ChangeLog	2012-03-22 13:17:02 UTC (rev 111679)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 13:18:57 UTC (rev 111680)
@@ -1,3 +1,15 @@
+2012-03-22  Raphael Kubo da Costa  rak...@freebsd.org
+
+[EFL] Unreviewed gardening.
+
+Update expectations for some fast/forms tests which were rendering
+placeholders with the wrong colors.
+
+* platform/efl/fast/forms/input-placeholder-text-indent-expected.png: Added.
+* platform/efl/fast/forms/isindex-placeholder-expected.png: Added.
+* platform/efl/fast/forms/placeholder-with-positioned-element-expected.png: Added.
+* platform/efl/fast/forms/textarea-placeholder-wrapping-expected.png: Added.
+
 2012-03-22  Pavel Feldman  pfeld...@chromium.org
 
 Web Inspector: dispatch styleSheetChanged event synchronously.


Added: trunk/LayoutTests/platform/efl/fast/forms/input-placeholder-text-indent-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/efl/fast/forms/input-placeholder-text-indent-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/efl/fast/forms/isindex-placeholder-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/efl/fast/forms/isindex-placeholder-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/efl/fast/forms/placeholder-with-positioned-element-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/efl/fast/forms/placeholder-with-positioned-element-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/efl/fast/forms/textarea-placeholder-wrapping-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/efl/fast/forms/textarea-placeholder-wrapping-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111682] trunk/Source/WebCore

[pfeldman]

Title: [111682] trunk/Source/WebCore








Revision 111682
Author pfeld...@chromium.org
Date 2012-03-22 06:25:59 -0700 (Thu, 22 Mar 2012)


Log Message
Web Inspector: make CSS and _javascript_ files editable by default.
https://bugs.webkit.org/show_bug.cgi?id=81787

Reviewed by Vsevolod Vlasov.

This change removes cancelEditing and setReadOnly capabilities from source frame.
It removes dblclick handler as well since one does not need to enter editing mode.
It also establishes proper content dispatching so that views are updated with the
resource content. All these are inter-dependent, need to be landed simultaneously.
Drive-by follow up to the r111675 where range is modified prior to the exiting
edit mode.

* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame):
(WebInspector._javascript_SourceFrame.prototype.requestContent):
(WebInspector._javascript_SourceFrame.prototype.afterTextChanged):
(WebInspector._javascript_SourceFrame.prototype.beforeTextChanged):
(WebInspector._javascript_SourceFrame.prototype.didEditContent):
(WebInspector._javascript_SourceFrame.prototype._lineNumberAfterEditing):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceSourceFrame):
(WebInspector.ResourceSourceFrame.prototype.suggestedFileName):
(WebInspector.ResourceSourceFrame.prototype._contentChanged):
(WebInspector.EditableResourceSourceFrame.prototype.canEditSource):
(WebInspector.EditableResourceSourceFrame.prototype.editContent.callbackWrapper):
(WebInspector.EditableResourceSourceFrame.prototype.editContent):
(WebInspector.EditableResourceSourceFrame.prototype._contentChanged):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._innerShowView):
(WebInspector.FrameResourceTreeElement.prototype._appendRevision):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.setScriptSourceIsDirty):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype.willHide):
(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.setContent):
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrame.prototype.didEditContent):
(WebInspector.SourceFrame.prototype.editContent):
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._startEditing):
(WebInspector.TextPrompt.prototype._stopEditing):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer):
(WebInspector.TextViewer.prototype._registerShortcuts):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js
trunk/Source/WebCore/inspector/front-end/ResourceView.js
trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/Settings.js
trunk/Source/WebCore/inspector/front-end/SourceFrame.js
trunk/Source/WebCore/inspector/front-end/TextPrompt.js
trunk/Source/WebCore/inspector/front-end/TextViewer.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (111681 => 111682)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 13:24:25 UTC (rev 111681)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 13:25:59 UTC (rev 111682)
@@ -1,3 +1,56 @@
+2012-03-22  Pavel Feldman  pfeld...@chromium.org
+
+Web Inspector: make CSS and _javascript_ files editable by default.
+https://bugs.webkit.org/show_bug.cgi?id=81787
+
+Reviewed by Vsevolod Vlasov.
+
+This change removes cancelEditing and setReadOnly capabilities from source frame.
+It removes dblclick handler as well since one does not need to enter editing mode.
+It also establishes proper content dispatching so that views are updated with the
+resource content. All these are inter-dependent, need to be landed simultaneously.
+Drive-by follow up to the r111675 where range is modified prior to the exiting
+edit mode.
+
+* inspector/front-end/_javascript_SourceFrame.js:
+(WebInspector._javascript_SourceFrame):
+(WebInspector._javascript_SourceFrame.prototype.requestContent):
+(WebInspector._javascript_SourceFrame.prototype.afterTextChanged):
+(WebInspector._javascript_SourceFrame.prototype.beforeTextChanged):
+(WebInspector._javascript_SourceFrame.prototype.didEditContent):
+(WebInspector._javascript_SourceFrame.prototype._lineNumberAfterEditing):
+* inspector/front-end/ResourceView.js:
+(WebInspector.ResourceSourceFrame):
+(WebInspector.ResourceSourceFrame.prototype.suggestedFileName):
+(WebInspector.ResourceSourceFrame.prototype._contentChanged):
+(WebInspector.EditableResourceSourceFrame.prototype.canEditSource):
+

[webkit-changes] [111684] trunk/Source/WebKit2

[ahf]

Title: [111684] trunk/Source/WebKit2








Revision 111684
Author a...@0x90.dk
Date 2012-03-22 06:51:44 -0700 (Thu, 22 Mar 2012)


Log Message
[Qt][WK2] Add QML API for handling database quotas https://bugs.webkit.org/show_bug.cgi?id=81827

Reviewed by Simon Hausmann.

Patch by Pierre Rossi and Alexander Færøy.

This patch adds a QML API for handling database quotas.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::exceededDatabaseQuota):
(QQuickWebViewExperimental::databaseQuotaDialog):
(QQuickWebViewExperimental::setDatabaseQuotaDialog):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/qt/QtDialogRunner.cpp:
(DatabaseQuotaDialogContextObject):
(DatabaseQuotaDialogContextObject::DatabaseQuotaDialogContextObject):
(DatabaseQuotaDialogContextObject::databaseName):
(DatabaseQuotaDialogContextObject::displayName):
(DatabaseQuotaDialogContextObject::currentQuota):
(DatabaseQuotaDialogContextObject::currentOriginUsage):
(DatabaseQuotaDialogContextObject::currentDatabaseUsage):
(DatabaseQuotaDialogContextObject::expectedUsage):
(DatabaseQuotaDialogContextObject::accept):
(DatabaseQuotaDialogContextObject::reject):
(QtDialogRunner::initForDatabaseQuotaDialog):
* UIProcess/qt/QtDialogRunner.h:
(QtDialogRunner):
(QtDialogRunner::databaseQuota):
(QtDialogRunner::onDatabaseQuotaAccepted):
* UIProcess/qt/QtWebPageUIClient.cpp:
(QtWebPageUIClient::QtWebPageUIClient):
(QtWebPageUIClient::exceededDatabaseQuota):
* UIProcess/qt/QtWebPageUIClient.h:
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformDefaultDatabaseDirectory):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h
trunk/Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp
trunk/Source/WebKit2/UIProcess/qt/QtDialogRunner.h
trunk/Source/WebKit2/UIProcess/qt/QtWebPageUIClient.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageUIClient.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (111683 => 111684)

--- trunk/Source/WebKit2/ChangeLog	2012-03-22 13:40:06 UTC (rev 111683)
+++ trunk/Source/WebKit2/ChangeLog	2012-03-22 13:51:44 UTC (rev 111684)
@@ -1,3 +1,44 @@
+2012-03-21  Alexander Færøy  alexander.fae...@nokia.com
+
+[Qt][WK2] Add QML API for handling database quotas
+https://bugs.webkit.org/show_bug.cgi?id=81827
+
+Reviewed by Simon Hausmann.
+
+Patch by Pierre Rossi and Alexander Færøy.
+
+This patch adds a QML API for handling database quotas.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewPrivate::exceededDatabaseQuota):
+(QQuickWebViewExperimental::databaseQuotaDialog):
+(QQuickWebViewExperimental::setDatabaseQuotaDialog):
+* UIProcess/API/qt/qquickwebview_p.h:
+* UIProcess/API/qt/qquickwebview_p_p.h:
+(QQuickWebViewPrivate):
+* UIProcess/qt/QtDialogRunner.cpp:
+(DatabaseQuotaDialogContextObject):
+(DatabaseQuotaDialogContextObject::DatabaseQuotaDialogContextObject):
+(DatabaseQuotaDialogContextObject::databaseName):
+(DatabaseQuotaDialogContextObject::displayName):
+(DatabaseQuotaDialogContextObject::currentQuota):
+(DatabaseQuotaDialogContextObject::currentOriginUsage):
+(DatabaseQuotaDialogContextObject::currentDatabaseUsage):
+(DatabaseQuotaDialogContextObject::expectedUsage):
+(DatabaseQuotaDialogContextObject::accept):
+(DatabaseQuotaDialogContextObject::reject):
+(QtDialogRunner::initForDatabaseQuotaDialog):
+* UIProcess/qt/QtDialogRunner.h:
+(QtDialogRunner):
+(QtDialogRunner::databaseQuota):
+(QtDialogRunner::onDatabaseQuotaAccepted):
+* UIProcess/qt/QtWebPageUIClient.cpp:
+(QtWebPageUIClient::QtWebPageUIClient):
+(QtWebPageUIClient::exceededDatabaseQuota):
+* UIProcess/qt/QtWebPageUIClient.h:
+* UIProcess/qt/WebContextQt.cpp:
+(WebKit::WebContext::platformDefaultDatabaseDirectory):
+
 2012-03-21  Tim Horton  timothy_hor...@apple.com
 
 Make use of CG rounded-rect primitives


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (111683 => 111684)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-03-22 13:40:06 UTC (rev 111683)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-03-22 13:51:44 UTC (rev 111684)
@@ -399,6 +399,21 @@
 
 }
 
+quint64 QQuickWebViewPrivate::exceededDatabaseQuota(const QString databaseName, const QString displayName, quint64 currentQuota, quint64 currentOriginUsage, quint64 currentDatabaseUsage, quint64 expectedUsage)
+{
+if (!databaseQuotaDialog)
+return 0;
+
+Q_Q(QQuickWebView);
+QtDialogRunner dialogRunner;
+if (!dialogRunner.initForDatabaseQuotaDialog(databaseQuotaDialog, q, databaseName, displayName, currentQuota, 

[webkit-changes] [111686] trunk/Source

[wjmaclean]

Title: [111686] trunk/Source








Revision 111686
Author wjmacl...@chromium.org
Date 2012-03-22 07:03:06 -0700 (Thu, 22 Mar 2012)


Log Message
Rename touchpad fling curve, add curve parameters to constructor.
https://bugs.webkit.org/show_bug.cgi?id=81820

Reviewed by Adrienne Walker.

Source/WebCore:

Covered by existing unit tests.

* GNUmakefile.list.am:
* WebCore.gypi:
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::fireUpAnAnimation):
* platform/TouchpadFlingPlatformGestureCurve.cpp: Renamed from Source/WebCore/platform/TouchFlingPlatformGestureCurve.cpp.
(WebCore):
(WebCore::TouchpadFlingPlatformGestureCurve::create):
(WebCore::TouchpadFlingPlatformGestureCurve::TouchpadFlingPlatformGestureCurve):
(WebCore::TouchpadFlingPlatformGestureCurve::~TouchpadFlingPlatformGestureCurve):
(WebCore::TouchpadFlingPlatformGestureCurve::apply):
* platform/TouchpadFlingPlatformGestureCurve.h: Renamed from Source/WebCore/platform/TouchFlingPlatformGestureCurve.h.
(WebCore):
(TouchpadFlingPlatformGestureCurve):

Source/WebKit/chromium:

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::gestureEvent):
* tests/PlatformGestureCurveTest.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/platform/ScrollAnimatorNone.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp


Added Paths

trunk/Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.cpp
trunk/Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.h


Removed Paths

trunk/Source/WebCore/platform/TouchFlingPlatformGestureCurve.cpp
trunk/Source/WebCore/platform/TouchFlingPlatformGestureCurve.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (111685 => 111686)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 13:59:41 UTC (rev 111685)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 14:03:06 UTC (rev 111686)
@@ -1,3 +1,26 @@
+2012-03-22  W. James MacLean  wjmacl...@chromium.org
+
+Rename touchpad fling curve, add curve parameters to constructor.
+https://bugs.webkit.org/show_bug.cgi?id=81820
+
+Reviewed by Adrienne Walker.
+
+Covered by existing unit tests.
+
+* GNUmakefile.list.am:
+* WebCore.gypi:
+* platform/ScrollAnimatorNone.cpp:
+(WebCore::ScrollAnimatorNone::fireUpAnAnimation):
+* platform/TouchpadFlingPlatformGestureCurve.cpp: Renamed from Source/WebCore/platform/TouchFlingPlatformGestureCurve.cpp.
+(WebCore):
+(WebCore::TouchpadFlingPlatformGestureCurve::create):
+(WebCore::TouchpadFlingPlatformGestureCurve::TouchpadFlingPlatformGestureCurve):
+(WebCore::TouchpadFlingPlatformGestureCurve::~TouchpadFlingPlatformGestureCurve):
+(WebCore::TouchpadFlingPlatformGestureCurve::apply):
+* platform/TouchpadFlingPlatformGestureCurve.h: Renamed from Source/WebCore/platform/TouchFlingPlatformGestureCurve.h.
+(WebCore):
+(TouchpadFlingPlatformGestureCurve):
+
 2012-03-22  Pavel Feldman  pfeld...@chromium.org
 
 Web Inspector: make CSS and _javascript_ files editable by default.


Modified: trunk/Source/WebCore/GNUmakefile.list.am (111685 => 111686)

--- trunk/Source/WebCore/GNUmakefile.list.am	2012-03-22 13:59:41 UTC (rev 111685)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2012-03-22 14:03:06 UTC (rev 111686)
@@ -3564,8 +3564,8 @@
 	Source/WebCore/platform/text/UnicodeBidi.h \
 	Source/WebCore/platform/text/UnicodeRange.cpp \
 	Source/WebCore/platform/text/UnicodeRange.h \
-	Source/WebCore/platform/TouchFlingPlatformGestureCurve.cpp \
-	Source/WebCore/platform/TouchFlingPlatformGestureCurve.h \
+	Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.cpp \
+	Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.h \
 	Source/WebCore/platform/ThemeTypes.h \
 	Source/WebCore/platform/ThreadCheck.h \
 	Source/WebCore/platform/ThreadGlobalData.cpp \


Modified: trunk/Source/WebCore/WebCore.gypi (111685 => 111686)

--- trunk/Source/WebCore/WebCore.gypi	2012-03-22 13:59:41 UTC (rev 111685)
+++ trunk/Source/WebCore/WebCore.gypi	2012-03-22 14:03:06 UTC (rev 111686)
@@ -3091,8 +3091,8 @@
 'platform/ThreadTimers.cpp',
 'platform/ThreadTimers.h',
 'platform/Timer.cpp',
-'platform/TouchFlingPlatformGestureCurve.cpp',
-'platform/TouchFlingPlatformGestureCurve.h',
+'platform/TouchpadFlingPlatformGestureCurve.cpp',
+'platform/TouchpadFlingPlatformGestureCurve.h',
 'platform/UUID.cpp',
 'platform/UUID.h',
 'platform/WheelFlingPlatformGestureCurve.cpp',


Modified: trunk/Source/WebCore/platform/ScrollAnimatorNone.cpp (111685 => 111686)

--- 

[webkit-changes] [111687] trunk/Source

[noam . rosenthal]

Title: [111687] trunk/Source








Revision 111687
Author noam.rosent...@nokia.com
Date 2012-03-22 07:07:23 -0700 (Thu, 22 Mar 2012)


Log Message
[Qt][WK2] The background appears to have one extra pixel from the contents
https://bugs.webkit.org/show_bug.cgi?id=81830

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

TextureMapperGL applied a 1-offset that was covering for another bug,
which was already fixed.

No new tests, this would be tested once we test GL rendering results.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::SharedGLData::scissorClip):

Source/WebKit2:

The clip-polygon from the scenegraph uses floats, not integers.
This could cause 1-offset clipping problems in some cases.

* UIProcess/qt/QtWebPageSGNode.cpp:
(WebKit::ContentsSGNode::clipRect):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtWebPageSGNode.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (111686 => 111687)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 14:03:06 UTC (rev 111686)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 14:07:23 UTC (rev 111687)
@@ -1,3 +1,18 @@
+2012-03-22  No'am Rosenthal  noam.rosent...@nokia.com
+
+[Qt][WK2] The background appears to have one extra pixel from the contents
+https://bugs.webkit.org/show_bug.cgi?id=81830
+
+Reviewed by Kenneth Rohde Christiansen.
+
+TextureMapperGL applied a 1-offset that was covering for another bug,
+which was already fixed.
+
+No new tests, this would be tested once we test GL rendering results.
+
+* platform/graphics/texmap/TextureMapperGL.cpp:
+(WebCore::TextureMapperGLData::SharedGLData::scissorClip):
+
 2012-03-22  W. James MacLean  wjmacl...@chromium.org
 
 Rename touchpad fling curve, add curve parameters to constructor.


Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp (111686 => 111687)

--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp	2012-03-22 14:03:06 UTC (rev 111686)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp	2012-03-22 14:07:23 UTC (rev 111687)
@@ -160,7 +160,7 @@
 
 GLint viewport[4];
 GL_CMD(glGetIntegerv(GL_VIEWPORT, viewport))
-GL_CMD(glScissor(rect.x(), viewport[3] - rect.maxY() + 1, rect.width() - 1, rect.height() - 1))
+GL_CMD(glScissor(rect.x(), viewport[3] - rect.maxY(), rect.width(), rect.height()))
 }
 
 void applyCurrentClip()


Modified: trunk/Source/WebKit2/ChangeLog (111686 => 111687)

--- trunk/Source/WebKit2/ChangeLog	2012-03-22 14:03:06 UTC (rev 111686)
+++ trunk/Source/WebKit2/ChangeLog	2012-03-22 14:07:23 UTC (rev 111687)
@@ -1,3 +1,16 @@
+2012-03-22  No'am Rosenthal  noam.rosent...@nokia.com
+
+[Qt][WK2] The background appears to have one extra pixel from the contents
+https://bugs.webkit.org/show_bug.cgi?id=81830
+
+Reviewed by Kenneth Rohde Christiansen.
+
+The clip-polygon from the scenegraph uses floats, not integers.
+This could cause 1-offset clipping problems in some cases.
+
+* UIProcess/qt/QtWebPageSGNode.cpp:
+(WebKit::ContentsSGNode::clipRect):
+
 2012-03-21  Alexander Færøy  alexander.fae...@nokia.com
 
 [Qt][WK2] Add QML API for handling database quotas


Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageSGNode.cpp (111686 => 111687)

--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageSGNode.cpp	2012-03-22 14:03:06 UTC (rev 111686)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageSGNode.cpp	2012-03-22 14:07:23 UTC (rev 111687)
@@ -81,7 +81,7 @@
 QPolygonF polygon;
 
 for (int i = 0; i  geometry-vertexCount(); i++)
-polygon.append(clipMatrix.map(QPoint(geometryPoints[i].x, geometryPoints[i].y)));
+polygon.append(clipMatrix.map(QPointF(geometryPoints[i].x, geometryPoints[i].y)));
 currentClip = polygon.boundingRect();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111688] trunk/Source/WebCore

[yurys]

Title: [111688] trunk/Source/WebCore








Revision 111688
Author yu...@chromium.org
Date 2012-03-22 07:12:31 -0700 (Thu, 22 Mar 2012)


Log Message
Web Inspector: Speed up the build retainers phase.
https://bugs.webkit.org/show_bug.cgi?id=81763

Replacing the edge iterator with a raw loop makes it
faster by more than 10 times.

Patch by Alexei Filippov alex...@chromium.org on 2012-03-22
Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildRetainers):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (111687 => 111688)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 14:07:23 UTC (rev 111687)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 14:12:31 UTC (rev 111688)
@@ -1,3 +1,16 @@
+2012-03-22  Alexei Filippov  alex...@chromium.org
+
+Web Inspector: Speed up the build retainers phase.
+https://bugs.webkit.org/show_bug.cgi?id=81763
+
+Replacing the edge iterator with a raw loop makes it
+faster by more than 10 times.
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/HeapSnapshot.js:
+(WebInspector.HeapSnapshot.prototype._buildRetainers):
+
 2012-03-22  No'am Rosenthal  noam.rosent...@nokia.com
 
 [Qt][WK2] The background appears to have one extra pixel from the contents


Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js (111687 => 111688)

--- trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js	2012-03-22 14:07:23 UTC (rev 111687)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js	2012-03-22 14:12:31 UTC (rev 111688)
@@ -959,22 +959,56 @@
 
 _buildRetainers: function()
 {
-this._buildReverseIndex(
-_retainerIndex,
-_retainers,
-(function (node, callback)
- {
- for (var edgesIter = node.edges; edgesIter.hasNext(); edgesIter.next())
- callback(this._nodePosition[edgesIter.edge.nodeIndex]);
- }).bind(this),
-(function (node, indexCallback, dataCallback)
- {
- for (var edgesIter = node.edges; edgesIter.hasNext(); edgesIter.next()) {
- var edge = edgesIter.edge;
- var retIndex = this._getRetainerIndex(edge.nodeIndex);
- dataCallback(indexCallback(retIndex), node.nodeIndex + this._firstEdgeOffset + edge.edgeIndex);
- }
- }).bind(this));
+var nodeIndexes = this.nodeIndexes;
+var nodePositions = this._nodePosition;
+var nodeCount = this.nodeCount;
+var nodes = this._nodes;
+
+// Builds up two arrays:
+//  - backRefsArray is a continuous array, where each node owns an
+//interval (can be empty) with corresponding back references.
+//  - indexArray is an array of indexes in the backRefsArray
+//with the same positions as in the _nodeIndex.
+var indexArray = this._retainerIndex = new Int32Array(nodeCount);
+var edgesCountOffset = this._edgesCountOffset;
+var firstEdgeOffset = this._firstEdgeOffset;
+var edgeFieldsCount = this._edgeFieldsCount;
+var edgeToNodeOffset = this._edgeToNodeOffset;
+var backRefsCount = 0;
+// Count the number of retainers for each node
+for (var i = 0; i  nodeCount; ++i) {
+var nodeIndex = nodeIndexes[i];
+var edgesOffset = nodeIndex + firstEdgeOffset + edgeToNodeOffset;
+var edgesCount = nodes[nodeIndex + edgesCountOffset];
+backRefsCount += edgesCount;
+for (var j = 0; j  edgesCount; ++j) {
+  var targetNodeIndex = nodes[j * edgeFieldsCount + edgesOffset];
+  ++indexArray[nodePositions[targetNodeIndex]];
+}
+}
+var backRefsArray = this._retainers = new Int32Array(backRefsCount);
+// Put in the first slot of each backRefsArray slice the count of entries
+// that will be filled.
+var backRefsPosition = 0;
+for (i = 0; i  nodeCount; ++i) {
+backRefsCount = backRefsArray[backRefsPosition] = indexArray[i];
+indexArray[i] = backRefsPosition;
+backRefsPosition += backRefsCount;
+}
+var retainerIndex = this._retainerIndex;
+// Fill up the retainers array with indexes of edges.
+for (var i = 0; i  nodeCount; ++i) {
+var nodeIndex = nodeIndexes[i];
+var edgesOffset = nodeIndex + firstEdgeOffset;
+var edgesCount = nodes[nodeIndex + edgesCountOffset];
+for (var j = 0; j  edgesCount; ++j) {
+var edgeIndex = j * edgeFieldsCount + edgesOffset;
+var retNode = nodePositions[nodes[edgeIndex + edgeToNodeOffset]];
+var retIndex = indexArray[retNode];
+

[webkit-changes] [111689] trunk/Source/WebCore

[leviw]

Title: [111689] trunk/Source/WebCore








Revision 111689
Author le...@chromium.org
Date 2012-03-22 07:14:13 -0700 (Thu, 22 Mar 2012)


Log Message
Update LayoutUnit usage in FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=81754

Reviewed by Eric Seidel.

FrameSelection stores its caret and repaint bounds in absolute coordinates. Absolute coordinates
we treat as pixel values, so this patch changes these values to integers. Sub-pixel precision
will still be used when these coordinates are passed down and used locally.

No new tests. No change in behavior.

* editing/FrameSelection.cpp:
(WebCore::absoluteCaretY): Uses absolute coordinates, which are ints.
(WebCore::FrameSelection::modify): Uses absolute coordinates to handle vertical selection
modification. Sub-pixel precision will be used when these values are converted to local ones.
(WebCore::CaretBase::absoluteBoundsForLocalRect): Absolute coordinates - ints.
(WebCore::FrameSelection::absoluteCaretBounds): Ditto.
(WebCore::CaretBase::caretRepaintRect): The caret repaint rect is stored in absolute coordinates.
Reverting the values to ints.
(WebCore::FrameSelection::recomputeCaretRect): Ditto.
* editing/FrameSelection.h:
(FrameSelection):
* editing/mac/FrameSelectionMac.mm:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange): Switching to store absolute
coordinates as integers.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/FrameSelection.cpp
trunk/Source/WebCore/editing/FrameSelection.h
trunk/Source/WebCore/editing/mac/FrameSelectionMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (111688 => 111689)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 14:12:31 UTC (rev 111688)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 14:14:13 UTC (rev 111689)
@@ -1,3 +1,31 @@
+2012-03-22  Levi Weintraub  le...@chromium.org
+
+Update LayoutUnit usage in FrameSelection
+https://bugs.webkit.org/show_bug.cgi?id=81754
+
+Reviewed by Eric Seidel.
+
+FrameSelection stores its caret and repaint bounds in absolute coordinates. Absolute coordinates
+we treat as pixel values, so this patch changes these values to integers. Sub-pixel precision
+will still be used when these coordinates are passed down and used locally.
+
+No new tests. No change in behavior.
+
+* editing/FrameSelection.cpp:
+(WebCore::absoluteCaretY): Uses absolute coordinates, which are ints.
+(WebCore::FrameSelection::modify): Uses absolute coordinates to handle vertical selection
+modification. Sub-pixel precision will be used when these values are converted to local ones.
+(WebCore::CaretBase::absoluteBoundsForLocalRect): Absolute coordinates - ints.
+(WebCore::FrameSelection::absoluteCaretBounds): Ditto.
+(WebCore::CaretBase::caretRepaintRect): The caret repaint rect is stored in absolute coordinates.
+Reverting the values to ints.
+(WebCore::FrameSelection::recomputeCaretRect): Ditto.
+* editing/FrameSelection.h:
+(FrameSelection):
+* editing/mac/FrameSelectionMac.mm:
+(WebCore::FrameSelection::notifyAccessibilityForSelectionChange): Switching to store absolute
+coordinates as integers.
+
 2012-03-22  Alexei Filippov  alex...@chromium.org
 
 Web Inspector: Speed up the build retainers phase.


Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (111688 => 111689)

--- trunk/Source/WebCore/editing/FrameSelection.cpp	2012-03-22 14:12:31 UTC (rev 111688)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp	2012-03-22 14:14:13 UTC (rev 111689)
@@ -987,9 +987,9 @@
 }
 
 // FIXME: Maybe baseline would be better?
-static bool absoluteCaretY(const VisiblePosition c, LayoutUnit y)
+static bool absoluteCaretY(const VisiblePosition c, int y)
 {
-LayoutRect rect = c.absoluteCaretBounds();
+IntRect rect = c.absoluteCaretBounds();
 if (rect.isEmpty())
 return false;
 y = rect.y() + rect.height() / 2;
@@ -1028,12 +1028,12 @@
 break;
 }
 
-LayoutUnit startY;
+int startY;
 if (!absoluteCaretY(pos, startY))
 return false;
 if (direction == DirectionUp)
 startY = -startY;
-LayoutUnit lastY = startY;
+int lastY = startY;
 
 VisiblePosition result;
 VisiblePosition next;
@@ -1045,12 +1045,12 @@
 
 if (next.isNull() || next == p)
 break;
-LayoutUnit nextY;
+int nextY;
 if (!absoluteCaretY(next, nextY))
 break;
 if (direction == DirectionUp)
 nextY = -nextY;
-if (nextY - startY  static_castLayoutUnit(verticalDistance))
+if (nextY - startY  static_castint(verticalDistance))
 break;
 if (nextY = lastY) {
 lastY = nextY;
@@ -1247,11 +1247,11 @@
 return localCaretRectWithoutUpdate();
 }
 
-LayoutRect CaretBase::absoluteBoundsForLocalRect(Node* node, const LayoutRect rect) const
+IntRect 

[webkit-changes] [111690] branches/subpixellayout/Source/WebCore

[leviw]

Title: [111690] branches/subpixellayout/Source/WebCore








Revision 111690
Author le...@chromium.org
Date 2012-03-22 07:25:13 -0700 (Thu, 22 Mar 2012)


Log Message
Cleaning up an unnecessary include and the result of an over-eager search/replace in r107773.

Modified Paths

branches/subpixellayout/Source/WebCore/WebCore.order
branches/subpixellayout/Source/WebCore/inspector/InspectorPageAgent.cpp




Diff

Modified: branches/subpixellayout/Source/WebCore/WebCore.order (111689 => 111690)

--- branches/subpixellayout/Source/WebCore/WebCore.order	2012-03-22 14:14:13 UTC (rev 111689)
+++ branches/subpixellayout/Source/WebCore/WebCore.order	2012-03-22 14:25:13 UTC (rev 111690)
@@ -10299,7 +10299,7 @@
 __ZNK7WebCore8CSSValue12isImageValueEv
 __ZNK7WebCore22CSSImageGeneratorValue21isImageGeneratorValueEv
 __ZN7WebCore22CSSImageGeneratorValue14generatedImageEv
-__ZNK7WebCore14CSSCanvasValue11isFractionalLayoutSizeEv
+__ZNK7WebCore14CSSCanvasValue11isFixedSizeEv
 __ZN7WebCore19StyleGeneratedImage9addClientEPNS_12RenderObjectE
 __ZN7WebCore22CSSImageGeneratorValue9addClientEPNS_12RenderObjectERKNS_7IntSizeE
 __ZN7WebCore46jsDocumentPrototypeFunctionGetCSSCanvasContextEPN3JSC9ExecStateE
@@ -10433,7 +10433,7 @@
 __ZN7WebCore9CSSParser16parseBorderImageEibRN3WTF6RefPtrINS_8CSSValueEEE
 __ZN7WebCore23BorderImageParseContext17commitBorderImageEPNS_9CSSParserEb
 __ZN7WebCore23BorderImageParseContextD1Ev
-__ZNK7WebCore22CSSImageGeneratorValue11isFractionalLayoutSizeEv
+__ZNK7WebCore22CSSImageGeneratorValue11isFixedSizeEv
 __ZN7WebCore16CSSGradientValue5imageEPNS_12RenderObjectERKNS_7IntSizeE
 __ZNK3WTF9HashTableIPN7WebCore12RenderObjectESt4pairIS3_S4_INS1_7IntSizeEiEENS_18PairFirstExtractorIS7_EENS_7PtrHashIS3_EENS_14PairHashTraitsINS_10HashTraitsIS3_EENSD_IS6_SE_E8containsIS3_NS_22IdentityHashTranslatorIS3_S7_SB_bRKT_
 __ZN7WebCore22CSSImageGeneratorValue8getImageEPNS_12RenderObjectERKNS_7IntSizeE


Modified: branches/subpixellayout/Source/WebCore/inspector/InspectorPageAgent.cpp (111689 => 111690)

--- branches/subpixellayout/Source/WebCore/inspector/InspectorPageAgent.cpp	2012-03-22 14:14:13 UTC (rev 111689)
+++ branches/subpixellayout/Source/WebCore/inspector/InspectorPageAgent.cpp	2012-03-22 14:25:13 UTC (rev 111690)
@@ -51,7 +51,6 @@
 #include DocumentLoader.h
 #include Frame.h
 #include FrameView.h
-#include FrameView.h
 #include HTMLFrameOwnerElement.h
 #include HTMLNames.h
 #include IdentifiersFactory.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111691] trunk/Source/WebCore

[caseq]

Title: [111691] trunk/Source/WebCore








Revision 111691
Author ca...@chromium.org
Date 2012-03-22 07:29:39 -0700 (Thu, 22 Mar 2012)


Log Message
Web Inspector: only update timeline overview categories strips when these are visible
https://bugs.webkit.org/show_bug.cgi?id=81903

Reviewed by Pavel Feldman.

- factor out category strips update into a separate method;
- only invoke it when Timeline overview mode is selected.

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype._showTimelines):
(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.TimelineOverviewPane.prototype._updateCategoryStrips):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (111690 => 111691)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 14:25:13 UTC (rev 111690)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 14:29:39 UTC (rev 111691)
@@ -1,3 +1,18 @@
+2012-03-22  Andrey Kosyakov  ca...@chromium.org
+
+Web Inspector: only update timeline overview categories strips when these are visible
+https://bugs.webkit.org/show_bug.cgi?id=81903
+
+Reviewed by Pavel Feldman.
+
+- factor out category strips update into a separate method;
+- only invoke it when Timeline overview mode is selected.
+
+* inspector/front-end/TimelineOverviewPane.js:
+(WebInspector.TimelineOverviewPane.prototype._showTimelines):
+(WebInspector.TimelineOverviewPane.prototype.update):
+(WebInspector.TimelineOverviewPane.prototype._updateCategoryStrips):
+
 2012-03-22  Levi Weintraub  le...@chromium.org
 
 Update LayoutUnit usage in FrameSelection


Modified: trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js (111690 => 111691)

--- trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js	2012-03-22 14:25:13 UTC (rev 111690)
+++ trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js	2012-03-22 14:29:39 UTC (rev 111691)
@@ -138,6 +138,7 @@
 this._heapGraph.hide();
 this._setVerticalOverview(this._currentMode === WebInspector.TimelineOverviewPane.Mode.EventsVertical);
 this._overviewGrid.itemsGraphsElement.removeStyleClass(hidden);
+this._updateCategoryStrips(this._presentationModel.rootRecord().children);
 this.dispatchEventToListeners(WebInspector.TimelineOverviewPane.Events.ModeChanged, this._currentMode);
 },
 
@@ -184,14 +185,6 @@
 update: function(showShortEvents)
 {
 this._showShortEvents = showShortEvents;
-// Clear summary bars.
-var timelines = {};
-for (var category in this._presentationModel.categories) {
-timelines[category] = [];
-this._categoryGraphs[category].clearChunks();
-}
-
-// Create sparse arrays with 101 cells each to fill with chunks for a given category.
 this._overviewCalculator.reset();
 
 function updateBoundaries(record)
@@ -203,6 +196,26 @@
 var records = this._presentationModel.rootRecord().children;
 WebInspector.TimelinePanel.forAllRecords(records, updateBoundaries.bind(this));
 
+if (this._heapGraph.visible) {
+this._heapGraph.setSize(this._overviewGrid.element.offsetWidth, 60);
+this._heapGraph.update(records);
+} else if (this._verticalOverview)
+this._verticalOverview.update(records);
+else
+this._updateCategoryStrips(records);
+this._overviewGrid.updateDividers(true, this._overviewCalculator);
+},
+
+_updateCategoryStrips: function(records)
+{
+// Clear summary bars.
+var timelines = {};
+for (var category in this._presentationModel.categories) {
+timelines[category] = [];
+this._categoryGraphs[category].clearChunks();
+}
+
+// Create sparse arrays with 101 cells each to fill with chunks for a given category.
 function markPercentagesForRecord(record)
 {
 if (!(this._showShortEvents || record.isLong()))
@@ -238,12 +251,6 @@
 }
 }
 
-this._heapGraph.setSize(this._overviewGrid.element.offsetWidth, 60);
-if (this._heapGraph.visible)
-this._heapGraph.update(records);
-if (this._verticalOverview)
-this._verticalOverview.update(records);
-this._overviewGrid.updateDividers(true, this._overviewCalculator);
 },
 
 updateEventDividers: function(records, dividerConstructor)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111692] trunk/Source/WebCore

[commit-queue]

Title: [111692] trunk/Source/WebCore








Revision 111692
Author commit-qu...@webkit.org
Date 2012-03-22 07:35:51 -0700 (Thu, 22 Mar 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=81893
Remove custom bindings form ScriptProfileNode.idl of attribute type Array.

Patch by Vineet Chaudhary rgf...@motorola.com on 2012-03-22
Reviewed by Kentaro Hara.

Replace [CustomGetter] Array with sequenceScriptProfileNode.
To remove the custom bindings code.

Test: No new tests. LayoutTests/fast/profiler/* test are enough for this.

* bindings/js/JSScriptProfileNodeCustom.cpp: Removed custom function.
(WebCore::JSScriptProfileNode::callUID):
* bindings/v8/custom/V8ScriptProfileNodeCustom.cpp: Removed custom function.
(WebCore):
* inspector/ScriptProfileNode.idl: Replaced Array with sequenceScriptProfileNode.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSScriptProfileNodeCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileNodeCustom.cpp
trunk/Source/WebCore/inspector/ScriptProfileNode.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (111691 => 111692)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 14:29:39 UTC (rev 111691)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 14:35:51 UTC (rev 111692)
@@ -1,3 +1,21 @@
+2012-03-22  Vineet Chaudhary  rgf...@motorola.com
+
+https://bugs.webkit.org/show_bug.cgi?id=81893
+Remove custom bindings form ScriptProfileNode.idl of attribute type Array.
+
+Reviewed by Kentaro Hara.
+
+Replace [CustomGetter] Array with sequenceScriptProfileNode.
+To remove the custom bindings code.
+
+Test: No new tests. LayoutTests/fast/profiler/* test are enough for this.
+
+* bindings/js/JSScriptProfileNodeCustom.cpp: Removed custom function.
+(WebCore::JSScriptProfileNode::callUID):
+* bindings/v8/custom/V8ScriptProfileNodeCustom.cpp: Removed custom function.
+(WebCore):
+* inspector/ScriptProfileNode.idl: Replaced Array with sequenceScriptProfileNode.
+
 2012-03-22  Andrey Kosyakov  ca...@chromium.org
 
 Web Inspector: only update timeline overview categories strips when these are visible


Modified: trunk/Source/WebCore/bindings/js/JSScriptProfileNodeCustom.cpp (111691 => 111692)

--- trunk/Source/WebCore/bindings/js/JSScriptProfileNodeCustom.cpp	2012-03-22 14:29:39 UTC (rev 111691)
+++ trunk/Source/WebCore/bindings/js/JSScriptProfileNodeCustom.cpp	2012-03-22 14:35:51 UTC (rev 111692)
@@ -28,12 +28,6 @@
 
 #include JSScriptProfileNode.h
 
-#if ENABLE(_javascript__DEBUGGER)
-#include profiler/ProfileNode.h
-#endif
-
-#include runtime/JSArray.h
-
 using namespace JSC;
 
 namespace WebCore {
@@ -46,20 +40,6 @@
 return result;
 }
 
-typedef VectorRefPtrProfileNode  ProfileNodesList;
-
-JSValue JSScriptProfileNode::children(ExecState* exec) const
-{
-const ProfileNodesList children = impl()-children();
-MarkedArgumentBuffer list;
-
-ProfileNodesList::const_iterator end = children.end();
-for (ProfileNodesList::const_iterator iter = children.begin(); iter != end; ++iter)
-list.append(toJS(exec, globalObject(), iter-get()));
-
-return constructArray(exec, globalObject(), list);
-}
-
 #endif
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileNodeCustom.cpp (111691 => 111692)

--- trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileNodeCustom.cpp	2012-03-22 14:29:39 UTC (rev 111691)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileNodeCustom.cpp	2012-03-22 14:35:51 UTC (rev 111692)
@@ -40,19 +40,6 @@
 
 namespace WebCore {
 
-v8::Handlev8::Value V8ScriptProfileNode::childrenAccessorGetter(v8::Localv8::String name, const v8::AccessorInfo info)
-{
-INC_STATS(DOM.ScriptProfileNode.childrenAccessorGetter);
-ScriptProfileNode* imp = V8ScriptProfileNode::toNative(info.Holder());
-const ProfileNodesList children = imp-children();
-v8::Handlev8::Array result = v8::Array::New(children.size());
-int index = 0;
-ProfileNodesList::const_iterator end = children.end();
-for (ProfileNodesList::const_iterator iter = children.begin(); iter != end; ++iter)
-result-Set(v8::Integer::New(index++), toV8(iter-get()));
-return result;
-}
-
 v8::Handlev8::Value V8ScriptProfileNode::callUIDAccessorGetter(v8::Localv8::String name, const v8::AccessorInfo info)
 {
 INC_STATS(DOM.ScriptProfileNode.callUIDAccessorGetter);


Modified: trunk/Source/WebCore/inspector/ScriptProfileNode.idl (111691 => 111692)

--- trunk/Source/WebCore/inspector/ScriptProfileNode.idl	2012-03-22 14:29:39 UTC (rev 111691)
+++ trunk/Source/WebCore/inspector/ScriptProfileNode.idl	2012-03-22 14:35:51 UTC (rev 111692)
@@ -37,7 +37,7 @@
 readonly attribute double totalTime;
 readonly attribute double selfTime;
 readonly attribute unsigned long numberOfCalls;
-readonly attribute [CustomGetter] Array children;
+readonly attribute 

[webkit-changes] [111694] trunk/Source/WebCore

[vsevik]

Title: [111694] trunk/Source/WebCore








Revision 111694
Author vse...@chromium.org
Date 2012-03-22 07:48:01 -0700 (Thu, 22 Mar 2012)


Log Message
Web Inspector: Introduce ScriptBound/ScriptUnbound events in ScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=81904

Reviewed by Pavel Feldman.

This is another step on the way to cleaner BreakpointManager logic.
Here we extract ScriptBound/ScriptUnbound events from UISourceCodeListChanged event.
This allows us to handle script-uiSourceCode binding separately from
uiSourceCode creation/deletion and to handle unbinding that was not
possible at all before.

* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype._uiSourceCodesForSourceMap):
(WebInspector.CompilerScriptMapping.prototype.addScript.get this):
(WebInspector.CompilerScriptMapping.prototype.addScript):
(WebInspector.CompilerScriptMapping.prototype.reset):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeChanged):
* inspector/front-end/ScriptMapping.js:
(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype._updateLiveLocation):
(WebInspector.MainScriptMapping.prototype._handleUISourceCodeListChanged):
(WebInspector.MainScriptMapping.prototype._handleScriptBound):
(WebInspector.MainScriptMapping.prototype._handleScriptUnbound):
* inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsScriptMapping.prototype.addScript.get this):
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):
(WebInspector.SnippetsScriptMapping.prototype._snippetRemoved.get this):
(WebInspector.SnippetsScriptMapping.prototype._snippetRemoved):
(WebInspector.SnippetsScriptMapping.prototype.reset):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerScriptMapping.js
trunk/Source/WebCore/inspector/front-end/ResourceScriptMapping.js
trunk/Source/WebCore/inspector/front-end/ScriptMapping.js
trunk/Source/WebCore/inspector/front-end/SnippetsModel.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (111693 => 111694)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 14:39:22 UTC (rev 111693)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 14:48:01 UTC (rev 111694)
@@ -1,3 +1,37 @@
+2012-03-22  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: Introduce ScriptBound/ScriptUnbound events in ScriptMapping.
+https://bugs.webkit.org/show_bug.cgi?id=81904
+
+Reviewed by Pavel Feldman.
+
+This is another step on the way to cleaner BreakpointManager logic.
+Here we extract ScriptBound/ScriptUnbound events from UISourceCodeListChanged event.
+This allows us to handle script-uiSourceCode binding separately from
+uiSourceCode creation/deletion and to handle unbinding that was not
+possible at all before.
+
+* inspector/front-end/CompilerScriptMapping.js:
+(WebInspector.CompilerScriptMapping.prototype._uiSourceCodesForSourceMap):
+(WebInspector.CompilerScriptMapping.prototype.addScript.get this):
+(WebInspector.CompilerScriptMapping.prototype.addScript):
+(WebInspector.CompilerScriptMapping.prototype.reset):
+* inspector/front-end/ResourceScriptMapping.js:
+(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeChanged):
+* inspector/front-end/ScriptMapping.js:
+(WebInspector.MainScriptMapping):
+(WebInspector.MainScriptMapping.prototype._updateLiveLocation):
+(WebInspector.MainScriptMapping.prototype._handleUISourceCodeListChanged):
+(WebInspector.MainScriptMapping.prototype._handleScriptBound):
+(WebInspector.MainScriptMapping.prototype._handleScriptUnbound):
+* inspector/front-end/SnippetsModel.js:
+(WebInspector.SnippetsScriptMapping.prototype.addScript.get this):
+(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
+(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):
+(WebInspector.SnippetsScriptMapping.prototype._snippetRemoved.get this):
+(WebInspector.SnippetsScriptMapping.prototype._snippetRemoved):
+(WebInspector.SnippetsScriptMapping.prototype.reset):
+
 2012-03-22  Vineet Chaudhary  rgf...@motorola.com
 
 https://bugs.webkit.org/show_bug.cgi?id=81893


Modified: trunk/Source/WebCore/inspector/front-end/CompilerScriptMapping.js (111693 => 111694)

--- trunk/Source/WebCore/inspector/front-end/CompilerScriptMapping.js	2012-03-22 14:39:22 UTC (rev 111693)
+++ trunk/Source/WebCore/inspector/front-end/CompilerScriptMapping.js	2012-03-22 14:48:01 UTC (rev 111694)
@@ -79,6 +79,19 @@
 },
 
 /**
+ * @param {WebInspector.SourceMapParser} sourceMap
+ * @return {Array.WebInspector.UISourceCode}
+ */
+_uiSourceCodesForSourceMap: function(sourceMap)
+{
+var result = []
+var sourceURLs = 

[webkit-changes] [111695] trunk

[apavlov]

Title: [111695] trunk








Revision 111695
Author apav...@chromium.org
Date 2012-03-22 07:53:28 -0700 (Thu, 22 Mar 2012)


Log Message
Web Inspector: Case of the elements of the xml document should be shown as it is in the console
https://bugs.webkit.org/show_bug.cgi?id=81902

Source/WebCore:

When registering a detached root, DOMAgent always presumes it is a node,
while it can also be a document.

Reviewed by Vsevolod Vlasov.

Test: inspector/console/console-xml-document.html

* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._setDetachedRoot):

LayoutTests:

Reviewed by Vsevolod Vlasov.

* inspector/console/console-xml-document-expected.txt: Added.
* inspector/console/console-xml-document.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js
trunk/Source/WebCore/inspector/front-end/DOMAgent.js


Added Paths

trunk/LayoutTests/inspector/console/console-xml-document-expected.txt
trunk/LayoutTests/inspector/console/console-xml-document.html




Diff

Modified: trunk/LayoutTests/ChangeLog (111694 => 111695)

--- trunk/LayoutTests/ChangeLog	2012-03-22 14:48:01 UTC (rev 111694)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 14:53:28 UTC (rev 111695)
@@ -1,3 +1,13 @@
+2012-03-22  Alexander Pavlov  apav...@chromium.org
+
+Web Inspector: Case of the elements of the xml document should be shown as it is in the console
+https://bugs.webkit.org/show_bug.cgi?id=81902
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/console/console-xml-document-expected.txt: Added.
+* inspector/console/console-xml-document.html: Added.
+
 2012-03-22  Ádám Kallai  ka...@inf.u-szeged.hu
 
 [Qt] Gardening. Skip failing test.


Added: trunk/LayoutTests/inspector/console/console-xml-document-expected.txt (0 => 111695)

--- trunk/LayoutTests/inspector/console/console-xml-document-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/console/console-xml-document-expected.txt	2012-03-22 14:53:28 UTC (rev 111695)
@@ -0,0 +1,5 @@
+CONSOLE MESSAGE: line 9: [object Document]
+Tests that XML document contents are logged using the correct case in the console.
+
+#documentMixedCase Test /MixedCase console-xml-document.html:9
+
Property changes on: trunk/LayoutTests/inspector/console/console-xml-document-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/inspector/console/console-xml-document.html (0 => 111695)

--- trunk/LayoutTests/inspector/console/console-xml-document.html	(rev 0)
+++ trunk/LayoutTests/inspector/console/console-xml-document.html	2012-03-22 14:53:28 UTC (rev 111695)
@@ -0,0 +1,33 @@
+html
+head
+script src=""
+script src=""
+script
+
+function onload()
+{
+console.dirxml((new DOMParser()).parseFromString(MixedCase Test /MixedCase, text/xml));
+runTest();
+}
+
+function test()
+{
+InspectorTest.expandConsoleMessages();
+InspectorTest.runAfterPendingDispatches(callback);
+
+function callback()
+{
+InspectorTest.dumpConsoleMessages();
+InspectorTest.completeTest();
+}
+}
+/script
+/head
+
+body _onload_=onload()
+p
+Tests that XML document contents are logged using the correct case in the console.
+/p
+
+/body
+/html
Property changes on: trunk/LayoutTests/inspector/console/console-xml-document.html
___


Added: svn:eol-style

Modified: trunk/Source/WebCore/ChangeLog (111694 => 111695)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 14:48:01 UTC (rev 111694)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 14:53:28 UTC (rev 111695)
@@ -1,3 +1,20 @@
+2012-03-22  Alexander Pavlov  apav...@chromium.org
+
+Web Inspector: Case of the elements of the xml document should be shown as it is in the console
+https://bugs.webkit.org/show_bug.cgi?id=81902
+
+When registering a detached root, DOMAgent always presumes it is a node,
+while it can also be a document.
+
+Reviewed by Vsevolod Vlasov.
+
+Test: inspector/console/console-xml-document.html
+
+* inspector/front-end/ConsoleMessage.js:
+(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
+* inspector/front-end/DOMAgent.js:
+(WebInspector.DOMAgent.prototype._setDetachedRoot):
+
 2012-03-22  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: Introduce ScriptBound/ScriptUnbound events in ScriptMapping.


Modified: trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js (111694 => 111695)

--- trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js	2012-03-22 14:48:01 UTC (rev 111694)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js	2012-03-22 14:53:28 UTC (rev 111695)
@@ -284,6 

[webkit-changes] [111696] trunk

[carlosgc]

Title: [111696] trunk








Revision 111696
Author carlo...@webkit.org
Date 2012-03-22 07:56:33 -0700 (Thu, 22 Mar 2012)


Log Message
[GTK] Use the angle-bracket form to include wtf headers
https://bugs.webkit.org/show_bug.cgi?id=81884

Patch by Carlos Garcia Campos cgar...@bb-webkit-rel-64.local.igalia.com on 2012-03-22
Reviewed by Eric Seidel.

Source/WebCore:

Use #include wtf/foo instead of #include foo.

* platform/graphics/freetype/FontPlatformData.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
* platform/gtk/DataObjectGtk.h:
* platform/network/ResourceHandleInternal.h:
* platform/network/soup/SocketStreamHandleSoup.cpp:

Source/WebKit/gtk:

Use #include wtf/foo instead of #include foo.

* WebCoreSupport/DocumentLoaderGtk.cpp:
* WebCoreSupport/DragClientGtk.h:
* WebCoreSupport/FrameLoaderClientGtk.cpp:
* WebCoreSupport/FullscreenVideoController.h:
* WebCoreSupport/GeolocationClientGtk.h:
* WebCoreSupport/InspectorClientGtk.h:
* WebCoreSupport/TextCheckerClientGtk.cpp:
* WebCoreSupport/TextCheckerClientGtk.h:
* webkit/webkitdownload.cpp:
* webkit/webkitfavicondatabase.cpp:
* webkit/webkitglobals.cpp:
* webkit/webkithittestresult.cpp:
* webkit/webkitnetworkrequest.cpp:
* webkit/webkitnetworkresponse.cpp:
* webkit/webkitspellcheckerenchant.cpp:
* webkit/webkitwebdatasourceprivate.h:
* webkit/webkitwebsettings.cpp:
* webkit/webkitwebsettingsprivate.h:
* webkit/webkitwebviewprivate.h:

Source/WebKit2:

Use #include wtf/foo instead of #include _javascript_Core/foo.

* UIProcess/API/gtk/tests/TestMain.h:
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

Tools:

Use #include wtf/foo instead of #include foo.

* DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
* DumpRenderTree/gtk/DumpRenderTree.cpp:
* DumpRenderTree/gtk/EditingCallbacks.cpp:
* DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/freetype/FontPlatformData.h
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
trunk/Source/WebCore/platform/gtk/DataObjectGtk.h
trunk/Source/WebCore/platform/network/ResourceHandleInternal.h
trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/WebCoreSupport/DocumentLoaderGtk.cpp
trunk/Source/WebKit/gtk/WebCoreSupport/DragClientGtk.h
trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp
trunk/Source/WebKit/gtk/WebCoreSupport/FullscreenVideoController.h
trunk/Source/WebKit/gtk/WebCoreSupport/GeolocationClientGtk.h
trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h
trunk/Source/WebKit/gtk/WebCoreSupport/TextCheckerClientGtk.cpp
trunk/Source/WebKit/gtk/WebCoreSupport/TextCheckerClientGtk.h
trunk/Source/WebKit/gtk/webkit/webkitdownload.cpp
trunk/Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp
trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp
trunk/Source/WebKit/gtk/webkit/webkithittestresult.cpp
trunk/Source/WebKit/gtk/webkit/webkitnetworkrequest.cpp
trunk/Source/WebKit/gtk/webkit/webkitnetworkresponse.cpp
trunk/Source/WebKit/gtk/webkit/webkitspellcheckerenchant.cpp
trunk/Source/WebKit/gtk/webkit/webkitwebdatasourceprivate.h
trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp
trunk/Source/WebKit/gtk/webkit/webkitwebsettingsprivate.h
trunk/Source/WebKit/gtk/webkit/webkitwebviewprivate.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/gtk/AccessibilityCallbacks.cpp
trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp
trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp
trunk/Tools/DumpRenderTree/gtk/EditingCallbacks.cpp
trunk/Tools/DumpRenderTree/gtk/WorkQueueItemGtk.cpp
trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (111695 => 111696)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 14:53:28 UTC (rev 111695)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 14:56:33 UTC (rev 111696)
@@ -1,3 +1,18 @@
+2012-03-22  Carlos Garcia Campos  cgar...@bb-webkit-rel-64.local.igalia.com
+
+[GTK] Use the angle-bracket form to include wtf headers
+https://bugs.webkit.org/show_bug.cgi?id=81884
+
+Reviewed by Eric Seidel.
+
+Use #include wtf/foo instead of #include foo.
+
+* platform/graphics/freetype/FontPlatformData.h:
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+* platform/gtk/DataObjectGtk.h:
+* platform/network/ResourceHandleInternal.h:
+* platform/network/soup/SocketStreamHandleSoup.cpp:
+
 2012-03-22  Alexander Pavlov  apav...@chromium.org
 
 Web Inspector: Case of the elements of the xml document should be shown as it is in the console


Modified: 

[webkit-changes] [111697] trunk/Source/WebCore

[loislo]

Title: [111697] trunk/Source/WebCore








Revision 111697
Author loi...@chromium.org
Date 2012-03-22 08:04:38 -0700 (Thu, 22 Mar 2012)


Log Message
Web Inspector: HeapProfiler: Heap snapshot worker has to report the errors to the front-end
https://bugs.webkit.org/show_bug.cgi?id=81804

Sometimes the worker process of HeapSnapshot does some wrong thing and throw an Exception.
At this momemnt we have no way to see the error in the front-end.

Reviewed by Yury Semikhatsky.

* English.lproj/localizedStrings.js:
* inspector/front-end/HeapSnapshotProxy.js: check the exception field and dump it into front-end's console.
(WebInspector.HeapSnapshotWorker.prototype._messageReceived):
* inspector/front-end/HeapSnapshotWorkerDispatcher.js: catch the exception and transfer it's text to requester's side.
(WebInspector.HeapSnapshotWorkerDispatcher.prototype.dispatchMessage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js
trunk/Source/WebCore/inspector/front-end/HeapSnapshotWorkerDispatcher.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (111696 => 111697)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 14:56:33 UTC (rev 111696)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 15:04:38 UTC (rev 111697)
@@ -1,3 +1,19 @@
+2012-03-21  Ilya Tikhonovsky  loi...@chromium.org
+
+Web Inspector: HeapProfiler: Heap snapshot worker has to report the errors to the front-end
+https://bugs.webkit.org/show_bug.cgi?id=81804
+
+Sometimes the worker process of HeapSnapshot does some wrong thing and throw an Exception.
+At this momemnt we have no way to see the error in the front-end.
+
+Reviewed by Yury Semikhatsky.
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/HeapSnapshotProxy.js: check the exception field and dump it into front-end's console.
+(WebInspector.HeapSnapshotWorker.prototype._messageReceived):
+* inspector/front-end/HeapSnapshotWorkerDispatcher.js: catch the exception and transfer it's text to requester's side.
+(WebInspector.HeapSnapshotWorkerDispatcher.prototype.dispatchMessage):
+
 2012-03-22  Carlos Garcia Campos  cgar...@bb-webkit-rel-64.local.igalia.com
 
 [GTK] Use the angle-bracket form to include wtf headers


Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js

(Binary files differ)


Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js (111696 => 111697)

--- trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js	2012-03-22 14:56:33 UTC (rev 111696)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js	2012-03-22 15:04:38 UTC (rev 111697)
@@ -188,6 +188,13 @@
 _messageReceived: function(event)
 {
 var data = ""
+if (event.data.error) {
+if (event.data.errorMethodName)
+WebInspector.log(WebInspector.UIString(An error happend when a call for method '%s' was requested, event.data.errorMethodName));
+WebInspector.log(event.data.errorCallStack);
+delete this._callbacks[data.callId];
+return;
+}
 if (!this._callbacks[data.callId])
 return;
 var callback = this._callbacks[data.callId];


Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotWorkerDispatcher.js (111696 => 111697)

--- trunk/Source/WebCore/inspector/front-end/HeapSnapshotWorkerDispatcher.js	2012-03-22 14:56:33 UTC (rev 111696)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotWorkerDispatcher.js	2012-03-22 15:04:38 UTC (rev 111697)
@@ -48,38 +48,44 @@
 dispatchMessage: function(event)
 {
 var data = ""
-switch (data.disposition) {
-case create: {
-var constructorFunction = this._findFunction(data.methodName);
-this._objects[data.objectId] = new constructorFunction();
-this._postMessage({callId: data.callId});
-break;
+var response = {callId: data.callId};
+try {
+switch (data.disposition) {
+case create: {
+var constructorFunction = this._findFunction(data.methodName);
+this._objects[data.objectId] = new constructorFunction();
+break;
+}
+case dispose: {
+delete this._objects[data.objectId];
+break;
+}
+case getter: {
+var object = this._objects[data.objectId];
+var result = object[data.methodName];
+response.result = result;
+break;
+}
+case factory: {
+var object = this._objects[data.objectId];
+var result = object[data.methodName].apply(object, data.methodArguments);
+if 

[webkit-changes] [111698] trunk/Source/WebKit/gtk

[sergio]

Title: [111698] trunk/Source/WebKit/gtk








Revision 111698
Author ser...@webkit.org
Date 2012-03-22 08:05:41 -0700 (Thu, 22 Mar 2012)


Log Message
[GTK] icon database requests not dispatched until new data arrives
https://bugs.webkit.org/show_bug.cgi?id=81665

Reviewed by Martin Robinson.

Wait for the import to finish before reporting that the favicon
cache does not have a pixbuf for an URL.

Changes already covered by the favicon database unit tests.

* webkit/webkitfavicondatabase.cpp:
(webkit_favicon_database_get_favicon_pixbuf):

Modified Paths

trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp




Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (111697 => 111698)

--- trunk/Source/WebKit/gtk/ChangeLog	2012-03-22 15:04:38 UTC (rev 111697)
+++ trunk/Source/WebKit/gtk/ChangeLog	2012-03-22 15:05:41 UTC (rev 111698)
@@ -1,3 +1,18 @@
+2012-03-22  Sergio Villar Senin  svil...@igalia.com
+
+[GTK] icon database requests not dispatched until new data arrives
+https://bugs.webkit.org/show_bug.cgi?id=81665
+
+Reviewed by Martin Robinson.
+
+Wait for the import to finish before reporting that the favicon
+cache does not have a pixbuf for an URL.
+
+Changes already covered by the favicon database unit tests.
+
+* webkit/webkitfavicondatabase.cpp:
+(webkit_favicon_database_get_favicon_pixbuf):
+
 2012-03-22  Carlos Garcia Campos  cgar...@bb-webkit-rel-64.local.igalia.com
 
 [GTK] Use the angle-bracket form to include wtf headers


Modified: trunk/Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp (111697 => 111698)

--- trunk/Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp	2012-03-22 15:04:38 UTC (rev 111697)
+++ trunk/Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp	2012-03-22 15:05:41 UTC (rev 111698)
@@ -521,8 +521,10 @@
 GRefPtrGSimpleAsyncResult result = adoptGRef(g_simple_async_result_new(G_OBJECT(database), callback, userData,
  reinterpret_castgpointer(webkit_favicon_database_get_favicon_pixbuf)));
 
-// If we don't have an icon for the given URI return ASAP.
-if (database-priv-importFinished  iconDatabase().synchronousIconURLForPageURL(String::fromUTF8(pageURI)).isEmpty()) {
+// If we don't have an icon for the given URI or the database is not opened then return ASAP. We have to check that
+// because if the database is not opened it will skip (and not notify about) every single icon load request
+if ((database-priv-importFinished  iconDatabase().synchronousIconURLForPageURL(String::fromUTF8(pageURI)).isEmpty())
+|| !iconDatabase().isOpen()) {
 g_simple_async_result_set_op_res_gpointer(result.get(), 0, 0);
 g_simple_async_result_complete_in_idle(result.get());
 return;
@@ -536,11 +538,11 @@
 ASSERT(icons);
 icons-append(adoptPtr(request));
 
+// We ask for the icon directly. If we don't get the icon data now,
+// we'll be notified later (even if the database is still importing icons).
 GdkPixbuf* pixbuf = getIconPixbufSynchronously(database, pageURL, IntSize(width, height));
-if (!pixbuf  !database-priv-importFinished) {
-// Initial import is ongoing, the icon data will be available later.
+if (!pixbuf)
 return;
-}
 
 request-asyncResultCompleteInIdle(pixbuf);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111699] trunk/Source/WebCore

[leviw]

Title: [111699] trunk/Source/WebCore








Revision 111699
Author le...@chromium.org
Date 2012-03-22 08:07:02 -0700 (Thu, 22 Mar 2012)


Log Message
Correct LayoutUnit usage in Accessibility code
https://bugs.webkit.org/show_bug.cgi?id=81789

Reviewed by Eric Seidel.

Reverting Accessibility hit testing code back to integers. Accessibility hit tests originate from
the embedder and don't accumulate offsets, so we get nothing from using LayoutUnits, and needlessly
expose them to the embedder.

No new tests. No change in behavior.

* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::elementAccessibilityHitTest): See above.
* accessibility/AccessibilityListBox.h:
(AccessibilityListBox):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::clickPoint): This value is only ever used to display a context menu,
which is always done with integer coordinates.
(WebCore::AccessibilityObject::boundingBoxForQuads): This is a bounding box built from floats. We
don't pixel snap floats, so we return an integer bounding box.
(WebCore::AccessibilityObject::elementAccessibilityHitTest): See above.
(WebCore::AccessibilityObject::scrollToMakeVisible): Pixel snapping the bounding box and simplifying
up the code to position it at (0,0).
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::accessibilityHitTest): See above.
(AccessibilityObject):
(WebCore::AccessibilityObject::pixelSnappedBoundingBoxRect): Convenience method for embedder callers.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForPoint): The point passed in here is comes from
screen coordinates and originates in embedder code. Reverting it to take an integer.
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest): See above.
(WebCore::AccessibilityRenderObject::accessibilityHitTest): See above.
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::accessibilityHitTest): See above.
* accessibility/AccessibilityScrollView.h:
(AccessibilityScrollView):
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::elementAccessibilityHitTest): See above.
* accessibility/AccessibilitySlider.h:
(AccessibilitySlider):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityListBox.cpp
trunk/Source/WebCore/accessibility/AccessibilityListBox.h
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h
trunk/Source/WebCore/accessibility/AccessibilityScrollView.cpp
trunk/Source/WebCore/accessibility/AccessibilityScrollView.h
trunk/Source/WebCore/accessibility/AccessibilitySlider.cpp
trunk/Source/WebCore/accessibility/AccessibilitySlider.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (111698 => 111699)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 15:05:41 UTC (rev 111698)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 15:07:02 UTC (rev 111699)
@@ -1,3 +1,48 @@
+2012-03-22  Levi Weintraub  le...@chromium.org
+
+Correct LayoutUnit usage in Accessibility code
+https://bugs.webkit.org/show_bug.cgi?id=81789
+
+Reviewed by Eric Seidel.
+
+Reverting Accessibility hit testing code back to integers. Accessibility hit tests originate from
+the embedder and don't accumulate offsets, so we get nothing from using LayoutUnits, and needlessly
+expose them to the embedder.
+
+No new tests. No change in behavior.
+
+* accessibility/AccessibilityListBox.cpp:
+(WebCore::AccessibilityListBox::elementAccessibilityHitTest): See above.
+* accessibility/AccessibilityListBox.h:
+(AccessibilityListBox):
+* accessibility/AccessibilityObject.cpp:
+(WebCore::AccessibilityObject::clickPoint): This value is only ever used to display a context menu,
+which is always done with integer coordinates.
+(WebCore::AccessibilityObject::boundingBoxForQuads): This is a bounding box built from floats. We
+don't pixel snap floats, so we return an integer bounding box.
+(WebCore::AccessibilityObject::elementAccessibilityHitTest): See above.
+(WebCore::AccessibilityObject::scrollToMakeVisible): Pixel snapping the bounding box and simplifying
+up the code to position it at (0,0).
+* accessibility/AccessibilityObject.h:
+(WebCore::AccessibilityObject::accessibilityHitTest): See above.
+(AccessibilityObject):
+(WebCore::AccessibilityObject::pixelSnappedBoundingBoxRect): Convenience method for embedder callers.
+* accessibility/AccessibilityRenderObject.cpp:
+(WebCore::AccessibilityRenderObject::visiblePositionForPoint): The point passed in here is comes from
+

[webkit-changes] [111701] branches/subpixellayout/Source/WebCore/rendering/RenderListMarker. cpp

[leviw]

Title: [111701] branches/subpixellayout/Source/WebCore/rendering/RenderListMarker.cpp








Revision 111701
Author le...@chromium.org
Date 2012-03-22 08:09:50 -0700 (Thu, 22 Mar 2012)


Log Message
Fixing pixel snapping in RenderListMarker and correcting the use of LayoutUnits mixed with fonts.

Modified Paths

branches/subpixellayout/Source/WebCore/rendering/RenderListMarker.cpp




Diff

Modified: branches/subpixellayout/Source/WebCore/rendering/RenderListMarker.cpp (111700 => 111701)

--- branches/subpixellayout/Source/WebCore/rendering/RenderListMarker.cpp	2012-03-22 15:09:08 UTC (rev 111700)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderListMarker.cpp	2012-03-22 15:09:50 UTC (rev 111701)
@@ -1094,8 +1094,7 @@
 {
 InlineBox* box = inlineBoxWrapper();
 if (!box)
-// FIXME: Should pixel snap?
-return IntRect(IntPoint(), expandedIntSize(size()));
+return IntRect(IntPoint(), frameRect().pixelSnappedSize());
 RootInlineBox* root = m_inlineBoxWrapper-root();
 int newLogicalTop = root-block()-style()-isFlippedBlocksWritingMode() ? m_inlineBoxWrapper-logicalBottom() - root-selectionBottom() : root-selectionTop() - m_inlineBoxWrapper-logicalTop();
 if (root-block()-style()-isHorizontalWritingMode())
@@ -1350,7 +1349,7 @@
 if (isImage()) {
 // FIXME: This is a somewhat arbitrary width.  Generated images for markers really won't become particularly useful
 // until we support the CSS3 marker pseudoclass to allow control over the width and height of the marker box.
-LayoutUnit bulletWidth = fontMetrics.ascent() / 2;
+int bulletWidth = fontMetrics.ascent() / 2;
 m_image-setContainerSizeForRenderer(this, IntSize(bulletWidth, bulletWidth), style()-effectiveZoom());
 LayoutSize imageSize = m_image-imageSize(this, style()-effectiveZoom());
 m_minPreferredLogicalWidth = m_maxPreferredLogicalWidth = style()-isHorizontalWritingMode() ? imageSize.width() : imageSize.height();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111702] trunk/Source/WebCore

[yurys]

Title: [111702] trunk/Source/WebCore








Revision 111702
Author yu...@chromium.org
Date 2012-03-22 08:15:52 -0700 (Thu, 22 Mar 2012)


Log Message
Unreviewed, rolling out r111688.
http://trac.webkit.org/changeset/111688
https://bugs.webkit.org/show_bug.cgi?id=81912

Heap profiler test fails (Requested by yurys on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2012-03-22

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildRetainers):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (111701 => 111702)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 15:09:50 UTC (rev 111701)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 15:15:52 UTC (rev 111702)
@@ -1,3 +1,14 @@
+2012-03-22  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r111688.
+http://trac.webkit.org/changeset/111688
+https://bugs.webkit.org/show_bug.cgi?id=81912
+
+Heap profiler test fails (Requested by yurys on #webkit).
+
+* inspector/front-end/HeapSnapshot.js:
+(WebInspector.HeapSnapshot.prototype._buildRetainers):
+
 2012-03-22  Dana Jansens  dan...@chromium.org
 
 [chromium] Early out in a new prepareToDraw() step if checkerboarding an accelerated animation in order to skip the frame


Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js (111701 => 111702)

--- trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js	2012-03-22 15:09:50 UTC (rev 111701)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js	2012-03-22 15:15:52 UTC (rev 111702)
@@ -959,56 +959,22 @@
 
 _buildRetainers: function()
 {
-var nodeIndexes = this.nodeIndexes;
-var nodePositions = this._nodePosition;
-var nodeCount = this.nodeCount;
-var nodes = this._nodes;
-
-// Builds up two arrays:
-//  - backRefsArray is a continuous array, where each node owns an
-//interval (can be empty) with corresponding back references.
-//  - indexArray is an array of indexes in the backRefsArray
-//with the same positions as in the _nodeIndex.
-var indexArray = this._retainerIndex = new Int32Array(nodeCount);
-var edgesCountOffset = this._edgesCountOffset;
-var firstEdgeOffset = this._firstEdgeOffset;
-var edgeFieldsCount = this._edgeFieldsCount;
-var edgeToNodeOffset = this._edgeToNodeOffset;
-var backRefsCount = 0;
-// Count the number of retainers for each node
-for (var i = 0; i  nodeCount; ++i) {
-var nodeIndex = nodeIndexes[i];
-var edgesOffset = nodeIndex + firstEdgeOffset + edgeToNodeOffset;
-var edgesCount = nodes[nodeIndex + edgesCountOffset];
-backRefsCount += edgesCount;
-for (var j = 0; j  edgesCount; ++j) {
-  var targetNodeIndex = nodes[j * edgeFieldsCount + edgesOffset];
-  ++indexArray[nodePositions[targetNodeIndex]];
-}
-}
-var backRefsArray = this._retainers = new Int32Array(backRefsCount);
-// Put in the first slot of each backRefsArray slice the count of entries
-// that will be filled.
-var backRefsPosition = 0;
-for (i = 0; i  nodeCount; ++i) {
-backRefsCount = backRefsArray[backRefsPosition] = indexArray[i];
-indexArray[i] = backRefsPosition;
-backRefsPosition += backRefsCount;
-}
-var retainerIndex = this._retainerIndex;
-// Fill up the retainers array with indexes of edges.
-for (var i = 0; i  nodeCount; ++i) {
-var nodeIndex = nodeIndexes[i];
-var edgesOffset = nodeIndex + firstEdgeOffset;
-var edgesCount = nodes[nodeIndex + edgesCountOffset];
-for (var j = 0; j  edgesCount; ++j) {
-var edgeIndex = j * edgeFieldsCount + edgesOffset;
-var retNode = nodePositions[nodes[edgeIndex + edgeToNodeOffset]];
-var retIndex = indexArray[retNode];
-var backRefIndex = retIndex + (--backRefsArray[retIndex]);
-backRefsArray[backRefIndex] = edgeIndex;
-}
-}
+this._buildReverseIndex(
+_retainerIndex,
+_retainers,
+(function (node, callback)
+ {
+ for (var edgesIter = node.edges; edgesIter.hasNext(); edgesIter.next())
+ callback(this._nodePosition[edgesIter.edge.nodeIndex]);
+ }).bind(this),
+(function (node, indexCallback, dataCallback)
+ {
+ for (var edgesIter = node.edges; edgesIter.hasNext(); edgesIter.next()) {
+ var edge = edgesIter.edge;
+ var retIndex = this._getRetainerIndex(edge.nodeIndex);
+ 

[webkit-changes] [111703] trunk/Source/WebKit/efl

[commit-queue]

Title: [111703] trunk/Source/WebKit/efl








Revision 111703
Author commit-qu...@webkit.org
Date 2012-03-22 08:17:57 -0700 (Thu, 22 Mar 2012)


Log Message
[EFL] Change returned view mode in case of NULL of ewkView.
https://bugs.webkit.org/show_bug.cgi?id=81636

Patch by Krzysztof Czech k.cz...@samsung.com on 2012-03-22
Reviewed by Eric Seidel.

Function ewk_view_mode_get returns wrong view mode in case of NULL of ewkView.

* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_mode_get):

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_view.cpp
trunk/Source/WebKit/efl/ewk/ewk_view.h




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (111702 => 111703)

--- trunk/Source/WebKit/efl/ChangeLog	2012-03-22 15:15:52 UTC (rev 111702)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-03-22 15:17:57 UTC (rev 111703)
@@ -1,3 +1,16 @@
+2012-03-22  Krzysztof Czech  k.cz...@samsung.com
+
+[EFL] Change returned view mode in case of NULL of ewkView.
+https://bugs.webkit.org/show_bug.cgi?id=81636
+
+Reviewed by Eric Seidel.
+
+Function ewk_view_mode_get returns wrong view mode in case of NULL of ewkView.
+
+* ewk/ewk_view.cpp:
+(_Ewk_View_Private_Data):
+(ewk_view_mode_get):
+
 2012-03-22  Hyowon Kim  hw1008@samsung.com
 
 [EFL] Add PageClientEfl to WebCoreSupport.


Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (111702 => 111703)

--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2012-03-22 15:15:52 UTC (rev 111702)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2012-03-22 15:17:57 UTC (rev 111703)
@@ -3793,8 +3793,8 @@
 
 Ewk_View_Mode ewk_view_mode_get(const Evas_Object* ewkView)
 {
-EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, EWK_VIEW_MODE_WINDOWED);
-EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, EWK_VIEW_MODE_WINDOWED);
+EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, EWK_VIEW_MODE_INVALID);
+EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, EWK_VIEW_MODE_INVALID);
 
 return static_castEwk_View_Mode(priv-page-viewMode());
 }


Modified: trunk/Source/WebKit/efl/ewk/ewk_view.h (111702 => 111703)

--- trunk/Source/WebKit/efl/ewk/ewk_view.h	2012-03-22 15:15:52 UTC (rev 111702)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.h	2012-03-22 15:17:57 UTC (rev 111703)
@@ -2239,7 +2239,8 @@
  *
  * @param o view object to get the view mode
  *
- * @return enum value of @a Ewk_View_Mode that indicates current view mode
+ * @return enum value of @a Ewk_View_Mode that indicates current view mode on success or
+ * EWK_VIEW_MODE_INVALID otherwise
  *
  * @see ewk_view_mode_set()
  */






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111704] trunk/Source/WebCore

[loislo]

Title: [111704] trunk/Source/WebCore








Revision 111704
Author loi...@chromium.org
Date 2012-03-22 08:22:54 -0700 (Thu, 22 Mar 2012)


Log Message
Unreviewed: Web Inspector: fix syntax error in text.

* English.lproj/localizedStrings.js:
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker.prototype._messageReceived):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (111703 => 111704)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 15:17:57 UTC (rev 111703)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 15:22:54 UTC (rev 111704)
@@ -1,3 +1,11 @@
+2012-03-22  Ilya Tikhonovsky  loi...@chromium.org
+
+Unreviewed: Web Inspector: fix syntax error in text.
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/HeapSnapshotProxy.js:
+(WebInspector.HeapSnapshotWorker.prototype._messageReceived):
+
 2012-03-22  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r111688.


Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js

(Binary files differ)


Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js (111703 => 111704)

--- trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js	2012-03-22 15:17:57 UTC (rev 111703)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js	2012-03-22 15:22:54 UTC (rev 111704)
@@ -190,7 +190,7 @@
 var data = ""
 if (event.data.error) {
 if (event.data.errorMethodName)
-WebInspector.log(WebInspector.UIString(An error happend when a call for method '%s' was requested, event.data.errorMethodName));
+WebInspector.log(WebInspector.UIString(An error happened when a call for method '%s' was requested, event.data.errorMethodName));
 WebInspector.log(event.data.errorCallStack);
 delete this._callbacks[data.callId];
 return;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111705] trunk/Source/WebKit2

[jocelyn . turcotte]

Title: [111705] trunk/Source/WebKit2








Revision 111705
Author jocelyn.turco...@nokia.com
Date 2012-03-22 08:24:26 -0700 (Thu, 22 Mar 2012)


Log Message
[Qt] Don't resume the suspended page if the user is continuously flicking.
https://bugs.webkit.org/show_bug.cgi?id=81895

Reviewed by Kenneth Rohde Christiansen.

Create an additional suspend deferrer between TouchBegin and TouchEnd to
relay with the one kept while the flick animation is running.
This allows the page to be suspended when a pan gesture starts and stay
that way until the last flick animation ends.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::touchBegin):
(WebKit):
(WebKit::QtViewportInteractionEngine::touchEnd):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::doneWithTouchEvent):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h
trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (111704 => 111705)

--- trunk/Source/WebKit2/ChangeLog	2012-03-22 15:22:54 UTC (rev 111704)
+++ trunk/Source/WebKit2/ChangeLog	2012-03-22 15:24:26 UTC (rev 111705)
@@ -1,3 +1,25 @@
+2012-03-22  Jocelyn Turcotte  jocelyn.turco...@nokia.com
+
+[Qt] Don't resume the suspended page if the user is continuously flicking.
+https://bugs.webkit.org/show_bug.cgi?id=81895
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Create an additional suspend deferrer between TouchBegin and TouchEnd to
+relay with the one kept while the flick animation is running.
+This allows the page to be suspended when a pan gesture starts and stay
+that way until the last flick animation ends.
+
+* UIProcess/qt/QtViewportInteractionEngine.cpp:
+(WebKit::QtViewportInteractionEngine::touchBegin):
+(WebKit):
+(WebKit::QtViewportInteractionEngine::touchEnd):
+(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
+* UIProcess/qt/QtViewportInteractionEngine.h:
+(QtViewportInteractionEngine):
+* UIProcess/qt/QtWebPageEventHandler.cpp:
+(QtWebPageEventHandler::doneWithTouchEvent):
+
 2012-03-22  Carlos Garcia Campos  cgar...@bb-webkit-rel-64.local.igalia.com
 
 [GTK] Use the angle-bracket form to include wtf headers


Modified: trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp (111704 => 111705)

--- trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp	2012-03-22 15:22:54 UTC (rev 111704)
+++ trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp	2012-03-22 15:24:26 UTC (rev 111705)
@@ -298,6 +298,18 @@
 setItemRectVisible(endVisibleContentRect);
 }
 
+void QtViewportInteractionEngine::touchBegin()
+{
+// Prevents resuming the page between the user's flicks of the page while the animation is running.
+if (scrollAnimationActive())
+m_touchUpdateDeferrer = adoptPtr(new ViewportUpdateDeferrer(this, ViewportUpdateDeferrer::DeferUpdateAndSuspendContent));
+}
+
+void QtViewportInteractionEngine::touchEnd()
+{
+m_touchUpdateDeferrer.clear();
+}
+
 QRectF QtViewportInteractionEngine::computePosRangeForItemAtScale(qreal itemScale) const
 {
 const QSizeF contentItemSize = m_content-contentsSize() * itemScale;
@@ -517,8 +529,6 @@
 
 void QtViewportInteractionEngine::pinchGestureStarted(const QPointF pinchCenterInViewportCoordinates)
 {
-ASSERT(!m_suspendCount);
-
 if (!m_constraints.isUserScalable)
 return;
 


Modified: trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h (111704 => 111705)

--- trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h	2012-03-22 15:22:54 UTC (rev 111704)
+++ trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h	2012-03-22 15:24:26 UTC (rev 111705)
@@ -76,6 +76,8 @@
 
 void wheelEvent(QWheelEvent*);
 void pagePositionRequest(const QPoint pos);
+void touchBegin();
+void touchEnd();
 
 bool scrollAnimationActive() const;
 void cancelScrollAnimation();
@@ -148,6 +150,7 @@
 bool m_hasSuspendedContent;
 OwnPtrViewportUpdateDeferrer m_scaleUpdateDeferrer;
 OwnPtrViewportUpdateDeferrer m_scrollUpdateDeferrer;
+OwnPtrViewportUpdateDeferrer m_touchUpdateDeferrer;
 
 bool m_hadUserInteraction;
 


Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp (111704 => 111705)

--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp	2012-03-22 15:22:54 UTC (rev 111704)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp	2012-03-22 15:24:26 UTC (rev 111705)
@@ -449,6 +449,7 @@
 case QEvent::TouchBegin:
 ASSERT(!m_interactionEngine-panGestureActive());
 

[webkit-changes] [111706] trunk/Source/WebCore

[philn]

Title: [111706] trunk/Source/WebCore








Revision 111706
Author ph...@webkit.org
Date 2012-03-22 08:30:26 -0700 (Thu, 22 Mar 2012)


Log Message
[GTK] ASSERT bug in WebAudio (AudioFileReader)
https://bugs.webkit.org/show_bug.cgi?id=81777

Reviewed by Martin Robinson.

* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::decodeAudioForBusCreation): Don't steal
the GstBus floating reference.
(WebCore::AudioFileReader::createBus): Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (111705 => 111706)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 15:24:26 UTC (rev 111705)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 15:30:26 UTC (rev 111706)
@@ -1,3 +1,15 @@
+2012-03-22  Philippe Normand  pnorm...@igalia.com
+
+[GTK] ASSERT bug in WebAudio (AudioFileReader)
+https://bugs.webkit.org/show_bug.cgi?id=81777
+
+Reviewed by Martin Robinson.
+
+* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
+(WebCore::AudioFileReader::decodeAudioForBusCreation): Don't steal
+the GstBus floating reference.
+(WebCore::AudioFileReader::createBus): Ditto.
+
 2012-03-22  Ilya Tikhonovsky  loi...@chromium.org
 
 Unreviewed: Web Inspector: fix syntax error in text.


Modified: trunk/Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp (111705 => 111706)

--- trunk/Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp	2012-03-22 15:24:26 UTC (rev 111705)
+++ trunk/Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp	2012-03-22 15:30:26 UTC (rev 111706)
@@ -280,7 +280,7 @@
 // A deinterleave element is added once a src pad becomes available in decodebin.
 m_pipeline = gst_pipeline_new(0);
 
-GRefPtrGstBus bus = adoptGRef(gst_pipeline_get_bus(GST_PIPELINE(m_pipeline)));
+GRefPtrGstBus bus = gst_pipeline_get_bus(GST_PIPELINE(m_pipeline));
 gst_bus_add_signal_watch(bus.get());
 g_signal_connect(bus.get(), message, G_CALLBACK(messageCallback), this);
 
@@ -334,7 +334,7 @@
 g_main_loop_run(m_loop.get());
 g_main_context_pop_thread_default(context.get());
 
-GRefPtrGstBus bus = adoptGRef(gst_pipeline_get_bus(GST_PIPELINE(m_pipeline)));
+GRefPtrGstBus bus = gst_pipeline_get_bus(GST_PIPELINE(m_pipeline));
 g_signal_handlers_disconnect_by_func(bus.get(), reinterpret_castgpointer(messageCallback), this);
 
 g_signal_handlers_disconnect_by_func(m_decodebin.get(), reinterpret_castgpointer(onGStreamerDecodebinPadAddedCallback), this);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111707] trunk/Source/WebKit/gtk

[commit-queue]

Title: [111707] trunk/Source/WebKit/gtk








Revision 111707
Author commit-qu...@webkit.org
Date 2012-03-22 08:36:10 -0700 (Thu, 22 Mar 2012)


Log Message
[GTK] Add MediaStream feature to avoid MediaStream test failure
https://bugs.webkit.org/show_bug.cgi?id=81727

Patch by Mao Yujie yujie@intel.com on 2012-03-22
Reviewed by Martin Robinson.

* GNUmakefile.am:
* WebCoreSupport/UserMediaClientGtk.cpp: Added.
(WebKit):
(WebKit::UserMediaClientGtk::UserMediaClientGtk):
(WebKit::UserMediaClientGtk::~UserMediaClientGtk):
(WebKit::UserMediaClientGtk::pageDestroyed):
(WebKit::UserMediaClientGtk::requestUserMedia):
(WebKit::UserMediaClientGtk::cancelUserMediaRequest):
* WebCoreSupport/UserMediaClientGtk.h: Added.
(WebKit):
(UserMediaClientGtk):
* webkit/webkitwebview.cpp:
(webkit_web_view_init):

Modified Paths

trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/GNUmakefile.am
trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp


Added Paths

trunk/Source/WebKit/gtk/WebCoreSupport/UserMediaClientGtk.cpp
trunk/Source/WebKit/gtk/WebCoreSupport/UserMediaClientGtk.h




Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (111706 => 111707)

--- trunk/Source/WebKit/gtk/ChangeLog	2012-03-22 15:30:26 UTC (rev 111706)
+++ trunk/Source/WebKit/gtk/ChangeLog	2012-03-22 15:36:10 UTC (rev 111707)
@@ -1,3 +1,24 @@
+2012-03-22  Mao Yujie  yujie@intel.com
+
+[GTK] Add MediaStream feature to avoid MediaStream test failure
+https://bugs.webkit.org/show_bug.cgi?id=81727
+
+Reviewed by Martin Robinson.
+
+* GNUmakefile.am:
+* WebCoreSupport/UserMediaClientGtk.cpp: Added.
+(WebKit):
+(WebKit::UserMediaClientGtk::UserMediaClientGtk):
+(WebKit::UserMediaClientGtk::~UserMediaClientGtk):
+(WebKit::UserMediaClientGtk::pageDestroyed):
+(WebKit::UserMediaClientGtk::requestUserMedia):
+(WebKit::UserMediaClientGtk::cancelUserMediaRequest):
+* WebCoreSupport/UserMediaClientGtk.h: Added.
+(WebKit):
+(UserMediaClientGtk):
+* webkit/webkitwebview.cpp:
+(webkit_web_view_init):
+
 2012-03-22  Sergio Villar Senin  svil...@igalia.com
 
 [GTK] icon database requests not dispatched until new data arrives


Modified: trunk/Source/WebKit/gtk/GNUmakefile.am (111706 => 111707)

--- trunk/Source/WebKit/gtk/GNUmakefile.am	2012-03-22 15:30:26 UTC (rev 111706)
+++ trunk/Source/WebKit/gtk/GNUmakefile.am	2012-03-22 15:36:10 UTC (rev 111707)
@@ -211,6 +211,8 @@
 	Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp \
 	Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h \
 	Source/WebKit/gtk/WebCoreSupport/PasteboardHelperGtk.h \
+	Source/WebKit/gtk/WebCoreSupport/UserMediaClientGtk.cpp \
+	Source/WebKit/gtk/WebCoreSupport/UserMediaClientGtk.h \
 	Source/WebKit/gtk/webkit/webkitapplicationcache.cpp \
 	Source/WebKit/gtk/webkit/webkitdownload.cpp \
 	Source/WebKit/gtk/webkit/webkitdownloadprivate.h \


Added: trunk/Source/WebKit/gtk/WebCoreSupport/UserMediaClientGtk.cpp (0 => 111707)

--- trunk/Source/WebKit/gtk/WebCoreSupport/UserMediaClientGtk.cpp	(rev 0)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/UserMediaClientGtk.cpp	2012-03-22 15:36:10 UTC (rev 111707)
@@ -0,0 +1,58 @@
+/*
+ * Copyright (C) 2012 Intel Inc. All rights reserved.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Library General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Library General Public License for more details.
+ *
+ * You should have received a copy of the GNU Library General Public License
+ * along with this library; see the file COPYING.LIB.  If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ *
+ */
+
+#include config.h
+#include UserMediaClientGtk.h
+
+#if ENABLE(MEDIA_STREAM)
+#include MediaStreamSource.h
+#include NotImplemented.h
+#include UserMediaRequest.h
+
+using namespace WebCore;
+
+namespace WebKit {
+
+UserMediaClientGtk::UserMediaClientGtk()
+{
+}
+
+UserMediaClientGtk::~UserMediaClientGtk()
+{
+}
+
+void UserMediaClientGtk::pageDestroyed()
+{
+notImplemented();
+}
+
+void UserMediaClientGtk::requestUserMedia(WTF::PassRefPtrUserMediaRequest prpRequest, const MediaStreamSourceVector audioSource, const MediaStreamSourceVector videoSource)
+{
+notImplemented();
+}
+
+void UserMediaClientGtk::cancelUserMediaRequest(UserMediaRequest* request)
+{
+notImplemented();
+}
+
+} // namespace WebKit;
+
+#endif // MEDIA_STREAM


Added: trunk/Source/WebKit/gtk/WebCoreSupport/UserMediaClientGtk.h (0 => 111707)

--- 

[webkit-changes] [111708] trunk/Source

[enne]

Title: [111708] trunk/Source








Revision 111708
Author e...@google.com
Date 2012-03-22 08:37:30 -0700 (Thu, 22 Mar 2012)


Log Message
[chromium] Fix scrollbar layers holding onto invalid textures after lost context
https://bugs.webkit.org/show_bug.cgi?id=81841

Reviewed by James Robinson.

Source/WebCore:

Unit test: CCLayerTreeHostImplTest.scrollbarLayerLostContext

* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::willDraw):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (111707 => 111708)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 15:36:10 UTC (rev 111707)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 15:37:30 UTC (rev 111708)
@@ -1,3 +1,15 @@
+2012-03-22  Adrienne Walker  e...@google.com
+
+[chromium] Fix scrollbar layers holding onto invalid textures after lost context
+https://bugs.webkit.org/show_bug.cgi?id=81841
+
+Reviewed by James Robinson.
+
+Unit test: CCLayerTreeHostImplTest.scrollbarLayerLostContext
+
+* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
+(WebCore::CCScrollbarLayerImpl::willDraw):
+
 2012-03-22  Philippe Normand  pnorm...@igalia.com
 
 [GTK] ASSERT bug in WebAudio (AudioFileReader)


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp (111707 => 111708)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp	2012-03-22 15:36:10 UTC (rev 111707)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp	2012-03-22 15:37:30 UTC (rev 111708)
@@ -58,6 +58,10 @@
 if (!m_texture)
 m_texture = ManagedTexture::create(layerRenderer-renderSurfaceTextureManager());
 
+// The context could have been lost since the last frame and the old texture
+// manager may no longer be valid.
+m_texture-setTextureManager(layerRenderer-renderSurfaceTextureManager());
+
 IntSize textureSize = contentBounds();
 if (!m_texture-reserve(textureSize, GraphicsContext3D::RGBA))
 return;


Modified: trunk/Source/WebKit/chromium/ChangeLog (111707 => 111708)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-03-22 15:36:10 UTC (rev 111707)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-03-22 15:37:30 UTC (rev 111708)
@@ -1,3 +1,14 @@
+2012-03-22  Adrienne Walker  e...@google.com
+
+[chromium] Fix scrollbar layers holding onto invalid textures after lost context
+https://bugs.webkit.org/show_bug.cgi?id=81841
+
+Reviewed by James Robinson.
+
+* tests/CCLayerTreeHostImplTest.cpp:
+(WebKitTests::TEST_F):
+(WebKitTests):
+
 2012-03-22  Dana Jansens  dan...@chromium.org
 
 [chromium] Early out in a new prepareToDraw() step if checkerboarding an accelerated animation in order to skip the frame


Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp (111707 => 111708)

--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp	2012-03-22 15:36:10 UTC (rev 111707)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp	2012-03-22 15:37:30 UTC (rev 111708)
@@ -25,12 +25,14 @@
 #include config.h
 
 #include cc/CCLayerTreeHostImpl.h
+#include cc/CCQuadCuller.h
 
 #include CCAnimationTestCommon.h
 #include FakeWebGraphicsContext3D.h
 #include GraphicsContext3DPrivate.h
 #include LayerRendererChromium.h
 #include cc/CCLayerImpl.h
+#include cc/CCScrollbarLayerImpl.h
 #include cc/CCSingleThreadProxy.h
 #include cc/CCTileDrawQuad.h
 #include gtest/gtest.h
@@ -1084,4 +1086,27 @@
 m_hostImpl-finishAllRendering();
 }
 
+TEST_F(CCLayerTreeHostImplTest, scrollbarLayerLostContext)
+{
+m_hostImpl-initializeLayerRenderer(createContext());
+m_hostImpl-setViewportSize(IntSize(10, 10));
+
+m_hostImpl-setRootLayer(CCScrollbarLayerImpl::create(0));
+CCScrollbarLayerImpl* scrollbar = static_castCCScrollbarLayerImpl*(m_hostImpl-rootLayer());
+scrollbar-setBounds(IntSize(1, 1));
+scrollbar-setContentBounds(IntSize(1, 1));
+scrollbar-setDrawsContent(true);
+
+for (int i = 0; i  2; ++i) {
+CCLayerTreeHostImpl::FrameData frame;
+EXPECT_TRUE(m_hostImpl-prepareToDraw(frame));
+ASSERT(frame.renderPasses.size() == 1);
+CCRenderPass* renderPass = frame.renderPasses[0].get();
+// Scrollbar layer should always generate quads, even after lost context
+EXPECT_GT(renderPass-quadList().size(), 0u);
+
+m_hostImpl-initializeLayerRenderer(createContext());
+}
+}
+
 } // namespace






___
webkit-changes mailing list
webkit-changes@lists.webkit.org

[webkit-changes] [111718] trunk/LayoutTests

[eae]

Title: [111718] trunk/LayoutTests








Revision 111718
Author e...@chromium.org
Date 2012-03-22 10:06:44 -0700 (Thu, 22 Mar 2012)


Log Message
Unreviewed test_expectations update for chromium. Marking a couple of tests as SLOW on SNOWLEOPARD DEBUG.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (111717 => 111718)

--- trunk/LayoutTests/ChangeLog	2012-03-22 17:01:48 UTC (rev 111717)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 17:06:44 UTC (rev 111718)
@@ -1,3 +1,9 @@
+2012-03-22  Emil A Eklund  e...@chromium.org
+
+Unreviewed test_expectations update for chromium. Marking a couple of tests as SLOW on SNOWLEOPARD DEBUG.
+
+* platform/chromium/test_expectations.txt:
+
 2012-03-22  Sudarsana Nagineni  sudarsana.nagin...@linux.intel.com
 
 [EFL] Map BackSpace key code to Unicode value


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (111717 => 111718)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-22 17:01:48 UTC (rev 111717)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-22 17:06:44 UTC (rev 111718)
@@ -40,6 +40,10 @@
 BUGCR24182 SLOW DEBUG WIN MAC : fast/js/dfg-int8array.html = PASS
 BUGCR24182 SLOW DEBUG WIN MAC : fast/js/dfg-uint8clampedarray.html = PASS
 BUGCR24182 SLOW DEBUG WIN MAC : fast/js/dfg-int16array.html = PASS
+BUGCR24182 SLOW SNOWLEOPARD DEBUG : http/tests/security/xss-DENIED-iframe-src-alias.html = PASS
+BUGCR24182 SLOW SNOWLEOPARD DEBUG : css3/flexbox/multiline-pack.html = PASS
+BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/js/dfg-float32array.html = PASS
+BUGCR24182 SLOW SNOWLEOPARD DEBUG : http/tests/misc/dns-prefetch-control.html = PASS
 // BUGCR24182 SLOW DEBUG : svg/filters/big-sized-filter.svg = PASS
 // See BUGCR104797
 
@@ -4242,3 +4246,4 @@
 BUGWK81816 SNOWLEOPARD DEBUG : fast/dom/DOMImplementation/createDocumentType-err.html = PASS TIMEOUT
 BUGWK81857 SNOWLEOPARD DEBUG : fast/frames/valid.html = PASS TIMEOUT
 BUGWK81857 SNOWLEOPARD DEBUG : fast/frames/calculate-order.html = PASS TIMEOUT
+BUGWK81931 SNOWLEOPARD DEBUG : fast/images/destroyed-image-load-event.html = PASS TIMEOUT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111721] trunk/Source/WebKit2

[ahf]

Title: [111721] trunk/Source/WebKit2








Revision 111721
Author a...@0x90.dk
Date 2012-03-22 10:22:38 -0700 (Thu, 22 Mar 2012)


Log Message
[Qt][WK2] Pass Origin information to the DatabaseQuotaDialogContextObject https://bugs.webkit.org/show_bug.cgi?id=81910

Reviewed by Simon Hausmann.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::exceededDatabaseQuota):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/qt/QtDialogRunner.cpp:
(DatabaseQuotaDialogContextObject):
(DatabaseQuotaDialogContextObject::DatabaseQuotaDialogContextObject):
(DatabaseQuotaDialogContextObject::securityOrigin):
(QtDialogRunner::initForDatabaseQuotaDialog):
* UIProcess/qt/QtDialogRunner.h:
(QtDialogRunner):
* UIProcess/qt/QtWebPageUIClient.cpp:
(QtWebPageUIClient::exceededDatabaseQuota):
* UIProcess/qt/QtWebPageUIClient.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h
trunk/Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp
trunk/Source/WebKit2/UIProcess/qt/QtDialogRunner.h
trunk/Source/WebKit2/UIProcess/qt/QtWebPageUIClient.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageUIClient.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (111720 => 111721)

--- trunk/Source/WebKit2/ChangeLog	2012-03-22 17:16:30 UTC (rev 111720)
+++ trunk/Source/WebKit2/ChangeLog	2012-03-22 17:22:38 UTC (rev 111721)
@@ -1,3 +1,25 @@
+2012-03-22  Alexander Færøy  alexander.fae...@nokia.com
+
+[Qt][WK2] Pass Origin information to the DatabaseQuotaDialogContextObject
+https://bugs.webkit.org/show_bug.cgi?id=81910
+
+Reviewed by Simon Hausmann.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewPrivate::exceededDatabaseQuota):
+* UIProcess/API/qt/qquickwebview_p_p.h:
+(QQuickWebViewPrivate):
+* UIProcess/qt/QtDialogRunner.cpp:
+(DatabaseQuotaDialogContextObject):
+(DatabaseQuotaDialogContextObject::DatabaseQuotaDialogContextObject):
+(DatabaseQuotaDialogContextObject::securityOrigin):
+(QtDialogRunner::initForDatabaseQuotaDialog):
+* UIProcess/qt/QtDialogRunner.h:
+(QtDialogRunner):
+* UIProcess/qt/QtWebPageUIClient.cpp:
+(QtWebPageUIClient::exceededDatabaseQuota):
+* UIProcess/qt/QtWebPageUIClient.h:
+
 2012-03-22  Jocelyn Turcotte  jocelyn.turco...@nokia.com
 
 [Qt] Don't resume the suspended page if the user is continuously flicking.


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (111720 => 111721)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-03-22 17:16:30 UTC (rev 111720)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-03-22 17:22:38 UTC (rev 111721)
@@ -399,14 +399,14 @@
 
 }
 
-quint64 QQuickWebViewPrivate::exceededDatabaseQuota(const QString databaseName, const QString displayName, quint64 currentQuota, quint64 currentOriginUsage, quint64 currentDatabaseUsage, quint64 expectedUsage)
+quint64 QQuickWebViewPrivate::exceededDatabaseQuota(const QString databaseName, const QString displayName, WKSecurityOriginRef securityOrigin, quint64 currentQuota, quint64 currentOriginUsage, quint64 currentDatabaseUsage, quint64 expectedUsage)
 {
 if (!databaseQuotaDialog)
 return 0;
 
 Q_Q(QQuickWebView);
 QtDialogRunner dialogRunner;
-if (!dialogRunner.initForDatabaseQuotaDialog(databaseQuotaDialog, q, databaseName, displayName, currentQuota, currentOriginUsage, currentDatabaseUsage, expectedUsage))
+if (!dialogRunner.initForDatabaseQuotaDialog(databaseQuotaDialog, q, databaseName, displayName, securityOrigin, currentQuota, currentOriginUsage, currentDatabaseUsage, expectedUsage))
 return 0;
 
 execDialogRunner(dialogRunner);


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h (111720 => 111721)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h	2012-03-22 17:16:30 UTC (rev 111720)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h	2012-03-22 17:22:38 UTC (rev 111721)
@@ -96,7 +96,7 @@
 void _q_onIconChangedForPageURL(const QUrl pageURL, const QUrl iconURLString);
 
 void chooseFiles(WKOpenPanelResultListenerRef, const QStringList selectedFileNames, QtWebPageUIClient::FileChooserType);
-quint64 exceededDatabaseQuota(const QString databaseName, const QString displayName, quint64 currentQuota, quint64 currentOriginUsage, quint64 currentDatabaseUsage, quint64 expectedUsage);
+quint64 exceededDatabaseQuota(const QString databaseName, const QString displayName, WKSecurityOriginRef securityOrigin, quint64 currentQuota, quint64 currentOriginUsage, quint64 currentDatabaseUsage, quint64 expectedUsage);
 void runJavaScriptAlert(const QString);
 bool runJavaScriptConfirm(const QString);
 QString runJavaScriptPrompt(const QString, const QString defaultValue, bool ok);


Modified: 

[webkit-changes] [111724] trunk/LayoutTests

[eae]

Title: [111724] trunk/LayoutTests








Revision 111724
Author e...@chromium.org
Date 2012-03-22 10:25:36 -0700 (Thu, 22 Mar 2012)


Log Message
Unreviewed test_expectations update for chromium.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (111723 => 111724)

--- trunk/LayoutTests/ChangeLog	2012-03-22 17:24:22 UTC (rev 111723)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 17:25:36 UTC (rev 111724)
@@ -1,3 +1,9 @@
+2012-03-22  Emil A Eklund  e...@chromium.org
+
+Unreviewed test_expectations update for chromium.
+
+* platform/chromium/test_expectations.txt:
+
 2012-03-22  Dan Bernstein  m...@apple.com
 
 Added fast/events/remove-target-with-shadow-in-drag.html to the Mac WebKit2 skip list, since


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (111723 => 111724)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-22 17:24:22 UTC (rev 111723)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-22 17:25:36 UTC (rev 111724)
@@ -44,6 +44,9 @@
 BUGCR24182 SLOW SNOWLEOPARD DEBUG : css3/flexbox/multiline-pack.html = PASS
 BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/js/dfg-float32array.html = PASS
 BUGCR24182 SLOW SNOWLEOPARD DEBUG : http/tests/misc/dns-prefetch-control.html = PASS
+BUGCR24182 SLOW SNOWLEOPARD DEBUG : svg/dom/baseVal-animVal-crash.html = PASS
+BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/dom/shadow/tree-scope-crash.html = PASS
+BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/loader/_javascript_-url-iframe-crash.html = PASS
 // BUGCR24182 SLOW DEBUG : svg/filters/big-sized-filter.svg = PASS
 // See BUGCR104797
 
@@ -4240,6 +4243,7 @@
 BUGWK81813 SNOWLEOPARD DEBUG : fast/forms/input-type-change3.html = PASS TIMEOUT
 BUGWK81813 SNOWLEOPARD DEBUG : fast/forms/textarea-align.html = PASS TIMEOUT
 BUGWK81813 SNOWLEOPARD DEBUG : fast/forms/select-empty-option-height.html = PASS TIMEOUT
+BUGWK81813 SNOWLEOPARD DEBUG : fast/forms/input-type-change.html = PASS TIMEOUT
 BUGWK81813 SNOWLEOPARD DEBUG : fast/forms/interactive-validation-remove-node-in-handler.html = PASS TIMEOUT
 BUGWK81814 SNOWLEOPARD DEBUG : fast/parser/fragment-parser.html = PASS TIMEOUT
 BUGWK81815 SNOWLEOPARD DEBUG : fast/writing-mode/japanese-ruby-vertical-lr.html = PASS TIMEOUT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111725] trunk/Source/WebCore

[commit-queue]

Title: [111725] trunk/Source/WebCore








Revision 111725
Author commit-qu...@webkit.org
Date 2012-03-22 10:28:06 -0700 (Thu, 22 Mar 2012)


Log Message
ReverbConvolver::latencyFrames() should return 0.
https://bugs.webkit.org/show_bug.cgi?id=81806

Patch by Xingnan Wang xingnan.w...@intel.com on 2012-03-22
Reviewed by Chris Rogers.

* platform/audio/ReverbConvolver.cpp:
(WebCore::ReverbConvolver::latencyFrames):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/ReverbConvolver.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (111724 => 111725)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 17:25:36 UTC (rev 111724)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 17:28:06 UTC (rev 111725)
@@ -1,3 +1,13 @@
+2012-03-22  Xingnan Wang  xingnan.w...@intel.com
+
+ReverbConvolver::latencyFrames() should return 0.
+https://bugs.webkit.org/show_bug.cgi?id=81806
+
+Reviewed by Chris Rogers.
+
+* platform/audio/ReverbConvolver.cpp:
+(WebCore::ReverbConvolver::latencyFrames):
+
 2012-03-22  Tony Chang  t...@chromium.org
 
 refactor flexbox in preparation for flex-line-pack


Modified: trunk/Source/WebCore/platform/audio/ReverbConvolver.cpp (111724 => 111725)

--- trunk/Source/WebCore/platform/audio/ReverbConvolver.cpp	2012-03-22 17:25:36 UTC (rev 111724)
+++ trunk/Source/WebCore/platform/audio/ReverbConvolver.cpp	2012-03-22 17:28:06 UTC (rev 111725)
@@ -231,9 +231,7 @@
 
 size_t ReverbConvolver::latencyFrames() const
 {
-// FIXME: ConvolverNode should not incur processing latency
-// https://bugs.webkit.org/show_bug.cgi?id=75564
-return m_minFFTSize / 2;
+return 0;
 }
 
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111726] trunk/Source/WebKit/blackberry

[mifenton]

Title: [111726] trunk/Source/WebKit/blackberry








Revision 111726
Author mifen...@rim.com
Date 2012-03-22 10:38:36 -0700 (Thu, 22 Mar 2012)


Log Message
[BlackBerry] DOMSupport isPositionInNode should have early returns for null nodes
https://bugs.webkit.org/show_bug.cgi?id=81929

Reviewed by Rob Buis.

Add early returns in isPositionInNode when either
node or the position node is null.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isPositionInNode):

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (111725 => 111726)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-03-22 17:28:06 UTC (rev 111725)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-03-22 17:38:36 UTC (rev 111726)
@@ -1,3 +1,16 @@
+2012-03-22  Mike Fenton  mifen...@rim.com
+
+[BlackBerry] DOMSupport isPositionInNode should have early returns for null nodes
+https://bugs.webkit.org/show_bug.cgi?id=81929
+
+Reviewed by Rob Buis.
+
+Add early returns in isPositionInNode when either
+node or the position node is null.
+
+* WebKitSupport/DOMSupport.cpp:
+(BlackBerry::WebKit::DOMSupport::isPositionInNode):
+
 2012-03-21  Jonathan Dong  jonathan.d...@torchmobile.com.cn
 
 [BlackBerry] Credential save and autofill implemetation


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp (111725 => 111726)

--- trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp	2012-03-22 17:28:06 UTC (rev 111725)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp	2012-03-22 17:38:36 UTC (rev 111726)
@@ -293,8 +293,14 @@
 
 bool isPositionInNode(Node* node, const Position position)
 {
+if (!node)
+return false;
+
 int offset = 0;
 Node* domNodeAtPos = DOMContainerNodeForPosition(position);
+if (!domNodeAtPos)
+return false;
+
 if (domNodeAtPos == position.containerNode())
 offset = position.computeOffsetInContainerNode();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111727] trunk/Source/WebCore

[eae]

Title: [111727] trunk/Source/WebCore








Revision 111727
Author e...@chromium.org
Date 2012-03-22 10:41:16 -0700 (Thu, 22 Mar 2012)


Log Message
Unreviewed, touching file to force bots to pick up CSS_SHADERS flag change. 

* css/CSSStyleSelector.h:
(CSSStyleSelector):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (111726 => 111727)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 17:38:36 UTC (rev 111726)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 17:41:16 UTC (rev 111727)
@@ -1,3 +1,10 @@
+2012-03-22  Emil A Eklund  e...@chromium.org
+
+Unreviewed, touching file to force bots to pick up CSS_SHADERS flag change. 
+
+* css/CSSStyleSelector.h:
+(CSSStyleSelector):
+
 2012-03-22  Xingnan Wang  xingnan.w...@intel.com
 
 ReverbConvolver::latencyFrames() should return 0.


Modified: trunk/Source/WebCore/css/CSSStyleSelector.h (111726 => 111727)

--- trunk/Source/WebCore/css/CSSStyleSelector.h	2012-03-22 17:38:36 UTC (rev 111726)
+++ trunk/Source/WebCore/css/CSSStyleSelector.h	2012-03-22 17:41:16 UTC (rev 111727)
@@ -404,6 +404,7 @@
 bool canShareStyleWithControl(StyledElement*) const;
 
 void applyProperty(int id, CSSValue*);
+
 #if ENABLE(SVG)
 void applySVGProperty(int id, CSSValue*);
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111728] trunk/LayoutTests

[commit-queue]

Title: [111728] trunk/LayoutTests








Revision 111728
Author commit-qu...@webkit.org
Date 2012-03-22 10:41:53 -0700 (Thu, 22 Mar 2012)


Log Message
Use stereo AudioBuffer instead of RealtimeAnalyserNode in the layout test of stereo2mono-down-mixing
https://bugs.webkit.org/show_bug.cgi?id=81881

Patch by Xingnan Wang xingnan.w...@intel.com on 2012-03-22
Reviewed by Chris Rogers.

* webaudio/stereo2mono-down-mixing.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webaudio/stereo2mono-down-mixing.html




Diff

Modified: trunk/LayoutTests/ChangeLog (111727 => 111728)

--- trunk/LayoutTests/ChangeLog	2012-03-22 17:41:16 UTC (rev 111727)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 17:41:53 UTC (rev 111728)
@@ -1,3 +1,12 @@
+2012-03-22  Xingnan Wang  xingnan.w...@intel.com
+
+Use stereo AudioBuffer instead of RealtimeAnalyserNode in the layout test of stereo2mono-down-mixing
+https://bugs.webkit.org/show_bug.cgi?id=81881
+
+Reviewed by Chris Rogers.
+
+* webaudio/stereo2mono-down-mixing.html:
+
 2012-03-22  Emil A Eklund  e...@chromium.org
 
 Unreviewed test_expectations update for chromium.


Modified: trunk/LayoutTests/webaudio/stereo2mono-down-mixing.html (111727 => 111728)

--- trunk/LayoutTests/webaudio/stereo2mono-down-mixing.html	2012-03-22 17:41:16 UTC (rev 111727)
+++ trunk/LayoutTests/webaudio/stereo2mono-down-mixing.html	2012-03-22 17:41:53 UTC (rev 111728)
@@ -15,21 +15,21 @@
 
 var sampleRate = 44100.0;
 var renderLengthSeconds = 0.1;
-var fftSize = 32;
 
 var context;
 var toneBuffer;
 var bufferSource;
-var analyser;
 
 function createDataBuffer(context, lengthInSeconds) {
-var audioBuffer = context.createBuffer(1, lengthInSeconds * sampleRate, sampleRate);
+var audioBuffer = context.createBuffer(2, lengthInSeconds * sampleRate, sampleRate);
 
 var n = audioBuffer.length;
-var data = ""
+var data0 = audioBuffer.getChannelData(0);
+var data1 = audioBuffer.getChannelData(1);
 
 for (var i = 0; i  n; ++i) {
-data[i] = 1.0;
+data0[i] = 1.0;
+data1[i] = 1.0;
 }
 
 return audioBuffer;
@@ -49,21 +49,16 @@
 
 window.jsTestIsAsync = true;
 
-// Create offline audio context.
+// Create offline audio context, the destination is mono.
 context = new webkitAudioContext(1, sampleRate * renderLengthSeconds, sampleRate);
-// Explicitly create a mono AudioContext so that the destination is mono.
+// Create a stereo AudioBuffer.
 toneBuffer = createDataBuffer(context, renderLengthSeconds);
 
 bufferSource = context.createBufferSource();
 bufferSource.buffer = toneBuffer;
 
-// We create an analyser here, because it has a hard-coded stereo output.
-analyser = context.createAnalyser();
-analyser.fftSize = fftSize;
+bufferSource.connect(context.destination);
 
-bufferSource.connect(analyser);
-analyser.connect(context.destination);
-
 bufferSource.noteOn(0);
 
 context._oncomplete_ = testFinished;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111729] trunk/LayoutTests

[mitz]

Title: [111729] trunk/LayoutTests








Revision 111729
Author m...@apple.com
Date 2012-03-22 10:46:26 -0700 (Thu, 22 Mar 2012)


Log Message
Added Mac expected results for this test from r110938, and removed the render tree dump
results from the cross-platform location, because this test contains text, so the render
varies by platform.

* fast/events/resize-events-expected.txt: Removed.
* platform/mac/fast/events/resize-events-expected.png: Added.
* platform/mac/fast/events/resize-events-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/mac/fast/events/resize-events-expected.png
trunk/LayoutTests/platform/mac/fast/events/resize-events-expected.txt


Removed Paths

trunk/LayoutTests/fast/events/resize-events-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (111728 => 111729)

--- trunk/LayoutTests/ChangeLog	2012-03-22 17:41:53 UTC (rev 111728)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 17:46:26 UTC (rev 111729)
@@ -1,3 +1,13 @@
+2012-03-22  Dan Bernstein  m...@apple.com
+
+Added Mac expected results for this test from r110938, and removed the render tree dump
+results from the cross-platform location, because this test contains text, so the render
+varies by platform.
+
+* fast/events/resize-events-expected.txt: Removed.
+* platform/mac/fast/events/resize-events-expected.png: Added.
+* platform/mac/fast/events/resize-events-expected.txt: Added.
+
 2012-03-22  Xingnan Wang  xingnan.w...@intel.com
 
 Use stereo AudioBuffer instead of RealtimeAnalyserNode in the layout test of stereo2mono-down-mixing


Deleted: trunk/LayoutTests/fast/events/resize-events-expected.txt (111728 => 111729)

--- trunk/LayoutTests/fast/events/resize-events-expected.txt	2012-03-22 17:41:53 UTC (rev 111728)
+++ trunk/LayoutTests/fast/events/resize-events-expected.txt	2012-03-22 17:46:26 UTC (rev 111729)
@@ -1,20 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x582
-  RenderBlock {DIV} at (0,0) size 784x79
-RenderBlock (anonymous) at (0,0) size 784x42
-  RenderText {#text} at (0,0) size 772x42
-text run at (0,0) width 652: Test how many resize events are emitted during page load and dynamic content generation. 
-text run at (652,0) width 120: Do not resize the
-text run at (0,21) width 192: page. It invalidates the test.
-RenderBlock {P} at (0,58) size 784x21
-  RenderText {#text} at (10,0) size 206x21
-text run at (10,0) width 206: Resize events (should be 0): 
-  RenderInline {SPAN} at (0,0) size 9x21
-RenderText {#text} at (216,0) size 9x21
-  text run at (216,0) width 9: 0
-  RenderText {#text} at (0,0) size 0x0
-  RenderBlock {DIV} at (0,95) size 784x402
-RenderBlock {DIV} at (10,0) size 764x402 [border: (1px solid #00)]


Added: trunk/LayoutTests/platform/mac/fast/events/resize-events-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/mac/fast/events/resize-events-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/mac/fast/events/resize-events-expected.txt (0 => 111729)

--- trunk/LayoutTests/platform/mac/fast/events/resize-events-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/fast/events/resize-events-expected.txt	2012-03-22 17:46:26 UTC (rev 111729)
@@ -0,0 +1,33 @@
+layer at (0,0) size 785x4248
+  RenderView at (0,0) size 785x600
+layer at (0,0) size 785x4248
+  RenderBlock {HTML} at (0,0) size 785x4248
+RenderBody {BODY} at (8,8) size 769x4230
+  RenderBlock {DIV} at (0,0) size 769x104
+RenderBlock (anonymous) at (0,0) size 769x36
+  RenderText {#text} at (0,0) size 736x36
+text run at (0,0) width 578: Test how many resize events are emitted during page load and dynamic content generation. 
+text run at (578,0) width 158: Do not resize the page. It
+text run at (0,18) width 119: invalidates the test.
+RenderBlock {P} at (0,52) size 769x52
+  RenderBlock (anonymous) at (0,0) size 769x18
+RenderText {#text} at (10,0) size 181x18
+  text run at (10,0) width 181: Resize events (should be 0): 
+RenderInline {SPAN} at (0,0) size 8x18
+  RenderText {#text} at (191,0) size 8x18
+text run at (191,0) width 8: 0
+RenderText {#text} at (0,0) size 0x0
+  RenderBlock {P} at (0,34) size 769x18 [color=#008000]
+RenderText {#text} at (10,0) size 39x18
+  text run at (10,0) width 39: PASS
+  RenderBlock {DIV} at (0,120) size 769x4110
+RenderBlock {DIV} at (10,0) size 749x402 [border: (1px solid 

[webkit-changes] [111734] trunk/Source/WebKit/chromium

[commit-queue]

Title: [111734] trunk/Source/WebKit/chromium








Revision 111734
Author commit-qu...@webkit.org
Date 2012-03-22 11:23:16 -0700 (Thu, 22 Mar 2012)


Log Message
[chromium] Plug-in failing to load shouldn't say Missing Plug-in
https://bugs.webkit.org/show_bug.cgi?id=81907

Patch by Bernhard Bauer bau...@google.com on 2012-03-22
Reviewed by Adam Barth.

Adding a MissingPluginText value to WebLocalizedString which can be used to override the Missing Plug-in message.

* public/platform/WebLocalizedString.h:
* src/LocalizedStrings.cpp:
(WebCore::missingPluginText):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebLocalizedString.h
trunk/Source/WebKit/chromium/src/LocalizedStrings.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (111733 => 111734)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-03-22 18:10:55 UTC (rev 111733)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-03-22 18:23:16 UTC (rev 111734)
@@ -1,3 +1,16 @@
+2012-03-22  Bernhard Bauer  bau...@google.com
+
+[chromium] Plug-in failing to load shouldn't say Missing Plug-in
+https://bugs.webkit.org/show_bug.cgi?id=81907
+
+Reviewed by Adam Barth.
+
+Adding a MissingPluginText value to WebLocalizedString which can be used to override the Missing Plug-in message.
+
+* public/platform/WebLocalizedString.h:
+* src/LocalizedStrings.cpp:
+(WebCore::missingPluginText):
+
 2012-03-22  Adrienne Walker  e...@google.com
 
 [chromium] Fix scrollbar layers holding onto invalid textures after lost context


Modified: trunk/Source/WebKit/chromium/public/platform/WebLocalizedString.h (111733 => 111734)

--- trunk/Source/WebKit/chromium/public/platform/WebLocalizedString.h	2012-03-22 18:10:55 UTC (rev 111733)
+++ trunk/Source/WebKit/chromium/public/platform/WebLocalizedString.h	2012-03-22 18:23:16 UTC (rev 111734)
@@ -35,46 +35,47 @@
 
 struct WebLocalizedString {
 enum Name {
+AXButtonActionVerb,
+AXCheckedCheckBoxActionVerb,
+AXHeadingText,
+AXImageMapText,
+AXLinkActionVerb,
+AXLinkText,
+AXListMarkerText,
+AXRadioButtonActionVerb,
+AXTextFieldActionVerb,
+AXUncheckedCheckBoxActionVerb,
+AXWebAreaText,
 DetailsLabel,
-SubmitButtonDefaultLabel,
-InputElementAltText,
-ResetButtonDefaultLabel,
 FileButtonChooseFileLabel,
 FileButtonChooseMultipleFilesLabel,
 FileButtonNoFileSelectedLabel,
+InputElementAltText,
+KeygenMenuHighGradeKeySize,
+KeygenMenuMediumGradeKeySize,
+MissingPluginText,
 MultipleFileUploadText,
+ResetButtonDefaultLabel,
 SearchableIndexIntroduction,
+SearchMenuClearRecentSearchesText,
 SearchMenuNoRecentSearchesText,
 SearchMenuRecentSearchesText,
-SearchMenuClearRecentSearchesText,
-AXWebAreaText,
-AXLinkText,
-AXListMarkerText,
-AXImageMapText,
-AXHeadingText,
-AXButtonActionVerb,
-AXRadioButtonActionVerb,
-AXTextFieldActionVerb,
-AXCheckedCheckBoxActionVerb,
-AXUncheckedCheckBoxActionVerb,
-AXLinkActionVerb,
-KeygenMenuHighGradeKeySize,
-KeygenMenuMediumGradeKeySize,
+SubmitButtonDefaultLabel,
+ValidationPatternMismatch,
+ValidationRangeOverflow,
+ValidationRangeUnderflow,
+ValidationStepMismatch,
+ValidationTooLong,
+ValidationTypeMismatch,
+ValidationTypeMismatchForEmail,
+ValidationTypeMismatchForMultipleEmail,
+ValidationTypeMismatchForURL,
 ValidationValueMissing,
 ValidationValueMissingForCheckbox,
 ValidationValueMissingForFile,
 ValidationValueMissingForMultipleFile,
 ValidationValueMissingForRadio,
 ValidationValueMissingForSelect,
-ValidationTypeMismatch,
-ValidationTypeMismatchForEmail,
-ValidationTypeMismatchForMultipleEmail,
-ValidationTypeMismatchForURL,
-ValidationPatternMismatch,
-ValidationTooLong,
-ValidationRangeUnderflow,
-ValidationRangeOverflow,
-ValidationStepMismatch,
 };
 };
 


Modified: trunk/Source/WebKit/chromium/src/LocalizedStrings.cpp (111733 => 111734)

--- trunk/Source/WebKit/chromium/src/LocalizedStrings.cpp	2012-03-22 18:10:55 UTC (rev 111733)
+++ trunk/Source/WebKit/chromium/src/LocalizedStrings.cpp	2012-03-22 18:23:16 UTC (rev 111734)
@@ -206,6 +206,9 @@
 
 String missingPluginText()
 {
+String text = query(WebLocalizedString::MissingPluginText);
+if (!text.isEmpty())
+return text;
 notImplemented();
 return String(Missing Plug-in);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111735] trunk

[jocelyn . turcotte]

Title: [111735] trunk








Revision 111735
Author jocelyn.turco...@nokia.com
Date 2012-03-22 11:32:49 -0700 (Thu, 22 Mar 2012)


Log Message
TiledBackingStore: Fix test regressions that appeared with r111560.
https://bugs.webkit.org/show_bug.cgi?id=81519

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The visible rect wasn't intersected with the contents rect anymore which
could lead to an astronomical layer size to check for intersecting tiles.

Add a visibleContentsRect that doesn't do the conversion and use it
in visibleAreaIsCovered.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::visibleContentsRect):
(WebCore):
(WebCore::TiledBackingStore::visibleRect):
(WebCore::TiledBackingStore::visibleAreaIsCovered):
* platform/graphics/TiledBackingStore.h:
(TiledBackingStore):

LayoutTests:

* platform/qt-5.0-wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-5.0-wk2/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp
trunk/Source/WebCore/platform/graphics/TiledBackingStore.h




Diff

Modified: trunk/LayoutTests/ChangeLog (111734 => 111735)

--- trunk/LayoutTests/ChangeLog	2012-03-22 18:23:16 UTC (rev 111734)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 18:32:49 UTC (rev 111735)
@@ -1,3 +1,12 @@
+2012-03-22  Jocelyn Turcotte  jocelyn.turco...@nokia.com
+
+TiledBackingStore: Fix test regressions that appeared with r111560.
+https://bugs.webkit.org/show_bug.cgi?id=81519
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* platform/qt-5.0-wk2/Skipped:
+
 2012-03-22  Dan Bernstein  m...@apple.com
 
 Added fast/events/drag-link.html to the Mac WebKit2 skip list, because running it has


Modified: trunk/LayoutTests/platform/qt-5.0-wk2/Skipped (111734 => 111735)

--- trunk/LayoutTests/platform/qt-5.0-wk2/Skipped	2012-03-22 18:23:16 UTC (rev 111734)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/Skipped	2012-03-22 18:32:49 UTC (rev 111735)
@@ -530,14 +530,6 @@
 compositing/geometry/ancestor-overflow-change.html
 compositing/geometry/tall-page-composited.html
 
-# REGRESSION(r111560): compositing/geometry/preserve-3d-switching.html timeout.
-# https://bugs.webkit.org/show_bug.cgi?id=81519
-compositing/geometry/preserve-3d-switching.html
-# REGRESSION(r111560): The following tests are crashing.
-# https://bugs.webkit.org/show_bug.cgi?id=81519
-compositing/geometry/layer-due-to-layer-children.html
-compositing/geometry/repaint-foreground-layer.html
-
 # Boxes are not showing the correct perspective.
 transforms/3d/general/perspective-units.html
 


Modified: trunk/Source/WebCore/ChangeLog (111734 => 111735)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 18:23:16 UTC (rev 111734)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 18:32:49 UTC (rev 111735)
@@ -1,3 +1,24 @@
+2012-03-22  Jocelyn Turcotte  jocelyn.turco...@nokia.com
+
+TiledBackingStore: Fix test regressions that appeared with r111560.
+https://bugs.webkit.org/show_bug.cgi?id=81519
+
+Reviewed by Kenneth Rohde Christiansen.
+
+The visible rect wasn't intersected with the contents rect anymore which
+could lead to an astronomical layer size to check for intersecting tiles.
+
+Add a visibleContentsRect that doesn't do the conversion and use it
+in visibleAreaIsCovered.
+
+* platform/graphics/TiledBackingStore.cpp:
+(WebCore::TiledBackingStore::visibleContentsRect):
+(WebCore):
+(WebCore::TiledBackingStore::visibleRect):
+(WebCore::TiledBackingStore::visibleAreaIsCovered):
+* platform/graphics/TiledBackingStore.h:
+(TiledBackingStore):
+
 2012-03-22  Joe Thomas  joetho...@motorola.com
 
 Make Length Calculation functions non-inline


Modified: trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp (111734 => 111735)

--- trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp	2012-03-22 18:23:16 UTC (rev 111734)
+++ trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp	2012-03-22 18:32:49 UTC (rev 111735)
@@ -166,9 +166,14 @@
 context-restore();
 }
 
+IntRect TiledBackingStore::visibleContentsRect() const
+{
+return intersection(m_client-tiledBackingStoreVisibleRect(), m_client-tiledBackingStoreContentsRect());
+}
+
 IntRect TiledBackingStore::visibleRect() const
 {
-return mapFromContents(intersection(m_client-tiledBackingStoreVisibleRect(), m_client-tiledBackingStoreContentsRect()));
+return mapFromContents(visibleContentsRect());
 }
 
 void TiledBackingStore::setContentsScale(float scale)
@@ -227,7 +232,7 @@
 
 bool TiledBackingStore::visibleAreaIsCovered() const
 {
-return coverageRatio(m_client-tiledBackingStoreVisibleRect()) == 1.0f;
+return coverageRatio(visibleContentsRect()) == 1.0f;
 }
 
 void TiledBackingStore::createTiles()


Modified: trunk/Source/WebCore/platform/graphics/TiledBackingStore.h (111734 => 111735)

--- 

[webkit-changes] [111736] trunk/Tools

[dpranke]

Title: [111736] trunk/Tools








Revision 111736
Author dpra...@chromium.org
Date 2012-03-22 11:44:10 -0700 (Thu, 22 Mar 2012)


Log Message
Re-land fix for r81603 yet again (!) with latest build fix.
https://bugs.webkit.org/show_bug.cgi?id=81603

Unreviewed, build fix.

The latest problem was a bad sprintf() in
BasePort._get_crash_log(). I've reworked that routine and added
unit tests for coverage.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._handle_error):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
(TestResultWriter.write_crash_log):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.diff_text):
(Port._get_crash_log):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.run_test):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_crash_log):
* Scripts/webkitpy/layout_tests/port/driver.py:
(DriverOutput.__init__):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.is_lion):
(MacPort._get_crash_log):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_default_child_processes):
(test_get_crash_log):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTPortTest.test_get_crash_log):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_get_crash_log):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestDriver.run_test):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.__init__):
(WebKitDriver._start):
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver.run_test):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py




Diff

Modified: trunk/Tools/ChangeLog (111735 => 111736)

--- trunk/Tools/ChangeLog	2012-03-22 18:32:49 UTC (rev 111735)
+++ trunk/Tools/ChangeLog	2012-03-22 18:44:10 UTC (rev 111736)
@@ -1,3 +1,47 @@
+2012-03-22  Dirk Pranke  dpra...@chromium.org
+
+Re-land fix for r81603 yet again (!) with latest build fix.
+https://bugs.webkit.org/show_bug.cgi?id=81603
+
+Unreviewed, build fix.
+
+The latest problem was a bad sprintf() in
+BasePort._get_crash_log(). I've reworked that routine and added
+unit tests for coverage.
+
+* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
+(SingleTestRunner._handle_error):
+* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
+(write_test_result):
+(TestResultWriter.write_crash_log):
+* Scripts/webkitpy/layout_tests/port/base.py:
+(Port.diff_text):
+(Port._get_crash_log):
+* Scripts/webkitpy/layout_tests/port/chromium.py:
+(ChromiumDriver.run_test):
+* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
+(ChromiumDriverTest.test_crash_log):
+* Scripts/webkitpy/layout_tests/port/driver.py:
+(DriverOutput.__init__):
+* Scripts/webkitpy/layout_tests/port/mac.py:
+(MacPort.is_lion):
+(MacPort._get_crash_log):
+* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
+(test_default_child_processes):
+(test_get_crash_log):
+* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
+(MockDRTPortTest.test_get_crash_log):
+* Scripts/webkitpy/layout_tests/port/port_testcase.py:
+(PortTestCase.test_get_crash_log):
+* Scripts/webkitpy/layout_tests/port/test.py:
+(TestDriver.run_test):
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitDriver.__init__):
+(WebKitDriver._start):
+(WebKitDriver.has_crashed):
+(WebKitDriver._check_for_driver_crash):
+(WebKitDriver.run_test):
+
 2012-03-22  Alexander Færøy  alexander.fae...@nokia.com
 
 [Qt] Enable support for handling database quota's in the MiniBrowser


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (111735 => 111736)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py	2012-03-22 18:32:49 UTC (rev 111735)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py	2012-03-22 18:44:10 UTC (rev 111736)
@@ -198,7 +198,9 @@
 testname = 

[webkit-changes] [111737] trunk/Source/WebKit2

[ahf]

Title: [111737] trunk/Source/WebKit2








Revision 111737
Author a...@0x90.dk
Date 2012-03-22 11:50:31 -0700 (Thu, 22 Mar 2012)


Log Message
[Qt][WK2] Remember to initialize databaseQuotaDialog https://bugs.webkit.org/show_bug.cgi?id=81942

Reviewed by Kenneth Rohde Christiansen.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (111736 => 111737)

--- trunk/Source/WebKit2/ChangeLog	2012-03-22 18:44:10 UTC (rev 111736)
+++ trunk/Source/WebKit2/ChangeLog	2012-03-22 18:50:31 UTC (rev 111737)
@@ -1,5 +1,15 @@
 2012-03-22  Alexander Færøy  alexander.fae...@nokia.com
 
+[Qt][WK2] Remember to initialize databaseQuotaDialog
+https://bugs.webkit.org/show_bug.cgi?id=81942
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewPrivate::QQuickWebViewPrivate):
+
+2012-03-22  Alexander Færøy  alexander.fae...@nokia.com
+
 [Qt][WK2] Pass Origin information to the DatabaseQuotaDialogContextObject
 https://bugs.webkit.org/show_bug.cgi?id=81910
 


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (111736 => 111737)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-03-22 18:44:10 UTC (rev 111736)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-03-22 18:50:31 UTC (rev 111737)
@@ -76,6 +76,7 @@
 , itemSelector(0)
 , proxyAuthenticationDialog(0)
 , filePicker(0)
+, databaseQuotaDialog(0)
 , userDidOverrideContentWidth(false)
 , userDidOverrideContentHeight(false)
 , m_navigatorQtObjectEnabled(false)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111738] trunk/Source/WebKit2

[pierre . rossi]

Title: [111738] trunk/Source/WebKit2








Revision 111738
Author pierre.ro...@gmail.com
Date 2012-03-22 11:53:45 -0700 (Thu, 22 Mar 2012)


Log Message
Revert back the device DPI to 160.

This corresponds to a device pixel ratio of 1, which
is nicer on the eye in many cases.

Rubber-stamped by Kenneth Rohde Christiansen.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::computeViewportConstraints):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (111737 => 111738)

--- trunk/Source/WebKit2/ChangeLog	2012-03-22 18:50:31 UTC (rev 111737)
+++ trunk/Source/WebKit2/ChangeLog	2012-03-22 18:53:45 UTC (rev 111738)
@@ -1,3 +1,15 @@
+2012-03-22  Pierre Rossi  pierre.ro...@gmail.com
+
+Revert back the device DPI to 160.
+
+This corresponds to a device pixel ratio of 1, which
+is nicer on the eye in many cases.
+
+Rubber-stamped by Kenneth Rohde Christiansen.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewFlickablePrivate::computeViewportConstraints):
+
 2012-03-22  Alexander Færøy  alexander.fae...@nokia.com
 
 [Qt][WK2] Remember to initialize databaseQuotaDialog


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (111737 => 111738)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-03-22 18:50:31 UTC (rev 111737)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-03-22 18:53:45 UTC (rev 111738)
@@ -688,7 +688,7 @@
 WebPreferences* wkPrefs = webPageProxy-pageGroup()-preferences();
 
 // FIXME: Remove later; Hardcode a value for now to make sure the DPI adjustment is being tested.
-wkPrefs-setDeviceDPI(240);
+wkPrefs-setDeviceDPI(160);
 
 wkPrefs-setDeviceWidth(availableSize.width());
 wkPrefs-setDeviceHeight(availableSize.height());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111740] trunk/Source/WebCore

[simon . fraser]

Title: [111740] trunk/Source/WebCore








Revision 111740
Author simon.fra...@apple.com
Date 2012-03-22 12:01:10 -0700 (Thu, 22 Mar 2012)


Log Message
Factor compositing layer updates after scroll into a new method
https://bugs.webkit.org/show_bug.cgi?id=81943

Reviewed by Dean Jackson.

Move some code that updates compositing layers after scrolling
into its own method, for cleanliness.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
(WebCore):
* rendering/RenderLayer.h:
(RenderLayer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (111739 => 111740)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 18:54:50 UTC (rev 111739)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 19:01:10 UTC (rev 111740)
@@ -1,3 +1,20 @@
+2012-03-22  Simon Fraser  simon.fra...@apple.com
+
+Factor compositing layer updates after scroll into a new method
+https://bugs.webkit.org/show_bug.cgi?id=81943
+
+Reviewed by Dean Jackson.
+
+Move some code that updates compositing layers after scrolling
+into its own method, for cleanliness.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::scrollTo):
+(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
+(WebCore):
+* rendering/RenderLayer.h:
+(RenderLayer):
+
 2012-03-22  Gavin Barraclough  barraclo...@apple.com
 
 Add JSValue::isFunction


Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (111739 => 111740)

--- trunk/Source/WebCore/rendering/RenderLayer.cpp	2012-03-22 18:54:50 UTC (rev 111739)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp	2012-03-22 19:01:10 UTC (rev 111740)
@@ -1480,23 +1480,9 @@
 view-updateWidgetPositions();
 }
 
-#if USE(ACCELERATED_COMPOSITING)
-if (compositor()-inCompositingMode()) {
-// Our stacking context is guaranteed to contain all of our descendants that may need
-// repositioning, so update compositing layers from there.
-if (RenderLayer* compositingAncestor = stackingContext()-enclosingCompositingLayer()) {
-if (compositor()-compositingConsultsOverlap())
-compositor()-updateCompositingLayers(CompositingUpdateOnScroll, compositingAncestor);
-else {
-bool isUpdateRoot = true;
-compositingAncestor-backing()-updateAfterLayout(RenderLayerBacking::AllDescendants, isUpdateRoot);
-}
-}
-}
-#endif
+updateCompositingLayersAfterScroll();
 
 RenderBoxModelObject* repaintContainer = renderer()-containerForRepaint();
-
 Frame* frame = renderer()-frame();
 if (frame) {
 // The caret rect needs to be invalidated after scrolling
@@ -1617,6 +1603,24 @@
 frameView-resumeScheduledEvents();
 }
 
+void RenderLayer::updateCompositingLayersAfterScroll()
+{
+#if USE(ACCELERATED_COMPOSITING)
+if (compositor()-inCompositingMode()) {
+// Our stacking context is guaranteed to contain all of our descendants that may need
+// repositioning, so update compositing layers from there.
+if (RenderLayer* compositingAncestor = stackingContext()-enclosingCompositingLayer()) {
+if (compositor()-compositingConsultsOverlap())
+compositor()-updateCompositingLayers(CompositingUpdateOnScroll, compositingAncestor);
+else {
+bool isUpdateRoot = true;
+compositingAncestor-backing()-updateAfterLayout(RenderLayerBacking::AllDescendants, isUpdateRoot);
+}
+}
+}
+#endif
+}
+
 LayoutRect RenderLayer::getRectToExpose(const LayoutRect visibleRect, const LayoutRect exposeRect, const ScrollAlignment alignX, const ScrollAlignment alignY)
 {
 // Determine the appropriate X behavior.


Modified: trunk/Source/WebCore/rendering/RenderLayer.h (111739 => 111740)

--- trunk/Source/WebCore/rendering/RenderLayer.h	2012-03-22 18:54:50 UTC (rev 111739)
+++ trunk/Source/WebCore/rendering/RenderLayer.h	2012-03-22 19:01:10 UTC (rev 111740)
@@ -676,6 +676,7 @@
 
 // NOTE: This should only be called by the overriden setScrollOffset from ScrollableArea.
 void scrollTo(int, int);
+void updateCompositingLayersAfterScroll();
 
 IntSize scrollbarOffset(const Scrollbar*) const;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111741] trunk/LayoutTests

[mitz]

Title: [111741] trunk/LayoutTests








Revision 111741
Author m...@apple.com
Date 2012-03-22 12:04:18 -0700 (Thu, 22 Mar 2012)


Log Message
Added Mac WebKit2 expected results for this test. http://webkit.org/b/81945 tracks the
fact that these results are wrong.

* platform/mac-wk2/fast/events: Added.
* platform/mac-wk2/fast/events/suspend-timers-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/mac-wk2/fast/events/
trunk/LayoutTests/platform/mac-wk2/fast/events/suspend-timers-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (111740 => 111741)

--- trunk/LayoutTests/ChangeLog	2012-03-22 19:01:10 UTC (rev 111740)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 19:04:18 UTC (rev 111741)
@@ -1,3 +1,11 @@
+2012-03-22  Dan Bernstein  m...@apple.com
+
+Added Mac WebKit2 expected results for this test. http://webkit.org/b/81945 tracks the
+fact that these results are wrong.
+
+* platform/mac-wk2/fast/events: Added.
+* platform/mac-wk2/fast/events/suspend-timers-expected.txt: Added.
+
 2012-03-22  Jocelyn Turcotte  jocelyn.turco...@nokia.com
 
 TiledBackingStore: Fix test regressions that appeared with r111560.


Added: trunk/LayoutTests/platform/mac-wk2/fast/events/suspend-timers-expected.txt (0 => 111741)

--- trunk/LayoutTests/platform/mac-wk2/fast/events/suspend-timers-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac-wk2/fast/events/suspend-timers-expected.txt	2012-03-22 19:04:18 UTC (rev 111741)
@@ -0,0 +1,54 @@
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+CONSOLE MESSAGE: line 6: Timeout in subframe-1 created
+CONSOLE MESSAGE: line 5: Loaded pagehide-timeout-go-back.html, going back
+FAIL: Timed out 

[webkit-changes] [111746] trunk

[kevino]

Title: [111746] trunk








Revision 111746
Author kev...@webkit.org
Date 2012-03-22 12:43:29 -0700 (Thu, 22 Mar 2012)


Log Message
[wx] Unreviewed. Adding Source/WTF to the build and updating waf port list.

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wscript
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/wscript
trunk/Tools/waf/build/settings.py
trunk/wscript




Diff

Modified: trunk/ChangeLog (111745 => 111746)

--- trunk/ChangeLog	2012-03-22 19:37:22 UTC (rev 111745)
+++ trunk/ChangeLog	2012-03-22 19:43:29 UTC (rev 111746)
@@ -1,3 +1,10 @@
+2012-03-22  Kevin Ollivier  kev...@theolliviers.com
+
+[wx] Unreviewed. Adding Source/WTF to the build and updating
+waf port list.
+
+* wscript:
+
 2012-03-21  Ryosuke Niwa  rn...@webkit.org
 
 Add the forgotten admin.html after r108917.


Modified: trunk/Source/_javascript_Core/ChangeLog (111745 => 111746)

--- trunk/Source/_javascript_Core/ChangeLog	2012-03-22 19:37:22 UTC (rev 111745)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-03-22 19:43:29 UTC (rev 111746)
@@ -1,3 +1,9 @@
+2012-03-22  Kevin Ollivier  kev...@theolliviers.com
+
+[wx] Unreviewed. Adding Source/WTF to the build.
+
+* wscript:
+
 2012-03-22  Gavin Barraclough  barraclo...@apple.com
 
 Add JSValue::isFunction


Modified: trunk/Source/_javascript_Core/wscript (111745 => 111746)

--- trunk/Source/_javascript_Core/wscript	2012-03-22 19:37:22 UTC (rev 111745)
+++ trunk/Source/_javascript_Core/wscript	2012-03-22 19:43:29 UTC (rev 111746)
@@ -56,7 +56,7 @@
 # 1. A simple program
 jscore = bld.new_task_gen(
 features = 'cc cxx cshlib',
-includes = '. .. assembler DerivedSources ForwardingHeaders ' + ' '.join(includes),
+includes = '. .. assembler ../WTF ../WTF/wtf ' + ' '.join(includes),
 source = sources,
 defines = ['BUILDING_JavaScriptCore'],
 target = 'jscore',
@@ -68,7 +68,7 @@
 
 obj = bld.new_task_gen(
 features = 'cxx cprogram',
-includes = '. .. assembler DerivedSources ForwardingHeaders ' + ' '.join(includes),
+includes = '. .. assembler ../WTF ' + ' '.join(includes),
 source = 'jsc.cpp',
 target = 'jsc',
 uselib = 'WX ICU ' + get_config(),


Modified: trunk/Tools/ChangeLog (111745 => 111746)

--- trunk/Tools/ChangeLog	2012-03-22 19:37:22 UTC (rev 111745)
+++ trunk/Tools/ChangeLog	2012-03-22 19:43:29 UTC (rev 111746)
@@ -1,3 +1,11 @@
+2012-03-22  Kevin Ollivier  kev...@theolliviers.com
+
+[wx] Unreviewed. Adding Source/WTF to the build and updating
+waf port list.
+
+* DumpRenderTree/wscript:
+* waf/build/settings.py:
+
 2012-03-22  Dirk Pranke  dpra...@chromium.org
 
 Re-land fix for r81603 yet again (!) with latest build fix.


Modified: trunk/Tools/DumpRenderTree/wscript (111745 => 111746)

--- trunk/Tools/DumpRenderTree/wscript	2012-03-22 19:37:22 UTC (rev 111745)
+++ trunk/Tools/DumpRenderTree/wscript	2012-03-22 19:43:29 UTC (rev 111746)
@@ -32,6 +32,7 @@
 include_paths = [
 os.path.join(output_dir),
 os.path.join(wk_root, 'Source', '_javascript_Core'),
+os.path.join(wk_root, 'Source', 'WTF'),
 os.path.join(wk_root, 'Source', 'WebCore'),
 os.path.join(wk_root, 'Source', 'WebCore', 'bindings', 'wx'),
 os.path.join(wk_root, 'Source', 'WebKit', 'wx'), 


Modified: trunk/Tools/waf/build/settings.py (111745 => 111746)

--- trunk/Tools/waf/build/settings.py	2012-03-22 19:37:22 UTC (rev 111745)
+++ trunk/Tools/waf/build/settings.py	2012-03-22 19:43:29 UTC (rev 111746)
@@ -61,17 +61,24 @@
 common_frameworks = []
 
 ports = [
+'BlackBerry',
 'Chromium',
+'Efl',
 'Gtk',
 'Mac',
 'None',
 'Qt',
 'Safari',
 'Win',
-'Wince',
+'WinCE',
 'wx',
 ]
 
+uses = [
+'CF',
+'CFNet',
+]
+
 port_uses = {
 'wx': ['CURL', 'WXGC'],
 }
@@ -126,6 +133,7 @@
 'Source/WebCore/loader/archive',
 'Source/WebCore/loader/cache',
 'Source/WebCore/loader/icon',
+'Source/WebCore/Modules/filesystem',
 'Source/WebCore/Modules/geolocation',
 'Source/WebCore/Modules/indexeddb',
 'Source/WebCore/Modules/webdatabase',


Modified: trunk/wscript (111745 => 111746)

--- trunk/wscript	2012-03-22 19:37:22 UTC (rev 111745)
+++ trunk/wscript	2012-03-22 19:43:29 UTC (rev 111746)
@@ -208,7 +208,6 @@
 
 import TaskGen
 
-# FIXME: Does this need to be Source/_javascript_Core?
 bld.add_subdirs('Source/_javascript_Core')
 
 if sys.platform.startswith('darwin'):
@@ -216,16 +215,24 @@
 TaskGen.task_gen.mappings['.m'] = TaskGen.task_gen.mappings['.cxx']
 
 features = [Options.options.port.lower()]
-exclude_patterns = ['*AllInOne.cpp', '*CFNet.cpp', '*Chromium*.cpp', 
-'*Efl.cpp', '*Gtk.cpp', '*Mac.cpp', '*None.cpp', '*Qt.cpp', '*Safari.cpp',
-

[webkit-changes] [111747] trunk/LayoutTests

[mitz]

Title: [111747] trunk/LayoutTests








Revision 111747
Author m...@apple.com
Date 2012-03-22 12:57:46 -0700 (Thu, 22 Mar 2012)


Log Message
Added all tests that failed on the Lion WebKit2 Release bot in r111739 to the Mac WebKit2
skip list.

Rubber-stamped by Geoff Garen.

* platform/mac-wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (111746 => 111747)

--- trunk/LayoutTests/ChangeLog	2012-03-22 19:43:29 UTC (rev 111746)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 19:57:46 UTC (rev 111747)
@@ -1,3 +1,12 @@
+2012-03-22  Dan Bernstein  m...@apple.com
+
+Added all tests that failed on the Lion WebKit2 Release bot in r111739 to the Mac WebKit2
+skip list.
+
+Rubber-stamped by Geoff Garen.
+
+* platform/mac-wk2/Skipped:
+
 2012-03-22  Ojan Vafai  o...@chromium.org
 
 Initial triage pass of css3/selectors3/html for the Chromium ports.


Modified: trunk/LayoutTests/platform/mac-wk2/Skipped (111746 => 111747)

--- trunk/LayoutTests/platform/mac-wk2/Skipped	2012-03-22 19:43:29 UTC (rev 111746)
+++ trunk/LayoutTests/platform/mac-wk2/Skipped	2012-03-22 19:57:46 UTC (rev 111747)
@@ -261,6 +261,25 @@
 
 ### START OF (3) Unclassified failures
 
+# All tests that failed on the Lion WebKit2 Release bot in r111739
+editing/execCommand/copy-without-selection.html
+editing/pasteboard/copy-two-pasteboard-types-both-work.html
+editing/pasteboard/pasting-empty-html-falls-back-to-text.html
+fast/events/suspend-timers.html
+fast/forms/interactive-validation-attach-assertion.html
+fast/forms/range/slider-delete-while-dragging-thumb.html
+fast/frames/flattening/frameset-flattening-advanced.html
+fast/history/form-submit-in-frame-via-onclick.html
+fast/history/form-submit-in-frame.html
+fast/history/saves-state-after-frame-nav.html
+fast/regions/css-regions-disabled.html
+http/tests/appcache/manifest-containing-itself.html
+http/tests/inspector/extensions-ignore-cache.html
+http/tests/security/credentials-in-referer.html
+http/tests/workers/terminate-during-sync-operation.html
+storage/hash-change-with-xhr.html
+svg/W3C-SVG-1.1/fonts-elem-04-b.svg
+
 ### END OF (3) Unclassified failures
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111748] trunk/LayoutTests

[mitz]

Title: [111748] trunk/LayoutTests








Revision 111748
Author m...@apple.com
Date 2012-03-22 13:03:05 -0700 (Thu, 22 Mar 2012)


Log Message
Added all tests that failed on the Lion WebKit2 Debug bot in r111739 to the Mac WebKit2
skip list (except those already on the list because they failed on the WebKit2 Releast bot).
Removed fast/events/suspend-timers.html from the list since its failure was addressed in a
later revision.

Rubber-stamped by Geoff Garen.

* platform/mac-wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (111747 => 111748)

--- trunk/LayoutTests/ChangeLog	2012-03-22 19:57:46 UTC (rev 111747)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 20:03:05 UTC (rev 111748)
@@ -1,5 +1,16 @@
 2012-03-22  Dan Bernstein  m...@apple.com
 
+Added all tests that failed on the Lion WebKit2 Debug bot in r111739 to the Mac WebKit2
+skip list (except those already on the list because they failed on the WebKit2 Releast bot).
+Removed fast/events/suspend-timers.html from the list since its failure was addressed in a
+later revision.
+
+Rubber-stamped by Geoff Garen.
+
+* platform/mac-wk2/Skipped:
+
+2012-03-22  Dan Bernstein  m...@apple.com
+
 Added all tests that failed on the Lion WebKit2 Release bot in r111739 to the Mac WebKit2
 skip list.
 


Modified: trunk/LayoutTests/platform/mac-wk2/Skipped (111747 => 111748)

--- trunk/LayoutTests/platform/mac-wk2/Skipped	2012-03-22 19:57:46 UTC (rev 111747)
+++ trunk/LayoutTests/platform/mac-wk2/Skipped	2012-03-22 20:03:05 UTC (rev 111748)
@@ -265,7 +265,6 @@
 editing/execCommand/copy-without-selection.html
 editing/pasteboard/copy-two-pasteboard-types-both-work.html
 editing/pasteboard/pasting-empty-html-falls-back-to-text.html
-fast/events/suspend-timers.html
 fast/forms/interactive-validation-attach-assertion.html
 fast/forms/range/slider-delete-while-dragging-thumb.html
 fast/frames/flattening/frameset-flattening-advanced.html
@@ -280,6 +279,16 @@
 storage/hash-change-with-xhr.html
 svg/W3C-SVG-1.1/fonts-elem-04-b.svg
 
+# All additional tests that failed on the Lion WebKit2 Debug bot in r111739
+fast/forms/validation-message-in-relative-body.html
+http/tests/appcache/cyrillic-uri.html
+http/tests/appcache/interrupted-update.html
+http/tests/cookies/simple-cookies-expired.html
+http/tests/inspector/inspect-element.html
+inspector/elements/edit-dom-actions.html
+storage/open-database-creation-callback-isolated-world.html
+storage/statement-error-callback-isolated-world.html
+
 ### END OF (3) Unclassified failures
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111749] trunk/Tools

[kov]

Title: [111749] trunk/Tools








Revision 111749
Author k...@webkit.org
Date 2012-03-22 13:23:01 -0700 (Thu, 22 Mar 2012)


Log Message
[GTK] Add make to the jhbuild moduleset
https://bugs.webkit.org/show_bug.cgi?id=81769

Reviewed by Martin Robinson.

Mostly based on a patch by Carlos Garcia Campos cgar...@igalia.com.
Add GNU make with custom patches to fix several issues:

- make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to
  fix the argument list limit of GNU make when running make
  distcheck.
- make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski
  and Jeremy Devenport to fix parallel build issues present in
  GNU make 3.82

* gtk/jhbuild.modules: Added make with patches.
* gtk/patches/make-3.82-arg-list-length.patch: Added.
* gtk/patches/make-3.82-parallel-build.patch: Added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules


Added Paths

trunk/Tools/gtk/patches/make-3.82-arg-list-length.patch
trunk/Tools/gtk/patches/make-3.82-parallel-build.patch




Diff

Modified: trunk/Tools/ChangeLog (111748 => 111749)

--- trunk/Tools/ChangeLog	2012-03-22 20:03:05 UTC (rev 111748)
+++ trunk/Tools/ChangeLog	2012-03-22 20:23:01 UTC (rev 111749)
@@ -1,3 +1,24 @@
+2012-03-22  Gustavo Noronha Silva  g...@gnome.org
+
+[GTK] Add make to the jhbuild moduleset
+https://bugs.webkit.org/show_bug.cgi?id=81769
+
+Reviewed by Martin Robinson.
+
+Mostly based on a patch by Carlos Garcia Campos cgar...@igalia.com.
+Add GNU make with custom patches to fix several issues:
+
+- make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to
+  fix the argument list limit of GNU make when running make
+  distcheck.
+- make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski
+  and Jeremy Devenport to fix parallel build issues present in
+  GNU make 3.82
+
+* gtk/jhbuild.modules: Added make with patches.
+* gtk/patches/make-3.82-arg-list-length.patch: Added.
+* gtk/patches/make-3.82-parallel-build.patch: Added.
+
 2012-03-22  Kevin Ollivier  kev...@theolliviers.com
 
 [wx] Unreviewed. Adding Source/WTF to the build and updating


Modified: trunk/Tools/gtk/jhbuild.modules (111748 => 111749)

--- trunk/Tools/gtk/jhbuild.modules	2012-03-22 20:03:05 UTC (rev 111748)
+++ trunk/Tools/gtk/jhbuild.modules	2012-03-22 20:23:01 UTC (rev 111749)
@@ -5,6 +5,7 @@
 
   metamodule id=webkitgtk-testing-dependencies
 dependencies
+  dep package=make/
   dep package=cairo/
   dep package=fonts/
   dep package=fontconfig/
@@ -20,6 +21,8 @@
 /dependencies
   /metamodule
 
+  repository type=tarball name=ftp.gnu.org
+  href=""
   repository type=tarball name=github.com
   href=""
   repository type=tarball name=sourceware.org
@@ -39,6 +42,15 @@
   repository type=tarball name=freedesktop.org
   href=""
 
+  autotools id=make autogen-sh=configure
+branch repo=ftp.gnu.org
+module=make/make-3.82.tar.bz2 version=3.82
+size=1242186 md5sum=1a11100f3c63fcf5753818e59d63088f
+  patch file=make-3.82-arg-list-length.patch strip=1/
+  patch file=make-3.82-parallel-build.patch strip=1/
+/branch
+  /autotools
+
   autotools id=cairo autogen-sh=configure
 dependencies
   dep package=pixman/


Added: trunk/Tools/gtk/patches/make-3.82-arg-list-length.patch (0 => 111749)

--- trunk/Tools/gtk/patches/make-3.82-arg-list-length.patch	(rev 0)
+++ trunk/Tools/gtk/patches/make-3.82-arg-list-length.patch	2012-03-22 20:23:01 UTC (rev 111749)
@@ -0,0 +1,104 @@
+diff -u make-3.82-orig/configure.in make-3.82/configure.in
+--- make-3.82-orig/configure.in	2010-07-28 07:39:50.0 +0200
 make-3.82/configure.in	2012-03-21 12:34:20.0 +0100
+@@ -64,7 +64,8 @@
+ AC_HEADER_STAT
+ AC_HEADER_TIME
+ AC_CHECK_HEADERS(stdlib.h locale.h unistd.h limits.h fcntl.h string.h \
+-		 memory.h sys/param.h sys/resource.h sys/time.h sys/timeb.h)
++		 memory.h sys/param.h sys/resource.h sys/time.h sys/timeb.h \
++		 sys/user.h linux/binfmts.h)
+ 
+ # Set a flag if we have an ANSI C compiler
+ if test $ac_cv_prog_cc_stdc != no; then
+Subdirectorios comunes: make-3.82-orig/doc y make-3.82/doc
+Subdirectorios comunes: make-3.82-orig/glob y make-3.82/glob
+diff -u make-3.82-orig/job.c make-3.82/job.c
+--- make-3.82-orig/job.c	2010-07-24 10:27:50.0 +0200
 make-3.82/job.c	2012-03-21 12:34:20.0 +0100
+@@ -29,6 +29,11 @@
+ 
+ #include string.h
+ 
++#if defined (HAVE_LINUX_BINFMTS_H)  defined (HAVE_SYS_USER_H)
++#include sys/user.h
++#include linux/binfmts.h
++#endif
++
+ /* Default shell to use.  */
+ #ifdef WINDOWS32
+ #include windows.h
+@@ -2795,6 +2800,7 @@
+ unsigned int sflags_len = strlen (shellflags);
+ char *command_ptr = NULL; /* used for batch_mode_shell mode */
+ char *new_line;
++char *args_ptr;
+ 
+ # ifdef __EMX__ /* is this necessary? */
+ if (!unixy_shell)
+@@ -2865,8 

[webkit-changes] [111750] trunk/Tools

[dpranke]

Title: [111750] trunk/Tools








Revision 111750
Author dpra...@chromium.org
Date 2012-03-22 13:29:22 -0700 (Thu, 22 Mar 2012)


Log Message
nrwt: crash while stopping layout test helper on apple mac lion
https://bugs.webkit.org/show_bug.cgi?id=81949

Reviewed by Eric Seidel.

stop_helper() didn't work right if the helper process wasn't
still running or didn't respond properly to being shut down. Fix
this and add some tests. Also add code to MockExecutive() to be
able to mock executive.popen() properly.

* Scripts/webkitpy/common/system/executive_mock.py:
(MockProcess.__init__):
(MockProcess.wait):
(MockExecutive.__init__):
(MockExecutive.popen):
* Scripts/webkitpy/common/system/systemhost_mock.py:
(MockSystemHost.__init__):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.start_helper):
(MacPort.stop_helper):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_get_crash_log):
(test_helper_starts):
(test_helper_fails_to_start):
(test_helper_fails_to_stop):
(test_helper_fails_to_stop.bad_waiter):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py
trunk/Tools/Scripts/webkitpy/common/system/systemhost_mock.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (111749 => 111750)

--- trunk/Tools/ChangeLog	2012-03-22 20:23:01 UTC (rev 111749)
+++ trunk/Tools/ChangeLog	2012-03-22 20:29:22 UTC (rev 111750)
@@ -1,3 +1,32 @@
+2012-03-22  Dirk Pranke  dpra...@chromium.org
+
+nrwt: crash while stopping layout test helper on apple mac lion
+https://bugs.webkit.org/show_bug.cgi?id=81949
+
+Reviewed by Eric Seidel.
+
+stop_helper() didn't work right if the helper process wasn't
+still running or didn't respond properly to being shut down. Fix
+this and add some tests. Also add code to MockExecutive() to be
+able to mock executive.popen() properly.
+
+* Scripts/webkitpy/common/system/executive_mock.py:
+(MockProcess.__init__):
+(MockProcess.wait):
+(MockExecutive.__init__):
+(MockExecutive.popen):
+* Scripts/webkitpy/common/system/systemhost_mock.py:
+(MockSystemHost.__init__):
+* Scripts/webkitpy/layout_tests/port/mac.py:
+(MacPort.start_helper):
+(MacPort.stop_helper):
+* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
+(test_get_crash_log):
+(test_helper_starts):
+(test_helper_fails_to_start):
+(test_helper_fails_to_stop):
+(test_helper_fails_to_stop.bad_waiter):
+
 2012-03-22  Gustavo Noronha Silva  g...@gnome.org
 
 [GTK] Add make to the jhbuild moduleset


Modified: trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py (111749 => 111750)

--- trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py	2012-03-22 20:23:01 UTC (rev 111749)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py	2012-03-22 20:29:22 UTC (rev 111750)
@@ -27,15 +27,20 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 import os
+import StringIO
 
 from webkitpy.common.system.deprecated_logging import log
 from webkitpy.common.system.executive import ScriptError
 
 
 class MockProcess(object):
-def __init__(self):
+def __init__(self, stdout='MOCK STDOUT\n'):
 self.pid = 42
+self.stdout = StringIO.StringIO(stdout)
+self.stdin = StringIO.StringIO()
 
+def wait(self):
+return
 
 # FIXME: This should be unified with MockExecutive2
 class MockExecutive(object):
@@ -52,6 +57,7 @@
 self._should_throw_when_run = should_throw_when_run or set()
 # FIXME: Once executive wraps os.getpid() we can just use a static pid for this process.
 self._running_pids = [os.getpid()]
+self._proc = None
 
 def check_running_pid(self, pid):
 return pid in self._running_pids
@@ -91,7 +97,9 @@
 
 def popen(self, *args, **kwargs):
 # FIXME: Implement logging when self._should_log is set.
-return MockProcess()
+if not self._proc:
+self._proc = MockProcess()
+return self._proc
 
 
 class MockExecutive2(object):


Modified: trunk/Tools/Scripts/webkitpy/common/system/systemhost_mock.py (111749 => 111750)

--- trunk/Tools/Scripts/webkitpy/common/system/systemhost_mock.py	2012-03-22 20:23:01 UTC (rev 111749)
+++ trunk/Tools/Scripts/webkitpy/common/system/systemhost_mock.py	2012-03-22 20:29:22 UTC (rev 111750)
@@ -35,8 +35,8 @@
 
 
 class MockSystemHost(object):
-def __init__(self, log_executive=False, executive_throws_when_run=None, os_name=None, os_version=None):
-self.executive = MockExecutive(should_log=log_executive, should_throw_when_run=executive_throws_when_run)
+def __init__(self, log_executive=False, executive_throws_when_run=None, os_name=None, os_version=None, executive=None):
+self.executive = 

[webkit-changes] [111751] trunk/Source/WebCore

[jchaffraix]

Title: [111751] trunk/Source/WebCore








Revision 111751
Author jchaffr...@webkit.org
Date 2012-03-22 13:36:34 -0700 (Thu, 22 Mar 2012)


Log Message
Enable style sharing for elements with a style attribute
https://bugs.webkit.org/show_bug.cgi?id=81523

Reviewed by Antti Koivisto.

Memory improvement change only.

Overall, this is a performance wash (some benchmarks may regress a bit due to the increase in time taken
by CSSStyleSelector::locateSharedStyle as we try more nodes, others increase their performance due to style sharing).

Instrumenting our style sharing, this should give us some nice memory shavings on some benchmarks:
- HTML5 isn't impacted as it doesn't use much inline style
- page cyclers' intl1 showed a 6% increase in style sharing.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
This method now handles inline style like presentation attributes on the element.

(WebCore::CSSStyleSelector::collectMatchingRulesForList):
(WebCore::CSSStyleSelector::locateSharedStyle):
Don't bail out for an element with an inline style declaration.

(WebCore::CSSStyleSelector::stylesEqual):
Generalized attributeStylesEqual to share the logic between attribute and
inline style property set. This means that attribute checks are actually
doing a little extra more work but that didn't impact our benchmarks.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (111750 => 111751)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 20:29:22 UTC (rev 111750)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 20:36:34 UTC (rev 111751)
@@ -1,3 +1,32 @@
+2012-03-22  Julien Chaffraix  jchaffr...@webkit.org
+
+Enable style sharing for elements with a style attribute
+https://bugs.webkit.org/show_bug.cgi?id=81523
+
+Reviewed by Antti Koivisto.
+
+Memory improvement change only.
+
+Overall, this is a performance wash (some benchmarks may regress a bit due to the increase in time taken
+by CSSStyleSelector::locateSharedStyle as we try more nodes, others increase their performance due to style sharing).
+
+Instrumenting our style sharing, this should give us some nice memory shavings on some benchmarks:
+- HTML5 isn't impacted as it doesn't use much inline style
+- page cyclers' intl1 showed a 6% increase in style sharing.
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::canShareStyleWithElement):
+This method now handles inline style like presentation attributes on the element.
+
+(WebCore::CSSStyleSelector::collectMatchingRulesForList):
+(WebCore::CSSStyleSelector::locateSharedStyle):
+Don't bail out for an element with an inline style declaration.
+
+(WebCore::CSSStyleSelector::stylesEqual):
+Generalized attributeStylesEqual to share the logic between attribute and
+inline style property set. This means that attribute checks are actually
+doing a little extra more work but that didn't impact our benchmarks.
+
 2012-03-22  Kevin Ollivier  kev...@theolliviers.com
 
 [wx] Unreviewed. WebDOM build fix after array type changes.


Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (111750 => 111751)

--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2012-03-22 20:29:22 UTC (rev 111750)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2012-03-22 20:36:34 UTC (rev 111751)
@@ -1160,8 +1160,6 @@
 return 0;
 #endif
 StyledElement* p = static_castStyledElement*(parent);
-if (p-inlineStyle())
-return 0;
 #if ENABLE(SVG)
 if (p-isSVGElement()  static_castSVGElement*(p)-animatedSMILStyleProperties())
 return 0;
@@ -1253,8 +1251,7 @@
 return true;
 }
 
-// This function makes some assumptions that only make sense for attribute styles (we only compare CSSProperty::id() and CSSProperty::value().)
-static inline bool attributeStylesEqual(StylePropertySet* a, StylePropertySet* b)
+static inline bool stylesEqual(const StylePropertySet* a, const StylePropertySet* b)
 {
 if (a == b)
 return true;
@@ -1268,9 +1265,16 @@
 const CSSProperty bProperty = b-propertyAt(j);
 if (aProperty.id() != bProperty.id())
 continue;
+
+// We don't check the short-hand property because long-hand vs short-hand is handled by checking the property set's count above.
+if (aProperty.isImportant() != bProperty.isImportant()
+|| aProperty.isInherited() != bProperty.isInherited() || aProperty.isImplicit() != bProperty.isImplicit())
+return false;
+
 // We could get a few more hits by comparing cssText() here, but that gets expensive quickly.
 if (aProperty.value() != bProperty.value())
 return false;
+
 break;
 }
 if (j == propertyCount)
@@ -1296,14 +1300,15 @@
   

[webkit-changes] [111753] trunk

[commit-queue]

Title: [111753] trunk








Revision 111753
Author commit-qu...@webkit.org
Date 2012-03-22 13:43:12 -0700 (Thu, 22 Mar 2012)


Log Message
[EFL] Enable view mode media feature layout tests
https://bugs.webkit.org/show_bug.cgi?id=81205

Tools:

Adding missing implementation setViewModeMediaFeature to EFL's
LayoutTestController so that we can unskip view mode
media feature layout tests.

Patch by Sudarsana Nagineni sudarsana.nagin...@linux.intel.com on 2012-03-22
Reviewed by Antonio Gomes.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setViewModeMediaFeature): Implemented.

LayoutTests:

Unskip tests connected with setViewModeMediaFeature.

Patch by Sudarsana Nagineni sudarsana.nagin...@linux.intel.com on 2012-03-22
Reviewed by Antonio Gomes.

* platform/efl/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (111752 => 111753)

--- trunk/LayoutTests/ChangeLog	2012-03-22 20:42:38 UTC (rev 111752)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 20:43:12 UTC (rev 111753)
@@ -1,3 +1,14 @@
+2012-03-22  Sudarsana Nagineni  sudarsana.nagin...@linux.intel.com
+
+[EFL] Enable view mode media feature layout tests
+https://bugs.webkit.org/show_bug.cgi?id=81205
+
+Unskip tests connected with setViewModeMediaFeature.
+
+Reviewed by Antonio Gomes.
+
+* platform/efl/Skipped:
+
 2012-03-22  Dan Bernstein  m...@apple.com
 
 Added all tests that failed on the Lion WebKit2 Debug bot in r111739 to the Mac WebKit2


Modified: trunk/LayoutTests/platform/efl/Skipped (111752 => 111753)

--- trunk/LayoutTests/platform/efl/Skipped	2012-03-22 20:42:38 UTC (rev 111752)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-03-22 20:43:12 UTC (rev 111753)
@@ -429,15 +429,6 @@
 svg/custom/manually-parsed-svg-disallowed-in-dashboard.html
 svg/custom/svg-disallowed-in-dashboard-object.html
 
-# EFL's LayoutTestController does not implement setViewModeMediaFeature
-fast/media/media-query-list-02.html
-fast/media/media-query-list-03.html
-fast/media/media-query-list-04.html
-fast/media/media-query-list-05.html
-fast/media/media-query-list-06.html
-fast/media/media-query-list-07.html
-fast/media/view-mode-media-feature.html
-
 # EFL's LayoutTestController does not implement enableAutoResizeMode
 fast/autoresize
 


Modified: trunk/Tools/ChangeLog (111752 => 111753)

--- trunk/Tools/ChangeLog	2012-03-22 20:42:38 UTC (rev 111752)
+++ trunk/Tools/ChangeLog	2012-03-22 20:43:12 UTC (rev 111753)
@@ -1,3 +1,17 @@
+2012-03-22  Sudarsana Nagineni  sudarsana.nagin...@linux.intel.com
+
+[EFL] Enable view mode media feature layout tests
+https://bugs.webkit.org/show_bug.cgi?id=81205
+
+Adding missing implementation setViewModeMediaFeature to EFL's 
+LayoutTestController so that we can unskip view mode 
+media feature layout tests.
+
+Reviewed by Antonio Gomes.
+
+* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+(LayoutTestController::setViewModeMediaFeature): Implemented.
+
 2012-03-22  Dirk Pranke  dpra...@chromium.org
 
 nrwt: crash while stopping layout test helper on apple mac lion


Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (111752 => 111753)

--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp	2012-03-22 20:42:38 UTC (rev 111752)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp	2012-03-22 20:43:12 UTC (rev 111753)
@@ -263,9 +263,22 @@
 DumpRenderTreeSupportEfl::setValueForUser(context, nodeObject, value);
 }
 
-void LayoutTestController::setViewModeMediaFeature(JSStringRef)
+void LayoutTestController::setViewModeMediaFeature(JSStringRef mode)
 {
-notImplemented();
+Evas_Object* view = browser-mainView();
+if (!view)
+return;
+
+if (equals(mode, windowed))
+ewk_view_mode_set(view, EWK_VIEW_MODE_WINDOWED);
+else if (equals(mode, floating))
+ewk_view_mode_set(view, EWK_VIEW_MODE_FLOATING);
+else if (equals(mode, fullscreen))
+ewk_view_mode_set(view, EWK_VIEW_MODE_FULLSCREEN);
+else if (equals(mode, maximized))
+ewk_view_mode_set(view, EWK_VIEW_MODE_MAXIMIZED);
+else if (equals(mode, minimized))
+ewk_view_mode_set(view, EWK_VIEW_MODE_MINIMIZED);
 }
 
 void LayoutTestController::setWindowIsKey(bool)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111754] trunk

[commit-queue]

Title: [111754] trunk








Revision 111754
Author commit-qu...@webkit.org
Date 2012-03-22 13:45:36 -0700 (Thu, 22 Mar 2012)


Log Message
HTMLPluginElement is not destroyed on reload or navigation if getNPObject is called
https://bugs.webkit.org/show_bug.cgi?id=80428

Patch by Dave Michael dmich...@chromium.org on 2012-03-22
Reviewed by Eric Seidel.

.:

Test: plugins/netscape-dom-access-and-reload.html

* Source/autotools/symbols.filter: Export a symbol for InspectorCounters::counterValue.

Source/WebCore:

Make HTMLPluginElement release its m_NPObject in detach() to break a
reference-counting cycle that happens on reload or navigation. With this
change, HTMLPlugInElement::removedFromDocument is unnecessary, so it
was removed. Note that Releasing m_NPObject does not result in a call to
the plugin; it simply releases a reference count on the wrapper object
for this HTMLPlugInElement. (The plugin's NPP_Deallocate is invoked
when the render tree is destroyed, when PluginView calls
PluginPackage::unload.) Thus, it is safe to release m_NPObject in
detach, because it can not result in layout or style changes.

Also added numberOfLiveNodes() and numberOfLiveDocuments() to
window.internals to enable testing.

Test: plugins/netscape-dom-access-and-reload.html

* WebCore.exp.in:
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::detach):
* html/HTMLPlugInElement.h:
(HTMLPlugInElement):
* testing/Internals.cpp:
(WebCore::Internals::numberOfLiveDocuments):
(WebCore::Internals::numberOfLiveNodes):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit2:

Test: plugins/netscape-dom-access-and-reload.html

* win/WebKit2.def: Export a symbol for InspectorCounters::counterValue
* win/WebKit2CFLite.def: Export a symbol for InspectorCounters::counterValue

LayoutTests:

* plugins/netscape-dom-access-and-reload-expected.txt: Added.
* plugins/netscape-dom-access-and-reload.html: Added.

Modified Paths

trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/html/HTMLPlugInElement.cpp
trunk/Source/WebCore/html/HTMLPlugInElement.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/win/WebKit2.def
trunk/Source/WebKit2/win/WebKit2CFLite.def
trunk/Source/autotools/symbols.filter


Added Paths

trunk/LayoutTests/plugins/netscape-dom-access-and-reload-expected.txt
trunk/LayoutTests/plugins/netscape-dom-access-and-reload.html




Diff

Modified: trunk/ChangeLog (111753 => 111754)

--- trunk/ChangeLog	2012-03-22 20:43:12 UTC (rev 111753)
+++ trunk/ChangeLog	2012-03-22 20:45:36 UTC (rev 111754)
@@ -1,3 +1,14 @@
+2012-03-22  Dave Michael  dmich...@chromium.org
+
+HTMLPluginElement is not destroyed on reload or navigation if getNPObject is called
+https://bugs.webkit.org/show_bug.cgi?id=80428
+
+Reviewed by Eric Seidel.
+
+Test: plugins/netscape-dom-access-and-reload.html
+
+* Source/autotools/symbols.filter: Export a symbol for InspectorCounters::counterValue.
+
 2012-03-22  Kevin Ollivier  kev...@theolliviers.com
 
 [wx] Unreviewed. Adding Source/WTF to the build and updating


Modified: trunk/LayoutTests/ChangeLog (111753 => 111754)

--- trunk/LayoutTests/ChangeLog	2012-03-22 20:43:12 UTC (rev 111753)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 20:45:36 UTC (rev 111754)
@@ -1,3 +1,13 @@
+2012-03-22  Dave Michael  dmich...@chromium.org
+
+HTMLPluginElement is not destroyed on reload or navigation if getNPObject is called
+https://bugs.webkit.org/show_bug.cgi?id=80428
+
+Reviewed by Eric Seidel.
+
+* plugins/netscape-dom-access-and-reload-expected.txt: Added.
+* plugins/netscape-dom-access-and-reload.html: Added.
+
 2012-03-22  Sudarsana Nagineni  sudarsana.nagin...@linux.intel.com
 
 [EFL] Enable view mode media feature layout tests


Added: trunk/LayoutTests/plugins/netscape-dom-access-and-reload-expected.txt (0 => 111754)

--- trunk/LayoutTests/plugins/netscape-dom-access-and-reload-expected.txt	(rev 0)
+++ trunk/LayoutTests/plugins/netscape-dom-access-and-reload-expected.txt	2012-03-22 20:45:36 UTC (rev 111754)
@@ -0,0 +1,3 @@
+This page tests reloading a Netscape plug-in that accesses its own DOM element. See https://bugs.webkit.org/show_bug.cgi?id=80428, HTMLPluginElement is not destroyed on reload or navigation if getNPObject is called. If it succeeds, you should see SUCCESS below. 
+
+SUCCESS


Added: trunk/LayoutTests/plugins/netscape-dom-access-and-reload.html (0 => 111754)

--- trunk/LayoutTests/plugins/netscape-dom-access-and-reload.html	(rev 0)
+++ trunk/LayoutTests/plugins/netscape-dom-access-and-reload.html	2012-03-22 20:45:36 UTC (rev 111754)
@@ -0,0 +1,55 @@
+!DOCTYPE html
+html
+head
+script
+function runTest()
+{
+// Make the 

[webkit-changes] [111755] trunk

[robert]

Title: [111755] trunk








Revision 111755
Author rob...@webkit.org
Date 2012-03-22 13:49:24 -0700 (Thu, 22 Mar 2012)


Log Message
Text should overflow when list item height set to 0
https://bugs.webkit.org/show_bug.cgi?id=78726

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: css2.1/20110323/height-applies-to-010a-expected.html
   fast/css/heightless-list-item-expected.html
   fast/css/heightless-list-item.html

* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::paint):
   If the list item has height:0, only paint it if the list item allows any block or inline content
   to overflow unclipped. The zero-height check is a shortcut to avoid unnecessary painting and
   this seems to be the only case where there's something to do.

LayoutTests:

* css2.1/20110323/height-applies-to-010a-expected.html: Added.
* css2.1/20110323/height-applies-to-010a.htm: Added.
* fast/css/heightless-list-item-expected.html: Added.
* fast/css/heightless-list-item.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderListItem.cpp


Added Paths

trunk/LayoutTests/css2.1/20110323/height-applies-to-010a-expected.html
trunk/LayoutTests/css2.1/20110323/height-applies-to-010a.htm
trunk/LayoutTests/fast/css/heightless-list-item-expected.html
trunk/LayoutTests/fast/css/heightless-list-item.html




Diff

Modified: trunk/LayoutTests/ChangeLog (111754 => 111755)

--- trunk/LayoutTests/ChangeLog	2012-03-22 20:45:36 UTC (rev 111754)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 20:49:24 UTC (rev 111755)
@@ -1,3 +1,15 @@
+2012-03-19  Robert Hogan  rob...@webkit.org
+
+Text should overflow when list item height set to 0
+https://bugs.webkit.org/show_bug.cgi?id=78726
+
+Reviewed by Julien Chaffraix.
+
+* css2.1/20110323/height-applies-to-010a-expected.html: Added.
+* css2.1/20110323/height-applies-to-010a.htm: Added.
+* fast/css/heightless-list-item-expected.html: Added.
+* fast/css/heightless-list-item.html: Added.
+
 2012-03-22  Dave Michael  dmich...@chromium.org
 
 HTMLPluginElement is not destroyed on reload or navigation if getNPObject is called


Added: trunk/LayoutTests/css2.1/20110323/height-applies-to-010a-expected.html (0 => 111755)

--- trunk/LayoutTests/css2.1/20110323/height-applies-to-010a-expected.html	(rev 0)
+++ trunk/LayoutTests/css2.1/20110323/height-applies-to-010a-expected.html	2012-03-22 20:49:24 UTC (rev 111755)
@@ -0,0 +1,59 @@
+!DOCTYPE html PUBLIC -//W3C//DTD HTML 4.01//EN http://www.w3.org/TR/html4/strict.dtd
+html
+
+ head
+
+  titleCSS Test: height set to 0 to elements with 'display' set to 'list-item'/title
+
+  link rel=author title=Gérard Talbot href=""
+  link rel=author title=Boris Zbarsky href=""
+  link rel=help title=10.5 Content height: the 'height' property href=""
+  link rel=help title=11.1.1 Overflow: the 'overflow' property href=""
+
+  meta content= name=flags
+  meta content=If height of content exceeds the set height of a block-level non-replaced element in normal flow (like a list-item element such as in this test), then the content should overflow according to the 'overflow' property. name=assert
+
+  style type=text/css
+  div
+  {
+  color: green;
+  display: list-item; 
+  font: 2em/1 serif;
+  margin-left: 1.25em;
+  overflow: visible;
+  }
+  
+  ul
+  {
+  height: auto;
+  margin-top: 1em;
+  overflow: visible;
+  }  
+  
+  li
+  {
+  color: green;
+  font: 2em/1 serif;
+  overflow: visible;
+  }
+  
+  /style
+
+ /head
+
+ body
+
+  pTest passes if strong3 green PASS/strong are each preceded by a filled disc./p
+
+  divPASS/div
+
+  ul
+liPASS/li
+  /ul
+
+  ul
+liPASS/li
+  /ul
+
+ /body
+/html
\ No newline at end of file
Property changes on: trunk/LayoutTests/css2.1/20110323/height-applies-to-010a-expected.html
___


Added: svn:eol-style

Added: trunk/LayoutTests/css2.1/20110323/height-applies-to-010a.htm (0 => 111755)

--- trunk/LayoutTests/css2.1/20110323/height-applies-to-010a.htm	(rev 0)
+++ trunk/LayoutTests/css2.1/20110323/height-applies-to-010a.htm	2012-03-22 20:49:24 UTC (rev 111755)
@@ -0,0 +1,62 @@
+!DOCTYPE html PUBLIC -//W3C//DTD HTML 4.01//EN http://www.w3.org/TR/html4/strict.dtd
+html
+
+ head
+
+  titleCSS Test: height set to 0 to elements with 'display' set to 'list-item'/title
+
+  link rel=author title=Gérard Talbot href=""
+  link rel=author title=Boris Zbarsky href=""
+  link rel=help title=10.5 Content height: the 'height' property href=""
+  link rel=help title=11.1.1 Overflow: the 'overflow' property href=""
+
+  meta content= name=flags
+  meta content=If height of content exceeds the set height of a block-level non-replaced element in normal flow (like a list-item element such as in this test), then the content should overflow according to the 'overflow' property. name=assert
+
+  

[webkit-changes] [111756] trunk

[commit-queue]

Title: [111756] trunk








Revision 111756
Author commit-qu...@webkit.org
Date 2012-03-22 13:51:48 -0700 (Thu, 22 Mar 2012)


Log Message
[EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=81512

Source/WebKit/efl:

Add missing implementation markerTextForListItem to EFL's
DumpRenderTreeSupport.

Patch by Sudarsana Nagineni sudarsana.nagin...@linux.intel.com on 2012-03-22
Reviewed by Antonio Gomes.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::markerTextForListItem):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Adding missing implementation markerTextForListItem to EFL's
LayoutTestController so that we can unskip related tests from
the skip list.

Patch by Sudarsana Nagineni sudarsana.nagin...@linux.intel.com on 2012-03-22
Reviewed by Antonio Gomes.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::markerTextForListItem): Implemented.

LayoutTests:

Unskip tests connected with markerTextForListItem().

Patch by Sudarsana Nagineni sudarsana.nagin...@linux.intel.com on 2012-03-22
Reviewed by Antonio Gomes.

* platform/efl/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp
trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (111755 => 111756)

--- trunk/LayoutTests/ChangeLog	2012-03-22 20:49:24 UTC (rev 111755)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 20:51:48 UTC (rev 111756)
@@ -1,3 +1,14 @@
+2012-03-22  Sudarsana Nagineni  sudarsana.nagin...@linux.intel.com
+
+[EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
+https://bugs.webkit.org/show_bug.cgi?id=81512
+
+Unskip tests connected with markerTextForListItem().
+
+Reviewed by Antonio Gomes.
+
+* platform/efl/Skipped:
+
 2012-03-19  Robert Hogan  rob...@webkit.org
 
 Text should overflow when list item height set to 0


Modified: trunk/LayoutTests/platform/efl/Skipped (111755 => 111756)

--- trunk/LayoutTests/platform/efl/Skipped	2012-03-22 20:49:24 UTC (rev 111755)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-03-22 20:51:48 UTC (rev 111756)
@@ -684,27 +684,6 @@
 # EFL's LayoutTestController does not implement callShouldCloseOnWebView
 fast/events/onbeforeunload-focused-iframe.html
 
-# EFL's LayoutTestController does not implement markerTextForListItem
-fast/lists/alpha-boundary-values.html
-fast/lists/alpha-list-wrap.html
-fast/lists/decimal-leading-zero.html
-fast/lists/li-values.html
-fast/lists/list-style-type-dynamic-change.html
-fast/lists/ol-nested-items-dynamic-insert.html
-fast/lists/ol-nested-items-dynamic-remove.html
-fast/lists/ol-nested-items.html
-fast/lists/ol-nested-list-dynamic-insert.html
-fast/lists/ol-nested-list-dynamic-remove.html
-fast/lists/ol-nested-list.html
-fast/lists/positioned-count-crash.html
-fast/lists/w3-css3-list-styles-alphabetic.html
-fast/lists/w3-css3-list-styles-fallback-style.html
-fast/lists/w3-css3-list-styles-numeric.html
-fast/lists/w3-css3-list-styles-symbolic.html
-fast/lists/w3-css3-lower-armenian.html
-fast/lists/w3-css3-upper-armenian.html
-fast/lists/w3-list-styles.html
-
 # EFL's LayoutTestController does not implement shadowPseudoId
 fullscreen/video-controls-override.html
 media/audio-delete-while-step-button-clicked.html


Modified: trunk/Source/WebKit/efl/ChangeLog (111755 => 111756)

--- trunk/Source/WebKit/efl/ChangeLog	2012-03-22 20:49:24 UTC (rev 111755)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-03-22 20:51:48 UTC (rev 111756)
@@ -1,5 +1,19 @@
 2012-03-22  Sudarsana Nagineni  sudarsana.nagin...@linux.intel.com
 
+[EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
+https://bugs.webkit.org/show_bug.cgi?id=81512
+
+Add missing implementation markerTextForListItem to EFL's 
+DumpRenderTreeSupport.
+
+Reviewed by Antonio Gomes.
+
+* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+(DumpRenderTreeSupportEfl::markerTextForListItem):
+* WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
+2012-03-22  Sudarsana Nagineni  sudarsana.nagin...@linux.intel.com
+
 [EFL] Implement LayoutTestController::setEditingBehavior
 https://bugs.webkit.org/show_bug.cgi?id=81124
 


Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp (111755 => 111756)

--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp	2012-03-22 20:49:24 UTC (rev 111755)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp	2012-03-22 20:51:48 UTC (rev 111756)
@@ -435,3 +435,13 @@
 
 corePage-settings()-setEditingBehaviorType(coreEditingBehavior);
 }
+
+String DumpRenderTreeSupportEfl::markerTextForListItem(JSContextRef context, 

[webkit-changes] [111757] trunk/Source/WebKit/blackberry

[mifenton]

Title: [111757] trunk/Source/WebKit/blackberry








Revision 111757
Author mifen...@rim.com
Date 2012-03-22 13:58:15 -0700 (Thu, 22 Mar 2012)


Log Message
[BlackBerry] DOMSupport isPositionInNode should have early returns for null nodes
https://bugs.webkit.org/show_bug.cgi?id=81929

Reviewed by Rob Buis.

Make suggested style clean up and move int offset = 0 directly
above is actual usage.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isPositionInNode):

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (111756 => 111757)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-03-22 20:51:48 UTC (rev 111756)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-03-22 20:58:15 UTC (rev 111757)
@@ -5,6 +5,19 @@
 
 Reviewed by Rob Buis.
 
+Make suggested style clean up and move int offset = 0 directly
+above is actual usage.
+
+* WebKitSupport/DOMSupport.cpp:
+(BlackBerry::WebKit::DOMSupport::isPositionInNode):
+
+2012-03-22  Mike Fenton  mifen...@rim.com
+
+[BlackBerry] DOMSupport isPositionInNode should have early returns for null nodes
+https://bugs.webkit.org/show_bug.cgi?id=81929
+
+Reviewed by Rob Buis.
+
 Add early returns in isPositionInNode when either
 node or the position node is null.
 


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp (111756 => 111757)

--- trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp	2012-03-22 20:51:48 UTC (rev 111756)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp	2012-03-22 20:58:15 UTC (rev 111757)
@@ -296,11 +296,11 @@
 if (!node)
 return false;
 
-int offset = 0;
 Node* domNodeAtPos = DOMContainerNodeForPosition(position);
 if (!domNodeAtPos)
 return false;
 
+int offset = 0;
 if (domNodeAtPos == position.containerNode())
 offset = position.computeOffsetInContainerNode();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111758] branches/chromium/1025

[kareng]

Title: [111758] branches/chromium/1025








Revision 111758
Author kar...@chromium.org
Date 2012-03-22 14:01:56 -0700 (Thu, 22 Mar 2012)


Log Message
Revert 104848 - [chromium] Re-enable Skia feColorMatrix filter implementation.
https://bugs.webkit.org/show_bug.cgi?id=76186

Source/WebCore:

This code was landed in http://trac.webkit.org/changeset/104566 and
partially reverted in http://trac.webkit.org/changeset/104632 due
to problems with the Windows Shared builder.  Those problems have
been fixed in r3006, since rolled into Chrome.

Reviewed by Kenneth Russell.

Covered by SVG feColorMatrix tests.

* WebCore.gypi:
* platform/graphics/filters/FEColorMatrix.h:

LayoutTests:

Remove suppressions for tests which now pass.

Reviewed by Kenneth Russell.

* platform/chromium/test_expectations.txt:


TBR=senorbla...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9836018

Modified Paths

branches/chromium/1025/LayoutTests/platform/chromium/test_expectations.txt
branches/chromium/1025/Source/WebCore/WebCore.gypi
branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEColorMatrix.h




Diff

Modified: branches/chromium/1025/LayoutTests/platform/chromium/test_expectations.txt (111757 => 111758)

--- branches/chromium/1025/LayoutTests/platform/chromium/test_expectations.txt	2012-03-22 20:58:15 UTC (rev 111757)
+++ branches/chromium/1025/LayoutTests/platform/chromium/test_expectations.txt	2012-03-22 21:01:56 UTC (rev 111758)
@@ -959,6 +959,15 @@
 BUGWK62974 : svg/custom/svg-fonts-with-no-element-reference.html = IMAGE+TEXT IMAGE
 BUGWK62974 MAC : svg/W3C-SVG-1.1/pservers-grad-08-b.svg = IMAGE
 
+BUGSENORBLANCO : svg/W3C-SVG-1.1/filters-color-01-b.svg = FAIL
+BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr.html = FAIL
+BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr.html = FAIL
+BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr.html = FAIL
+BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop.html = FAIL
+
+BUGSENORBLANCO : svg/filters/feColorMatrix-offset.svg = FAIL
+BUGSENORBLANCO : svg/filters/feColorMatrix-saturate.svg = FAIL
+
 // -
 // End SVG Regressions
 // -


Modified: branches/chromium/1025/Source/WebCore/WebCore.gypi (111757 => 111758)

--- branches/chromium/1025/Source/WebCore/WebCore.gypi	2012-03-22 20:58:15 UTC (rev 111757)
+++ branches/chromium/1025/Source/WebCore/WebCore.gypi	2012-03-22 21:01:56 UTC (rev 111758)
@@ -3383,7 +3383,6 @@
 'platform/graphics/filters/arm/FEGaussianBlurNEON.h',
 'platform/graphics/filters/arm/FELightingNEON.cpp',
 'platform/graphics/filters/arm/FELightingNEON.h',
-'platform/graphics/filters/skia/FEColorMatrixSkia.cpp',
 'platform/graphics/filters/skia/FEGaussianBlurSkia.cpp',
 'platform/graphics/freetype/FontCacheFreeType.cpp',
 'platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp',


Modified: branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEColorMatrix.h (111757 => 111758)

--- branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEColorMatrix.h	2012-03-22 20:58:15 UTC (rev 111757)
+++ branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEColorMatrix.h	2012-03-22 21:01:56 UTC (rev 111758)
@@ -49,9 +49,6 @@
 bool setValues(const Vectorfloat);
 
 virtual void platformApplySoftware();
-#if USE(SKIA)
-virtual bool platformApplySkia();
-#endif
 virtual void dump();
 
 virtual TextStream externalRepresentation(TextStream, int indention) const;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111759] branches/chromium/1025

[kareng]

Title: [111759] branches/chromium/1025








Revision 111759
Author kar...@chromium.org
Date 2012-03-22 14:06:30 -0700 (Thu, 22 Mar 2012)


Log Message
Revert 104632 - Source/WebCore: [Chromium] Partial revert of r104566, since it breaks the shared
library build on Windows.
https://bugs.webkit.org/show_bug.cgi?id=75994

Reviewed by Dmitry Titov.

Covered by SVG feColorMatrix tests (see LayoutTests/ChangeLog).

* WebCore.gypi:
* platform/graphics/filters/FEColorMatrix.h:

LayoutTests: Suppress failures caused by partial revert of r104566.
https://bugs.webkit.org/show_bug.cgi?id=75994

Reviewed by Dmitry Titov.

* platform/chromium/test_expectations.txt:


TBR=senorbla...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9835025

Modified Paths

branches/chromium/1025/LayoutTests/platform/chromium/test_expectations.txt
branches/chromium/1025/Source/WebCore/WebCore.gypi
branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEColorMatrix.h




Diff

Modified: branches/chromium/1025/LayoutTests/platform/chromium/test_expectations.txt (111758 => 111759)

--- branches/chromium/1025/LayoutTests/platform/chromium/test_expectations.txt	2012-03-22 21:01:56 UTC (rev 111758)
+++ branches/chromium/1025/LayoutTests/platform/chromium/test_expectations.txt	2012-03-22 21:06:30 UTC (rev 111759)
@@ -959,15 +959,6 @@
 BUGWK62974 : svg/custom/svg-fonts-with-no-element-reference.html = IMAGE+TEXT IMAGE
 BUGWK62974 MAC : svg/W3C-SVG-1.1/pservers-grad-08-b.svg = IMAGE
 
-BUGSENORBLANCO : svg/W3C-SVG-1.1/filters-color-01-b.svg = FAIL
-BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr.html = FAIL
-BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr.html = FAIL
-BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr.html = FAIL
-BUGSENORBLANCO : svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop.html = FAIL
-
-BUGSENORBLANCO : svg/filters/feColorMatrix-offset.svg = FAIL
-BUGSENORBLANCO : svg/filters/feColorMatrix-saturate.svg = FAIL
-
 // -
 // End SVG Regressions
 // -


Modified: branches/chromium/1025/Source/WebCore/WebCore.gypi (111758 => 111759)

--- branches/chromium/1025/Source/WebCore/WebCore.gypi	2012-03-22 21:01:56 UTC (rev 111758)
+++ branches/chromium/1025/Source/WebCore/WebCore.gypi	2012-03-22 21:06:30 UTC (rev 111759)
@@ -3383,6 +3383,7 @@
 'platform/graphics/filters/arm/FEGaussianBlurNEON.h',
 'platform/graphics/filters/arm/FELightingNEON.cpp',
 'platform/graphics/filters/arm/FELightingNEON.h',
+'platform/graphics/filters/skia/FEColorMatrixSkia.cpp',
 'platform/graphics/filters/skia/FEGaussianBlurSkia.cpp',
 'platform/graphics/freetype/FontCacheFreeType.cpp',
 'platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp',


Modified: branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEColorMatrix.h (111758 => 111759)

--- branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEColorMatrix.h	2012-03-22 21:01:56 UTC (rev 111758)
+++ branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEColorMatrix.h	2012-03-22 21:06:30 UTC (rev 111759)
@@ -49,6 +49,9 @@
 bool setValues(const Vectorfloat);
 
 virtual void platformApplySoftware();
+#if USE(SKIA)
+virtual bool platformApplySkia();
+#endif
 virtual void dump();
 
 virtual TextStream externalRepresentation(TextStream, int indention) const;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111760] branches/chromium/1025/Source/WebCore

[kareng]

Title: [111760] branches/chromium/1025/Source/WebCore








Revision 111760
Author kar...@chromium.org
Date 2012-03-22 14:09:20 -0700 (Thu, 22 Mar 2012)


Log Message
Revert 104566 - Source/WebCore: [Skia] Switch FEColorMatrix to use a skia-based implementation when
compiling with USE(SKIA).  This change will also switch the software
implementation of FEGaussianBlur to the skia implementation (ie.,
it removes the acceleration check).
https://bugs.webkit.org/show_bug.cgi?id=75582

Reviewed by Dirk Schulze.

Covered by svg/W3C-SVG-1.1/filters-color-01-b.svg and friends (will
need a rebaseline).

* WebCore.gypi:
Add FEColorMatrixSkia.cpp to the build.
* platform/graphics/filters/FEColorMatrix.h:
Add platformApplySkia().
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplySoftware):
Remove skia-specific code from FEGaussianBlur::platformApplySoftware().
* platform/graphics/filters/FEGaussianBlur.h:
Make platformApplySkia() virtual, and put it behind #if USE(SKIA).
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::apply):
Call out to platformApplySkia(), or fall back to
platformApplySoftware().
* platform/graphics/filters/FilterEffect.h:
Add platformApplySkia().
* platform/graphics/filters/skia/FEColorMatrixSkia.cpp: Added.
(WebCore::saturateMatrix):
(WebCore::hueRotateMatrix):
(WebCore::luminanceToAlphaMatrix):
(WebCore::FEColorMatrix::platformApplySkia):
Process color matrix effect, by calling out to generic matrix
version of SkColorMatrixFilter.
* platform/graphics/filters/skia/FEGaussianBlurSkia.cpp:
(WebCore::FEGaussianBlur::platformApplySkia):
Change the signature of FEGaussianBlur::platformApplySkia to be an
override of the new FilterEffect base class version.

LayoutTests: [chomium] Mark svg FEColorMatrix tests as needing new baselines.
https://bugs.webkit.org/show_bug.cgi?id=75582

Reviewed by Dirk Schulze.

* platform/chromium/test_expectations.txt:


TBR=senorbla...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9837019

Modified Paths

branches/chromium/1025/Source/WebCore/WebCore.gypi
branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEColorMatrix.h
branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp
branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h
branches/chromium/1025/Source/WebCore/platform/graphics/filters/FilterEffect.cpp
branches/chromium/1025/Source/WebCore/platform/graphics/filters/FilterEffect.h
branches/chromium/1025/Source/WebCore/platform/graphics/filters/skia/FEGaussianBlurSkia.cpp




Diff

Modified: branches/chromium/1025/Source/WebCore/WebCore.gypi (111759 => 111760)

--- branches/chromium/1025/Source/WebCore/WebCore.gypi	2012-03-22 21:06:30 UTC (rev 111759)
+++ branches/chromium/1025/Source/WebCore/WebCore.gypi	2012-03-22 21:09:20 UTC (rev 111760)
@@ -3383,7 +3383,6 @@
 'platform/graphics/filters/arm/FEGaussianBlurNEON.h',
 'platform/graphics/filters/arm/FELightingNEON.cpp',
 'platform/graphics/filters/arm/FELightingNEON.h',
-'platform/graphics/filters/skia/FEColorMatrixSkia.cpp',
 'platform/graphics/filters/skia/FEGaussianBlurSkia.cpp',
 'platform/graphics/freetype/FontCacheFreeType.cpp',
 'platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp',


Modified: branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEColorMatrix.h (111759 => 111760)

--- branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEColorMatrix.h	2012-03-22 21:06:30 UTC (rev 111759)
+++ branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEColorMatrix.h	2012-03-22 21:09:20 UTC (rev 111760)
@@ -49,9 +49,6 @@
 bool setValues(const Vectorfloat);
 
 virtual void platformApplySoftware();
-#if USE(SKIA)
-virtual bool platformApplySkia();
-#endif
 virtual void dump();
 
 virtual TextStream externalRepresentation(TextStream, int indention) const;


Modified: branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp (111759 => 111760)

--- branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp	2012-03-22 21:06:30 UTC (rev 111759)
+++ branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp	2012-03-22 21:09:20 UTC (rev 111760)
@@ -273,6 +273,13 @@
 
 void FEGaussianBlur::platformApplySoftware()
 {
+#if USE(SKIA)
+if (filter()-renderingMode() == Accelerated) {
+platformApplySkia();
+return;
+}
+#endif
+
 FilterEffect* in = inputEffect(0);
 
 ByteArray* srcPixelArray = createPremultipliedImageResult();


Modified: branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h (111759 => 111760)

--- branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h	2012-03-22 21:06:30 UTC (rev 111759)
+++ branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h	

[webkit-changes] [111761] trunk/LayoutTests

[mitz]

Title: [111761] trunk/LayoutTests








Revision 111761
Author m...@apple.com
Date 2012-03-22 14:10:52 -0700 (Thu, 22 Mar 2012)


Log Message
Added fast/events/suspend-timers.html to the Mac WebKit2 skipped list, and removed the
failing results checked in as expected results. The results vary across runs.

* platform/mac-wk2/Skipped:
* platform/mac-wk2/fast/events: Removed.
* platform/mac-wk2/fast/events/suspend-timers-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/Skipped


Removed Paths

trunk/LayoutTests/platform/mac-wk2/fast/events/




Diff

Modified: trunk/LayoutTests/ChangeLog (111760 => 111761)

--- trunk/LayoutTests/ChangeLog	2012-03-22 21:09:20 UTC (rev 111760)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 21:10:52 UTC (rev 111761)
@@ -1,3 +1,12 @@
+2012-03-22  Dan Bernstein  m...@apple.com
+
+Added fast/events/suspend-timers.html to the Mac WebKit2 skipped list, and removed the
+failing results checked in as expected results. The results vary across runs.
+
+* platform/mac-wk2/Skipped:
+* platform/mac-wk2/fast/events: Removed.
+* platform/mac-wk2/fast/events/suspend-timers-expected.txt: Removed.
+
 2012-03-22  Sudarsana Nagineni  sudarsana.nagin...@linux.intel.com
 
 [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()


Modified: trunk/LayoutTests/platform/mac-wk2/Skipped (111760 => 111761)

--- trunk/LayoutTests/platform/mac-wk2/Skipped	2012-03-22 21:09:20 UTC (rev 111760)
+++ trunk/LayoutTests/platform/mac-wk2/Skipped	2012-03-22 21:10:52 UTC (rev 111761)
@@ -247,6 +247,10 @@
 # https://bugs.webkit.org/show_bug.cgi?id=81833
 fast/events/drag-link.html
 
+# fast/events/suspend-timers.html is failing in Mac WebKit2, even though LayoutTestController.overridePreference is implemented in WebKitTestRunner
+# https://bugs.webkit.org/show_bug.cgi?id=81945
+fast/events/suspend-timers.html
+
 ### END OF (1) Classified failures with bug reports
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111762] trunk/Source

[andersca]

Title: [111762] trunk/Source








Revision 111762
Author ander...@apple.com
Date 2012-03-22 14:14:49 -0700 (Thu, 22 Mar 2012)


Log Message
ASSERT(!needsLayout) in RenderView.cpp when visiting http://www.panic.com/blog/
https://bugs.webkit.org/show_bug.cgi?id=81953
rdar://problem/11086998

Reviewed by Sam Weinig.

Source/WebCore:

If a page ends up creating CATiledLayers, CA transactions can be committed outside of the normal
CA run loop observer, so we can't call setNeedsDisplay on tile cache layers directly because then
we'll end up calling into painting code before all the layers have been flushed.

Fix this by adding a list of dirty rects to platformCALayerDidCreateTiles and change GraphicsLayerCA to
mark them as dirty. This ensures that any CA transaction commits won't cause newly added layers to be painted.

* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::LayerClient::platformCALayerDidCreateTiles):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
* platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
* platform/graphics/ca/PlatformCALayerClient.h:
(PlatformCALayerClient):
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setScale):
(WebCore::TileCache::revalidateTiles):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerDidCreateTiles):

Source/WebKit/win:

Update for changes to WebCore.

* FullscreenVideoController.cpp:
(FullscreenVideoController::LayerClient::platformCALayerDidCreateTiles):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
trunk/Source/WebCore/platform/graphics/ca/PlatformCALayerClient.h
trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm
trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/FullscreenVideoController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (111761 => 111762)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 21:10:52 UTC (rev 111761)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 21:14:49 UTC (rev 111762)
@@ -1,3 +1,32 @@
+2012-03-22  Anders Carlsson  ander...@apple.com
+
+ASSERT(!needsLayout) in RenderView.cpp when visiting http://www.panic.com/blog/
+https://bugs.webkit.org/show_bug.cgi?id=81953
+rdar://problem/11086998
+
+Reviewed by Sam Weinig.
+
+If a page ends up creating CATiledLayers, CA transactions can be committed outside of the normal
+CA run loop observer, so we can't call setNeedsDisplay on tile cache layers directly because then
+we'll end up calling into painting code before all the layers have been flushed.
+
+Fix this by adding a list of dirty rects to platformCALayerDidCreateTiles and change GraphicsLayerCA to
+mark them as dirty. This ensures that any CA transaction commits won't cause newly added layers to be painted.
+
+* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
+(WebCore::LayerClient::platformCALayerDidCreateTiles):
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+(WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
+* platform/graphics/ca/GraphicsLayerCA.h:
+(GraphicsLayerCA):
+* platform/graphics/ca/PlatformCALayerClient.h:
+(PlatformCALayerClient):
+* platform/graphics/ca/mac/TileCache.mm:
+(WebCore::TileCache::setScale):
+(WebCore::TileCache::revalidateTiles):
+* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
+(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerDidCreateTiles):
+
 2012-03-19  Robert Hogan  rob...@webkit.org
 
 Text should overflow when list item height set to 0


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp (111761 => 111762)

--- trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp	2012-03-22 21:10:52 UTC (rev 111761)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp	2012-03-22 21:14:49 UTC (rev 111762)
@@ -160,7 +160,7 @@
 virtual bool platformCALayerContentsOpaque() const { return false; }
 virtual bool platformCALayerDrawsContent() const { return false; }
 virtual void platformCALayerLayerDidDisplay(PlatformLayer*) { }
-virtual void platformCALayerDidCreateTiles() { }
+virtual void platformCALayerDidCreateTiles(const VectorFloatRect) { }
 virtual float platformCALayerDeviceScaleFactor() { return 1; }
 
 AVFWrapper* m_parent;


Modified: 

[webkit-changes] [111763] branches/chromium/1025/Source/WebCore

[kareng]

Title: [111763] branches/chromium/1025/Source/WebCore








Revision 111763
Author kar...@chromium.org
Date 2012-03-22 14:15:41 -0700 (Thu, 22 Mar 2012)


Log Message
Revert 102385 - Use Skia's implementation of Gaussian blur when accelerated filters
are enabled.
https://bugs.webkit.org/show_bug.cgi?id=73949

Reviewed by Zoltan Herczeg.

In the future, this will be covered by the SVG tests run in GPU mode.

* WebCore.gypi:
Add FEGaussianBlurSkia.cpp to the build.
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplySoftware):
Call out to platformApplySkia() when USE_SKIA is enabled.
* platform/graphics/filters/FEGaussianBlur.h:
platformApplySkia() declaration.
* platform/graphics/filters/skia: Added.
* platform/graphics/filters/skia/FEGaussianBlurSkia.cpp: Added.
(WebCore::FEGaussianBlur::platformApplySkia):
On the Skia port, use SkBlurImageFilter for drawing
Gaussian blurs in accelerated mode.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::copyImage):
Implement ImageBuffer::copyImage() with DontCopyBackingStore semantics.


TBR=senorbla...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9839023

Modified Paths

branches/chromium/1025/Source/WebCore/WebCore.gypi
branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp
branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h
branches/chromium/1025/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp




Diff

Modified: branches/chromium/1025/Source/WebCore/WebCore.gypi (111762 => 111763)

--- branches/chromium/1025/Source/WebCore/WebCore.gypi	2012-03-22 21:14:49 UTC (rev 111762)
+++ branches/chromium/1025/Source/WebCore/WebCore.gypi	2012-03-22 21:15:41 UTC (rev 111763)
@@ -3383,7 +3383,6 @@
 'platform/graphics/filters/arm/FEGaussianBlurNEON.h',
 'platform/graphics/filters/arm/FELightingNEON.cpp',
 'platform/graphics/filters/arm/FELightingNEON.h',
-'platform/graphics/filters/skia/FEGaussianBlurSkia.cpp',
 'platform/graphics/freetype/FontCacheFreeType.cpp',
 'platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp',
 'platform/graphics/freetype/FontPlatformData.h',


Modified: branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp (111762 => 111763)

--- branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp	2012-03-22 21:14:49 UTC (rev 111762)
+++ branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp	2012-03-22 21:15:41 UTC (rev 111763)
@@ -273,13 +273,6 @@
 
 void FEGaussianBlur::platformApplySoftware()
 {
-#if USE(SKIA)
-if (filter()-renderingMode() == Accelerated) {
-platformApplySkia();
-return;
-}
-#endif
-
 FilterEffect* in = inputEffect(0);
 
 ByteArray* srcPixelArray = createPremultipliedImageResult();


Modified: branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h (111762 => 111763)

--- branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h	2012-03-22 21:14:49 UTC (rev 111762)
+++ branches/chromium/1025/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h	2012-03-22 21:15:41 UTC (rev 111763)
@@ -74,7 +74,6 @@
 
 inline void platformApplyGeneric(ByteArray* srcPixelArray, ByteArray* tmpPixelArray, unsigned kernelSizeX, unsigned kernelSizeY, IntSize paintSize);
 inline void platformApplyNeon(ByteArray* srcPixelArray, ByteArray* tmpPixelArray, unsigned kernelSizeX, unsigned kernelSizeY, IntSize paintSize);
-void platformApplySkia();
 
 float m_stdX;
 float m_stdY;


Modified: branches/chromium/1025/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp (111762 => 111763)

--- branches/chromium/1025/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp	2012-03-22 21:14:49 UTC (rev 111762)
+++ branches/chromium/1025/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp	2012-03-22 21:15:41 UTC (rev 111763)
@@ -152,7 +152,8 @@
 
 PassRefPtrImage ImageBuffer::copyImage(BackingStoreCopy copyBehavior) const
 {
-return BitmapImageSingleFrameSkia::create(*m_data.m_platformContext.bitmap(), copyBehavior == CopyBackingStore);
+ASSERT(copyBehavior == CopyBackingStore);
+return BitmapImageSingleFrameSkia::create(*m_data.m_platformContext.bitmap(), true);
 }
 
 PlatformLayer* ImageBuffer::platformLayer() const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111764] trunk/Source/WebCore

[eae]

Title: [111764] trunk/Source/WebCore








Revision 111764
Author e...@chromium.org
Date 2012-03-22 14:19:08 -0700 (Thu, 22 Mar 2012)


Log Message
Unreviewed, add missing import.

* rendering/RenderThemeMac.mm:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (111763 => 111764)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 21:15:41 UTC (rev 111763)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 21:19:08 UTC (rev 111764)
@@ -1,3 +1,9 @@
+2012-03-22  Emil A Eklund  e...@chromium.org
+
+Unreviewed, add missing import.
+
+* rendering/RenderThemeMac.mm:
+
 2012-03-22  Anders Carlsson  ander...@apple.com
 
 ASSERT(!needsLayout) in RenderView.cpp when visiting http://www.panic.com/blog/


Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (111763 => 111764)

--- trunk/Source/WebCore/rendering/RenderThemeMac.mm	2012-03-22 21:15:41 UTC (rev 111763)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm	2012-03-22 21:19:08 UTC (rev 111764)
@@ -23,6 +23,7 @@
 #import BitmapImage.h
 #import ColorMac.h
 #import CSSStyleSelector.h
+#import CSSValueList.h
 #import CSSValueKeywords.h
 #import Document.h
 #import Element.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111765] trunk/Tools

[dpranke]

Title: [111765] trunk/Tools








Revision 111765
Author dpra...@chromium.org
Date 2012-03-22 14:24:28 -0700 (Thu, 22 Mar 2012)


Log Message
new-run-webkit-tests blames the wrong test for crashing
https://bugs.webkit.org/show_bug.cgi?id=81951

Reviewed by Adam Barth.

NRWT wasn't extracting the WebProcess pid correct; should've
used re.search instead of re.match :(. Add more tests!

* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._get_crash_log):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(WebKitDriverTest.test_no_timeout):
(WebKitDriverTest):
(WebKitDriverTest.test_check_for_driver_crash):
(WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess):
(WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
(WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
(WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.name):
(WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
(WebKitDriverTest.test_check_for_driver_crash.assert_crash):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (111764 => 111765)

--- trunk/Tools/ChangeLog	2012-03-22 21:19:08 UTC (rev 111764)
+++ trunk/Tools/ChangeLog	2012-03-22 21:24:28 UTC (rev 111765)
@@ -1,3 +1,29 @@
+2012-03-22  Dirk Pranke  dpra...@chromium.org
+
+new-run-webkit-tests blames the wrong test for crashing
+https://bugs.webkit.org/show_bug.cgi?id=81951
+
+Reviewed by Adam Barth.
+
+NRWT wasn't extracting the WebProcess pid correct; should've
+used re.search instead of re.match :(. Add more tests!
+
+* Scripts/webkitpy/layout_tests/port/mac.py:
+(MacPort._get_crash_log):
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitDriver.has_crashed):
+(WebKitDriver._check_for_driver_crash):
+* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
+(WebKitDriverTest.test_no_timeout):
+(WebKitDriverTest):
+(WebKitDriverTest.test_check_for_driver_crash):
+(WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess):
+(WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
+(WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
+(WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.name):
+(WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
+(WebKitDriverTest.test_check_for_driver_crash.assert_crash):
+
 2012-03-22  Sudarsana Nagineni  sudarsana.nagin...@linux.intel.com
 
 [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py (111764 => 111765)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py	2012-03-22 21:19:08 UTC (rev 111764)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py	2012-03-22 21:24:28 UTC (rev 111765)
@@ -166,6 +166,8 @@
 crash_log = ''
 crash_logs = CrashLogs(self._filesystem)
 now = time.time()
+# FIXME: delete this after we're sure this code is working ...
+_log.debug('looking for crash log for %s:%s' % (name, str(pid)))
 deadline = now + 5 * int(self.get_option('child_processes'))
 while not crash_log and now = deadline:
 crash_log = crash_logs.find_newest_log(name, pid, include_errors=True)


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (111764 => 111765)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-03-22 21:19:08 UTC (rev 111764)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-03-22 21:24:28 UTC (rev 111765)
@@ -497,6 +497,7 @@
 self._crashed_process_name = self._server_process.name()
 self._crashed_pid = self._server_process.pid()
 return True
+return False
 
 def _check_for_driver_crash(self, error_line):
 if error_line == #CRASHED\n:
@@ -507,11 +508,13 @@
 elif error_line.startswith(#CRASHED - WebProcess):
 # WebKitTestRunner uses this to report that the WebProcess subprocess crashed.
 pid = None
-m = re.match('pid (\d+)', error_line)
+m = re.search('pid (\d+)', error_line)
 if m:
 pid = int(m.group(1))
 self._crashed_process_name = 'WebProcess'
 self._crashed_pid = pid
+# FIXME: delete this after we're sure this code is working :)
+_log.debug('WebProcess crash, pid = %s, error_line = %s' % (str(pid), error_line))
 return True
 return self.has_crashed()
 


Modified: 

[webkit-changes] [111766] trunk/LayoutTests

[robert]

Title: [111766] trunk/LayoutTests








Revision 111766
Author rob...@webkit.org
Date 2012-03-22 14:27:33 -0700 (Thu, 22 Mar 2012)


Log Message
Make reference result added in r111755 compatible with Qt and GTK ports.

Unreviewed.

* fast/css/heightless-list-item-expected.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/heightless-list-item-expected.html




Diff

Modified: trunk/LayoutTests/ChangeLog (111765 => 111766)

--- trunk/LayoutTests/ChangeLog	2012-03-22 21:24:28 UTC (rev 111765)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 21:27:33 UTC (rev 111766)
@@ -1,3 +1,11 @@
+2012-03-22  Robert Hogan  rob...@webkit.org
+
+Make reference result added in r111755 compatible with Qt and GTK ports.
+
+Unreviewed.
+
+* fast/css/heightless-list-item-expected.html:
+
 2012-03-22  Dan Bernstein  m...@apple.com
 
 Added fast/events/suspend-timers.html to the Mac WebKit2 skipped list, and removed the


Modified: trunk/LayoutTests/fast/css/heightless-list-item-expected.html (111765 => 111766)

--- trunk/LayoutTests/fast/css/heightless-list-item-expected.html	2012-03-22 21:24:28 UTC (rev 111765)
+++ trunk/LayoutTests/fast/css/heightless-list-item-expected.html	2012-03-22 21:27:33 UTC (rev 111766)
@@ -64,28 +64,5 @@
   !--Inline content in div with display: list-item, overflow-y: hidden and height:0 does not get painted--
   div id=heightzerolistitem style=overflow-y:hidden;PASS/div
 
-  !--Inline content in list-item with overflow-y: hidden and height:0 does not get painted--
-  ul
-li id=yhiddenPASS/li
-  /ul
-
-  !--Block content in list-item with overflow-y: hidden and height:0 does not get painted--
-  ul
-li id=yhiddendivPASS/div/li
-  /ul
-
-  !--Inline content in div with display: list-item, overflow-x: hidden and height:0 does not get painted--
-  div id=heightzerolistitem style=overflow-x:hidden;PASS/div
-
-  !--Inline content in list-item with overflow-x: hidden and height:0 does not get painted--
-  ul
-li id=xhiddenPASS/li
-  /ul
-
-  !--Block content in list-item with overflow-x: hidden and height:0 does not get painted--
-  ul
-li id=xhiddendivPASS/div/li
-  /ul
- 
   /body
 /html
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111767] trunk

[tony]

Title: [111767] trunk








Revision 111767
Author t...@chromium.org
Date 2012-03-22 14:45:58 -0700 (Thu, 22 Mar 2012)


Log Message
flexbox flexing implementation should match the spec
https://bugs.webkit.org/show_bug.cgi?id=70796

Reviewed by Ojan Vafai.

Source/WebCore:

Match the algorithm in the spec. Handling min/max constraints are slightly improved.
http://dev.w3.org/csswg/css3-flexbox/#resolve-the-flexible-lengths

New test cases in css3/flexbox/flex-algorithm-min-max.html.

* rendering/RenderFlexibleBox.cpp:
(WebCore::adjustFlexSizeForMinAndMax): Step 5 of resolving flexible lengths.
(WebCore):
(WebCore::RenderFlexibleBox::Violation::Violation):
(RenderFlexibleBox::Violation):
(WebCore::RenderFlexibleBox::freezeViolations): Used by step 6.
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
* rendering/RenderFlexibleBox.h:

LayoutTests:

* css3/flexbox/flex-algorithm-min-max-expected.txt:
* css3/flexbox/flex-algorithm-min-max.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/flexbox/flex-algorithm-min-max-expected.txt
trunk/LayoutTests/css3/flexbox/flex-algorithm-min-max.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.h




Diff

Modified: trunk/LayoutTests/ChangeLog (111766 => 111767)

--- trunk/LayoutTests/ChangeLog	2012-03-22 21:27:33 UTC (rev 111766)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 21:45:58 UTC (rev 111767)
@@ -1,3 +1,13 @@
+2012-03-22  Tony Chang  t...@chromium.org
+
+flexbox flexing implementation should match the spec
+https://bugs.webkit.org/show_bug.cgi?id=70796
+
+Reviewed by Ojan Vafai.
+
+* css3/flexbox/flex-algorithm-min-max-expected.txt:
+* css3/flexbox/flex-algorithm-min-max.html:
+
 2012-03-22  Robert Hogan  rob...@webkit.org
 
 Make reference result added in r111755 compatible with Qt and GTK ports.


Modified: trunk/LayoutTests/css3/flexbox/flex-algorithm-min-max-expected.txt (111766 => 111767)

--- trunk/LayoutTests/css3/flexbox/flex-algorithm-min-max-expected.txt	2012-03-22 21:27:33 UTC (rev 111766)
+++ trunk/LayoutTests/css3/flexbox/flex-algorithm-min-max-expected.txt	2012-03-22 21:45:58 UTC (rev 111767)
@@ -5,3 +5,8 @@
 PASS
 PASS
 PASS
+PASS
+PASS
+PASS
+PASS
+PASS


Modified: trunk/LayoutTests/css3/flexbox/flex-algorithm-min-max.html (111766 => 111767)

--- trunk/LayoutTests/css3/flexbox/flex-algorithm-min-max.html	2012-03-22 21:27:33 UTC (rev 111766)
+++ trunk/LayoutTests/css3/flexbox/flex-algorithm-min-max.html	2012-03-22 21:45:58 UTC (rev 111767)
@@ -75,5 +75,31 @@
   div data-expected-width=100 style=width: -webkit-flex(1 0 50%); max-width: 100px/div
 /div
 
+div class=flexbox style=width: 200px
+  div data-expected-width=150 style=width: -webkit-flex(1); min-width: 150px/div
+  div data-expected-width=50 style=width: -webkit-flex(1); max-width: 90px/div
+/div
+
+div class=flexbox style=width: 200px
+  div data-expected-width=150 style=width: -webkit-flex(1); min-width: 120px/div
+  div data-expected-width=50 style=width: -webkit-flex(1); max-width: 50px/div
+/div
+
+div class=flexbox style=width: 200px
+  div data-expected-width=100 style=width: -webkit-flex(1); min-width: 100px/div
+  div data-expected-width=100 style=width: -webkit-flex(3);/div
+/div
+
+div class=flexbox style=width: 200px
+  div data-expected-width=150 style=width: -webkit-flex(1 50px); min-width: 100px/div
+  div data-expected-width=50 style=width: -webkit-flex(1 100px); max-width: 50px/div
+/div
+
+div class=flexbox
+  div data-expected-width=80 style=width: -webkit-flex(1)/div
+  div data-expected-width=160 style=width: -webkit-flex(2)/div
+  div data-expected-width=360 style=width: -webkit-flex(1); min-width: 360px/div
+/div
+
 /body
 /html


Modified: trunk/Source/WebCore/ChangeLog (111766 => 111767)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 21:27:33 UTC (rev 111766)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 21:45:58 UTC (rev 111767)
@@ -1,3 +1,24 @@
+2012-03-22  Tony Chang  t...@chromium.org
+
+flexbox flexing implementation should match the spec
+https://bugs.webkit.org/show_bug.cgi?id=70796
+
+Reviewed by Ojan Vafai.
+
+Match the algorithm in the spec. Handling min/max constraints are slightly improved.
+http://dev.w3.org/csswg/css3-flexbox/#resolve-the-flexible-lengths
+
+New test cases in css3/flexbox/flex-algorithm-min-max.html.
+
+* rendering/RenderFlexibleBox.cpp:
+(WebCore::adjustFlexSizeForMinAndMax): Step 5 of resolving flexible lengths.
+(WebCore):
+(WebCore::RenderFlexibleBox::Violation::Violation):
+(RenderFlexibleBox::Violation):
+(WebCore::RenderFlexibleBox::freezeViolations): Used by step 6.
+(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
+* rendering/RenderFlexibleBox.h:
+
 2012-03-22  Emil A Eklund  e...@chromium.org
 
 Unreviewed, add missing import.


Modified: 

[webkit-changes] [111768] trunk/Source/WebCore

[eae]

Title: [111768] trunk/Source/WebCore








Revision 111768
Author e...@chromium.org
Date 2012-03-22 14:53:05 -0700 (Thu, 22 Mar 2012)


Log Message
Unreviewed, add missing include statement for CSSValueList.h.

* css/CSSStyleSelector.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (111767 => 111768)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 21:45:58 UTC (rev 111767)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 21:53:05 UTC (rev 111768)
@@ -1,3 +1,9 @@
+2012-03-22  Emil A Eklund  e...@chromium.org
+
+Unreviewed, add missing include statement for CSSValueList.h.
+
+* css/CSSStyleSelector.h:
+
 2012-03-22  Tony Chang  t...@chromium.org
 
 flexbox flexing implementation should match the spec


Modified: trunk/Source/WebCore/css/CSSStyleSelector.h (111767 => 111768)

--- trunk/Source/WebCore/css/CSSStyleSelector.h	2012-03-22 21:45:58 UTC (rev 111767)
+++ trunk/Source/WebCore/css/CSSStyleSelector.h	2012-03-22 21:53:05 UTC (rev 111768)
@@ -23,6 +23,7 @@
 #define CSSStyleSelector_h
 
 #include CSSRule.h
+#include CSSValueList.h
 #include LinkHash.h
 #include MediaQueryExp.h
 #include RenderStyle.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111769] trunk

[commit-queue]

Title: [111769] trunk








Revision 111769
Author commit-qu...@webkit.org
Date 2012-03-22 15:01:39 -0700 (Thu, 22 Mar 2012)


Log Message
OLD_COMPILE_FLAGS was set incorrectly in WebKitHelpers.cmake
https://bugs.webkit.org/show_bug.cgi?id=81961

Patch by Ming Xie m...@rim.com on 2012-03-22
Reviewed by Rob Buis.

This fixes the regression introduced by r109292

* Source/cmake/WebKitHelpers.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/WebKitHelpers.cmake




Diff

Modified: trunk/ChangeLog (111768 => 111769)

--- trunk/ChangeLog	2012-03-22 21:53:05 UTC (rev 111768)
+++ trunk/ChangeLog	2012-03-22 22:01:39 UTC (rev 111769)
@@ -1,3 +1,14 @@
+2012-03-22  Ming Xie  m...@rim.com
+
+OLD_COMPILE_FLAGS was set incorrectly in WebKitHelpers.cmake
+https://bugs.webkit.org/show_bug.cgi?id=81961
+
+Reviewed by Rob Buis.
+
+This fixes the regression introduced by r109292
+
+* Source/cmake/WebKitHelpers.cmake:
+
 2012-03-22  Dave Michael  dmich...@chromium.org
 
 HTMLPluginElement is not destroyed on reload or navigation if getNPObject is called


Modified: trunk/Source/cmake/WebKitHelpers.cmake (111768 => 111769)

--- trunk/Source/cmake/WebKitHelpers.cmake	2012-03-22 21:53:05 UTC (rev 111768)
+++ trunk/Source/cmake/WebKitHelpers.cmake	2012-03-22 22:01:39 UTC (rev 111769)
@@ -27,7 +27,7 @@
 
 GET_TARGET_PROPERTY(TARGET_TYPE ${_target} TYPE)
 IF (${TARGET_TYPE} STREQUAL STATIC_LIBRARY) # -fPIC is automatically added to shared libraries
-SET(OLD_COMPILE_FLAGS -fPIC)
+SET(OLD_COMPILE_FLAGS -fPIC ${OLD_COMPILE_FLAGS})
 ENDIF ()
 
 SET(OLD_COMPILE_FLAGS -fno-exceptions -fno-strict-aliasing ${OLD_COMPILE_FLAGS})






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111770] trunk/Source/WebCore

[kubo]

Title: [111770] trunk/Source/WebCore








Revision 111770
Author k...@profusion.mobi
Date 2012-03-22 15:03:20 -0700 (Thu, 22 Mar 2012)


Log Message
Crash in fast/dom/navigator-detached-nocrash.html
https://bugs.webkit.org/show_bug.cgi?id=81773

Reviewed by Adam Barth.

BatteryManager::create() blindly assumes the Navigator* it
receives has a valid Frame, which is not always the case, as made
evident by the crashing test.

Follow abarth's suggestion and just stop
NavigatorBattery::webkitBattery() before it reaches the call to
BatteryManager::create() if that's the case.

No new tests, covered by fast/dom/navigator-detached-nocrash.html.

* Modules/battery/NavigatorBattery.cpp:
(WebCore::NavigatorBattery::webkitBattery):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/battery/NavigatorBattery.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (111769 => 111770)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 22:01:39 UTC (rev 111769)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 22:03:20 UTC (rev 111770)
@@ -1,3 +1,23 @@
+2012-03-22  Raphael Kubo da Costa  rak...@freebsd.org
+
+Crash in fast/dom/navigator-detached-nocrash.html
+https://bugs.webkit.org/show_bug.cgi?id=81773
+
+Reviewed by Adam Barth.
+
+BatteryManager::create() blindly assumes the Navigator* it
+receives has a valid Frame, which is not always the case, as made
+evident by the crashing test.
+
+Follow abarth's suggestion and just stop
+NavigatorBattery::webkitBattery() before it reaches the call to
+BatteryManager::create() if that's the case.
+
+No new tests, covered by fast/dom/navigator-detached-nocrash.html.
+
+* Modules/battery/NavigatorBattery.cpp:
+(WebCore::NavigatorBattery::webkitBattery):
+
 2012-03-22  Emil A Eklund  e...@chromium.org
 
 Unreviewed, add missing include statement for CSSValueList.h.


Modified: trunk/Source/WebCore/Modules/battery/NavigatorBattery.cpp (111769 => 111770)

--- trunk/Source/WebCore/Modules/battery/NavigatorBattery.cpp	2012-03-22 22:01:39 UTC (rev 111769)
+++ trunk/Source/WebCore/Modules/battery/NavigatorBattery.cpp	2012-03-22 22:03:20 UTC (rev 111770)
@@ -39,6 +39,9 @@
 
 BatteryManager* NavigatorBattery::webkitBattery(ScriptExecutionContext* context, Navigator* navigator)
 {
+if (!navigator-frame())
+return 0;
+
 NavigatorBattery* navigatorBattery = NavigatorBattery::from(navigator);
 if (!navigatorBattery-m_batteryManager)
 navigatorBattery-m_batteryManager = BatteryManager::create(context, navigator);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111771] trunk/Tools

[aestes]

Title: [111771] trunk/Tools








Revision 111771
Author aes...@apple.com
Date 2012-03-22 15:05:04 -0700 (Thu, 22 Mar 2012)


Log Message
check-for-inappropriate-objc-class-names should ignore the class defined by libarclite.
https://bugs.webkit.org/show_bug.cgi?id=81971

Reviewed by Dan Bernstein.

Xcode will automatically link ObjC binaries against libarclite in some
cases, which defines a class called __ARCLite__.
check-for-inappropriate-objc-class-names shouldn't complain about this
class name.

* Scripts/check-for-inappropriate-objc-class-names:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/check-for-inappropriate-objc-class-names




Diff

Modified: trunk/Tools/ChangeLog (111770 => 111771)

--- trunk/Tools/ChangeLog	2012-03-22 22:03:20 UTC (rev 111770)
+++ trunk/Tools/ChangeLog	2012-03-22 22:05:04 UTC (rev 111771)
@@ -1,3 +1,17 @@
+2012-03-22  Andy Estes  aes...@apple.com
+
+check-for-inappropriate-objc-class-names should ignore the class defined by libarclite.
+https://bugs.webkit.org/show_bug.cgi?id=81971
+
+Reviewed by Dan Bernstein.
+
+Xcode will automatically link ObjC binaries against libarclite in some
+cases, which defines a class called __ARCLite__.
+check-for-inappropriate-objc-class-names shouldn't complain about this
+class name.
+
+* Scripts/check-for-inappropriate-objc-class-names:
+
 2012-03-22  Dirk Pranke  dpra...@chromium.org
 
 new-run-webkit-tests blames the wrong test for crashing


Modified: trunk/Tools/Scripts/check-for-inappropriate-objc-class-names (111770 => 111771)

--- trunk/Tools/Scripts/check-for-inappropriate-objc-class-names	2012-03-22 22:03:20 UTC (rev 111770)
+++ trunk/Tools/Scripts/check-for-inappropriate-objc-class-names	2012-03-22 22:05:04 UTC (rev 111771)
@@ -38,6 +38,9 @@
 
 my @allowedPrefixes = @ARGV;
 
+# Xcode will automatically link ObjC binaries against libarclite in some cases, which defines a class called __ARCLite__.
+push(@allowedPrefixes, __ARCLite);
+
 die No allowed prefixes passed on the command line if !@allowedPrefixes;
 
 my $arch = $ENV{'CURRENT_ARCH'};






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111772] trunk/Source/WebKit/blackberry

[mifenton]

Title: [111772] trunk/Source/WebKit/blackberry








Revision 111772
Author mifen...@rim.com
Date 2012-03-22 15:12:23 -0700 (Thu, 22 Mar 2012)


Log Message
[BlackBerry] Add pattern matching for hexadecimal type input fields
https://bugs.webkit.org/show_bug.cgi?id=81944

Reviewed by Rob Buis.

PR 98504.

Add mapping of patterns matching hexadecimal input
to a specialized type and provide input styling based
on that format.

Reviewed Internally by Gen Mak.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementPatternIndicatesHexadecimal):
(DOMSupport):
* WebKitSupport/DOMSupport.h:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::convertInputType):
(BlackBerry::WebKit::inputStyle):

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp
trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.h
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (111771 => 111772)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-03-22 22:05:04 UTC (rev 111771)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-03-22 22:12:23 UTC (rev 111772)
@@ -1,5 +1,28 @@
 2012-03-22  Mike Fenton  mifen...@rim.com
 
+[BlackBerry] Add pattern matching for hexadecimal type input fields
+https://bugs.webkit.org/show_bug.cgi?id=81944
+
+Reviewed by Rob Buis.
+
+PR 98504.
+
+Add mapping of patterns matching hexadecimal input
+to a specialized type and provide input styling based
+on that format.
+
+Reviewed Internally by Gen Mak.
+
+* WebKitSupport/DOMSupport.cpp:
+(BlackBerry::WebKit::DOMSupport::elementPatternIndicatesHexadecimal):
+(DOMSupport):
+* WebKitSupport/DOMSupport.h:
+* WebKitSupport/InputHandler.cpp:
+(BlackBerry::WebKit::convertInputType):
+(BlackBerry::WebKit::inputStyle):
+
+2012-03-22  Mike Fenton  mifen...@rim.com
+
 [BlackBerry] DOMSupport isPositionInNode should have early returns for null nodes
 https://bugs.webkit.org/show_bug.cgi?id=81929
 


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp (111771 => 111772)

--- trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp	2012-03-22 22:05:04 UTC (rev 111771)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp	2012-03-22 22:12:23 UTC (rev 111772)
@@ -385,6 +385,34 @@
 return false;
 }
 
+bool elementPatternIndicatesHexadecimal(const HTMLInputElement* inputElement)
+{
+if (!inputElement)
+return false;
+
+if (inputElement-fastHasAttribute(HTMLNames::patternAttr)) {
+AtomicString patternAttribute = inputElement-fastGetAttribute(HTMLNames::patternAttr);
+if (patternAttribute.startsWith([0-9a-fA-F])) {
+// The pattern is for hexadecimal, make sure nothing else is permitted.
+
+// Check if it was an exact match.
+if (patternAttribute.length() == 11)
+return true;
+
+// Is the regex specifying a character count?
+if (patternAttribute[11] != '{' || !patternAttribute.endsWith(}))
+return false;
+
+int count = 0;
+// Make sure the number in the regex is actually a number.
+if ((sscanf(patternAttribute.string().latin1().data(), [0-9a-fA-F]{%d}\0, count) == 1)  count  0)
+return true;
+}
+}
+
+return false;
+}
+
 IntPoint convertPointToFrame(const Frame* sourceFrame, const Frame* targetFrame, const IntPoint point, const bool clampToTargetFrame)
 {
 ASSERT(sourceFrame  targetFrame);


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.h (111771 => 111772)

--- trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.h	2012-03-22 22:05:04 UTC (rev 111771)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.h	2012-03-22 22:12:23 UTC (rev 111772)
@@ -77,6 +77,7 @@
 bool elementIdOrNameIndicatesNoAutocomplete(const WebCore::Element*);
 bool elementIdOrNameIndicatesEmail(const WebCore::HTMLInputElement*);
 bool elementIdOrNameIndicatesUrl(const WebCore::HTMLInputElement*);
+bool elementPatternIndicatesHexadecimal(const WebCore::HTMLInputElement*);
 
 WebCore::IntPoint convertPointToFrame(const WebCore::Frame* sourceFrame, const WebCore::Frame* targetFrame, const WebCore::IntPoint sourcePoint, const bool clampToTargetFrame = false);
 


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (111771 => 111772)

--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2012-03-22 22:05:04 UTC (rev 111771)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2012-03-22 22:12:23 UTC (rev 111772)
@@ -158,6 +158,8 @@
 return InputTypeEmail;
 if (DOMSupport::elementIdOrNameIndicatesUrl(inputElement))
 return InputTypeURL;
+if (DOMSupport::elementPatternIndicatesHexadecimal(inputElement))
+

[webkit-changes] [111773] trunk/Tools

[mitz]

Title: [111773] trunk/Tools








Revision 111773
Author m...@apple.com
Date 2012-03-22 15:30:52 -0700 (Thu, 22 Mar 2012)


Log Message
Font fallback in WebKitTestRunner depends on user settings
https://bugs.webkit.org/show_bug.cgi?id=81978

Reviewed by Jessie Berlin.

* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize): Added an AppleLanguages key
with a value consisting of the array (en) to the override defaults
dictionary. This is the same value used in DumpRenderTree, and it
ensures that font fallback follows a consistent path that is not
affected by the language preferences of the user running the test.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm




Diff

Modified: trunk/Tools/ChangeLog (111772 => 111773)

--- trunk/Tools/ChangeLog	2012-03-22 22:12:23 UTC (rev 111772)
+++ trunk/Tools/ChangeLog	2012-03-22 22:30:52 UTC (rev 111773)
@@ -1,3 +1,17 @@
+2012-03-22  Dan Bernstein  m...@apple.com
+
+Font fallback in WebKitTestRunner depends on user settings
+https://bugs.webkit.org/show_bug.cgi?id=81978
+
+Reviewed by Jessie Berlin.
+
+* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
+(WTR::InjectedBundle::platformInitialize): Added an AppleLanguages key
+with a value consisting of the array (en) to the override defaults
+dictionary. This is the same value used in DumpRenderTree, and it
+ensures that font fallback follows a consistent path that is not
+affected by the language preferences of the user running the test.
+
 2012-03-22  Andy Estes  aes...@apple.com
 
 check-for-inappropriate-objc-class-names should ignore the class defined by libarclite.


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm (111772 => 111773)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm	2012-03-22 22:12:23 UTC (rev 111772)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm	2012-03-22 22:30:52 UTC (rev 111773)
@@ -37,6 +37,7 @@
 [NSNumber numberWithBool:NO], @AppleScrollAnimationEnabled,
 [NSNumber numberWithBool:NO], @NSOverlayScrollersEnabled,
 @Always,@AppleShowScrollBars,
+[NSArray arrayWithObject:@en],  @AppleLanguages,
 nil];
 
 [[NSUserDefaults standardUserDefaults] setVolatileDomain:dict forName:NSArgumentDomain];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111774] trunk/Source/WebKit/blackberry

[commit-queue]

Title: [111774] trunk/Source/WebKit/blackberry








Revision 111774
Author commit-qu...@webkit.org
Date 2012-03-22 15:32:54 -0700 (Thu, 22 Mar 2012)


Log Message
[BlackBerry] DeviceDPI Scaling is broken on mobile.
https://bugs.webkit.org/show_bug.cgi?id=81966

Fix our viewport argument handling to only override the
targetDensityDpi on tablet devices. Allow WebCore to use
dpi scaling for smaller screen mobile devices.

Patch by Mike Lattanzio mlattan...@rim.com on 2012-03-22
Reviewed by Rob Buis.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/ChangeLog




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (111773 => 111774)

--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-03-22 22:30:52 UTC (rev 111773)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-03-22 22:32:54 UTC (rev 111774)
@@ -3116,9 +3116,11 @@
 int deviceHeight = Platform::Graphics::Screen::primaryScreen()-height();
 FloatSize currentPPI = Platform::Graphics::Screen::primaryScreen()-pixelsPerInch(-1);
 int deviceDPI = int(roundf((currentPPI.width() + currentPPI.height()) / 2));
-if (m_viewportArguments.targetDensityDpi == ViewportArguments::ValueAuto) {
-// Auto means 160dpi if we leave it alone. This looks terrible for pages wanting 1:1.
-// FIXME: This is insufficient for devices with high dpi, as they will render content unreadably small.
+if (m_viewportArguments.targetDensityDpi == ViewportArguments::ValueAuto
+ !Platform::DeviceInfo::instance()-isMobile()) {
+// If the content provider hasn't specified a target dpi and we have a large
+// screen we assume the content is fine and set the targetDensityDpi to our dpi.
+// On smaller screen mobile devices we skip this and use WebCore dpi scaling.
 m_viewportArguments.targetDensityDpi = deviceDPI;
 }
 


Modified: trunk/Source/WebKit/blackberry/ChangeLog (111773 => 111774)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-03-22 22:30:52 UTC (rev 111773)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-03-22 22:32:54 UTC (rev 111774)
@@ -1,3 +1,17 @@
+2012-03-22  Mike Lattanzio  mlattan...@rim.com
+
+[BlackBerry] DeviceDPI Scaling is broken on mobile.
+https://bugs.webkit.org/show_bug.cgi?id=81966
+
+Fix our viewport argument handling to only override the
+targetDensityDpi on tablet devices. Allow WebCore to use
+dpi scaling for smaller screen mobile devices.
+
+Reviewed by Rob Buis.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
+
 2012-03-22  Mike Fenton  mifen...@rim.com
 
 [BlackBerry] Add pattern matching for hexadecimal type input fields






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111775] trunk/Source/WebCore

[abarth]

Title: [111775] trunk/Source/WebCore








Revision 111775
Author aba...@webkit.org
Date 2012-03-22 15:39:39 -0700 (Thu, 22 Mar 2012)


Log Message
ContainerNode::insertedIntoTree and removedFromTree use weak iteration patterns
https://bugs.webkit.org/show_bug.cgi?id=80570

Reviewed by Ryosuke Niwa.

These functions use weak iteration patterns, but as far as I can tell,
we never execute script below these functions.  This patch adds ASSERTs
to help us avoid adding events in the future.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertedIntoTree):
(WebCore::ContainerNode::removedFromTree):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadInternal):
- There's a somewhat complex call chain from insertedIntoTree into
  HTMLMediaElement, and somewhat complex control flow below
  loadInternal that eventually leads to the BeforeLoad event being
  fired.  In studying this code, I don't see a way for the
  BeforeLoad event to be fired during insertedIntoTree, but I've
  added this assert here to make sure we don't call loadInternal
  when we're not supposed to dispatch events.  This ASSERT should
  help us catch these BeforeLoad errors more quickly.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/html/HTMLMediaElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (111774 => 111775)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 22:32:54 UTC (rev 111774)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 22:39:39 UTC (rev 111775)
@@ -1,3 +1,28 @@
+2012-03-22  Adam Barth  aba...@webkit.org
+
+ContainerNode::insertedIntoTree and removedFromTree use weak iteration patterns
+https://bugs.webkit.org/show_bug.cgi?id=80570
+
+Reviewed by Ryosuke Niwa.
+
+These functions use weak iteration patterns, but as far as I can tell,
+we never execute script below these functions.  This patch adds ASSERTs
+to help us avoid adding events in the future.
+
+* dom/ContainerNode.cpp:
+(WebCore::ContainerNode::insertedIntoTree):
+(WebCore::ContainerNode::removedFromTree):
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::loadInternal):
+- There's a somewhat complex call chain from insertedIntoTree into
+  HTMLMediaElement, and somewhat complex control flow below
+  loadInternal that eventually leads to the BeforeLoad event being
+  fired.  In studying this code, I don't see a way for the
+  BeforeLoad event to be fired during insertedIntoTree, but I've
+  added this assert here to make sure we don't call loadInternal
+  when we're not supposed to dispatch events.  This ASSERT should
+  help us catch these BeforeLoad errors more quickly.
+
 2012-03-22  Raphael Kubo da Costa  rak...@freebsd.org
 
 Crash in fast/dom/navigator-detached-nocrash.html


Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (111774 => 111775)

--- trunk/Source/WebCore/dom/ContainerNode.cpp	2012-03-22 22:32:54 UTC (rev 111774)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp	2012-03-22 22:39:39 UTC (rev 111775)
@@ -795,20 +795,24 @@
 {
 if (!deep)
 return;
+forbidEventDispatch();
 for (Node* child = m_firstChild; child; child = child-nextSibling()) {
 if (child-isContainerNode())
 toContainerNode(child)-insertedIntoTree(true);
 }
+allowEventDispatch();
 }
 
 void ContainerNode::removedFromTree(bool deep)
 {
 if (!deep)
 return;
+forbidEventDispatch();
 for (Node* child = m_firstChild; child; child = child-nextSibling()) {
 if (child-isContainerNode())
 toContainerNode(child)-removedFromTree(true);
 }
+allowEventDispatch();
 }
 
 void ContainerNode::childrenChanged(bool changedByParser, Node*, Node*, int childCountDelta)


Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (111774 => 111775)

--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2012-03-22 22:32:54 UTC (rev 111774)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2012-03-22 22:39:39 UTC (rev 111775)
@@ -715,6 +715,11 @@
 
 void HTMLMediaElement::loadInternal()
 {
+// Some of the code paths below this function dispatch the BeforeLoad event. This ASSERT helps
+// us catch those bugs more quickly without needing all the branches to align to actually
+// trigger the event.
+ASSERT(!eventDispatchForbidden());
+
 // If we can't start a load right away, start it later.
 Page* page = document()-page();
 if (pageConsentRequiredForLoad()  page  !page-canStartMedia()) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111776] trunk/LayoutTests

[eae]

Title: [111776] trunk/LayoutTests








Revision 111776
Author e...@chromium.org
Date 2012-03-22 15:43:16 -0700 (Thu, 22 Mar 2012)


Log Message
Unreviewed rebaseline for chromium leopard.

* platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-2-expected.png: Added.
* platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-6-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-2-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-6-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (111775 => 111776)

--- trunk/LayoutTests/ChangeLog	2012-03-22 22:39:39 UTC (rev 111775)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 22:43:16 UTC (rev 111776)
@@ -1,3 +1,10 @@
+2012-03-22  Emil A Eklund  e...@chromium.org
+
+Unreviewed rebaseline for chromium leopard.
+
+* platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-2-expected.png: Added.
+* platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-6-expected.png: Added.
+
 2012-03-22  Tony Chang  t...@chromium.org
 
 flexbox flexing implementation should match the spec


Added: trunk/LayoutTests/platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-2-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-2-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-6-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-6-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111777] trunk/Source

[commit-queue]

Title: [111777] trunk/Source








Revision 111777
Author commit-qu...@webkit.org
Date 2012-03-22 15:43:19 -0700 (Thu, 22 Mar 2012)


Log Message
[chromium] LayerRendererChromium should use GpuMemoryAllocationChanged callback to explicitly manage framebuffer.
https://bugs.webkit.org/show_bug.cgi?id=81823

Patch by Michal Mocny mmo...@google.com on 2012-03-22
Reviewed by Adrienne Walker.

Source/WebCore:

New UnitTests: LayerRendererChromiumTest

* platform/graphics/chromium/LayerRendererChromium.cpp:
(LayerRendererGpuMemoryAllocationChangedCallbackAdapter):
(WebCore::LayerRendererGpuMemoryAllocationChangedCallbackAdapter::create):
(WebCore::LayerRendererGpuMemoryAllocationChangedCallbackAdapter::~LayerRendererGpuMemoryAllocationChangedCallbackAdapter):
(WebCore::LayerRendererGpuMemoryAllocationChangedCallbackAdapter::onGpuMemoryAllocationChanged):
(WebCore::LayerRendererGpuMemoryAllocationChangedCallbackAdapter::LayerRendererGpuMemoryAllocationChangedCallbackAdapter):
(WebCore):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::~LayerRendererChromium):
(WebCore::LayerRendererChromium::setVisible):
(WebCore::LayerRendererChromium::swapBuffers):
(WebCore::LayerRendererChromium::discardFramebuffer):
(WebCore::LayerRendererChromium::ensureFramebuffer):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
(LayerRendererChromiumClient):
(LayerRendererChromium):
(WebCore::LayerRendererChromium::isFramebufferDiscarded):
(ScopedEnsureFramebufferAllocation):
(WebCore::ScopedEnsureFramebufferAllocation::ScopedEnsureFramebufferAllocation):
(WebCore::ScopedEnsureFramebufferAllocation::~ScopedEnsureFramebufferAllocation):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
(LayerRendererCapabilities):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setVisible):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::compositeAndReadback):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::compositeAndReadback):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/LayerRendererChromiumTest.cpp: Added.
(FrameCountingMemoryAllocationSettingContext):
(FrameCountingMemoryAllocationSettingContext::FrameCountingMemoryAllocationSettingContext):
(FrameCountingMemoryAllocationSettingContext::prepareTexture):
(FrameCountingMemoryAllocationSettingContext::setMemoryAllocationChangedCallbackCHROMIUM):
(FrameCountingMemoryAllocationSettingContext::getString):
(FrameCountingMemoryAllocationSettingContext::frameCount):
(FrameCountingMemoryAllocationSettingContext::setMemoryAllocation):
(FakeLayerRendererChromiumClient):
(FakeLayerRendererChromiumClient::FakeLayerRendererChromiumClient):
(FakeLayerRendererChromiumClient::viewportSize):
(FakeLayerRendererChromiumClient::settings):
(FakeLayerRendererChromiumClient::rootLayer):
(FakeLayerRendererChromiumClient::didLoseContext):
(FakeLayerRendererChromiumClient::onSwapBuffersComplete):
(FakeLayerRendererChromiumClient::setFullRootLayerDamage):
(FakeLayerRendererChromiumClient::setFullRootLayerDamageCount):
(FakeLayerRendererChromium):
(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(LayerRendererChromiumTest::SetUp):
(LayerRendererChromiumTest::swapBuffers):
(TEST_F):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gypi


Added Paths

trunk/Source/WebKit/chromium/tests/LayerRendererChromiumTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (111776 => 111777)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 22:43:16 UTC (rev 111776)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 22:43:19 UTC (rev 111777)
@@ -1,3 +1,46 @@
+2012-03-22  Michal Mocny  mmo...@google.com
+
+[chromium] LayerRendererChromium should use GpuMemoryAllocationChanged callback to explicitly manage framebuffer.
+https://bugs.webkit.org/show_bug.cgi?id=81823
+
+Reviewed by Adrienne Walker.
+
+New UnitTests: LayerRendererChromiumTest
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(LayerRendererGpuMemoryAllocationChangedCallbackAdapter):
+

[webkit-changes] [111779] trunk/Source/WebCore

[haraken]

Title: [111779] trunk/Source/WebCore








Revision 111779
Author hara...@chromium.org
Date 2012-03-22 16:08:13 -0700 (Thu, 22 Mar 2012)


Log Message
run-bindings-tests output a lot of errors in TestSerializedScriptValueInterface.idl
https://bugs.webkit.org/show_bug.cgi?id=81852

Reviewed by Adam Barth.

run-bindings-tests output a lot of errors in TestSerializedScriptValueInterface.idl:

Use of uninitialized value in string eq at WebCore/bindings/scripts/CodeGeneratorJS.pm line 2743.
Use of uninitialized value $name in substitution (s///) at WebCore/bindings/scripts/CodeGenerator.pm line 119.
Use of uninitialized value $type in string eq at WebCore/bindings/scripts/CodeGeneratorJS.pm line 2969.
Use of uninitialized value $type in string eq at WebCore/bindings/scripts/CodeGeneratorJS.pm line 2972.
Use of uninitialized value $type in hash element at WebCore/bindings/scripts/CodeGenerator.pm line 367.
Use of uninitialized value $type in hash element at WebCore/bindings/scripts/CodeGenerator.pm line 368.
...

This is because [Constructor(...)] does not yet support [Optional] arguments.
It just supports [Optional=DefaultIsUndefined] and [Optional=DefaultIsNullString] arguments:
https://trac.webkit.org/wiki/WebKitIDL#Constructor

This patch replaces [Optional] with [Optional=DefaultIsUndefined]
in TestSerializedScriptValueInterface.idl.

Test: bindings/scripts/test/TestSerializedScriptValueInterface.idl

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
* bindings/scripts/test/TestSerializedScriptValueInterface.idl:
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/TestSerializedScriptValueInterface.idl
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (111778 => 111779)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 23:00:33 UTC (rev 111778)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 23:08:13 UTC (rev 111779)
@@ -1,3 +1,39 @@
+2012-03-22  Kentaro Hara  hara...@chromium.org
+
+run-bindings-tests output a lot of errors in TestSerializedScriptValueInterface.idl
+https://bugs.webkit.org/show_bug.cgi?id=81852
+
+Reviewed by Adam Barth.
+
+run-bindings-tests output a lot of errors in TestSerializedScriptValueInterface.idl:
+
+Use of uninitialized value in string eq at WebCore/bindings/scripts/CodeGeneratorJS.pm line 2743.
+Use of uninitialized value $name in substitution (s///) at WebCore/bindings/scripts/CodeGenerator.pm line 119.
+Use of uninitialized value $type in string eq at WebCore/bindings/scripts/CodeGeneratorJS.pm line 2969.
+Use of uninitialized value $type in string eq at WebCore/bindings/scripts/CodeGeneratorJS.pm line 2972.
+Use of uninitialized value $type in hash element at WebCore/bindings/scripts/CodeGenerator.pm line 367.
+Use of uninitialized value $type in hash element at WebCore/bindings/scripts/CodeGenerator.pm line 368.
+...
+
+This is because [Constructor(...)] does not yet support [Optional] arguments.
+It just supports [Optional=DefaultIsUndefined] and [Optional=DefaultIsNullString] arguments:
+https://trac.webkit.org/wiki/WebKitIDL#Constructor
+
+This patch replaces [Optional] with [Optional=DefaultIsUndefined]
+in TestSerializedScriptValueInterface.idl.
+
+Test: bindings/scripts/test/TestSerializedScriptValueInterface.idl
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateConstructorDefinition):
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateConstructorCallback):
+* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
+(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
+* bindings/scripts/test/TestSerializedScriptValueInterface.idl:
+* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
+(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
+
 2012-03-22  Michal Mocny  mmo...@google.com
 
 [chromium] LayerRendererChromium should use GpuMemoryAllocationChanged callback to explicitly manage framebuffer.


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (111778 => 111779)

--- 

[webkit-changes] [111780] trunk

[ossy]

Title: [111780] trunk








Revision 111780
Author o...@webkit.org
Date 2012-03-22 16:17:44 -0700 (Thu, 22 Mar 2012)


Log Message
Actually move WTF files to their new home
https://bugs.webkit.org/show_bug.cgi?id=81844

[Qt] Unreviewed buildfix after r111778.

.:

* Source/api.pri:

Source/WebCore:

* Target.pri:

Source/WTF:

* WTF.pri:

Tools:

* DumpRenderTree/qt/DumpRenderTree.pro:

Modified Paths

trunk/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.pri
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri
trunk/Source/api.pri
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro




Diff

Modified: trunk/ChangeLog (111779 => 111780)

--- trunk/ChangeLog	2012-03-22 23:08:13 UTC (rev 111779)
+++ trunk/ChangeLog	2012-03-22 23:17:44 UTC (rev 111780)
@@ -1,3 +1,12 @@
+2012-03-22  Csaba Osztrogonác  o...@webkit.org
+
+Actually move WTF files to their new home
+https://bugs.webkit.org/show_bug.cgi?id=81844
+
+[Qt] Unreviewed buildfix after r111778.
+
+* Source/api.pri:
+
 2012-03-22  Ming Xie  m...@rim.com
 
 OLD_COMPILE_FLAGS was set incorrectly in WebKitHelpers.cmake


Modified: trunk/Source/WTF/ChangeLog (111779 => 111780)

--- trunk/Source/WTF/ChangeLog	2012-03-22 23:08:13 UTC (rev 111779)
+++ trunk/Source/WTF/ChangeLog	2012-03-22 23:17:44 UTC (rev 111780)
@@ -1,3 +1,12 @@
+2012-03-22  Csaba Osztrogonác  o...@webkit.org
+
+Actually move WTF files to their new home
+https://bugs.webkit.org/show_bug.cgi?id=81844
+
+[Qt] Unreviewed buildfix after r111778.
+
+* WTF.pri:
+
 2012-03-22  Eric Seidel  e...@webkit.org
 
 Actually move WTF files to their new home


Modified: trunk/Source/WTF/WTF.pri (111779 => 111780)

--- trunk/Source/WTF/WTF.pri	2012-03-22 23:08:13 UTC (rev 111779)
+++ trunk/Source/WTF/WTF.pri	2012-03-22 23:17:44 UTC (rev 111780)
@@ -16,7 +16,8 @@
 $$SOURCE_DIR \
 $$SOURCE_DIR/gobject \
 $$SOURCE_DIR/qt \
-$$SOURCE_DIR/unicode
+$$SOURCE_DIR/unicode \
+$$SOURCE_DIR/wtf
 
 haveQt(5) {
 mac {


Modified: trunk/Source/WebCore/ChangeLog (111779 => 111780)

--- trunk/Source/WebCore/ChangeLog	2012-03-22 23:08:13 UTC (rev 111779)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 23:17:44 UTC (rev 111780)
@@ -1,3 +1,12 @@
+2012-03-22  Csaba Osztrogonác  o...@webkit.org
+
+Actually move WTF files to their new home
+https://bugs.webkit.org/show_bug.cgi?id=81844
+
+[Qt] Unreviewed buildfix after r111778.
+
+* Target.pri:
+
 2012-03-22  Kentaro Hara  hara...@chromium.org
 
 run-bindings-tests output a lot of errors in TestSerializedScriptValueInterface.idl


Modified: trunk/Source/WebCore/Target.pri (111779 => 111780)

--- trunk/Source/WebCore/Target.pri	2012-03-22 23:08:13 UTC (rev 111779)
+++ trunk/Source/WebCore/Target.pri	2012-03-22 23:17:44 UTC (rev 111780)
@@ -21,7 +21,7 @@
 # path for QtScript when it's built as a standalone module
 QT += script
 } else {
-INCLUDEPATH += $$PWD/../_javascript_Core/wtf/qt/compat
+INCLUDEPATH += $$PWD/../WTF/wtf/qt/compat
 }
 
 RESOURCES += \


Modified: trunk/Source/api.pri (111779 => 111780)

--- trunk/Source/api.pri	2012-03-22 23:08:13 UTC (rev 111779)
+++ trunk/Source/api.pri	2012-03-22 23:17:44 UTC (rev 111780)
@@ -200,7 +200,8 @@
 
 INCLUDEPATH += \
 $$PWD/WebKit/qt/Api \
-$$PWD/WebKit/qt/WebCoreSupport
+$$PWD/WebKit/qt/WebCoreSupport \
+$$PWD/WTF/wtf/qt
 
 contains(DEFINES, ENABLE_VIDEO=1) {
 !contains(DEFINES, WTF_USE_QTKIT=1):!contains(DEFINES, WTF_USE_GSTREAMER=1):contains(DEFINES, WTF_USE_QT_MULTIMEDIA=1) {


Modified: trunk/Tools/ChangeLog (111779 => 111780)

--- trunk/Tools/ChangeLog	2012-03-22 23:08:13 UTC (rev 111779)
+++ trunk/Tools/ChangeLog	2012-03-22 23:17:44 UTC (rev 111780)
@@ -1,3 +1,12 @@
+2012-03-22  Csaba Osztrogonác  o...@webkit.org
+
+Actually move WTF files to their new home
+https://bugs.webkit.org/show_bug.cgi?id=81844
+
+[Qt] Unreviewed buildfix after r111778.
+
+* DumpRenderTree/qt/DumpRenderTree.pro:
+
 2012-03-22  Dan Bernstein  m...@apple.com
 
 Font fallback in WebKitTestRunner depends on user settings


Modified: trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro (111779 => 111780)

--- trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro	2012-03-22 23:08:13 UTC (rev 111779)
+++ trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro	2012-03-22 23:17:44 UTC (rev 111780)
@@ -11,7 +11,7 @@
 
 load(features)
 
-WEBKIT += wtf webcore
+WEBKIT += wtf _javascript_core webcore
 
 INCLUDEPATH += \
 $$PWD/.. \
@@ -36,7 +36,7 @@
 testplugin.h
 
 SOURCES += \
-$${ROOT_WEBKIT_DIR}/Source/_javascript_Core/wtf/Assertions.cpp \
+$${ROOT_WEBKIT_DIR}/Source/WTF/wtf/Assertions.cpp \
 $$PWD/../WorkQueue.cpp \
 DumpRenderTreeQt.cpp \
 EventSenderQt.cpp \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org

[webkit-changes] [111781] trunk/Source/JavaScriptCore

[fpizlo]

Title: [111781] trunk/Source/_javascript_Core








Revision 111781
Author fpi...@apple.com
Date 2012-03-22 16:24:40 -0700 (Thu, 22 Mar 2012)


Log Message
DFG NodeFlags has some duplicate code and naming issues
https://bugs.webkit.org/show_bug.cgi?id=81975

Reviewed by Gavin Barraclough.

Removed most references to ArithNodeFlags since those are now just part
of the node flags. Fixed some renaming goofs (EdgedAsNum is once again
NodeUsedAsNum). Got rid of setArithNodeFlags() and mergeArithNodeFlags()
because the former was never called and the latter did the same things as
mergeFlags().

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGNode.h:
(JSC::DFG::Node::arithNodeFlags):
(Node):
* dfg/DFGNodeFlags.cpp:
(JSC::DFG::nodeFlagsAsString):
* dfg/DFGNodeFlags.h:
(DFG):
(JSC::DFG::nodeUsedAsNumber):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultArithFlags):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.cpp
trunk/Source/_javascript_Core/dfg/DFGNode.h
trunk/Source/_javascript_Core/dfg/DFGNodeFlags.cpp
trunk/Source/_javascript_Core/dfg/DFGNodeFlags.h
trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (111780 => 111781)

--- trunk/Source/_javascript_Core/ChangeLog	2012-03-22 23:17:44 UTC (rev 111780)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-03-22 23:24:40 UTC (rev 111781)
@@ -1,3 +1,34 @@
+2012-03-22  Filip Pizlo  fpi...@apple.com
+
+DFG NodeFlags has some duplicate code and naming issues
+https://bugs.webkit.org/show_bug.cgi?id=81975
+
+Reviewed by Gavin Barraclough.
+
+Removed most references to ArithNodeFlags since those are now just part
+of the node flags. Fixed some renaming goofs (EdgedAsNum is once again
+NodeUsedAsNum). Got rid of setArithNodeFlags() and mergeArithNodeFlags()
+because the former was never called and the latter did the same things as
+mergeFlags().
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::makeSafe):
+(JSC::DFG::ByteCodeParser::makeDivSafe):
+(JSC::DFG::ByteCodeParser::handleIntrinsic):
+* dfg/DFGGraph.cpp:
+(JSC::DFG::Graph::dump):
+* dfg/DFGNode.h:
+(JSC::DFG::Node::arithNodeFlags):
+(Node):
+* dfg/DFGNodeFlags.cpp:
+(JSC::DFG::nodeFlagsAsString):
+* dfg/DFGNodeFlags.h:
+(DFG):
+(JSC::DFG::nodeUsedAsNumber):
+* dfg/DFGPredictionPropagationPhase.cpp:
+(JSC::DFG::PredictionPropagationPhase::propagate):
+(JSC::DFG::PredictionPropagationPhase::mergeDefaultArithFlags):
+
 2012-03-22  Eric Seidel  e...@webkit.org
 
 Actually move WTF files to their new home


Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (111780 => 111781)

--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2012-03-22 23:17:44 UTC (rev 111780)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2012-03-22 23:24:40 UTC (rev 111781)
@@ -709,7 +709,7 @@
 case ArithNegate:
 case ValueAdd:
 case ArithMod: // for ArithMode MayOverflow means we tried to divide by zero, or we saw double.
-m_graph[nodeIndex].mergeArithNodeFlags(NodeMayOverflow);
+m_graph[nodeIndex].mergeFlags(NodeMayOverflow);
 break;
 
 case ArithMul:
@@ -718,13 +718,13 @@
 #if DFG_ENABLE(DEBUG_VERBOSE)
 dataLog(Making ArithMul @%u take deepest slow case.\n, nodeIndex);
 #endif
-m_graph[nodeIndex].mergeArithNodeFlags(NodeMayOverflow | NodeMayNegZero);
+m_graph[nodeIndex].mergeFlags(NodeMayOverflow | NodeMayNegZero);
 } else if (m_inlineStackTop-m_profiledBlock-likelyToTakeSlowCase(m_currentIndex)
|| m_inlineStackTop-m_exitProfile.hasExitSite(m_currentIndex, NegativeZero)) {
 #if DFG_ENABLE(DEBUG_VERBOSE)
 dataLog(Making ArithMul @%u take faster slow case.\n, nodeIndex);
 #endif
-m_graph[nodeIndex].mergeArithNodeFlags(NodeMayNegZero);
+m_graph[nodeIndex].mergeFlags(NodeMayNegZero);
 }
 break;
 
@@ -757,7 +757,7 @@
 
 // FIXME: It might be possible to make this more granular. The DFG certainly can
 // distinguish between negative zero and overflow in its exit profiles.
-m_graph[nodeIndex].mergeArithNodeFlags(NodeMayOverflow | NodeMayNegZero);
+m_graph[nodeIndex].mergeFlags(NodeMayOverflow | NodeMayNegZero);
 
 return nodeIndex;
 }
@@ -1297,7 

[webkit-changes] [111782] trunk/Source/WTF

[mitz]

Title: [111782] trunk/Source/WTF








Revision 111782
Author m...@apple.com
Date 2012-03-22 16:35:43 -0700 (Thu, 22 Mar 2012)


Log Message
Fixed the _javascript_Core debug build after r111778.

* WTF.xcodeproj/project.pbxproj: Use debug DEBUG_DEFINES when building
the Debug configuration.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WTF/ChangeLog (111781 => 111782)

--- trunk/Source/WTF/ChangeLog	2012-03-22 23:24:40 UTC (rev 111781)
+++ trunk/Source/WTF/ChangeLog	2012-03-22 23:35:43 UTC (rev 111782)
@@ -1,3 +1,10 @@
+2012-03-22  Dan Bernstein  m...@apple.com
+
+Fixed the _javascript_Core debug build after r111778.
+
+* WTF.xcodeproj/project.pbxproj: Use debug DEBUG_DEFINES when building
+the Debug configuration.
+
 2012-03-22  Csaba Osztrogonác  o...@webkit.org
 
 Actually move WTF files to their new home


Modified: trunk/Source/WTF/WTF.xcodeproj/project.pbxproj (111781 => 111782)

--- trunk/Source/WTF/WTF.xcodeproj/project.pbxproj	2012-03-22 23:24:40 UTC (rev 111781)
+++ trunk/Source/WTF/WTF.xcodeproj/project.pbxproj	2012-03-22 23:35:43 UTC (rev 111782)
@@ -1200,6 +1200,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 5D247B7314689C4700E78B76 /* WTF.xcconfig */;
 			buildSettings = {
+DEBUG_DEFINES = $(DEBUG_DEFINES_debug);
 			};
 			name = Debug;
 		};






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111784] tags/Safari-534.56.2/

[lforschler]

Title: [111784] tags/Safari-534.56.2/








Revision 111784
Author lforsch...@apple.com
Date 2012-03-22 16:43:47 -0700 (Thu, 22 Mar 2012)


Log Message
New tag.

Added Paths

tags/Safari-534.56.2/




Diff

Property changes: tags/Safari-534.56.2



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111785] branches/safari-534.56-branch/Source

[lforschler]

Title: [111785] branches/safari-534.56-branch/Source








Revision 111785
Author lforsch...@apple.com
Date 2012-03-22 16:46:29 -0700 (Thu, 22 Mar 2012)


Log Message
Versioning.

Modified Paths

branches/safari-534.56-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-534.56-branch/Source/_javascript_Glue/Configurations/Version.xcconfig
branches/safari-534.56-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-534.56-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-534.56-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-534.56-branch/Source/_javascript_Core/Configurations/Version.xcconfig (111784 => 111785)

--- branches/safari-534.56-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2012-03-22 23:43:47 UTC (rev 111784)
+++ branches/safari-534.56-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2012-03-22 23:46:29 UTC (rev 111785)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 56;
-TINY_VERSION = 2;
+TINY_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.56-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (111784 => 111785)

--- branches/safari-534.56-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2012-03-22 23:43:47 UTC (rev 111784)
+++ branches/safari-534.56-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2012-03-22 23:46:29 UTC (rev 111785)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 56;
-TINY_VERSION = 2;
+TINY_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.56-branch/Source/WebCore/Configurations/Version.xcconfig (111784 => 111785)

--- branches/safari-534.56-branch/Source/WebCore/Configurations/Version.xcconfig	2012-03-22 23:43:47 UTC (rev 111784)
+++ branches/safari-534.56-branch/Source/WebCore/Configurations/Version.xcconfig	2012-03-22 23:46:29 UTC (rev 111785)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 56;
-TINY_VERSION = 2;
+TINY_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.56-branch/Source/WebKit/mac/Configurations/Version.xcconfig (111784 => 111785)

--- branches/safari-534.56-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2012-03-22 23:43:47 UTC (rev 111784)
+++ branches/safari-534.56-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2012-03-22 23:46:29 UTC (rev 111785)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 56;
-TINY_VERSION = 2;
+TINY_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.56-branch/Source/WebKit2/Configurations/Version.xcconfig (111784 => 111785)

--- branches/safari-534.56-branch/Source/WebKit2/Configurations/Version.xcconfig	2012-03-22 23:43:47 UTC (rev 111784)
+++ branches/safari-534.56-branch/Source/WebKit2/Configurations/Version.xcconfig	2012-03-22 23:46:29 UTC (rev 111785)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 56;
-TINY_VERSION = 2;
+TINY_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111786] trunk/Source/JavaScriptCore

[mrowe]

Title: [111786] trunk/Source/_javascript_Core








Revision 111786
Author mr...@apple.com
Date 2012-03-22 16:47:50 -0700 (Thu, 22 Mar 2012)


Log Message
Fix the build.

* Configurations/_javascript_Core.xcconfig: Tell the linker to pull in all members from static libraries
rather than only those that contain symbols that _javascript_Core itself uses.
* _javascript_Core.xcodeproj/project.pbxproj: Remove some bogus settings that crept in to the Xcode project.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (111785 => 111786)

--- trunk/Source/_javascript_Core/ChangeLog	2012-03-22 23:46:29 UTC (rev 111785)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-03-22 23:47:50 UTC (rev 111786)
@@ -1,3 +1,11 @@
+2012-03-22  Mark Rowe  mr...@apple.com
+
+Fix the build.
+
+* Configurations/_javascript_Core.xcconfig: Tell the linker to pull in all members from static libraries
+rather than only those that contain symbols that _javascript_Core itself uses.
+* _javascript_Core.xcodeproj/project.pbxproj: Remove some bogus settings that crept in to the Xcode project.
+
 2012-03-22  Filip Pizlo  fpi...@apple.com
 
 DFG NodeFlags has some duplicate code and naming issues


Modified: trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig (111785 => 111786)

--- trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig	2012-03-22 23:46:29 UTC (rev 111785)
+++ trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig	2012-03-22 23:47:50 UTC (rev 111786)
@@ -34,7 +34,7 @@
 JSVALUE_MODEL_x86_64 = 64;
 
 // Prevent C++ standard library operator new, delete and their related exception types from being exported as weak symbols.
-OTHER_LDFLAGS_HIDE_SYMBOLS = -Wl,-unexported_symbol -Wl,__ZTISt9bad_alloc -Wl,-unexported_symbol -Wl,__ZTISt9exception -Wl,-unexported_symbol -Wl,__ZTSSt9bad_alloc -Wl,-unexported_symbol -Wl,__ZTSSt9exception -Wl,-unexported_symbol -Wl,__ZdlPvS_ -Wl,-unexported_symbol -Wl,__ZnwmPv;
+OTHER_LDFLAGS_HIDE_SYMBOLS = -Wl,-unexported_symbol -Wl,__ZTISt9bad_alloc -Wl,-unexported_symbol -Wl,__ZTISt9exception -Wl,-unexported_symbol -Wl,__ZTSSt9bad_alloc -Wl,-unexported_symbol -Wl,__ZTSSt9exception -Wl,-unexported_symbol -Wl,__ZdlPvS_ -Wl,-unexported_symbol -Wl,__ZnwmPv -Wl,-all_load;
 OTHER_LDFLAGS_BASE = -lobjc -Wl,-Y,3 $(OTHER_LDFLAGS_HIDE_SYMBOLS);
 OTHER_LDFLAGS = $(OTHER_LDFLAGS_$(REAL_PLATFORM_NAME));
 OTHER_LDFLAGS_iphoneos = $(OTHER_LDFLAGS_BASE);


Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (111785 => 111786)

--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2012-03-22 23:46:29 UTC (rev 111785)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2012-03-22 23:47:50 UTC (rev 111786)
@@ -3182,10 +3182,6 @@
 			baseConfigurationReference = 1C9051430BA9E8A70081E9D0 /* _javascript_Core.xcconfig */;
 			buildSettings = {
 INSTALL_PATH = $(BUILT_PRODUCTS_DIR);
-LIBRARY_SEARCH_PATHS = (
-	$(inherited),
-	\$(SRCROOT)/../../WebKitBuild/Release\,
-);
 			};
 			name = Debug;
 		};
@@ -3194,10 +3190,6 @@
 			baseConfigurationReference = 1C9051430BA9E8A70081E9D0 /* _javascript_Core.xcconfig */;
 			buildSettings = {
 INSTALL_PATH = $(BUILT_PRODUCTS_DIR);
-LIBRARY_SEARCH_PATHS = (
-	$(inherited),
-	\$(SRCROOT)/../../WebKitBuild/Release\,
-);
 			};
 			name = Release;
 		};
@@ -3206,10 +3198,6 @@
 			baseConfigurationReference = 1C9051430BA9E8A70081E9D0 /* _javascript_Core.xcconfig */;
 			buildSettings = {
 BUILD_VARIANTS = normal;
-LIBRARY_SEARCH_PATHS = (
-	$(inherited),
-	\$(SRCROOT)/../../WebKitBuild/Release\,
-);
 			};
 			name = Production;
 		};
@@ -3371,10 +3359,6 @@
 			baseConfigurationReference = 1C9051430BA9E8A70081E9D0 /* _javascript_Core.xcconfig */;
 			buildSettings = {
 INSTALL_PATH = $(BUILT_PRODUCTS_DIR);
-LIBRARY_SEARCH_PATHS = (
-	$(inherited),
-	\$(SRCROOT)/../../WebKitBuild/Release\,
-);
 			};
 			name = Profiling;
 		};






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111788] trunk/Source/WTF

[mrobinson]

Title: [111788] trunk/Source/WTF








Revision 111788
Author mrobin...@webkit.org
Date 2012-03-22 17:09:11 -0700 (Thu, 22 Mar 2012)


Log Message
One more GTK+ build fix after r111778.

* GNUmakefile.am: Adding missing include path.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/GNUmakefile.am




Diff

Modified: trunk/Source/WTF/ChangeLog (111787 => 111788)

--- trunk/Source/WTF/ChangeLog	2012-03-22 23:50:18 UTC (rev 111787)
+++ trunk/Source/WTF/ChangeLog	2012-03-23 00:09:11 UTC (rev 111788)
@@ -1,5 +1,11 @@
 2012-03-22  Martin Robinson  mrobin...@igalia.com
 
+One more GTK+ build fix after r111778.
+
+* GNUmakefile.am: Adding missing include path.
+
+2012-03-22  Martin Robinson  mrobin...@igalia.com
+
 Fixed the GTK+ WTF/_javascript_Core build after r111778.
 
 * GNUmakefile.am: Remove some extra trailing backslashes and a few uncessary


Modified: trunk/Source/WTF/GNUmakefile.am (111787 => 111788)

--- trunk/Source/WTF/GNUmakefile.am	2012-03-22 23:50:18 UTC (rev 111787)
+++ trunk/Source/WTF/GNUmakefile.am	2012-03-23 00:09:11 UTC (rev 111788)
@@ -29,4 +29,5 @@
 libWTF_la_CPPFLAGS = \
 	$(global_cppflags) \
 	-I$(srcdir)/Source \
-	-I$(srcdir)/Source/WTF
+	-I$(srcdir)/Source/WTF \
+	-I$(srcdir)/Source/WTF/wtf






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111789] trunk/Source/WebCore

[benjamin]

Title: [111789] trunk/Source/WebCore








Revision 111789
Author benja...@webkit.org
Date 2012-03-22 17:13:01 -0700 (Thu, 22 Mar 2012)


Log Message
Remove an obsolete comment regarding magic frames from Geolocation
https://bugs.webkit.org/show_bug.cgi?id=81871

Patch by Benjamin Poulain bpoul...@apple.com on 2012-03-22
Reviewed by Alexey Proskuryakov.

Moving a frame into another document is no longer possible after r111361. The comment
is now irrelevant.

* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::stop):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (111788 => 111789)

--- trunk/Source/WebCore/ChangeLog	2012-03-23 00:09:11 UTC (rev 111788)
+++ trunk/Source/WebCore/ChangeLog	2012-03-23 00:13:01 UTC (rev 111789)
@@ -1,3 +1,16 @@
+2012-03-22  Benjamin Poulain  bpoul...@apple.com
+
+Remove an obsolete comment regarding magic frames from Geolocation
+https://bugs.webkit.org/show_bug.cgi?id=81871
+
+Reviewed by Alexey Proskuryakov.
+
+Moving a frame into another document is no longer possible after r111361. The comment
+is now irrelevant.
+
+* Modules/geolocation/Geolocation.cpp:
+(WebCore::Geolocation::stop):
+
 2012-03-22  Csaba Osztrogonác  o...@webkit.org
 
 Actually move WTF files to their new home


Modified: trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp (111788 => 111789)

--- trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp	2012-03-23 00:09:11 UTC (rev 111788)
+++ trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp	2012-03-23 00:13:01 UTC (rev 111789)
@@ -256,12 +256,6 @@
 
 void Geolocation::stop()
 {
-// FIXME: We should ideally allow existing Geolocation activities to continue
-// when the Geolocation's iframe is reparented. (Assuming we continue to
-// support reparenting iframes.)
-// See https://bugs.webkit.org/show_bug.cgi?id=55577
-// and https://bugs.webkit.org/show_bug.cgi?id=52877
-
 Page* page = this-page();
 if (page  m_allowGeolocation == InProgress)
 page-geolocationController()-cancelPermissionRequest(this);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111790] trunk/Source/WTF

[eric]

Title: [111790] trunk/Source/WTF








Revision 111790
Author e...@webkit.org
Date 2012-03-22 17:17:37 -0700 (Thu, 22 Mar 2012)


Log Message
One more GTK+ build fix after r111778.

Patch by Martin Robinson mrobin...@igalia.com on 2012-03-22

* GNUmakefile.am: Adding missing include path.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.vcproj/WTFCommon.vsprops




Diff

Modified: trunk/Source/WTF/ChangeLog (111789 => 111790)

--- trunk/Source/WTF/ChangeLog	2012-03-23 00:13:01 UTC (rev 111789)
+++ trunk/Source/WTF/ChangeLog	2012-03-23 00:17:37 UTC (rev 111790)
@@ -33,6 +33,15 @@
 Actually move WTF files to their new home
 https://bugs.webkit.org/show_bug.cgi?id=81844
 
+Unreviewed attempt to fix AppleWin.
+
+* WTF.vcproj/WTFCommon.vsprops:
+
+2012-03-22  Eric Seidel  e...@webkit.org
+
+Actually move WTF files to their new home
+https://bugs.webkit.org/show_bug.cgi?id=81844
+
 Unreviewed.  The 5MB file move is not very reviewable,
 but various port representatives have OK'd changes to the
 individual build systems.


Modified: trunk/Source/WTF/WTF.vcproj/WTFCommon.vsprops (111789 => 111790)

--- trunk/Source/WTF/WTF.vcproj/WTFCommon.vsprops	2012-03-23 00:13:01 UTC (rev 111789)
+++ trunk/Source/WTF/WTF.vcproj/WTFCommon.vsprops	2012-03-23 00:17:37 UTC (rev 111790)
@@ -7,7 +7,7 @@
 	
 	Tool
 		Name=VCCLCompilerTool
-		AdditionalIncludeDirectories=../../_javascript_Core/;../../_javascript_Core/wtf/;../../_javascript_Core/wtf/threads;../../_javascript_Core/wtf/unicode/;quot;$(ConfigurationBuildDir)\include\privatequot;;quot;$(WebKitLibrariesDir)\includequot;;quot;$(ConfigurationBuildDir)\include\_javascript_Corequot;;quot;$(WebKitLibrariesDir)\include\pthreadsquot;
+		AdditionalIncludeDirectories=../;../wtf/;../wtf/threads/;../wtf/unicode/;quot;$(ConfigurationBuildDir)\include\privatequot;;quot;$(WebKitLibrariesDir)\includequot;;quot;$(ConfigurationBuildDir)\include\_javascript_Corequot;;quot;$(WebKitLibrariesDir)\include\pthreadsquot;
 		PreprocessorDefinitions=__STD_C
 		ProgramDataBaseFileName=$(OutDir)\$(TargetName).vc80.pdb
 		ForcedIncludeFiles=ICUVersion.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111791] trunk

[tony]

Title: [111791] trunk








Revision 111791
Author t...@chromium.org
Date 2012-03-22 17:18:56 -0700 (Thu, 22 Mar 2012)


Log Message
Unreviewed, fix chromium build after wtf move.

Source/_javascript_Core:

Remove old wtf_config and wtf targets.

* _javascript_Core.gyp/_javascript_Core.gyp:

Source/Platform:

Only use newwtf, remove references to wtf.

* Platform.gyp/Platform.gyp:

Source/WebCore:

Only use newwtf, remove references to wtf.

* WebCore.gyp/WebCore.gyp:

Source/WTF:

Move wtf_config and wtf settings to newwtf.

* WTF.gyp/WTF.gyp:

Tools:

Only use newwtf, remove references to wtf.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp
trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gyp/Platform.gyp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.gyp/WTF.gyp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (111790 => 111791)

--- trunk/Source/_javascript_Core/ChangeLog	2012-03-23 00:17:37 UTC (rev 111790)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-03-23 00:18:56 UTC (rev 111791)
@@ -1,3 +1,11 @@
+2012-03-22  Tony Chang  t...@chromium.org
+
+Unreviewed, fix chromium build after wtf move.
+
+Remove old wtf_config and wtf targets.
+
+* _javascript_Core.gyp/_javascript_Core.gyp:
+
 2012-03-22  Martin Robinson  mrobin...@igalia.com
 
 Fixed the GTK+ WTF/_javascript_Core build after r111778.


Modified: trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp (111790 => 111791)

--- trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp	2012-03-23 00:17:37 UTC (rev 111790)
+++ trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp	2012-03-23 00:18:56 UTC (rev 111791)
@@ -57,146 +57,9 @@
   ],
   'targets': [
 {
-  # This target sets up defines and includes that are required by WTF and
-  # its dependents.
-  'target_name': 'wtf_config',
-  'type': 'none',
-  'direct_dependent_settings': {
-'defines': [
-  # Import features_defines from features.gypi
-  '@(feature_defines)',
-
-  # Turns on #if PLATFORM(CHROMIUM)
-  'BUILDING_CHROMIUM__=1',
-  # Controls wtf/FastMalloc
-  # FIXME: consider moving into config.h
-  'USE_SYSTEM_MALLOC=1',
-],
-'conditions': [
-  ['OS==win', {
-'defines': [
-  '__STD_C',
-  '_CRT_SECURE_NO_DEPRECATE',
-  '_SCL_SECURE_NO_DEPRECATE',
-  'CRASH=__debugbreak',
-],
-'include_dirs': [
-  '../os-win32',
-],
-  }],
-  ['OS==mac', {
-'defines': [
-  # Use USE_NEW_THEME on Mac.
-  'WTF_USE_NEW_THEME=1',
-],
-  }],
-  ['os_posix == 1 and OS != mac', {
-'defines': [
-  'WTF_USE_PTHREADS=1',
-],
-  }],
-],
-  }
-},
-{
-  'target_name': 'wtf',
-  'type': 'static_library',
-  'variables': { 'optimize': 'max' },
-  'dependencies': [
-'wtf_config',
-'(chromium_src_dir)/third_party/icu/icu.gyp:icui18n',
-'(chromium_src_dir)/third_party/icu/icu.gyp:icuuc',
-'../../WTF/WTF.gyp/WTF.gyp:newwtf',
-  ],
-  'include_dirs': [
-'../',
-'../wtf', # Some .cpp expect #include Assertions.h, etc. to work.
-'../wtf/unicode', # Likewise some expect #include Collator.h to work.
-  ],
-  'sources': [
-'@(_javascript_core_publicheader_files)',
-'@(_javascript_core_privateheader_files)',
-'@(_javascript_core_files)',
-  ],
-  'sources/': [
-# First exclude everything ...
-['exclude', '../'],
-# ... Then include what we want.
-['include', '../wtf/'],
-# FIXME: This is clearly not sustainable.
-['exclude', '../wtf/efl'],
-['exclude', '../wtf/gobject'],
-['exclude', '../wtf/gtk'],
-['exclude', '../wtf/mac'],
-['exclude', '../wtf/qt'],
-['exclude', '../wtf/url'],
-['exclude', '../wtf/wince'],
-['exclude', '../wtf/wx'],
-['exclude', '../wtf/unicode/wince'],
-['exclude', '../wtf/unicode/glib'],
-['exclude', '../wtf/unicode/qt4'],
-# GLib/GTK, even though its name doesn't really indicate.
-['exclude', '/(gtk|glib|gobject)/.*\\.(cpp|h)$'],
-['exclude', '(Default|Gtk|Mac|None|Qt|Win|Wx|Efl|Symbian)\\.(cpp|mm)$'],
-['exclude', 'wtf/CurrentTime\\.cpp$'],
-['exclude', 'wtf/OSRandomSource\\.cpp$'],
-['exclude', 'wtf/MainThread.cpp$'],
-['exclude',