date:20121015

[webkit-changes] [131421] trunk

2012-10-15 Thread tkent

Title: [131421] trunk








Revision 131421
Author tk...@chromium.org
Date 2012-10-15 23:54:46 -0700 (Mon, 15 Oct 2012)


Log Message
Fix some appearance glitches of multiple fields input elements
https://bugs.webkit.org/show_bug.cgi?id=99412

Reviewed by Kentaro Hara.

Source/WebCore:

1. If CSS-specified width is wider than the intrinsic width of an input,
the spin button and the picker indicator triangle should be put at the
right side of the content area.

2. Remove top, right, and bottom paddings to match input[type=number]
appearance as possible.

3. Remove unnecessary position:relative for spin buttons.

4. Center content vertically if the height is taller than the intrinsic height.

Tests: Update all of rendering tests for input element with multiple fields UI.

* css/html.css:
(input[type="date"]):
- Specify display:-webkit-inline-flex and -webkit-align-items:stretch to center contents.
- Remove top/right/bottom paddings.
(input[type="datetime"]): Ditto.
(input[type="datetime-local"]): Ditto.
(input[type="month"]): Ditto.
(input[type="time"]): Ditto.
(input[type="week"]): Ditto.
(input::-webkit-datetime-edit):
- Switch to the starndard flexible box from the legacy one.
- Add white-space:pre to avoid to collapse white spaces.
(input::-webkit-datetime-edit-gap):
Added. This element is added to push a spin button to the right side.
(input::-webkit-date-and-time-container):
Add -webkit-flex:1 for the input flexible box.
Sort properties.
(input[type="week"]::-webkit-inner-spin-button):
- Use this in date, datetime, datetime-local, and week types.
- Add display:inline-block because other elements in -webkit-datetime-edit is inilne.
- Add position:static to cancel position:relative below.

* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::layout):
Add an element with -webkit-datetime-edit-gap before a spin button.

LayoutTests:

All of rendering tests for multiple fields inputs need rebaseline
because of the padding change.

* fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt:
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html:
Add a fixed height case.
* platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt
trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/html.css
trunk/Source/WebCore/html/shadow/DateTimeEditElement.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (131420 => 131421)

--- trunk/LayoutTests/ChangeLog	2012-10-16 06:50:00 UTC (rev 131420)
+++ trunk/LayoutTests/ChangeLog	2012-10-16 06:54:46 UTC (rev 131421)
@@ -1,3 +1,20 @@
+2012-10-15  Kent Tamura  
+
+Fix some appearance glitches of multiple fields input elements
+https://bugs.webkit.org/show_bug.cgi?id=99412
+
+Reviewed by Kentaro Hara.
+
+All of rendering tests for multiple fields inputs need rebaseline
+because of the padding change.
+
+* fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt:
+* fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html:
+Add a fixed height case.
+* platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
+* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
+* platform/chromium/TestExpectations:
+
 2012-10-16  Keishi Hattori  
 
 [Chromium] Mark date-suggestion-picker-appearance.html as need rebaseline


Modified: trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt (131420 => 131421)

--- trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt	2012-10-16 06:50:00 UTC (rev 131420)
+++ trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt	2012-10-16 06:54:46 UTC (rev 131421)
@@ -3,3 +3,4 @@
 background, color: 
 font-size: 
 font-size with fixed input width: 
+Fixed input height: 


Modified: trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html (131420 => 131421)

--- trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html	2012-10-16 06:50:

[webkit-changes] [131420] trunk/LayoutTests

2012-10-15 Thread keishi

Title: [131420] trunk/LayoutTests








Revision 131420
Author kei...@webkit.org
Date 2012-10-15 23:50:00 -0700 (Mon, 15 Oct 2012)


Log Message
[Chromium] Mark date-suggestion-picker-appearance.html as need rebaseline

Unreviewed.

Mark date-suggestion-picker-appearance.html as need rebaseline until chromium side change lands.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (131419 => 131420)

--- trunk/LayoutTests/ChangeLog	2012-10-16 06:41:58 UTC (rev 131419)
+++ trunk/LayoutTests/ChangeLog	2012-10-16 06:50:00 UTC (rev 131420)
@@ -1,3 +1,13 @@
+2012-10-16  Keishi Hattori  
+
+[Chromium] Mark date-suggestion-picker-appearance.html as need rebaseline
+
+Unreviewed.
+
+Mark date-suggestion-picker-appearance.html as need rebaseline until chromium side change lands.
+
+* platform/chromium/TestExpectations:
+
 2012-10-15  Keishi Hattori  
 
 Move suggestion picker tests to suggestion-picker directory


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (131419 => 131420)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-16 06:41:58 UTC (rev 131419)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-16 06:50:00 UTC (rev 131420)
@@ -3890,6 +3890,7 @@
 webkit.org/b/99291 fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic.html [ Pass ImageOnlyFailure ]
 webkit.org/b/99291 [ Mac Linux Win ] platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl.html [ Pass ImageOnlyFailure ]
 webkit.org/b/99291 [ Mac Linux Win ] platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl.html [ Pass ImageOnlyFailure ]
+webkit.org/b/99421 platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance.html [ Pass ImageOnlyFailure ]
 
 webkit.org/b/96549 [ Mac Android ] platform/chromium/virtual/gpu/fast/hidpi/focus-rings.html [ ImageOnlyFailure ]
 webkit.org/b/96549 [ Mac ] platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131419] trunk/Source/WebCore

2012-10-15 Thread yurys

Title: [131419] trunk/Source/WebCore








Revision 131419
Author yu...@chromium.org
Date 2012-10-15 23:41:58 -0700 (Mon, 15 Oct 2012)


Log Message
Web Inspector: can't click delete button if watch _expression_ is very long
https://bugs.webkit.org/show_bug.cgi?id=99414

Reviewed by Vsevolod Vlasov.

Minus button in watch _expression_ section doesn't overlap with the
_expression_/value anymore.

* inspector/front-end/inspector.css:
(.properties-tree.watch-expressions > li.hovered):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/inspector.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (131418 => 131419)

--- trunk/Source/WebCore/ChangeLog	2012-10-16 06:38:26 UTC (rev 131418)
+++ trunk/Source/WebCore/ChangeLog	2012-10-16 06:41:58 UTC (rev 131419)
@@ -1,3 +1,16 @@
+2012-10-15  Yury Semikhatsky  
+
+Web Inspector: can't click delete button if watch _expression_ is very long
+https://bugs.webkit.org/show_bug.cgi?id=99414
+
+Reviewed by Vsevolod Vlasov.
+
+Minus button in watch _expression_ section doesn't overlap with the
+_expression_/value anymore.
+
+* inspector/front-end/inspector.css:
+(.properties-tree.watch-expressions > li.hovered):
+
 2012-10-15  Sheriff Bot  
 
 Unreviewed, rolling out r131403.


Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (131418 => 131419)

--- trunk/Source/WebCore/inspector/front-end/inspector.css	2012-10-16 06:38:26 UTC (rev 131418)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css	2012-10-16 06:41:58 UTC (rev 131419)
@@ -1596,6 +1596,10 @@
 padding-left: 15px;
 }
 
+.properties-tree.watch-expressions > li.hovered {
+padding-right: 14px;
+}
+
 .watch-expressions > li.editing-sub-part .text-prompt {
 display: block;
 width: 100%;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131418] trunk/Source/WebCore

2012-10-15 Thread commit-queue

Title: [131418] trunk/Source/WebCore








Revision 131418
Author commit-qu...@webkit.org
Date 2012-10-15 23:38:26 -0700 (Mon, 15 Oct 2012)


Log Message
Unreviewed, rolling out r131403.
http://trac.webkit.org/changeset/131403
https://bugs.webkit.org/show_bug.cgi?id=99420

Suspicious to cause Performance test failing (Requested by
shinyak|gardenin on #webkit).

Patch by Sheriff Bot  on 2012-10-15

* dom/Document.cpp:
(WebCore::Document::isValidName):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (131417 => 131418)

--- trunk/Source/WebCore/ChangeLog	2012-10-16 06:37:24 UTC (rev 131417)
+++ trunk/Source/WebCore/ChangeLog	2012-10-16 06:38:26 UTC (rev 131418)
@@ -1,3 +1,15 @@
+2012-10-15  Sheriff Bot  
+
+Unreviewed, rolling out r131403.
+http://trac.webkit.org/changeset/131403
+https://bugs.webkit.org/show_bug.cgi?id=99420
+
+Suspicious to cause Performance test failing (Requested by
+shinyak|gardenin on #webkit).
+
+* dom/Document.cpp:
+(WebCore::Document::isValidName):
+
 2012-10-15  Yury Semikhatsky  
 
 Web Inspector: restore watch _expression_ expansion state


Modified: trunk/Source/WebCore/dom/Document.cpp (131417 => 131418)

--- trunk/Source/WebCore/dom/Document.cpp	2012-10-16 06:37:24 UTC (rev 131417)
+++ trunk/Source/WebCore/dom/Document.cpp	2012-10-16 06:38:26 UTC (rev 131418)
@@ -3923,19 +3923,6 @@
 return String::format("%02d/%02d/%04d %02d:%02d:%02d", date.month() + 1, date.monthDay(), date.fullYear(), date.hour(), date.minute(), date.second());
 }
 
-static bool isValidNameNonASCII(const LChar* characters, unsigned length)
-{
-if (!isValidNameStart(characters[0]))
-return false;
-
-for (unsigned i = 1; i < length; ++i) {
-if (!isValidNamePart(characters[i]))
-return false;
-}
-
-return true;
-}
-
 static bool isValidNameNonASCII(const UChar* characters, unsigned length)
 {
 unsigned i = 0;
@@ -3976,20 +3963,16 @@
 if (!length)
 return false;
 
+const UChar* characters;
 if (name.is8Bit()) {
-const LChar* characters = name.characters8();
-
+if (isValidNameASCII(name.characters8(), length))
+return true;
+characters = name.characters();
+} else {
+characters = name.characters16();
 if (isValidNameASCII(characters, length))
 return true;
-
-return isValidNameNonASCII(characters, length);
 }
-
-const UChar* characters = name.characters16();
-
-if (isValidNameASCII(characters, length))
-return true;
-
 return isValidNameNonASCII(characters, length);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131417] trunk/Source/WebKit2

2012-10-15 Thread commit-queue

Title: [131417] trunk/Source/WebKit2








Revision 131417
Author commit-qu...@webkit.org
Date 2012-10-15 23:37:24 -0700 (Mon, 15 Oct 2012)


Log Message
[EFL][WK2] Regression(r131337): Made 3 Cookie Manager API tests fail
https://bugs.webkit.org/show_bug.cgi?id=99416

Patch by Christophe Dumez  on 2012-10-15
Reviewed by Gyuyoung Kim.

After r131337, the favicon database is enabled and it causes new
requests to "/favicon.ico" on the http server. The http server used
in the cookie manager test was too strict and was calling FAIL() for
any unrecognized HTTP request (such as the one to /favicon.ico).
This patch makes the http server in cookie manager API tests less
strict.

* UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(serverCallback):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (131416 => 131417)

--- trunk/Source/WebKit2/ChangeLog	2012-10-16 06:31:04 UTC (rev 131416)
+++ trunk/Source/WebKit2/ChangeLog	2012-10-16 06:37:24 UTC (rev 131417)
@@ -1,3 +1,20 @@
+2012-10-15  Christophe Dumez  
+
+[EFL][WK2] Regression(r131337): Made 3 Cookie Manager API tests fail
+https://bugs.webkit.org/show_bug.cgi?id=99416
+
+Reviewed by Gyuyoung Kim.
+
+After r131337, the favicon database is enabled and it causes new
+requests to "/favicon.ico" on the http server. The http server used
+in the cookie manager test was too strict and was calling FAIL() for
+any unrecognized HTTP request (such as the one to /favicon.ico).
+This patch makes the http server in cookie manager API tests less
+strict.
+
+* UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
+(serverCallback):
+
 2012-10-15  Gyuyoung Kim  
 
 Unreviewed, rolling out r131349.


Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp (131416 => 131417)

--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp	2012-10-16 06:31:04 UTC (rev 131416)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp	2012-10-16 06:37:24 UTC (rev 131417)
@@ -61,7 +61,8 @@
 } else if (!strcmp(path, "/image.png"))
 soup_message_headers_replace(message->response_headers, "Set-Cookie", "baz=qux; Max-Age=60");
 else
-FAIL();
+soup_message_set_status(message, SOUP_STATUS_NOT_FOUND);
+
 soup_message_body_complete(message->response_body);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131416] trunk/Tools

2012-10-15 Thread commit-queue

Title: [131416] trunk/Tools








Revision 131416
Author commit-qu...@webkit.org
Date 2012-10-15 23:31:04 -0700 (Mon, 15 Oct 2012)


Log Message
[EFL][WK2] Display page favicons in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=99265

Patch by Christophe Dumez  on 2012-10-15
Reviewed by Gyuyoung Kim.

Display current page favicon in the URL bar.
This uses the new favicon database API in
EFL WebKit2.

* MiniBrowser/efl/main.c:
(on_favicon_received):
(on_view_icon_changed):
(window_create):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/efl/main.c




Diff

Modified: trunk/Tools/ChangeLog (131415 => 131416)

--- trunk/Tools/ChangeLog	2012-10-16 06:25:22 UTC (rev 131415)
+++ trunk/Tools/ChangeLog	2012-10-16 06:31:04 UTC (rev 131416)
@@ -1,3 +1,19 @@
+2012-10-15  Christophe Dumez  
+
+[EFL][WK2] Display page favicons in MiniBrowser
+https://bugs.webkit.org/show_bug.cgi?id=99265
+
+Reviewed by Gyuyoung Kim.
+
+Display current page favicon in the URL bar.
+This uses the new favicon database API in
+EFL WebKit2.
+
+* MiniBrowser/efl/main.c:
+(on_favicon_received):
+(on_view_icon_changed):
+(window_create):
+
 2012-10-15  Simon Fraser  
 
 Update the url bar in MiniBrowser when getting the committed URL


Modified: trunk/Tools/MiniBrowser/efl/main.c (131415 => 131416)

--- trunk/Tools/MiniBrowser/efl/main.c	2012-10-16 06:25:22 UTC (rev 131415)
+++ trunk/Tools/MiniBrowser/efl/main.c	2012-10-16 06:31:04 UTC (rev 131416)
@@ -322,6 +322,45 @@
 info("Download failed!\n");
 }
 
+static void
+on_favicon_received(const char *page_url, Evas_Object *icon, void *event_info)
+{
+Browser_Window *app_data = (Browser_Window *)event_info;
+if (strcmp(page_url, ewk_view_url_get(app_data->webview)))
+return;
+
+/* Remove previous icon from URL bar */
+Evas_Object *old_icon = elm_object_part_content_unset(app_data->url_bar, "icon");
+if (old_icon) {
+evas_object_unref(old_icon);
+evas_object_del(old_icon);
+}
+
+/* Show new icon in URL bar */
+if (icon) {
+/* Workaround for icon display bug:
+ * http://trac.enlightenment.org/e/ticket/1616 */
+evas_object_size_hint_min_set(icon, 48, 24);
+evas_object_image_filled_set(icon, EINA_FALSE);
+evas_object_image_fill_set(icon, 24, 0, 24, 24);
+elm_object_part_content_set(app_data->url_bar, "icon", icon);
+evas_object_ref(icon);
+}
+}
+
+static void
+on_view_icon_changed(void *user_data, Evas_Object *webview, void *event_info)
+{
+Browser_Window *app_data = (Browser_Window *)user_data;
+/* Retrieve the view's favicon */
+Ewk_Context *context = ewk_view_context_get(webview);
+Ewk_Favicon_Database *icon_database = ewk_context_favicon_database_get(context);
+
+const char *page_url = ewk_view_url_get(webview);
+Evas *evas = evas_object_evas_get(webview);
+ewk_favicon_database_async_icon_get(icon_database, page_url, evas, on_favicon_received, app_data);
+}
+
 static int
 quit(Eina_Bool success, const char *msg)
 {
@@ -610,6 +649,7 @@
 /* Create URL bar */
 app_data->url_bar = elm_entry_add(app_data->window);
 elm_entry_scrollable_set(app_data->url_bar, EINA_TRUE);
+elm_entry_scrollbar_policy_set(app_data->url_bar, ELM_SCROLLER_POLICY_OFF, ELM_SCROLLER_POLICY_OFF);
 elm_entry_single_line_set(app_data->url_bar, EINA_TRUE);
 elm_entry_cnp_mode_set(app_data->url_bar, ELM_CNP_MODE_PLAINTEXT);
 elm_entry_text_style_user_push(app_data->url_bar, "DEFAULT='font_size=18'");
@@ -657,6 +697,7 @@
 evas_object_smart_callback_add(app_data->webview, "download,failed", on_download_failed, app_data);
 evas_object_smart_callback_add(app_data->webview, "download,finished", on_download_finished, app_data);
 evas_object_smart_callback_add(app_data->webview, "download,request", on_download_request, app_data);
+evas_object_smart_callback_add(app_data->webview, "icon,changed", on_view_icon_changed, app_data);
 evas_object_smart_callback_add(app_data->webview, "load,error", on_error, app_data);
 evas_object_smart_callback_add(app_data->webview, "load,progress", on_progress, app_data);
 evas_object_smart_callback_add(app_data->webview, "title,changed", on_title_changed, app_data);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131414] trunk

2012-10-15 Thread yurys

Title: [131414] trunk








Revision 131414
Author yu...@chromium.org
Date 2012-10-15 22:54:32 -0700 (Mon, 15 Oct 2012)


Log Message
Web Inspector: restore watch _expression_ expansion state
https://bugs.webkit.org/show_bug.cgi?id=99304

Reviewed by Pavel Feldman.

Expand watch _expression_ value and its properties if they were expanded
before update.

Source/WebCore:

Test: inspector/debugger/watch-expressions-preserve-expansion.html

* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionTreeElement.prototype.onexpand):
(WebInspector.WatchExpressionTreeElement.prototype.oncollapse):
(WebInspector.WatchExpressionTreeElement.prototype.onattach):
(WebInspector.WatchExpressionTreeElement.prototype._expression):
(WebInspector.WatchedPropertyTreeElement):
(WebInspector.WatchedPropertyTreeElement.prototype.onattach):
(WebInspector.WatchedPropertyTreeElement.prototype.onexpand):
(WebInspector.WatchedPropertyTreeElement.prototype.oncollapse):
(WebInspector.WatchedPropertyTreeElement.prototype._propertyPath):

LayoutTests:

* inspector/debugger/watch-expressions-preserve-expansion-expected.txt: Added.
* inspector/debugger/watch-expressions-preserve-expansion.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js
trunk/Source/WebCore/inspector/front-end/ScopeChainSidebarPane.js
trunk/Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js


Added Paths

trunk/LayoutTests/inspector/debugger/watch-expressions-preserve-expansion-expected.txt
trunk/LayoutTests/inspector/debugger/watch-expressions-preserve-expansion.html




Diff

Modified: trunk/LayoutTests/ChangeLog (131413 => 131414)

--- trunk/LayoutTests/ChangeLog	2012-10-16 05:25:34 UTC (rev 131413)
+++ trunk/LayoutTests/ChangeLog	2012-10-16 05:54:32 UTC (rev 131414)
@@ -1,3 +1,16 @@
+2012-10-15  Yury Semikhatsky  
+
+Web Inspector: restore watch _expression_ expansion state
+https://bugs.webkit.org/show_bug.cgi?id=99304
+
+Reviewed by Pavel Feldman.
+
+Expand watch _expression_ value and its properties if they were expanded
+before update.
+
+* inspector/debugger/watch-expressions-preserve-expansion-expected.txt: Added.
+* inspector/debugger/watch-expressions-preserve-expansion.html: Added.
+
 2012-10-15  Mike West  
 
 Warn when CSP headers don't separate directives with ';'.


Added: trunk/LayoutTests/inspector/debugger/watch-expressions-preserve-expansion-expected.txt (0 => 131414)

--- trunk/LayoutTests/inspector/debugger/watch-expressions-preserve-expansion-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/debugger/watch-expressions-preserve-expansion-expected.txt	2012-10-16 05:54:32 UTC (rev 131414)
@@ -0,0 +1,29 @@
+Test that watch expressions expansion state is restored after update.
+
+Bug 99304
+Watch expressions added.
+expanded globalObject [object Object]
+expanded foo [object Object]
+expanded bar [object Object]
+Watch expressions expanded.
+  globalObject: Object
+foo: Object
+  bar: Object
+baz: 2012
+__proto__: Object
+  __proto__: Object
+__proto__: Object
+  windowAlias: Window
+error: Execution context with given id not found.
+error: Execution context with given id not found.
+Page reloaded.
+Watch expressions after page reload:
+  globalObject: Object
+foo: Object
+  bar: Object
+baz: 2012
+__proto__: Object
+  __proto__: Object
+__proto__: Object
+  windowAlias: Window
+


Added: trunk/LayoutTests/inspector/debugger/watch-expressions-preserve-expansion.html (0 => 131414)

--- trunk/LayoutTests/inspector/debugger/watch-expressions-preserve-expansion.html	(rev 0)
+++ trunk/LayoutTests/inspector/debugger/watch-expressions-preserve-expansion.html	2012-10-16 05:54:32 UTC (rev 131414)
@@ -0,0 +1,90 @@
+
+
+
+
+var globalObject = {
+foo: {
+bar: {
+baz: 2012
+}
+}
+};
+var windowAlias = window;
+
+var test = function()
+{
+var watchExpressionsSection;
+
+// We need to initialize scripts panel so that watch expressions section is created.
+WebInspector.showPanel("scripts");
+
+watchExpressionsSection = WebInspector.panels.scripts.sidebarPanes.watchExpressions.section;
+watchExpressionsSection.watchExpressions = [];
+watchExpressionsSection.watchExpressions.push("globalObject");
+watchExpressionsSection.watchExpressions.push("windowAlias");
+
+InspectorTest.addSniffer(WebInspector.WatchExpressionsSection.prototype, "updateProperties", step1);
+watchExpressionsSection.update();
+
+function expandProperty(parent, path, callback)
+{
+if (!path.length) return callback();
+var childName = path.shift();
+var child = InspectorTest._findChildPropertyTreeElement(parent, childName);
+if (!child) {
+InspectorTest.addResul

[webkit-changes] [131413] trunk

2012-10-15 Thread mkwst

Title: [131413] trunk








Revision 131413
Author mk...@chromium.org
Date 2012-10-15 22:25:34 -0700 (Mon, 15 Oct 2012)


Log Message
Warn when CSP headers don't separate directives with ';'.
https://bugs.webkit.org/show_bug.cgi?id=99274

Reviewed by Adam Barth.

Source/WebCore:

A recent bug report exhibited confusion as to what role, exactly,
semicolons play in Content Security Policy definitions. This patch
adjusts the parser to warn web authors if a directive name is
encountered while parsing a source list, which would almost certainly
point to a missing semicolon. For example, something like:

script-src 'self' object-src 'self' style-src *

would throw two warnings, noting that 'object-src' and 'style-src' are
probably meant as directives, and not as source expressions in the
'script-src' source list.

Test: http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon.html

* page/ContentSecurityPolicy.cpp:
(WebCore::CSPSourceList::parse):
Throw the new warning onto the console if the hostname of a source
_expression_ matches a CSP directive name.
(WebCore::CSPDirectiveList::addDirective):
Use the exciting new static variables so that the names of various
directives are available outside of CSPDirectiveList::addDirective.
These were previously defined as local static ASCIILiterals. Now
they're static const char[] in an anonymous namespace.
(WebCore::ContentSecurityPolicy::isDirectiveName):
Static method that compares a string to all the known directive
names, returning true if there's a (case-insensitive) match.
(WebCore):
(WebCore::ContentSecurityPolicy::reportDirectiveAsSourceExpression):
A new warning message which should be printed when a directive name
is encountered as a source _expression_. Matching the directive name
is done via a new 'isDirectiveName' function which lives in an
anonymous namespace along with the other CSP helper functions.
* page/ContentSecurityPolicy.h:
Added 'reportDirectiveAsSourceExpression' signature.

LayoutTests:

* http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/ContentSecurityPolicy.cpp
trunk/Source/WebCore/page/ContentSecurityPolicy.h


Added Paths

trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon-expected.txt
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon.html




Diff

Modified: trunk/LayoutTests/ChangeLog (131412 => 131413)

--- trunk/LayoutTests/ChangeLog	2012-10-16 05:16:55 UTC (rev 131412)
+++ trunk/LayoutTests/ChangeLog	2012-10-16 05:25:34 UTC (rev 131413)
@@ -1,3 +1,13 @@
+2012-10-15  Mike West  
+
+Warn when CSP headers don't separate directives with ';'.
+https://bugs.webkit.org/show_bug.cgi?id=99274
+
+Reviewed by Adam Barth.
+
+* http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon-expected.txt: Added.
+* http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon.html: Added.
+
 2012-10-15  Pablo Flouret  
 
 Add force parameter to DOMTokenList.toggle


Added: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon-expected.txt (0 => 131413)

--- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon-expected.txt	2012-10-16 05:25:34 UTC (rev 131413)
@@ -0,0 +1,16 @@
+CONSOLE MESSAGE: The Content Security Policy directive 'default-src' contains 'script-src' as a source _expression_. Did you mean 'default-src ...; script-src...' (note the semicolon)?
+CONSOLE MESSAGE: The Content Security Policy directive 'script-src' contains 'object-src' as a source _expression_. Did you mean 'script-src ...; object-src...' (note the semicolon)?
+CONSOLE MESSAGE: The Content Security Policy directive 'script-src' contains 'style-src' as a source _expression_. Did you mean 'script-src ...; style-src...' (note the semicolon)?
+If a web author forgets a semicolon, we should do our best to warn them that the policy they've defined is probably not what they intended.
+
+
+
+
+Frame: '-->'
+
+PASS
+
+
+Frame: '-->'
+
+PASS


Added: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon.html (0 => 131413)

--- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon.html	(rev 0)
+++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon.html	2012-10-16 05:25:34 UTC (rev 131413)
@@ -0,0 +1,14 @@
+
+
+
+
+
+var tests = [
+

[webkit-changes] [131411] trunk/Source/WebCore

2012-10-15 Thread japhet

Title: [131411] trunk/Source/WebCore








Revision 131411
Author jap...@chromium.org
Date 2012-10-15 22:14:44 -0700 (Mon, 15 Oct 2012)


Log Message
ResourceLoader::sendResourceLoadCallbacks() is backwards
https://bugs.webkit.org/show_bug.cgi?id=99366

Reviewed by Daniel Bates.

No new tests, this function is uncalled but will be used
in a later patch.

* loader/ResourceLoader.h:
(WebCore::ResourceLoader::sendResourceLoadCallbacks):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ResourceLoader.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (131410 => 131411)

--- trunk/Source/WebCore/ChangeLog	2012-10-16 05:07:56 UTC (rev 131410)
+++ trunk/Source/WebCore/ChangeLog	2012-10-16 05:14:44 UTC (rev 131411)
@@ -1,3 +1,16 @@
+2012-10-15  Nate Chapin  
+
+ResourceLoader::sendResourceLoadCallbacks() is backwards
+https://bugs.webkit.org/show_bug.cgi?id=99366
+
+Reviewed by Daniel Bates.
+
+No new tests, this function is uncalled but will be used
+in a later patch.
+
+* loader/ResourceLoader.h:
+(WebCore::ResourceLoader::sendResourceLoadCallbacks):
+
 2012-10-15  Dan Bernstein  
 
 REGRESSION (r131365): WidthIterator::advance() is needlessly passed a GlyphBuffer in many cases


Modified: trunk/Source/WebCore/loader/ResourceLoader.h (131410 => 131411)

--- trunk/Source/WebCore/loader/ResourceLoader.h	2012-10-16 05:07:56 UTC (rev 131410)
+++ trunk/Source/WebCore/loader/ResourceLoader.h	2012-10-16 05:14:44 UTC (rev 131411)
@@ -139,7 +139,7 @@
 
 const KURL& url() const { return m_request.url(); } 
 ResourceHandle* handle() const { return m_handle.get(); }
-bool sendResourceLoadCallbacks() const { return m_options.sendLoadCallbacks; }
+bool sendResourceLoadCallbacks() const { return m_options.sendLoadCallbacks == SendCallbacks; }
 
 bool reachedTerminalState() const { return m_reachedTerminalState; }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131410] trunk/Source/WebCore

2012-10-15 Thread mitz

Title: [131410] trunk/Source/WebCore








Revision 131410
Author m...@apple.com
Date 2012-10-15 22:07:56 -0700 (Mon, 15 Oct 2012)


Log Message
REGRESSION (r131365): WidthIterator::advance() is needlessly passed a GlyphBuffer in many cases
https://bugs.webkit.org/show_bug.cgi?id=99413

Reviewed by Adele Peterson.

r131365 made Font::width() always pass a GlyphBuffer pointer to floatWidthForSimpleText and
from there down to WidthIterator::advance(). However, when measuring the width of a run, a
GlyphBuffer is only needed if font transforms (kerning and ligatures) need to be applied.

No new test, because there is no change in behavior.

* platform/graphics/Font.cpp:
(WebCore::Font::width): Removed the local GlyphBuffer that was passed down to
floatWidthForSimpleText().
* platform/graphics/Font.h: Removed the GlyphBuffer* parameter to floatWidthForSimpleText.
All but the above caller were passing 0.
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::floatWidthForSimpleText): Removed the GlyphBuffer* parameter and added a
local GlyphBuffer, which is passed by reference to WidthIterator::advance() only if
typesetting features require it.
(WebCore::Font::offsetForPositionForSimpleText): Updated for change to
floatWidthForSimpleText.
* platform/graphics/pango/FontPango.cpp:
(WebCore::Font::floatWidthForComplexText): Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Font.cpp
trunk/Source/WebCore/platform/graphics/Font.h
trunk/Source/WebCore/platform/graphics/FontFastPath.cpp
trunk/Source/WebCore/platform/graphics/pango/FontPango.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (131409 => 131410)

--- trunk/Source/WebCore/ChangeLog	2012-10-16 04:42:00 UTC (rev 131409)
+++ trunk/Source/WebCore/ChangeLog	2012-10-16 05:07:56 UTC (rev 131410)
@@ -1,3 +1,30 @@
+2012-10-15  Dan Bernstein  
+
+REGRESSION (r131365): WidthIterator::advance() is needlessly passed a GlyphBuffer in many cases
+https://bugs.webkit.org/show_bug.cgi?id=99413
+
+Reviewed by Adele Peterson.
+
+r131365 made Font::width() always pass a GlyphBuffer pointer to floatWidthForSimpleText and
+from there down to WidthIterator::advance(). However, when measuring the width of a run, a
+GlyphBuffer is only needed if font transforms (kerning and ligatures) need to be applied.
+
+No new test, because there is no change in behavior.
+
+* platform/graphics/Font.cpp:
+(WebCore::Font::width): Removed the local GlyphBuffer that was passed down to
+floatWidthForSimpleText().
+* platform/graphics/Font.h: Removed the GlyphBuffer* parameter to floatWidthForSimpleText.
+All but the above caller were passing 0.
+* platform/graphics/FontFastPath.cpp:
+(WebCore::Font::floatWidthForSimpleText): Removed the GlyphBuffer* parameter and added a
+local GlyphBuffer, which is passed by reference to WidthIterator::advance() only if
+typesetting features require it.
+(WebCore::Font::offsetForPositionForSimpleText): Updated for change to
+floatWidthForSimpleText.
+* platform/graphics/pango/FontPango.cpp:
+(WebCore::Font::floatWidthForComplexText): Ditto.
+
 2012-10-15  Pablo Flouret  
 
 Add force parameter to DOMTokenList.toggle


Modified: trunk/Source/WebCore/platform/graphics/Font.cpp (131409 => 131410)

--- trunk/Source/WebCore/platform/graphics/Font.cpp	2012-10-16 04:42:00 UTC (rev 131409)
+++ trunk/Source/WebCore/platform/graphics/Font.cpp	2012-10-16 05:07:56 UTC (rev 131410)
@@ -187,8 +187,7 @@
 // If the complex text implementation cannot return fallback fonts, avoid
 // returning them for simple text as well.
 static bool returnFallbackFonts = canReturnFallbackFontsForComplexText();
-GlyphBuffer glyphBuffer;
-return floatWidthForSimpleText(run, &glyphBuffer, returnFallbackFonts ? fallbackFonts : 0, codePathToUse == SimpleWithGlyphOverflow || (glyphOverflow && glyphOverflow->computeBounds) ? glyphOverflow : 0);
+return floatWidthForSimpleText(run, returnFallbackFonts ? fallbackFonts : 0, codePathToUse == SimpleWithGlyphOverflow || (glyphOverflow && glyphOverflow->computeBounds) ? glyphOverflow : 0);
 }
 
 return floatWidthForComplexText(run, fallbackFonts, glyphOverflow);
@@ -205,7 +204,7 @@
 glyphName = "";
 
 if (codePath(run) != Complex)
-return floatWidthForSimpleText(run, 0);
+return floatWidthForSimpleText(run);
 
 return floatWidthForComplexText(run);
 }


Modified: trunk/Source/WebCore/platform/graphics/Font.h (131409 => 131410)

--- trunk/Source/WebCore/platform/graphics/Font.h	2012-10-16 04:42:00 UTC (rev 131409)
+++ trunk/Source/WebCore/platform/graphics/Font.h	2012-10-16 05:07:56 UTC (rev 131410)
@@ -223,7 +223,7 @@
 void drawGlyphs(GraphicsContext*, const SimpleFontData*, const GlyphBuffer&, int from, int to, const FloatPoint&) const;
 void drawGlyphBuf

[webkit-changes] [131409] trunk/Source/WebKit/blackberry

2012-10-15 Thread commit-queue

Title: [131409] trunk/Source/WebKit/blackberry








Revision 131409
Author commit-qu...@webkit.org
Date 2012-10-15 21:42:00 -0700 (Mon, 15 Oct 2012)


Log Message
[BlackBerry] Web Inspector: Remove the useless preferences items in "inspectorBB.js"
https://bugs.webkit.org/show_bug.cgi?id=99404

Patch by Peter Wang  on 2012-10-15
Reviewed by George Staikos.

In "inspectorBB.js", remove the useless preferences items to catch up the new code of frontend.

* WebCoreSupport/inspectorBB.js:

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/inspectorBB.js




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (131408 => 131409)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-10-16 03:57:02 UTC (rev 131408)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-10-16 04:42:00 UTC (rev 131409)
@@ -1,3 +1,14 @@
+2012-10-15  Peter Wang  
+
+[BlackBerry] Web Inspector: Remove the useless preferences items in "inspectorBB.js"
+https://bugs.webkit.org/show_bug.cgi?id=99404
+
+Reviewed by George Staikos.
+
+In "inspectorBB.js", remove the useless preferences items to catch up the new code of frontend.
+
+* WebCoreSupport/inspectorBB.js:
+
 2012-10-15  Jakob Petsovits  
 
 [BlackBerry] Only reallocate buffers that were allocated before suspending


Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/inspectorBB.js (131408 => 131409)

--- trunk/Source/WebKit/blackberry/WebCoreSupport/inspectorBB.js	2012-10-16 03:57:02 UTC (rev 131408)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/inspectorBB.js	2012-10-16 04:42:00 UTC (rev 131409)
@@ -17,17 +17,8 @@
  */
 var context = {};
 (function () {
-Preferences.ignoreWhitespace = false;
-Preferences.samplingCPUProfiler = true;
-Preferences.debuggerAlwaysEnabled = true;
-Preferences.profilerAlwaysEnabled = true;
-Preferences.canEditScriptSource = false;
-Preferences._onlineDetectionEnabled_ = false;
-Preferences.nativeInstrumentationEnabled = true;
 // FIXME: Turn this to whatever the value of --enable-file-system for chrome.
 Preferences.fileSystemEnabled = false;
-Preferences.canClearCacheAndCookies = true;
-Preferences.showCookiesTab = true;
 })();
 InspectorFrontendHost.copyText = function(tmp) {
 var encoded = encodeURI(tmp);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131408] trunk

2012-10-15 Thread commit-queue

Title: [131408] trunk








Revision 131408
Author commit-qu...@webkit.org
Date 2012-10-15 20:57:02 -0700 (Mon, 15 Oct 2012)


Log Message
Add force parameter to DOMTokenList.toggle
https://bugs.webkit.org/show_bug.cgi?id=99375

Patch by Pablo Flouret  on 2012-10-15
Reviewed by Darin Adler.

Source/WebCore:

See http://dom.spec.whatwg.org/#dom-domtokenlist-toggle and
https://www.w3.org/Bugs/Public/show_bug.cgi?id=18463

Essentially, the optional boolean force parameter, if present, makes
toggle always add or remove a class.

No new tests, modified fast/dom/HTMLElement/script-tests/class-list.js

* html/DOMTokenList.cpp:
(WebCore::DOMTokenList::toggle):
(WebCore):
* html/DOMTokenList.h:
(DOMTokenList):
* html/DOMTokenList.idl:
New toggle() overload that takes a force parameter and calls
addInternal() or removeInternal() based on it.

LayoutTests:

* fast/dom/HTMLElement/class-list-expected.txt:
* fast/dom/HTMLElement/class-list-quirks-expected.txt:
* fast/dom/HTMLElement/script-tests/class-list.js:
(shouldThrowDOMException):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/HTMLElement/class-list-expected.txt
trunk/LayoutTests/fast/dom/HTMLElement/class-list-quirks-expected.txt
trunk/LayoutTests/fast/dom/HTMLElement/script-tests/class-list.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/DOMTokenList.cpp
trunk/Source/WebCore/html/DOMTokenList.h
trunk/Source/WebCore/html/DOMTokenList.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (131407 => 131408)

--- trunk/LayoutTests/ChangeLog	2012-10-16 03:51:00 UTC (rev 131407)
+++ trunk/LayoutTests/ChangeLog	2012-10-16 03:57:02 UTC (rev 131408)
@@ -1,3 +1,15 @@
+2012-10-15  Pablo Flouret  
+
+Add force parameter to DOMTokenList.toggle
+https://bugs.webkit.org/show_bug.cgi?id=99375
+
+Reviewed by Darin Adler.
+
+* fast/dom/HTMLElement/class-list-expected.txt:
+* fast/dom/HTMLElement/class-list-quirks-expected.txt:
+* fast/dom/HTMLElement/script-tests/class-list.js:
+(shouldThrowDOMException):
+
 2012-10-15  Shinya Kawanaka  
 
 [Chromium] Unreviewed gardening, TestExpectations updated.


Modified: trunk/LayoutTests/fast/dom/HTMLElement/class-list-expected.txt (131407 => 131408)

--- trunk/LayoutTests/fast/dom/HTMLElement/class-list-expected.txt	2012-10-16 03:51:00 UTC (rev 131407)
+++ trunk/LayoutTests/fast/dom/HTMLElement/class-list-expected.txt	2012-10-16 03:57:02 UTC (rev 131408)
@@ -18,10 +18,23 @@
 PASS element.className is " y y "
 PASS element.className is "y"
 Ensure that we can handle empty class name correctly
+PASS element.classList.toggle('x') is true
 PASS element.className is "x"
+PASS element.classList.toggle('x') is false
 PASS element.className is ""
 PASS element.classList.contains('x') is false
 PASS element.classList[1] is undefined.
+Test toggle with force argument
+PASS element.classList.toggle('x', true) is true
+PASS element.className is "x"
+PASS element.classList.toggle('x', true) is true
+PASS element.className is "x"
+PASS element.classList.toggle('x', false) is false
+PASS element.className is ""
+PASS element.classList.toggle('x', false) is false
+PASS element.className is ""
+PASS element.classList.toggle('', true) threw expected DOMException with code 12
+PASS element.classList.toggle('x y', false) threw expected DOMException with code 5
 Testing add in presence of trailing white spaces.
 PASS element.className is "x y"
 PASS element.className is "x\ty"


Modified: trunk/LayoutTests/fast/dom/HTMLElement/class-list-quirks-expected.txt (131407 => 131408)

--- trunk/LayoutTests/fast/dom/HTMLElement/class-list-quirks-expected.txt	2012-10-16 03:51:00 UTC (rev 131407)
+++ trunk/LayoutTests/fast/dom/HTMLElement/class-list-quirks-expected.txt	2012-10-16 03:57:02 UTC (rev 131408)
@@ -18,10 +18,23 @@
 PASS element.className is " y y "
 PASS element.className is "y"
 Ensure that we can handle empty class name correctly
+PASS element.classList.toggle('x') is true
 PASS element.className is "x"
+PASS element.classList.toggle('x') is false
 PASS element.className is ""
 PASS element.classList.contains('x') is false
 PASS element.classList[1] is undefined.
+Test toggle with force argument
+PASS element.classList.toggle('x', true) is true
+PASS element.className is "x"
+PASS element.classList.toggle('x', true) is true
+PASS element.className is "x"
+PASS element.classList.toggle('x', false) is false
+PASS element.className is ""
+PASS element.classList.toggle('x', false) is false
+PASS element.className is ""
+PASS element.classList.toggle('', true) threw expected DOMException with code 12
+PASS element.classList.toggle('x y', false) threw expected DOMException with code 5
 Testing add in presence of trailing white spaces.
 PASS element.className is "x y"
 PASS element.className is "x\ty"


Modified: trunk/LayoutTests/fast/dom/HTMLElement/script-tests/class-list.js (131407 => 131408)

--- trunk/LayoutTests/fast/dom/HTMLElement/script-tests/cla

[webkit-changes] [131407] trunk/LayoutTests

2012-10-15 Thread shinyak

Title: [131407] trunk/LayoutTests








Revision 131407
Author shin...@chromium.org
Date 2012-10-15 20:51:00 -0700 (Mon, 15 Oct 2012)


Log Message
[Chromium] Unreviewed gardening, TestExpectations updated.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (131406 => 131407)

--- trunk/LayoutTests/ChangeLog	2012-10-16 03:48:58 UTC (rev 131406)
+++ trunk/LayoutTests/ChangeLog	2012-10-16 03:51:00 UTC (rev 131407)
@@ -1,3 +1,9 @@
+2012-10-15  Shinya Kawanaka  
+
+[Chromium] Unreviewed gardening, TestExpectations updated.
+
+* platform/chromium/TestExpectations:
+
 2012-10-15  Keishi Hattori  
 
 Add tests for suggestion picker that test step/min/max attributes


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (131406 => 131407)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-16 03:48:58 UTC (rev 131406)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-16 03:51:00 UTC (rev 131407)
@@ -1037,7 +1037,8 @@
 webkit.org/b/82894 [ Debug ] inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
 
 webkit.org/b/60109 [ Win Release ] inspector/elements/edit-dom-actions.html [ Failure Pass ]
-webkit.org/b/60109 [ Win Debug ] inspector/elements/edit-dom-actions.html [ Skip ]
+webkit.org/b/60109 [ Win Debug ] inspector/elements/edit-dom-actions.html [ Pass Timeout ]
+webkit.org/b/60109 [ Linux Release ] inspector/elements/edit-dom-actions.html [ Pass Timeout ]
 
 webkit.org/b/72434 [ Linux Win Release ] inspector/styles/svg-style.xhtml [ Failure Pass ]
 webkit.org/b/72434 [ Linux Win Debug ] inspector/styles/svg-style.xhtml [ Failure Slow ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131406] trunk/Source/WebCore/ChangeLog

2012-10-15 Thread mitz

Title: [131406] trunk/Source/WebCore/ChangeLog








Revision 131406
Author m...@apple.com
Date 2012-10-15 20:48:58 -0700 (Mon, 15 Oct 2012)


Log Message
Fixed a typo in the change log.

Modified Paths

trunk/Source/WebCore/ChangeLog




Diff

Modified: trunk/Source/WebCore/ChangeLog (131405 => 131406)

--- trunk/Source/WebCore/ChangeLog	2012-10-16 03:47:25 UTC (rev 131405)
+++ trunk/Source/WebCore/ChangeLog	2012-10-16 03:48:58 UTC (rev 131406)
@@ -8,7 +8,7 @@
 * platform/graphics/WidthIterator.cpp:
 * platform/graphics/WidthIterator.h:
 (WebCore::WidthIterator::shouldApplyFontTransforms): Changed to return false if the run is
-shorter than 2 characters. 1-character are invariant under font transforms, and therefore
+shorter than 2 characters. 1-character runs are invariant under font transforms, and therefore
 Font::codePath() sends them through WidthIterator even on platforms where WidthIterator
 does not support kerning and ligatures.
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131405] trunk/Source/WebCore

2012-10-15 Thread mitz

Title: [131405] trunk/Source/WebCore








Revision 131405
Author m...@apple.com
Date 2012-10-15 20:47:25 -0700 (Mon, 15 Oct 2012)


Log Message
Layout Test fast/text/justify-ideograph-leading-expansion.html is failing an assertion chromium mac
https://bugs.webkit.org/show_bug.cgi?id=99406

Reviewed by Darin Adler.

* platform/graphics/WidthIterator.cpp:
* platform/graphics/WidthIterator.h:
(WebCore::WidthIterator::shouldApplyFontTransforms): Changed to return false if the run is
shorter than 2 characters. 1-character are invariant under font transforms, and therefore
Font::codePath() sends them through WidthIterator even on platforms where WidthIterator
does not support kerning and ligatures.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/WidthIterator.cpp
trunk/Source/WebCore/platform/graphics/WidthIterator.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (131404 => 131405)

--- trunk/Source/WebCore/ChangeLog	2012-10-16 03:43:29 UTC (rev 131404)
+++ trunk/Source/WebCore/ChangeLog	2012-10-16 03:47:25 UTC (rev 131405)
@@ -1,3 +1,17 @@
+2012-10-15  Dan Bernstein  
+
+Layout Test fast/text/justify-ideograph-leading-expansion.html is failing an assertion chromium mac
+https://bugs.webkit.org/show_bug.cgi?id=99406
+
+Reviewed by Darin Adler.
+
+* platform/graphics/WidthIterator.cpp:
+* platform/graphics/WidthIterator.h:
+(WebCore::WidthIterator::shouldApplyFontTransforms): Changed to return false if the run is
+shorter than 2 characters. 1-character are invariant under font transforms, and therefore
+Font::codePath() sends them through WidthIterator even on platforms where WidthIterator
+does not support kerning and ligatures.
+
 2012-10-15  Michael Saboff  
 
 Add 8 bit patch to Document::isValidName() for the non ASCII case


Modified: trunk/Source/WebCore/platform/graphics/WidthIterator.cpp (131404 => 131405)

--- trunk/Source/WebCore/platform/graphics/WidthIterator.cpp	2012-10-16 03:43:29 UTC (rev 131404)
+++ trunk/Source/WebCore/platform/graphics/WidthIterator.cpp	2012-10-16 03:47:25 UTC (rev 131405)
@@ -27,7 +27,6 @@
 #include "Latin1TextIterator.h"
 #include "SimpleFontData.h"
 #include "SurrogatePairAwareTextIterator.h"
-#include "TextRun.h"
 #include 
 
 using namespace WTF;


Modified: trunk/Source/WebCore/platform/graphics/WidthIterator.h (131404 => 131405)

--- trunk/Source/WebCore/platform/graphics/WidthIterator.h	2012-10-16 03:43:29 UTC (rev 131404)
+++ trunk/Source/WebCore/platform/graphics/WidthIterator.h	2012-10-16 03:47:25 UTC (rev 131405)
@@ -24,6 +24,7 @@
 
 #include "Font.h"
 #include "SVGGlyph.h"
+#include "TextRun.h"
 #include 
 #include 
 #include 
@@ -91,7 +92,7 @@
 template 
 inline unsigned advanceInternal(TextIterator&, GlyphBuffer*);
 
-bool shouldApplyFontTransforms() const { return m_typesettingFeatures & (Kerning | Ligatures); }
+bool shouldApplyFontTransforms() const { return m_run.length() > 1 && (m_typesettingFeatures & (Kerning | Ligatures)); }
 
 TypesettingFeatures m_typesettingFeatures;
 HashSet* m_fallbackFonts;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131404] trunk/LayoutTests

2012-10-15 Thread keishi

Title: [131404] trunk/LayoutTests








Revision 131404
Author kei...@webkit.org
Date 2012-10-15 20:43:29 -0700 (Mon, 15 Oct 2012)


Log Message
Add tests for suggestion picker that test step/min/max attributes
https://bugs.webkit.org/show_bug.cgi?id=99168

Reviewed by Kent Tamura.

These tests that setting step/min/max attributes filters out values from the suggestion picker.

* fast/forms/resources/suggestion-picker-common.js:
(valueForEntry): Returns value for an suggestion list entry element.
(highlightedEntry):
(entryValues): Returns an array of entry values.
(openPicker): Added callback argument.
(popupOpenCallbackWrapper):
* platform/chromium-android/TestExpectations:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-min-max-attribute-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-min-max-attribute.html: Added.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html: Added.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-min-max-attribute-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-min-max-attribute.html: Added.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-step-attribute-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-step-attribute.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/resources/suggestion-picker-common.js
trunk/LayoutTests/platform/chromium-android/TestExpectations


Added Paths

trunk/LayoutTests/platform/chromium/fast/forms/suggestion-picker/
trunk/LayoutTests/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-min-max-attribute-expected.txt
trunk/LayoutTests/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-min-max-attribute.html
trunk/LayoutTests/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute-expected.txt
trunk/LayoutTests/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html
trunk/LayoutTests/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-min-max-attribute-expected.txt
trunk/LayoutTests/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-min-max-attribute.html
trunk/LayoutTests/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-step-attribute-expected.txt
trunk/LayoutTests/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-step-attribute.html




Diff

Modified: trunk/LayoutTests/ChangeLog (131403 => 131404)

--- trunk/LayoutTests/ChangeLog	2012-10-16 03:29:18 UTC (rev 131403)
+++ trunk/LayoutTests/ChangeLog	2012-10-16 03:43:29 UTC (rev 131404)
@@ -1,3 +1,28 @@
+2012-10-15  Keishi Hattori  
+
+Add tests for suggestion picker that test step/min/max attributes
+https://bugs.webkit.org/show_bug.cgi?id=99168
+
+Reviewed by Kent Tamura.
+
+These tests that setting step/min/max attributes filters out values from the suggestion picker.
+
+* fast/forms/resources/suggestion-picker-common.js:
+(valueForEntry): Returns value for an suggestion list entry element.
+(highlightedEntry):
+(entryValues): Returns an array of entry values.
+(openPicker): Added callback argument.
+(popupOpenCallbackWrapper):
+* platform/chromium-android/TestExpectations:
+* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-min-max-attribute-expected.txt: Added.
+* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-min-max-attribute.html: Added.
+* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute-expected.txt: Added.
+* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html: Added.
+* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-min-max-attribute-expected.txt: Added.
+* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-min-max-attribute.html: Added.
+* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-step-attribute-expected.txt: Added.
+* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-step-attribute.html: Added.
+
 2012-10-15  Vlad Grecescu  , Douglas Stockwell  
 
 Support for background-clip:content-box and padding-box with border-radius


Modified: trunk/LayoutTests/fast/forms/resources/suggestion-picker-common.js (131403 => 131404)

--- trunk/LayoutTests/fast/forms/resources/suggestion-picker-common.js	2012-10-16 03:29:18 UTC (rev 131403)
+++ trunk/LayoutTests/fast/forms/resources/suggestion-picker-common.js	2012-10-16 03:43:29 UTC (rev 131404)
@@ -4,25 +4,46 @@
 
 var popupWindow = nul

[webkit-changes] [131403] trunk/Source/WebCore

2012-10-15 Thread msaboff

Title: [131403] trunk/Source/WebCore








Revision 131403
Author msab...@apple.com
Date 2012-10-15 20:29:18 -0700 (Mon, 15 Oct 2012)


Log Message
Add 8 bit patch to Document::isValidName() for the non ASCII case
https://bugs.webkit.org/show_bug.cgi?id=99402

Reviewed by Darin Adler.

Added 8 bit path to complete the processing of an 8 bit names without up-converting.

* dom/Document.cpp:
(WebCore::isValidNameNonASCII):
(WebCore::Document::isValidName):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (131402 => 131403)

--- trunk/Source/WebCore/ChangeLog	2012-10-16 03:26:49 UTC (rev 131402)
+++ trunk/Source/WebCore/ChangeLog	2012-10-16 03:29:18 UTC (rev 131403)
@@ -1,3 +1,16 @@
+2012-10-15  Michael Saboff  
+
+Add 8 bit patch to Document::isValidName() for the non ASCII case
+https://bugs.webkit.org/show_bug.cgi?id=99402
+
+Reviewed by Darin Adler.
+
+Added 8 bit path to complete the processing of an 8 bit names without up-converting.
+
+* dom/Document.cpp:
+(WebCore::isValidNameNonASCII):
+(WebCore::Document::isValidName):
+
 2012-10-15  Vlad Grecescu  , Douglas Stockwell  
 
 Support for background-clip:content-box and padding-box with border-radius


Modified: trunk/Source/WebCore/dom/Document.cpp (131402 => 131403)

--- trunk/Source/WebCore/dom/Document.cpp	2012-10-16 03:26:49 UTC (rev 131402)
+++ trunk/Source/WebCore/dom/Document.cpp	2012-10-16 03:29:18 UTC (rev 131403)
@@ -3923,6 +3923,19 @@
 return String::format("%02d/%02d/%04d %02d:%02d:%02d", date.month() + 1, date.monthDay(), date.fullYear(), date.hour(), date.minute(), date.second());
 }
 
+static bool isValidNameNonASCII(const LChar* characters, unsigned length)
+{
+if (!isValidNameStart(characters[0]))
+return false;
+
+for (unsigned i = 1; i < length; ++i) {
+if (!isValidNamePart(characters[i]))
+return false;
+}
+
+return true;
+}
+
 static bool isValidNameNonASCII(const UChar* characters, unsigned length)
 {
 unsigned i = 0;
@@ -3963,16 +3976,20 @@
 if (!length)
 return false;
 
-const UChar* characters;
 if (name.is8Bit()) {
-if (isValidNameASCII(name.characters8(), length))
-return true;
-characters = name.characters();
-} else {
-characters = name.characters16();
+const LChar* characters = name.characters8();
+
 if (isValidNameASCII(characters, length))
 return true;
+
+return isValidNameNonASCII(characters, length);
 }
+
+const UChar* characters = name.characters16();
+
+if (isValidNameASCII(characters, length))
+return true;
+
 return isValidNameNonASCII(characters, length);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131401] trunk/Source/WebKit2

2012-10-15 Thread commit-queue

Title: [131401] trunk/Source/WebKit2








Revision 131401
Author commit-qu...@webkit.org
Date 2012-10-15 20:25:08 -0700 (Mon, 15 Oct 2012)


Log Message
[EFL][WK2] Add APIs for cache model
https://bugs.webkit.org/show_bug.cgi?id=98889

Patch by Jongseok Yang  on 2012-10-15
Reviewed by Gyuyoung Kim.

Add ewk_context_cache_model_set(), ewk_context_cache_model_get().

The cache model means the level for the cache capacity.
If EWK_CACHE_MODEL_DOCUMENT_BROWSER, the biggest cache capacity will be set.

* UIProcess/API/efl/ewk_context.cpp:
(ewk_context_cache_model_set):
(ewk_context_cache_model_get):
* UIProcess/API/efl/ewk_context.h:
* UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.h
trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (131400 => 131401)

--- trunk/Source/WebKit2/ChangeLog	2012-10-16 03:20:18 UTC (rev 131400)
+++ trunk/Source/WebKit2/ChangeLog	2012-10-16 03:25:08 UTC (rev 131401)
@@ -1,3 +1,22 @@
+2012-10-15  Jongseok Yang  
+
+[EFL][WK2] Add APIs for cache model
+https://bugs.webkit.org/show_bug.cgi?id=98889
+
+Reviewed by Gyuyoung Kim.
+
+Add ewk_context_cache_model_set(), ewk_context_cache_model_get().
+
+The cache model means the level for the cache capacity.
+If EWK_CACHE_MODEL_DOCUMENT_BROWSER, the biggest cache capacity will be set.
+
+* UIProcess/API/efl/ewk_context.cpp:
+(ewk_context_cache_model_set):
+(ewk_context_cache_model_get):
+* UIProcess/API/efl/ewk_context.h:
+* UIProcess/API/efl/tests/test_ewk2_context.cpp:
+(TEST_F):
+
 2012-10-15  Byungwoo Lee  
 
 Fix unused parameter build warning.


Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp (131400 => 131401)

--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp	2012-10-16 03:20:18 UTC (rev 131400)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp	2012-10-16 03:25:08 UTC (rev 131401)
@@ -38,6 +38,7 @@
 #include "ewk_download_job.h"
 #include "ewk_download_job_private.h"
 #include "ewk_favicon_database_private.h"
+#include "ewk_private.h"
 #include 
 #include 
 #include 
@@ -338,3 +339,23 @@
 WKRetainPtr wkVisitedURL(AdoptWK, WKStringCreateWithUTF8CString(visitedURL));
 WKContextAddVisitedLink(ewkContext->context.get(), wkVisitedURL.get());
 }
+
+// Ewk_Cache_Model enum validation
+COMPILE_ASSERT_MATCHING_ENUM(EWK_CACHE_MODEL_DOCUMENT_VIEWER, kWKCacheModelDocumentViewer);
+COMPILE_ASSERT_MATCHING_ENUM(EWK_CACHE_MODEL_DOCUMENT_BROWSER, kWKCacheModelDocumentBrowser);
+COMPILE_ASSERT_MATCHING_ENUM(EWK_CACHE_MODEL_PRIMARY_WEBBROWSER, kWKCacheModelPrimaryWebBrowser);
+
+Eina_Bool ewk_context_cache_model_set(Ewk_Context* ewkContext, Ewk_Cache_Model cacheModel)
+{
+EINA_SAFETY_ON_NULL_RETURN_VAL(ewkContext, false);
+WKContextSetCacheModel(ewk_context_WKContext_get(ewkContext), static_cast(cacheModel));
+return true;
+}
+
+Ewk_Cache_Model ewk_context_cache_model_get(const Ewk_Context* ewkContext)
+{
+EINA_SAFETY_ON_NULL_RETURN_VAL(ewkContext, EWK_CACHE_MODEL_DOCUMENT_VIEWER);
+WKCacheModel cacheModel = WKContextGetCacheModel(ewk_context_WKContext_get(ewkContext));
+return static_cast(cacheModel);
+}
+


Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.h (131400 => 131401)

--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.h	2012-10-16 03:20:18 UTC (rev 131400)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.h	2012-10-16 03:25:08 UTC (rev 131401)
@@ -51,6 +51,23 @@
 typedef struct _Ewk_Context Ewk_Context;
 
 /**
+ * \enum_Ewk_Cache_Model
+ *
+ * @brief   Contains option for cache model
+ */
+enum _Ewk_Cache_Model {
+/// Use the smallest cache capacity.
+EWK_CACHE_MODEL_DOCUMENT_VIEWER,
+/// Use bigger cache capacity than EWK_CACHE_MODEL_DOCUMENT_VIEWER.
+EWK_CACHE_MODEL_DOCUMENT_BROWSER,
+/// Use the biggest cache capacity.
+EWK_CACHE_MODEL_PRIMARY_WEBBROWSER
+};
+
+/// Creates a type name for the _Ewk_Cache_Model.
+typedef enum _Ewk_Cache_Model Ewk_Cache_Model;
+
+/**
  * @typedef Ewk_Url_Scheme_Request_Cb Ewk_Url_Scheme_Request_Cb
  * @brief Callback type for use with ewk_context_url_scheme_register().
  */
@@ -268,6 +285,27 @@
  */
 EAPI void ewk_context_visited_link_add(Ewk_Context *context, const char *visited_url);
 
+/**
+ * Set @a cache_model as the cache model for @a context.
+ *
+ * By default, it is EWK_CACHE_MODEL_DOCUMENT_BROWSER.
+ *
+ * @param context context object to update.
+ * @param cache_model a #Ewk_Cache_Model.
+ *
+ * @return @c EINA_TRUE on success or @c EINA_FALSE on failure
+ */
+EAPI Eina_Bool ewk_context_cache_model_set(Ewk_Context *context, Ewk_Cache_Model cache_model);
+
+/**
+ * Gets the cache model for @a context.
+ *
+ * @param context context object to query.
+ *

[webkit-changes] [131400] trunk/LayoutTests

2012-10-15 Thread tkent

Title: [131400] trunk/LayoutTests








Revision 131400
Author tk...@chromium.org
Date 2012-10-15 20:20:18 -0700 (Mon, 15 Oct 2012)


Log Message
[Chromium] Layout Test *-multiple-fields-keyboard-events.html etc. are failing on Win XP
https://bugs.webkit.org/show_bug.cgi?id=99408

These failures are expected. Just do rebaseline.

* platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt: Added.
* platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt: Added.
* platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt
trunk/LayoutTests/platform/chromium-win-xp/fast/forms/month-multiple-fields/
trunk/LayoutTests/platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt
trunk/LayoutTests/platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (131399 => 131400)

--- trunk/LayoutTests/ChangeLog	2012-10-16 02:46:15 UTC (rev 131399)
+++ trunk/LayoutTests/ChangeLog	2012-10-16 03:20:18 UTC (rev 131400)
@@ -1,3 +1,14 @@
+2012-10-15  Kent Tamura  
+
+[Chromium] Layout Test *-multiple-fields-keyboard-events.html etc. are failing on Win XP
+https://bugs.webkit.org/show_bug.cgi?id=99408
+
+These failures are expected. Just do rebaseline.
+
+* platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt: Added.
+* platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt: Added.
+* platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Added.
+
 2012-10-15  Shinya Kawanaka  
 
 [Chromium] Unreviewed gardening, TestExpectations updated.


Added: trunk/LayoutTests/platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt (0 => 131400)

--- trunk/LayoutTests/platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt	2012-10-16 03:20:18 UTC (rev 131400)
@@ -0,0 +1,66 @@
+Multiple fields UI of month input type with keyboard events
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Please run this with DumpRenderTree.
+
+Test following keys:
+Digits
+Left/Right - Move focus field inside element
+Up/Down - Increment/decrement value of focus field
+Tab - Move focus field
+Backspace - Make value empty
+  
+== Digit keys ==
+PASS input.value is "0012-09-20"
+== Left/Right keys ==
+PASS input.value is "2012-09-06"
+PASS document.activeElement.id is "input"
+== Up/Down keys ==
+PASS input.value is "2012-10-29"
+PASS input.value is "2012-08-29"
+== Up/Down keys on empty value ==
+PASS input.value is "2012-11-01"
+== Up/Down keys on empty value 2 ==
+PASS input.value is "2012-02-28"
+== Tab key ==
+PASS input.value is "2012-09-05"
+PASS input.value is "2012-09-07"
+PASS document.activeElement.id is "after"
+== Shfit+Tab key ==
+PASS input.value is "0003-09-30"
+PASS document.activeElement.id is "before"
+== Up key on maximum value ==
+PASS input.value is "0001-10-14"
+== Up key with a maximum attribute ==
+PASS input.value is "1000-01-01"
+== Down key on minimum value ==
+PASS input.value is ""
+== Down key with a minimum attribute ==
+PASS input.value is ""
+== Inconsistent min-max attributes ==
+PASS input.value is "1000-12-31"
+PASS input.value is "1999-12-31"
+== Make an invalid date ==
+PASS input.value is ""
+== Backspace key ==
+PASS input.value is ""
+== Delete key ==
+PASS input.value is ""
+== Typeahead ==
+PASS input.value is "2012-12-01"
+PASS input.value is "2012-12-02"
+== RTL Left/Right keys ==
+FAIL input.value should be 2012-09-01. Was 2012-01-28.
+FAIL input.value should be 2012-02-01. Was 2012-12-28.
+FAIL input.value should be 2012-03-01. Was 0003-12-28.
+== Disabled/readonly ==
+PASS input.value is "2012-10-08"
+PASS input.value is "2012-11-08"
+PASS input.value is "2012-11-08"
+PASS input.value is "2012-12-08"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Property changes on: trunk/LayoutTests/platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt (0

[webkit-changes] [131399] trunk/Source/WebKit/chromium

2012-10-15 Thread peter

Title: [131399] trunk/Source/WebKit/chromium








Revision 131399
Author pe...@chromium.org
Date 2012-10-15 19:46:15 -0700 (Mon, 15 Oct 2012)


Log Message
[Chromium] Enable FAST_MOBILE_SCROLLING for Android
https://bugs.webkit.org/show_bug.cgi?id=99401

Reviewed by Adam Barth.

* features.gypi: Add the define to the Android-only section.

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (131398 => 131399)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-10-16 02:36:11 UTC (rev 131398)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-10-16 02:46:15 UTC (rev 131399)
@@ -1,3 +1,12 @@
+2012-10-15  Peter Beverloo  
+
+[Chromium] Enable FAST_MOBILE_SCROLLING for Android
+https://bugs.webkit.org/show_bug.cgi?id=99401
+
+Reviewed by Adam Barth.
+
+* features.gypi: Add the define to the Android-only section.
+
 2012-10-15  Sheriff Bot  
 
 Unreviewed.  Rolled DEPS.


Modified: trunk/Source/WebKit/chromium/features.gypi (131398 => 131399)

--- trunk/Source/WebKit/chromium/features.gypi	2012-10-16 02:36:11 UTC (rev 131398)
+++ trunk/Source/WebKit/chromium/features.gypi	2012-10-16 02:46:15 UTC (rev 131399)
@@ -151,6 +151,7 @@
   'ENABLE_ACCELERATED_OVERFLOW_SCROLLING=1',
   'ENABLE_CALENDAR_PICKER=0',
   'ENABLE_DATALIST_ELEMENT=0',
+  'ENABLE_FAST_MOBILE_SCROLLING=1',
   'ENABLE_INPUT_SPEECH=0',
   'ENABLE_INPUT_TYPE_COLOR=0',
   'ENABLE_JAVASCRIPT_I18N_API=0',






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131398] trunk/Source/WebKit/chromium

2012-10-15 Thread commit-queue

Title: [131398] trunk/Source/WebKit/chromium








Revision 131398
Author commit-qu...@webkit.org
Date 2012-10-15 19:36:11 -0700 (Mon, 15 Oct 2012)


Log Message
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot  on 2012-10-15

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (131397 => 131398)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-10-16 02:05:47 UTC (rev 131397)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-10-16 02:36:11 UTC (rev 131398)
@@ -1,3 +1,9 @@
+2012-10-15  Sheriff Bot  
+
+Unreviewed.  Rolled DEPS.
+
+* DEPS:
+
 2012-10-15  Peter Beverloo  
 
 [Chromium] The default target for Android builds should be "all" instead of "All"


Modified: trunk/Source/WebKit/chromium/DEPS (131397 => 131398)

--- trunk/Source/WebKit/chromium/DEPS	2012-10-16 02:05:47 UTC (rev 131397)
+++ trunk/Source/WebKit/chromium/DEPS	2012-10-16 02:36:11 UTC (rev 131398)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '161787'
+  'chromium_rev': '162004'
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131397] trunk/Source

2012-10-15 Thread commit-queue

Title: [131397] trunk/Source








Revision 131397
Author commit-qu...@webkit.org
Date 2012-10-15 19:05:47 -0700 (Mon, 15 Oct 2012)


Log Message
Fix unused parameter build warning.
https://bugs.webkit.org/show_bug.cgi?id=99400

Patch by Byungwoo Lee  on 2012-10-15
Reviewed by Gyuyoung Kim.

Remove the name of unused parameters to fix the build warning (-Wunused-parameter).

Source/WebCore:

* platform/network/soup/ResourceErrorSoup.cpp:
(WebCore::ResourceError::tlsError):

Source/WebKit2:

* Shared/soup/WebCoreArgumentCodersSoup.cpp:
(CoreIPCencodePlatformData):
(CoreIPCdecodePlatformData):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getSharedWorkerProcessConnection):
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::handleEditingCommand):
(WebKit::NetscapePlugin::isEditingCommandEnabled):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceErrorSoup.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp
trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (131396 => 131397)

--- trunk/Source/WebCore/ChangeLog	2012-10-16 01:59:54 UTC (rev 131396)
+++ trunk/Source/WebCore/ChangeLog	2012-10-16 02:05:47 UTC (rev 131397)
@@ -1,3 +1,15 @@
+2012-10-15  Byungwoo Lee  
+
+Fix unused parameter build warning.
+https://bugs.webkit.org/show_bug.cgi?id=99400
+
+Reviewed by Gyuyoung Kim.
+
+Remove the name of unused parameters to fix the build warning (-Wunused-parameter).
+
+* platform/network/soup/ResourceErrorSoup.cpp:
+(WebCore::ResourceError::tlsError):
+
 2012-10-15  Kenichi Ishibashi  
 
 [WebSocket] WebSocketInflater should handle BFINAL = 1 blocks


Modified: trunk/Source/WebCore/platform/network/soup/ResourceErrorSoup.cpp (131396 => 131397)

--- trunk/Source/WebCore/platform/network/soup/ResourceErrorSoup.cpp	2012-10-16 01:59:54 UTC (rev 131396)
+++ trunk/Source/WebCore/platform/network/soup/ResourceErrorSoup.cpp	2012-10-16 02:05:47 UTC (rev 131397)
@@ -56,7 +56,7 @@
 failingURI(request), String::fromUTF8(error->message));
 }
 
-ResourceError ResourceError::tlsError(SoupRequest* request, unsigned tlsErrors, GTlsCertificate* certificate)
+ResourceError ResourceError::tlsError(SoupRequest* request, unsigned /* tlsErrors */, GTlsCertificate*)
 {
 return ResourceError(g_quark_to_string(SOUP_HTTP_ERROR), SOUP_STATUS_SSL_FAILED,
 failingURI(request), unacceptableTLSCertificate());


Modified: trunk/Source/WebKit2/ChangeLog (131396 => 131397)

--- trunk/Source/WebKit2/ChangeLog	2012-10-16 01:59:54 UTC (rev 131396)
+++ trunk/Source/WebKit2/ChangeLog	2012-10-16 02:05:47 UTC (rev 131397)
@@ -1,3 +1,21 @@
+2012-10-15  Byungwoo Lee  
+
+Fix unused parameter build warning.
+https://bugs.webkit.org/show_bug.cgi?id=99400
+
+Reviewed by Gyuyoung Kim.
+
+Remove the name of unused parameters to fix the build warning (-Wunused-parameter).
+
+* Shared/soup/WebCoreArgumentCodersSoup.cpp:
+(CoreIPCencodePlatformData):
+(CoreIPCdecodePlatformData):
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::getSharedWorkerProcessConnection):
+* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+(WebKit::NetscapePlugin::handleEditingCommand):
+(WebKit::NetscapePlugin::isEditingCommandEnabled):
+
 2012-10-15  Dan Bernstein  
 
 WebKit2 part of  Font’s fast code path doesn’t support kerning and ligatures


Modified: trunk/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp (131396 => 131397)

--- trunk/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp	2012-10-16 01:59:54 UTC (rev 131396)
+++ trunk/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp	2012-10-16 02:05:47 UTC (rev 131397)
@@ -66,11 +66,11 @@
 }
 
 
-void ArgumentCoder::encodePlatformData(ArgumentEncoder* encoder, const ResourceError& resourceError)
+void ArgumentCoder::encodePlatformData(ArgumentEncoder*, const ResourceError&)
 {
 }
 
-bool ArgumentCoder::decodePlatformData(ArgumentDecoder* decoder, ResourceError& resourceError)
+bool ArgumentCoder::decodePlatformData(ArgumentDecoder*, ResourceError&)
 {
 return true;
 }


Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp (131396 => 131397)

--- trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp	2012-10-16 01:59:54 UTC (rev 131396)
+++ trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp	2012-10-16 02:05:47 UTC (rev 131397)
@@ -390,7 +390,7 @@
 
 #endif
 
-void WebProcessProxy::getSharedWorkerProcessConnection(const String& url, const String& name, PassRefPtr reply)
+void WebProcessProxy::getSharedWorkerProcessConnection(const String& /* url */, const String& /* name */, PassRefPtr)
 {
 // FIXME: Implement
 }


Modified: trunk/Source/WebKit2/WebProcess/

[webkit-changes] [131396] trunk/LayoutTests

2012-10-15 Thread shinyak

Title: [131396] trunk/LayoutTests








Revision 131396
Author shin...@chromium.org
Date 2012-10-15 18:59:54 -0700 (Mon, 15 Oct 2012)


Log Message
[Chromium] Unreviewed gardening, TestExpectations updated.

Now lint passes.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (131395 => 131396)

--- trunk/LayoutTests/ChangeLog	2012-10-16 01:40:45 UTC (rev 131395)
+++ trunk/LayoutTests/ChangeLog	2012-10-16 01:59:54 UTC (rev 131396)
@@ -1,3 +1,11 @@
+2012-10-15  Shinya Kawanaka  
+
+[Chromium] Unreviewed gardening, TestExpectations updated.
+
+Now lint passes.
+
+* platform/chromium/TestExpectations:
+
 2012-10-15  Kenichi Ishibashi  
 
 [WebSocket] WebSocketInflater should handle BFINAL = 1 blocks


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (131395 => 131396)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-16 01:40:45 UTC (rev 131395)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-16 01:59:54 UTC (rev 131396)
@@ -3901,8 +3901,8 @@
 webkit.org/b/99291 fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic.html [ Pass ImageOnlyFailure ]
 webkit.org/b/99291 fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html [ Pass ImageOnlyFailure ]
 webkit.org/b/99291 fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic.html [ Pass ImageOnlyFailure ]
-webkit.org/b/99291 platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html [ Pass ImageOnlyFailure ]
-webkit.org/b/99291 platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl.html [ Pass ImageOnlyFailure ]
+webkit.org/b/99291 [ Mac Linux Win ] platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html [ Pass ImageOnlyFailure ]
+webkit.org/b/99291 [ Mac Linux Win ] platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl.html [ Pass ImageOnlyFailure ]
 
 webkit.org/b/96549 [ Mac Android ] platform/chromium/virtual/gpu/fast/hidpi/focus-rings.html [ ImageOnlyFailure ]
 webkit.org/b/96549 [ Mac ] platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131395] trunk

2012-10-15 Thread bashi

Title: [131395] trunk








Revision 131395
Author ba...@chromium.org
Date 2012-10-15 18:40:45 -0700 (Mon, 15 Oct 2012)


Log Message
[WebSocket] WebSocketInflater should handle BFINAL = 1 blocks
https://bugs.webkit.org/show_bug.cgi?id=99282

Reviewed by Yuta Kitamura.

Source/WebCore:

Reset decompression state if WebSocketInflater decompress a block with
BFINAL set to 1.

Test: http/tests/websocket/tests/hybi/deflate-frame-set-bfinal.html

* Modules/websockets/WebSocketDeflater.cpp:
(WebCore::WebSocketInflater::addBytes):
Reset decompression state if inflate() returns Z_STREAM_END, which means the BFINAL
of the current block was set to 1.
(WebCore::WebSocketInflater::finish): Add an assertion.

LayoutTests:

Added a test for receiving compressed blocks with BFINAL set to 1.

* http/tests/websocket/tests/hybi/deflate-frame-set-bfinal-expected.txt: Added.
* http/tests/websocket/tests/hybi/deflate-frame-set-bfinal.html: Added.
* http/tests/websocket/tests/hybi/deflate-frame_wsh.py:
(web_socket_do_extra_handshake): Call set_bfinal() if the 'set_bfinal' parameter is passed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/websocket/tests/hybi/deflate-frame_wsh.py
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/websockets/WebSocketDeflater.cpp


Added Paths

trunk/LayoutTests/http/tests/websocket/tests/hybi/deflate-frame-set-bfinal-expected.txt
trunk/LayoutTests/http/tests/websocket/tests/hybi/deflate-frame-set-bfinal.html




Diff

Modified: trunk/LayoutTests/ChangeLog (131394 => 131395)

--- trunk/LayoutTests/ChangeLog	2012-10-16 01:20:18 UTC (rev 131394)
+++ trunk/LayoutTests/ChangeLog	2012-10-16 01:40:45 UTC (rev 131395)
@@ -1,3 +1,17 @@
+2012-10-15  Kenichi Ishibashi  
+
+[WebSocket] WebSocketInflater should handle BFINAL = 1 blocks
+https://bugs.webkit.org/show_bug.cgi?id=99282
+
+Reviewed by Yuta Kitamura.
+
+Added a test for receiving compressed blocks with BFINAL set to 1.
+
+* http/tests/websocket/tests/hybi/deflate-frame-set-bfinal-expected.txt: Added.
+* http/tests/websocket/tests/hybi/deflate-frame-set-bfinal.html: Added.
+* http/tests/websocket/tests/hybi/deflate-frame_wsh.py:
+(web_socket_do_extra_handshake): Call set_bfinal() if the 'set_bfinal' parameter is passed.
+
 2012-10-15  Simon Fraser  
 
 Fix GraphicsLayer visible rect computation when scrolling in WebKit1


Added: trunk/LayoutTests/http/tests/websocket/tests/hybi/deflate-frame-set-bfinal-expected.txt (0 => 131395)

--- trunk/LayoutTests/http/tests/websocket/tests/hybi/deflate-frame-set-bfinal-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/deflate-frame-set-bfinal-expected.txt	2012-10-16 01:40:45 UTC (rev 131395)
@@ -0,0 +1,16 @@
+Test receiving compressed frames with BFINAL = 1.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+Sending message: "Hello"
+PASS event.data is 'Hello'
+Sending message: "World"
+PASS event.data is 'World'
+Sending message: "Goodbye"
+PASS event.data is 'Goodbye'
+onclose() was called.
+PASS closeEvent.wasClean is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/http/tests/websocket/tests/hybi/deflate-frame-set-bfinal.html (0 => 131395)

--- trunk/LayoutTests/http/tests/websocket/tests/hybi/deflate-frame-set-bfinal.html	(rev 0)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/deflate-frame-set-bfinal.html	2012-10-16 01:40:45 UTC (rev 131395)
@@ -0,0 +1,56 @@
+
+
+
+
+
+
+
+