[webkit-changes] [134748] trunk
Title: [134748] trunk Revision 134748 Author shin...@chromium.org Date 2012-11-14 23:41:33 -0800 (Wed, 14 Nov 2012) Log Message Changing pseudoClass (:disabled) should cause distribution. https://bugs.webkit.org/show_bug.cgi?id=101901 Reviewed by Hajime Morita. Source/WebCore: We have to invalidate distribution when pseudo-class (:disabled) is changed. According to the HTML5 spec, :disabled will match button, input, select, textarea, optgroup, option, command, li, and fieldset. However, command is not implemented yet, we skip li and command. li might have 'disabled' state, but we need a command element to make it 'disabled' state. Tests: fast/dom/shadow/pseudoclass-update-disabled-button.html fast/dom/shadow/pseudoclass-update-disabled-fieldset.html fast/dom/shadow/pseudoclass-update-disabled-input.html fast/dom/shadow/pseudoclass-update-disabled-optgroup.html fast/dom/shadow/pseudoclass-update-disabled-option.html fast/dom/shadow/pseudoclass-update-disabled-select.html fast/dom/shadow/pseudoclass-update-disabled-textarea.html * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::disabledAttributeChanged): * html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::parseAttribute): * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::parseAttribute): LayoutTests: * fast/dom/shadow/pseudoclass-update-disabled-button-expected.html: Added. * fast/dom/shadow/pseudoclass-update-disabled-button.html: Added. * fast/dom/shadow/pseudoclass-update-disabled-fieldset-expected.html: Added. * fast/dom/shadow/pseudoclass-update-disabled-fieldset.html: Added. * fast/dom/shadow/pseudoclass-update-disabled-input-expected.html: Added. * fast/dom/shadow/pseudoclass-update-disabled-input.html: Added. * fast/dom/shadow/pseudoclass-update-disabled-optgroup-expected.txt: Added. * fast/dom/shadow/pseudoclass-update-disabled-optgroup.html: Added. * fast/dom/shadow/pseudoclass-update-disabled-option-expected.txt: Added. * fast/dom/shadow/pseudoclass-update-disabled-option.html: Added. * fast/dom/shadow/pseudoclass-update-disabled-select-expected.html: Added. * fast/dom/shadow/pseudoclass-update-disabled-select.html: Added. * fast/dom/shadow/pseudoclass-update-disabled-textarea-expected.html: Added. * fast/dom/shadow/pseudoclass-update-disabled-textarea.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLFormControlElement.cpp trunk/Source/WebCore/html/HTMLOptGroupElement.cpp trunk/Source/WebCore/html/HTMLOptionElement.cpp Added Paths trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-disabled-button-expected.html trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-disabled-button.html trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-disabled-fieldset-expected.html trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-disabled-fieldset.html trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-disabled-input-expected.html trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-disabled-input.html trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-disabled-optgroup-expected.txt trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-disabled-optgroup.html trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-disabled-option-expected.txt trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-disabled-option.html trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-disabled-select-expected.html trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-disabled-select.html trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-disabled-textarea-expected.html trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-disabled-textarea.html Diff Modified: trunk/LayoutTests/ChangeLog (134747 => 134748) --- trunk/LayoutTests/ChangeLog 2012-11-15 07:34:30 UTC (rev 134747) +++ trunk/LayoutTests/ChangeLog 2012-11-15 07:41:33 UTC (rev 134748) @@ -1,3 +1,25 @@ +2012-11-14 Shinya Kawanaka + +Changing pseudoClass (:disabled) should cause distribution. +https://bugs.webkit.org/show_bug.cgi?id=101901 + +Reviewed by Hajime Morita. + +* fast/dom/shadow/pseudoclass-update-disabled-button-expected.html: Added. +* fast/dom/shadow/pseudoclass-update-disabled-button.html: Added. +* fast/dom/shadow/pseudoclass-update-disabled-fieldset-expected.html: Added. +* fast/dom/shadow/pseudoclass-update-disabled-fieldset.html: Added. +* fast/dom/shadow/pseudoclass-update-disabled-input-expected.html: Added. +* fast/dom/shadow/pseudoclass-update-disabled-input.html: Added. +* fast/dom/shadow/pseudoclass-update-disabled-optgroup-expected.txt: Added. +* fast/dom/shadow/pseudoclass-update-disabled-optgroup.html: Added. +* fast/dom/shadow/pseudoclass-update-disabled-option-expected.txt: Added. +* fast/dom/shadow/pseudoclass-update-disabled-option.html: Added. +* fast/dom/shadow/pseudoclass-update-disabled-select-expe
[webkit-changes] [134747] trunk
Title: [134747] trunk Revision 134747 Author commit-qu...@webkit.org Date 2012-11-14 23:34:30 -0800 (Wed, 14 Nov 2012) Log Message Unreviewed, rolling out r134691, r134703, r134715, r134716, and r134733. http://trac.webkit.org/changeset/134691 http://trac.webkit.org/changeset/134703 http://trac.webkit.org/changeset/134715 http://trac.webkit.org/changeset/134716 http://trac.webkit.org/changeset/134733 https://bugs.webkit.org/show_bug.cgi?id=102342 "Broke the Apple Windows Debug and GTK builds." (Requested by dydx on #webkit). Patch by Sheriff Bot on 2012-11-14 Source/WebCore: * WebCore.exp.in: * bindings/js/SerializedScriptValue.h: * testing/Internals.cpp: * testing/Internals.h: (WebCore): * testing/Internals.idl: Source/WebKit2: * win/WebKit2.def: * win/WebKit2CFLite.def: LayoutTests: * platform/chromium/fast/storage/serialized-script-value-expected.txt: Removed. * platform/chromium/fast/storage/serialized-script-value.html: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/bindings/js/SerializedScriptValue.h trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/Internals.h trunk/Source/WebCore/testing/Internals.idl trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/win/WebKit2.def trunk/Source/WebKit2/win/WebKit2CFLite.def Removed Paths trunk/LayoutTests/platform/chromium/fast/storage/serialized-script-value-expected.txt trunk/LayoutTests/platform/chromium/fast/storage/serialized-script-value.html Diff Modified: trunk/LayoutTests/ChangeLog (134746 => 134747) --- trunk/LayoutTests/ChangeLog 2012-11-15 07:12:19 UTC (rev 134746) +++ trunk/LayoutTests/ChangeLog 2012-11-15 07:34:30 UTC (rev 134747) @@ -1,3 +1,20 @@ +2012-11-14 Sheriff Bot + +Unreviewed, rolling out r134691, r134703, r134715, r134716, +and r134733. +http://trac.webkit.org/changeset/134691 +http://trac.webkit.org/changeset/134703 +http://trac.webkit.org/changeset/134715 +http://trac.webkit.org/changeset/134716 +http://trac.webkit.org/changeset/134733 +https://bugs.webkit.org/show_bug.cgi?id=102342 + +"Broke the Apple Windows Debug and GTK builds." (Requested by +dydx on #webkit). + +* platform/chromium/fast/storage/serialized-script-value-expected.txt: Removed. +* platform/chromium/fast/storage/serialized-script-value.html: Removed. + 2012-11-14 Kentaro Hara Unreviewed. Rebaselined images. Deleted: trunk/LayoutTests/platform/chromium/fast/storage/serialized-script-value-expected.txt (134746 => 134747) --- trunk/LayoutTests/platform/chromium/fast/storage/serialized-script-value-expected.txt 2012-11-15 07:12:19 UTC (rev 134746) +++ trunk/LayoutTests/platform/chromium/fast/storage/serialized-script-value-expected.txt 2012-11-15 07:34:30 UTC (rev 134747) @@ -1,125 +0,0 @@ - -Deserialize to {"foo":"zoo","bar":{"baz":"myNewKey"}}: -PASS JSON.stringify(newObj) is JSON.stringify(obj) -Serialize {"foo":"zoo","bar":{"baz":"myNewKey"}}: -PASS bufferView.length is expectedBufferValues.length - -Deserialize to {"foo":"zoo","bar":"myNewKey"}: -PASS JSON.stringify(newObj) is JSON.stringify(obj) -Serialize {"foo":"zoo","bar":"myNewKey"}: -PASS bufferView.length is expectedBufferValues.length - -Deserialize to []: -PASS JSON.stringify(newObj) is JSON.stringify(obj) -Serialize []: -PASS bufferView.length is expectedBufferValues.length - -Deserialize to {"foo":"zoo"}: -PASS JSON.stringify(newObj) is JSON.stringify(obj) -PASS JSON.stringify(newObj) is JSON.stringify(obj) -Serialize {"foo":"zoo"}: -PASS bufferView.length is expectedBufferValues.length - -Deserialize to {"foo":null}: -PASS JSON.stringify(newObj) is JSON.stringify(obj) -PASS JSON.stringify(newObj) is JSON.stringify(obj) -Serialize {"foo":null}: -PASS bufferView.length is expectedBufferValues.length - -Deserialize to {}: -PASS JSON.stringify(newObj) is JSON.stringify(obj) -PASS JSON.stringify(newObj) is JSON.stringify(obj) -Serialize {}: -PASS bufferView.length is expectedBufferValues.length - -Deserialize to undefined: -PASS JSON.stringify(newObj) is JSON.stringify(obj) -Serialize undefined: -PASS bufferView.length is expectedBufferValues.length - -Deserialize to true: -PASS JSON.stringify(newObj) is JSON.stringify(obj) -Serialize true: -PASS bufferView.length is expectedBufferValues.length - -Deserialize to false: -PASS JSON.stringify(newObj) is JSON.stringify(obj) -Serialize false: -PASS bufferView.length is expectedBufferValues.length - -Deserialize to 10: -PASS JSON.stringify(newObj) is JSON.stringify(obj) -Serialize 10: -PASS bufferView.length is expectedBufferValues.length - -Deserialize to -10: -PASS JSON.stringify(newObj) is JSON.stringify(obj) -Serialize -10: -PASS bufferView.length is expectedBufferValues.length - -Deserialize to 1073741824: -PASS JSON.stringify(newObj) is JSON.stringify(obj) -Serialize 1073741824: -PASS bufferView.length i
[webkit-changes] [134746] trunk/LayoutTests
Title: [134746] trunk/LayoutTests Revision 134746 Author hara...@chromium.org Date 2012-11-14 23:12:19 -0800 (Wed, 14 Nov 2012) Log Message Unreviewed. Rebaselined images. * platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Added. * platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added. * platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Added. * platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png trunk/LayoutTests/platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png trunk/LayoutTests/platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png trunk/LayoutTests/platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (134745 => 134746) --- trunk/LayoutTests/ChangeLog 2012-11-15 06:57:37 UTC (rev 134745) +++ trunk/LayoutTests/ChangeLog 2012-11-15 07:12:19 UTC (rev 134746) @@ -1,3 +1,12 @@ +2012-11-14 Kentaro Hara + +Unreviewed. Rebaselined images. + +* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Added. +* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added. +* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Added. +* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added. + 2012-11-14 Dirk Schulze Support animation of basic shape 'polygon' Added: trunk/LayoutTests/platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134745] trunk/Source/WebCore
Title: [134745] trunk/Source/WebCore Revision 134745 Author pfeld...@chromium.org Date 2012-11-14 22:57:37 -0800 (Wed, 14 Nov 2012) Log Message Not reviewed: fixing inspector tests under Qt. * inspector/front-end/TestController.js: * inspector/front-end/utilities.js: (.): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/TestController.js trunk/Source/WebCore/inspector/front-end/utilities.js Diff Modified: trunk/Source/WebCore/ChangeLog (134744 => 134745) --- trunk/Source/WebCore/ChangeLog 2012-11-15 06:51:10 UTC (rev 134744) +++ trunk/Source/WebCore/ChangeLog 2012-11-15 06:57:37 UTC (rev 134745) @@ -1,3 +1,11 @@ +2012-11-14 Pavel Feldman + +Not reviewed: fixing inspector tests under Qt. + +* inspector/front-end/TestController.js: +* inspector/front-end/utilities.js: +(.): + 2012-11-14 Kentaro Hara Unreviewed. Rebaselined run-bindings-tests. Modified: trunk/Source/WebCore/inspector/front-end/TestController.js (134744 => 134745) --- trunk/Source/WebCore/inspector/front-end/TestController.js 2012-11-15 06:51:10 UTC (rev 134744) +++ trunk/Source/WebCore/inspector/front-end/TestController.js 2012-11-15 06:57:37 UTC (rev 134745) @@ -45,6 +45,7 @@ WebInspector.evaluateForTestInFrontend = function(callId, script) { +WebInspector.isUnderTest = true; function invokeMethod() { try { Modified: trunk/Source/WebCore/inspector/front-end/utilities.js (134744 => 134745) --- trunk/Source/WebCore/inspector/front-end/utilities.js 2012-11-15 06:51:10 UTC (rev 134744) +++ trunk/Source/WebCore/inspector/front-end/utilities.js 2012-11-15 06:57:37 UTC (rev 134745) @@ -878,6 +878,13 @@ { this._observer = new WebKitMutationObserver(handler); NonLeakingMutationObserver._instances.push(this); +if (!window.testRunner && !WebInspector.isUnderTest && !NonLeakingMutationObserver._unloadListener) { +NonLeakingMutationObserver._unloadListener = function() { +while (NonLeakingMutationObserver._instances.length) +NonLeakingMutationObserver._instances[NonLeakingMutationObserver._instances.length - 1].disconnect(); +}; +window.addEventListener("unload", NonLeakingMutationObserver._unloadListener, false); +} } NonLeakingMutationObserver._instances = []; @@ -902,10 +909,3 @@ } } -if (!window.testRunner) { -window.addEventListener("unload", function() { -while (NonLeakingMutationObserver._instances.length) -NonLeakingMutationObserver._instances[NonLeakingMutationObserver._instances.length - 1].disconnect(); -}, false); -} - ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134744] trunk
Title: [134744] trunk Revision 134744 Author commit-qu...@webkit.org Date 2012-11-14 22:51:10 -0800 (Wed, 14 Nov 2012) Log Message Unreviewed, rolling out r134741. http://trac.webkit.org/changeset/134741 https://bugs.webkit.org/show_bug.cgi?id=102337 "Change is incorrect." (Requested by dydx on #webkit). Patch by Sheriff Bot on 2012-11-14 .: * Source/autotools/symbols.filter: Source/WebKit2: * win/WebKit2.def: * win/WebKit2CFLite.def: Modified Paths trunk/ChangeLog trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/win/WebKit2.def trunk/Source/WebKit2/win/WebKit2CFLite.def trunk/Source/autotools/symbols.filter Diff Modified: trunk/ChangeLog (134743 => 134744) --- trunk/ChangeLog 2012-11-15 06:44:33 UTC (rev 134743) +++ trunk/ChangeLog 2012-11-15 06:51:10 UTC (rev 134744) @@ -1,3 +1,13 @@ +2012-11-14 Sheriff Bot + +Unreviewed, rolling out r134741. +http://trac.webkit.org/changeset/134741 +https://bugs.webkit.org/show_bug.cgi?id=102337 + +"Change is incorrect." (Requested by dydx on #webkit). + +* Source/autotools/symbols.filter: + 2012-11-14 Daniel Bates Attempt to fix the Apple Windows Debug and GTK builds after Modified: trunk/Source/WebKit2/ChangeLog (134743 => 134744) --- trunk/Source/WebKit2/ChangeLog 2012-11-15 06:44:33 UTC (rev 134743) +++ trunk/Source/WebKit2/ChangeLog 2012-11-15 06:51:10 UTC (rev 134744) @@ -1,3 +1,14 @@ +2012-11-14 Sheriff Bot + +Unreviewed, rolling out r134741. +http://trac.webkit.org/changeset/134741 +https://bugs.webkit.org/show_bug.cgi?id=102337 + +"Change is incorrect." (Requested by dydx on #webkit). + +* win/WebKit2.def: +* win/WebKit2CFLite.def: + 2012-11-14 Daniel Bates Attempt to fix the Apple Windows Debug and GTK builds after Modified: trunk/Source/WebKit2/win/WebKit2.def (134743 => 134744) --- trunk/Source/WebKit2/win/WebKit2.def 2012-11-15 06:44:33 UTC (rev 134743) +++ trunk/Source/WebKit2/win/WebKit2.def 2012-11-15 06:51:10 UTC (rev 134744) @@ -172,7 +172,6 @@ ?create@ShadowRoot@WebCore@@SA?AV?$PassRefPtr@VShadowRoot@WebCore@@@WTF@@PAVElement@2@AAH@Z ?createWrapper@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNode@1@@Z ?deserialize@SerializedScriptValue@WebCore@@QAE?AVJSValue@JSC@@PAVExecState@4@PAVJSGlobalObject@4@PAV?$Vector@V?$RefPtr@VMessagePort@WebCore@@@WTF@@$00@WTF@@W4SerializationErrorMode@2@@Z -?deserializeBuffer@Internals@WebCore@@QBE?AV?$PassRefPtr@VSerializedScriptValue@WebCore@@@WTF@@V?$PassRefPtr@VArrayBuffer@WTF@@@4@@Z ?documentState@HistoryItem@WebCore@@QBEABV?$Vector@VString@WTF@@$0A@@WTF@@XZ ?ensureSelectFeatureSetCollected@ElementShadow@WebCore@@QAEXXZ ?equal@WTF@@YA_NPBVStringImpl@1@PBE@Z @@ -224,7 +223,6 @@ ?scriptNameToCode@WebCore@@YA?AW4UScriptCode@@ABVString@WTF@@@Z ?scrollElementToRect@FrameView@WebCore@@QAEXPAVElement@2@ABVIntRect@2@@Z ?scrollingStateTreeAsText@Page@WebCore@@QAE?AVString@WTF@@XZ -?serializeObject@Internals@WebCore@@QBE?AV?$PassRefPtr@VArrayBuffer@WTF@@@WTF@@V?$PassRefPtr@VSerializedScriptValue@WebCore@@@4@@Z ?setCanStartMedia@Page@WebCore@@QAEX_N@Z ?setCursiveFontFamily@Settings@WebCore@@QAEXABVAtomicString@WTF@@W4UScriptCode@@@Z ?setDeviceScaleFactor@Page@WebCore@@QAEXM@Z Modified: trunk/Source/WebKit2/win/WebKit2CFLite.def (134743 => 134744) --- trunk/Source/WebKit2/win/WebKit2CFLite.def 2012-11-15 06:44:33 UTC (rev 134743) +++ trunk/Source/WebKit2/win/WebKit2CFLite.def 2012-11-15 06:51:10 UTC (rev 134744) @@ -165,7 +165,6 @@ ?create@ShadowRoot@WebCore@@SA?AV?$PassRefPtr@VShadowRoot@WebCore@@@WTF@@PAVElement@2@AAH@Z ?createWrapper@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNode@1@@Z ?deserialize@SerializedScriptValue@WebCore@@QAE?AVJSValue@JSC@@PAVExecState@4@PAVJSGlobalObject@4@PAV?$Vector@V?$RefPtr@VMessagePort@WebCore@@@WTF@@$00@WTF@@W4SerializationErrorMode@2@@Z -?deserializeBuffer@Internals@WebCore@@QBE?AV?$PassRefPtr@VSerializedScriptValue@WebCore@@@WTF@@V?$PassRefPtr@VArrayBuffer@WTF@@@4@@Z ?documentState@HistoryItem@WebCore@@QBEABV?$Vector@VString@WTF@@$0A@@WTF@@XZ ?ensureSelectFeatureSetCollected@ElementShadow@WebCore@@QAEXXZ ?equal@WTF@@YA_NPBVStringImpl@1@PBE@Z @@ -217,7 +216,6 @@ ?scriptNameToCode@WebCore@@YA?AW4UScriptCode@@ABVString@WTF@@@Z ?scrollElementToRect@FrameView@WebCore@@QAEXPAVElement@2@ABVIntRect@2@@Z ?scrollingStateTreeAsText@Page@WebCore@@QAE?AVString@WTF@@XZ -?serializeObject@Internals@WebCore@@QBE?AV?$PassRefPtr@VArrayBuffer@WTF@@@WTF@@V?$PassRefPtr@VSerializedScriptValue@WebCore@@@4@@Z ?setCanStartMedia@Page@WebCore@@QAEX_N@Z ?setCursiveFontFamily@Settings@WebCore@@QAEXABVAtomicString@WTF@@W4UScriptCode@@@Z ?setDeviceScaleFactor@Page@WebCore@@
[webkit-changes] [134743] trunk
Title: [134743] trunk Revision 134743 Author commit-qu...@webkit.org Date 2012-11-14 22:44:33 -0800 (Wed, 14 Nov 2012) Log Message [EFL] Port tiled backing store https://bugs.webkit.org/show_bug.cgi?id=71352 Patch by Ryuan Choi on 2012-11-14 Reviewed by Gyuyoung Kim. Source/WebKit/efl: Added ewk_view_setting_tiled_backing_store_enabled_{get|set} to give possibility to use WebCore's tiled backing store in WebKit/Efl port. This makes WebKit/Efl compliant with WebKit's generic solution of tiled backing store. * WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::invalidateRootView): (WebCore): (WebCore::ChromeClientEfl::visibleRectForTiledBackingStore): * WebCoreSupport/ChromeClientEfl.h: (ChromeClientEfl): * ewk/ewk_frame_private.h: Declared missing classes which used in this file. * ewk/ewk_paint_context.cpp: (ewk_paint_context_paint): Implemented to paint tiled backing store * ewk/ewk_view.cpp: (ewk_view_setting_tiled_backing_store_enabled_set): Added API to enable/disable the WebCore's tiled backing store. (ewk_view_setting_tiled_backing_store_enabled_get): Added API to query if the WebCore's tiled backing store is enabled. (ewk_view_tiled_backing_store_invalidate): * ewk/ewk_view.h: * ewk/ewk_view_private.h: * ewk/ewk_view_single.cpp: (_ewk_view_single_smart_repaints_process): Implemented to update visible area of tiled backing store. * tests/test_ewk_view.cpp: Added test case of ewk_view_setting_tiled_backing_store. (TEST_F): Tools: * EWebLauncher/main.c: Added option to test the WebCore's tiled backing store. (_User_Arguments): (windowCreate): (parseUserArguments): Modified Paths trunk/Source/WebKit/efl/ChangeLog trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h trunk/Source/WebKit/efl/ewk/ewk_frame_private.h trunk/Source/WebKit/efl/ewk/ewk_paint_context.cpp trunk/Source/WebKit/efl/ewk/ewk_view.cpp trunk/Source/WebKit/efl/ewk/ewk_view.h trunk/Source/WebKit/efl/ewk/ewk_view_private.h trunk/Source/WebKit/efl/ewk/ewk_view_single.cpp trunk/Source/WebKit/efl/tests/test_ewk_view.cpp trunk/Tools/ChangeLog trunk/Tools/EWebLauncher/main.c Diff Modified: trunk/Source/WebKit/efl/ChangeLog (134742 => 134743) --- trunk/Source/WebKit/efl/ChangeLog 2012-11-15 06:42:21 UTC (rev 134742) +++ trunk/Source/WebKit/efl/ChangeLog 2012-11-15 06:44:33 UTC (rev 134743) @@ -1,5 +1,40 @@ 2012-11-14 Ryuan Choi +[EFL] Port tiled backing store +https://bugs.webkit.org/show_bug.cgi?id=71352 + +Reviewed by Gyuyoung Kim. + +Added ewk_view_setting_tiled_backing_store_enabled_{get|set} to give possibility +to use WebCore's tiled backing store in WebKit/Efl port. This makes WebKit/Efl +compliant with WebKit's generic solution of tiled backing store. + +* WebCoreSupport/ChromeClientEfl.cpp: +(WebCore::ChromeClientEfl::invalidateRootView): +(WebCore): +(WebCore::ChromeClientEfl::visibleRectForTiledBackingStore): +* WebCoreSupport/ChromeClientEfl.h: +(ChromeClientEfl): +* ewk/ewk_frame_private.h: +Declared missing classes which used in this file. +* ewk/ewk_paint_context.cpp: +(ewk_paint_context_paint): Implemented to paint tiled backing store +* ewk/ewk_view.cpp: +(ewk_view_setting_tiled_backing_store_enabled_set): +Added API to enable/disable the WebCore's tiled backing store. +(ewk_view_setting_tiled_backing_store_enabled_get): +Added API to query if the WebCore's tiled backing store is enabled. +(ewk_view_tiled_backing_store_invalidate): +* ewk/ewk_view.h: +* ewk/ewk_view_private.h: +* ewk/ewk_view_single.cpp: +(_ewk_view_single_smart_repaints_process): +Implemented to update visible area of tiled backing store. +* tests/test_ewk_view.cpp: Added test case of ewk_view_setting_tiled_backing_store. +(TEST_F): + +2012-11-14 Ryuan Choi + [EFL] Refactor theme to choose whether to support foreground color of selection https://bugs.webkit.org/show_bug.cgi?id=102037 Modified: trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp (134742 => 134743) --- trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp 2012-11-15 06:42:21 UTC (rev 134742) +++ trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp 2012-11-15 06:44:33 UTC (rev 134743) @@ -515,9 +515,14 @@ notImplemented(); } -void ChromeClientEfl::invalidateRootView(const IntRect& /*updateRect*/, bool /*immediate*/) +void ChromeClientEfl::invalidateRootView(const IntRect& updateRect, bool /*immediate*/) { +#if USE(TILED_BACKING_STORE) +ewk_view_tiled_backing_store_invalidate(m_view, updateRect); +#else +UNUSED_PARAM(updateRect); notImplemented(); +#endif } void ChromeClientEfl::invalidateContentsAndRootView(const IntRect& updateRect, bool /*immediate*/) @@ -653,6 +658,16 @@ { notImplemented()
[webkit-changes] [134742] trunk/Source/WebKit/chromium
Title: [134742] trunk/Source/WebKit/chromium Revision 134742 Author commit-qu...@webkit.org Date 2012-11-14 22:42:21 -0800 (Wed, 14 Nov 2012) Log Message Unreviewed. Rolled DEPS. Patch by Sheriff Bot on 2012-11-14 * DEPS: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/DEPS Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (134741 => 134742) --- trunk/Source/WebKit/chromium/ChangeLog 2012-11-15 06:37:43 UTC (rev 134741) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-11-15 06:42:21 UTC (rev 134742) @@ -1,3 +1,9 @@ +2012-11-14 Sheriff Bot + +Unreviewed. Rolled DEPS. + +* DEPS: + 2012-11-14 Joshua Bell IndexedDB: Remove magic numbers in record comparator, handle missing case Modified: trunk/Source/WebKit/chromium/DEPS (134741 => 134742) --- trunk/Source/WebKit/chromium/DEPS 2012-11-15 06:37:43 UTC (rev 134741) +++ trunk/Source/WebKit/chromium/DEPS 2012-11-15 06:42:21 UTC (rev 134742) @@ -32,7 +32,7 @@ vars = { 'chromium_svn': 'http://src.chromium.org/svn/trunk/src', - 'chromium_rev': '167602' + 'chromium_rev': '167840' } deps = { ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134741] trunk
Title: [134741] trunk Revision 134741 Author dba...@webkit.org Date 2012-11-14 22:37:43 -0800 (Wed, 14 Nov 2012) Log Message Attempt to fix the Apple Windows Debug and GTK builds after (https://bugs.webkit.org/show_bug.cgi?id=96818) .: Export symbols similar to the ones we added to WebCore.exp.in in . * Source/autotools/symbols.filter: Source/WebKit2: Export symbols of the form: ?deserializeBuffer@Internals@WebCore[...] ?serializeObject@Internals@WebCore[...] * win/WebKit2.def: * win/WebKit2CFLite.def: Modified Paths trunk/ChangeLog trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/win/WebKit2.def trunk/Source/WebKit2/win/WebKit2CFLite.def trunk/Source/autotools/symbols.filter Diff Modified: trunk/ChangeLog (134740 => 134741) --- trunk/ChangeLog 2012-11-15 06:13:56 UTC (rev 134740) +++ trunk/ChangeLog 2012-11-15 06:37:43 UTC (rev 134741) @@ -1,3 +1,13 @@ +2012-11-14 Daniel Bates + +Attempt to fix the Apple Windows Debug and GTK builds after +(https://bugs.webkit.org/show_bug.cgi?id=96818) + +Export symbols similar to the ones we added to WebCore.exp.in in +. + +* Source/autotools/symbols.filter: + 2012-11-14 KyungTae Kim [EFL] Turn on error on warnings for "sign-compare" Modified: trunk/Source/WebKit2/ChangeLog (134740 => 134741) --- trunk/Source/WebKit2/ChangeLog 2012-11-15 06:13:56 UTC (rev 134740) +++ trunk/Source/WebKit2/ChangeLog 2012-11-15 06:37:43 UTC (rev 134741) @@ -1,3 +1,15 @@ +2012-11-14 Daniel Bates + +Attempt to fix the Apple Windows Debug and GTK builds after +(https://bugs.webkit.org/show_bug.cgi?id=96818) + +Export symbols of the form: +?deserializeBuffer@Internals@WebCore[...] +?serializeObject@Internals@WebCore[...] + +* win/WebKit2.def: +* win/WebKit2CFLite.def: + 2012-11-14 Alec Flett Fix windows build exports (again) Modified: trunk/Source/WebKit2/win/WebKit2.def (134740 => 134741) --- trunk/Source/WebKit2/win/WebKit2.def 2012-11-15 06:13:56 UTC (rev 134740) +++ trunk/Source/WebKit2/win/WebKit2.def 2012-11-15 06:37:43 UTC (rev 134741) @@ -172,6 +172,7 @@ ?create@ShadowRoot@WebCore@@SA?AV?$PassRefPtr@VShadowRoot@WebCore@@@WTF@@PAVElement@2@AAH@Z ?createWrapper@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNode@1@@Z ?deserialize@SerializedScriptValue@WebCore@@QAE?AVJSValue@JSC@@PAVExecState@4@PAVJSGlobalObject@4@PAV?$Vector@V?$RefPtr@VMessagePort@WebCore@@@WTF@@$00@WTF@@W4SerializationErrorMode@2@@Z +?deserializeBuffer@Internals@WebCore@@QBE?AV?$PassRefPtr@VSerializedScriptValue@WebCore@@@WTF@@V?$PassRefPtr@VArrayBuffer@WTF@@@4@@Z ?documentState@HistoryItem@WebCore@@QBEABV?$Vector@VString@WTF@@$0A@@WTF@@XZ ?ensureSelectFeatureSetCollected@ElementShadow@WebCore@@QAEXXZ ?equal@WTF@@YA_NPBVStringImpl@1@PBE@Z @@ -223,6 +224,7 @@ ?scriptNameToCode@WebCore@@YA?AW4UScriptCode@@ABVString@WTF@@@Z ?scrollElementToRect@FrameView@WebCore@@QAEXPAVElement@2@ABVIntRect@2@@Z ?scrollingStateTreeAsText@Page@WebCore@@QAE?AVString@WTF@@XZ +?serializeObject@Internals@WebCore@@QBE?AV?$PassRefPtr@VArrayBuffer@WTF@@@WTF@@V?$PassRefPtr@VSerializedScriptValue@WebCore@@@4@@Z ?setCanStartMedia@Page@WebCore@@QAEX_N@Z ?setCursiveFontFamily@Settings@WebCore@@QAEXABVAtomicString@WTF@@W4UScriptCode@@@Z ?setDeviceScaleFactor@Page@WebCore@@QAEXM@Z Modified: trunk/Source/WebKit2/win/WebKit2CFLite.def (134740 => 134741) --- trunk/Source/WebKit2/win/WebKit2CFLite.def 2012-11-15 06:13:56 UTC (rev 134740) +++ trunk/Source/WebKit2/win/WebKit2CFLite.def 2012-11-15 06:37:43 UTC (rev 134741) @@ -165,6 +165,7 @@ ?create@ShadowRoot@WebCore@@SA?AV?$PassRefPtr@VShadowRoot@WebCore@@@WTF@@PAVElement@2@AAH@Z ?createWrapper@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNode@1@@Z ?deserialize@SerializedScriptValue@WebCore@@QAE?AVJSValue@JSC@@PAVExecState@4@PAVJSGlobalObject@4@PAV?$Vector@V?$RefPtr@VMessagePort@WebCore@@@WTF@@$00@WTF@@W4SerializationErrorMode@2@@Z +?deserializeBuffer@Internals@WebCore@@QBE?AV?$PassRefPtr@VSerializedScriptValue@WebCore@@@WTF@@V?$PassRefPtr@VArrayBuffer@WTF@@@4@@Z ?documentState@HistoryItem@WebCore@@QBEABV?$Vector@VString@WTF@@$0A@@WTF@@XZ ?ensureSelectFeatureSetCollected@ElementShadow@WebCore@@QAEXXZ ?equal@WTF@@YA_NPBVStringImpl@1@PBE@Z @@ -216,6 +217,7 @@ ?scriptNameToCode@WebCore@@YA?AW4UScriptCode@@ABVString@WTF@@@Z ?scrollElementToRect@FrameView@WebCore@@QAEXPAVElement@2@ABVIntRect@2@@Z ?scrollingStateTreeAsText@Page@WebCore@@QAE?AVString@WTF@@XZ +?serializeObject@Internals@WebCore@@QBE?AV?$PassRefPtr@VArrayBuffer@WTF@@@WTF@@V?$PassRefPtr@VSerializedScriptValue@WebCore@@@4@@Z ?setCanStartMedia@Page@WebCore@@QAEX_N@Z ?setCursiveFontFamily@Settings@WebCore@@
[webkit-changes] [134740] branches/safari-536.28-branch/Source/WebCore
Title: [134740] branches/safari-536.28-branch/Source/WebCore Revision 134740 Author simon.fra...@apple.com Date 2012-11-14 22:13:56 -0800 (Wed, 14 Nov 2012) Log Message Scrolling some versions of the facebook page is very slow Merge r134737 2012-11-14 Simon Fraser Don't use temporary clip rects when hit testing https://bugs.webkit.org/show_bug.cgi?id=102329 Reviewed by Beth Dakin. We now cache clip rects separately for painting, hit testing etc. Hit testing clip rects are always shrunk to exclude scrollbars (so that hit testing on the scrollbars works), so we no longer every need to use temporary clip rects during hit testing. Added an assertion that the scrollbar relevancy when we computed the clip rects is the same as that when using them. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::updateClipRects): * rendering/RenderLayer.h: (WebCore::ClipRectsCache::ClipRectsCache): (ClipRectsCache): Modified Paths branches/safari-536.28-branch/Source/WebCore/ChangeLog branches/safari-536.28-branch/Source/WebCore/rendering/RenderLayer.cpp branches/safari-536.28-branch/Source/WebCore/rendering/RenderLayer.h Diff Modified: branches/safari-536.28-branch/Source/WebCore/ChangeLog (134739 => 134740) --- branches/safari-536.28-branch/Source/WebCore/ChangeLog 2012-11-15 06:11:11 UTC (rev 134739) +++ branches/safari-536.28-branch/Source/WebCore/ChangeLog 2012-11-15 06:13:56 UTC (rev 134740) @@ -1,3 +1,31 @@ +2012-11-14 Simon Fraser + + Scrolling some versions of the facebook page is very slow + +Merge r134737 + +2012-11-14 Simon Fraser + +Don't use temporary clip rects when hit testing +https://bugs.webkit.org/show_bug.cgi?id=102329 + +Reviewed by Beth Dakin. + +We now cache clip rects separately for painting, hit testing etc. Hit testing +clip rects are always shrunk to exclude scrollbars (so that hit testing on +the scrollbars works), so we no longer every need to use temporary clip rects +during hit testing. + +Added an assertion that the scrollbar relevancy when we computed the clip rects +is the same as that when using them. + +* rendering/RenderLayer.cpp: +(WebCore::RenderLayer::hitTestLayer): +(WebCore::RenderLayer::updateClipRects): +* rendering/RenderLayer.h: +(WebCore::ClipRectsCache::ClipRectsCache): +(ClipRectsCache): + 2012-11-14 Timothy Hatcher Merge r134100 Modified: branches/safari-536.28-branch/Source/WebCore/rendering/RenderLayer.cpp (134739 => 134740) --- branches/safari-536.28-branch/Source/WebCore/rendering/RenderLayer.cpp 2012-11-15 06:11:11 UTC (rev 134739) +++ branches/safari-536.28-branch/Source/WebCore/rendering/RenderLayer.cpp 2012-11-15 06:13:56 UTC (rev 134740) @@ -3456,7 +3456,6 @@ { // The natural thing would be to keep HitTestingTransformState on the stack, but it's big, so we heap-allocate. -bool useTemporaryClipRects = renderer()->view()->frameView()->containsScrollableAreaWithOverlayScrollbars(); LayoutRect hitTestArea = result.rectForPoint(hitTestPoint); @@ -3464,7 +3463,7 @@ if (transform() && !appliedTransform) { // Make sure the parent's clip rects have been calculated. if (parent()) { -ClipRect clipRect = backgroundClipRect(rootLayer, result.region(), useTemporaryClipRects ? TemporaryClipRects : RootRelativeClipRects, IncludeOverlayScrollbarSize); +ClipRect clipRect = backgroundClipRect(rootLayer, result.region(), RootRelativeClipRects, IncludeOverlayScrollbarSize); // Go ahead and test the enclosing clip now. if (!clipRect.intersects(hitTestArea)) return 0; @@ -3525,7 +3524,7 @@ ClipRect bgRect; ClipRect fgRect; ClipRect outlineRect; -calculateRects(rootLayer, result.region(), useTemporaryClipRects ? TemporaryClipRects : RootRelativeClipRects, hitTestRect, layerBounds, bgRect, fgRect, outlineRect, 0, IncludeOverlayScrollbarSize); +calculateRects(rootLayer, result.region(), RootRelativeClipRects, hitTestRect, layerBounds, bgRect, fgRect, outlineRect, 0, IncludeOverlayScrollbarSize); // The following are used for keeping track of the z-depth of the hit point of 3d-transformed // descendants. @@ -3801,6 +3800,7 @@ ASSERT(clipRectsType < NumCachedClipRectsTypes); if (m_clipRectsCache && m_clipRectsCache->m_clipRects[clipRectsType]) { ASSERT(rootLayer == m_clipRectsCache->m_clipRectsRoot[clipRectsType]); +ASSERT(m_clipRectsCache->m_scrollbarRelevancy[clipRectsType] == relevancy); return; // We have the correct cached value. } @@ -3823,6 +3823,7 @@ #ifndef NDEBUG m_clipRectsCache->m_clipRectsRoot[cli
[webkit-changes] [134739] branches/safari-536.28-branch
Title: [134739] branches/safari-536.28-branch Revision 134739 Author timo...@apple.com Date 2012-11-14 22:11:11 -0800 (Wed, 14 Nov 2012) Log Message Merge r134100. Modified Paths branches/safari-536.28-branch/LayoutTests/ChangeLog branches/safari-536.28-branch/Source/WebCore/ChangeLog branches/safari-536.28-branch/Source/WebCore/html/HTMLCanvasElement.cpp branches/safari-536.28-branch/Source/WebCore/platform/graphics/ImageBuffer.h branches/safari-536.28-branch/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp branches/safari-536.28-branch/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp branches/safari-536.28-branch/Source/WebCore/platform/graphics/qt/ImageBufferQt.cpp branches/safari-536.28-branch/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp branches/safari-536.28-branch/Source/WebCore/platform/graphics/wince/ImageBufferWinCE.cpp branches/safari-536.28-branch/Source/WebCore/platform/graphics/wx/ImageBufferWx.cpp Diff Modified: branches/safari-536.28-branch/LayoutTests/ChangeLog (134738 => 134739) --- branches/safari-536.28-branch/LayoutTests/ChangeLog 2012-11-15 05:48:35 UTC (rev 134738) +++ branches/safari-536.28-branch/LayoutTests/ChangeLog 2012-11-15 06:11:11 UTC (rev 134739) @@ -1,5 +1,22 @@ 2012-11-14 Timothy Hatcher +Merge r134100 + +2012-10-28 Timothy Hatcher + +Test if -webkit-canvas in CSS uses the full backing store instead +of always 1x when rendering. + +https://bugs.webkit.org/show_bug.cgi?id=100611 + +Reviewed by Dean Jackson. + +* fast/canvas/canvas-as-image-hidpi-expected.png: Added. +* fast/canvas/canvas-as-image-hidpi-expected.txt: Added. +* fast/canvas/canvas-as-image-hidpi.html: Added. + +2012-11-14 Timothy Hatcher + Merge r134099 2012-10-28 Timothy Hatcher Modified: branches/safari-536.28-branch/Source/WebCore/ChangeLog (134738 => 134739) --- branches/safari-536.28-branch/Source/WebCore/ChangeLog 2012-11-15 05:48:35 UTC (rev 134738) +++ branches/safari-536.28-branch/Source/WebCore/ChangeLog 2012-11-15 06:11:11 UTC (rev 134739) @@ -1,5 +1,37 @@ 2012-11-14 Timothy Hatcher +Merge r134100 + +2012-10-28 Timothy Hatcher + +Make -webkit-canvas in CSS use the full backing store instead +of always 1x when rendering. + +https://bugs.webkit.org/show_bug.cgi?id=100611 + +Reviewed by Dean Jackson. + +Test: fast/canvas/canvas-as-image-hidpi.html + +* html/HTMLCanvasElement.cpp: +(WebCore::HTMLCanvasElement::makePresentationCopy): Pass Unscaled to copyImage. +(WebCore::HTMLCanvasElement::copiedImage): Ditto. +* platform/graphics/ImageBuffer.h: +* platform/graphics/cg/ImageBufferCG.cpp: +(WebCore::ImageBuffer::copyImage): Added Scale parameter and use copyNativeImage for Unscaled. +* platform/graphics/cairo/ImageBufferCairo.cpp: +(WebCore::ImageBuffer::copyImage): Added unnamed ScaleBehavior parameter. +* platform/graphics/qt/ImageBufferQt.cpp: +(WebCore::ImageBuffer::copyImage): Ditto. +* platform/graphics/skia/ImageBufferSkia.cpp: +(WebCore::ImageBuffer::copyImage): Ditto. +* platform/graphics/wince/ImageBufferWinCE.cpp: +(WebCore::ImageBuffer::copyImage): Ditto. +* platform/graphics/wx/ImageBufferWx.cpp: +(WebCore::ImageBuffer::copyImage): Ditto. + +2012-11-14 Timothy Hatcher + Merge r134099 2012-10-28 Timothy Hatcher Modified: branches/safari-536.28-branch/Source/WebCore/html/HTMLCanvasElement.cpp (134738 => 134739) --- branches/safari-536.28-branch/Source/WebCore/html/HTMLCanvasElement.cpp 2012-11-15 05:48:35 UTC (rev 134738) +++ branches/safari-536.28-branch/Source/WebCore/html/HTMLCanvasElement.cpp 2012-11-15 06:11:11 UTC (rev 134739) @@ -370,7 +370,7 @@ { if (!m_presentedImage) { // The buffer contains the last presented data, so save a copy of it. -m_presentedImage = buffer()->copyImage(CopyBackingStore); +m_presentedImage = buffer()->copyImage(CopyBackingStore, Unscaled); } } @@ -600,7 +600,7 @@ if (!m_copiedImage && buffer()) { if (m_context) m_context->paintRenderingResultsToCanvas(); -m_copiedImage = buffer()->copyImage(CopyBackingStore); +m_copiedImage = buffer()->copyImage(CopyBackingStore, Unscaled); } return m_copiedImage.get(); } Modified: branches/safari-536.28-branch/Source/WebCore/platform/graphics/ImageBuffer.h (134738 => 134739) --- branches/safari-536.28-branch/Source/WebCore/platform/graphics/ImageBuffer.h 2012-11-15 05:48:35 UTC (rev 134738) +++ branches/safari-536.28-branch/Source/WebCore/platform/graphics/ImageBuffer.h 2012-11-15 06:11:11 UTC (rev 134739) @@ -73,6 +73,11 @@ Deferred }; +enum ScaleBehavior { +Scaled, +Unscaled +}; + class ImageBuffer { WTF_MAKE_NONCOPYABL
[webkit-changes] [134738] trunk/Source/WebCore
Title: [134738] trunk/Source/WebCore Revision 134738 Author hara...@chromium.org Date 2012-11-14 21:48:35 -0800 (Wed, 14 Nov 2012) Log Message Unreviewed. Rebaselined run-bindings-tests. * bindings/scripts/test/V8/V8TestNode.h: (WebCore::toV8Fast): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h Diff Modified: trunk/Source/WebCore/ChangeLog (134737 => 134738) --- trunk/Source/WebCore/ChangeLog 2012-11-15 05:47:01 UTC (rev 134737) +++ trunk/Source/WebCore/ChangeLog 2012-11-15 05:48:35 UTC (rev 134738) @@ -1,3 +1,10 @@ +2012-11-14 Kentaro Hara + +Unreviewed. Rebaselined run-bindings-tests. + +* bindings/scripts/test/V8/V8TestNode.h: +(WebCore::toV8Fast): + 2012-11-14 Simon Fraser Don't use temporary clip rects when hit testing Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h (134737 => 134738) --- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h 2012-11-15 05:47:01 UTC (rev 134737) +++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h 2012-11-15 05:48:35 UTC (rev 134738) @@ -88,17 +88,10 @@ // in an isolated world. The fastest way we know how to do that is to check // whether the holder's inline wrapper is the same wrapper we see in the // v8::AccessorInfo. -v8::Handle holderWrapper = info.Holder(); -if (holder->wrapper() == holderWrapper) { -v8::Handle wrapper = impl->wrapper(); -if (!wrapper.IsEmpty()) -return wrapper; -} else { -v8::Handle wrapper = V8DOMWrapper::getCachedWrapper(impl); -if (!wrapper.IsEmpty()) -return wrapper; -} -return wrap(impl, holderWrapper, info.GetIsolate()); +v8::Handle wrapper = (holder->wrapper() == info.Holder()) ? impl->wrapper() : V8DOMWrapper::getCachedWrapper(impl); +if (!wrapper.IsEmpty()) +return wrapper; +return wrap(impl, info.Holder(), info.GetIsolate()); } inline v8::Handle toV8(PassRefPtr< TestNode > impl, v8::Handle creationContext = v8::Handle(), v8::Isolate* isolate = 0) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134737] trunk/Source/WebCore
Title: [134737] trunk/Source/WebCore Revision 134737 Author simon.fra...@apple.com Date 2012-11-14 21:47:01 -0800 (Wed, 14 Nov 2012) Log Message Don't use temporary clip rects when hit testing https://bugs.webkit.org/show_bug.cgi?id=102329 Reviewed by Beth Dakin. We now cache clip rects separately for painting, hit testing etc. Hit testing clip rects are always shrunk to exclude scrollbars (so that hit testing on the scrollbars works), so we no longer every need to use temporary clip rects during hit testing. Added an assertion that the scrollbar relevancy when we computed the clip rects is the same as that when using them. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::updateClipRects): * rendering/RenderLayer.h: (WebCore::ClipRectsCache::ClipRectsCache): (ClipRectsCache): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderLayer.h Diff Modified: trunk/Source/WebCore/ChangeLog (134736 => 134737) --- trunk/Source/WebCore/ChangeLog 2012-11-15 05:33:41 UTC (rev 134736) +++ trunk/Source/WebCore/ChangeLog 2012-11-15 05:47:01 UTC (rev 134737) @@ -1,3 +1,25 @@ +2012-11-14 Simon Fraser + +Don't use temporary clip rects when hit testing +https://bugs.webkit.org/show_bug.cgi?id=102329 + +Reviewed by Beth Dakin. + +We now cache clip rects separately for painting, hit testing etc. Hit testing +clip rects are always shrunk to exclude scrollbars (so that hit testing on +the scrollbars works), so we no longer every need to use temporary clip rects +during hit testing. + +Added an assertion that the scrollbar relevancy when we computed the clip rects +is the same as that when using them. + +* rendering/RenderLayer.cpp: +(WebCore::RenderLayer::hitTestLayer): +(WebCore::RenderLayer::updateClipRects): +* rendering/RenderLayer.h: +(WebCore::ClipRectsCache::ClipRectsCache): +(ClipRectsCache): + 2012-11-14 Dirk Schulze Support animation of basic shape 'polygon' Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (134736 => 134737) --- trunk/Source/WebCore/rendering/RenderLayer.cpp 2012-11-15 05:33:41 UTC (rev 134736) +++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2012-11-15 05:47:01 UTC (rev 134737) @@ -3709,13 +3709,11 @@ // The natural thing would be to keep HitTestingTransformState on the stack, but it's big, so we heap-allocate. -bool useTemporaryClipRects = renderer()->view()->frameView()->containsScrollableAreaWithOverlayScrollbars(); - // Apply a transform if we have one. if (transform() && !appliedTransform) { // Make sure the parent's clip rects have been calculated. if (parent()) { -ClipRect clipRect = backgroundClipRect(rootLayer, hitTestLocation.region(), useTemporaryClipRects ? TemporaryClipRects : RootRelativeClipRects, IncludeOverlayScrollbarSize); +ClipRect clipRect = backgroundClipRect(rootLayer, hitTestLocation.region(), RootRelativeClipRects, IncludeOverlayScrollbarSize); // Go ahead and test the enclosing clip now. if (!clipRect.intersects(hitTestLocation)) return 0; @@ -3782,7 +3780,7 @@ ClipRect bgRect; ClipRect fgRect; ClipRect outlineRect; -calculateRects(rootLayer, hitTestLocation.region(), useTemporaryClipRects ? TemporaryClipRects : RootRelativeClipRects, hitTestRect, layerBounds, bgRect, fgRect, outlineRect, 0, IncludeOverlayScrollbarSize); +calculateRects(rootLayer, hitTestLocation.region(), RootRelativeClipRects, hitTestRect, layerBounds, bgRect, fgRect, outlineRect, 0, IncludeOverlayScrollbarSize); // The following are used for keeping track of the z-depth of the hit point of 3d-transformed // descendants. @@ -4071,6 +4069,7 @@ if (m_clipRectsCache && m_clipRectsCache->m_clipRects[clipRectsType]) { ASSERT(rootLayer == m_clipRectsCache->m_clipRectsRoot[clipRectsType]); ASSERT(m_clipRectsCache->m_respectingOverflowClip[clipRectsType] == (respectOverflowClip == RespectOverflowClip)); +ASSERT(m_clipRectsCache->m_scrollbarRelevancy[clipRectsType] == relevancy); return; // We have the correct cached value. } @@ -4094,6 +4093,7 @@ #ifndef NDEBUG m_clipRectsCache->m_clipRectsRoot[clipRectsType] = rootLayer; m_clipRectsCache->m_respectingOverflowClip[clipRectsType] = respectOverflowClip == RespectOverflowClip; +m_clipRectsCache->m_scrollbarRelevancy[clipRectsType] = relevancy; #endif } Modified: trunk/Source/WebCore/rendering/RenderLayer.h (134736 => 134737) --- trunk/Source/WebCore/rendering/RenderLayer.h 2012-11-15 05:33:41 UTC (rev 134736) +++ trunk/Source/WebCore/rendering/RenderLayer.h 2012-11-15 05:47:01 UTC (rev 134737) @@ -237,6 +237,7 @@ for (int i = 0; i < NumCachedClipRectsT
[webkit-changes] [134736] trunk
Title: [134736] trunk Revision 134736 Author k...@webkit.org Date 2012-11-14 21:33:41 -0800 (Wed, 14 Nov 2012) Log Message Support animation of basic shape 'polygon' https://bugs.webkit.org/show_bug.cgi?id=102080 Reviewed by Daniel Bates. Source/WebCore: The basic shapes 'circle', 'rectangle' and 'ellipse' are animatable with the committed patch http://trac.webkit.org/changeset/134352. This is a follow-up patch to make 'polygon' animatable as well, as long as the number of vertices between start and end polygon is the same. Added polygon animation test to existing test: fast/exclusions/shape-inside/shape-inside-animation.html css3/masking/clip-path-animation.html * page/animation/CSSPropertyAnimation.cpp: Forgot to add copyright with last commits. * rendering/style/BasicShapes.cpp: (WebCore::BasicShape::canBlend): Polygons are allowed now. (WebCore::BasicShapePolygon::blend): Interpolate polygon shapes. LayoutTests: Added animation test for basic shape 'polygon' to existing test css3/masking/clip-path-animation.html and fast/exclusions/shape-inside/shape-inside-animation.html. * animations/resources/animation-test-helpers.js: (parseBasicShape): * css3/masking/clip-path-animation-expected.txt: * css3/masking/clip-path-animation.html: * fast/exclusions/shape-inside/shape-inside-animation-expected.txt: * fast/exclusions/shape-inside/shape-inside-animation.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/animations/resources/animation-test-helpers.js trunk/LayoutTests/css3/masking/clip-path-animation-expected.txt trunk/LayoutTests/css3/masking/clip-path-animation.html trunk/LayoutTests/fast/exclusions/shape-inside/shape-inside-animation-expected.txt trunk/LayoutTests/fast/exclusions/shape-inside/shape-inside-animation.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp trunk/Source/WebCore/rendering/style/BasicShapes.cpp Diff Modified: trunk/LayoutTests/ChangeLog (134735 => 134736) --- trunk/LayoutTests/ChangeLog 2012-11-15 05:27:08 UTC (rev 134735) +++ trunk/LayoutTests/ChangeLog 2012-11-15 05:33:41 UTC (rev 134736) @@ -1,3 +1,21 @@ +2012-11-14 Dirk Schulze + +Support animation of basic shape 'polygon' +https://bugs.webkit.org/show_bug.cgi?id=102080 + +Reviewed by Daniel Bates. + +Added animation test for basic shape 'polygon' to existing test +css3/masking/clip-path-animation.html and +fast/exclusions/shape-inside/shape-inside-animation.html. + +* animations/resources/animation-test-helpers.js: +(parseBasicShape): +* css3/masking/clip-path-animation-expected.txt: +* css3/masking/clip-path-animation.html: +* fast/exclusions/shape-inside/shape-inside-animation-expected.txt: +* fast/exclusions/shape-inside/shape-inside-animation.html: + 2012-11-14 Shinya Kawanaka Changing pseudoClass (:checked) should cause distribution. Modified: trunk/LayoutTests/animations/resources/animation-test-helpers.js (134735 => 134736) --- trunk/LayoutTests/animations/resources/animation-test-helpers.js 2012-11-15 05:27:08 UTC (rev 134735) +++ trunk/LayoutTests/animations/resources/animation-test-helpers.js 2012-11-15 05:33:41 UTC (rev 134736) @@ -76,6 +76,9 @@ case "ellipse": matches = s.match("ellipse\\((.*)\\s*,\\s*(.*)\\s*,\\s*(.*)\\,\\s*(.*)\\)"); break; +case "polygon": +matches = s.match("polygon\\(nonzero, (.*)\\s+(.*)\\s*,\\s*(.*)\\s+(.*)\\s*,\\s*(.*)\\s+(.*)\\s*,\\s*(.*)\\s+(.*)\\)"); +break; default: return null; } Modified: trunk/LayoutTests/css3/masking/clip-path-animation-expected.txt (134735 => 134736) --- trunk/LayoutTests/css3/masking/clip-path-animation-expected.txt 2012-11-15 05:27:08 UTC (rev 134735) +++ trunk/LayoutTests/css3/masking/clip-path-animation-expected.txt 2012-11-15 05:33:41 UTC (rev 134736) @@ -1,5 +1,6 @@ - + PASS - "webkitClipPath" property for "rectangle-box" element at 1s saw something close to: rectangle(10%, 10%, 80%, 80%) PASS - "webkitClipPath" property for "circle-box" element at 1s saw something close to: circle(35%, 35%, 35%) PASS - "webkitClipPath" property for "ellipse-box" element at 1s saw something close to: ellipse(35%, 35%, 35%, 30%) +PASS - "webkitClipPath" property for "polygon-box" element at 1s saw something close to: polygon(nonzero, 10% 10%, 90% 10%, 90% 90%, 10% 90%) Modified: trunk/LayoutTests/css3/masking/clip-path-animation.html (134735 => 134736) --- trunk/LayoutTests/css3/masking/clip-path-animation.html 2012-11-15 05:27:08 UTC (rev 134735) +++ trunk/LayoutTests/css3/masking/clip-path-animation.html 2012-11-15 05:33:41 UTC (rev 134736) @@ -23,7 +23,11 @@ -webkit-animation: ellipse-anim 2s linear } +#polygon-box { + -webkit-animation: polygon-anim 2s linear +} + @-webkit-keyframes rectangle-anim { from { -webkit-clip-path: rectangle(0%, 0%, 100
[webkit-changes] [134735] trunk/Source/WebCore
Title: [134735] trunk/Source/WebCore Revision 134735 Author hara...@chromium.org Date 2012-11-14 21:27:08 -0800 (Wed, 14 Nov 2012) Log Message Unreviewed. Fix code generator warnings. * bindings/scripts/CodeGeneratorV8.pm: (GenerateFunctionCallback): (GenerateImplementation): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm Diff Modified: trunk/Source/WebCore/ChangeLog (134734 => 134735) --- trunk/Source/WebCore/ChangeLog 2012-11-15 05:18:02 UTC (rev 134734) +++ trunk/Source/WebCore/ChangeLog 2012-11-15 05:27:08 UTC (rev 134735) @@ -1,3 +1,11 @@ +2012-11-14 Kentaro Hara + +Unreviewed. Fix code generator warnings. + +* bindings/scripts/CodeGeneratorV8.pm: +(GenerateFunctionCallback): +(GenerateImplementation): + 2012-11-14 Shinya Kawanaka Changing pseudoClass (:checked) should cause distribution. Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (134734 => 134735) --- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-11-15 05:18:02 UTC (rev 134734) +++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-11-15 05:27:08 UTC (rev 134735) @@ -1551,7 +1551,6 @@ my $dataNode = shift; my $interfaceName = shift; -my $interfaceName = $dataNode->name; my $name = $function->signature->name; if (@{$function->{overloads}} > 1) { @@ -2669,7 +2668,6 @@ my $interfaceName = $dataNode->name; my $visibleInterfaceName = $codeGenerator->GetVisibleInterfaceName($dataNode); my $className = "V8$interfaceName"; -my $interfaceName = $interfaceName; my $nativeType = GetNativeTypeForConversions($dataNode, $interfaceName); # - Add default header template ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134734] branches/safari-536.28-branch
Title: [134734] branches/safari-536.28-branch Revision 134734 Author timo...@apple.com Date 2012-11-14 21:18:02 -0800 (Wed, 14 Nov 2012) Log Message Merge r134099. Modified Paths branches/safari-536.28-branch/LayoutTests/ChangeLog branches/safari-536.28-branch/Source/WebCore/ChangeLog branches/safari-536.28-branch/Source/WebCore/html/HTMLCanvasElement.cpp branches/safari-536.28-branch/Source/WebCore/html/HTMLCanvasElement.h Added Paths branches/safari-536.28-branch/LayoutTests/fast/canvas/canvas-resize-reset-pixelRatio-expected.txt branches/safari-536.28-branch/LayoutTests/fast/canvas/canvas-resize-reset-pixelRatio.html Diff Modified: branches/safari-536.28-branch/LayoutTests/ChangeLog (134733 => 134734) --- branches/safari-536.28-branch/LayoutTests/ChangeLog 2012-11-15 04:53:22 UTC (rev 134733) +++ branches/safari-536.28-branch/LayoutTests/ChangeLog 2012-11-15 05:18:02 UTC (rev 134734) @@ -1,3 +1,18 @@ +2012-11-14 Timothy Hatcher + +Merge r134099 + +2012-10-28 Timothy Hatcher + +Test the canvas backing store pixel ratio when the buffer resizes. + +https://bugs.webkit.org/show_bug.cgi?id=100608 + +Reviewed by Darin Adler. + +* fast/canvas/canvas-resize-reset-pixelRatio-expected.txt: Added. +* fast/canvas/canvas-resize-reset-pixelRatio.html: Added. + 2012-11-14 Beth Dakin testRunner is called layoutTestController on the branch. Added: branches/safari-536.28-branch/LayoutTests/fast/canvas/canvas-resize-reset-pixelRatio-expected.txt (0 => 134734) --- branches/safari-536.28-branch/LayoutTests/fast/canvas/canvas-resize-reset-pixelRatio-expected.txt (rev 0) +++ branches/safari-536.28-branch/LayoutTests/fast/canvas/canvas-resize-reset-pixelRatio-expected.txt 2012-11-15 05:18:02 UTC (rev 134734) @@ -0,0 +1,6 @@ +Testing webkitBackingStorePixelRatio after resize +PASS: webkitBackingStorePixelRatio is 1. +PASS: webkitBackingStorePixelRatio is 2. +PASS: webkitBackingStorePixelRatio is 1. +PASS: webkitBackingStorePixelRatio is 2. + Added: branches/safari-536.28-branch/LayoutTests/fast/canvas/canvas-resize-reset-pixelRatio.html (0 => 134734) --- branches/safari-536.28-branch/LayoutTests/fast/canvas/canvas-resize-reset-pixelRatio.html (rev 0) +++ branches/safari-536.28-branch/LayoutTests/fast/canvas/canvas-resize-reset-pixelRatio.html 2012-11-15 05:18:02 UTC (rev 134734) @@ -0,0 +1,56 @@ + + +function log(message) +{ +document.getElementById("console").appendChild(document.createTextNode(message + "\n")); +} + +if (!window.layoutTestController) +log("This test requires WebKitlayoutTestController or DumpRenderTree."); + +layoutTestController.dumpAsText(); +layoutTestController.waitUntilDone(); + +var canvas = document.createElement("canvas"); +canvas.width = 8; +canvas.height = 8; + +var context = canvas.getContext("2d"); +var cssContext = document.getCSSCanvasContext("2d", "test", 8, 8); + +if (context.webkitBackingStorePixelRatio !== 1) +log("FAIL: expected webkitBackingStorePixelRatio of 1, was " + context.webkitBackingStorePixelRatio + "."); + +layoutTestController.setBackingScaleFactor(2, function() { +var testCanvas = document.createElement("canvas"); +var testContext = testCanvas.getContext("2d"); + +if (testContext.webkitBackingStorePixelRatio === 2) { +log("Testing webkitBackingStorePixelRatio after resize"); + +function assertPixelRatio(context, expected) +{ +if (context.webkitBackingStorePixelRatio === expected) +log("PASS: webkitBackingStorePixelRatio is " + expected + "."); +else +log("FAIL: webkitBackingStorePixelRatio is " + context.webkitBackingStorePixelRatio + ", expected " + expected + "."); +} + +assertPixelRatio(context, 1); + +canvas.width = 8; +canvas.height = 8; + +assertPixelRatio(context, 2); + +assertPixelRatio(cssContext, 1); + +cssContext = document.getCSSCanvasContext("2d", "test", 8, 8); + +assertPixelRatio(cssContext, 2); +} else +log("High-DPI canvas is not enabled."); + +layoutTestController.notifyDone(); +}); + Modified: branches/safari-536.28-branch/Source/WebCore/ChangeLog (134733 => 134734) --- branches/safari-536.28-branch/Source/WebCore/ChangeLog 2012-11-15 04:53:22 UTC (rev 134733) +++ branches/safari-536.28-branch/Source/WebCore/ChangeLog 2012-11-15 05:18:02 UTC (rev 134734) @@ -1,3 +1,29 @@ +2012-11-14 Timothy Hatcher + +Merge r134099 + +2012-10-28 Timothy Hatcher + +Reset the canvas backing store pixel ratio when the buffer resizes. + +The backing store was not being recreated using the current page pixel ratio +when a resize occurred. + +https://bug
[webkit-changes] [134733] trunk/Source/WebKit2
Title: [134733] trunk/Source/WebKit2 Revision 134733 Author alecfl...@chromium.org Date 2012-11-14 20:53:22 -0800 (Wed, 14 Nov 2012) Log Message Fix windows build exports (again) https://bugs.webkit.org/show_bug.cgi?id=102324 Unreviewed windows-only build fix. Add one more export that was causing unit tests to fail to link. * win/WebKit2.def: * win/WebKit2CFLite.def: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/win/WebKit2.def trunk/Source/WebKit2/win/WebKit2CFLite.def Diff Modified: trunk/Source/WebKit2/ChangeLog (134732 => 134733) --- trunk/Source/WebKit2/ChangeLog 2012-11-15 04:29:21 UTC (rev 134732) +++ trunk/Source/WebKit2/ChangeLog 2012-11-15 04:53:22 UTC (rev 134733) @@ -1,3 +1,15 @@ +2012-11-14 Alec Flett + +Fix windows build exports (again) +https://bugs.webkit.org/show_bug.cgi?id=102324 + +Unreviewed windows-only build fix. + +Add one more export that was causing unit tests to fail to link. + +* win/WebKit2.def: +* win/WebKit2CFLite.def: + 2012-11-14 Brent Fulgham [WinCairo] Build correction after r134703. Modified: trunk/Source/WebKit2/win/WebKit2.def (134732 => 134733) --- trunk/Source/WebKit2/win/WebKit2.def 2012-11-15 04:29:21 UTC (rev 134732) +++ trunk/Source/WebKit2/win/WebKit2.def 2012-11-15 04:53:22 UTC (rev 134733) @@ -155,6 +155,7 @@ ??1ClientRectList@WebCore@@QAE@XZ ??0String@WTF@@QAE@PBD@Z ??0String@WTF@@QAE@PB_W@Z +??0String@WTF@@QAE@PB_WI@Z ??1SerializedScriptValue@WebCore@@QAE@XZ ?absoluteBoundingBoxRect@RenderObject@WebCore@@QBE?AVIntRect@2@_N@Z ?absoluteBoundingBoxRectIgnoringTransforms@RenderObject@WebCore@@QBE?AVIntRect@2@XZ Modified: trunk/Source/WebKit2/win/WebKit2CFLite.def (134732 => 134733) --- trunk/Source/WebKit2/win/WebKit2CFLite.def 2012-11-15 04:29:21 UTC (rev 134732) +++ trunk/Source/WebKit2/win/WebKit2CFLite.def 2012-11-15 04:53:22 UTC (rev 134733) @@ -148,6 +148,7 @@ ??1ClientRectList@WebCore@@QAE@XZ ??0String@WTF@@QAE@PBD@Z ??0String@WTF@@QAE@PB_W@Z +??0String@WTF@@QAE@PB_WI@Z ??1SerializedScriptValue@WebCore@@QAE@XZ ?absoluteBoundingBoxRect@RenderObject@WebCore@@QBE?AVIntRect@2@_N@Z ?absoluteBoundingBoxRectIgnoringTransforms@RenderObject@WebCore@@QBE?AVIntRect@2@XZ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134732] trunk
Title: [134732] trunk Revision 134732 Author shin...@chromium.org Date 2012-11-14 20:29:21 -0800 (Wed, 14 Nov 2012) Log Message Changing pseudoClass (:checked) should cause distribution. https://bugs.webkit.org/show_bug.cgi?id=101902 Reviewed by Dimitri Glazkov. Source/WebCore: When the 'checked' state is changed, we have to invalidate distribution. According to the HTML5 spec, :checked should match a checked input[type="checkbox"], a checked input[type="radio"], a selected option, and commands. However, we don't have a command element yet. Tests: fast/dom/shadow/pseudoclass-update-checked-input.html fast/dom/shadow/pseudoclass-update-checked-option.html * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setSelectedState): LayoutTests: Since an option element does not create a renderer, we cannot make its test a reftest. * fast/dom/shadow/pseudoclass-update-checked-input-expected.html: Added. * fast/dom/shadow/pseudoclass-update-checked-input.html: Added. * fast/dom/shadow/pseudoclass-update-checked-option-expected.txt: Added. * fast/dom/shadow/pseudoclass-update-checked-option.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLInputElement.cpp trunk/Source/WebCore/html/HTMLOptionElement.cpp Added Paths trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-checked-input-expected.html trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-checked-input.html trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-checked-option-expected.txt trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-checked-option.html Diff Modified: trunk/LayoutTests/ChangeLog (134731 => 134732) --- trunk/LayoutTests/ChangeLog 2012-11-15 03:52:52 UTC (rev 134731) +++ trunk/LayoutTests/ChangeLog 2012-11-15 04:29:21 UTC (rev 134732) @@ -1,3 +1,17 @@ +2012-11-14 Shinya Kawanaka + +Changing pseudoClass (:checked) should cause distribution. +https://bugs.webkit.org/show_bug.cgi?id=101902 + +Reviewed by Dimitri Glazkov. + +Since an option element does not create a renderer, we cannot make its test a reftest. + +* fast/dom/shadow/pseudoclass-update-checked-input-expected.html: Added. +* fast/dom/shadow/pseudoclass-update-checked-input.html: Added. +* fast/dom/shadow/pseudoclass-update-checked-option-expected.txt: Added. +* fast/dom/shadow/pseudoclass-update-checked-option.html: Added. + 2012-11-14 Keishi Hattori Add tests for week picker Added: trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-checked-input-expected.html (0 => 134732) --- trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-checked-input-expected.html (rev 0) +++ trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-checked-input-expected.html 2012-11-15 04:29:21 UTC (rev 134732) @@ -0,0 +1,21 @@ + + + + +When an input element became 'checked' or not-'checked', distribution should happen. + +Case 1: input[type=checkbox] becomes checked + + +Case 2: input[type=checkbox] becomes non-checked + + +Case 3: input[type=radio] becomes checked + + +Case 4: input[type=radio] becomes non-checked + + + + + Added: trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-checked-input.html (0 => 134732) --- trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-checked-input.html (rev 0) +++ trunk/LayoutTests/fast/dom/shadow/pseudoclass-update-checked-input.html 2012-11-15 04:29:21 UTC (rev 134732) @@ -0,0 +1,52 @@ + + + + + + + +When an input element became 'checked' or not-'checked', distribution should happen.
+ +Case 1: input[type=checkbox] becomes checked
++ ++ +Case 2: input[type=checkbox] becomes non-checked
++ ++ +Case 3: input[type=radio] becomes checked
++ ++ +Case 4: input[type=radio] becomes non-checked
++ ++ + +