date:20130111

[webkit-changes] [139413] trunk/Source/WebKit/chromium

2013-01-11 Thread pfeldman

Title: [139413] trunk/Source/WebKit/chromium








Revision 139413
Author pfeld...@chromium.org
Date 2013-01-11 00:33:06 -0800 (Fri, 11 Jan 2013)


Log Message
Web Inspector [chromium]: toolbar border is missing on non-Mac in docked-to-bottom mode
https://bugs.webkit.org/show_bug.cgi?id=106560

Reviewed by Vsevolod Vlasov.

* src/js/devTools.css:
(body.dock-to-bottom.platform-mac #toolbar):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/js/devTools.css




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (139412 => 139413)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-11 07:54:11 UTC (rev 139412)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-11 08:33:06 UTC (rev 139413)
@@ -1,3 +1,13 @@
+2013-01-11  Pavel Feldman  pfeld...@chromium.org
+
+Web Inspector [chromium]: toolbar border is missing on non-Mac in docked-to-bottom mode
+https://bugs.webkit.org/show_bug.cgi?id=106560
+
+Reviewed by Vsevolod Vlasov.
+
+* src/js/devTools.css:
+(body.dock-to-bottom.platform-mac #toolbar):
+
 2013-01-10  Noel Gordon  noel.gor...@gmail.com
 
 [chromium] Disable PNG and ICO image webkit-unit-tests after r139347


Modified: trunk/Source/WebKit/chromium/src/js/devTools.css (139412 => 139413)

--- trunk/Source/WebKit/chromium/src/js/devTools.css	2013-01-11 07:54:11 UTC (rev 139412)
+++ trunk/Source/WebKit/chromium/src/js/devTools.css	2013-01-11 08:33:06 UTC (rev 139413)
@@ -3,10 +3,13 @@
 }
 
 body.dock-to-bottom #toolbar {
-border-top-color: white;
 cursor: default; /* overriden */
 }
 
+body.dock-to-bottom.platform-mac #toolbar {
+border-top-color: white;
+}
+
 /* Chrome theme overrides */
 
 body.platform-windows #toolbar, body.platform-windows.inactive #toolbar {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139414] trunk

2013-01-11 Thread vsevik

Title: [139414] trunk








Revision 139414
Author vse...@chromium.org
Date 2013-01-11 00:37:07 -0800 (Fri, 11 Jan 2013)


Log Message
Web Inspector: Refactoring, move NetworkWorkspaceProvider to NetworkUISourceCodeProvider.js and rename its parent to SimpleWorkspaceProvider.
https://bugs.webkit.org/show_bug.cgi?id=106635

Reviewed by Pavel Feldman.

Source/WebCore:

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping):
* inspector/front-end/DefaultScriptMapping.js:
(WebInspector.DefaultScriptMapping):
(WebInspector.DefaultScriptMapping.prototype.addScript):
(WebInspector.DebuggerWorkspaceProvider):
(WebInspector.DebuggerWorkspaceProvider.prototype.addDebuggerFile):
* inspector/front-end/LiveEditSupport.js:
(WebInspector.LiveEditSupport):
(WebInspector.LiveEditSupport.prototype.uiSourceCodeForLiveEdit):
(WebInspector.LiveEditWorkspaceProvider):
(WebInspector.LiveEditWorkspaceProvider.prototype.addLiveEditFile):
* inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkWorkspaceProvider):
(WebInspector.NetworkWorkspaceProvider.prototype.addNetworkFile):
* inspector/front-end/SimpleWorkspaceProvider.js: Renamed from Source/WebCore/inspector/front-end/NetworkWorkspaceProvider.js.
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.requestFileContent):
(WebInspector.SimpleWorkspaceProvider.prototype.setFileContent):
(WebInspector.SimpleWorkspaceProvider.prototype.searchInFileContent):
(WebInspector.SimpleWorkspaceProvider.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFile):
(WebInspector.SimpleWorkspaceProvider.prototype.uniqueURI):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

LayoutTests:

* http/tests/inspector/compiler-script-mapping.html:
* inspector/debugger/resource-script-mapping.html:
* inspector/debugger/scripts-panel.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html
trunk/LayoutTests/inspector/debugger/resource-script-mapping.html
trunk/LayoutTests/inspector/debugger/scripts-panel.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/inspector/compile-front-end.py
trunk/Source/WebCore/inspector/front-end/DebuggerScriptMapping.js
trunk/Source/WebCore/inspector/front-end/DefaultScriptMapping.js
trunk/Source/WebCore/inspector/front-end/LiveEditSupport.js
trunk/Source/WebCore/inspector/front-end/NetworkUISourceCodeProvider.js
trunk/Source/WebCore/inspector/front-end/WebKit.qrc
trunk/Source/WebCore/inspector/front-end/inspector.html
trunk/Source/WebCore/inspector/front-end/inspector.js


Added Paths

trunk/Source/WebCore/inspector/front-end/SimpleWorkspaceProvider.js


Removed Paths

trunk/Source/WebCore/inspector/front-end/NetworkWorkspaceProvider.js




Diff

Modified: trunk/LayoutTests/ChangeLog (139413 => 139414)

--- trunk/LayoutTests/ChangeLog	2013-01-11 08:33:06 UTC (rev 139413)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 08:37:07 UTC (rev 139414)
@@ -1,3 +1,14 @@
+2013-01-11  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: Refactoring, move NetworkWorkspaceProvider to NetworkUISourceCodeProvider.js and rename its parent to SimpleWorkspaceProvider.
+https://bugs.webkit.org/show_bug.cgi?id=106635
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/compiler-script-mapping.html:
+* inspector/debugger/resource-script-mapping.html:
+* inspector/debugger/scripts-panel.html:
+
 2013-01-10  Grzegorz Czajkowski  g.czajkow...@samsung.com
 
 On Linux, should be able to get spelling suggestions without selecting the misspelled word


Modified: trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html (139413 => 139414)

--- trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html	2013-01-11 08:33:06 UTC (rev 139413)
+++ trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html	2013-01-11 08:37:07 UTC (rev 139414)
@@ -16,7 +16,7 @@
 InspectorTest.createWorkspace();
 var compilerScriptMapping = new WebInspector.CompilerScriptMapping(InspectorTest.testWorkspace, InspectorTest.testNetworkWorkspaceProvider);
 resourceScriptMapping = new WebInspector.ResourceScriptMapping(InspectorTest.testWorkspace);
-defaultScriptMapping = new WebInspector.DefaultScriptMapping(InspectorTest.testWorkspace, InspectorTest.testDebuggerWorkspaceProvider);
+defaultScriptMapping = new WebInspector.DefaultScriptMapping(InspectorTest.testWorkspace);
 return compilerScriptMapping;
 }
 
@@ -313,7 +313,7 @@
 var workspace = new WebInspector.Workspace();

[webkit-changes] [139415] trunk

2013-01-11 Thread carlosgc

Title: [139415] trunk








Revision 139415
Author carlo...@webkit.org
Date 2013-01-11 00:42:42 -0800 (Fri, 11 Jan 2013)


Log Message
[GTK] Add API to set the web extensions directory to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=106462

Reviewed by Xan Lopez.

.:

* Source/autotools/symbols.filter: Update
WebGtkExtensionManager::initialize symbol.

Source/WebKit2:

* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_set_web_extensions_directory): Set
the given directory as injected bundle initialization user data.
* UIProcess/API/gtk/WebKitWebContext.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
* UIProcess/API/gtk/tests/TestWebExtensions.cpp:
(beforeAll): Update the test to use
webkit_web_context_set_web_extensions_directory()
instead of setting the WEBKIT_WEB_EXTENSIONS_PATH env var.
* WebProcess/gtk/WebGtkExtensionManager.cpp:
(WebKit::WebGtkExtensionManager::scanModules): Append the given
additional web extensions directory to the list of directories to
scan for modules.
(WebKit::WebGtkExtensionManager::initialize): Get the additional
web extensions directory from initialization user data and pass it
to scanModules().
* WebProcess/gtk/WebGtkExtensionManager.h:
(WebGtkExtensionManager): Add userData parameter.
* WebProcess/gtk/WebGtkInjectedBundleMain.cpp:
(WKBundleInitialize): Pass initialization user data to
WebGtkExtensionManager.

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h
trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp
trunk/Source/WebKit2/WebProcess/gtk/WebGtkExtensionManager.cpp
trunk/Source/WebKit2/WebProcess/gtk/WebGtkExtensionManager.h
trunk/Source/WebKit2/WebProcess/gtk/WebGtkInjectedBundleMain.cpp
trunk/Source/autotools/symbols.filter




Diff

Modified: trunk/ChangeLog (139414 => 139415)

--- trunk/ChangeLog	2013-01-11 08:37:07 UTC (rev 139414)
+++ trunk/ChangeLog	2013-01-11 08:42:42 UTC (rev 139415)
@@ -1,3 +1,13 @@
+2013-01-10  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Add API to set the web extensions directory to WebKit2 GTK+
+https://bugs.webkit.org/show_bug.cgi?id=106462
+
+Reviewed by Xan Lopez.
+
+* Source/autotools/symbols.filter: Update
+WebGtkExtensionManager::initialize symbol.
+
 2013-01-10  Tony Chang  t...@chromium.org
 
 Speed up supplemental dependency computation


Modified: trunk/Source/WebKit2/ChangeLog (139414 => 139415)

--- trunk/Source/WebKit2/ChangeLog	2013-01-11 08:37:07 UTC (rev 139414)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-11 08:42:42 UTC (rev 139415)
@@ -1,3 +1,32 @@
+2013-01-10  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Add API to set the web extensions directory to WebKit2 GTK+
+https://bugs.webkit.org/show_bug.cgi?id=106462
+
+Reviewed by Xan Lopez.
+
+* UIProcess/API/gtk/WebKitWebContext.cpp:
+(webkit_web_context_set_web_extensions_directory): Set
+the given directory as injected bundle initialization user data.
+* UIProcess/API/gtk/WebKitWebContext.h:
+* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
+* UIProcess/API/gtk/tests/TestWebExtensions.cpp:
+(beforeAll): Update the test to use
+webkit_web_context_set_web_extensions_directory()
+instead of setting the WEBKIT_WEB_EXTENSIONS_PATH env var.
+* WebProcess/gtk/WebGtkExtensionManager.cpp:
+(WebKit::WebGtkExtensionManager::scanModules): Append the given
+additional web extensions directory to the list of directories to
+scan for modules.
+(WebKit::WebGtkExtensionManager::initialize): Get the additional
+web extensions directory from initialization user data and pass it
+to scanModules().
+* WebProcess/gtk/WebGtkExtensionManager.h:
+(WebGtkExtensionManager): Add userData parameter.
+* WebProcess/gtk/WebGtkInjectedBundleMain.cpp:
+(WKBundleInitialize): Pass initialization user data to
+WebGtkExtensionManager.
+
 2013-01-10  Huang Dongsung  luxte...@company100.net
 
 [Qt][EFL] Rename from xxxContentsScale() to xxxScale() in PageViewportController.


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp (139414 => 139415)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp	2013-01-11 08:37:07 UTC (rev 139414)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp	2013-01-11 08:42:42 UTC (rev 139415)
@@ -748,6 +748,24 @@
 return context-priv-tlsErrorsPolicy;
 }
 
+/**
+ * webkit_web_context_set_web_extensions_directory:
+ * @context: a #WebKitWebContext
+ * @directory: the directory to add
+ *
+ * Set the directory where WebKit will look for Web Extensions.
+ * This method must be called before loading anything in this

[webkit-changes] [139416] trunk

2013-01-11 Thread pfeldman

Title: [139416] trunk








Revision 139416
Author pfeld...@chromium.org
Date 2013-01-11 01:45:03 -0800 (Fri, 11 Jan 2013)


Log Message
Web Inspector [chromium]: Debugger.globalObjectCleared is not dispatched on reload after renderer swap
https://bugs.webkit.org/show_bug.cgi?id=106555

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Wrong ::enable was made virtual in the InspectorDebuggerAgent.

Test: inspector/debugger/debugger-scripts-reload.html

* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::enable):
(WebCore::PageDebuggerAgent::disable):
* inspector/PageDebuggerAgent.h:
(PageDebuggerAgent):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/debugger-scripts-reload-expected.txt: Added.
* inspector/debugger/debugger-scripts-reload.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/debugger-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h
trunk/Source/WebCore/inspector/PageDebuggerAgent.cpp
trunk/Source/WebCore/inspector/PageDebuggerAgent.h


Added Paths

trunk/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt
trunk/LayoutTests/inspector/debugger/debugger-scripts-reload.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139415 => 139416)

--- trunk/LayoutTests/ChangeLog	2013-01-11 08:42:42 UTC (rev 139415)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 09:45:03 UTC (rev 139416)
@@ -1,3 +1,15 @@
+2013-01-11  Pavel Feldman  pfeld...@chromium.org
+
+Web Inspector [chromium]: Debugger.globalObjectCleared is not dispatched on reload after renderer swap
+https://bugs.webkit.org/show_bug.cgi?id=106555
+
+Reviewed by Vsevolod Vlasov.
+
+* http/tests/inspector/debugger-test.js:
+(initialize_DebuggerTest):
+* inspector/debugger/debugger-scripts-reload-expected.txt: Added.
+* inspector/debugger/debugger-scripts-reload.html: Added.
+
 2013-01-11  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: Refactoring, move NetworkWorkspaceProvider to NetworkUISourceCodeProvider.js and rename its parent to SimpleWorkspaceProvider.


Modified: trunk/LayoutTests/http/tests/inspector/debugger-test.js (139415 => 139416)

--- trunk/LayoutTests/http/tests/inspector/debugger-test.js	2013-01-11 08:42:42 UTC (rev 139415)
+++ trunk/LayoutTests/http/tests/inspector/debugger-test.js	2013-01-11 09:45:03 UTC (rev 139416)
@@ -284,7 +284,7 @@
 var scripts = [];
 for (var scriptId in WebInspector.debuggerModel._scripts) {
 var script = WebInspector.debuggerModel._scripts[scriptId];
-if (filter(script))
+if (!filter || filter(script))
 scripts.push(script);
 }
 return scripts;


Added: trunk/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt (0 => 139416)

--- trunk/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt	2013-01-11 09:45:03 UTC (rev 139416)
@@ -0,0 +1,7 @@
+Tests that scripts list is cleared upon page reload.
+
+Debugger was enabled.
+Dummy script found: dummyScript.js
+Page reloaded.
+Debugger was disabled.
+
Property changes on: trunk/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/inspector/debugger/debugger-scripts-reload.html (0 => 139416)

--- trunk/LayoutTests/inspector/debugger/debugger-scripts-reload.html	(rev 0)
+++ trunk/LayoutTests/inspector/debugger/debugger-scripts-reload.html	2013-01-11 09:45:03 UTC (rev 139416)
@@ -0,0 +1,51 @@
+html
+head
+script src=""
+script src=""
+
+script
+
+function test()
+{
+InspectorTest.evaluateInPage(function foo() {} //@ sourceURL=dummyScript.js, step1);
+
+function step1()
+{
+InspectorTest.startDebuggerTest(step2);
+}
+
+function step2()
+{
+InspectorTest.queryScripts(function(script) { step3({ data: script }) });
+WebInspector.debuggerModel.addEventListener(WebInspector.DebuggerModel.Events.ParsedScriptSource, step3);
+}
+
+function step3(event)
+{
+var script = event.data;
+if (script.sourceURL.indexOf(dummyScript.js) !== -1) {
+InspectorTest.addResult(Dummy script found:  + script.sourceURL);
+// Let scripts dispatch and reload.
+setTimeout(InspectorTest.reloadPage.bind(InspectorTest, afterReload), 0);
+}
+}
+
+function afterReload()
+{
+var scripts = InspectorTest.queryScripts();
+for (var i = 0; i  scripts.length; ++i) {
+if (scripts[i].sourceURL.indexOf(dummyScript.js) !== -1)
+InspectorTest.addResult(FAILED: dummy script found after navigation);

[webkit-changes] [139417] trunk/Source

2013-01-11 Thread commit-queue

Title: [139417] trunk/Source








Revision 139417
Author commit-qu...@webkit.org
Date 2013-01-11 01:53:11 -0800 (Fri, 11 Jan 2013)


Log Message
[EFL] Fix unused parameter build error
https://bugs.webkit.org/show_bug.cgi?id=106639

Patch by KwangYong Choi ky0.c...@samsung.com on 2013-01-11
Reviewed by Kentaro Hara.

Use UNUSED_PARAM macro to fix build error.

Source/WebCore:

No new tests, no behavior change.

* platform/efl/EflScreenUtilities.cpp:
(WebCore::isUsingEcoreX):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::supportsDataListUI):

Source/WebKit/efl:

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::intentMessagePorts):
* ewk/ewk_contextmenu.cpp:
(ewk_context_menu_destroy):
(ewk_context_menu_item_select):
* ewk/ewk_file_chooser.cpp:
(ewk_file_chooser_capture_get):
* ewk/ewk_frame.cpp:
(ewk_frame_feed_touch_event):
* ewk/ewk_intent.cpp:
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_suggestions_get):
(ewk_intent_extra_get):
(ewk_intent_extra_names_get):
* ewk/ewk_intent_request.cpp:
(ewk_intent_request_ref):
(ewk_intent_request_unref):
(ewk_intent_request_intent_get):
* ewk/ewk_security_origin.cpp:
(ewk_security_origin_web_database_usage_get):
(ewk_security_origin_web_database_quota_get):
* ewk/ewk_settings.cpp:
(ewk_settings_shadow_dom_enable_set):
* ewk/ewk_view.cpp:
(ewk_view_context_menu_forward_event):
(ewk_view_setting_should_display_subtitles_get):
(ewk_view_setting_should_display_captions_get):
(ewk_view_setting_should_display_captions_set):
(ewk_view_setting_should_display_subtitles_set):
(ewk_view_setting_should_display_text_descriptions_get):
(ewk_view_setting_should_display_text_descriptions_set):

Source/WebKit2:

* UIProcess/API/efl/ewk_color_picker.cpp:
(ewk_color_picker_color_set):
(ewk_color_picker_color_get):
* UIProcess/API/efl/ewk_context.cpp:
(ewk_context_additional_plugin_path_set):
* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_fullscreen_enabled_set):
(ewk_settings_fullscreen_enabled_get):
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_intent_deliver):
(ewk_view_feed_touch_event):
(ewk_view_touch_events_enabled_set):
(ewk_view_touch_events_enabled_get):
(ewk_view_fullscreen_exit):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/EflScreenUtilities.cpp
trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp
trunk/Source/WebKit/efl/ewk/ewk_contextmenu.cpp
trunk/Source/WebKit/efl/ewk/ewk_file_chooser.cpp
trunk/Source/WebKit/efl/ewk/ewk_frame.cpp
trunk/Source/WebKit/efl/ewk/ewk_intent.cpp
trunk/Source/WebKit/efl/ewk/ewk_intent_request.cpp
trunk/Source/WebKit/efl/ewk/ewk_security_origin.cpp
trunk/Source/WebKit/efl/ewk/ewk_settings.cpp
trunk/Source/WebKit/efl/ewk/ewk_view.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_color_picker.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139416 => 139417)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 09:45:03 UTC (rev 139416)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 09:53:11 UTC (rev 139417)
@@ -1,3 +1,19 @@
+2013-01-11  KwangYong Choi  ky0.c...@samsung.com
+
+[EFL] Fix unused parameter build error
+https://bugs.webkit.org/show_bug.cgi?id=106639
+
+Reviewed by Kentaro Hara.
+
+Use UNUSED_PARAM macro to fix build error.
+
+No new tests, no behavior change.
+
+* platform/efl/EflScreenUtilities.cpp:
+(WebCore::isUsingEcoreX):
+* platform/efl/RenderThemeEfl.cpp:
+(WebCore::RenderThemeEfl::supportsDataListUI):
+
 2013-01-11  Pavel Feldman  pfeld...@chromium.org
 
 Web Inspector [chromium]: Debugger.globalObjectCleared is not dispatched on reload after renderer swap


Modified: trunk/Source/WebCore/platform/efl/EflScreenUtilities.cpp (139416 => 139417)

--- trunk/Source/WebCore/platform/efl/EflScreenUtilities.cpp	2013-01-11 09:45:03 UTC (rev 139416)
+++ trunk/Source/WebCore/platform/efl/EflScreenUtilities.cpp	2013-01-11 09:53:11 UTC (rev 139417)
@@ -146,6 +146,7 @@
 || !strcmp(engine, software_16_x11)
 || !strncmp(engine, xrender, sizeof(xrender) - 1);
 #else
+UNUSED_PARAM(evas);
 return false;
 #endif
 }


Modified: trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp (139416 => 139417)

--- trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2013-01-11 09:45:03 UTC (rev 139416)
+++ trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2013-01-11 09:53:11 UTC (rev 139417)
@@ -757,6 +757,7 @@
 // FIXME: We need to support other types.
 return type == InputTypeNames::range();
 #else
+UNUSED_PARAM(type);
 return false;
 #endif
 }


Modified: trunk/Source/WebKit/efl/ChangeLog (139416 => 139417)

---

[webkit-changes] [139418] trunk

2013-01-11 Thread commit-queue

Title: [139418] trunk








Revision 139418
Author commit-qu...@webkit.org
Date 2013-01-11 02:06:11 -0800 (Fri, 11 Jan 2013)


Log Message
Web Inspector: [Resources] Delete cookie deletes all cookies with matching name.
https://bugs.webkit.org/show_bug.cgi?id=105633

Patch by Eugene Klyuchnikov eus...@chromium.org on 2013-01-11
Reviewed by Pavel Feldman.

Source/WebCore:

Delete cookie deletes all cookies with matching name,
ignoring domain and path.

* inspector/Inspector.json: Change argument domain to url
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::deleteCookie): Use url to delte cookies.
* inspector/InspectorPageAgent.h: Adopt new signature.
* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype._deleteCookie): Ditto.

LayoutTests:

Adopt new signatures.

* http/tests/inspector/resource-main-cookies.php:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/resource-main-cookies.php
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp
trunk/Source/WebCore/inspector/InspectorPageAgent.h
trunk/Source/WebCore/inspector/front-end/CookieItemsView.js




Diff

Modified: trunk/LayoutTests/ChangeLog (139417 => 139418)

--- trunk/LayoutTests/ChangeLog	2013-01-11 09:53:11 UTC (rev 139417)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 10:06:11 UTC (rev 139418)
@@ -1,3 +1,14 @@
+2013-01-11  Eugene Klyuchnikov  eus...@chromium.org
+
+Web Inspector: [Resources] Delete cookie deletes all cookies with matching name.
+https://bugs.webkit.org/show_bug.cgi?id=105633
+
+Reviewed by Pavel Feldman.
+
+Adopt new signatures.
+
+* http/tests/inspector/resource-main-cookies.php:
+
 2013-01-11  Pavel Feldman  pfeld...@chromium.org
 
 Web Inspector [chromium]: Debugger.globalObjectCleared is not dispatched on reload after renderer swap


Modified: trunk/LayoutTests/http/tests/inspector/resource-main-cookies.php (139417 => 139418)

--- trunk/LayoutTests/http/tests/inspector/resource-main-cookies.php	2013-01-11 09:53:11 UTC (rev 139417)
+++ trunk/LayoutTests/http/tests/inspector/resource-main-cookies.php	2013-01-11 10:06:11 UTC (rev 139418)
@@ -11,8 +11,9 @@
 {
 var cookieName = cookieName;
 var cookieDomain = 127.0.0.1;
+var cookieURL = http:// + cookieDomain + /;
 // Ensure cookie is deleted before testing.
-PageAgent.deleteCookie(cookieName, cookieDomain, step1);
+PageAgent.deleteCookie(cookieName, cookieURL, step1);
 
 function step1()
 {
@@ -33,7 +34,7 @@
 }
 }
 // Ensure cookie is deleted after testing.
-PageAgent.deleteCookie(cookieName, cookieDomain, step4);
+PageAgent.deleteCookie(cookieName, cookieURL, step4);
 }
 
 function step4()


Modified: trunk/Source/WebCore/ChangeLog (139417 => 139418)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 09:53:11 UTC (rev 139417)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 10:06:11 UTC (rev 139418)
@@ -1,3 +1,20 @@
+2013-01-11  Eugene Klyuchnikov  eus...@chromium.org
+
+Web Inspector: [Resources] Delete cookie deletes all cookies with matching name.
+https://bugs.webkit.org/show_bug.cgi?id=105633
+
+Reviewed by Pavel Feldman.
+
+Delete cookie deletes all cookies with matching name,
+ignoring domain and path.
+
+* inspector/Inspector.json: Change argument domain to url
+* inspector/InspectorPageAgent.cpp:
+(WebCore::InspectorPageAgent::deleteCookie): Use url to delte cookies.
+* inspector/InspectorPageAgent.h: Adopt new signature.
+* inspector/front-end/CookieItemsView.js:
+(WebInspector.CookieItemsView.prototype._deleteCookie): Ditto.
+
 2013-01-11  KwangYong Choi  ky0.c...@samsung.com
 
 [EFL] Fix unused parameter build error


Modified: trunk/Source/WebCore/inspector/Inspector.json (139417 => 139418)

--- trunk/Source/WebCore/inspector/Inspector.json	2013-01-11 09:53:11 UTC (rev 139417)
+++ trunk/Source/WebCore/inspector/Inspector.json	2013-01-11 10:06:11 UTC (rev 139418)
@@ -259,9 +259,9 @@
 name: deleteCookie,
 parameters: [
 { name: cookieName, type: string, description: Name of the cookie to remove. },
-{ name: domain, type: string, description: Domain of the cookie to remove. }
+{ name: url, type: string, description: URL to match cooke domain and path. }
 ],
-description: Deletes browser cookie with given name for the given domain.,
+description: Deletes browser cookie with given name, domain and path.,
 hidden: true
 },
 {


Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (139417 => 139418)

--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp	2013-01-11 09:53:11 UTC (rev 139417)
+++

[webkit-changes] [139420] trunk/Tools

2013-01-11 Thread commit-queue

Title: [139420] trunk/Tools








Revision 139420
Author commit-qu...@webkit.org
Date 2013-01-11 02:11:47 -0800 (Fri, 11 Jan 2013)


Log Message
Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
https://bugs.webkit.org/show_bug.cgi?id=106636

Patch by Alan Cutter alancut...@chromium.org on 2013-01-11
Reviewed by Adam Barth.

This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.

* EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
* EWSTools/GoogleComputeEngine/build-commit-queue.sh:
* EWSTools/screen-config:
* EWSTools/start-queue.sh:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh
trunk/Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh
trunk/Tools/EWSTools/screen-config
trunk/Tools/EWSTools/start-queue.sh




Diff

Modified: trunk/Tools/ChangeLog (139419 => 139420)

--- trunk/Tools/ChangeLog	2013-01-11 10:07:49 UTC (rev 139419)
+++ trunk/Tools/ChangeLog	2013-01-11 10:11:47 UTC (rev 139420)
@@ -1,3 +1,17 @@
+2013-01-11  Alan Cutter  alancut...@chromium.org
+
+Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
+https://bugs.webkit.org/show_bug.cgi?id=106636
+
+Reviewed by Adam Barth.
+
+This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
+
+* EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
+* EWSTools/GoogleComputeEngine/build-commit-queue.sh:
+* EWSTools/screen-config:
+* EWSTools/start-queue.sh:
+
 2013-01-10  Ryosuke Niwa  rn...@webkit.org
 
 kill-old-processes and delete-stale-build-files use CRLF linebreaks


Modified: trunk/Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh (139419 => 139420)

--- trunk/Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh	2013-01-11 10:07:49 UTC (rev 139419)
+++ trunk/Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh	2013-01-11 10:11:47 UTC (rev 139420)
@@ -54,6 +54,6 @@
 cd tools 
 bash build-vm.sh 
 bash build-repo.sh $QUEUE_TYPE $BUGZILLA_USERNAME $BUGZILLA_PASSWORD 
-bash build-boot-cmd.sh \screen -t kr ./start-queue.sh $QUEUE_TYPE $BOT_ID\ 
+bash build-boot-cmd.sh \screen -t kr ./start-queue.sh $QUEUE_TYPE $BOT_ID 10\ 
 bash boot.sh
 


Modified: trunk/Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh (139419 => 139420)

--- trunk/Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh	2013-01-11 10:07:49 UTC (rev 139419)
+++ trunk/Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh	2013-01-11 10:11:47 UTC (rev 139420)
@@ -58,6 +58,6 @@
 bash configure-svn-auth.sh $SVN_USERNAME $SVN_PASSWORD 
 bash build-vm.sh 
 bash build-repo.sh $QUEUE_TYPE $BUGZILLA_USERNAME $BUGZILLA_PASSWORD 
-bash build-boot-cmd.sh \screen -t kr ./start-queue.sh $QUEUE_TYPE $BOT_ID\ 
+bash build-boot-cmd.sh \screen -t kr ./start-queue.sh $QUEUE_TYPE $BOT_ID 10\ 
 bash boot.sh
 


Modified: trunk/Tools/EWSTools/screen-config (139419 => 139420)

--- trunk/Tools/EWSTools/screen-config	2013-01-11 10:07:49 UTC (rev 139419)
+++ trunk/Tools/EWSTools/screen-config	2013-01-11 10:11:47 UTC (rev 139420)
@@ -1,4 +1,4 @@
-screen -t style ./start-queue.sh style-queue
-screen -t qt ./start-queue.sh qt-ews
-screen -t kr ./start-queue.sh chromium-ews
-screen -t gtk ./start-queue.sh gtk-ews
+screen -t style ./start-queue.sh style-queue 10
+screen -t qt ./start-queue.sh qt-ews 10
+screen -t kr ./start-queue.sh chromium-ews 10
+screen -t gtk ./start-queue.sh gtk-ews 10


Modified: trunk/Tools/EWSTools/start-queue.sh (139419 => 139420)

--- trunk/Tools/EWSTools/start-queue.sh	2013-01-11 10:07:49 UTC (rev 139419)
+++ trunk/Tools/EWSTools/start-queue.sh	2013-01-11 10:11:47 UTC (rev 139420)
@@ -27,31 +27,38 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+if [[ $# -lt 3 ]] || [[ $# -gt 4 ]]; then
+echo Usage: start-queue-loop.sh QUEUE_NAME BOT_ID RESET_AFTER_ITERATION [QUEUE_PARAMS]
+exit 1
+fi
+
 QUEUE_NAME=$1
 BOT_ID=$2
+RESET_AFTER_ITERATION=$3
+QUEUE_PARAMS=$4
 
 cd /mnt/git/webkit-$QUEUE_NAME
 while :
 do
-  # This somewhat quirky sequence of steps seems to clear up all the broken
-  # git situations we've gotten ourself into in the past.
-  git clean -f # Remove any left-over layout test results, added files, etc.
-  git rebase --abort # If we got killed during a git rebase, we need to clean up.
-  git fetch origin # Avoid updating the working copy to a stale revision.
-  git checkout origin/master -f
-  git branch -D master
-  git checkout origin/master -b master
+# This somewhat quirky sequence of steps seems to clear up all the broken
+# git situations we've gotten ourself into in the past.
+git clean -f # Remove any left-over layout test results, added files, etc.
+git rebase --abort # If we got killed during a git

[webkit-changes] [139421] trunk/Source/WebKit2

2013-01-11 Thread commit-queue

Title: [139421] trunk/Source/WebKit2








Revision 139421
Author commit-qu...@webkit.org
Date 2013-01-11 02:30:15 -0800 (Fri, 11 Jan 2013)


Log Message
[WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
https://bugs.webkit.org/show_bug.cgi?id=106447

Patch by Krzysztof Czech k.cz...@samsung.com on 2013-01-11
Reviewed by Andreas Kling.

Files do not have HAVE(ACCESSIBILITY) guards.
This is source of potential build breakes, when macro is not enabled.

* WebProcess/WebPage/atk/WebPageAccessibilityObject.h:
* WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObject.h
trunk/Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139420 => 139421)

--- trunk/Source/WebKit2/ChangeLog	2013-01-11 10:11:47 UTC (rev 139420)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-11 10:30:15 UTC (rev 139421)
@@ -1,3 +1,16 @@
+2013-01-11  Krzysztof Czech  k.cz...@samsung.com
+
+[WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
+https://bugs.webkit.org/show_bug.cgi?id=106447
+
+Reviewed by Andreas Kling.
+
+Files do not have HAVE(ACCESSIBILITY) guards.
+This is source of potential build breakes, when macro is not enabled.
+
+* WebProcess/WebPage/atk/WebPageAccessibilityObject.h:
+* WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:
+
 2013-01-11  KwangYong Choi  ky0.c...@samsung.com
 
 [EFL] Fix unused parameter build error


Modified: trunk/Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObject.h (139420 => 139421)

--- trunk/Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObject.h	2013-01-11 10:11:47 UTC (rev 139420)
+++ trunk/Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObject.h	2013-01-11 10:30:15 UTC (rev 139421)
@@ -26,6 +26,8 @@
 #ifndef WebPageAccessibilityObject_h
 #define WebPageAccessibilityObject_h
 
+#if HAVE(ACCESSIBILITY)
+
 #include atk/atk.h
 
 namespace WebKit {
@@ -61,4 +63,5 @@
 
 G_END_DECLS
 
+#endif
 #endif // WebPageAccessibilityObject_h


Modified: trunk/Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp (139420 => 139421)

--- trunk/Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp	2013-01-11 10:11:47 UTC (rev 139420)
+++ trunk/Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp	2013-01-11 10:30:15 UTC (rev 139421)
@@ -26,6 +26,8 @@
 #include config.h
 #include WebPageAccessibilityObject.h
 
+#if HAVE(ACCESSIBILITY)
+
 #include WebPage.h
 #include WebCore/AXObjectCache.h
 #include WebCore/Frame.h
@@ -138,3 +140,5 @@
 return;
 atk_object_set_parent(rootObject, ATK_OBJECT(accessible));
 }
+
+#endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139422] trunk/Source/WebKit2

2013-01-11 Thread commit-queue

Title: [139422] trunk/Source/WebKit2








Revision 139422
Author commit-qu...@webkit.org
Date 2013-01-11 02:31:42 -0800 (Fri, 11 Jan 2013)


Log Message
[EFL][WK2] Add ewk_view_page_contents_get() API
https://bugs.webkit.org/show_bug.cgi?id=106440

Patch by KwangYong Choi ky0.c...@samsung.com on 2013-01-11
Reviewed by Gyuyoung Kim.

Add ewk_view_page_contents_get() API for getting contents of the current page.
Currently, it supports only MHTML type.

* UIProcess/API/efl/ewk_view.cpp:
(Ewk_Page_Contents_Context):
(ewkViewPageContentsCallback):
(ewk_view_page_contents_get):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(PageContentsCallback):
(TEST_F):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h
trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139421 => 139422)

--- trunk/Source/WebKit2/ChangeLog	2013-01-11 10:30:15 UTC (rev 139421)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-11 10:31:42 UTC (rev 139422)
@@ -1,3 +1,22 @@
+2013-01-11  KwangYong Choi  ky0.c...@samsung.com
+
+[EFL][WK2] Add ewk_view_page_contents_get() API
+https://bugs.webkit.org/show_bug.cgi?id=106440
+
+Reviewed by Gyuyoung Kim.
+
+Add ewk_view_page_contents_get() API for getting contents of the current page.
+Currently, it supports only MHTML type.
+
+* UIProcess/API/efl/ewk_view.cpp:
+(Ewk_Page_Contents_Context):
+(ewkViewPageContentsCallback):
+(ewk_view_page_contents_get):
+* UIProcess/API/efl/ewk_view.h:
+* UIProcess/API/efl/tests/test_ewk2_view.cpp:
+(PageContentsCallback):
+(TEST_F):
+
 2013-01-11  Krzysztof Czech  k.cz...@samsung.com
 
 [WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.


Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (139421 => 139422)

--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp	2013-01-11 10:30:15 UTC (rev 139421)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp	2013-01-11 10:31:42 UTC (rev 139422)
@@ -39,6 +39,7 @@
 #include WKRetainPtr.h
 #include WKString.h
 #include WebContext.h
+#include WebData.h
 #include WebFullScreenManagerProxy.h
 #include WebPageGroup.h
 #include WebPreferences.h
@@ -145,6 +146,17 @@
 }  \
 } while (0)
 
+/// Creates a type name for Ewk_Page_Contents_Context.
+typedef struct Ewk_Page_Contents_Context Ewk_Page_Contents_Context;
+
+/*
+ * @brief Structure containing page contents context used for ewk_view_page_contents_get() API.
+ */
+struct Ewk_Page_Contents_Context {
+Ewk_Page_Contents_Type type;
+Ewk_Page_Contents_Cb callback;
+};
+
 static void _ewk_view_smart_changed(Ewk_View_Smart_Data* smartData)
 {
 if (smartData-changed.any)
@@ -938,3 +950,36 @@
 
 impl-setDrawsBackground(enabled);
 }
+
+/**
+ * @internal
+ * Callback function used for ewk_view_page_contents_get().
+ */
+static void ewkViewPageContentsCallback(WKDataRef wkData, WKErrorRef, void* context)
+{
+EINA_SAFETY_ON_NULL_RETURN(context);
+
+RefPtrWebData webData = toImpl(wkData);
+Ewk_Page_Contents_Context* contentsContext= static_castEwk_Page_Contents_Context*(context);
+contentsContext-callback(contentsContext-type, reinterpret_castconst char*(webData-bytes()));
+
+delete contentsContext;
+}
+
+Eina_Bool ewk_view_page_contents_get(const Evas_Object* ewkView, Ewk_Page_Contents_Type type, Ewk_Page_Contents_Cb callback)
+{
+EINA_SAFETY_ON_NULL_RETURN_VAL(callback, false);
+EWK_VIEW_IMPL_GET_OR_RETURN(ewkView, impl, false);
+
+// We only support MHTML at the moment.
+if (type != EWK_PAGE_CONTENTS_TYPE_MHTML)
+return false;
+
+Ewk_Page_Contents_Context* context = new Ewk_Page_Contents_Context;
+context-type = type;
+context-callback = callback;
+
+impl-page()-getContentsAsMHTMLData(DataCallback::create(context, ewkViewPageContentsCallback), false);
+
+return true;
+}


Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h (139421 => 139422)

--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h	2013-01-11 10:30:15 UTC (rev 139421)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h	2013-01-11 10:31:42 UTC (rev 139422)
@@ -107,6 +107,11 @@
 EWK_TEXT_DIRECTION_LEFT_TO_RIGHT
 } Ewk_Text_Direction;
 
+/// Enum values containing page contents type values.
+typedef enum {
+EWK_PAGE_CONTENTS_TYPE_MHTML
+} Ewk_Page_Contents_Type;
+
 typedef struct Ewk_View_Smart_Data Ewk_View_Smart_Data;
 typedef struct Ewk_View_Smart_Class Ewk_View_Smart_Class;
 
@@ -315,6 +320,14 @@
 } Ewk_Pagination_Mode;
 
 /**
+ * Creates a type name for the callback function used to get the page contents.
+ *
+ * @param type type of the contents
+ * @param data string buffer of the contents
+ */
+typedef void

[webkit-changes] [139423] trunk/Source/WebCore

2013-01-11 Thread mary . wu

Title: [139423] trunk/Source/WebCore








Revision 139423
Author mary...@torchmobile.com.cn
Date 2013-01-11 03:12:18 -0800 (Fri, 11 Jan 2013)


Log Message
[BlackBerry] Enable concatenating headers with same field name
https://bugs.webkit.org/show_bug.cgi?id=106625

Reviewed by Rob Buis.

RFC 2616 specifies that headers could concatenate with comma if they have
same field name. We should enable this if the header allows multiple values.

RIM PR# 275508, internally reviewed by Joe Mason

(WebCore):
(WebCore::isAppendableHeader):
(WebCore::NetworkJob::handleNotifyHeaderReceived):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139422 => 139423)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 10:31:42 UTC (rev 139422)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 11:12:18 UTC (rev 139423)
@@ -1,3 +1,19 @@
+2013-01-11  Mary Wu  mary...@torchmobile.com.cn
+
+[BlackBerry] Enable concatenating headers with same field name
+https://bugs.webkit.org/show_bug.cgi?id=106625
+
+Reviewed by Rob Buis.
+
+RFC 2616 specifies that headers could concatenate with comma if they have
+same field name. We should enable this if the header allows multiple values.
+
+RIM PR# 275508, internally reviewed by Joe Mason
+
+(WebCore):
+(WebCore::isAppendableHeader):
+(WebCore::NetworkJob::handleNotifyHeaderReceived):
+
 2013-01-11  Jochen Eisinger  joc...@chromium.org
 
 Connect UserGestureIndicator for mousedown and mouseup events


Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp (139422 => 139423)

--- trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2013-01-11 10:31:42 UTC (rev 139422)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2013-01-11 11:12:18 UTC (rev 139423)
@@ -63,6 +63,22 @@
 return statusCode == 401;
 }
 
+static char* const appendableHeaders[] = {access-control-allow-origin, allow,
+set-cookie, set-cookie2, vary, via, warning};
+
+static bool isAppendableHeader(const String key)
+{
+// Non-standard header fields are conventionally marked by prefixing the field name with X-.
+if (key.startsWith(x-))
+return true;
+
+for (int i = 0; i  sizeof(appendableHeaders) /sizeof(char*); i++)
+if (key == appendableHeaders[i])
+return true;
+
+return false;
+}
+
 NetworkJob::NetworkJob()
 : FrameDestructionObserver(0)
 , m_playerId(0)
@@ -336,20 +352,17 @@
 m_contentType = value.lower();
 else if (lowerKey == content-disposition)
 m_contentDisposition = value;
-else if (lowerKey == set-cookie) {
-if (m_frame  m_frame-loader()  m_frame-loader()-client()
- static_castFrameLoaderClientBlackBerry*(m_frame-loader()-client())-cookiesEnabled()) {
-handleSetCookieHeader(value);
-// If there are several Set-Cookie headers, we should combine the following ones with the first.
-if (m_response.httpHeaderFields().contains(Set-Cookie)) {
-m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + ,  + value);
-return;
-}
-}
-} else if (equalIgnoringCase(key, BlackBerry::Platform::NetworkRequest::HEADER_BLACKBERRY_FTP))
+else if (lowerKey == set-cookie  m_frame  m_frame-loader()  m_frame-loader()-client()
+ static_castFrameLoaderClientBlackBerry*(m_frame-loader()-client())-cookiesEnabled())
+handleSetCookieHeader(value);
+else if (equalIgnoringCase(key, BlackBerry::Platform::NetworkRequest::HEADER_BLACKBERRY_FTP))
 handleFTPHeader(value);
 
-m_response.setHTTPHeaderField(key, value);
+if (m_response.httpHeaderFields().contains(key.utf8().data())  isAppendableHeader(lowerKey)) {
+// If there are several headers with same key, we should combine the following ones with the first.
+m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + ,  + value);
+} else
+m_response.setHTTPHeaderField(key, value);
 }
 
 void NetworkJob::handleNotifyMultipartHeaderReceived(const String key, const String value)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139424] trunk/Source/WebCore

2013-01-11 Thread tkent

Title: [139424] trunk/Source/WebCore








Revision 139424
Author tk...@chromium.org
Date 2013-01-11 03:24:43 -0800 (Fri, 11 Jan 2013)


Log Message
BaseDateAndTimeInputType should not inherit from TextFieldInputType
https://bugs.webkit.org/show_bug.cgi?id=106306

Reviewed by Hajime Morita.

Date/time input types don't need text-field features at all.

No new tests. This should not make any behavior changes except reduction
of memory usage.

* html/BaseDateAndTimeInputType.h:
Inherit InputType instead of TextFieldInputType.
(WebCore::BaseDateAndTimeInputType::BaseDateAndTimeInputType):
(BaseDateAndTimeInputType): Update function declarations.
* html/BaseDateAndTimeInputType.cpp:
Remove handleKeydownEvent and convertFromVisibleValue, which are for
TextFieldInputType.
(WebCore::BaseDateAndTimeInputType::shouldRespectListAttribute):
Added. This is necessary for datalist support. TextFieldInputType has
the same code.
(WebCore::BaseDateAndTimeInputType::valueMissing):
Added. This is necessary for validity.valueMissing. TextFieldInputType
has the same code.

* html/BaseChooserOnlyDateAndTimeInputType.cpp:
Remove unnecessary functions which cancel TextFieldInputType behavior.
* html/BaseChooserOnlyDateAndTimeInputType.h:
(BaseChooserOnlyDateAndTimeInputType): Remove declarations for them.

* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
Remove unnecessary functions which cancel TextFieldInputType behavior.
* html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
Add SpinButtonOwner interface. We didn't need it because
TextFieldInputType implements it.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp
trunk/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.h
trunk/Source/WebCore/html/BaseDateAndTimeInputType.cpp
trunk/Source/WebCore/html/BaseDateAndTimeInputType.h
trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp
trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139423 => 139424)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 11:12:18 UTC (rev 139423)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 11:24:43 UTC (rev 139424)
@@ -1,3 +1,41 @@
+2013-01-11  Kent Tamura  tk...@chromium.org
+
+BaseDateAndTimeInputType should not inherit from TextFieldInputType
+https://bugs.webkit.org/show_bug.cgi?id=106306
+
+Reviewed by Hajime Morita.
+
+Date/time input types don't need text-field features at all.
+
+No new tests. This should not make any behavior changes except reduction
+of memory usage.
+
+* html/BaseDateAndTimeInputType.h:
+Inherit InputType instead of TextFieldInputType.
+(WebCore::BaseDateAndTimeInputType::BaseDateAndTimeInputType):
+(BaseDateAndTimeInputType): Update function declarations.
+* html/BaseDateAndTimeInputType.cpp:
+Remove handleKeydownEvent and convertFromVisibleValue, which are for
+TextFieldInputType.
+(WebCore::BaseDateAndTimeInputType::shouldRespectListAttribute):
+Added. This is necessary for datalist support. TextFieldInputType has
+the same code.
+(WebCore::BaseDateAndTimeInputType::valueMissing):
+Added. This is necessary for validity.valueMissing. TextFieldInputType
+has the same code.
+
+* html/BaseChooserOnlyDateAndTimeInputType.cpp:
+Remove unnecessary functions which cancel TextFieldInputType behavior.
+* html/BaseChooserOnlyDateAndTimeInputType.h:
+(BaseChooserOnlyDateAndTimeInputType): Remove declarations for them.
+
+* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
+Remove unnecessary functions which cancel TextFieldInputType behavior.
+* html/BaseMultipleFieldsDateAndTimeInputType.h:
+(BaseMultipleFieldsDateAndTimeInputType):
+Add SpinButtonOwner interface. We didn't need it because
+TextFieldInputType implements it.
+
 2013-01-11  Mary Wu  mary...@torchmobile.com.cn
 
 [BlackBerry] Enable concatenating headers with same field name


Modified: trunk/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp (139423 => 139424)

--- trunk/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp	2013-01-11 11:12:18 UTC (rev 139423)
+++ trunk/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp	2013-01-11 11:24:43 UTC (rev 139424)
@@ -59,25 +59,6 @@
 m_dateTimeChooser = chrome-openDateTimeChooser(this, parameters);
 }
 
-RenderObject* BaseChooserOnlyDateAndTimeInputType::createRenderer(RenderArena* arena, RenderStyle* style) const
-{
-// Cancel the override by TextFieldInputType.
-// FIXME: Remove this function when we stop inheriting TextFieldInputType.
-return InputType::createRenderer(arena, style);
-}
-
-void BaseChooserOnlyDateAndTimeInputType::updateInnerTextValue()
-{
-// Cancel the override by TextFieldInputType.
-

[webkit-changes] [139426] trunk/Source/WebCore

2013-01-11 Thread aandrey

Title: [139426] trunk/Source/WebCore








Revision 139426
Author aand...@chromium.org
Date 2013-01-11 03:59:58 -0800 (Fri, 11 Jan 2013)


Log Message
Web Inspector: [Canvas] a minor follow-up to r137262
https://bugs.webkit.org/show_bug.cgi?id=106644

Reviewed by Pavel Feldman.

* inspector/InjectedScriptCanvasModuleSource.js:
(.):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (139425 => 139426)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 11:44:01 UTC (rev 139425)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 11:59:58 UTC (rev 139426)
@@ -1,3 +1,13 @@
+2013-01-11  Andrey Adaikin  aand...@chromium.org
+
+Web Inspector: [Canvas] a minor follow-up to r137262
+https://bugs.webkit.org/show_bug.cgi?id=106644
+
+Reviewed by Pavel Feldman.
+
+* inspector/InjectedScriptCanvasModuleSource.js:
+(.):
+
 2013-01-11  Kent Tamura  tk...@chromium.org
 
 BaseDateAndTimeInputType should not inherit from TextFieldInputType


Modified: trunk/Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js (139425 => 139426)

--- trunk/Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js	2013-01-11 11:44:01 UTC (rev 139425)
+++ trunk/Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js	2013-01-11 11:59:58 UTC (rev 139426)
@@ -745,6 +745,7 @@
 this._id = data.id;
 this._resourceManager = null;
 this._calls = [];
+this._boundResources = Object.create(null);
 this._wrappedObject = null;
 cache.put(data.id, this); // Put into the cache early to avoid loops.
 this._doReplayCalls(data, cache);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139427] trunk/Source/WebCore

2013-01-11 Thread apavlov

Title: [139427] trunk/Source/WebCore








Revision 139427
Author apav...@chromium.org
Date 2013-01-11 04:09:30 -0800 (Fri, 11 Jan 2013)


Log Message
Web Inspector: [Elements] Search in the DOM tree does not scroll horizontally
https://bugs.webkit.org/show_bug.cgi?id=106648

Reviewed by Vsevolod Vlasov.

Scroll into view the first match in every tree element, if needed.

* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ElementsPanel.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (139426 => 139427)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 11:59:58 UTC (rev 139426)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 12:09:30 UTC (rev 139427)
@@ -1,3 +1,15 @@
+2013-01-11  Alexander Pavlov  apav...@chromium.org
+
+Web Inspector: [Elements] Search in the DOM tree does not scroll horizontally
+https://bugs.webkit.org/show_bug.cgi?id=106648
+
+Reviewed by Vsevolod Vlasov.
+
+Scroll into view the first match in every tree element, if needed.
+
+* inspector/front-end/ElementsPanel.js:
+(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult):
+
 2013-01-11  Andrey Adaikin  aand...@chromium.org
 
 Web Inspector: [Canvas] a minor follow-up to r137262


Modified: trunk/Source/WebCore/inspector/front-end/ElementsPanel.js (139426 => 139427)

--- trunk/Source/WebCore/inspector/front-end/ElementsPanel.js	2013-01-11 11:59:58 UTC (rev 139426)
+++ trunk/Source/WebCore/inspector/front-end/ElementsPanel.js	2013-01-11 12:09:30 UTC (rev 139427)
@@ -523,6 +523,9 @@
 if (treeElement) {
 treeElement.highlightSearchResults(this._searchQuery);
 treeElement.reveal();
+var matches = treeElement.listItemElement.getElementsByClassName(webkit-search-result);
+if (matches.length)
+matches[0].scrollIntoViewIfNeeded();
 }
 },
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139428] trunk/Source/WebKit2

2013-01-11 Thread carlosgc

Title: [139428] trunk/Source/WebKit2








Revision 139428
Author carlo...@webkit.org
Date 2013-01-11 04:26:37 -0800 (Fri, 11 Jan 2013)


Log Message
[GTK] Remove support for global extensions in WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=106646

Reviewed by Xan Lopez.

We have now API to set the web extensions directory. A global web
estensions directory doesn't make sense anymore.

* WebProcess/gtk/WebGtkExtensionManager.cpp:
(WebKit::WebGtkExtensionManager::scanModules): Only scan the given
directory for modules.
(WebKit::WebGtkExtensionManager::initialize): Load modules found
in the given directory only.
* WebProcess/gtk/WebGtkExtensionManager.h:
(WebGtkExtensionManager): Remove appendModuleDirectories().

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/gtk/WebGtkExtensionManager.cpp
trunk/Source/WebKit2/WebProcess/gtk/WebGtkExtensionManager.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139427 => 139428)

--- trunk/Source/WebKit2/ChangeLog	2013-01-11 12:09:30 UTC (rev 139427)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-11 12:26:37 UTC (rev 139428)
@@ -1,3 +1,21 @@
+2013-01-11  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Remove support for global extensions in WebKit2 GTK+
+https://bugs.webkit.org/show_bug.cgi?id=106646
+
+Reviewed by Xan Lopez.
+
+We have now API to set the web extensions directory. A global web
+estensions directory doesn't make sense anymore.
+
+* WebProcess/gtk/WebGtkExtensionManager.cpp:
+(WebKit::WebGtkExtensionManager::scanModules): Only scan the given
+directory for modules.
+(WebKit::WebGtkExtensionManager::initialize): Load modules found
+in the given directory only.
+* WebProcess/gtk/WebGtkExtensionManager.h:
+(WebGtkExtensionManager): Remove appendModuleDirectories().
+
 2013-01-11  KwangYong Choi  ky0.c...@samsung.com
 
 [EFL][WK2] Add ewk_view_page_contents_get() API


Modified: trunk/Source/WebKit2/WebProcess/gtk/WebGtkExtensionManager.cpp (139427 => 139428)

--- trunk/Source/WebKit2/WebProcess/gtk/WebGtkExtensionManager.cpp	2013-01-11 12:09:30 UTC (rev 139427)
+++ trunk/Source/WebKit2/WebProcess/gtk/WebGtkExtensionManager.cpp	2013-01-11 12:26:37 UTC (rev 139428)
@@ -38,47 +38,31 @@
 {
 }
 
-void WebGtkExtensionManager::appendModuleDirectories(VectorString directories)
+void WebGtkExtensionManager::scanModules(const String webExtensionsDirectory, VectorString modules)
 {
-String extensionPaths(getenv(WEBKIT_WEB_EXTENSIONS_PATH));
-if (!extensionPaths.isEmpty()) {
-VectorString paths;
-extensionPaths.split(UChar(':'), /* allowEmptyEntries */ false, paths);
-directories.append(paths);
+VectorString modulePaths = WebCore::listDirectory(webExtensionsDirectory, String(*.so));
+for (size_t i = 0; i  modulePaths.size(); ++i) {
+if (WebCore::fileExists(modulePaths[i]))
+modules.append(modulePaths[i]);
 }
-
-static const char* extensionDefaultDirectory = LIBDIRG_DIR_SEPARATOR_Swebkitgtk-WEBKITGTK_API_VERSION_STRINGG_DIR_SEPARATOR_Sweb-extensionsG_DIR_SEPARATOR_S;
-directories.append(WebCore::filenameToString(extensionDefaultDirectory));
 }
 
-void WebGtkExtensionManager::scanModules(const String additionalWebExtensionsDirectory, VectorString modules)
-{
-VectorString moduleDirectories;
-if (!additionalWebExtensionsDirectory.isNull())
-moduleDirectories.append(additionalWebExtensionsDirectory);
-appendModuleDirectories(moduleDirectories);
-
-for (size_t i = 0; i  moduleDirectories.size(); ++i) {
-VectorString modulePaths = WebCore::listDirectory(moduleDirectories[i], String(*.so));
-for (size_t j = 0; j  modulePaths.size(); ++j) {
-if (WebCore::fileExists(modulePaths[j]))
-modules.append(modulePaths[j]);
-}
-}
-}
-
 void WebGtkExtensionManager::initialize(WKBundleRef bundle, WKTypeRef userData)
 {
 m_extension = adoptGRef(webkitWebExtensionCreate(toImpl(bundle)));
 
-String additionalWebExtensionsDirectory;
+String webExtensionsDirectory;
 if (userData) {
 ASSERT(WKGetTypeID(userData) == WKStringGetTypeID());
-additionalWebExtensionsDirectory = toImpl(static_castWKStringRef(userData))-string();
+webExtensionsDirectory = toImpl(static_castWKStringRef(userData))-string();
 }
 
+if (webExtensionsDirectory.isNull())
+return;
+
 VectorString modulePaths;
-scanModules(additionalWebExtensionsDirectory, modulePaths);
+scanModules(webExtensionsDirectory, modulePaths);
+
 for (size_t i = 0; i  modulePaths.size(); ++i) {
 OwnPtrModule module = adoptPtr(new Module(modulePaths[i]));
 if (!module-load())
@@ -89,7 +73,6 @@
 if (!initializeFunction)
 continue;
 
-// FIXME: check we don't load the same module twice from different paths.

[webkit-changes] [139429] trunk

2013-01-11 Thread commit-queue

Title: [139429] trunk








Revision 139429
Author commit-qu...@webkit.org
Date 2013-01-11 04:28:24 -0800 (Fri, 11 Jan 2013)


Log Message
Web Inspector: Option+Click on Node Expander Doesn't Work the First Time
https://bugs.webkit.org/show_bug.cgi?id=66868

Source/WebCore:

Up to now, the TreeElement.prototype.expandRecursively() method would correctly
expand children recursively based on the provided depth, but would not wait to
perform this task until all child nodes had been populated, which means that this
would only work incrementally with one additional level of child nodes being shown
expanded in the DOM tree upon alt+clicking a given node with a deep hierarchy.

In order to fix this, this patch adds a new optional argument to the DOMAgent's
requestChildNodes() methods to provide the depth at which we want to retrieve children
of a given node. The DOMAgent provides a new .getSubtree() method that calls
requestChildNodes() with the provided depth.

Then in ElementsTreeOutline, we subclass .expandRecursively() to first call DOMAgent's
new .getSubtree() method and then call the default implementation when all nodes
have been retrieved from the backend.

Patch by Antoine Quint grao...@apple.com on 2013-01-11
Reviewed by Pavel Feldman.

Tests: inspector-protocol/dom-request-child-nodes-depth.html
   inspector/elements/expand-recursively.html

* inspector/Inspector.json: Add the new `depth` parameter to DOM.requestChildNodes().
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend): Add a new optional `depth` parameter
which defaults to 1.
(WebCore::InspectorDOMAgent::requestChildNodes): Add a new optional `depth` parameter
which defaults to 1 and allows -1 as an unbound value.
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.):
(WebInspector.DOMNode.prototype.getSubtree): New method allowing to specify at what depth
we want to retrieve children of a given node from the backend.
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.expandRecursively): Override default implementation
to first obtain the deepest subtree for the current node so that deep expansion happens as expected.

LayoutTests:

Adding a new protocol test that covers the new `depth` parameter for the
requestChildNodes method and a new front-end method that tests correct
behavior of the expandRecursively() method.

Patch by Antoine Quint grao...@apple.com on 2013-01-11
Reviewed by Pavel Feldman.

* inspector-protocol/dom-request-child-nodes-depth-expected.txt: Added.
* inspector-protocol/dom-request-child-nodes-depth.html: Added.
* inspector/elements/expand-recursively-expected.txt: Added.
* inspector/elements/expand-recursively.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp
trunk/Source/WebCore/inspector/InspectorDOMAgent.h
trunk/Source/WebCore/inspector/front-end/DOMAgent.js
trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js


Added Paths

trunk/LayoutTests/inspector/elements/expand-recursively-expected.txt
trunk/LayoutTests/inspector/elements/expand-recursively.html
trunk/LayoutTests/inspector-protocol/dom-request-child-nodes-depth-expected.txt
trunk/LayoutTests/inspector-protocol/dom-request-child-nodes-depth.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139428 => 139429)

--- trunk/LayoutTests/ChangeLog	2013-01-11 12:26:37 UTC (rev 139428)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 12:28:24 UTC (rev 139429)
@@ -1,3 +1,19 @@
+2013-01-11  Antoine Quint  grao...@apple.com
+
+Web Inspector: Option+Click on Node Expander Doesn't Work the First Time
+https://bugs.webkit.org/show_bug.cgi?id=66868
+
+Adding a new protocol test that covers the new `depth` parameter for the
+requestChildNodes method and a new front-end method that tests correct
+behavior of the expandRecursively() method.
+
+Reviewed by Pavel Feldman.
+
+* inspector-protocol/dom-request-child-nodes-depth-expected.txt: Added.
+* inspector-protocol/dom-request-child-nodes-depth.html: Added.
+* inspector/elements/expand-recursively-expected.txt: Added.
+* inspector/elements/expand-recursively.html: Added.
+
 2013-01-11  Noel Gordon  noel.gor...@gmail.com
 
 [chromium] Add ImageOnlyFailure for fast/css/font-face-unicode-range.html on win


Added: trunk/LayoutTests/inspector/elements/expand-recursively-expected.txt (0 => 139429)

--- trunk/LayoutTests/inspector/elements/expand-recursively-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/elements/expand-recursively-expected.txt	2013-01-11 12:28:24 UTC (rev 139429)
@@ -0,0 +1,28 @@
+Tests that expanding elements recursively works.
+
+= Initial state of tree outline =
+
++ div id=depth-1…/div
+
+=

[webkit-changes] [139430] trunk/Source/WebCore

2013-01-11 Thread zandobersek

Title: [139430] trunk/Source/WebCore








Revision 139430
Author zandober...@gmail.com
Date 2013-01-11 04:43:46 -0800 (Fri, 11 Jan 2013)


Log Message
[GTK] Disable the ENABLE_LEGACY_WEB_AUDIO feature define in release builds
https://bugs.webkit.org/show_bug.cgi?id=106577

Reviewed by Philippe Normand.

The Web Audio feature is not enabled in the release builds, so there's
no need to enable the legacy Web Audio API either.

No new tests - no new functionality.

* GNUmakefile.features.am.in:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.features.am.in




Diff

Modified: trunk/Source/WebCore/ChangeLog (139429 => 139430)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 12:28:24 UTC (rev 139429)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 12:43:46 UTC (rev 139430)
@@ -1,3 +1,17 @@
+2013-01-11  Zan Dobersek  zandober...@gmail.com
+
+[GTK] Disable the ENABLE_LEGACY_WEB_AUDIO feature define in release builds
+https://bugs.webkit.org/show_bug.cgi?id=106577
+
+Reviewed by Philippe Normand.
+
+The Web Audio feature is not enabled in the release builds, so there's
+no need to enable the legacy Web Audio API either.
+
+No new tests - no new functionality.
+
+* GNUmakefile.features.am.in:
+
 2013-01-11  Antoine Quint  grao...@apple.com
 
 Web Inspector: Option+Click on Node Expander Doesn't Work the First Time


Modified: trunk/Source/WebCore/GNUmakefile.features.am.in (139429 => 139430)

--- trunk/Source/WebCore/GNUmakefile.features.am.in	2013-01-11 12:28:24 UTC (rev 139429)
+++ trunk/Source/WebCore/GNUmakefile.features.am.in	2013-01-11 12:43:46 UTC (rev 139430)
@@ -52,7 +52,7 @@
 	ENABLE_LEGACY_CSS_VENDOR_PREFIXES=0 \
 	ENABLE_LEGACY_NOTIFICATIONS=0 \
 	ENABLE_LEGACY_VENDOR_PREFIXES=1 \
-	ENABLE_LEGACY_WEB_AUDIO=1 \
+	ENABLE_LEGACY_WEB_AUDIO=0 \
 	ENABLE_LINK_PREFETCH=0 \
 	ENABLE_LINK_PRERENDER=0 \
 	ENABLE_MATHML=1 \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139431] trunk/Tools

2013-01-11 Thread commit-queue

Title: [139431] trunk/Tools








Revision 139431
Author commit-qu...@webkit.org
Date 2013-01-11 04:50:53 -0800 (Fri, 11 Jan 2013)


Log Message
[jhbuild] Remove the run-with-jhbuild scripts.
https://bugs.webkit.org/show_bug.cgi?id=106572

Patch by Raphael Kubo da Costa raphael.kubo.da.co...@intel.com on 2013-01-11
Reviewed by Martin Robinson.

Both ports which use jhbuild were mostly duplicating the
`run-with-jhbuild' script in their own directories for no clear reason.

The script itself was just a thin wrapper around the `jhbuild-wrapper',
so just start using that directly and get rid of a useless middle man.

Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
instead.

* Scripts/run-_javascript_core-tests:
* Scripts/run-launcher:
* Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary):
(buildAutotoolsProject):
(jhbuildWrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):
(buildCMakeGeneratedProject):
* Scripts/webkitpy/common/multiprocessing_bootstrap.py:
(run):
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.__init__):
(EflPort._image_diff_command):
* efl/run-with-jhbuild: Removed.
* gtk/run-with-jhbuild: Removed.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests
trunk/Tools/Scripts/run-launcher
trunk/Tools/Scripts/webkitdirs.pm
trunk/Tools/Scripts/webkitpy/common/multiprocessing_bootstrap.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py


Removed Paths

trunk/Tools/efl/run-with-jhbuild
trunk/Tools/gtk/run-with-jhbuild




Diff

Modified: trunk/Tools/ChangeLog (139430 => 139431)

--- trunk/Tools/ChangeLog	2013-01-11 12:43:46 UTC (rev 139430)
+++ trunk/Tools/ChangeLog	2013-01-11 12:50:53 UTC (rev 139431)
@@ -1,3 +1,35 @@
+2013-01-11  Raphael Kubo da Costa  raphael.kubo.da.co...@intel.com
+
+[jhbuild] Remove the run-with-jhbuild scripts.
+https://bugs.webkit.org/show_bug.cgi?id=106572
+
+Reviewed by Martin Robinson.
+
+Both ports which use jhbuild were mostly duplicating the
+`run-with-jhbuild' script in their own directories for no clear reason.
+
+The script itself was just a thin wrapper around the `jhbuild-wrapper',
+so just start using that directly and get rid of a useless middle man.
+
+Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
+instead.
+
+* Scripts/run-_javascript_core-tests:
+* Scripts/run-launcher:
+* Scripts/webkitdirs.pm:
+(runAutogenForAutotoolsProjectIfNecessary):
+(buildAutotoolsProject):
+(jhbuildWrapperPrefixIfNeeded):
+(generateBuildSystemFromCMakeProject):
+(buildCMakeGeneratedProject):
+* Scripts/webkitpy/common/multiprocessing_bootstrap.py:
+(run):
+* Scripts/webkitpy/layout_tests/port/efl.py:
+(EflPort.__init__):
+(EflPort._image_diff_command):
+* efl/run-with-jhbuild: Removed.
+* gtk/run-with-jhbuild: Removed.
+
 2013-01-11  Alan Cutter  alancut...@chromium.org
 
 Allow arbitrary queue launch parameters in EWSTools/start-queue.sh


Modified: trunk/Tools/Scripts/run-_javascript_core-tests (139430 => 139431)

--- trunk/Tools/Scripts/run-_javascript_core-tests	2013-01-11 12:43:46 UTC (rev 139430)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2013-01-11 12:50:53 UTC (rev 139431)
@@ -140,10 +140,14 @@
 printf Running: jsDriver.pl -e squirrelfish -s %s -f actual.html %s\n, jscPath($productDir), join( , @jsArgs);
 my @jsDriverCmd = (perl, jsDriver.pl, -e, squirrelfish, -s, jscPath($productDir), -f, actual.html, @jsArgs);
 if (isGtk() || isEfl()) {
-my $jhbuildPrefix = sourceDir() . /Tools/;
-$jhbuildPrefix .= isEfl() ? efl : ;
-$jhbuildPrefix .= isGtk() ? gtk : ;
-$jhbuildPrefix .= /run-with-jhbuild;
+my @jhbuildPrefix = sourceDir() . /Tools/jhbuild/jhbuild-wrapper;
+
+if (isEfl())
+push(@jhbuildPrefix, '--efl');
+elsif (isGtk())
+push(@jhbuildPrefix, '--gtk');
+push(@jhbuildPrefix, 'run');
+
 unshift(@jsDriverCmd, $jhbuildPrefix);
 }
 my $result = system(@jsDriverCmd);


Modified: trunk/Tools/Scripts/run-launcher (139430 => 139431)

--- trunk/Tools/Scripts/run-launcher	2013-01-11 12:43:46 UTC (rev 139430)
+++ trunk/Tools/Scripts/run-launcher	2013-01-11 12:50:53 UTC (rev 139431)
@@ -69,7 +69,9 @@
 } else {
 unshift(@ARGV, catdir($launcherPath, Programs, GtkLauncher));
 }
-$launcherPath = catdir(sourceDir(), Tools, gtk, run-with-jhbuild);
+$launcherPath = catdir(sourceDir(), Tools, jhbuild, jhbuild-wrapper);
+unshift(@ARGV, '--gtk');
+unshift(@ARGV, 'run');
 }
 
 if (isEfl()) {
@@ -78,7 +80,9 @@
 } else {
 unshift(@ARGV, catdir($launcherPath, bin, EWebLauncher));
 }
-$launcherPath = catdir(sourceDir(), Tools, efl, run-with-jhbuild);
+$launcherPath = catdir(sourceDir(), Tools, jhbuild, jhbuild-wrapper);
+

[webkit-changes] [139432] trunk/Source/WebCore

2013-01-11 Thread akling

Title: [139432] trunk/Source/WebCore








Revision 139432
Author akl...@apple.com
Date 2013-01-11 04:58:53 -0800 (Fri, 11 Jan 2013)


Log Message
Remove unused CSSSelector(QualifiedName) constructor.
http://webkit.org/b/106652

Reviewed by Antti Koivisto.

* css/CSSSelector.h:
(CSSSelector):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSSelector.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139431 => 139432)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 12:50:53 UTC (rev 139431)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 12:58:53 UTC (rev 139432)
@@ -1,3 +1,13 @@
+2013-01-11  Andreas Kling  akl...@apple.com
+
+Remove unused CSSSelector(QualifiedName) constructor.
+http://webkit.org/b/106652
+
+Reviewed by Antti Koivisto.
+
+* css/CSSSelector.h:
+(CSSSelector):
+
 2013-01-11  Zan Dobersek  zandober...@gmail.com
 
 [GTK] Disable the ENABLE_LEGACY_WEB_AUDIO feature define in release builds


Modified: trunk/Source/WebCore/css/CSSSelector.h (139431 => 139432)

--- trunk/Source/WebCore/css/CSSSelector.h	2013-01-11 12:50:53 UTC (rev 139431)
+++ trunk/Source/WebCore/css/CSSSelector.h	2013-01-11 12:58:53 UTC (rev 139432)
@@ -36,7 +36,6 @@
 WTF_MAKE_FAST_ALLOCATED;
 public:
 CSSSelector();
-CSSSelector(const QualifiedName);
 CSSSelector(const CSSSelector);
 
 ~CSSSelector();
@@ -372,19 +371,6 @@
 {
 }
 
-inline CSSSelector::CSSSelector(const QualifiedName qName)
-: m_relation(Descendant)
-, m_match(None)
-, m_pseudoType(PseudoNotParsed)
-, m_parsedNth(false)
-, m_isLastInSelectorList(false)
-, m_isLastInTagHistory(true)
-, m_hasRareData(false)
-, m_isForPage(false)
-, m_tag(qName)
-{
-}
-
 inline CSSSelector::CSSSelector(const CSSSelector o)
 : m_relation(o.m_relation)
 , m_match(o.m_match)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139433] trunk/Tools

2013-01-11 Thread ossy

Title: [139433] trunk/Tools








Revision 139433
Author o...@webkit.org
Date 2013-01-11 05:18:43 -0800 (Fri, 11 Jan 2013)


Log Message
Unreviewed typo fixes after r139431.

* Scripts/run-_javascript_core-tests:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests




Diff

Modified: trunk/Tools/ChangeLog (139432 => 139433)

--- trunk/Tools/ChangeLog	2013-01-11 12:58:53 UTC (rev 139432)
+++ trunk/Tools/ChangeLog	2013-01-11 13:18:43 UTC (rev 139433)
@@ -1,3 +1,9 @@
+2013-01-11  Csaba Osztrogonác  o...@webkit.org
+
+Unreviewed typo fixes after r139431.
+
+* Scripts/run-_javascript_core-tests:
+
 2013-01-11  Raphael Kubo da Costa  raphael.kubo.da.co...@intel.com
 
 [jhbuild] Remove the run-with-jhbuild scripts.


Modified: trunk/Tools/Scripts/run-_javascript_core-tests (139432 => 139433)

--- trunk/Tools/Scripts/run-_javascript_core-tests	2013-01-11 12:58:53 UTC (rev 139432)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2013-01-11 13:18:43 UTC (rev 139433)
@@ -142,13 +142,14 @@
 if (isGtk() || isEfl()) {
 my @jhbuildPrefix = sourceDir() . /Tools/jhbuild/jhbuild-wrapper;
 
-if (isEfl())
+if (isEfl()) {
 push(@jhbuildPrefix, '--efl');
-elsif (isGtk())
+} elsif (isGtk()) {
 push(@jhbuildPrefix, '--gtk');
+}
 push(@jhbuildPrefix, 'run');
 
-unshift(@jsDriverCmd, $jhbuildPrefix);
+unshift(@jsDriverCmd, @jhbuildPrefix);
 }
 my $result = system(@jsDriverCmd);
 exit exitStatus($result)  if $result;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139434] trunk/Tools

2013-01-11 Thread rakuco

Title: [139434] trunk/Tools








Revision 139434
Author rak...@webkit.org
Date 2013-01-11 05:28:32 -0800 (Fri, 11 Jan 2013)


Log Message
Unreviewed jhbuild-related fix after r139431.

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.__init__): Pass a string to set_option_default(), since
shlex.split() will be called on it later.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py




Diff

Modified: trunk/Tools/ChangeLog (139433 => 139434)

--- trunk/Tools/ChangeLog	2013-01-11 13:18:43 UTC (rev 139433)
+++ trunk/Tools/ChangeLog	2013-01-11 13:28:32 UTC (rev 139434)
@@ -1,3 +1,11 @@
+2013-01-11  Raphael Kubo da Costa  raphael.kubo.da.co...@intel.com
+
+Unreviewed jhbuild-related fix after r139431.
+
+* Scripts/webkitpy/layout_tests/port/efl.py:
+(EflPort.__init__): Pass a string to set_option_default(), since
+shlex.split() will be called on it later.
+
 2013-01-11  Csaba Osztrogonác  o...@webkit.org
 
 Unreviewed typo fixes after r139431.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py (139433 => 139434)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py	2013-01-11 13:18:43 UTC (rev 139433)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py	2013-01-11 13:28:32 UTC (rev 139434)
@@ -43,7 +43,7 @@
 
 self._jhbuild_wrapper_path = [self.path_from_webkit_base('Tools', 'jhbuild', 'jhbuild-wrapper'), '--efl', 'run']
 
-self.set_option_default('wrapper', self._jhbuild_wrapper_path)
+self.set_option_default('wrapper', ' '.join(self._jhbuild_wrapper_path))
 self.webprocess_cmd_prefix = self.get_option('webprocess_cmd_prefix')
 
 self._pulseaudio_sanitizer = PulseAudioSanitizer()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139435] trunk

2013-01-11 Thread commit-queue

Title: [139435] trunk








Revision 139435
Author commit-qu...@webkit.org
Date 2013-01-11 05:56:37 -0800 (Fri, 11 Jan 2013)


Log Message
Text Autosizing - elements much narrower than its parent autosizing clusters should be autosized separately.
https://bugs.webkit.org/show_bug.cgi?id=105188

Patch by Anton Vayvod avay...@chromium.org on 2013-01-11
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Some blocks of text might be narrower than their parent clusters and should be autosized separately.
This helps with autosizing for the pages implementing the sidebars as a narrow blocks of text with wide margins and
the main content being positioned atop this margin (or vice versa).

* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::isContainerAutosizingCluster):

Returns true if the container is more than 200 pixels narrower than its parent cluster's lowest common
ancestor of all the text nodes.

LayoutTests:

Checked that a narrow autosizing container becomes an autosizing cluster.
Fixed other tests that used narrow descendant blocks.

* fast/text-autosizing/cluster-narrow-in-wide-expected.html:
* fast/text-autosizing/cluster-narrow-in-wide-ohidden-expected.html:
* fast/text-autosizing/cluster-narrow-in-wide-ohidden.html:
* fast/text-autosizing/cluster-narrow-in-wide.html:
* fast/text-autosizing/cluster-with-wide-lca-expected.html:
* fast/text-autosizing/cluster-with-wide-lca.html:
* fast/text-autosizing/narrow-child-expected.html:
* fast/text-autosizing/narrow-child.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/text-autosizing/cluster-narrow-in-wide-expected.html
trunk/LayoutTests/fast/text-autosizing/cluster-narrow-in-wide-ohidden-expected.html
trunk/LayoutTests/fast/text-autosizing/cluster-narrow-in-wide-ohidden.html
trunk/LayoutTests/fast/text-autosizing/cluster-narrow-in-wide.html
trunk/LayoutTests/fast/text-autosizing/cluster-with-wide-lca-expected.html
trunk/LayoutTests/fast/text-autosizing/cluster-with-wide-lca.html
trunk/LayoutTests/fast/text-autosizing/narrow-child-expected.html
trunk/LayoutTests/fast/text-autosizing/narrow-child.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/TextAutosizer.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (139434 => 139435)

--- trunk/LayoutTests/ChangeLog	2013-01-11 13:28:32 UTC (rev 139434)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 13:56:37 UTC (rev 139435)
@@ -1,3 +1,22 @@
+2013-01-11  Anton Vayvod  avay...@chromium.org
+
+Text Autosizing - elements much narrower than its parent autosizing clusters should be autosized separately.
+https://bugs.webkit.org/show_bug.cgi?id=105188
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Checked that a narrow autosizing container becomes an autosizing cluster.
+Fixed other tests that used narrow descendant blocks.
+
+* fast/text-autosizing/cluster-narrow-in-wide-expected.html:
+* fast/text-autosizing/cluster-narrow-in-wide-ohidden-expected.html:
+* fast/text-autosizing/cluster-narrow-in-wide-ohidden.html:
+* fast/text-autosizing/cluster-narrow-in-wide.html:
+* fast/text-autosizing/cluster-with-wide-lca-expected.html:
+* fast/text-autosizing/cluster-with-wide-lca.html:
+* fast/text-autosizing/narrow-child-expected.html:
+* fast/text-autosizing/narrow-child.html:
+
 2013-01-11  Antoine Quint  grao...@apple.com
 
 Web Inspector: Option+Click on Node Expander Doesn't Work the First Time


Modified: trunk/LayoutTests/fast/text-autosizing/cluster-narrow-in-wide-expected.html (139434 => 139435)

--- trunk/LayoutTests/fast/text-autosizing/cluster-narrow-in-wide-expected.html	2013-01-11 13:28:32 UTC (rev 139434)
+++ trunk/LayoutTests/fast/text-autosizing/cluster-narrow-in-wide-expected.html	2013-01-11 13:56:37 UTC (rev 139435)
@@ -11,14 +11,20 @@
 /head
 body
 
-div style=width: 400px; float: left; font-size: 1.25rem
-This text should be autosized to just 20px computed font size (16 * 400/320), since the float:left causes this to be a new cluster, and it is only 400px wide.
+div style=width: 600px; float: left; font-size: 1.875rem
+This text should be autosized to just 30px computed font size (16 * 600/320), since the float:left causes this to be a new cluster, and it is only 600px wide.
 /div
 
-div style=width: 320px; font-size: 2.5rem
-This text should be autosized to 40px computed font-size (16 * 800/320), since despite its width:320px it is part of the 800px wide root cluster.
+div style=width: 320px
+This text should not be autosized, since because of its width:320px it becomes a separate cluster.br
+Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.
 /div
 
+div style=width: 600px; font-size: 2.5rem
+This text should be autosized to 40px

[webkit-changes] [139436] trunk/Source/WebKit2

2013-01-11 Thread zandobersek

Title: [139436] trunk/Source/WebKit2








Revision 139436
Author zandober...@gmail.com
Date 2013-01-11 06:34:06 -0800 (Fri, 11 Jan 2013)


Log Message
Unreviewed. Build fix for the GTK debug builds of WebKit2 after r139415.

* WebProcess/gtk/WebGtkExtensionManager.cpp:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/gtk/WebGtkExtensionManager.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139435 => 139436)

--- trunk/Source/WebKit2/ChangeLog	2013-01-11 13:56:37 UTC (rev 139435)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-11 14:34:06 UTC (rev 139436)
@@ -1,3 +1,9 @@
+2013-01-11  Zan Dobersek  zandober...@gmail.com
+
+Unreviewed. Build fix for the GTK debug builds of WebKit2 after r139415.
+
+* WebProcess/gtk/WebGtkExtensionManager.cpp:
+
 2013-01-11  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Remove support for global extensions in WebKit2 GTK+


Modified: trunk/Source/WebKit2/WebProcess/gtk/WebGtkExtensionManager.cpp (139435 => 139436)

--- trunk/Source/WebKit2/WebProcess/gtk/WebGtkExtensionManager.cpp	2013-01-11 13:56:37 UTC (rev 139435)
+++ trunk/Source/WebKit2/WebProcess/gtk/WebGtkExtensionManager.cpp	2013-01-11 14:34:06 UTC (rev 139436)
@@ -22,6 +22,8 @@
 
 #include InjectedBundle.h
 #include WKBundleAPICast.h
+#include WKString.h
+#include WKType.h
 #include WebKitWebExtensionPrivate.h
 #include WebCore/FileSystem.h
 #include wtf/OwnPtr.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139437] trunk

2013-01-11 Thread allan . jensen

Title: [139437] trunk








Revision 139437
Author allan.jen...@digia.com
Date 2013-01-11 06:37:29 -0800 (Fri, 11 Jan 2013)


Log Message
[Qt][WK1] Web Audio support
https://bugs.webkit.org/show_bug.cgi?id=106651

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Convert _javascript_ Uint8Array to QByteArray. This conversion is necessary to support testRunner.setAudioData().

* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::isJSUint8Array):
(Bindings):
(JSC::Bindings::valueRealType):
(JSC::Bindings::convertValueToQVariant):

Source/WebKit/qt:

Expose setting to enable WebAudio at runtime.

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):
* Api/qwebsettings.h:

Tools:

Implements support for dumping audio data in DumpRenderTree.

Adds WebAudio to toggleable features in QtTestBrowser.

Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::dump):
* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::reset):
(TestRunner::overridePreference):
(TestRunner::setAudioData):
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner::shouldDumpAsAudio):
(TestRunner::audioData):
(TestRunner):
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::applyPrefs):
(LauncherWindow::createChrome):
(LauncherWindow::toggleWebAudio):
* QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
(WindowOptions):
(LauncherWindow):
* qmake/mkspecs/features/features.prf:
* qmake/mkspecs/features/features.pri:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bridge/qt/qt_runtime.cpp
trunk/Source/WebKit/qt/Api/qwebsettings.cpp
trunk/Source/WebKit/qt/Api/qwebsettings.h
trunk/Source/WebKit/qt/ChangeLog
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp
trunk/Tools/DumpRenderTree/qt/TestRunnerQt.cpp
trunk/Tools/DumpRenderTree/qt/TestRunnerQt.h
trunk/Tools/QtTestBrowser/launcherwindow.cpp
trunk/Tools/QtTestBrowser/launcherwindow.h
trunk/Tools/qmake/mkspecs/features/features.prf
trunk/Tools/qmake/mkspecs/features/features.pri




Diff

Modified: trunk/Source/WebCore/ChangeLog (139436 => 139437)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 14:34:06 UTC (rev 139436)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 14:37:29 UTC (rev 139437)
@@ -1,3 +1,18 @@
+2013-01-11  Allan Sandfeld Jensen  allan.jen...@digia.com
+
+[Qt][WK1] Web Audio support
+https://bugs.webkit.org/show_bug.cgi?id=106651
+
+Reviewed by Jocelyn Turcotte.
+
+Convert _javascript_ Uint8Array to QByteArray. This conversion is necessary to support testRunner.setAudioData().
+
+* bridge/qt/qt_runtime.cpp:
+(JSC::Bindings::isJSUint8Array):
+(Bindings):
+(JSC::Bindings::valueRealType):
+(JSC::Bindings::convertValueToQVariant):
+
 2013-01-11  Anton Vayvod  avay...@chromium.org
 
 Text Autosizing - elements much narrower than its parent autosizing clusters should be autosized separately.


Modified: trunk/Source/WebCore/bridge/qt/qt_runtime.cpp (139436 => 139437)

--- trunk/Source/WebCore/bridge/qt/qt_runtime.cpp	2013-01-11 14:34:06 UTC (rev 139436)
+++ trunk/Source/WebCore/bridge/qt/qt_runtime.cpp	2013-01-11 14:37:29 UTC (rev 139437)
@@ -103,7 +103,7 @@
 QObj,
 Object,
 Null,
-RTUint8ClampedArray
+RTUint8Array
 } JSRealType;
 
 #if defined(QTWK_RUNTIME_CONVERSION_DEBUG) || defined(QTWK_RUNTIME_MATCH_DEBUG)
@@ -145,9 +145,9 @@
 customRuntimeConversions()-insert(qtMetaTypeId, conversion);
 }
 
-static bool isJSUint8ClampedArray(JSObjectRef object)
+static bool isJSUint8Array(JSObjectRef object)
 {
-return toJS(object)-inherits(JSUint8ClampedArray::s_info);
+return toJS(object)-inherits(JSUint8Array::s_info);
 }
 
 static bool isJSArray(JSObjectRef object)
@@ -180,8 +180,8 @@
 
 JSObjectRef object = JSValueToObject(context, value, exception);
 
-if (isJSUint8ClampedArray(object))
-return RTUint8ClampedArray;
+if (isJSUint8Array(object))
+return RTUint8Array;
 if (isJSArray(object))
 return Array;
 if (isJSDate(object))
@@ -356,7 +356,7 @@
 case QObj:
 hint = QMetaType::QObjectStar;
 break;
-case RTUint8ClampedArray:
+case RTUint8Array:
 hint = QMetaType::QByteArray;
 break;
 case Array:
@@ -490,8 +490,8 @@
 }
 
 case QMetaType::QByteArray: {
-if (type == RTUint8ClampedArray) {
-WTF::Uint8ClampedArray* arr = toUint8ClampedArray(toJS(toJS(context), value));
+if (type == RTUint8Array) {
+WTF::Uint8Array* arr = toUint8Array(toJS(toJS(context), value));
 ret = QVariant(QByteArray(reinterpret_castconst char*(arr-data()),

[webkit-changes] [139438] trunk/Tools

2013-01-11 Thread rakuco

Title: [139438] trunk/Tools








Revision 139438
Author rak...@webkit.org
Date 2013-01-11 06:40:51 -0800 (Fri, 11 Jan 2013)


Log Message
Another unreviewed fix after r139431.

In a way, this is also a generic bug fix, since previously isEfl()
would fail when called from run-efl-tests and we thus did not use
jhbuild to run our tests. This now resulted in us calling
jhbuild-wrapper run without specifying a platform.

* Scripts/run-efl-tests: Pass --efl to ARGV manually for isEfl()
to work.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-efl-tests




Diff

Modified: trunk/Tools/ChangeLog (139437 => 139438)

--- trunk/Tools/ChangeLog	2013-01-11 14:37:29 UTC (rev 139437)
+++ trunk/Tools/ChangeLog	2013-01-11 14:40:51 UTC (rev 139438)
@@ -1,3 +1,15 @@
+2013-01-11  Raphael Kubo da Costa  raphael.kubo.da.co...@intel.com
+
+Another unreviewed fix after r139431.
+
+In a way, this is also a generic bug fix, since previously isEfl()
+would fail when called from run-efl-tests and we thus did not use
+jhbuild to run our tests. This now resulted in us calling
+jhbuild-wrapper run without specifying a platform.
+
+* Scripts/run-efl-tests: Pass --efl to ARGV manually for isEfl()
+to work.
+
 2013-01-11  Allan Sandfeld Jensen  allan.jen...@digia.com
 
 [Qt][WK1] Web Audio support


Modified: trunk/Tools/Scripts/run-efl-tests (139437 => 139438)

--- trunk/Tools/Scripts/run-efl-tests	2013-01-11 14:37:29 UTC (rev 139437)
+++ trunk/Tools/Scripts/run-efl-tests	2013-01-11 14:40:51 UTC (rev 139438)
@@ -48,6 +48,9 @@
 } else {
 setConfiguration();
 
+# Manually add this for jhbuildWrapperPrefixIfNeeded().
+push(@ARGV, --efl);
+
 my $returnCode = exitStatus(generateBuildSystemFromCMakeProject(Efl, undef, cmakeBasedPortArguments()));
 exit($returnCode) if $returnCode;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139440] branches/chromium/1364

2013-01-11 Thread dominicc

Title: [139440] branches/chromium/1364








Revision 139440
Author domin...@chromium.org
Date 2013-01-11 07:03:22 -0800 (Fri, 11 Jan 2013)


Log Message
Merge 139256
 border-radius with box-shadow is not rendered correctly
 https://bugs.webkit.org/show_bug.cgi?id=106404
 
 Reviewed by Hajime Morita.
 
 Source/WebCore:
 
 RoundedRect::isRenderable is wrong. So RoundedRect::adjustRadii
 is invoked for renderable RoundedRects.
 
 Test: fast/borders/border-radius-with-box-shadow.html
 
 * platform/graphics/RoundedRect.cpp:
 (WebCore::RoundedRect::isRenderable):
 Have to compare topLeft's height plus bottomLeft's height with
 rect's height and to compare topRight's height plus bottomRight's
 height with rect's height.
 
 LayoutTests:
 
 * fast/borders/border-radius-with-box-shadow-expected.txt: Added.
 * fast/borders/border-radius-with-box-shadow.html: Added.
 * platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png: Added.
 

TBR=ta...@google.com

Modified Paths

branches/chromium/1364/Source/WebCore/platform/graphics/RoundedRect.cpp


Added Paths

branches/chromium/1364/LayoutTests/fast/borders/border-radius-with-box-shadow-expected.txt
branches/chromium/1364/LayoutTests/fast/borders/border-radius-with-box-shadow.html
branches/chromium/1364/LayoutTests/platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png




Diff

Copied: branches/chromium/1364/LayoutTests/fast/borders/border-radius-with-box-shadow-expected.txt (from rev 139256, trunk/LayoutTests/fast/borders/border-radius-with-box-shadow-expected.txt) (0 => 139440)

--- branches/chromium/1364/LayoutTests/fast/borders/border-radius-with-box-shadow-expected.txt	(rev 0)
+++ branches/chromium/1364/LayoutTests/fast/borders/border-radius-with-box-shadow-expected.txt	2013-01-11 15:03:22 UTC (rev 139440)
@@ -0,0 +1 @@
+


Copied: branches/chromium/1364/LayoutTests/fast/borders/border-radius-with-box-shadow.html (from rev 139256, trunk/LayoutTests/fast/borders/border-radius-with-box-shadow.html) (0 => 139440)

--- branches/chromium/1364/LayoutTests/fast/borders/border-radius-with-box-shadow.html	(rev 0)
+++ branches/chromium/1364/LayoutTests/fast/borders/border-radius-with-box-shadow.html	2013-01-11 15:03:22 UTC (rev 139440)
@@ -0,0 +1,26 @@
+!doctype html
+head
+style
+.fo_menu{
+width: 549px;
+height: 45px;
+background-color: #00;
+border-top-left-radius: 130px 70px;
+border-top-right-radius: 130px 70px;
+margin:50ppx;
+box-shadow: 0px 0px 1px 1px #00;
+}
+/style
+script
+if (window.testRunner)
+   testRunner.dumpAsText(true);
+/script
+/head
+body
+!-- [bug 106404] https://bugs.webkit.org/show_bug.cgi?id=106404 --
+!-- border-radius with box-shadow is not rendered correctly. --
+!-- This test is for checking whether the above bug is correctly --
+!-- fixed or not. --
+div class=fo_menu
+/div
+/body


Copied: branches/chromium/1364/LayoutTests/platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png (from rev 139256, trunk/LayoutTests/platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png) (0 => 139440)

--- branches/chromium/1364/LayoutTests/platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png	(rev 0)
+++ branches/chromium/1364/LayoutTests/platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png	2013-01-11 15:03:22 UTC (rev 139440)
@@ -0,0 +1,12 @@
+\x89PNG
+
+
+IHDR X')tEXtchecksuma22288c0f6dc62ecd5b163b292ddcfbd\xDC\xCE\xD4IDATx\x9C\xED\xDDKo\x9Cg\xFD\xC7\xE1xb{\\xDA\xE0\x98\x92\xD4\xB4$*\xE2 RE\xADXTH *\xED\x82\xBC^\xB2 \xEDP$\x8DZ\x81\x84I\x92AU\x8AR5\xD4DIH;1Nl'\x8F\xEB9=\xF3_XͿ\x97\x9E\xBE\x93I\xC6׵\xF4i~#Y\xF6g\xEE\xE7\x9E\xFB\xE9k\xB7\xDB;\xC8)u{\x80^#\xB0\xC2@\x98\xC0Xa\xFD\xDD\xA0\x83\xDA\xEDv\xADV+\x8A\xA2(\x8AZ\xAD\xD6n\xB7\x8B\xA2h4\xCDf\xF3\xCE\xD74\x9B\xCDF\xA3QE\xE7\xF8\xA5Ri``\xA0\xBF\xFF\xFF\xFFD\xF7\xF7\xF7\x94J\xA5\xBE\xBE\xBEr\xB9\*\x95J\xA5R\xB9\\xEE\xEB\xEB\xEB\xE2\x9C\xC0\xBB\xE9\x91\xC0j4\x8DF\xA3V\xAB5\x9B\xCDz\xBD\xDEh466\xE6\xE7\xE7k\xB5Z\xADV\xBBr\xE5J\xADVk4\x8B\x8B\x8Bkkk\x9BEU\xC5\xDA\xDA\xDA\xE2\xE2\xE2;\x93\xA0\xEB\xFA\xFB\xFB\xF7\xEC\xD93::Z*\x95v\xEC\xD8Q*\x95FGG\xF7\xEC\xD9300P.\x97\xF7\xED\xDBW.\x97\xCB\xE5\xF2\xD4\xD4\xD4\xD0\xD0\xD0\xD0\xD0\xD0\xC0\xC0\xC0\xE0\xE0`\xB9\\xE8\xF63\x80\xED\xEE\xBE\xACv\xBB]\xAF\xD77޶\xBE\xBE~\xFD\xFA\xF5\xFF\xFB\xDF+++׮][^^~\xF3\xCD7766n޼YE\xBBݮV\xAB\xEDv\xBB\xDDn\xFF\xC7z\xD5\xE6g\xBB\xF8\\xB6\xD4\xD7׷YW\x9B6״\xFA\xFA\xFA\xFA\xFA\xFAFFF6?\xBBk׮\xA1\xA1\xA1O}\xEAS\xBBw\xEF޻w\xEF\xF8\xF8\xF8\xE4\xE4\xE4'\xF1\x89\x8F\xFC\xE3\xC3\xC3\xC3Co

[webkit-changes] [139441] trunk/Tools

2013-01-11 Thread mario

Title: [139441] trunk/Tools








Revision 139441
Author ma...@webkit.org
Date 2013-01-11 07:31:12 -0800 (Fri, 11 Jan 2013)


Log Message
Unreviewed. Update my e-mail addresses.

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (139440 => 139441)

--- trunk/Tools/ChangeLog	2013-01-11 15:03:22 UTC (rev 139440)
+++ trunk/Tools/ChangeLog	2013-01-11 15:31:12 UTC (rev 139441)
@@ -1,3 +1,9 @@
+2013-01-11  Mario Sanchez Prada  mario.pr...@samsung.com
+
+Unreviewed. Update my e-mail addresses.
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2013-01-11  Raphael Kubo da Costa  raphael.kubo.da.co...@intel.com
 
 Another unreviewed fix after r139431.


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (139440 => 139441)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2013-01-11 15:03:22 UTC (rev 139440)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2013-01-11 15:31:12 UTC (rev 139441)
@@ -341,7 +341,7 @@
 Committer(Mads Ager, a...@chromium.org),
 Committer(Mahesh Kulkarni, [mahesh.kulka...@nokia.com, mahe...@webkit.org], maheshk),
 Committer(Marcus Voltis Bulach, bul...@chromium.org),
-Committer(Mario Sanchez Prada, [ma...@webkit.org], msanchez),
+Committer(Mario Sanchez Prada, [ma...@webkit.org, mario.pr...@samsung.com], msanchez),
 Committer(Mark Lam, mark@apple.com, mlam),
 Committer(Mary Wu, [mary...@torchmobile.com.cn, wwendy2...@gmail.com], marywu),
 Committer(Matt Delaney, mdela...@apple.com),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139442] branches/chromium/1364/Source/WebCore/inspector/front-end

2013-01-11 Thread vsevik

Title: [139442] branches/chromium/1364/Source/WebCore/inspector/front-end








Revision 139442
Author vse...@chromium.org
Date 2013-01-11 07:33:38 -0800 (Fri, 11 Jan 2013)


Log Message
Merge 138481
 Unreviewed, rolling out r137905.
 http://trac.webkit.org/changeset/137905
 https://bugs.webkit.org/show_bug.cgi?id=105765
 
 Popover does not disappear when hovering another identifier in
 sources panel. (Requested by vsevik on #webkit).
 
 Patch by Sheriff Bot webkit.review@gmail.com on 2012-12-26
 
 * inspector/front-end/Popover.js:
 (WebInspector.Popover.prototype._innerShow):
 * inspector/front-end/popover.css:
 (.popover):

TBR=commit-qu...@webkit.org
BUG=167597
Review URL: https://codereview.chromium.org/11860010

Modified Paths

branches/chromium/1364/Source/WebCore/inspector/front-end/Popover.js
branches/chromium/1364/Source/WebCore/inspector/front-end/popover.css




Diff

Modified: branches/chromium/1364/Source/WebCore/inspector/front-end/Popover.js (139441 => 139442)

--- branches/chromium/1364/Source/WebCore/inspector/front-end/Popover.js	2013-01-11 15:31:12 UTC (rev 139441)
+++ branches/chromium/1364/Source/WebCore/inspector/front-end/Popover.js	2013-01-11 15:33:38 UTC (rev 139442)
@@ -106,7 +106,7 @@
 this._positionElement(anchor, preferredWidth, preferredHeight);
 
 if (this._popoverHelper) {
-this.element.addEventListener(mousemove, this._popoverHelper._killHidePopoverTimer.bind(this._popoverHelper), true);
+contentElement.addEventListener(mousemove, this._popoverHelper._killHidePopoverTimer.bind(this._popoverHelper), true);
 this.element.addEventListener(mouseout, this._popoverHelper._popoverMouseOut.bind(this._popoverHelper), true);
 }
 },


Modified: branches/chromium/1364/Source/WebCore/inspector/front-end/popover.css (139441 => 139442)

--- branches/chromium/1364/Source/WebCore/inspector/front-end/popover.css	2013-01-11 15:31:12 UTC (rev 139441)
+++ branches/chromium/1364/Source/WebCore/inspector/front-end/popover.css	2013-01-11 15:33:38 UTC (rev 139442)
@@ -3,6 +3,7 @@
 -webkit-border-image: url(Images/popoverBackground.png) 25 25 25 25;
 border-width: 25px;
 z-index: 100;
+pointer-events: none;
 }
 
 .popover .content {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139443] trunk/Tools

2013-01-11 Thread commit-queue

Title: [139443] trunk/Tools








Revision 139443
Author commit-qu...@webkit.org
Date 2013-01-11 07:33:57 -0800 (Fri, 11 Jan 2013)


Log Message
[chromium] move some whitespace and resize related methods to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106655

Patch by Dan Carney dcar...@google.com on 2013-01-11
Reviewed by Jochen Eisinger.

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebKit):
(WebTestRunner::WebTestDelegate::setClientWindowRect):
(WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
(WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
(WebTestRunner):
(WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
(WebTestRunner::TestRunner::enableAutoResizeMode):
(WebTestRunner::TestRunner::disableAutoResizeMode):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setClientWindowRect):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h




Diff

Modified: trunk/Tools/ChangeLog (139442 => 139443)

--- trunk/Tools/ChangeLog	2013-01-11 15:33:38 UTC (rev 139442)
+++ trunk/Tools/ChangeLog	2013-01-11 15:33:57 UTC (rev 139443)
@@ -1,3 +1,33 @@
+2013-01-11  Dan Carney  dcar...@google.com
+
+[chromium] move some whitespace and resize related methods to TestRunner library
+https://bugs.webkit.org/show_bug.cgi?id=106655
+
+Reviewed by Jochen Eisinger.
+
+* DumpRenderTree/chromium/DRTTestRunner.cpp:
+(DRTTestRunner::DRTTestRunner):
+* DumpRenderTree/chromium/DRTTestRunner.h:
+(DRTTestRunner):
+* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
+(WebKit):
+(WebTestRunner::WebTestDelegate::setClientWindowRect):
+(WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
+(WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
+(WebTestRunner::TestRunner::TestRunner):
+(WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
+(WebTestRunner):
+(WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
+(WebTestRunner::TestRunner::enableAutoResizeMode):
+(WebTestRunner::TestRunner::disableAutoResizeMode):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
+(TestRunner):
+* DumpRenderTree/chromium/WebViewHost.cpp:
+(WebViewHost::setClientWindowRect):
+* DumpRenderTree/chromium/WebViewHost.h:
+(WebViewHost):
+
 2013-01-11  Mario Sanchez Prada  mario.pr...@samsung.com
 
 Unreviewed. Update my e-mail addresses.


Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139442 => 139443)

--- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-11 15:33:38 UTC (rev 139442)
+++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-11 15:33:57 UTC (rev 139443)
@@ -113,14 +113,12 @@
 bindMethod(didLosePointerLock, DRTTestRunner::didLosePointerLock);
 bindMethod(didNotAcquirePointerLock, DRTTestRunner::didNotAcquirePointerLock);
 #endif
-bindMethod(disableAutoResizeMode, DRTTestRunner::disableAutoResizeMode);
 bindMethod(display, DRTTestRunner::display);
 bindMethod(displayInvalidatedRegion, DRTTestRunner::displayInvalidatedRegion);
 bindMethod(dumpBackForwardList, DRTTestRunner::dumpBackForwardList);
 bindMethod(dumpProgressFinishedCallback, DRTTestRunner::dumpProgressFinishedCallback);
 bindMethod(dumpSelectionRect, DRTTestRunner::dumpSelectionRect);
 bindMethod(dumpStatusCallbacks, DRTTestRunner::dumpWindowStatusChanges);
-bindMethod(enableAutoResizeMode, DRTTestRunner::enableAutoResizeMode);
 bindMethod(evaluateInWebInspector, DRTTestRunner::evaluateInWebInspector);
 #if ENABLE(NOTIFICATIONS)
 bindMethod(grantWebNotificationPermission, DRTTestRunner::grantWebNotificationPermission);
@@ -151,9 +149,7 @@
 #endif
 bindMethod(setPOSIXLocale, DRTTestRunner::setPOSIXLocale);
 bindMethod(setPrinting, DRTTestRunner::setPrinting);
-bindMethod(setSelectTrailingWhitespaceEnabled, DRTTestRunner::setSelectTrailingWhitespaceEnabled);

[webkit-changes] [139444] trunk

2013-01-11 Thread schenney

Title: [139444] trunk








Revision 139444
Author schen...@chromium.org
Date 2013-01-11 07:35:06 -0800 (Fri, 11 Jan 2013)


Log Message
Objects can be re-added to the AXObjectCache during removal
https://bugs.webkit.org/show_bug.cgi?id=104171

Source/WebCore:

The problem occurs when a label's corresponding element is a sibling
that precedes it in the render tree, and the corresponding element is
removed. The corresponding element's AX render object is removed, but
then recreated when accessibilityIsIgnored() invokes correspondingControl()
on the label. The corresponding renderer then has an AX render object
that survives beyond the deleted renderer, leading to invalid memory
accesses.

The solution is to rearrange the calls to delete the renderer's AX
render object only when we are sure it will no longer be required.

Reviewed by Simon Fraser.

Test: accessibility/corresponding-control-deleted-crash.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed): Move the call to remove the
renderer from the AXCache to after the renderer is removed from the
render tree. This means that the AXObject still exists during renderer
removal, as we require.

LayoutTests:

Reviewed by Simon Fraser.

New test which asserts with !m_hasAXObject in RenderObject::~RenderObject without the patch. Requires Shadow DOM enabled.

* accessibility/corresponding-control-deleted-crash-expected.txt: Added.
* accessibility/corresponding-control-deleted-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp


Added Paths

trunk/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt
trunk/LayoutTests/accessibility/corresponding-control-deleted-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139443 => 139444)

--- trunk/LayoutTests/ChangeLog	2013-01-11 15:33:57 UTC (rev 139443)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 15:35:06 UTC (rev 139444)
@@ -1,3 +1,15 @@
+2013-01-11  Stephen Chenney  schen...@chromium.org
+
+Objects can be re-added to the AXObjectCache during removal
+https://bugs.webkit.org/show_bug.cgi?id=104171
+
+Reviewed by Simon Fraser.
+
+New test which asserts with !m_hasAXObject in RenderObject::~RenderObject without the patch. Requires Shadow DOM enabled.
+
+* accessibility/corresponding-control-deleted-crash-expected.txt: Added.
+* accessibility/corresponding-control-deleted-crash.html: Added.
+
 2013-01-11  Sudarsana Nagineni  sudarsana.nagin...@intel.com
 
 Unreviewed EFL gardening.


Added: trunk/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt (0 => 139444)

--- trunk/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt	2013-01-11 15:35:06 UTC (rev 139444)
@@ -0,0 +1,9 @@
+Make sure that a debug assert is not triggered when a call to RenderBlock::deleteLineBoxTree calls AccessibilityRenderObject::accessibilityIsIgnored which may require the AXObject for a node that is being deleted.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/accessibility/corresponding-control-deleted-crash.html (0 => 139444)

--- trunk/LayoutTests/accessibility/corresponding-control-deleted-crash.html	(rev 0)
+++ trunk/LayoutTests/accessibility/corresponding-control-deleted-crash.html	2013-01-11 15:35:06 UTC (rev 139444)
@@ -0,0 +1,42 @@
+
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body
+
+p id=description/p
+div id=console/div
+
+script
+description(Make sure that a debug assert is not triggered when a call to RenderBlock::deleteLineBoxTree calls AccessibilityRenderObject::accessibilityIsIgnored which may require the AXObject for a node that is being deleted.);
+
+var label = document.createElement('label');
+label.style.position = 'fixed';
+document.body.appendChild(label);
+
+var progress = document.createElement('progress');
+progress.style.display = 'block';
+label.appendChild(progress);
+
+var kbd = document.createElement('kbd');
+label.appendChild(kbd);
+
+var labelShadow = label.webkitCreateShadowRoot();
+
+var select = document.createElement('select');
+select.setAttribute('multiple', 'multiple');
+labelShadow.appendChild(select);
+
+var shadow = document.createElement('shadow');
+labelShadow.appendChild(shadow);
+
+select.focus();
+
+document.body.removeChild(label);
+
+/script
+script src=""
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (139443 => 139444)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 15:33:57 UTC (rev 139443)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 15:35:06 UTC (rev 139444)
@@ -1,3 +1,28 @@
+2013-01-11  Stephen Chenney

[webkit-changes] [139445] trunk

2013-01-11 Thread schenney

Title: [139445] trunk








Revision 139445
Author schen...@chromium.org
Date 2013-01-11 07:41:11 -0800 (Fri, 11 Jan 2013)


Log Message
Source/WebKit/chromium: Removing Skia flags that have been disabling oprtimizations and other improvements.

Unreviewed build fix.

These changes have been extensively tested by the Skia team, and
WebKit test result changes will be monitored.

* skia_webkit.gyp:

LayoutTests: Unreviewed test expectations update.

All of the tests will be rebaselined by end of day.

* platform/chromium/TestExpectations: Mark tests affected by Skia flag changes as expected to fail.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/skia_webkit.gyp




Diff

Modified: trunk/LayoutTests/ChangeLog (139444 => 139445)

--- trunk/LayoutTests/ChangeLog	2013-01-11 15:35:06 UTC (rev 139444)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 15:41:11 UTC (rev 139445)
@@ -1,5 +1,13 @@
 2013-01-11  Stephen Chenney  schen...@chromium.org
 
+Unreviewed test expectations update.
+
+All of the tests will be rebaselined by end of day.
+
+* platform/chromium/TestExpectations: Mark tests affected by Skia flag changes as expected to fail.
+
+2013-01-11  Stephen Chenney  schen...@chromium.org
+
 Objects can be re-added to the AXObjectCache during removal
 https://bugs.webkit.org/show_bug.cgi?id=104171
 


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139444 => 139445)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-11 15:35:06 UTC (rev 139444)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-11 15:41:11 UTC (rev 139445)
@@ -4293,3 +4293,495 @@
 webkit.org/b/106606 platform/chromium/virtual/gpu/fast/canvas/webgl/context-release-upon-reload.html [ Timeout Pass ]
 webkit.org/b/106609 [ Win ] animations/fill-mode-iteration-count-non-integer.html [ Failure ]
 webkit.org/b/106612 [ Win ] fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html [ Failure Pass ]
+
+Bug(schenney) canvas/philip/tests/2d.gradient.interpolate.overlap2.html [ Failure ]
+Bug(schenney) canvas/philip/tests/2d.gradient.linear.transform.1.html [ Failure ]
+Bug(schenney) canvas/philip/tests/2d.gradient.linear.transform.2.html [ Failure ]
+Bug(schenney) canvas/philip/tests/2d.gradient.linear.transform.3.html [ Failure ]
+Bug(schenney) canvas/philip/tests/2d.gradient.radial.transform.1.html [ Failure ]
+Bug(schenney) canvas/philip/tests/2d.gradient.radial.transform.2.html [ Failure ]
+Bug(schenney) canvas/philip/tests/2d.gradient.radial.transform.3.html [ Failure ]
+Bug(schenney) css1/box_properties/acid_test.html [ ImageOnlyFailure ]
+Bug(schenney) css2.1/t09-c5526c-display-00-e.html [ ImageOnlyFailure ]
+Bug(schenney) css3/images/cross-fade-overflow-position.html [ ImageOnlyFailure ]
+Bug(schenney) css3/selectors3/html/css3-modsel-161.html [ ImageOnlyFailure ]
+Bug(schenney) css3/selectors3/html/css3-modsel-19b.html [ ImageOnlyFailure ]
+Bug(schenney) css3/selectors3/html/css3-modsel-25.html [ ImageOnlyFailure ]
+Bug(schenney) css3/selectors3/html/css3-modsel-64.html [ ImageOnlyFailure ]
+Bug(schenney) css3/selectors3/html/css3-modsel-70.html [ ImageOnlyFailure ]
+Bug(schenney) css3/selectors3/xhtml/css3-modsel-161.xml [ ImageOnlyFailure ]
+Bug(schenney) css3/selectors3/xhtml/css3-modsel-19b.xml [ ImageOnlyFailure ]
+Bug(schenney) css3/selectors3/xhtml/css3-modsel-25.xml [ ImageOnlyFailure ]
+Bug(schenney) css3/selectors3/xhtml/css3-modsel-64.xml [ ImageOnlyFailure ]
+Bug(schenney) css3/selectors3/xhtml/css3-modsel-70.xml [ ImageOnlyFailure ]
+Bug(schenney) css3/selectors3/xml/css3-modsel-161.xml [ ImageOnlyFailure ]
+Bug(schenney) css3/selectors3/xml/css3-modsel-19b.xml [ ImageOnlyFailure ]
+Bug(schenney) css3/selectors3/xml/css3-modsel-25.xml [ ImageOnlyFailure ]
+Bug(schenney) css3/selectors3/xml/css3-modsel-64.xml [ ImageOnlyFailure ]
+Bug(schenney) css3/selectors3/xml/css3-modsel-70.xml [ ImageOnlyFailure ]
+Bug(schenney) editing/pasteboard/4641033.html [ ImageOnlyFailure ]
+Bug(schenney) editing/pasteboard/4944770-1.html [ ImageOnlyFailure ]
+Bug(schenney) editing/pasteboard/4944770-2.html [ ImageOnlyFailure ]
+Bug(schenney) editing/selection/3690703-2.html [ ImageOnlyFailure ]
+Bug(schenney) editing/selection/3690703.html [ ImageOnlyFailure ]
+Bug(schenney) editing/selection/3690719.html [ ImageOnlyFailure ]
+Bug(schenney) editing/selection/4397952.html [ ImageOnlyFailure ]
+Bug(schenney) editing/selection/5240265.html [ ImageOnlyFailure ]
+Bug(schenney) editing/selection/caret-before-select.html [ ImageOnlyFailure ]
+Bug(schenney) editing/selection/replaced-boundaries-3.html [ ImageOnlyFailure ]
+Bug(schenney) editing/selection/select-box.html [ ImageOnlyFailure ]
+Bug(schenney) editing/selection/select-element-paragraph-boundary.html [ ImageOnlyFailure ]
+Bug(schenney) editing/selection/selection-button-text.html [ ImageOnlyFailure ]

[webkit-changes] [139446] trunk/Source/WebCore

2013-01-11 Thread abecsi

Title: [139446] trunk/Source/WebCore








Revision 139446
Author abe...@webkit.org
Date 2013-01-11 07:55:02 -0800 (Fri, 11 Jan 2013)


Log Message
[Qt] Fix the build if libxslt is not available but libxml2 is
https://bugs.webkit.org/show_bug.cgi?id=106661

Reviewed by Simon Hausmann.

On Linux building the xml parser sources fails if the needed libxslt
dependencies are not installed but libxml2 is.

* WebCore.pri: add libxml2 to pkg-config if not on mac.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.pri




Diff

Modified: trunk/Source/WebCore/ChangeLog (139445 => 139446)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 15:41:11 UTC (rev 139445)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 15:55:02 UTC (rev 139446)
@@ -1,3 +1,15 @@
+2013-01-11  Andras Becsi  andras.be...@digia.com
+
+[Qt] Fix the build if libxslt is not available but libxml2 is
+https://bugs.webkit.org/show_bug.cgi?id=106661
+
+Reviewed by Simon Hausmann.
+
+On Linux building the xml parser sources fails if the needed libxslt
+dependencies are not installed but libxml2 is.
+
+* WebCore.pri: add libxml2 to pkg-config if not on mac.
+
 2013-01-11  Stephen Chenney  schen...@chromium.org
 Objects can be re-added to the AXObjectCache during removal
 https://bugs.webkit.org/show_bug.cgi?id=104171


Modified: trunk/Source/WebCore/WebCore.pri (139445 => 139446)

--- trunk/Source/WebCore/WebCore.pri	2013-01-11 15:41:11 UTC (rev 139445)
+++ trunk/Source/WebCore/WebCore.pri	2013-01-11 15:55:02 UTC (rev 139446)
@@ -116,6 +116,8 @@
 } else {
 QT *= xmlpatterns
 }
+} else:!mac:use?(LIBXML2) {
+PKGCONFIG += libxml-2.0
 }
 
 use?(ZLIB) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139447] branches/chromium/1364

2013-01-11 Thread rjkroege

Title: [139447] branches/chromium/1364








Revision 139447
Author rjkro...@chromium.org
Date 2013-01-11 08:34:52 -0800 (Fri, 11 Jan 2013)


Log Message
Merge 139339
 Manually revert http://trac.webkit.org/changeset/136012
 https://bugs.webkit.org/show_bug.cgi?id=106580
 
 Reviewed by Dimitri Glazkov.
 
 Source/WebCore:
 
 136012 broke touch-scrolling of an overflow div in an iframe. Revert manually
 to work around conflicts.
 
 * page/EventHandler.cpp:
 (WebCore::EventHandler::handleWheelEvent):
 
 LayoutTests:
 
 * fast/events/touch/gesture/touch-gesture-scroll-remove-node-expected.txt: Removed.
 * fast/events/touch/gesture/touch-gesture-scroll-remove-node.html: Removed.
 

TBR=rjkro...@chromium.org

Modified Paths

branches/chromium/1364/Source/WebCore/page/EventHandler.cpp


Removed Paths

branches/chromium/1364/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-remove-node-expected.txt
branches/chromium/1364/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-remove-node.html




Diff

Deleted: branches/chromium/1364/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-remove-node-expected.txt (139446 => 139447)

--- branches/chromium/1364/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-remove-node-expected.txt	2013-01-11 15:55:02 UTC (rev 139446)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-remove-node-expected.txt	2013-01-11 16:34:52 UTC (rev 139447)
@@ -1,29 +0,0 @@
-This tests gesture event scrolling of a div where the element the scrolling starts on is removed from an onscroll event handler.
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-
-begin scroll
-scroll up
-PASS scroller.scrollTop is 96
-PASS scroller.scrollLeft is 0
-PASS wheelCount is 1
-PASS scrollCount is 1
-PASS typeof cache[2] is typeof undefined
-scroll down
-PASS scroller.scrollTop is 0
-PASS scroller.scrollLeft is 0
-PASS wheelCount is 2
-PASS scrollCount is 2
-1
-2
-3
-4
-5
-6
-7
-8
-9
-10
-11
-


Deleted: branches/chromium/1364/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-remove-node.html (139446 => 139447)

--- branches/chromium/1364/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-remove-node.html	2013-01-11 15:55:02 UTC (rev 139446)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-remove-node.html	2013-01-11 16:34:52 UTC (rev 139447)
@@ -1,197 +0,0 @@
-!DOCTYPE=html
-html
-head
-script src=""
-script src=""
-style
-  #spacing {
-width: 200px;
-height: 120px;
-  }
-  #scroller {
-border: 1px solid #777;
-box-sizing: content-box;
-height: 300px;
-margin: 20px;
-overflow-x: hidden;
-overflow-y: auto;
-width: 100px
-  }
-  .spacer {
-box-sizing: border-box;
-display: block;
-overflow: hidden;
-visibility: hidden;
-  }
-  .list-item {
-line-height: 30px;
-text-align: center;
-  }
-/style
-/head
-body _onload_=runTest();
-  div id=spacing/div
-  div id=scroller
-div id = top-spacer class=spacer/div
-
-div id = bottom-spacer class=spacer/div
-  /div
-script
-var cache = {};
-
-/* One more that the maximum that can be fully fit on screen. */
-var maxVisibleItems = 11;
-
-var listSize = 300;
-
-var itemHeight = 30;
-
-function $(name) {
-  return document.getElementById(name);
-}
-
-function onScroll(e) {
-  redraw();
-}
-
-function redraw() {
-  // Create new items and add to cache.
-  var top = $('scroller').scrollTop;
-  var first = Math.floor(top / 30);
-  if (first  listSize - maxVisibleItems)
-first = listSize - maxVisibleItems;
-  var newItems = [];
-  for (var i = 0; i  maxVisibleItems; i++) {
-var index = first + i;
-if (cache[index] == undefined) {
-  var element = document.createElement('div');
-  element.className = 'list-item';
-  element.textContent = String(index+1);
-  element.data = ""
-  element.data.index = index;
-  cache[index] = element;
-  newItems.push(element);
-}
-  }
-  // Remove items that are not visible.
-  for (var i = 0; i  first; i++) {
-if (cache[i])
-  delete cache[i];
-  }
-  for (var i = first + maxVisibleItems; i  listSize; i++) {
-if (cache[i])
-  delete cache[i];
-  }
-  // Pad spacer elements to preserve height of scrollable list.
-  $('top-spacer').style.height = (first * itemHeight) + 'px';
-  $('bottom-spacer').style.height =
-  ((listSize - maxVisibleItems - first) * 30) + 'px';
-
-  // Remove off-screen elements.
-  var anchor = $('bottom-spacer');
-  var parent = $('scroller');
-  for (var item = $('top-spacer').nextSibling; item != anchor; ) {
-if (!item.classList || !item.classList.contains('list-item')) {
-  item = item.nextSibling;
-  continue;
-}
-if (!cache[item.data.index]) {
-  var next = item.nextSibling;
-  scroller.removeChild(item);
-  item = next;
-} else {
-  item = item.nextSibling;
-}
-  }
-
-  // Insert new on-screen elements.

[webkit-changes] [139448] trunk/LayoutTests

2013-01-11 Thread schenney

Title: [139448] trunk/LayoutTests








Revision 139448
Author schen...@chromium.org
Date 2013-01-11 08:39:12 -0800 (Fri, 11 Jan 2013)


Log Message
[Chromium] Test Expectations update after Skia flag changes.

Unreviewed test expectations update.

Apparently, we use Skia to draw some forms on Mac and Win, causing
failures not seen on Linux.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139447 => 139448)

--- trunk/LayoutTests/ChangeLog	2013-01-11 16:34:52 UTC (rev 139447)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 16:39:12 UTC (rev 139448)
@@ -1,7 +1,18 @@
 2013-01-11  Stephen Chenney  schen...@chromium.org
 
+[Chromium] Test Expectations update after Skia flag changes.
+
 Unreviewed test expectations update.
 
+Apparently, we use Skia to draw some forms on Mac and Win, causing
+failures not seen on Linux.
+
+* platform/chromium/TestExpectations:
+
+2013-01-11  Stephen Chenney  schen...@chromium.org
+
+Unreviewed test expectations update.
+
 All of the tests will be rebaselined by end of day.
 
 * platform/chromium/TestExpectations: Mark tests affected by Skia flag changes as expected to fail.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139447 => 139448)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-11 16:34:52 UTC (rev 139447)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-11 16:39:12 UTC (rev 139448)
@@ -4294,6 +4294,517 @@
 webkit.org/b/106609 [ Win ] animations/fill-mode-iteration-count-non-integer.html [ Failure ]
 webkit.org/b/106612 [ Win ] fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html [ Failure Pass ]
 
+Bug(schenney) editing/deleting/4922367.html [ Failure ]
+Bug(schenney) editing/deleting/5099303.html [ Failure ]
+Bug(schenney) editing/deleting/5126166.html [ Failure ]
+Bug(schenney) editing/deleting/5144139-2.html [ Failure ]
+Bug(schenney) editing/deleting/5206311-1.html [ Failure ]
+Bug(schenney) editing/deleting/5272440.html [ Failure ]
+Bug(schenney) editing/deleting/5369009.html [ Failure ]
+Bug(schenney) editing/deleting/5433862-2.html [ Failure ]
+Bug(schenney) editing/deleting/5483370.html [ Failure ]
+Bug(schenney) editing/deleting/collapse-whitespace-3587601-fix.html [ Failure ]
+Bug(schenney) editing/deleting/delete-3608445-fix.html [ Failure ]
+Bug(schenney) editing/deleting/delete-3608462-fix.html [ Failure ]
+Bug(schenney) editing/deleting/delete-408-fix.html [ Failure ]
+Bug(schenney) editing/deleting/delete-after-span-ws-001.html [ Failure ]
+Bug(schenney) editing/deleting/delete-after-span-ws-002.html [ Failure ]
+Bug(schenney) editing/deleting/delete-after-span-ws-003.html [ Failure ]
+Bug(schenney) editing/deleting/delete-and-undo.html [ Failure ]
+Bug(schenney) editing/deleting/delete-at-paragraph-boundaries-002.html [ Failure ]
+Bug(schenney) editing/deleting/delete-at-paragraph-boundaries-003.html [ Failure ]
+Bug(schenney) editing/deleting/delete-at-paragraph-boundaries-004.html [ Failure ]
+Bug(schenney) editing/deleting/delete-at-paragraph-boundaries-005.html [ Failure ]
+Bug(schenney) editing/deleting/delete-at-paragraph-boundaries-006.html [ Failure ]
+Bug(schenney) editing/deleting/delete-at-paragraph-boundaries-007.html [ Failure ]
+Bug(schenney) editing/deleting/delete-at-paragraph-boundaries-008.html [ Failure ]
+Bug(schenney) editing/deleting/delete-at-paragraph-boundaries-009.html [ Failure ]
+Bug(schenney) editing/deleting/delete-at-paragraph-boundaries-010.html [ Failure ]
+Bug(schenney) editing/deleting/delete-at-paragraph-boundaries-011.html [ Failure ]
+Bug(schenney) editing/deleting/delete-at-start-or-end.html [ Failure ]
+Bug(schenney) editing/deleting/delete-block-contents-001.html [ Failure ]
+Bug(schenney) editing/deleting/delete-block-contents-002.html [ Failure ]
+Bug(schenney) editing/deleting/delete-block-contents-003.html [ Failure ]
+Bug(schenney) editing/deleting/delete-block-merge-contents-001.html [ Failure ]
+Bug(schenney) editing/deleting/delete-block-merge-contents-002.html [ Failure ]
+Bug(schenney) editing/deleting/delete-block-merge-contents-003.html [ Failure ]
+Bug(schenney) editing/deleting/delete-block-merge-contents-004.html [ Failure ]
+Bug(schenney) editing/deleting/delete-block-merge-contents-005.html [ Failure ]
+Bug(schenney) editing/deleting/delete-block-merge-contents-006.html [ Failure ]
+Bug(schenney) editing/deleting/delete-block-merge-contents-007.html [ Failure ]
+Bug(schenney) editing/deleting/delete-block-merge-contents-008.html [ Failure ]
+Bug(schenney) editing/deleting/delete-block-merge-contents-009.html [ Failure ]
+Bug(schenney) editing/deleting/delete-block-merge-contents-010.html [ Failure ]
+Bug(schenney) editing/deleting/delete-block-merge-contents-011.html [ Failure ]
+Bug(schenney)

[webkit-changes] [139449] trunk/Tools

2013-01-11 Thread rakuco

Title: [139449] trunk/Tools








Revision 139449
Author rak...@webkit.org
Date 2013-01-11 08:49:25 -0800 (Fri, 11 Jan 2013)


Log Message
Yet another unreviewed fix after r139431.

* Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
the correct order.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-launcher




Diff

Modified: trunk/Tools/ChangeLog (139448 => 139449)

--- trunk/Tools/ChangeLog	2013-01-11 16:39:12 UTC (rev 139448)
+++ trunk/Tools/ChangeLog	2013-01-11 16:49:25 UTC (rev 139449)
@@ -1,3 +1,10 @@
+2013-01-11  Raphael Kubo da Costa  raphael.kubo.da.co...@intel.com
+
+Yet another unreviewed fix after r139431.
+
+* Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
+the correct order.
+
 2013-01-11  Dan Carney  dcar...@google.com
 
 [chromium] move some whitespace and resize related methods to TestRunner library


Modified: trunk/Tools/Scripts/run-launcher (139448 => 139449)

--- trunk/Tools/Scripts/run-launcher	2013-01-11 16:39:12 UTC (rev 139448)
+++ trunk/Tools/Scripts/run-launcher	2013-01-11 16:49:25 UTC (rev 139449)
@@ -70,10 +70,9 @@
 unshift(@ARGV, catdir($launcherPath, Programs, GtkLauncher));
 }
 $launcherPath = catdir(sourceDir(), Tools, jhbuild, jhbuild-wrapper);
-unshift(@ARGV, '--gtk');
-unshift(@ARGV, 'run');
+unshift(@ARGV, (--gtk, run));
 }
-
+
 if (isEfl()) {
 if (isWK2()) {
 unshift(@ARGV, catdir($launcherPath, bin, MiniBrowser));
@@ -81,10 +80,9 @@
 unshift(@ARGV, catdir($launcherPath, bin, EWebLauncher));
 }
 $launcherPath = catdir(sourceDir(), Tools, jhbuild, jhbuild-wrapper);
-unshift(@ARGV, '--efl');
-unshift(@ARGV, 'run');
+unshift(@ARGV, (--efl, run));
 }
-
+
 if (isWx()) {
 if (isDarwin()) {
 $launcherPath = catdir($launcherPath, 'wxBrowser.app', 'Contents', 'MacOS', 'wxBrowser');






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139450] trunk/LayoutTests

2013-01-11 Thread fmalita

Title: [139450] trunk/LayoutTests








Revision 139450
Author fmal...@chromium.org
Date 2013-01-11 08:56:53 -0800 (Fri, 11 Jan 2013)


Log Message
[Chromium] Unreviewed gardening.

Rebaselining results after http://trac.webkit.org/changeset/139238.

* platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png:
* platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
* platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
* platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
* platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
* platform/chromium-mac-lion/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-mac/fast/backgrounds/border-radius-split-background-image-expected.png:
* platform/chromium-mac/fast/borders/border-radius-complex-inner-expected.png:
* platform/chromium-mac/fast/borders/border-radius-inset-outset-expected.png:
* platform/chromium-mac/fast/borders/border-radius-wide-border-05-expected.png:
* platform/chromium-mac/fast/borders/border-styles-split-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png:
* platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png:
* platform/chromium-mac/fast/writing-mode/border-styles-vertical-lr-expected.png:
* platform/chromium-mac/fast/writing-mode/border-styles-vertical-rl-expected.png:
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
* platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-win/fast/backgrounds/border-radius-split-background-image-expected.png:
* platform/chromium-win/fast/borders/border-radius-complex-inner-expected.png:
* platform/chromium-win/fast/borders/border-radius-inset-outset-expected.png:
* platform/chromium-win/fast/borders/border-radius-wide-border-05-expected.png:
* platform/chromium-win/fast/borders/border-styles-split-expected.png:
* platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
* platform/chromium-win/fast/borders/mixed-border-styles-radius-expected.png:
* platform/chromium-win/fast/writing-mode/border-styles-vertical-lr-expected.png:
* platform/chromium-win/fast/writing-mode/border-styles-vertical-rl-expected.png:
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/border-radius-split-background-image-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/borders/border-radius-complex-inner-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/borders/border-radius-inset-outset-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/borders/border-radius-wide-border-05-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/borders/border-styles-split-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/border-styles-vertical-lr-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/border-styles-vertical-rl-expected.png

[webkit-changes] [139452] trunk/Source/WebCore

2013-01-11 Thread commit-queue

Title: [139452] trunk/Source/WebCore








Revision 139452
Author commit-qu...@webkit.org
Date 2013-01-11 09:09:21 -0800 (Fri, 11 Jan 2013)


Log Message
Web Inspector: [Resources] Make grid columns set configurable.
https://bugs.webkit.org/show_bug.cgi?id=105739

Patch by Eugene Klyuchnikov eus...@chromium.org on 2013-01-11
Reviewed by Pavel Feldman.

Added context menu on grid header to hide/show grid columns.
Hidden columns set is persisted.

* inspector/front-end/DataGrid.js:
Fixed show/hide behavior, introduced weight control.
* inspector/front-end/NetworkPanel.js:
Added member to track visibility of columns in detailerd mode. Added
context menu for grid header.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DataGrid.js
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (139451 => 139452)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 17:08:45 UTC (rev 139451)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 17:09:21 UTC (rev 139452)
@@ -1,3 +1,19 @@
+2013-01-11  Eugene Klyuchnikov  eus...@chromium.org
+
+Web Inspector: [Resources] Make grid columns set configurable.
+https://bugs.webkit.org/show_bug.cgi?id=105739
+
+Reviewed by Pavel Feldman.
+
+Added context menu on grid header to hide/show grid columns.
+Hidden columns set is persisted.
+
+* inspector/front-end/DataGrid.js:
+Fixed show/hide behavior, introduced weight control.
+* inspector/front-end/NetworkPanel.js:
+Added member to track visibility of columns in detailerd mode. Added
+context menu for grid header.
+
 2013-01-11  Andras Becsi  andras.be...@digia.com
 
 [Qt] Fix the build if libxslt is not available but libxml2 is


Modified: trunk/Source/WebCore/inspector/front-end/DataGrid.js (139451 => 139452)

--- trunk/Source/WebCore/inspector/front-end/DataGrid.js	2013-01-11 17:08:45 UTC (rev 139451)
+++ trunk/Source/WebCore/inspector/front-end/DataGrid.js	2013-01-11 17:09:21 UTC (rev 139452)
@@ -588,73 +588,50 @@
 this.dispatchEventToListeners(width changed);
 },
 
-columnWidthsMap: function()
+applyColumnWeights: function()
 {
-var result = {};
-for (var i = 0; i  this._columnsArray.length; ++i) {
-var width = this._headerTableColumnGroup.children[i].style.width;
-result[this._columnsArray[i].columnIdentifier] = parseFloat(width);
+var sumOfWeights = 0.0;
+for (var columnIdentifier in this.columns) {
+if (this.isColumnVisible(columnIdentifier))
+sumOfWeights += this.columns[columnIdentifier].weight;
 }
-return result;
-},
+var factor = 100 / sumOfWeights;
 
-applyColumnWidthsMap: function(columnWidthsMap)
-{
 for (var columnIdentifier in this.columns) {
 var column = this.columns[columnIdentifier];
-var width = (columnWidthsMap[columnIdentifier] || 0) + %;
+var width = this.isColumnVisible(columnIdentifier) ? ((factor * column.weight) + %): 0%;
 this._headerTableColumnGroup.children[column.ordinal].style.width = width;
 this._dataTableColumnGroup.children[column.ordinal].style.width = width;
 }
 
-// Normalize widths
-delete this._columnWidthsInitialized;
-this.updateWidths();
+this._positionResizers();
+this.dispatchEventToListeners(width changed);
 },
 
+/**
+ * @param {string} columnIdentifier
+ */
 isColumnVisible: function(columnIdentifier)
 {
-var column = this.columns[columnIdentifier];
-var columnElement = column.element;
-return !columnElement.hidden;
+return !this.columns[columnIdentifier].hidden;
 },
 
-showColumn: function(columnIdentifier)
+/**
+ * @param {string} columnIdentifier
+ * @param {boolean} visible
+ */
+setColumnVisible: function(columnIdentifier, visible)
 {
-var column = this.columns[columnIdentifier];
-var columnElement = column.element;
-if (!columnElement.hidden)
+if (visible === !this.columns[columnIdentifier].hidden)
 return;
 
-columnElement.hidden = false;
-columnElement.removeStyleClass(hidden);
-
-var columnBodyElement = column.bodyElement;
-columnBodyElement.hidden = false;
-columnBodyElement.removeStyleClass(hidden);
+this.columns[columnIdentifier].hidden = !visible;
+if (visible)
+this.element.removeStyleClass(hide- + columnIdentifier + -column);
+else
+this.element.addStyleClass(hide- + columnIdentifier + -column);
 },
 
-hideColumn: function(columnIdentifier)
-{
-var column = this.columns[columnIdentifier];
-var columnElement = column.element;
-if (columnElement.hidden)
-return;
-
-var

[webkit-changes] [139453] trunk/Tools

2013-01-11 Thread commit-queue

Title: [139453] trunk/Tools








Revision 139453
Author commit-qu...@webkit.org
Date 2013-01-11 09:28:12 -0800 (Fri, 11 Jan 2013)


Log Message
[GTK] Disable the unit tests timeout when running from make check
https://bugs.webkit.org/show_bug.cgi?id=106670

Patch by Carlos Garcia Campos cgar...@igalia.com on 2013-01-11
Reviewed by Philippe Normand.

* GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/GNUmakefile.am




Diff

Modified: trunk/Tools/ChangeLog (139452 => 139453)

--- trunk/Tools/ChangeLog	2013-01-11 17:09:21 UTC (rev 139452)
+++ trunk/Tools/ChangeLog	2013-01-11 17:28:12 UTC (rev 139453)
@@ -1,3 +1,12 @@
+2013-01-11  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Disable the unit tests timeout when running from make check
+https://bugs.webkit.org/show_bug.cgi?id=106670
+
+Reviewed by Philippe Normand.
+
+* GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
+
 2013-01-11  Raphael Kubo da Costa  raphael.kubo.da.co...@intel.com
 
 Yet another unreviewed fix after r139431.


Modified: trunk/Tools/GNUmakefile.am (139452 => 139453)

--- trunk/Tools/GNUmakefile.am	2013-01-11 17:09:21 UTC (rev 139452)
+++ trunk/Tools/GNUmakefile.am	2013-01-11 17:28:12 UTC (rev 139453)
@@ -290,7 +290,7 @@
 endif
 
 check-local:
-	$(top_srcdir)/Tools/Scripts/run-gtk-tests
+	$(top_srcdir)/Tools/Scripts/run-gtk-tests --timeout=-1
 
 EXTRA_DIST += \
 	Tools/gtk/common.py \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139456] trunk

2013-01-11 Thread dmazzoni

Title: [139456] trunk








Revision 139456
Author dmazz...@google.com
Date 2013-01-11 10:06:57 -0800 (Fri, 11 Jan 2013)


Log Message
AX: Computed hierarchical level is not consistent with aria-level
https://bugs.webkit.org/show_bug.cgi?id=106638

Reviewed by Chris Fleizach.

Source/WebCore:

Make hierarchicalLevel computation 1-based to match the aria-level spec.

Extends an existing test: platform/mac/accessibility/aria-tree.html.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::hierarchicalLevel):
* accessibility/AccessibilityObject.h:
(AccessibilityObject):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

Extend aria-tree.html to check the hierarchicalLevel automatically
computed when aria-level is not provided. Make sure they're consistent.
Now, the mac disclosureLevel will be one less than the web aria-level.

* platform/mac/accessibility/aria-tree-expected.txt:
* platform/mac/accessibility/aria-tree.html:
* platform/mac/accessibility/aria-treegrid-expected.txt:
* platform/mac/accessibility/aria-treegrid.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/accessibility/aria-tree-expected.txt
trunk/LayoutTests/platform/mac/accessibility/aria-tree.html
trunk/LayoutTests/platform/mac/accessibility/aria-treegrid-expected.txt
trunk/LayoutTests/platform/mac/accessibility/aria-treegrid.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (139455 => 139456)

--- trunk/LayoutTests/ChangeLog	2013-01-11 17:48:09 UTC (rev 139455)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 18:06:57 UTC (rev 139456)
@@ -1,3 +1,19 @@
+2013-01-11  Dominic Mazzoni  dmazz...@google.com
+
+AX: Computed hierarchical level is not consistent with aria-level
+https://bugs.webkit.org/show_bug.cgi?id=106638
+
+Reviewed by Chris Fleizach.
+
+Extend aria-tree.html to check the hierarchicalLevel automatically
+computed when aria-level is not provided. Make sure they're consistent.
+Now, the mac disclosureLevel will be one less than the web aria-level.
+
+* platform/mac/accessibility/aria-tree-expected.txt:
+* platform/mac/accessibility/aria-tree.html:
+* platform/mac/accessibility/aria-treegrid-expected.txt:
+* platform/mac/accessibility/aria-treegrid.html:
+
 2013-01-11  Stephen Chenney  schen...@chromium.org
 
 [Chromium] Test Expectations update after Skia flag changes.


Modified: trunk/LayoutTests/platform/mac/accessibility/aria-tree-expected.txt (139455 => 139456)

--- trunk/LayoutTests/platform/mac/accessibility/aria-tree-expected.txt	2013-01-11 17:48:09 UTC (rev 139455)
+++ trunk/LayoutTests/platform/mac/accessibility/aria-tree-expected.txt	2013-01-11 18:06:57 UTC (rev 139456)
@@ -3,6 +3,9 @@
 Cats
 Siamese
 Tabby
+Vegetables
+Carrots
+Broccoli
 This tests that aria trees and tree items are converted into AXOutlines and AXRows, with all the right attributes.
 
 On success, you will see a series of PASS messages, followed by TEST COMPLETE.
@@ -10,16 +13,16 @@
 
 PASS tree.role is 'AXRole: AXOutline'
 PASS canSetRows is true
-PASS tree.childrenCount is 5
+PASS tree.childrenCount is 8
 PASS treeitem1.role is 'AXRole: AXRow'
 PASS treeitem1.subrole is 'AXSubrole: AXOutlineRow'
 PASS treeitem1.isExpanded is true
-PASS treeitem1.hierarchicalLevel is 1
+PASS treeitem1.hierarchicalLevel is 0
 PASS canSetDisclosing is true
 PASS treeitem2.role is 'AXRole: AXRow'
 PASS treeitem2.subrole is 'AXSubrole: AXOutlineRow'
 PASS treeitem2.isExpanded is false
-PASS treeitem2.hierarchicalLevel is 2
+PASS treeitem2.hierarchicalLevel is 1
 PASS treeitem2.disclosedByRow().isEqual(treeitem1) is true
 PASS canSetDisclosing is false
 PASS treeitem3.stringValue is 'AXValue: Birds'
@@ -30,6 +33,9 @@
 PASS treeitem3.isSelected is false
 PASS treeitem3.isSelected is true
 PASS selectedRow.isEqual(treeitem3) is true
+PASS treeitem4.hierarchicalLevel is 0
+PASS treeitem5.hierarchicalLevel is 1
+PASS treeitem6.hierarchicalLevel is 1
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/platform/mac/accessibility/aria-tree.html (139455 => 139456)

--- trunk/LayoutTests/platform/mac/accessibility/aria-tree.html	2013-01-11 17:48:09 UTC (rev 139455)
+++ trunk/LayoutTests/platform/mac/accessibility/aria-tree.html	2013-01-11 18:06:57 UTC (rev 139456)
@@ -26,6 +26,18 @@
 /ul
 /span
 /li
+
+li id=treeitem4 role=treeitem aria-expanded=true
+span
+span class=expander/span
+Vegetables
+/span
+ul role=group
+div id=treeitem5 role=treeitemspanCarrots/span/div
+div id=treeitem6

[webkit-changes] [139457] trunk

2013-01-11 Thread fmalita

Title: [139457] trunk








Revision 139457
Author fmal...@chromium.org
Date 2013-01-11 10:10:10 -0800 (Fri, 11 Jan 2013)


Log Message
[SVG] Suppress resource rebuilding for unattached and shadow elements
https://bugs.webkit.org/show_bug.cgi?id=106664

Reviewed by Dirk Schulze.

Source/WebCore:

SVGStyledElement::buildPendingResourcesIfNeeded() can be called while cloning a subtree
(as nodes are inserted into the clone, while still detached) or when elements are inserted
into the shadow tree. Both of these cases are problematic for SVGUseElement and can trigger
indirect recursion in SVGUseElement::buildPendingResource.

Since shadow and !inDocument() nodes are of no interest to ID dependents (they cannot be
found by ID in the document), the patch short-circuits buildPendingResource() for these
cases.

Test: svg/custom/use-rebuild-resources-crash.svg

* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):

LayoutTests:

* svg/custom/use-rebuild-resources-crash-expected.txt: Added.
* svg/custom/use-rebuild-resources-crash.svg: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGStyledElement.cpp


Added Paths

trunk/LayoutTests/svg/custom/use-rebuild-resources-crash-expected.txt
trunk/LayoutTests/svg/custom/use-rebuild-resources-crash.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (139456 => 139457)

--- trunk/LayoutTests/ChangeLog	2013-01-11 18:06:57 UTC (rev 139456)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 18:10:10 UTC (rev 139457)
@@ -1,3 +1,13 @@
+2013-01-11  Florin Malita  fmal...@chromium.org
+
+[SVG] Suppress resource rebuilding for unattached and shadow elements
+https://bugs.webkit.org/show_bug.cgi?id=106664
+
+Reviewed by Dirk Schulze.
+
+* svg/custom/use-rebuild-resources-crash-expected.txt: Added.
+* svg/custom/use-rebuild-resources-crash.svg: Added.
+
 2013-01-11  Dominic Mazzoni  dmazz...@google.com
 
 AX: Computed hierarchical level is not consistent with aria-level


Added: trunk/LayoutTests/svg/custom/use-rebuild-resources-crash-expected.txt (0 => 139457)

--- trunk/LayoutTests/svg/custom/use-rebuild-resources-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/svg/custom/use-rebuild-resources-crash-expected.txt	2013-01-11 18:10:10 UTC (rev 139457)
@@ -0,0 +1,2 @@
+PASS: Did not crash.
+


Added: trunk/LayoutTests/svg/custom/use-rebuild-resources-crash.svg (0 => 139457)

--- trunk/LayoutTests/svg/custom/use-rebuild-resources-crash.svg	(rev 0)
+++ trunk/LayoutTests/svg/custom/use-rebuild-resources-crash.svg	2013-01-11 18:10:10 UTC (rev 139457)
@@ -0,0 +1,31 @@
+?xml version=1.0 encoding=iso-8859-1 standalone=no?
+svg id=svg xmlns:xlink=http://www.w3.org/1999/xlink xmlns=http://www.w3.org/2000/svg
+  !-- Test for https://bugs.webkit.org/show_bug.cgi?id=106664 --
+  defs
+symbol id=s1
+  use/
+  rect id=r1/
+/symbol
+
+use id=u1 xlink:href=""
+
+style
+  use { clip-path: url(#r1); }
+/style
+  /defs
+
+  textPASS: Did not crash./text
+
+  script
+function initCF() {
+  u1 = document.getElementById('u1');
+  clone = u1.cloneNode(false);
+  document.getElementById('svg').appendChild(clone);
+}
+
+if (window.testRunner)
+  testRunner.dumpAsText();
+
+document.addEventListener(DOMContentLoaded, initCF, false);
+  /script
+/svg


Modified: trunk/Source/WebCore/ChangeLog (139456 => 139457)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 18:06:57 UTC (rev 139456)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 18:10:10 UTC (rev 139457)
@@ -1,3 +1,24 @@
+2013-01-11  Florin Malita  fmal...@chromium.org
+
+[SVG] Suppress resource rebuilding for unattached and shadow elements
+https://bugs.webkit.org/show_bug.cgi?id=106664
+
+Reviewed by Dirk Schulze.
+
+SVGStyledElement::buildPendingResourcesIfNeeded() can be called while cloning a subtree
+(as nodes are inserted into the clone, while still detached) or when elements are inserted
+into the shadow tree. Both of these cases are problematic for SVGUseElement and can trigger
+indirect recursion in SVGUseElement::buildPendingResource.
+
+Since shadow and !inDocument() nodes are of no interest to ID dependents (they cannot be
+found by ID in the document), the patch short-circuits buildPendingResource() for these
+cases.
+
+Test: svg/custom/use-rebuild-resources-crash.svg
+
+* svg/SVGStyledElement.cpp:
+(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
+
 2013-01-11  Dominic Mazzoni  dmazz...@google.com
 
 AX: Computed hierarchical level is not consistent with aria-level


Modified: trunk/Source/WebCore/svg/SVGStyledElement.cpp (139456 => 139457)

--- trunk/Source/WebCore/svg/SVGStyledElement.cpp	2013-01-11 18:06:57 UTC (rev 139456)
+++ trunk/Source/WebCore/svg/SVGStyledElement.cpp

[webkit-changes] [139458] trunk/Source/WebCore

2013-01-11 Thread haraken

Title: [139458] trunk/Source/WebCore








Revision 139458
Author hara...@chromium.org
Date 2013-01-11 10:37:25 -0800 (Fri, 11 Jan 2013)


Log Message
[V8] Slightly optimize getWrapperFast()
https://bugs.webkit.org/show_bug.cgi?id=106667

Reviewed by Adam Barth.

This patch improves an if condition in getWrapperFast(),
as commented in DOMDataStore.h.

This patch improves performance of div.firstChild from
15.1 ns to 14.0 ns (+7.8%), although I couldn't observe
performance improvement in Dromaeo/dom-traverse.

No tests. No change in behavior.

* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::getWrapperFast):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/DOMDataStore.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139457 => 139458)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 18:10:10 UTC (rev 139457)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 18:37:25 UTC (rev 139458)
@@ -1,3 +1,22 @@
+2013-01-11  Kentaro Hara  hara...@chromium.org
+
+[V8] Slightly optimize getWrapperFast()
+https://bugs.webkit.org/show_bug.cgi?id=106667
+
+Reviewed by Adam Barth.
+
+This patch improves an if condition in getWrapperFast(),
+as commented in DOMDataStore.h.
+
+This patch improves performance of div.firstChild from
+15.1 ns to 14.0 ns (+7.8%), although I couldn't observe
+performance improvement in Dromaeo/dom-traverse.
+
+No tests. No change in behavior.
+
+* bindings/v8/DOMDataStore.h:
+(WebCore::DOMDataStore::getWrapperFast):
+
 2013-01-11  Florin Malita  fmal...@chromium.org
 
 [SVG] Suppress resource rebuilding for unattached and shadow elements


Modified: trunk/Source/WebCore/bindings/v8/DOMDataStore.h (139457 => 139458)

--- trunk/Source/WebCore/bindings/v8/DOMDataStore.h	2013-01-11 18:10:10 UTC (rev 139457)
+++ trunk/Source/WebCore/bindings/v8/DOMDataStore.h	2013-01-11 18:37:25 UTC (rev 139458)
@@ -64,15 +64,18 @@
 templatetypename T, typename HolderContainer, typename Wrappable
 static v8::Handlev8::Object getWrapperFast(T* object, const HolderContainer container, Wrappable* holder)
 {
-// What we'd really like to check here is whether we're in the main world or
-// in an isolated world. The fastest way we know how to do that is to check
-// whether the wrappable's wrapper is the same as the holder
-if (holderContainsWrapper(container, holder)) {
+// What we'd really like to check here is whether we're in the
+// main world or in an isolated world. The fastest way to do that
+// is to check that there is no isolated world and the 'object'
+// is an object that can exist in the main world. The second fastest
+// way is to check whether the wrappable's wrapper is the same as
+// the holder.
+if ((!DOMWrapperWorld::isolatedWorldsExist()  isMainWorldObject(object)) || holderContainsWrapper(container, holder)) {
 if (mainWorldWrapperIsStoredInObject(object))
 return getWrapperFromObject(object);
 return mainWorldStore()-m_wrapperMap.get(object);
 }
-return getWrapper(object, container.GetIsolate());
+return current(container.GetIsolate())-get(object);
 }
 
 templatetypename T






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139461] trunk

2013-01-11 Thread wangxianzhu

Title: [139461] trunk








Revision 139461
Author wangxian...@chromium.org
Date 2013-01-11 10:57:42 -0800 (Fri, 11 Jan 2013)


Log Message
RenderLayerCompositor should let ScrollingCoordinator update main thread scrolling reasons after change of layers
https://bugs.webkit.org/show_bug.cgi?id=105652

Reviewed by Simon Fraser.

Source/WebCore:

Let ScrollingCoordinator know the change of ViewportConstrainedNotCompositedReason in time.
By the way moved RenderLayerCompositor::FixedPositionLayerNotCompositedReason to RenderLayer::ViewportConstrainedNotCompositedReason.

Tests: compositing/layer-creation/fixed-position-in-view-dynamic.html
   compositing/layer-creation/fixed-position-out-of-view-dynamic.html

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects):
(WebCore::ScrollingCoordinator::mainThreadScrollingReasons):
(WebCore::ScrollingCoordinator::mainThreadScrollingReasonsAsText):
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
* page/scrolling/mac/ScrollingCoordinatorMac.h:
(WebCore::ScrollingCoordinatorMac::hasVisibleSlowRepaintViewportConstrainedObjects):
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::logThreadedScrollingMode):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::paintLayer):
* rendering/RenderLayer.h:
(RenderLayer): Moved RenderLayerCompositor::FixedPositionLayerNotCompositedReason to here and renamed it to ViewportConstrainedNotCompositedReason.
(WebCore::RenderLayer::setViewportConstrainedNotCompositedReason):
(WebCore::RenderLayer::viewportConstrainedNotCompositedReason):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::updateBacking): Now updates ViewportConstrainedNotCompositedReason here instead of in computeCompositingRequirements before so that the reason is updated in time.
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::needsToBeComposited):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::reasonForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
(WebCore::RenderLayerCompositor::reportMemoryUsage):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):

LayoutTests:

Tests to ensure mainThreadScrollingReasons are correctly updated after a fixed element is dynamically inserted into the DOM tree.

* compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Added.
* compositing/layer-creation/fixed-position-in-view-dynamic.html: Added.
* compositing/layer-creation/fixed-position-out-of-view-dynamic-expected.txt: Added.
* compositing/layer-creation/fixed-position-out-of-view-dynamic.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h
trunk/Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h
trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.h


Added Paths

trunk/LayoutTests/compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt
trunk/LayoutTests/compositing/layer-creation/fixed-position-in-view-dynamic.html
trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-dynamic-expected.txt
trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-dynamic.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139460 => 139461)

--- trunk/LayoutTests/ChangeLog	2013-01-11 18:39:21 UTC (rev 139460)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 18:57:42 UTC (rev 139461)
@@ -1,3 +1,17 @@
+2013-01-11  Xianzhu Wang  wangxian...@chromium.org
+
+RenderLayerCompositor should let ScrollingCoordinator update main thread scrolling reasons after change of layers
+https://bugs.webkit.org/show_bug.cgi?id=105652
+
+Reviewed by Simon Fraser.
+
+Tests to ensure mainThreadScrollingReasons are correctly updated after a fixed element is dynamically inserted into the DOM tree.
+
+* compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Added.
+* compositing/layer-creation/fixed-position-in-view-dynamic.html: Added.
+* compositing/layer-creation/fixed-position-out-of-view-dynamic-expected.txt: Added.
+* compositing/layer-creation/fixed-position-out-of-view-dynamic.html: Added.
+
 2013-01-11  Kenneth Russell  k...@google.com
 
 [Chromium] WebGL typed array constructor crashes on exception


Added: trunk/LayoutTests/compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt (0 => 139461)

---

[webkit-changes] [139462] branches/chromium/1364

2013-01-11 Thread leviw

Title: [139462] branches/chromium/1364








Revision 139462
Author le...@chromium.org
Date 2013-01-11 10:59:24 -0800 (Fri, 11 Jan 2013)


Log Message
Merge 139346
 ScrollingCoordinator touch event hit rects aren't converted to proper coordinates when in nested views
 https://bugs.webkit.org/show_bug.cgi?id=106383
 
 Reviewed by James Robinson.
 
 Source/WebCore: 
 
 ScrollingCoordinator uses clippedOverflowRectForRepaint(0) to generate the bounds for a renderer's hit
 testing rect. The rect this returns is in the coordinates of its document. This change converts the
 rect to the outermost view's coordinate system using convertToContainingView.
 
 Tests: platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html
 
 * page/scrolling/ScrollingCoordinator.cpp:
 (WebCore::accumulateRendererTouchEventTargetRects):
 
 LayoutTests: 
 
 * platform/chromium/fast/events/touch/resources: Added.
 * platform/chromium/fast/events/touch/resources/frame-with-touch-handler.html: Added.
 * platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt: Added.
 * platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html: Added.
 

TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/11865013

Modified Paths

branches/chromium/1364/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp


Added Paths

branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt
branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html




Diff

Copied: branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt (from rev 139346, trunk/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt) (0 => 139462)

--- branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt	(rev 0)
+++ branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt	2013-01-11 18:59:24 UTC (rev 139462)
@@ -0,0 +1,4 @@
+This test validates that touch hit tests rects are created in the coordinates of the outermost view, not their containing view. This test only works in DumpRenderTree.
+[0]: (60, 110, 50, 50)
+[1]: (420, 170, 50, 50)
+


Copied: branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html (from rev 139346, trunk/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html) (0 => 139462)

--- branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html	(rev 0)
+++ branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html	2013-01-11 18:59:24 UTC (rev 139462)
@@ -0,0 +1,57 @@
+!DOCTYPE html
+html
+head
+style
+#iframe1 {
+	position: absolute;
+	top: 100px;
+	left: 50px;
+	width: 200px;
+	height: 200px;
+}
+#iframe2 {
+	position: absolute;
+	top: 100px;
+	left: 400px;
+	width: 200px;
+	height: 200px;
+}
+/style
+body _onload_=runTest();
+divThis test validates that touch hit tests rects are created in the coordinates of the outermost view, not their containing view.
+This test only works in DumpRenderTree./div
+div id=console/div
+iframe id=iframe1 src=""
+iframe id=iframe2/iframe
+script
+
+var iframeDocument = document.getElementById(iframe2).contentWindow.document;
+iframeDocument.open('text/html', 'replace');
+iframeDocument.write(!DOCTYPE html\nhtmlbodyiframe src="" style=\position: relative; top: 50px;\/iframe/body);
+iframeDocument.close();
+
+function log(msg) {
+	var span = document.createElement(span);
+	document.getElementById(console).appendChild(span);
+span.innerHTML = msg + 'br /';
+}
+
+function sortRects(a, b) {
+	return a.top - b.top;
+}
+
+function runTest() {
+	if (!window.testRunner)
+		return;
+	window.testRunner.dumpAsText();
+
+	rects = window.internals.touchEventTargetClientRects(document);
+	var sortedRects = new Array();
+	for (var i = 0; i  rects.length; ++i)
+		sortedRects[i] = rects[i];
+	sortedRects.sort(sortRects);
+	for (var i = 0; i  rects.length; ++i)
+		log([ + i + ]: ( + sortedRects[i].left + ,  + sortedRects[i].top + ,  + sortedRects[i].width + ,  + sortedRects[i].height + ));
+}
+/script
+/body


Modified: branches/chromium/1364/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp (139461 => 139462)

--- branches/chromium/1364/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp	2013-01-11 18:57:42 UTC (rev 139461)
+++ branches/chromium/1364/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp	2013-01-11 18:59:24 UTC (rev 139462)
@@ -185,9 +185,16 @@
 if (parentRect.isEmpty() || renderer-isFloating() || renderer-isPositioned() || renderer-hasTransform()) {
 // FIXME: This method is O(N^2) as it walks the tree to the root for every renderer. RenderGeometryMap would fix this.
 IntRect r =

[webkit-changes] [139463] trunk/LayoutTests

2013-01-11 Thread leviw

Title: [139463] trunk/LayoutTests








Revision 139463
Author le...@chromium.org
Date 2013-01-11 11:07:46 -0800 (Fri, 11 Jan 2013)


Log Message
Unreviewed gardening. Skipping accessibility/corresponding-control-deleted-crash.html on Mac since
it fails without Shadow DOM enabled.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139462 => 139463)

--- trunk/LayoutTests/ChangeLog	2013-01-11 18:59:24 UTC (rev 139462)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 19:07:46 UTC (rev 139463)
@@ -1,3 +1,10 @@
+2013-01-11  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Skipping accessibility/corresponding-control-deleted-crash.html on Mac since
+it fails without Shadow DOM enabled.
+
+* platform/mac/TestExpectations:
+
 2013-01-11  Xianzhu Wang  wangxian...@chromium.org
 
 RenderLayerCompositor should let ScrollingCoordinator update main thread scrolling reasons after change of layers


Modified: trunk/LayoutTests/platform/mac/TestExpectations (139462 => 139463)

--- trunk/LayoutTests/platform/mac/TestExpectations	2013-01-11 18:59:24 UTC (rev 139462)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-01-11 19:07:46 UTC (rev 139463)
@@ -430,6 +430,7 @@
 fast/dom/shadow
 editing/shadow
 inspector/elements/update-shadowdom.html
+accessibility/corresponding-control-deleted-crash.html
 
 # ENABLE(TEMPLATE_ELEMENT) is disabled.
 fast/dom/HTMLTemplateElement






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139464] trunk/Source/WebKit2

2013-01-11 Thread andersca

Title: [139464] trunk/Source/WebKit2








Revision 139464
Author ander...@apple.com
Date 2013-01-11 11:08:47 -0800 (Fri, 11 Jan 2013)


Log Message
Incoming synchronous messages can sometimes arrive out of order
https://bugs.webkit.org/show_bug.cgi?id=106677
rdar://problem/12889499

Reviewed by Andreas Kling.

In cases where synchronous messages come in more than one connection at the same time, we can sometimes deliver
the synchronous messages before any pending asynchronous messages on that connection. This breaks FIFO ordering.

Fix this by separating the dispatch all incoming synchronous messages phase out into multiple phases, so we'll
schedule one call per connection instead of one call for all connections.

* Platform/CoreIPC/Connection.cpp:
(Connection::SyncMessageState):
(CoreIPC::Connection::SyncMessageState::SyncMessageState):
(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
(CoreIPC::Connection::SyncMessageState::dispatchMessages):
(CoreIPC::Connection::SyncMessageState::dispatchMessageAndResetDidScheduleDispatchMessagesForConnection):
(CoreIPC::Connection::waitForSyncReply):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139463 => 139464)

--- trunk/Source/WebKit2/ChangeLog	2013-01-11 19:07:46 UTC (rev 139463)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-11 19:08:47 UTC (rev 139464)
@@ -1,3 +1,25 @@
+2013-01-11  Anders Carlsson  ander...@apple.com
+
+Incoming synchronous messages can sometimes arrive out of order
+https://bugs.webkit.org/show_bug.cgi?id=106677
+rdar://problem/12889499
+
+Reviewed by Andreas Kling.
+
+In cases where synchronous messages come in more than one connection at the same time, we can sometimes deliver
+the synchronous messages before any pending asynchronous messages on that connection. This breaks FIFO ordering.
+
+Fix this by separating the dispatch all incoming synchronous messages phase out into multiple phases, so we'll
+schedule one call per connection instead of one call for all connections.
+
+* Platform/CoreIPC/Connection.cpp:
+(Connection::SyncMessageState):
+(CoreIPC::Connection::SyncMessageState::SyncMessageState):
+(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
+(CoreIPC::Connection::SyncMessageState::dispatchMessages):
+(CoreIPC::Connection::SyncMessageState::dispatchMessageAndResetDidScheduleDispatchMessagesForConnection):
+(CoreIPC::Connection::waitForSyncReply):
+
 2013-01-11  Zan Dobersek  zandober...@gmail.com
 
 Unreviewed. Build fix for the GTK debug builds of WebKit2 after r139415.


Modified: trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp (139463 => 139464)

--- trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp	2013-01-11 19:07:46 UTC (rev 139463)
+++ trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp	2013-01-11 19:08:47 UTC (rev 139464)
@@ -30,6 +30,7 @@
 #include CoreIPCMessageKinds.h
 #include WebCore/RunLoop.h
 #include wtf/CurrentTime.h
+#include wtf/HashSet.h
 
 using namespace WebCore;
 
@@ -54,7 +55,9 @@
 // waiting for a reply to a synchronous message.
 bool processIncomingMessage(Connection*, IncomingMessage);
 
-void dispatchMessages();
+// Dispatch pending sync messages. if allowedConnection is not null, will only dispatch messages
+// from that connection and put the other messages back in the queue.
+void dispatchMessages(Connection* allowedConnection);
 
 private:
 explicit SyncMessageState(RunLoop*);
@@ -72,15 +75,16 @@
 return syncMessageStateMapMutex;
 }
 
-void dispatchMessageAndResetDidScheduleDispatchMessagesWork();
+void dispatchMessageAndResetDidScheduleDispatchMessagesForConnection(Connection*);
 
 RunLoop* m_runLoop;
 BinarySemaphore m_waitForSyncReplySemaphore;
 
-// Protects m_didScheduleDispatchMessagesWork and m_messagesToDispatchWhileWaitingForSyncReply.
+// Protects m_didScheduleDispatchMessagesWorkSet and m_messagesToDispatchWhileWaitingForSyncReply.
 Mutex m_mutex;
 
-bool m_didScheduleDispatchMessagesWork;
+// The set of connections for which we've scheduled a call to dispatchMessageAndResetDidScheduleDispatchMessagesForConnection.
+HashSetRefPtrConnection  m_didScheduleDispatchMessagesWorkSet;
 
 struct ConnectionAndIncomingMessage {
 RefPtrConnection connection;
@@ -107,7 +111,6 @@
 
 Connection::SyncMessageState::SyncMessageState(RunLoop* runLoop)
 : m_runLoop(runLoop)
-, m_didScheduleDispatchMessagesWork(false)
 {
 }
 
@@ -132,10 +135,8 @@
 {
 MutexLocker locker(m_mutex);
 
-if (!m_didScheduleDispatchMessagesWork) {
-m_runLoop-dispatch(WTF::bind(SyncMessageState::dispatchMessageAndResetDidScheduleDispatchMessagesWork, this));
-m_didScheduleDispatchMessagesWork = true;
-}
+

[webkit-changes] [139465] trunk/Source/WebCore

2013-01-11 Thread carlosgc

Title: [139465] trunk/Source/WebCore








Revision 139465
Author carlo...@webkit.org
Date 2013-01-11 11:11:12 -0800 (Fri, 11 Jan 2013)


Log Message
Unreviewed. Fix make distcheck.

* GNUmakefile.list.am: Add missing header files.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am




Diff

Modified: trunk/Source/WebCore/ChangeLog (139464 => 139465)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 19:08:47 UTC (rev 139464)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 19:11:12 UTC (rev 139465)
@@ -1,3 +1,9 @@
+2013-01-11  Carlos Garcia Campos  cgar...@igalia.com
+
+Unreviewed. Fix make distcheck.
+
+* GNUmakefile.list.am: Add missing header files.
+
 2013-01-11  Xianzhu Wang  wangxian...@chromium.org
 
 RenderLayerCompositor should let ScrollingCoordinator update main thread scrolling reasons after change of layers


Modified: trunk/Source/WebCore/GNUmakefile.list.am (139464 => 139465)

--- trunk/Source/WebCore/GNUmakefile.list.am	2013-01-11 19:08:47 UTC (rev 139464)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2013-01-11 19:11:12 UTC (rev 139465)
@@ -1993,7 +1993,7 @@
 	Source/WebCore/Modules/notifications/NotificationPermissionCallback.h \
 	Source/WebCore/Modules/notifications/WorkerContextNotifications.cpp \
 	Source/WebCore/Modules/notifications/WorkerContextNotifications.h \
-	Source/WebCore/Modules/proximity/DeviceProximity.h \
+	Source/WebCore/Modules/proximity/DeviceProximityClient.h \
 	Source/WebCore/Modules/proximity/DeviceProximityController.cpp \
 	Source/WebCore/Modules/proximity/DeviceProximityController.h \
 	Source/WebCore/Modules/proximity/DeviceProximityEvent.cpp \
@@ -2703,6 +2703,7 @@
 	Source/WebCore/dom/Attr.cpp \
 	Source/WebCore/dom/Attr.h \
 	Source/WebCore/dom/Attribute.h \
+	Source/WebCore/dom/AutocompleteErrorEvent.h \
 	Source/WebCore/dom/BeforeLoadEvent.h \
 	Source/WebCore/dom/BeforeTextInsertedEvent.cpp \
 	Source/WebCore/dom/BeforeTextInsertedEvent.h \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139466] trunk

2013-01-11 Thread carlosgc

Title: [139466] trunk








Revision 139466
Author carlo...@webkit.org
Date 2013-01-11 11:14:25 -0800 (Fri, 11 Jan 2013)


Log Message
Unreviewed. Update NEWS and configure.ac for 1.11.4 release

.:

* configure.ac: Bump version numbers.

Source/WebKit/gtk:

* NEWS: Added release notes for 1.11.4.

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/NEWS
trunk/configure.ac




Diff

Modified: trunk/ChangeLog (139465 => 139466)

--- trunk/ChangeLog	2013-01-11 19:11:12 UTC (rev 139465)
+++ trunk/ChangeLog	2013-01-11 19:14:25 UTC (rev 139466)
@@ -1,3 +1,9 @@
+2013-01-11  Carlos Garcia Campos  cgar...@igalia.com
+
+Unreviewed. Update NEWS and configure.ac for 1.11.4 release
+
+* configure.ac: Bump version numbers.
+
 2013-01-10  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Add API to set the web extensions directory to WebKit2 GTK+


Modified: trunk/Source/WebKit/gtk/ChangeLog (139465 => 139466)

--- trunk/Source/WebKit/gtk/ChangeLog	2013-01-11 19:11:12 UTC (rev 139465)
+++ trunk/Source/WebKit/gtk/ChangeLog	2013-01-11 19:14:25 UTC (rev 139466)
@@ -1,3 +1,9 @@
+2013-01-11  Carlos Garcia Campos  cgar...@igalia.com
+
+Unreviewed. Update NEWS and configure.ac for 1.11.4 release
+
+* NEWS: Added release notes for 1.11.4.
+
 2013-01-08  Mark Lam  mark@apple.com
 
 Removed the need for the ProposedDatabase mechanism.


Modified: trunk/Source/WebKit/gtk/NEWS (139465 => 139466)

--- trunk/Source/WebKit/gtk/NEWS	2013-01-11 19:11:12 UTC (rev 139465)
+++ trunk/Source/WebKit/gtk/NEWS	2013-01-11 19:14:25 UTC (rev 139466)
@@ -1,4 +1,36 @@
 =
+WebKitGTK+ 1.11.4
+=
+
+What's new in WebKitGTK+ 1.11.4?
+
+  - Add support for loading web process extensions to WebKit2 GTK+.
+  - Embed the HTTP authentication dialog into the WebView in WebKit2.
+  - Add support for IME Composition to WebKit2.
+  - Add API to notify about display/execution of insecure content to
+WebKit2 GTK+ API.
+  - Add GTK+ API to set a WebKitWebView in view source mode to WebKit2.
+  - Add API to set a TLS errors policy to WebKit2 GTK+ API.
+  - Add WEBKIT_HIT_TEST_RESULT_CONTEXT_SCROLLBAR to WebKit2 GTK+ API.
+  - Add support for remote Web Inspector to WebKit2.
+  - Complete the documentation od sections in WebKit2 GTK+ API.
+  - Fix cookies and custom URI requests when the web process is
+re-launched after a crash.
+  - Fix a crash in WebKit2 when running inside Xvfb.
+  - Fix a crash in WebKit2 when the WebView is resized with the
+inspector attached.
+  - Use Harfbuzz instead of Pango in GTK+ port.
+  - Add support for WebP image.
+  - Port WebAudio backend to GStreamer 1.0 API.
+  - Fix the buffering ranges reported with GStreamer 1.0.
+  - Implement multipart/x-mixed-replace in the soup network backend.
+  - Fix invalid entries for plugins in navigator.plugins.
+  - Add implementation for AccessibilityUIElementGtk::isSelectable()
+and AccessibilityUIElementGtk::isMultiSelectable().
+  - Expose ARIA roles for tab, tabpanel and tablist.
+  - Fixed several memory leaks.
+
+=
 WebKitGTK+ 1.11.2
 =
 


Modified: trunk/configure.ac (139465 => 139466)

--- trunk/configure.ac	2013-01-11 19:11:12 UTC (rev 139465)
+++ trunk/configure.ac	2013-01-11 19:14:25 UTC (rev 139466)
@@ -2,14 +2,14 @@
 
 m4_define([webkit_major_version], [1])
 m4_define([webkit_minor_version], [11])
-m4_define([webkit_micro_version], [2])
+m4_define([webkit_micro_version], [4])
 
 # This is the version we'll be using as part of our User-Agent string
 # e.g., AppleWebKit/$(webkit_user_agent_version) ...
 #
 # Sourced from Source/WebCore/Configurations/Version.xcconfig
 m4_define([webkit_user_agent_major_version], [537])
-m4_define([webkit_user_agent_minor_version], [20])
+m4_define([webkit_user_agent_minor_version], [26])
 
 AC_INIT([WebKitGTK],[webkit_major_version.webkit_minor_version.webkit_micro_version],[http://bugs.webkit.org/])
 
@@ -35,13 +35,13 @@
 
 dnl # Libtool library version, not to confuse with API version
 dnl # see http://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html
-LIBWEBKITGTK_VERSION=17:1:17
+LIBWEBKITGTK_VERSION=18:0:18
 AC_SUBST([LIBWEBKITGTK_VERSION])
 
-LIBJAVASCRIPTCOREGTK_VERSION=13:7:13
+LIBJAVASCRIPTCOREGTK_VERSION=13:8:13
 AC_SUBST([LIBJAVASCRIPTCOREGTK_VERSION])
 
-LIBWEBKIT2GTK_VERSION=19:0:19
+LIBWEBKIT2GTK_VERSION=20:0:20
 AC_SUBST([LIBWEBKIT2GTK_VERSION])
 
 AM_INIT_AUTOMAKE([foreign subdir-objects dist-xz no-dist-gzip tar-ustar])






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139468] trunk/LayoutTests

2013-01-11 Thread leviw

Title: [139468] trunk/LayoutTests








Revision 139468
Author le...@chromium.org
Date 2013-01-11 11:21:55 -0800 (Fri, 11 Jan 2013)


Log Message
Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/hidpi/image-set-background-dynamic.html
as slow on Debug builds.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139467 => 139468)

--- trunk/LayoutTests/ChangeLog	2013-01-11 19:20:16 UTC (rev 139467)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 19:21:55 UTC (rev 139468)
@@ -1,3 +1,10 @@
+2013-01-11  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/hidpi/image-set-background-dynamic.html
+as slow on Debug builds.
+
+* platform/chromium/TestExpectations:
+
 2013-01-11  Stephen Chenney  schen...@chromium.org
 
 [ Chromium ] New Mac rebaselines (some)


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139467 => 139468)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-11 19:20:16 UTC (rev 139467)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-11 19:21:55 UTC (rev 139468)
@@ -93,6 +93,7 @@
 webkit.org/b/103744 svg/dom/viewspec-parser-6.html [ Pass Timeout ]
 crbug.com/24182 [ Debug ] platform/chromium/inspector/styles/device-metrics-fit-window.html [ Pass Slow ]
 webkit.org/b/105785 [ Release ] http/tests/inspector/indexeddb [ Pass Slow ]
+crbug.com/24182 [ Debug ] platform/chromium/virtual/gpu/fast/hidpi/image-set-background-dynamic.html [ Pass Slow ]
 
 # These tests started being slow when we switched to DRT.
 webkit.org/b/90488 [ Debug ] inspector [ Pass Slow ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139469] trunk/Source/WebCore

2013-01-11 Thread haraken

Title: [139469] trunk/Source/WebCore








Revision 139469
Author hara...@chromium.org
Date 2013-01-11 11:27:39 -0800 (Fri, 11 Jan 2013)


Log Message
[V8] Do not create a local handle for a cached v8 string that is returned to V8 immediately
https://bugs.webkit.org/show_bug.cgi?id=106557

Reviewed by Adam Barth.

Currently we are always creating a local handle for a cached
V8 string returned to V8:

  HandleValue v8String(StringImpl* impl, Isolate* isolate) {
...;
return LocalString::New(isolate, m_cachedString);
  }

However, we don't need to create a local handle in a case
where it is guaranteed that no V8 object allocation is conducted
before a control flow returns back to V8. In particular, in a case
where a cached V8 string is immediately returned to V8, we don't
need to create a local handle:

  HandleValue AttrGetter() {
...;
return v8String(imp-(), isolate);  // This can return a persistent handle safely.
  }

This patch improves performance of div.id by 9.2%.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateCallbackImplementation):
(GenerateFunctionCallString):
(NativeToJSValue):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::TestExceptionV8Internal::nameAttrGetter):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):
* bindings/v8/V8Binding.h:
(WebCore::v8String):
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):
* bindings/v8/V8ValueCache.cpp:
(WebCore::StringCache::v8ExternalStringSlow):
* bindings/v8/V8ValueCache.h:
(WebCore::StringCache::v8ExternalString):
(StringCache):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.h
trunk/Source/WebCore/bindings/v8/V8ValueCache.cpp
trunk/Source/WebCore/bindings/v8/V8ValueCache.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139468 => 139469)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 19:21:55 UTC (rev 139468)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 19:27:39 UTC (rev 139469)
@@ -1,3 +1,68 @@
+2013-01-11  Kentaro Hara  hara...@chromium.org
+
+[V8] Do not create a local handle for a cached v8 string that is returned to V8 immediately
+https://bugs.webkit.org/show_bug.cgi?id=106557
+
+Reviewed by Adam Barth.
+
+Currently we are always creating a local handle for a cached
+V8 string returned to V8:
+
+  HandleValue v8String(StringImpl* impl, Isolate* isolate) {
+...;
+return LocalString::New(isolate, m_cachedString);
+  }
+
+However, we don't need to create a local handle in a case
+where it is guaranteed that no V8 object allocation is conducted
+before a control flow returns back to V8. In particular, in a case
+where a cached V8 string is immediately returned to V8, we don't
+need to create a local handle:
+
+  HandleValue AttrGetter() {
+...;
+return v8String(imp-(), isolate);  // This can return a persistent handle safely.
+  }
+
+This patch improves performance of div.id by 9.2%.
+
+No tests. No change in behavior.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateNormalAttrGetter):
+(GenerateCallbackImplementation):
+(GenerateFunctionCallString):
+(NativeToJSValue):
+* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
+(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
+(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
+* bindings/scripts/test/V8/V8TestException.cpp:
+

[webkit-changes] [139470] trunk/Source/WebCore

2013-01-11 Thread inferno

Title: [139470] trunk/Source/WebCore








Revision 139470
Author infe...@chromium.org
Date 2013-01-11 11:35:31 -0800 (Fri, 11 Jan 2013)


Log Message
Heap-use-after-free in WebCore::RenderText::computePreferredLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=95901

Reviewed by Simon Fraser.

Prevent re-entrancy of view layout. Loading of SVG document during font load
causes it to re-enter layout and blowing the style away from underneath.

Test: Go to http://www.speckproducts.com and make sure crash does not happen.

* dom/Document.cpp:
(WebCore::Document::updateLayout):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139469 => 139470)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 19:27:39 UTC (rev 139469)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 19:35:31 UTC (rev 139470)
@@ -1,3 +1,18 @@
+2013-01-11  Abhishek Arya  infe...@chromium.org
+
+Heap-use-after-free in WebCore::RenderText::computePreferredLogicalWidths
+https://bugs.webkit.org/show_bug.cgi?id=95901
+
+Reviewed by Simon Fraser.
+
+Prevent re-entrancy of view layout. Loading of SVG document during font load
+causes it to re-enter layout and blowing the style away from underneath.
+
+Test: Go to http://www.speckproducts.com and make sure crash does not happen.
+
+* dom/Document.cpp:
+(WebCore::Document::updateLayout):
+
 2013-01-11  Kentaro Hara  hara...@chromium.org
 
 [V8] Do not create a local handle for a cached v8 string that is returned to V8 immediately


Modified: trunk/Source/WebCore/dom/Document.cpp (139469 => 139470)

--- trunk/Source/WebCore/dom/Document.cpp	2013-01-11 19:27:39 UTC (rev 139469)
+++ trunk/Source/WebCore/dom/Document.cpp	2013-01-11 19:35:31 UTC (rev 139470)
@@ -1899,16 +1899,24 @@
 void Document::updateLayout()
 {
 ASSERT(isMainThread());
+
+FrameView* frameView = view();
+if (frameView  frameView-isInLayout()) {
+// View layout should not be re-entrant.
+ASSERT_NOT_REACHED();
+return;
+}
+
 if (Element* oe = ownerElement())
 oe-document()-updateLayout();
 
 updateStyleIfNeeded();
 
 StackStats::LayoutCheckPoint layoutCheckPoint;
+
 // Only do a layout if changes have occurred that make it necessary.  
-FrameView* v = view();
-if (v  renderer()  (v-layoutPending() || renderer()-needsLayout()))
-v-layout();
+if (frameView  renderer()  (frameView-layoutPending() || renderer()-needsLayout()))
+frameView-layout();
 }
 
 // FIXME: This is a bad idea and needs to be removed eventually.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139471] trunk/Tools

2013-01-11 Thread jparent

Title: [139471] trunk/Tools








Revision 139471
Author jpar...@chromium.org
Date 2013-01-11 11:39:34 -0800 (Fri, 11 Jan 2013)


Log Message
Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
https://bugs.webkit.org/show_bug.cgi?id=106247

Old code nulled out the loader instance when it completed loading and
then later used the fact that it was null to determine if it had loaded
or not.  This is not only unintuitive, but it also prevents using the
loader object later on.

Added new method, used it, added unit test for it.

Reviewed by Dirk Pranke.

* TestResultServer/static-dashboards/dashboard_base.js:
(resourceLoadingComplete):
(handleLocationChange):
* TestResultServer/static-dashboards/loader.js:
(.):
* TestResultServer/static-dashboards/loader_unittests.js:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js
trunk/Tools/TestResultServer/static-dashboards/loader.js
trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js




Diff

Modified: trunk/Tools/ChangeLog (139470 => 139471)

--- trunk/Tools/ChangeLog	2013-01-11 19:35:31 UTC (rev 139470)
+++ trunk/Tools/ChangeLog	2013-01-11 19:39:34 UTC (rev 139471)
@@ -1,3 +1,24 @@
+2013-01-11  Julie Parent  jpar...@chromium.org
+
+Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
+https://bugs.webkit.org/show_bug.cgi?id=106247
+
+Old code nulled out the loader instance when it completed loading and
+then later used the fact that it was null to determine if it had loaded
+or not.  This is not only unintuitive, but it also prevents using the
+loader object later on.
+
+Added new method, used it, added unit test for it.
+
+Reviewed by Dirk Pranke.
+
+* TestResultServer/static-dashboards/dashboard_base.js:
+(resourceLoadingComplete):
+(handleLocationChange):
+* TestResultServer/static-dashboards/loader.js:
+(.):
+* TestResultServer/static-dashboards/loader_unittests.js:
+
 2013-01-11  Ryosuke Niwa  rn...@webkit.org
 
 Try CRLF to LF change in r139407 again.


Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (139470 => 139471)

--- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js	2013-01-11 19:35:31 UTC (rev 139470)
+++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js	2013-01-11 19:39:34 UTC (rev 139471)
@@ -500,8 +500,6 @@
 
 function resourceLoadingComplete(errorMsgs)
 {
-g_resourceLoader = null;
-
 if (errorMsgs)
 addError(errorMsgs)
 
@@ -510,7 +508,7 @@
 
 function handleLocationChange()
 {
-if (g_resourceLoader)
+if (!g_resourceLoader.isLoadingComplete())
 return;
 
 if (parseParameters())


Modified: trunk/Tools/TestResultServer/static-dashboards/loader.js (139470 => 139471)

--- trunk/Tools/TestResultServer/static-dashboards/loader.js	2013-01-11 19:35:31 UTC (rev 139470)
+++ trunk/Tools/TestResultServer/static-dashboards/loader.js	2013-01-11 19:39:34 UTC (rev 139471)
@@ -67,6 +67,7 @@
 
 this._buildersThatFailedToLoad = [];
 this._staleBuilders = [];
+this._loadingComplete = false;
 }
 
 loader.Loader.prototype = {
@@ -74,10 +75,18 @@
 {
 this._loadNext();
 },
+isLoadingComplete: function()
+{
+return this._loadingComplete;
+},
 _loadNext: function()
 {
 var loadingStep = this._loadingSteps.shift();
 if (!loadingStep) {
+this._loadingComplete = true;
+// FIXME(jparent): Loader should not know about global
+// functions, should use a callback or dispatch load
+// event instead.
 resourceLoadingComplete(this._getLoadingErrorMessages());
 return;
 }


Modified: trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js (139470 => 139471)

--- trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js	2013-01-11 19:35:31 UTC (rev 139470)
+++ trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js	2013-01-11 19:39:34 UTC (rev 139471)
@@ -153,4 +153,14 @@
 resourceLoader._buildersThatFailedToLoad = ['builder1', 'builder2'];
 resourceLoader._staleBuilders = ['staleBuilder1'];
 equal(resourceLoader._getLoadingErrorMessages(), 'ERROR: Failed to get data from builder1,builder2.brERROR: Data from staleBuilder1 is more than 1 day stale.br');
+});
+
+test('Loaded state set', 2, function() {
+resetGlobals();
+  
+var resourceLoader = new loader.Loader();
+equal(false, resourceLoader.isLoadingComplete(), 'Before loading, loading is not complete');
+resourceLoader._loadingSteps = [];
+resourceLoader.load();
+equal(true, resourceLoader.isLoadingComplete(), 'After loading, loading is complete');
 });
\ No newline at end of file






___
webkit-changes mailing list

[webkit-changes] [139473] branches/chromium/1364

2013-01-11 Thread kerz

Title: [139473] branches/chromium/1364








Revision 139473
Author k...@chromium.org
Date 2013-01-11 11:43:49 -0800 (Fri, 11 Jan 2013)


Log Message
Merge 138111
 Text Autosizing: containers wider than their enclosing clusters should be autosized as separate clusters
 https://bugs.webkit.org/show_bug.cgi?id=103627
 
 Patch by Anton Vayvod avay...@chromium.org on 2012-12-18
 Reviewed by Julien Chaffraix.
 
 Source/WebCore:
 
 Some blocks of texts might be wider than their parent clusters and need to be autosized separately.
 
 isAutosizingCluster() now checks for the width of the container being greater than the width of the lowest
 common ancestor of the text nodes of the enclosing cluster. This block containing all text is passed to all
 tree traversal methods.
 An overloaded version is added for cases when we don't have the lowest common ancestor yet.
 
 The change fixes several cases covered by existing tests.
 
 * rendering/TextAutosizer.cpp:
 (WebCore::TextAutosizer::processSubtree):
 
 Calls processCluster with a new number of arguments.
 
 (WebCore::TextAutosizer::processCluster):
 
 Passes block containing all text nodes into processContainer. Assertion removed since it can no longer be
 checked without passing an additional parameter (the parent block containing all text) to the function
 for the sake of this assertion only.
 
 (WebCore::TextAutosizer::processContainer):
 
 |parentBlockContainingAllText| parameter passed into isAutosizingCluster.
 
 (WebCore::TextAutosizer::isAutosizingCluster(const RenderBlock*, const RenderBlock*)):
 
 The overloaded method that is used when the render block checked is already known to be an autosizing
 container and there's full information necessary to determine if it's a cluster like the parent block
 containing all text within the enclosing cluster.
 Considers a block a cluster if it is wider than its parent block containing all text within enclosing
 cluster.
 
 (WebCore::TextAutosizer::isAutosizingCluster(const RenderObject*)):
 
 The overloaded method that checks for the given object to be an autosizing container first (for
 convenience of the caller) and doesn't require information about the parent cluster. Used when such
 information is not available, for example, in the process of retrieving the information for the parent
 cluster or when looking for the root cluster in the tree.
 
 (WebCore::TextAutosizer::clusterShouldBeAutosized):
 
 Passes new parameter to measureDescendantTextWidth.
 
 (WebCore::TextAutosizer::measureDescendantTextWidth):
 
 Uses blockContainingAllText parameter to pass to isAutosizingCluster.
 
 (WebCore::TextAutosizer::findDeepestBlockContainingAllText):
 
 Assertion removed since it can no longer be checked without passing an additional parameter (the
 parent block containing all text) to the function for the sake of this assertion only.
 
 (WebCore::TextAutosizer::findFirstTextLeafNotInCluster):
 Uses shorter isAutosizingCluster call.
 
 LayoutTests:
 
 Modified existing tests to reflect the new autosizing approach to handling of the elements that are
 wider than the lowest common ancestor of the text nodes of the enclosing autosizing cluster.
 
 * fast/text-autosizing/cluster-wide-in-narrow-expected.html:
 * fast/text-autosizing/cluster-wide-in-narrow.html:
 * fast/text-autosizing/wide-child-expected.html:
 * fast/text-autosizing/wide-child.html:
 * fast/text-autosizing/wide-in-narrow-overflow-scroll-expected.html:
 * fast/text-autosizing/wide-in-narrow-overflow-scroll.html:

TBR=commit-qu...@webkit.org
Review URL: https://codereview.chromium.org/11859014

Modified Paths

branches/chromium/1364/LayoutTests/ChangeLog
branches/chromium/1364/LayoutTests/fast/text-autosizing/cluster-wide-in-narrow-expected.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/cluster-wide-in-narrow.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/wide-child-expected.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/wide-child.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/wide-in-narrow-overflow-scroll-expected.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/wide-in-narrow-overflow-scroll.html
branches/chromium/1364/Source/WebCore/ChangeLog
branches/chromium/1364/Source/WebCore/rendering/TextAutosizer.cpp
branches/chromium/1364/Source/WebCore/rendering/TextAutosizer.h




Diff

Modified: branches/chromium/1364/LayoutTests/ChangeLog (139472 => 139473)

--- branches/chromium/1364/LayoutTests/ChangeLog	2013-01-11 19:41:17 UTC (rev 139472)
+++ branches/chromium/1364/LayoutTests/ChangeLog	2013-01-11 19:43:49 UTC (rev 139473)
@@ -1,5 +1,22 @@
-2012-12-21  Keishi Hattori  kei...@webkit.org
+2012-12-18  Anton Vayvod  avay...@chromium.org
 
+Text Autosizing: containers wider than their enclosing clusters should be autosized as separate clusters
+https://bugs.webkit.org/show_bug.cgi?id=103627
+
+

[webkit-changes] [139474] branches/chromium/1364

2013-01-11 Thread kerz

Title: [139474] branches/chromium/1364








Revision 139474
Author k...@chromium.org
Date 2013-01-11 11:45:41 -0800 (Fri, 11 Jan 2013)


Log Message
Merge 139435
 Text Autosizing - elements much narrower than its parent autosizing clusters should be autosized separately.
 https://bugs.webkit.org/show_bug.cgi?id=105188
 
 Patch by Anton Vayvod avay...@chromium.org on 2013-01-11
 Reviewed by Kenneth Rohde Christiansen.
 
 Source/WebCore:
 
 Some blocks of text might be narrower than their parent clusters and should be autosized separately.
 This helps with autosizing for the pages implementing the sidebars as a narrow blocks of text with wide margins and
 the main content being positioned atop this margin (or vice versa).
 
 * rendering/TextAutosizer.cpp:
 (WebCore::TextAutosizer::isContainerAutosizingCluster):
 
 Returns true if the container is more than 200 pixels narrower than its parent cluster's lowest common
 ancestor of all the text nodes.
 
 LayoutTests:
 
 Checked that a narrow autosizing container becomes an autosizing cluster.
 Fixed other tests that used narrow descendant blocks.
 
 * fast/text-autosizing/cluster-narrow-in-wide-expected.html:
 * fast/text-autosizing/cluster-narrow-in-wide-ohidden-expected.html:
 * fast/text-autosizing/cluster-narrow-in-wide-ohidden.html:
 * fast/text-autosizing/cluster-narrow-in-wide.html:
 * fast/text-autosizing/cluster-with-wide-lca-expected.html:
 * fast/text-autosizing/cluster-with-wide-lca.html:
 * fast/text-autosizing/narrow-child-expected.html:
 * fast/text-autosizing/narrow-child.html:

TBR=commit-qu...@webkit.org
Review URL: https://codereview.chromium.org/11864024

Modified Paths

branches/chromium/1364/LayoutTests/ChangeLog
branches/chromium/1364/LayoutTests/fast/text-autosizing/cluster-narrow-in-wide-expected.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/cluster-narrow-in-wide-ohidden-expected.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/cluster-narrow-in-wide-ohidden.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/cluster-narrow-in-wide.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/cluster-with-wide-lca-expected.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/cluster-with-wide-lca.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/narrow-child-expected.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/narrow-child.html
branches/chromium/1364/Source/WebCore/ChangeLog
branches/chromium/1364/Source/WebCore/rendering/TextAutosizer.cpp




Diff

Modified: branches/chromium/1364/LayoutTests/ChangeLog (139473 => 139474)

--- branches/chromium/1364/LayoutTests/ChangeLog	2013-01-11 19:43:49 UTC (rev 139473)
+++ branches/chromium/1364/LayoutTests/ChangeLog	2013-01-11 19:45:41 UTC (rev 139474)
@@ -1,5 +1,24 @@
-2012-12-18  Anton Vayvod  avay...@chromium.org
+2013-01-11  Anton Vayvod  avay...@chromium.org
 
+Text Autosizing - elements much narrower than its parent autosizing clusters should be autosized separately.
+https://bugs.webkit.org/show_bug.cgi?id=105188
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Checked that a narrow autosizing container becomes an autosizing cluster.
+Fixed other tests that used narrow descendant blocks.
+
+* fast/text-autosizing/cluster-narrow-in-wide-expected.html:
+* fast/text-autosizing/cluster-narrow-in-wide-ohidden-expected.html:
+* fast/text-autosizing/cluster-narrow-in-wide-ohidden.html:
+* fast/text-autosizing/cluster-narrow-in-wide.html:
+* fast/text-autosizing/cluster-with-wide-lca-expected.html:
+* fast/text-autosizing/cluster-with-wide-lca.html:
+* fast/text-autosizing/narrow-child-expected.html:
+* fast/text-autosizing/narrow-child.html:
+
+2013-01-11  Antoine Quint  grao...@apple.com
+
 Text Autosizing: containers wider than their enclosing clusters should be autosized as separate clusters
 https://bugs.webkit.org/show_bug.cgi?id=103627
 


Modified: branches/chromium/1364/LayoutTests/fast/text-autosizing/cluster-narrow-in-wide-expected.html (139473 => 139474)

--- branches/chromium/1364/LayoutTests/fast/text-autosizing/cluster-narrow-in-wide-expected.html	2013-01-11 19:43:49 UTC (rev 139473)
+++ branches/chromium/1364/LayoutTests/fast/text-autosizing/cluster-narrow-in-wide-expected.html	2013-01-11 19:45:41 UTC (rev 139474)
@@ -11,14 +11,20 @@
 /head
 body
 
-div style=width: 400px; float: left; font-size: 1.25rem
-This text should be autosized to just 20px computed font size (16 * 400/320), since the float:left causes this to be a new cluster, and it is only 400px wide.
+div style=width: 600px; float: left; font-size: 1.875rem
+This text should be autosized to just 30px computed font size (16 * 600/320), since the float:left causes this to be a new cluster, and it is only 600px wide.
 /div
 
-div style=width: 320px; font-size: 2.5rem
-This text should be autosized to 40px computed

[webkit-changes] [139476] branches/chromium/1364

2013-01-11 Thread kerz

Title: [139476] branches/chromium/1364








Revision 139476
Author k...@chromium.org
Date 2013-01-11 11:49:31 -0800 (Fri, 11 Jan 2013)


Log Message
Merge 138162
 Text Autosizing: Work out what to do about form controls
 https://bugs.webkit.org/show_bug.cgi?id=102560
 
 Patch by Tim Volodine timvolod...@chromium.org on 2012-12-19
 Reviewed by Kenneth Rohde Christiansen.
 
 Source/WebCore:
 
 Disallow autosizing of form input controls like buttons, text input fields, selection controls, radio buttons
 and check boxes. This is a short term solution to avoid inconsistent autosizing of form controls (which is
 worse than not autosizing at all).
 
 Tests: fast/text-autosizing/form-controls-autosizing-button-input-elements.html
fast/text-autosizing/form-controls-autosizing-checkbox-input-element.html
fast/text-autosizing/form-controls-autosizing-radio-input-element.html
fast/text-autosizing/form-controls-autosizing-select-element.html
fast/text-autosizing/form-controls-autosizing-textfield-input-elements.html
 
 * rendering/TextAutosizer.cpp:
 (WebCore):
 (WebCore::formInputTags):
 (WebCore::TextAutosizer::isAutosizingContainer):
 (WebCore::TextAutosizer::contentHeightIsConstrained):
 (WebCore::TextAutosizer::containerShouldBeAutosized):
 (WebCore::TextAutosizer::containerContainsOneOfTags):
 * rendering/TextAutosizer.h:
 
 LayoutTests:
 
 Tests for form input elements autosizing. Added tests to check that various kinds of form elements
 don't get autosized, i.e. buttons, textareas, check boxes, radio button and selection menus.
 
 * fast/text-autosizing/form-controls-autosizing-button-input-elements-expected.html: Added.
 * fast/text-autosizing/form-controls-autosizing-button-input-elements.html: Added.
 * fast/text-autosizing/form-controls-autosizing-checkbox-input-element-expected.html: Added.
 * fast/text-autosizing/form-controls-autosizing-checkbox-input-element.html: Added.
 * fast/text-autosizing/form-controls-autosizing-radio-input-element-expected.html: Added.
 * fast/text-autosizing/form-controls-autosizing-radio-input-element.html: Added.
 * fast/text-autosizing/form-controls-autosizing-select-element-expected.html: Added.
 * fast/text-autosizing/form-controls-autosizing-select-element.html: Added.
 * fast/text-autosizing/form-controls-autosizing-textfield-input-elements-expected.html: Added.
 * fast/text-autosizing/form-controls-autosizing-textfield-input-elements.html: Added.

TBR=commit-qu...@webkit.org
Review URL: https://codereview.chromium.org/11858022

Modified Paths

branches/chromium/1364/LayoutTests/ChangeLog
branches/chromium/1364/Source/WebCore/ChangeLog
branches/chromium/1364/Source/WebCore/rendering/TextAutosizer.cpp
branches/chromium/1364/Source/WebCore/rendering/TextAutosizer.h


Added Paths

branches/chromium/1364/LayoutTests/fast/text-autosizing/form-controls-autosizing-button-input-elements-expected.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/form-controls-autosizing-button-input-elements.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/form-controls-autosizing-checkbox-input-element-expected.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/form-controls-autosizing-checkbox-input-element.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/form-controls-autosizing-radio-input-element-expected.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/form-controls-autosizing-radio-input-element.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/form-controls-autosizing-select-element-expected.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/form-controls-autosizing-select-element.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/form-controls-autosizing-textfield-input-elements-expected.html
branches/chromium/1364/LayoutTests/fast/text-autosizing/form-controls-autosizing-textfield-input-elements.html




Diff

Modified: branches/chromium/1364/LayoutTests/ChangeLog (139475 => 139476)

--- branches/chromium/1364/LayoutTests/ChangeLog	2013-01-11 19:46:33 UTC (rev 139475)
+++ branches/chromium/1364/LayoutTests/ChangeLog	2013-01-11 19:49:31 UTC (rev 139476)
@@ -1,5 +1,26 @@
-2013-01-11  Anton Vayvod  avay...@chromium.org
+2012-12-19  Tim Volodine  timvolod...@chromium.org
 
+Text Autosizing: Work out what to do about form controls
+https://bugs.webkit.org/show_bug.cgi?id=102560
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Tests for form input elements autosizing. Added tests to check that various kinds of form elements
+don't get autosized, i.e. buttons, textareas, check boxes, radio button and selection menus.
+
+* fast/text-autosizing/form-controls-autosizing-button-input-elements-expected.html: Added.
+* fast/text-autosizing/form-controls-autosizing-button-input-elements.html: Added.
+* fast/text-autosizing/form-controls-autosizing-checkbox-input-element-expected.html: Added.
+*

[webkit-changes] [139477] branches/safari-536.28-branch/Source/WebKit2

2013-01-11 Thread andersca

Title: [139477] branches/safari-536.28-branch/Source/WebKit2








Revision 139477
Author ander...@apple.com
Date 2013-01-11 11:50:19 -0800 (Fri, 11 Jan 2013)


Log Message
Merge r139464.

2013-01-11  Anders Carlsson  ander...@apple.com

Incoming synchronous messages can sometimes arrive out of order
https://bugs.webkit.org/show_bug.cgi?id=106677
rdar://problem/12889499

Reviewed by Andreas Kling.

In cases where synchronous messages come in more than one connection at the same time, we can sometimes deliver
the synchronous messages before any pending asynchronous messages on that connection. This breaks FIFO ordering.

Fix this by separating the dispatch all incoming synchronous messages phase out into multiple phases, so we'll
schedule one call per connection instead of one call for all connections.

* Platform/CoreIPC/Connection.cpp:
(Connection::SyncMessageState):
(CoreIPC::Connection::SyncMessageState::SyncMessageState):
(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
(CoreIPC::Connection::SyncMessageState::dispatchMessages):
(CoreIPC::Connection::SyncMessageState::dispatchMessageAndResetDidScheduleDispatchMessagesForConnection):
(CoreIPC::Connection::waitForSyncReply):

Modified Paths

branches/safari-536.28-branch/Source/WebKit2/ChangeLog
branches/safari-536.28-branch/Source/WebKit2/Platform/CoreIPC/Connection.cpp




Diff

Modified: branches/safari-536.28-branch/Source/WebKit2/ChangeLog (139476 => 139477)

--- branches/safari-536.28-branch/Source/WebKit2/ChangeLog	2013-01-11 19:49:31 UTC (rev 139476)
+++ branches/safari-536.28-branch/Source/WebKit2/ChangeLog	2013-01-11 19:50:19 UTC (rev 139477)
@@ -1,3 +1,29 @@
+2013-01-11  Anders Carlsson  ander...@apple.com
+
+Merge r139464.
+
+2013-01-11  Anders Carlsson  ander...@apple.com
+
+Incoming synchronous messages can sometimes arrive out of order
+https://bugs.webkit.org/show_bug.cgi?id=106677
+rdar://problem/12889499
+
+Reviewed by Andreas Kling.
+
+In cases where synchronous messages come in more than one connection at the same time, we can sometimes deliver
+the synchronous messages before any pending asynchronous messages on that connection. This breaks FIFO ordering.
+
+Fix this by separating the dispatch all incoming synchronous messages phase out into multiple phases, so we'll
+schedule one call per connection instead of one call for all connections.
+
+* Platform/CoreIPC/Connection.cpp:
+(Connection::SyncMessageState):
+(CoreIPC::Connection::SyncMessageState::SyncMessageState):
+(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
+(CoreIPC::Connection::SyncMessageState::dispatchMessages):
+(CoreIPC::Connection::SyncMessageState::dispatchMessageAndResetDidScheduleDispatchMessagesForConnection):
+(CoreIPC::Connection::waitForSyncReply):
+
 2012-12-13  Lucas Forschler  lforsch...@apple.com
 
 Rollout r133937


Modified: branches/safari-536.28-branch/Source/WebKit2/Platform/CoreIPC/Connection.cpp (139476 => 139477)

--- branches/safari-536.28-branch/Source/WebKit2/Platform/CoreIPC/Connection.cpp	2013-01-11 19:49:31 UTC (rev 139476)
+++ branches/safari-536.28-branch/Source/WebKit2/Platform/CoreIPC/Connection.cpp	2013-01-11 19:50:19 UTC (rev 139477)
@@ -30,6 +30,7 @@
 #include CoreIPCMessageKinds.h
 #include WebCore/RunLoop.h
 #include wtf/CurrentTime.h
+#include wtf/HashSet.h
 
 using namespace std;
 using namespace WebCore;
@@ -62,7 +63,9 @@
 // waiting for a reply to a synchronous message.
 bool processIncomingMessage(Connection*, IncomingMessage);
 
-void dispatchMessages();
+// Dispatch pending sync messages. if allowedConnection is not null, will only dispatch messages
+// from that connection and put the other messages back in the queue.
+void dispatchMessages(Connection* allowedConnection);
 
 private:
 explicit SyncMessageState(RunLoop*);
@@ -80,15 +83,16 @@
 return syncMessageStateMapMutex;
 }
 
-void dispatchMessageAndResetDidScheduleDispatchMessagesWork();
+void dispatchMessageAndResetDidScheduleDispatchMessagesForConnection(Connection*);
 
 RunLoop* m_runLoop;
 BinarySemaphore m_waitForSyncReplySemaphore;
 
-// Protects m_didScheduleDispatchMessagesWork and m_messagesToDispatchWhileWaitingForSyncReply.
+// Protects m_didScheduleDispatchMessagesWorkSet and m_messagesToDispatchWhileWaitingForSyncReply.
 Mutex m_mutex;
 
-bool m_didScheduleDispatchMessagesWork;
+// The set of connections for which we've scheduled a call to dispatchMessageAndResetDidScheduleDispatchMessagesForConnection.
+HashSetRefPtrConnection  m_didScheduleDispatchMessagesWorkSet;
 
 struct ConnectionAndIncomingMessage {
 RefPtrConnection connection;
@@ -115,7 +119,6 @@

[webkit-changes] [139478] trunk/Tools

2013-01-11 Thread psolanki

Title: [139478] trunk/Tools








Revision 139478
Author psola...@apple.com
Date 2013-01-11 11:58:00 -0800 (Fri, 11 Jan 2013)


Log Message
TestRunner leaks when running tests
https://bugs.webkit.org/show_bug.cgi?id=106683

Reviewed by Simon Fraser.

Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
tests.

* DumpRenderTree/TestRunner.cpp:
(TestRunner::makeWindowObject):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/TestRunner.cpp




Diff

Modified: trunk/Tools/ChangeLog (139477 => 139478)

--- trunk/Tools/ChangeLog	2013-01-11 19:50:19 UTC (rev 139477)
+++ trunk/Tools/ChangeLog	2013-01-11 19:58:00 UTC (rev 139478)
@@ -1,3 +1,17 @@
+2013-01-11  Pratik Solanki  psola...@apple.com
+
+TestRunner leaks when running tests
+https://bugs.webkit.org/show_bug.cgi?id=106683
+
+Reviewed by Simon Fraser.
+
+Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
+to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
+tests.
+
+* DumpRenderTree/TestRunner.cpp:
+(TestRunner::makeWindowObject):
+
 2013-01-11  Julie Parent  jpar...@chromium.org
 
 Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.


Modified: trunk/Tools/DumpRenderTree/TestRunner.cpp (139477 => 139478)

--- trunk/Tools/DumpRenderTree/TestRunner.cpp	2013-01-11 19:50:19 UTC (rev 139477)
+++ trunk/Tools/DumpRenderTree/TestRunner.cpp	2013-01-11 19:58:00 UTC (rev 139478)
@@ -2143,7 +2143,6 @@
 {
 JSRetainPtrJSStringRef testRunnerStr(Adopt, JSStringCreateWithUTF8CString(testRunner));
 ref();
-ref();
 
 JSClassRef classRef = getJSClass();
 JSValueRef layoutTestContollerObject = JSObjectMake(context, classRef, this);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139479] trunk

2013-01-11 Thread leviw

Title: [139479] trunk








Revision 139479
Author le...@chromium.org
Date 2013-01-11 11:59:48 -0800 (Fri, 11 Jan 2013)


Log Message
RenderGeometryMap and TransformState disagree with sub-pixel layout and translations
https://bugs.webkit.org/show_bug.cgi?id=106047

Reviewed by Simon Fraser.

Source/WebCore:

Mirror RenderGeometryMap's optimization for integer-translated transforms in TransformState.
This avoids the current behavior where the two can disagree on mappings, since RenderGeometryMap
pixel-snapped later when a translation occurred between two sub-pixel containers.

Test: fast/layers/geometry-map-transform-state-translation-mismatch.html

* platform/graphics/transforms/TransformState.h:
(WebCore::TransformState::setQuad): Clear accumulatedOffset when setting a new quad. Note: this
implementation only works properly when only tracking a quad.
* platform/graphics/transforms/TransformState.cpp:
(WebCore::TransformState::applyTransform): apply integral translations to the accumulatedOffset
for performance and consistency with RenderGeometryMap.

LayoutTests:

* fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt: Added.
* fast/layers/geometry-map-transform-state-translation-mismatch.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/transforms/TransformState.cpp
trunk/Source/WebCore/platform/graphics/transforms/TransformState.h


Added Paths

trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt
trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139478 => 139479)

--- trunk/LayoutTests/ChangeLog	2013-01-11 19:58:00 UTC (rev 139478)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 19:59:48 UTC (rev 139479)
@@ -1,3 +1,13 @@
+2013-01-11  Levi Weintraub  le...@chromium.org
+
+RenderGeometryMap and TransformState disagree with sub-pixel layout and translations
+https://bugs.webkit.org/show_bug.cgi?id=106047
+
+Reviewed by Simon Fraser.
+
+* fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt: Added.
+* fast/layers/geometry-map-transform-state-translation-mismatch.html: Added.
+
 2013-01-11  Stephen Chenney  schen...@chromium.org
 
 [Chromium] Mac editing test rebaseline


Added: trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt (0 => 139479)

--- trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt	2013-01-11 19:59:48 UTC (rev 139479)
@@ -0,0 +1,2 @@
+This tests that RenderGeometryMap and TransformState both avoid pixel snapping prior to applying translation-only transforms. The test passes if it doesn't assert on Debug.
+


Added: trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html (0 => 139479)

--- trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html	(rev 0)
+++ trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html	2013-01-11 19:59:48 UTC (rev 139479)
@@ -0,0 +1,33 @@
+!DOCTYPE html
+html
+style
+.wrapper {
+  width: 200px;
+  margin-left: 101.7px;
+}
+
+.content {
+  background: rgba(255, 0, 0, 0.2);
+  -webkit-transform: translateZ(0);
+  width: 100px;
+}
+
+.inner {
+  background: rgba(0, 0, 255, 0.2);
+  position: relative;
+  left: -6.25px;   
+}
+/style
+script
+if (window.testRunner)
+	testRunner.dumpAsText();
+/script
+body
+div id=descriptionThis tests that RenderGeometryMap and TransformState both avoid pixel snapping prior to applying translation-only transforms.
+The test passes if it doesn't assert on Debug./div
+div class=wrapper
+div class=content
+div class=inner/div
+/div
+/div
+/body


Modified: trunk/Source/WebCore/ChangeLog (139478 => 139479)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 19:58:00 UTC (rev 139478)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 19:59:48 UTC (rev 139479)
@@ -1,3 +1,23 @@
+2013-01-11  Levi Weintraub  le...@chromium.org
+
+RenderGeometryMap and TransformState disagree with sub-pixel layout and translations
+https://bugs.webkit.org/show_bug.cgi?id=106047
+
+Reviewed by Simon Fraser.
+
+Mirror RenderGeometryMap's optimization for integer-translated transforms in TransformState.
+This avoids the current behavior where the two can disagree on mappings, since RenderGeometryMap
+pixel-snapped later when a translation occurred between two sub-pixel containers.
+
+Test: fast/layers/geometry-map-transform-state-translation-mismatch.html
+
+* platform/graphics/transforms/TransformState.h:
+(WebCore::TransformState::setQuad): Clear accumulatedOffset when setting a new

[webkit-changes] [139481] trunk/Source/JavaScriptCore

2013-01-11 Thread ggaren

Title: [139481] trunk/Source/_javascript_Core








Revision 139481
Author gga...@apple.com
Date 2013-01-11 12:13:21 -0800 (Fri, 11 Jan 2013)


Log Message
Rename propertyOffsetFor = offsetForPropertyNumber
https://bugs.webkit.org/show_bug.cgi?id=106685

Reviewed by Gavin Barraclough.

Since the argument is just a typedef and not an object, I wanted to clarify the meaning.

* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::nextOffset): Updated for rename.

* runtime/PropertyOffset.h:
(JSC::offsetForPropertyNumber): Renamed. Also changed some PropertyOffset variables
to plain ints, because they're not actually on the PropertyOffsets number line.

* runtime/Structure.cpp:
(JSC::Structure::flattenDictionaryStructure):
* runtime/Structure.h:
(JSC::Structure::lastValidOffset): Updated for rename.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/PropertyMapHashTable.h
trunk/Source/_javascript_Core/runtime/PropertyOffset.h
trunk/Source/_javascript_Core/runtime/Structure.cpp
trunk/Source/_javascript_Core/runtime/Structure.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (139480 => 139481)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-11 20:06:20 UTC (rev 139480)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-11 20:13:21 UTC (rev 139481)
@@ -1,3 +1,24 @@
+2013-01-11  Geoffrey Garen  gga...@apple.com
+
+Rename propertyOffsetFor = offsetForPropertyNumber
+https://bugs.webkit.org/show_bug.cgi?id=106685
+
+Reviewed by Gavin Barraclough.
+
+Since the argument is just a typedef and not an object, I wanted to clarify the meaning.
+
+* runtime/PropertyMapHashTable.h:
+(JSC::PropertyTable::nextOffset): Updated for rename.
+
+* runtime/PropertyOffset.h:
+(JSC::offsetForPropertyNumber): Renamed. Also changed some PropertyOffset variables
+to plain ints, because they're not actually on the PropertyOffsets number line.
+
+* runtime/Structure.cpp:
+(JSC::Structure::flattenDictionaryStructure):
+* runtime/Structure.h:
+(JSC::Structure::lastValidOffset): Updated for rename.
+
 2013-01-10  Zan Dobersek  zandober...@gmail.com
 
 Remove the ENABLE_ANIMATION_API feature define occurences


Modified: trunk/Source/_javascript_Core/runtime/PropertyMapHashTable.h (139480 => 139481)

--- trunk/Source/_javascript_Core/runtime/PropertyMapHashTable.h	2013-01-11 20:06:20 UTC (rev 139480)
+++ trunk/Source/_javascript_Core/runtime/PropertyMapHashTable.h	2013-01-11 20:13:21 UTC (rev 139481)
@@ -491,7 +491,7 @@
 if (hasDeletedOffset())
 return getDeletedOffset();
 
-return propertyOffsetFor(size(), inlineCapacity);
+return offsetForPropertyNumber(size(), inlineCapacity);
 }
 
 inline PassOwnPtrPropertyTable PropertyTable::copy(JSGlobalData globalData, JSCell* owner, unsigned newCapacity)


Modified: trunk/Source/_javascript_Core/runtime/PropertyOffset.h (139480 => 139481)

--- trunk/Source/_javascript_Core/runtime/PropertyOffset.h	2013-01-11 20:06:20 UTC (rev 139480)
+++ trunk/Source/_javascript_Core/runtime/PropertyOffset.h	2013-01-11 20:13:21 UTC (rev 139481)
@@ -45,9 +45,9 @@
 
 // Declare all of the functions because they tend to do forward calls.
 inline void checkOffset(PropertyOffset);
-inline void checkOffset(PropertyOffset, PropertyOffset inlineCapacity);
+inline void checkOffset(PropertyOffset, int inlineCapacity);
 inline void validateOffset(PropertyOffset);
-inline void validateOffset(PropertyOffset, PropertyOffset inlineCapacity);
+inline void validateOffset(PropertyOffset, int inlineCapacity);
 inline bool isValidOffset(PropertyOffset);
 inline bool isInlineOffset(PropertyOffset);
 inline bool isOutOfLineOffset(PropertyOffset);
@@ -55,7 +55,7 @@
 inline size_t offsetInOutOfLineStorage(PropertyOffset);
 inline size_t offsetInRespectiveStorage(PropertyOffset);
 inline size_t numberOfOutOfLineSlotsForLastOffset(PropertyOffset);
-inline size_t numberOfSlotsForLastOffset(PropertyOffset, PropertyOffset inlineCapacity);
+inline size_t numberOfSlotsForLastOffset(PropertyOffset, int inlineCapacity);
 
 inline void checkOffset(PropertyOffset offset)
 {
@@ -63,7 +63,7 @@
 ASSERT(offset = invalidOffset);
 }
 
-inline void checkOffset(PropertyOffset offset, PropertyOffset inlineCapacity)
+inline void checkOffset(PropertyOffset offset, int inlineCapacity)
 {
 UNUSED_PARAM(offset);
 UNUSED_PARAM(inlineCapacity);
@@ -79,7 +79,7 @@
 ASSERT(isValidOffset(offset));
 }
 
-inline void validateOffset(PropertyOffset offset, PropertyOffset inlineCapacity)
+inline void validateOffset(PropertyOffset offset, int inlineCapacity)
 {
 checkOffset(offset, inlineCapacity);
 ASSERT(isValidOffset(offset));
@@ -132,7 +132,7 @@
 return offset - firstOutOfLineOffset + 1;
 }
 
-inline size_t numberOfSlotsForLastOffset(PropertyOffset offset, PropertyOffset inlineCapacity)
+inline size_t numberOfSlotsForLastOffset(PropertyOffset offset,

[webkit-changes] [139482] trunk/Source/JavaScriptCore

2013-01-11 Thread ggaren

Title: [139482] trunk/Source/_javascript_Core








Revision 139482
Author gga...@apple.com
Date 2013-01-11 12:20:25 -0800 (Fri, 11 Jan 2013)


Log Message
Fixed some bogus PropertyOffset ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=106686

Reviewed by Gavin Barraclough.

The ASSERTs were passing a JSType instead of an inlineCapacity, due to
an incomplete refactoring.

The compiler didn't catch this because both types are int underneath.

* runtime/JSObject.h:
(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::offsetForLocation):
* runtime/Structure.cpp:
(JSC::Structure::addPropertyTransitionToExistingStructure): Validate against
our inline capacity, as we intended.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSObject.h
trunk/Source/_javascript_Core/runtime/Structure.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (139481 => 139482)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-11 20:13:21 UTC (rev 139481)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-11 20:20:25 UTC (rev 139482)
@@ -1,5 +1,25 @@
 2013-01-11  Geoffrey Garen  gga...@apple.com
 
+Fixed some bogus PropertyOffset ASSERTs
+https://bugs.webkit.org/show_bug.cgi?id=106686
+
+Reviewed by Gavin Barraclough.
+
+The ASSERTs were passing a JSType instead of an inlineCapacity, due to
+an incomplete refactoring.
+
+The compiler didn't catch this because both types are int underneath.
+
+* runtime/JSObject.h:
+(JSC::JSObject::getDirect):
+(JSC::JSObject::getDirectLocation):
+(JSC::JSObject::offsetForLocation):
+* runtime/Structure.cpp:
+(JSC::Structure::addPropertyTransitionToExistingStructure): Validate against
+our inline capacity, as we intended.
+
+2013-01-11  Geoffrey Garen  gga...@apple.com
+
 Rename propertyOffsetFor = offsetForPropertyNumber
 https://bugs.webkit.org/show_bug.cgi?id=106685
 


Modified: trunk/Source/_javascript_Core/runtime/JSObject.h (139481 => 139482)

--- trunk/Source/_javascript_Core/runtime/JSObject.h	2013-01-11 20:13:21 UTC (rev 139481)
+++ trunk/Source/_javascript_Core/runtime/JSObject.h	2013-01-11 20:20:25 UTC (rev 139482)
@@ -504,14 +504,14 @@
 JSValue getDirect(JSGlobalData globalData, PropertyName propertyName) const
 {
 PropertyOffset offset = structure()-get(globalData, propertyName);
-checkOffset(offset, structure()-typeInfo().type());
+checkOffset(offset, structure()-inlineCapacity());
 return offset != invalidOffset ? getDirectOffset(offset) : JSValue();
 }
 
 WriteBarrierBaseUnknown* getDirectLocation(JSGlobalData globalData, PropertyName propertyName)
 {
 PropertyOffset offset = structure()-get(globalData, propertyName);
-checkOffset(offset, structure()-typeInfo().type());
+checkOffset(offset, structure()-inlineCapacity());
 return isValidOffset(offset) ? locationForOffset(offset) : 0;
 }
 
@@ -570,7 +570,7 @@
 result = offsetInInlineStorage;
 else
 result = outOfLineStorage() - location + (firstOutOfLineOffset - 1);
-validateOffset(result, structure()-typeInfo().type());
+validateOffset(result, structure()-inlineCapacity());
 return result;
 }
 


Modified: trunk/Source/_javascript_Core/runtime/Structure.cpp (139481 => 139482)

--- trunk/Source/_javascript_Core/runtime/Structure.cpp	2013-01-11 20:13:21 UTC (rev 139481)
+++ trunk/Source/_javascript_Core/runtime/Structure.cpp	2013-01-11 20:20:25 UTC (rev 139482)
@@ -304,7 +304,7 @@
 JSCell* specificValueInPrevious = existingTransition-m_specificValueInPrevious.get();
 if (specificValueInPrevious  specificValueInPrevious != specificValue)
 return 0;
-validateOffset(existingTransition-m_offset, structure-m_typeInfo.type());
+validateOffset(existingTransition-m_offset, existingTransition-inlineCapacity());
 offset = existingTransition-m_offset;
 return existingTransition;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139483] trunk/Source/WebCore

2013-01-11 Thread haraken

Title: [139483] trunk/Source/WebCore








Revision 139483
Author hara...@chromium.org
Date 2013-01-11 12:21:41 -0800 (Fri, 11 Jan 2013)


Log Message
Unreviewed. Rebaselined run-bindings-tests.

* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::TestExceptionV8Internal::nameAttrGetter):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139482 => 139483)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 20:20:25 UTC (rev 139482)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 20:21:41 UTC (rev 139483)
@@ -1,3 +1,28 @@
+2013-01-11  Kentaro Hara  hara...@chromium.org
+
+Unreviewed. Rebaselined run-bindings-tests.
+
+* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
+(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
+(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
+* bindings/scripts/test/V8/V8TestException.cpp:
+(WebCore::TestExceptionV8Internal::nameAttrGetter):
+* bindings/scripts/test/V8/V8TestInterface.cpp:
+(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetter):
+(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
+(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):
+* bindings/scripts/test/V8/V8TestObj.cpp:
+(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
+(WebCore::TestObjV8Internal::staticStringAttrAttrGetter):
+(WebCore::TestObjV8Internal::stringAttrAttrGetter):
+(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
+(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
+(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
+(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
+(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
+(WebCore::TestObjV8Internal::hashAttrGetter):
+(WebCore::TestObjV8Internal::conditionalMethod1Callback):
+
 2013-01-11  Levi Weintraub  le...@chromium.org
 
 RenderGeometryMap and TransformState disagree with sub-pixel layout and translations


Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.cpp (139482 => 139483)

--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.cpp	2013-01-11 20:20:25 UTC (rev 139482)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.cpp	2013-01-11 20:21:41 UTC (rev 139483)
@@ -41,13 +41,13 @@
 static v8::Handlev8::Value attr1AttrGetter(v8::Localv8::String name, const v8::AccessorInfo info)
 {
 TestEventConstructor* imp = V8TestEventConstructor::toNative(info.Holder());
-return v8String(imp-attr1(), info.GetIsolate(), ReturnPersistentHandle);
+return v8String(imp-attr1(), info.GetIsolate(), ReturnUnsafeHandle);
 }
 
 static v8::Handlev8::Value attr2AttrGetter(v8::Localv8::String name, const v8::AccessorInfo info)
 {
 TestEventConstructor* imp = V8TestEventConstructor::toNative(info.Holder());
-return v8String(imp-attr2(), info.GetIsolate(), ReturnPersistentHandle);
+return v8String(imp-attr2(), info.GetIsolate(), ReturnUnsafeHandle);
 }
 
 } // namespace TestEventConstructorV8Internal


Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.cpp (139482 => 139483)

--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.cpp	2013-01-11 20:20:25 UTC (rev 139482)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.cpp	2013-01-11 20:21:41 UTC (rev 139483)
@@ -40,7 +40,7 @@
 static v8::Handlev8::Value nameAttrGetter(v8::Localv8::String name, const

[webkit-changes] [139484] trunk/Source/WebCore

2013-01-11 Thread pdr

Title: [139484] trunk/Source/WebCore








Revision 139484
Author p...@google.com
Date 2013-01-11 12:23:46 -0800 (Fri, 11 Jan 2013)


Log Message
Skip CachedImage::CreateImage if we don't have image data
https://bugs.webkit.org/show_bug.cgi?id=106156

Reviewed by Nate Chapin.

This patch skips image creation if we do not have image data. This can occur during
cache revalidation when the revalidation request (304 not modified) comes back without
any content. In this revalidation case, the http spec requires that a mimetype not be set
on the response to prevent a cached resource from having a different mimetype
from the revalidated resource. Because revalidation requests do not have a mimetype,
CachedImage::CreateImage() will fail on SVG images. This patch prevents
CachedImage::CreateImage() from being called during revalidation.

No new tests as there are no observable changes from this patch.

* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::data):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedImage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139483 => 139484)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 20:21:41 UTC (rev 139483)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 20:23:46 UTC (rev 139484)
@@ -1,3 +1,23 @@
+2013-01-11  Philip Rogers  p...@google.com
+
+Skip CachedImage::CreateImage if we don't have image data
+https://bugs.webkit.org/show_bug.cgi?id=106156
+
+Reviewed by Nate Chapin.
+
+This patch skips image creation if we do not have image data. This can occur during
+cache revalidation when the revalidation request (304 not modified) comes back without
+any content. In this revalidation case, the http spec requires that a mimetype not be set
+on the response to prevent a cached resource from having a different mimetype
+from the revalidated resource. Because revalidation requests do not have a mimetype,
+CachedImage::CreateImage() will fail on SVG images. This patch prevents
+CachedImage::CreateImage() from being called during revalidation.
+
+No new tests as there are no observable changes from this patch.
+
+* loader/cache/CachedImage.cpp:
+(WebCore::CachedImage::data):
+
 2013-01-11  Kentaro Hara  hara...@chromium.org
 
 Unreviewed. Rebaselined run-bindings-tests.


Modified: trunk/Source/WebCore/loader/cache/CachedImage.cpp (139483 => 139484)

--- trunk/Source/WebCore/loader/cache/CachedImage.cpp	2013-01-11 20:21:41 UTC (rev 139483)
+++ trunk/Source/WebCore/loader/cache/CachedImage.cpp	2013-01-11 20:23:46 UTC (rev 139484)
@@ -360,14 +360,16 @@
 {
 m_data = data;
 
-createImage();
+if (m_data)
+createImage();
 
 bool sizeAvailable = false;
 
 // Have the image update its data from its internal buffer.
 // It will not do anything now, but will delay decoding until 
 // queried for info (like size or specific image frames).
-sizeAvailable = m_image-setData(m_data ? m_data-sharedBuffer() : 0, allDataReceived);
+if (m_image)
+sizeAvailable = m_image-setData(m_data ? m_data-sharedBuffer() : 0, allDataReceived);
 
 // Go ahead and tell our observers to try to draw if we have either
 // received all the data or the size is known.  Each chunk from the
@@ -375,9 +377,9 @@
 // to decode.
 if (sizeAvailable || allDataReceived) {
 size_t maxDecodedImageSize = maximumDecodedImageSize();
-IntSize s = m_image-size();
+IntSize s = m_image ? m_image-size() : IntSize();
 size_t estimatedDecodedImageSize = s.width() * s.height() * 4; // no overflow check
-if (m_image-isNull() || (maxDecodedImageSize  0  estimatedDecodedImageSize  maxDecodedImageSize)) {
+if (!m_image || m_image-isNull() || (maxDecodedImageSize  0  estimatedDecodedImageSize  maxDecodedImageSize)) {
 error(errorOccurred() ? status() : DecodeError);
 if (inCache())
 memoryCache()-remove(this);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139486] trunk/Source/JavaScriptCore

2013-01-11 Thread mhahnenberg

Title: [139486] trunk/Source/_javascript_Core








Revision 139486
Author mhahnenb...@apple.com
Date 2013-01-11 12:56:20 -0800 (Fri, 11 Jan 2013)


Log Message
Objective-C objects that are passed to _javascript_ leak (until the JSContext is destroyed)
https://bugs.webkit.org/show_bug.cgi?id=106056

Reviewed by Darin Adler.

* API/APIJSValue.h:
* API/JSValue.mm: Make the reference to the JSContext strong.
(-[JSValue context]):
(-[JSValue initWithValue:inContext:]):
(-[JSValue dealloc]):
* API/JSWrapperMap.mm: Make the reference back from wrappers to Obj-C objects weak instead of strong.
Also add an explicit WeakGCMap in the JSWrapperMap rather than using Obj-C associated object API which 
was causing memory leaks.
(wrapperClass):
(-[JSObjCClassInfo wrapperForObject:]):
(-[JSWrapperMap initWithContext:]):
(-[JSWrapperMap dealloc]):
(-[JSWrapperMap wrapperForObject:]):

Modified Paths

trunk/Source/_javascript_Core/API/APIJSValue.h
trunk/Source/_javascript_Core/API/JSValue.mm
trunk/Source/_javascript_Core/API/JSWrapperMap.mm
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/API/APIJSValue.h (139485 => 139486)

--- trunk/Source/_javascript_Core/API/APIJSValue.h	2013-01-11 20:31:09 UTC (rev 139485)
+++ trunk/Source/_javascript_Core/API/APIJSValue.h	2013-01-11 20:56:20 UTC (rev 139486)
@@ -29,7 +29,7 @@
 
 // A JSValue is a reference to a value within the _javascript_ object space of a
 // JSVirtualMachine. All instances of JSValue originate from a JSContext, and
-// hold a weak reference to this JSContext. Where an instance method is invoked
+// hold a strong reference to this JSContext. Where an instance method is invoked
 // upon a JSValue, and this returns another JSValue, the returned JSValue will
 // originate from the same JSContext as the JSValue on which the method was
 // invoked.


Modified: trunk/Source/_javascript_Core/API/JSValue.mm (139485 => 139486)

--- trunk/Source/_javascript_Core/API/JSValue.mm	2013-01-11 20:31:09 UTC (rev 139485)
+++ trunk/Source/_javascript_Core/API/JSValue.mm	2013-01-11 20:56:20 UTC (rev 139486)
@@ -53,7 +53,7 @@
 
 @implementation JSValue {
 JSValueRef m_value;
-JSContext *m_weakContext;
+JSContext *m_context;
 }
 
 + (JSValue *)valueWithObject:(id)value inContext:(JSContext *)context
@@ -521,7 +521,7 @@
 
 - (JSContext *)context
 {
-return objc_loadWeak(m_weakContext);
+return m_context;
 }
 
 @end
@@ -1049,7 +1049,7 @@
 return nil;
 
 ASSERT(value);
-objc_initWeak(m_weakContext, context);
+m_context = [context retain];
 [context protect:value];
 m_value = value;
 return self;
@@ -1172,7 +1172,8 @@
 JSContext *context = [self context];
 if (context)
 [context unprotect:m_value];
-objc_destroyWeak(m_weakContext);
+[m_context release];
+m_context = nil;
 [super dealloc];
 }
 


Modified: trunk/Source/_javascript_Core/API/JSWrapperMap.mm (139485 => 139486)

--- trunk/Source/_javascript_Core/API/JSWrapperMap.mm	2013-01-11 20:31:09 UTC (rev 139485)
+++ trunk/Source/_javascript_Core/API/JSWrapperMap.mm	2013-01-11 20:56:20 UTC (rev 139486)
@@ -28,10 +28,12 @@
 
 #if JS_OBJC_API_ENABLED
 
+#import APICast.h
 #import JSContextInternal.h
 #import JSWrapperMap.h
 #import ObjCCallbackFunction.h
 #import ObjcRuntimeExtras.h
+#import WeakGCMap.h
 #import wtf/TCSpinLock.h
 #import wtf/Vector.h
 
@@ -376,6 +378,7 @@
 @implementation JSWrapperMap {
 JSContext *m_context;
 NSMutableDictionary *m_classMap;
+JSC::WeakGCMapid, JSC::JSObject m_cachedWrappers;
 }
 
 - (id)initWithContext:(JSContext *)context
@@ -413,10 +416,11 @@
 
 - (JSValue *)wrapperForObject:(id)object
 {
-JSValue *wrapper = objc_getAssociatedObject(object, m_context);
-if (wrapper  wrapper.context)
-return wrapper;
+JSC::JSObject* jsWrapper = m_cachedWrappers.get(object);
+if (jsWrapper)
+return [JSValue valueWithValue:toRef(jsWrapper) inContext:m_context];
 
+JSValue *wrapper;
 if (class_isMetaClass(object_getClass(object)))
 wrapper = [[self classInfoForClass:(Class)object] constructor];
 else {
@@ -429,7 +433,9 @@
 // (1) For immortal objects JSValues will effectively leak and this results in error output being logged - we should avoid adding associated objects to immortal objects.
 // (2) A long lived object may rack up many JSValues. When the contexts are released these will unproctect the associated _javascript_ objects,
 // but still, would probably nicer if we made it so that only one associated object was required, broadcasting object dealloc.
-objc_setAssociatedObject(object, m_context, wrapper, OBJC_ASSOCIATION_RETAIN);
+JSC::ExecState* exec = toJS(contextInternalContext(m_context));
+jsWrapper = toJS(exec, valueInternalValue(wrapper)).toObject(exec);
+m_cachedWrappers.set(exec-globalData(), object, jsWrapper);
 return wrapper;
 }
 


Modified: trunk/Source/_javascript_Core/ChangeLog

[webkit-changes] [139487] trunk/Source/WTF

2013-01-11 Thread fpizlo

Title: [139487] trunk/Source/WTF








Revision 139487
Author fpi...@apple.com
Date 2013-01-11 13:08:47 -0800 (Fri, 11 Jan 2013)


Log Message
Add WTF_EXPORT_PRIVATE to printInternal() methods of PrintStream.h

Rubber stamped by Mark Hahnenberg.

This will make it easier to use dataLog() from WebCore.

* wtf/PrintStream.h:
(WTF):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PrintStream.h




Diff

Modified: trunk/Source/WTF/ChangeLog (139486 => 139487)

--- trunk/Source/WTF/ChangeLog	2013-01-11 20:56:20 UTC (rev 139486)
+++ trunk/Source/WTF/ChangeLog	2013-01-11 21:08:47 UTC (rev 139487)
@@ -1,3 +1,14 @@
+2013-01-11  Filip Pizlo  fpi...@apple.com
+
+Add WTF_EXPORT_PRIVATE to printInternal() methods of PrintStream.h
+
+Rubber stamped by Mark Hahnenberg.
+
+This will make it easier to use dataLog() from WebCore.
+
+* wtf/PrintStream.h:
+(WTF):
+
 2013-01-09  Antti Koivisto  an...@apple.com
 
 Release FastMalloc thread caches on memory warning


Modified: trunk/Source/WTF/wtf/PrintStream.h (139486 => 139487)

--- trunk/Source/WTF/wtf/PrintStream.h	2013-01-11 20:56:20 UTC (rev 139486)
+++ trunk/Source/WTF/wtf/PrintStream.h	2013-01-11 21:08:47 UTC (rev 139487)
@@ -208,22 +208,22 @@
 }
 };
 
-void printInternal(PrintStream, const char*);
-void printInternal(PrintStream, const CString);
-void printInternal(PrintStream, const String);
+WTF_EXPORT_PRIVATE void printInternal(PrintStream, const char*);
+WTF_EXPORT_PRIVATE void printInternal(PrintStream, const CString);
+WTF_EXPORT_PRIVATE void printInternal(PrintStream, const String);
 inline void printInternal(PrintStream out, char* value) { printInternal(out, static_castconst char*(value)); }
 inline void printInternal(PrintStream out, CString value) { printInternal(out, static_castconst CString(value)); }
 inline void printInternal(PrintStream out, String value) { printInternal(out, static_castconst String(value)); }
-void printInternal(PrintStream, bool);
-void printInternal(PrintStream, int);
-void printInternal(PrintStream, unsigned);
-void printInternal(PrintStream, long);
-void printInternal(PrintStream, unsigned long);
-void printInternal(PrintStream, long long);
-void printInternal(PrintStream, unsigned long long);
-void printInternal(PrintStream, float);
-void printInternal(PrintStream, double);
-void printInternal(PrintStream, RawPointer);
+WTF_EXPORT_PRIVATE void printInternal(PrintStream, bool);
+WTF_EXPORT_PRIVATE void printInternal(PrintStream, int);
+WTF_EXPORT_PRIVATE void printInternal(PrintStream, unsigned);
+WTF_EXPORT_PRIVATE void printInternal(PrintStream, long);
+WTF_EXPORT_PRIVATE void printInternal(PrintStream, unsigned long);
+WTF_EXPORT_PRIVATE void printInternal(PrintStream, long long);
+WTF_EXPORT_PRIVATE void printInternal(PrintStream, unsigned long long);
+WTF_EXPORT_PRIVATE void printInternal(PrintStream, float);
+WTF_EXPORT_PRIVATE void printInternal(PrintStream, double);
+WTF_EXPORT_PRIVATE void printInternal(PrintStream, RawPointer);
 
 templatetypename T
 void printInternal(PrintStream out, const T value)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139488] trunk/Source/JavaScriptCore

2013-01-11 Thread ggaren

Title: [139488] trunk/Source/_javascript_Core








Revision 139488
Author gga...@apple.com
Date 2013-01-11 13:09:29 -0800 (Fri, 11 Jan 2013)


Log Message
Removed an unused version of getDirectLocation
https://bugs.webkit.org/show_bug.cgi?id=106691

Reviewed by Gavin Barraclough.

getDirectLocation is a weird operation. Removing the unused version is
the easy part.

* runtime/JSObject.h:
(JSObject):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSObject.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (139487 => 139488)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-11 21:08:47 UTC (rev 139487)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-11 21:09:29 UTC (rev 139488)
@@ -1,3 +1,16 @@
+2013-01-11  Geoffrey Garen  gga...@apple.com
+
+Removed an unused version of getDirectLocation
+https://bugs.webkit.org/show_bug.cgi?id=106691
+
+Reviewed by Gavin Barraclough.
+
+getDirectLocation is a weird operation. Removing the unused version is
+the easy part.
+
+* runtime/JSObject.h:
+(JSObject):
+
 2013-01-11  Mark Hahnenberg  mhahnenb...@apple.com
 
 Objective-C objects that are passed to _javascript_ leak (until the JSContext is destroyed)


Modified: trunk/Source/_javascript_Core/runtime/JSObject.h (139487 => 139488)

--- trunk/Source/_javascript_Core/runtime/JSObject.h	2013-01-11 21:08:47 UTC (rev 139487)
+++ trunk/Source/_javascript_Core/runtime/JSObject.h	2013-01-11 21:09:29 UTC (rev 139488)
@@ -515,13 +515,6 @@
 return isValidOffset(offset) ? locationForOffset(offset) : 0;
 }
 
-WriteBarrierBaseUnknown* getDirectLocation(JSGlobalData globalData, PropertyName propertyName, unsigned attributes)
-{
-JSCell* specificFunction;
-PropertyOffset offset = structure()-get(globalData, propertyName, attributes, specificFunction);
-return isValidOffset(offset) ? locationForOffset(offset) : 0;
-}
-
 bool hasInlineStorage() const { return structure()-hasInlineStorage(); }
 ConstPropertyStorage inlineStorageUnsafe() const
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139489] trunk/LayoutTests

2013-01-11 Thread leviw

Title: [139489] trunk/LayoutTests








Revision 139489
Author le...@chromium.org
Date 2013-01-11 13:20:43 -0800 (Fri, 11 Jan 2013)


Log Message
Unreviewed gardening. r139445 triggered assertions in Skia on debug Chromium bots.
Marking them as crashing in TestExpectations.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139488 => 139489)

--- trunk/LayoutTests/ChangeLog	2013-01-11 21:09:29 UTC (rev 139488)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 21:20:43 UTC (rev 139489)
@@ -1,3 +1,10 @@
+2013-01-11  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. r139445 triggered assertions in Skia on debug Chromium bots.
+Marking them as crashing in TestExpectations.
+
+* platform/chromium/TestExpectations:
+
 2013-01-11  Stephen Chenney  schen...@chromium.org
 
 [Chromium] More test expectations for Skia changes


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139488 => 139489)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-11 21:09:29 UTC (rev 139488)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-11 21:20:43 UTC (rev 139489)
@@ -4268,6 +4268,13 @@
 webkit.org/b/106426 [ Win ] inspector/geolocation-watchPosition.html [ Failure Pass ]
 crbug.com/166932 [ Debug ] plugins/embed-attributes-setting.html [ Crash Pass ]
 
+# Broken by Skia flag changes in r139445
+crbug.com/169550 [ Debug ] fast/borders/border-mixed-alpha.html [ Crash ]
+crbug.com/169550 [ Debug ] fast/borders/outline-alpha-block.html [ Crash ]
+crbug.com/169550 [ Debug ] fast/borders/outline-alpha-inline.html [ Crash ]
+crbug.com/169550 [ Debug ] fast/lists/big-list-marker.html [ Crash ]
+crbug.com/169550 [ Debug ] platform/chromium/virtual/deferred/fast/images/icon-decoding.html [ Crash ]
+
 # Transient. Needs rebaseline.
 webkit.org/b/103955 fast/repaint/4774354.html [ ImageOnlyFailure ]
 webkit.org/b/103955 fast/repaint/4776765.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139491] trunk/Source/JavaScriptCore

2013-01-11 Thread ggaren

Title: [139491] trunk/Source/_javascript_Core








Revision 139491
Author gga...@apple.com
Date 2013-01-11 13:33:47 -0800 (Fri, 11 Jan 2013)


Log Message
Removed getDirectLocation and offsetForLocation and all their uses
https://bugs.webkit.org/show_bug.cgi?id=106692

Reviewed by Filip Pizlo.

getDirectLocation() and its associated offsetForLocation() relied on
detailed knowledge of the rules of PropertyOffset, JSObject, and
Structure, which is a hard thing to reverse-engineer reliably. Luckily,
it wasn't needed, and all clients either wanted a true value or a
PropertyOffset. So, I refactored accordingly.

* dfg/DFGOperations.cpp: Renamed putDirectOffset to putDirect, to clarify
that we are not putting an offset.

* runtime/JSActivation.cpp:
(JSC::JSActivation::getOwnPropertySlot): Get a value instead of a value
pointer, since we never wanted a pointer to begin with.

* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertySlot): Use a PropertyOffset instead of a pointer,
so we don't have to reverse-engineer the offset from the pointer.

* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::resetInheritorID):
(JSC::JSObject::inheritorID):
(JSC::JSObject::removeDirect):
(JSC::JSObject::fillGetterPropertySlot):
(JSC::JSObject::getOwnPropertyDescriptor): Renamed getDirectOffset and
putDirectOffset, as explaind above. We want to use the name getDirectOffset
for when the thing you're getting is the offset.

* runtime/JSObject.h:
(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectOffset): Changed getDirectLocation to getDirectOffset,
since clients really wants PropertyOffsets and not locations.

(JSObject::offsetForLocation): Removed this function because it was hard
to get right.

(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectUndefined):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
* runtime/JSScope.cpp:
(JSC::executeResolveOperations):
(JSC::JSScope::resolvePut):
* runtime/JSValue.cpp:
(JSC::JSValue::putToPrimitive): Updated for renames.

* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot): Use a PropertyOffset instead of a pointer,
so we don't have to reverse-engineer the offset from the pointer.

* runtime/Structure.cpp:
(JSC::Structure::flattenDictionaryStructure): Updated for renames.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/runtime/JSActivation.cpp
trunk/Source/_javascript_Core/runtime/JSFunction.cpp
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/runtime/JSObject.h
trunk/Source/_javascript_Core/runtime/JSScope.cpp
trunk/Source/_javascript_Core/runtime/JSValue.cpp
trunk/Source/_javascript_Core/runtime/Lookup.cpp
trunk/Source/_javascript_Core/runtime/Structure.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (139490 => 139491)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-11 21:30:33 UTC (rev 139490)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-11 21:33:47 UTC (rev 139491)
@@ -1,5 +1,65 @@
 2013-01-11  Geoffrey Garen  gga...@apple.com
 
+Removed getDirectLocation and offsetForLocation and all their uses
+https://bugs.webkit.org/show_bug.cgi?id=106692
+
+Reviewed by Filip Pizlo.
+
+getDirectLocation() and its associated offsetForLocation() relied on
+detailed knowledge of the rules of PropertyOffset, JSObject, and
+Structure, which is a hard thing to reverse-engineer reliably. Luckily,
+it wasn't needed, and all clients either wanted a true value or a
+PropertyOffset. So, I refactored accordingly.
+
+* dfg/DFGOperations.cpp: Renamed putDirectOffset to putDirect, to clarify
+that we are not putting an offset.
+
+* runtime/JSActivation.cpp:
+(JSC::JSActivation::getOwnPropertySlot): Get a value instead of a value
+pointer, since we never wanted a pointer to begin with.
+
+* runtime/JSFunction.cpp:
+(JSC::JSFunction::getOwnPropertySlot): Use a PropertyOffset instead of a pointer,
+so we don't have to reverse-engineer the offset from the pointer.
+
+* runtime/JSObject.cpp:
+(JSC::JSObject::put):
+(JSC::JSObject::resetInheritorID):
+(JSC::JSObject::inheritorID):
+(JSC::JSObject::removeDirect):
+(JSC::JSObject::fillGetterPropertySlot):
+(JSC::JSObject::getOwnPropertyDescriptor): Renamed getDirectOffset and
+putDirectOffset, as explaind above. We want to use the name getDirectOffset
+for when the thing you're getting is the offset.
+
+* runtime/JSObject.h:
+(JSC::JSObject::getDirect):
+(JSC::JSObject::getDirectOffset): Changed getDirectLocation to getDirectOffset,
+since clients really wants PropertyOffsets and not locations.
+
+(JSObject::offsetForLocation): Removed this function because it was hard
+to get

[webkit-changes] [139494] trunk/Source

2013-01-11 Thread tony

Title: [139494] trunk/Source








Revision 139494
Author t...@chromium.org
Date 2013-01-11 14:08:32 -0800 (Fri, 11 Jan 2013)


Log Message
[chromium] Don't regenerate all bindings when any idl file changes
https://bugs.webkit.org/show_bug.cgi?id=106604

Reviewed by Kentaro Hara.

Source/WebCore:

Currently, every idl file is a dependency of generating the supplemental dependency map
and generating bindings is a dependency of the map. This means that touching any idl file
causes us to regenerate all the bindings.

Change it so that generating bindings only depends on the idl files that have Supplemental= in them.
We only have 24 idl files with Supplemental (3.7% of the 638 idl files in WebCore) so modifying
any of those will cause all bindings to be regenerated.

If you add or remove a new idl file, you have to rerun gyp which will fix up any dependencies.
If you edit an existing file and add Supplemental= to it, you will now need to rerun gyp_{webkit,chromium}.
I think that's a reasonable tradeoff since it seems highly unlikely that you would adding Supplemental=
to an existing file without renaming it. The bots will always be fine because they always run
gyp after updating.

No new tests, this is a build only change.

* WebCore.gyp/WebCore.gyp: Remove (SHARED_INTERMEDIATE_DIR)/supplemental_dependency.tmp, which was causing
the full rebuild. The step to generate this file is still a hard dependency so it will still be generated and
used by generate-bindings.pl. Also remove @(webcore_test_support_idl_files). This was saying we should regenerate
all bindings if a test idl file changed. That doesn't make sense.
* WebCore.gyp/scripts/supplemental_idl_files.py: Added.
(DoMain):

Source/WebKit/chromium:

* gyp_webkit: Add Source/WebCore/WebCore.gyp/scripts to the python import search path
so we can generate idl dependencies at gyp time.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/gyp_webkit


Added Paths

trunk/Source/WebCore/WebCore.gyp/scripts/supplemental_idl_files.py




Diff

Modified: trunk/Source/WebCore/ChangeLog (139493 => 139494)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 22:05:25 UTC (rev 139493)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 22:08:32 UTC (rev 139494)
@@ -1,3 +1,33 @@
+2013-01-11  Tony Chang  t...@chromium.org
+
+[chromium] Don't regenerate all bindings when any idl file changes
+https://bugs.webkit.org/show_bug.cgi?id=106604
+
+Reviewed by Kentaro Hara.
+
+Currently, every idl file is a dependency of generating the supplemental dependency map
+and generating bindings is a dependency of the map. This means that touching any idl file
+causes us to regenerate all the bindings.
+
+Change it so that generating bindings only depends on the idl files that have Supplemental= in them.
+We only have 24 idl files with Supplemental (3.7% of the 638 idl files in WebCore) so modifying
+any of those will cause all bindings to be regenerated.
+
+If you add or remove a new idl file, you have to rerun gyp which will fix up any dependencies.
+If you edit an existing file and add Supplemental= to it, you will now need to rerun gyp_{webkit,chromium}.
+I think that's a reasonable tradeoff since it seems highly unlikely that you would adding Supplemental=
+to an existing file without renaming it. The bots will always be fine because they always run
+gyp after updating.
+
+No new tests, this is a build only change.
+
+* WebCore.gyp/WebCore.gyp: Remove (SHARED_INTERMEDIATE_DIR)/supplemental_dependency.tmp, which was causing
+the full rebuild. The step to generate this file is still a hard dependency so it will still be generated and
+used by generate-bindings.pl. Also remove @(webcore_test_support_idl_files). This was saying we should regenerate
+all bindings if a test idl file changed. That doesn't make sense.
+* WebCore.gyp/scripts/supplemental_idl_files.py: Added.
+(DoMain):
+
 2013-01-11  Alexandru Chiculita  ach...@adobe.com
 
 Element is displayed behind a composited layer when clipping is used on a previous element


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (139493 => 139494)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2013-01-11 22:05:25 UTC (rev 139493)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2013-01-11 22:08:32 UTC (rev 139494)
@@ -1165,8 +1165,7 @@
 '../bindings/scripts/IDLParser.pm',
 '../bindings/scripts/IDLAttributes.txt',
 '../bindings/scripts/preprocessor.pm',
-'(SHARED_INTERMEDIATE_DIR)/supplemental_dependency.tmp',
-'@(webcore_test_support_idl_files)',
+'!@pymod_do_main(supplemental_idl_files @(bindings_idl_files))',
   ],
   'outputs': [
 # FIXME:  The .cpp file should

[webkit-changes] [139496] trunk/Source/JavaScriptCore

2013-01-11 Thread fpizlo

Title: [139496] trunk/Source/_javascript_Core








Revision 139496
Author fpi...@apple.com
Date 2013-01-11 14:18:27 -0800 (Fri, 11 Jan 2013)


Log Message
It should be possible to enable verbose printing of each OSR exit at run-time (rather than compile-time) and it should print register state
https://bugs.webkit.org/show_bug.cgi?id=106700

Reviewed by Mark Hahnenberg.

* dfg/DFGAssemblyHelpers.h:
(DFG):
(JSC::DFG::AssemblyHelpers::debugCall):
* dfg/DFGCommon.h:
* dfg/DFGOSRExit.h:
(DFG):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* runtime/Options.h:
(JSC):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.h
trunk/Source/_javascript_Core/dfg/DFGCommon.h
trunk/Source/_javascript_Core/dfg/DFGOSRExit.h
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/runtime/Options.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (139495 => 139496)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-11 22:15:54 UTC (rev 139495)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-11 22:18:27 UTC (rev 139496)
@@ -1,3 +1,25 @@
+2013-01-11  Filip Pizlo  fpi...@apple.com
+
+It should be possible to enable verbose printing of each OSR exit at run-time (rather than compile-time) and it should print register state
+https://bugs.webkit.org/show_bug.cgi?id=106700
+
+Reviewed by Mark Hahnenberg.
+
+* dfg/DFGAssemblyHelpers.h:
+(DFG):
+(JSC::DFG::AssemblyHelpers::debugCall):
+* dfg/DFGCommon.h:
+* dfg/DFGOSRExit.h:
+(DFG):
+* dfg/DFGOSRExitCompiler32_64.cpp:
+(JSC::DFG::OSRExitCompiler::compileExit):
+* dfg/DFGOSRExitCompiler64.cpp:
+(JSC::DFG::OSRExitCompiler::compileExit):
+* dfg/DFGOperations.cpp:
+* dfg/DFGOperations.h:
+* runtime/Options.h:
+(JSC):
+
 2013-01-11  Geoffrey Garen  gga...@apple.com
 
 Removed getDirectLocation and offsetForLocation and all their uses


Modified: trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.h (139495 => 139496)

--- trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.h	2013-01-11 22:15:54 UTC (rev 139495)
+++ trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.h	2013-01-11 22:18:27 UTC (rev 139496)
@@ -39,7 +39,7 @@
 
 namespace JSC { namespace DFG {
 
-typedef void (*V_DFGDebugOperation_EP)(ExecState*, void*);
+typedef void (*V_DFGDebugOperation_EPP)(ExecState*, void*, void*);
 
 class AssemblyHelpers : public MacroAssembler {
 public:
@@ -170,7 +170,7 @@
 }
 
 // Add a debug call. This call has no effect on JIT code execution state.
-void debugCall(V_DFGDebugOperation_EP function, void* argument)
+void debugCall(V_DFGDebugOperation_EPP function, void* argument)
 {
 size_t scratchSize = sizeof(EncodedJSValue) * (GPRInfo::numberOfRegisters + FPRInfo::numberOfRegisters);
 ScratchBuffer* scratchBuffer = m_globalData-scratchBufferForSize(scratchSize);
@@ -194,12 +194,14 @@
 storePtr(TrustedImmPtr(scratchSize), GPRInfo::regT0);
 
 #if CPU(X86_64) || CPU(ARM)
+move(TrustedImmPtr(buffer), GPRInfo::argumentGPR2);
 move(TrustedImmPtr(argument), GPRInfo::argumentGPR1);
 move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
 GPRReg scratch = selectScratchGPR(GPRInfo::argumentGPR0, GPRInfo::argumentGPR1);
 #elif CPU(X86)
 poke(GPRInfo::callFrameRegister, 0);
 poke(TrustedImmPtr(argument), 1);
+poke(TrustedImmPtr(buffer), 2);
 GPRReg scratch = GPRInfo::regT0;
 #else
 #error DFG JIT not supported on this platform.


Modified: trunk/Source/_javascript_Core/dfg/DFGCommon.h (139495 => 139496)

--- trunk/Source/_javascript_Core/dfg/DFGCommon.h	2013-01-11 22:15:54 UTC (rev 139495)
+++ trunk/Source/_javascript_Core/dfg/DFGCommon.h	2013-01-11 22:18:27 UTC (rev 139496)
@@ -70,8 +70,6 @@
 #define DFG_ENABLE_XOR_DEBUG_AID 0
 // Emit a breakpoint into the speculation failure code.
 #define DFG_ENABLE_JIT_BREAK_ON_SPECULATION_FAILURE 0
-// Log every speculation failure.
-#define DFG_ENABLE_VERBOSE_SPECULATION_FAILURE 0
 // Disable the DFG JIT without having to touch Platform.h
 #define DFG_DEBUG_LOCAL_DISBALE 0
 // Enable OSR entry from baseline JIT.


Modified: trunk/Source/_javascript_Core/dfg/DFGOSRExit.h (139495 => 139496)

--- trunk/Source/_javascript_Core/dfg/DFGOSRExit.h	2013-01-11 22:15:54 UTC (rev 139495)
+++ trunk/Source/_javascript_Core/dfg/DFGOSRExit.h	2013-01-11 22:18:27 UTC (rev 139496)
@@ -122,12 +122,10 @@
 bool considerAddingAsFrequentExitSiteSlow(CodeBlock* dfgCodeBlock, CodeBlock* profiledCodeBlock);
 };
 
-#if

[webkit-changes] [139497] trunk/Source/WebCore

2013-01-11 Thread tonyg

Title: [139497] trunk/Source/WebCore








Revision 139497
Author to...@chromium.org
Date 2013-01-11 14:20:13 -0800 (Fri, 11 Jan 2013)


Log Message
We should be able to checkpoint and restore the HTMLTokenizer across threads
https://bugs.webkit.org/show_bug.cgi?id=106597

Based on patch by Adam Barth.

This has the ability to create a checkpoint any time the parser is blocked on a script.
We clear m_appropriateEndTagName after each end tag is flushed so that the ASSERT in
canCreateCheckpoint() will pass.

Reviewed by Adam Barth.

No new tests because no new functionality.

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/HTMLDocumentParser.h:
(WebCore):
(HTMLDocumentParser):
* html/parser/HTMLTokenizer.cpp:
(WebCore):
(WebCore::HTMLTokenizer::canCreateCheckpoint):
(WebCore::HTMLTokenizer::createCheckpoint):
(WebCore::HTMLTokenizer::restoreFromCheckpoint):
* html/parser/HTMLTokenizer.h:
(HTMLTokenizer):
(Checkpoint):
(WebCore::HTMLTokenizer::Checkpoint::Checkpoint):
* xml/parser/MarkupTokenizerBase.h:
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::InputStreamPreprocessor):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::skipNextNewLine):
(InputStreamPreprocessor):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::reset):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp
trunk/Source/WebCore/html/parser/HTMLTokenizer.h
trunk/Source/WebCore/xml/parser/MarkupTokenizerBase.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139496 => 139497)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 22:18:27 UTC (rev 139496)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 22:20:13 UTC (rev 139497)
@@ -1,3 +1,39 @@
+2013-01-11  Tony Gentilcore  to...@chromium.org
+
+We should be able to checkpoint and restore the HTMLTokenizer across threads
+https://bugs.webkit.org/show_bug.cgi?id=106597
+
+Based on patch by Adam Barth.
+
+This has the ability to create a checkpoint any time the parser is blocked on a script.
+We clear m_appropriateEndTagName after each end tag is flushed so that the ASSERT in
+canCreateCheckpoint() will pass.
+
+Reviewed by Adam Barth.
+
+No new tests because no new functionality.
+
+* html/parser/HTMLDocumentParser.cpp:
+(WebCore::HTMLDocumentParser::HTMLDocumentParser):
+(WebCore::HTMLDocumentParser::pumpTokenizer):
+* html/parser/HTMLDocumentParser.h:
+(WebCore):
+(HTMLDocumentParser):
+* html/parser/HTMLTokenizer.cpp:
+(WebCore):
+(WebCore::HTMLTokenizer::canCreateCheckpoint):
+(WebCore::HTMLTokenizer::createCheckpoint):
+(WebCore::HTMLTokenizer::restoreFromCheckpoint):
+* html/parser/HTMLTokenizer.h:
+(HTMLTokenizer):
+(Checkpoint):
+(WebCore::HTMLTokenizer::Checkpoint::Checkpoint):
+* xml/parser/MarkupTokenizerBase.h:
+(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::InputStreamPreprocessor):
+(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::skipNextNewLine):
+(InputStreamPreprocessor):
+(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::reset):
+
 2013-01-11  Tony Chang  t...@chromium.org
 
 [chromium] Don't regenerate all bindings when any idl file changes


Modified: trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp (139496 => 139497)

--- trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp	2013-01-11 22:18:27 UTC (rev 139496)
+++ trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp	2013-01-11 22:20:13 UTC (rev 139497)
@@ -136,6 +136,41 @@
 m_additionalAllowedCharacter = '\0';
 }
 
+#if ENABLE(THREADED_HTML_PARSER)
+
+bool HTMLTokenizer::canCreateCheckpoint() const
+{
+if (!m_appropriateEndTagName.isEmpty())
+return false;
+if (!m_temporaryBuffer.isEmpty())
+return false;
+if (!m_bufferedEndTagName.isEmpty())
+return false;
+return true;
+}
+
+void HTMLTokenizer::createCheckpoint(Checkpoint result) const
+{
+ASSERT(canCreateCheckpoint());
+result.options = m_options;
+result.state = m_state;
+result.additionalAllowedCharacter = m_additionalAllowedCharacter;
+result.skipNextNewLine = m_inputStreamPreprocessor.skipNextNewLine();
+result.shouldAllowCDATA = m_shouldAllowCDATA;
+}
+
+void HTMLTokenizer::restoreFromCheckpoint(const Checkpoint checkpoint)
+{
+m_token = 0;
+m_options = checkpoint.options;
+m_state = checkpoint.state;
+m_additionalAllowedCharacter = checkpoint.additionalAllowedCharacter;
+m_inputStreamPreprocessor.reset(checkpoint.skipNextNewLine);
+m_shouldAllowCDATA = checkpoint.shouldAllowCDATA;
+}
+
+#endif
+
 inline bool HTMLTokenizer::processEntity(SegmentedString source)
 {
 bool notEnoughCharacters = false;
@@ -161,6 +196,7 @@
 return true;

[webkit-changes] [139499] trunk/LayoutTests

2013-01-11 Thread schenney

Title: [139499] trunk/LayoutTests








Revision 139499
Author schen...@chromium.org
Date 2013-01-11 14:30:43 -0800 (Fri, 11 Jan 2013)


Log Message
[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

Mac 10.6 and 10.7 results that are the last to be failing on those bots.

* platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/fallback-traits-fixup-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/hidpi: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/text/fallback-traits-fixup-expected.png


Added Paths

trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/hidpi/
trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (139498 => 139499)

--- trunk/LayoutTests/ChangeLog	2013-01-11 22:26:24 UTC (rev 139498)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 22:30:43 UTC (rev 139499)
@@ -4,6 +4,20 @@
 
 Unreviewed test expectations update.
 
+Mac 10.6 and 10.7 results that are the last to be failing on those bots.
+
+* platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
+* platform/chromium-mac-snowleopard/fast/text/fallback-traits-fixup-expected.png:
+* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/hidpi: Added.
+* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
+* platform/chromium-mac/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
+
+2013-01-11  Stephen Chenney  schen...@chromium.org
+
+[Chromium] More test expectations for Skia changes
+
+Unreviewed test expectations update.
+
 Mac 10.8 results that were not ready when the other mac results were updated.
 
 * platform/chromium-mac-lion/editing/selection/iframe-expected.png:


Added: trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png
___

Added: svn:mime-type

Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/text/fallback-traits-fixup-expected.png

(Binary files differ)


Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139502] trunk

2013-01-11 Thread rafaelw

Title: [139502] trunk








Revision 139502
Author rafa...@chromium.org
Date 2013-01-11 14:45:35 -0800 (Fri, 11 Jan 2013)


Log Message
Prevent HTMLPreloadScanner from fetching resources inside template
https://bugs.webkit.org/show_bug.cgi?id=106687

Reviewed by Adam Barth.

Source/WebCore:

This patch adds a simple counter to the preload scanner which increments on template start
tag and decrements on template element. It only fetchs resources when the counter is at zero
(i.e. for elements not contained by a template element).

Test re-enabled within fast/dom/HTMLTemplateElement/inertContents.html

* html/parser/HTMLPreloadScanner.cpp:
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
(WebCore::HTMLPreloadScanner::processToken):
* html/parser/HTMLPreloadScanner.h:
(HTMLPreloadScanner):

LayoutTests:

* fast/dom/HTMLTemplateElement/inertContents-expected.txt:
* fast/dom/HTMLTemplateElement/inertContents.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents-expected.txt
trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp
trunk/Source/WebCore/html/parser/HTMLPreloadScanner.h




Diff

Modified: trunk/LayoutTests/ChangeLog (139501 => 139502)

--- trunk/LayoutTests/ChangeLog	2013-01-11 22:42:45 UTC (rev 139501)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 22:45:35 UTC (rev 139502)
@@ -1,3 +1,13 @@
+2013-01-11  Rafael Weinstein  rafa...@chromium.org
+
+Prevent HTMLPreloadScanner from fetching resources inside template
+https://bugs.webkit.org/show_bug.cgi?id=106687
+
+Reviewed by Adam Barth.
+
+* fast/dom/HTMLTemplateElement/inertContents-expected.txt:
+* fast/dom/HTMLTemplateElement/inertContents.html:
+
 2013-01-11  Stephen Chenney  schen...@chromium.org
 
 [Chromium] More test expectations for Skia changes


Modified: trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents-expected.txt (139501 => 139502)

--- trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents-expected.txt	2013-01-11 22:42:45 UTC (rev 139501)
+++ trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents-expected.txt	2013-01-11 22:45:35 UTC (rev 139502)
@@ -1,11 +1,7 @@
-The test asserts that elements within template contents are inert, e.g. script does not run.
+http://foo.com/shouldLoad.jpg - willSendRequest NSURLRequest URL http://foo.com/shouldLoad.jpg, main document URL inertContents.html, http method GET redirectResponse (null)
+Blocked access to external URL http://foo.com/shouldLoad.jpg
+http://foo.com/shouldLoad.jpg - didFailLoadingWithError: NSError domain NSURLErrorDomain, code -999, failing URL (null)
+The test asserts that elements within template contents are inert, e.g. resources do not fetch, script does not run.
 
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+Before template content insertion: script did not run, after template content insertion: script did run.
 
-
-PASS testVal is script has not run
-PASS testVal is script has run
-PASS successfullyParsed is true
-
-TEST COMPLETE
-


Modified: trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents.html (139501 => 139502)

--- trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents.html	2013-01-11 22:42:45 UTC (rev 139501)
+++ trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents.html	2013-01-11 22:45:35 UTC (rev 139502)
@@ -1,17 +1,29 @@
-!DOCTYPE html
 body
-script src=""
+pThe test asserts that elements within template contents are inert, e.g. resources do not fetch, script does not run./p
+template id=templatescriptwindow.testVal = script did run;/scriptimg src=""
+div id=output
+/div
+
 script
-var testVal = 'script has not run';
+var testVal = script did not run;
+
+window._onload_ = function() {
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.dumpResourceLoadCallbacks();
+}
+
+var output = document.getElementById('output');
+output.innerHTML = 'Before template content insertion: ' + testVal;
+
+var templateContent = document.getElementById('template').content;
+var img = templateContent.childNodes[1];
+img.src = ""
+document.body.appendChild(templateContent);
+
+output.innerHTML += ', after template content insertion: ' + testVal + '.';
+}
 /script
-!-- FIXME: Add non-flaky test for img tags --
-templatescriptwindow.testVal = 'script has run';/script/template
-script
-description('The test asserts that elements within template contents are inert, e.g. script does not run.');
-shouldBeEqualToString('testVal', 'script has not run');
-var templateContent = document.querySelector('template').content;
-document.body.appendChild(templateContent);
-shouldBeEqualToString('testVal', 'script has run');
-/script
-script src=""
+/head
+body
 /body


Modified: trunk/Source/WebCore/ChangeLog (139501 => 139502)

---

[webkit-changes] [139500] trunk/Source/WebKit2

2013-01-11 Thread mitz

Title: [139500] trunk/Source/WebKit2








Revision 139500
Author m...@apple.com
Date 2013-01-11 14:34:50 -0800 (Fri, 11 Jan 2013)


Log Message
Exclude unused resources.

Reviewed by Darin Adler.

* Configurations/WebKit2.xcconfig: Defined EXCLUDED_SOURCE_FILE_NAMES.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/WebKit2.xcconfig




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139499 => 139500)

--- trunk/Source/WebKit2/ChangeLog	2013-01-11 22:30:43 UTC (rev 139499)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-11 22:34:50 UTC (rev 139500)
@@ -1,3 +1,11 @@
+2013-01-11  Dan Bernstein  m...@apple.com
+
+Exclude unused resources.
+
+Reviewed by Darin Adler.
+
+* Configurations/WebKit2.xcconfig: Defined EXCLUDED_SOURCE_FILE_NAMES.
+
 2013-01-11  Anders Carlsson  ander...@apple.com
 
 Incoming synchronous messages can sometimes arrive out of order


Modified: trunk/Source/WebKit2/Configurations/WebKit2.xcconfig (139499 => 139500)

--- trunk/Source/WebKit2/Configurations/WebKit2.xcconfig	2013-01-11 22:30:43 UTC (rev 139499)
+++ trunk/Source/WebKit2/Configurations/WebKit2.xcconfig	2013-01-11 22:34:50 UTC (rev 139500)
@@ -1,4 +1,4 @@
-// Copyright (C) 2010 Apple Inc. All rights reserved.
+// Copyright (C) 2010, 2013 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -33,3 +33,7 @@
 
 OTHER_LDFLAGS = $(OTHER_LDFLAGS_$(PLATFORM_NAME)) $(OTHER_LDFLAGS);
 OTHER_LDFLAGS_macosx = $(FRAMEWORK_AND_LIBRARY_LDFLAGS);
+
+EXCLUDED_SOURCE_FILE_NAMES = $(EXCLUDED_SOURCE_FILE_NAMES_$(PLATFORM_NAME));
+EXCLUDED_SOURCE_FILE_NAMES_iphoneos = *.pdf;
+EXCLUDED_SOURCE_FILE_NAMES_iphonesimulator = $(EXCLUDED_SOURCE_FILE_NAMES_iphoneos);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139503] trunk

2013-01-11 Thread commit-queue

Title: [139503] trunk








Revision 139503
Author commit-qu...@webkit.org
Date 2013-01-11 14:52:31 -0800 (Fri, 11 Jan 2013)


Log Message
Unreviewed, rolling out r139044.
http://trac.webkit.org/changeset/139044
https://bugs.webkit.org/show_bug.cgi?id=106702

Caused various scrolling anomolies on Mac with drag and drop
(Requested by smfr on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2013-01-11

Source/WebCore:

* page/AutoscrollController.cpp:
(WebCore::AutoscrollController::AutoscrollController):
(WebCore::AutoscrollController::autoscrollTimerFired):
* page/AutoscrollController.h:
(WebCore):
(AutoscrollController):
* page/EventHandler.cpp:
(WebCore::EventHandler::updateDragAndDrop):
* rendering/RenderBox.cpp:
(WebCore):
(WebCore::RenderBox::autoscroll):
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::autoscroll):
* rendering/RenderLayer.h:
(RenderLayer):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::autoscroll):
* rendering/RenderListBox.h:
(RenderListBox):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::autoscroll):
* rendering/RenderTextControlSingleLine.h:
(RenderTextControlSingleLine):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::dragSourceEndedAt):
(WebKit::WebViewImpl::dragSourceMovedTo):
(WebKit::WebViewImpl::dragTargetDrop):
(WebKit::WebViewImpl::dragTargetDragEnterOrOver):
* src/WebViewImpl.h:
(WebKit):

LayoutTests:

* fast/events/drag-and-drop-autoscroll-expected.txt: Removed.
* fast/events/drag-and-drop-autoscroll.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/AutoscrollController.cpp
trunk/Source/WebCore/page/AutoscrollController.h
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderListBox.cpp
trunk/Source/WebCore/rendering/RenderListBox.h
trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp
trunk/Source/WebCore/rendering/RenderTextControlSingleLine.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h


Removed Paths

trunk/LayoutTests/fast/events/drag-and-drop-autoscroll-expected.txt
trunk/LayoutTests/fast/events/drag-and-drop-autoscroll.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139502 => 139503)

--- trunk/LayoutTests/ChangeLog	2013-01-11 22:45:35 UTC (rev 139502)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 22:52:31 UTC (rev 139503)
@@ -1,3 +1,15 @@
+2013-01-11  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r139044.
+http://trac.webkit.org/changeset/139044
+https://bugs.webkit.org/show_bug.cgi?id=106702
+
+Caused various scrolling anomolies on Mac with drag and drop
+(Requested by smfr on #webkit).
+
+* fast/events/drag-and-drop-autoscroll-expected.txt: Removed.
+* fast/events/drag-and-drop-autoscroll.html: Removed.
+
 2013-01-11  Rafael Weinstein  rafa...@chromium.org
 
 Prevent HTMLPreloadScanner from fetching resources inside template


Deleted: trunk/LayoutTests/fast/events/drag-and-drop-autoscroll-expected.txt (139502 => 139503)

--- trunk/LayoutTests/fast/events/drag-and-drop-autoscroll-expected.txt	2013-01-11 22:45:35 UTC (rev 139502)
+++ trunk/LayoutTests/fast/events/drag-and-drop-autoscroll-expected.txt	2013-01-11 22:52:31 UTC (rev 139503)
@@ -1,8 +0,0 @@
-Check autoscroll by drag-and-drop
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-
-PASS scrollable.scrollTop  0
-For manual testing, drag and drop Drop Me to Scrollable area.
-


Deleted: trunk/LayoutTests/fast/events/drag-and-drop-autoscroll.html (139502 => 139503)

--- trunk/LayoutTests/fast/events/drag-and-drop-autoscroll.html	2013-01-11 22:45:35 UTC (rev 139502)
+++ trunk/LayoutTests/fast/events/drag-and-drop-autoscroll.html	2013-01-11 22:52:31 UTC (rev 139503)
@@ -1,101 +0,0 @@
-html
-head
-style type=text/css
-#draggable {
-  padding: 5pt;
-  border: 3px solid #00cc00;
-  background: #00;
-  width: 80px;
-  cursor: hand;
-}
-
-#scrollable {
-height: 200px;
-overflow: auto;
-border: solid 3px #cc;
-}
-/style
-script
-function $(id) { return document.getElementById(id); }
-
-function finishTest() {
-eventSender.mouseUp();
-$('container').innerHTML = '';
-window.testRunner.notifyDone();
-}
-
-function testIt() {
-var draggable = $('draggable');
-var scrollable = $('scrollable');
-
-if (!window.eventSender)
-return;
-
-eventSender.dragMode = false;
-
-// Grab draggable
-eventSender.mouseMoveTo(draggable.offsetLeft + 5, draggable.offsetTop + 5);
-eventSender.mouseDown();
-
-// Move mouse to

[webkit-changes] [139504] trunk/LayoutTests

2013-01-11 Thread kbr

Title: [139504] trunk/LayoutTests








Revision 139504
Author k...@google.com
Date 2013-01-11 14:56:34 -0800 (Fri, 11 Jan 2013)


Log Message
[Chromium] Layout Test fast/canvas/webgl/context-release-upon-reload.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=106606

Reviewed by Dimitri Glazkov.

Reduced number of iterations of test, and marked as slow. Changed
test's output and expectations so number of iterations can be
adjusted without rebaselining.

* fast/canvas/webgl/context-release-upon-reload-expected.txt:
* fast/canvas/webgl/context-release-upon-reload.html:
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/canvas/webgl/context-release-upon-reload-expected.txt
trunk/LayoutTests/fast/canvas/webgl/context-release-upon-reload.html
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139503 => 139504)

--- trunk/LayoutTests/ChangeLog	2013-01-11 22:52:31 UTC (rev 139503)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 22:56:34 UTC (rev 139504)
@@ -1,3 +1,18 @@
+2013-01-11  Kenneth Russell  k...@google.com
+
+[Chromium] Layout Test fast/canvas/webgl/context-release-upon-reload.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=106606
+
+Reviewed by Dimitri Glazkov.
+
+Reduced number of iterations of test, and marked as slow. Changed
+test's output and expectations so number of iterations can be
+adjusted without rebaselining.
+
+* fast/canvas/webgl/context-release-upon-reload-expected.txt:
+* fast/canvas/webgl/context-release-upon-reload.html:
+* platform/chromium/TestExpectations:
+
 2013-01-11  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r139044.


Modified: trunk/LayoutTests/fast/canvas/webgl/context-release-upon-reload-expected.txt (139503 => 139504)

--- trunk/LayoutTests/fast/canvas/webgl/context-release-upon-reload-expected.txt	2013-01-11 22:52:31 UTC (rev 139503)
+++ trunk/LayoutTests/fast/canvas/webgl/context-release-upon-reload-expected.txt	2013-01-11 22:56:34 UTC (rev 139504)
@@ -3,56 +3,7 @@
 
 On success, you will see a series of PASS messages, followed by TEST COMPLETE.
 
-
-Test 1 of 10
-PASS context was created properly
-PASS getError was expected value: NO_ERROR : Should be no errors
-PASS Buffer was the correct size: 1680x1050
-
-Test 2 of 10
-PASS context was created properly
-PASS getError was expected value: NO_ERROR : Should be no errors
-PASS Buffer was the correct size: 1680x1050
-
-Test 3 of 10
-PASS context was created properly
-PASS getError was expected value: NO_ERROR : Should be no errors
-PASS Buffer was the correct size: 1680x1050
-
-Test 4 of 10
-PASS context was created properly
-PASS getError was expected value: NO_ERROR : Should be no errors
-PASS Buffer was the correct size: 1680x1050
-
-Test 5 of 10
-PASS context was created properly
-PASS getError was expected value: NO_ERROR : Should be no errors
-PASS Buffer was the correct size: 1680x1050
-
-Test 6 of 10
-PASS context was created properly
-PASS getError was expected value: NO_ERROR : Should be no errors
-PASS Buffer was the correct size: 1680x1050
-
-Test 7 of 10
-PASS context was created properly
-PASS getError was expected value: NO_ERROR : Should be no errors
-PASS Buffer was the correct size: 1680x1050
-
-Test 8 of 10
-PASS context was created properly
-PASS getError was expected value: NO_ERROR : Should be no errors
-PASS Buffer was the correct size: 1680x1050
-
-Test 9 of 10
-PASS context was created properly
-PASS getError was expected value: NO_ERROR : Should be no errors
-PASS Buffer was the correct size: 1680x1050
-
-Test 10 of 10
-PASS context was created properly
-PASS getError was expected value: NO_ERROR : Should be no errors
-PASS Buffer was the correct size: 1680x1050
+PASS All drawing buffers were allocated at the correct size
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/fast/canvas/webgl/context-release-upon-reload.html (139503 => 139504)

--- trunk/LayoutTests/fast/canvas/webgl/context-release-upon-reload.html	2013-01-11 22:52:31 UTC (rev 139503)
+++ trunk/LayoutTests/fast/canvas/webgl/context-release-upon-reload.html	2013-01-11 22:56:34 UTC (rev 139504)
@@ -20,33 +20,48 @@
 }
 
 var host = document.getElementById(host);
-var testIterations = 10;
+var testIterations = 8;
 var currentIteration = 0;
 
 function refreshFrame() {
   if(currentIteration  testIterations) {
 currentIteration++;
-debug();
-debug(Test  + currentIteration +  of  + testIterations);
 host.src = ""
   } else {
+testPassed(All drawing buffers were allocated at the correct size);
 finishTest();
   }
 }
 
 function testContext() {
+  var bail = false;
   var gl = host.contentWindow.glContext;
-  assertMsg(gl != null, context was created properly);
+  if (gl == null) {
+bail = true;
+testFailed(context was not created properly);

[webkit-changes] [139505] trunk/Tools

2013-01-11 Thread rniwa

Title: [139505] trunk/Tools








Revision 139505
Author rn...@webkit.org
Date 2013-01-11 14:57:29 -0800 (Fri, 11 Jan 2013)


Log Message
REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
https://bugs.webkit.org/show_bug.cgi?id=106688

Reviewed by Eric Seidel.

Update the regular _expression_ used to strip the garbage at the beginning.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests.nrwt_log_message_regexp):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (139504 => 139505)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2013-01-11 22:56:34 UTC (rev 139504)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2013-01-11 22:57:29 UTC (rev 139505)
@@ -363,7 +363,7 @@
 self.incorrectLayoutLines = incorrectLayoutLines
 
 # FIXME: This will break if new-run-webkit-tests changes its default log formatter.
-nrwt_log_message_regexp = re.compile(r'(?Plog_prefix.*) (?Plog_levelDEBUG|INFO) (?Pmessage.*)')
+nrwt_log_message_regexp = re.compile(r'\d{2}:\d{2}:\d{2}(\.\d+)?\s+\d+\s+(?Pmessage.*)')
 
 def _strip_python_logging_prefix(self, line):
 match_object = self.nrwt_log_message_regexp.match(line)


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py (139504 => 139505)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py	2013-01-11 22:56:34 UTC (rev 139504)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py	2013-01-11 22:57:29 UTC (rev 139505)
@@ -53,11 +53,11 @@
 def test_nrwt_leaks_parsing(self):
 run_webkit_tests = RunWebKitTests()  # pylint is confused by the way we import the module ... pylint: disable-msg=E0602
 log_text = 
-2011-08-09 10:05:18,580 29486 mac.py:275 INFO leaks found for a total of 197,936 bytes!
-2011-08-09 10:05:18,580 29486 mac.py:276 INFO 1 unique leaks found!
+12:44:24.295 77706 13981 total leaks found for a total of 197,936 bytes!
+12:44:24.295 77706 1 unique leaks found!
 
 expected_incorrect_lines = [
-'leaks found for a total of 197,936 bytes!',
+'13981 total leaks found for a total of 197,936 bytes!',
 '1 unique leaks found!',
 ]
 run_webkit_tests._parseNewRunWebKitTestsOutput(log_text)


Modified: trunk/Tools/ChangeLog (139504 => 139505)

--- trunk/Tools/ChangeLog	2013-01-11 22:56:34 UTC (rev 139504)
+++ trunk/Tools/ChangeLog	2013-01-11 22:57:29 UTC (rev 139505)
@@ -1,3 +1,15 @@
+2013-01-11  Ryosuke Niwa  rn...@webkit.org
+
+REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
+https://bugs.webkit.org/show_bug.cgi?id=106688
+
+Reviewed by Eric Seidel.
+
+Update the regular _expression_ used to strip the garbage at the beginning.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(RunWebKitTests.nrwt_log_message_regexp):
+
 2013-01-11  Pratik Solanki  psola...@apple.com
 
 TestRunner leaks when running tests






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139506] trunk/Source/JavaScriptCore

2013-01-11 Thread fpizlo

Title: [139506] trunk/Source/_javascript_Core








Revision 139506
Author fpi...@apple.com
Date 2013-01-11 15:04:35 -0800 (Fri, 11 Jan 2013)


Log Message
Add a run-time option to print bytecode at DFG compile time
https://bugs.webkit.org/show_bug.cgi?id=106704

Reviewed by Mark Hahnenberg.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseCodeBlock):
* runtime/Options.h:
(JSC):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/runtime/Options.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (139505 => 139506)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-11 22:57:29 UTC (rev 139505)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-11 23:04:35 UTC (rev 139506)
@@ -1,5 +1,17 @@
 2013-01-11  Filip Pizlo  fpi...@apple.com
 
+Add a run-time option to print bytecode at DFG compile time
+https://bugs.webkit.org/show_bug.cgi?id=106704
+
+Reviewed by Mark Hahnenberg.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::parseCodeBlock):
+* runtime/Options.h:
+(JSC):
+
+2013-01-11  Filip Pizlo  fpi...@apple.com
+
 It should be possible to enable verbose printing of each OSR exit at run-time (rather than compile-time) and it should print register state
 https://bugs.webkit.org/show_bug.cgi?id=106700
 


Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (139505 => 139506)

--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2013-01-11 22:57:29 UTC (rev 139505)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2013-01-11 23:04:35 UTC (rev 139506)
@@ -31,6 +31,7 @@
 #include ArrayConstructor.h
 #include CallLinkStatus.h
 #include CodeBlock.h
+#include CodeBlockWithJITType.h
 #include DFGArrayMode.h
 #include DFGCapabilities.h
 #include GetByIdStatus.h
@@ -3641,15 +3642,24 @@
 *m_globalData-m_perBytecodeProfiler, m_inlineStackTop-m_profiledBlock);
 }
 
+bool shouldDumpBytecode = Options::dumpBytecodeAtDFGTime();
 #if DFG_ENABLE(DEBUG_VERBOSE)
-dataLog(
-Parsing , *codeBlock,
-: captureCount = , codeBlock-symbolTable() ? codeBlock-symbolTable()-captureCount() : 0,
-, needsFullScopeChain = , codeBlock-needsFullScopeChain(),
-, needsActivation = , codeBlock-ownerExecutable()-needsActivation(),
-, isStrictMode = , codeBlock-ownerExecutable()-isStrictMode(), \n);
-codeBlock-baselineVersion()-dumpBytecode();
+shouldDumpBytecode |= true;
 #endif
+if (shouldDumpBytecode) {
+dataLog(Parsing , *codeBlock);
+if (m_inlineStackTop-m_inlineCallFrame) {
+dataLog(
+ for inlining at , CodeBlockWithJITType(m_codeBlock, JITCode::DFGJIT),
+ , m_inlineStackTop-m_inlineCallFrame-caller);
+}
+dataLog(
+: captureCount = , codeBlock-symbolTable() ? codeBlock-symbolTable()-captureCount() : 0,
+, needsFullScopeChain = , codeBlock-needsFullScopeChain(),
+, needsActivation = , codeBlock-ownerExecutable()-needsActivation(),
+, isStrictMode = , codeBlock-ownerExecutable()-isStrictMode(), \n);
+codeBlock-baselineVersion()-dumpBytecode();
+}
 
 for (unsigned jumpTargetIndex = 0; jumpTargetIndex = codeBlock-numberOfJumpTargets(); ++jumpTargetIndex) {
 // The maximum bytecode offset to go into the current basicblock is either the next jump target, or the end of the instructions.


Modified: trunk/Source/_javascript_Core/runtime/Options.h (139505 => 139506)

--- trunk/Source/_javascript_Core/runtime/Options.h	2013-01-11 22:57:29 UTC (rev 139505)
+++ trunk/Source/_javascript_Core/runtime/Options.h	2013-01-11 23:04:35 UTC (rev 139506)
@@ -74,7 +74,7 @@
 v(bool, showDisassembly, false) \
 v(bool, showDFGDisassembly, false) \
 v(bool, showAllDFGNodes, false) \
-\
+v(bool, dumpBytecodeAtDFGTime, false) \
 v(bool, printEachOSRExit, false) \
 \
 v(bool, enableProfiler, false) \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139507] branches/safari-536.28-branch/Tools/BuildSlaveSupport/ delete-stale-build-files

2013-01-11 Thread rniwa

Title: [139507] branches/safari-536.28-branch/Tools/BuildSlaveSupport/delete-stale-build-files








Revision 139507
Author rn...@webkit.org
Date 2013-01-11 15:08:04 -0800 (Fri, 11 Jan 2013)


Log Message
Copy delete-stable-build-files into this branch as needed.

Added Paths

branches/safari-536.28-branch/Tools/BuildSlaveSupport/delete-stale-build-files




Diff

Copied: branches/safari-536.28-branch/Tools/BuildSlaveSupport/delete-stale-build-files (from rev 139506, trunk/Tools/BuildSlaveSupport/delete-stale-build-files) (0 => 139507)

--- branches/safari-536.28-branch/Tools/BuildSlaveSupport/delete-stale-build-files	(rev 0)
+++ branches/safari-536.28-branch/Tools/BuildSlaveSupport/delete-stale-build-files	2013-01-11 23:08:04 UTC (rev 139507)
@@ -0,0 +1,82 @@
+#!/usr/bin/python
+# Copyright (C) 2013 Apple Inc.  All rights reserved.
+# Copyright (C) 2012 Google Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+#
+# 1.  Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2.  Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS AS IS AND ANY
+# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import optparse
+import os
+import subprocess
+import sys
+
+
+def main():
+parser = optparse.OptionParser(usage: %prog [options])
+parser.add_option(--platform, dest=platform)
+parser.add_option(--debug, action="" const=debug, dest=configuration)
+parser.add_option(--release, action="" const=release, dest=configuration)
+
+options, parameters = parser.parse_args()
+if not options.platform:
+parser.error(Platform is required)
+return -1
+if not options.configuration:
+parser.error(Configuration is required)
+return -2
+
+genericPlatform = options.platform.split('-', 1)[0]
+if genericPlatform != 'mac':
+print 'Exited without removing any files.'
+return 0
+
+directory = webkitBuildDirectory(genericPlatform, options.configuration)
+exit_code = 0
+
+for root, _, files in os.walk(directory):
+for name in files:
+full_path = os.path.join(root, name)
+ext = os.path.splitext(full_path)[1]
+
+try:
+if ext in ('.dep', '.timestamp', '.txt', '.html', '.js', '.generated') or os.path.getsize(full_path):
+continue
+except OSError as exception:
+print exception
+continue
+
+try:
+os.remove(full_path)
+print 'Removed', full_path
+except OSError as exception:
+print exception
+exit_code += 1
+
+return exit_code
+
+
+def webkitBuildDirectory(platform, configuration):
+return subprocess.Popen(['perl', os.path.join(os.path.dirname(__file__), .., Scripts, webkit-build-directory),
+-- + platform, -- + configuration, '--top-level'], stdout=subprocess.PIPE).communicate()[0].strip()
+
+
+if __name__ == '__main__':
+sys.exit(main())


Property changes: branches/safari-536.28-branch/Tools/BuildSlaveSupport/delete-stale-build-files



Added: svn:executable

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139508] trunk/Source/JavaScriptCore

2013-01-11 Thread mhahnenberg

Title: [139508] trunk/Source/_javascript_Core








Revision 139508
Author mhahnenb...@apple.com
Date 2013-01-11 15:09:37 -0800 (Fri, 11 Jan 2013)


Log Message
testapi is failing with a block-related error in the Objc API
https://bugs.webkit.org/show_bug.cgi?id=106055

Reviewed by Filip Pizlo.

Same bug as in testapi.mm. We need to actually call the static block, rather than casting the block to a bool.

* API/ObjCCallbackFunction.mm:
(blockSignatureContainsClass):

Modified Paths

trunk/Source/_javascript_Core/API/ObjCCallbackFunction.mm
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/API/ObjCCallbackFunction.mm (139507 => 139508)

--- trunk/Source/_javascript_Core/API/ObjCCallbackFunction.mm	2013-01-11 23:08:04 UTC (rev 139507)
+++ trunk/Source/_javascript_Core/API/ObjCCallbackFunction.mm	2013-01-11 23:09:37 UTC (rev 139508)
@@ -549,7 +549,7 @@
 static bool containsClass = ^{
 id block = ^(NSString *string){ return string; };
 return _Block_has_signature(block)  strstr(_Block_signature(block), NSString);
-};
+}();
 return containsClass;
 }
 


Modified: trunk/Source/_javascript_Core/ChangeLog (139507 => 139508)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-11 23:08:04 UTC (rev 139507)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-11 23:09:37 UTC (rev 139508)
@@ -1,3 +1,15 @@
+2013-01-11  Mark Hahnenberg  mhahnenb...@apple.com
+
+testapi is failing with a block-related error in the Objc API
+https://bugs.webkit.org/show_bug.cgi?id=106055
+
+Reviewed by Filip Pizlo.
+
+Same bug as in testapi.mm. We need to actually call the static block, rather than casting the block to a bool.
+
+* API/ObjCCallbackFunction.mm:
+(blockSignatureContainsClass):
+
 2013-01-11  Filip Pizlo  fpi...@apple.com
 
 Add a run-time option to print bytecode at DFG compile time






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139509] trunk

2013-01-11 Thread simonjam

Title: [139509] trunk








Revision 139509
Author simon...@chromium.org
Date 2013-01-11 15:18:06 -0800 (Fri, 11 Jan 2013)


Log Message
Restore old semantics to webkitRequestAnimationFrame callbacks
https://bugs.webkit.org/show_bug.cgi?id=106697

Reviewed by James Robinson.

Source/WebCore:

Sites that use GWT = 2.4 are buggy and rely on Date.now()-like callback values.
We'll restore that behavior to the prefixed version of webkitRequestAnimationFrame.
requestAnimationFrame will continue to follow the spec.

Test: fast/animation/request-animation-frame-prefix.html

* dom/RequestAnimationFrameCallback.h:
(RequestAnimationFrameCallback):
* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::requestAnimationFrame):
(WebCore):
(WebCore::DOMWindow::webkitRequestAnimationFrame):
* page/DOMWindow.h:
(DOMWindow):
* page/DOMWindow.idl:

LayoutTests:

* fast/animation/request-animation-frame-prefix-expected.txt: Added.
* fast/animation/request-animation-frame-prefix.html: Added.
* fast/animation/script-tests/request-animation-frame-prefix.js: Added.
(busyWait):
(window.webkitRequestAnimationFrame):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/RequestAnimationFrameCallback.h
trunk/Source/WebCore/dom/ScriptedAnimationController.cpp
trunk/Source/WebCore/page/DOMWindow.cpp
trunk/Source/WebCore/page/DOMWindow.h
trunk/Source/WebCore/page/DOMWindow.idl


Added Paths

trunk/LayoutTests/fast/animation/request-animation-frame-prefix-expected.txt
trunk/LayoutTests/fast/animation/request-animation-frame-prefix.html
trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-prefix.js




Diff

Modified: trunk/LayoutTests/ChangeLog (139508 => 139509)

--- trunk/LayoutTests/ChangeLog	2013-01-11 23:09:37 UTC (rev 139508)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 23:18:06 UTC (rev 139509)
@@ -1,3 +1,16 @@
+2013-01-11  James Simonsen  simon...@chromium.org
+
+Restore old semantics to webkitRequestAnimationFrame callbacks
+https://bugs.webkit.org/show_bug.cgi?id=106697
+
+Reviewed by James Robinson.
+
+* fast/animation/request-animation-frame-prefix-expected.txt: Added.
+* fast/animation/request-animation-frame-prefix.html: Added.
+* fast/animation/script-tests/request-animation-frame-prefix.js: Added.
+(busyWait):
+(window.webkitRequestAnimationFrame):
+
 2013-01-11  Kenneth Russell  k...@google.com
 
 [Chromium] Layout Test fast/canvas/webgl/context-release-upon-reload.html is a flaky timeout


Added: trunk/LayoutTests/fast/animation/request-animation-frame-prefix-expected.txt (0 => 139509)

--- trunk/LayoutTests/fast/animation/request-animation-frame-prefix-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-prefix-expected.txt	2013-01-11 23:18:06 UTC (rev 139509)
@@ -0,0 +1,9 @@
+Tests the timestamps provided to prefixed webkitRequestAnimationFrame callbacks
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS legacyFirstTimestamp is = firstTimestamp
+PASS legacySecondTimestamp is = secondTimestamp
+PASS deltaError  0.001 is true
+


Added: trunk/LayoutTests/fast/animation/request-animation-frame-prefix.html (0 => 139509)

--- trunk/LayoutTests/fast/animation/request-animation-frame-prefix.html	(rev 0)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-prefix.html	2013-01-11 23:18:06 UTC (rev 139509)
@@ -0,0 +1,11 @@
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body
+span id=e/span
+span id=f/span
+script src=""
+/body
+/html


Added: trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-prefix.js (0 => 139509)

--- trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-prefix.js	(rev 0)
+++ trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-prefix.js	2013-01-11 23:18:06 UTC (rev 139509)
@@ -0,0 +1,46 @@
+description(Tests the timestamps provided to prefixed webkitRequestAnimationFrame callbacks);
+
+var firstTimestamp = undefined;
+var secondTimestamp = undefined;
+var legacyFirstTimestamp = undefined;
+var legacySecondTimestamp = undefined;
+var deltaError = undefined;
+
+function busyWait(millis) {
+var start = Date.now();
+while (Date.now()-start  millis) {}
+}
+
+window.requestAnimationFrame(function(timestamp) {
+firstTimestamp = timestamp;
+});
+
+window.webkitRequestAnimationFrame(function(timestamp) {
+legacyFirstTimestamp = timestamp;
+
+window.requestAnimationFrame(function(timestamp) {
+secondTimestamp = timestamp;
+});
+
+window.webkitRequestAnimationFrame(function(timestamp) {
+legacySecondTimestamp = timestamp;
+
+shouldBeGreaterThanOrEqual(legacyFirstTimestamp, firstTimestamp);
+

[webkit-changes] [139510] trunk/Source/JavaScriptCore

2013-01-11 Thread psolanki

Title: [139510] trunk/Source/_javascript_Core








Revision 139510
Author psola...@apple.com
Date 2013-01-11 15:32:44 -0800 (Fri, 11 Jan 2013)


Log Message
Fix function name typo ProgramExecutable::initalizeGlobalProperties()
https://bugs.webkit.org/show_bug.cgi?id=106701

Reviewed by Geoffrey Garen.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
* runtime/Executable.cpp:
(JSC::ProgramExecutable::initializeGlobalProperties):
* runtime/Executable.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
trunk/Source/_javascript_Core/runtime/Executable.cpp
trunk/Source/_javascript_Core/runtime/Executable.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (139509 => 139510)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-11 23:18:06 UTC (rev 139509)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-11 23:32:44 UTC (rev 139510)
@@ -1,3 +1,16 @@
+2013-01-11  Pratik Solanki  psola...@apple.com
+
+Fix function name typo ProgramExecutable::initalizeGlobalProperties()
+https://bugs.webkit.org/show_bug.cgi?id=106701
+
+Reviewed by Geoffrey Garen.
+
+* interpreter/Interpreter.cpp:
+(JSC::Interpreter::execute):
+* runtime/Executable.cpp:
+(JSC::ProgramExecutable::initializeGlobalProperties):
+* runtime/Executable.h:
+
 2013-01-11  Mark Hahnenberg  mhahnenb...@apple.com
 
 testapi is failing with a block-related error in the Objc API


Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (139509 => 139510)

--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp	2013-01-11 23:18:06 UTC (rev 139509)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp	2013-01-11 23:32:44 UTC (rev 139510)
@@ -952,7 +952,7 @@
 // object.
 
 // Compile source to bytecode if necessary:
-if (JSObject* error = program-initalizeGlobalProperties(globalData, callFrame, scope))
+if (JSObject* error = program-initializeGlobalProperties(globalData, callFrame, scope))
 return checkedReturn(throwError(callFrame, error));
 
 if (JSObject* error = program-compile(callFrame, scope))


Modified: trunk/Source/_javascript_Core/runtime/Executable.cpp (139509 => 139510)

--- trunk/Source/_javascript_Core/runtime/Executable.cpp	2013-01-11 23:18:06 UTC (rev 139509)
+++ trunk/Source/_javascript_Core/runtime/Executable.cpp	2013-01-11 23:32:44 UTC (rev 139510)
@@ -372,7 +372,7 @@
 return index;
 }
 
-JSObject* ProgramExecutable::initalizeGlobalProperties(JSGlobalData globalData, CallFrame* callFrame, JSScope* scope)
+JSObject* ProgramExecutable::initializeGlobalProperties(JSGlobalData globalData, CallFrame* callFrame, JSScope* scope)
 {
 ASSERT(scope);
 JSGlobalObject* globalObject = scope-globalObject();


Modified: trunk/Source/_javascript_Core/runtime/Executable.h (139509 => 139510)

--- trunk/Source/_javascript_Core/runtime/Executable.h	2013-01-11 23:18:06 UTC (rev 139509)
+++ trunk/Source/_javascript_Core/runtime/Executable.h	2013-01-11 23:32:44 UTC (rev 139510)
@@ -500,7 +500,7 @@
 }
 
 
-JSObject* initalizeGlobalProperties(JSGlobalData, CallFrame*, JSScope*);
+JSObject* initializeGlobalProperties(JSGlobalData, CallFrame*, JSScope*);
 
 static void destroy(JSCell*);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139511] trunk/Source/WebKit/chromium

2013-01-11 Thread tony

Title: [139511] trunk/Source/WebKit/chromium








Revision 139511
Author t...@chromium.org
Date 2013-01-11 15:34:42 -0800 (Fri, 11 Jan 2013)


Log Message
Unreviewed, revert r139157 to fix the chromium build.
These files were deleted in a follow up and since r139044 was reverted, we need to
add back these files.

* WebKit.gyp:
* src/DragScrollTimer.cpp: Added.
(WebKit):
(WebKit::distanceToRect):
(WebKit::DragScrollTimer::DragScrollTimer):
(WebKit::DragScrollTimer::~DragScrollTimer):
(WebKit::DragScrollTimer::stop):
(WebKit::DragScrollTimer::scroll):
(WebKit::DragScrollTimer::update):
(WebKit::DragScrollTimer::triggerScroll):
(WebKit::DragScrollTimer::scrollDistanceFor):
* src/DragScrollTimer.h: Added.
(WebKit):
(DragScrollTimer):
(WebKit::DragScrollTimer::fired):
(WebKit::DragScrollTimer::shouldScroll):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp


Added Paths

trunk/Source/WebKit/chromium/src/DragScrollTimer.cpp
trunk/Source/WebKit/chromium/src/DragScrollTimer.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (139510 => 139511)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-11 23:32:44 UTC (rev 139510)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-11 23:34:42 UTC (rev 139511)
@@ -1,3 +1,26 @@
+2013-01-11  Tony Chang  t...@chromium.org
+
+Unreviewed, revert r139157 to fix the chromium build.
+These files were deleted in a follow up and since r139044 was reverted, we need to
+add back these files.
+
+* WebKit.gyp:
+* src/DragScrollTimer.cpp: Added.
+(WebKit):
+(WebKit::distanceToRect):
+(WebKit::DragScrollTimer::DragScrollTimer):
+(WebKit::DragScrollTimer::~DragScrollTimer):
+(WebKit::DragScrollTimer::stop):
+(WebKit::DragScrollTimer::scroll):
+(WebKit::DragScrollTimer::update):
+(WebKit::DragScrollTimer::triggerScroll):
+(WebKit::DragScrollTimer::scrollDistanceFor):
+* src/DragScrollTimer.h: Added.
+(WebKit):
+(DragScrollTimer):
+(WebKit::DragScrollTimer::fired):
+(WebKit::DragScrollTimer::shouldScroll):
+
 2013-01-11  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r139044.


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (139510 => 139511)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2013-01-11 23:32:44 UTC (rev 139510)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2013-01-11 23:34:42 UTC (rev 139511)
@@ -384,6 +384,8 @@
 'src/DOMUtilitiesPrivate.h',
 'src/DragClientImpl.cpp',
 'src/DragClientImpl.h',
+'src/DragScrollTimer.cpp',
+'src/DragScrollTimer.h',
 'src/EditorClientImpl.cpp',
 'src/EditorClientImpl.h',
 'src/EventListenerWrapper.cpp',


Added: trunk/Source/WebKit/chromium/src/DragScrollTimer.cpp (0 => 139511)

--- trunk/Source/WebKit/chromium/src/DragScrollTimer.cpp	(rev 0)
+++ trunk/Source/WebKit/chromium/src/DragScrollTimer.cpp	2013-01-11 23:34:42 UTC (rev 139511)
@@ -0,0 +1,126 @@
+/*
+ * Copyright (C) 2010 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include config.h
+#include DragScrollTimer.h
+
+#include FrameView.h
+
+using namespace WebCore;
+
+namespace WebKit {
+
+// Computes the distance from a point outside a rect to the nearest edge of the rect.
+static IntSize distanceToRect(const IntPoint

[webkit-changes] [139513] trunk

2013-01-11 Thread simonjam

Title: [139513] trunk








Revision 139513
Author simon...@chromium.org
Date 2013-01-11 15:54:56 -0800 (Fri, 11 Jan 2013)


Log Message
[Resource Timing] XMLHttpRequests should have initiator type 'xmlhttprequest'
https://bugs.webkit.org/show_bug.cgi?id=106409

Reviewed by Nate Chapin.

Source/WebCore:

The initiator is passed through ThreadableLoaderOptions to the CachedResourceRequest. This is
optional, so other users of ThreadableLoader will have the default initiator of 'request'. Note
that synchronous XHRs don't show up in the Resource Timing buffer yet.

Test: http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html

* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadRequest):
* loader/ThreadableLoader.h:
(ThreadableLoaderOptions):
* loader/cache/CachedResourceRequestInitiators.cpp:
(WebCore::CachedResourceRequestInitiators::CachedResourceRequestInitiators):
* loader/cache/CachedResourceRequestInitiators.h:
(CachedResourceRequestInitiators):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):

LayoutTests:

* http/tests/w3c/webperf/resources/all_resource_types.htm:
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types-expected.txt:
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/w3c/webperf/resources/all_resource_types.htm
trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types-expected.txt
trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp
trunk/Source/WebCore/loader/ThreadableLoader.h
trunk/Source/WebCore/loader/cache/CachedResourceRequestInitiators.cpp
trunk/Source/WebCore/loader/cache/CachedResourceRequestInitiators.h
trunk/Source/WebCore/xml/XMLHttpRequest.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (139512 => 139513)

--- trunk/LayoutTests/ChangeLog	2013-01-11 23:42:14 UTC (rev 139512)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 23:54:56 UTC (rev 139513)
@@ -1,3 +1,14 @@
+2013-01-11  James Simonsen  simon...@chromium.org
+
+[Resource Timing] XMLHttpRequests should have initiator type 'xmlhttprequest'
+https://bugs.webkit.org/show_bug.cgi?id=106409
+
+Reviewed by Nate Chapin.
+
+* http/tests/w3c/webperf/resources/all_resource_types.htm:
+* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types-expected.txt:
+* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html:
+
 2013-01-11  Stephen Chenney  schen...@chromium.org
 
 [Chromium] More test expectations for Skia changes


Modified: trunk/LayoutTests/http/tests/w3c/webperf/resources/all_resource_types.htm (139512 => 139513)

--- trunk/LayoutTests/http/tests/w3c/webperf/resources/all_resource_types.htm	2013-01-11 23:42:14 UTC (rev 139512)
+++ trunk/LayoutTests/http/tests/w3c/webperf/resources/all_resource_types.htm	2013-01-11 23:54:56 UTC (rev 139513)
@@ -14,9 +14,13 @@
 iframe src="" width=100px height=100px/iframe
 script src=""
 script
-var xhr = new XMLHttpRequest;
-xhr.open(GET, blank_page_yellow.htm, false);
-xhr.send();
+var async_xhr = new XMLHttpRequest;
+async_xhr.open(GET, generate_resource.php?type=imageid=async_xhr, true);
+async_xhr._onreadystatechange_ = function() {
+if (async_xhr.readyState == 4  async_xhr.status == 200  parent.hasOwnProperty('on_async_xhr_done'))
+parent.on_async_xhr_done();
+}
+async_xhr.send();
 /script
 style
 @font-face {


Modified: trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types-expected.txt (139512 => 139513)

--- trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types-expected.txt	2013-01-11 23:42:14 UTC (rev 139512)
+++ trunk/LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types-expected.txt	2013-01-11 23:54:56 UTC (rev 139513)
@@ -7,17 +7,18 @@
 PASS /w3c/webperf/resources/Ahem.ttf is expected to have initiatorType css 
 PASS /w3c/webperf/resources/blank_image.png is expected to have initiatorType img 
 PASS /w3c/webperf/resources/blank_page_green.htm is expected to have initiatorType iframe 
-PASS /w3c/webperf/resources/blank_page_yellow.htm is expected to have initiatorType xmlhttprequest 
 PASS /w3c/webperf/resources/empty_script.js is expected to have initiatorType script 
 PASS /w3c/webperf/resources/generate_resource.php?type=cssid=embed is expected to have initiatorType embed 
 PASS

[webkit-changes] [139514] trunk/Source/WebKit2

2013-01-11 Thread ap

Title: [139514] trunk/Source/WebKit2








Revision 139514
Author a...@apple.com
Date 2013-01-11 16:01:56 -0800 (Fri, 11 Jan 2013)


Log Message
[WK2] Make it possible to send sync messages from secondary threads
https://bugs.webkit.org/show_bug.cgi?id=106708

Reviewed by Anders Carlsson.

It is hugely beneficial to implement sync messages at Connection level, because
ad hoc code that blocks a thread and wakes it up when a reply arrives on main
thread can't be made equally performant. A CoreOPC MessageDecoder can be moved across
threads, which can't be done with a decoded argument passed by reference to client code.

Sync messages from secondary threads are tracked in much simpler data structure
than client thread ones, because we don't need to be concerned with incoming messages.

* Platform/CoreIPC/Connection.cpp:
(Connection::SecondaryThreadPendingSyncReply):
(CoreIPC::Connection::SecondaryThreadPendingSyncReply::SecondaryThreadPendingSyncReply):
(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::sendSyncMessageFromSecondaryThread):
(CoreIPC::Connection::processIncomingSyncReply):
(CoreIPC::Connection::connectionDidClose):

* Platform/CoreIPC/Connection.h: Also corrected a misleading comment.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp
trunk/Source/WebKit2/Platform/CoreIPC/Connection.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139513 => 139514)

--- trunk/Source/WebKit2/ChangeLog	2013-01-11 23:54:56 UTC (rev 139513)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-12 00:01:56 UTC (rev 139514)
@@ -1,3 +1,29 @@
+2013-01-11  Alexey Proskuryakov  a...@apple.com
+
+[WK2] Make it possible to send sync messages from secondary threads
+https://bugs.webkit.org/show_bug.cgi?id=106708
+
+Reviewed by Anders Carlsson.
+
+It is hugely beneficial to implement sync messages at Connection level, because
+ad hoc code that blocks a thread and wakes it up when a reply arrives on main
+thread can't be made equally performant. A CoreOPC MessageDecoder can be moved across
+threads, which can't be done with a decoded argument passed by reference to client code.
+
+Sync messages from secondary threads are tracked in much simpler data structure
+than client thread ones, because we don't need to be concerned with incoming messages.
+
+* Platform/CoreIPC/Connection.cpp:
+(Connection::SecondaryThreadPendingSyncReply):
+(CoreIPC::Connection::SecondaryThreadPendingSyncReply::SecondaryThreadPendingSyncReply):
+(CoreIPC::Connection::createSyncMessageEncoder):
+(CoreIPC::Connection::sendSyncMessage):
+(CoreIPC::Connection::sendSyncMessageFromSecondaryThread):
+(CoreIPC::Connection::processIncomingSyncReply):
+(CoreIPC::Connection::connectionDidClose):
+
+* Platform/CoreIPC/Connection.h: Also corrected a misleading comment.
+
 2013-01-11  Dan Bernstein  m...@apple.com
 
 Exclude unused resources.


Modified: trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp (139513 => 139514)

--- trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp	2013-01-11 23:54:56 UTC (rev 139513)
+++ trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp	2013-01-12 00:01:56 UTC (rev 139514)
@@ -93,6 +93,18 @@
 VectorConnectionAndIncomingMessage m_messagesToDispatchWhileWaitingForSyncReply;
 };
 
+class Connection::SecondaryThreadPendingSyncReply {
+WTF_MAKE_NONCOPYABLE(SecondaryThreadPendingSyncReply);
+public:
+SecondaryThreadPendingSyncReply() : replyDecoder(0) { }
+
+// The reply decoder, will be null if there was an error processing the sync message on the other side.
+MessageDecoder* replyDecoder;
+
+BinarySemaphore semaphore;
+};
+
+
 PassRefPtrConnection::SyncMessageState Connection::SyncMessageState::getOrCreate(RunLoop* runLoop)
 {
 MutexLocker locker(syncMessageStateMapMutex());
@@ -297,7 +309,8 @@
 OwnPtrMessageEncoder encoder = MessageEncoder::create(messageReceiverName, messageName, destinationID);
 
 // Encode the sync request ID.
-syncRequestID = ++m_syncRequestID;
+COMPILE_ASSERT(sizeof(m_syncRequestID) == sizeof(int64_t), CanUseAtomicIncrement);
+syncRequestID = atomicIncrement(reinterpret_castint64_t volatile*(m_syncRequestID));
 encoder-encode(syncRequestID);
 
 return encoder.release();
@@ -386,8 +399,11 @@
 
 PassOwnPtrMessageDecoder Connection::sendSyncMessage(MessageID messageID, uint64_t syncRequestID, PassOwnPtrMessageEncoder encoder, double timeout, unsigned syncSendFlags)
 {
-// We only allow sending sync messages from the client run loop.
-ASSERT(RunLoop::current() == m_clientRunLoop);
+if (RunLoop::current() != m_clientRunLoop) {
+// No flags are

[webkit-changes] [139515] trunk/Source/WebKit2

2013-01-11 Thread ap

Title: [139515] trunk/Source/WebKit2








Revision 139515
Author a...@apple.com
Date 2013-01-11 16:04:23 -0800 (Fri, 11 Jan 2013)


Log Message
[WK2] Make it possible to send sync messages from secondary threads
https://bugs.webkit.org/show_bug.cgi?id=106708

Apply another review comment (overlooked a ditto).

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendSyncMessage):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139514 => 139515)

--- trunk/Source/WebKit2/ChangeLog	2013-01-12 00:01:56 UTC (rev 139514)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-12 00:04:23 UTC (rev 139515)
@@ -3,6 +3,16 @@
 [WK2] Make it possible to send sync messages from secondary threads
 https://bugs.webkit.org/show_bug.cgi?id=106708
 
+Apply another review comment (overlooked a ditto).
+
+* Platform/CoreIPC/Connection.cpp:
+(CoreIPC::Connection::sendSyncMessage):
+
+2013-01-11  Alexey Proskuryakov  a...@apple.com
+
+[WK2] Make it possible to send sync messages from secondary threads
+https://bugs.webkit.org/show_bug.cgi?id=106708
+
 Reviewed by Anders Carlsson.
 
 It is hugely beneficial to implement sync messages at Connection level, because


Modified: trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp (139514 => 139515)

--- trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp	2013-01-12 00:01:56 UTC (rev 139514)
+++ trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp	2013-01-12 00:04:23 UTC (rev 139515)
@@ -405,10 +405,8 @@
 return sendSyncMessageFromSecondaryThread(messageID, syncRequestID, encoder, timeout);
 }
 
-if (!isValid()) {
-didFailToSendSyncMessage();
+if (!isValid())
 return nullptr;
-}
 
 // Push the pending sync reply information on our stack.
 {
@@ -436,8 +434,6 @@
 m_pendingSyncReplies.removeLast();
 }
 
-// FIXME: Should we call didFailToSendSyncMessage()? It may be unexpected to get in on a background thread.
-
 return reply.release();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139516] trunk/Source/WebKit2

2013-01-11 Thread ap

Title: [139516] trunk/Source/WebKit2








Revision 139516
Author a...@apple.com
Date 2013-01-11 16:08:30 -0800 (Fri, 11 Jan 2013)


Log Message
[WK2] Network process unblocks all waiting threads when any sync reply arrives
https://bugs.webkit.org/show_bug.cgi?id=106713

Reviewed by Brady Eidson.

Switch to sending sync CoreIPC messages, which is now possible.

* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::didClose):
We no longer have response maps.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::willSendRequest): Just send a sync message.
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpace): Ditto.
(WebKit::NetworkResourceLoader::didReceiveDataArray): Added an unrelated assertion.

* NetworkProcess/NetworkResourceLoader.h:
* NetworkProcess/NetworkResourceLoader.messages.in:
Removed no longer used reply messages and their handlers.

* Shared/BlockingResponseMap.h: Removed a bool version, which was not perfectly
safe, and only used in NetworkProcess.
(BlockingResponseMap::didReceiveResponse): Updated a still valid FIXME to not refer
to network process.
(BlockingResponseMap::cancel): Ditto.

* WebProcess/Network/NetworkProcessConnection.h:
* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveSyncMessage):
Plumbing to handle sync messages.

* WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::willSendRequest):
(WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace):
* WebProcess/Network/WebResourceLoader.h:
* WebProcess/Network/WebResourceLoader.messages.in:
Updated (simplified) sync messages and their handlers.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.h
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.h
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.messages.in
trunk/Source/WebKit2/Shared/BlockingResponseMap.h
trunk/Source/WebKit2/WebProcess/Network/NetworkProcessConnection.cpp
trunk/Source/WebKit2/WebProcess/Network/NetworkProcessConnection.h
trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp
trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.h
trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.messages.in




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139515 => 139516)

--- trunk/Source/WebKit2/ChangeLog	2013-01-12 00:04:23 UTC (rev 139515)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-12 00:08:30 UTC (rev 139516)
@@ -1,5 +1,45 @@
 2013-01-11  Alexey Proskuryakov  a...@apple.com
 
+[WK2] Network process unblocks all waiting threads when any sync reply arrives
+https://bugs.webkit.org/show_bug.cgi?id=106713
+
+Reviewed by Brady Eidson.
+
+Switch to sending sync CoreIPC messages, which is now possible.
+
+* NetworkProcess/NetworkConnectionToWebProcess.h:
+* NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::didClose):
+We no longer have response maps.
+
+* NetworkProcess/NetworkResourceLoader.cpp:
+(WebKit::NetworkResourceLoader::willSendRequest): Just send a sync message.
+(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpace): Ditto.
+(WebKit::NetworkResourceLoader::didReceiveDataArray): Added an unrelated assertion.
+
+* NetworkProcess/NetworkResourceLoader.h:
+* NetworkProcess/NetworkResourceLoader.messages.in:
+Removed no longer used reply messages and their handlers.
+
+* Shared/BlockingResponseMap.h: Removed a bool version, which was not perfectly
+safe, and only used in NetworkProcess.
+(BlockingResponseMap::didReceiveResponse): Updated a still valid FIXME to not refer
+to network process.
+(BlockingResponseMap::cancel): Ditto.
+
+* WebProcess/Network/NetworkProcessConnection.h:
+* WebProcess/Network/NetworkProcessConnection.cpp:
+(WebKit::NetworkProcessConnection::didReceiveSyncMessage):
+Plumbing to handle sync messages.
+
+* WebProcess/Network/WebResourceLoader.cpp:
+(WebKit::WebResourceLoader::willSendRequest):
+(WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace):
+* WebProcess/Network/WebResourceLoader.h:
+* WebProcess/Network/WebResourceLoader.messages.in:
+Updated (simplified) sync messages and their handlers.
+
+2013-01-11  Alexey Proskuryakov  a...@apple.com
+
 [WK2] Make it possible to send sync

[webkit-changes] [139518] trunk/Source/WebCore

2013-01-11 Thread jsbell

Title: [139518] trunk/Source/WebCore








Revision 139518
Author jsb...@chromium.org
Date 2013-01-11 16:12:55 -0800 (Fri, 11 Jan 2013)


Log Message
IndexedDB: IDBTransaction should manage lifetime of IDBRequests
https://bugs.webkit.org/show_bug.cgi?id=106678

Reviewed by Tony Chang.

Ensure reference count of IDBRequests don't bounce off zero if there are no script
references are while the events are arriving.

No new tests - no detectable behavior changes.

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::create): Register with transaction (which now takes a ref) here to...
(WebCore::IDBRequest::IDBRequest): ...avoid having to relax adoption requirements here.
* Modules/indexeddb/IDBTransaction.cpp: Keep RefPtrs to outstanding requests.
(WebCore::IDBTransaction::~IDBTransaction):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::onAbort):
* Modules/indexeddb/IDBTransaction.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139517 => 139518)

--- trunk/Source/WebCore/ChangeLog	2013-01-12 00:10:59 UTC (rev 139517)
+++ trunk/Source/WebCore/ChangeLog	2013-01-12 00:12:55 UTC (rev 139518)
@@ -1,3 +1,24 @@
+2013-01-11  Joshua Bell  jsb...@chromium.org
+
+IndexedDB: IDBTransaction should manage lifetime of IDBRequests
+https://bugs.webkit.org/show_bug.cgi?id=106678
+
+Reviewed by Tony Chang.
+
+Ensure reference count of IDBRequests don't bounce off zero if there are no script
+references are while the events are arriving.
+
+No new tests - no detectable behavior changes.
+
+* Modules/indexeddb/IDBRequest.cpp:
+(WebCore::IDBRequest::create): Register with transaction (which now takes a ref) here to...
+(WebCore::IDBRequest::IDBRequest): ...avoid having to relax adoption requirements here.
+* Modules/indexeddb/IDBTransaction.cpp: Keep RefPtrs to outstanding requests.
+(WebCore::IDBTransaction::~IDBTransaction):
+(WebCore::IDBTransaction::abort):
+(WebCore::IDBTransaction::onAbort):
+* Modules/indexeddb/IDBTransaction.h:
+
 2013-01-11  James Simonsen  simon...@chromium.org
 
 [Resource Timing] XMLHttpRequests should have initiator type 'xmlhttprequest'


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp (139517 => 139518)

--- trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp	2013-01-12 00:10:59 UTC (rev 139517)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp	2013-01-12 00:12:55 UTC (rev 139518)
@@ -49,6 +49,9 @@
 {
 RefPtrIDBRequest request(adoptRef(new IDBRequest(context, source, IDBTransactionBackendInterface::NormalTask, transaction)));
 request-suspendIfNeeded();
+// Requests associated with IDBFactory (open/deleteDatabase/getDatabaseNames) are not associated with transactions.
+if (transaction)
+transaction-registerRequest(request.get());
 return request.release();
 }
 
@@ -56,6 +59,9 @@
 {
 RefPtrIDBRequest request(adoptRef(new IDBRequest(context, source, taskType, transaction)));
 request-suspendIfNeeded();
+// Requests associated with IDBFactory (open/deleteDatabase/getDatabaseNames) are not associated with transactions.
+if (transaction)
+transaction-registerRequest(request.get());
 return request.release();
 }
 
@@ -78,10 +84,6 @@
 , m_preventPropagation(false)
 , m_requestState(context)
 {
-// Requests associated with IDBFactory (open/deleteDatabase/getDatabaseNames) are not
-// associated with transactions.
-if (m_transaction)
-m_transaction-registerRequest(this);
 }
 
 IDBRequest::~IDBRequest()


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp (139517 => 139518)

--- trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp	2013-01-12 00:10:59 UTC (rev 139517)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp	2013-01-12 00:12:55 UTC (rev 139518)
@@ -120,6 +120,7 @@
 IDBTransaction::~IDBTransaction()
 {
 ASSERT(m_state == Finished);
+ASSERT(m_requestList.isEmpty());
 }
 
 const String IDBTransaction::mode() const
@@ -223,7 +224,7 @@
 m_state = Finishing;
 
 while (!m_requestList.isEmpty()) {
-IDBRequest* request = *m_requestList.begin();
+RefPtrIDBRequest request = *m_requestList.begin();
 m_requestList.remove(request);
 request-abort();
 }
@@ -300,7 +301,7 @@
 // Abort was not triggered by front-end, so outstanding requests must
 // be aborted now.
 while (!m_requestList.isEmpty()) {
-IDBRequest* request = *m_requestList.begin();
+RefPtrIDBRequest request = *m_requestList.begin();
 m_requestList.remove(request);
 request-abort();
 }


Modified:

[webkit-changes] [139519] trunk/Source/WebKit/blackberry

2013-01-11 Thread commit-queue

Title: [139519] trunk/Source/WebKit/blackberry








Revision 139519
Author commit-qu...@webkit.org
Date 2013-01-11 16:14:58 -0800 (Fri, 11 Jan 2013)


Log Message
[BlackBerry] Modifying the databaseQuota call to WebPageClient
https://bugs.webkit.org/show_bug.cgi?id=106703

Patch by Otto Derek Cheung otche...@rim.com on 2013-01-11
Reviewed by Yong Li.

The databaseQuota call in WebPageClientImpl is modified to take in
BP:Strings directly. Also, we want to use the origin URL from the security origin.
Not the database identifier.

* Api/WebPageClient.h:
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPageClient.h
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPageClient.h (139518 => 139519)

--- trunk/Source/WebKit/blackberry/Api/WebPageClient.h	2013-01-12 00:12:55 UTC (rev 139518)
+++ trunk/Source/WebKit/blackberry/Api/WebPageClient.h	2013-01-12 00:14:58 UTC (rev 139519)
@@ -178,7 +178,7 @@
 virtual void scheduleCloseWindow() = 0;
 
 // Database interface.
-virtual unsigned long long databaseQuota(const unsigned short* origin, unsigned originLength, const unsigned short* databaseName, unsigned databaseNameLength, unsigned long long originUsage, unsigned long long currentQuota, unsigned long long estimatedSize) = 0;
+virtual unsigned long long databaseQuota(const BlackBerry::Platform::String origin, const BlackBerry::Platform::String databaseName, unsigned long long originUsage, unsigned long long currentQuota, unsigned long long estimatedSize) = 0;
 
 virtual void setIconForUrl(const BlackBerry::Platform::String originalPageUrl, const BlackBerry::Platform::String finalPageUrl, const BlackBerry::Platform::String iconUrl) = 0;
 virtual void setFavicon(const BlackBerry::Platform::String dataInBase64, const BlackBerry::Platform::String url) = 0;


Modified: trunk/Source/WebKit/blackberry/ChangeLog (139518 => 139519)

--- trunk/Source/WebKit/blackberry/ChangeLog	2013-01-12 00:12:55 UTC (rev 139518)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2013-01-12 00:14:58 UTC (rev 139519)
@@ -1,3 +1,18 @@
+2013-01-11  Otto Derek Cheung  otche...@rim.com
+
+[BlackBerry] Modifying the databaseQuota call to WebPageClient
+https://bugs.webkit.org/show_bug.cgi?id=106703
+
+Reviewed by Yong Li.
+
+The databaseQuota call in WebPageClientImpl is modified to take in
+BP:Strings directly. Also, we want to use the origin URL from the security origin.
+Not the database identifier.
+
+* Api/WebPageClient.h:
+* WebCoreSupport/ChromeClientBlackBerry.cpp:
+(WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
+
 2013-01-10  Yongxin Dai  yo...@rim.com
 
 [BlackBerry] Handle the case that start/end position is out of unclipped selection region


Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp (139518 => 139519)

--- trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp	2013-01-12 00:12:55 UTC (rev 139518)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp	2013-01-12 00:14:58 UTC (rev 139519)
@@ -504,10 +504,9 @@
 unsigned long long estimatedSize = details.expectedUsage();
 const String nameStr = details.displayName();
 
-String originStr = origin-databaseIdentifier();
+String originStr = origin-toString();
 
-unsigned long long quota = m_webPagePrivate-m_client-databaseQuota(originStr.characters(), originStr.length(),
-nameStr.characters(), nameStr.length(), originUsage, currentQuota, estimatedSize);
+unsigned long long quota = m_webPagePrivate-m_client-databaseQuota(originStr, nameStr, originUsage, currentQuota, estimatedSize);
 
 manager.setQuota(origin, quota);
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139520] trunk/Source/WebCore

2013-01-11 Thread commit-queue

Title: [139520] trunk/Source/WebCore








Revision 139520
Author commit-qu...@webkit.org
Date 2013-01-11 16:19:01 -0800 (Fri, 11 Jan 2013)


Log Message
Explicitly set msvs_cygwin_shell to true for actions in WebKit
https://bugs.webkit.org/show_bug.cgi?id=106706

Patch by Robert Iannucci iannu...@chromium.org on 2013-01-11
Reviewed by Tony Chang.

Currently, msvs_cygwin_shell is set to 1 by default. This patch
explicitly sets it on the actions which will break if msvs_cygwin_shell
were set to 0. This is in preparation for changing the default value of
msvs_cygwin_shell, which in turn is in preparation of the removal of
cygwin as a buld-system requirement.

Since this change will have no semantic effect, no new tests are
required.

* WebCore.gyp/WebCore.gyp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139519 => 139520)

--- trunk/Source/WebCore/ChangeLog	2013-01-12 00:14:58 UTC (rev 139519)
+++ trunk/Source/WebCore/ChangeLog	2013-01-12 00:19:01 UTC (rev 139520)
@@ -1,3 +1,21 @@
+2013-01-11  Robert Iannucci  iannu...@chromium.org
+
+Explicitly set msvs_cygwin_shell to true for actions in WebKit
+https://bugs.webkit.org/show_bug.cgi?id=106706
+
+Reviewed by Tony Chang.
+
+Currently, msvs_cygwin_shell is set to 1 by default. This patch
+explicitly sets it on the actions which will break if msvs_cygwin_shell
+were set to 0. This is in preparation for changing the default value of
+msvs_cygwin_shell, which in turn is in preparation of the removal of
+cygwin as a buld-system requirement.
+
+Since this change will have no semantic effect, no new tests are
+required.
+
+* WebCore.gyp/WebCore.gyp:
+
 2013-01-11  Joshua Bell  jsb...@chromium.org
 
 IndexedDB: IDBTransaction should manage lifetime of IDBRequests


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (139519 => 139520)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2013-01-12 00:14:58 UTC (rev 139519)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2013-01-12 00:19:01 UTC (rev 139520)
@@ -401,6 +401,7 @@
 '--output_cpp_dir', '(SHARED_INTERMEDIATE_DIR)/webcore',
   ],
   'message': 'Generating Inspector protocol sources from Inspector.json',
+  'msvs_cygwin_shell': 1,
 },
   ]
 },
@@ -551,6 +552,7 @@
 '--',
 '@(_inputs)',
   ],
+  'msvs_cygwin_shell': 1,
 },
   ]
 },
@@ -708,6 +710,7 @@
   ],
 }],
   ],
+  'msvs_cygwin_shell': 1,
 },
 {
   'action_name': 'CSSValueKeywords',
@@ -736,6 +739,7 @@
   ],
 }],
   ],
+  'msvs_cygwin_shell': 1,
 },
 {
   'action_name': 'HTMLNames',
@@ -762,6 +766,7 @@
 '--wrapperFactoryV8',
 '--extraDefines', '(feature_defines)'
   ],
+  'msvs_cygwin_shell': 1,
 },
 {
   'action_name': 'WebKitFontFamilyNames',
@@ -782,6 +787,7 @@
 '--',
 '--fonts',
   ],
+  'msvs_cygwin_shell': 1,
 },
 {
   'action_name': 'SVGNames',
@@ -809,6 +815,7 @@
 '--wrapperFactoryV8',
 '--extraDefines', '(feature_defines)'
   ],
+  'msvs_cygwin_shell': 1,
 },
 {
   'action_name': 'EventFactory',
@@ -828,6 +835,7 @@
 '--',
 '@(_inputs)',
   ],
+  'msvs_cygwin_shell': 1,
 },
 {
   'action_name': 'EventTargetFactory',
@@ -846,6 +854,7 @@
 '--',
 '@(_inputs)',
   ],
+  'msvs_cygwin_shell': 1,
 },
 {
   'action_name': 'ExceptionCodeDescription',
@@ -866,6 +875,7 @@
 '--',
 '@(_inputs)',
   ],
+  'msvs_cygwin_shell': 1,
 },
 {
   'action_name': 'MathMLNames',
@@ -890,6 +900,7 @@
 '--factory',
 '--extraDefines', '(feature_defines)'
   ],
+  'msvs_cygwin_shell': 1,
 },
 {
   'action_name': 'UserAgentStyleSheets',
@@ -936,6 +947,7 @@
 '--',
 '--defines', '(feature_defines)',
   ],
+  'msvs_cygwin_shell': 1,
 },
 {
   'action_name': 'PickerCommon',
@@ -1033,6 +1045,7 @@
 '--',
 '--extraDefines', '(feature_defines)'
   ],
+  'msvs_cygwin_shell': 1,
 },
 {
   'action_name': 'XMLNSNames',
@@ -1053,6 +1066,7 @@
 '--',
 '--extraDefines', '(feature_defines)'
   ],
+  'msvs_cygwin_shell': 1,
 },
 {
   'action_name': 'XMLNames',
@@ -1073,6 +1087,7 @@
 '--',
 '--extraDefines',

[webkit-changes] [139521] trunk/LayoutTests

2013-01-11 Thread schenney

Title: [139521] trunk/LayoutTests








Revision 139521
Author schen...@chromium.org
Date 2013-01-11 16:30:40 -0800 (Fri, 11 Jan 2013)


Log Message
[Chromium] Fixing the 10.8 layout tests

Unreviewed test expectations update.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139520 => 139521)

--- trunk/LayoutTests/ChangeLog	2013-01-12 00:19:01 UTC (rev 139520)
+++ trunk/LayoutTests/ChangeLog	2013-01-12 00:30:40 UTC (rev 139521)
@@ -1,3 +1,11 @@
+2013-01-11  Stephen Chenney  schen...@chromium.org
+
+[Chromium] Fixing the 10.8 layout tests
+
+Unreviewed test expectations update.
+
+* platform/chromium/TestExpectations:
+
 2013-01-11  James Simonsen  simon...@chromium.org
 
 [Resource Timing] XMLHttpRequests should have initiator type 'xmlhttprequest'


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139520 => 139521)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-12 00:19:01 UTC (rev 139520)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-12 00:30:40 UTC (rev 139521)
@@ -2833,7 +2833,7 @@
 
 webkit.org/b/65199 [ Android Linux SnowLeopard Win ] fast/writing-mode/broken-ideograph-small-caps.html [ Failure ]
 
-webkit.org/b/65453 [ Lion SnowLeopard ] fast/css/outline-auto-empty-rects.html [ ImageOnlyFailure ]
+webkit.org/b/65453 [ Mac ] fast/css/outline-auto-empty-rects.html [ ImageOnlyFailure ]
 
 webkit.org/b/93546 compositing/plugins/no-backing-store.html [ Failure Pass ]
 webkit.org/b/93546 platform/chromium/virtual/softwarecompositing/plugins/no-backing-store.html [ Failure Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139522] trunk/Tools

2013-01-11 Thread jparent

Title: [139522] trunk/Tools








Revision 139522
Author jpar...@chromium.org
Date 2013-01-11 16:41:48 -0800 (Fri, 11 Jan 2013)


Log Message
Builder should not be a valid parameter for stats dashboard
https://bugs.webkit.org/show_bug.cgi?id=106698

Reviewed by Dirk Pranke.

Since builder is a dashboard specific parameter, dashboard_base
should not be handling it in handleValidHashParameterWrapper, rather,
each specific dashboard should in its handleValidHashParameter function.

Note that the FIXME in dashboard_base about this was actually wrong -
we don't want to move it to g_crossDashboardState, because it isn't
actually cross dashboard state.

In fact, flakiness and treemap have the code in
handleValidHashParameter, but it is currently dead code because
dashboard_base gets to it first.

Added the proper handling to timeline_explorer, since builder is
valid there.

* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/timeline_explorer.html:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js
trunk/Tools/TestResultServer/static-dashboards/timeline_explorer.html




Diff

Modified: trunk/Tools/ChangeLog (139521 => 139522)

--- trunk/Tools/ChangeLog	2013-01-12 00:30:40 UTC (rev 139521)
+++ trunk/Tools/ChangeLog	2013-01-12 00:41:48 UTC (rev 139522)
@@ -1,3 +1,28 @@
+2013-01-11  Julie Parent  jpar...@chromium.org
+
+Builder should not be a valid parameter for stats dashboard
+https://bugs.webkit.org/show_bug.cgi?id=106698
+
+Reviewed by Dirk Pranke.
+
+Since builder is a dashboard specific parameter, dashboard_base
+should not be handling it in handleValidHashParameterWrapper, rather,
+each specific dashboard should in its handleValidHashParameter function.
+
+Note that the FIXME in dashboard_base about this was actually wrong -
+we don't want to move it to g_crossDashboardState, because it isn't
+actually cross dashboard state.
+
+In fact, flakiness and treemap have the code in 
+handleValidHashParameter, but it is currently dead code because 
+dashboard_base gets to it first.
+
+Added the proper handling to timeline_explorer, since builder is
+valid there.
+
+* TestResultServer/static-dashboards/dashboard_base.js:
+* TestResultServer/static-dashboards/timeline_explorer.html:
+
 2013-01-11  Ryosuke Niwa  rn...@webkit.org
 
 REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs


Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (139521 => 139522)

--- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js	2013-01-12 00:30:40 UTC (rev 139521)
+++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js	2013-01-12 00:41:48 UTC (rev 139522)
@@ -185,12 +185,6 @@
 });
 return true;
 
-// FIXME: This should probably be stored on g_crossDashboardState like everything else in this function.
-case 'builder':
-validateParameter(g_currentState, key, value,
-function() { return value in currentBuilders(); });
-return true;
-
 case 'useTestData':
 case 'showAllRuns':
 g_crossDashboardState[key] = value == 'true';


Modified: trunk/Tools/TestResultServer/static-dashboards/timeline_explorer.html (139521 => 139522)

--- trunk/Tools/TestResultServer/static-dashboards/timeline_explorer.html	2013-01-12 00:30:40 UTC (rev 139521)
+++ trunk/Tools/TestResultServer/static-dashboards/timeline_explorer.html	2013-01-12 00:41:48 UTC (rev 139522)
@@ -152,6 +152,10 @@
 function handleValidHashParameter(key, value)
 {
 switch(key) {
+case 'builder':
+validateParameter(g_currentState, key, value,
+function() { return value in currentBuilders(); });
+return true;
 case 'buildTimestamp':
 g_currentState.buildTimestamp = parseInt(value, 10);
 return true;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139523] trunk/Source/WebCore

2013-01-11 Thread tonyg

Title: [139523] trunk/Source/WebCore








Revision 139523
Author to...@chromium.org
Date 2013-01-11 17:28:40 -0800 (Fri, 11 Jan 2013)


Log Message
Move constructTreeFromHTMLToken into HTMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=106694

Reviewed by Adam Barth.

This way it will sit parallel to a new constructTreeFromCompactHTMLToken method.

No new tests because no new functionality.

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken):
(WebCore):
* html/parser/HTMLDocumentParser.h:
* html/parser/HTMLTreeBuilder.cpp:
* html/parser/HTMLTreeBuilder.h:
(HTMLTreeBuilder):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp
trunk/Source/WebCore/html/parser/HTMLDocumentParser.h
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.h
trunk/Source/WebCore/html/parser/TextDocumentParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139522 => 139523)

--- trunk/Source/WebCore/ChangeLog	2013-01-12 00:41:48 UTC (rev 139522)
+++ trunk/Source/WebCore/ChangeLog	2013-01-12 01:28:40 UTC (rev 139523)
@@ -1,3 +1,23 @@
+2013-01-11  Tony Gentilcore  to...@chromium.org
+
+Move constructTreeFromHTMLToken into HTMLDocumentParser
+https://bugs.webkit.org/show_bug.cgi?id=106694
+
+Reviewed by Adam Barth.
+
+This way it will sit parallel to a new constructTreeFromCompactHTMLToken method.
+
+No new tests because no new functionality.
+
+* html/parser/HTMLDocumentParser.cpp:
+(WebCore::HTMLDocumentParser::pumpTokenizer):
+(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken):
+(WebCore):
+* html/parser/HTMLDocumentParser.h:
+* html/parser/HTMLTreeBuilder.cpp:
+* html/parser/HTMLTreeBuilder.h:
+(HTMLTreeBuilder):
+
 2013-01-11  Robert Iannucci  iannu...@chromium.org
 
 Explicitly set msvs_cygwin_shell to true for actions in WebKit


Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp (139522 => 139523)

--- trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp	2013-01-12 00:41:48 UTC (rev 139522)
+++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp	2013-01-12 01:28:40 UTC (rev 139523)
@@ -273,7 +273,7 @@
 m_xssAuditor.filterToken(m_token);
 }
 
-m_treeBuilder-constructTreeFromToken(m_token);
+constructTreeFromHTMLToken(m_token);
 ASSERT(m_token.isUninitialized());
 }
 
@@ -299,6 +299,37 @@
 InspectorInstrumentation::didWriteHTML(cookie, m_input.current().currentLine().zeroBasedInt());
 }
 
+void HTMLDocumentParser::constructTreeFromHTMLToken(HTMLToken rawToken)
+{
+RefPtrAtomicHTMLToken token = AtomicHTMLToken::create(rawToken);
+
+// We clear the rawToken in case constructTreeFromAtomicToken
+// synchronously re-enters the parser. We don't clear the token immedately
+// for Character tokens because the AtomicHTMLToken avoids copying the
+// characters by keeping a pointer to the underlying buffer in the
+// HTMLToken. Fortunately, Character tokens can't cause us to re-enter
+// the parser.
+//
+// FIXME: Stop clearing the rawToken once we start running the parser off
+// the main thread or once we stop allowing synchronous _javascript_
+// execution from parseAttribute.
+if (rawToken.type() != HTMLTokenTypes::Character)
+rawToken.clear();
+
+m_treeBuilder-constructTree(token.get());
+
+// AtomicHTMLToken keeps a pointer to the HTMLToken's buffer instead
+// of copying the characters for performance.
+// Clear the external characters pointer before the raw token is cleared
+// to make sure that we won't have a dangling pointer.
+token-clearExternalCharacters();
+
+if (!rawToken.isUninitialized()) {
+ASSERT(rawToken.type() == HTMLTokenTypes::Character);
+rawToken.clear();
+}
+}
+
 bool HTMLDocumentParser::hasInsertionPoint()
 {
 // FIXME: The wasCreatedByScript() branch here might not be fully correct.


Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.h (139522 => 139523)

--- trunk/Source/WebCore/html/parser/HTMLDocumentParser.h	2013-01-12 00:41:48 UTC (rev 139522)
+++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.h	2013-01-12 01:28:40 UTC (rev 139523)
@@ -121,6 +121,7 @@
 bool canTakeNextToken(SynchronousMode, PumpSession);
 void pumpTokenizer(SynchronousMode);
 void pumpTokenizerIfPossible(SynchronousMode);
+void constructTreeFromHTMLToken(HTMLToken);
 
 void runScriptsForPausedTreeBuilder();
 void resumeParsingAfterScriptExecution();


Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (139522 => 139523)

--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2013-01-12 00:41:48 UTC (rev 139522)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2013-01-12

[webkit-changes] [139524] trunk/LayoutTests

2013-01-11 Thread schenney

Title: [139524] trunk/LayoutTests








Revision 139524
Author schen...@chromium.org
Date 2013-01-11 17:28:56 -0800 (Fri, 11 Jan 2013)


Log Message
[Chromium] Fixing the linux layout tests

Unreviewed test expectations update.

Some tests were apparently not rebaselined for linux.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139523 => 139524)

--- trunk/LayoutTests/ChangeLog	2013-01-12 01:28:40 UTC (rev 139523)
+++ trunk/LayoutTests/ChangeLog	2013-01-12 01:28:56 UTC (rev 139524)
@@ -1,5 +1,15 @@
 2013-01-11  Stephen Chenney  schen...@chromium.org
 
+[Chromium] Fixing the linux layout tests
+
+Unreviewed test expectations update.
+
+Some tests were apparently not rebaselined for linux.
+
+* platform/chromium/TestExpectations:
+
+2013-01-11  Stephen Chenney  schen...@chromium.org
+
 [Chromium] Fixing the 10.8 layout tests
 
 Unreviewed test expectations update.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139523 => 139524)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-12 01:28:40 UTC (rev 139523)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-12 01:28:56 UTC (rev 139524)
@@ -4498,5 +4498,12 @@
 Bug(schenney) svg/zoom/page/zoom-background-images.html [ ImageOnlyFailure ]
 Bug(schenney) svg/zoom/page/zoom-mask-with-percentages.svg [ ImageOnlyFailure ]
 Bug(schenney) svg/zoom/page/zoom-svg-through-object-with-override-size.html [ ImageOnlyFailure ]
+Bug(schenney) fast/borders/border-image-01.html [ ImageOnlyFailure ]
+Bug(schenney) fast/borders/border-image-longhand.html [ ImageOnlyFailure ]
+Bug(schenney) fast/borders/border-image-repeat.html [ ImageOnlyFailure ]
+Bug(schenney) fast/borders/border-image-scrambled.html [ ImageOnlyFailure ]
+Bug(schenney) fast/borders/border-image-slices.html [ ImageOnlyFailure ]
+Bug(schenney) fast/borders/border-image-source.html [ ImageOnlyFailure ]
+Bug(schenney) fast/css/continuationCrash.html [ ImageOnlyFailure ]
+Bug(schenney) fast/text/international/hindi-spacing.html [ ImageOnlyFailure Pass ]
 
-






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139525] trunk/Source/WebKit2

2013-01-11 Thread commit-queue

Title: [139525] trunk/Source/WebKit2








Revision 139525
Author commit-qu...@webkit.org
Date 2013-01-11 17:32:22 -0800 (Fri, 11 Jan 2013)


Log Message
Coordinated Graphics: Remove the dependency of WebCoordinatedSurface::Handle from Coordinated Graphics.
https://bugs.webkit.org/show_bug.cgi?id=104347

Patch by Huang Dongsung luxte...@company100.net on 2013-01-11
Reviewed by Noam Rosenthal.

It is a preparation patch for Threaded Coordinated Graphics on WK1.

Currently, UpdateAtlas and CoordinatedImageBacking use
WebCoordinatedSurface::Handle, but WebCoordinatedSurface::Handle can be
used only IPC-based Coordinated Graphics. So this patch removes the
dependency of WebCoordinatedSurface::Handle from UpdateAtlas and
CoordinatedImageBacking. Now CoordinatedLayerTreeHost converts the
handle to a WebCoordinatedSurface.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.cpp:
(WebKit::CoordinatedImageBacking::update):
(WebKit::CoordinatedImageBacking::releaseSurfaceIfNeeded):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.h:
(Coordinator):
(CoordinatedImageBacking):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::updateImageBacking):
(WebKit::CoordinatedLayerTreeHost::createUpdateAtlas):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(WebKit):
(CoordinatedLayerTreeHost):
* WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::~UpdateAtlas):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
* WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:
(UpdateAtlasClient):
(UpdateAtlas):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.cpp
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.h
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139524 => 139525)

--- trunk/Source/WebKit2/ChangeLog	2013-01-12 01:28:56 UTC (rev 139524)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-12 01:32:22 UTC (rev 139525)
@@ -1,3 +1,39 @@
+2013-01-11  Huang Dongsung  luxte...@company100.net
+
+Coordinated Graphics: Remove the dependency of WebCoordinatedSurface::Handle from Coordinated Graphics.
+https://bugs.webkit.org/show_bug.cgi?id=104347
+
+Reviewed by Noam Rosenthal.
+
+It is a preparation patch for Threaded Coordinated Graphics on WK1.
+
+Currently, UpdateAtlas and CoordinatedImageBacking use
+WebCoordinatedSurface::Handle, but WebCoordinatedSurface::Handle can be
+used only IPC-based Coordinated Graphics. So this patch removes the
+dependency of WebCoordinatedSurface::Handle from UpdateAtlas and
+CoordinatedImageBacking. Now CoordinatedLayerTreeHost converts the
+handle to a WebCoordinatedSurface.
+
+* WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.cpp:
+(WebKit::CoordinatedImageBacking::update):
+(WebKit::CoordinatedImageBacking::releaseSurfaceIfNeeded):
+* WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.h:
+(Coordinator):
+(CoordinatedImageBacking):
+* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
+(WebKit::CoordinatedLayerTreeHost::updateImageBacking):
+(WebKit::CoordinatedLayerTreeHost::createUpdateAtlas):
+* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
+(WebKit):
+(CoordinatedLayerTreeHost):
+* WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:
+(WebKit::UpdateAtlas::UpdateAtlas):
+(WebKit::UpdateAtlas::~UpdateAtlas):
+(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
+* WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:
+(UpdateAtlasClient):
+(UpdateAtlas):
+
 2013-01-11  Alexey Proskuryakov  a...@apple.com
 
 [WK2] Network process unblocks all waiting threads when any sync reply arrives


Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.cpp (139524 => 139525)

--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.cpp	2013-01-12 01:28:56 UTC (rev 139524)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.cpp	2013-01-12 01:32:22 UTC (rev 139525)
@@ -104,10 +104,7 @@
 }
 
 m_surface = CoordinatedSurface::create(m_image-size(), m_image-currentFrameHasAlpha() ? CoordinatedSurface::SupportsAlpha : CoordinatedSurface::NoFlags);
-m_handle = adoptPtr(new

[webkit-changes] [139526] trunk/Source

2013-01-11 Thread commit-queue

Title: [139526] trunk/Source








Revision 139526
Author commit-qu...@webkit.org
Date 2013-01-11 17:35:19 -0800 (Fri, 11 Jan 2013)


Log Message
[TexMap] Rename current[Transform|Opacity|Filters] in TextureMapperLayer.
https://bugs.webkit.org/show_bug.cgi?id=105760

Patch by Huang Dongsung luxte...@company100.net on 2013-01-11
Reviewed by Noam Rosenthal.

Source/WebCore:

TextureMapperLayer has two transform members: an original value and a
changeable value. The changeable value would be changed by animations.
This patch puts 'current' prefix on the changeable value to clarify
its purpose. Opacity and filters ditto.

No new tests. Refactoring only.

* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::paintSelfAndChildren):
(WebCore::TextureMapperLayer::intermediateSurfaceRect):
(WebCore::TextureMapperLayer::shouldPaintToIntermediateSurface):
(WebCore::TextureMapperLayer::isVisible):
(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
(WebCore::TextureMapperLayer::paintRecursive):
(WebCore::TextureMapperLayer::flushCompositingStateForThisLayerOnly):
(WebCore::TextureMapperLayer::syncAnimations):
(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):
* platform/graphics/texmap/TextureMapperLayer.h:
(WebCore::TextureMapperLayer::TextureMapperLayer):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::State::State):

Source/WebKit/qt:

TextureMapperLayerClientQt uses setTransform() and setOpacity() in
GraphicsLayer instead of TextureMapperLayer like LayerTreeRenderer.
This removes unnecessary public API for TextureMapperLayer.

* WebCoreSupport/TextureMapperLayerClientQt.cpp:
(TextureMapperLayerClientQt::renderCompositedLayers):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/TextureMapperLayerClientQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139525 => 139526)

--- trunk/Source/WebCore/ChangeLog	2013-01-12 01:32:22 UTC (rev 139525)
+++ trunk/Source/WebCore/ChangeLog	2013-01-12 01:35:19 UTC (rev 139526)
@@ -1,3 +1,34 @@
+2013-01-11  Huang Dongsung  luxte...@company100.net
+
+[TexMap] Rename current[Transform|Opacity|Filters] in TextureMapperLayer.
+https://bugs.webkit.org/show_bug.cgi?id=105760
+
+Reviewed by Noam Rosenthal.
+
+TextureMapperLayer has two transform members: an original value and a
+changeable value. The changeable value would be changed by animations.
+This patch puts 'current' prefix on the changeable value to clarify
+its purpose. Opacity and filters ditto.
+
+No new tests. Refactoring only.
+
+* platform/graphics/texmap/TextureMapperLayer.cpp:
+(WebCore::TextureMapperLayer::computeTransformsRecursive):
+(WebCore::TextureMapperLayer::paintSelf):
+(WebCore::TextureMapperLayer::paintSelfAndChildren):
+(WebCore::TextureMapperLayer::intermediateSurfaceRect):
+(WebCore::TextureMapperLayer::shouldPaintToIntermediateSurface):
+(WebCore::TextureMapperLayer::isVisible):
+(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
+(WebCore::TextureMapperLayer::paintRecursive):
+(WebCore::TextureMapperLayer::flushCompositingStateForThisLayerOnly):
+(WebCore::TextureMapperLayer::syncAnimations):
+(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):
+* platform/graphics/texmap/TextureMapperLayer.h:
+(WebCore::TextureMapperLayer::TextureMapperLayer):
+(TextureMapperLayer):
+(WebCore::TextureMapperLayer::State::State):
+
 2013-01-11  Tony Gentilcore  to...@chromium.org
 
 Move constructTreeFromHTMLToken into HTMLDocumentParser


Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp (139525 => 139526)

--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp	2013-01-12 01:32:22 UTC (rev 139525)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp	2013-01-12 01:35:19 UTC (rev 139526)
@@ -54,11 +54,6 @@
 return this;
 }
 
-void TextureMapperLayer::setTransform(const TransformationMatrix matrix)
-{
-m_transform.setLocalTransform(matrix);
-}
-
 void TextureMapperLayer::clearBackingStoresRecursive()
 {
 m_backingStore.clear();
@@ -77,15 +72,15 @@
 // Compute transforms recursively on the way down to leafs.
 TransformationMatrix parentTransform;
 if (m_parent)
-parentTransform = m_parent-m_transform.combinedForChildren();
+parentTransform = m_parent-m_currentTransform.combinedForChildren();
 else if (m_effectTarget)
-parentTransform = m_effectTarget-m_transform.combined();
-m_transform.combineTransforms(parentTransform);

[webkit-changes] [139527] trunk/LayoutTests

2013-01-11 Thread leviw

Title: [139527] trunk/LayoutTests








Revision 139527
Author le...@chromium.org
Date 2013-01-11 17:40:29 -0800 (Fri, 11 Jan 2013)


Log Message
Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/canvas/getPutImageDataPairTest.html
as slow on all Chromium platforms.


* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139526 => 139527)

--- trunk/LayoutTests/ChangeLog	2013-01-12 01:35:19 UTC (rev 139526)
+++ trunk/LayoutTests/ChangeLog	2013-01-12 01:40:29 UTC (rev 139527)
@@ -1,3 +1,11 @@
+2013-01-11  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/canvas/getPutImageDataPairTest.html
+as slow on all Chromium platforms.
+
+
+* platform/chromium/TestExpectations:
+
 2013-01-11  Stephen Chenney  schen...@chromium.org
 
 [Chromium] Fixing the linux layout tests


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139526 => 139527)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-12 01:35:19 UTC (rev 139526)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-12 01:40:29 UTC (rev 139527)
@@ -12,8 +12,7 @@
 webkit.org/b/91666 [ Mac ] editing/pasteboard/emacs-ctrl-k-y-001.html [ Failure Slow ]
 webkit.org/b/91666 [ Mac ] editing/pasteboard/emacs-cntl-y-001.html [ ImageOnlyFailure Slow ]
 webkit.org/b/82097 editing/selection/move-by-word-visually-crash-test-5.html [ Pass Slow ]
-webkit.org/b/79679 [ Debug ] platform/chromium/virtual/gpu/fast/canvas/getPutImageDataPairTest.html [ Pass Slow ]
-webkit.org/b/79679 [ Mac Release ] platform/chromium/virtual/gpu/fast/canvas/getPutImageDataPairTest.html [ Pass Slow ]
+webkit.org/b/79679 platform/chromium/virtual/gpu/fast/canvas/getPutImageDataPairTest.html [ Pass Slow ]
 webkit.org/b/92287 [ Linux Mac Win ] fast/canvas/webgl/context-creation-and-destruction.html [ Pass Timeout Failure ]
 webkit.org/b/92287 [ Linux Mac Win ] platform/chromium/virtual/gpu/fast/canvas/webgl/context-creation-and-destruction.html [ Pass Timeout Failure ]
 crbug.com/24182 [ Debug ] fast/css/large-list-of-rules-crash.html [ Pass Slow ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139528] trunk

2013-01-11 Thread fpizlo

Title: [139528] trunk








Revision 139528
Author fpi...@apple.com
Date 2013-01-11 17:43:27 -0800 (Fri, 11 Jan 2013)


Log Message
Phantom(GetLocal) should be treated as relevant to OSR
https://bugs.webkit.org/show_bug.cgi?id=106715

Reviewed by Mark Hahnenberg.

Source/_javascript_Core: 

* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performBlockCSE):

LayoutTests: 

* fast/js/dfg-phantom-get-local-expected.txt: Added.
* fast/js/dfg-phantom-get-local.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-phantom-get-local.js: Added.
(foo):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/jsc-test-list
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp


Added Paths

trunk/LayoutTests/fast/js/dfg-phantom-get-local-expected.txt
trunk/LayoutTests/fast/js/dfg-phantom-get-local.html
trunk/LayoutTests/fast/js/script-tests/dfg-phantom-get-local.js




Diff

Modified: trunk/LayoutTests/ChangeLog (139527 => 139528)

--- trunk/LayoutTests/ChangeLog	2013-01-12 01:40:29 UTC (rev 139527)
+++ trunk/LayoutTests/ChangeLog	2013-01-12 01:43:27 UTC (rev 139528)
@@ -1,3 +1,16 @@
+2013-01-11  Filip Pizlo  fpi...@apple.com
+
+Phantom(GetLocal) should be treated as relevant to OSR
+https://bugs.webkit.org/show_bug.cgi?id=106715
+
+Reviewed by Mark Hahnenberg.
+
+* fast/js/dfg-phantom-get-local-expected.txt: Added.
+* fast/js/dfg-phantom-get-local.html: Added.
+* fast/js/jsc-test-list:
+* fast/js/script-tests/dfg-phantom-get-local.js: Added.
+(foo):
+
 2013-01-11  Levi Weintraub  le...@chromium.org
 
 Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/canvas/getPutImageDataPairTest.html


Added: trunk/LayoutTests/fast/js/dfg-phantom-get-local-expected.txt (0 => 139528)

--- trunk/LayoutTests/fast/js/dfg-phantom-get-local-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/js/dfg-phantom-get-local-expected.txt	2013-01-12 01:43:27 UTC (rev 139528)
@@ -0,0 +1,209 @@
+Tests that Phantom(GetLocal) is treated as being relevant to OSR.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}} : {f:42, g:{}}) is false
+PASS foo(i  190 ? {f:42, g:{h:3}}

[webkit-changes] [139529] trunk/Source/WebCore

2013-01-11 Thread esprehn

Title: [139529] trunk/Source/WebCore








Revision 139529
Author espr...@chromium.org
Date 2013-01-11 17:48:51 -0800 (Fri, 11 Jan 2013)


Log Message
No need to initialize RefPtrs to 0 in ElementRareData
https://bugs.webkit.org/show_bug.cgi?id=106717

Reviewed by Ryosuke Niwa.

RefPtrs initialize themself to null, so there's no reason
to do it manually. This was code leftover from when
PseudoElements were stored in bare ptrs instead of in
RefPtrs.

No new tests, just refactoring.

* dom/ElementRareData.h:
(WebCore::ElementRareData::ElementRareData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ElementRareData.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139528 => 139529)

--- trunk/Source/WebCore/ChangeLog	2013-01-12 01:43:27 UTC (rev 139528)
+++ trunk/Source/WebCore/ChangeLog	2013-01-12 01:48:51 UTC (rev 139529)
@@ -1,3 +1,20 @@
+2013-01-11  Elliott Sprehn  espr...@chromium.org
+
+No need to initialize RefPtrs to 0 in ElementRareData
+https://bugs.webkit.org/show_bug.cgi?id=106717
+
+Reviewed by Ryosuke Niwa.
+
+RefPtrs initialize themself to null, so there's no reason
+to do it manually. This was code leftover from when
+PseudoElements were stored in bare ptrs instead of in
+RefPtrs.
+
+No new tests, just refactoring.
+
+* dom/ElementRareData.h:
+(WebCore::ElementRareData::ElementRareData):
+
 2013-01-11  Huang Dongsung  luxte...@company100.net
 
 [TexMap] Rename current[Transform|Opacity|Filters] in TextureMapperLayer.


Modified: trunk/Source/WebCore/dom/ElementRareData.h (139528 => 139529)

--- trunk/Source/WebCore/dom/ElementRareData.h	2013-01-12 01:43:27 UTC (rev 139528)
+++ trunk/Source/WebCore/dom/ElementRareData.h	2013-01-12 01:48:51 UTC (rev 139529)
@@ -150,8 +150,6 @@
 
 inline ElementRareData::ElementRareData()
 : m_minimumSizeForResizing(defaultMinimumSizeForResizing())
-, m_generatedBefore(0)
-, m_generatedAfter(0)
 {
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139530] trunk/Source/WebKit/blackberry

2013-01-11 Thread commit-queue

Title: [139530] trunk/Source/WebKit/blackberry








Revision 139530
Author commit-qu...@webkit.org
Date 2013-01-11 17:49:56 -0800 (Fri, 11 Jan 2013)


Log Message
[BlackBerry] Focus zoom animation doesn't occur on devices with physical keyboard
https://bugs.webkit.org/show_bug.cgi?id=106719

Patch by Andrew Lo a...@rim.com on 2013-01-11
Reviewed by Yong Li.
Internally reviewed by Mike Fenton.

Internal PR 278687

Always ensureFocusTextElementVisible if an element is focused when
the device has a physical keyboard.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setElementFocused):

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (139529 => 139530)

--- trunk/Source/WebKit/blackberry/ChangeLog	2013-01-12 01:48:51 UTC (rev 139529)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2013-01-12 01:49:56 UTC (rev 139530)
@@ -1,3 +1,19 @@
+2013-01-11  Andrew Lo  a...@rim.com
+
+[BlackBerry] Focus zoom animation doesn't occur on devices with physical keyboard
+https://bugs.webkit.org/show_bug.cgi?id=106719
+
+Reviewed by Yong Li.
+Internally reviewed by Mike Fenton.
+
+Internal PR 278687
+
+Always ensureFocusTextElementVisible if an element is focused when
+the device has a physical keyboard.
+
+* WebKitSupport/InputHandler.cpp:
+(BlackBerry::WebKit::InputHandler::setElementFocused):
+
 2013-01-11  Otto Derek Cheung  otche...@rim.com
 
 [BlackBerry] Modifying the databaseQuota call to WebPageClient


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (139529 => 139530)

--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2013-01-12 01:48:51 UTC (rev 139529)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2013-01-12 01:49:56 UTC (rev 139530)
@@ -64,6 +64,7 @@
 #include htmlediting.h
 #include visible_units.h
 
+#include BlackBerryPlatformDeviceInfo.h
 #include BlackBerryPlatformIMF.h
 #include BlackBerryPlatformKeyboardEvent.h
 #include BlackBerryPlatformLog.h
@@ -900,7 +901,8 @@
 frame-selection()-setFocused(isInputModeEnabled());
 
 // Ensure visible when refocusing.
-m_shouldEnsureFocusTextElementVisibleOnSelectionChanged = isActiveTextEdit();
+// If device does not have physical keyboard, wait to ensure visible until VKB resizes viewport so that both animations are combined into one.
+m_shouldEnsureFocusTextElementVisibleOnSelectionChanged = isActiveTextEdit() || DeviceInfo::instance()-hasPhysicalKeyboard();
 
 // Clear the existing focus node details.
 setElementUnfocused(true /*refocusOccuring*/);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139532] trunk/Source/WebKit/chromium

2013-01-11 Thread commit-queue

Title: [139532] trunk/Source/WebKit/chromium








Revision 139532
Author commit-qu...@webkit.org
Date 2013-01-11 18:02:26 -0800 (Fri, 11 Jan 2013)


Log Message
WebWidgetClient::didHandleGestureEvent needs to distinguish the case if the event is processed or swallowed
https://bugs.webkit.org/show_bug.cgi?id=104427

Patch by Tien-Ren Chen trc...@chromium.org on 2013-01-11
Reviewed by Adam Barth.

When a gesture needs to be disambiguated, WebKit doesn't update cursor focus.
We added an extra status for didHandleGestureEvent(), so we can distinguish
the case whether the event is actually delivered to the web page or cancelled.

* public/WebViewClient.h:
* public/WebWidgetClient.h:
(WebKit):
(WebWidgetClient):
(WebKit::WebWidgetClient::didHandleGestureEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
* tests/WebViewTest.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebViewClient.h
trunk/Source/WebKit/chromium/public/WebWidgetClient.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/tests/WebViewTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (139531 => 139532)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-12 01:58:11 UTC (rev 139531)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-12 02:02:26 UTC (rev 139532)
@@ -1,3 +1,23 @@
+2013-01-11  Tien-Ren Chen  trc...@chromium.org
+
+WebWidgetClient::didHandleGestureEvent needs to distinguish the case if the event is processed or swallowed
+https://bugs.webkit.org/show_bug.cgi?id=104427
+
+Reviewed by Adam Barth.
+
+When a gesture needs to be disambiguated, WebKit doesn't update cursor focus.
+We added an extra status for didHandleGestureEvent(), so we can distinguish
+the case whether the event is actually delivered to the web page or cancelled.
+
+* public/WebViewClient.h:
+* public/WebWidgetClient.h:
+(WebKit):
+(WebWidgetClient):
+(WebKit::WebWidgetClient::didHandleGestureEvent):
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::handleGestureEvent):
+* tests/WebViewTest.cpp:
+
 2013-01-11  Eberhard Graether  egraet...@google.com
 
 [chromium] Add ContinuousPainter to call setNeedsDisplay on all layers recursively in continuous painting mode


Modified: trunk/Source/WebKit/chromium/public/WebViewClient.h (139531 => 139532)

--- trunk/Source/WebKit/chromium/public/WebViewClient.h	2013-01-12 01:58:11 UTC (rev 139531)
+++ trunk/Source/WebKit/chromium/public/WebViewClient.h	2013-01-12 02:02:26 UTC (rev 139532)
@@ -144,9 +144,6 @@
 // Called to retrieve the provider of desktop notifications.
 virtual WebNotificationPresenter* notificationPresenter() { return 0; }
 
-// Called when a gesture event is handled.
-virtual void didHandleGestureEvent(const WebGestureEvent event, bool eventSwallowed) { }
-
 // Called to request an icon for the specified filenames.
 // The icon is shown in a file upload control.
 virtual bool queryIconForFiles(const WebVectorWebString filenames, WebIconLoadingCompletion*) { return false; }


Modified: trunk/Source/WebKit/chromium/public/WebWidgetClient.h (139531 => 139532)

--- trunk/Source/WebKit/chromium/public/WebWidgetClient.h	2013-01-12 01:58:11 UTC (rev 139531)
+++ trunk/Source/WebKit/chromium/public/WebWidgetClient.h	2013-01-12 02:02:26 UTC (rev 139532)
@@ -39,6 +39,7 @@
 
 namespace WebKit {
 
+class WebGestureEvent;
 class WebString;
 class WebWidget;
 struct WebCursorInfo;
@@ -163,6 +164,15 @@
 // Returns true iff the pointer is locked to this widget.
 virtual bool isPointerLocked() { return false; }
 
+// Called when a gesture event is handled.
+enum EventStatus {
+EventStatusUnprocessed,
+EventStatusProcessed,
+EventStatusCancelled
+};
+virtual void didHandleGestureEvent(const WebGestureEvent event, EventStatus) { }
+virtual void didHandleGestureEvent(const WebGestureEvent event, bool eventSwallowed) { } // deprecated
+
 protected:
 ~WebWidgetClient() { }
 };


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (139531 => 139532)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-01-12 01:58:11 UTC (rev 139531)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-01-12 02:02:26 UTC (rev 139532)
@@ -680,7 +680,7 @@
 #if ENABLE(GESTURE_EVENTS)
 bool WebViewImpl::handleGestureEvent(const WebGestureEvent event)
 {
-bool eventSwallowed = false;
+WebWidgetClient::EventStatus eventStatus = WebWidgetClient::EventStatusUnprocessed;
 
 // Handle link highlighting outside the main switch to avoid getting lost in the
 // complicated set of cases handled below.
@@ -713,7 +713,7 @@
 OwnPtrWebGestureCurve flingCurve = adoptPtr(Platform::current()-createFlingAnimationCurve(event.sourceDevice, WebFloatPoint(event.data.flingStart.velocityX, event.data.flingStart.velocityY),

[webkit-changes] [139533] trunk/Source/WebCore

2013-01-11 Thread tonyg

Title: [139533] trunk/Source/WebCore








Revision 139533
Author to...@chromium.org
Date 2013-01-11 18:05:52 -0800 (Fri, 11 Jan 2013)


Log Message
Move HTMLTokenTypes to its own file
https://bugs.webkit.org/show_bug.cgi?id=106722

Reviewed by Levi Weintraub.

Also mark AtomicHTMLToken ctor as explicit.

No new tests because no new functionality.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
* html/parser/HTMLTokenTypes.h: Added.
(WebCore):
(HTMLTokenTypes):
(DoctypeData):
(WebCore::HTMLTokenTypes::DoctypeData::DoctypeData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/html/parser/HTMLToken.h


Added Paths

trunk/Source/WebCore/html/parser/HTMLTokenTypes.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139532 => 139533)

--- trunk/Source/WebCore/ChangeLog	2013-01-12 02:02:26 UTC (rev 139532)
+++ trunk/Source/WebCore/ChangeLog	2013-01-12 02:05:52 UTC (rev 139533)
@@ -1,3 +1,27 @@
+2013-01-11  Tony Gentilcore  to...@chromium.org
+
+Move HTMLTokenTypes to its own file
+https://bugs.webkit.org/show_bug.cgi?id=106722
+
+Reviewed by Levi Weintraub.
+
+Also mark AtomicHTMLToken ctor as explicit.
+
+No new tests because no new functionality.
+
+* GNUmakefile.list.am:
+* Target.pri:
+* WebCore.gypi:
+* WebCore.vcproj/WebCore.vcproj:
+* WebCore.xcodeproj/project.pbxproj:
+* html/parser/HTMLToken.h:
+(WebCore::AtomicHTMLToken::AtomicHTMLToken):
+* html/parser/HTMLTokenTypes.h: Added.
+(WebCore):
+(HTMLTokenTypes):
+(DoctypeData):
+(WebCore::HTMLTokenTypes::DoctypeData::DoctypeData):
+
 2013-01-11  Elliott Sprehn  espr...@chromium.org
 
 No need to initialize RefPtrs to 0 in ElementRareData


Modified: trunk/Source/WebCore/GNUmakefile.list.am (139532 => 139533)

--- trunk/Source/WebCore/GNUmakefile.list.am	2013-01-12 02:02:26 UTC (rev 139532)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2013-01-12 02:05:52 UTC (rev 139533)
@@ -3562,6 +3562,7 @@
 	Source/WebCore/html/parser/HTMLSourceTracker.h \
 	Source/WebCore/html/parser/HTMLStackItem.h \
 	Source/WebCore/html/parser/HTMLToken.h \
+	Source/WebCore/html/parser/HTMLTokenTypes.h \
 	Source/WebCore/html/parser/HTMLTokenizer.cpp \
 	Source/WebCore/html/parser/HTMLTokenizer.h \
 	Source/WebCore/html/parser/HTMLTreeBuilder.cpp \


Modified: trunk/Source/WebCore/Target.pri (139532 => 139533)

--- trunk/Source/WebCore/Target.pri	2013-01-12 02:02:26 UTC (rev 139532)
+++ trunk/Source/WebCore/Target.pri	2013-01-12 02:05:52 UTC (rev 139533)
@@ -1891,6 +1891,7 @@
 html/parser/HTMLScriptRunner.h \
 html/parser/HTMLScriptRunnerHost.h \
 html/parser/HTMLToken.h \
+html/parser/HTMLTokenTypes.h \
 html/parser/HTMLTokenizer.h \
 html/parser/HTMLTreeBuilder.h \
 html/parser/HTMLViewSourceParser.h \


Modified: trunk/Source/WebCore/WebCore.gypi (139532 => 139533)

--- trunk/Source/WebCore/WebCore.gypi	2013-01-12 02:02:26 UTC (rev 139532)
+++ trunk/Source/WebCore/WebCore.gypi	2013-01-12 02:05:52 UTC (rev 139533)
@@ -3367,6 +3367,7 @@
 'html/parser/HTMLSourceTracker.h',
 'html/parser/HTMLStackItem.h',
 'html/parser/HTMLToken.h',
+'html/parser/HTMLTokenTypes.h',
 'html/parser/HTMLTokenizer.cpp',
 'html/parser/HTMLTokenizer.h',
 'html/parser/HTMLTreeBuilder.cpp',


Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (139532 => 139533)

--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2013-01-12 02:02:26 UTC (rev 139532)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2013-01-12 02:05:52 UTC (rev 139533)
@@ -64557,6 +64557,10 @@
 	
 /File
 File
+	RelativePath=..\html\parser\HTMLTokenTypes.h
+	
+/File
+File
 	RelativePath=..\html\parser\HTMLTokenizer.cpp
 	
 /File


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (139532 => 139533)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2013-01-12 02:02:26 UTC (rev 139532)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2013-01-12 02:05:52 UTC (rev 139533)
@@ -5,6 +5,7 @@
 		97C0784F1165D5BE003A32EF /* SuffixTree.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SuffixTree.h; sourceTree = group; };
 		97C1F552122855CB00EDE615 /* HTMLStackItem.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = HTMLStackItem.h; path = parser/HTMLStackItem.h; sourceTree = group; };
 		97C1F552122855CB00EDE616 /* HTMLToken.h */ = {isa =

[webkit-changes] [139534] trunk/LayoutTests

2013-01-11 Thread commit-queue

Title: [139534] trunk/LayoutTests








Revision 139534
Author commit-qu...@webkit.org
Date 2013-01-11 18:07:18 -0800 (Fri, 11 Jan 2013)


Log Message
Need new accessibility layout test to verify levels of headings
https://bugs.webkit.org/show_bug.cgi?id=106243

Patch by James Craig ja...@cookiecrook.com on 2013-01-11
Reviewed by Chris Fleizach.

New layout test to verify accessibility API heading levels on implicit h1-h6 and explicit @aria-level.

* accessibility/heading-level-expected.txt: Added.
* accessibility/heading-level.html: Added.
* platform/chromium/TestExpectations: Skip for Chromium due to webkit.org/b/106682

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations


Added Paths

trunk/LayoutTests/accessibility/heading-level-expected.txt
trunk/LayoutTests/accessibility/heading-level.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139533 => 139534)

--- trunk/LayoutTests/ChangeLog	2013-01-12 02:05:52 UTC (rev 139533)
+++ trunk/LayoutTests/ChangeLog	2013-01-12 02:07:18 UTC (rev 139534)
@@ -1,3 +1,16 @@
+2013-01-11  James Craig  ja...@cookiecrook.com
+
+Need new accessibility layout test to verify levels of headings
+https://bugs.webkit.org/show_bug.cgi?id=106243
+
+Reviewed by Chris Fleizach.
+
+New layout test to verify accessibility API heading levels on implicit h1-h6 and explicit @aria-level.
+
+* accessibility/heading-level-expected.txt: Added.
+* accessibility/heading-level.html: Added.
+* platform/chromium/TestExpectations: Skip for Chromium due to webkit.org/b/106682
+
 2013-01-11  Filip Pizlo  fpi...@apple.com
 
 Phantom(GetLocal) should be treated as relevant to OSR


Added: trunk/LayoutTests/accessibility/heading-level-expected.txt (0 => 139534)

--- trunk/LayoutTests/accessibility/heading-level-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/heading-level-expected.txt	2013-01-12 02:07:18 UTC (rev 139534)
@@ -0,0 +1,27 @@
+This tests that headings have a level matching the implicit default value or explicitly defined aria-level value.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS: level is 1.
+PASS: level is 2.
+PASS: level is 3.
+PASS: level is 4.
+PASS: level is 5.
+PASS: level is 6.
+PASS: level is 1.
+PASS: level is 2.
+PASS: level is 3.
+PASS: level is 4.
+PASS: level is 5.
+PASS: level is 6.
+PASS: level is 1.
+PASS: level is 2.
+PASS: level is 3.
+PASS: level is 4.
+PASS: level is 5.
+PASS: level is 6.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/accessibility/heading-level.html (0 => 139534)

--- trunk/LayoutTests/accessibility/heading-level.html	(rev 0)
+++ trunk/LayoutTests/accessibility/heading-level.html	2013-01-12 02:07:18 UTC (rev 139534)
@@ -0,0 +1,66 @@
+!DOCTYPE HTML
+html
+body
+script src=""
+
+!-- implicit level of tag --
+h1 class=ex data-expected=1X/h1
+h2 class=ex data-expected=2X/h2
+h3 class=ex data-expected=3X/h3
+h4 class=ex data-expected=4X/h4
+h5 class=ex data-expected=5X/h5
+h6 class=ex data-expected=6X/h6
+
+!-- explicit aria-level overrides on h1-h6 (withOUT explicit heading role declaration) does not work in current WebKit. --
+!-- Waiting on thread resolution to determine if it's a bug: http://lists.w3.org/Archives/Public/wai-xtech/2013Jan/0019.html --
+!-- 
+h6 class=ex data-expected=1 aria-level=1X/h6
+h5 class=ex data-expected=2 aria-level=2X/h5
+h4 class=ex data-expected=3 aria-level=3X/h4
+h3 class=ex data-expected=4 aria-level=4X/h3
+h2 class=ex data-expected=5 aria-level=5X/h2
+h1 class=ex data-expected=6 aria-level=6X/h1
+--
+
+!-- explicit aria-level overrides on h1-h6 (with explicit heading role declaration) --
+h6 class=ex role=heading data-expected=1 aria-level=1X/h6
+h5 class=ex role=heading data-expected=2 aria-level=2X/h5
+h4 class=ex role=heading data-expected=3 aria-level=3X/h4
+h3 class=ex role=heading data-expected=4 aria-level=4X/h3
+h2 class=ex role=heading data-expected=5 aria-level=5X/h2
+h1 class=ex role=heading data-expected=6 aria-level=6X/h1
+
+!-- explicit aria-level set on div with explicit heading role declaration --
+div class=ex role=heading data-expected=1 aria-level=1X/div
+div class=ex role=heading data-expected=2 aria-level=2X/div
+div class=ex role=heading data-expected=3 aria-level=3X/div
+div class=ex role=heading data-expected=4 aria-level=4X/div
+div class=ex role=heading data-expected=5 aria-level=5X/div
+div class=ex role=heading data-expected=6 aria-level=6X/div
+
+!-- todo: h1 elements nested in section elements should inherit nested level. --
+
+div id=console/div
+script
+if (window.testRunner  window.accessibilityController) {
+description(This tests that headings have a level matching the implicit default value or explicitly defined aria-level value.)
+var examples = document.querySelectorAll('.ex');
+for (var i = 0, c = examples.length; i  c;

1 2 >

1 - 100 of 106 matches

Mail list logo