from:"nvasilyev"

[webkit-changes] [186278] trunk/Source/WebInspectorUI

2015-07-04 Thread nvasilyev

Title: [186278] trunk/Source/WebInspectorUI








Revision 186278
Author nvasil...@apple.com
Date 2015-07-04 07:45:09 -0700 (Sat, 04 Jul 2015)


Log Message
Web Inspector: The arrow that appears for Web Inspector Layout  Rendering records overlaps the category switcher
https://bugs.webkit.org/show_bug.cgi?id=146605

Reviewed by Timothy Hatcher.

* UserInterface/Views/TimelineDataGrid.css:
(.data-grid.timeline  .navigation-bar-container):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (186277 => 186278)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-07-04 04:13:00 UTC (rev 186277)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-07-04 14:45:09 UTC (rev 186278)
@@ -1,3 +1,13 @@
+2015-07-04  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: The arrow that appears for Web Inspector Layout  Rendering records overlaps the category switcher
+https://bugs.webkit.org/show_bug.cgi?id=146605
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/TimelineDataGrid.css:
+(.data-grid.timeline  .navigation-bar-container):
+
 2015-07-03  Dan Bernstein  m...@apple.com
 
 [Xcode] Update some build settings as recommended by Xcode 7


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.css (186277 => 186278)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.css	2015-07-04 04:13:00 UTC (rev 186277)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.css	2015-07-04 14:45:09 UTC (rev 186278)
@@ -34,6 +34,7 @@
 right: 0;
 height: 32px;
 
+z-index: 10;
 pointer-events: none;
 visibility: hidden;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [186102] trunk/Source/WebInspectorUI

2015-06-29 Thread nvasilyev

Title: [186102] trunk/Source/WebInspectorUI








Revision 186102
Author nvasil...@apple.com
Date 2015-06-29 17:47:29 -0700 (Mon, 29 Jun 2015)


Log Message
Web Inspector: Unable to select the text of an inline error message
https://bugs.webkit.org/show_bug.cgi?id=145813

Reviewed by Timothy Hatcher.

* UserInterface/Views/CodeMirrorOverrides.css:
(.CodeMirror-linewidget):
* UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor.prototype.createWidgetForLine):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorOverrides.css
trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (186101 => 186102)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-06-30 00:40:33 UTC (rev 186101)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-06-30 00:47:29 UTC (rev 186102)
@@ -1,3 +1,15 @@
+2015-06-29  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: Unable to select the text of an inline error message
+https://bugs.webkit.org/show_bug.cgi?id=145813
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/CodeMirrorOverrides.css:
+(.CodeMirror-linewidget):
+* UserInterface/Views/TextEditor.js:
+(WebInspector.TextEditor.prototype.createWidgetForLine):
+
 2015-06-29  Joseph Pecoraro  pecor...@apple.com
 
 Web Inspector: Remove harmless error for not getting named flows


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorOverrides.css (186101 => 186102)

--- trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorOverrides.css	2015-06-30 00:40:33 UTC (rev 186101)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorOverrides.css	2015-06-30 00:47:29 UTC (rev 186102)
@@ -80,3 +80,7 @@
 line-height: 13px;
 text-align: right;
 }
+
+.CodeMirror-linewidget {
+-webkit-user-select: text;
+}


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js (186101 => 186102)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js	2015-06-30 00:40:33 UTC (rev 186101)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js	2015-06-30 00:47:29 UTC (rev 186102)
@@ -593,7 +593,7 @@
 return null;
 
 var widgetElement = document.createElement(div);
-var lineWidget = this._codeMirror.addLineWidget(lineHandle, widgetElement, {coverGutter: false, noHScroll: true, handleMouseEvents: true});
+var lineWidget = this._codeMirror.addLineWidget(lineHandle, widgetElement, {coverGutter: false, noHScroll: true});
 return new WebInspector.LineWidget(lineWidget, widgetElement);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [186042] trunk/Source/WebInspectorUI

2015-06-28 Thread nvasilyev

Title: [186042] trunk/Source/WebInspectorUI








Revision 186042
Author nvasil...@apple.com
Date 2015-06-28 00:43:13 -0700 (Sun, 28 Jun 2015)


Log Message
Web Inspector: Wrong border color of console messages when filters are enabled
https://bugs.webkit.org/show_bug.cgi?id=146392

Reviewed by Timothy Hatcher.

* UserInterface/Views/LogContentView.css:
(.console-error-level:not(.filtered-out, .filtered-out-by-search) + .console-item):
(.console-warning-level:not(.filtered-out, .filtered-out-by-search) + .console-item):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (186041 => 186042)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-06-28 03:47:00 UTC (rev 186041)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-06-28 07:43:13 UTC (rev 186042)
@@ -1,3 +1,14 @@
+2015-06-28  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: Wrong border color of console messages when filters are enabled
+https://bugs.webkit.org/show_bug.cgi?id=146392
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/LogContentView.css:
+(.console-error-level:not(.filtered-out, .filtered-out-by-search) + .console-item):
+(.console-warning-level:not(.filtered-out, .filtered-out-by-search) + .console-item):
+
 2015-06-25  Matt Baker  mattba...@apple.com
 
 Web Inspector: Wrong timeline selected after switching from Rendering Frames to Timelines


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css (186041 => 186042)

--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css	2015-06-28 03:47:00 UTC (rev 186041)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css	2015-06-28 07:43:13 UTC (rev 186042)
@@ -50,11 +50,13 @@
 border-top: 1px solid rgb(240, 240, 240);
 }
 
-.console-error-level + .console-item {
+.console-error-level:not(.filtered-out, .filtered-out-by-search),
+.console-error-level:not(.filtered-out, .filtered-out-by-search) + .console-item {
 border-top-color: hsl(0, 100%, 92%);
 }
 
-.console-warning-level + .console-item {
+.console-warning-level:not(.filtered-out, .filtered-out-by-search),
+.console-warning-level:not(.filtered-out, .filtered-out-by-search) + .console-item {
 border-top-color: hsl(40, 100%, 90%);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [185836] trunk/Source/WebInspectorUI

2015-06-22 Thread nvasilyev

Title: [185836] trunk/Source/WebInspectorUI








Revision 185836
Author nvasil...@apple.com
Date 2015-06-22 10:53:43 -0700 (Mon, 22 Jun 2015)


Log Message
Web Inspector: Consider making read-only style rules have a darker background
https://bugs.webkit.org/show_bug.cgi?id=145983

Reviewed by Timothy Hatcher.

* UserInterface/Views/CSSStyleDeclarationSection.css:
(.style-declaration-section:not(.locked)):
(.style-declaration-section): Deleted.
* UserInterface/Views/CSSStyleDeclarationTextEditor.css:
(.css-style-text-editor.read-only  .CodeMirror):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (185835 => 185836)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-06-22 17:47:33 UTC (rev 185835)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-06-22 17:53:43 UTC (rev 185836)
@@ -1,5 +1,18 @@
 2015-06-22  Nikita Vasilyev  nvasil...@apple.com
 
+Web Inspector: Consider making read-only style rules have a darker background
+https://bugs.webkit.org/show_bug.cgi?id=145983
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/CSSStyleDeclarationSection.css:
+(.style-declaration-section:not(.locked)):
+(.style-declaration-section): Deleted.
+* UserInterface/Views/CSSStyleDeclarationTextEditor.css:
+(.css-style-text-editor.read-only  .CodeMirror):
+
+2015-06-22  Nikita Vasilyev  nvasil...@apple.com
+
 Web Inspector: Unable to select text of user input messages in the console
 https://bugs.webkit.org/show_bug.cgi?id=145888
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css (185835 => 185836)

--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css	2015-06-22 17:47:33 UTC (rev 185835)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css	2015-06-22 17:53:43 UTC (rev 185836)
@@ -29,10 +29,13 @@
 
 padding: 5px;
 
-background-color: white;
 border-bottom: 1px solid rgb(179, 179, 179);
 }
 
+.style-declaration-section:not(.locked) {
+background-color: white;
+}
+
 .style-declaration-section.last-in-group {
 margin-bottom: 15px;
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.css (185835 => 185836)

--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.css	2015-06-22 17:47:33 UTC (rev 185835)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.css	2015-06-22 17:53:43 UTC (rev 185836)
@@ -53,6 +53,11 @@
 text-indent: 0;
 }
 
+.css-style-text-editor.read-only,
+.css-style-text-editor.read-only  .CodeMirror {
+background-color: transparent;
+}
+
 .css-style-text-editor.read-only  .CodeMirror pre {
 text-indent: 0;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [185835] trunk/Source/WebInspectorUI

2015-06-22 Thread nvasilyev

Title: [185835] trunk/Source/WebInspectorUI








Revision 185835
Author nvasil...@apple.com
Date 2015-06-22 10:47:33 -0700 (Mon, 22 Jun 2015)


Log Message
Web Inspector: Unable to select text of user input messages in the console
https://bugs.webkit.org/show_bug.cgi?id=145888

Reviewed by Timothy Hatcher.

* UserInterface/Views/ConsoleMessageView.css:
(.console-user-command  .console-message-text):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (185834 => 185835)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-06-22 17:41:59 UTC (rev 185834)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-06-22 17:47:33 UTC (rev 185835)
@@ -1,3 +1,13 @@
+2015-06-22  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: Unable to select text of user input messages in the console
+https://bugs.webkit.org/show_bug.cgi?id=145888
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/ConsoleMessageView.css:
+(.console-user-command  .console-message-text):
+
 2015-06-20  Nikita Vasilyev  nvasil...@apple.com
 
 Web Inspector: Unable to select parent element in the DOM tree path bar


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css (185834 => 185835)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css	2015-06-22 17:41:59 UTC (rev 185834)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css	2015-06-22 17:47:33 UTC (rev 185835)
@@ -199,6 +199,7 @@
 
 .console-user-command  .console-message-text {
 color: rgb(0, 128, 255);
+-webkit-user-select: text;
 }
 
 .console-saved-variable {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [185263] trunk/Source/WebInspectorUI

2015-06-05 Thread nvasilyev

Title: [185263] trunk/Source/WebInspectorUI








Revision 185263
Author nvasil...@apple.com
Date 2015-06-05 14:36:16 -0700 (Fri, 05 Jun 2015)


Log Message
Web Inspector: [REGRESSION] Dashboard's resource count does not reset when main resource navigates
https://bugs.webkit.org/show_bug.cgi?id=144553

Add missing _mainResourceDidChange, which was removed after switching to the tabs UI.

Reviewed by Timothy Hatcher.

* UserInterface/Models/DefaultDashboard.js:
(WebInspector.DefaultDashboard):
_waitingForFirstMainResourceToStartTrackingSize is not used anywhere, remove it.

(WebInspector.DefaultDashboard.prototype._mainResourceDidChange): Added.

(WebInspector.DefaultDashboard.prototype._resourceSizeDidChange): Removed.
Unused.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/DefaultDashboard.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (185262 => 185263)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-06-05 21:31:27 UTC (rev 185262)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-06-05 21:36:16 UTC (rev 185263)
@@ -1,3 +1,21 @@
+2015-06-05  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: [REGRESSION] Dashboard's resource count does not reset when main resource navigates
+https://bugs.webkit.org/show_bug.cgi?id=144553
+
+Add missing _mainResourceDidChange, which was removed after switching to the tabs UI.
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Models/DefaultDashboard.js:
+(WebInspector.DefaultDashboard):
+_waitingForFirstMainResourceToStartTrackingSize is not used anywhere, remove it.
+
+(WebInspector.DefaultDashboard.prototype._mainResourceDidChange): Added.
+
+(WebInspector.DefaultDashboard.prototype._resourceSizeDidChange): Removed.
+Unused.
+
 2015-06-05  Matt Baker  mattba...@apple.com
 
 Web Inspector: Switch to doughnut chart and remove idle time in the Rendering Frames timeline


Modified: trunk/Source/WebInspectorUI/UserInterface/Models/DefaultDashboard.js (185262 => 185263)

--- trunk/Source/WebInspectorUI/UserInterface/Models/DefaultDashboard.js	2015-06-05 21:31:27 UTC (rev 185262)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/DefaultDashboard.js	2015-06-05 21:36:16 UTC (rev 185263)
@@ -29,9 +29,8 @@
 {
 super();
 
-this._waitingForFirstMainResourceToStartTrackingSize = true;
-
 // Necessary events required to track load of resources.
+WebInspector.Frame.addEventListener(WebInspector.Frame.Event.MainResourceDidChange, this._mainResourceDidChange, this);
 WebInspector.Frame.addEventListener(WebInspector.Frame.Event.ResourceWasAdded, this._resourceWasAdded, this);
 WebInspector.frameResourceManager.addEventListener(WebInspector.FrameResourceManager.Event.FrameWasAdded, this._frameWasAdded, this);
 
@@ -100,6 +99,15 @@
 this.dispatchEventToListeners(WebInspector.DefaultDashboard.Event.DataDidChange);
 }
 
+_mainResourceDidChange(event)
+{
+if (!event.target.isMainFrame())
+return;
+
+this._resourcesCount = 1;
+this._dataDidChange();
+}
+
 _resourceWasAdded(event)
 {
 ++this.resourcesCount;
@@ -110,11 +118,6 @@
 ++this.resourcesCount;
 }
 
-_resourceSizeDidChange(event)
-{
-this.resourcesSize += event.target.size - event.data.previousSize;
-}
-
 _consoleMessageAdded(event)
 {
 var message = event.data.message;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [185236] trunk/Source/WebInspectorUI

2015-06-04 Thread nvasilyev

Title: [185236] trunk/Source/WebInspectorUI








Revision 185236
Author nvasil...@apple.com
Date 2015-06-04 21:31:18 -0700 (Thu, 04 Jun 2015)


Log Message
Web Inspector: Close and open tabs on mouseup, not mousedown
https://bugs.webkit.org/show_bug.cgi?id=145656

Match Safari's behaviour.

Reviewed by Timothy Hatcher.

* UserInterface/Views/TabBar.js:
(WebInspector.TabBar):
(WebInspector.TabBar.prototype.set newTabItem):
(WebInspector.TabBar.prototype._handleMouseDown):
(WebInspector.TabBar.prototype._handleClick): Added.
(WebInspector.TabBar.prototype._handleMouseUp):
(WebInspector.TabBar.prototype._handleNewTabClick): Added.
(WebInspector.TabBar.prototype._handleMouseMoved):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (185235 => 185236)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-06-05 03:37:35 UTC (rev 185235)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-06-05 04:31:18 UTC (rev 185236)
@@ -1,5 +1,23 @@
 2015-06-04  Nikita Vasilyev  nvasil...@apple.com
 
+Web Inspector: Close and open tabs on mouseup, not mousedown
+https://bugs.webkit.org/show_bug.cgi?id=145656
+
+Match Safari's behaviour.
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/TabBar.js:
+(WebInspector.TabBar):
+(WebInspector.TabBar.prototype.set newTabItem):
+(WebInspector.TabBar.prototype._handleMouseDown):
+(WebInspector.TabBar.prototype._handleClick): Added.
+(WebInspector.TabBar.prototype._handleMouseUp):
+(WebInspector.TabBar.prototype._handleNewTabClick): Added.
+(WebInspector.TabBar.prototype._handleMouseMoved):
+
+2015-06-04  Nikita Vasilyev  nvasil...@apple.com
+
 Web Inspector: Decrease tabs height to match Safari's tabs height
 https://bugs.webkit.org/show_bug.cgi?id=145647
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js (185235 => 185236)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js	2015-06-05 03:37:35 UTC (rev 185235)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js	2015-06-05 04:31:18 UTC (rev 185236)
@@ -38,6 +38,7 @@
 this._element.appendChild(topBorderElement);
 
 this._element.addEventListener(mousedown, this._handleMouseDown.bind(this));
+this._element.addEventListener(click, this._handleClick.bind(this));
 this._element.addEventListener(mouseleave, this._handleMouseLeave.bind(this));
 
 this._tabBarItems = [];
@@ -57,17 +58,22 @@
 
 set newTabItem(newTabItem)
 {
+if (!this._handleNewTabClickListener)
+this._handleNewTabClickListener = this._handleNewTabClick.bind(this);
+
 if (!this._handleNewTabMouseEnterListener)
 this._handleNewTabMouseEnterListener = this._handleNewTabMouseEnter.bind(this);
 
 if (this._newTabItem) {
 this._newTabItem.element.classList.remove(new-tab-button);
+this._newTabItem.element.removeEventListener(click, this._handleNewTabClickListener);
 this._newTabItem.element.removeEventListener(mouseenter, this._handleNewTabMouseEnterListener);
 this.removeTabBarItem(this._newTabItem, true);
 }
 
 if (newTabItem) {
 newTabItem.element.classList.add(new-tab-button);
+newTabItem.element.addEventListener(click, this._handleNewTabClickListener);
 newTabItem.element.addEventListener(mouseenter, this._handleNewTabMouseEnterListener);
 this.addTabBarItem(newTabItem, true);
 }
@@ -552,16 +558,12 @@
 if (tabBarItem.disabled)
 return;
 
-if (tabBarItem === this._newTabItem) {
-this.dispatchEventToListeners(WebInspector.TabBar.Event.NewTabItemClicked);
+if (tabBarItem === this._newTabItem)
 return;
-}
 
 var closeButtonElement = event.target.enclosingNodeOrSelfWithClass(WebInspector.TabBarItem.CloseButtonStyleClassName);
-if (closeButtonElement) {
-this.removeTabBarItem(tabBarItem, false, true);
+if (closeButtonElement)
 return;
-}
 
 this.selectedTabBarItem = tabBarItem;
 
@@ -589,6 +591,24 @@
 event.stopPropagation();
 }
 
+_handleClick(event)
+{
+var itemElement = event.target.enclosingNodeOrSelfWithClass(WebInspector.TabBarItem.StyleClassName);
+if (!itemElement)
+return;
+
+var tabBarItem = itemElement[WebInspector.TabBarItem.ElementReferenceSymbol];
+if (!tabBarItem)
+return;
+
+if (tabBarItem.disabled)
+return;
+
+var closeButtonElement = event.target.enclosingNodeOrSelfWithClass(WebInspector.TabBarItem.CloseButtonStyleClassName);
+if (closeButtonElement)
+this.removeTabBarItem(tabBarItem, false, true);
+}
+

[webkit-changes] [185214] trunk/Source/WebInspectorUI

2015-06-04 Thread nvasilyev

Title: [185214] trunk/Source/WebInspectorUI








Revision 185214
Author nvasil...@apple.com
Date 2015-06-04 13:43:20 -0700 (Thu, 04 Jun 2015)


Log Message
Web Inspector: Decrease tabs height to match Safari's tabs height
https://bugs.webkit.org/show_bug.cgi?id=145647

Reviewed by Timothy Hatcher.

* UserInterface/Views/TabBar.css:
(.tab-bar):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (185213 => 185214)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-06-04 20:15:14 UTC (rev 185213)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-06-04 20:43:20 UTC (rev 185214)
@@ -1,3 +1,13 @@
+2015-06-04  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: Decrease tabs height to match Safari's tabs height
+https://bugs.webkit.org/show_bug.cgi?id=145647
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/TabBar.css:
+(.tab-bar):
+
 2015-06-04  Tobias Reiss  tobi+web...@basecode.de
 
 Web Inspector: Activity Viewer does not update on Clear Log on reload


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css (185213 => 185214)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css	2015-06-04 20:15:14 UTC (rev 185213)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css	2015-06-04 20:43:20 UTC (rev 185214)
@@ -35,7 +35,7 @@
 background-image: linear-gradient(to bottom, rgb(199, 199, 199), rgb(184, 184, 184));
 background-size: 100% 200%;
 
-height: 30px;
+height: 26px;
 
 white-space: nowrap;
 overflow: hidden;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [185164] trunk/Source/WebInspectorUI

2015-06-03 Thread nvasilyev

Title: [185164] trunk/Source/WebInspectorUI








Revision 185164
Author nvasil...@apple.com
Date 2015-06-03 13:37:23 -0700 (Wed, 03 Jun 2015)


Log Message
Web Inspector: Search field bottom border doesn't match the rest of the toolbar
https://bugs.webkit.org/show_bug.cgi?id=145611

Reviewed by Timothy Hatcher.

* UserInterface/Views/Toolbar.css:
(body:not(.unknown-mac) .toolbar .search-bar  input[type=search]):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (185163 => 185164)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-06-03 20:36:25 UTC (rev 185163)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-06-03 20:37:23 UTC (rev 185164)
@@ -1,3 +1,13 @@
+2015-06-03  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: Search field bottom border doesn't match the rest of the toolbar
+https://bugs.webkit.org/show_bug.cgi?id=145611
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/Toolbar.css:
+(body:not(.unknown-mac) .toolbar .search-bar  input[type=search]):
+
 2015-06-03  Joseph Pecoraro  pecor...@apple.com
 
 Web Inspector: Uncaught exception starting a NavigationBar drag and mousing over a different NavigationBar


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css (185163 => 185164)

--- trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css	2015-06-03 20:36:25 UTC (rev 185163)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css	2015-06-03 20:37:23 UTC (rev 185164)
@@ -125,7 +125,7 @@
 }
 
 body:not(.unknown-mac) .toolbar .search-bar  input[type=search] {
-box-shadow: hsla(0, 0%, 0%, 0.3) 0 1px 1px -1px, 0 0 0 7px hsla(211, 96%, 48%, 0);
+box-shadow: 0 0 0 7px hsla(211, 96%, 48%, 0);
 transition: box-shadow .25s cubic-bezier(0.165, 0.840, 0.440, 1) /* easeOutQuart */;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [185135] trunk/Source/WebInspectorUI

2015-06-02 Thread nvasilyev

Title: [185135] trunk/Source/WebInspectorUI








Revision 185135
Author nvasil...@apple.com
Date 2015-06-02 16:58:42 -0700 (Tue, 02 Jun 2015)


Log Message
Web Inspector: Dashboard arrow icon on the right is overlapped by a long function/file name
https://bugs.webkit.org/show_bug.cgi?id=145540

Also, increase clickable area of the arrow icon.

Reviewed by Timothy Hatcher.

* UserInterface/Views/DashboardContainerView.css:
(.dashboard-container .advance-arrow):
(.dashboard-container .advance-arrow.advance-forward):
(.dashboard-container .advance-arrow.advance-backward):
* UserInterface/Views/DebuggerDashboardView.css:
(.dashboard.debugger  .location):
(.toolbar .dashboard.debugger):
Increase padding on the right so the content of the dashboard would be never be overlayed by the arrow.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css
trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (185134 => 185135)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-06-02 23:56:12 UTC (rev 185134)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-06-02 23:58:42 UTC (rev 185135)
@@ -1,3 +1,21 @@
+2015-06-02  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: Dashboard arrow icon on the right is overlapped by a long function/file name
+https://bugs.webkit.org/show_bug.cgi?id=145540
+
+Also, increase clickable area of the arrow icon.
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/DashboardContainerView.css:
+(.dashboard-container .advance-arrow):
+(.dashboard-container .advance-arrow.advance-forward):
+(.dashboard-container .advance-arrow.advance-backward):
+* UserInterface/Views/DebuggerDashboardView.css:
+(.dashboard.debugger  .location):
+(.toolbar .dashboard.debugger):
+Increase padding on the right so the content of the dashboard would be never be overlayed by the arrow.
+
 2015-06-02  Joseph Pecoraro  pecor...@apple.com
 
 Web Inspector: Shift + Cmd + Left/Right shouldn't switch tabs while editing text


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css (185134 => 185135)

--- trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css	2015-06-02 23:56:12 UTC (rev 185134)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css	2015-06-02 23:58:42 UTC (rev 185135)
@@ -114,10 +114,11 @@
 
 .dashboard-container .advance-arrow {
 position: absolute;
-right: 0px;
-width: 10px;
-height: 10px;
-margin: 4px;
+right: 0;
+width: 12px;
+top: 0;
+bottom: 0;
+padding: 4px 0;
 opacity: 0.6;
 
 z-index: 1000;
@@ -127,6 +128,7 @@
 
 transition-property: opacity;
 transition-duration: 0.2s;
+background-clip: content-box;
 }
 
 .dashboard-container .advance-arrow:hover {
@@ -151,10 +153,10 @@
 
 .dashboard-container .advance-arrow.advance-forward {
 top: 0;
-background-position: 0% 0%;
+background-position: 50% 4px;
 }
 
 .dashboard-container .advance-arrow.advance-backward {
 bottom: 0;
-background-position: 0% 100%;
+background-position: 50% -4px;
 }


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css (185134 => 185135)

--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css	2015-06-02 23:56:12 UTC (rev 185134)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css	2015-06-02 23:58:42 UTC (rev 185135)
@@ -31,7 +31,7 @@
 text-align: center;
 text-shadow: rgba(255, 255, 255, 0.5) 0 1px 0;
 color: rgb(60, 60, 60);
-padding: 0 5px;
+padding: 0 12px 0 5px;
 }
 
 .dashboard.debugger  .message {
@@ -90,6 +90,7 @@
 }
 
 .dashboard.debugger  .location {
+overflow: hidden;
 flex: initial;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [185139] trunk/Source/WebInspectorUI

2015-06-02 Thread nvasilyev

Title: [185139] trunk/Source/WebInspectorUI








Revision 185139
Author nvasil...@apple.com
Date 2015-06-02 19:46:44 -0700 (Tue, 02 Jun 2015)


Log Message
Web Inspector: Use non-monospace font for the frame selector
https://bugs.webkit.org/show_bug.cgi?id=145586

Reviewed by Timothy Hatcher.

* UserInterface/Views/HierarchicalPathComponent.css:
(.hierarchical-path-component):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (185138 => 185139)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-06-03 02:33:16 UTC (rev 185138)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-06-03 02:46:44 UTC (rev 185139)
@@ -1,5 +1,15 @@
 2015-06-02  Nikita Vasilyev  nvasil...@apple.com
 
+Web Inspector: Use non-monospace font for the frame selector
+https://bugs.webkit.org/show_bug.cgi?id=145586
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/HierarchicalPathComponent.css:
+(.hierarchical-path-component):
+
+2015-06-02  Nikita Vasilyev  nvasil...@apple.com
+
 Web Inspector: Dashboard arrow icon on the right is overlapped by a long function/file name
 https://bugs.webkit.org/show_bug.cgi?id=145540
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css (185138 => 185139)

--- trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css	2015-06-03 02:33:16 UTC (rev 185138)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css	2015-06-03 02:46:44 UTC (rev 185139)
@@ -28,6 +28,9 @@
 position: relative;
 height: 20px;
 min-width: 32px;
+
+font-family: -webkit-system-font, sans-serif;
+font-size: 11px;
 }
 
 .hierarchical-path-component.show-selector-arrows {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [185094] trunk/Source/WebInspectorUI

2015-06-01 Thread nvasilyev

Title: [185094] trunk/Source/WebInspectorUI








Revision 185094
Author nvasil...@apple.com
Date 2015-06-01 18:53:45 -0700 (Mon, 01 Jun 2015)


Log Message
Web Inspector: Pause/resume button in the debugger dashboard is vertically misaligned
https://bugs.webkit.org/show_bug.cgi?id=145534

Reviewed by Timothy Hatcher.

* UserInterface/Views/ButtonNavigationItem.css:
(.navigation-bar .item.button.suppress-emboss):
Never show borders for the pause/resume button.

* UserInterface/Views/DebuggerDashboardView.css:
(.dashboard.debugger .navigation-bar .item.button):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.css
trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (185093 => 185094)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-06-02 01:29:38 UTC (rev 185093)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-06-02 01:53:45 UTC (rev 185094)
@@ -1,3 +1,17 @@
+2015-06-01  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: Pause/resume button in the debugger dashboard is vertically misaligned
+https://bugs.webkit.org/show_bug.cgi?id=145534
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/ButtonNavigationItem.css:
+(.navigation-bar .item.button.suppress-emboss):
+Never show borders for the pause/resume button.
+
+* UserInterface/Views/DebuggerDashboardView.css:
+(.dashboard.debugger .navigation-bar .item.button):
+
 2015-05-31  Yusuke Suzuki  utatane@gmail.com
 
 Web Inspector: Drop forEach from WeakMap / WeakSet native member function maps


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.css (185093 => 185094)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.css	2015-06-02 01:29:38 UTC (rev 185093)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.css	2015-06-02 01:53:45 UTC (rev 185094)
@@ -62,6 +62,12 @@
 opacity: 0.35 !important;
 }
 
+.navigation-bar .item.button.suppress-emboss {
+background-image: none !important;
+border-color: transparent !important;
+box-shadow: none !important;
+}
+
 .navigation-bar .item.button.suppress-emboss  .glyph {
 background-color: rgb(95, 95, 95);
 }


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css (185093 => 185094)

--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css	2015-06-02 01:29:38 UTC (rev 185093)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css	2015-06-02 01:53:45 UTC (rev 185094)
@@ -50,6 +50,7 @@
 .dashboard.debugger .navigation-bar .item.button {
 flex-direction: row;
 width: 16px;
+height: 16px;
 cursor: pointer;
 padding: 0;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [184978] trunk/Source/WebInspectorUI

2015-05-28 Thread nvasilyev

Title: [184978] trunk/Source/WebInspectorUI








Revision 184978
Author nvasil...@apple.com
Date 2015-05-28 21:50:59 -0700 (Thu, 28 May 2015)


Log Message
Web Inspector: Update toolbar styles
https://bugs.webkit.org/show_bug.cgi?id=145419

Also, use hairline borders (1 phisical pixel) on retina (DPI = 2).

Reviewed by Timothy Hatcher.

* UserInterface/Views/ButtonToolbarItem.css:
(.toolbar .item.button): Deleted.
(.toolbar.icon-and-label-vertical .item.button): Deleted.
(.toolbar.icon-and-label-horizontal .item.button): Deleted.
(.toolbar .item.button  .glyph): Deleted.
(.toolbar.small-size .item.button  .glyph): Deleted.
* UserInterface/Views/DashboardContainerView.css:
(.toolbar .dashboard-container): Deleted.
(.toolbar.collapsed .dashboard-container): Deleted.
(.toolbar.small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container): Deleted.
(.toolbar .dashboard.slide-out-down): Deleted.
(.toolbar .dashboard.slide-in-up): Deleted.
* UserInterface/Views/Toolbar.css:
(.toolbar .search-bar  input[type=search]):
(.toolbar .search-bar  input[type=search]::-webkit-textfield-decoration-container):
(body:not(.unknown-mac) .toolbar .dashboard-container):
(body:not(.unknown-mac) .toolbar .search-bar  input[type=search]):
(body:not(.unknown-mac) .toolbar .search-bar  input[type=search]:focus):
(body:not(.unknown-mac) .toolbar .item.button:active):
(body.window-inactive:not(.unknown-mac) .toolbar .dashboard-container):
(body.unknown-mac .toolbar .dashboard-container):
(body.unknown-mac .toolbar .search-bar  input[type=search]):
(body.unknown-mac .toolbar .search-bar  input[type=search]:focus):
(@media (-webkit-min-device-pixel-ratio: 2)):
(body.unknown-mac .toolbar .item.button:active):
(body.unknown-mac.window-inactive .toolbar .dashboard-container):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.css
trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css
trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (184977 => 184978)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-05-29 04:47:39 UTC (rev 184977)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-05-29 04:50:59 UTC (rev 184978)
@@ -1,3 +1,39 @@
+2015-05-28  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: Update toolbar styles
+https://bugs.webkit.org/show_bug.cgi?id=145419
+
+Also, use hairline borders (1 phisical pixel) on retina (DPI = 2).
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/ButtonToolbarItem.css:
+(.toolbar .item.button): Deleted.
+(.toolbar.icon-and-label-vertical .item.button): Deleted.
+(.toolbar.icon-and-label-horizontal .item.button): Deleted.
+(.toolbar .item.button  .glyph): Deleted.
+(.toolbar.small-size .item.button  .glyph): Deleted.
+* UserInterface/Views/DashboardContainerView.css:
+(.toolbar .dashboard-container): Deleted.
+(.toolbar.collapsed .dashboard-container): Deleted.
+(.toolbar.small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container): Deleted.
+(.toolbar .dashboard.slide-out-down): Deleted.
+(.toolbar .dashboard.slide-in-up): Deleted.
+* UserInterface/Views/Toolbar.css:
+(.toolbar .search-bar  input[type=search]):
+(.toolbar .search-bar  input[type=search]::-webkit-textfield-decoration-container):
+(body:not(.unknown-mac) .toolbar .dashboard-container):
+(body:not(.unknown-mac) .toolbar .search-bar  input[type=search]):
+(body:not(.unknown-mac) .toolbar .search-bar  input[type=search]:focus):
+(body:not(.unknown-mac) .toolbar .item.button:active):
+(body.window-inactive:not(.unknown-mac) .toolbar .dashboard-container):
+(body.unknown-mac .toolbar .dashboard-container):
+(body.unknown-mac .toolbar .search-bar  input[type=search]):
+(body.unknown-mac .toolbar .search-bar  input[type=search]:focus):
+(@media (-webkit-min-device-pixel-ratio: 2)):
+(body.unknown-mac .toolbar .item.button:active):
+(body.unknown-mac.window-inactive .toolbar .dashboard-container):
+
 2015-05-28  Devin Rousso  drou...@apple.com
 
 Web Inspector: Jump from a computed style to the rule it came from


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.css (184977 => 184978)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.css	2015-05-29 04:47:39 UTC (rev 184977)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.css	2015-05-29 04:50:59 UTC (rev 184978)
@@ -27,30 +27,10 @@
 align-items: center;
 justify-content: center;
 
-border-radius: 4px;
-background-color: rgb(252, 252, 252);
-
-border: 1px solid transparent;
-border-top-color: white;
-
-

[webkit-changes] [184873] trunk/Source/WebInspectorUI

2015-05-26 Thread nvasilyev

Title: [184873] trunk/Source/WebInspectorUI








Revision 184873
Author nvasil...@apple.com
Date 2015-05-26 14:20:50 -0700 (Tue, 26 May 2015)


Log Message
Web Inspector: The bottom part debugger is clipped in the tab’s title
https://bugs.webkit.org/show_bug.cgi?id=145381

Reviewed by Timothy Hatcher.

* UserInterface/Views/TabBar.css:
(.tab-bar  .item):
Set line-height to fit debugger. Setting line-height to 16px, which is the
size of the tabs icons, moves the text one pixel up, so set it to 15px.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (184872 => 184873)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-05-26 21:18:37 UTC (rev 184872)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-05-26 21:20:50 UTC (rev 184873)
@@ -1,3 +1,15 @@
+2015-05-26  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: The bottom part debugger is clipped in the tab’s title
+https://bugs.webkit.org/show_bug.cgi?id=145381
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/TabBar.css:
+(.tab-bar  .item):
+Set line-height to fit debugger. Setting line-height to 16px, which is the
+size of the tabs icons, moves the text one pixel up, so set it to 15px.
+
 2015-05-26  Dan Bernstein  m...@apple.com
 
 rdar://problem/21104551 Update build settings


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css (184872 => 184873)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css	2015-05-26 21:18:37 UTC (rev 184872)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css	2015-05-26 21:20:50 UTC (rev 184873)
@@ -87,6 +87,7 @@
 border-top: 1px solid rgb(168, 168, 168);
 
 height: 100%;
+line-height: 15px;
 outline: none;
 
 /* FIXME: These cause noticeable transitions when focusing the window. Fix that with _javascript_? */






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [184877] trunk/Source/WebInspectorUI

2015-05-26 Thread nvasilyev

Title: [184877] trunk/Source/WebInspectorUI








Revision 184877
Author nvasil...@apple.com
Date 2015-05-26 14:48:41 -0700 (Tue, 26 May 2015)


Log Message
Web Inspector: focus outline of a search field should have a radius
https://bugs.webkit.org/show_bug.cgi?id=145383

Add a focus outline animation to roughly mimic the default focus outline of OS X.

Reviewed by Timothy Hatcher.

* UserInterface/Views/Toolbar.css:
(.toolbar .search-bar  input[type=search]):
-webkit-focus-ring-color doesn't follow element's curvature (e.g. border-radius)
and it cannot be animated. Replace it with box-shadow.

(.toolbar .search-bar  input[type=search]:focus):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (184876 => 184877)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-05-26 21:38:57 UTC (rev 184876)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-05-26 21:48:41 UTC (rev 184877)
@@ -1,5 +1,21 @@
 2015-05-26  Nikita Vasilyev  nvasil...@apple.com
 
+Web Inspector: focus outline of a search field should have a radius
+https://bugs.webkit.org/show_bug.cgi?id=145383
+
+Add a focus outline animation to roughly mimic the default focus outline of OS X.
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/Toolbar.css:
+(.toolbar .search-bar  input[type=search]):
+-webkit-focus-ring-color doesn't follow element's curvature (e.g. border-radius)
+and it cannot be animated. Replace it with box-shadow.
+
+(.toolbar .search-bar  input[type=search]:focus):
+
+2015-05-26  Nikita Vasilyev  nvasil...@apple.com
+
 Web Inspector: The bottom part debugger is clipped in the tab’s title
 https://bugs.webkit.org/show_bug.cgi?id=145381
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css (184876 => 184877)

--- trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css	2015-05-26 21:38:57 UTC (rev 184876)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css	2015-05-26 21:48:41 UTC (rev 184877)
@@ -114,16 +114,16 @@
 border: 1px solid transparent;
 border-top-color: white;
 
-box-shadow: rgba(0, 0, 0, 0.15) 0 1px 0;
-
 background-clip: initial;
 
 margin: 4px;
+
+box-shadow: rgba(0, 0, 0, 0.15) 0 1px 0, 0 0 0 7px hsla(211, 96%, 48%, 0);
+transition: box-shadow .25s cubic-bezier(0.165, 0.840, 0.440, 1) /* easeOutQuart */;
 }
 
 .toolbar .search-bar  input[type=search]:focus {
-outline: auto 5px -webkit-focus-ring-color;
-outline-offset: -2px
+box-shadow: rgba(0, 0, 0, 0.15) 0 1px 0, 0 0 0 3px hsla(211, 96%, 48%, 0.4);
 }
 
 .toolbar .search-bar  input[type=search]::-webkit-textfield-decoration-container {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [184748] trunk/Source/WebInspectorUI

2015-05-21 Thread nvasilyev

Title: [184748] trunk/Source/WebInspectorUI








Revision 184748
Author nvasil...@apple.com
Date 2015-05-21 19:54:44 -0700 (Thu, 21 May 2015)


Log Message
Web Inspector: Dashboard debugger information can be clipped
https://bugs.webkit.org/show_bug.cgi?id=144209

Reviewed by Timothy Hatcher.

* UserInterface/Views/DashboardContainerView.css:
(.toolbar .dashboard-container):
Make dashboard flexible by using vw (viewport width units).

* UserInterface/Views/DefaultDashboardView.css:
(.toolbar .dashboard.default):
Center default dashboard icons in the middle, don't spread them along the dashboard.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css
trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (184747 => 184748)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-05-22 02:39:25 UTC (rev 184747)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-05-22 02:54:44 UTC (rev 184748)
@@ -1,3 +1,18 @@
+2015-05-21  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: Dashboard debugger information can be clipped
+https://bugs.webkit.org/show_bug.cgi?id=144209
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/DashboardContainerView.css:
+(.toolbar .dashboard-container):
+Make dashboard flexible by using vw (viewport width units).
+
+* UserInterface/Views/DefaultDashboardView.css:
+(.toolbar .dashboard.default):
+Center default dashboard icons in the middle, don't spread them along the dashboard.
+
 2015-05-21  Joseph Pecoraro  pecor...@apple.com
 
 Web Inspector: Improve the UI of the type profiler popover


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css (184747 => 184748)

--- trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css	2015-05-22 02:39:25 UTC (rev 184747)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css	2015-05-22 02:54:44 UTC (rev 184748)
@@ -26,7 +26,7 @@
 .toolbar .dashboard-container {
 position: relative;
 
-width: 225px;
+width: 36vw;
 
 border-radius: 4px;
 background-color: rgb(252, 252, 252);


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.css (184747 => 184748)

--- trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.css	2015-05-22 02:39:25 UTC (rev 184747)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.css	2015-05-22 02:54:44 UTC (rev 184748)
@@ -34,7 +34,7 @@
 .toolbar .dashboard.default {
 display: flex;
 flex-flow: row nowrap;
-justify-content: space-between;
+justify-content: center;
 }
 
 .toolbar .dashboard.default  .item {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [184553] trunk/Source/WebInspectorUI

2015-05-19 Thread nvasilyev

Title: [184553] trunk/Source/WebInspectorUI








Revision 184553
Author nvasil...@apple.com
Date 2015-05-19 00:12:40 -0700 (Tue, 19 May 2015)


Log Message
Web Inspector: Convert stackTrace from raw payload data to an array of CallFrames
https://bugs.webkit.org/show_bug.cgi?id=144982

Reviewed by Joseph Pecoraro.

* UserInterface/Controllers/LogManager.js:
* UserInterface/Main.html:
* UserInterface/Models/CallFrame.js:
(WebInspector.CallFrame.fromPayload):
Consider an empty string url as a native code as it was in
WebInspector.ConsoleMessageView.prototype._firstNonNativeCallFrame

* UserInterface/Models/ConsoleMessage.js:
(WebInspector.ConsoleMessage):
Convert _stackTrace from an array of payload objects to WebInspector.StackTrace model.

* UserInterface/Models/StackTrace.js: Added.
(WebInspector.StackTrace):
(WebInspector.StackTrace.prototype.get callFrames):
(WebInspector.StackTrace.prototype.get firstNonNativeCallFrame): Added.
(WebInspector.StackTrace.fromPayload):
* UserInterface/Test.html:
* UserInterface/Views/CallFrameView.js:
(WebInspector.CallFrameView):
Don't show a URL when sourceCodeLocation is missing, fix webkit.org/b/145071.

* UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView):
(WebInspector.ConsoleMessageView.prototype.toClipboardString):
(WebInspector.ConsoleMessageView.prototype._appendLocationLink):
(WebInspector.ConsoleMessageView.prototype._appendStackTrace):
(WebInspector.ConsoleMessageView.prototype._shouldShowStackTrace):
(WebInspector.ConsoleMessageView.prototype._linkifyCallFrame):
(WebInspector.ConsoleMessageView.prototype._firstNonNativeCallFrame): Deleted.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/LogManager.js
trunk/Source/WebInspectorUI/UserInterface/Main.html
trunk/Source/WebInspectorUI/UserInterface/Models/CallFrame.js
trunk/Source/WebInspectorUI/UserInterface/Models/ConsoleMessage.js
trunk/Source/WebInspectorUI/UserInterface/Test.html
trunk/Source/WebInspectorUI/UserInterface/Views/CallFrameView.js
trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js


Added Paths

trunk/Source/WebInspectorUI/UserInterface/Models/StackTrace.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (184552 => 184553)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-05-19 06:49:56 UTC (rev 184552)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-05-19 07:12:40 UTC (rev 184553)
@@ -1,3 +1,40 @@
+2015-05-19  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: Convert stackTrace from raw payload data to an array of CallFrames
+https://bugs.webkit.org/show_bug.cgi?id=144982
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Controllers/LogManager.js:
+* UserInterface/Main.html:
+* UserInterface/Models/CallFrame.js:
+(WebInspector.CallFrame.fromPayload):
+Consider an empty string url as a native code as it was in 
+WebInspector.ConsoleMessageView.prototype._firstNonNativeCallFrame
+
+* UserInterface/Models/ConsoleMessage.js:
+(WebInspector.ConsoleMessage):
+Convert _stackTrace from an array of payload objects to WebInspector.StackTrace model.
+
+* UserInterface/Models/StackTrace.js: Added.
+(WebInspector.StackTrace):
+(WebInspector.StackTrace.prototype.get callFrames):
+(WebInspector.StackTrace.prototype.get firstNonNativeCallFrame): Added.
+(WebInspector.StackTrace.fromPayload):
+* UserInterface/Test.html:
+* UserInterface/Views/CallFrameView.js:
+(WebInspector.CallFrameView):
+Don't show a URL when sourceCodeLocation is missing, fix webkit.org/b/145071.
+
+* UserInterface/Views/ConsoleMessageView.js:
+(WebInspector.ConsoleMessageView):
+(WebInspector.ConsoleMessageView.prototype.toClipboardString):
+(WebInspector.ConsoleMessageView.prototype._appendLocationLink):
+(WebInspector.ConsoleMessageView.prototype._appendStackTrace):
+(WebInspector.ConsoleMessageView.prototype._shouldShowStackTrace):
+(WebInspector.ConsoleMessageView.prototype._linkifyCallFrame):
+(WebInspector.ConsoleMessageView.prototype._firstNonNativeCallFrame): Deleted.
+
 2015-05-18  Joseph Pecoraro  pecor...@apple.com
 
 Web Inspector: Improve Reliability of Closing and Reopening Elements Tab


Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/LogManager.js (184552 => 184553)

--- trunk/Source/WebInspectorUI/UserInterface/Controllers/LogManager.js	2015-05-19 06:49:56 UTC (rev 184552)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/LogManager.js	2015-05-19 07:12:40 UTC (rev 184553)
@@ -38,7 +38,6 @@
 {
 // Called from WebInspector.ConsoleObserver.
 
-// FIXME: stackTrace should be converted to a model object.
 // FIXME: Get a request from request ID.
 
 if (parameters)


Modified:

[webkit-changes] [184045] trunk/Source/WebInspectorUI

2015-05-10 Thread nvasilyev

Title: [184045] trunk/Source/WebInspectorUI








Revision 184045
Author nvasil...@apple.com
Date 2015-05-10 05:23:07 -0700 (Sun, 10 May 2015)


Log Message
Web Inspector: In the console, show function name next to the source link
https://bugs.webkit.org/show_bug.cgi?id=144372

Introduce CallFrameView to display counsole message source links. It looks like this:

[f] functionName - filename.js:42

Reviewed by Timothy Hatcher.

* UserInterface/Base/Main.js:
(WebInspector.createSourceCodeLocationLink):
(WebInspector.linkifyLocation):
(.showSourceCodeLocation):
(WebInspector.linkifyElement):
Abstract this out as it's used in WebInspector.CallFrameView and WebInspector.createSourceCodeLocationLink.

(WebInspector.sourceCodeForURL):
Move this code from Timeline to Main.js as it's used by Console too.

(WebInspector.linkifyURLAsNode):
Remove tooltipText argument as it is never used.

* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._callFramesFromPayload):
* UserInterface/Main.html:
* UserInterface/Models/CallFrame.js:
(WebInspector.CallFrame.fromPayload):
Abstract this out as it's used in WebInspector.TimelineManager.prototype._callFramesFromPayload and
WebInspector.ConsoleMessageView._appendLocationLink.

(WebInspector.CallFrame):
* UserInterface/Views/CallFrameTreeElement.js:
(WebInspector.CallFrameTreeElement):
Move it to WebInspector.CallFrameView.iconForCallFrame.

* UserInterface/Views/CallFrameView.css: Added.
(.call-frame):
(.call-frame .icon):
(.call-frame .titles):
(.call-frame .title):
(.call-frame .source-link):
(.call-frame .title + .subtitle  .source-link):
(.call-frame .subtitle .source-link):
(.call-frame:focus .subtitle .source-link):
(.call-frame .subtitle:empty):
(.call-frame .subtitle):
(.call-frame .colon):
(.call-frame .title + .subtitle::before):
* UserInterface/Views/CallFrameView.js: Added.
(WebInspector.CallFrameView):
(WebInspector.CallFrameView.iconClassNameForCallFrame):
* UserInterface/Views/ConsoleMessageView.css:
(.console-message .console-message-location):
(.console-message .call-frame):
(.console-message .go-to-link):
(.console-message .go-to-link:focus):
(.console-message .console-message-url::before):
(.console-saved-variable): Deleted.
* UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._appendLocationLink):
* UserInterface/Views/DebuggerDashboardView.js:
* UserInterface/Views/Main.css:
(.hidden): Deleted.
* UserInterface/Views/ProfileNodeTreeElement.js:
(WebInspector.ProfileNodeTreeElement):
* UserInterface/Views/TimelineDataGridNode.js:
(WebInspector.TimelineDataGridNode.prototype.createCellContent):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
trunk/Source/WebInspectorUI/UserInterface/Main.html
trunk/Source/WebInspectorUI/UserInterface/Models/CallFrame.js
trunk/Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.js
trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css
trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js
trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.js
trunk/Source/WebInspectorUI/UserInterface/Views/Main.css
trunk/Source/WebInspectorUI/UserInterface/Views/ProfileNodeTreeElement.js
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js


Added Paths

trunk/Source/WebInspectorUI/UserInterface/Views/CallFrameView.css
trunk/Source/WebInspectorUI/UserInterface/Views/CallFrameView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (184044 => 184045)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-05-10 06:46:33 UTC (rev 184044)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-05-10 12:23:07 UTC (rev 184045)
@@ -1,3 +1,73 @@
+2015-05-10  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: In the console, show function name next to the source link
+https://bugs.webkit.org/show_bug.cgi?id=144372
+
+Introduce CallFrameView to display counsole message source links. It looks like this:
+
+[f] functionName - filename.js:42
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Base/Main.js:
+(WebInspector.createSourceCodeLocationLink):
+(WebInspector.linkifyLocation):
+(.showSourceCodeLocation):
+(WebInspector.linkifyElement):
+Abstract this out as it's used in WebInspector.CallFrameView and WebInspector.createSourceCodeLocationLink.
+
+(WebInspector.sourceCodeForURL):
+Move this code from Timeline to Main.js as it's used by Console too.
+
+(WebInspector.linkifyURLAsNode):
+Remove tooltipText argument as it is never used.
+
+* UserInterface/Controllers/TimelineManager.js:
+(WebInspector.TimelineManager.prototype._callFramesFromPayload):
+* UserInterface/Main.html:
+* UserInterface/Models/CallFrame.js:
+

[webkit-changes] [183862] trunk/LayoutTests

2015-05-06 Thread nvasilyev

Title: [183862] trunk/LayoutTests








Revision 183862
Author nvasil...@apple.com
Date 2015-05-06 00:02:36 -0700 (Wed, 06 May 2015)


Log Message
LayoutTests/fast/forms/button-line-height.html is broken on non-Mac/non-iOS ports
https://bugs.webkit.org/show_bug.cgi?id=144673

* TestExpectations: Skip broken test.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (183861 => 183862)

--- trunk/LayoutTests/ChangeLog	2015-05-06 06:55:16 UTC (rev 183861)
+++ trunk/LayoutTests/ChangeLog	2015-05-06 07:02:36 UTC (rev 183862)
@@ -1,3 +1,10 @@
+2015-05-05  Nikita Vasilyev  nvasil...@apple.com
+
+LayoutTests/fast/forms/button-line-height.html is broken on non-Mac/non-iOS ports
+https://bugs.webkit.org/show_bug.cgi?id=144673
+
+* TestExpectations: Skip broken test.
+
 2015-05-05  Manuel Rego Casasnovas  r...@igalia.com
 
 [CSS Grid Layout] grid-template-areas should accept none value


Modified: trunk/LayoutTests/TestExpectations (183861 => 183862)

--- trunk/LayoutTests/TestExpectations	2015-05-06 06:55:16 UTC (rev 183861)
+++ trunk/LayoutTests/TestExpectations	2015-05-06 07:02:36 UTC (rev 183862)
@@ -20,6 +20,8 @@
 
 webkit.org/b/119094 fast/forms/color/input-color-onchange-event.html [ Crash Pass ]
 
+webkit.org/b/144673 fast/forms/button-line-height.html [ Skip ]
+
 # This test will run slowly in debug mode, but is plenty fast in release.
 [ Debug ] js/slow-stress/emscripten-memops.html [ Skip ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [183668] trunk/Source/WebInspectorUI

2015-04-30 Thread nvasilyev

Title: [183668] trunk/Source/WebInspectorUI








Revision 183668
Author nvasil...@apple.com
Date 2015-04-30 22:57:26 -0700 (Thu, 30 Apr 2015)


Log Message
REGRESSION: Web Inspector: Console message repeat count overlapped by icon
https://bugs.webkit.org/show_bug.cgi?id=144344

Reviewed by Timothy Hatcher.

* UserInterface/Views/ConsoleMessageView.css:
(.console-message .repeat-count):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (183667 => 183668)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-05-01 05:01:17 UTC (rev 183667)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-05-01 05:57:26 UTC (rev 183668)
@@ -1,3 +1,13 @@
+2015-04-30  Nikita Vasilyev  nvasil...@apple.com
+
+REGRESSION: Web Inspector: Console message repeat count overlapped by icon
+https://bugs.webkit.org/show_bug.cgi?id=144344
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/ConsoleMessageView.css:
+(.console-message .repeat-count):
+
 2015-04-30  Jon Davis  j...@apple.com
 
 Web Inspector: console should show an icon for console.info() messages


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css (183667 => 183668)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css	2015-05-01 05:01:17 UTC (rev 183667)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css	2015-05-01 05:57:26 UTC (rev 183668)
@@ -34,7 +34,7 @@
 float: left;
 
 padding: 1px 4px;
-margin: 0 2px 0 -18px;
+margin: 0 4px 0 0;
 
 height: 15px;
 background-color: rgb(128, 151, 189);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [183062] trunk/Source/WebInspectorUI

2015-04-21 Thread nvasilyev

Title: [183062] trunk/Source/WebInspectorUI








Revision 183062
Author nvasil...@apple.com
Date 2015-04-21 06:01:18 -0700 (Tue, 21 Apr 2015)


Log Message
Web Inspector: Make formatted nodes more consistent with formatted objects
https://bugs.webkit.org/show_bug.cgi?id=142159

Reviewed by Timothy Hatcher.

* UserInterface/Views/DOMTreeOutline.css:
(.dom-tree-outline ol):
Keep indentation exactly two spaces of Menlo.

(.dom-tree-outline li):
(.dom-tree-outline li.parent):
(.dom-tree-outline li .html-tag.close):
(.dom-tree-outline li.parent::before):
(.dom-tree-outline:focus li.parent.selected::before):
(.dom-tree-outline li.parent.expanded::before):
(.dom-tree-outline:focus li.parent.expanded.selected::before):
* UserInterface/Views/FormattedValue.css:
(.formatted-node  .dom-tree-outline ol):
Keep indentation exactly two spaces of Menlo.

* UserInterface/Views/ObjectTreePropertyTreeElement.css:
(.object-tree-property  .disclosure-button):
Disclosure triangle is 13 by 13 pixels. Having it in the middle of 16 by 16
pixels block makes it look bloory on non-retina screen, because:
(16 - 13) / 2 = 1.5px. Replacing 16 with 15 fixes the problem.

* UserInterface/Views/ObjectTreeView.css:
(.object-tree:not(.lossless-preview)  :matches(.title, .object-preview)):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css
trunk/Source/WebInspectorUI/UserInterface/Views/FormattedValue.css
trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css
trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (183061 => 183062)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-04-21 10:11:06 UTC (rev 183061)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-04-21 13:01:18 UTC (rev 183062)
@@ -1,3 +1,34 @@
+2015-04-21  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: Make formatted nodes more consistent with formatted objects
+https://bugs.webkit.org/show_bug.cgi?id=142159
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/DOMTreeOutline.css:
+(.dom-tree-outline ol):
+Keep indentation exactly two spaces of Menlo.
+
+(.dom-tree-outline li):
+(.dom-tree-outline li.parent):
+(.dom-tree-outline li .html-tag.close):
+(.dom-tree-outline li.parent::before):
+(.dom-tree-outline:focus li.parent.selected::before):
+(.dom-tree-outline li.parent.expanded::before):
+(.dom-tree-outline:focus li.parent.expanded.selected::before):
+* UserInterface/Views/FormattedValue.css:
+(.formatted-node  .dom-tree-outline ol):
+Keep indentation exactly two spaces of Menlo.
+
+* UserInterface/Views/ObjectTreePropertyTreeElement.css:
+(.object-tree-property  .disclosure-button):
+Disclosure triangle is 13 by 13 pixels. Having it in the middle of 16 by 16
+pixels block makes it look bloory on non-retina screen, because:
+(16 - 13) / 2 = 1.5px. Replacing 16 with 15 fixes the problem.
+
+* UserInterface/Views/ObjectTreeView.css:
+(.object-tree:not(.lossless-preview)  :matches(.title, .object-preview)):
+
 2015-04-20  Joseph Pecoraro  pecor...@apple.com
 
 Web Inspector: Unify PrettyPrinting Tool and UserInterface resources


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css (183061 => 183062)

--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css	2015-04-21 10:11:06 UTC (rev 183061)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css	2015-04-21 13:01:18 UTC (rev 183062)
@@ -86,7 +86,7 @@
 
 .dom-tree-outline ol {
 list-style-type: none;
-padding-left: 14px;
+padding-left: 1.2em;
 margin: 0;
 }
 
@@ -99,7 +99,7 @@
 }
 
 .dom-tree-outline li {
-padding: 0 0 0 12px;
+padding: 0 0 0 17px;
 word-wrap: break-word;
 }
 
@@ -116,11 +116,11 @@
 }
 
 .dom-tree-outline li.parent {
-margin-left: -10px;
+margin-left: -15px;
 }
 
 .dom-tree-outline li .html-tag.close {
-margin-left: -14px;
+margin-left: -13px;
 }
 
 .dom-tree-outline li.parent::before {
@@ -128,27 +128,27 @@
 
 content: ;
 
-background-image: -webkit-canvas(disclosure-triangle-tiny-closed-normal);
-background-size: 8px 8px;
+background-image: -webkit-canvas(navigation-sidebar-panel-disclosure-triangle-closed-normal);
+background-size: 13px 13px;
 background-repeat: no-repeat;
 
-width: 8px;
-height: 8px;
+width: 13px;
+height: 13px;
 
-margin-top: 2px;
+margin-left: 0;
 padding-right: 2px;
 }
 
 .dom-tree-outline:focus li.parent.selected::before {
-background-image: -webkit-canvas(disclosure-triangle-tiny-closed-selected);
+background-image: -webkit-canvas(navigation-sidebar-panel-disclosure-triangle-closed-selected);
 }
 
 .dom-tree-outline li.parent.expanded::before {
-background-image:

[webkit-changes] [182989] trunk/Source/WebInspectorUI

2015-04-18 Thread nvasilyev

Title: [182989] trunk/Source/WebInspectorUI








Revision 182989
Author nvasil...@apple.com
Date 2015-04-18 21:19:54 -0700 (Sat, 18 Apr 2015)


Log Message
Web Inspector: Make prototype pill’s background semi-transparent
https://bugs.webkit.org/show_bug.cgi?id=143928

Reviewed by Timothy Hatcher.

* UserInterface/Views/ObjectTreePropertyTreeElement.css:
(.object-tree-property.prototype-property):

(.object-tree-property.prototype-property:hover, .object-tree-property.prototype-property:focus):
Slightly highlight the prototype pill when hovering over.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (182988 => 182989)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-04-19 03:29:25 UTC (rev 182988)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-04-19 04:19:54 UTC (rev 182989)
@@ -1,3 +1,16 @@
+2015-04-18  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: Make prototype pill’s background semi-transparent
+https://bugs.webkit.org/show_bug.cgi?id=143928
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/ObjectTreePropertyTreeElement.css:
+(.object-tree-property.prototype-property):
+
+(.object-tree-property.prototype-property:hover, .object-tree-property.prototype-property:focus):
+Slightly highlight the prototype pill when hovering over.
+
 2015-04-17  Jono Wells  jonowe...@apple.com
 
 Web Inspector: All sans-serif font family rules should be set the same way.


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css (182988 => 182989)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css	2015-04-19 03:29:25 UTC (rev 182988)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css	2015-04-19 04:19:54 UTC (rev 182989)
@@ -133,14 +133,18 @@
 .object-tree-property.prototype-property {
 display: inline-block;
 
-border: 1px solid rgb(222, 222, 222);
-background-color: rgb(242, 242, 242);
+border: 1px solid hsla(0, 0%, 0%, 0.06);
+background-color: hsla(0, 0%, 0%, 0.03);
 border-radius: 3px;
 
 padding: 0 10px 1px 0;
 margin: 3px 0 2px 0;
 }
 
+.object-tree-property.prototype-property:hover, .object-tree-property.prototype-property:focus {
+border-color: hsla(0, 0%, 0%, 0.1);
+}
+
 .object-tree-property.prototype-property  .icon {
 display: none;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182990] trunk/Source/WebInspectorUI

2015-04-18 Thread nvasilyev

Title: [182990] trunk/Source/WebInspectorUI








Revision 182990
Author nvasil...@apple.com
Date 2015-04-18 21:20:46 -0700 (Sat, 18 Apr 2015)


Log Message
Web Inspector: Pass multiple arguments to classList.add and classList.remove
https://bugs.webkit.org/show_bug.cgi?id=143914

classList.add and classList.remove can accept multiple arguments, use that.

Reviewed by Timothy Hatcher.

* UserInterface/Base/Main.js:
(WebInspector.updateDockedState):
* UserInterface/Views/DOMTreeDataGrid.js:
(WebInspector.DOMTreeDataGrid):
* UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline):
* UserInterface/Views/DataGrid.js:
(WebInspector.DataGridNode.prototype.set hasChildren):
* UserInterface/Views/DatabaseContentView.js:
(WebInspector.DatabaseContentView):
* UserInterface/Views/DetailsSection.js:
(WebInspector.DetailsSection):
* UserInterface/Views/DetailsSectionPropertiesRow.js:
(WebInspector.DetailsSectionPropertiesRow):
* UserInterface/Views/GeneralTreeElement.js:
(WebInspector.GeneralTreeElement.prototype.set classNames):
* UserInterface/Views/NavigationItem.js:
(WebInspector.NavigationItem):
* UserInterface/Views/ResourceContentView.js:
(WebInspector.ResourceContentView):
* UserInterface/Views/ResourceTimelineDataGridNode.js:
(WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):
* UserInterface/Views/Sidebar.js:
(WebInspector.Sidebar):
* UserInterface/Views/SidebarPanel.js:
(WebInspector.SidebarPanel):
* UserInterface/Views/SourceCodeTextEditor.js:
* UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor):
* UserInterface/Views/TimelineRuler.js:

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js
trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js
trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.js
trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSectionPropertiesRow.js
trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js
trunk/Source/WebInspectorUI/UserInterface/Views/NavigationItem.js
trunk/Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js
trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js
trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (182989 => 182990)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-04-19 04:20:46 UTC (rev 182990)
@@ -1,5 +1,45 @@
 2015-04-18  Nikita Vasilyev  nvasil...@apple.com
 
+Web Inspector: Pass multiple arguments to classList.add and classList.remove
+https://bugs.webkit.org/show_bug.cgi?id=143914
+
+classList.add and classList.remove can accept multiple arguments, use that.
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Base/Main.js:
+(WebInspector.updateDockedState):
+* UserInterface/Views/DOMTreeDataGrid.js:
+(WebInspector.DOMTreeDataGrid):
+* UserInterface/Views/DOMTreeOutline.js:
+(WebInspector.DOMTreeOutline):
+* UserInterface/Views/DataGrid.js:
+(WebInspector.DataGridNode.prototype.set hasChildren):
+* UserInterface/Views/DatabaseContentView.js:
+(WebInspector.DatabaseContentView):
+* UserInterface/Views/DetailsSection.js:
+(WebInspector.DetailsSection):
+* UserInterface/Views/DetailsSectionPropertiesRow.js:
+(WebInspector.DetailsSectionPropertiesRow):
+* UserInterface/Views/GeneralTreeElement.js:
+(WebInspector.GeneralTreeElement.prototype.set classNames):
+* UserInterface/Views/NavigationItem.js:
+(WebInspector.NavigationItem):
+* UserInterface/Views/ResourceContentView.js:
+(WebInspector.ResourceContentView):
+* UserInterface/Views/ResourceTimelineDataGridNode.js:
+(WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):
+* UserInterface/Views/Sidebar.js:
+(WebInspector.Sidebar):
+* UserInterface/Views/SidebarPanel.js:
+(WebInspector.SidebarPanel):
+* UserInterface/Views/SourceCodeTextEditor.js:
+* UserInterface/Views/TextEditor.js:
+(WebInspector.TextEditor):
+* UserInterface/Views/TimelineRuler.js:
+
+2015-04-18  Nikita Vasilyev  nvasil...@apple.com
+
 Web Inspector: Make prototype pill’s background semi-transparent
 https://bugs.webkit.org/show_bug.cgi?id=143928
 


Modified:

[webkit-changes] [182796] trunk/Source/WebInspectorUI

2015-04-14 Thread nvasilyev

Title: [182796] trunk/Source/WebInspectorUI








Revision 182796
Author nvasil...@apple.com
Date 2015-04-14 08:15:35 -0700 (Tue, 14 Apr 2015)


Log Message
Web Inspector: Align array's indices and set's bullet points under the property icon
https://bugs.webkit.org/show_bug.cgi?id=143698

Reviewed by Timothy Hatcher.

* UserInterface/Views/ObjectTreeMapEntryTreeElement.css:
(.object-tree-array-index.object-tree-map-entry  .titles  .title  .index-name):
* UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
(.object-tree-array-index .index-name):
Right align array's and set's indices.

(.object-tree-map-entry):
Overwrite left property from .object-tree-array-index.

(.object-tree-property + ol .object-tree-map-entry):
Overwrite left property from .object-tree-property + ol .object-tree-array-index.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css
trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (182795 => 182796)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-04-14 13:59:36 UTC (rev 182795)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-04-14 15:15:35 UTC (rev 182796)
@@ -1,3 +1,22 @@
+2015-04-14  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: Align array's indices and set's bullet points under the property icon
+https://bugs.webkit.org/show_bug.cgi?id=143698
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/ObjectTreeMapEntryTreeElement.css:
+(.object-tree-array-index.object-tree-map-entry  .titles  .title  .index-name):
+* UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
+(.object-tree-array-index .index-name):
+Right align array's and set's indices.
+
+(.object-tree-map-entry):
+Overwrite left property from .object-tree-array-index.
+
+(.object-tree-property + ol .object-tree-map-entry):
+Overwrite left property from .object-tree-property + ol .object-tree-array-index.
+
 2015-04-13  Joseph Pecoraro  pecor...@apple.com
 
 Web Inspector: Expanding window.navigator.mimeTypes in ObjectTree shows no native properties


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css (182795 => 182796)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css	2015-04-14 13:59:36 UTC (rev 182795)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css	2015-04-14 15:15:35 UTC (rev 182796)
@@ -45,9 +45,9 @@
 top: -1px;
 
 display: inline-block;
-width: 22px;
-margin-left: 13px;
-text-align: center;
+width: 30px;
+margin-right: 7px;
+text-align: right;
 }
 
 /* An array inside an array we should reduce the padding-start. */


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.css (182795 => 182796)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.css	2015-04-14 13:59:36 UTC (rev 182795)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.css	2015-04-14 15:15:35 UTC (rev 182796)
@@ -24,7 +24,7 @@
  */
 
 .object-tree-array-index.object-tree-map-entry  .titles  .title  .index-name {
-width: 37px;
+width: 40px;
 text-align: right;
 margin-right: 5px;
 }
@@ -36,4 +36,9 @@
 .object-tree-map-entry {
 padding-top: 2px;
 padding-bottom: 2px;
+left: -2px;
 }
+
+.object-tree-property + ol .object-tree-map-entry {
+left: -8px;
+}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182655] trunk/Source/WebInspectorUI

2015-04-11 Thread nvasilyev

Title: [182655] trunk/Source/WebInspectorUI








Revision 182655
Author nvasil...@apple.com
Date 2015-04-11 07:40:22 -0700 (Sat, 11 Apr 2015)


Log Message
Web Inspector: Use semi-transparent map item dividers
https://bugs.webkit.org/show_bug.cgi?id=143630

Reviewed by Timothy Hatcher.

* UserInterface/Views/ObjectTreeMapEntryTreeElement.css:
(.object-tree-map-entry.key:not(:first-child)):
(.object-tree-map-entry.key): Deleted.
(.object-tree-map-entry.key:first-of-type): Deleted.
Use one selector instead of two.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (182654 => 182655)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-04-11 14:37:23 UTC (rev 182654)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-04-11 14:40:22 UTC (rev 182655)
@@ -1,5 +1,18 @@
 2015-04-11  Nikita Vasilyev  nvasil...@apple.com
 
+Web Inspector: Use semi-transparent map item dividers
+https://bugs.webkit.org/show_bug.cgi?id=143630
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/ObjectTreeMapEntryTreeElement.css:
+(.object-tree-map-entry.key:not(:first-child)):
+(.object-tree-map-entry.key): Deleted.
+(.object-tree-map-entry.key:first-of-type): Deleted.
+Use one selector instead of two.
+
+2015-04-11  Nikita Vasilyev  nvasil...@apple.com
+
 Web Inspector: Objects are vertically misaligned by 1px
 https://bugs.webkit.org/show_bug.cgi?id=143629
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.css (182654 => 182655)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.css	2015-04-11 14:37:23 UTC (rev 182654)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.css	2015-04-11 14:40:22 UTC (rev 182655)
@@ -29,14 +29,10 @@
 margin-right: 5px;
 }
 
-.object-tree-map-entry.key {
-border-top: 1px solid hsl(0, 0%, 96%);
+.object-tree-map-entry.key:not(:first-child) {
+border-top: 1px solid hsla(0, 0%, 0%, 0.05);
 }
 
-.object-tree-map-entry.key:first-of-type {
-border-top: none;
-}
-
 .object-tree-map-entry {
 padding-top: 2px;
 padding-bottom: 2px;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182654] trunk/Source/WebInspectorUI

2015-04-11 Thread nvasilyev

Title: [182654] trunk/Source/WebInspectorUI








Revision 182654
Author nvasil...@apple.com
Date 2015-04-11 07:37:23 -0700 (Sat, 11 Apr 2015)


Log Message
Web Inspector: Objects are vertically misaligned by 1px
https://bugs.webkit.org/show_bug.cgi?id=143629

Reviewed by Timothy Hatcher.

* UserInterface/Views/FormattedValue.css:
(.formatted-object, .formatted-node, .formatted-error, .formatted-map, .formatted-set, .formatted-weakmap):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/FormattedValue.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (182653 => 182654)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-04-11 10:02:09 UTC (rev 182653)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-04-11 14:37:23 UTC (rev 182654)
@@ -1,3 +1,13 @@
+2015-04-11  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: Objects are vertically misaligned by 1px
+https://bugs.webkit.org/show_bug.cgi?id=143629
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/FormattedValue.css:
+(.formatted-object, .formatted-node, .formatted-error, .formatted-map, .formatted-set, .formatted-weakmap):
+
 2015-04-10  Joseph Pecoraro  pecor...@apple.com
 
 Web Inspector: Fix Console Message Toggle


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FormattedValue.css (182653 => 182654)

--- trunk/Source/WebInspectorUI/UserInterface/Views/FormattedValue.css	2015-04-11 10:02:09 UTC (rev 182653)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FormattedValue.css	2015-04-11 14:37:23 UTC (rev 182654)
@@ -26,7 +26,6 @@
 .formatted-object, .formatted-node, .formatted-error, .formatted-map, .formatted-set, .formatted-weakmap {
 position: relative;
 display: inline-block;
-vertical-align: top;
 color: black;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182359] trunk/Source/WebInspectorUI

2015-04-05 Thread nvasilyev

Title: [182359] trunk/Source/WebInspectorUI








Revision 182359
Author nvasil...@apple.com
Date 2015-04-05 09:52:49 -0700 (Sun, 05 Apr 2015)


Log Message
Web Inspector: ObjectTree array index hints are clipped when shown in popover
https://bugs.webkit.org/show_bug.cgi?id=143309

Reviewed by Brian Burg.

* UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
(.object-tree-array-index .index-name):
Add left margin that equals the width of the expand/collapse icon.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (182358 => 182359)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-04-05 15:34:21 UTC (rev 182358)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-04-05 16:52:49 UTC (rev 182359)
@@ -1,3 +1,14 @@
+2015-04-05  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: ObjectTree array index hints are clipped when shown in popover
+https://bugs.webkit.org/show_bug.cgi?id=143309
+
+Reviewed by Brian Burg.
+
+* UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
+(.object-tree-array-index .index-name):
+Add left margin that equals the width of the expand/collapse icon.
+
 2015-03-31  Nikita Vasilyev  nvasil...@apple.com
 
 Web Inspector: console.error(object) has double disclosure triangles


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css (182358 => 182359)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css	2015-04-05 15:34:21 UTC (rev 182358)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css	2015-04-05 16:52:49 UTC (rev 182359)
@@ -46,6 +46,7 @@
 
 display: inline-block;
 width: 22px;
+margin-left: 13px;
 text-align: center;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182221] trunk/Source/WebInspectorUI

2015-04-01 Thread nvasilyev

Title: [182221] trunk/Source/WebInspectorUI








Revision 182221
Author nvasil...@apple.com
Date 2015-03-31 23:16:48 -0700 (Tue, 31 Mar 2015)


Log Message
Web Inspector: console.error(object) has double disclosure triangles
https://bugs.webkit.org/show_bug.cgi?id=142069

Use inline-block instead of float: left or position: absolute to
make layout more predictable and easier to understand.

Reviewed by Timothy Hatcher.

* UserInterface/Views/LogContentView.css:
(.outline-disclosure, .outline-disclosure ol):
(.outline-disclosure  li.parent):
(.outline-disclosure  li.parent::before):
(.outline-disclosure li.parent): Deleted.
(.outline-disclosure li.parent::before): Deleted.
* UserInterface/Views/ObjectTreePropertyTreeElement.css:
(.object-tree-property  .titles):
(.object-tree-property  .disclosure-button):
(.object-tree-property  .icon):
* UserInterface/Views/ObjectTreeView.css:
(.object-tree  :matches(.title, .object-preview)::before):
(.object-tree:not(.lossless-preview)  :matches(.title, .object-preview)):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css
trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css
trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (182220 => 182221)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-04-01 05:00:02 UTC (rev 182220)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-04-01 06:16:48 UTC (rev 182221)
@@ -1,3 +1,27 @@
+2015-03-31  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: console.error(object) has double disclosure triangles
+https://bugs.webkit.org/show_bug.cgi?id=142069
+
+Use inline-block instead of float: left or position: absolute to
+make layout more predictable and easier to understand.
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/LogContentView.css:
+(.outline-disclosure, .outline-disclosure ol):
+(.outline-disclosure  li.parent):
+(.outline-disclosure  li.parent::before):
+(.outline-disclosure li.parent): Deleted.
+(.outline-disclosure li.parent::before): Deleted.
+* UserInterface/Views/ObjectTreePropertyTreeElement.css:
+(.object-tree-property  .titles):
+(.object-tree-property  .disclosure-button):
+(.object-tree-property  .icon):
+* UserInterface/Views/ObjectTreeView.css:
+(.object-tree  :matches(.title, .object-preview)::before):
+(.object-tree:not(.lossless-preview)  :matches(.title, .object-preview)):
+
 2015-03-31  Jono Wells  jonowe...@apple.com
 
 Web Inspector: REGRESSION: Filtering no longer works


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css (182220 => 182221)

--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css	2015-04-01 05:00:02 UTC (rev 182220)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css	2015-04-01 06:16:48 UTC (rev 182221)
@@ -377,7 +377,7 @@
 
 .outline-disclosure, .outline-disclosure ol {
 list-style-type: none;
--webkit-padding-start: 12px;
+-webkit-padding-start: 0;
 margin: 0;
 }
 
@@ -393,7 +393,7 @@
 margin-bottom: 2px;
 }
 
-.outline-disclosure li.parent {
+.outline-disclosure  li.parent {
 margin-left: -12px
 }
 
@@ -401,7 +401,7 @@
 margin-left: -12px;
 }
 
-.outline-disclosure li.parent::before {
+.outline-disclosure  li.parent::before {
 float: left;
 
 content: ;
@@ -413,7 +413,7 @@
 width: 8px;
 height: 8px;
 
-margin-top: 4px;
+margin-top: 3px;
 padding-right: 2px;
 }
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css (182220 => 182221)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css	2015-04-01 05:00:02 UTC (rev 182220)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css	2015-04-01 06:16:48 UTC (rev 182221)
@@ -35,10 +35,13 @@
 text-overflow: ellipsis;
 overflow: hidden;
 white-space: nowrap;
+display: inline-block;
+vertical-align: top;
 }
 
 .object-tree-property  .disclosure-button {
-float: left;
+display: inline-block;
+vertical-align: top;
 
 width: 16px;
 height: 16px;
@@ -61,7 +64,8 @@
 }
 
 .object-tree-property  .icon {
-float: left;
+display: inline-block;
+vertical-align: top;
 position: relative;
 
 width: 16px;


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css (182220 => 182221)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css	2015-04-01 05:00:02 UTC (rev 182220)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css	2015-04-01 06:16:48 UTC (rev 182221)
@@ -32,10 +32,11 @@
 }
 
 .object-tree  :matches(.title, .object-preview)::before {
-position: absolute;
+display: inline-block;
 
-

[webkit-changes] [182053] trunk/Source/WebInspectorUI

2015-03-27 Thread nvasilyev

Title: [182053] trunk/Source/WebInspectorUI








Revision 182053
Author nvasil...@apple.com
Date 2015-03-26 23:48:10 -0700 (Thu, 26 Mar 2015)


Log Message
Web Inspector: clicking on console record while REPL is focused does not select a new record
https://bugs.webkit.org/show_bug.cgi?id=142171

Reviewed by Timothy Hatcher.

* UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype._mousedown):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (182052 => 182053)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-03-27 06:36:48 UTC (rev 182052)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-03-27 06:48:10 UTC (rev 182053)
@@ -1,3 +1,13 @@
+2015-03-26  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: clicking on console record while REPL is focused does not select a new record
+https://bugs.webkit.org/show_bug.cgi?id=142171
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/LogContentView.js:
+(WebInspector.LogContentView.prototype._mousedown):
+
 2015-03-26  Andres Gomez  ago...@igalia.com
 
 [GTK] Web Inspector: New Images for Console Types


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js (182052 => 182053)

--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js	2015-03-27 06:36:48 UTC (rev 182052)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js	2015-03-27 06:48:10 UTC (rev 182053)
@@ -374,11 +374,8 @@
 return;
 }
 
-if (!this._focused) {
+if (!this._focused)
 this.messagesElement.focus();
-if (this._selectedMessages.length)
-return;
-}
 
 this._mouseDownWrapper = event.target.enclosingNodeOrSelfWithClass(WebInspector.LogContentView.ItemWrapperStyleClassName);
 this._mouseDownShiftKey = event.shiftKey;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [181961] trunk/Source/WebInspectorUI

2015-03-25 Thread nvasilyev

Title: [181961] trunk/Source/WebInspectorUI








Revision 181961
Author nvasil...@apple.com
Date 2015-03-25 09:49:57 -0700 (Wed, 25 Mar 2015)


Log Message
Web Inspector: console.table with source code location look poor
https://bugs.webkit.org/show_bug.cgi?id=142068

Reviewed by Timothy Hatcher.

* UserInterface/Views/LegacyConsoleMessageImpl.js:
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsTable):
Remove dataGridContainer as it is an unnecessary span element.
* UserInterface/Views/LogContentView.css:
(.console-messages .data-grid):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/LegacyConsoleMessageImpl.js
trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (181960 => 181961)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-03-25 16:45:28 UTC (rev 181960)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-03-25 16:49:57 UTC (rev 181961)
@@ -1,3 +1,16 @@
+2015-03-25  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: console.table with source code location look poor
+https://bugs.webkit.org/show_bug.cgi?id=142068
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/LegacyConsoleMessageImpl.js:
+(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsTable):
+Remove dataGridContainer as it is an unnecessary span element.
+* UserInterface/Views/LogContentView.css:
+(.console-messages .data-grid):
+
 2015-03-24  Joseph Pecoraro  pecor...@apple.com
 
 Web Inspector: IndexedDB / Databases ContentViews should have refresh button


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LegacyConsoleMessageImpl.js (181960 => 181961)

--- trunk/Source/WebInspectorUI/UserInterface/Views/LegacyConsoleMessageImpl.js	2015-03-25 16:45:28 UTC (rev 181960)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LegacyConsoleMessageImpl.js	2015-03-25 16:49:57 UTC (rev 181961)
@@ -451,10 +451,9 @@
 return element;
 }
 
-var dataGridContainer = element.createChild(span);
 var dataGrid = WebInspector.DataGrid.createSortableDataGrid(columnNames, flatValues);
 dataGrid.element.classList.add(inline);
-dataGridContainer.appendChild(dataGrid.element);
+element.appendChild(dataGrid.element);
 
 return element;
 },


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css (181960 => 181961)

--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css	2015-03-25 16:45:28 UTC (rev 181960)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css	2015-03-25 16:49:57 UTC (rev 181961)
@@ -251,6 +251,10 @@
 color: rgb(15%, 15%, 15%);
 }
 
+.console-messages .data-grid {
+clear: both;
+}
+
 .console-message-url {
 float: right;
 margin-left: 4px;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [181819] trunk/Source/WebInspectorUI

2015-03-20 Thread nvasilyev

Title: [181819] trunk/Source/WebInspectorUI








Revision 181819
Author nvasil...@apple.com
Date 2015-03-20 16:38:03 -0700 (Fri, 20 Mar 2015)


Log Message
Web Inspector: Fast typing lags in the Styles sidebar or Console
https://bugs.webkit.org/show_bug.cgi?id=142919

Asynchronous autocomplete causes a race condition in CodeMirror,
which results in skipped characters in while typing. Completing immediately
fixes the issues.

Reviewed by Timothy Hatcher.

* UserInterface/Controllers/CodeMirrorCompletionController.js:
(WebInspector.CodeMirrorCompletionController.prototype.hideCompletions):
(WebInspector.CodeMirrorCompletionController.prototype._completeAtCurrentPosition):
(WebInspector.CodeMirrorCompletionController.prototype.):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (181818 => 181819)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-03-20 23:37:51 UTC (rev 181818)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-03-20 23:38:03 UTC (rev 181819)
@@ -1,3 +1,19 @@
+2015-03-20  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: Fast typing lags in the Styles sidebar or Console
+https://bugs.webkit.org/show_bug.cgi?id=142919
+
+Asynchronous autocomplete causes a race condition in CodeMirror,
+which results in skipped characters in while typing. Completing immediately
+fixes the issues.
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Controllers/CodeMirrorCompletionController.js:
+(WebInspector.CodeMirrorCompletionController.prototype.hideCompletions):
+(WebInspector.CodeMirrorCompletionController.prototype._completeAtCurrentPosition):
+(WebInspector.CodeMirrorCompletionController.prototype.):
+
 2015-03-19  Joseph Pecoraro  pecor...@apple.com
 
 Web Inspector: Adopt ES6 Class Syntax for all Model Objects


Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js (181818 => 181819)

--- trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js	2015-03-20 23:37:51 UTC (rev 181818)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js	2015-03-20 23:38:03 UTC (rev 181819)
@@ -169,11 +169,6 @@
 this._implicitSuffix = ;
 this._forced = false;
 
-if (this._completionDelayTimeout) {
-clearTimeout(this._completionDelayTimeout);
-delete this._completionDelayTimeout;
-}
-
 delete this._currentCompletion;
 delete this._ignoreNextCursorActivity;
 },
@@ -443,11 +438,6 @@
 return;
 }
 
-if (this._completionDelayTimeout) {
-clearTimeout(this._completionDelayTimeout);
-delete this._completionDelayTimeout;
-}
-
 this._removeCompletionHint(true, true);
 
 var cursor = this._codeMirror.getCursor();
@@ -787,15 +777,7 @@
 if (change.origin === +delete  !this._hasPendingCompletion())
 return;
 
-if (this._completionDelayTimeout) {
-clearTimeout(this._completionDelayTimeout);
-delete this._completionDelayTimeout;
-}
-
-if (this._hasPendingCompletion())
-this._completeAtCurrentPosition(false);
-else
-this._completionDelayTimeout = setTimeout(this._completeAtCurrentPosition.bind(this, false), WebInspector.CodeMirrorCompletionController.CompletionTypingDelay);
+this._completeAtCurrentPosition(false);
 },
 
 _handleCursorActivity: function(codeMirror)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [181610] trunk/Source/WebInspectorUI

2015-03-16 Thread nvasilyev

Title: [181610] trunk/Source/WebInspectorUI








Revision 181610
Author nvasil...@apple.com
Date 2015-03-16 20:56:18 -0700 (Mon, 16 Mar 2015)


Log Message
Web Inspector: Rename ConsoleMessage and ConsoleMessageImpl to LegacyConsoleMessage and LegacyConsoleMessageImpl respectively
https://bugs.webkit.org/show_bug.cgi?id=142712

As a first step of ConsoleMessage refactoring (https://bugs.webkit.org/show_bug.cgi?id=142599):

  - Rename WebInspector.ConsoleMessage class to WebInspector.LegacyConsoleMessage
  - Rename WebInspector.ConsoleMessageImpl class to WebInspector.LegacyConsoleMessageImpl
  - Rename ConsoleMessage.js file to LegacyConsoleMessage.js
  - Rename ConsoleMessageImpl file to LegacyConsoleMessageImpl.js

Reviewed by Joseph Pecoraro.

* UserInterface/Controllers/_javascript_LogViewController.js:
(WebInspector._javascript_LogViewController.prototype._appendConsoleMessage):
* UserInterface/Controllers/LogManager.js:
(WebInspector.LogManager.prototype.messageWasAdded):
* UserInterface/Main.html:
* UserInterface/Models/DefaultDashboard.js:
(WebInspector.DefaultDashboard.prototype._incrementConsoleMessageType):
* UserInterface/Views/ConsoleCommandResult.js:
(WebInspector.ConsoleCommandResult):
(WebInspector.ConsoleCommandResult.prototype.toMessageElement):
* UserInterface/Views/ConsoleGroup.js:
(WebInspector.ConsoleGroup.prototype.render):
* UserInterface/Views/LegacyConsoleMessage.js: Renamed from Source/WebInspectorUI/UserInterface/Views/ConsoleMessage.js.
(WebInspector.LegacyConsoleMessage):
(WebInspector.LegacyConsoleMessage.prototype.isErrorOrWarning):
(WebInspector.LegacyConsoleMessage.prototype.updateRepeatCount):
(WebInspector.LegacyConsoleMessage.prototype.clone):
(WebInspector.LegacyConsoleMessage.create):
* UserInterface/Views/LegacyConsoleMessageImpl.js: Renamed from Source/WebInspectorUI/UserInterface/Views/ConsoleMessageImpl.js.
(WebInspector.LegacyConsoleMessageImpl):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatMessage):
(WebInspector.LegacyConsoleMessageImpl.prototype._shouldDumpStackTrace):
(WebInspector.LegacyConsoleMessageImpl.prototype._shouldHideURL):
(WebInspector.LegacyConsoleMessageImpl.prototype._firstNonNativeCallFrame):
(WebInspector.LegacyConsoleMessageImpl.prototype.get message):
(WebInspector.LegacyConsoleMessageImpl.prototype.get formattedMessage):
(WebInspector.LegacyConsoleMessageImpl.prototype._linkifyLocation):
(WebInspector.LegacyConsoleMessageImpl.prototype._linkifyCallFrame):
(WebInspector.LegacyConsoleMessageImpl.prototype.isErrorOrWarning):
(WebInspector.LegacyConsoleMessageImpl.prototype._format):
(WebInspector.LegacyConsoleMessageImpl.prototype._isExpandable):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameter):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsValue):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsObject):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsString):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsNode):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsArray):
(WebInspector.LegacyConsoleMessageImpl.prototype._rootPropertyPathForObject):
(WebInspector.LegacyConsoleMessageImpl.prototype._userProvidedColumnNames):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsTable):
(WebInspector.LegacyConsoleMessageImpl.prototype.):
(WebInspector.LegacyConsoleMessageImpl.prototype.stringFormatter):
(WebInspector.LegacyConsoleMessageImpl.prototype.floatFormatter):
(WebInspector.LegacyConsoleMessageImpl.prototype.integerFormatter):
(WebInspector.LegacyConsoleMessageImpl.prototype.styleFormatter):
(WebInspector.LegacyConsoleMessageImpl.prototype.isWhitelistedProperty):
(WebInspector.LegacyConsoleMessageImpl.prototype.append):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatWithSubstitutionString):
(WebInspector.LegacyConsoleMessageImpl.prototype.decorateMessageElement):
(WebInspector.LegacyConsoleMessageImpl.prototype.toMessageElement):
(WebInspector.LegacyConsoleMessageImpl.prototype._populateStackTraceTreeElement):
(WebInspector.LegacyConsoleMessageImpl.prototype.updateRepeatCount):
(WebInspector.LegacyConsoleMessageImpl.prototype.toString):
(WebInspector.LegacyConsoleMessageImpl.prototype.get text):
(WebInspector.LegacyConsoleMessageImpl.prototype.isEqual):
(WebInspector.LegacyConsoleMessageImpl.prototype.get stackTrace):
(WebInspector.LegacyConsoleMessageImpl.prototype.clone):
(WebInspector.LegacyConsoleMessageImpl.prototype.get levelString):
(WebInspector.LegacyConsoleMessageImpl.prototype.get clipboardPrefixString):
(WebInspector.LegacyConsoleMessageImpl.prototype.toClipboardString):
* UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype.didAppendConsoleMessage):
(WebInspector.LogContentView.prototype._messageAdded):
(WebInspector.LogContentView.prototype._filterMessages):
(WebInspector.LogContentView.prototype._reappendProvisionalMessages):
*

[webkit-changes] [181588] trunk/Tools/Scripts/webkitpy/common/config/contributors.json

2015-03-16 Thread nvasilyev

Title: [181588] trunk/Tools/Scripts/webkitpy/common/config/contributors.json








Revision 181588
Author nvasil...@apple.com
Date 2015-03-16 16:11:03 -0700 (Mon, 16 Mar 2015)


Log Message
Unreviewed. Move myself from reviewers to commiters. I was added to reviewers by mistake.

Modified Paths

trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (181587 => 181588)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2015-03-16 23:01:21 UTC (rev 181587)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2015-03-16 23:11:03 UTC (rev 181588)
@@ -2070,6 +2070,17 @@
 diegoyam
  ]
   },
+  Nikita Vasilyev : {
+ emails : [
+nvasil...@apple.com,
+m...@elv1s.ru
+ ],
+ expertise : Web Inspector,
+ nicks : [
+NVI,
+    nvasilyev
+ ]
+  },
   Nima Ghanavatian : {
  emails : [
 nghanavat...@blackberry.com,
@@ -4437,17 +4448,6 @@
 thakis
  ]
   },
-  Nikita Vasilyev : {
- emails : [
-nvasil...@apple.com,
-m...@elv1s.ru
- ],
- expertise : Web Inspector,
- nicks : [
-NVI,
-    nvasilyev
- ]
-  },
   Nikolas Zimmermann : {
  emails : [
 zimmerm...@kde.org,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [181585] trunk/Tools/Scripts/webkitpy/common/config/contributors.json

2015-03-16 Thread nvasilyev

Title: [181585] trunk/Tools/Scripts/webkitpy/common/config/contributors.json








Revision 181585
Author nvasil...@apple.com
Date 2015-03-16 15:49:56 -0700 (Mon, 16 Mar 2015)


Log Message
Unreviewed. Add myself as a committer.

Modified Paths

trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (181584 => 181585)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2015-03-16 22:47:19 UTC (rev 181584)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2015-03-16 22:49:56 UTC (rev 181585)
@@ -4437,6 +4437,17 @@
 thakis
  ]
   },
+  Nikita Vasilyev : {
+ emails : [
+nvasil...@apple.com,
+m...@elv1s.ru
+ ],
+ expertise : Web Inspector,
+ nicks : [
+NVI,
+    nvasilyev
+ ]
+  },
   Nikolas Zimmermann : {
  emails : [
 zimmerm...@kde.org,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [181517] trunk/Source/WebInspectorUI

2015-03-15 Thread nvasilyev

Title: [181517] trunk/Source/WebInspectorUI








Revision 181517
Author nvasil...@apple.com
Date 2015-03-15 17:19:49 -0700 (Sun, 15 Mar 2015)


Log Message
Web Inspector: Rename ConsoleMessage and ConsoleMessageImpl to LegacyConsoleMessage and LegacyConsoleMessageImpl respectively
https://bugs.webkit.org/show_bug.cgi?id=142712

As a first step of ConsoleMessage refactoring (https://bugs.webkit.org/show_bug.cgi?id=142599):

  - Rename WebInspector.ConsoleMessage class to WebInspector.LegacyConsoleMessage
  - Rename WebInspector.ConsoleMessageImpl class to WebInspector.LegacyConsoleMessageImpl
  - Rename ConsoleMessage.js file to LegacyConsoleMessage.js
  - Rename ConsoleMessageImpl file to LegacyConsoleMessageImpl.js

Reviewed by Joseph Pecoraro.

* UserInterface/Controllers/_javascript_LogViewController.js:
(WebInspector._javascript_LogViewController.prototype._appendConsoleMessage):
* UserInterface/Controllers/LogManager.js:
(WebInspector.LogManager.prototype.messageWasAdded):
* UserInterface/Main.html:
* UserInterface/Models/DefaultDashboard.js:
(WebInspector.DefaultDashboard.prototype._incrementConsoleMessageType):
* UserInterface/Views/ConsoleCommandResult.js:
(WebInspector.ConsoleCommandResult):
(WebInspector.ConsoleCommandResult.prototype.toMessageElement):
* UserInterface/Views/ConsoleGroup.js:
(WebInspector.ConsoleGroup.prototype.render):
* UserInterface/Views/LegacyConsoleMessage.js: Renamed from Source/WebInspectorUI/UserInterface/Views/ConsoleMessage.js.
(WebInspector.LegacyConsoleMessage):
(WebInspector.LegacyConsoleMessage.prototype.isErrorOrWarning):
(WebInspector.LegacyConsoleMessage.prototype.updateRepeatCount):
(WebInspector.LegacyConsoleMessage.prototype.clone):
(WebInspector.LegacyConsoleMessage.create):
* UserInterface/Views/LegacyConsoleMessageImpl.js: Renamed from Source/WebInspectorUI/UserInterface/Views/ConsoleMessageImpl.js.
(WebInspector.LegacyConsoleMessageImpl):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatMessage):
(WebInspector.LegacyConsoleMessageImpl.prototype._shouldDumpStackTrace):
(WebInspector.LegacyConsoleMessageImpl.prototype._shouldHideURL):
(WebInspector.LegacyConsoleMessageImpl.prototype._firstNonNativeCallFrame):
(WebInspector.LegacyConsoleMessageImpl.prototype.get message):
(WebInspector.LegacyConsoleMessageImpl.prototype.get formattedMessage):
(WebInspector.LegacyConsoleMessageImpl.prototype._linkifyLocation):
(WebInspector.LegacyConsoleMessageImpl.prototype._linkifyCallFrame):
(WebInspector.LegacyConsoleMessageImpl.prototype.isErrorOrWarning):
(WebInspector.LegacyConsoleMessageImpl.prototype._format):
(WebInspector.LegacyConsoleMessageImpl.prototype._isExpandable):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameter):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsValue):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsObject):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsString):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsNode):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsArray):
(WebInspector.LegacyConsoleMessageImpl.prototype._rootPropertyPathForObject):
(WebInspector.LegacyConsoleMessageImpl.prototype._userProvidedColumnNames):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsTable):
(WebInspector.LegacyConsoleMessageImpl.prototype.):
(WebInspector.LegacyConsoleMessageImpl.prototype.stringFormatter):
(WebInspector.LegacyConsoleMessageImpl.prototype.floatFormatter):
(WebInspector.LegacyConsoleMessageImpl.prototype.integerFormatter):
(WebInspector.LegacyConsoleMessageImpl.prototype.styleFormatter):
(WebInspector.LegacyConsoleMessageImpl.prototype.isWhitelistedProperty):
(WebInspector.LegacyConsoleMessageImpl.prototype.append):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatWithSubstitutionString):
(WebInspector.LegacyConsoleMessageImpl.prototype.decorateMessageElement):
(WebInspector.LegacyConsoleMessageImpl.prototype.toMessageElement):
(WebInspector.LegacyConsoleMessageImpl.prototype._populateStackTraceTreeElement):
(WebInspector.LegacyConsoleMessageImpl.prototype.updateRepeatCount):
(WebInspector.LegacyConsoleMessageImpl.prototype.toString):
(WebInspector.LegacyConsoleMessageImpl.prototype.get text):
(WebInspector.LegacyConsoleMessageImpl.prototype.isEqual):
(WebInspector.LegacyConsoleMessageImpl.prototype.get stackTrace):
(WebInspector.LegacyConsoleMessageImpl.prototype.clone):
(WebInspector.LegacyConsoleMessageImpl.prototype.get levelString):
(WebInspector.LegacyConsoleMessageImpl.prototype.get clipboardPrefixString):
(WebInspector.LegacyConsoleMessageImpl.prototype.toClipboardString):
* UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype.didAppendConsoleMessage):
(WebInspector.LogContentView.prototype._messageAdded):
(WebInspector.LogContentView.prototype._filterMessages):
(WebInspector.LogContentView.prototype._reappendProvisionalMessages):
*

[webkit-changes] [181518] trunk/Source/WebInspectorUI

2015-03-15 Thread nvasilyev

Title: [181518] trunk/Source/WebInspectorUI








Revision 181518
Author nvasil...@apple.com
Date 2015-03-15 17:40:59 -0700 (Sun, 15 Mar 2015)


Log Message
Web Inspector: Console Scrolls Unexpectedly when Clicking inside un-selected Expanding Object
https://bugs.webkit.org/show_bug.cgi?id=142655

Don't scroll when selection change is triggered by clicking, e.g.
only scroll on arrow up and down key press events.

Reviewed by Joseph Pecoraro.

* UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype._mousemove):
(WebInspector.LogContentView.prototype._updateMessagesSelection):
(WebInspector.LogContentView.prototype._upArrowWasPressed):
(WebInspector.LogContentView.prototype._downArrowWasPressed):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (181517 => 181518)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-03-16 00:19:49 UTC (rev 181517)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-03-16 00:40:59 UTC (rev 181518)
@@ -1,5 +1,21 @@
 2015-03-15  Nikita Vasilyev  nvasil...@apple.com
 
+Web Inspector: Console Scrolls Unexpectedly when Clicking inside un-selected Expanding Object
+https://bugs.webkit.org/show_bug.cgi?id=142655
+
+Don't scroll when selection change is triggered by clicking, e.g.
+only scroll on arrow up and down key press events.
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/LogContentView.js:
+(WebInspector.LogContentView.prototype._mousemove):
+(WebInspector.LogContentView.prototype._updateMessagesSelection):
+(WebInspector.LogContentView.prototype._upArrowWasPressed):
+(WebInspector.LogContentView.prototype._downArrowWasPressed):
+
+2015-03-15  Nikita Vasilyev  nvasil...@apple.com
+
 Web Inspector: Rename ConsoleMessage and ConsoleMessageImpl to LegacyConsoleMessage and LegacyConsoleMessageImpl respectively
 https://bugs.webkit.org/show_bug.cgi?id=142712
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js (181517 => 181518)

--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js	2015-03-16 00:19:49 UTC (rev 181517)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js	2015-03-16 00:40:59 UTC (rev 181518)
@@ -421,9 +421,9 @@
 selection.removeAllRanges();
 
 if (!this._mouseMoveIsRowSelection)
-this._updateMessagesSelection(this._mouseDownWrapper, this._mouseDownCommandKey, this._mouseDownShiftKey);
+this._updateMessagesSelection(this._mouseDownWrapper, this._mouseDownCommandKey, this._mouseDownShiftKey, false);
 
-this._updateMessagesSelection(wrapper, false, true);
+this._updateMessagesSelection(wrapper, false, true, false);
 
 this._mouseMoveIsRowSelection = true;
 
@@ -444,7 +444,7 @@
 
 if (this._targetInMessageCanBeSelected(event.target, wrapper)) {
 var sameWrapper = wrapper === this._mouseDownWrapper;
-this._updateMessagesSelection(wrapper, sameWrapper ? this._mouseDownCommandKey : false, sameWrapper ? this._mouseDownShiftKey : true);
+this._updateMessagesSelection(wrapper, sameWrapper ? this._mouseDownCommandKey : false, sameWrapper ? this._mouseDownShiftKey : true, false);
 }
 } else if (!selection.isCollapsed) {
 // There is a text selection, clear the row selection.
@@ -483,7 +483,7 @@
 }
 },
 
-_updateMessagesSelection: function(message, multipleSelection, rangeSelection)
+_updateMessagesSelection: function(message, multipleSelection, rangeSelection, shouldScrollIntoView)
 {
 var alreadySelectedMessage = this._selectedMessages.contains(message);
 if (alreadySelectedMessage  this._selectedMessages.length  multipleSelection) {
@@ -529,7 +529,7 @@
 if (!rangeSelection)
 this._referenceMessageForRangeSelection = message;
 
-if (!alreadySelectedMessage)
+if (shouldScrollIntoView  !alreadySelectedMessage)
 this._ensureMessageIsVisible(this._selectedMessages.lastValue);
 },
 
@@ -751,17 +751,17 @@
 
 if (!this._selectedMessages.length) {
 if (messages.length)
-this._updateMessagesSelection(messages.lastValue, false, false);
+this._updateMessagesSelection(messages.lastValue, false, false, true);
 return;
 }
 
 var lastMessage = this._selectedMessages.lastValue;
 var previousMessage = this._previousMessage(lastMessage);
 if (previousMessage)
-this._updateMessagesSelection(previousMessage, false, event.shiftKey);
+this._updateMessagesSelection(previousMessage, false, event.shiftKey, true);
 else if (!event.shiftKey) {
 this._clearMessagesSelection();
-

[webkit-changes] [180941] trunk/Source/WebInspectorUI

2015-03-03 Thread nvasilyev

Title: [180941] trunk/Source/WebInspectorUI








Revision 180941
Author nvasil...@apple.com
Date 2015-03-03 10:10:56 -0800 (Tue, 03 Mar 2015)


Log Message
Web Inspector: Refactoring: separate ConsoleSession from ConsoleGroup
https://bugs.webkit.org/show_bug.cgi?id=142141

ConsoleSession doesn't have a title and it's not collapsible either.
Simplify ConsoleSession by removing excessive markup.

Reviewed by Timothy Hatcher.

* UserInterface/Controllers/_javascript_LogViewController.js:
(WebInspector._javascript_LogViewController):
(WebInspector._javascript_LogViewController.prototype.startNewSession):
(WebInspector._javascript_LogViewController.prototype._appendConsoleMessage):
(WebInspector._javascript_LogViewController.prototype.get topConsoleGroup): Deleted.
* UserInterface/Main.html:
* UserInterface/Views/ConsoleGroup.js:
(WebInspector.ConsoleGroup):
(WebInspector.ConsoleGroup.prototype.render):
(WebInspector.ConsoleGroup.prototype.addMessage):
(WebInspector.ConsoleGroup.prototype.append):
(WebInspector.ConsoleGroup.prototype.hasMessages): Deleted.
* UserInterface/Views/ConsoleSession.js: Added.
(WebInspector.ConsoleSession):
(WebInspector.ConsoleSession.prototype.addMessage):
(WebInspector.ConsoleSession.prototype.append):
(WebInspector.ConsoleSession.prototype.hasMessages):
* UserInterface/Views/LogContentView.css:
(.console-session + .console-session):
(.console-group.new-session .console-group-messages .console-item:first-child): Deleted.
(.console-group.new-session): Deleted.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/_javascript_LogViewController.js
trunk/Source/WebInspectorUI/UserInterface/Main.html
trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleGroup.js
trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css


Added Paths

trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleSession.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (180940 => 180941)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-03-03 18:05:59 UTC (rev 180940)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-03-03 18:10:56 UTC (rev 180941)
@@ -1,3 +1,35 @@
+2015-03-03  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: Refactoring: separate ConsoleSession from ConsoleGroup
+https://bugs.webkit.org/show_bug.cgi?id=142141
+
+ConsoleSession doesn't have a title and it's not collapsible either.
+Simplify ConsoleSession by removing excessive markup.
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Controllers/_javascript_LogViewController.js:
+(WebInspector._javascript_LogViewController):
+(WebInspector._javascript_LogViewController.prototype.startNewSession):
+(WebInspector._javascript_LogViewController.prototype._appendConsoleMessage):
+(WebInspector._javascript_LogViewController.prototype.get topConsoleGroup): Deleted.
+* UserInterface/Main.html:
+* UserInterface/Views/ConsoleGroup.js:
+(WebInspector.ConsoleGroup):
+(WebInspector.ConsoleGroup.prototype.render):
+(WebInspector.ConsoleGroup.prototype.addMessage):
+(WebInspector.ConsoleGroup.prototype.append):
+(WebInspector.ConsoleGroup.prototype.hasMessages): Deleted.
+* UserInterface/Views/ConsoleSession.js: Added.
+(WebInspector.ConsoleSession):
+(WebInspector.ConsoleSession.prototype.addMessage):
+(WebInspector.ConsoleSession.prototype.append):
+(WebInspector.ConsoleSession.prototype.hasMessages):
+* UserInterface/Views/LogContentView.css:
+(.console-session + .console-session):
+(.console-group.new-session .console-group-messages .console-item:first-child): Deleted.
+(.console-group.new-session): Deleted.
+
 2015-03-03  Brian J. Burg  b...@cs.washington.edu
 
 Web Inspector: popover should use requestAnimationFrame to drive move/resize animations


Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/_javascript_LogViewController.js (180940 => 180941)

--- trunk/Source/WebInspectorUI/UserInterface/Controllers/_javascript_LogViewController.js	2015-03-03 18:05:59 UTC (rev 180940)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/_javascript_LogViewController.js	2015-03-03 18:10:56 UTC (rev 180941)
@@ -45,7 +45,7 @@
 this._previousMessage = null;
 this._repeatCountWasInterrupted = false;
 
-this._topConsoleGroups = [];
+this._sessions = [];
 
 this.messagesClearKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl, K, this._handleClearShortcut.bind(this));
 this.messagesAlternateClearKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Control, L, this._handleClearShortcut.bind(this), this._element);
@@ -74,11 +74,6 @@
 return this._prompt;
 },
 
-get topConsoleGroup()
-{
-return

[webkit-changes] [180725] trunk/Source/WebInspectorUI

2015-02-26 Thread nvasilyev

Title: [180725] trunk/Source/WebInspectorUI








Revision 180725
Author nvasil...@apple.com
Date 2015-02-26 21:32:07 -0800 (Thu, 26 Feb 2015)


Log Message
Web Inspector: Add a subtle blue background for selected console messages
https://bugs.webkit.org/show_bug.cgi?id=142073

Reviewed by Timothy Hatcher.

* UserInterface/Views/LogContentView.css:
(.console-item.selected::after):
(.console-messages:focus .console-item.selected):
(.console-messages:focus .console-item.selected + .console-item):
(.console-error-level + .console-item):
(.console-error-level .section .header .title):
(.console-warning-level):
(.console-warning-level + .console-item):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (180724 => 180725)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-02-27 05:27:13 UTC (rev 180724)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-02-27 05:32:07 UTC (rev 180725)
@@ -1,3 +1,19 @@
+2015-02-26  Nikita Vasilyev  nvasil...@apple.com
+
+Web Inspector: Add a subtle blue background for selected console messages
+https://bugs.webkit.org/show_bug.cgi?id=142073
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/LogContentView.css:
+(.console-item.selected::after):
+(.console-messages:focus .console-item.selected):
+(.console-messages:focus .console-item.selected + .console-item):
+(.console-error-level + .console-item):
+(.console-error-level .section .header .title):
+(.console-warning-level):
+(.console-warning-level + .console-item):
+
 2015-02-26  Joseph Pecoraro  pecor...@apple.com
 
 Web Inspector: Colored console messages apply text color to object tree properties


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css (180724 => 180725)

--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css	2015-02-27 05:27:13 UTC (rev 180724)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css	2015-02-27 05:32:07 UTC (rev 180725)
@@ -63,10 +63,11 @@
 display: block;
 content: ;
 left: 0;
-top: 0;
-bottom: 0;
+top: -1px;
+bottom: -1px;
 background: hsl(0, 0%, 60%);
 width: 2px;
+z-index: 10;
 }
 
 .console-messages:focus .console-item.selected .data-grid tr.selected {
@@ -77,6 +78,15 @@
 background-color: hsl(210, 0%, 90%) !important;
 }
 
+.console-messages:focus .console-item.selected {
+background-color: hsl(210, 98%, 96%);
+border-color: hsl(210, 90%, 93%);
+}
+
+.console-messages:focus .console-item.selected + .console-item {
+border-top-color: hsl(210, 90%, 93%);
+}
+
 .console-messages:focus .console-item.selected::after {
 background: hsl(210, 100%, 49%);
 }
@@ -170,9 +180,13 @@
 border-color: hsl(0, 100%, 92%);
 }
 
+.console-error-level + .console-item {
+border-top-color: hsl(0, 100%, 92%);
+}
+
 .console-error-level .console-message-text,
 .console-error-level .section .header .title {
-color: hsl(0, 75%, 50%);
+color: hsl(0, 75%, 45%);
 }
 
 .console-debug-level .console-message-text {
@@ -189,9 +203,13 @@
 
 .console-warning-level {
 background-color: hsl(50, 100%, 94%);
-border-color: hsl(50, 100%, 86%);
+border-color: hsl(40, 100%, 90%);
 }
 
+.console-warning-level + .console-item {
+border-top-color: hsl(40, 100%, 90%);
+}
+
 .console-warning-level .console-message-text {
 color: hsl(30, 90%, 35%);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

< 1 2 3 4 5 6

501 - 538 of 538 matches

Mail list logo