[webkit-changes] [194569] trunk/Tools

[aakash_jain]

Title: [194569] trunk/Tools








Revision 194569
Author aakash_j...@apple.com
Date 2016-01-04 18:16:48 -0800 (Mon, 04 Jan 2016)


Log Message
error running layout tests on iOS simulator on latest build
https://bugs.webkit.org/show_bug.cgi?id=152719


Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/xcode/simulator.py:
(Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
  before running simctl spawn command.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/xcode/simulator.py




Diff

Modified: trunk/Tools/ChangeLog (194568 => 194569)

--- trunk/Tools/ChangeLog	2016-01-05 01:48:00 UTC (rev 194568)
+++ trunk/Tools/ChangeLog	2016-01-05 02:16:48 UTC (rev 194569)
@@ -1,3 +1,15 @@
+2016-01-04  Aakash Jain  
+
+error running layout tests on iOS simulator on latest build
+https://bugs.webkit.org/show_bug.cgi?id=152719
+
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/xcode/simulator.py:
+(Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
+  before running simctl spawn command.
+
 2016-01-03  Michael Catanzaro  
 
 Unreviewed, move Frédéric Wang to committers list


Modified: trunk/Tools/Scripts/webkitpy/xcode/simulator.py (194568 => 194569)

--- trunk/Tools/Scripts/webkitpy/xcode/simulator.py	2016-01-05 01:48:00 UTC (rev 194568)
+++ trunk/Tools/Scripts/webkitpy/xcode/simulator.py	2016-01-05 02:16:48 UTC (rev 194569)
@@ -275,6 +275,7 @@
 
 @staticmethod
 def wait_until_device_is_booted(udid, timeout_seconds=60 * 5):
+Simulator.wait_until_device_is_in_state(udid, Simulator.DeviceState.BOOTED, timeout_seconds)
 with timeout(seconds=timeout_seconds):
 while True:
 state = subprocess.check_output(['xcrun', 'simctl', 'spawn', udid, 'launchctl', 'print', 'system']).strip()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194768] trunk/Tools

[aakash_jain]

Title: [194768] trunk/Tools








Revision 194768
Author aakash_j...@apple.com
Date 2016-01-08 10:20:27 -0800 (Fri, 08 Jan 2016)


Log Message
run-webkit-tests mis-counts totals when there are other crashes
https://bugs.webkit.org/show_bug.cgi?id=152894


Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/layout_tests/models/test_run_results.py:
(TestRunResults.add): Do not update result counters for other crashes.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py




Diff

Modified: trunk/Tools/ChangeLog (194767 => 194768)

--- trunk/Tools/ChangeLog	2016-01-08 18:10:36 UTC (rev 194767)
+++ trunk/Tools/ChangeLog	2016-01-08 18:20:27 UTC (rev 194768)
@@ -1,3 +1,14 @@
+2016-01-08  Aakash Jain  
+
+run-webkit-tests mis-counts totals when there are other crashes
+https://bugs.webkit.org/show_bug.cgi?id=152894
+
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/layout_tests/models/test_run_results.py:
+(TestRunResults.add): Do not update result counters for other crashes.
+
 2016-01-08  Youenn Fablet  
 
 webkit-patch build-and-test should have an option to iterate over new tests


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py (194767 => 194768)

--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py	2016-01-08 18:10:36 UTC (rev 194767)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py	2016-01-08 18:20:27 UTC (rev 194768)
@@ -67,6 +67,8 @@
 def add(self, test_result, expected, test_is_slow):
 self.tests_by_expectation[test_result.type].add(test_result.test_name)
 self.results_by_name[test_result.test_name] = test_result
+if test_result.is_other_crash:
+return
 if test_result.type != test_expectations.SKIP:
 self.all_results.append(test_result)
 self.remaining -= 1






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194346] trunk/Tools

[aakash_jain]

Title: [194346] trunk/Tools








Revision 194346
Author aakash_j...@apple.com
Date 2015-12-21 13:14:06 -0800 (Mon, 21 Dec 2015)


Log Message
Unreviewed, add myself to the committers list.

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (194345 => 194346)

--- trunk/Tools/ChangeLog	2015-12-21 21:01:49 UTC (rev 194345)
+++ trunk/Tools/ChangeLog	2015-12-21 21:14:06 UTC (rev 194346)
@@ -1,3 +1,9 @@
+2015-12-21  Aakash Jain  <aakash_j...@apple.com>
+
+Unreviewed, add myself to the committers list.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2015-12-21  Michael Catanzaro  <mcatanz...@igalia.com>
 
 [GTK] jquery.min.js violates DFSG


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (194345 => 194346)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2015-12-21 21:01:49 UTC (rev 194345)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2015-12-21 21:14:06 UTC (rev 194346)
@@ -1,5 +1,13 @@
 {
"Committers" : {
+  "Aakash Jain" : {
+ "emails" : [
+"aakash_j...@apple.com"
+ ],
+ "nicks" : [
+"aakash_jain"
+ ]
+  },
   "Aaron Boodman" : {
  "emails" : [
 "a...@chromium.org"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201821] trunk/Tools

[aakash_jain]

Title: [201821] trunk/Tools








Revision 201821
Author aakash_j...@apple.com
Date 2016-06-08 12:17:52 -0700 (Wed, 08 Jun 2016)


Log Message
tests fail if display sleeps while run-webkit-tests is running
https://bugs.webkit.org/show_bug.cgi?id=153919

Reviewed by Alexey Proskuryakov.

* DumpRenderTree/mac/LayoutTestHelper.m:
(releaseSleepAssertions): Release both Display sleep and System sleep assertions.
(addSleepAssertions): Add sleep assertion for both Display sleep and System sleep.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m




Diff

Modified: trunk/Tools/ChangeLog (201820 => 201821)

--- trunk/Tools/ChangeLog	2016-06-08 18:52:37 UTC (rev 201820)
+++ trunk/Tools/ChangeLog	2016-06-08 19:17:52 UTC (rev 201821)
@@ -1,3 +1,14 @@
+2016-06-08  Aakash Jain  
+
+tests fail if display sleeps while run-webkit-tests is running
+https://bugs.webkit.org/show_bug.cgi?id=153919
+
+Reviewed by Alexey Proskuryakov.
+
+* DumpRenderTree/mac/LayoutTestHelper.m:
+(releaseSleepAssertions): Release both Display sleep and System sleep assertions.
+(addSleepAssertions): Add sleep assertion for both Display sleep and System sleep.
+
 2016-06-08  Lucas Forschler  
 
 Reverted changeset 201814.


Modified: trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m (201820 => 201821)

--- trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m	2016-06-08 18:52:37 UTC (rev 201820)
+++ trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m	2016-06-08 19:17:52 UTC (rev 201821)
@@ -47,7 +47,8 @@
 // running layout tests.
 
 static int installColorProfile = false;
-static uint32_t assertionID = 0;
+static uint32_t assertionIDForDisplaySleep = 0;
+static uint32_t assertionIDForSystemSleep = 0;
 
 static NSMutableDictionary *originalColorProfileURLs()
 {
@@ -195,16 +196,17 @@
 restoreDisplayColorProfiles(displays);
 }
 
-static void releaseDisplaySleepAssertion()
+static void releaseSleepAssertions()
 {
-IOPMAssertionRelease(assertionID);
+IOPMAssertionRelease(assertionIDForDisplaySleep);
+IOPMAssertionRelease(assertionIDForSystemSleep);
 }
 
 static void simpleSignalHandler(int sig)
 {
 // Try to restore the color profile and try to go down cleanly
 restoreUserColorProfile();
-releaseDisplaySleepAssertion();
+releaseSleepAssertions();
 exit(128 + sig);
 }
 
@@ -240,12 +242,14 @@
 NSLog(@"IOObjectRelease() failed in %s with kernResult = %d", __FUNCTION__, kernResult);
 }
 
-void addDisplaySleepAssertion() 
+void addSleepAssertions()
 {
 CFStringRef assertionName = CFSTR("WebKit LayoutTestHelper");
 CFStringRef assertionDetails = CFSTR("WebKit layout-test helper tool is preventing sleep.");
+IOPMAssertionCreateWithDescription(kIOPMAssertionTypePreventUserIdleDisplaySleep,
+assertionName, assertionDetails, assertionDetails, NULL, 0, NULL, );
 IOPMAssertionCreateWithDescription(kIOPMAssertionTypePreventUserIdleSystemSleep,
-assertionName, assertionDetails, assertionDetails, NULL, 0, NULL, );
+assertionName, assertionDetails, assertionDetails, NULL, 0, NULL, );
 }
 
 int main(int argc, char* argv[])
@@ -269,7 +273,7 @@
 signal(SIGHUP, simpleSignalHandler);
 signal(SIGTERM, simpleSignalHandler);
 
-addDisplaySleepAssertion();
+addSleepAssertions();
 lockDownDiscreteGraphics();
 
 // Save off the current profile, and then install the layout test profile.
@@ -284,7 +288,7 @@
 
 // Restore the profile
 restoreUserColorProfile();
-releaseDisplaySleepAssertion();
+releaseSleepAssertions();
 
 return 0;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201812] trunk/Tools

[aakash_jain]

Title: [201812] trunk/Tools








Revision 201812
Author aakash_j...@apple.com
Date 2016-06-08 11:03:08 -0700 (Wed, 08 Jun 2016)


Log Message
Don't try to cleanup non-existing ios Simulators
https://bugs.webkit.org/show_bug.cgi?id=158510

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.clean_up_test_run):
Check if simulator exists before trying to clean it up.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/ios.py




Diff

Modified: trunk/Tools/ChangeLog (201811 => 201812)

--- trunk/Tools/ChangeLog	2016-06-08 17:46:06 UTC (rev 201811)
+++ trunk/Tools/ChangeLog	2016-06-08 18:03:08 UTC (rev 201812)
@@ -1,3 +1,14 @@
+2016-06-08  Aakash Jain  
+
+Don't try to cleanup non-existing ios Simulators
+https://bugs.webkit.org/show_bug.cgi?id=158510
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/port/ios.py:
+(IOSSimulatorPort.clean_up_test_run): 
+Check if simulator exists before trying to clean it up.
+
 2016-06-08  Brady Eidson  
 
 Try to fix the Windows build.


Modified: trunk/Tools/Scripts/webkitpy/port/ios.py (201811 => 201812)

--- trunk/Tools/Scripts/webkitpy/port/ios.py	2016-06-08 17:46:06 UTC (rev 201811)
+++ trunk/Tools/Scripts/webkitpy/port/ios.py	2016-06-08 18:03:08 UTC (rev 201812)
@@ -254,6 +254,8 @@
 pass
 
 for i in xrange(self.child_processes()):
+if not os.path.exists(self.get_simulator_path(i)):
+continue
 try:
 subprocess.call([self.LSREGISTER_PATH, "-v", "-u", self.get_simulator_path(i)])
 shutil.rmtree(self.get_simulator_path(i), ignore_errors=True)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201986] trunk/Tools

[aakash_jain]

Title: [201986] trunk/Tools








Revision 201986
Author aakash_j...@apple.com
Date 2016-06-12 20:57:23 -0700 (Sun, 12 Jun 2016)


Log Message
run-safari/run-webkit-app fail to quit iOS simulator after Xcode installation
https://bugs.webkit.org/show_bug.cgi?id=158651
rdar://problem/26499824

Reviewed by Daniel Bates.

This change is to make our tools more robust. Sometimes run-safari/run-webkit-app fails
to start the tests as one of the first thing these scripts do is to relaunch iOS Simulators,
and in process call quitIOSSimulator. In case the Simulator is not registered in LaunchServices
for some reason, quitIOSSimulator fails and the script stops. This change will make the scripts
still continue when they fail to quit iOS Simuator, and modify the way Simulator is opened,
so that Simulator is implicitly registered with LaunchServices while opening it.

* Scripts/webkitdirs.pm:
(relaunchIOSSimulator):
Launch iOS Simulator using complete path. Partially reverting http://trac.webkit.org/changeset/184202.
(quitIOSSimulator):
Do not die if quitting ios Simulator fails, so that relaunchIOSSimulator can still
attempt to launch the simulator.
(waitUntilIOSSimulatorDeviceIsInState):
Added a FIXME.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Tools/ChangeLog (201985 => 201986)

--- trunk/Tools/ChangeLog	2016-06-12 20:57:11 UTC (rev 201985)
+++ trunk/Tools/ChangeLog	2016-06-13 03:57:23 UTC (rev 201986)
@@ -1,3 +1,27 @@
+2016-06-12  Aakash Jain  
+
+run-safari/run-webkit-app fail to quit iOS simulator after Xcode installation
+https://bugs.webkit.org/show_bug.cgi?id=158651
+rdar://problem/26499824
+
+Reviewed by Daniel Bates.
+
+This change is to make our tools more robust. Sometimes run-safari/run-webkit-app fails 
+to start the tests as one of the first thing these scripts do is to relaunch iOS Simulators,
+and in process call quitIOSSimulator. In case the Simulator is not registered in LaunchServices
+for some reason, quitIOSSimulator fails and the script stops. This change will make the scripts
+still continue when they fail to quit iOS Simuator, and modify the way Simulator is opened, 
+so that Simulator is implicitly registered with LaunchServices while opening it.
+
+* Scripts/webkitdirs.pm:
+(relaunchIOSSimulator):
+Launch iOS Simulator using complete path. Partially reverting http://trac.webkit.org/changeset/184202.
+(quitIOSSimulator):
+Do not die if quitting ios Simulator fails, so that relaunchIOSSimulator can still 
+attempt to launch the simulator.
+(waitUntilIOSSimulatorDeviceIsInState):
+Added a FIXME.
+
 2016-06-11  Myles C. Maxfield  
 
 Addressing post-review comments after r201978.


Modified: trunk/Tools/Scripts/webkitdirs.pm (201985 => 201986)

--- trunk/Tools/Scripts/webkitdirs.pm	2016-06-12 20:57:11 UTC (rev 201985)
+++ trunk/Tools/Scripts/webkitdirs.pm	2016-06-13 03:57:23 UTC (rev 201986)
@@ -2252,6 +2252,7 @@
 {
 my ($deviceUDID, $waitUntilState) = @_;
 my $device = iosSimulatorDeviceByUDID($deviceUDID);
+# FIXME: We should add a maximum time limit to wait here.
 while ($device->{state} ne $waitUntilState) {
 usleep(500 * 1000); # Waiting 500ms between file system polls does not make script run-safari feel sluggish.
 $device = iosSimulatorDeviceByUDID($deviceUDID);
@@ -2278,8 +2279,9 @@
 quitIOSSimulator($simulatedDevice->{UDID});
 
 # FIXME:  Switch to using CoreSimulator.framework for launching and quitting iOS Simulator
-my $iosSimulatorBundleID = "com.apple.iphonesimulator";
-system("open", "-b", $iosSimulatorBundleID, "--args", "-CurrentDeviceUDID", $simulatedDevice->{UDID}) == 0 or die "Failed to open $iosSimulatorBundleID: $!";
+chomp(my $developerDirectory = $ENV{DEVELOPER_DIR} || `xcode-select --print-path`); 
+my $iosSimulatorPath = File::Spec->catfile($developerDirectory, "Applications", "Simulator.app"); 
+system("open", "-a", $iosSimulatorPath, "--args", "-CurrentDeviceUDID", $simulatedDevice->{UDID}) == 0 or die "Failed to open $iosSimulatorPath: $!"; 
 
 waitUntilIOSSimulatorDeviceIsInState($simulatedDevice->{UDID}, SIMULATOR_DEVICE_STATE_BOOTED);
 }
@@ -2288,7 +2290,11 @@
 {
 my ($waitForShutdownOfSimulatedDeviceUDID) = @_;
 # FIXME:  Switch to using CoreSimulator.framework for launching and quitting iOS Simulator
-exitStatus(system {"osascript"} "osascript", "-e", 'tell application id "com.apple.iphonesimulator" to quit') == 0 or die "Failed to quit iOS Simulator: $!";
+if (exitStatus(system {"osascript"} "osascript", "-e", 'tell application id "com.apple.iphonesimulator" to quit')) {
+# osascript returns a non-zero exit status if Simulator.app is not registered in LaunchServices.
+return;
+}
+
 if 

[webkit-changes] [201489] trunk/Tools

[aakash_jain]

Title: [201489] trunk/Tools








Revision 201489
Author aakash_j...@apple.com
Date 2016-05-28 11:27:53 -0700 (Sat, 28 May 2016)


Log Message
tests fail if display sleeps while run-webkit-tests is running
https://bugs.webkit.org/show_bug.cgi?id=153919

Reviewed by Darin Adler.

* DumpRenderTree/mac/LayoutTestHelper.m:
(addDisplaySleepAssertion): Use PreventUserIdleSystemSleep flag, same as set by caffeinate tool.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m




Diff

Modified: trunk/Tools/ChangeLog (201488 => 201489)

--- trunk/Tools/ChangeLog	2016-05-28 18:26:41 UTC (rev 201488)
+++ trunk/Tools/ChangeLog	2016-05-28 18:27:53 UTC (rev 201489)
@@ -1,3 +1,13 @@
+2016-05-28  Aakash Jain  
+
+tests fail if display sleeps while run-webkit-tests is running
+https://bugs.webkit.org/show_bug.cgi?id=153919
+
+Reviewed by Darin Adler.
+
+* DumpRenderTree/mac/LayoutTestHelper.m:
+(addDisplaySleepAssertion): Use PreventUserIdleSystemSleep flag, same as set by caffeinate tool.
+
 2016-05-27  Srinivasan Vijayaraghavan  
 
 Display failing JSC stress tests in buildbot dashboard


Modified: trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m (201488 => 201489)

--- trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m	2016-05-28 18:26:41 UTC (rev 201488)
+++ trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m	2016-05-28 18:27:53 UTC (rev 201489)
@@ -244,7 +244,7 @@
 {
 CFStringRef assertionName = CFSTR("WebKit LayoutTestHelper");
 CFStringRef assertionDetails = CFSTR("WebKit layout-test helper tool is preventing sleep.");
-IOPMAssertionCreateWithDescription(kIOPMAssertionTypePreventUserIdleDisplaySleep,
+IOPMAssertionCreateWithDescription(kIOPMAssertionTypePreventUserIdleSystemSleep,
 assertionName, assertionDetails, assertionDetails, NULL, 0, NULL, );
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201606] trunk/Tools

[aakash_jain]

Title: [201606] trunk/Tools








Revision 201606
Author aakash_j...@apple.com
Date 2016-06-02 11:42:43 -0700 (Thu, 02 Jun 2016)


Log Message
LayoutTests time out intermittently due to alert about reopening Simulator after it unexpectedly quit
https://bugs.webkit.org/show_bug.cgi?id=158305

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.clean_up_test_run): Delete simulator's savedState directories during cleanup.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/ios.py




Diff

Modified: trunk/Tools/ChangeLog (201605 => 201606)

--- trunk/Tools/ChangeLog	2016-06-02 18:41:16 UTC (rev 201605)
+++ trunk/Tools/ChangeLog	2016-06-02 18:42:43 UTC (rev 201606)
@@ -1,3 +1,13 @@
+2016-06-02  Aakash Jain  
+
+LayoutTests time out intermittently due to alert about reopening Simulator after it unexpectedly quit
+https://bugs.webkit.org/show_bug.cgi?id=158305
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/port/ios.py:
+(IOSSimulatorPort.clean_up_test_run): Delete simulator's savedState directories during cleanup.
+
 2016-06-01  Brian Burg  
 
 REGRESSION(r191907): Can't enter combining diacritic marks in Web Inspector fields


Modified: trunk/Tools/Scripts/webkitpy/port/ios.py (201605 => 201606)

--- trunk/Tools/Scripts/webkitpy/port/ios.py	2016-06-02 18:41:16 UTC (rev 201605)
+++ trunk/Tools/Scripts/webkitpy/port/ios.py	2016-06-02 18:42:43 UTC (rev 201606)
@@ -259,6 +259,8 @@
 shutil.rmtree(self.get_simulator_path(i), ignore_errors=True)
 shutil.rmtree(os.path.join(os.path.expanduser("~"), "Library/Logs/CoreSimulator/",
 self.testing_device(i).udid), ignore_errors=True)
+shutil.rmtree(os.path.join(os.path.expanduser("~"), "Library/Saved Application State/",
+self.SIMULATOR_BUNDLE_ID + str(i) + ".savedState"), ignore_errors=True)
 Simulator().delete_device(self.testing_device(i).udid)
 except:
 _log.warning('Unable to remove Simulator' + str(i))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202062] trunk/Tools

[aakash_jain]

Title: [202062] trunk/Tools








Revision 202062
Author aakash_j...@apple.com
Date 2016-06-14 14:27:19 -0700 (Tue, 14 Jun 2016)


Log Message
Too much log data generated during layout-tests on iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=158751

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort._quit_ios_simulator): Do not use -v flag.
(IOSSimulatorPort.clean_up_test_run): Ditto.
(IOSSimulatorPort._createSimulatorApp): Ditto.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/ios.py




Diff

Modified: trunk/Tools/ChangeLog (202061 => 202062)

--- trunk/Tools/ChangeLog	2016-06-14 20:35:24 UTC (rev 202061)
+++ trunk/Tools/ChangeLog	2016-06-14 21:27:19 UTC (rev 202062)
@@ -1,3 +1,15 @@
+2016-06-14  Aakash Jain  
+
+Too much log data generated during layout-tests on iOS Simulator
+https://bugs.webkit.org/show_bug.cgi?id=158751
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/port/ios.py:
+(IOSSimulatorPort._quit_ios_simulator): Do not use -v flag.
+(IOSSimulatorPort.clean_up_test_run): Ditto.
+(IOSSimulatorPort._createSimulatorApp): Ditto.
+
 2016-06-14  David Kilzer  
 
 Follow-up fix: REGRESSION (r202020): El Capitan CMake Debug build broken


Modified: trunk/Tools/Scripts/webkitpy/port/ios.py (202061 => 202062)

--- trunk/Tools/Scripts/webkitpy/port/ios.py	2016-06-14 20:35:24 UTC (rev 202061)
+++ trunk/Tools/Scripts/webkitpy/port/ios.py	2016-06-14 21:27:19 UTC (rev 202062)
@@ -240,7 +240,7 @@
 
 def _quit_ios_simulator(self):
 # FIXME: We should kill only the Simulators we started.
-subprocess.call(["killall", "-9", "-v", "-m", "Simulator"])
+subprocess.call(["killall", "-9", "-m", "Simulator"])
 
 def clean_up_test_run(self):
 super(IOSSimulatorPort, self).clean_up_test_run()
@@ -257,7 +257,7 @@
 if not os.path.exists(self.get_simulator_path(i)):
 continue
 try:
-subprocess.call([self.LSREGISTER_PATH, "-v", "-u", self.get_simulator_path(i)])
+subprocess.call([self.LSREGISTER_PATH, "-u", self.get_simulator_path(i)])
 shutil.rmtree(self.get_simulator_path(i), ignore_errors=True)
 shutil.rmtree(os.path.join(os.path.expanduser("~"), "Library/Logs/CoreSimulator/",
 self.testing_device(i).udid), ignore_errors=True)
@@ -497,4 +497,4 @@
 subprocess.check_output(["/usr/libexec/PlistBuddy", "-c", command, plist_path])
 subprocess.check_output(["install_name_tool", "-add_rpath", self.developer_dir + "/Library/PrivateFrameworks/", destination + "/Contents/MacOS/Simulator"])
 subprocess.check_output(["codesign", "-fs", "-", destination])
-subprocess.check_output([self.LSREGISTER_PATH, "-v", "-f", destination])
+subprocess.check_output([self.LSREGISTER_PATH, "-f", destination])






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202319] trunk/Tools

[aakash_jain]

Title: [202319] trunk/Tools








Revision 202319
Author aakash_j...@apple.com
Date 2016-06-21 20:34:05 -0700 (Tue, 21 Jun 2016)


Log Message
Fix formatting issues reported by check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=159008

Reviewed by Alexey Proskuryakov.

Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
There is no functionality change.

* Scripts/webkitpy/tool/bot/irc_command.py:
(Restart.execute):
(Rollout):
* Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_exception_during_command):
(IRCBotTest.test_exception_during_command.CommandWithException):
(IRCBotTest.test_exception_during_command.CommandWithException.execute):
* Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(test_missing_unit_test_results_path):
(test_layout_test_results):
* Scripts/webkitpy/tool/bot/queueengine.py:
* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
* Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
(AbstractSequencedCommand):
(AbstractSequencedCommand.__init__):
* Scripts/webkitpy/tool/commands/download.py:
(Land):
* Scripts/webkitpy/tool/commands/openbugs.py:
* Scripts/webkitpy/tool/commands/openbugs_unittest.py:
(OpenBugsTest):
* Scripts/webkitpy/tool/commands/queries.py:
(PatchesToCommitQueue):
(PatchesToCommitQueue.__init__):
(PatchesToCommitQueue._needs_commit_queue):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_platform):
(PrintBaselinesTest):
(PrintBaselinesTest.setUp):
* Scripts/webkitpy/tool/commands/queues.py:
(AbstractQueue):
(AbstractQueue.__init__):
(AbstractQueue.execute):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(test_auto_retry):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand._files_to_add):
(AbstractParallelRebaselineCommand):
(AbstractParallelRebaselineCommand._rebaseline):
* Scripts/webkitpy/tool/commands/setupgitclone.py:
(SetupGitClone):
* Scripts/webkitpy/tool/commands/sheriffbot.py:
* Scripts/webkitpy/tool/commands/stepsequence.py:
* Scripts/webkitpy/tool/commands/upload.py:
(PostCommits._comment_text_for_commit):
(PostCommits):
(PostCommits.execute):
(MarkBugFixed):
(MarkBugFixed.__init__):
* Scripts/webkitpy/tool/commands/upload_unittest.py:
(UploadCommandsTest):
(UploadCommandsTest.test_commit_message_for_current_diff):
* Scripts/webkitpy/tool/grammar_unittest.py:
(GrammarTest):
(GrammarTest.test_join_with_separators):
* Scripts/webkitpy/tool/multicommandtool.py:
(HelpCommand.__init__):
(HelpCommand):
(HelpCommand._help_epilog):
(HelpCommand._remove_help_options):
(MultiCommandTool):
(MultiCommandTool.__init__):
(MultiCommandTool.main):
* Scripts/webkitpy/tool/multicommandtool_unittest.py:
(TrivialCommand):
(TrivialCommand.__init__):
(MultiCommandToolTest):
(MultiCommandToolTest._assert_tool_main_outputs):
(MultiCommandToolTest.test_retry):
(test_command_help):
* Scripts/webkitpy/tool/steps/__init__.py:
* Scripts/webkitpy/tool/steps/abstractstep.py:
* Scripts/webkitpy/tool/steps/applypatch.py:
* Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
(ApplyPatchWithLocalCommit):
(ApplyPatchWithLocalCommit.options):
* Scripts/webkitpy/tool/steps/build.py:
* Scripts/webkitpy/tool/steps/checkstyle.py:
(CheckStyle):
(CheckStyle.options):
* Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
* Scripts/webkitpy/tool/steps/closebug.py:
* Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
* Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
(CloseBugForLandDiffTest):
(CloseBugForLandDiffTest.test_empty_state):
* Scripts/webkitpy/tool/steps/closepatch.py:
* Scripts/webkitpy/tool/steps/commit.py:
(Commit.run):
* Scripts/webkitpy/tool/steps/confirmdiff.py:
* Scripts/webkitpy/tool/steps/editchangelog.py:
* Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
* Scripts/webkitpy/tool/steps/metastep.py:
(MetaStep):
(MetaStep.__init__):
(MetaStep.run):
* Scripts/webkitpy/tool/steps/obsoletepatches.py:
* Scripts/webkitpy/tool/steps/options.py:
(Options):
* Scripts/webkitpy/tool/steps/postdiff.py:
* Scripts/webkitpy/tool/steps/postdiffforcommit.py:
* Scripts/webkitpy/tool/steps/postdiffforrevert.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
* Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
(PrepareChangeLogTest):
(PrepareChangeLogTest.test_resolve_existing_entry):
* Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
* Scripts/webkitpy/tool/steps/promptforbugortitle.py:
* Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
* Scripts/webkitpy/tool/steps/revertrevision.py:
* Scripts/webkitpy/tool/steps/runtests.py:
* Scripts/webkitpy/tool/steps/runtests_unittest.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:
(StepsTest):
(StepsTest._step_options):
* Scripts/webkitpy/tool/steps/update.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
(UpdateChangeLogsWithReviewerTest):
(UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
* 

[webkit-changes] [202070] trunk/Tools

[aakash_jain]

Title: [202070] trunk/Tools








Revision 202070
Author aakash_j...@apple.com
Date 2016-06-14 16:28:11 -0700 (Tue, 14 Jun 2016)


Log Message
Continuous "Reentrancy avoided" error messages in run-webkit-tests if Simulator quits unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=158756

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/xcode/simulator.py:
(Simulator.wait_until_device_is_booted): If checking Simulator boot state fails, verify if
the "simulator device" is still in booted state. Since we ensured that simulator device
was in booted state earlier in this method, this indicates that simulator device has shut down
unexpectedly.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/xcode/simulator.py




Diff

Modified: trunk/Tools/ChangeLog (202069 => 202070)

--- trunk/Tools/ChangeLog	2016-06-14 22:56:02 UTC (rev 202069)
+++ trunk/Tools/ChangeLog	2016-06-14 23:28:11 UTC (rev 202070)
@@ -1,3 +1,16 @@
+2016-06-14  Aakash Jain  
+
+Continuous "Reentrancy avoided" error messages in run-webkit-tests if Simulator quits unexpectedly
+https://bugs.webkit.org/show_bug.cgi?id=158756
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/xcode/simulator.py:
+(Simulator.wait_until_device_is_booted): If checking Simulator boot state fails, verify if
+the "simulator device" is still in booted state. Since we ensured that simulator device 
+was in booted state earlier in this method, this indicates that simulator device has shut down
+unexpectedly.
+
 2016-06-14  David Kilzer  
 
 Follow-up fix #2: REGRESSION (r202020): El Capitan CMake Debug build broken


Modified: trunk/Tools/Scripts/webkitpy/xcode/simulator.py (202069 => 202070)

--- trunk/Tools/Scripts/webkitpy/xcode/simulator.py	2016-06-14 22:56:02 UTC (rev 202069)
+++ trunk/Tools/Scripts/webkitpy/xcode/simulator.py	2016-06-14 23:28:11 UTC (rev 202070)
@@ -283,7 +283,9 @@
 if re.search("A[\s]+com.apple.springboard.services", state):
 return
 except subprocess.CalledProcessError:
-_log.warn("Error in checking Simulator boot status.")
+if Simulator.device_state(udid) != Simulator.DeviceState.BOOTED:
+raise RuntimeError('Simuator device quit unexpectedly.')
+_log.warn("Error in checking Simulator boot status. Will retry in 1 second.")
 time.sleep(1)
 
 @staticmethod






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202283] trunk/Tools

[aakash_jain]

Title: [202283] trunk/Tools








Revision 202283
Author aakash_j...@apple.com
Date 2016-06-21 11:26:53 -0700 (Tue, 21 Jun 2016)


Log Message
run-_javascript_core-tests should have flag to skip mozilla tests
https://bugs.webkit.org/show_bug.cgi?id=158963
rdar://problem/25838924

Reviewed by Alexey Proskuryakov.

* Scripts/run-_javascript_core-tests:
(runJSCStressTests): Added flag to skip mozilla tests.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests




Diff

Modified: trunk/Tools/ChangeLog (202282 => 202283)

--- trunk/Tools/ChangeLog	2016-06-21 18:15:48 UTC (rev 202282)
+++ trunk/Tools/ChangeLog	2016-06-21 18:26:53 UTC (rev 202283)
@@ -1,3 +1,14 @@
+2016-06-21  Aakash Jain  
+
+run-_javascript_core-tests should have flag to skip mozilla tests
+https://bugs.webkit.org/show_bug.cgi?id=158963
+rdar://problem/25838924
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/run-_javascript_core-tests:
+(runJSCStressTests): Added flag to skip mozilla tests.
+
 2016-06-20  Commit Queue  
 
 Unreviewed, rolling out r202136.


Modified: trunk/Tools/Scripts/run-_javascript_core-tests (202282 => 202283)

--- trunk/Tools/Scripts/run-_javascript_core-tests	2016-06-21 18:15:48 UTC (rev 202282)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2016-06-21 18:26:53 UTC (rev 202283)
@@ -59,6 +59,7 @@
 
 my $runJSCStress = 1;
 my $runJITStressTests = 1;
+my $runMozillaTests = 1;
 my $runQuickMode = 0;
 my $envVars = "";
 my $gmallocPath = undef;
@@ -77,6 +78,7 @@
 my $testapiDefault = $runTestAPI ? "will run" : "will not run";
 my $jscStressDefault = $runJSCStress ? "will run" : " will not run";
 my $jitStressTestsDefault = $runJITStressTests ? "will run" : " will not run";
+my $mozillaTestsDefault = $runMozillaTests ? "will run" : " will not run";
 my $quickModeDefault = $runQuickMode ? "some" : "all";
 my $failFastDefault = $failFast ? "fail fast" : "don't fail fast";
 my $filter;
@@ -89,6 +91,7 @@
   --[no-]testapiRun (or don't run) testapi (default: $testapiDefault)
   --[no-]jsc-stress Run (or don't run) the JSC stress tests (default: $jscStressDefault)
   --[no-]jit-stress-tests   Run (or don't run) the JIT stress tests (default: $jitStressTestsDefault)
+  --[no-]mozilla-tests  Run (or don't run) the Mozilla tests (default: $mozillaTestsDefault)
   --[no-]quick  Run some (or all) of the regular testing modes (default: $quickModeDefault)
 If the runner only runs some it will run the default and no-cjit-validate modes.
 Note, this will not change the behavior of tests that specify their own modes.
@@ -119,6 +122,7 @@
 'testapi!' => \$runTestAPI,
 'jsc-stress!' => \$runJSCStress,
 'jit-stress-tests!' => \$runJITStressTests,
+'mozilla-tests!' => \$runMozillaTests,
 'quick!' => \$runQuickMode,
 'fail-fast!' => \$failFast,
 'json-output=s' => \$jsonFileName,
@@ -240,7 +244,6 @@
 "PerformanceTests/SunSpider/no-architecture-specific-optimizations.yaml",
 "PerformanceTests/SunSpider/shadow-chicken.yaml",
 "PerformanceTests/SunSpider/tests/v8-v6",
-"Source/_javascript_Core/tests/mozilla/mozilla-tests.yaml",
 "Source/_javascript_Core/tests/stress",
 "LayoutTests/js/regress/script-tests",
 "PerformanceTests/SunSpider/profiler-test.yaml",
@@ -249,10 +252,11 @@
 "Source/_javascript_Core/tests/controlFlowProfiler.yaml",
 "Source/_javascript_Core/tests/es6.yaml",
 "Source/_javascript_Core/tests/modules.yaml");
-} else {
-@testList = ("Source/_javascript_Core/tests/mozilla/mozilla-tests.yaml");
 }
 
+if ($runMozillaTests) {
+push(@testList, "Source/_javascript_Core/tests/mozilla/mozilla-tests.yaml");
+}
 
 # Set LANG environment variable so the stress tests will work with newer ruby ()
 $ENV{LANG}="en_US.UTF-8";






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202107] trunk/Tools

[aakash_jain]

Title: [202107] trunk/Tools








Revision 202107
Author aakash_j...@apple.com
Date 2016-06-15 14:25:53 -0700 (Wed, 15 Jun 2016)


Log Message
Too much log data generated during layout-tests on iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=158751

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.developer_dir): memoized the property so that it is not called
repeatedly.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/ios.py




Diff

Modified: trunk/Tools/ChangeLog (202106 => 202107)

--- trunk/Tools/ChangeLog	2016-06-15 21:15:13 UTC (rev 202106)
+++ trunk/Tools/ChangeLog	2016-06-15 21:25:53 UTC (rev 202107)
@@ -1,3 +1,14 @@
+2016-06-15  Aakash Jain  
+
+Too much log data generated during layout-tests on iOS Simulator
+https://bugs.webkit.org/show_bug.cgi?id=158751
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/port/ios.py:
+(IOSSimulatorPort.developer_dir): memoized the property so that it is not called
+repeatedly.
+
 2016-06-15  Per Arne Vollan  
 
 [Win][CMake] Changes in WebKit options are not reflected in incremental builds.


Modified: trunk/Tools/Scripts/webkitpy/port/ios.py (202106 => 202107)

--- trunk/Tools/Scripts/webkitpy/port/ios.py	2016-06-15 21:15:13 UTC (rev 202106)
+++ trunk/Tools/Scripts/webkitpy/port/ios.py	2016-06-15 21:25:53 UTC (rev 202107)
@@ -469,6 +469,7 @@
 return fallback
 
 @property
+@memoized
 def developer_dir(self):
 return self._executive.run_command(['xcode-select', '--print-path']).rstrip()
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196212] trunk/Tools

[aakash_jain]

Title: [196212] trunk/Tools








Revision 196212
Author aakash_j...@apple.com
Date 2016-02-05 23:00:56 -0800 (Fri, 05 Feb 2016)


Log Message
tests fail if display sleeps while run-webkit-tests is running
https://bugs.webkit.org/show_bug.cgi?id=153919

Reviewed by Alexey Proskuryakov.

* DumpRenderTree/mac/LayoutTestHelper.m:
(addDisplaySleepAssertion): Add the assertion so that the display doesn't turn off.
(releaseDisplaySleepAssertion): Release the DisplaySleep Assertion.
(simpleSignalHandler): Release the DisplaySleepAssertion in case of any iterrupt.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m




Diff

Modified: trunk/Tools/ChangeLog (196211 => 196212)

--- trunk/Tools/ChangeLog	2016-02-06 06:21:37 UTC (rev 196211)
+++ trunk/Tools/ChangeLog	2016-02-06 07:00:56 UTC (rev 196212)
@@ -1,3 +1,15 @@
+2016-02-05  Aakash Jain  
+
+tests fail if display sleeps while run-webkit-tests is running
+https://bugs.webkit.org/show_bug.cgi?id=153919
+
+Reviewed by Alexey Proskuryakov.
+
+* DumpRenderTree/mac/LayoutTestHelper.m:
+(addDisplaySleepAssertion): Add the assertion so that the display doesn't turn off.
+(releaseDisplaySleepAssertion): Release the DisplaySleep Assertion.
+(simpleSignalHandler): Release the DisplaySleepAssertion in case of any iterrupt.
+
 2016-02-05  Alex Christensen  
 
 Fix iOS API tests after r196082


Modified: trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m (196211 => 196212)

--- trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m	2016-02-06 06:21:37 UTC (rev 196211)
+++ trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m	2016-02-06 07:00:56 UTC (rev 196212)
@@ -33,6 +33,7 @@
 
 #import 
 #import 
+#import 
 #import 
 #import 
 #import 
@@ -44,6 +45,7 @@
 // running layout tests.
 
 static int installColorProfile = false;
+static uint32_t assertionID = 0;
 
 static NSMutableDictionary *originalColorProfileURLs()
 {
@@ -191,10 +193,16 @@
 restoreDisplayColorProfiles(displays);
 }
 
+static void releaseDisplaySleepAssertion()
+{
+IOPMAssertionRelease(assertionID);
+}
+
 static void simpleSignalHandler(int sig)
 {
 // Try to restore the color profile and try to go down cleanly
 restoreUserColorProfile();
+releaseDisplaySleepAssertion();
 exit(128 + sig);
 }
 
@@ -230,6 +238,14 @@
 NSLog(@"IOObjectRelease() failed in %s with kernResult = %d", __FUNCTION__, kernResult);
 }
 
+void addDisplaySleepAssertion() 
+{
+CFStringRef assertionName = CFSTR("WebKit LayoutTestHelper");
+CFStringRef assertionDetails = CFSTR("WebKit layout-test helper tool is preventing sleep.");
+IOPMAssertionCreateWithDescription(kIOPMAssertionTypePreventUserIdleDisplaySleep,
+assertionName, assertionDetails, assertionDetails, NULL, 0, NULL, );
+}
+
 int main(int argc, char* argv[])
 {
 struct option options[] = {
@@ -251,6 +267,7 @@
 signal(SIGHUP, simpleSignalHandler);
 signal(SIGTERM, simpleSignalHandler);
 
+addDisplaySleepAssertion();
 lockDownDiscreteGraphics();
 
 // Save off the current profile, and then install the layout test profile.
@@ -265,6 +282,7 @@
 
 // Restore the profile
 restoreUserColorProfile();
+releaseDisplaySleepAssertion();
 
 return 0;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196360] trunk/Source/WebCore

[aakash_jain]

Title: [196360] trunk/Source/WebCore








Revision 196360
Author aakash_j...@apple.com
Date 2016-02-09 21:36:48 -0800 (Tue, 09 Feb 2016)


Log Message
Headers that use WEBCORE_EXPORT should include PlatformExportMacros.h
https://bugs.webkit.org/show_bug.cgi?id=146984

Reviewed by Alexey Proskuryakov.

* Modules/speech/SpeechSynthesis.h:
* contentextensions/ContentExtensionError.h:
* dom/DeviceOrientationClient.h:
* platform/graphics/Color.h:
* platform/ios/wak/WebCoreThread.h:
* platform/network/CacheValidation.h:
* platform/network/cf/CertificateInfo.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/speech/SpeechSynthesis.h
trunk/Source/WebCore/contentextensions/ContentExtensionError.h
trunk/Source/WebCore/dom/DeviceOrientationClient.h
trunk/Source/WebCore/platform/graphics/Color.h
trunk/Source/WebCore/platform/ios/wak/WebCoreThread.h
trunk/Source/WebCore/platform/network/CacheValidation.h
trunk/Source/WebCore/platform/network/cf/CertificateInfo.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (196359 => 196360)

--- trunk/Source/WebCore/ChangeLog	2016-02-10 04:52:29 UTC (rev 196359)
+++ trunk/Source/WebCore/ChangeLog	2016-02-10 05:36:48 UTC (rev 196360)
@@ -1,3 +1,18 @@
+2016-02-09  Aakash Jain  
+
+Headers that use WEBCORE_EXPORT should include PlatformExportMacros.h
+https://bugs.webkit.org/show_bug.cgi?id=146984
+
+Reviewed by Alexey Proskuryakov.
+
+* Modules/speech/SpeechSynthesis.h:
+* contentextensions/ContentExtensionError.h:
+* dom/DeviceOrientationClient.h:
+* platform/graphics/Color.h:
+* platform/ios/wak/WebCoreThread.h:
+* platform/network/CacheValidation.h:
+* platform/network/cf/CertificateInfo.h:
+
 2016-02-09  Nan Wang  
 
 AX: Implement word related text marker functions using TextIterator


Modified: trunk/Source/WebCore/Modules/speech/SpeechSynthesis.h (196359 => 196360)

--- trunk/Source/WebCore/Modules/speech/SpeechSynthesis.h	2016-02-10 04:52:29 UTC (rev 196359)
+++ trunk/Source/WebCore/Modules/speech/SpeechSynthesis.h	2016-02-10 05:36:48 UTC (rev 196360)
@@ -28,6 +28,7 @@
 
 #if ENABLE(SPEECH_SYNTHESIS)
 
+#include "PlatformExportMacros.h"
 #include "PlatformSpeechSynthesisUtterance.h"
 #include "PlatformSpeechSynthesizer.h"
 #include "SpeechSynthesisUtterance.h"


Modified: trunk/Source/WebCore/contentextensions/ContentExtensionError.h (196359 => 196360)

--- trunk/Source/WebCore/contentextensions/ContentExtensionError.h	2016-02-10 04:52:29 UTC (rev 196359)
+++ trunk/Source/WebCore/contentextensions/ContentExtensionError.h	2016-02-10 05:36:48 UTC (rev 196360)
@@ -28,6 +28,7 @@
 
 #if ENABLE(CONTENT_EXTENSIONS)
 
+#include "PlatformExportMacros.h"
 #include 
 
 namespace WebCore {


Modified: trunk/Source/WebCore/dom/DeviceOrientationClient.h (196359 => 196360)

--- trunk/Source/WebCore/dom/DeviceOrientationClient.h	2016-02-10 04:52:29 UTC (rev 196359)
+++ trunk/Source/WebCore/dom/DeviceOrientationClient.h	2016-02-10 05:36:48 UTC (rev 196360)
@@ -28,6 +28,7 @@
 #define DeviceOrientationClient_h
 
 #include "DeviceClient.h"
+#include "PlatformExportMacros.h"
 #include 
 
 namespace WebCore {


Modified: trunk/Source/WebCore/platform/graphics/Color.h (196359 => 196360)

--- trunk/Source/WebCore/platform/graphics/Color.h	2016-02-10 04:52:29 UTC (rev 196359)
+++ trunk/Source/WebCore/platform/graphics/Color.h	2016-02-10 05:36:48 UTC (rev 196360)
@@ -27,6 +27,7 @@
 #define Color_h
 
 #include "ColorSpace.h"
+#include "PlatformExportMacros.h"
 #include 
 #include 
 #include 


Modified: trunk/Source/WebCore/platform/ios/wak/WebCoreThread.h (196359 => 196360)

--- trunk/Source/WebCore/platform/ios/wak/WebCoreThread.h	2016-02-10 04:52:29 UTC (rev 196359)
+++ trunk/Source/WebCore/platform/ios/wak/WebCoreThread.h	2016-02-10 05:36:48 UTC (rev 196360)
@@ -30,6 +30,11 @@
 
 #import 
 
+// Use __has_include here so that things work when rewritten into WebKitLegacy headers.
+#if __has_include()
+#import 
+#endif
+
 #if defined(__cplusplus)
 extern "C" {
 #endif


Modified: trunk/Source/WebCore/platform/network/CacheValidation.h (196359 => 196360)

--- trunk/Source/WebCore/platform/network/CacheValidation.h	2016-02-10 04:52:29 UTC (rev 196359)
+++ trunk/Source/WebCore/platform/network/CacheValidation.h	2016-02-10 05:36:48 UTC (rev 196360)
@@ -26,6 +26,7 @@
 #ifndef CacheValidation_h
 #define CacheValidation_h
 
+#include "PlatformExportMacros.h"
 #include 
 
 namespace WebCore {


Modified: trunk/Source/WebCore/platform/network/cf/CertificateInfo.h (196359 => 196360)

--- trunk/Source/WebCore/platform/network/cf/CertificateInfo.h	2016-02-10 04:52:29 UTC (rev 196359)
+++ trunk/Source/WebCore/platform/network/cf/CertificateInfo.h	2016-02-10 05:36:48 UTC (rev 196360)
@@ -26,6 +26,7 @@
 #ifndef CertificateInfo_h
 #define CertificateInfo_h
 
+#include "PlatformExportMacros.h"
 #include 
 
 namespace WebCore {

[webkit-changes] [196106] trunk/Tools

[aakash_jain]

Title: [196106] trunk/Tools








Revision 196106
Author aakash_j...@apple.com
Date 2016-02-03 21:16:16 -0800 (Wed, 03 Feb 2016)


Log Message
Logs/CoreSimulator filling up OS disk on WebKit testers
https://bugs.webkit.org/show_bug.cgi?id=153853


Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.clean_up_test_run): Delete Logs during cleanup.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/ios.py




Diff

Modified: trunk/Tools/ChangeLog (196105 => 196106)

--- trunk/Tools/ChangeLog	2016-02-04 03:36:32 UTC (rev 196105)
+++ trunk/Tools/ChangeLog	2016-02-04 05:16:16 UTC (rev 196106)
@@ -1,3 +1,14 @@
+2016-02-03  Aakash Jain  
+
+Logs/CoreSimulator filling up OS disk on WebKit testers
+https://bugs.webkit.org/show_bug.cgi?id=153853
+
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/port/ios.py:
+(IOSSimulatorPort.clean_up_test_run): Delete Logs during cleanup.
+
 2016-02-03  Brian Burg  
 
 git-add-reviewer should work when run from a subdirectory within the repository


Modified: trunk/Tools/Scripts/webkitpy/port/ios.py (196105 => 196106)

--- trunk/Tools/Scripts/webkitpy/port/ios.py	2016-02-04 03:36:32 UTC (rev 196105)
+++ trunk/Tools/Scripts/webkitpy/port/ios.py	2016-02-04 05:16:16 UTC (rev 196106)
@@ -257,6 +257,8 @@
 try:
 subprocess.call([self.LSREGISTER_PATH, "-v", "-u", self.get_simulator_path(i)])
 shutil.rmtree(self.get_simulator_path(i), ignore_errors=True)
+shutil.rmtree(os.path.join(os.path.expanduser("~"), "Library/Logs/CoreSimulator/",
+self.testing_device(i).udid), ignore_errors=True)
 Simulator().delete_device(self.testing_device(i).udid)
 except:
 _log.warning('Unable to remove Simulator' + str(i))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [195557] trunk/Tools

[aakash_jain]

Title: [195557] trunk/Tools








Revision 195557
Author aakash_j...@apple.com
Date 2016-01-25 14:37:49 -0800 (Mon, 25 Jan 2016)


Log Message
Failing to upload to flakiness dashboard should not be a hard error
https://bugs.webkit.org/show_bug.cgi?id=153444


Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._upload_json_files): If JSON file is not generated, do not try to upload it.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py




Diff

Modified: trunk/Tools/ChangeLog (195556 => 195557)

--- trunk/Tools/ChangeLog	2016-01-25 22:35:02 UTC (rev 195556)
+++ trunk/Tools/ChangeLog	2016-01-25 22:37:49 UTC (rev 195557)
@@ -1,3 +1,14 @@
+2016-01-25  Aakash Jain  
+
+Failing to upload to flakiness dashboard should not be a hard error
+https://bugs.webkit.org/show_bug.cgi?id=153444
+
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/layout_tests/controllers/manager.py:
+(Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
+
 2016-01-25  Daniel Bates  
 
 WebKitTestRunner: Credential cache is not cleared between tests


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (195556 => 195557)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py	2016-01-25 22:35:02 UTC (rev 195556)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py	2016-01-25 22:37:49 UTC (rev 195557)
@@ -381,6 +381,7 @@
 _log.debug("Finished writing JSON file for the test results server.")
 else:
 _log.debug("Failed to generate JSON file for the test results server.")
+return
 
 json_files = ["incremental_results.json", "full_results.json", "times_ms.json"]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [197830] trunk/Tools

[aakash_jain]

Title: [197830] trunk/Tools








Revision 197830
Author aakash_j...@apple.com
Date 2016-03-08 18:50:22 -0800 (Tue, 08 Mar 2016)


Log Message
Booting multiple iOS simulator parallely fails sometimes
https://bugs.webkit.org/show_bug.cgi?id=155208


Reviewed by Darin Adler.

* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.setup_test_run): Increase the time delay between subsequent
simulator boot.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/ios.py




Diff

Modified: trunk/Tools/ChangeLog (197829 => 197830)

--- trunk/Tools/ChangeLog	2016-03-09 02:27:18 UTC (rev 197829)
+++ trunk/Tools/ChangeLog	2016-03-09 02:50:22 UTC (rev 197830)
@@ -1,3 +1,15 @@
+2016-03-08  Aakash Jain  
+
+Booting multiple iOS simulator parallely fails sometimes
+https://bugs.webkit.org/show_bug.cgi?id=155208
+
+
+Reviewed by Darin Adler.
+
+* Scripts/webkitpy/port/ios.py:
+(IOSSimulatorPort.setup_test_run): Increase the time delay between subsequent
+simulator boot.
+
 2016-03-08  Alexey Proskuryakov  
 
 Add iOS debug testers to flakiness dashboard


Modified: trunk/Tools/Scripts/webkitpy/port/ios.py (197829 => 197830)

--- trunk/Tools/Scripts/webkitpy/port/ios.py	2016-03-09 02:27:18 UTC (rev 197829)
+++ trunk/Tools/Scripts/webkitpy/port/ios.py	2016-03-09 02:50:22 UTC (rev 197830)
@@ -232,7 +232,7 @@
 '--args', '-CurrentDeviceUDID', device_udid])
 
 if mac_os_version in ['elcapitan', 'yosemite', 'mavericks']:
-time.sleep(1)
+time.sleep(2)
 
 _log.info('Waiting for all iOS Simulators to finish booting.')
 for i in xrange(self.child_processes()):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [197891] trunk/Tools

[aakash_jain]

Title: [197891] trunk/Tools








Revision 197891
Author aakash_j...@apple.com
Date 2016-03-09 15:07:49 -0800 (Wed, 09 Mar 2016)


Log Message
use ulimit command to check process limit in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=155260

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.default_child_processes): Use ulimit command output instead of
launchctl limit maxproc command.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/ios.py




Diff

Modified: trunk/Tools/ChangeLog (197890 => 197891)

--- trunk/Tools/ChangeLog	2016-03-09 23:02:57 UTC (rev 197890)
+++ trunk/Tools/ChangeLog	2016-03-09 23:07:49 UTC (rev 197891)
@@ -1,3 +1,14 @@
+2016-03-09  Aakash Jain  
+
+use ulimit command to check process limit in webkitpy
+https://bugs.webkit.org/show_bug.cgi?id=155260
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/port/ios.py:
+(IOSSimulatorPort.default_child_processes): Use ulimit command output instead of 
+launchctl limit maxproc command.
+
 2016-03-09  Alexey Proskuryakov  
 
 Stop building armv7 on iOS device builders


Modified: trunk/Tools/Scripts/webkitpy/port/ios.py (197890 => 197891)

--- trunk/Tools/Scripts/webkitpy/port/ios.py	2016-03-09 23:02:57 UTC (rev 197890)
+++ trunk/Tools/Scripts/webkitpy/port/ios.py	2016-03-09 23:07:49 UTC (rev 197891)
@@ -136,7 +136,7 @@
 def default_child_processes(self):
 """Return the number of Simulators instances to use for this port."""
 best_child_process_count_for_cpu = self._executive.cpu_count() / 2
-system_process_count_limit = int(subprocess.check_output(["launchctl", "limit", "maxproc"]).strip().split()[1])
+system_process_count_limit = int(subprocess.check_output(["ulimit", "-u"]).strip())
 current_process_count = len(subprocess.check_output(["ps", "aux"]).strip().split('\n'))
 _log.info('Process limit: %d, current #processes: %d' % (system_process_count_limit, current_process_count))
 maximum_simulator_count_on_this_system = (system_process_count_limit - current_process_count) // self.PROCESS_COUNT_ESTIMATE_PER_SIMULATOR_INSTANCE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [197704] trunk/Tools

[aakash_jain]

Title: [197704] trunk/Tools








Revision 197704
Author aakash_j...@apple.com
Date 2016-03-07 13:40:38 -0800 (Mon, 07 Mar 2016)


Log Message
webkitpy should verify timestamp from CrashLogs while collecting all crash logs
https://bugs.webkit.org/show_bug.cgi?id=155000


Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs._find_all_logs_darwin): Make sure that crash log timestamp is within expected
time range, because file modification time is not always accurate.
(CrashLogs.get_timestamp_from_logs): Parse the timestamp from logs.
* Scripts/webkitpy/common/system/crashlogs_unittest.py:
(CrashLogsTest.test_get_timestamp_from_logs_darwin): Testcase for above function.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py
trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (197703 => 197704)

--- trunk/Tools/ChangeLog	2016-03-07 21:39:32 UTC (rev 197703)
+++ trunk/Tools/ChangeLog	2016-03-07 21:40:38 UTC (rev 197704)
@@ -1,3 +1,18 @@
+2016-03-07  Aakash Jain  
+
+webkitpy should verify timestamp from CrashLogs while collecting all crash logs
+https://bugs.webkit.org/show_bug.cgi?id=155000
+
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/common/system/crashlogs.py:
+(CrashLogs._find_all_logs_darwin): Make sure that crash log timestamp is within expected 
+time range, because file modification time is not always accurate.
+(CrashLogs.get_timestamp_from_logs): Parse the timestamp from logs.
+* Scripts/webkitpy/common/system/crashlogs_unittest.py:
+(CrashLogsTest.test_get_timestamp_from_logs_darwin): Testcase for above function.
+
 2016-03-06  Alexey Proskuryakov  
 
 build-webkit prints an error on iOS simulator bots


Modified: trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py (197703 => 197704)

--- trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py	2016-03-07 21:39:32 UTC (rev 197703)
+++ trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py	2016-03-07 21:40:38 UTC (rev 197704)
@@ -29,6 +29,7 @@
 
 import codecs
 import re
+import datetime
 
 
 class CrashLogs(object):
@@ -139,6 +140,13 @@
 result_name = "Unknown"
 pid = 0
 log_contents = self._host.filesystem.read_text_file(path)
+# Verify timestamp from log contents
+crash_time = self.get_timestamp_from_log(log_contents)
+if crash_time is not None and newer_than is not None:
+start_time = datetime.datetime.fromtimestamp(float(newer_than))
+if crash_time < start_time:
+continue
+
 match = first_line_regex.match(log_contents[0:log_contents.find('\n')])
 if match:
 process_name = match.group('process_name')
@@ -158,3 +166,14 @@
 if include_errors and errors and len(crash_logs) == 0:
 return errors
 return crash_logs
+
+def get_timestamp_from_log(self, log_contents):
+date_match = re.search('Date/Time:\s+(.+?)\n', log_contents)
+if not date_match:
+return None
+try:
+crash_time_str = ' '.join(date_match.group(1).split(" ")[0:2])
+crash_time = datetime.datetime.strptime(crash_time_str, '%Y-%m-%d %H:%M:%S.%f')
+except ValueError:
+return None
+return crash_time


Modified: trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py (197703 => 197704)

--- trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py	2016-03-07 21:39:32 UTC (rev 197703)
+++ trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py	2016-03-07 21:40:38 UTC (rev 197704)
@@ -336,3 +336,16 @@
 filesystem.read_binary_file = bad_read
 log = crash_logs.find_newest_log("DumpRenderTree", 28531, include_errors=True)
 self.assertIn('IOError: No such file or directory', log)
+
+def test_get_timestamp_from_logs_darwin(self):
+if not SystemHost().platform.is_mac():
+return
+
+crash_report = make_mock_crash_report_darwin('DumpRenderTree', 28528)
+crash_logs = CrashLogs(MockSystemHost())
+crash_timestamp = crash_logs.get_timestamp_from_log(crash_report)
+self.assertIn('2011-12-07 13:27:34.816', str(crash_timestamp))
+
+crash_report = crash_report.replace("Date/Time", "")
+crash_timestamp = crash_logs.get_timestamp_from_log(crash_report)
+self.assertIsNone(crash_timestamp)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201370] trunk/Tools

[aakash_jain]

Title: [201370] trunk/Tools








Revision 201370
Author aakash_j...@apple.com
Date 2016-05-24 18:21:45 -0700 (Tue, 24 May 2016)


Log Message
Reorganize dashboard code: move code from _timeIntervalString to base class
https://bugs.webkit.org/show_bug.cgi?id=158047
rdar://problem/26457274

Reviewed by Alexey Proskuryakov and Dean Johnson.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
(BubbleQueueView.prototype._timeIntervalString): Moved core logic to base class so as to make it re-usable.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
(QueueView.prototype._readableTimeString): Same.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js (201369 => 201370)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js	2016-05-25 00:55:13 UTC (rev 201369)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js	2016-05-25 01:21:45 UTC (rev 201370)
@@ -97,20 +97,8 @@
 
 _timeIntervalString: function(time)
 {
-var secondsInHour = 60 * 60;
 var timeDifference = (Date.now() - time.getTime()) / 1000;
-var hours = Math.floor(timeDifference / secondsInHour);
-var minutes = Math.floor((timeDifference - hours * secondsInHour) / 60);
-var hoursPart = "";
-if (hours === 1)
-hoursPart = "1\xa0hour and ";
-else if (hours > 0)
-hoursPart = hours + "\xa0hours and ";
-if (!minutes)
-return "less than a minute";
-if (minutes === 1)
-return hoursPart + "1\xa0minute";
-return hoursPart + minutes + "\xa0minutes";
+return this._readableTimeString(timeDifference)
 },
 
 _popoverContentForBubbleQueue: function(queue)


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js (201369 => 201370)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js	2016-05-25 00:55:13 UTC (rev 201369)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js	2016-05-25 01:21:45 UTC (rev 201370)
@@ -227,5 +227,22 @@
 return "r" + revision;
 // Truncating for display. Git traditionally uses seven characters for a short hash.
 return revision.substr(0, 7);
+},
+
+_readableTimeString: function(seconds)
+{
+var secondsInHour = 60 * 60;
+var hours = Math.floor(seconds / secondsInHour);
+var minutes = Math.floor((seconds - hours * secondsInHour) / 60);
+var hoursPart = "";
+if (hours === 1)
+hoursPart = "1\xa0hour and ";
+else if (hours > 0)
+hoursPart = hours + "\xa0hours and ";
+if (!minutes)
+return "less than a minute";
+if (minutes === 1)
+return hoursPart + "1\xa0minute";
+return hoursPart + minutes + "\xa0minutes";
 }
 };


Modified: trunk/Tools/ChangeLog (201369 => 201370)

--- trunk/Tools/ChangeLog	2016-05-25 00:55:13 UTC (rev 201369)
+++ trunk/Tools/ChangeLog	2016-05-25 01:21:45 UTC (rev 201370)
@@ -1,3 +1,16 @@
+2016-05-24  Aakash Jain  
+
+Reorganize dashboard code: move code from _timeIntervalString to base class
+https://bugs.webkit.org/show_bug.cgi?id=158047
+rdar://problem/26457274
+
+Reviewed by Alexey Proskuryakov and Dean Johnson.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
+(BubbleQueueView.prototype._timeIntervalString): Moved core logic to base class so as to make it re-usable.
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
+(QueueView.prototype._readableTimeString): Same.
+
 2016-05-24  Yusuke Suzuki  
 
 [JSC][GTK][EFL] Allow run-jsc-benchmark to use WebKitTestRunner in EFL / GTK ports






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201117] trunk/Tools

[aakash_jain]

Title: [201117] trunk/Tools








Revision 201117
Author aakash_j...@apple.com
Date 2016-05-18 16:55:25 -0700 (Wed, 18 May 2016)


Log Message
Remove underline from Status Bubbles on dashboard
https://bugs.webkit.org/show_bug.cgi?id=157870
rdar://problem/26332321

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Reverted style
change made in http://trac.webkit.org/r200880

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css (201116 => 201117)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css	2016-05-18 23:49:50 UTC (rev 201116)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css	2016-05-18 23:55:25 UTC (rev 201117)
@@ -38,7 +38,7 @@
 text-decoration: none;
 }
 
-a:hover:link {
+a:hover {
 text-decoration: underline;
 }
 


Modified: trunk/Tools/ChangeLog (201116 => 201117)

--- trunk/Tools/ChangeLog	2016-05-18 23:49:50 UTC (rev 201116)
+++ trunk/Tools/ChangeLog	2016-05-18 23:55:25 UTC (rev 201117)
@@ -1,3 +1,14 @@
+2016-05-18  Aakash Jain  
+
+Remove underline from Status Bubbles on dashboard
+https://bugs.webkit.org/show_bug.cgi?id=157870
+rdar://problem/26332321
+
+Reviewed by Alexey Proskuryakov.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Reverted style 
+change made in http://trac.webkit.org/r200880
+
 2016-05-18  Michael Saboff  
 
 r199812 broke test262






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201244] trunk/Tools

[aakash_jain]

Title: [201244] trunk/Tools








Revision 201244
Author aakash_j...@apple.com
Date 2016-05-21 12:21:31 -0700 (Sat, 21 May 2016)


Log Message
Simulator launch fails intermittently due to failure in checking simulator boot status
https://bugs.webkit.org/show_bug.cgi?id=157965
rdar://problem/26402404

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/xcode/simulator.py:
(Simulator.wait_until_device_is_booted): Ignore CalledProcessError exception while checking
whether simulator has finished booting.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/xcode/simulator.py




Diff

Modified: trunk/Tools/ChangeLog (201243 => 201244)

--- trunk/Tools/ChangeLog	2016-05-21 18:42:21 UTC (rev 201243)
+++ trunk/Tools/ChangeLog	2016-05-21 19:21:31 UTC (rev 201244)
@@ -1,3 +1,15 @@
+2016-05-21  Aakash Jain  
+
+Simulator launch fails intermittently due to failure in checking simulator boot status
+https://bugs.webkit.org/show_bug.cgi?id=157965
+rdar://problem/26402404
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/xcode/simulator.py:
+(Simulator.wait_until_device_is_booted): Ignore CalledProcessError exception while checking
+whether simulator has finished booting.
+
 2016-05-21  Dan Bernstein  
 
 Silence warnings from svn propget when using newer versions of Subversion.


Modified: trunk/Tools/Scripts/webkitpy/xcode/simulator.py (201243 => 201244)

--- trunk/Tools/Scripts/webkitpy/xcode/simulator.py	2016-05-21 18:42:21 UTC (rev 201243)
+++ trunk/Tools/Scripts/webkitpy/xcode/simulator.py	2016-05-21 19:21:31 UTC (rev 201244)
@@ -278,9 +278,12 @@
 Simulator.wait_until_device_is_in_state(udid, Simulator.DeviceState.BOOTED, timeout_seconds)
 with timeout(seconds=timeout_seconds):
 while True:
-state = subprocess.check_output(['xcrun', 'simctl', 'spawn', udid, 'launchctl', 'print', 'system']).strip()
-if re.search("A[\s]+com.apple.springboard.services", state):
-return
+try:
+state = subprocess.check_output(['xcrun', 'simctl', 'spawn', udid, 'launchctl', 'print', 'system']).strip()
+if re.search("A[\s]+com.apple.springboard.services", state):
+return
+except subprocess.CalledProcessError:
+_log.warn("Error in checking Simulator boot status.")
 time.sleep(1)
 
 @staticmethod






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [200880] trunk/Tools

[aakash_jain]

Title: [200880] trunk/Tools








Revision 200880
Author aakash_j...@apple.com
Date 2016-05-13 13:35:58 -0700 (Fri, 13 May 2016)


Log Message
Dashboard code restructuring
https://bugs.webkit.org/show_bug.cgi?id=157680


Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
(BubbleQueueView.prototype.addLinkToRow): Moved to base class.
(BubbleQueueView.prototype.addTextToRow): Moved to base class.
(BubbleQueueView.prototype._addDividerToPopover): Moved to base class.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
(BuildbotCombinedQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._appendPendingRevisionCount): Moved to base class and modified to take
additional argument.
(BuildbotQueueView.prototype._popoverLinesForCommitRange): Moved to base class.
(BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved to base class.
(BuildbotQueueView.prototype._addDividerToPopover): Moved to base class.
(BuildbotQueueView.prototype._formatRevisionForDisplay): Moved to base class.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(documentReady): Display any customView if available.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
(QueueView.prototype.addLinkToRow): Moved from child class, no changes.
(QueueView.prototype.addTextToRow): Moved from child class, no changes.
(QueueView.prototype._addDividerToPopover): Moved from child class, no changes.
(QueueView.prototype._appendPendingRevisionCount): Moved from child class, made it more generic
by taking latestIterationGetter method as an argument.
(QueueView.prototype._popoverLinesForCommitRange): Moved from child class, no changes.
(QueueView.prototype._presentPopoverForPendingCommits): Moved from child class, no changes.
(QueueView.prototype._formatRevisionForDisplay): Moved from child class, no changes.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(a:hover:link): Underline only when there is a link.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js (200879 => 200880)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js	2016-05-13 20:16:29 UTC (rev 200879)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js	2016-05-13 20:35:58 UTC (rev 200880)
@@ -75,24 +75,6 @@
 }, this);
 },
 
-addLinkToRow: function(rowElement, className, text, url)
-{
-var linkElement = document.createElement("a");
-linkElement.className = className;
-linkElement.textContent = text;
-linkElement.href = ""
-linkElement.target = "_blank";
-rowElement.appendChild(linkElement);
-},
-
-addTextToRow: function(rowElement, className, text)
-{
-var spanElement = document.createElement("span");
-spanElement.className = className;
-spanElement.textContent = text;
-rowElement.appendChild(spanElement);
-},
-
 _addQueueHeadingToPopover: function(queue, content)
 {
 var title = document.createElement("div");
@@ -113,13 +95,6 @@
 content.appendChild(title);
 },
 
-_addDividerToPopover: function(content)
-{
-var divider = document.createElement("div");
-divider.className = "divider";
-

[webkit-changes] [203830] trunk/Tools

[aakash_jain]

Title: [203830] trunk/Tools








Revision 203830
Author aakash_j...@apple.com
Date 2016-07-28 13:12:31 -0700 (Thu, 28 Jul 2016)


Log Message
EWS error message "Error: * did not process patch" should include explanation
https://bugs.webkit.org/show_bug.cgi?id=159903


Reviewed by Alexey Proskuryakov.

* QueueStatusServer/handlers/statusbubble.py:
(StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
is not processed.
* QueueStatusServer/handlers/processingtimesjson.py:
(ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
of the code.
* Scripts/webkitpy/tool/bot/commitqueuetask.py:
(CommitQueueTask.validate): Add more information about validation failure.
(CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
* Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
(EarlyWarningSystemTask.validate): Add more information about validation failure.
(EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
* Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchIsNotValid.__init__): Add the failure_message argument.
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
failure details.
* Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue.process_work_item): Same.
(StyleQueue.review_patch): Same.
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(test_non_valid_patch): Updated test-cases messages to match the above changes.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/QueueStatusServer/handlers/processingtimesjson.py
trunk/Tools/QueueStatusServer/handlers/statusbubble.py
trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py
trunk/Tools/Scripts/webkitpy/tool/bot/earlywarningsystemtask.py
trunk/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py
trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py
trunk/Tools/Scripts/webkitpy/tool/commands/queues.py
trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (203829 => 203830)

--- trunk/Tools/ChangeLog	2016-07-28 19:53:32 UTC (rev 203829)
+++ trunk/Tools/ChangeLog	2016-07-28 20:12:31 UTC (rev 203830)
@@ -1,3 +1,34 @@
+2016-07-28  Aakash Jain  
+
+EWS error message "Error: * did not process patch" should include explanation
+https://bugs.webkit.org/show_bug.cgi?id=159903
+
+
+Reviewed by Alexey Proskuryakov.
+
+* QueueStatusServer/handlers/statusbubble.py:
+(StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
+is not processed.
+* QueueStatusServer/handlers/processingtimesjson.py:
+(ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
+of the code.
+* Scripts/webkitpy/tool/bot/commitqueuetask.py:
+(CommitQueueTask.validate): Add more information about validation failure.
+(CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
+* Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
+(EarlyWarningSystemTask.validate): Add more information about validation failure.
+(EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
+* Scripts/webkitpy/tool/bot/patchanalysistask.py:
+(PatchIsNotValid.__init__): Add the failure_message argument.
+* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+(AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
+failure details.
+* Scripts/webkitpy/tool/commands/queues.py:
+(CommitQueue.process_work_item): Same.
+(StyleQueue.review_patch): Same.
+* Scripts/webkitpy/tool/commands/queues_unittest.py:
+(test_non_valid_patch): Updated test-cases messages to match the above changes.
+
 2016-07-27  Alexey Proskuryakov  
 
 LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete


Modified: trunk/Tools/QueueStatusServer/handlers/processingtimesjson.py (203829 => 203830)

--- trunk/Tools/QueueStatusServer/handlers/processingtimesjson.py	2016-07-28 19:53:32 UTC (rev 203829)
+++ trunk/Tools/QueueStatusServer/handlers/processingtimesjson.py	2016-07-28 20:12:31 UTC (rev 203830)
@@ -40,7 +40,7 @@
 return "pass"
 elif status_message == "Fail":
 return "fail"
-elif status_message == "Error: " + queue_name + " did not process patch.":
+elif "did not process patch" in status_message:
 return "not processed"
 elif status_message == "Error: " + queue_name + " unable to apply patch.":
 return "could not apply"


Modified: trunk/Tools/QueueStatusServer/handlers/statusbubble.py (203829 => 203830)

--- trunk/Tools/QueueStatusServer/handlers/statusbubble.py	2016-07-28 19:53:32 UTC (rev 

[webkit-changes] [204382] trunk/Tools

[aakash_jain]

Title: [204382] trunk/Tools








Revision 204382
Author aakash_j...@apple.com
Date 2016-08-11 12:45:13 -0700 (Thu, 11 Aug 2016)


Log Message
EWS should check if the patch is still valid before executing every major step
https://bugs.webkit.org/show_bug.cgi?id=160739
rdar://problem/27768813

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/tool/bot/commitqueuetask.py:
(CommitQueueTask.run): validate method is now executed in base class.
* Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
(EarlyWarningSystemTask.run): validate method is now executed in base class.
* Scripts/webkitpy/tool/bot/stylequeuetask.py:
(StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
* Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
* Scripts/webkitpy/tool/commands/perfalizer.py:
(PerfalizerTask.validate): Added.
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(test_manual_reject_during_processing): Updated test case.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py
trunk/Tools/Scripts/webkitpy/tool/bot/earlywarningsystemtask.py
trunk/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py
trunk/Tools/Scripts/webkitpy/tool/bot/stylequeuetask.py
trunk/Tools/Scripts/webkitpy/tool/commands/perfalizer.py
trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (204381 => 204382)

--- trunk/Tools/ChangeLog	2016-08-11 19:22:26 UTC (rev 204381)
+++ trunk/Tools/ChangeLog	2016-08-11 19:45:13 UTC (rev 204382)
@@ -1,3 +1,25 @@
+2016-08-11  Aakash Jain  
+
+EWS should check if the patch is still valid before executing every major step
+https://bugs.webkit.org/show_bug.cgi?id=160739
+rdar://problem/27768813
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/tool/bot/commitqueuetask.py:
+(CommitQueueTask.run): validate method is now executed in base class.
+* Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
+(EarlyWarningSystemTask.run): validate method is now executed in base class.
+* Scripts/webkitpy/tool/bot/stylequeuetask.py:
+(StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
+* Scripts/webkitpy/tool/bot/patchanalysistask.py:
+(PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
+that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
+* Scripts/webkitpy/tool/commands/perfalizer.py:
+(PerfalizerTask.validate): Added.
+* Scripts/webkitpy/tool/commands/queues_unittest.py:
+(test_manual_reject_during_processing): Updated test case.
+
 2016-08-11  Alex Christensen  
 
 Add URLParser stub


Modified: trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py (204381 => 204382)

--- trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py	2016-08-11 19:22:26 UTC (rev 204381)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py	2016-08-11 19:45:13 UTC (rev 204382)
@@ -72,8 +72,6 @@
 return self._test_patch()
 
 def run(self):
-if not self.validate():
-raise PatchIsNotValid(self._patch, self.error)
 if not self._clean():
 return False
 if not self._update():
@@ -89,10 +87,6 @@
 return self.report_failure()
 if not self._did_pass_tests_recently():
 return False
-# Make sure the patch is still valid before landing (e.g., make sure
-# no one has set commit-queue- since we started working on the patch.)
-if not self.validate():
-raise PatchIsNotValid(self._patch, self.error)
 # FIXME: We should understand why the land failure occurred and retry if possible.
 if not self._land():
 return self.report_failure()


Modified: trunk/Tools/Scripts/webkitpy/tool/bot/earlywarningsystemtask.py (204381 => 204382)

--- trunk/Tools/Scripts/webkitpy/tool/bot/earlywarningsystemtask.py	2016-08-11 19:22:26 UTC (rev 204381)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/earlywarningsystemtask.py	2016-08-11 19:45:13 UTC (rev 204382)
@@ -52,8 +52,6 @@
 return True
 
 def run(self):
-if not self.validate():
-raise PatchIsNotValid(self._patch, self.error)
 if not self._clean():
 return False
 if not self._update():


Modified: trunk/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py (204381 => 204382)

--- trunk/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py	2016-08-11 19:22:26 UTC (rev 204381)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py	2016-08-11 19:45:13 UTC (rev 204382)
@@ 

[webkit-changes] [204389] trunk/Tools

[aakash_jain]

Title: [204389] trunk/Tools








Revision 204389
Author aakash_j...@apple.com
Date 2016-08-11 14:25:08 -0700 (Thu, 11 Aug 2016)


Log Message
Keep EWS logs for longer
https://bugs.webkit.org/show_bug.cgi?id=160776

Reviewed by Daniel Bates.

* EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/EWSTools/start-queue-mac.sh




Diff

Modified: trunk/Tools/ChangeLog (204388 => 204389)

--- trunk/Tools/ChangeLog	2016-08-11 21:21:55 UTC (rev 204388)
+++ trunk/Tools/ChangeLog	2016-08-11 21:25:08 UTC (rev 204389)
@@ -1,3 +1,12 @@
+2016-08-11  Aakash Jain  
+
+Keep EWS logs for longer
+https://bugs.webkit.org/show_bug.cgi?id=160776
+
+Reviewed by Daniel Bates.
+
+* EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
+
 2016-08-11  Simon Fraser  
 
 iOS DRT/WTR project cleanup


Modified: trunk/Tools/EWSTools/start-queue-mac.sh (204388 => 204389)

--- trunk/Tools/EWSTools/start-queue-mac.sh	2016-08-11 21:21:55 UTC (rev 204388)
+++ trunk/Tools/EWSTools/start-queue-mac.sh	2016-08-11 21:25:08 UTC (rev 204389)
@@ -51,9 +51,9 @@
 TIME_TO_REBOOT=$(( $(date +%s) + 3600 * 12))
 
 while [ $TIME_TO_REBOOT -gt $(date +%s) ] || [ $(date +%H) -lt 1 ] || [ $(date +%H) -ge 6 ]; do
-# Delete log files older than 14 days, move aside the main $QUEUE_NAME-ews.log file to prevent it from growing extra large.
+# Delete log files older than 30 days, move aside the main $QUEUE_NAME-ews.log file to prevent it from growing extra large.
 cd $EWS_HOME/$QUEUE_NAME-logs
-find . -mtime +14 -delete
+find . -mtime +30 -delete
 if [ -s $QUEUE_NAME.log ]; then
 mv -f $QUEUE_NAME.log ${QUEUE_NAME}_$(date +%Y-%m-%d_%H-%m).log
 fi






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [203479] trunk/Tools

[aakash_jain]

Title: [203479] trunk/Tools








Revision 203479
Author aakash_j...@apple.com
Date 2016-07-20 16:28:22 -0700 (Wed, 20 Jul 2016)


Log Message
REGRESSION(r148588): ews classes might get garbage collected
https://bugs.webkit.org/show_bug.cgi?id=159990

Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
in a variable so that they do not get garbage collected.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/commands/__init__.py




Diff

Modified: trunk/Tools/ChangeLog (203478 => 203479)

--- trunk/Tools/ChangeLog	2016-07-20 23:24:15 UTC (rev 203478)
+++ trunk/Tools/ChangeLog	2016-07-20 23:28:22 UTC (rev 203479)
@@ -1,3 +1,13 @@
+2016-07-20  Aakash Jain  
+
+REGRESSION(r148588): ews classes might get garbage collected
+https://bugs.webkit.org/show_bug.cgi?id=159990
+
+Reviewed by Ryosuke Niwa.
+
+* Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
+in a variable so that they do not get garbage collected.
+
 2016-07-20  Jeremy Jones  
 
 Add API test for layout constraints after exit fullscreen


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/__init__.py (203478 => 203479)

--- trunk/Tools/Scripts/webkitpy/tool/commands/__init__.py	2016-07-20 23:24:15 UTC (rev 203478)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/__init__.py	2016-07-20 23:28:22 UTC (rev 203479)
@@ -22,4 +22,4 @@
 from webkitpy.tool.commands.upload import *
 from webkitpy.tool.commands.suggestnominations import *
 
-AbstractEarlyWarningSystem.load_ews_classes()
+classes = AbstractEarlyWarningSystem.load_ews_classes()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [203485] trunk/Tools

[aakash_jain]

Title: [203485] trunk/Tools








Revision 203485
Author aakash_j...@apple.com
Date 2016-07-20 19:09:51 -0700 (Wed, 20 Jul 2016)


Log Message
Revert temporary fix r203417
https://bugs.webkit.org/show_bug.cgi?id=160001

Reviewed by Alexey Proskuryakov.

* EWSTools/start-queue-mac.sh: Revert the temporary fix.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/EWSTools/start-queue-mac.sh




Diff

Modified: trunk/Tools/ChangeLog (203484 => 203485)

--- trunk/Tools/ChangeLog	2016-07-21 00:45:39 UTC (rev 203484)
+++ trunk/Tools/ChangeLog	2016-07-21 02:09:51 UTC (rev 203485)
@@ -1,5 +1,14 @@
 2016-07-20  Aakash Jain  
 
+Revert temporary fix r203417
+https://bugs.webkit.org/show_bug.cgi?id=160001
+
+Reviewed by Alexey Proskuryakov.
+
+* EWSTools/start-queue-mac.sh: Revert the temporary fix.
+
+2016-07-20  Aakash Jain  
+
 REGRESSION(r148588): ews classes might get garbage collected
 https://bugs.webkit.org/show_bug.cgi?id=159990
 


Modified: trunk/Tools/EWSTools/start-queue-mac.sh (203484 => 203485)

--- trunk/Tools/EWSTools/start-queue-mac.sh	2016-07-21 00:45:39 UTC (rev 203484)
+++ trunk/Tools/EWSTools/start-queue-mac.sh	2016-07-21 02:09:51 UTC (rev 203485)
@@ -80,9 +80,6 @@
 # preventing webkit-patch from launching.
 ./Tools/Scripts/test-webkitpy
 
-# Temporary workaround for iOS EWS failing after the fix for bug 159539.
-find ./Tools -name *.pyc -delete
-
 # We use --exit-after-iteration to pick up any changes to webkit-patch, including
 # changes to the contributors.json file.
 ./Tools/Scripts/webkit-patch $QUEUE_NAME --bot-id=$BOT_ID --no-confirm --exit-after-iteration $RESET_AFTER_ITERATION $QUEUE_PARAMS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [203386] trunk/Tools

[aakash_jain]

Title: [203386] trunk/Tools








Revision 203386
Author aakash_j...@apple.com
Date 2016-07-18 17:24:50 -0700 (Mon, 18 Jul 2016)


Log Message
EWS console logs doesn't go to log file
https://bugs.webkit.org/show_bug.cgi?id=159539


Reviewed by David Kilzer.

* Scripts/webkitpy/common/system/logutils.py:
(configure_logger_to_log_to_file): Added method to configure the logger to log to file.
(FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
to filesystem. It also supports passing MockFilesystem.
(FileSystemHandler.__init__): Initialize the class and calls base class __init__.
(FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
(_test_ews): Same.
* Scripts/webkitpy/tool/commands/queues.py:
(AbstractQueue.begin_work_queue): Configure the logger to log to file.
(AbstractQueue._log_directory): Using filesystem object instead of os.
(AbstractQueue.queue_log_path): Same.
(AbstractQueue.__init__): Passed host parameter.
(PatchProcessingQueue.__init__): Same.
(CommitQueue.__init__): Same.
(AbstractReviewQueue.__init__): Same.
(StyleQueue.__init__): Same.
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(TestCommitQueue): Passed MockHost() as host.
(TestCommitQueue.__init__): Same.
(TestQueue.__init__): Same.
(TestReviewQueue.__init__): Same.
(TestFeederQueue.__init__): Same.
(AbstractPatchQueueTest.test_next_patch): Same.
(PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
(test_commit_queue_failure): Same.
(MockCommitQueueTask.results_from_patch_test_run): Same.
(test_rollout_lands): Same.
(test_non_valid_patch): Same.
(test_auto_retry): Same.
(test_style_queue_with_watch_list_exception): Same.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/logutils.py
trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py
trunk/Tools/Scripts/webkitpy/tool/commands/queues.py
trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (203385 => 203386)

--- trunk/Tools/ChangeLog	2016-07-19 00:24:28 UTC (rev 203385)
+++ trunk/Tools/ChangeLog	2016-07-19 00:24:50 UTC (rev 203386)
@@ -1,3 +1,44 @@
+2016-07-18  Aakash Jain  
+
+EWS console logs doesn't go to log file
+https://bugs.webkit.org/show_bug.cgi?id=159539
+
+
+Reviewed by David Kilzer.
+
+* Scripts/webkitpy/common/system/logutils.py:
+(configure_logger_to_log_to_file): Added method to configure the logger to log to file.
+(FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
+to filesystem. It also supports passing MockFilesystem.
+(FileSystemHandler.__init__): Initialize the class and calls base class __init__.
+(FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
+* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
+(AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
+(_test_ews): Same.
+* Scripts/webkitpy/tool/commands/queues.py:
+(AbstractQueue.begin_work_queue): Configure the logger to log to file.
+(AbstractQueue._log_directory): Using filesystem object instead of os.
+(AbstractQueue.queue_log_path): Same.
+(AbstractQueue.__init__): Passed host parameter.
+(PatchProcessingQueue.__init__): Same.
+(CommitQueue.__init__): Same.
+(AbstractReviewQueue.__init__): Same.
+(StyleQueue.__init__): Same.
+* Scripts/webkitpy/tool/commands/queues_unittest.py:
+(TestCommitQueue): Passed MockHost() as host.
+(TestCommitQueue.__init__): Same.
+(TestQueue.__init__): Same.
+(TestReviewQueue.__init__): Same.
+(TestFeederQueue.__init__): Same.
+(AbstractPatchQueueTest.test_next_patch): Same.
+(PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
+(test_commit_queue_failure): Same.
+(MockCommitQueueTask.results_from_patch_test_run): Same.
+(test_rollout_lands): Same.
+(test_non_valid_patch): Same.
+(test_auto_retry): Same.
+(test_style_queue_with_watch_list_exception): Same.
+
 2016-07-02  Filip Pizlo  
 
 WTF::Lock should be fair eventually


Modified: trunk/Tools/Scripts/webkitpy/common/system/logutils.py (203385 => 203386)

--- trunk/Tools/Scripts/webkitpy/common/system/logutils.py	2016-07-19 00:24:28 UTC (rev 203385)
+++ trunk/Tools/Scripts/webkitpy/common/system/logutils.py	2016-07-19 00:24:50 UTC (rev 203386)
@@ -31,7 +31,9 @@
 
 import webkitpy
 
+from logging import FileHandler
 
+
 _log = logging.getLogger(__name__)
 
 # We set these directory 

[webkit-changes] [204230] trunk/Tools

[aakash_jain]

Title: [204230] trunk/Tools








Revision 204230
Author aakash_j...@apple.com
Date 2016-08-06 12:33:10 -0700 (Sat, 06 Aug 2016)


Log Message
EWS Style Queue fails to process patches which fails validation
https://bugs.webkit.org/show_bug.cgi?id=160632

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/tool/bot/stylequeuetask.py:
(StyleQueueTask.validate): Add more information about validation failure.
(StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(test_non_valid_patch): Add a unit test to test the above code path.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/bot/stylequeuetask.py
trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (204229 => 204230)

--- trunk/Tools/ChangeLog	2016-08-06 18:23:15 UTC (rev 204229)
+++ trunk/Tools/ChangeLog	2016-08-06 19:33:10 UTC (rev 204230)
@@ -1,3 +1,16 @@
+2016-08-06  Aakash Jain  
+
+EWS Style Queue fails to process patches which fails validation
+https://bugs.webkit.org/show_bug.cgi?id=160632
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/tool/bot/stylequeuetask.py:
+(StyleQueueTask.validate): Add more information about validation failure.
+(StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
+* Scripts/webkitpy/tool/commands/queues_unittest.py:
+(test_non_valid_patch): Add a unit test to test the above code path.
+
 2016-08-06  Sam Weinig  
 
 WTF needs a variant implementation


Modified: trunk/Tools/Scripts/webkitpy/tool/bot/stylequeuetask.py (204229 => 204230)

--- trunk/Tools/Scripts/webkitpy/tool/bot/stylequeuetask.py	2016-08-06 18:23:15 UTC (rev 204229)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/stylequeuetask.py	2016-08-06 19:33:10 UTC (rev 204230)
@@ -38,10 +38,13 @@
 def validate(self):
 self._patch = self._delegate.refetch_patch(self._patch)
 if self._patch.is_obsolete():
+self.error = "Patch is obsolete."
 return False
 if self._patch.bug().is_closed():
+self.error = "Bug is already closed."
 return False
 if self._patch.review() == "-":
+self.error = "Patch is marked r-."
 return False
 return True
 
@@ -64,7 +67,7 @@
 
 def run(self):
 if not self.validate():
-raise PatchIsNotValid(self._patch)
+raise PatchIsNotValid(self._patch, self.error)
 if not self._clean():
 return False
 if not self._update():


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py (204229 => 204230)

--- trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py	2016-08-06 18:23:15 UTC (rev 204229)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py	2016-08-06 19:33:10 UTC (rev 204230)
@@ -534,3 +534,14 @@
 }
 tool = MockTool(executive_throws_when_run=set(['apply-watchlist-local']))
 self.assert_queue_outputs(StyleQueue(host=MockHost()), expected_logs=expected_logs, tool=tool)
+
+def test_non_valid_patch(self):
+tool = MockTool()
+patch = tool.bugs.fetch_attachment(10007)  # _patch8, resolved bug, without review flag, not marked obsolete (maybe already landed)
+expected_logs = {
+"begin_work_queue": self._default_begin_work_queue_logs("style-queue"),
+"process_work_item": """MOCK: update_status: style-queue Error: style-queue did not process patch. Reason: Bug is already closed.
+MOCK: release_work_item: style-queue 10007
+""",
+}
+self.assert_queue_outputs(StyleQueue(host=MockHost()), tool=tool, work_item=patch, expected_logs=expected_logs)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [204275] trunk/Tools

[aakash_jain]

Title: [204275] trunk/Tools








Revision 204275
Author aakash_j...@apple.com
Date 2016-08-08 18:17:52 -0700 (Mon, 08 Aug 2016)


Log Message
Some EWS console logs doesn't go to log file
https://bugs.webkit.org/show_bug.cgi?id=160585
rdar://problem/24464570

Reviewed by Daniel Bates.

* Scripts/webkitpy/common/system/logutils.py:
(FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
any possible overwriting.
* Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.open_text_file_for_writing): Same.
* Scripts/webkitpy/common/system/filesystem_unittest.py:
(RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
(RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
* Scripts/webkitpy/tool/commands/queues.py:
(AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
This will ensure that all the sub-modules inside webkitpy will log to file.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/filesystem.py
trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py
trunk/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py
trunk/Tools/Scripts/webkitpy/common/system/logutils.py
trunk/Tools/Scripts/webkitpy/tool/commands/queues.py




Diff

Modified: trunk/Tools/ChangeLog (204274 => 204275)

--- trunk/Tools/ChangeLog	2016-08-09 01:06:50 UTC (rev 204274)
+++ trunk/Tools/ChangeLog	2016-08-09 01:17:52 UTC (rev 204275)
@@ -1,3 +1,25 @@
+2016-08-08  Aakash Jain  
+
+Some EWS console logs doesn't go to log file
+https://bugs.webkit.org/show_bug.cgi?id=160585
+rdar://problem/24464570
+
+Reviewed by Daniel Bates.
+
+* Scripts/webkitpy/common/system/logutils.py:
+(FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
+any possible overwriting.
+* Scripts/webkitpy/common/system/filesystem.py:
+(FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
+* Scripts/webkitpy/common/system/filesystem_mock.py:
+(MockFileSystem.open_text_file_for_writing): Same.
+* Scripts/webkitpy/common/system/filesystem_unittest.py:
+(RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
+(RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
+* Scripts/webkitpy/tool/commands/queues.py:
+(AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
+This will ensure that all the sub-modules inside webkitpy will log to file.
+
 2016-08-08  Simon Fraser  
 
 Have the iOS platform interit from the Apple platform in webkitpy


Modified: trunk/Tools/Scripts/webkitpy/common/system/filesystem.py (204274 => 204275)

--- trunk/Tools/Scripts/webkitpy/common/system/filesystem.py	2016-08-09 01:06:50 UTC (rev 204274)
+++ trunk/Tools/Scripts/webkitpy/common/system/filesystem.py	2016-08-09 01:17:52 UTC (rev 204275)
@@ -235,7 +235,9 @@
 # not being seekable. See http://stackoverflow.com/questions/1510188/can-seek-and-tell-work-with-utf-8-encoded-documents-in-python .
 return codecs.open(path, 'r', 'utf8', errors)
 
-def open_text_file_for_writing(self, path):
+def open_text_file_for_writing(self, path, should_append=False):
+if should_append:
+return codecs.open(path, 'a', 'utf8')
 return codecs.open(path, 'w', 'utf8')
 
 def open_stdin(self):


Modified: trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py (204274 => 204275)

--- trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py	2016-08-09 01:06:50 UTC (rev 204274)
+++ trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py	2016-08-09 01:17:52 UTC (rev 204275)
@@ -337,7 +337,7 @@
 self._raise_not_found(path)
 return ReadableTextFileObject(self, path, self.files[path])
 
-def open_text_file_for_writing(self, path):
+def open_text_file_for_writing(self, path, should_append=False):
 return WritableTextFileObject(self, path)
 
 def read_text_file(self, path):


Modified: trunk/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py (204274 => 204275)

--- trunk/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py	2016-08-09 01:06:50 UTC (rev 204274)
+++ trunk/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py	2016-08-09 01:17:52 UTC (rev 204275)
@@ -187,7 +187,6 @@
 text_path = None
 
 unicode_text_string = u'\u016An\u012Dc\u014Dde\u033D'
-hex_equivalent = '\xC5\xAA\x6E\xC4\xAD\x63\xC5\x8D\x64\x65\xCC\xBD'
 try:
 text_path = 

[webkit-changes] [204289] trunk/Tools

[aakash_jain]

Title: [204289] trunk/Tools








Revision 204289
Author aakash_j...@apple.com
Date 2016-08-09 12:30:16 -0700 (Tue, 09 Aug 2016)


Log Message
EWS logging should ensure the logging to file is stopped on queue termination
https://bugs.webkit.org/show_bug.cgi?id=160698
rdar://problem/24464570

Reviewed by Daniel Bates.

* Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine._stopping): Stop logging to file on queue termination.
(QueueEngine._begin_logging): Configure the Python logger to log to file.
* Scripts/webkitpy/common/system/logutils.py:
(configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
(QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
* Scripts/webkitpy/tool/commands/queues.py:
(AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
(AbstractQueue.queue_log_path): Same.
(AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
(AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
which moved to QueueEngine now.
(PatchProcessingQueue.__init__): Same.
(CommitQueue.__init__): Same.
(AbstractReviewQueue.__init__): Same.
(StyleQueue.__init__): Same.
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(TestCommitQueue): Removed host parameter.
(TestCommitQueue.__init__): Same.
(AbstractPatchQueueTest.test_next_patch): Same.
(PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
(test_commit_queue_failure): Same.
(mock_run_webkit_patch):
(MockCommitQueueTask.results_from_patch_test_run): Same.
(test_rollout_lands): Same.
(test_non_valid_patch): Same.
(test_auto_retry): Same.
(test_style_queue_with_watch_list_exception): Same.
(TestQueue.__init__): Deleted.
(TestReviewQueue.__init__): Deleted.
(TestFeederQueue.__init__): Deleted.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/logutils.py
trunk/Tools/Scripts/webkitpy/tool/bot/queueengine.py
trunk/Tools/Scripts/webkitpy/tool/bot/queueengine_unittest.py
trunk/Tools/Scripts/webkitpy/tool/commands/queues.py
trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (204288 => 204289)

--- trunk/Tools/ChangeLog	2016-08-09 18:52:11 UTC (rev 204288)
+++ trunk/Tools/ChangeLog	2016-08-09 19:30:16 UTC (rev 204289)
@@ -1,3 +1,44 @@
+2016-08-09  Aakash Jain  
+
+EWS logging should ensure the logging to file is stopped on queue termination
+https://bugs.webkit.org/show_bug.cgi?id=160698
+rdar://problem/24464570
+
+Reviewed by Daniel Bates.
+
+* Scripts/webkitpy/tool/bot/queueengine.py:
+(QueueEngine._stopping): Stop logging to file on queue termination.
+(QueueEngine._begin_logging): Configure the Python logger to log to file.
+* Scripts/webkitpy/common/system/logutils.py:
+(configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
+* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
+(QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
+* Scripts/webkitpy/tool/commands/queues.py:
+(AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
+(AbstractQueue.queue_log_path): Same.
+(AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
+(AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
+which moved to QueueEngine now.
+(PatchProcessingQueue.__init__): Same.
+(CommitQueue.__init__): Same.
+(AbstractReviewQueue.__init__): Same.
+(StyleQueue.__init__): Same.
+* Scripts/webkitpy/tool/commands/queues_unittest.py:
+(TestCommitQueue): Removed host parameter.
+(TestCommitQueue.__init__): Same.
+(AbstractPatchQueueTest.test_next_patch): Same.
+(PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
+(test_commit_queue_failure): Same.
+(mock_run_webkit_patch):
+(MockCommitQueueTask.results_from_patch_test_run): Same.
+(test_rollout_lands): Same.
+(test_non_valid_patch): Same.
+(test_auto_retry): Same.
+(test_style_queue_with_watch_list_exception): Same.
+(TestQueue.__init__): Deleted.
+(TestReviewQueue.__init__): Deleted.
+(TestFeederQueue.__init__): Deleted.
+
 2016-08-09  Konstantin Tokarev  
 
 webkit-gtk tarball fails to build due to missing files


Modified: trunk/Tools/Scripts/webkitpy/common/system/logutils.py (204288 => 204289)

--- trunk/Tools/Scripts/webkitpy/common/system/logutils.py	2016-08-09 18:52:11 UTC (rev 204288)
+++ 

[webkit-changes] [204105] trunk/Tools

[aakash_jain]

Title: [204105] trunk/Tools








Revision 204105
Author aakash_j...@apple.com
Date 2016-08-03 16:25:02 -0700 (Wed, 03 Aug 2016)


Log Message
Document instructions for increasing process and file limits
https://bugs.webkit.org/show_bug.cgi?id=160528
rdar://problem/24777576

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.default_child_processes):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/ios.py




Diff

Modified: trunk/Tools/ChangeLog (204104 => 204105)

--- trunk/Tools/ChangeLog	2016-08-03 22:53:09 UTC (rev 204104)
+++ trunk/Tools/ChangeLog	2016-08-03 23:25:02 UTC (rev 204105)
@@ -1,3 +1,14 @@
+2016-08-03  Aakash Jain  
+
+Document instructions for increasing process and file limits
+https://bugs.webkit.org/show_bug.cgi?id=160528
+rdar://problem/24777576
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/port/ios.py:
+(IOSSimulatorPort.default_child_processes):
+
 2016-08-03  Anders Carlsson  
 
 Remove the Objective-C bindings generator


Modified: trunk/Tools/Scripts/webkitpy/port/ios.py (204104 => 204105)

--- trunk/Tools/Scripts/webkitpy/port/ios.py	2016-08-03 22:53:09 UTC (rev 204104)
+++ trunk/Tools/Scripts/webkitpy/port/ios.py	2016-08-03 23:25:02 UTC (rev 204105)
@@ -143,10 +143,9 @@
 # FIXME: We should also take into account the available RAM.
 
 if (maximum_simulator_count_on_this_system < best_child_process_count_for_cpu):
-_log.warn("This machine could support %s child processes, but only has enough process limit for %s."
+_log.warn("This machine could support %s simulators, but is only configured for %s."
 % (best_child_process_count_for_cpu, maximum_simulator_count_on_this_system))
-_log.warn('Run "launchctl limit" to check these limits')
-# FIXME: Add url for webpage explaining how to increase these limits.
+_log.warn('Please see .')
 
 if maximum_simulator_count_on_this_system == 0:
 maximum_simulator_count_on_this_system = 1






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [204527] trunk/Tools

[aakash_jain]

Title: [204527] trunk/Tools








Revision 204527
Author aakash_j...@apple.com
Date 2016-08-16 15:24:23 -0700 (Tue, 16 Aug 2016)


Log Message
EWS logs file are rotated too quickly
https://bugs.webkit.org/show_bug.cgi?id=160724

Reviewed by Daniel Bates.

Currently we are rotating the log file after 10 iterations of queue. If the queue
doesn't have any pending patches, these iterations result in very small amount of
logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
This results in a lot of log files in a day. This patch ensures that we rotate the
log file when its file size is greater than or equal to 100 KB.

* EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/EWSTools/start-queue-mac.sh




Diff

Modified: trunk/Tools/ChangeLog (204526 => 204527)

--- trunk/Tools/ChangeLog	2016-08-16 22:20:05 UTC (rev 204526)
+++ trunk/Tools/ChangeLog	2016-08-16 22:24:23 UTC (rev 204527)
@@ -1,3 +1,18 @@
+2016-08-16  Aakash Jain  
+
+EWS logs file are rotated too quickly
+https://bugs.webkit.org/show_bug.cgi?id=160724
+
+Reviewed by Daniel Bates.
+
+Currently we are rotating the log file after 10 iterations of queue. If the queue
+doesn't have any pending patches, these iterations result in very small amount of 
+logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
+This results in a lot of log files in a day. This patch ensures that we rotate the
+log file when its file size is greater than or equal to 100 KB.
+
+* EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
+
 2016-08-16  Daniel Bates  
 
 WKSI static library should be named by major iOS revision, not individual updates


Modified: trunk/Tools/EWSTools/start-queue-mac.sh (204526 => 204527)

--- trunk/Tools/EWSTools/start-queue-mac.sh	2016-08-16 22:20:05 UTC (rev 204526)
+++ trunk/Tools/EWSTools/start-queue-mac.sh	2016-08-16 22:24:23 UTC (rev 204527)
@@ -55,7 +55,10 @@
 cd $EWS_HOME/$QUEUE_NAME-logs
 find . -mtime +30 -delete
 if [ -s $QUEUE_NAME.log ]; then
-mv -f $QUEUE_NAME.log ${QUEUE_NAME}_$(date +%Y-%m-%d_%H-%m).log
+filesize=$(stat -f%z "$QUEUE_NAME.log")  # filesize in bytes.
+if [ $filesize -ge 10 ]; then
+mv -f $QUEUE_NAME.log ${QUEUE_NAME}_$(date +%Y-%m-%d_%H-%m).log
+fi
 fi
 cd $WEBKIT_HOME
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211877] trunk/Source/WebCore

[aakash_jain]

Title: [211877] trunk/Source/WebCore








Revision 211877
Author aakash_j...@apple.com
Date 2017-02-08 09:22:28 -0800 (Wed, 08 Feb 2017)


Log Message
Remove unused method WebCore::PluginData::pluginNameForMimeType
https://bugs.webkit.org/show_bug.cgi?id=167986

Reviewed by Anders Carlsson.

* plugins/PluginData.cpp:
(WebCore::PluginData::pluginNameForWebVisibleMimeType): Deleted.
* plugins/PluginData.h: Removed pluginNameForWebVisibleMimeType.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/plugins/PluginData.cpp
trunk/Source/WebCore/plugins/PluginData.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (211876 => 211877)

--- trunk/Source/WebCore/ChangeLog	2017-02-08 17:19:45 UTC (rev 211876)
+++ trunk/Source/WebCore/ChangeLog	2017-02-08 17:22:28 UTC (rev 211877)
@@ -1,3 +1,14 @@
+2017-02-08  Aakash Jain  
+
+Remove unused method WebCore::PluginData::pluginNameForMimeType
+https://bugs.webkit.org/show_bug.cgi?id=167986
+
+Reviewed by Anders Carlsson.
+
+* plugins/PluginData.cpp:
+(WebCore::PluginData::pluginNameForWebVisibleMimeType): Deleted.
+* plugins/PluginData.h: Removed pluginNameForWebVisibleMimeType.
+
 2017-02-08  Carlos Garcia Campos  
 
 [GTK] Fix translatable form validation messages


Modified: trunk/Source/WebCore/plugins/PluginData.cpp (211876 => 211877)

--- trunk/Source/WebCore/plugins/PluginData.cpp	2017-02-08 17:19:45 UTC (rev 211876)
+++ trunk/Source/WebCore/plugins/PluginData.cpp	2017-02-08 17:22:28 UTC (rev 211877)
@@ -148,14 +148,6 @@
 return false;
 }
 
-String PluginData::pluginNameForWebVisibleMimeType(const String& mimeType) const
-{
-PluginInfo info;
-if (getPluginInfoForWebVisibleMimeType(mimeType, info))
-return info.name;
-return String();
-}
-
 String PluginData::pluginFileForWebVisibleMimeType(const String& mimeType) const
 {
 PluginInfo info;


Modified: trunk/Source/WebCore/plugins/PluginData.h (211876 => 211877)

--- trunk/Source/WebCore/plugins/PluginData.h	2017-02-08 17:19:45 UTC (rev 211876)
+++ trunk/Source/WebCore/plugins/PluginData.h	2017-02-08 17:22:28 UTC (rev 211877)
@@ -98,7 +98,6 @@
 };
 
 WEBCORE_EXPORT bool supportsWebVisibleMimeType(const String& mimeType, const AllowedPluginTypes) const;
-String pluginNameForWebVisibleMimeType(const String& mimeType) const;
 String pluginFileForWebVisibleMimeType(const String& mimeType) const;
 
 WEBCORE_EXPORT bool supportsMimeType(const String& mimeType, const AllowedPluginTypes) const;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211878] trunk/Source/WebCore

[aakash_jain]

Title: [211878] trunk/Source/WebCore








Revision 211878
Author aakash_j...@apple.com
Date 2017-02-08 09:26:23 -0800 (Wed, 08 Feb 2017)


Log Message
Move WKMouseInRect to WAKView.mm
https://bugs.webkit.org/show_bug.cgi?id=167989

Reviewed by Alexey Proskuryakov.

* platform/ios/wak/WAKAppKitStubs.h: Removed WKMouseInRect.
* platform/ios/wak/WAKAppKitStubs.m:
(WKMouseInRect): Deleted.
* platform/ios/wak/WAKView.mm:
(-[WAKView mouse:inRect:]): Added the logic of WKMouseInRect here instead of separate function call.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/wak/WAKAppKitStubs.h
trunk/Source/WebCore/platform/ios/wak/WAKAppKitStubs.m
trunk/Source/WebCore/platform/ios/wak/WAKView.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (211877 => 211878)

--- trunk/Source/WebCore/ChangeLog	2017-02-08 17:22:28 UTC (rev 211877)
+++ trunk/Source/WebCore/ChangeLog	2017-02-08 17:26:23 UTC (rev 211878)
@@ -1,5 +1,18 @@
 2017-02-08  Aakash Jain  
 
+Move WKMouseInRect to WAKView.mm
+https://bugs.webkit.org/show_bug.cgi?id=167989
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/ios/wak/WAKAppKitStubs.h: Removed WKMouseInRect.
+* platform/ios/wak/WAKAppKitStubs.m:
+(WKMouseInRect): Deleted.
+* platform/ios/wak/WAKView.mm: 
+(-[WAKView mouse:inRect:]): Added the logic of WKMouseInRect here instead of separate function call.
+
+2017-02-08  Aakash Jain  
+
 Remove unused method WebCore::PluginData::pluginNameForMimeType
 https://bugs.webkit.org/show_bug.cgi?id=167986
 


Modified: trunk/Source/WebCore/platform/ios/wak/WAKAppKitStubs.h (211877 => 211878)

--- trunk/Source/WebCore/platform/ios/wak/WAKAppKitStubs.h	2017-02-08 17:22:28 UTC (rev 211877)
+++ trunk/Source/WebCore/platform/ios/wak/WAKAppKitStubs.h	2017-02-08 17:26:23 UTC (rev 211878)
@@ -209,16 +209,6 @@
 + (void)setHiddenUntilMouseMoves:(BOOL)flag;
 @end
 
-#ifdef __cplusplus
-extern "C" {
-#endif
-
-BOOL WKMouseInRect(CGPoint aPoint, CGRect aRect);
-
-#ifdef __cplusplus
-}
-#endif
-
 #endif // TARGET_OS_IPHONE
 
 #endif // WAKAppKitStubs_h


Modified: trunk/Source/WebCore/platform/ios/wak/WAKAppKitStubs.m (211877 => 211878)

--- trunk/Source/WebCore/platform/ios/wak/WAKAppKitStubs.m	2017-02-08 17:22:28 UTC (rev 211877)
+++ trunk/Source/WebCore/platform/ios/wak/WAKAppKitStubs.m	2017-02-08 17:26:23 UTC (rev 211878)
@@ -30,13 +30,6 @@
 
 id NSApp = nil;
 
-BOOL WKMouseInRect(CGPoint aPoint, CGRect aRect) 
-{
-return aPoint.x >= aRect.origin.x &&
-aPoint.x < (aRect.origin.x + aRect.size.width) &&
-aPoint.y >= aRect.origin.y && aPoint.y < (aRect.origin.y + aRect.size.height);
-}
-
 @implementation NSCursor
 + (void)setHiddenUntilMouseMoves:(BOOL)flag
 {


Modified: trunk/Source/WebCore/platform/ios/wak/WAKView.mm (211877 => 211878)

--- trunk/Source/WebCore/platform/ios/wak/WAKView.mm	2017-02-08 17:22:28 UTC (rev 211877)
+++ trunk/Source/WebCore/platform/ios/wak/WAKView.mm	2017-02-08 17:26:23 UTC (rev 211878)
@@ -673,7 +673,9 @@
 
 - (BOOL)mouse:(NSPoint)aPoint inRect:(NSRect)aRect 
 { 
-return WKMouseInRect (aPoint, aRect);
+return aPoint.x >= aRect.origin.x
+&& aPoint.x < (aRect.origin.x + aRect.size.width)
+&& aPoint.y >= aRect.origin.y && aPoint.y < (aRect.origin.y + aRect.size.height);
 }
 
 - (BOOL)needsPanelToBecomeKey






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211880] trunk/Source/WebCore

[aakash_jain]

Title: [211880] trunk/Source/WebCore








Revision 211880
Author aakash_j...@apple.com
Date 2017-02-08 09:31:16 -0800 (Wed, 08 Feb 2017)


Log Message
Remove WebCoreObjCDeallocWithWebThreadLock from header file
https://bugs.webkit.org/show_bug.cgi?id=167987

Reviewed by Alexey Proskuryakov.

* platform/ios/wak/WebCoreThread.mm: Added WebCoreObjCDeallocWithWebThreadLock.
* platform/ios/wak/WebCoreThreadMessage.h: Removed WebCoreObjCDeallocWithWebThreadLock.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm
trunk/Source/WebCore/platform/ios/wak/WebCoreThreadMessage.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (211879 => 211880)

--- trunk/Source/WebCore/ChangeLog	2017-02-08 17:29:08 UTC (rev 211879)
+++ trunk/Source/WebCore/ChangeLog	2017-02-08 17:31:16 UTC (rev 211880)
@@ -1,5 +1,15 @@
 2017-02-08  Aakash Jain  
 
+Remove WebCoreObjCDeallocWithWebThreadLock from header file
+https://bugs.webkit.org/show_bug.cgi?id=167987
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/ios/wak/WebCoreThread.mm: Added WebCoreObjCDeallocWithWebThreadLock.
+* platform/ios/wak/WebCoreThreadMessage.h: Removed WebCoreObjCDeallocWithWebThreadLock.
+
+2017-02-08  Aakash Jain  
+
 Move WKMouseInRect to WAKView.mm
 https://bugs.webkit.org/show_bug.cgi?id=167989
 


Modified: trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm (211879 => 211880)

--- trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm	2017-02-08 17:29:08 UTC (rev 211879)
+++ trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm	2017-02-08 17:31:16 UTC (rev 211880)
@@ -139,6 +139,7 @@
 
 static pthread_mutex_t WebCoreReleaseLock;
 static void WebCoreObjCDeallocOnWebThreadImpl(id self, SEL _cmd);
+static void WebCoreObjCDeallocWithWebThreadLock(Class cls);
 static void WebCoreObjCDeallocWithWebThreadLockImpl(id self, SEL _cmd);
 
 static NSMutableArray *sAsyncDelegates = nil;


Modified: trunk/Source/WebCore/platform/ios/wak/WebCoreThreadMessage.h (211879 => 211880)

--- trunk/Source/WebCore/platform/ios/wak/WebCoreThreadMessage.h	2017-02-08 17:29:08 UTC (rev 211879)
+++ trunk/Source/WebCore/platform/ios/wak/WebCoreThreadMessage.h	2017-02-08 17:31:16 UTC (rev 211880)
@@ -47,7 +47,6 @@
 
 // Register a class for deallocation on the WebThread
 WEBCORE_EXPORT void WebCoreObjCDeallocOnWebThread(Class cls);
-void WebCoreObjCDeallocWithWebThreadLock(Class cls);
 
 // Asynchronous from main thread to web thread.
 WEBCORE_EXPORT void WebThreadAdoptAndRelease(id obj);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211889] trunk/Source/WebCore

[aakash_jain]

Title: [211889] trunk/Source/WebCore








Revision 211889
Author aakash_j...@apple.com
Date 2017-02-08 11:42:49 -0800 (Wed, 08 Feb 2017)


Log Message
Move private methods from WKContentObservation.h to a separate header file
https://bugs.webkit.org/show_bug.cgi?id=167998

Reviewed by Alexey Proskuryakov.

* WebCore.xcodeproj/project.pbxproj: Added WKContentObservationInternal.h
* platform/ios/wak/WKContentObservationInternal.h: Added.
* platform/ios/wak/WKContentObservation.h: Moved methods to WKContentObservationInternal.h
* platform/ios/wak/WKContentObservation.cpp: Included new header file.
* page/DOMTimer.cpp: Same.
* page/DOMWindow.cpp: Same.
* style/RenderTreeUpdater.cpp: Same.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/page/DOMTimer.cpp
trunk/Source/WebCore/page/DOMWindow.cpp
trunk/Source/WebCore/platform/ios/wak/WKContentObservation.cpp
trunk/Source/WebCore/platform/ios/wak/WKContentObservation.h
trunk/Source/WebCore/style/RenderTreeUpdater.cpp


Added Paths

trunk/Source/WebCore/platform/ios/wak/WKContentObservationInternal.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (211888 => 211889)

--- trunk/Source/WebCore/ChangeLog	2017-02-08 19:36:00 UTC (rev 211888)
+++ trunk/Source/WebCore/ChangeLog	2017-02-08 19:42:49 UTC (rev 211889)
@@ -1,3 +1,18 @@
+2017-02-08  Aakash Jain  
+
+Move private methods from WKContentObservation.h to a separate header file
+https://bugs.webkit.org/show_bug.cgi?id=167998
+
+Reviewed by Alexey Proskuryakov.
+
+* WebCore.xcodeproj/project.pbxproj: Added WKContentObservationInternal.h
+* platform/ios/wak/WKContentObservationInternal.h: Added.
+* platform/ios/wak/WKContentObservation.h: Moved methods to WKContentObservationInternal.h
+* platform/ios/wak/WKContentObservation.cpp: Included new header file.
+* page/DOMTimer.cpp: Same.
+* page/DOMWindow.cpp: Same.
+* style/RenderTreeUpdater.cpp: Same.
+
 2017-02-08  Youenn Fablet  
 
 RTCPeerConnection constructor can take null as input


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (211888 => 211889)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2017-02-08 19:36:00 UTC (rev 211888)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2017-02-08 19:42:49 UTC (rev 211889)
@@ -6550,6 +6550,7 @@
 		E5BA7D63151437CA00FE1E3F /* LengthFunctions.h in Headers */ = {isa = PBXBuildFile; fileRef = E5BA7D62151437CA00FE1E3F /* LengthFunctions.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		EBF5121C1696496C0056BD25 /* JSTypeConversions.cpp in Sources */ = {isa = PBXBuildFile; fileRef = EBF5121A1696496C0056BD25 /* JSTypeConversions.cpp */; };
 		EBF5121D1696496C0056BD25 /* JSTypeConversions.h in Headers */ = {isa = PBXBuildFile; fileRef = EBF5121B1696496C0056BD25 /* JSTypeConversions.h */; };
+		ECCDB8811E4B8C5900A1AEA6 /* WKContentObservationInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = ECCDB8801E4B8C5900A1AEA6 /* WKContentObservationInternal.h */; };
 		ED2BA83C09A24B91006C0AC4 /* DocumentMarker.h in Headers */ = {isa = PBXBuildFile; fileRef = ED2BA83B09A24B91006C0AC4 /* DocumentMarker.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		ED501DC60B249F2900AE18D9 /* EditorMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = ED501DC50B249F2900AE18D9 /* EditorMac.mm */; };
 		EDE3A5000C7A430600956A37 /* ColorMac.h in Headers */ = {isa = PBXBuildFile; fileRef = EDE3A4FF0C7A430600956A37 /* ColorMac.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -14711,6 +14712,7 @@
 		EB081CD91696084400553730 /* TypeConversions.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = TypeConversions.idl; sourceTree = ""; };
 		EBF5121A1696496C0056BD25 /* JSTypeConversions.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSTypeConversions.cpp; sourceTree = ""; };
 		EBF5121B1696496C0056BD25 /* JSTypeConversions.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSTypeConversions.h; sourceTree = ""; };
+		ECCDB8801E4B8C5900A1AEA6 /* WKContentObservationInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKContentObservationInternal.h; sourceTree = ""; };
 		ED2BA83B09A24B91006C0AC4 /* DocumentMarker.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DocumentMarker.h; sourceTree = ""; };
 		ED501DC50B249F2900AE18D9 /* EditorMac.mm */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.objcpp; path = EditorMac.mm; sourceTree = ""; };
 		EDE3A4FF0C7A430600956A37 /* ColorMac.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ColorMac.h; sourceTree = ""; };
@@ -19975,6 +19977,7 @@
 		A148328B187F506800DA63A6 /* wak */ = {
 			isa 

[webkit-changes] [211899] trunk/Source/WebCore

[aakash_jain]

Title: [211899] trunk/Source/WebCore








Revision 211899
Author aakash_j...@apple.com
Date 2017-02-08 13:58:21 -0800 (Wed, 08 Feb 2017)


Log Message
Move private methods from WKGraphics.h to a separate header file
https://bugs.webkit.org/show_bug.cgi?id=167996

Reviewed by Alexey  Proskuryakov.

* platform/ios/wak/WKGraphicsInternal.h: Added.
* WebCore.xcodeproj/project.pbxproj: Added WKGraphicsInternal.h
* platform/ios/wak/WKGraphics.h: Moved methods to WKGraphicsInternal.h
* platform/graphics/mac/GraphicsContextMac.mm: Included new header file.
* platform/ios/wak/WKGraphics.mm: Same.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm
trunk/Source/WebCore/platform/ios/wak/WKGraphics.h
trunk/Source/WebCore/platform/ios/wak/WKGraphics.mm


Added Paths

trunk/Source/WebCore/platform/ios/wak/WKGraphicsInternal.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (211898 => 211899)

--- trunk/Source/WebCore/ChangeLog	2017-02-08 21:37:02 UTC (rev 211898)
+++ trunk/Source/WebCore/ChangeLog	2017-02-08 21:58:21 UTC (rev 211899)
@@ -1,3 +1,16 @@
+2017-02-08  Aakash Jain  
+
+Move private methods from WKGraphics.h to a separate header file
+https://bugs.webkit.org/show_bug.cgi?id=167996
+
+Reviewed by Alexey  Proskuryakov.
+
+* platform/ios/wak/WKGraphicsInternal.h: Added.
+* WebCore.xcodeproj/project.pbxproj: Added WKGraphicsInternal.h
+* platform/ios/wak/WKGraphics.h: Moved methods to WKGraphicsInternal.h
+* platform/graphics/mac/GraphicsContextMac.mm: Included new header file.
+* platform/ios/wak/WKGraphics.mm: Same.
+
 2017-02-08  Brady Eidson  
 
 Opt-out iBooks from synchronous willSendRequest on iOS.


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (211898 => 211899)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2017-02-08 21:37:02 UTC (rev 211898)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2017-02-08 21:58:21 UTC (rev 211899)
@@ -6553,6 +6553,7 @@
 		EBF5121C1696496C0056BD25 /* JSTypeConversions.cpp in Sources */ = {isa = PBXBuildFile; fileRef = EBF5121A1696496C0056BD25 /* JSTypeConversions.cpp */; };
 		EBF5121D1696496C0056BD25 /* JSTypeConversions.h in Headers */ = {isa = PBXBuildFile; fileRef = EBF5121B1696496C0056BD25 /* JSTypeConversions.h */; };
 		ECCDB8811E4B8C5900A1AEA6 /* WKContentObservationInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = ECCDB8801E4B8C5900A1AEA6 /* WKContentObservationInternal.h */; };
+		ECCDB8871E4BB63F00A1AEA6 /* WKGraphicsInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = ECCDB8861E4BB63F00A1AEA6 /* WKGraphicsInternal.h */; };
 		ED2BA83C09A24B91006C0AC4 /* DocumentMarker.h in Headers */ = {isa = PBXBuildFile; fileRef = ED2BA83B09A24B91006C0AC4 /* DocumentMarker.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		ED501DC60B249F2900AE18D9 /* EditorMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = ED501DC50B249F2900AE18D9 /* EditorMac.mm */; };
 		EDE3A5000C7A430600956A37 /* ColorMac.h in Headers */ = {isa = PBXBuildFile; fileRef = EDE3A4FF0C7A430600956A37 /* ColorMac.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -14723,6 +14724,7 @@
 		EBF5121A1696496C0056BD25 /* JSTypeConversions.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSTypeConversions.cpp; sourceTree = ""; };
 		EBF5121B1696496C0056BD25 /* JSTypeConversions.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSTypeConversions.h; sourceTree = ""; };
 		ECCDB8801E4B8C5900A1AEA6 /* WKContentObservationInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKContentObservationInternal.h; sourceTree = ""; };
+		ECCDB8861E4BB63F00A1AEA6 /* WKGraphicsInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKGraphicsInternal.h; sourceTree = ""; };
 		ED2BA83B09A24B91006C0AC4 /* DocumentMarker.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DocumentMarker.h; sourceTree = ""; };
 		ED501DC50B249F2900AE18D9 /* EditorMac.mm */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.objcpp; path = EditorMac.mm; sourceTree = ""; };
 		EDE3A4FF0C7A430600956A37 /* ColorMac.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ColorMac.h; sourceTree = ""; };
@@ -19987,6 +19989,7 @@
 		A148328B187F506800DA63A6 /* wak */ = {
 			isa = PBXGroup;
 			children = (
+ECCDB8861E4BB63F00A1AEA6 /* WKGraphicsInternal.h */,
 ECCDB8801E4B8C5900A1AEA6 /* WKContentObservationInternal.h */,
 FE69986F192087E7006936BD /* FloatingPointEnvironment.cpp */,
 FE699870192087E7006936BD /* FloatingPointEnvironment.h */,
@@ -27994,6 +27997,7 @@
 			

[webkit-changes] [211901] trunk/Source/WebKit/mac

[aakash_jain]

Title: [211901] trunk/Source/WebKit/mac








Revision 211901
Author aakash_j...@apple.com
Date 2017-02-08 14:04:38 -0800 (Wed, 08 Feb 2017)


Log Message
Don't re-export WKUtilities.h from WebKit
https://bugs.webkit.org/show_bug.cgi?id=167977

Reviewed by Alexey Proskuryakov.

* MigrateHeaders.make: Removed WKUtilities.h

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/MigrateHeaders.make




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (211900 => 211901)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-08 22:01:53 UTC (rev 211900)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-08 22:04:38 UTC (rev 211901)
@@ -1,3 +1,12 @@
+2017-02-08  Aakash Jain  
+
+Don't re-export WKUtilities.h from WebKit
+https://bugs.webkit.org/show_bug.cgi?id=167977
+
+Reviewed by Alexey Proskuryakov.
+
+* MigrateHeaders.make: Removed WKUtilities.h
+
 2017-02-06  Alex Christensen  
 
 credentials should be partitioned by main document domain


Modified: trunk/Source/WebKit/mac/MigrateHeaders.make (211900 => 211901)

--- trunk/Source/WebKit/mac/MigrateHeaders.make	2017-02-08 22:01:53 UTC (rev 211900)
+++ trunk/Source/WebKit/mac/MigrateHeaders.make	2017-02-08 22:04:38 UTC (rev 211901)
@@ -199,7 +199,6 @@
 $(PRIVATE_HEADERS_DIR)/WKContentObservation.h \
 $(PRIVATE_HEADERS_DIR)/WKGraphics.h \
 $(PRIVATE_HEADERS_DIR)/WKTypes.h \
-$(PRIVATE_HEADERS_DIR)/WKUtilities.h \
 $(PRIVATE_HEADERS_DIR)/WebCoreFrameView.h \
 $(PRIVATE_HEADERS_DIR)/WebCoreThread.h \
 $(PRIVATE_HEADERS_DIR)/WebCoreThreadMessage.h \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211925] trunk/Source/WebKit/mac

[aakash_jain]

Title: [211925] trunk/Source/WebKit/mac








Revision 211925
Author aakash_j...@apple.com
Date 2017-02-08 18:13:51 -0800 (Wed, 08 Feb 2017)


Log Message
Don't re-export PluginData.h from WebKit
https://bugs.webkit.org/show_bug.cgi?id=168020

Reviewed by Alexey Proskuryakov.

* MigrateHeaders.make: Removed PluginData.h

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/MigrateHeaders.make




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (211924 => 211925)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-09 02:06:10 UTC (rev 211924)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-09 02:13:51 UTC (rev 211925)
@@ -1,5 +1,14 @@
 2017-02-08  Aakash Jain  
 
+Don't re-export PluginData.h from WebKit
+https://bugs.webkit.org/show_bug.cgi?id=168020
+
+Reviewed by Alexey Proskuryakov.
+
+* MigrateHeaders.make: Removed PluginData.h
+
+2017-02-08  Aakash Jain  
+
 Don't re-export WKUtilities.h from WebKit
 https://bugs.webkit.org/show_bug.cgi?id=167977
 


Modified: trunk/Source/WebKit/mac/MigrateHeaders.make (211924 => 211925)

--- trunk/Source/WebKit/mac/MigrateHeaders.make	2017-02-09 02:06:10 UTC (rev 211924)
+++ trunk/Source/WebKit/mac/MigrateHeaders.make	2017-02-09 02:13:51 UTC (rev 211925)
@@ -189,7 +189,6 @@
 $(PRIVATE_HEADERS_DIR)/DOMHTMLTextAreaElementPrivate.h \
 $(PRIVATE_HEADERS_DIR)/DOMUIKitExtensions.h \
 $(PRIVATE_HEADERS_DIR)/KeyEventCodesIOS.h \
-$(PRIVATE_HEADERS_DIR)/PluginData.h \
 $(PRIVATE_HEADERS_DIR)/ScrollTypes.h \
 $(PRIVATE_HEADERS_DIR)/SystemMemory.h \
 $(PRIVATE_HEADERS_DIR)/WAKAppKitStubs.h \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211389] trunk/Tools

[aakash_jain]

Title: [211389] trunk/Tools








Revision 211389
Author aakash_j...@apple.com
Date 2017-01-30 15:21:57 -0800 (Mon, 30 Jan 2017)


Log Message
QueueStatusServer should have an explicit timeout for _fetch_url
https://bugs.webkit.org/show_bug.cgi?id=167467

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/net/statusserver.py:
(StatusServer._fetch_url): Add an explicit timeout of 300s.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/net/statusserver.py




Diff

Modified: trunk/Tools/ChangeLog (211388 => 211389)

--- trunk/Tools/ChangeLog	2017-01-30 23:03:27 UTC (rev 211388)
+++ trunk/Tools/ChangeLog	2017-01-30 23:21:57 UTC (rev 211389)
@@ -1,3 +1,13 @@
+2017-01-30  Aakash Jain  
+
+QueueStatusServer should have an explicit timeout for _fetch_url
+https://bugs.webkit.org/show_bug.cgi?id=167467
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/common/net/statusserver.py:
+(StatusServer._fetch_url): Add an explicit timeout of 300s.
+
 2017-01-30  Kocsen Chung  
 
 Add support for Trac instances that host multiple projects.


Modified: trunk/Tools/Scripts/webkitpy/common/net/statusserver.py (211388 => 211389)

--- trunk/Tools/Scripts/webkitpy/common/net/statusserver.py	2017-01-30 23:03:27 UTC (rev 211388)
+++ trunk/Tools/Scripts/webkitpy/common/net/statusserver.py	2017-01-30 23:21:57 UTC (rev 211389)
@@ -166,7 +166,7 @@
 def _fetch_url(self, url):
 # FIXME: This should use NetworkTransaction's 404 handling instead.
 try:
-return urllib2.urlopen(url).read()
+return urllib2.urlopen(url, timeout=300).read()
 except urllib2.HTTPError, e:
 if e.code == 404:
 return None






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211156] trunk/Source/WebKit

[aakash_jain]

Title: [211156] trunk/Source/WebKit








Revision 211156
Author aakash_j...@apple.com
Date 2017-01-25 12:02:00 -0800 (Wed, 25 Jan 2017)


Log Message
LoadWebLocalizedStrings method should be moved in correct file
https://bugs.webkit.org/show_bug.cgi?id=167393

Reviewed by Alexey Proskuryakov.

Source/WebKit/ios:

* Misc/WebUIKitSupport.mm:
(LoadWebLocalizedStringsTimerCallback): Moved from WebLocalizableStrings.mm
(LoadWebLocalizedStrings): Moved from WebLocalizableStrings.mm

Source/WebKit/mac:

* Misc/WebLocalizableStrings.h: Deleted LoadWebLocalizedStrings method.
* Misc/WebLocalizableStrings.mm:
(LoadWebLocalizedStringsTimerCallback): Deleted, moved to WebUIKitSupport.mm
(LoadWebLocalizedStrings): Deleted, moved to WebUIKitSupport.mm

Modified Paths

trunk/Source/WebKit/ios/ChangeLog
trunk/Source/WebKit/ios/Misc/WebUIKitSupport.mm
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.h
trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.mm




Diff

Modified: trunk/Source/WebKit/ios/ChangeLog (211155 => 211156)

--- trunk/Source/WebKit/ios/ChangeLog	2017-01-25 19:14:18 UTC (rev 211155)
+++ trunk/Source/WebKit/ios/ChangeLog	2017-01-25 20:02:00 UTC (rev 211156)
@@ -1,3 +1,14 @@
+2017-01-25  Aakash Jain  
+
+LoadWebLocalizedStrings method should be moved in correct file
+https://bugs.webkit.org/show_bug.cgi?id=167393
+
+Reviewed by Alexey Proskuryakov.
+
+* Misc/WebUIKitSupport.mm:
+(LoadWebLocalizedStringsTimerCallback): Moved from WebLocalizableStrings.mm
+(LoadWebLocalizedStrings): Moved from WebLocalizableStrings.mm
+
 2017-01-21  Darin Adler  
 
 Remove PassRefPtr from "page" directory of WebCore, also deploy references


Modified: trunk/Source/WebKit/ios/Misc/WebUIKitSupport.mm (211155 => 211156)

--- trunk/Source/WebKit/ios/Misc/WebUIKitSupport.mm	2017-01-25 19:14:18 UTC (rev 211155)
+++ trunk/Source/WebKit/ios/Misc/WebUIKitSupport.mm	2017-01-25 20:02:00 UTC (rev 211156)
@@ -29,7 +29,7 @@
 
 #import "WebDatabaseManagerInternal.h"
 #import "WebKitSystemInterface.h"
-#import "WebLocalizableStrings.h"
+#import "WebLocalizableStringsInternal.h"
 #import "WebPlatformStrategies.h"
 #import "WebSystemInterface.h"
 #import "WebViewPrivate.h"
@@ -51,6 +51,23 @@
 return s_linkedOnOrAfterIOS5;
 }
 
+// See  Optimize WebLocalizedString for why we do this on a background thread on a timer callback
+static void LoadWebLocalizedStringsTimerCallback(CFRunLoopTimerRef timer, void *info)
+{
+dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_LOW, 0), ^ {
+// We don't care if we find this string, but searching for it will load the plist and save the results.
+// FIXME: It would be nicer to do this in a more direct way.
+UI_STRING_KEY_INTERNAL("Typing", "Typing (Undo action name)", "Undo action name");
+});
+}
+
+static void LoadWebLocalizedStrings()
+{
+CFRunLoopTimerRef timer = CFRunLoopTimerCreate(kCFAllocatorDefault, CFAbsoluteTimeGetCurrent(), 0, 0, 0, , NULL);
+CFRunLoopAddTimer(CFRunLoopGetCurrent(), timer, kCFRunLoopCommonModes);
+CFRelease(timer);
+}
+
 void WebKitInitialize(void)
 {
 static bool webkitInitialized;


Modified: trunk/Source/WebKit/mac/ChangeLog (211155 => 211156)

--- trunk/Source/WebKit/mac/ChangeLog	2017-01-25 19:14:18 UTC (rev 211155)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-01-25 20:02:00 UTC (rev 211156)
@@ -1,3 +1,15 @@
+2017-01-25  Aakash Jain  
+
+LoadWebLocalizedStrings method should be moved in correct file
+https://bugs.webkit.org/show_bug.cgi?id=167393
+
+Reviewed by Alexey Proskuryakov.
+
+* Misc/WebLocalizableStrings.h: Deleted LoadWebLocalizedStrings method.
+* Misc/WebLocalizableStrings.mm:
+(LoadWebLocalizedStringsTimerCallback): Deleted, moved to WebUIKitSupport.mm
+(LoadWebLocalizedStrings): Deleted, moved to WebUIKitSupport.mm
+
 2017-01-24  Zalan Bujtas  
 
 Add simple line layout toggle to MiniBrowser


Modified: trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.h (211155 => 211156)

--- trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.h	2017-01-25 19:14:18 UTC (rev 211155)
+++ trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.h	2017-01-25 20:02:00 UTC (rev 211156)
@@ -49,10 +49,6 @@
 
 WebLocalizedStringType WebLocalizedString(WebLocalizableStringsBundle* bundle, const char* key);
 
-#if TARGET_OS_IPHONE
-void LoadWebLocalizedStrings(void); // The first WebLocalizedString call can take over 20ms unless this function is called beforehand.
-#endif
-
 #ifdef __cplusplus
 }
 #endif


Modified: trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.mm (211155 => 211156)

--- trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.mm	2017-01-25 19:14:18 UTC (rev 211155)
+++ trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.mm	2017-01-25 20:02:00 UTC (rev 211156)
@@ -31,11 +31,6 @@
 

[webkit-changes] [212795] trunk/Source/WebKit

[aakash_jain]

Title: [212795] trunk/Source/WebKit








Revision 212795
Author aakash_j...@apple.com
Date 2017-02-21 18:42:43 -0800 (Tue, 21 Feb 2017)


Log Message
Make WebKitStatisticsPrivate.h project header
https://bugs.webkit.org/show_bug.cgi?id=168686

Reviewed by Alexey Proskuryakov.

* WebKit.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebKit/ChangeLog (212794 => 212795)

--- trunk/Source/WebKit/ChangeLog	2017-02-22 02:42:35 UTC (rev 212794)
+++ trunk/Source/WebKit/ChangeLog	2017-02-22 02:42:43 UTC (rev 212795)
@@ -1,3 +1,12 @@
+2017-02-21  Aakash Jain  
+
+Make WebKitStatisticsPrivate.h project header
+https://bugs.webkit.org/show_bug.cgi?id=168686
+
+Reviewed by Alexey Proskuryakov.
+
+* WebKit.xcodeproj/project.pbxproj:
+
 2017-02-21  Commit Queue  
 
 Unreviewed, rolling out r212768.


Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (212794 => 212795)

--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2017-02-22 02:42:35 UTC (rev 212794)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2017-02-22 02:42:43 UTC (rev 212795)
@@ -201,7 +201,7 @@
 		9398101D0824BF01008DF038 /* WebKitLogging.h in Headers */ = {isa = PBXBuildFile; fileRef = 93AEB17D032C1735008635CE /* WebKitLogging.h */; settings = {ATTRIBUTES = (); }; };
 		9398101E0824BF01008DF038 /* WebKitNSStringExtras.h in Headers */ = {isa = PBXBuildFile; fileRef = 7082F56F038EADAA00A80180 /* WebKitNSStringExtras.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		9398101F0824BF01008DF038 /* WebKitStatistics.h in Headers */ = {isa = PBXBuildFile; fileRef = F53444CE02E87CBA018635CA /* WebKitStatistics.h */; settings = {ATTRIBUTES = (Private, ); }; };
-		939810200824BF01008DF038 /* WebKitStatisticsPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = F53444D202E87D4B018635CA /* WebKitStatisticsPrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
+		939810200824BF01008DF038 /* WebKitStatisticsPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = F53444D202E87D4B018635CA /* WebKitStatisticsPrivate.h */; };
 		939810210824BF01008DF038 /* WebNSControlExtras.h in Headers */ = {isa = PBXBuildFile; fileRef = 9345DDB20365FFD0008635CE /* WebNSControlExtras.h */; };
 		939810220824BF01008DF038 /* WebNSImageExtras.h in Headers */ = {isa = PBXBuildFile; fileRef = 8398847A03426FB000BC5F5E /* WebNSImageExtras.h */; };
 		939810230824BF01008DF038 /* WebNSPasteboardExtras.h in Headers */ = {isa = PBXBuildFile; fileRef = ED2B2474033A2DA800C1A526 /* WebNSPasteboardExtras.h */; settings = {ATTRIBUTES = (Private, ); }; };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212792] trunk/Source/WebKit/mac

[aakash_jain]

Title: [212792] trunk/Source/WebKit/mac








Revision 212792
Author aakash_j...@apple.com
Date 2017-02-21 18:39:31 -0800 (Tue, 21 Feb 2017)


Log Message
Export various NSString symbols from WebViewPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=168689

Reviewed by Alexey Proskuryakov.

* WebKit.exp:

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebKit.exp




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (212791 => 212792)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-22 02:29:48 UTC (rev 212791)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-22 02:39:31 UTC (rev 212792)
@@ -1,3 +1,12 @@
+2017-02-21  Aakash Jain  
+
+Export various NSString symbols from WebViewPrivate.h
+https://bugs.webkit.org/show_bug.cgi?id=168689
+
+Reviewed by Alexey Proskuryakov.
+
+* WebKit.exp:
+
 2017-02-21  Commit Queue  
 
 Unreviewed, rolling out r212768.


Modified: trunk/Source/WebKit/mac/WebKit.exp (212791 => 212792)

--- trunk/Source/WebKit/mac/WebKit.exp	2017-02-22 02:29:48 UTC (rev 212791)
+++ trunk/Source/WebKit/mac/WebKit.exp	2017-02-22 02:39:31 UTC (rev 212792)
@@ -193,6 +193,8 @@
 _WebElementImageKey
 _WebElementImageRectKey
 _WebElementImageURLKey
+_WebElementIsContentEditableKey
+_WebElementIsInScrollBarKey
 _WebElementIsSelectedKey
 _WebElementLinkIsLiveKey
 _WebElementLinkLabelKey
@@ -200,6 +202,8 @@
 _WebElementLinkTitleKey
 _WebElementLinkURLKey
 _WebElementMediaURLKey
+_WebElementSpellingToolTipKey
+_WebElementTitleKey
 _WebFrameCanSuspendActiveDOMObjects
 _WebFrameHasPlugins
 _WebFrameHasUnloadListener






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212805] trunk/Source/WebKit/mac

[aakash_jain]

Title: [212805] trunk/Source/WebKit/mac








Revision 212805
Author aakash_j...@apple.com
Date 2017-02-21 21:08:54 -0800 (Tue, 21 Feb 2017)


Log Message
Export various NSString symbols from WebPreferencesPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=168701

Reviewed by Alexey Proskuryakov.

* WebKit.exp:

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebKit.exp




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (212804 => 212805)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-22 04:42:53 UTC (rev 212804)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-22 05:08:54 UTC (rev 212805)
@@ -1,3 +1,12 @@
+2017-02-21  Aakash Jain  
+
+Export various NSString symbols from WebPreferencesPrivate.h
+https://bugs.webkit.org/show_bug.cgi?id=168701
+
+Reviewed by Alexey Proskuryakov.
+
+* WebKit.exp:
+
 2017-02-21  Joseph Pecoraro  
 
 Add missing WebConsoleMessage string key


Modified: trunk/Source/WebKit/mac/WebKit.exp (212804 => 212805)

--- trunk/Source/WebKit/mac/WebKit.exp	2017-02-22 04:42:53 UTC (rev 212804)
+++ trunk/Source/WebKit/mac/WebKit.exp	2017-02-22 05:08:54 UTC (rev 212805)
@@ -236,7 +236,10 @@
 _WebPlugInContainingElementKey
 _WebPlugInModeKey
 _WebPlugInShouldLoadMainResourceKey
+_WebPreferencesCacheModelChangedInternalNotification
+_WebPreferencesChangedInternalNotification
 _WebPreferencesChangedNotification
+_WebPreferencesRemovedNotification
 _WebScriptErrorDescriptionKey
 _WebScriptErrorDomain
 _WebScriptErrorLineNumberKey






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212809] trunk/Source/WebKit/mac

[aakash_jain]

Title: [212809] trunk/Source/WebKit/mac








Revision 212809
Author aakash_j...@apple.com
Date 2017-02-21 22:57:13 -0800 (Tue, 21 Feb 2017)


Log Message
Export various NSString symbols from WebFramePrivate.h
https://bugs.webkit.org/show_bug.cgi?id=168702

Reviewed by Alexey Proskuryakov.

* WebKit.exp:

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebKit.exp




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (212808 => 212809)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-22 06:55:54 UTC (rev 212808)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-22 06:57:13 UTC (rev 212809)
@@ -1,5 +1,14 @@
 2017-02-21  Aakash Jain  
 
+Export various NSString symbols from WebFramePrivate.h
+https://bugs.webkit.org/show_bug.cgi?id=168702
+
+Reviewed by Alexey Proskuryakov.
+
+* WebKit.exp:
+
+2017-02-21  Aakash Jain  
+
 Export various NSString symbols from WebPreferencesPrivate.h
 https://bugs.webkit.org/show_bug.cgi?id=168701
 


Modified: trunk/Source/WebKit/mac/WebKit.exp (212808 => 212809)

--- trunk/Source/WebKit/mac/WebKit.exp	2017-02-22 06:55:54 UTC (rev 212808)
+++ trunk/Source/WebKit/mac/WebKit.exp	2017-02-22 06:57:13 UTC (rev 212809)
@@ -230,6 +230,9 @@
 _WebKitLocalCacheDefaultsKey
 _WebKitResourceLoadStatisticsDirectoryDefaultsKey
 _WebLocalizedString
+_WebPageCacheDataSourceKey
+_WebPageCacheDocumentViewKey
+_WebPageCacheEntryDateKey
 _WebPlugInAttributesKey
 _WebPlugInBaseURLKey
 _WebPlugInContainerKey






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212770] trunk/Source/WebKit/mac

[aakash_jain]

Title: [212770] trunk/Source/WebKit/mac








Revision 212770
Author aakash_j...@apple.com
Date 2017-02-21 15:16:43 -0800 (Tue, 21 Feb 2017)


Log Message
Export symbols for various classes present in webkit SPI
https://bugs.webkit.org/show_bug.cgi?id=168674

Reviewed by Dan Bernstein.

* WebKit.exp:

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebKit.exp




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (212769 => 212770)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-21 23:16:02 UTC (rev 212769)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-21 23:16:43 UTC (rev 212770)
@@ -1,3 +1,12 @@
+2017-02-21  Aakash Jain  
+
+Export symbols for various classes present in webkit SPI
+https://bugs.webkit.org/show_bug.cgi?id=168674
+
+Reviewed by Dan Bernstein.
+
+* WebKit.exp:
+
 2017-02-21  Andreas Kling  
 
 [iOS] Remove old WebKit1 MemoryMeasure helper.


Modified: trunk/Source/WebKit/mac/WebKit.exp (212769 => 212770)

--- trunk/Source/WebKit/mac/WebKit.exp	2017-02-21 23:16:02 UTC (rev 212769)
+++ trunk/Source/WebKit/mac/WebKit.exp	2017-02-21 23:16:43 UTC (rev 212770)
@@ -98,6 +98,7 @@
 .objc_class_name_DOMNode
 .objc_class_name_DOMNodeIterator
 .objc_class_name_DOMNodeList
+.objc_class_name_DOMObject
 .objc_class_name_DOMOverflowEvent
 .objc_class_name_DOMProcessingInstruction
 .objc_class_name_DOMProgressEvent
@@ -121,13 +122,16 @@
 .objc_class_name_WebCoreStatistics
 .objc_class_name_WebDataSource
 .objc_class_name_WebDatabaseManager
+.objc_class_name_WebDatabaseQuotaManager
 .objc_class_name_WebDefaultPolicyDelegate
 .objc_class_name_WebDeviceOrientation
 .objc_class_name_WebDeviceOrientationProviderMock
 .objc_class_name_WebDownload
+.objc_class_name_WebFixedPositionContent
 .objc_class_name_WebFormDelegate
 .objc_class_name_WebFrame
 .objc_class_name_WebFrameView
+.objc_class_name_WebGeolocation
 .objc_class_name_WebGeolocationPosition
 .objc_class_name_WebHTMLRepresentation
 .objc_class_name_WebHTMLView
@@ -135,7 +139,10 @@
 .objc_class_name_WebHistoryItem
 .objc_class_name_WebInspector
 .objc_class_name_WebKitStatistics
+.objc_class_name_WebNavigationData
+.objc_class_name_WebNotification
 .objc_class_name_WebPluginDatabase
+.objc_class_name_WebPolicyDecisionListener
 .objc_class_name_WebPreferences
 .objc_class_name_WebResource
 .objc_class_name_WebScriptCallFrame
@@ -145,6 +152,8 @@
 .objc_class_name_WebTextIterator
 .objc_class_name_WebUserContentURLPattern
 .objc_class_name_WebView
+.objc_class_name_WebVisiblePosition
+.objc_class_name_WKQuadObject
 _DOMException
 _DOMRangeException
 _DOMEventException






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212774] trunk/Source/WebKit/mac

[aakash_jain]

Title: [212774] trunk/Source/WebKit/mac








Revision 212774
Author aakash_j...@apple.com
Date 2017-02-21 15:49:42 -0800 (Tue, 21 Feb 2017)


Log Message
Export various NSString symbols from WebUIDelegatePrivate.h
https://bugs.webkit.org/show_bug.cgi?id=168679

Reviewed by Joseph Pecoraro.

* WebKit.exp:

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebKit.exp




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (212773 => 212774)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-21 23:25:49 UTC (rev 212773)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-21 23:49:42 UTC (rev 212774)
@@ -1,5 +1,14 @@
 2017-02-21  Aakash Jain  
 
+Export various NSString symbols from WebUIDelegatePrivate.h
+https://bugs.webkit.org/show_bug.cgi?id=168679
+
+Reviewed by Joseph Pecoraro.
+
+* WebKit.exp:
+
+2017-02-21  Aakash Jain  
+
 Export symbols for various classes present in webkit SPI
 https://bugs.webkit.org/show_bug.cgi?id=168674
 


Modified: trunk/Source/WebKit/mac/WebKit.exp (212773 => 212774)

--- trunk/Source/WebKit/mac/WebKit.exp	2017-02-21 23:25:49 UTC (rev 212773)
+++ trunk/Source/WebKit/mac/WebKit.exp	2017-02-21 23:49:42 UTC (rev 212774)
@@ -165,6 +165,21 @@
 _WebActionNavigationTypeKey
 _WebActionOriginalURLKey
 _WebArchivePboardType
+_WebConsoleMessageAppCacheMessageSource
+_WebConsoleMessageCSSMessageSource
+_WebConsoleMessageConsoleAPIMessageSource
+_WebConsoleMessageDebugMessageLevel
+_WebConsoleMessageErrorMessageLevel
+_WebConsoleMessageInfoMessageLevel
+_WebConsoleMessageJSMessageSource
+_WebConsoleMessageLogMessageLevel
+_WebConsoleMessageNetworkMessageSource
+_WebConsoleMessageOtherMessageSource
+_WebConsoleMessageRenderingMessageSource
+_WebConsoleMessageSecurityMessageSource
+_WebConsoleMessageStorageMessageSource
+_WebConsoleMessageWarningMessageLevel
+_WebConsoleMessageXMLMessageSource
 _WebDatabaseDidModifyDatabaseNotification
 _WebDatabaseDidModifyOriginNotification
 _WebDatabaseDirectoryDefaultsKey






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212641] trunk/Source/WebKit/mac

[aakash_jain]

Title: [212641] trunk/Source/WebKit/mac








Revision 212641
Author aakash_j...@apple.com
Date 2017-02-20 09:20:04 -0800 (Mon, 20 Feb 2017)


Log Message
Stop exporting DOMNodeFilter
https://bugs.webkit.org/show_bug.cgi?id=168542

Reviewed by Alexey Proskuryakov.

* WebKit.exp:

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebKit.exp




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (212640 => 212641)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-20 17:18:27 UTC (rev 212640)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-20 17:20:04 UTC (rev 212641)
@@ -1,3 +1,12 @@
+2017-02-20  Aakash Jain  
+
+Stop exporting DOMNodeFilter
+https://bugs.webkit.org/show_bug.cgi?id=168542
+
+Reviewed by Alexey Proskuryakov.
+
+* WebKit.exp:
+
 2017-02-20  Manuel Rego Casasnovas  
 
 [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT


Modified: trunk/Source/WebKit/mac/WebKit.exp (212640 => 212641)

--- trunk/Source/WebKit/mac/WebKit.exp	2017-02-20 17:18:27 UTC (rev 212640)
+++ trunk/Source/WebKit/mac/WebKit.exp	2017-02-20 17:20:04 UTC (rev 212641)
@@ -96,7 +96,6 @@
 .objc_class_name_DOMMutationEvent
 .objc_class_name_DOMNamedNodeMap
 .objc_class_name_DOMNode
-.objc_class_name_DOMNodeFilter
 .objc_class_name_DOMNodeIterator
 .objc_class_name_DOMNodeList
 .objc_class_name_DOMOverflowEvent






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212643] trunk/Source/WebKit/mac

[aakash_jain]

Title: [212643] trunk/Source/WebKit/mac








Revision 212643
Author aakash_j...@apple.com
Date 2017-02-20 09:24:06 -0800 (Mon, 20 Feb 2017)


Log Message
Stop exporting DOMTokenList from WebKit
https://bugs.webkit.org/show_bug.cgi?id=168544

Reviewed by Alexey Proskuryakov.

* WebKit.exp:

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebKit.exp




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (212642 => 212643)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-20 17:22:56 UTC (rev 212642)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-20 17:24:06 UTC (rev 212643)
@@ -1,3 +1,12 @@
+2017-02-20  Aakash Jain  
+
+Stop exporting DOMTokenList from WebKit
+https://bugs.webkit.org/show_bug.cgi?id=168544
+
+Reviewed by Alexey Proskuryakov.
+
+* WebKit.exp:
+
 2017-02-20  Alexey Proskuryakov  
 
 Clean up how WebKit exports _WebCreateFragment


Modified: trunk/Source/WebKit/mac/WebKit.exp (212642 => 212643)

--- trunk/Source/WebKit/mac/WebKit.exp	2017-02-20 17:22:56 UTC (rev 212642)
+++ trunk/Source/WebKit/mac/WebKit.exp	2017-02-20 17:24:06 UTC (rev 212643)
@@ -109,7 +109,6 @@
 .objc_class_name_DOMText
 .objc_class_name_DOMTextEvent
 .objc_class_name_DOMTimeRanges
-.objc_class_name_DOMTokenList
 .objc_class_name_DOMTreeWalker
 .objc_class_name_DOMUIEvent
 .objc_class_name_DOMWheelEvent






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212654] trunk/Source/WebKit/ios

[aakash_jain]

Title: [212654] trunk/Source/WebKit/ios








Revision 212654
Author aakash_j...@apple.com
Date 2017-02-20 10:14:58 -0800 (Mon, 20 Feb 2017)


Log Message
Stop exporting WebPluginController from WebKit
https://bugs.webkit.org/show_bug.cgi?id=168603

Reviewed by Alexey Proskuryakov.

* WebKit.iOS.exp:

Modified Paths

trunk/Source/WebKit/ios/ChangeLog
trunk/Source/WebKit/ios/WebKit.iOS.exp




Diff

Modified: trunk/Source/WebKit/ios/ChangeLog (212653 => 212654)

--- trunk/Source/WebKit/ios/ChangeLog	2017-02-20 18:00:58 UTC (rev 212653)
+++ trunk/Source/WebKit/ios/ChangeLog	2017-02-20 18:14:58 UTC (rev 212654)
@@ -1,3 +1,12 @@
+2017-02-20  Aakash Jain  
+
+Stop exporting WebPluginController from WebKit
+https://bugs.webkit.org/show_bug.cgi?id=168603
+
+Reviewed by Alexey Proskuryakov.
+
+* WebKit.iOS.exp:
+
 2017-02-10  Aakash Jain  
 
 WebKitLegacy doesn't re-export various symbols from WebCore required by clients


Modified: trunk/Source/WebKit/ios/WebKit.iOS.exp (212653 => 212654)

--- trunk/Source/WebKit/ios/WebKit.iOS.exp	2017-02-20 18:00:58 UTC (rev 212653)
+++ trunk/Source/WebKit/ios/WebKit.iOS.exp	2017-02-20 18:14:58 UTC (rev 212654)
@@ -4,7 +4,6 @@
 .objc_class_name_WebMIMETypeRegistry
 .objc_class_name_WebPDFView
 .objc_class_name_WebPDFViewPlaceholder
-.objc_class_name_WebPluginController
 .objc_class_name_WebScriptObject
 .objc_class_name_WebSelectionRect
 .objc_class_name_WebUndefined






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212694] trunk/Source/WebKit/mac

[aakash_jain]

Title: [212694] trunk/Source/WebKit/mac








Revision 212694
Author aakash_j...@apple.com
Date 2017-02-20 18:23:39 -0800 (Mon, 20 Feb 2017)


Log Message
Exclude various mac-specific header files from iOS build
https://bugs.webkit.org/show_bug.cgi?id=168621

Reviewed by Dan Bernstein.

* Configurations/WebKitLegacy.xcconfig:

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (212693 => 212694)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-21 02:12:04 UTC (rev 212693)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-21 02:23:39 UTC (rev 212694)
@@ -1,3 +1,12 @@
+2017-02-20  Aakash Jain  
+
+Exclude various mac-specific header files from iOS build
+https://bugs.webkit.org/show_bug.cgi?id=168621
+
+Reviewed by Dan Bernstein.
+
+* Configurations/WebKitLegacy.xcconfig:
+
 2017-02-20  Wenson Hsieh  
 
 Add plumbing to the UI process for TextIndicatorData when computing the drag image


Modified: trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig (212693 => 212694)

--- trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig	2017-02-21 02:12:04 UTC (rev 212693)
+++ trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig	2017-02-21 02:23:39 UTC (rev 212694)
@@ -24,7 +24,7 @@
 #include "FeatureDefines.xcconfig"
 #include "Version.xcconfig"
 
-EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = *.defs *.nib *.pdf *.tiff CarbonUtils.m CarbonWindowAdapter.mm CarbonWindowContentView.m CarbonWindowFrame.m HIViewAdapter.m HIWebView.mm OutlookQuirksUserScript.js PopupMenuMac.mm SearchPopupMenuMac.mm WebClipView.* WebDashboardRegion.* WebDynamicScrollBarsView.* WebIconDatabase.* WebIconDatabasePrivate.* WebInspectorClient.mm WebJavaScriptTextInputPanel.* WebNSEventExtras.* WebNSPasteboardExtras.* WebNSWindowExtras.* WebPanelAuthenticationHandler.* WebPluginsPrivate.* WebStringTruncator.* WebTextCompletionController.*;
+EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = *.defs *.nib *.pdf *.tiff CarbonUtils.* CarbonWindowAdapter.* CarbonWindowContentView.* CarbonWindowFrame.* HIViewAdapter.* HIWebView.* OutlookQuirksUserScript.js PopupMenuMac.* SearchPopupMenuMac.* WebClipView.* WebDashboardRegion.* WebDynamicScrollBarsView.* WebIconDatabase.* WebIconDatabasePrivate.* WebInspectorClient.* WebJavaScriptTextInputPanel.* WebNSEventExtras.* WebNSPasteboardExtras.* WebNSWindowExtras.* WebPanelAuthenticationHandler.* WebPluginsPrivate.* WebStringTruncator.* WebTextCompletionController.*;
 EXCLUDED_SOURCE_FILE_NAMES[sdk=macosx*] = *IOS.mm MemoryMeasure.h WebCaretChangeListener.h WebFixedPositionContent.h WebFrameIOS.h WebFrameIPhone.h WebGeolocationCoreLocationProvider.h WebGeolocationPrivate.h WebGeolocationProviderIOS.h WebMIMETypeRegistry.h WebNSStringExtrasIOS.h WebNSStringExtrasIPhone.h WebPDFViewIOS.h WebPDFViewIPhone.h WebPDFViewPlaceholder.h WebSelectionRect.h WebUIKitDelegate.h WebUIKitSupport.h WebVisiblePosition.h DOMHTMLTextAreaElementPrivate.h DOMUIKitExtensions.h;
 
 EXPORTED_SYMBOLS_FILE = $(EXPORTED_SYMBOLS_FILE_$(CURRENT_ARCH));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212697] trunk/Source/WebKit/mac

[aakash_jain]

Title: [212697] trunk/Source/WebKit/mac








Revision 212697
Author aakash_j...@apple.com
Date 2017-02-20 20:44:17 -0800 (Mon, 20 Feb 2017)


Log Message
Stop exporting interface WebCoreScrollView on iOS
https://bugs.webkit.org/show_bug.cgi?id=168536

Reviewed by Dan Bernstein.

* WebKit.exp: Moved symbol for WebCoreScrollView interface to mac specific file.
* WebKit.mac.exp: Ditto.
* WebView/WebHTMLView.mm: WebCoreScrollView shouldn't be defined for iOS platform.

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebKit.exp
trunk/Source/WebKit/mac/WebKit.mac.exp
trunk/Source/WebKit/mac/WebView/WebHTMLView.mm




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (212696 => 212697)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-21 02:35:35 UTC (rev 212696)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-21 04:44:17 UTC (rev 212697)
@@ -1,5 +1,16 @@
 2017-02-20  Aakash Jain  
 
+Stop exporting interface WebCoreScrollView on iOS
+https://bugs.webkit.org/show_bug.cgi?id=168536
+
+Reviewed by Dan Bernstein.
+
+* WebKit.exp: Moved symbol for WebCoreScrollView interface to mac specific file.
+* WebKit.mac.exp: Ditto.
+* WebView/WebHTMLView.mm: WebCoreScrollView shouldn't be defined for iOS platform.
+
+2017-02-20  Aakash Jain  
+
 Exclude various mac-specific header files from iOS build
 https://bugs.webkit.org/show_bug.cgi?id=168621
 


Modified: trunk/Source/WebKit/mac/WebKit.exp (212696 => 212697)

--- trunk/Source/WebKit/mac/WebKit.exp	2017-02-21 02:35:35 UTC (rev 212696)
+++ trunk/Source/WebKit/mac/WebKit.exp	2017-02-21 04:44:17 UTC (rev 212697)
@@ -118,7 +118,6 @@
 .objc_class_name_WebArchive
 .objc_class_name_WebBackForwardList
 .objc_class_name_WebCache
-.objc_class_name_WebCoreScrollView
 .objc_class_name_WebCoreStatistics
 .objc_class_name_WebDataSource
 .objc_class_name_WebDatabaseManager


Modified: trunk/Source/WebKit/mac/WebKit.mac.exp (212696 => 212697)

--- trunk/Source/WebKit/mac/WebKit.mac.exp	2017-02-21 02:35:35 UTC (rev 212696)
+++ trunk/Source/WebKit/mac/WebKit.mac.exp	2017-02-21 04:44:17 UTC (rev 212697)
@@ -1,3 +1,4 @@
+.objc_class_name_WebCoreScrollView
 .objc_class_name_WebDynamicScrollBarsView
 .objc_class_name_WebIconDatabase
 .objc_class_name_WebJavaScriptTextInputPanel


Modified: trunk/Source/WebKit/mac/WebView/WebHTMLView.mm (212696 => 212697)

--- trunk/Source/WebKit/mac/WebView/WebHTMLView.mm	2017-02-21 02:35:35 UTC (rev 212696)
+++ trunk/Source/WebKit/mac/WebView/WebHTMLView.mm	2017-02-21 04:44:17 UTC (rev 212697)
@@ -778,6 +778,7 @@
 // Fake URL scheme.
 #define WebDataProtocolScheme @"webkit-fake-url"
 
+#if !PLATFORM(IOS)
 //  References to WebCoreScrollView as a subview of a WebHTMLView may be present
 // in some NIB files, so NSUnarchiver must be still able to look up this now-unused class.
 @interface WebCoreScrollView : NSScrollView
@@ -786,7 +787,6 @@
 @implementation WebCoreScrollView
 @end
 
-#if !PLATFORM(IOS)
 // We need this to be able to safely reference the CachedImage for the promised drag data
 static CachedImageClient& promisedDataClient()
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212473] trunk/Source/WebKit2

[aakash_jain]

Title: [212473] trunk/Source/WebKit2








Revision 212473
Author aakash_j...@apple.com
Date 2017-02-16 15:18:40 -0800 (Thu, 16 Feb 2017)


Log Message
Remove unused WKContextGetProcessSuppressionEnabled and WKContextSetProcessSuppressionEnabled
https://bugs.webkit.org/show_bug.cgi?id=168460

Reviewed by Dan Bernstein.

* UIProcess/API/C/mac/WKContextPrivateMac.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (212472 => 212473)

--- trunk/Source/WebKit2/ChangeLog	2017-02-16 23:16:36 UTC (rev 212472)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-16 23:18:40 UTC (rev 212473)
@@ -1,5 +1,14 @@
 2017-02-16  Aakash Jain  
 
+Remove unused WKContextGetProcessSuppressionEnabled and WKContextSetProcessSuppressionEnabled
+https://bugs.webkit.org/show_bug.cgi?id=168460
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/API/C/mac/WKContextPrivateMac.h:
+
+2017-02-16  Aakash Jain  
+
 Removed unused method WKContextGetProcessModel
 https://bugs.webkit.org/show_bug.cgi?id=168457
 


Modified: trunk/Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.h (212472 => 212473)

--- trunk/Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.h	2017-02-16 23:16:36 UTC (rev 212472)
+++ trunk/Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.h	2017-02-16 23:18:40 UTC (rev 212473)
@@ -33,9 +33,6 @@
 extern "C" {
 #endif
 
-WK_EXPORT bool WKContextGetProcessSuppressionEnabled(WKContextRef context);
-WK_EXPORT void WKContextSetProcessSuppressionEnabled(WKContextRef context, bool enabled);
-
 WK_EXPORT bool WKContextIsPlugInUpdateAvailable(WKContextRef context, WKStringRef plugInBundleIdentifier);
 
 WK_EXPORT void WKContextSetPluginLoadClientPolicy(WKContextRef context, WKPluginLoadClientPolicy policy, WKStringRef host, WKStringRef bundleIdentifier, WKStringRef versionString);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212475] trunk/Source/WebKit2

[aakash_jain]

Title: [212475] trunk/Source/WebKit2








Revision 212475
Author aakash_j...@apple.com
Date 2017-02-16 15:26:53 -0800 (Thu, 16 Feb 2017)


Log Message
Remove unused method WKBundlePageCopyContextMenuItemTitle
https://bugs.webkit.org/show_bug.cgi?id=168456

Reviewed by Dan Bernstein.

* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Removed WKBundlePageCopyContextMenuItemTitle.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (212474 => 212475)

--- trunk/Source/WebKit2/ChangeLog	2017-02-16 23:22:01 UTC (rev 212474)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-16 23:26:53 UTC (rev 212475)
@@ -1,5 +1,14 @@
 2017-02-16  Aakash Jain  
 
+Remove unused method WKBundlePageCopyContextMenuItemTitle
+https://bugs.webkit.org/show_bug.cgi?id=168456
+
+Reviewed by Dan Bernstein.
+
+* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Removed WKBundlePageCopyContextMenuItemTitle.
+
+2017-02-16  Aakash Jain  
+
 Remove unused WKContextGetProcessSuppressionEnabled and WKContextSetProcessSuppressionEnabled
 https://bugs.webkit.org/show_bug.cgi?id=168460
 


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h (212474 => 212475)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h	2017-02-16 23:22:01 UTC (rev 212474)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h	2017-02-16 23:26:53 UTC (rev 212475)
@@ -85,7 +85,6 @@
 WK_EXPORT void WKAccessibilityEnableEnhancedAccessibility(bool);
 WK_EXPORT bool WKAccessibilityEnhancedAccessibilityEnabled();
 
-WK_EXPORT WKStringRef WKBundlePageCopyContextMenuItemTitle(WKContextMenuItemRef);
 WK_EXPORT void WKBundlePageClickMenuItem(WKBundlePageRef, WKContextMenuItemRef);
 WK_EXPORT WKArrayRef WKBundlePageCopyContextMenuItems(WKBundlePageRef);
 WK_EXPORT WKArrayRef WKBundlePageCopyContextMenuAtPointInWindow(WKBundlePageRef, WKPoint);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212471] trunk/Source/WebKit2

[aakash_jain]

Title: [212471] trunk/Source/WebKit2








Revision 212471
Author aakash_j...@apple.com
Date 2017-02-16 15:16:13 -0800 (Thu, 16 Feb 2017)


Log Message
Removed unused method WKContextGetProcessModel
https://bugs.webkit.org/show_bug.cgi?id=168457

Reviewed by Dan Bernstein.

* UIProcess/API/C/WKContext.h: Removed WKContextGetProcessModel.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKContext.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (212470 => 212471)

--- trunk/Source/WebKit2/ChangeLog	2017-02-16 23:13:45 UTC (rev 212470)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-16 23:16:13 UTC (rev 212471)
@@ -1,3 +1,12 @@
+2017-02-16  Aakash Jain  
+
+Removed unused method WKContextGetProcessModel
+https://bugs.webkit.org/show_bug.cgi?id=168457
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/API/C/WKContext.h: Removed WKContextGetProcessModel.
+
 2017-02-16  Tim Horton  
 
 WKWebView inside a UICollectionView flashes when items are inserted above it


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.h (212470 => 212471)

--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.h	2017-02-16 23:13:45 UTC (rev 212470)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.h	2017-02-16 23:16:13 UTC (rev 212471)
@@ -132,7 +132,6 @@
 
 // FIXME: Move these to WKDeprecatedFunctions.cpp once support for Mavericks has been dropped.
 WK_EXPORT void WKContextSetProcessModel(WKContextRef, WKProcessModel);
-WK_EXPORT WKProcessModel WKContextGetProcessModel(WKContextRef);
 
 WK_EXPORT void WKContextSetMaximumNumberOfProcesses(WKContextRef context, unsigned numberOfProcesses);
 WK_EXPORT unsigned WKContextGetMaximumNumberOfProcesses(WKContextRef context);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212591] trunk/Tools

[aakash_jain]

Title: [212591] trunk/Tools








Revision 212591
Author aakash_j...@apple.com
Date 2017-02-17 15:49:59 -0800 (Fri, 17 Feb 2017)


Log Message
Fix failure from r212579.

Unreviewed build-fix.

* Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
(CheckPatchRelevance._changes_are_relevant): Return true for all groups others than jsc for now.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/steps/checkpatchrelevance.py




Diff

Modified: trunk/Tools/ChangeLog (212590 => 212591)

--- trunk/Tools/ChangeLog	2017-02-17 23:41:37 UTC (rev 212590)
+++ trunk/Tools/ChangeLog	2017-02-17 23:49:59 UTC (rev 212591)
@@ -1,3 +1,12 @@
+2017-02-17  Aakash Jain  
+
+Fix failure from r212579.
+
+Unreviewed build-fix.
+
+* Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
+(CheckPatchRelevance._changes_are_relevant): Return true for all groups others than jsc for now.
+
 2017-02-17  Srinivasan Vijayaraghavan  
 
 EWS should run _javascript_Core tests


Modified: trunk/Tools/Scripts/webkitpy/tool/steps/checkpatchrelevance.py (212590 => 212591)

--- trunk/Tools/Scripts/webkitpy/tool/steps/checkpatchrelevance.py	2017-02-17 23:41:37 UTC (rev 212590)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/checkpatchrelevance.py	2017-02-17 23:49:59 UTC (rev 212591)
@@ -50,7 +50,7 @@
 
 def _changes_are_relevant(self, changed_files):
 # In the default case, all patches are relevant
-if self._options.group is None:
+if self._options.group != 'jsc':
 return True
 
 patterns = self.group_to_paths_mapping[self._options.group]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212534] trunk/Source/WebKit2

[aakash_jain]

Title: [212534] trunk/Source/WebKit2








Revision 212534
Author aakash_j...@apple.com
Date 2017-02-16 22:03:14 -0800 (Thu, 16 Feb 2017)


Log Message
Remove unused methods WKPageGetDebugPaintFlags and WKPageSetDebugPaintFlags
https://bugs.webkit.org/show_bug.cgi?id=168464

Reviewed by Alexey Proskuryakov.

* UIProcess/API/C/WKPagePrivate.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (212533 => 212534)

--- trunk/Source/WebKit2/ChangeLog	2017-02-17 05:36:05 UTC (rev 212533)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-17 06:03:14 UTC (rev 212534)
@@ -1,3 +1,12 @@
+2017-02-16  Aakash Jain  
+
+Remove unused methods WKPageGetDebugPaintFlags and WKPageSetDebugPaintFlags
+https://bugs.webkit.org/show_bug.cgi?id=168464
+
+Reviewed by Alexey Proskuryakov.
+
+* UIProcess/API/C/WKPagePrivate.h:
+
 2017-02-16  Youenn Fablet  
 
 [WebRTC] libwebrtc socket addresses should not be passed as strings


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h (212533 => 212534)

--- trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h	2017-02-17 05:36:05 UTC (rev 212533)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h	2017-02-17 06:03:14 UTC (rev 212534)
@@ -42,9 +42,6 @@
 };
 typedef unsigned WKPageDebugPaintFlags;
 
-WK_EXPORT void WKPageSetDebugPaintFlags(WKPageDebugPaintFlags flags);
-WK_EXPORT WKPageDebugPaintFlags WKPageGetDebugPaintFlags(void);
-
 WK_EXPORT WKStringRef WKPageCopyStandardUserAgentWithApplicationName(WKStringRef);
 
 enum {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212833] trunk/Source/WebKit

[aakash_jain]

Title: [212833] trunk/Source/WebKit








Revision 212833
Author aakash_j...@apple.com
Date 2017-02-22 09:44:34 -0800 (Wed, 22 Feb 2017)


Log Message
Move iOS specific symbols to WebKit.ios.exp
https://bugs.webkit.org/show_bug.cgi?id=168726

Reviewed by Alexey Proskuryakov.

Source/WebKit/ios:

* WebKit.iOS.exp:

Source/WebKit/mac:

* WebKit.exp:

Modified Paths

trunk/Source/WebKit/ios/ChangeLog
trunk/Source/WebKit/ios/WebKit.iOS.exp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebKit.exp




Diff

Modified: trunk/Source/WebKit/ios/ChangeLog (212832 => 212833)

--- trunk/Source/WebKit/ios/ChangeLog	2017-02-22 17:15:45 UTC (rev 212832)
+++ trunk/Source/WebKit/ios/ChangeLog	2017-02-22 17:44:34 UTC (rev 212833)
@@ -1,3 +1,12 @@
+2017-02-22  Aakash Jain  
+
+Move iOS specific symbols to WebKit.ios.exp
+https://bugs.webkit.org/show_bug.cgi?id=168726
+
+Reviewed by Alexey Proskuryakov.
+
+* WebKit.iOS.exp:
+
 2017-02-21  Commit Queue  
 
 Unreviewed, rolling out r212768.


Modified: trunk/Source/WebKit/ios/WebKit.iOS.exp (212832 => 212833)

--- trunk/Source/WebKit/ios/WebKit.iOS.exp	2017-02-22 17:15:45 UTC (rev 212832)
+++ trunk/Source/WebKit/ios/WebKit.iOS.exp	2017-02-22 17:44:34 UTC (rev 212833)
@@ -1,8 +1,12 @@
+.objc_class_name_WKQuadObject
+.objc_class_name_WebFixedPositionContent
+.objc_class_name_WebGeolocation
 .objc_class_name_WebGeolocationProviderIOS
 .objc_class_name_WebMIMETypeRegistry
 .objc_class_name_WebPDFView
 .objc_class_name_WebPDFViewPlaceholder
 .objc_class_name_WebSelectionRect
+.objc_class_name_WebVisiblePosition
 _WebDatabaseOriginsDidChangeNotification
 _WebKitCreatePathWithShrinkWrappedRects
 _WebKitGetLastLineBreakInBuffer


Modified: trunk/Source/WebKit/mac/ChangeLog (212832 => 212833)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-22 17:15:45 UTC (rev 212832)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-22 17:44:34 UTC (rev 212833)
@@ -1,3 +1,12 @@
+2017-02-22  Aakash Jain  
+
+Move iOS specific symbols to WebKit.ios.exp
+https://bugs.webkit.org/show_bug.cgi?id=168726
+
+Reviewed by Alexey Proskuryakov.
+
+* WebKit.exp:
+
 2017-02-21  Youenn Fablet  
 
 [WebRTC][Mac] Activate libwebrtc


Modified: trunk/Source/WebKit/mac/WebKit.exp (212832 => 212833)

--- trunk/Source/WebKit/mac/WebKit.exp	2017-02-22 17:15:45 UTC (rev 212832)
+++ trunk/Source/WebKit/mac/WebKit.exp	2017-02-22 17:44:34 UTC (rev 212833)
@@ -127,11 +127,9 @@
 .objc_class_name_WebDeviceOrientation
 .objc_class_name_WebDeviceOrientationProviderMock
 .objc_class_name_WebDownload
-.objc_class_name_WebFixedPositionContent
 .objc_class_name_WebFormDelegate
 .objc_class_name_WebFrame
 .objc_class_name_WebFrameView
-.objc_class_name_WebGeolocation
 .objc_class_name_WebGeolocationPosition
 .objc_class_name_WebHTMLRepresentation
 .objc_class_name_WebHTMLView
@@ -152,8 +150,6 @@
 .objc_class_name_WebTextIterator
 .objc_class_name_WebUserContentURLPattern
 .objc_class_name_WebView
-.objc_class_name_WebVisiblePosition
-.objc_class_name_WKQuadObject
 _DOMException
 _DOMRangeException
 _DOMEventException






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212859] trunk/Source/WebKit/mac

[aakash_jain]

Title: [212859] trunk/Source/WebKit/mac








Revision 212859
Author aakash_j...@apple.com
Date 2017-02-22 15:44:53 -0800 (Wed, 22 Feb 2017)


Log Message
Move instance members from WKQuadObject to implementation file
https://bugs.webkit.org/show_bug.cgi?id=168740

Reviewed by Tim Horton.

* DOM/DOM.mm: Moving instance member to implementation file.
* DOM/DOMExtensions.h: Ditto.

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/DOM/DOM.mm
trunk/Source/WebKit/mac/DOM/DOMExtensions.h




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (212858 => 212859)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-22 23:38:30 UTC (rev 212858)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-22 23:44:53 UTC (rev 212859)
@@ -1,5 +1,15 @@
 2017-02-22  Aakash Jain  
 
+Move instance members from WKQuadObject to implementation file
+https://bugs.webkit.org/show_bug.cgi?id=168740
+
+Reviewed by Tim Horton.
+
+* DOM/DOM.mm: Moving instance member to implementation file.
+* DOM/DOMExtensions.h: Ditto.
+
+2017-02-22  Aakash Jain  
+
 Move iOS specific symbols to WebKit.ios.exp
 https://bugs.webkit.org/show_bug.cgi?id=168726
 


Modified: trunk/Source/WebKit/mac/DOM/DOM.mm (212858 => 212859)

--- trunk/Source/WebKit/mac/DOM/DOM.mm	2017-02-22 23:38:30 UTC (rev 212858)
+++ trunk/Source/WebKit/mac/DOM/DOM.mm	2017-02-22 23:44:53 UTC (rev 212859)
@@ -210,7 +210,9 @@
 return { CGPointZero, CGPointZero, CGPointZero, CGPointZero };
 }
 
-@implementation WKQuadObject
+@implementation WKQuadObject {
+WKQuad _quad;
+}
 
 - (id)initWithQuad:(WKQuad)quad
 {


Modified: trunk/Source/WebKit/mac/DOM/DOMExtensions.h (212858 => 212859)

--- trunk/Source/WebKit/mac/DOM/DOMExtensions.h	2017-02-22 23:38:30 UTC (rev 212858)
+++ trunk/Source/WebKit/mac/DOM/DOMExtensions.h	2017-02-22 23:44:53 UTC (rev 212859)
@@ -51,9 +51,6 @@
 } WKQuad;
 
 @interface WKQuadObject : NSObject
-{
-WKQuad _quad;
-}
 - (id)initWithQuad:(WKQuad)quad;
 - (WKQuad)quad;
 - (CGRect)boundingBox;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212858] trunk/Source/WebKit/ios

[aakash_jain]

Title: [212858] trunk/Source/WebKit/ios








Revision 212858
Author aakash_j...@apple.com
Date 2017-02-22 15:38:30 -0800 (Wed, 22 Feb 2017)


Log Message
Move instance members from WebPDFViewPlaceholder.h to implementation file
https://bugs.webkit.org/show_bug.cgi?id=168705

Reviewed by Tim Horton.

* WebView/WebPDFViewPlaceholder.h: Moving instance members to implementation file.
* WebView/WebPDFViewPlaceholder.mm: Ditto.

Modified Paths

trunk/Source/WebKit/ios/ChangeLog
trunk/Source/WebKit/ios/WebView/WebPDFViewPlaceholder.h
trunk/Source/WebKit/ios/WebView/WebPDFViewPlaceholder.mm




Diff

Modified: trunk/Source/WebKit/ios/ChangeLog (212857 => 212858)

--- trunk/Source/WebKit/ios/ChangeLog	2017-02-22 23:30:15 UTC (rev 212857)
+++ trunk/Source/WebKit/ios/ChangeLog	2017-02-22 23:38:30 UTC (rev 212858)
@@ -1,5 +1,15 @@
 2017-02-22  Aakash Jain  
 
+Move instance members from WebPDFViewPlaceholder.h to implementation file
+https://bugs.webkit.org/show_bug.cgi?id=168705
+
+Reviewed by Tim Horton.
+
+* WebView/WebPDFViewPlaceholder.h: Moving instance members to implementation file.
+* WebView/WebPDFViewPlaceholder.mm: Ditto.
+
+2017-02-22  Aakash Jain  
+
 Move instance members from WebSelectionRect.h to implementation file
 https://bugs.webkit.org/show_bug.cgi?id=168732
 


Modified: trunk/Source/WebKit/ios/WebView/WebPDFViewPlaceholder.h (212857 => 212858)

--- trunk/Source/WebKit/ios/WebView/WebPDFViewPlaceholder.h	2017-02-22 23:30:15 UTC (rev 212857)
+++ trunk/Source/WebKit/ios/WebView/WebPDFViewPlaceholder.h	2017-02-22 23:38:30 UTC (rev 212858)
@@ -37,20 +37,8 @@
 be drawn to the UI by some other object (ideally the delegate of this class) while still interfacing
 with WAK and WebKit correctly.
 */
-@interface WebPDFViewPlaceholder : WAKView  {
-NSString *_title;
-NSArray *_pageRects;
-NSArray *_pageYOrigins;
-CGPDFDocumentRef _document;
-WebDataSource *_dataSource; // weak to prevent cycles.
+@interface WebPDFViewPlaceholder : WAKView 
 
-NSObject *_delegate;
-
-BOOL _didFinishLoad;
-
-CGSize _containerSize;
-}
-
 /*!
 @method setAsPDFDocRepAndView
 @abstract This methods sets [WebPDFViewPlaceholder class] as the document and view representations


Modified: trunk/Source/WebKit/ios/WebView/WebPDFViewPlaceholder.mm (212857 => 212858)

--- trunk/Source/WebKit/ios/WebView/WebPDFViewPlaceholder.mm	2017-02-22 23:30:15 UTC (rev 212857)
+++ trunk/Source/WebKit/ios/WebView/WebPDFViewPlaceholder.mm	2017-02-22 23:38:30 UTC (rev 212858)
@@ -102,7 +102,19 @@
 
 #pragma mark WebPDFViewPlaceholder implementation
 
-@implementation WebPDFViewPlaceholder
+@implementation WebPDFViewPlaceholder {
+NSString *_title;
+NSArray *_pageRects;
+NSArray *_pageYOrigins;
+CGPDFDocumentRef _document;
+WebDataSource *_dataSource; // weak to prevent cycles.
+
+NSObject *_delegate;
+
+BOOL _didFinishLoad;
+
+CGSize _containerSize;
+}
 
 @synthesize delegate = _delegate;
 @synthesize pageRects = _pageRects;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212903] trunk/Source/WebKit/ios

[aakash_jain]

Title: [212903] trunk/Source/WebKit/ios








Revision 212903
Author aakash_j...@apple.com
Date 2017-02-23 11:00:46 -0800 (Thu, 23 Feb 2017)


Log Message
Move instance member from WebFixedPositionContent to implementation file
https://bugs.webkit.org/show_bug.cgi?id=168766

Reviewed by Tim Horton.

* WebCoreSupport/WebFixedPositionContent.h: Moving instance member to implementation file.
* WebCoreSupport/WebFixedPositionContent.mm: Ditto.

Modified Paths

trunk/Source/WebKit/ios/ChangeLog
trunk/Source/WebKit/ios/WebCoreSupport/WebFixedPositionContent.h
trunk/Source/WebKit/ios/WebCoreSupport/WebFixedPositionContent.mm




Diff

Modified: trunk/Source/WebKit/ios/ChangeLog (212902 => 212903)

--- trunk/Source/WebKit/ios/ChangeLog	2017-02-23 18:59:19 UTC (rev 212902)
+++ trunk/Source/WebKit/ios/ChangeLog	2017-02-23 19:00:46 UTC (rev 212903)
@@ -1,3 +1,13 @@
+2017-02-23  Aakash Jain  
+
+Move instance member from WebFixedPositionContent to implementation file
+https://bugs.webkit.org/show_bug.cgi?id=168766
+
+Reviewed by Tim Horton.
+
+* WebCoreSupport/WebFixedPositionContent.h: Moving instance member to implementation file.
+* WebCoreSupport/WebFixedPositionContent.mm: Ditto.
+
 2017-02-22  Aakash Jain  
 
 Move instance members from WebPDFView to implementation file


Modified: trunk/Source/WebKit/ios/WebCoreSupport/WebFixedPositionContent.h (212902 => 212903)

--- trunk/Source/WebKit/ios/WebCoreSupport/WebFixedPositionContent.h	2017-02-23 18:59:19 UTC (rev 212902)
+++ trunk/Source/WebKit/ios/WebCoreSupport/WebFixedPositionContent.h	2017-02-23 19:00:46 UTC (rev 212903)
@@ -39,9 +39,7 @@
 // like position:fixed layers.
 // Can be called without taking the WebThread lock.
 
-@interface WebFixedPositionContent : NSObject {
-struct WebFixedPositionContentData* _private;
-}
+@interface WebFixedPositionContent : NSObject
 
 - (id)initWithWebView:(WebView *)webView;
 


Modified: trunk/Source/WebKit/ios/WebCoreSupport/WebFixedPositionContent.mm (212902 => 212903)

--- trunk/Source/WebKit/ios/WebCoreSupport/WebFixedPositionContent.mm	2017-02-23 18:59:19 UTC (rev 212902)
+++ trunk/Source/WebKit/ios/WebCoreSupport/WebFixedPositionContent.mm	2017-02-23 19:00:46 UTC (rev 212903)
@@ -84,7 +84,9 @@
 {
 }
 
-@implementation WebFixedPositionContent
+@implementation WebFixedPositionContent {
+struct WebFixedPositionContentData* _private;
+}
 
 - (id)initWithWebView:(WebView *)webView
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212552] trunk/Tools

[aakash_jain]

Title: [212552] trunk/Tools








Revision 212552
Author aakash_j...@apple.com
Date 2017-02-17 09:09:52 -0800 (Fri, 17 Feb 2017)


Log Message
Fix tools that were broken by Efl removal
https://bugs.webkit.org/show_bug.cgi?id=168496

Reviewed by Alexey Proskuryakov.

* QueueStatusServer/config/queues.py:
* Scripts/webkitpy/common/config/ews.json:
* TestResultServer/static-dashboards/builders.jsonp:
* TestResultServer/static-dashboards/flakiness_dashboard.js:
* TestResultServer/static-dashboards/loader_unittests.js:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/QueueStatusServer/config/queues.py
trunk/Tools/Scripts/webkitpy/common/config/ews.json
trunk/Tools/TestResultServer/static-dashboards/builders.jsonp
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js
trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js




Diff

Modified: trunk/Tools/ChangeLog (212551 => 212552)

--- trunk/Tools/ChangeLog	2017-02-17 16:25:56 UTC (rev 212551)
+++ trunk/Tools/ChangeLog	2017-02-17 17:09:52 UTC (rev 212552)
@@ -1,3 +1,16 @@
+2017-02-17  Aakash Jain  
+
+Fix tools that were broken by Efl removal
+https://bugs.webkit.org/show_bug.cgi?id=168496
+
+Reviewed by Alexey Proskuryakov.
+
+* QueueStatusServer/config/queues.py:
+* Scripts/webkitpy/common/config/ews.json:
+* TestResultServer/static-dashboards/builders.jsonp:
+* TestResultServer/static-dashboards/flakiness_dashboard.js:
+* TestResultServer/static-dashboards/loader_unittests.js:
+
 2017-02-16  Lucas Forschler  
 
 https://bugs.webkit.org/show_bug.cgi?id=168442


Modified: trunk/Tools/QueueStatusServer/config/queues.py (212551 => 212552)

--- trunk/Tools/QueueStatusServer/config/queues.py	2017-02-17 16:25:56 UTC (rev 212551)
+++ trunk/Tools/QueueStatusServer/config/queues.py	2017-02-17 17:09:52 UTC (rev 212552)
@@ -41,7 +41,6 @@
 "mac-debug-ews",
 "mac-32bit-ews",
 "win-ews",
-"efl-wk2-ews",
 ]
 
 # If the patch is still active after this much time, then a bot must have frozen or rebooted,


Modified: trunk/Tools/Scripts/webkitpy/common/config/ews.json (212551 => 212552)

--- trunk/Tools/Scripts/webkitpy/common/config/ews.json	2017-02-17 16:25:56 UTC (rev 212551)
+++ trunk/Tools/Scripts/webkitpy/common/config/ews.json	2017-02-17 17:09:52 UTC (rev 212552)
@@ -5,12 +5,6 @@
 "xan.lo...@gmail.com"
 ]
 },
-"EFL WK2 EWS": {
-"port": "efl-wk2",
-"watchers": [
-"gyuyoung@webkit.org"
-]
-},
 "Win EWS": {
 "port": "win",
 "watchers": [


Modified: trunk/Tools/TestResultServer/static-dashboards/builders.jsonp (212551 => 212552)

--- trunk/Tools/TestResultServer/static-dashboards/builders.jsonp	2017-02-17 16:25:56 UTC (rev 212551)
+++ trunk/Tools/TestResultServer/static-dashboards/builders.jsonp	2017-02-17 17:09:52 UTC (rev 212552)
@@ -21,9 +21,9 @@
 "Apple iOS 10 Simulator Debug WK2 (Tests)", 
 "Apple iOS 10 Simulator Release WK1 (Tests)", 
 "Apple iOS 10 Simulator Release WK2 (Tests)", 
-"EFL Linux 64-bit Release WK2", 
 "GTK Linux 64-bit Debug (Tests)", 
-"GTK Linux 64-bit Release (Tests)"
+"GTK Linux 64-bit Release (Tests)",
+"GTK Linux 64-bit Release Wayland (Tests)"
 ]
 }
 }, 


Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (212551 => 212552)

--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js	2017-02-17 16:25:56 UTC (rev 212551)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js	2017-02-17 17:09:52 UTC (rev 212552)
@@ -77,16 +77,6 @@
 }
 }
 },
-'EFL': {
-expectationsDirectory: 'efl',
-subPlatforms: {
-'LINUX': {
-subPlatforms: {
-'WK2': { fallbackPlatforms: ['EFL', 'WK2'], expectationsDirectory: 'efl-wk2' }
-}
-}
-}
-},
 'WK2': {
 basePlatform: true,
 expectationsDirectory: 'wk2'
@@ -360,8 +350,6 @@
 return determineWKPlatform(builderNameUpperCase, 'APPLE_IOS_SIMULATOR');
 if (string.contains(builderNameUpperCase, 'GTK LINUX'))
 return determineWKPlatform(builderNameUpperCase, 'GTK_LINUX');
-if (string.contains(builderNameUpperCase, 'EFL'))
-return determineWKPlatform(builderNameUpperCase, 'EFL_LINUX');
 }
 
 function platformAndBuildType(builderName)


Modified: trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js (212551 => 212552)

--- trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js	2017-02-17 16:25:56 UTC (rev 212551)
+++ trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js	2017-02-17 17:09:52 UTC (rev 212552)
@@ 

[webkit-changes] [212874] trunk/Source/WebKit/ios

[aakash_jain]

Title: [212874] trunk/Source/WebKit/ios








Revision 212874
Author aakash_j...@apple.com
Date 2017-02-22 19:41:09 -0800 (Wed, 22 Feb 2017)


Log Message
Export m_isLoggingEnabled symbol from MemoryMeasure.h
https://bugs.webkit.org/show_bug.cgi?id=168760

Reviewed by Alexey Proskuryakov.

* WebKit.iOS.exp: Exporting m_isLoggingEnabled symbol.

Modified Paths

trunk/Source/WebKit/ios/ChangeLog
trunk/Source/WebKit/ios/WebKit.iOS.exp




Diff

Modified: trunk/Source/WebKit/ios/ChangeLog (212873 => 212874)

--- trunk/Source/WebKit/ios/ChangeLog	2017-02-23 02:57:14 UTC (rev 212873)
+++ trunk/Source/WebKit/ios/ChangeLog	2017-02-23 03:41:09 UTC (rev 212874)
@@ -1,5 +1,14 @@
 2017-02-22  Aakash Jain  
 
+Export m_isLoggingEnabled symbol from MemoryMeasure.h
+https://bugs.webkit.org/show_bug.cgi?id=168760
+
+Reviewed by Alexey Proskuryakov.
+
+* WebKit.iOS.exp: Exporting m_isLoggingEnabled symbol.
+
+2017-02-22  Aakash Jain  
+
 Move instance members from WebPDFViewPlaceholder.h to implementation file
 https://bugs.webkit.org/show_bug.cgi?id=168705
 


Modified: trunk/Source/WebKit/ios/WebKit.iOS.exp (212873 => 212874)

--- trunk/Source/WebKit/ios/WebKit.iOS.exp	2017-02-23 02:57:14 UTC (rev 212873)
+++ trunk/Source/WebKit/ios/WebKit.iOS.exp	2017-02-23 03:41:09 UTC (rev 212874)
@@ -35,6 +35,7 @@
 __ZN6WebKit13MemoryMeasure10taskMemoryEv
 __ZN6WebKit13MemoryMeasure13enableLoggingEb
 __ZN6WebKit13MemoryMeasure16isLoggingEnabledEv
+__ZN6WebKit13MemoryMeasure18m_isLoggingEnabledE
 __ZN6WebKit13MemoryMeasureD1Ev
 __ZN6WebKit13MemoryMeasureD2Ev
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212856] trunk/Source/WebKit/ios

[aakash_jain]

Title: [212856] trunk/Source/WebKit/ios








Revision 212856
Author aakash_j...@apple.com
Date 2017-02-22 15:12:59 -0800 (Wed, 22 Feb 2017)


Log Message
Move instance members from WebSelectionRect.h to implementation file
https://bugs.webkit.org/show_bug.cgi?id=168732

Reviewed by Tim Horton.

* WebCoreSupport/WebSelectionRect.h: Moving instance members to implementation file.
* WebCoreSupport/WebSelectionRect.m: Ditto.

Modified Paths

trunk/Source/WebKit/ios/ChangeLog
trunk/Source/WebKit/ios/WebCoreSupport/WebSelectionRect.h
trunk/Source/WebKit/ios/WebCoreSupport/WebSelectionRect.m




Diff

Modified: trunk/Source/WebKit/ios/ChangeLog (212855 => 212856)

--- trunk/Source/WebKit/ios/ChangeLog	2017-02-22 23:09:26 UTC (rev 212855)
+++ trunk/Source/WebKit/ios/ChangeLog	2017-02-22 23:12:59 UTC (rev 212856)
@@ -1,5 +1,15 @@
 2017-02-22  Aakash Jain  
 
+Move instance members from WebSelectionRect.h to implementation file
+https://bugs.webkit.org/show_bug.cgi?id=168732
+
+Reviewed by Tim Horton.
+
+* WebCoreSupport/WebSelectionRect.h: Moving instance members to implementation file.
+* WebCoreSupport/WebSelectionRect.m: Ditto.
+
+2017-02-22  Aakash Jain  
+
 Move iOS specific symbols to WebKit.ios.exp
 https://bugs.webkit.org/show_bug.cgi?id=168726
 


Modified: trunk/Source/WebKit/ios/WebCoreSupport/WebSelectionRect.h (212855 => 212856)

--- trunk/Source/WebKit/ios/WebCoreSupport/WebSelectionRect.h	2017-02-22 23:09:26 UTC (rev 212855)
+++ trunk/Source/WebKit/ios/WebCoreSupport/WebSelectionRect.h	2017-02-22 23:12:59 UTC (rev 212856)
@@ -29,17 +29,7 @@
 #import 
 #import 
 
-@interface WebSelectionRect : NSObject  {
-CGRect m_rect;
-WKWritingDirection m_writingDirection;
-BOOL m_isLineBreak;
-BOOL m_isFirstOnLine;
-BOOL m_isLastOnLine;
-BOOL m_containsStart;
-BOOL m_containsEnd;
-BOOL m_isInFixedPosition;
-BOOL m_isHorizontal;
-}
+@interface WebSelectionRect : NSObject 
 
 @property (nonatomic, assign) CGRect rect;
 @property (nonatomic, assign) WKWritingDirection writingDirection;


Modified: trunk/Source/WebKit/ios/WebCoreSupport/WebSelectionRect.m (212855 => 212856)

--- trunk/Source/WebKit/ios/WebCoreSupport/WebSelectionRect.m	2017-02-22 23:09:26 UTC (rev 212855)
+++ trunk/Source/WebKit/ios/WebCoreSupport/WebSelectionRect.m	2017-02-22 23:12:59 UTC (rev 212856)
@@ -27,7 +27,17 @@
 
 #import "WebSelectionRect.h"
 
-@implementation WebSelectionRect
+@implementation WebSelectionRect {
+CGRect m_rect;
+WKWritingDirection m_writingDirection;
+BOOL m_isLineBreak;
+BOOL m_isFirstOnLine;
+BOOL m_isLastOnLine;
+BOOL m_containsStart;
+BOOL m_containsEnd;
+BOOL m_isInFixedPosition;
+BOOL m_isHorizontal;
+}
 
 @synthesize rect = m_rect;
 @synthesize writingDirection = m_writingDirection;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212879] trunk/Source/WebKit

[aakash_jain]

Title: [212879] trunk/Source/WebKit








Revision 212879
Author aakash_j...@apple.com
Date 2017-02-22 23:19:19 -0800 (Wed, 22 Feb 2017)


Log Message
Export Objective-C symbols for variables in Webkit SPI
https://bugs.webkit.org/show_bug.cgi?id=168758

Reviewed by Alexey Proskuryakov.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj: Generating separate .exp file for i386 without _OBJC_IVAR symbols.

Source/WebKit/mac:

* Configurations/WebKitLegacy.xcconfig: using separate .exp file for i386.
* WebKit.exp: Added various Objective-C symbols.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig
trunk/Source/WebKit/mac/WebKit.exp




Diff

Modified: trunk/Source/WebKit/ChangeLog (212878 => 212879)

--- trunk/Source/WebKit/ChangeLog	2017-02-23 07:10:54 UTC (rev 212878)
+++ trunk/Source/WebKit/ChangeLog	2017-02-23 07:19:19 UTC (rev 212879)
@@ -1,3 +1,12 @@
+2017-02-22  Aakash Jain  
+
+Export Objective-C symbols for variables in Webkit SPI
+https://bugs.webkit.org/show_bug.cgi?id=168758
+
+Reviewed by Alexey Proskuryakov.
+
+* WebKit.xcodeproj/project.pbxproj: Generating separate .exp file for i386 without _OBJC_IVAR symbols.
+
 2017-02-21  Aakash Jain  
 
 Make WebKitStatisticsPrivate.h project header


Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (212878 => 212879)

--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2017-02-23 07:10:54 UTC (rev 212878)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2017-02-23 07:19:19 UTC (rev 212879)
@@ -3304,10 +3304,11 @@
 			outputPaths = (
 "$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.LP64.exp",
 "$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp",
+"$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.i386.exp",
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = "mkdir -p \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy\"\n\nif [[ \"${PLATFORM_NAME}\" != \"macosx\" ]]; then\ncat \"${PROJECT_DIR}/mac/WebKit.exp\" \"${PROJECT_DIR}/ios/WebKit.iOS.exp\" > \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp\"\nelse\ncat \"${PROJECT_DIR}/mac/WebKit.exp\" \"${PROJECT_DIR}/mac/WebKit.mac.exp\" > \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp\"\nfi\n\nif [ -f \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/ReexportedWebCoreSymbols_${CURRENT_ARCH}.exp\" ]; then\ncat \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/ReexportedWebCoreSymbols_${CURRENT_ARCH}.exp\" >> \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp\"\nfi\n\n# exclude Carbon functions on 64-bit\nsed -e s/^_HI
 WebViewCreate$// -e s/^_HIWebViewGetWebView$// -e s/^_WebConvertNSImageToCGImageRef$// -e s/^_WebInitForCarbon$// \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp\" > \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/WebKitLegacy.LP64.exp\"\n";
+			shellScript = "mkdir -p \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy\"\n\nif [[ \"${PLATFORM_NAME}\" != \"macosx\" ]]; then\ncat \"${PROJECT_DIR}/mac/WebKit.exp\" \"${PROJECT_DIR}/ios/WebKit.iOS.exp\" > \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp\"\nelse\ncat \"${PROJECT_DIR}/mac/WebKit.exp\" \"${PROJECT_DIR}/mac/WebKit.mac.exp\" > \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp\"\nfi\n\nif [ -f \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/ReexportedWebCoreSymbols_${CURRENT_ARCH}.exp\" ]; then\ncat \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/ReexportedWebCoreSymbols_${CURRENT_ARCH}.exp\" >> \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp\"\nfi\n\n# exclude Carbon functions on 64-bit\nsed -e s/^_HIW
 ebViewCreate$// -e s/^_HIWebViewGetWebView$// -e s/^_WebConvertNSImageToCGImageRef$// -e s/^_WebInitForCarbon$// \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp\" > \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/WebKitLegacy.LP64.exp\"\n\n# exclude OBJC_IVAR for i386\ngrep -v \"_OBJC_IVAR\" \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp\" > \"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/WebKitLegacy.i386.exp\"";
 		};
 		1C6CB0510AA63EB000D23BFD /* Migrate Headers */ = {
 			isa = PBXShellScriptBuildPhase;


Modified: trunk/Source/WebKit/mac/ChangeLog (212878 => 212879)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-23 07:10:54 UTC (rev 212878)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-23 07:19:19 UTC (rev 212879)
@@ -1,5 +1,15 @@
 2017-02-22  Aakash Jain  
 
+Export Objective-C symbols for variables in Webkit SPI
+

[webkit-changes] [212880] trunk/Source/WebKit/ios

[aakash_jain]

Title: [212880] trunk/Source/WebKit/ios








Revision 212880
Author aakash_j...@apple.com
Date 2017-02-22 23:24:22 -0800 (Wed, 22 Feb 2017)


Log Message
Move instance members from WebPDFView to implementation file
https://bugs.webkit.org/show_bug.cgi?id=168765

Reviewed by Tim Horton.

* WebView/WebPDFViewIOS.h: Moving instance members to implementation file.
* WebView/WebPDFViewIOS.mm: Ditto.

Modified Paths

trunk/Source/WebKit/ios/ChangeLog
trunk/Source/WebKit/ios/WebView/WebPDFViewIOS.h
trunk/Source/WebKit/ios/WebView/WebPDFViewIOS.mm




Diff

Modified: trunk/Source/WebKit/ios/ChangeLog (212879 => 212880)

--- trunk/Source/WebKit/ios/ChangeLog	2017-02-23 07:19:19 UTC (rev 212879)
+++ trunk/Source/WebKit/ios/ChangeLog	2017-02-23 07:24:22 UTC (rev 212880)
@@ -1,5 +1,15 @@
 2017-02-22  Aakash Jain  
 
+Move instance members from WebPDFView to implementation file
+https://bugs.webkit.org/show_bug.cgi?id=168765
+
+Reviewed by Tim Horton.
+
+* WebView/WebPDFViewIOS.h: Moving instance members to implementation file.
+* WebView/WebPDFViewIOS.mm: Ditto.
+
+2017-02-22  Aakash Jain  
+
 Export m_isLoggingEnabled symbol from MemoryMeasure.h
 https://bugs.webkit.org/show_bug.cgi?id=168760
 


Modified: trunk/Source/WebKit/ios/WebView/WebPDFViewIOS.h (212879 => 212880)

--- trunk/Source/WebKit/ios/WebView/WebPDFViewIOS.h	2017-02-23 07:19:19 UTC (rev 212879)
+++ trunk/Source/WebKit/ios/WebView/WebPDFViewIOS.h	2017-02-23 07:24:22 UTC (rev 212880)
@@ -25,12 +25,7 @@
 
 #import 
 
-@interface WebPDFView : WAKView  {
-BOOL dataSourceHasBeenSet;
-CGPDFDocumentRef _PDFDocument;
-NSString *_title;
-CGRect *_pageRects;
-}
+@interface WebPDFView : WAKView 
 
 - (unsigned)pageNumberForRect:(CGRect)rect;
 - (unsigned)totalPages;


Modified: trunk/Source/WebKit/ios/WebView/WebPDFViewIOS.mm (212879 => 212880)

--- trunk/Source/WebKit/ios/WebView/WebPDFViewIOS.mm	2017-02-23 07:19:19 UTC (rev 212879)
+++ trunk/Source/WebKit/ios/WebView/WebPDFViewIOS.mm	2017-02-23 07:24:22 UTC (rev 212880)
@@ -67,7 +67,12 @@
 return CGColorCreate(graySpace, components);
 }
 
-@implementation WebPDFView
+@implementation WebPDFView {
+BOOL dataSourceHasBeenSet;
+CGPDFDocumentRef _PDFDocument;
+NSString *_title;
+CGRect *_pageRects;
+}
 
 + (NSArray *)supportedMIMETypes
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212307] trunk/Source/WebCore

[aakash_jain]

Title: [212307] trunk/Source/WebCore








Revision 212307
Author aakash_j...@apple.com
Date 2017-02-14 10:51:24 -0800 (Tue, 14 Feb 2017)


Log Message
Remove unused WebThreadContextIsCurrent method from WebCoreThread.h
https://bugs.webkit.org/show_bug.cgi?id=168254

Reviewed by Dan Bernstein.

* platform/ios/wak/WebCoreThread.h: Removed unused WebThreadContextIsCurrent.
* platform/ios/wak/WebCoreThread.mm:
(WebThreadContextIsCurrent): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/wak/WebCoreThread.h
trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (212306 => 212307)

--- trunk/Source/WebCore/ChangeLog	2017-02-14 18:07:39 UTC (rev 212306)
+++ trunk/Source/WebCore/ChangeLog	2017-02-14 18:51:24 UTC (rev 212307)
@@ -1,3 +1,14 @@
+2017-02-14  Aakash Jain  
+
+Remove unused WebThreadContextIsCurrent method from WebCoreThread.h
+https://bugs.webkit.org/show_bug.cgi?id=168254
+
+Reviewed by Dan Bernstein.
+
+* platform/ios/wak/WebCoreThread.h: Removed unused WebThreadContextIsCurrent.
+* platform/ios/wak/WebCoreThread.mm:
+(WebThreadContextIsCurrent): Deleted.
+
 2017-02-14  Alexey Proskuryakov  
 
 WebCore shouldn't export SystemMemory.h


Modified: trunk/Source/WebCore/platform/ios/wak/WebCoreThread.h (212306 => 212307)

--- trunk/Source/WebCore/platform/ios/wak/WebCoreThread.h	2017-02-14 18:07:39 UTC (rev 212306)
+++ trunk/Source/WebCore/platform/ios/wak/WebCoreThread.h	2017-02-14 18:51:24 UTC (rev 212307)
@@ -88,7 +88,6 @@
 CFRunLoopRef WebThreadRunLoop(void);
 WEBCORE_EXPORT NSRunLoop* WebThreadNSRunLoop(void);
 WebThreadContext *WebThreadCurrentContext(void);
-bool WebThreadContextIsCurrent(void);
 
 WEBCORE_EXPORT void WebThreadSetDelegateSourceRunLoopMode(CFStringRef mode);
 


Modified: trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm (212306 => 212307)

--- trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm	2017-02-14 18:07:39 UTC (rev 212306)
+++ trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm	2017-02-14 18:51:24 UTC (rev 212307)
@@ -992,11 +992,6 @@
 return CurrentThreadContext();
 }
 
-bool WebThreadContextIsCurrent(void)
-{   
-return WebThreadCurrentContext() == webThreadContext;
-}
-
 void WebThreadSetDelegateSourceRunLoopMode(CFStringRef mode)
 {
 ASSERT(!webThreadStarted);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212255] trunk/Source/WebCore

[aakash_jain]

Title: [212255] trunk/Source/WebCore








Revision 212255
Author aakash_j...@apple.com
Date 2017-02-13 15:10:12 -0800 (Mon, 13 Feb 2017)


Log Message
Remove unused WebCoreThreadSafe.h
https://bugs.webkit.org/show_bug.cgi?id=168236

Reviewed by Dan Bernstein.

* platform/ios/wak/WebCoreThreadSafe.h: Removed.
* WebCore.xcodeproj/project.pbxproj: Removed WebCoreThreadSafe.h
* platform/ios/wak/WebCoreThread.mm: Removed WebCoreThreadSafe.h and included WAKWindow.h directly

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm


Removed Paths

trunk/Source/WebCore/platform/ios/wak/WebCoreThreadSafe.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (212254 => 212255)

--- trunk/Source/WebCore/ChangeLog	2017-02-13 23:10:10 UTC (rev 212254)
+++ trunk/Source/WebCore/ChangeLog	2017-02-13 23:10:12 UTC (rev 212255)
@@ -1,3 +1,14 @@
+2017-02-13  Aakash Jain  
+
+Remove unused WebCoreThreadSafe.h
+https://bugs.webkit.org/show_bug.cgi?id=168236
+
+Reviewed by Dan Bernstein.
+
+* platform/ios/wak/WebCoreThreadSafe.h: Removed.
+* WebCore.xcodeproj/project.pbxproj: Removed WebCoreThreadSafe.h
+* platform/ios/wak/WebCoreThread.mm: Removed WebCoreThreadSafe.h and included WAKWindow.h directly
+
 2017-02-13  Anders Carlsson  
 
 Fix iOS build.


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (212254 => 212255)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2017-02-13 23:10:10 UTC (rev 212254)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2017-02-13 23:10:12 UTC (rev 212255)
@@ -3989,7 +3989,6 @@
 		A14832CA187F678000DA63A6 /* WebCoreThreadMessage.h in Headers */ = {isa = PBXBuildFile; fileRef = A148329C187F508700DA63A6 /* WebCoreThreadMessage.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		A14832CB187F67B400DA63A6 /* WebCoreThreadRun.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A148329D187F508700DA63A6 /* WebCoreThreadRun.cpp */; };
 		A14832CC187F67C400DA63A6 /* WebCoreThreadRun.h in Headers */ = {isa = PBXBuildFile; fileRef = A148329E187F508700DA63A6 /* WebCoreThreadRun.h */; settings = {ATTRIBUTES = (Private, ); }; };
-		A14832CD187F682E00DA63A6 /* WebCoreThreadSafe.h in Headers */ = {isa = PBXBuildFile; fileRef = A148329F187F508700DA63A6 /* WebCoreThreadSafe.h */; };
 		A14832CE187F683400DA63A6 /* WebCoreThreadSystemInterface.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A14832A0187F508700DA63A6 /* WebCoreThreadSystemInterface.cpp */; };
 		A14832CF187F684700DA63A6 /* WebCoreThreadSystemInterface.h in Headers */ = {isa = PBXBuildFile; fileRef = A14832A1187F508700DA63A6 /* WebCoreThreadSystemInterface.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		A149786E1ABAF33800CEF7E4 /* ContentFilter.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A149786C1ABAF33800CEF7E4 /* ContentFilter.cpp */; };
@@ -11785,7 +11784,6 @@
 		A148329C187F508700DA63A6 /* WebCoreThreadMessage.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebCoreThreadMessage.h; sourceTree = ""; };
 		A148329D187F508700DA63A6 /* WebCoreThreadRun.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WebCoreThreadRun.cpp; sourceTree = ""; };
 		A148329E187F508700DA63A6 /* WebCoreThreadRun.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebCoreThreadRun.h; sourceTree = ""; };
-		A148329F187F508700DA63A6 /* WebCoreThreadSafe.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebCoreThreadSafe.h; sourceTree = ""; };
 		A14832A0187F508700DA63A6 /* WebCoreThreadSystemInterface.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WebCoreThreadSystemInterface.cpp; sourceTree = ""; };
 		A14832A1187F508700DA63A6 /* WebCoreThreadSystemInterface.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebCoreThreadSystemInterface.h; sourceTree = ""; };
 		A14832A2187F508700DA63A6 /* WKContentObservation.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WKContentObservation.cpp; sourceTree = ""; };
@@ -20001,7 +1,6 @@
 A148329C187F508700DA63A6 /* WebCoreThreadMessage.h */,
 A148329D187F508700DA63A6 /* WebCoreThreadRun.cpp */,
 A148329E187F508700DA63A6 /* WebCoreThreadRun.h */,
-A148329F187F508700DA63A6 /* WebCoreThreadSafe.h */,
 A14832A0187F508700DA63A6 /* WebCoreThreadSystemInterface.cpp */,
 A14832A1187F508700DA63A6 /* WebCoreThreadSystemInterface.h */,
 A14832A2187F508700DA63A6 /* WKContentObservation.cpp */,
@@ -28683,7 +28680,6 @@
 A14832C9187F676B00DA63A6 /* WebCoreThreadInternal.h in Headers */,
 A14832CA187F678000DA63A6 /* WebCoreThreadMessage.h in Headers 

[webkit-changes] [212251] trunk/Source/WebCore

[aakash_jain]

Title: [212251] trunk/Source/WebCore








Revision 212251
Author aakash_j...@apple.com
Date 2017-02-13 14:55:55 -0800 (Mon, 13 Feb 2017)


Log Message
WAKResponder should be exported from WebCore
https://bugs.webkit.org/show_bug.cgi?id=168245

Reviewed by Dan Bernstein.

* platform/ios/wak/WAKResponder.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/wak/WAKResponder.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (212250 => 212251)

--- trunk/Source/WebCore/ChangeLog	2017-02-13 22:53:46 UTC (rev 212250)
+++ trunk/Source/WebCore/ChangeLog	2017-02-13 22:55:55 UTC (rev 212251)
@@ -1,3 +1,12 @@
+2017-02-13  Aakash Jain  
+
+WAKResponder should be exported from WebCore
+https://bugs.webkit.org/show_bug.cgi?id=168245
+
+Reviewed by Dan Bernstein.
+
+* platform/ios/wak/WAKResponder.h:
+
 2017-02-13  Simon Fraser  
 
 Log to the History Channel in a few more places


Modified: trunk/Source/WebCore/platform/ios/wak/WAKResponder.h (212250 => 212251)

--- trunk/Source/WebCore/platform/ios/wak/WAKResponder.h	2017-02-13 22:53:46 UTC (rev 212250)
+++ trunk/Source/WebCore/platform/ios/wak/WAKResponder.h	2017-02-13 22:55:55 UTC (rev 212251)
@@ -33,7 +33,7 @@
 
 @class WebEvent;
 
-@interface WAKResponder : NSObject
+WEBCORE_EXPORT @interface WAKResponder : NSObject
 {
 
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212128] trunk/Source/WebKit/mac

[aakash_jain]

Title: [212128] trunk/Source/WebKit/mac








Revision 212128
Author aakash_j...@apple.com
Date 2017-02-10 11:26:36 -0800 (Fri, 10 Feb 2017)


Log Message
WebResourceLoadDelegatePrivate.h cannot be imported standalone
https://bugs.webkit.org/show_bug.cgi?id=168096

Reviewed by Alexey Proskuryakov.

* WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger.

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebResourceLoadDelegatePrivate.h




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (212127 => 212128)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-10 19:16:59 UTC (rev 212127)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-10 19:26:36 UTC (rev 212128)
@@ -1,3 +1,12 @@
+2017-02-10  Aakash Jain  
+
+WebResourceLoadDelegatePrivate.h cannot be imported standalone
+https://bugs.webkit.org/show_bug.cgi?id=168096
+
+Reviewed by Alexey Proskuryakov.
+
+* WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger. 
+
 2017-02-09  Antti Koivisto  
 
 Remove most cases of #if ENABLE(CACHE_PARTITIONING)


Modified: trunk/Source/WebKit/mac/WebView/WebResourceLoadDelegatePrivate.h (212127 => 212128)

--- trunk/Source/WebKit/mac/WebView/WebResourceLoadDelegatePrivate.h	2017-02-10 19:16:59 UTC (rev 212127)
+++ trunk/Source/WebKit/mac/WebView/WebResourceLoadDelegatePrivate.h	2017-02-10 19:26:36 UTC (rev 212128)
@@ -26,7 +26,7 @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#import 
+#import 
 
 @class WebView;
 @class WebDataSource;
@@ -58,7 +58,7 @@
 #if TARGET_OS_IPHONE
 - (id)webThreadWebView:(WebView *)sender identifierForInitialRequest:(NSURLRequest *)request fromDataSource:(WebDataSource *)dataSource;
 - (NSURLRequest *)webThreadWebView:(WebView *)sender resource:(id)identifier willSendRequest:(NSURLRequest *)request redirectResponse:(NSURLResponse *)redirectResponse fromDataSource:(WebDataSource *)dataSource;
-- (void)webThreadWebView:(WebView *)sender resource:(id)identifier didReceiveContentLength:(WebNSInteger)length fromDataSource:(WebDataSource *)dataSource;
+- (void)webThreadWebView:(WebView *)sender resource:(id)identifier didReceiveContentLength:(NSInteger)length fromDataSource:(WebDataSource *)dataSource;
 - (void)webThreadWebView:(WebView *)sender resource:(id)identifier didReceiveResponse:(NSURLResponse *)response fromDataSource:(WebDataSource *)dataSource;
 - (void)webThreadWebView:(WebView *)webView didLoadResourceFromMemoryCache:(NSURLRequest *)request response:(NSURLResponse *)response length:(NSInteger)length fromDataSource:(WebDataSource *)dataSource;
 - (void)webThreadWebView:(WebView *)sender resource:(id)identifier didFinishLoadingFromDataSource:(WebDataSource *)dataSource;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212143] trunk/Source/WebKit/mac

[aakash_jain]

Title: [212143] trunk/Source/WebKit/mac








Revision 212143
Author aakash_j...@apple.com
Date 2017-02-10 13:24:43 -0800 (Fri, 10 Feb 2017)


Log Message
cleanup WebLocalizableStrings.
https://bugs.webkit.org/show_bug.cgi?id=168078

Reviewed by Alexey Proskuryakov.

* Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle
as it's for each framework's own consumption, and never needs to be exported.

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.h




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (212142 => 212143)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-10 21:17:37 UTC (rev 212142)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-10 21:24:43 UTC (rev 212143)
@@ -1,5 +1,15 @@
 2017-02-10  Aakash Jain  
 
+cleanup WebLocalizableStrings.
+https://bugs.webkit.org/show_bug.cgi?id=168078
+
+Reviewed by Alexey Proskuryakov.
+
+* Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle 
+as it's for each framework's own consumption, and never needs to be exported.
+
+2017-02-10  Aakash Jain  
+
 WebResourceLoadDelegatePrivate.h cannot be imported standalone
 https://bugs.webkit.org/show_bug.cgi?id=168096
 


Modified: trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.h (212142 => 212143)

--- trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.h	2017-02-10 21:17:37 UTC (rev 212142)
+++ trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.h	2017-02-10 21:24:43 UTC (rev 212143)
@@ -62,6 +62,8 @@
 
 #define LOCALIZABLE_STRINGS_BUNDLE(F) LOCALIZABLE_STRINGS_BUNDLE_HELPER(F)
 #define LOCALIZABLE_STRINGS_BUNDLE_HELPER(F) F ## LocalizableStringsBundle
+
+__attribute__((visibility("hidden")))
 extern WebLocalizableStringsBundle LOCALIZABLE_STRINGS_BUNDLE(FRAMEWORK_NAME);
 
 #define UI_STRING(string, comment) WebLocalizedStringWithValue(_STRINGS_BUNDLE(FRAMEWORK_NAME), string, string)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212179] trunk/Source/WebKit/ios

[aakash_jain]

Title: [212179] trunk/Source/WebKit/ios








Revision 212179
Author aakash_j...@apple.com
Date 2017-02-10 20:54:32 -0800 (Fri, 10 Feb 2017)


Log Message
WebKitLegacy doesn't re-export various symbols from WebCore required by clients
https://bugs.webkit.org/show_bug.cgi?id=168158


Reviewed by Dan Bernstein.

* WebKit.iOS.exp: Exporting various symbols which are required by clients. This
would enable clients to stop linking against WebCore and instead link against WebKit.

Modified Paths

trunk/Source/WebKit/ios/ChangeLog
trunk/Source/WebKit/ios/WebKit.iOS.exp




Diff

Modified: trunk/Source/WebKit/ios/ChangeLog (212178 => 212179)

--- trunk/Source/WebKit/ios/ChangeLog	2017-02-11 04:40:38 UTC (rev 212178)
+++ trunk/Source/WebKit/ios/ChangeLog	2017-02-11 04:54:32 UTC (rev 212179)
@@ -1,3 +1,14 @@
+2017-02-10  Aakash Jain  
+
+WebKitLegacy doesn't re-export various symbols from WebCore required by clients
+https://bugs.webkit.org/show_bug.cgi?id=168158
+
+
+Reviewed by Dan Bernstein.
+
+* WebKit.iOS.exp: Exporting various symbols which are required by clients. This 
+would enable clients to stop linking against WebCore and instead link against WebKit.
+
 2017-02-02  Yongjun Zhang  
 
 In iOS, we should take background assertion when accessing localstorage databases.


Modified: trunk/Source/WebKit/ios/WebKit.iOS.exp (212178 => 212179)

--- trunk/Source/WebKit/ios/WebKit.iOS.exp	2017-02-11 04:40:38 UTC (rev 212178)
+++ trunk/Source/WebKit/ios/WebKit.iOS.exp	2017-02-11 04:54:32 UTC (rev 212179)
@@ -1,9 +1,15 @@
+.objc_class_name_WAKWindow
+.objc_class_name_WebEvent
 .objc_class_name_WebGeolocationProviderIOS
 .objc_class_name_WebMIMETypeRegistry
 .objc_class_name_WebPDFView
 .objc_class_name_WebPDFViewPlaceholder
 .objc_class_name_WebPluginController
+.objc_class_name_WebScriptObject
 .objc_class_name_WebSelectionRect
+.objc_class_name_WebUndefined
+.objc_class_name_WAKView
+_WAKViewFrameSizeDidChangeNotification
 _WebDatabaseOriginsDidChangeNotification
 _WebKitCreatePathWithShrinkWrappedRects
 _WebKitGetLastLineBreakInBuffer
@@ -20,6 +26,22 @@
 _WebOpenPanelConfigurationMediaCaptureTypeKey
 _WebQuickLookFileNameKey
 _WebQuickLookUTIKey
+_WebThreadCallDelegateAsync
+_WebThreadCallDelegate
+_WebThreadIsCurrent
+_WebThreadIsEnabled
+_WebThreadIsLocked
+_WebThreadLock
+_WebThreadLockFromAnyThread
+_WebThreadLockPopModal
+_WebThreadLockPushModal
+_WebThreadMakeNSInvocation
+_WebThreadNotCurrent
+_WebThreadRun
+_WebThreadRunOnMainThread
+_WebThreadUnlock
+_WebThreadUnlockFromAnyThread
+_WebThreadUnlockGuardForMail
 _WebViewportHeightKey
 _WebViewportInitialScaleKey
 _WebViewportMaximumScaleKey
@@ -27,6 +49,8 @@
 _WebViewportUserScalableKey
 _WebViewportShrinkToFitKey
 _WebViewportWidthKey
+_WKGetCurrentGraphicsContext
+_WKSetCurrentGraphicsContext
 
 # So that we can use the MemoryMeasure class in MobileSafari
 __ZN6WebKit13MemoryMeasure10taskMemoryEv






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212343] trunk/Source/WebCore

[aakash_jain]

Title: [212343] trunk/Source/WebCore








Revision 212343
Author aakash_j...@apple.com
Date 2017-02-14 21:19:57 -0800 (Tue, 14 Feb 2017)


Log Message
Move methods from WebCoreThread.h to WebCoreThreadInternal.h
https://bugs.webkit.org/show_bug.cgi?id=168326

Reviewed by Alexey Proskuryakov.

* platform/ios/wak/WebCoreThread.h: Move methods WebThreadRunLoop and WebThreadCurrentContext to WebCoreThreadInternal.h
* platform/ios/wak/WebCoreThreadInternal.h: Ditto.
* platform/ios/wak/WebCoreThreadRun.cpp: Removed WebCoreThread.h as it is already included by WebCoreThreadInternal.h
* platform/ios/wak/WKGraphics.mm: Included WebCoreThreadInternal.h, it subsequently includes WebCoreThread.h
* inspector/InspectorTimelineAgent.cpp: Ditto.
* page/mac/PageMac.mm: Ditto.
* platform/cf/MainThreadSharedTimerCF.cpp: Ditto.
* platform/cocoa/MemoryPressureHandlerCocoa.mm: Ditto.
* platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp: Ditto.
* platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp: Ditto.
* bindings/js/CommonVM.cpp: included WebCoreThreadInternal.h

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/CommonVM.cpp
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/page/mac/PageMac.mm
trunk/Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp
trunk/Source/WebCore/platform/cocoa/MemoryPressureHandlerCocoa.mm
trunk/Source/WebCore/platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp
trunk/Source/WebCore/platform/ios/wak/WKGraphics.mm
trunk/Source/WebCore/platform/ios/wak/WebCoreThread.h
trunk/Source/WebCore/platform/ios/wak/WebCoreThreadInternal.h
trunk/Source/WebCore/platform/ios/wak/WebCoreThreadRun.cpp
trunk/Source/WebCore/platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (212342 => 212343)

--- trunk/Source/WebCore/ChangeLog	2017-02-15 05:05:47 UTC (rev 212342)
+++ trunk/Source/WebCore/ChangeLog	2017-02-15 05:19:57 UTC (rev 212343)
@@ -1,3 +1,22 @@
+2017-02-14  Aakash Jain  
+
+Move methods from WebCoreThread.h to WebCoreThreadInternal.h
+https://bugs.webkit.org/show_bug.cgi?id=168326
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/ios/wak/WebCoreThread.h: Move methods WebThreadRunLoop and WebThreadCurrentContext to WebCoreThreadInternal.h
+* platform/ios/wak/WebCoreThreadInternal.h: Ditto.
+* platform/ios/wak/WebCoreThreadRun.cpp: Removed WebCoreThread.h as it is already included by WebCoreThreadInternal.h
+* platform/ios/wak/WKGraphics.mm: Included WebCoreThreadInternal.h, it subsequently includes WebCoreThread.h
+* inspector/InspectorTimelineAgent.cpp: Ditto.
+* page/mac/PageMac.mm: Ditto.
+* platform/cf/MainThreadSharedTimerCF.cpp: Ditto.
+* platform/cocoa/MemoryPressureHandlerCocoa.mm: Ditto.
+* platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp: Ditto.
+* platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp: Ditto.
+* bindings/js/CommonVM.cpp: included WebCoreThreadInternal.h
+
 2017-02-14  Wenson Hsieh  
 
 [WK2] Support data interaction on links


Modified: trunk/Source/WebCore/bindings/js/CommonVM.cpp (212342 => 212343)

--- trunk/Source/WebCore/bindings/js/CommonVM.cpp	2017-02-15 05:05:47 UTC (rev 212342)
+++ trunk/Source/WebCore/bindings/js/CommonVM.cpp	2017-02-15 05:19:57 UTC (rev 212343)
@@ -34,6 +34,10 @@
 #include 
 #include 
 
+#if PLATFORM(IOS)
+#include "WebCoreThreadInternal.h"
+#endif
+
 using namespace JSC;
 
 namespace WebCore {


Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp (212342 => 212343)

--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp	2017-02-15 05:05:47 UTC (rev 212342)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp	2017-02-15 05:19:57 UTC (rev 212343)
@@ -53,7 +53,7 @@
 
 #if PLATFORM(IOS)
 #include "RuntimeApplicationChecks.h"
-#include "WebCoreThread.h"
+#include "WebCoreThreadInternal.h"
 #endif
 
 #if PLATFORM(COCOA)


Modified: trunk/Source/WebCore/page/mac/PageMac.mm (212342 => 212343)

--- trunk/Source/WebCore/page/mac/PageMac.mm	2017-02-15 05:05:47 UTC (rev 212342)
+++ trunk/Source/WebCore/page/mac/PageMac.mm	2017-02-15 05:19:57 UTC (rev 212343)
@@ -37,7 +37,7 @@
 #import "RenderObject.h"
 
 #if PLATFORM(IOS)
-#import "WebCoreThread.h"
+#import "WebCoreThreadInternal.h"
 #endif
 
 namespace WebCore {


Modified: trunk/Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp (212342 => 212343)

--- trunk/Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp	2017-02-15 05:05:47 UTC (rev 212342)
+++ trunk/Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp	2017-02-15 05:19:57 UTC (rev 212343)
@@ -31,7 +31,7 @@
 #if PLATFORM(MAC)
 #import "PowerObserverMac.h"
 #elif PLATFORM(IOS)
-#import "WebCoreThread.h"
+#import "WebCoreThreadInternal.h"
 #import "WebCoreThreadRun.h"
 #endif
 

[webkit-changes] [212376] trunk/Source

[aakash_jain]

Title: [212376] trunk/Source








Revision 212376
Author aakash_j...@apple.com
Date 2017-02-15 10:13:18 -0800 (Wed, 15 Feb 2017)


Log Message
Remove WebIOSEvent interface
https://bugs.webkit.org/show_bug.cgi?id=168368

Reviewed by Tim Horton.

Source/WebCore:

* platform/ios/WebEvent.h: Removed WebIOSEvent.

Source/WebKit2:

* Shared/NativeWebKeyboardEvent.h: Using WebEvent from WebCore instead of WebIOSEvent.
* Shared/ios/NativeWebKeyboardEventIOS.mm: Ditto.
* Shared/ios/WebIOSEventFactory.h: Ditto.
* Shared/ios/WebIOSEventFactory.mm: Ditto.
* UIProcess/ios/WKContentViewInteraction.h: Ditto.
* UIProcess/ios/WKContentViewInteraction.mm: Ditto.
* UIProcess/API/C/WKPage.cpp: Using WebEvent from WebKit.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/WebEvent.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/NativeWebKeyboardEvent.h
trunk/Source/WebKit2/Shared/ios/NativeWebKeyboardEventIOS.mm
trunk/Source/WebKit2/Shared/ios/WebIOSEventFactory.h
trunk/Source/WebKit2/Shared/ios/WebIOSEventFactory.mm
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (212375 => 212376)

--- trunk/Source/WebCore/ChangeLog	2017-02-15 18:12:25 UTC (rev 212375)
+++ trunk/Source/WebCore/ChangeLog	2017-02-15 18:13:18 UTC (rev 212376)
@@ -1,3 +1,12 @@
+2017-02-15  Aakash Jain  
+
+Remove WebIOSEvent interface
+https://bugs.webkit.org/show_bug.cgi?id=168368
+
+Reviewed by Tim Horton.
+
+* platform/ios/WebEvent.h: Removed WebIOSEvent.
+
 2017-02-15  Chris Dumez  
 
 [iOS] Form Validation Bubble should be sensitive to Dynamic Type


Modified: trunk/Source/WebCore/platform/ios/WebEvent.h (212375 => 212376)

--- trunk/Source/WebCore/platform/ios/WebEvent.h	2017-02-15 18:12:25 UTC (rev 212375)
+++ trunk/Source/WebCore/platform/ios/WebEvent.h	2017-02-15 18:13:18 UTC (rev 212376)
@@ -185,8 +185,5 @@
 
 @end
 
-@interface WebIOSEvent : WebEvent
-@end
-
 #endif // TARGET_OS_IPHONE
 #endif // WebEventIOS_h


Modified: trunk/Source/WebKit2/ChangeLog (212375 => 212376)

--- trunk/Source/WebKit2/ChangeLog	2017-02-15 18:12:25 UTC (rev 212375)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-15 18:13:18 UTC (rev 212376)
@@ -1,3 +1,18 @@
+2017-02-15  Aakash Jain  
+
+Remove WebIOSEvent interface
+https://bugs.webkit.org/show_bug.cgi?id=168368
+
+Reviewed by Tim Horton.
+
+* Shared/NativeWebKeyboardEvent.h: Using WebEvent from WebCore instead of WebIOSEvent.
+* Shared/ios/NativeWebKeyboardEventIOS.mm: Ditto.
+* Shared/ios/WebIOSEventFactory.h: Ditto.
+* Shared/ios/WebIOSEventFactory.mm: Ditto.
+* UIProcess/ios/WKContentViewInteraction.h: Ditto.
+* UIProcess/ios/WKContentViewInteraction.mm: Ditto.
+* UIProcess/API/C/WKPage.cpp: Using WebEvent from WebKit.
+
 2017-02-14  Carlos Garcia Campos  
 
 [GTK] Update cookie manager API to properly work with ephemeral sessions


Modified: trunk/Source/WebKit2/Shared/NativeWebKeyboardEvent.h (212375 => 212376)

--- trunk/Source/WebKit2/Shared/NativeWebKeyboardEvent.h	2017-02-15 18:12:25 UTC (rev 212375)
+++ trunk/Source/WebKit2/Shared/NativeWebKeyboardEvent.h	2017-02-15 18:13:18 UTC (rev 212376)
@@ -52,7 +52,7 @@
 
 #if PLATFORM(IOS)
 #include 
-OBJC_CLASS WebIOSEvent;
+OBJC_CLASS WebEvent;
 #endif
 
 namespace WebKit {
@@ -68,7 +68,7 @@
 NativeWebKeyboardEvent(const Evas_Event_Key_Down*, bool);
 NativeWebKeyboardEvent(const Evas_Event_Key_Up*);
 #elif PLATFORM(IOS)
-NativeWebKeyboardEvent(WebIOSEvent *);
+NativeWebKeyboardEvent(::WebEvent *);
 #endif
 
 #if USE(APPKIT)
@@ -81,7 +81,7 @@
 const void* nativeEvent() const { return m_nativeEvent; }
 bool isFiltered() const { return m_isFiltered; }
 #elif PLATFORM(IOS)
-WebIOSEvent* nativeEvent() const { return m_nativeEvent.get(); }
+::WebEvent* nativeEvent() const { return m_nativeEvent.get(); }
 #endif
 
 private:
@@ -95,7 +95,7 @@
 const void* m_nativeEvent;
 bool m_isFiltered;
 #elif PLATFORM(IOS)
-RetainPtr m_nativeEvent;
+RetainPtr<::WebEvent> m_nativeEvent;
 #endif
 };
 


Modified: trunk/Source/WebKit2/Shared/ios/NativeWebKeyboardEventIOS.mm (212375 => 212376)

--- trunk/Source/WebKit2/Shared/ios/NativeWebKeyboardEventIOS.mm	2017-02-15 18:12:25 UTC (rev 212375)
+++ trunk/Source/WebKit2/Shared/ios/NativeWebKeyboardEventIOS.mm	2017-02-15 18:13:18 UTC (rev 212376)
@@ -32,7 +32,7 @@
 
 namespace WebKit {
 
-NativeWebKeyboardEvent::NativeWebKeyboardEvent(WebIOSEvent *event)
+NativeWebKeyboardEvent::NativeWebKeyboardEvent(::WebEvent *event)
 : WebKeyboardEvent(WebIOSEventFactory::createWebKeyboardEvent(event))
 , m_nativeEvent(event)
 {


Modified: 

[webkit-changes] [212402] trunk/Source/WebKit

[aakash_jain]

Title: [212402] trunk/Source/WebKit








Revision 212402
Author aakash_j...@apple.com
Date 2017-02-15 15:29:49 -0800 (Wed, 15 Feb 2017)


Log Message
revert DOMTextEvent.h and DOMHTMLCanvasElement.h to private header
https://bugs.webkit.org/show_bug.cgi?id=168393

Reviewed by Dan Bernstein.

Reverting a seemingly accidental change from r204717.

* WebKit.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebKit/ChangeLog (212401 => 212402)

--- trunk/Source/WebKit/ChangeLog	2017-02-15 23:23:30 UTC (rev 212401)
+++ trunk/Source/WebKit/ChangeLog	2017-02-15 23:29:49 UTC (rev 212402)
@@ -1,3 +1,14 @@
+2017-02-15  Aakash Jain  
+
+revert DOMTextEvent.h and DOMHTMLCanvasElement.h to private header
+https://bugs.webkit.org/show_bug.cgi?id=168393
+
+Reviewed by Dan Bernstein.
+
+Reverting a seemingly accidental change from r204717.
+
+* WebKit.xcodeproj/project.pbxproj:
+
 2017-02-09  Alex Christensen  
 
 Fix CMake build.


Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (212401 => 212402)

--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2017-02-15 23:23:30 UTC (rev 212401)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2017-02-15 23:29:49 UTC (rev 212402)
@@ -463,7 +463,7 @@
 		93D436C31D57ABEE00AB85EA /* DOMHTMLBRElement.mm in Sources */ = {isa = PBXBuildFile; fileRef = 93D435711D57ABEE00AB85EA /* DOMHTMLBRElement.mm */; };
 		93D436C41D57ABEE00AB85EA /* DOMHTMLButtonElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 93D435721D57ABEE00AB85EA /* DOMHTMLButtonElement.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		93D436C51D57ABEE00AB85EA /* DOMHTMLButtonElement.mm in Sources */ = {isa = PBXBuildFile; fileRef = 93D435731D57ABEE00AB85EA /* DOMHTMLButtonElement.mm */; };
-		93D436C61D57ABEE00AB85EA /* DOMHTMLCanvasElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 93D435741D57ABEE00AB85EA /* DOMHTMLCanvasElement.h */; };
+		93D436C61D57ABEE00AB85EA /* DOMHTMLCanvasElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 93D435741D57ABEE00AB85EA /* DOMHTMLCanvasElement.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		93D436C71D57ABEE00AB85EA /* DOMHTMLCanvasElement.mm in Sources */ = {isa = PBXBuildFile; fileRef = 93D435751D57ABEE00AB85EA /* DOMHTMLCanvasElement.mm */; };
 		93D436C81D57ABEE00AB85EA /* DOMHTMLCollection.h in Headers */ = {isa = PBXBuildFile; fileRef = 93D435761D57ABEE00AB85EA /* DOMHTMLCollection.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		93D436C91D57ABEE00AB85EA /* DOMHTMLCollection.mm in Sources */ = {isa = PBXBuildFile; fileRef = 93D435771D57ABEE00AB85EA /* DOMHTMLCollection.mm */; };
@@ -645,7 +645,7 @@
 		93D437791D57ABEF00AB85EA /* DOMStylesheets.h in Headers */ = {isa = PBXBuildFile; fileRef = 93D436271D57ABEE00AB85EA /* DOMStylesheets.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		93D4377A1D57ABEF00AB85EA /* DOMText.h in Headers */ = {isa = PBXBuildFile; fileRef = 93D436281D57ABEE00AB85EA /* DOMText.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		93D4377B1D57ABEF00AB85EA /* DOMText.mm in Sources */ = {isa = PBXBuildFile; fileRef = 93D436291D57ABEE00AB85EA /* DOMText.mm */; };
-		93D4377C1D57ABEF00AB85EA /* DOMTextEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = 93D4362A1D57ABEE00AB85EA /* DOMTextEvent.h */; };
+		93D4377C1D57ABEF00AB85EA /* DOMTextEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = 93D4362A1D57ABEE00AB85EA /* DOMTextEvent.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		93D4377D1D57ABEF00AB85EA /* DOMTextEvent.mm in Sources */ = {isa = PBXBuildFile; fileRef = 93D4362B1D57ABEE00AB85EA /* DOMTextEvent.mm */; };
 		93D4377E1D57ABEF00AB85EA /* DOMTextInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 93D4362C1D57ABEE00AB85EA /* DOMTextInternal.h */; };
 		93D4377F1D57ABEF00AB85EA /* DOMTimeRanges.h in Headers */ = {isa = PBXBuildFile; fileRef = 93D4362D1D57ABEE00AB85EA /* DOMTimeRanges.h */; settings = {ATTRIBUTES = (Private, ); }; };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [210944] trunk/Tools

[aakash_jain]

Title: [210944] trunk/Tools








Revision 210944
Author aakash_j...@apple.com
Date 2017-01-19 16:56:28 -0800 (Thu, 19 Jan 2017)


Log Message
Ensure status server logs go to log file
https://bugs.webkit.org/show_bug.cgi?id=167210

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/net/statusserver.py:
(StatusServer.next_work_item): Change log level from debug to info in
order to facilitate deubgging issues.
(StatusServer.update_work_items): Same.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/net/statusserver.py




Diff

Modified: trunk/Tools/ChangeLog (210943 => 210944)

--- trunk/Tools/ChangeLog	2017-01-20 00:23:54 UTC (rev 210943)
+++ trunk/Tools/ChangeLog	2017-01-20 00:56:28 UTC (rev 210944)
@@ -1,3 +1,15 @@
+2017-01-19  Aakash Jain  
+
+Ensure status server logs go to log file
+https://bugs.webkit.org/show_bug.cgi?id=167210
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/common/net/statusserver.py:
+(StatusServer.next_work_item): Change log level from debug to info in
+order to facilitate deubgging issues.
+(StatusServer.update_work_items): Same.
+
 2017-01-19  Megan Gardner  
 
 Additional selection tests and interpolation fix


Modified: trunk/Tools/Scripts/webkitpy/common/net/statusserver.py (210943 => 210944)

--- trunk/Tools/Scripts/webkitpy/common/net/statusserver.py	2017-01-20 00:23:54 UTC (rev 210943)
+++ trunk/Tools/Scripts/webkitpy/common/net/statusserver.py	2017-01-20 00:56:28 UTC (rev 210944)
@@ -123,7 +123,7 @@
 return NetworkTransaction().run(lambda: self._post_work_item_to_ews(attachment_id))
 
 def next_work_item(self, queue_name):
-_log.debug("Fetching next work item for %s" % queue_name)
+_log.info("Fetching next work item for %s" % queue_name)
 next_patch_url = "%s/next-patch/%s" % (self.url, queue_name)
 return self._fetch_url(next_patch_url)
 
@@ -152,7 +152,7 @@
 return NetworkTransaction(convert_404_to_None=True).run(lambda: self._post_release_lock(queue_name, patch))
 
 def update_work_items(self, queue_name, high_priority_work_items, work_items):
-_log.debug("Recording work items: %s for %s" % (high_priority_work_items + work_items, queue_name))
+_log.info("Recording work items: %s for %s" % (high_priority_work_items + work_items, queue_name))
 return NetworkTransaction().run(lambda: self._post_work_items_to_server(queue_name, high_priority_work_items, work_items))
 
 def update_status(self, queue_name, status, patch=None, results_file=None):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213017] trunk/Source/WebKit/mac

[aakash_jain]

Title: [213017] trunk/Source/WebKit/mac








Revision 213017
Author aakash_j...@apple.com
Date 2017-02-26 16:16:50 -0800 (Sun, 26 Feb 2017)


Log Message
Simplify EXPORTED_SYMBOLS_FILE variables in WebKitLegacy.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=168819

Reviewed by Dan Bernstein.

* Configurations/WebKitLegacy.xcconfig:

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (213016 => 213017)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-27 00:13:26 UTC (rev 213016)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-27 00:16:50 UTC (rev 213017)
@@ -1,3 +1,12 @@
+2017-02-26  Aakash Jain  
+
+Simplify EXPORTED_SYMBOLS_FILE variables in WebKitLegacy.xcconfig
+https://bugs.webkit.org/show_bug.cgi?id=168819
+
+Reviewed by Dan Bernstein.
+
+* Configurations/WebKitLegacy.xcconfig:
+
 2017-02-22  Aakash Jain  
 
 Export Objective-C symbols for variables in Webkit SPI


Modified: trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig (213016 => 213017)

--- trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig	2017-02-27 00:13:26 UTC (rev 213016)
+++ trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig	2017-02-27 00:16:50 UTC (rev 213017)
@@ -27,15 +27,9 @@
 EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = *.defs *.nib *.pdf *.tiff CarbonUtils.* CarbonWindowAdapter.* CarbonWindowContentView.* CarbonWindowFrame.* HIViewAdapter.* HIWebView.* OutlookQuirksUserScript.js PopupMenuMac.* SearchPopupMenuMac.* WebClipView.* WebDashboardRegion.* WebDynamicScrollBarsView.* WebIconDatabase.* WebIconDatabasePrivate.* WebInspectorClient.* WebJavaScriptTextInputPanel.* WebNSEventExtras.* WebNSPasteboardExtras.* WebNSWindowExtras.* WebPanelAuthenticationHandler.* WebPluginsPrivate.* WebStringTruncator.* WebTextCompletionController.*;
 EXCLUDED_SOURCE_FILE_NAMES[sdk=macosx*] = *IOS.mm MemoryMeasure.h WebCaretChangeListener.h WebFixedPositionContent.h WebFrameIOS.h WebFrameIPhone.h WebGeolocationCoreLocationProvider.h WebGeolocationPrivate.h WebGeolocationProviderIOS.h WebMIMETypeRegistry.h WebNSStringExtrasIOS.h WebNSStringExtrasIPhone.h WebPDFViewIOS.h WebPDFViewIPhone.h WebPDFViewPlaceholder.h WebSelectionRect.h WebUIKitDelegate.h WebUIKitSupport.h WebVisiblePosition.h DOMHTMLTextAreaElementPrivate.h DOMUIKitExtensions.h;
 
-EXPORTED_SYMBOLS_FILE = $(EXPORTED_SYMBOLS_FILE_$(CURRENT_ARCH));
-EXPORTED_SYMBOLS_FILE_ = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp;
-EXPORTED_SYMBOLS_FILE_armv7 = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp;
-EXPORTED_SYMBOLS_FILE_armv7k = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp;
-EXPORTED_SYMBOLS_FILE_armv7s = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp;
-EXPORTED_SYMBOLS_FILE_arm64 = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp;
-EXPORTED_SYMBOLS_FILE_i386 = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.i386.exp;
-EXPORTED_SYMBOLS_FILE_x86_64[sdk=iphonesimulator*] = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp;
-EXPORTED_SYMBOLS_FILE_x86_64[sdk=macosx*] = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.LP64.exp;
+EXPORTED_SYMBOLS_FILE = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp;
+EXPORTED_SYMBOLS_FILE[sdk=macosx*][arch=i386] = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.i386.exp;
+EXPORTED_SYMBOLS_FILE[sdk=macosx*][arch=x86_64] = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.LP64.exp;
 
 WK_XCODE_SUPPORTS_TEXT_BASED_STUBS = $(WK_NOT_$(WK_EMPTY_$(TAPI_VERIFY_MODE)));
 WK_PRIVATE_FRAMEWORKS_DIR = $(WK_PRIVATE_FRAMEWORKS_DIR_$(USE_INTERNAL_SDK));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213096] trunk/Source/WebKit

[aakash_jain]

Title: [213096] trunk/Source/WebKit








Revision 213096
Author aakash_j...@apple.com
Date 2017-02-27 14:54:26 -0800 (Mon, 27 Feb 2017)


Log Message
Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
https://bugs.webkit.org/show_bug.cgi?id=168919

Reviewed by Tim Horton.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj: Run scripts which are run for installhdrs phase for installapi phase as well.

Source/WebKit/mac:

* Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
* migrate-headers.sh: Run the migrate-headers script for installapi phase.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig
trunk/Source/WebKit/mac/migrate-headers.sh




Diff

Modified: trunk/Source/WebKit/ChangeLog (213095 => 213096)

--- trunk/Source/WebKit/ChangeLog	2017-02-27 22:44:19 UTC (rev 213095)
+++ trunk/Source/WebKit/ChangeLog	2017-02-27 22:54:26 UTC (rev 213096)
@@ -1,3 +1,12 @@
+2017-02-27  Aakash Jain  
+
+Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
+https://bugs.webkit.org/show_bug.cgi?id=168919
+
+Reviewed by Tim Horton.
+
+* WebKit.xcodeproj/project.pbxproj: Run scripts which are run for installhdrs phase for installapi phase as well.
+
 2017-02-22  Aakash Jain  
 
 Export Objective-C symbols for variables in Webkit SPI


Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (213095 => 213096)

--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2017-02-27 22:44:19 UTC (rev 213095)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2017-02-27 22:54:26 UTC (rev 213096)
@@ -3338,7 +3338,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ]; then\nexit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-inappropriate-objc-class-names ]; then\n../../Tools/Scripts/check-for-inappropriate-objc-class-names DOM Web _Web || exit $?\nfi";
+			shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ] || [ \"${ACTION}\" = \"installapi\" ]; then\nexit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-inappropriate-objc-class-names ]; then\n../../Tools/Scripts/check-for-inappropriate-objc-class-names DOM Web _Web || exit $?\nfi";
 		};
 		5D0D54210E98631D0029E223 /* Check For Weak VTables and Externals */ = {
 			isa = PBXShellScriptBuildPhase;
@@ -3353,7 +3353,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ]; then\nexit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-weak-vtables-and-externals ]; then\n../../Tools/Scripts/check-for-weak-vtables-and-externals || exit $?\nfi";
+			shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ] || [ \"${ACTION}\" = \"installapi\" ]; then\nexit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-weak-vtables-and-externals ]; then\n../../Tools/Scripts/check-for-weak-vtables-and-externals || exit $?\nfi";
 		};
 		5D2F7DB70C687A5A00B5B72B /* Update Info.plist with version information */ = {
 			isa = PBXShellScriptBuildPhase;


Modified: trunk/Source/WebKit/mac/ChangeLog (213095 => 213096)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-27 22:44:19 UTC (rev 213095)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-27 22:54:26 UTC (rev 213096)
@@ -1,3 +1,13 @@
+2017-02-27  Aakash Jain  
+
+Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
+https://bugs.webkit.org/show_bug.cgi?id=168919
+
+Reviewed by Tim Horton.
+
+* Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
+* migrate-headers.sh: Run the migrate-headers script for installapi phase.
+
 2017-02-27  Alex Christensen  
 
 [libwebrtc] Enable WebRTC in some Production Builds


Modified: trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig (213095 => 213096)

--- trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig	2017-02-27 22:44:19 UTC (rev 213095)
+++ trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig	2017-02-27 22:54:26 UTC (rev 213096)
@@ -119,3 +119,8 @@
 
 WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR_$(WK_USE_OVERRIDE_FRAMEWORKS_DIR));
 WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR_YES = "$(WK_OVERRIDE_FRAMEWORKS_DIR)";
+
+// FIXME: Enable TAPI in open source builds once  is fixed in all supported SDKs.
+SUPPORTS_TEXT_BASED_API[sdk=iphone*] = $(USE_INTERNAL_SDK);
+OTHER_TAPI_FLAGS[sdk=iphone*] = -x objective-c++ -std=c++11 -fno-rtti;
+TAPI_VERIFY_MODE[sdk=iphone*] = Pedantic;


Modified: trunk/Source/WebKit/mac/migrate-headers.sh (213095 => 213096)

--- trunk/Source/WebKit/mac/migrate-headers.sh	2017-02-27 22:44:19 UTC (rev 213095)
+++ trunk/Source/WebKit/mac/migrate-headers.sh	2017-02-27 22:54:26 UTC (rev 

[webkit-changes] [205149] trunk/Tools

[aakash_jain]

Title: [205149] trunk/Tools








Revision 205149
Author aakash_j...@apple.com
Date 2016-08-29 14:51:35 -0700 (Mon, 29 Aug 2016)


Log Message
EWS should indicate which bot processed the patch
https://bugs.webkit.org/show_bug.cgi?id=161222

Reviewed by Alexey Proskuryakov.

* QueueStatusServer/handlers/statusbubble.py:
(StatusBubble._build_bubble): Remove the bot id from bubbles as it is confusing.
bot ids are now displayed in patch status page.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/QueueStatusServer/handlers/statusbubble.py




Diff

Modified: trunk/Tools/ChangeLog (205148 => 205149)

--- trunk/Tools/ChangeLog	2016-08-29 21:35:20 UTC (rev 205148)
+++ trunk/Tools/ChangeLog	2016-08-29 21:51:35 UTC (rev 205149)
@@ -1,3 +1,14 @@
+2016-08-29  Aakash Jain  
+
+EWS should indicate which bot processed the patch
+https://bugs.webkit.org/show_bug.cgi?id=161222
+
+Reviewed by Alexey Proskuryakov.
+
+* QueueStatusServer/handlers/statusbubble.py:
+(StatusBubble._build_bubble): Remove the bot id from bubbles as it is confusing.
+bot ids are now displayed in patch status page.
+
 2016-08-29  Alex Christensen  
 
 URLParser should parse about:blank


Modified: trunk/Tools/QueueStatusServer/handlers/statusbubble.py (205148 => 205149)

--- trunk/Tools/QueueStatusServer/handlers/statusbubble.py	2016-08-29 21:35:20 UTC (rev 205148)
+++ trunk/Tools/QueueStatusServer/handlers/statusbubble.py	2016-08-29 21:51:35 UTC (rev 205149)
@@ -132,7 +132,7 @@
 statuses))
 if not latest_resultative_status:
 bubble["state"] = "started"
-bubble["details_message"] = (statuses[0].bot_id + ", recent messages:\n\n"
+bubble["details_message"] = ("Recent messages:\n\n"
 + "\n".join([status.message for status in statuses]) + "\n\n" + self._iso_time(statuses[0].date))
 elif statuses[0].message == "Pass":
 bubble["state"] = "pass"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205160] trunk/Tools

[aakash_jain]

Title: [205160] trunk/Tools








Revision 205160
Author aakash_j...@apple.com
Date 2016-08-29 16:54:25 -0700 (Mon, 29 Aug 2016)


Log Message
EWS patch status page should indicate bot corresponding to each status message
https://bugs.webkit.org/show_bug.cgi?id=161280

Reviewed by Alexey Proskuryakov.

* QueueStatusServer/templates/patch.html: Formatting changes.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/QueueStatusServer/templates/patch.html




Diff

Modified: trunk/Tools/ChangeLog (205159 => 205160)

--- trunk/Tools/ChangeLog	2016-08-29 23:23:56 UTC (rev 205159)
+++ trunk/Tools/ChangeLog	2016-08-29 23:54:25 UTC (rev 205160)
@@ -1,5 +1,14 @@
 2016-08-29  Aakash Jain  
 
+EWS patch status page should indicate bot corresponding to each status message
+https://bugs.webkit.org/show_bug.cgi?id=161280
+
+Reviewed by Alexey Proskuryakov.
+
+* QueueStatusServer/templates/patch.html: Formatting changes.
+
+2016-08-29  Aakash Jain  
+
 EWS should indicate which bot processed the patch
 https://bugs.webkit.org/show_bug.cgi?id=161222
 


Modified: trunk/Tools/QueueStatusServer/templates/patch.html (205159 => 205160)

--- trunk/Tools/QueueStatusServer/templates/patch.html	2016-08-29 23:23:56 UTC (rev 205159)
+++ trunk/Tools/QueueStatusServer/templates/patch.html	2016-08-29 23:54:25 UTC (rev 205160)
@@ -12,7 +12,7 @@
   {{ queue_name }}
   {% for status in statuses %}
 
-  ({{ status.bot_id }}): 
+  {{ status.bot_id }}
   {{ status.message|force_escape|urlize|webkit_linkify|safe }}{% if status.results_file %}
   [{{ status.key.id|results_link|safe }}]{% endif %}
   {{ status.date|timesince }} ago






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206187] trunk/Tools

[aakash_jain]

Title: [206187] trunk/Tools








Revision 206187
Author aakash_j...@apple.com
Date 2016-09-20 17:21:02 -0700 (Tue, 20 Sep 2016)


Log Message
enable remote_api (for debugging) in flakiness dashboard app
https://bugs.webkit.org/show_bug.cgi?id=162325

Reviewed by Alexey Proskuryakov.

* TestResultServer/app.yaml: enabled remote_api and datastore_admin.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/app.yaml




Diff

Modified: trunk/Tools/ChangeLog (206186 => 206187)

--- trunk/Tools/ChangeLog	2016-09-20 23:58:00 UTC (rev 206186)
+++ trunk/Tools/ChangeLog	2016-09-21 00:21:02 UTC (rev 206187)
@@ -1,3 +1,12 @@
+2016-09-20  Aakash Jain  
+
+enable remote_api (for debugging) in flakiness dashboard app
+https://bugs.webkit.org/show_bug.cgi?id=162325
+
+Reviewed by Alexey Proskuryakov.
+
+* TestResultServer/app.yaml: enabled remote_api and datastore_admin.
+
 2016-09-20  Ryan Haddad  
 
 Unreviewed, rolling out r206180.


Modified: trunk/Tools/TestResultServer/app.yaml (206186 => 206187)

--- trunk/Tools/TestResultServer/app.yaml	2016-09-20 23:58:00 UTC (rev 206186)
+++ trunk/Tools/TestResultServer/app.yaml	2016-09-21 00:21:02 UTC (rev 206187)
@@ -4,6 +4,10 @@
 threadsafe: false
 api_version: 1
 
+builtins:
+- datastore_admin: on
+- remote_api: on
+
 handlers:
 - url: /stylesheets
   static_dir: stylesheets






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205010] trunk/Tools

[aakash_jain]

Title: [205010] trunk/Tools








Revision 205010
Author aakash_j...@apple.com
Date 2016-08-26 03:54:51 -0700 (Fri, 26 Aug 2016)


Log Message
EWS should indicate which bot processed the patch
https://bugs.webkit.org/show_bug.cgi?id=161222

Reviewed by Daniel Bates.

* QueueStatusServer/handlers/statusbubble.py:
(StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
Also added "Started processing patch" message to progress_statuses.
I might consider displaying bot id in other statuses as well later on.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/QueueStatusServer/handlers/statusbubble.py




Diff

Modified: trunk/Tools/ChangeLog (205009 => 205010)

--- trunk/Tools/ChangeLog	2016-08-26 08:46:02 UTC (rev 205009)
+++ trunk/Tools/ChangeLog	2016-08-26 10:54:51 UTC (rev 205010)
@@ -1,3 +1,16 @@
+2016-08-26  Aakash Jain  
+
+EWS should indicate which bot processed the patch
+https://bugs.webkit.org/show_bug.cgi?id=161222
+
+Reviewed by Daniel Bates.
+
+* QueueStatusServer/handlers/statusbubble.py:
+(StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
+after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
+Also added "Started processing patch" message to progress_statuses.
+I might consider displaying bot id in other statuses as well later on.
+
 2016-08-26  Gyuyoung Kim  
 
 [EFL] Change homepage url to www.ewebkit.org on MiniBrowser


Modified: trunk/Tools/QueueStatusServer/handlers/statusbubble.py (205009 => 205010)

--- trunk/Tools/QueueStatusServer/handlers/statusbubble.py	2016-08-26 08:46:02 UTC (rev 205009)
+++ trunk/Tools/QueueStatusServer/handlers/statusbubble.py	2016-08-26 10:54:51 UTC (rev 205010)
@@ -40,6 +40,7 @@
 from sets import Set
 
 progress_statuses = Set([
+"Started processing patch",
 "Cleaned working directory",
 "Updated working directory",
 "Applied patch",
@@ -131,7 +132,7 @@
 statuses))
 if not latest_resultative_status:
 bubble["state"] = "started"
-bubble["details_message"] = ("Started processing.\n\nRecent messages:\n\n"
+bubble["details_message"] = (statuses[0].bot_id + ", recent messages:\n\n"
 + "\n".join([status.message for status in statuses]) + "\n\n" + self._iso_time(statuses[0].date))
 elif statuses[0].message == "Pass":
 bubble["state"] = "pass"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205054] trunk/Tools

[aakash_jain]

Title: [205054] trunk/Tools








Revision 205054
Author aakash_j...@apple.com
Date 2016-08-26 15:52:06 -0700 (Fri, 26 Aug 2016)


Log Message
webkit-queues queue-status page should should list more recent statuses
https://bugs.webkit.org/show_bug.cgi?id=161220

Reviewed by Daniel Bates.

* QueueStatusServer/handlers/queuestatus.py:
(QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/QueueStatusServer/handlers/queuestatus.py




Diff

Modified: trunk/Tools/ChangeLog (205053 => 205054)

--- trunk/Tools/ChangeLog	2016-08-26 22:41:41 UTC (rev 205053)
+++ trunk/Tools/ChangeLog	2016-08-26 22:52:06 UTC (rev 205054)
@@ -1,3 +1,13 @@
+2016-08-26  Aakash Jain  
+
+webkit-queues queue-status page should should list more recent statuses
+https://bugs.webkit.org/show_bug.cgi?id=161220
+
+Reviewed by Daniel Bates.
+
+* QueueStatusServer/handlers/queuestatus.py:
+(QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.
+
 2016-08-26  Dan Bernstein  
 
 [Cocoa] Infinite recursion calling -charValue on a WKNSNumber


Modified: trunk/Tools/QueueStatusServer/handlers/queuestatus.py (205053 => 205054)

--- trunk/Tools/QueueStatusServer/handlers/queuestatus.py	2016-08-26 22:41:41 UTC (rev 205053)
+++ trunk/Tools/QueueStatusServer/handlers/queuestatus.py	2016-08-26 22:52:06 UTC (rev 205054)
@@ -62,7 +62,7 @@
 statuses.filter("queue_name =", queue.name())
 if bot_id:
 statuses.filter("bot_id =", bot_id)
-return statuses.order("-date").fetch(15)
+return statuses.order("-date").fetch(50)
 
 def _fetch_last_message_matching(self, queue, bot_id, message):
 statuses = queuestatus.QueueStatus.all()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205121] trunk/Tools

[aakash_jain]

Title: [205121] trunk/Tools








Revision 205121
Author aakash_j...@apple.com
Date 2016-08-29 09:18:37 -0700 (Mon, 29 Aug 2016)


Log Message
EWS patch status page should indicate bot corresponding to each status message
https://bugs.webkit.org/show_bug.cgi?id=161280

Reviewed by Alexey Proskuryakov.

* QueueStatusServer/templates/patch.html: Added bot_id in the template so that bot id is displayed
for each status message.
* QueueStatusServer/stylesheets/common.css:
(.status-bot): Added corresponding stylesheet class.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/QueueStatusServer/stylesheets/common.css
trunk/Tools/QueueStatusServer/templates/patch.html




Diff

Modified: trunk/Tools/ChangeLog (205120 => 205121)

--- trunk/Tools/ChangeLog	2016-08-29 16:12:24 UTC (rev 205120)
+++ trunk/Tools/ChangeLog	2016-08-29 16:18:37 UTC (rev 205121)
@@ -1,3 +1,15 @@
+2016-08-29  Aakash Jain  
+
+EWS patch status page should indicate bot corresponding to each status message
+https://bugs.webkit.org/show_bug.cgi?id=161280
+
+Reviewed by Alexey Proskuryakov.
+
+* QueueStatusServer/templates/patch.html: Added bot_id in the template so that bot id is displayed
+for each status message.
+* QueueStatusServer/stylesheets/common.css:
+(.status-bot): Added corresponding stylesheet class.
+
 2016-08-29  Per Arne Vollan  
 
 Attempt to fix Windows build after r205090.


Modified: trunk/Tools/QueueStatusServer/stylesheets/common.css (205120 => 205121)

--- trunk/Tools/QueueStatusServer/stylesheets/common.css	2016-08-29 16:12:24 UTC (rev 205120)
+++ trunk/Tools/QueueStatusServer/stylesheets/common.css	2016-08-29 16:18:37 UTC (rev 205121)
@@ -72,6 +72,12 @@
   font-size: 8pt;
 }
 
+.status-bot {
+  color: #AAA;
+  float: left;
+  font-size: 11pt;
+}
+
 .queue_bubble {
 border: 1px solid black;
 margin-bottom: 10px;


Modified: trunk/Tools/QueueStatusServer/templates/patch.html (205120 => 205121)

--- trunk/Tools/QueueStatusServer/templates/patch.html	2016-08-29 16:12:24 UTC (rev 205120)
+++ trunk/Tools/QueueStatusServer/templates/patch.html	2016-08-29 16:18:37 UTC (rev 205121)
@@ -12,6 +12,7 @@
   {{ queue_name }}
   {% for status in statuses %}
 
+  ({{ status.bot_id }}): 
   {{ status.message|force_escape|urlize|webkit_linkify|safe }}{% if status.results_file %}
   [{{ status.key.id|results_link|safe }}]{% endif %}
   {{ status.date|timesince }} ago






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205003] trunk/Tools

[aakash_jain]

Title: [205003] trunk/Tools








Revision 205003
Author aakash_j...@apple.com
Date 2016-08-25 22:33:58 -0700 (Thu, 25 Aug 2016)


Log Message
ews queues should update status server when they start processing patch
https://bugs.webkit.org/show_bug.cgi?id=161223

Reviewed by Daniel Bates.

* Scripts/webkitpy/tool/commands/queues.py:
(AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(StyleQueueTest.test_style_queue_with_style_exception): Same.
(test_style_queue_with_watch_list_exception): Same.
(test_non_valid_patch): Same.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py
trunk/Tools/Scripts/webkitpy/tool/commands/queues.py
trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (205002 => 205003)

--- trunk/Tools/ChangeLog	2016-08-26 02:16:41 UTC (rev 205002)
+++ trunk/Tools/ChangeLog	2016-08-26 05:33:58 UTC (rev 205003)
@@ -1,3 +1,19 @@
+2016-08-25  Aakash Jain  
+
+ews queues should update status server when they start processing patch
+https://bugs.webkit.org/show_bug.cgi?id=161223
+
+Reviewed by Daniel Bates.
+
+* Scripts/webkitpy/tool/commands/queues.py:
+(AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
+* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
+(EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
+* Scripts/webkitpy/tool/commands/queues_unittest.py:
+(StyleQueueTest.test_style_queue_with_style_exception): Same.
+(test_style_queue_with_watch_list_exception): Same.
+(test_non_valid_patch): Same.
+
 2016-08-25  Alex Christensen  
 
 CMake build fix.


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py (205002 => 205003)

--- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py	2016-08-26 02:16:41 UTC (rev 205002)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py	2016-08-26 05:33:58 UTC (rev 205003)
@@ -77,7 +77,8 @@
 
 expected_logs = {
 "begin_work_queue": self._default_begin_work_queue_logs(ews.name),
-"process_work_item": """Running: webkit-patch --status-host=example.com clean --port=%(port)s%(architecture)s
+"process_work_item": """MOCK: update_status: %(name)s Started processing patch
+Running: webkit-patch --status-host=example.com clean --port=%(port)s%(architecture)s
 Running: webkit-patch --status-host=example.com update --port=%(port)s%(architecture)s
 Running: webkit-patch --status-host=example.com apply-attachment --no-update --non-interactive 1 --port=%(port)s%(architecture)s
 Running: webkit-patch --status-host=example.com build --no-clean --no-update --build-style=%(build_style)s --port=%(port)s%(architecture)s


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queues.py (205002 => 205003)

--- trunk/Tools/Scripts/webkitpy/tool/commands/queues.py	2016-08-26 02:16:41 UTC (rev 205002)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/queues.py	2016-08-26 05:33:58 UTC (rev 205003)
@@ -445,6 +445,7 @@
 return self._next_patch()
 
 def process_work_item(self, patch):
+self._update_status("Started processing patch", patch)
 passed = self.review_patch(patch)
 if passed:
 self._did_pass(patch)


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py (205002 => 205003)

--- trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py	2016-08-26 02:16:41 UTC (rev 205002)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py	2016-08-26 05:33:58 UTC (rev 205003)
@@ -471,7 +471,8 @@
 def test_style_queue_with_style_exception(self):
 expected_logs = {
 "begin_work_queue": self._default_begin_work_queue_logs("style-queue"),
-"process_work_item": """Running: webkit-patch --status-host=example.com clean
+"process_work_item": """MOCK: update_status: style-queue Started processing patch
+Running: webkit-patch --status-host=example.com clean
 MOCK: update_status: style-queue Cleaned working directory
 Running: webkit-patch --status-host=example.com update
 MOCK: update_status: style-queue Updated working directory
@@ -493,7 +494,8 @@
 def test_style_queue_with_watch_list_exception(self):
 expected_logs = {
 "begin_work_queue": self._default_begin_work_queue_logs("style-queue"),
-"process_work_item": """Running: webkit-patch --status-host=example.com clean
+"process_work_item": """MOCK: 

[webkit-changes] [214470] trunk/Tools

[aakash_jain]

Title: [214470] trunk/Tools








Revision 214470
Author aakash_j...@apple.com
Date 2017-03-28 02:33:21 -0700 (Tue, 28 Mar 2017)


Log Message
Dashboard test fails with error: latestIterationGetter is not a function
https://bugs.webkit.org/show_bug.cgi?id=170167

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
(this.view._latestProductiveIteration): Configure _latestProductiveIteration in setup.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js (214469 => 214470)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js	2017-03-28 07:49:56 UTC (rev 214469)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js	2017-03-28 09:33:21 UTC (rev 214470)
@@ -167,6 +167,13 @@
 };
 this.queue.branches = [this.trunkBranch];
 this.view = new MockBuildbotQueueView([this.queue]);
+this.view._latestProductiveIteration = function(queue)
+{
+var iteration = {
+revision: { "openSource": "33021" },
+};
+return iteration;
+}
 }
 });
 
@@ -173,7 +180,7 @@
 var settings = new Settings;
 test("_appendPendingRevisionCount", function()
 {
-this.view._appendPendingRevisionCount(this.queue);
+this.view._appendPendingRevisionCount(this.queue, this.view._latestProductiveIteration);
 var revisionsBehind = this.view.element.getElementsByClassName("message")[0].innerHTML.match(/.*(\d+) revision(|s) behind/)[1];
 strictEqual(revisionsBehind, "1", "assert revisions behind");
 });
@@ -188,7 +195,7 @@
 {
 var element = document.createElement("div");
 var popover = new Dashboard.Popover();
-this.view._presentPopoverForPendingCommits(element, popover, this.queue);
+this.view._presentPopoverForPendingCommits(this.view._latestProductiveIteration, element, popover, this.queue);
 var nodeList = popover._element.getElementsByClassName("pending-commit");
 strictEqual(nodeList.length, 1, "has 1 pending commit");
 });
@@ -204,16 +211,9 @@
 }
 };
 this.queue.branches = [this.someOtherBranch];
-this.view._latestProductiveIteration = function(queue)
-{
-var iteration = {
-revision: { "openSource": "33021" },
-};
-return iteration;
-};
 var element = document.createElement("div");
 var popover = new Dashboard.Popover();
-this.view._presentPopoverForPendingCommits(element, popover, this.queue);
+this.view._presentPopoverForPendingCommits(this.view._latestProductiveIteration, element, popover, this.queue);
 var nodeList = popover._element.getElementsByClassName("pending-commit");
 strictEqual(nodeList.length, 0, "has 0 pending commits");
 });


Modified: trunk/Tools/ChangeLog (214469 => 214470)

--- trunk/Tools/ChangeLog	2017-03-28 07:49:56 UTC (rev 214469)
+++ trunk/Tools/ChangeLog	2017-03-28 09:33:21 UTC (rev 214470)
@@ -1,3 +1,13 @@
+2017-03-28  Aakash Jain  
+
+Dashboard test fails with error: latestIterationGetter is not a function
+https://bugs.webkit.org/show_bug.cgi?id=170167
+
+Reviewed by Alexey Proskuryakov.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
+(this.view._latestProductiveIteration): Configure _latestProductiveIteration in setup.
+
 2017-03-27  Lucas Forschler  
 
 Another test v8.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214615] trunk/Tools

[aakash_jain]

Title: [214615] trunk/Tools








Revision 214615
Author aakash_j...@apple.com
Date 2017-03-30 12:43:36 -0700 (Thu, 30 Mar 2017)


Log Message
Change my status to be a WebKit reviewer.

Unreviewed status update edit.

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (214614 => 214615)

--- trunk/Tools/ChangeLog	2017-03-30 19:18:07 UTC (rev 214614)
+++ trunk/Tools/ChangeLog	2017-03-30 19:43:36 UTC (rev 214615)
@@ -1,3 +1,11 @@
+2017-03-30  Aakash Jain  <aakash_j...@apple.com>
+
+Change my status to be a WebKit reviewer.
+
+Unreviewed status update edit.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2017-03-30  Carlos Alberto Lopez Perez  <clo...@igalia.com>
 
 Change my status to be a WebKit reviewer.


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (214614 => 214615)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2017-03-30 19:18:07 UTC (rev 214614)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2017-03-30 19:43:36 UTC (rev 214615)
@@ -6,7 +6,7 @@
   "nicks" : [
  "aakash_jain"
   ],
-  "status" : "committer"
+  "status" : "reviewer"
},
"Aaron Boodman" : {
   "emails" : [






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214497] trunk/Tools

[aakash_jain]

Title: [214497] trunk/Tools








Revision 214497
Author aakash_j...@apple.com
Date 2017-03-28 15:14:49 -0700 (Tue, 28 Mar 2017)


Log Message
Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions
https://bugs.webkit.org/show_bug.cgi?id=170193

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
Fixed the order of arguments.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js (214496 => 214497)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js	2017-03-28 21:56:10 UTC (rev 214496)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js	2017-03-28 22:14:49 UTC (rev 214497)
@@ -324,7 +324,7 @@
 iteration._javascript_CoreTestResults = new MockBuildbotTestResults();
 
 var view = new BuildbotQueueView();
-view._presentPopoverForJavaScriptCoreTestRegressions(element, popover, iteration, "jscore-test");
+view._presentPopoverForJavaScriptCoreTestRegressions("jscore-test", element, popover, iteration);
 
 JSON.load("resources/test-jsc-results.json", function(data)
 {
@@ -368,7 +368,7 @@
 iteration._javascript_CoreTestResults = {"regressions": ["uno", "dos", "tres"]};
 
 var view = new BuildbotQueueView();
-view._presentPopoverForJavaScriptCoreTestRegressions(element, popover, iteration, "jscore-test");
+view._presentPopoverForJavaScriptCoreTestRegressions("jscore-test", element, popover, iteration);
 
 var numChildrenInEmptyPopoverContent = 2;
 strictEqual(popover._content.childNodes.length - numChildrenInEmptyPopoverContent,


Modified: trunk/Tools/ChangeLog (214496 => 214497)

--- trunk/Tools/ChangeLog	2017-03-28 21:56:10 UTC (rev 214496)
+++ trunk/Tools/ChangeLog	2017-03-28 22:14:49 UTC (rev 214497)
@@ -1,5 +1,15 @@
 2017-03-28  Aakash Jain  
 
+Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions
+https://bugs.webkit.org/show_bug.cgi?id=170193
+
+Reviewed by Alexey Proskuryakov.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
+Fixed the order of arguments.
+
+2017-03-28  Aakash Jain  
+
 Dashboard tests fails to fetch the revision from commits
 https://bugs.webkit.org/show_bug.cgi?id=170191
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214496] trunk/Tools

[aakash_jain]

Title: [214496] trunk/Tools








Revision 214496
Author aakash_j...@apple.com
Date 2017-03-28 14:56:10 -0700 (Tue, 28 Mar 2017)


Log Message
Dashboard tests fails to fetch the revision from commits
https://bugs.webkit.org/show_bug.cgi?id=170191

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
Added recordedCommitIndicesByRevisionNumber.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
(setup): Populated trac.recordedCommitIndicesByRevisionNumber since the dashboard code uses this variable.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js (214495 => 214496)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js	2017-03-28 21:43:49 UTC (rev 214495)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js	2017-03-28 21:56:10 UTC (rev 214496)
@@ -106,4 +106,15 @@
 "containsBranchLocation": true,
 "branches": ["trunk"]
 }
-];
\ No newline at end of file
+];
+
+MockTrac.recordedCommitIndicesByRevisionNumber = {
+33018: 0,
+33019: 1,
+33020: 2,
+33021: 3,
+33022: 4,
+33023: 5,
+33024: 6,
+33025: 7
+};


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js (214495 => 214496)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js	2017-03-28 21:43:49 UTC (rev 214495)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js	2017-03-28 21:56:10 UTC (rev 214496)
@@ -91,6 +91,7 @@
 test("nextRevision", function()
 {
 this.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
+this.trac.recordedCommitIndicesByRevisionNumber = MockTrac.recordedCommitIndicesByRevisionNumber;
 strictEqual(this.trac.nextRevision("trunk", "33020"), "33022", "nextRevision same branch");
 strictEqual(this.trac.nextRevision("trunk", "33019"), "33020", "nextRevision different branch");
 });
@@ -98,6 +99,7 @@
 test("indexOfRevision", function()
 {
 this.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
+this.trac.recordedCommitIndicesByRevisionNumber = MockTrac.recordedCommitIndicesByRevisionNumber;
 strictEqual(this.trac.indexOfRevision("33020"), 2, "indexOfRevision");
 });
 
@@ -104,6 +106,7 @@
 test("commitsOnBranchLaterThanRevision", function()
 {
 this.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
+this.trac.recordedCommitIndicesByRevisionNumber = MockTrac.recordedCommitIndicesByRevisionNumber;
 var commits = this.trac.commitsOnBranchLaterThanRevision("trunk", "33020");
 equal(commits.length, 1, "greater than 33020");
 });
@@ -111,6 +114,7 @@
 test("commitsOnBranchLaterThanRevision no commits", function()
 {
 this.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
+this.trac.recordedCommitIndicesByRevisionNumber = MockTrac.recordedCommitIndicesByRevisionNumber;
 var commits = this.trac.commitsOnBranchLaterThanRevision("someOtherBranch", "33021");
 equal(commits.length, 0, "greater than 33021");
 });
@@ -118,6 +122,7 @@
 test("commitsOnBranchInRevisionRange", function()
 {
 this.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
+this.trac.recordedCommitIndicesByRevisionNumber = MockTrac.recordedCommitIndicesByRevisionNumber;
 var commits = this.trac.commitsOnBranchInRevisionRange("trunk", "33020", "33022");
 equal(commits.length, 2, "in range 33020, 33022");
 });
@@ -156,6 +161,7 @@
 setup: function() {
 this.trac = new MockTrac();
 this.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
+this.trac.recordedCommitIndicesByRevisionNumber = MockTrac.recordedCommitIndicesByRevisionNumber;
 this.queue = new MockBuildbotQueue();
 this.trunkBranch = {
 name: "trunk",
@@ -382,6 +388,7 @@
 setup: function() {
 Dashboard.Repository.OpenSource.trac = new MockTrac();
 Dashboard.Repository.OpenSource.trac.recordedCommits = MockTrac.EXAMPLE_TRAC_COMMITS;
+Dashboard.Repository.OpenSource.trac.recordedCommitIndicesByRevisionNumber = MockTrac.recordedCommitIndicesByRevisionNumber;
 this.queue = new MockBuildbotQueue();
 this.queue.branches = [{
 name: "trunk",


Modified: trunk/Tools/ChangeLog (214495 => 214496)

--- trunk/Tools/ChangeLog	2017-03-28 21:43:49 UTC (rev 214495)
+++ trunk/Tools/ChangeLog	2017-03-28 21:56:10 UTC (rev 

[webkit-changes] [214631] trunk/Tools

[aakash_jain]

Title: [214631] trunk/Tools








Revision 214631
Author aakash_j...@apple.com
Date 2017-03-30 15:18:22 -0700 (Thu, 30 Mar 2017)


Log Message
Support tvOS and watchOS in webkitdirs.pm
https://bugs.webkit.org/show_bug.cgi?id=170267

Reviewed by Alexey Proskuryakov.

* Scripts/webkitdirs.pm:
(determineXcodeSDK): Evaluate sdk for tvos and watchos.
(xcodeSDKPlatformName): Added support for tvos and watchos.
(determinePortName): Same.
(isAppleCocoaWebKit): Same.
(willUseAppleTVDeviceSDK): Added.
(willUseAppleTVSimulatorSDK): Added.
(willUseWatchDeviceSDK): Added.
(willUseWatchSimulatorSDK): Added.
(isTVOSWebKit): Added.
(isWATCHOSWebKit): Added.
(isIOSLikeWebKit): Added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Tools/ChangeLog (214630 => 214631)

--- trunk/Tools/ChangeLog	2017-03-30 22:08:46 UTC (rev 214630)
+++ trunk/Tools/ChangeLog	2017-03-30 22:18:22 UTC (rev 214631)
@@ -1,3 +1,23 @@
+2017-03-30  Aakash Jain  
+
+Support tvOS and watchOS in webkitdirs.pm
+https://bugs.webkit.org/show_bug.cgi?id=170267
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitdirs.pm:
+(determineXcodeSDK): Evaluate sdk for tvos and watchos.
+(xcodeSDKPlatformName): Added support for tvos and watchos.
+(determinePortName): Same.
+(isAppleCocoaWebKit): Same.
+(willUseAppleTVDeviceSDK): Added.
+(willUseAppleTVSimulatorSDK): Added.
+(willUseWatchDeviceSDK): Added.
+(willUseWatchSimulatorSDK): Added.
+(isTVOSWebKit): Added.
+(isWATCHOSWebKit): Added.
+(isIOSLikeWebKit): Added.
+
 2017-03-30  Wenson Hsieh  
 
 [WK2] Touches should not cancel when showing a custom action sheet while data interaction is active


Modified: trunk/Tools/Scripts/webkitdirs.pm (214630 => 214631)

--- trunk/Tools/Scripts/webkitdirs.pm	2017-03-30 22:08:46 UTC (rev 214630)
+++ trunk/Tools/Scripts/webkitdirs.pm	2017-03-30 22:18:22 UTC (rev 214631)
@@ -102,6 +102,8 @@
 GTK  => "GTK",
 Efl  => "Efl",
 iOS  => "iOS",
+tvOS => "tvOS",
+watchOS  => "watchOS",
 Mac  => "Mac",
 JSCOnly  => "JSCOnly",
 WinCairo => "WinCairo",
@@ -464,6 +466,20 @@
 if (checkForArgumentAndRemoveFromARGV("--simulator") || checkForArgumentAndRemoveFromARGV("--ios-simulator")) {
 $xcodeSDK ||= 'iphonesimulator';
 }
+if (checkForArgumentAndRemoveFromARGV("--tvos-device")) {
+my $hasInternalSDK = exitStatus(system("xcrun --sdk appletvos.internal --show-sdk-version > /dev/null 2>&1")) == 0;
+$xcodeSDK ||=  $hasInternalSDK ? "appletvos.internal" : "appletvos";
+}
+if (checkForArgumentAndRemoveFromARGV("--tvos-simulator")) {
+$xcodeSDK ||= "appletvsimulator";
+}
+if (checkForArgumentAndRemoveFromARGV("--watchos-device")) {
+my $hasInternalSDK = exitStatus(system("xcrun --sdk watchos.internal --show-sdk-version > /dev/null 2>&1")) == 0;
+$xcodeSDK ||=  $hasInternalSDK ? "watchos.internal" : "watchos";
+}
+if (checkForArgumentAndRemoveFromARGV("--watchos-simulator")) {
+$xcodeSDK ||= "watchsimulator";
+}
 }
 
 sub xcodeSDK
@@ -482,9 +498,13 @@
 {
 determineXcodeSDK();
 return "" if !defined $xcodeSDK;
+return "appletvos" if $xcodeSDK =~ /appletvos/i;
+return "appletvsimulator" if $xcodeSDK =~ /appletvsimulator/i;
 return "iphoneos" if $xcodeSDK =~ /iphoneos/i;
 return "iphonesimulator" if $xcodeSDK =~ /iphonesimulator/i;
 return "macosx" if $xcodeSDK =~ /macosx/i;
+return "watchos" if $xcodeSDK =~ /watchos/i;
+return "watchsimulator" if $xcodeSDK =~ /watchsimulator/i;
 die "Couldn't determine platform name from Xcode SDK";
 }
 
@@ -1039,6 +1059,10 @@
 determineXcodeSDK();
 if (willUseIOSDeviceSDK() || willUseIOSSimulatorSDK()) {
 $portName = iOS;
+} elsif (willUseAppleTVDeviceSDK() || willUseAppleTVSimulatorSDK()) {
+$portName = tvOS;
+} elsif (willUseWatchDeviceSDK() || willUseWatchSimulatorSDK()) {
+$portName = watchOS;
 } else {
 $portName = Mac;
 }
@@ -1223,7 +1247,7 @@
 
 sub isAppleCocoaWebKit()
 {
-return (portName() eq Mac) || isIOSWebKit();
+return (portName() eq Mac) || isIOSWebKit() || isTVOSWebKit() || isWatchOSWebKit();
 }
 
 sub isAppleWinWebKit()
@@ -1289,11 +1313,46 @@
 return xcodeSDKPlatformName() eq "iphonesimulator";
 }
 
+sub willUseAppleTVDeviceSDK()
+{
+return xcodeSDKPlatformName() eq "appletvos";
+}
+
+sub willUseAppleTVSimulatorSDK()
+{
+return xcodeSDKPlatformName() eq "appletvsimulator";
+}
+
+sub willUseWatchDeviceSDK()
+{
+return xcodeSDKPlatformName() eq "watchos";
+}
+
+sub willUseWatchSimulatorSDK()
+{
+return xcodeSDKPlatformName() eq "watchsimulator";
+}
+
 sub isIOSWebKit()
 {
 return portName() eq iOS;
 }
 
+sub 

[webkit-changes] [214238] trunk/Tools

[aakash_jain]

Title: [214238] trunk/Tools








Revision 214238
Author aakash_j...@apple.com
Date 2017-03-21 17:45:15 -0700 (Tue, 21 Mar 2017)


Log Message
EWS fails to parse_bug_id_from_attachment_page after bugzilla upgrade
https://bugs.webkit.org/show_bug.cgi?id=169937


Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla._parse_bug_id_from_attachment_page): Since rel tag is no longer present, parsing the bug id from bug_title. 
* Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fixed unit test.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py
trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (214237 => 214238)

--- trunk/Tools/ChangeLog	2017-03-22 00:08:40 UTC (rev 214237)
+++ trunk/Tools/ChangeLog	2017-03-22 00:45:15 UTC (rev 214238)
@@ -1,5 +1,17 @@
 2017-03-21  Aakash Jain  
 
+EWS fails to parse_bug_id_from_attachment_page after bugzilla upgrade
+https://bugs.webkit.org/show_bug.cgi?id=169937
+
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+(Bugzilla._parse_bug_id_from_attachment_page): Since rel tag is no longer present, parsing the bug id from bug_title. 
+* Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fixed unit test.
+
+2017-03-21  Aakash Jain  
+
 ews should indicate in logs when it fails to parse_bug_id_from_attachment_page
 https://bugs.webkit.org/show_bug.cgi?id=169927
 


Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py (214237 => 214238)

--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py	2017-03-22 00:08:40 UTC (rev 214237)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py	2017-03-22 00:45:15 UTC (rev 214238)
@@ -486,11 +486,14 @@
 
 def _parse_bug_id_from_attachment_page(self, page):
 # The "Up" relation happens to point to the bug.
-up_link = BeautifulSoup(page).find('link', rel='Up')
-if not up_link:
+title = BeautifulSoup(page).find('div', attrs={'id':'bug_title'})
+if not title :
 _log.warning("This attachment does not exist (or you don't have permissions to view it).")
 return None
-match = re.search("show_bug.cgi\?id=(?P\d+)", up_link['href'])
+match = re.search("show_bug.cgi\?id=(?P\d+)", str(title))
+if not match:
+_log.warning("Unable to parse bug id from attachment")
+return None
 return int(match.group('bug_id'))
 
 def bug_id_for_attachment_id(self, attachment_id):


Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py (214237 => 214238)

--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py	2017-03-22 00:08:40 UTC (rev 214237)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py	2017-03-22 00:45:15 UTC (rev 214238)
@@ -238,8 +238,9 @@
   
 
   Attachment 41073 Details for Bug 27314
-+
+  Attachment 41073 Details for
+  : Sample bug
 """
 
 def test_attachment_detail_bug_parsing(self):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214233] trunk/Tools

[aakash_jain]

Title: [214233] trunk/Tools








Revision 214233
Author aakash_j...@apple.com
Date 2017-03-21 15:33:30 -0700 (Tue, 21 Mar 2017)


Log Message
ews should indicate in logs when it fails to parse_bug_id_from_attachment_page
https://bugs.webkit.org/show_bug.cgi?id=169927

Reviewed by  Alexey Proskuryakov.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla._parse_bug_id_from_attachment_page): Added log statement.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py




Diff

Modified: trunk/Tools/ChangeLog (214232 => 214233)

--- trunk/Tools/ChangeLog	2017-03-21 21:39:01 UTC (rev 214232)
+++ trunk/Tools/ChangeLog	2017-03-21 22:33:30 UTC (rev 214233)
@@ -1,3 +1,13 @@
+2017-03-21  Aakash Jain  
+
+ews should indicate in logs when it fails to parse_bug_id_from_attachment_page
+https://bugs.webkit.org/show_bug.cgi?id=169927
+
+Reviewed by  Alexey Proskuryakov.
+
+* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+(Bugzilla._parse_bug_id_from_attachment_page): Added log statement.
+
 2017-03-20  Simon Fraser  
 
 Add a system trace point for memory warning handling


Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py (214232 => 214233)

--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py	2017-03-21 21:39:01 UTC (rev 214232)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py	2017-03-21 22:33:30 UTC (rev 214233)
@@ -488,8 +488,7 @@
 # The "Up" relation happens to point to the bug.
 up_link = BeautifulSoup(page).find('link', rel='Up')
 if not up_link:
-# This attachment does not exist (or you don't have permissions to
-# view it).
+_log.warning("This attachment does not exist (or you don't have permissions to view it).")
 return None
 match = re.search("show_bug.cgi\?id=(?P\d+)", up_link['href'])
 return int(match.group('bug_id'))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213974] trunk/Tools

[aakash_jain]

Title: [213974] trunk/Tools








Revision 213974
Author aakash_j...@apple.com
Date 2017-03-14 23:18:35 -0700 (Tue, 14 Mar 2017)


Log Message
start-queue-mac.sh should create logs directory if it doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=169634

Reviewed by Alexey Proskuryakov.

* EWSTools/start-queue-mac.sh: Creating logs directory if it doesn't exist.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/EWSTools/start-queue-mac.sh




Diff

Modified: trunk/Tools/ChangeLog (213973 => 213974)

--- trunk/Tools/ChangeLog	2017-03-15 05:52:08 UTC (rev 213973)
+++ trunk/Tools/ChangeLog	2017-03-15 06:18:35 UTC (rev 213974)
@@ -1,3 +1,12 @@
+2017-03-14  Aakash Jain  
+
+start-queue-mac.sh should create logs directory if it doesn't exist
+https://bugs.webkit.org/show_bug.cgi?id=169634
+
+Reviewed by Alexey Proskuryakov.
+
+* EWSTools/start-queue-mac.sh: Creating logs directory if it doesn't exist.
+
 2017-03-14  Andy Estes  
 
 [iOS] -[WKWebView _dataForDisplayedPDF] returns nil when called before an encrypted PDF has been unlocked


Modified: trunk/Tools/EWSTools/start-queue-mac.sh (213973 => 213974)

--- trunk/Tools/EWSTools/start-queue-mac.sh	2017-03-15 05:52:08 UTC (rev 213973)
+++ trunk/Tools/EWSTools/start-queue-mac.sh	2017-03-15 06:18:35 UTC (rev 213974)
@@ -41,7 +41,12 @@
 
 EWS_HOME=/Volumes/Data/EWS
 WEBKIT_HOME=$EWS_HOME/WebKit
+LOGS_DIR=$EWS_HOME/$QUEUE_NAME-logs
 
+if [ ! -d "$LOGS_DIR" ]; then
+mkdir -p $LOGS_DIR
+fi
+
 # If building for iOS, make sure we run this script to make it possible to build frameworks.
 if [ "$QUEUE_NAME" == "ios-ews" ]; then
 (cd $WEBKIT_HOME; sudo ./Tools/Scripts/configure-xcode-for-ios-development)
@@ -52,7 +57,7 @@
 
 while [ $TIME_TO_REBOOT -gt $(date +%s) ] || [ $(date +%H) -lt 1 ] || [ $(date +%H) -ge 6 ]; do
 # Delete log files older than 30 days, move aside the main $QUEUE_NAME-ews.log file to prevent it from growing extra large.
-cd $EWS_HOME/$QUEUE_NAME-logs
+cd $LOGS_DIR
 find . -mtime +30 -delete
 if [ -s $QUEUE_NAME.log ]; then
 filesize=$(stat -f%z "$QUEUE_NAME.log")  # filesize in bytes.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214957] trunk/Tools

[aakash_jain]

Title: [214957] trunk/Tools








Revision 214957
Author aakash_j...@apple.com
Date 2017-04-05 12:03:58 -0700 (Wed, 05 Apr 2017)


Log Message
Rename isIOSLikeWebKit to isEmbeddedWebKit.

Rubber-stamped by Alexey Proskuryakov. 

* Scripts/webkitdirs.pm:
(isEmbeddedWebKit): Added
(isIOSLikeWebKit): Deleted.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Tools/ChangeLog (214956 => 214957)

--- trunk/Tools/ChangeLog	2017-04-05 18:57:35 UTC (rev 214956)
+++ trunk/Tools/ChangeLog	2017-04-05 19:03:58 UTC (rev 214957)
@@ -1,3 +1,13 @@
+2017-04-05  Aakash Jain  
+
+Rename isIOSLikeWebKit to isEmbeddedWebKit.
+
+Rubber-stamped by Alexey Proskuryakov. 
+
+* Scripts/webkitdirs.pm:
+(isEmbeddedWebKit): Added
+(isIOSLikeWebKit): Deleted.
+
 2017-04-05  Alex Christensen  
 
 Fix CMake build.


Modified: trunk/Tools/Scripts/webkitdirs.pm (214956 => 214957)

--- trunk/Tools/Scripts/webkitdirs.pm	2017-04-05 18:57:35 UTC (rev 214956)
+++ trunk/Tools/Scripts/webkitdirs.pm	2017-04-05 19:03:58 UTC (rev 214957)
@@ -1348,7 +1348,7 @@
 return portName() eq watchOS;
 }
 
-sub isIOSLikeWebKit()
+sub isEmbeddedWebKit()
 {
 return  isIOSWebKit() || isTVOSWebKit() || isWatchOSWebKit();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214958] trunk/Tools

[aakash_jain]

Title: [214958] trunk/Tools








Revision 214958
Author aakash_j...@apple.com
Date 2017-04-05 12:08:07 -0700 (Wed, 05 Apr 2017)


Log Message
Formatting fix to remove extra space.

Unreviewed formatting fix.

* Scripts/webkitdirs.pm:
(isEmbeddedWebKit): Remove extra space.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Tools/ChangeLog (214957 => 214958)

--- trunk/Tools/ChangeLog	2017-04-05 19:03:58 UTC (rev 214957)
+++ trunk/Tools/ChangeLog	2017-04-05 19:08:07 UTC (rev 214958)
@@ -1,5 +1,14 @@
 2017-04-05  Aakash Jain  
 
+Formatting fix to remove extra space.
+
+Unreviewed formatting fix.
+
+* Scripts/webkitdirs.pm:
+(isEmbeddedWebKit): Remove extra space.
+
+2017-04-05  Aakash Jain  
+
 Rename isIOSLikeWebKit to isEmbeddedWebKit.
 
 Rubber-stamped by Alexey Proskuryakov. 


Modified: trunk/Tools/Scripts/webkitdirs.pm (214957 => 214958)

--- trunk/Tools/Scripts/webkitdirs.pm	2017-04-05 19:03:58 UTC (rev 214957)
+++ trunk/Tools/Scripts/webkitdirs.pm	2017-04-05 19:08:07 UTC (rev 214958)
@@ -1350,7 +1350,7 @@
 
 sub isEmbeddedWebKit()
 {
-return  isIOSWebKit() || isTVOSWebKit() || isWatchOSWebKit();
+return isIOSWebKit() || isTVOSWebKit() || isWatchOSWebKit();
 }
 
 sub determineNmPath()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [215214] trunk/Tools

[aakash_jain]

Title: [215214] trunk/Tools








Revision 215214
Author aakash_j...@apple.com
Date 2017-04-10 19:49:59 -0700 (Mon, 10 Apr 2017)


Log Message
Add test262 _javascript_Core tests to dashboard
https://bugs.webkit.org/show_bug.cgi?id=170711

Rubber-stamped by Joseph Pecoraro.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot): Added test262 JSC tests to dashboard.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js (215213 => 215214)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js	2017-04-11 01:14:15 UTC (rev 215213)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js	2017-04-11 02:49:59 UTC (rev 215214)
@@ -53,6 +53,8 @@
 "Apple El Capitan LLINT CLoop (BuildAndTest)": {heading: "LLINT CLoop (BuildAndTest)"},
 "Apple El Capitan Debug JSC (Tests)": {heading: "Debug JSC (Tests)"},
 "Apple El Capitan Release JSC (Tests)": {heading: "Release JSC (Tests)"},
+"Apple El Capitan Debug Test262 (Tests)": {heading: "Debug Test262 (Tests)"},
+"Apple El Capitan Release Test262 (Tests)": {heading: "Release Test262 (Tests)"},
 }},
 "Apple iOS 10 Release (Build)": {platform: Dashboard.Platform.iOS10Device, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.Universal},
 "Apple iOS 10 Simulator Release (Build)": {platform: Dashboard.Platform.iOS10Simulator, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},


Modified: trunk/Tools/ChangeLog (215213 => 215214)

--- trunk/Tools/ChangeLog	2017-04-11 01:14:15 UTC (rev 215213)
+++ trunk/Tools/ChangeLog	2017-04-11 02:49:59 UTC (rev 215214)
@@ -1,3 +1,13 @@
+2017-04-10  Aakash Jain  
+
+Add test262 _javascript_Core tests to dashboard
+https://bugs.webkit.org/show_bug.cgi?id=170711
+
+Rubber-stamped by Joseph Pecoraro.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
+(WebKitBuildbot): Added test262 JSC tests to dashboard.
+
 2017-04-10  Alex Christensen  
 
 REGRESSION(r195479) First main resource load in new WebProcess bypasses content extensions






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [215635] trunk/Tools

[aakash_jain]

Title: [215635] trunk/Tools








Revision 215635
Author aakash_j...@apple.com
Date 2017-04-21 13:56:04 -0700 (Fri, 21 Apr 2017)


Log Message
Bubbles on dashboard doesn't turn red for test262 failures
https://bugs.webkit.org/show_bug.cgi?id=171129

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added test262-test.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (215634 => 215635)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js	2017-04-21 20:31:39 UTC (rev 215634)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js	2017-04-21 20:56:04 UTC (rev 215635)
@@ -86,6 +86,7 @@
 "webkit-jsc-cloop-test": "_javascript_ cloop test",
 "webkitperl-test": "webkitperl test",
 "webkitpy-test": "webkitpy test",
+"test262-test": "test262 test",
 };
 
 BuildbotIteration.Event = {


Modified: trunk/Tools/ChangeLog (215634 => 215635)

--- trunk/Tools/ChangeLog	2017-04-21 20:31:39 UTC (rev 215634)
+++ trunk/Tools/ChangeLog	2017-04-21 20:56:04 UTC (rev 215635)
@@ -1,3 +1,12 @@
+2017-04-21  Aakash Jain  
+
+Bubbles on dashboard doesn't turn red for test262 failures
+https://bugs.webkit.org/show_bug.cgi?id=171129
+
+Reviewed by Alexey Proskuryakov.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added test262-test.
+
 2017-04-21  Commit Queue  
 
 Unreviewed, rolling out r215620 and r215623.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes