Re: [Wesnoth-dev] Feedback on automated name changing process
moreover, when you use svn rename, svn correctly tracks the file wrt change history On 4/22/07, Bruno Wolff III <[EMAIL PROTECTED]> wrote: > Would it be possible to have the update script issue svn rename commands, > rather than just renaming files. I found it a bit annoying that svn didn't > know the music files (in the test run) were just renamed and it downloaded > fresh copies when I did an update. This was probably a worst case scenario, > but even for text files it would still be nicer to avoid having to redownload > files that have only (or mostly) just had name changes. > > ___ > Wesnoth-dev mailing list > Wesnoth-dev@gna.org > https://mail.gna.org/listinfo/wesnoth-dev > ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] Feedback on automated name changing process
On Sun, Apr 22, 2007 at 10:10:27PM +0200, jeremy rosen wrote: > moreover, when you use svn rename, svn correctly tracks the file wrt > change history Right, but please note that subversion is still very faulty related to renames. It works probably more or less in a single branch such as trunk but forget merging renamed files from one branch to another. This will not work (yet, it's worked on but will probably still need at least one year until proper supported!). Jens ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] Feedback on automated name changing process
Bruno Wolff III <[EMAIL PROTECTED]>: > Would it be possible to have the update script issue svn rename commands, > rather than just renaming files. I found it a bit annoying that svn didn't > know the music files (in the test run) were just renamed and it downloaded > fresh copies when I did an update. This was probably a worst case scenario, > but even for text files it would still be nicer to avoid having to redownload > files that have only (or mostly) just had name changes. upconvert doesn't actually do any fike renames. I did those myself using svn mv, If svn rename really has better semantics (something I had no idea about) I'll do that in the future. -- http://www.catb.org/~esr/";>Eric S. Raymond ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] Feedback on automated name changing process
On Sun, Apr 22, 2007 at 20:51:33 -0400, "Eric S. Raymond" <[EMAIL PROTECTED]> wrote: > Bruno Wolff III <[EMAIL PROTECTED]>: > > Would it be possible to have the update script issue svn rename commands, > > rather than just renaming files. I found it a bit annoying that svn didn't > > know the music files (in the test run) were just renamed and it downloaded > > fresh copies when I did an update. This was probably a worst case scenario, > > but even for text files it would still be nicer to avoid having to > > redownload > > files that have only (or mostly) just had name changes. > > upconvert doesn't actually do any fike renames. I did those myself using > svn mv, If svn rename really has better semantics (something I had no idea > about) I'll do that in the future. To the best of my understanding svn mv and svn rename are aliases for each other. So it should have worked. My checkout should have been less than a week out of date, so I wouldn't have expected a big change that would have required redownloading the files. Maybe it is a deficiancy in subversion. I am also running svn 1.3.2, which isn't the latest version. But I would have expect it to do this right. So it sounds like you did try to do things right, the command isn't really part of upconvert in any case, and something went wrong for me. (I don't know if anyone else saw the same thing when they updated.) So there isn't anything to change. ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] Feedback on automated name changing process
Selon Bruno Wolff III <[EMAIL PROTECTED]>: > On Sun, Apr 22, 2007 at 20:51:33 -0400, > "Eric S. Raymond" <[EMAIL PROTECTED]> wrote: > > Bruno Wolff III <[EMAIL PROTECTED]>: > > > Would it be possible to have the update script issue svn rename commands, > > > rather than just renaming files. I found it a bit annoying that svn > didn't > > > know the music files (in the test run) were just renamed and it > downloaded > > > fresh copies when I did an update. This was probably a worst case > scenario, > > > but even for text files it would still be nicer to avoid having to > redownload > > > files that have only (or mostly) just had name changes. > > > > upconvert doesn't actually do any fike renames. I did those myself using > > svn mv, If svn rename really has better semantics (something I had no idea > > about) I'll do that in the future. > > To the best of my understanding svn mv and svn rename are aliases for each > other. So it should have worked. My checkout should have been less than a > week > out of date, so I wouldn't have expected a big change that would have > required redownloading the files. Maybe it is a deficiancy in subversion. > I am also running svn 1.3.2, which isn't the latest version. But I would > have expect it to do this right. > > So it sounds like you did try to do things right, the command isn't really > part > of upconvert in any case, and something went wrong for me. (I don't know > if anyone else saw the same thing when they updated.) So there isn't anything > to change. > AFAIK it wasn't just a rename, the files were modifed too (the metadata of the ogg files was updated). ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] Feedback on automated name changing process
Benoit Timbert <[EMAIL PROTECTED]>: > AFAIK it wasn't just a rename, the files were modifed too (the > metadata of the ogg files was updated). That's true, but it was a separate change from the rename. Timothy Pinkham supplied titles for gameplay-01.ogg and gameplay-02.ogg, and I changed the title tag to reflect this. I asked Timothy for titles because I'm thinking about implementing some way for players to see the title and author of the currently running track -- perhaps in a popup window, perhaps as a display field in the sound options dialogue. -- http://www.catb.org/~esr/";>Eric S. Raymond ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] Feedback on automated name changing process
On Mon, Apr 23, 2007 at 06:10:17 -0400, "Eric S. Raymond" <[EMAIL PROTECTED]> wrote: > Benoit Timbert <[EMAIL PROTECTED]>: > > AFAIK it wasn't just a rename, the files were modifed too (the > > metadata of the ogg files was updated). > > That's true, but it was a separate change from the rename. Timothy > Pinkham supplied titles for gameplay-01.ogg and gameplay-02.ogg, and > I changed the title tag to reflect this. > > I asked Timothy for titles because I'm thinking about implementing > some way for players to see the title and author of the currently > running track -- perhaps in a popup window, perhaps as a display field in > the sound options dialogue. It's possible that I got both of these changes in one update. I have seen binary files get updates instead of full replacements, but I don't know how smart the code is about matching the old and new versions of binary files. ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] Feedback on automated name changing process
On Mon, Apr 23, 2007 at 09:09:40AM -0500, Bruno Wolff III wrote: > On Mon, Apr 23, 2007 at 06:10:17 -0400, > "Eric S. Raymond" <[EMAIL PROTECTED]> wrote: > > Benoit Timbert <[EMAIL PROTECTED]>: > > > AFAIK it wasn't just a rename, the files were modifed too (the > > > metadata of the ogg files was updated). > > > > That's true, but it was a separate change from the rename. Timothy > > Pinkham supplied titles for gameplay-01.ogg and gameplay-02.ogg, and > > I changed the title tag to reflect this. > > > > I asked Timothy for titles because I'm thinking about implementing > > some way for players to see the title and author of the currently > > running track -- perhaps in a popup window, perhaps as a display field in > > the sound options dialogue. > > It's possible that I got both of these changes in one update. I have seen > binary files get updates instead of full replacements, but I don't know how > smart the code is about matching the old and new versions of binary files. svn move doesn't really move http://svnbook.red-bean.com/nightly/en/svn.ref.svn.c.move.html Regards, Mark de Wever aka Mordante/SkeletonCrew ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] Feedback on automated name changing process
On Mon, Apr 23, 2007 at 17:34:37 +0200, Mark de Wever <[EMAIL PROTECTED]> wrote: > > svn move doesn't really move > http://svnbook.red-bean.com/nightly/en/svn.ref.svn.c.move.html But it does do a copy to the new location before doing the delete. That should it to use the previous file name when doing an update. In my case the file may have changed in a way where svn did not think it could reuse most of the file and hence it ended up transfering full copies of the files. ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] Feedback on automated name changing process
Bruno Wolff III <[EMAIL PROTECTED]>: > It's possible that I got both of these changes in one update. I have seen > binary files get updates instead of full replacements, but I don't know how > smart the code is about matching the old and new versions of binary files. I just got a title from Zhaytee for wesnoth-1.ogg; he suggests we call it "Revelation". It will be interesting to see what the update pattern is when I make that change. -- http://www.catb.org/~esr/";>Eric S. Raymond ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] Feedback on automated name changing process
On Mon, Apr 23, 2007 at 14:42:16 -0400, "Eric S. Raymond" <[EMAIL PROTECTED]> wrote: > Bruno Wolff III <[EMAIL PROTECTED]>: > > It's possible that I got both of these changes in one update. I have seen > > binary files get updates instead of full replacements, but I don't know how > > smart the code is about matching the old and new versions of binary files. > > I just got a title from Zhaytee for wesnoth-1.ogg; he suggests we call it > "Revelation". It will be interesting to see what the update pattern is > when I make that change. I'll watch for the commit message and update to the rev before and then update to that specific rev and report back what happened. I should be able to try this tonight. ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] Feedback on automated name changing process
On Mon, Apr 23, 2007 at 15:14:16 -0500, Bruno Wolff III <[EMAIL PROTECTED]> wrote: > On Mon, Apr 23, 2007 at 14:42:16 -0400, > "Eric S. Raymond" <[EMAIL PROTECTED]> wrote: > > Bruno Wolff III <[EMAIL PROTECTED]>: > > > It's possible that I got both of these changes in one update. I have seen > > > binary files get updates instead of full replacements, but I don't know > > > how > > > smart the code is about matching the old and new versions of binary files. > > > > I just got a title from Zhaytee for wesnoth-1.ogg; he suggests we call it > > "Revelation". It will be interesting to see what the update pattern is > > when I make that change. > > I'll watch for the commit message and update to the rev before and then > update to that specific rev and report back what happened. > I should be able to try this tonight. Going from 17007 to 17008 was a quick update to wesnoth-1.ogg. Going from 17008 to 17009 involved downloading a fresh copy of wesnoth-1.ogg under its new name. So this problem appears to be dumbness on the part of svn. ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] Feedback on automated name changing process
On Mon, Apr 23, 2007 at 21:57:56 -0500, Bruno Wolff III <[EMAIL PROTECTED]> wrote: > > Going from 17007 to 17008 was a quick update to wesnoth-1.ogg. Going from > 17008 to 17009 involved downloading a fresh copy of wesnoth-1.ogg under > its new name. So this problem appears to be dumbness on the part of svn. I didn't see the efficiency of rename listed as an issue by the svn project. The closest issue is making rename a real function rather than D+A. Just to make sure I am going to join their users list and try to get the issue on their tracking system. ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] Feedback on automated name changing process
On Mon, Apr 23, 2007 at 10:30:04PM -0500, Bruno Wolff III wrote: > On Mon, Apr 23, 2007 at 21:57:56 -0500, > Bruno Wolff III <[EMAIL PROTECTED]> wrote: > > Going from 17007 to 17008 was a quick update to wesnoth-1.ogg. Going from > > 17008 to 17009 involved downloading a fresh copy of wesnoth-1.ogg under > > its new name. So this problem appears to be dumbness on the part of svn. > > I didn't see the efficiency of rename listed as an issue by the svn project. > The closest issue is making rename a real function rather than D+A. > Just to make sure I am going to join their users list and try to get the > issue on their tracking system. If I understand correctly you are complaining that after a rename and a minor change to the renamed file users having an older copy of the working copy need to fetch the full file instead of only the delta relative to the old file, right? According to http://svn.collab.net/repos/svn/trunk/CHANGES: Version 1.4.2 dramatically speed up commit of wc-to-wc copy (r21471) Version 1.4.0 also contains "numerous working copy improvements" by using a new data file format in .svn/ (no XML any more) and using an improved delta algorithm. I strongly suggest to test the new version. (It fixed also at least one major problem I reported :-) Jens ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] Feedback on automated name changing process
On Tue, Apr 24, 2007 at 09:45:06 +0200, Jens Seidel <[EMAIL PROTECTED]> wrote: > > If I understand correctly you are complaining that after a rename and a > minor change to the renamed file users having an older copy of the > working copy need to fetch the full file instead of only the delta > relative to the old file, right? Yes, though my latest test suggests that even after a rename without a minor change this also is a problem. > According to http://svn.collab.net/repos/svn/trunk/CHANGES: > Version 1.4.2 > dramatically speed up commit of wc-to-wc copy (r21471) > > Version 1.4.0 also contains "numerous working copy improvements" by > using a new data file format in .svn/ (no XML any more) and using an > improved delta algorithm. > > I strongly suggest to test the new version. (It fixed also at least one > major problem I reported :-) I'll take a look at this. I am running the version that comes with Fedora Core 5 right now, which appears to be a pre 1.4 development version. Fedora 7 has 1.4.3 and I'll be switching to that at home soon. In the meantime I can look at building a copy from source, but your comment about meta data format changes suggests there may be some pain in that. ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] Feedback on automated name changing process
Bruno Wolff III <[EMAIL PROTECTED]>: > Going from 17007 to 17008 was a quick update to wesnoth-1.ogg. Going from > 17008 to 17009 involved downloading a fresh copy of wesnoth-1.ogg under > its new name. So this problem appears to be dumbness on the part of svn. That's the result I was expecting, and agreed. -- http://www.catb.org/~esr/";>Eric S. Raymond ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
Re: [Wesnoth-dev] Feedback on automated name changing process
On Tue, Apr 24, 2007 at 21:59:12 -0400, "Eric S. Raymond" <[EMAIL PROTECTED]> wrote: > Bruno Wolff III <[EMAIL PROTECTED]>: > > Going from 17007 to 17008 was a quick update to wesnoth-1.ogg. Going from > > 17008 to 17009 involved downloading a fresh copy of wesnoth-1.ogg under > > its new name. So this problem appears to be dumbness on the part of svn. > > That's the result I was expecting, and agreed. In case people are curious, this is now entered in subversion's issue tracker. At least one person there thinks it would be a good thing to do so it might get changed at some point before they do their real rename fix. See: http://subversion.tigris.org/issues/show_bug.cgi?id=2773 ___ Wesnoth-dev mailing list Wesnoth-dev@gna.org https://mail.gna.org/listinfo/wesnoth-dev
