[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

[Daimona]

Daimona added a comment.


  In T353961#9595560 <https://phabricator.wikimedia.org/T353961#9595560>, 
@Lucas_Werkmeister_WMDE wrote:
  
  > Which is a bit of a shame, because @Daimona removed a bunch of inter-table 
dependencies like this when introducing ChangedTablesTracker 
<https://gerrit.wikimedia.org/r/c/mediawiki/core/+/946538> (it used to be 
something like “if `slot_roles` is cleared then also clear `ip_changes`”, 
yuck), and now we’d be reintroducing something similar again and go behind 
`ChangedTablesTracker`’s back, so to speak :/ but I can’t really think of a 
better solution. Any thoughts?
  
  Yeah, it's not ideal :( Unfortunately, while the `addDBDataOnce` idea was 
noble and it definitely helped a lot making the suites faster, I believe its 
implementation wasn't planned very carefully. For once, the method might have 
been made static. That does mean not being able to access non-static properties 
in it, but it would've allowed us to run it as part of the `beforeClass` hook. 
This was already clear 
<https://gerrit.wikimedia.org/g/mediawiki/core/+/56e704e617faac8a3b2819ae44e61a0019104bc4/tests/phpunit/MediaWikiIntegrationTestCase.php#683>
 when addDBDataOnce was being introduced, but nobody noticed that making the 
method non-static actually made that harder. Then there's the problem of 
leaving the database in a consistent state. Any "once before class" method 
needs to be paired with an "once after class" counterpart; this wasn't done for 
addDBDataOnce. Everyone just relied on `tablesUsed` to truncate tables 
(assuming you wouldn't forget about it altogether), and the combination of 
addDBDataOnce + tablesUsed was also never considered carefully enough. All in 
all, `$dbDataOnceTables` is itself a hack; one that comes directly from the 
flaws of the previous `addDBDataOnce` implementation.
  
  Sadly, all I had for you is the rant above and not an actual solution :/ 
Ideally, I think addDBDataOnce should be treated as a "seeding" method. You use 
it to define the initial state of the database for the test class, and the 
database is brought back to that state after every test. I'm just not sure how 
to do that, particularly considering the performance requirements. It would be 
a larger change. As long as it's just one test that needs the behaviour to 
change, can we maybe try fixing it in place? I know it's not ideal, but I worry 
that changing the code in MWIntegrationTestCase may introduce more edge cases 
and unwanted effects that people may rely on. What about adding something like 
the following to your addDBDataOnce method?
  
$dbw->insert( 'user_autocreate_serial', /* random row */ );
$dbw->truncateTable( 'user_autocreate_serial' );
  
  This should add the table to `$dbDataOnceTables` and hopefully fix your 
issue. It's ugly, I know... But I'd rather not change this in core unless 
absolutely necessary...

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Daimona
Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353957: Wikibase secondary CI is broken and email sending is broken again (Dec 2023)

[Daimona]

Daimona added a comment.


  In T353957#9424131 <https://phabricator.wikimedia.org/T353957#9424131>, 
@Daimona wrote:
  
  > H I don't quite understand why PHPUnit is printing the usage and then 
aborting. It's definitely not the first time I'm seeing this, but I can't 
remember what the cause is.
  
  Maybe it can't find a config file? That would be weird though, as it should 
use the phpunit.xml.dist in MW core by default.

TASK DETAIL
  https://phabricator.wikimedia.org/T353957

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Lucas_Werkmeister_WMDE, Aklapper, Daimona, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353957: Wikibase secondary CI is broken and email sending is broken again (Dec 2023)

[Daimona]

Daimona added a comment.


  H I don't quite understand why PHPUnit is printing the usage and then 
aborting. It's definitely not the first time I'm seeing this, but I can't 
remember what the cause is.

TASK DETAIL
  https://phabricator.wikimedia.org/T353957

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Lucas_Werkmeister_WMDE, Aklapper, Daimona, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T351709: Wikibase CI broken since $tablesUsed replaced with automatic query tracking

[Daimona]

Daimona added a comment.


  In T351709#9348821 <https://phabricator.wikimedia.org/T351709#9348821>, 
@Lucas_Werkmeister_WMDE wrote:
  
  > Apparently both affected tests have this pattern: [...]
  
  Indeed, that pattern had already caused some test failures before. I thought 
I had fixed all of them before putting my change up for review, but apparently 
some of them went unnoticed.

TASK DETAIL
  https://phabricator.wikimedia.org/T351709

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Daimona
Cc: Michael, tstarling, Daimona, Lucas_Werkmeister_WMDE, Aklapper, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Eihel, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, Esc3300, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Agabi10, Neuronton, Scott_WUaS, abian, Wikidata-bugs, aude, Sjoerddebruin, 
Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328497: Remove unnecessary targets definitions

[Daimona]

Daimona removed a project: CampaignEvents.

TASK DETAIL
  https://phabricator.wikimedia.org/T328497

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: KSiebert, StudiesWorld, Jdforrester-WMF, Aklapper, Krinkle, Catrope, 
Legoktm, TrevorParscal, ori, Ricordisamoa, Krenair, gerritbot, Florian, brion, 
Nikerabbit, Tgr, pmiazga, Ciencia_Al_Poder, Tacsipacsi, Ltrlg, 
AntiCompositeNumber, kostajh, Universal_Omega, Michael, alistair3149, 
Jdlrobson, rpakzad, Danny_Benjafield_WMDE, Uata1122, fbalicchia, 
Isabelladantes1983, Themindcoder, Mohamed-Awnallah, isarantopoulos, KLawal-WMF, 
Adamm71, PMenon-WMF, gonzalez.actor, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, Gethan, STH, 786, Sgs, fenpedia, lbowmaker, BTullis, Biggs657, 
karapayneWMDE, toberto, Simonmaignan, Invadibot, LaMagiaaa, DesignerThan, Func, 
Zabe, Ywats0ns, H0bby, Asartea, Bebiezaza, maantietaja, Parlautan, calbon, 
Wilmanbeno, GhostInTheMachine, Juan90264, Zblace, Anerka, Alter-paule, 
Beast1978, CBogen, ItamarWMDE, Un1tY, Nintendofan885, Akuckartz, Soda, Demian, 
apaskulin, Dzaky17, Hook696, CptViraj, darthmon_wmde, Hakimi97, Eihel, Jtneill, 
abi_, taavi, MJL, Kent7301, Chambersjay, FriedrickMILBarbarossa, joker88john, 
Dinadineke, DannyS712, wildly_boy, CucyNoiD, Nandana, Chief_Mike, Klaas_Z4us_V, 
Matlin, Tumz24, Gaboe420, Urfiner, Jony, lucamauri, Patriccck, 
CycloneIsaac, Giuliamocci, tabish.shaikh91, Cpaulf30, Lahi, Gq86, Af420, 
Xinbenlv, Vacio, Ramsey-WMF, SapphieWillie, Bsandipan, tsca, Xover, 
Lucas_Werkmeister_WMDE, Gboyers, GoranSMilovanovic, Fz-29, Chicocvenancio, 
JakeTheDeveloper, Mahir256, QZanden, cmadeo, srishakatux, Viveksr96, Esc3300, 
merbst, LawExplorer, spatton, RIT_RAJARSHI, Flycatchr, Samuele2002, Lewizho99, 
Lemondoge, Maathavan, elukey, Assassas77, _jensen, Jseddon, rosalieper, 
Agabi10, Bodhisattwa, Mkdw, XanonymusX, Taiwania_Justo, Neuronton, shinjiman, 
gabriel-wmde, Scott_WUaS, mb, Cirdan, Samwilson, DStrine, Volker_E, XenoRyet, 
Izno, SBisson, Wong128hk, Luke081515, freephile, Unapersona, IKhitron, abian, 
Zache, Hsarrazin, Wikidata-bugs, Snowolf, Base, aude, AndyRussG, Ebe123, 
Pcoombe, Dinoguy1000, Amire80, jeblad, jayvdb, Mvolz, RandomDSdevel, Shizhao, 
fbstj, Paladox, Arrbee, santhosh, KartikMistry, Isarra, Alchimista, 
Billinghurst, TheDJ, Ladsgroup, Jackmcbarn, Mbch331, jayantanth, Jay8g, ashley, 
jeremyb, vyuen
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328497: Remove unnecessary targets definitions

[Daimona]

Daimona added a subtask: T351001: Remove unnecessary ResourceLoader targets 
definitions from CampaignEvents.

TASK DETAIL
  https://phabricator.wikimedia.org/T328497

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: KSiebert, StudiesWorld, Jdforrester-WMF, Aklapper, Krinkle, Catrope, 
Legoktm, TrevorParscal, ori, Ricordisamoa, Krenair, gerritbot, Florian, brion, 
Nikerabbit, Tgr, pmiazga, Ciencia_Al_Poder, Tacsipacsi, Ltrlg, 
AntiCompositeNumber, kostajh, Universal_Omega, Michael, alistair3149, 
Jdlrobson, rpakzad, Danny_Benjafield_WMDE, Uata1122, fbalicchia, 
Isabelladantes1983, Themindcoder, Mohamed-Awnallah, isarantopoulos, KLawal-WMF, 
Adamm71, PMenon-WMF, gonzalez.actor, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, vyuen, Gethan, STH, 786, Sgs, fenpedia, lbowmaker, BTullis, 
Biggs657, karapayneWMDE, toberto, Simonmaignan, Invadibot, LaMagiaaa, 
DesignerThan, Func, Zabe, Ywats0ns, H0bby, Asartea, Bebiezaza, maantietaja, 
Parlautan, calbon, Wilmanbeno, GhostInTheMachine, Juan90264, Zblace, Anerka, 
Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, Nintendofan885, Akuckartz, 
Soda, Demian, apaskulin, Dzaky17, Hook696, CptViraj, darthmon_wmde, Hakimi97, 
Eihel, Jtneill, abi_, taavi, MJL, Kent7301, Chambersjay, 
FriedrickMILBarbarossa, joker88john, Dinadineke, DannyS712, wildly_boy, 
CucyNoiD, Nandana, Chief_Mike, Klaas_Z4us_V, Matlin, Tumz24, Gaboe420, 
Urfiner, Jony, lucamauri, Patriccck, CycloneIsaac, Giuliamocci, 
tabish.shaikh91, Cpaulf30, Lahi, Gq86, Af420, Xinbenlv, Vacio, Ramsey-WMF, 
SapphieWillie, Bsandipan, Daimona, tsca, Xover, Lucas_Werkmeister_WMDE, 
Gboyers, GoranSMilovanovic, Fz-29, Chicocvenancio, JakeTheDeveloper, Mahir256, 
QZanden, cmadeo, srishakatux, Viveksr96, Esc3300, merbst, LawExplorer, spatton, 
RIT_RAJARSHI, Flycatchr, Samuele2002, Lewizho99, Lemondoge, Maathavan, elukey, 
Assassas77, _jensen, Jseddon, rosalieper, Agabi10, Bodhisattwa, Mkdw, 
XanonymusX, Taiwania_Justo, Neuronton, shinjiman, gabriel-wmde, Scott_WUaS, mb, 
Cirdan, Samwilson, DStrine, Volker_E, XenoRyet, Izno, SBisson, Wong128hk, 
Luke081515, freephile, Unapersona, IKhitron, abian, Zache, Hsarrazin, 
Wikidata-bugs, Snowolf, Base, aude, AndyRussG, Ebe123, Pcoombe, Dinoguy1000, 
Amire80, jeblad, jayvdb, Mvolz, RandomDSdevel, Shizhao, fbstj, Paladox, Arrbee, 
santhosh, KartikMistry, Isarra, Alchimista, Billinghurst, TheDJ, Ladsgroup, 
Jackmcbarn, Mbch331, jayantanth, Jay8g, ashley, jeremyb
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340201: Use custom language code to find i18n XSS issues

[Daimona]

Daimona added a comment.


  In T340201#9211976 <https://phabricator.wikimedia.org/T340201#9211976>, 
@Bawolff wrote:
  
  > - mustache templates
  
  Yup, that would be T199397 <https://phabricator.wikimedia.org/T199397>. I'm 
not sure how feasible that would be.
  
  > Maybe we should think about how to either refactor these code patterns so 
we can use phan-taint-check on them, or think of ways of making phan taint 
check better.
  
  +1, always happy to hear suggestions on how to make taint-check more useful.

TASK DETAIL
  https://phabricator.wikimedia.org/T340201

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Daimona
Cc: Bawolff, Daimona, Nikerabbit, Jdforrester-WMF, Fomafix, Lydia_Pintscher, 
sbassett, jhsoby, kostajh, matmarex, bd808, Michael, Aklapper, 
Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Cleo_Lemoisson, Astuthiodit_1, 
karapayneWMDE, Invadibot, Dylsss, Devnull, maantietaja, ItamarWMDE, Akuckartz, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Luke081515, Wikidata-bugs, aude, 
Grunny, csteipp, Mbch331, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277464: [EPIC] Multiple Wikibase service wiring tests fail when run as unit tests

[Daimona]

Daimona removed a parent task: T90875: Use vendor/bin/phpunit instead of 
tests/phpunit/phpunit.php.

TASK DETAIL
  https://phabricator.wikimedia.org/T277464

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: ItamarWMDE, Michael, kostajh, WMDE-leszek, Aklapper, 
Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T345372: Wikibase CI broken: RuntimeException: Database backend disabled

[Daimona]

Daimona closed this task as "Resolved".
Daimona assigned this task to Lucas_Werkmeister_WMDE.
Daimona added a comment.


  All patches merged, Wikibase CI is green, resolving this.

TASK DETAIL
  https://phabricator.wikimedia.org/T345372

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Daimona
Cc: Daimona, Urbanecm_WMF, Michael, Dreamy_Jazz, Lucas_Werkmeister_WMDE, 
Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T248088: Make PHPUnit tests fail on warnings

[Daimona]

Daimona closed this task as "Resolved".
Daimona assigned this task to Umherirrender.
Daimona added a comment.


  This was resolved in r586067 
<https://gerrit.wikimedia.org/r/c/mediawiki/core/+/586067> 3 years ago.

TASK DETAIL
  https://phabricator.wikimedia.org/T248088

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Umherirrender, Daimona
Cc: Daimona, WMDE-leszek, Aklapper, MaxSem, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
darthmon_wmde, Nandana, kostajh, lucamauri, Lahi, Gq86, mojoaxel, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, 
Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

[Daimona]

Daimona added a subtask: T142120: Remove UnitTestsList hook subscribers, move 
tests to be autodiscovered for extensions that have been converted to extension 
registration.

TASK DETAIL
  https://phabricator.wikimedia.org/T298509

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Krinkle, cscott, kostajh, Jdforrester-WMF, Aklapper, 
Danny_Benjafield_WMDE, fbalicchia, Astuthiodit_1, SLopes-WMF, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, DAlangi_WMF, Akuckartz, darthmon_wmde, 
WDoranWMF, EvanProdromou, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, 
XenoRyet, Izno, Jrf, Wikidata-bugs, aude, Dinoguy1000, ssastry, Arlolra, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T342418: Speed up Language creation

[Daimona]

Daimona added a comment.


  Just came here to say that I tried running LanguageConverterFactoryTest 
(which is super slow, see T50217#9030084 
<https://phabricator.wikimedia.org/T50217#9030084>) before and after the 
changes in this ticket. It went from 12-13 seconds to 1 second, which is 
AMAZING! Thank you!

TASK DETAIL
  https://phabricator.wikimedia.org/T342418

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Daimona
Cc: matmarex, Winston_Sung, Nikerabbit, Daimona, Michael, tstarling, 
Lucas_Werkmeister_WMDE, Aklapper, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
MaryMunyoki, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, srishakatux, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Arrbee, KartikMistry, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

[Daimona]

Daimona added a comment.


  Note that the presence of this hook makes it quite difficult to have a 
standard PHPUnit setup (T227900 <https://phabricator.wikimedia.org/T227900>, 
T90875 <https://phabricator.wikimedia.org/T90875>), because we need to fully 
initialize MediaWiki in order to run the hook. For now I'm going to implement a 
workaround, but I'd really like to see this hook go away.

TASK DETAIL
  https://phabricator.wikimedia.org/T298509

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Krinkle, cscott, kostajh, Jdforrester-WMF, Aklapper, fbalicchia, 
Astuthiodit_1, SLopes-WMF, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
DAlangi_WMF, Akuckartz, darthmon_wmde, WDoranWMF, EvanProdromou, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, XenoRyet, Izno, Jrf, Wikidata-bugs, 
aude, Dinoguy1000, ssastry, Arlolra, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

[Daimona]

Daimona removed parent tasks: T227900: Phase out usage of 
tests/phpunit/suite.xml, T90875: Use vendor/bin/phpunit instead of 
tests/phpunit/phpunit.php.

TASK DETAIL
  https://phabricator.wikimedia.org/T298509

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Krinkle, cscott, kostajh, Jdforrester-WMF, Aklapper, fbalicchia, 
Astuthiodit_1, SLopes-WMF, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
DAlangi_WMF, Akuckartz, darthmon_wmde, WDoranWMF, EvanProdromou, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, XenoRyet, Izno, Jrf, Wikidata-bugs, 
aude, Dinoguy1000, ssastry, Arlolra, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

[Daimona]

Daimona added a parent task: T227900: Phase out usage of 
tests/phpunit/suite.xml.

TASK DETAIL
  https://phabricator.wikimedia.org/T298509

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Krinkle, cscott, kostajh, Jdforrester-WMF, Aklapper, fbalicchia, 
Astuthiodit_1, SLopes-WMF, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
DAlangi_WMF, Akuckartz, darthmon_wmde, WDoranWMF, EvanProdromou, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, XenoRyet, Izno, Jrf, Wikidata-bugs, 
aude, Dinoguy1000, ssastry, Arlolra, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340928: UsageTrackingIntegrationTest::testUpdateUsage fails locally, and in CI when not using phpunit.php

[Daimona]

Daimona closed this task as "Resolved".
Daimona added a comment.


  Local failure is resolved, hence closing this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T340928

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Lucas_Werkmeister_WMDE, Aklapper, Daimona, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340928: UsageTrackingIntegrationTest::testUpdateUsage fails locally, and in CI when not using phpunit.php

[Daimona]

Daimona added a comment.


  In T340928#8987551 <https://phabricator.wikimedia.org/T340928#8987551>, 
@Lucas_Werkmeister_WMDE wrote:
  
  > In T340928#8984321 <https://phabricator.wikimedia.org/T340928#8984321>, 
@Daimona wrote:
  >
  >> Right, I didn't realize that since Wikibase doesn't have a single 
extension.json file, LocalSettingsGenerator will use the old style 
`require_once`, which includes `Wikibase.php`, which provides some overrides 
for CI.
  >>
  >> I'm going to skip the test if the needed setting isn't enabled, and this 
will fix this task.
  >
  > I uploaded an alternative way to improve the test, but I disagree that this 
fixes the task. It sounds like the issue here is that your changes cause our 
CI-only settings to not be loaded in CI. That’s a problem even if all the 
remaining tests are green.
  
  Yeah, sorry for the confusion. What I meant is that the patch above will fix 
the test failure when the setting's not enabled, which is what I was getting on 
my local. The config fix for switching to composer PHPUnit is r935034 
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/935034>, 
which ensures that the test will be executed after the switch. That's in scope 
for T90875 <https://phabricator.wikimedia.org/T90875> though, not this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T340928

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Lucas_Werkmeister_WMDE, Aklapper, Daimona, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340928: UsageTrackingIntegrationTest::testUpdateUsage fails locally, and in CI when not using phpunit.php

[Daimona]

Daimona claimed this task.
Daimona added a comment.


  Right, I didn't realize that since Wikibase doesn't have a single 
extension.json file, LocalSettingsGenerator will use the old style 
`require_once`, which includes `Wikibase.php`, which provides some overrides 
for CI.
  
  I'm going to skip the test if the needed setting isn't enabled, and this will 
fix this task.
  
  I'll leave it up to the maintainers whether the documentation (mw.org, 
readmes, something else) should mention that the config set by Wikibase.php 
might be useful for local development.

TASK DETAIL
  https://phabricator.wikimedia.org/T340928

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Aklapper, Daimona, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340928: UsageTrackingIntegrationTest::testUpdateUsage fails locally, and in CI when not using phpunit.php

[Daimona]

Daimona added a comment.


  Looks like this has to do with the special config 
<https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/7c169d33929171fbe2e2460df56c1a0bf95cb2d5/build>
 that is injected in Wikimedia CI.
  
  The issue disappears locally if I add 
`$wgWBClientSettings['allowDataAccessInUserLanguage'] = true;` to my 
LocalSettings.php.
  
  Also, the test run without phpunit.php shows that a few tests are skipped, 
apparently because they need `$wgWBClientSettings['dataBridgeEnabled'] = true;`.
  
  Locally, as well as in CI when not using phpunit.php, those settings have the 
default value of false, which causes the skips and failures. Now looking into a 
solution.

TASK DETAIL
  https://phabricator.wikimedia.org/T340928

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Aklapper, Daimona, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340928: UsageTrackingIntegrationTest::testUpdateUsage fails locally, and in CI when not using phpunit.php

[Daimona]

Daimona added a comment.


  Also, note that this test is not failing in CI with MW master. That's why I'm 
suggesting it may have to do with config, where it would fail locally because I 
have a different config than CI, and it would also fail in CI when not using 
phpunit.php because the config bootstrapping is different. I still wasn't able 
to find the cause for the failure though, mostly because I know absolutely 
nothing about whatever the test is doing.

TASK DETAIL
  https://phabricator.wikimedia.org/T340928

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Aklapper, Daimona, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340928: UsageTrackingIntegrationTest::testUpdateUsage fails locally, and in CI when not using phpunit.php

[Daimona]

Daimona created this task.
Daimona added projects: Wikidata, MediaWiki-extensions-WikibaseClient.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  In r934707 <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/934707> I'm 
trying to get rid of tests/phpunit/phpunit.php. All tests are passing, except 
for UsageTrackingIntegrationTest::testUpdateUsage. I can reproduce this 
locally; in fact, the test is failing locally even when using the master 
version of Wikibase and core. I think the test might be implicitly making some 
assumptions on the configuration that are not always true, or something like 
that, though I still haven't pinpointed the cause of the failure.

TASK DETAIL
  https://phabricator.wikimedia.org/T340928

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Aklapper, Daimona, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

[Daimona]

Daimona added a comment.


  In T65632#8945234 <https://phabricator.wikimedia.org/T65632#8945234>, 
@matej_suchanek wrote:
  
  > I suspect MediawikiEditFilterHookRunner::getContextForEditFilter 
<https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/41b35ffd4b9d060916c950cb3ad6600e516a0f72/repo/includes/EditEntity/MediawikiEditFilterHookRunner.php#120>
 does not carry over the "original" WikiPage instance (used as the "carrier" of 
the PreparedUpdate).
  
  This seems correct: instantiating a DerivativeContext does not set the 
`wikipage` field, which is lazy-loaded in `getWikipage()`, and created from 
scratch if a Title is available. I'd be a bit scared changing this in any way 
though (e.g., persisting the WikiPage object), because of the potential side 
effects it could have. OTOH, I don't think there's a task for adding 
PreparedUpdate to the hook parameters. Should we just do that instead? I think 
that would mean creating a new hook; it might be a good occasion to address 
some of the issues reported in T304238 
<https://phabricator.wikimedia.org/T304238>.

TASK DETAIL
  https://phabricator.wikimedia.org/T65632

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Ladsgroup, Daimona, matej_suchanek, Lydia_Pintscher, daniel, hoo, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
94rain, Dinadineke, Nandana, lucamauri, tabish.shaikh91, Lahi, Gq86, 
GoranSMilovanovic, ihojose, JakeTheDeveloper, QZanden, merbst, LawExplorer, 
Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, 
Wikidata-bugs, aude, Nullzero, Huji, Billinghurst, TheDJ, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329705: Create Wikidata property for Event pages

[Daimona]

Daimona edited projects, added Wikidata; removed CampaignEvents.
Daimona added a comment.


  Removing #campaignevents 
<https://phabricator.wikimedia.org/tag/campaignevents/> as this is not about 
the codebase of the extension, adding #wikidata 
<https://phabricator.wikimedia.org/tag/wikidata/> instead.

TASK DETAIL
  https://phabricator.wikimedia.org/T329705

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Bachounda, Astuthiodit_1, vyuen, IBrazal, VPuffetMichel, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
SBisson, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T293346: Identify edits via Wikidata User Interface in AbuseFilter rules

[Daimona]

Daimona added a comment.


  In T293346#8068839 <https://phabricator.wikimedia.org/T293346#8068839>, 
@Lydia_Pintscher wrote:
  
  > Is this possible now that we are tagging all UI edits? I don't know if 
abuse filter has access to that.
  
  No, unfortunately. AF uses the EditFilterMergedContent hook, which is run 
before change tags are applied.

TASK DETAIL
  https://phabricator.wikimedia.org/T293346

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Lydia_Pintscher, Streetmathematician, Aklapper, Bugreporter, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
94rain, Nandana, Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, LawExplorer, 
Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, 
Wikidata-bugs, aude, Nullzero, Huji, Billinghurst, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306789: AbuseFilter messages contain local hrefs even for links formed with interwiki prefix

[Daimona]

Daimona added a comment.


  I'm not familiar with wikidata, so I'm not sure what's really happening here. 
However, this does not seem to be caused by AbuseFilter itself: IIUC, a 
wikidata filter is being run on another wiki, but this is NOT happening via the 
AbuseFilter's own "global filters" feature. In fact, I think AF is being 
manually triggered by Wikibase (e.g. by running the EditFilterMergedContent 
hook). AF simply returns a Status object with the error messages, but it's up 
to the calling code to make sure that those messages are parsed correctly. As 
an aside, AF does not let you use a customized warning message for global 
filters, possibly because parsing it in the right context could be difficult.

TASK DETAIL
  https://phabricator.wikimedia.org/T306789

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, CX_Zoom, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Manuel, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, 94rain, Nandana, Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, 
LawExplorer, Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Nirmos, Wikidata-bugs, aude, Nullzero, Huji, Billinghurst, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move

[Daimona]

Daimona added a comment.


  In T308443#7933248 <https://phabricator.wikimedia.org/T308443#7933248>, 
@tstarling wrote:
  
  > - Patch phan. Wastes upstream's time with ancient PHP version issues, and 
probably incurs a rebase cost when reapplying the core patch, due to phan 
deployment delay.
  
  I think creating an issue upstream would make sense; I'm not sure what the 
PHP compat policy for phan is, but I'm not aware of any plans about dropping 
support for older PHP versions. I do agree that this would take a while though, 
because of the slow rollout of the new version.

TASK DETAIL
  https://phabricator.wikimedia.org/T308443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Ladsgroup, Reedy, ItamarWMDE, Michael, RhinosF1, Krinkle, 
tstarling, kostajh, Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, Sgs, 
karapayneWMDE, Invadibot, caldera, maantietaja, NavinRizwi, Akuckartz, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, 
LawExplorer, Iniquity, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, 
Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T300306: [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release

[Daimona]

Daimona closed subtask T304243: Replace (error|warning|success)box in test 
cases of AbuseFilter as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T300306

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Stang, Daimona, Krinkle, Edtadros, Volker_E, Esanders, Aklapper, 
Tacsipacsi, Nikerabbit, Iniquity, Johan, PeterBowman, Amorymeltzer, 
Jdforrester-WMF, ovasileva, Trizek-WMF, Izno, Patafisik, Jdlrobson, 
Fernandobacasegua34, Astuthiodit_1, 786, fenpedia, Suran38, Biggs657, 
karapayneWMDE, toberto, bwang, Invadibot, Feldpauschhaylee2017, LaMagiaaa, 
Lalamarie69, R4356th, Bebiezaza, maantietaja, Wilmanbeno, Juan90264, 
Alter-paule, Beast1978, CBogen, Un1tY, FelixE2019, Akuckartz, Hook696, 
darthmon_wmde, WDoranWMF, Kent7301, RhinosF1, EvanProdromou, joker88john, 
SD0001, DannyS712, CucyNoiD, Nandana, Chief_Mike, Tumz24, Gaboe420, Jony, 
CycloneIsaac, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Minilexikon, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, spatton, Samuele2002, 
Lewizho99, JJMC89, Maathavan, _jensen, Jseddon, rosalieper, Agabi10, Neuronton, 
gabriel-wmde, Scott_WUaS, mb, Pchelolo, DStrine, XenoRyet, Wong128hk, 
Luke081515, Nirmos, Unapersona, Wikidata-bugs, Base, aude, AndyRussG, Ebe123, 
Pcoombe, Dinoguy1000, jayvdb, RandomDSdevel, Lydia_Pintscher, Isarra, Addshore, 
Mbch331, Jay8g, Ltrlg, Krenair, jeremyb, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T300306: [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release

[Daimona]

Daimona added a comment.


  In T300306#7778299 <https://phabricator.wikimedia.org/T300306#7778299>, 
@Jdlrobson wrote:
  
  > @Daimona message boxes were designed intentionally to not have attributes. 
If an element is using custom attributes then there are 3 options:
  >
  > - Make the message box a child of an element which has those attributes
  > - Make the child have these attributes
  > - Replace the attributes with a class if possible
  
  Makes sense to me.
  
  > Is there an example of code which wouldn't work with any of those options?
  
  No idea, I guess we could try and apply these options to the remaining uses 
in core.
  
  I still think it may be a good idea to have the get...Classes() methods for 
code that is not easy to migrate. The documentation of those methods could 
state that usage is discouraged and that they will be removed in the future.

TASK DETAIL
  https://phabricator.wikimedia.org/T300306

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Krinkle, Edtadros, Volker_E, Esanders, Aklapper, Tacsipacsi, 
Nikerabbit, Iniquity, Johan, PeterBowman, Amorymeltzer, Jdforrester-WMF, 
ovasileva, Trizek-WMF, Izno, Patafisik, Jdlrobson, Fernandobacasegua34, 
Astuthiodit_1, 786, fenpedia, Suran38, Biggs657, karapayneWMDE, toberto, bwang, 
Invadibot, Feldpauschhaylee2017, LaMagiaaa, Lalamarie69, Zabe, Asartea, 
Florian_COLLIN, R4356th, Bebiezaza, maantietaja, Wilmanbeno, Juan90264, 
Alter-paule, Beast1978, CBogen, GeneralNotability, Un1tY, FelixE2019, 
Akuckartz, Dzaky17, Hook696, CptViraj, darthmon_wmde, ST47, WDoranWMF, Majavah, 
Kent7301, Chambersjay, RhinosF1, EvanProdromou, joker88john, SD0001, 94rain, 
DannyS712, wildly_boy, CucyNoiD, Nandana, Chief_Mike, Tks4Fish, Tumz24, 
Gaboe420, Jony, CycloneIsaac, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Minilexikon, Bsandipan, Gboyers, GoranSMilovanovic, ihojose, 
Mahir256, QZanden, LawExplorer, Litanwei, spatton, Samuele2002, Lewizho99, 
JJMC89, Maathavan, SundanceRaphael, _jensen, Jseddon, rosalieper, Agabi10, AGK, 
XanonymusX, Neuronton, RuyP, JEumerus, gabriel-wmde, Scott_WUaS, mb, Cirdan, 
Pchelolo, DStrine, XenoRyet, Wong128hk, Luke081515, Nirmos, Bsadowski1, 
mys_721tx, I_JethroBT, Unapersona, Zache, alex-mashin, Niharika, Wikidata-bugs, 
Snowolf, Base, aude, AndyRussG, Ebe123, Nullzero, Pcoombe, Huji, Dinoguy1000, 
jeblad, jayvdb, MrStradivarius, RandomDSdevel, fbstj, Lydia_Pintscher, Florian, 
KartikMistry, Isarra, Billinghurst, Ladsgroup, Addshore, Jackmcbarn, Mbch331, 
Jay8g, Ltrlg, Glaisher, Krenair, jeremyb, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T300306: [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release

[Daimona]

Daimona added a comment.


  My opinion is that these classes should not be removed until we provide 
proper replacements. The task description already provides many useful 
examples, but there seems to be at least one use case which is not covered, 
i.e. when you want a (success|error|warning)box with some additional custom 
attributes. Currently, any such use case would need to hardcode the new class 
names. I'm arguing that this is tech debt and we shouldn't that in new code 
(and replacing the old class name with the new one effectively makes it "new" 
IMO). My proposal is that we either add some parameters to the `Html::*Box` 
functions to allow this customization, or we introduce new methods like 
`Html::getErrorBoxClasses()`. I believe that either solution can be implemented 
reasonably quickly and would still allow the April deadline to be met without 
introducing more technical debt. Additional context is available in the 
comments of r768144 <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/768144>.

TASK DETAIL
  https://phabricator.wikimedia.org/T300306

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Krinkle, Edtadros, Volker_E, Esanders, Aklapper, Tacsipacsi, 
Nikerabbit, Iniquity, Johan, PeterBowman, Amorymeltzer, Jdforrester-WMF, 
ovasileva, Trizek-WMF, Izno, Patafisik, Jdlrobson, Fernandobacasegua34, 
Astuthiodit_1, 786, fenpedia, Suran38, Biggs657, karapayneWMDE, toberto, bwang, 
Invadibot, Feldpauschhaylee2017, LaMagiaaa, Lalamarie69, Zabe, Asartea, 
Florian_COLLIN, R4356th, Bebiezaza, maantietaja, Wilmanbeno, Juan90264, 
Alter-paule, Beast1978, CBogen, GeneralNotability, Un1tY, FelixE2019, 
Akuckartz, Dzaky17, Hook696, CptViraj, darthmon_wmde, ST47, WDoranWMF, Majavah, 
Kent7301, Chambersjay, RhinosF1, EvanProdromou, joker88john, SD0001, 94rain, 
DannyS712, wildly_boy, CucyNoiD, Nandana, Chief_Mike, Tks4Fish, Tumz24, 
Gaboe420, Jony, CycloneIsaac, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Minilexikon, Bsandipan, Gboyers, GoranSMilovanovic, ihojose, 
Mahir256, QZanden, LawExplorer, Litanwei, spatton, Samuele2002, Lewizho99, 
JJMC89, Maathavan, SundanceRaphael, _jensen, Jseddon, rosalieper, Agabi10, AGK, 
XanonymusX, Neuronton, RuyP, JEumerus, gabriel-wmde, Scott_WUaS, mb, Cirdan, 
Pchelolo, DStrine, XenoRyet, Wong128hk, Luke081515, Nirmos, Bsadowski1, 
mys_721tx, I_JethroBT, Unapersona, Zache, alex-mashin, Niharika, Wikidata-bugs, 
Snowolf, Base, aude, AndyRussG, Ebe123, Nullzero, Pcoombe, Huji, Dinoguy1000, 
jeblad, jayvdb, MrStradivarius, RandomDSdevel, fbstj, Lydia_Pintscher, Florian, 
KartikMistry, Isarra, Billinghurst, Ladsgroup, Addshore, Jackmcbarn, Mbch331, 
Jay8g, Ltrlg, Glaisher, Krenair, jeremyb, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

[Daimona]

Daimona added a comment.


  Based on my local testing, my guess was right. This was caused by r747596 
<https://gerrit.wikimedia.org/r/c/mediawiki/core/+/747596> -- notice how 
`$slotRole` is not passed to onEditFilterMergedContent. OTOH, it's really not 
that patch's fault, since the parameter is not officially documented in the 
hook documentation, nor is it present in the EditFilterMergedContentHook 
interface (see T25 <https://phabricator.wikimedia.org/T25>).
  
  At this point, I think that the core hook should be changed to pass this 
parameter. Making it mandatory would be a breaking change and we'd better 
replace the hook with a new one, so perhaps we can just add it as an optional 
(but recommended) parameter for now.

TASK DETAIL
  https://phabricator.wikimedia.org/T298672

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Bugreporter, Base, Aklapper, Jdx, Invadibot, GFontenelle_WMF, 
maantietaja, Y.ssk, FRomeo_WMF, Muchiri124, CBogen, Nintendofan885, Akuckartz, 
94rain, Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, Anoop, 
SandraF_WMF, GoranSMilovanovic, ihojose, QZanden, Tramullas, Acer, LawExplorer, 
Litanwei, Salgo60, JJMC89, Silverfish, Poyekhali, _jensen, rosalieper, 4nn1l2, 
Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Nirmos, Jane023, 
Wikidata-bugs, matthiasmullie, aude, Nullzero, Huji, El_Grafo, Dinoguy1000, 
Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Billinghurst, Jackmcbarn, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

[Daimona]

Daimona added a subtask: T25: Wikibase runs the EditFilterMergedContent 
hook with an extra parameter.

TASK DETAIL
  https://phabricator.wikimedia.org/T298672

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Bugreporter, Base, Aklapper, Jdx, Invadibot, GFontenelle_WMF, 
maantietaja, Y.ssk, FRomeo_WMF, Muchiri124, CBogen, Nintendofan885, Akuckartz, 
94rain, Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, Anoop, 
SandraF_WMF, GoranSMilovanovic, ihojose, QZanden, Tramullas, Acer, LawExplorer, 
Litanwei, Salgo60, JJMC89, Silverfish, Poyekhali, _jensen, rosalieper, 4nn1l2, 
Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Nirmos, Jane023, 
Wikidata-bugs, matthiasmullie, aude, Nullzero, Huji, El_Grafo, Dinoguy1000, 
Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Billinghurst, Jackmcbarn, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288885: Wikibase runs the EditFilterMergedContent hook with an extra parameter

[Daimona]

Daimona added a parent task: T298672: "Anonymous" users cannot undo changes 
related to structured data due to AbuseFilter.

TASK DETAIL
  https://phabricator.wikimedia.org/T25

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Invadibot, maantietaja, Akuckartz, 94rain, Nandana, 
Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, 
Nullzero, Huji, Billinghurst, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288885: Wikibase runs the EditFilterMergedContent hook with an extra parameter

[Daimona]

Daimona updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T25

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Invadibot, maantietaja, Akuckartz, 94rain, Nandana, 
Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, 
Nullzero, Huji, Billinghurst, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

[Daimona]

Daimona added a comment.


  The first thing that comes to mind is that whoever is firing the 
EditFilterMergedContent hook is passing SLOT_MAIN instead of the actual slot 
being edited. I'll try to reproduce this locally and see if that's indeed the 
reason.

TASK DETAIL
  https://phabricator.wikimedia.org/T298672

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Bugreporter, Base, Aklapper, Jdx, Invadibot, GFontenelle_WMF, 
maantietaja, Y.ssk, FRomeo_WMF, Muchiri124, CBogen, Nintendofan885, Akuckartz, 
94rain, Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, Anoop, 
SandraF_WMF, GoranSMilovanovic, ihojose, QZanden, Tramullas, Acer, LawExplorer, 
Litanwei, Salgo60, JJMC89, Silverfish, Poyekhali, _jensen, rosalieper, 4nn1l2, 
Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Nirmos, Jane023, 
Wikidata-bugs, matthiasmullie, aude, Nullzero, Huji, El_Grafo, Dinoguy1000, 
Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Billinghurst, Jackmcbarn, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288885: Wikibase runs the EditFilterMergedContent hook with an extra parameter

[Daimona]

Daimona removed a parent task: T261067: Use DI in AbuseFilterHooks.

TASK DETAIL
  https://phabricator.wikimedia.org/T25

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Invadibot, maantietaja, Akuckartz, 94rain, Nandana, 
Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, 
Nullzero, Huji, Billinghurst, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288885: Wikibase runs the EditFilterMergedContent hook with an extra parameter

[Daimona]

Daimona added a comment.


  Actually, it's possible to add the parameter to the handler and phan won't 
complain. Yet it requires the extension to pick a default, and it looks like a 
code smell anyway. Hence, I still believe that this should be fixed in 
Wikibase/core.

TASK DETAIL
  https://phabricator.wikimedia.org/T25

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Invadibot, maantietaja, Akuckartz, 94rain, Nandana, 
Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, 
Nullzero, Huji, Billinghurst, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288885: Wikibase runs the EditFilterMergedContent hook with an extra parameter

[Daimona]

Daimona updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T25

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Invadibot, maantietaja, Akuckartz, 94rain, Nandana, 
Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, 
Nullzero, Huji, Billinghurst, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288885: Wikibase runs the EditFilterMergedContent hook with an extra parameter

[Daimona]

Daimona added a parent task: T261067: Use DI in AbuseFilterHooks.

TASK DETAIL
  https://phabricator.wikimedia.org/T25

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Invadibot, maantietaja, Akuckartz, 94rain, Nandana, 
Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, 
Nullzero, Huji, Billinghurst, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288885: Wikibase runs the EditFilterMergedContent hook with an extra parameter

[Daimona]

Daimona created this task.
Daimona added projects: Wikidata, MediaWiki-Core-Hooks, AbuseFilter.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Wikibase has its own code 
<https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/a1cba3fe72085761941752c257263061c923fd0a/repo/includes/EditEntity/MediawikiEditFilterHookRunner.php#103>
 to run the EditFilterMergedContent hook which also passes the $slotRole 
parameter. However, this isn't passed when the hook is run by EditPage, and the 
parameter is also absent in the new-style EditFilterMergedContentHook 
interface. Among other things, this means that any handler that needs the 
$slotRole parameter (e.g. AbuseFilter) cannot switch to the new interface for 
the EditFilterMergedContent hook.
  
  Either the parameter is added to MW core, or runs a new hook there.

TASK DETAIL
  https://phabricator.wikimedia.org/T25

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Invadibot, maantietaja, Akuckartz, 94rain, Nandana, 
Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, 
Nullzero, Huji, Billinghurst, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288722: Master tests failing for EntitySchema due to diff class changes

[Daimona]

Daimona moved this task from Ready  to Product sign-off 落 on the 
Community-Tech (CommTech-Sprint-6) board.
Daimona added a comment.


  (Not sure where this should go)

TASK DETAIL
  https://phabricator.wikimedia.org/T288722

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5411/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Aklapper, Daimona, DannyS712, NRodriguez, ldelench_wmf, Invadibot, 
maantietaja, SCIdude, Akuckartz, ifried, HMonroy, pdehaye, Nandana, 
Amorymeltzer, Lahi, Gq86, dmaza, Andrawaag, GoranSMilovanovic, QZanden, 
YULdigitalpreservation, LawExplorer, Salgo60, JJMC89, B20180, _jensen, 
rosalieper, Scott_WUaS, Samwilson, MisterSynergy, Nakon, abian, MusikAnimal, 
Wikidata-bugs, WMDE-Fisch, aude, Ricordisamoa, -jem-, Lydia_Pintscher, 
Jdforrester-WMF, Addshore, Mbch331, Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288722: Master tests failing for EntitySchema due to diff class changes

[Daimona]

Daimona removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T288722

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Aklapper, Daimona, DannyS712, NRodriguez, ldelench_wmf, Invadibot, 
maantietaja, SCIdude, Akuckartz, ifried, HMonroy, pdehaye, Nandana, 
Amorymeltzer, Lahi, Gq86, dmaza, Andrawaag, GoranSMilovanovic, QZanden, 
YULdigitalpreservation, LawExplorer, Salgo60, JJMC89, B20180, _jensen, 
rosalieper, Scott_WUaS, Samwilson, MisterSynergy, Nakon, abian, MusikAnimal, 
Wikidata-bugs, WMDE-Fisch, aude, Ricordisamoa, -jem-, Lydia_Pintscher, 
Jdforrester-WMF, Addshore, Mbch331, Krenair, Biggs657, Lalamarie69, Juan90264, 
Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, 
Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T285498: Wikidata: Investigate bibliographic bot

[Daimona]

Daimona added a comment.


  In T285498#7220146 <https://phabricator.wikimedia.org/T285498#7220146>, 
@Samwilson wrote:
  
  >> A part which queries Wikidata for bare URLs.
  >
  > A Sparql query can do this, and perhaps we'd want to query based on missing 
reference properties, and not just alone Reference URLs (e.g. a URL and title 
might be set, but no author or published date).
  
  Yeah, I was also thinking about SPARQL, but I've never queried wikidata so I 
don't really know whether it's the right tool. I think retrieving a list of 
pages that use reference URLs would be trivial, the non-trivial part is making 
sure that a given reference only has the reference URL and nothing else.
  
  >> A part which parses the citoid output and puts it back on the wiki.
  >
  > It's certainly be possible to do this, given the data returned by Citoid, 
but I'm wondering if this is reliable enough for an unsupervised process. For 
example, adding a reference while editing gives the user a change to check that 
the title, author, date etc. are correct and what they want, before they save 
the data. If a bot comes along later, finds a bare Reference URL, and fills in 
the missing data, there doesn't seem to be any process by which the user can 
easily confirm that it's correct. This feels like it might be a concern, but it 
didn't come up during the Wishlist Survey, so perhaps I'm misunderstanding 
things.
  
  Right, this is a valid concern. I think it all boils down to the accuracy 
degree of citoid, and also whether it prefers false positives or false 
negatives when generating data (i.e. whether it knows the probability of the 
auto-generated data being correct for a given field, and what it does based on 
this probability, in terms of "generate data anyway" and "don't generate any 
data"). If it's not accuracy-focused, an entirely automatic process might 
indeed be problematic, and we might want to implement option 1 or 3 instead.
  
  > It seems to me that the first thing is to find out if anyone else is 
working on the while-editing tool
  
  +1
  
  > there's a 'Manual' tab in the references section on Test Wikidata, which 
looks like it's meant to have an 'Automatic' section next to it... but I guess 
it's not functioning yet (the code 
<https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/ea35dd53bb0c8ffe384c2ea344b159233d47cb7d/view/resources/jquery/wikibase/jquery.wikibase.referenceview.js#104>
 looks like it's missing any other tab, and it doesn't look like 
`$wbRefTabsEnabled` is configurable)? So maybe we could help with that work, if 
it's been stalled?
  
  I think it used to work on the beta cluster, given T228411 
<https://phabricator.wikimedia.org/T228411> and the comments at T199197 
<https://phabricator.wikimedia.org/T199197>, but maybe it was disabled since 
then.
  
  In T285498#7220165 <https://phabricator.wikimedia.org/T285498#7220165>, 
@Lydia_Pintscher wrote:
  
  > Thanks for looking into this! I think before you move forward we should 
have a call to talk through what the Wikidata team has already done with 
Marielle in this area. It's a deceptively simple problem on the surface.
  
  Thank you @Lydia_Pintscher, this would be fantastic!

TASK DETAIL
  https://phabricator.wikimedia.org/T285498

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Lydia_Pintscher, Samwilson, HMonroy, Aklapper, NRodriguez, ldelench_wmf, 
Invadibot, maantietaja, Akuckartz, ifried, Nandana, Lahi, Gq86, dmaza, 
GoranSMilovanovic, QZanden, LawExplorer, JJMC89, B20180, _jensen, rosalieper, 
Scott_WUaS, Nakon, MusikAnimal, Wikidata-bugs, aude, Ricordisamoa, -jem-, 
Mbch331, Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T285498: Wikidata: Investigate bibliographic bot

[Daimona]

Daimona moved this task from In Development  to Review/Feedback  on the 
Community-Tech (CommTech-Sprint-4) board.
Daimona added a comment.


  Preliminary investigation
  -
  
  What follows is my preliminary investigation on this wish. It is not complete 
yet, mostly because I think we need to refine the scope, and then maybe put 
additional effort into one direction.
  
  Problem statement, AIUI
  ---
  
  Many references on Wikidata only consist of a bare URL. This is subpar 
because it doesn't expose detail about the source, at least not in a structured 
format (note, I'm making this statement given my experience as a Wikipedia 
editor, but with little knowledge about Wikidata). We want a way to reduce the 
amount of such references.
  
  Possible solutions
  --
  
  I can see three ways in which we can act in order to mitigate the issue:
  
  1. Provide visual guidance on the VisualEditor, so users will add structured 
references right from the start (or use this to autofill details on existing 
bare URLs while editing).
  2. Provide an on-wiki gadget that does the same thing as 1.
  3. Provide an external tool, with a nice interface and OAuth-based, that 
editors can use to change existing references on a given page to make them 
structured.
  4. Create a bot (without an OAuth-based interface) that periodically scans 
for bare URLs and replaces them with structured data.
  
  Below is an initial investigation on each of these, but we might want to 
focus only on some of them. Note that options 3. and 4. are not mutually 
exclusive. In fact, we might merge them into a single tool that scans things on 
its own but can also be manually controlled (like IABot).
  
  1. While editing
  
  
  This approach is essentially what citoid 
<https://www.mediawiki.org/wiki/Citoid> does out of Wikidata. When you click 
the button to add a reference and the dialog appears, you have an option to 
autogenerate data from a URL. So what we would need here is citoid integration 
with Wikidata. There is already a task for this: T199197: [2.11] Integrate 
Citoid in Wikidata <https://phabricator.wikimedia.org/T199197> (see also the 
subtasks). That task is stalled, but TTBOMK, some teams were (are?) already 
working on this. We might want to get in touch with them before exploring this 
direction or deciding that we don't want to go there.
  
  Also, I think it's worth noting that according to T199197 
<https://phabricator.wikimedia.org/T199197>, the integration should already be 
on for beta wikidata. I went to tried this at 
https://wikidata.beta.wmflabs.org/wiki/Q381012 (which is a test page linked in 
that same task), but I didn't get any option to generate structured data from a 
URL. So either it's been disabled there, or I'm missing something.
  
  2. Gadget
  -
  
  There's already a user script for this: User:Aude/citoid.js 
<https://www.wikidata.org/wiki/User:Aude/citoid.js> (which was mentioned 
above), plus the fork 
<https://www.wikidata.org/wiki/User:MichaelSchoenitzer/CiteTool> mentioned by 
Sam. AIUI, this is just a stopgap until option 1 is implemented. IMHO, it's not 
worth putting effort into implementing/refining a stopgap. Also, if we were to 
go this route, there wouldn't be much to do, beyond making sure that the code 
works and has all the functionality that we need. Note that these scripts use 
citoid as backend.
  
  3. Manual OAuth tool
  
  
  There is already a tool for this that works on Wikipedia: 
https://refill.toolforge.org/. This tool is written in python and looks very 
good, it has a nice interface and it's localized. It also works well 
<https://it.wikipedia.org/w/index.php?title=Utente:Daimona_Eaytoy/Sandbox=121912880=121912865>.
 The problem, as implied before, is that it only works on Wikipedia, so not on 
Wikidata. The tool also uses citoid as backend.
  
  What to do in this direction depends on the approach we want to follow. If a 
web interface is enough, we can maybe get in touch with the maintainer and add 
wikidata support to this tool. If we also want a dedicated backend (i.e. a 
bot), then building on top of refill may or may not be the best thing to do.
  
  4. Bot
  --
  
  I couldn't find an existing bot that performs this task (I grepped bot user 
pages on wikidata with a few keywords like `P854`). We can architect such a bot 
pretty much however we feel right. I believe the only certain thing is that we 
need to use citoid as backend. It exposes a REST API 
<https://en.wikipedia.org/api/rest_v1/#/Citation/getCitation> which apparently 
has support for a "wikibase" output format. Essentially, we'd have to put 
together:
  
  - A part which queries Wikidata for bare URLs. I don't have a solution for 
this due to my lack of knowledge about Wikidata, but I'm confident that there's 
a way to do this with hig

[Wikidata-bugs] [Maniphest] T285498: Wikidata: Investigate bibliographic bot

[Daimona]

Daimona claimed this task.
Daimona moved this task from Ready  to In Development  on the Community-Tech 
(CommTech-Sprint-4) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T285498

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5383/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Samwilson, HMonroy, Aklapper, NRodriguez, ldelench_wmf, Invadibot, 
maantietaja, Akuckartz, ifried, Nandana, Lahi, Gq86, dmaza, GoranSMilovanovic, 
QZanden, LawExplorer, JJMC89, B20180, _jensen, rosalieper, Scott_WUaS, Nakon, 
MusikAnimal, Wikidata-bugs, aude, Ricordisamoa, -jem-, Mbch331, Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T285581: Global AbuseFilter inconsistency for NewItem on Wikidata

[Daimona]

Daimona added a comment.


  The namespace is explicitly set 
<https://phabricator.wikimedia.org/diffusion/EABF/browse/master/includes/AbuseLogger.php$152>
 to 0, and has always been. I think this might be due to issues with cross-wiki 
references. Things might have improved lately with the ongoing refactor of the 
Title class.

TASK DETAIL
  https://phabricator.wikimedia.org/T285581

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Zabe, Aklapper, 1234qwer1234qwer4, Invadibot, maantietaja, 
Akuckartz, 94rain, Nandana, Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, 
LawExplorer, Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Nirmos, Wikidata-bugs, aude, Nullzero, Huji, Billinghurst, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283457: Drop requirement of data-values/common < 1.0.0 from known repos

[Daimona]

Daimona added a parent task: T283216: Cleanup old PHPUnit Class Aliases.

TASK DETAIL
  https://phabricator.wikimedia.org/T283457

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283457: Drop requirement of data-values/common < 1.0.0 from known repos

[Daimona]

Daimona created this task.
Daimona added projects: Wikibase-Quality-Constraints, Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  At the time of writing, Wikibase's composer.json has `"data-values/common": 
"^1.0.0|^0.4.0|^0.3.0",`, and WikibaseQualityConstraints has 
`"data-values/common": "^0.4.0|^0.3.0",`. These are old versions, and only 
1.0.0+ should be kept instead. The main reason for this is that we can then 
drop old PHPUnit aliases (T283216 <https://phabricator.wikimedia.org/T283216>).

TASK DETAIL
  https://phabricator.wikimedia.org/T283457

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T278011: Stop using the MediaWikiPHPUnitTest::startTest hook in Wikibase

[Daimona]

Daimona added a comment.


  In T278011#6934730 <https://phabricator.wikimedia.org/T278011#6934730>, 
@Lucas_Werkmeister_WMDE wrote:
  
  > Nope, too early :D
  >
  >> 12:11:10 Tests: 4319, Assertions: 14540, **Errors: 63, Failures: 14**, 
Skipped: 276.
  >
  > But let’s revisit this towards the end of the service migration.
  
  What about adding a trait which calls `WikibaseRepo::resetClassStatics()` in 
tearDownAfterClass? The problem is to figure out which test classes need it, I 
guess.

TASK DETAIL
  https://phabricator.wikimedia.org/T278011

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Rosalie_WMDE, ItamarWMDE, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, 
Daimona, Aklapper, Invadibot, maantietaja, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278011: Stop using the MediaWikiPHPUnitTest::startTest hook in Wikibase

[Daimona]

Daimona added a project: MediaWiki-extensions-WikibaseRepository.
Restricted Application added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T278011

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Invadibot, maantietaja, Akuckartz, darthmon_wmde, 
Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277859: Exception caught: MediaWiki\User\UserEditTracker::getUserEditCount requires a user ID on beta

[Daimona]

Daimona claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T277859

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Ladsgroup, Addshore, Aklapper, maantietaja, Akuckartz, darthmon_wmde, 
94rain, Nandana, Lahi, Gq86, Daimona, GoranSMilovanovic, ihojose, QZanden, 
LawExplorer, Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Nirmos, abian, Wikidata-bugs, aude, Nullzero, Huji, Lydia_Pintscher, 
Billinghurst, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269315: Fatal error: Cannot pass parameter 1 by reference (Wikibase\DataModel\Entity)

[Daimona]

Daimona added a comment.


  Even if it isn't an opcache corruption, it might still be a PHP bug. In 
principle it might make sense to report it upstream, but since we're using PHP 
7.2 (no longer supported), I think we should first see if this still happens 
after upgrading to a supported version; that would be PHP 7.4 at the time of 
writing and until 28 Nov 2021. And we'd also need a smaller test case. As such, 
IMHO the best option is to just wait (at least until WMF servers run a PHP 
version that still has active support), see if it fixes itself, and then decide.

TASK DETAIL
  https://phabricator.wikimedia.org/T269315

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Umherirrender, Addshore, hashar, Lucas_Werkmeister_WMDE, 
Ladsgroup, mmodell, RhinosF1, Aklapper, Reedy, maantietaja, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, abian, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269757: Time to require PHP 7.2+?

[Daimona]

Daimona updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T269757

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Akuckartz, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269757: Time to require PHP 7.2+?

[Daimona]

Daimona created this task.
Daimona added a project: Wikibase-Quality-Constraints.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  Copying from T269756 <https://phabricator.wikimedia.org/T269756>:
  
  The extension's composer.json reads:
  
  "php": ">=5.5.9"
  But the code is already using PHP 7.1 nullable types, as spotted by phan in 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikidata.org/+/647228. 
Perhaps it's time to bump the requirement to PHP 7.2+? Or is these some good 
reason to keep it at 5.5, and we should remove PHP 7 features?

TASK DETAIL
  https://phabricator.wikimedia.org/T269757

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Akuckartz, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269756: Time to require PHP 7.2+?

[Daimona]

Daimona created this task.
Daimona added projects: Wikidata.org, Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  The extension's composer.json reads:
  
"php": ">=5.5.9"
  
  But the code is already using PHP 7.1 nullable types, as spotted by phan in 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikidata.org/+/647228. 
Perhaps it's time to bump the requirement to PHP 7.2+? Or is these some good 
reason to keep it at 5.5, and we should remove PHP 7  features?

TASK DETAIL
  https://phabricator.wikimedia.org/T269756

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T260915: Move DataValues away from “withered” PHPUnit 4

[Daimona]

Daimona added a comment.


  Well done everybody! Should another task be created about the removal of 
PHPUnit4CompatTrait 
<https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/574a68116410b531c8b3f7952c5e866ec3cfd4c8/repo/tests/phpunit/includes/Parsers/PHPUnit4CompatTrait.php>?
 That is blocked on bumping the versions of the affected DataValues libraries.

TASK DETAIL
  https://phabricator.wikimedia.org/T260915

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, Daimona
Cc: WMDE-leszek, ItamarWMDE, Daimona, MaxSem, Aklapper, Lucas_Werkmeister_WMDE, 
Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, 
Nikerabbit, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T265091: element (".wb-ui-event-emitting-button--edit") still not existing after 3000ms

[Daimona]

Daimona added a comment.


  In T265091#6586803 <https://phabricator.wikimedia.org/T265091#6586803>, 
@Reedy wrote:
  
  > In T265091#6586789 <https://phabricator.wikimedia.org/T265091#6586789>, 
@Daimona wrote:
  >
  >> Dupe of T264926 <https://phabricator.wikimedia.org/T264926>?
  >
  > Doesn't seem to be... I don't see `wb-ui-event-emitting-button--edit` 
mentioned in that bug... Similar/related? sure
  
  Yeah, there seems to be a bunch of tests failing randomly. I think no-one 
really knows why, and for as much as we know, it might be some upstream problem 
with wdio.

TASK DETAIL
  https://phabricator.wikimedia.org/T265091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Reedy, Akuckartz, DannyS712, Nandana, Lahi, Gq86, 
Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, zeljkofilipin, 
Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T265091: element (".wb-ui-event-emitting-button--edit") still not existing after 3000ms

[Daimona]

Daimona added a comment.


  Dupe of T264926 <https://phabricator.wikimedia.org/T264926>?

TASK DETAIL
  https://phabricator.wikimedia.org/T265091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Reedy, Akuckartz, DannyS712, Nandana, Lahi, Gq86, 
Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, zeljkofilipin, 
Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264841: Flaky selenium test: WikibaseReferenceOnProtectedPage

[Daimona]

Daimona added a comment.


  There seem to be more flaky test, not only in WB but also elsewhere (e.g. 
AbuseFilter and FileImporter at least). I'm convincing myself that it might be 
a wdio bug, as per comments at T264926 
<https://phabricator.wikimedia.org/T264926>.

TASK DETAIL
  https://phabricator.wikimedia.org/T264841

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Nikerabbit, Aklapper, Daimona, Akuckartz, DannyS712, Nandana, lucamauri, 
Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264841: Flaky selenium test: WikibaseReferenceOnProtectedPage

[Daimona]

Daimona triaged this task as "High" priority.
Daimona added a comment.


  I'm seeing this error more and more, e.g. today on r629233 
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/629233>. 
I'm unsure about the status for other gated extensions, but it's quite 
annoying. Could someone please take a look?

TASK DETAIL
  https://phabricator.wikimedia.org/T264841

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Aklapper, Daimona, Akuckartz, darthmon_wmde, DannyS712, Nandana, lucamauri, 
Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264841: Flaky selenium test: WikibaseReferenceOnProtectedPage

[Daimona]

Daimona created this task.
Daimona added projects: MediaWiki-extensions-WikibaseClient, ci-test-error 
(WMF-deployed Build Failure).
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  Recently I've been consistently facing a flaky selenium test from 
Wikibase/client/data-bridge, which is making the build fail on other repos. 
I've spotted this error roughly 5 times in the last week, for AbuseFilter 
patches. Recent example 
<https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/62784/console>:
  
01:24:19 [chrome 73.0.3683.75 Linux #0-3] Spec: 
/workspace/src/extensions/Wikibase/repo/tests/selenium/specs/readmode.references.js
01:24:19 [chrome 73.0.3683.75 Linux #0-3] Running: chrome (v73.0.3683.75) 
on Linux
01:24:19 [chrome 73.0.3683.75 Linux #0-3] Session ID: 
f78ee0e565857c3801d9ec06375be73c
01:24:19 [chrome 73.0.3683.75 Linux #0-3]
01:24:19 [chrome 73.0.3683.75 Linux #0-3] WikibaseReferenceOnProtectedPage
01:24:19 [chrome 73.0.3683.75 Linux #0-3]✖ can expand collapsed 
references on a protected page as unprivileged user
01:24:19 [chrome 73.0.3683.75 Linux #0-3]
01:24:19 [chrome 73.0.3683.75 Linux #0-3] 1 failing (28.1s)
01:24:19 [chrome 73.0.3683.75 Linux #0-3]
01:24:19 [chrome 73.0.3683.75 Linux #0-3] 1) 
WikibaseReferenceOnProtectedPage can expand collapsed references on a protected 
page as unprivileged user
01:24:19 [chrome 73.0.3683.75 Linux #0-3] element 
(".wikibase-statementview-references-container 
.wikibase-statementview-references-heading a.ui-toggler") still not displayed 
after 1ms
01:24:19 [chrome 73.0.3683.75 Linux #0-3] Error: element 
(".wikibase-statementview-references-container 
.wikibase-statementview-references-heading a.ui-toggler") still not displayed 
after 1ms
01:24:19 [chrome 73.0.3683.75 Linux #0-3] at Context. 
(/workspace/src/extensions/Wikibase/repo/tests/selenium/specs/readmode.references.js:19:111)
  
  and the screenshot 
<https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/62784/artifact/log/can-expand-collapsed-references-on-a-protected-page-as-unprivileged-user.png>
 doesn't seem to show anything suspicious.

TASK DETAIL
  https://phabricator.wikimedia.org/T264841

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Aklapper, Daimona, Akuckartz, darthmon_wmde, DannyS712, Nandana, lucamauri, 
Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T105325: [Bug] edit_diff_pst variable is broken on Wikidata

[Daimona]

Daimona added a project: TestMe.
Daimona added a comment.


  Based on a couple random edits on wikidata, this seems to be working 
correctly now. Leaving open for confirmation. If it's still broken, this task 
can be considered for the upcoming overhaul.

TASK DETAIL
  https://phabricator.wikimedia.org/T105325

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, hoo, Addshore, Aklapper, Luke081515, matej_suchanek, Akuckartz, 
darthmon_wmde, 94rain, Nandana, Lahi, Gq86, GoranSMilovanovic, ihojose, 
QZanden, LawExplorer, Litanwei, JJMC89, TerraCodes, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, Nullzero, Huji, 
Billinghurst, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T254701: Tests failing for the master branch of WikibaseLexeme

[Daimona]

Daimona closed this task as "Resolved".
Daimona assigned this task to Jakob_WMDE.
Daimona added a project: phan.
Daimona added a comment.


  Fixed with 
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/602735/
  
  Aside, we might consider enabling `allow_method_param_type_widening` for 
phan, since we only support PHP 7.2+.

TASK DETAIL
  https://phabricator.wikimedia.org/T254701

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jakob_WMDE, Daimona
Cc: Daimona, DannyS712, darthmon_wmde, Nandana, Mringgaard, Lahi, Gq86, 
Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, 
Mbch331, hashar
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T250338: Replace `NewRevisionFromEditComplete` with a new hook

[Daimona]

Daimona added a comment.


  In T250338#6170464 <https://phabricator.wikimedia.org/T250338#6170464>, 
@DannyS712 wrote:
  
  > @Daimona or another phan expert - would you be willing to take a look at 
the wikibase phan failure?
  
  It's coming from an array property, so likely a false positive. Upgrading 
taint-check might help, perhaps it's worth trying.
  
  I didn't investigate the failure locally, nor will I do that unless it still 
exists on master. Debugging taint-check failures is usually a process of trial 
and error that takes a lot of time.
  
  > The failure doesn't exist on master, and shouldn't have been caused by the 
commit, which doesn't touch any of the files involved in the phan error
  
  It doesn't matter. Taint-check scans the code base very deeply and is often 
nondeterministic. The patch above may well have caused this new issue to appear.

TASK DETAIL
  https://phabricator.wikimedia.org/T250338

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DannyS712, Daimona
Cc: Daimona, Aklapper, Pchelolo, DannyS712, Naike, Blissjay007, Oblanco79, 
Alter-paule, NavinRizwi, Beast1978, Un1tY, eprodromou, Dzaky17, Hook696, 
Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, 
joker88john, 94rain, CucyNoiD, Nandana, NebulousIris, kostajh, Gaboe420, Jony, 
lucamauri, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, 
Force_Radical, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Vexations, Jayprakash12345, Th3d3v1ls, Ramalepe, 
Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, 
rosalieper, XanonymusX, Taiwania_Justo, Scott_WUaS, Cirdan, Izno, Zache, 
Wikidata-bugs, aude, Dinoguy1000, jeblad, brion, TheDJ, Jdforrester-WMF, 
Jackmcbarn, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T250720: Wikidata edit filter does not fire when test tool says it should

[Daimona]

Daimona added a comment.


  In T250720#6073559 <https://phabricator.wikimedia.org/T250720#6073559>, 
@Ahmad252 wrote:
  
  > In T250720#6072828 <https://phabricator.wikimedia.org/T250720#6072828>, 
@Daimona wrote:
  >
  >> Haven't checked deeply, but a possible hint is that AF doesn't see 
automatic edit summaries (I think there was a task for that) which, however, it 
sees when retrospectively examinating edits.
  >
  > But still, the edit summary it sees (the *real* summary) is something like 
`/* undo:0||REVID|USERNAME */`.
  
  It depends on how you define "real". I have to say, I'm not at all certain 
about the summary that the filter is effectively seeing, so... I don't even 
know where the 'undo:0 ...' part is coming from in Wikibase, so I can't tell 
whether it can be read by the AF.
  
  In T250720#6074608 <https://phabricator.wikimedia.org/T250720#6074608>, 
@matej_suchanek wrote:
  
  > For testing, I re-used blank 
https://www.wikidata.org/wiki/Special:AbuseFilter/31 with
  >
  >   'undo:0' in summary
  >
  > During the test, there were at least 9 undo actions (tagged as `mw-undo`, 
example 
<https://www.wikidata.org/w/index.php?title=Q1659640=1593296=1162557029=1161698093>)
 but none of them triggered the filter. So @Daimona may be right...
  
  Not surprising... I'd be glad to confirm this and investigate it locally, but 
I don't have Wikibase installed on my wiki, and it's also not so easy to 
install IIRC (also I'm not practical with it).

TASK DETAIL
  https://phabricator.wikimedia.org/T250720

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: matej_suchanek, Ahmad252, Daimona, Aklapper, Bovlb, darthmon_wmde, 94rain, 
Nandana, Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, LawExplorer, 
Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, 
Wikidata-bugs, aude, Nullzero, Huji, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else

[Daimona]

Daimona closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T250570

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: matej_suchanek, Daimona, DannyS712, Aklapper, darthmon_wmde, 94rain, 
Nandana, Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, LawExplorer, 
Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, 
Wikidata-bugs, aude, Nullzero, Huji, Jdforrester-WMF, Jackmcbarn, Mbch331, Rxy, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T250720: Wikidata edit filter does not fire when test tool says it should

[Daimona]

Daimona added a comment.


  Haven't checked deeply, but a possible hint is that AF doesn't see automatic 
edit summaries (I think there was a task for that) which, however, it sees when 
retrospectively examinating edits.

TASK DETAIL
  https://phabricator.wikimedia.org/T250720

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Bovlb, darthmon_wmde, 94rain, Nandana, Lahi, Gq86, 
GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, _jensen, 
rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, Nullzero, Huji, 
Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Claimed] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else

[Daimona]

Daimona claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T250570

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: matej_suchanek, Daimona, DannyS712, Aklapper, Blissjay007, Oblanco79, 
Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Kent7301, Meekrab2012, joker88john, 94rain, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, Pablo-WMDE, 
GoranSMilovanovic, Adik2382, ihojose, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Litanwei, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, Nullzero, Huji, 
Jdforrester-WMF, Jackmcbarn, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else

[Daimona]

Daimona added a comment.


  In T250570#6068356 <https://phabricator.wikimedia.org/T250570#6068356>, 
@Daimona wrote:
  
  > Or actually, I think it's because checking `getType() == UNDEFINED` (at 
least in callKeyword and callFunc, perhaps elsewhere) doesn't work well for 
arrays (it doesn't recurse).
  
  Yeah, this one. MWE: `'x' in [ user_name ]`

TASK DETAIL
  https://phabricator.wikimedia.org/T250570

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, DannyS712, Aklapper, darthmon_wmde, 94rain, Nandana, Lahi, Gq86, 
Pablo-WMDE, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, 
Nullzero, Huji, Jdforrester-WMF, Jackmcbarn, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else

[Daimona]

Daimona added a comment.


  Or actually, I think it's because checking `getType() == UNDEFINED` (at least 
in callKeyword and callFunc, perhaps elsewhere) doesn't work well for arrays 
(it doesn't recurse).
  
  Adding AFPData::hasUndefined() as a recursive method would be the solution.

TASK DETAIL
  https://phabricator.wikimedia.org/T250570

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, DannyS712, Aklapper, darthmon_wmde, 94rain, Nandana, Lahi, Gq86, 
Pablo-WMDE, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, 
Nullzero, Huji, Jdforrester-WMF, Jackmcbarn, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else

[Daimona]

Daimona added a comment.


  I think explicit casts aren't special-cased in the DUNDEFINED check, should 
be an easy fix

TASK DETAIL
  https://phabricator.wikimedia.org/T250570

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, DannyS712, Aklapper, darthmon_wmde, 94rain, Nandana, Lahi, Gq86, 
Pablo-WMDE, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, 
Nullzero, Huji, Jdforrester-WMF, Jackmcbarn, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Retitled] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else

[Daimona]

Daimona renamed this task from "AFPException when saving filter on wikidata" to 
"AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to 
something else".
Daimona updated the task description.
Daimona edited Stack Trace.

TASK DETAIL
  https://phabricator.wikimedia.org/T250570

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, DannyS712, Aklapper, darthmon_wmde, 94rain, Nandana, Lahi, Gq86, 
Pablo-WMDE, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, 
Nullzero, Huji, Jdforrester-WMF, Jackmcbarn, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Merged] T247782: WikibaseLexeme CI broken due to Title constructor being private

[Daimona]

Daimona merged a task: T247806: Make WikibaseLexeme compatible with PHP 7.4.
Daimona added subscribers: Jdforrester-WMF, Reedy, Aklapper.

TASK DETAIL
  https://phabricator.wikimedia.org/T247782

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Aklapper, Reedy, Jdforrester-WMF, WMDE-leszek, Lucas_Werkmeister_WMDE, 
Daimona, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, 
NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247806: Make WikibaseLexeme compatible with PHP 7.4

[Daimona]

Daimona added a comment.


  Not because of PHP 7.4 :-[

TASK DETAIL
  https://phabricator.wikimedia.org/T247806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Reedy, Aklapper, Jdforrester-WMF, darthmon_wmde, Nandana, 
Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Nikerabbit, MaxSem, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T247806: Make WikibaseLexeme compatible with PHP 7.4

[Daimona]

Daimona closed this task as a duplicate of T247782: WikibaseLexeme CI broken 
due to Title constructor being private.

TASK DETAIL
  https://phabricator.wikimedia.org/T247806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Reedy, Aklapper, Jdforrester-WMF, darthmon_wmde, Nandana, Mringgaard, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Nikerabbit, MaxSem, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247782: WikibaseLexeme CI broken due to Title constructor being private

[Daimona]

Daimona added a comment.


  Meh, I thought these test-only errors would have been spotted by the wmf-gate 
jobs. Sorry for the breakage :(

TASK DETAIL
  https://phabricator.wikimedia.org/T247782

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Lucas_Werkmeister_WMDE, Daimona, Alter-paule, Beast1978, Un1tY, Hook696, 
Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247670: PHPUnit warning noise from ClientParserOutputDataUpdaterTest (Wikibase)

[Daimona]

Daimona added a comment.


  It doesn't seem a recent regression, see 
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+blame/de5e309c258b121bf0626728d8d9a6fd2ab0c717/client/tests/phpunit/includes/ClientParserOutputDataUpdaterTest.php#170
  
  The fix should be as easy as doing what PHPUnit suggest.

TASK DETAIL
  https://phabricator.wikimedia.org/T247670

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Krinkle, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247595: Make Wikibase compatible with PHP 7.4

[Daimona]

Daimona added a comment.


  Now it should be compatible. Can we enable PHP74 tests as voting?

TASK DETAIL
  https://phabricator.wikimedia.org/T247595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Nikerabbit, MaxSem, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T243590: Fix WikibaseDataModel CI for php 7.4

[Daimona]

Daimona added a comment.


  In T243590#5962809 <https://phabricator.wikimedia.org/T243590#5962809>, 
@Jdforrester-WMF wrote:
  
  > Is this the same set of issues that emit errors in the CI run?
  
  Apparently, no. Filed T247595 <https://phabricator.wikimedia.org/T247595> for 
that.

TASK DETAIL
  https://phabricator.wikimedia.org/T243590

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Jdforrester-WMF, srishakatux, Reedy, Addshore, Aklapper, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Nikerabbit, MaxSem, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T247595: Make Wikibase compatible with PHP 7.4

[Daimona]

Daimona created this task.
Daimona added projects: PHP 7.4 support, Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  From T243590#5962809 <https://phabricator.wikimedia.org/T243590#5962809>:
  
00:18:23.529 There were 3 errors:
00:18:23.529 
00:18:23.529 1) 
Wikibase\Client\Tests\Api\ApiPropsEntityUsageTest::testEntityUsage with data 
set "by title" (array('query', 'entityusage', 'Vienna11|Berlin22'), 
array(array(array(array(array('O', 'S', array(array(array(array('S')), 
array(array('S'))
00:18:23.529 === Logs generated by test case
00:18:23.529 [localisation] [debug] LocalisationCache using store 
LCStoreNull []
00:18:23.529 [localisation] [debug] LocalisationCache using store 
LCStoreNull []
00:18:23.529 [MessageCache] [debug] MessageCache using store {class} 
{"class":"HashBagOStuff"}
00:18:23.529 [objectcache] [debug] MainWANObjectCache using store {class} 
{"class":"EmptyBagOStuff"}
00:18:23.529 ===
00:18:23.529 Trying to access array offset on value of type null
00:18:23.529 
00:18:23.529 /workspace/src/includes/api/ApiPageSet.php:127
00:18:23.529 
/workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/ApiPropsEntityUsageTest.php:117
00:18:23.529 
/workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/ApiPropsEntityUsageTest.php:164
00:18:23.529 
/workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/ApiPropsEntityUsageTest.php:226
00:18:23.529 
/workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
00:18:23.529 /workspace/src/maintenance/doMaintenance.php:99
00:18:23.529 
00:18:23.529 2) 
Wikibase\Client\Tests\Api\ApiPropsEntityUsageTest::testEntityUsage with data 
set "by entity" (array('query', 'entityusage', 'Vienna11|Berlin22', 'Q3|Q4'), 
array(array(array(array(array('O', 'S', array(array(array(array('S')), 
array(array('S'))
00:18:23.529 === Logs generated by test case
00:18:23.529 [objectcache] [debug] MainWANObjectCache using store {class} 
{"class":"EmptyBagOStuff"}
00:18:23.529 [localisation] [debug] LocalisationCache using store 
LCStoreNull []
00:18:23.529 [localisation] [debug] LocalisationCache using store 
LCStoreNull []
00:18:23.529 [MessageCache] [debug] MessageCache using store {class} 
{"class":"HashBagOStuff"}
00:18:23.529 [objectcache] [debug] MainWANObjectCache using store {class} 
{"class":"EmptyBagOStuff"}
00:18:23.529 ===
00:18:23.529 Trying to access array offset on value of type null
00:18:23.529 
00:18:23.529 /workspace/src/includes/api/ApiPageSet.php:127
00:18:23.529 
/workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/ApiPropsEntityUsageTest.php:117
00:18:23.529 
/workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/ApiPropsEntityUsageTest.php:164
00:18:23.529 
/workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/ApiPropsEntityUsageTest.php:226
00:18:23.529 
/workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
00:18:23.529 /workspace/src/maintenance/doMaintenance.php:99
00:18:23.529 
00:18:23.529 3) 
Wikibase\Client\Tests\Changes\ChangeRunCoalescerTest::testCoalesceChanges with 
data set "local link breaks" (array(Wikibase\Lib\Changes\ItemChange Object 
(...), Wikibase\Lib\Changes\ItemChange Object (...)), 
array(Wikibase\Lib\Changes\ItemChange Object (...), 
Wikibase\Lib\Changes\ItemChange Object (...)))
00:18:23.529 === Logs generated by test case
00:18:23.529 [objectcache] [debug] MainWANObjectCache using store {class} 
{"class":"EmptyBagOStuff"}
00:18:23.529 ===
00:18:23.529 
Wikibase\Client\Changes\ChangeRunCoalescer::coalesceRuns:array_key_exists(): 
Using array_key_exists() on objects is deprecated. Use isset() or 
property_exists() instead [Called from 
Wikibase\Client\Changes\ChangeRunCoalescer::coalesceRuns in 
/workspace/src/extensions/Wikibase/client/includes/Changes/ChangeRunCoalescer.php
 at line 287]
00:18:23.529 
00:18:23.529 /workspace/src/includes/debug/MWDebug.php:333
00:18:23.529 /workspace/src/includes/debug/MWDebug.php:188
00:18:23.529 /workspace/src/includes/GlobalFunctions.php:1068
00:18:23.529 
/workspace/src/extensions/Wikibase/client/includes/Changes/ChangeRunCoalescer.php:287
00:18:23.529 
/workspace/src/extensions/Wikibase/client/includes/Changes/ChangeRunCoalescer.php:80
00:18:23.529 
/workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Changes/ChangeRunCoalescerTest.php:386
00:18:23.529 
/workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
00:18:23.529 /workspace/src/maintenance/doMaintenance.php:99

TASK DETAIL
  https://phabricator.wikimedia.org/T247595

EMAIL PREFERENCES
  https://phabricator.wik

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

[Daimona]

Daimona added a comment.


  That change is not responsible, but the extension is broken: 
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/47112/artifact/log/mw-error.log

TASK DETAIL
  https://phabricator.wikimedia.org/T245629

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde, pdehaye, Nandana, 
Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, 
LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, 
Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, 
Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

[Daimona]

Daimona added a comment.


  In T237164#5896034 <https://phabricator.wikimedia.org/T237164#5896034>, 
@Addshore wrote:
  
  > It looks like that was removed in 
https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/552166/ but not linked to 
this ticket.
  
  Ah, thanks, I forgot about that step.
  
  > And then this starts becoming messier
  
  +1
  
  > I'd propose we also restore this require-dev in the core composer.json for 
now pinned to the same version as in Wikibase, essentially restoring the way 
things were.
  
  And +1, let's restore the status quo.

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, Daimona
Cc: Rosalie_WMDE, Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, 
Aklapper, MaxSem, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

[Daimona]

Daimona added a comment.


  For some reason, cache/integration-tests is not being installed, see 
https://integration.wikimedia.org/ci/job/wikibase-repo-docker/11815/console. 
This used to work before the test was disabled.
  
  Also, the library is currently broken: its public interface is using 
symfony/phpunit-bridge, but it's listed in `require-dev` instead of `require`, 
see https://github.com/php-cache/integration-tests/pull/107. I believe we had 
discussed this briefly on gerrit at the time, and agreed that disabling the 
test was the best solution for the time being.

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, Daimona
Cc: Rosalie_WMDE, Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, 
Aklapper, MaxSem, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

[Daimona]

Daimona added a comment.


  In T243296#5829712 <https://phabricator.wikimedia.org/T243296#5829712>, 
@Addshore wrote:
  
  > I'm going to go around and update this in various places that it is used.
  
  I can help with review.
  
  > Also going forward we will consider if we even want this seperate library 
or if this should be merged into the mediawiki bit
  
  Note that there might be two separate discussions: 1-whether we want a 
separate *repository*, 2-whether we want a separate *ruleset*. We can merge the 
repositories while keeping a standalone config for WB, which IMHO requires less 
discussion and is a good idea to make it happen.

TASK DETAIL
  https://phabricator.wikimedia.org/T243296

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore, Daimona
Cc: Addshore, Legoktm, thiemowmde, WMDE-leszek, Lucas_Werkmeister_WMDE, 
Daimona, Ladsgroup, Jdforrester-WMF, Aklapper, MaxSem, Iflorez, darthmon_wmde, 
alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

[Daimona]

Daimona added a comment.


  In T237164#5827203 <https://phabricator.wikimedia.org/T237164#5827203>, 
@Jdforrester-WMF wrote:
  
  > Is this going anywhere, or are we just going to leave it disabled forever?
  
  I guess it's going to sit in the bitrot limbo until a new version is released 
upstream. Which, in turn, seems implausible, judging from the last commit dates 
and the open issues/PRs.

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, MaxSem, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

[Daimona]

Daimona added a comment.


  Not if we move the main ruleset file per T243296#5826268 
<https://phabricator.wikimedia.org/T243296#5826268>. And, of course, unless it 
turns out to be impossible to have two different rulesets in MW-CS.

TASK DETAIL
  https://phabricator.wikimedia.org/T243296

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Legoktm, thiemowmde, WMDE-leszek, Lucas_Werkmeister_WMDE, Daimona, 
Ladsgroup, Jdforrester-WMF, Aklapper, MaxSem, darthmon_wmde, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

[Daimona]

Daimona added a comment.


  In T243296#5826260 <https://phabricator.wikimedia.org/T243296#5826260>, 
@Lucas_Werkmeister_WMDE wrote:
  
  > (Unless “Move the WB ruleset to MW-CS” includes disabling those rules for 
all of MW-CS?)
  
  Sort of, yes. I believe it's possible to have two different rulesets, and 
choose which one to use. WB repos would still point to the same ruleset, just 
at another location.

TASK DETAIL
  https://phabricator.wikimedia.org/T243296

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Legoktm, thiemowmde, WMDE-leszek, Lucas_Werkmeister_WMDE, Daimona, 
Ladsgroup, Jdforrester-WMF, Aklapper, MaxSem, darthmon_wmde, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

[Daimona]

Daimona added a comment.


  In T243296#5821602 <https://phabricator.wikimedia.org/T243296#5821602>, 
@Legoktm wrote:
  
  > I think we could ship it inside the MediaWiki-Codesniffer repo so it 
doesn't fall behind at least.
  
  I think this is a great idea to get started with. I guess the plan would be 
to:
  
  - Export WB sniffs to MW-CS (the ones that we want to keep)
  - Move the WB ruleset to MW-CS
  - Archive the WB-CS repo
  - For each repo using WB-CS:
- composer: remove WB-CS, add MW-CS
- .phpcs.xml: load the WB ruleset from the new location

TASK DETAIL
  https://phabricator.wikimedia.org/T243296

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Legoktm, thiemowmde, WMDE-leszek, Lucas_Werkmeister_WMDE, Daimona, 
Ladsgroup, Jdforrester-WMF, Aklapper, MaxSem, darthmon_wmde, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T243296: Release a new version of WikibaseCodeSniffer

[Daimona]

Daimona added subscribers: Ladsgroup, Daimona.
Daimona added a comment.


  CC @Ladsgroup as releaser of the last two versions and (AFAICS) most active 
maintainer.

TASK DETAIL
  https://phabricator.wikimedia.org/T243296

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Ladsgroup, Jdforrester-WMF, Aklapper, MaxSem, darthmon_wmde, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
Lethexie, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, thiemowmde, 
Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Raised Priority] T243122: Math master is currently broken due to a Wikibase change

[Daimona]

Daimona raised the priority of this task from "Medium" to "Unbreak Now!".
Daimona added a comment.


  In T243122#5814763 <https://phabricator.wikimedia.org/T243122#5814763>, 
@Physikerwelt wrote:
  
  > I think this is not ubn. Why not disable the test?
  
  Because it's not a faulty test: there's a signature mismatch, and it will 
produce a PHP warning (at least) as soon as the file is loaded. I believe this 
is enough to qualify as train blocker, hence ubn.

TASK DETAIL
  https://phabricator.wikimedia.org/T243122

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Physikerwelt, Liuxinyu970226, RhinosF1, Reedy, Aklapper, Daimona, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Maosef, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, 
aude, fredw, Pkra, scfc, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T243124: Class "Wikibase\Lib\Store\EntityTitleLookup" does not exist.

[Daimona]

Daimona added a project: MediaWiki-extensions-PropertySuggester.

TASK DETAIL
  https://phabricator.wikimedia.org/T243124

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Aklapper, Reedy, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Sjoerddebruin, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T243122: Math master is currently broken due to a Wikibase change

[Daimona]

Daimona added a parent task: T233864: 1.35.0-wmf.16 deployment blockers.

TASK DETAIL
  https://phabricator.wikimedia.org/T243122

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Aklapper, Daimona, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Maosef, QZanden, LawExplorer, Debenben, _jensen, rosalieper, Scott_WUaS, Izno, 
Wikidata-bugs, aude, fredw, Physikerwelt, Pkra, scfc, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T243122: Math master is currently broken due to a Wikibase change

[Daimona]

Daimona created this task.
Daimona added projects: Math, Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  As observed in r565622 
<https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Math/+/565622/>, tests 
currently fail on Math because of:
  
  > PHP Fatal error:  Declaration of 
MathMLRdfBuilder::addValue(Wikimedia\Purtle\RdfWriter $writer, 
$propertyValueNamespace, $propertyValueLName, $dataType, 
Wikibase\DataModel\Snak\PropertyValueSnak $snak) must be compatible with 
Wikibase\Rdf\ValueSnakRdfBuilder::addValue(Wikimedia\Purtle\RdfWriter $writer, 
$propertyValueNamespace, $propertyValueLName, $dataType, $snakNamespace, 
Wikibase\DataModel\Snak\PropertyValueSnak $snak) in 
/workspace/src/extensions/Math/src/MathMLRdfBuilder.php on line 7
  
  This failure is clearly not spurious, and was caused by r533202 
<https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/533202/> 
for Wikibase. I'm unsure what the fix is [1], but either way, this needs to be 
fixed before the next train.
  
  [1] - Maybe just adding that extra parameter would suffice, but I'm no 
confident enough with Wikibase to know if that's true.

TASK DETAIL
  https://phabricator.wikimedia.org/T243122

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Aklapper, Daimona, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Maosef, QZanden, LawExplorer, Debenben, _jensen, rosalieper, Scott_WUaS, Izno, 
Wikidata-bugs, aude, fredw, Physikerwelt, Pkra, scfc, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T240884: Standalone service to evaluate user-provided regular expressions

[Daimona]

Daimona added a comment.


  In T240884#5810160 <https://phabricator.wikimedia.org/T240884#5810160>, 
@sbassett wrote:
  
  > In T240884#5810094 <https://phabricator.wikimedia.org/T240884#5810094>, 
@Ladsgroup wrote:
  >
  >> One complicating factor here is that AbuseFilter and SpamBlacklist both 
don't have a clear maintainer.
  >
  > I think @Daimona is understood to be the de facto AF maintainer these days 
(trusted dev, wmf-NDA, etc.) and is pretty active 
<https://gerrit.wikimedia.org/r/q/project:mediawiki%252Fextensions%252FAbuseFilter>
 in its current development.
  
  So, I'm going to answer for myself. I think a re2-like solution would indeed 
improve performance [1] for regexps-related extensions. AbuseFilter and 
SpamBlacklist for sure, but also TitleBlacklist, and CentralAuth as of T101615 
<https://phabricator.wikimedia.org/T101615>. Given the number of possible 
consumers, I believe that a reusable service would be the best choice.
  
  Of note, there's also T187669 <https://phabricator.wikimedia.org/T187669> 
about adding a static ReDoS validator, in case you want to explore it as an 
alternative.
  
  [1] - About AbuseFilter performance, some numbers are on grafana 
<https://grafana.wikimedia.org/d/00393/mediawiki-abusefilter-profiling?orgId=1>,
 and there's also a dashboard 
<https://logstash.wikimedia.org/app/kibana#/dashboard/941a0560-b9b2-11e7-a3f7-cb9288bcae84?_g=h@1251ff0&_a=h@cf77ba6>
 on logstash, although regexps aren't the only responsible for slowness.

TASK DETAIL
  https://phabricator.wikimedia.org/T240884

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, daniel, tstarling, Bawolff, Joe, WMDE-leszek, Volans, sbassett, 
Krinkle, Agabi10, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
darthmon_wmde, DannyS712, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, 
RazeSoldier, QZanden, LawExplorer, _jensen, rosalieper, D3r1ck01, Scott_WUaS, 
Izno, SBisson, Perhelion, Wikidata-bugs, Base, aude, GWicke, jayvdb, fbstj, 
santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T241947: Stop using $wgUser in Wikibase

[Daimona]

Daimona added a comment.


  In T241947#5802594 <https://phabricator.wikimedia.org/T241947#5802594>, 
@Addshore wrote:
  
  > Well, RequestContext::getMain is slightly less evil that the global 
probably.
  
  Yeah, well, a little bit... I believe the only difference is that, when using 
RequestContext, any piece of code writing to $wgUser and 
RequestContext::getMain only has to write to the latter. Aside from this, 
they're the same thing 
<https://gerrit.wikimedia.org/g/mediawiki/core/+/0ff789715c7e9d4a560bf26242072ad4cb2aea10/includes/Setup.php#837>.
  
  > So I'd go for lets just make that patch and hen resolve this task for now :)
  > If someone wants to get rid of RequestContext::getMain then that is a whole 
different kettle of fish to tackle later down the line.
  
  Sure :) In places where a User object can be injected, I believe that it's 
not worth it to use RequestContext::getMain now, and replace it with proper DI 
later. But, where there's no clear way to inject a User, I think 
RequestContext::getMain is acceptable.

TASK DETAIL
  https://phabricator.wikimedia.org/T241947

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Addshore, Daimona, Aklapper, Chaytanya, darthmon_wmde, DannyS712, Nandana, 
Kieubinhtb, Guilhermebm, Mh-3110, Amorymeltzer, Asad_Ali_Palijo, Lahi, Gq86, 
GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, 
JakeTheDeveloper, QZanden, LawExplorer, _jensen, rosalieper, D3r1ck01, 
Scott_WUaS, Jonas, MuhammadShuaib, Izno, MGChecker, Tmalhotra, SimmeD, 
Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T241947: Stop using $wgUser in Wikibase

[Daimona]

Daimona added a comment.


  In T241947#5802562 <https://phabricator.wikimedia.org/T241947#5802562>, 
@Addshore wrote:
  
  > In T241947#5776623 <https://phabricator.wikimedia.org/T241947#5776623>, 
@Daimona wrote:
  >
  >> Note: there are two usages in the entry point which I'm unsure how to fix.
  >
  > I guess they could come from "Context".
  > I don't obviously see anything else in core that could be used at this 
second.
  > Which would mean something like:
  >
  >   RequestContext::getMain()->getUser()
  >
  > In place of the global
  
  Yeah, that's also the only alternative I can think of, given how early the 
entry point is executed. Given that RequestContext::getMain is almost the same 
as $wgUser, I'd suggest waiting; in case some new code introduces an 
alternative...

TASK DETAIL
  https://phabricator.wikimedia.org/T241947

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Addshore, Daimona, Aklapper, Chaytanya, darthmon_wmde, DannyS712, Nandana, 
Kieubinhtb, Guilhermebm, Mh-3110, Amorymeltzer, Asad_Ali_Palijo, Lahi, Gq86, 
GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, 
JakeTheDeveloper, QZanden, LawExplorer, _jensen, rosalieper, D3r1ck01, 
Scott_WUaS, Jonas, MuhammadShuaib, Izno, MGChecker, Tmalhotra, SimmeD, 
Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T241947: Stop using $wgUser in Wikibase

[Daimona]

Daimona added a comment.


  Note: there are two usages in the entry point which I'm unsure how to fix.

TASK DETAIL
  https://phabricator.wikimedia.org/T241947

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, 
Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Izno, MGChecker, Wikidata-bugs, aude, Dinoguy1000, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T241947: Stop using $wgUser in Wikibase

[Daimona]

Daimona created this task.
Daimona added projects: Technical-Debt (Deprecation process), 
MediaWiki-extensions-WikibaseRepository.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION


TASK DETAIL
  https://phabricator.wikimedia.org/T241947

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, darthmon_wmde, DannyS712, Nandana, Amorymeltzer, Lahi, 
Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Izno, MGChecker, Wikidata-bugs, aude, Dinoguy1000, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T239265: Special:Diff: Bad value for parameter $title: invalid name 'Diff/1_'

[Daimona]

Daimona edited projects, added MediaWiki-Special-pages; removed Wikidata, 
MediaWiki-extensions-Diff.

TASK DETAIL
  https://phabricator.wikimedia.org/T239265

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Aklapper, Daimona, Amorymeltzer, Lsherwinforone, Jayprakash12345, 
Sethakill, Wong128hk, Jdforrester-WMF, Rxy, Jay8g, Krenair, darthmon_wmde, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T239265: Special:Diff: Bad value for parameter $title: invalid name 'Diff/1_'

[Daimona]

Daimona created this task.
Daimona added projects: Wikimedia-production-error, MediaWiki-extensions-Diff.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  Error
  -
  
  `MediaWiki version:`  **`1.35.0-wmf.5`**
  
  name=message
[Xd1zIQpAAD0AAH@TyZMAAACC] /wiki/Speciale:Diff   
Wikimedia\Assert\ParameterAssertionException from line 63 of 
/srv/mediawiki/php-1.35.0-wmf.5/vendor/wikimedia/assert/src/Assert.php: Bad 
value for parameter $title: invalid name 'Diff/1_'
  
  
  
  Impact
  --
  
  The page fatals. Instead, it should fail gracefully and inform the user that 
the input is invalid (or trim the input).
  
  Notes
  -
  
  Can be triggered by heading to Special:Diff, then paste something ending with 
a space (e.g. "1 ") in "Revision ID of difference" and hit "Show differences". 
As I wrote above, it should either fail gracefully, or (probably better) trim 
the input.

TASK DETAIL
  https://phabricator.wikimedia.org/T239265

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Aklapper, Daimona, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T235326: Wikibase PHPUnit tests are broken

[Daimona]

Daimona closed this task as "Resolved".
Daimona removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T235326

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Ladsgroup, Lucas_Werkmeister_WMDE, thiemowmde, Aklapper, Daimona, 
darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, 
CucyNoiD, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, WSH1906, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs