Re: [Wikitech-l] MediaWiki Supported Browser List
On Sat, May 7, 2011 at 2:23 PM, Andrew Garrett agarr...@wikimedia.org wrote: What does this mean? i believe that might a comment regarding tables having a border defined in html or not. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r87482]: New comment added
User Duplicatebug posted a comment on MediaWiki.r87482. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87482#c16648 Commit summary: * Fix for bug 28534: IE 6 content type detection again * Fix for bug 28639: user object instance cache pollution * Release notes formatting tweak. Comment: preg_match( '/\.[^\\/:*?|%]+(#|\?|$)/i', 'load.php' ); is true. That breaks the loading of stylesheets in some cases for IE. For example bug 28840 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87482]: Revision status changed
User MaxSem changed the status of MediaWiki.r87482. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87482#c0 Commit summary: * Fix for bug 28534: IE 6 content type detection again * Fix for bug 28639: user object instance cache pollution * Release notes formatting tweak. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87212]: New comment added
User Duplicatebug posted a comment on MediaWiki.r87212. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87212#c16649 Commit summary: Added wgIsMainPage (Title-isMainPage) to mw.config * Instead of ugly javascript construction to compare href-attributes or re-constructing proper pagenames, let's use Title-isMainPage which does this much better * Kept function for compatibility. mw.util.isMainPage() was never released, should probably be removed before 1.18 branch point. Comment: isMainPage() handles also isRelatedToMainpage, which is now missing ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87573]: Revision status changed
User Bryan changed the status of MediaWiki.r87573. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87573#c0 Commit summary: More __ for r87572 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87585]: Revision status changed
User Bryan changed the status of MediaWiki.r87585. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87585#c0 Commit summary: using wfScript() instead of hard-coding api.php, which also gets us the right path. This improves on r87575 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87518]: New comment added
User Bryan posted a comment on MediaWiki.r87518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87518#c16650 Commit summary: start branching 1.18 Comment: CodeReview needs a like button for revisions like this! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87619]: New comment added, and revision status changed
User Jeroen De Dauw changed the status of MediaWiki.r87619. Old Status: new New Status: ok User Jeroen De Dauw also posted a comment on MediaWiki.r87619. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87619#c16651 Commit summary: Followup r87605/r8760: Make description of userright consistent with existing messages Comment: Cool, thanks! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87521]: Revision status changed
User DieBuche changed the status of MediaWiki.r87521. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87521#c0 Commit summary: removing jquery.elastic since you get this for free with jquery.ui.dialog ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87212]: New comment added
User Krinkle posted a comment on MediaWiki.r87212. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87212#c16652 Commit summary: Added wgIsMainPage (Title-isMainPage) to mw.config * Instead of ugly javascript construction to compare href-attributes or re-constructing proper pagenames, let's use Title-isMainPage which does this much better * Kept function for compatibility. mw.util.isMainPage() was never released, should probably be removed before 1.18 branch point. Comment: That's correct. However this method was never released in any stable release, or any beta or release-candidate. So compatibility should not be an issue as much. Besides, the isRelatedToMainpage was buggy at best, and the way I did it wasn't very pretty either. Nor was it requested via BugZilla, if you think such functionality would be useful, feel free to open a ticket and be sure to refer to this revision and leave an example usecase as well :). Thanks! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83786]: New comment added, and revision status changed
User Happy-melon changed the status of MediaWiki.r83786. Old Status: fixme New Status: new User Happy-melon also posted a comment on MediaWiki.r83786. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83786#c16653 Commit summary: Divert a river through the Augean Stables that is SpecialBlockip.php. * Move to SpecialBlock.php, and rename class appropriately * Complete refactor * Use HTMLForm in block form. This changes most of the ids and field names on the form, but allows proper validation, nicer formatting, clears up several fixmes, and is generally Better(TM). * Spin various parts out into static functions, several of which properly belong in the backend (but Block.php is a worse mess still) * Invert some of the block options so that every checkbox makes the block more severe (so check to disable email is fine, but check to allow usertalk edit (default true) is inverted to check to disable usertalk edit (default false). * revert r40359 (move doMassUserBlock() to core). No one seems to be using this function, which has nothing to do with the frontend UI in SpecialBlock (it might perhaps belong in Block.php); it is pretty bespoke for CheckUser, doesn't seem to have very much utility elsewhere. Comment: ''Exposes'' bug 28797, more like. Fixed in r87627. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81414]: New comment added
User Krinkle posted a comment on MediaWiki.r81414. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81414#c16654 Commit summary: Test suite for revisions and date related magic variables. Tests should be carefully reviewed, please note there is are exceptions for 'revisionday' and 'revisionmonth1' magics which are hardcoded in the parser to return an integer. Follow up r66200 TESTS: $ php phpunit.php -c suite.xml --filter MagicVariable --testdox PHPUnit 3.5.10 by Sebastian Bergmann. MagicVariable [x] Currentday is un padded [x] Currentdaytwo is zero padded [x] Localday is un padded [x] Localdaytwo is zero padded [x] Currentmonth is zero padded [x] Currentmonthone is un padded [x] Localmonth is zero padded [x] Localmonthone is un padded [x] Revisionday is un padded [x] Revisiondaytwo is zero padded [x] Revisionmonth is zero padded [x] Revisionmonthone is un padded $ Comment: Removing 1.18 (which is the tag to MFT to branches/REL1_18). See [[CodeReview Tags]] ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87628]: New comment added
User Bryan posted a comment on MediaWiki.r87628. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87628#c16655 Commit summary: (bug 28834) Restore nl2br() wrappers removed in r85918. Comment: Shouldn't the second parameter of nl2br ($is_xhtml) be set, depending on $wgWellFormedXml? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87621]: Revision status changed
User Bryan changed the status of MediaWiki.r87621. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87621#c0 Commit summary: Notice: Use of undefined constant GAID_FOR_UPDATE - assumed 'GAID_FOR_UPDATE' in D:\www\MW_trunk\phase3\includes\Title.php on line 3085 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87470]: Revision status changed
User Bryan changed the status of MediaWiki.r87470. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87470#c0 Commit summary: Likely that nobody is calling getPath() on a ForeignAPI repo, but best to warn them anyway. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87357]: New comment added, and revision status changed
User Bryan changed the status of MediaWiki.r87357. Old Status: ok New Status: fixme User Bryan also posted a comment on MediaWiki.r87357. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87357#c16656 Commit summary: (bug 19408) user_properties.up_property: 32 bytes is not enough. Increased it to 255 bytes to be like page titles Some minor tweaks to modifyField() in the installer to make it more useful and added insertUpdateRow() Comment: Sqlite does not support ALTER TABLE MODIFY, but it doesn't need it in this case, because varchars are converted to TEXT columns, which don't have a maximum length. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87261]: New comment added, and revision status changed
User Bryan changed the status of MediaWiki.r87261. Old Status: new New Status: fixme User Bryan also posted a comment on MediaWiki.r87261. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87261#c16657 Commit summary: A few minor RSD changes Comment: I don't think this is correct. The protocol states that ''engineLink is the URL to the home of the engine''. The engine is MediaWiki, so it should really just link to the MW home page. Furthermore, ''homePageLink is the URL of the users homepage'', so that should in fact link to Title::newMainPage()-getFullUrl(). See also the example in the protocol: pre engineNameBlog Munging CMS/engineName engineLinkhttp://www.blogmunging.com/ /engineLink homePageLinkhttp://www.userdomain.com/ /homePageLink /pre http://tales.phrasewise.com/rfc/rsd ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87629]: Revision status changed
User Jeroen De Dauw changed the status of MediaWiki.r87629. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87629#c0 Commit summary: Followup r87625: Register alias file for translate ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86766]: Revision status changed
User Bryan changed the status of MediaWiki.r86766. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86766#c0 Commit summary: Simplify a bit to make nicer links: Special:ListFiles/Username ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87261]: Revision status changed
User Reedy changed the status of MediaWiki.r87261. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87261#c0 Commit summary: A few minor RSD changes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86363]: New comment added
User Bryan posted a comment on MediaWiki.r86363. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86363#c16658 Commit summary: Apply LoadBalancer related fixes Patches by Yuvi Panda From (bug 28583) Remove all /* private */ declarations in MediaWiki core Comment: You could use a negative number instead of 1234, or even a non-numeric string. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87628]: New comment added
User Happy-melon posted a comment on MediaWiki.r87628. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87628#c16659 Commit summary: (bug 28834) Restore nl2br() wrappers removed in r85918. Comment: No because a) the parameter was added in PHP 5.3 and so may not be available, and (more importantly) b) wfDie() does not assume that it is able to access the value of tt$wgWellFormedXml/tt in either LocalSettings or DefaultSettings, and so unconditionally outputs an ttXHTML 1.0 Transitional/tt doctype, regardless of the general state of the wiki. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80792]: New comment added
User Helder.wiki posted a comment on MediaWiki.r80792. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/80792#c16660 Commit summary: adding links to other skins in mediaWiki JS test suite. (Previously making sure everything works in all skins was a PITA Comment: wgPageName -- mw.config.get( 'wgPageName' ) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] integration of MediaWiki and version control system as backend?
The problem is that we want a CVS-like interface, with per-article versioning. Only a few operations would be cross-article (renaming, moving sections to a different article...) and we don't have a way to express transactions anyway. There's no global status of the code to keep. The articles should be freely modifiable concurrently. Using something like stock git we would end up with almost a branch per article. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r80572]: New comment added
User Helder.wiki posted a comment on MediaWiki.r80572. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/80572#c16661 Commit summary: Fix bug in mw.Map + fix bug 26801 + wrapper mediawiki.special.upload.js * Map.prototype.exists was checking the type of the wrong variable. Fixed now, checking multiple at once is now possible (as documented) * bug 26801: No references to legacy globals, use mw.config everywhere in core (grep search for 'wg' in /resources returned only * Addressed some JS Lint warnings (combining var statements, faster and less code); * Removed trailing tabs and spaces Comment: == 'Blankpage' -- === 'Blankpage' ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87542]: Revision status changed
User Reedy changed the status of MediaWiki.r87542. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87542#c0 Commit summary: Followup r87541 Move RELEASE-NOTES to HISTORY ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added, and revision status changed
User Happy-melon changed the status of MediaWiki.r85918. Old Status: fixme New Status: new User Happy-melon also posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c16662 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the three major entry points (index.php, api.php, load.php) back to PHP 4.4.9. We don't care what happens if you actually try to run these files on old versions, but the entry files need to parse correctly. * consign /includes/templates/PHP4.php and /includes/templates/NoLocalSettings.php to the fiery pit of hell where they belong. * Prevent loading of any other files for PHP 5. WebStart.php was rendered unparseable in PHP 4 by the introduction of try/catch blocks in r85327. * Die outright with a pretty error message on PHP 5.2.3 as well as PHP 4. All versions of PHP below that throw parse errors of various sorts. * Reimplement wfDie() to provide an entry-point-dependent die-with-readable-error-message function (for instance, we want a pretty human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment block in load.php, etc). * Standardise the appearance of the catastrophic errors thrown at the top of the stack with the ones lower down (exception-within-exception, etc). There isn't really a way to do this without duplication, AFAICT. Comment: Fixed in r87628. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86273]: Revision status changed
User Happy-melon changed the status of MediaWiki.r86273. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86273#c0 Commit summary: Follow-up r85929: update MediaWiki::articleFromTitle() calls in extensions (and a few edgecases which were missed in core) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87637]: New comment added, and revision status changed
User Siebrand changed the status of MediaWiki.r87637. Old Status: new New Status: fixme User Siebrand also posted a comment on MediaWiki.r87637. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87637#c16663 Commit summary: Centralise the minimum-required-php-version in a MW_MIN_PHP_VERSION constant in Defines.php. This requires loading Defines.php before the PHP4 version checks, so include a big note reminding people not to include anything other than vanilla define() statements in there. I have a sneaking suspicion that including Defines.php in the entry points might not play nicely with HipHop, but I can't test it (wrong OS). Comment: PHP Warning: require_once(/www/w/maintenance/includes/Defines.php): failed to open stream: No such file or directory in /www/w/maintenance/Maintenance.php on line 24 PHP Fatal error: require_once(): Failed opening required '/www/w/maintenance/includes/Defines.php' (include_path='.:/usr/share/php:/usr/share/pear') in /www/w/maintenance/Maintenance.php on line 24 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added, and revision status changed
User Happy-melon changed the status of MediaWiki.r86041. Old Status: fixme New Status: new User Happy-melon also posted a comment on MediaWiki.r86041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c16664 Commit summary: r86001, now with less scariness :P I took out the delete action and did purge instead, which is a much more self-contained action-with-a-form. Also implement a few changes suggested by Brion on IRC last night. Comment: Added in r87642. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87637]: Revision status changed
User Happy-melon changed the status of MediaWiki.r87637. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87637#c0 Commit summary: Centralise the minimum-required-php-version in a MW_MIN_PHP_VERSION constant in Defines.php. This requires loading Defines.php before the PHP4 version checks, so include a big note reminding people not to include anything other than vanilla define() statements in there. I have a sneaking suspicion that including Defines.php in the entry points might not play nicely with HipHop, but I can't test it (wrong OS). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87635]: New comment added
User Nikerabbit posted a comment on MediaWiki.r87635. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87635#c16665 Commit summary: * Implement MW_VERSION constant in Defines.php and use it in preference to $wgVersion. Defines.php will have been loaded anywhere that DefaultSettings.php has been loaded. * Move the declaration of $wgFeedClasses from Defines.php to WebStart.php Comment: -1. It's harder to change constant than variable. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87635]: New comment added
User Happy-melon posted a comment on MediaWiki.r87635. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87635#c1 Commit summary: * Implement MW_VERSION constant in Defines.php and use it in preference to $wgVersion. Defines.php will have been loaded anywhere that DefaultSettings.php has been loaded. * Move the declaration of $wgFeedClasses from Defines.php to WebStart.php Comment: When would you ever want to dynamically change the variable describing the MW version?!? The fact that it's immutable is a strength, not a weakness, less chance of it getting accidentally overwritten. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87635]: New comment added
User Nikerabbit posted a comment on MediaWiki.r87635. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87635#c16667 Commit summary: * Implement MW_VERSION constant in Defines.php and use it in preference to $wgVersion. Defines.php will have been loaded anywhere that DefaultSettings.php has been loaded. * Move the declaration of $wgFeedClasses from Defines.php to WebStart.php Comment: People who run modified version of MediaWiki? People who want to fake the version for unknown reasons? Why is everyone breaking threading when responding to first comment? Bad ui I guess. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87543]: New comment added
User Nikerabbit posted a comment on MediaWiki.r87543. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87543#c16668 Commit summary: Fix 2 more 1.18's from RELEASE-NOTES in r87542 Comment: The latter part deliberate or not? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] RFC: Change of RELEASE-NOTES location for trunk
I have gone ahead and renamed them in r87633 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r87587]: New comment added
User Siebrand posted a comment on MediaWiki.r87587. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87587#c16669 Commit summary: Kill $wgRateLimitsExcludedGroups which was deprecated in 1.13 Comment: Should this type of change be in RELEASE-NOTES? Not sure what my opinion is. I do recognise however that it's not always clear to me which when to include something or not... Are there any guidelines? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87635]: New comment added
User ^demon posted a comment on MediaWiki.r87635. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87635#c16670 Commit summary: * Implement MW_VERSION constant in Defines.php and use it in preference to $wgVersion. Defines.php will have been loaded anywhere that DefaultSettings.php has been loaded. * Move the declaration of $wgFeedClasses from Defines.php to WebStart.php Comment: +1 on reverting $wgVersion as a constant. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87587]: New comment added
User ^demon posted a comment on MediaWiki.r87587. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87587#c16671 Commit summary: Kill $wgRateLimitsExcludedGroups which was deprecated in 1.13 Comment: When it doubt, it goes in the RELEASE-NOTES. This should definitely be there, since we're removing back-compat. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87587]: New comment added, and revision status changed
User Siebrand changed the status of MediaWiki.r87587. Old Status: new New Status: fixme User Siebrand also posted a comment on MediaWiki.r87587. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87587#c16672 Commit summary: Kill $wgRateLimitsExcludedGroups which was deprecated in 1.13 Comment: Then reedy will, unfortunately, have to get busy updating the release notes for many more revs - he's been doing a lot of work on it (thanks Sam!) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87587]: New comment added, and revision status changed
User Siebrand changed the status of MediaWiki.r87587. Old Status: fixme New Status: ok User Siebrand also posted a comment on MediaWiki.r87587. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87587#c16673 Commit summary: Kill $wgRateLimitsExcludedGroups which was deprecated in 1.13 Comment: Ugh. Fixed in r87604. Please use the follow-up revs, Sam :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r77374]: New comment added
User Siebrand posted a comment on MediaWiki.r77374.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/77374#c16674
Commit summary:
(bug 25638) Allow manual associating and dissociating of follow-up revisions in
CodeReview. This has a bug: you have to click the Associate button to submit an
association, pressing Enter in the text box won't work. I'll fix that soon.
* Enforce causality of references (i.e. a revision cannot be a follow-up to
itself or to a revision in its future) in getReferences() and addReferences()
* Move code adding associations ('references' in the code) in
CodeRevision::save() to addReferences() and add removeReferences()
* UI for this thing is similar to the one for sign-offs and in accordance with
Trevor's mockup on the bug. Needs some more input from Trevor though
* Changed follow-ups table to always show, even if there are no follow-ups.
This is needed so people can associate new follow-ups to a revision that
doesn't have any yet
Comment:
Nice feature. Used it for the first time today. I think the rev log should be
updated when a revision if associated or disassociated manually, as is done for
example for adding/removing tags.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87635]: Revision status changed
User Siebrand changed the status of MediaWiki.r87635. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87635#c0 Commit summary: * Implement MW_VERSION constant in Defines.php and use it in preference to $wgVersion. Defines.php will have been loaded anywhere that DefaultSettings.php has been loaded. * Move the declaration of $wgFeedClasses from Defines.php to WebStart.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87644]: New comment added, and revision status changed
User Platonides changed the status of MediaWiki.r87644. Old Status: new New Status: ok User Platonides also posted a comment on MediaWiki.r87644. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87644#c16675 Commit summary: Sigh, syntax terror in r87640 Comment: I was unable to find the commas before the double arrows. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87635]: New comment added
User Happy-melon posted a comment on MediaWiki.r87635. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87635#c16676 Commit summary: * Implement MW_VERSION constant in Defines.php and use it in preference to $wgVersion. Defines.php will have been loaded anywhere that DefaultSettings.php has been loaded. * Move the declaration of $wgFeedClasses from Defines.php to WebStart.php Comment: Anyone running a modified version of MW can and should hack the version number along with whatever else they've changed, precisely ''so that'' it gets reverted along with any other changes if they do an upgrade without repatching. Updating the version via LocalSettings, which won't get overwritten by an upgrade, and the code via core hacks which will, is asking for (more than the usual amount of) trouble. I can see merit in a ttwfGetVersionText()/tt function which can be hooked to change the display on things like Special:Version and the meta generator tag, but being able to fudge ttversion_compare()/tt calls is neither big nor clever. ttMW_VERSION/tt summarises the state of the other 714,000 lines of code in MW core, version comparisons exist to stop Bad Things™ happening when those structures don't match up with what external code expects to see. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87212]: New comment added
User Duplicatebug posted a comment on MediaWiki.r87212. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87212#c16677 Commit summary: Added wgIsMainPage (Title-isMainPage) to mw.config * Instead of ugly javascript construction to compare href-attributes or re-constructing proper pagenames, let's use Title-isMainPage which does this much better * Kept function for compatibility. mw.util.isMainPage() was never released, should probably be removed before 1.18 branch point. Comment: No problem, I do not think, it is necessary. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84058]: New comment added
User Bawolff posted a comment on MediaWiki.r84058. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84058#c16678 Commit summary: Add an hourcount parameter to limit results returned to those added to the category in the last X hours. the guidelines for news sitemaps indicate they should only have stuff from the last 48 hours. Parameter is off by default. Comment: Specifying any of '0', '-1', or any non-numeric string disables it. Users can just specify ?hourcount=none to disable that, since its a non-numeric string. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87649]: Revision status changed
User Reedy changed the status of MediaWiki.r87649. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87649#c0 Commit summary: Adding my USERINFO file. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87626]: Revision status changed
User Reedy changed the status of MediaWiki.r87626. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87626#c0 Commit summary: some work on db schema ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87645]: New comment added
User Reedy posted a comment on MediaWiki.r87645. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87645#c16679 Commit summary: Followup r87578: PHP Notice: Use of Linker::makeLinkObj is deprecated. [Called from call_user_func_array in (internal function)] for /w/i.php?title=Special:RecentChangestranslations=filterul li- line - calls Linker::makeLinkObj()/li liSkin.php line 1552 calls call_user_func_array()/li li- line - calls Skin::__call()/li liRenameuser.php line 58 calls SkinVector::makeLinkObj()/li li- line - calls wfRenameUserLogActionText()/li Comment: Hmm. I only obviously found 3 in extensions, hence marking it as such. BLEH ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87664]: Revision status changed
User Reedy changed the status of MediaWiki.r87664. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87664#c0 Commit summary: Fix typos. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87642]: Revision status changed
User Reedy changed the status of MediaWiki.r87642. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87642#c0 Commit summary: Autoloader entries for r86041. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87669]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r87669. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87669#c16680 Commit summary: Run populate_fr_rev_timestamp() via updater Comment: Note: I don't really like how populate_fr_rev_timestamp() uses echo(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86764]: New comment added, and revision status changed
User Bawolff changed the status of MediaWiki.r86764. Old Status: new New Status: fixme User Bawolff also posted a comment on MediaWiki.r86764. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86764#c16681 Commit summary: Embrace comment with () only when really needed. In Special:ListFiles and ImagePage the comment is shown alone in a table cell - no () needed Comment: Minor issue: Previously it returned an element with a leading space before it, now it doesn't. I think this causes the history page view to have entries like: 20:23, 13 December 2010 Some user m (1,897 bytes)(Some edit summary) (undo) Note the missing space between the edit summary and the byte count. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
