[MediaWiki-CodeReview] [MediaWiki r88764]: Revision status changed
User Krinkle changed the status of MediaWiki.r88764. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88764#c0 Commit summary: Don't generate the footer div if there isn't any footer link. Removed blank line between the lis of $validFooterLinks ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89680]: Revision status changed
User ^demon changed the status of MediaWiki.r89680. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89680#c0 Commit summary: remove useless type hint (fu r85004) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87292]: Revision status changed
User Reedy changed the status of MediaWiki.r87292. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87292#c0 Commit summary: * (bug 20468) User::invalidateCache throws 1205: Lock wait timeout exceeded Severly limit the number of calls that actually update the database (for no gain!). Leaving stuff that needs to update memcached Still, there's probably quite a lot of these calls which are still superfluous ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89471]: Revision status changed
User Reedy changed the status of MediaWiki.r89471. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89471#c0 Commit summary: Add BlockTest to the tests autoloader. Needed by ApiBlockTest.php Added tabs to other items (compare ignoring whitespace). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89693]: Revision status changed
User ^demon changed the status of MediaWiki.r89693. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89693#c0 Commit summary: Revert r87292 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89694]: Revision status changed
User ^demon changed the status of MediaWiki.r89694. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89694#c0 Commit summary: Kill the extra indenting, and fix trailing whitespace ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89644]: Revision status changed
User ^demon changed the status of MediaWiki.r89644. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89644#c0 Commit summary: Fix broken r89643. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89643]: Revision status changed
User ^demon changed the status of MediaWiki.r89643. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89643#c0 Commit summary: Add GENDER support for 'lockedbyandtime'. Suggested by Purodha Blissenbach. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r74035]: New comment added, and revision status changed
User Platonides changed the status of MediaWiki.r74035. Old Status: fixme New Status: new User Platonides also posted a comment on MediaWiki.r74035. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74035#c17797 Commit summary: Follow up r74034: Refactor GAID_FOR_UPDATE into Title::GAID_FOR_UPDATE. Yay less file-scope code (for extensions) Comment: Fixed in r89696. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89666]: Revision status changed
User ^demon changed the status of MediaWiki.r89666. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89666#c0 Commit summary: Added phpunit test cases for r87497, r88076: ResourceLoader module name prefix collapsing ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87260]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87260. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87260#c0 Commit summary: * Removed Skin::reallyGenerateUserStylesheet() nothing uses it and nothing overrides it * Corrected Skin::generateUserJs() and Skin::generateUserStylesheet()'s comments: nothing override them anymore, also marked them as deprecated, only usage is action=rawgen=(css|js) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89696]: Revision status changed
User ^demon changed the status of MediaWiki.r89696. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89696#c0 Commit summary: Translate extension wants to keep 1.16 compatible. Use GAID_FOR_UPDATE and keep the define there so that it won't break in 1.18 Follow up r74035. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87249]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87249. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87249#c0 Commit summary: Get the revision ID from the OutputPage object instead of making a copy ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87250]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87250. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87250#c0 Commit summary: Moved Skin::$mWatchLinkNum to SkinLegacy since it's only used there and made it protected per documentation (nothing else apart SkinLegacy uses it) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89696]: New comment added
User Nikerabbit posted a comment on MediaWiki.r89696. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89696#c17798 Commit summary: Translate extension wants to keep 1.16 compatible. Use GAID_FOR_UPDATE and keep the define there so that it won't break in 1.18 Follow up r74035. Comment: Thanks a lot! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89696]: New comment added
User Platonides posted a comment on MediaWiki.r89696. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89696#c17799 Commit summary: Translate extension wants to keep 1.16 compatible. Use GAID_FOR_UPDATE and keep the define there so that it won't break in 1.18 Follow up r74035. Comment: No problem, Niklas :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89648]: New comment added
User P.Copp posted a comment on MediaWiki.r89648. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89648#c17800 Commit summary: Another try at fixing bug 93 tilde signatures inside nowiki tags sometimes get expanded (includeonlynowiki/nowiki/includeonly) * Change the preprocessor to insert strip items for ignore nodes during pre-save-transform, just like comment nodes are handled already. This effectively disables all pre-save-transform steps inside includeonly tags. * Adapt parser tests to the new behavior. Comment: Actually it disables PST on ''includeonly'' sections which was intentional. I mentioned it in the commit summary but perhaps I wasn't clear enough. I proposed this change on the linked bug [https://bugzilla.wikimedia.org/show_bug.cgi?id=93#c19 in November 2009] and still think this would be the right approach. At the moment many templates use hacks like pre~~includeonly/includeonly~~/pre to include signatures in substed templates without expanding them right on the spot. With the proposed change you could simply write preincludeonly/includeonly/pre Please do also note, that unlike r88997 this change won't break any existing page, because it doesn't expand anything that wasn't expanded before. As for the parser tests: There was only one test, that had to be changed and it was only introduced in r89191. So, if there are any objections to the proposed behavior I'd like to hear them :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87326]: New comment added
User P.Copp posted a comment on MediaWiki.r87326.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87326#c17801
Commit summary:
Fix Bug 28354: Edit tab is shown as view source for blocked users, which
breaks squid caching
* Skip user block checks for Title::quickUserCan(). This restores the behavior
from 1.16 rsp. before r65504.
* Remove unnecessary check for $short count($errors), this is already
handled by getUserPermissionsErrorsInternal().
Comment:
Yes, I just removed the check as it is duplicated in
Title::getUserPermissionsErrorsInternal():
pre
while( count( $checks ) 0
!( $short count( $errors ) 0 ) ) {
$method = array_shift( $checks );
$errors = $this-$method( $action, $user,
$errors, $doExpensiveQueries, $short );
}
/pre
The parameter $short is merely a residue of the refactoring of r65504 and could
be removed from most of these functions.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87222]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87222. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87222. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87222#c17802 Commit summary: When we failed to detect a DB driver, put the help info in the failure box, rather than hiding it in a little help box nobody's going to find Comment: Error message seems to work ok... I did though find that things seem to get a bit confused if you change what drivers are available once you get past the environmental check page; it seems to look up the available DB types once there, and doesn't update them until you go back to the environment check page. :) Most of the time this should be fine. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86131]: New comment added
User Platonides posted a comment on MediaWiki.r86131. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86131#c17803 Commit summary: * Pass around parser options instead of users and made some parser options consistency fixes * Moved makeParserOptions to Article.php * Renamed currentIncludeVersions - getRevIncludes * Renamed updatePageCache - setPageCache * Moved FlaggedRevs::getCacheKey up Comment: Why didn't you make makeParserOptions static? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89674]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r89674. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89674#c0 Commit summary: Followup r87347, bug 7, use makeTitleSafe. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87347]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87347. Old Status: fixme New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r87347. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87347#c17805 Commit summary: (bug 7) Special:Listfiles no longer throws an error on bogus file entries Comment: and fixed in r89674, thanks :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87326]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87326. Old Status: fixme New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87326. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87326#c17806 Commit summary: Fix Bug 28354: Edit tab is shown as view source for blocked users, which breaks squid caching * Skip user block checks for Title::quickUserCan(). This restores the behavior from 1.16 rsp. before r65504. * Remove unnecessary check for $short count($errors), this is already handled by getUserPermissionsErrorsInternal(). Comment: I'll leave that as an exercise for future cleanup then. :) No clear problems standing out otherwise. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87322]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87322. Old Status: fixme New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87322. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87322#c17807 Commit summary: Tablesorter: Add a title attribute to sort arrows ( Bug 21453 ) Comment: ''nod'' it's not superawful; taking this off fixme, leaving a todo tag. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82102]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r82102. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82102#c17808 Commit summary: * (bug 26298) Throw warning instead of silently saving blank page when php-suhosin removes wpTextbox1 for being 'too long' or some such To resolve this, edit your php.ini and raise the limits in suhosin.request.max_value_length and suhosin.post.max_value_length settings to more reasonable values. As a helper for users hit by this, I've made a tweak on trunk in rX to check for the case of a missing wpTextbox1 field (which I can confirm when installing Suhosin and setting the suhosin.request.max_value_length absurdly low). This extends the previous behavior to check for incomplete form submissions by just checking if the edittime (a late field) is present; and also I added a message to show when it forces those previews. So now when someone hits this sort of filter, it'll force a preview. Unfortunately that'll show a big empty box, but at least you'll know it's because something went wrong, and it won't save it silently... Adds UI message 'edit_form_incomplete' with default English value. It's fairly generic as we can't know whether the field was filtered for length, content, or what. Comment: That's what I get for copy-pasting the same text in the commit summary and the bug. ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89707]: New comment added
User Wikinaut posted a comment on MediaWiki.r89707. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89707#c17809 Commit summary: quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is dangerous subject to change from the require-once-loaded extensions. This is NOT A FINAL fix, just a small improvement Comment: remaining problem: $e . If an extensions take the liberty to use $e , it changes the loop. Please fix finally. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89707]: Revision status changed
User Wikinaut changed the status of MediaWiki.r89707. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89707#c0 Commit summary: quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is dangerous subject to change from the require-once-loaded extensions. This is NOT A FINAL fix, just a small improvement ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89707]: New comment added
User Wikinaut posted a comment on MediaWiki.r89707. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89707#c17810 Commit summary: quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is dangerous subject to change from the require-once-loaded extensions. This is NOT A FINAL fix, just a small improvement Comment: s/take/takes/ (my keyboard does not like me) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89707]: Revision status changed
User Platonides changed the status of MediaWiki.r89707. Old Status: fixme New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89707#c0 Commit summary: quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is dangerous subject to change from the require-once-loaded extensions. This is NOT A FINAL fix, just a small improvement ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89707]: New comment added, and revision status changed
User Wikinaut changed the status of MediaWiki.r89707. Old Status: ok New Status: fixme User Wikinaut also posted a comment on MediaWiki.r89707. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89707#c17811 Commit summary: quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is dangerous subject to change from the require-once-loaded extensions. This is NOT A FINAL fix, just a small improvement Comment: Attention, we need a better code for the loop to avoid $e. Any volunteers? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89708]: Revision status changed
User Wikinaut changed the status of MediaWiki.r89708. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89708#c0 Commit summary: Follow up r89707. No need for the explicit concatenations. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89707]: New comment added
User Wikinaut posted a comment on MediaWiki.r89707. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89707#c17813 Commit summary: quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is dangerous subject to change from the require-once-loaded extensions. This is NOT A FINAL fix, just a small improvement Comment: Oops, I overlooked that, yes, thanks, will try to remember this. +++ I am happy that the issue of installation plus extensions appears now finally be solved +++ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87243]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r87243. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87243#c17814 Commit summary: Make jquery.tablesorter more resilient by checking multiple cells before assuming a type. Fixes Bug 28775 Comment: Looks ok offhand, but especially since this is fixing a known regression, it should really come with some test cases. Reopened bug 28775 w/ needs-unittests keyword added some notes on https://bugzilla.wikimedia.org/show_bug.cgi?id=28775#c2 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added
User Tim Starling posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17815 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the three major entry points (index.php, api.php, load.php) back to PHP 4.4.9. We don't care what happens if you actually try to run these files on old versions, but the entry files need to parse correctly. * consign /includes/templates/PHP4.php and /includes/templates/NoLocalSettings.php to the fiery pit of hell where they belong. * Prevent loading of any other files for PHP 5. WebStart.php was rendered unparseable in PHP 4 by the introduction of try/catch blocks in r85327. * Die outright with a pretty error message on PHP 5.2.3 as well as PHP 4. All versions of PHP below that throw parse errors of various sorts. * Reimplement wfDie() to provide an entry-point-dependent die-with-readable-error-message function (for instance, we want a pretty human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment block in load.php, etc). * Standardise the appearance of the catastrophic errors thrown at the top of the stack with the ones lower down (exception-within-exception, etc). There isn't really a way to do this without duplication, AFAICT. Comment: Well yeah, specifically, documenting the fact that parse errors mean you have to upgrade to PHP 5 and leaving it at that. The reason I did some work on PHP 4 error messages in r41713 is because we were having support requests from people who didn't know what the parse errors meant. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added
User Platonides posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17816 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the three major entry points (index.php, api.php, load.php) back to PHP 4.4.9. We don't care what happens if you actually try to run these files on old versions, but the entry files need to parse correctly. * consign /includes/templates/PHP4.php and /includes/templates/NoLocalSettings.php to the fiery pit of hell where they belong. * Prevent loading of any other files for PHP 5. WebStart.php was rendered unparseable in PHP 4 by the introduction of try/catch blocks in r85327. * Die outright with a pretty error message on PHP 5.2.3 as well as PHP 4. All versions of PHP below that throw parse errors of various sorts. * Reimplement wfDie() to provide an entry-point-dependent die-with-readable-error-message function (for instance, we want a pretty human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment block in load.php, etc). * Standardise the appearance of the catastrophic errors thrown at the top of the stack with the ones lower down (exception-within-exception, etc). There isn't really a way to do this without duplication, AFAICT. Comment: I'm pretty sure I broke PHP 4 parsing in r88959. You did [http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/index.php?r1=88958r2=88959]. PHP 4 doesn't like try/catch. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17817 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the three major entry points (index.php, api.php, load.php) back to PHP 4.4.9. We don't care what happens if you actually try to run these files on old versions, but the entry files need to parse correctly. * consign /includes/templates/PHP4.php and /includes/templates/NoLocalSettings.php to the fiery pit of hell where they belong. * Prevent loading of any other files for PHP 5. WebStart.php was rendered unparseable in PHP 4 by the introduction of try/catch blocks in r85327. * Die outright with a pretty error message on PHP 5.2.3 as well as PHP 4. All versions of PHP below that throw parse errors of various sorts. * Reimplement wfDie() to provide an entry-point-dependent die-with-readable-error-message function (for instance, we want a pretty human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment block in load.php, etc). * Standardise the appearance of the catastrophic errors thrown at the top of the stack with the ones lower down (exception-within-exception, etc). There isn't really a way to do this without duplication, AFAICT. Comment: I'd say let's either drop the PHP 4 checks entirely, or move the actual code out of the entry points and require() through to the 'real' code, so we don't all keep accidentally checking things in that break the PHP 4 parser. :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added
User Platonides posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17818 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the three major entry points (index.php, api.php, load.php) back to PHP 4.4.9. We don't care what happens if you actually try to run these files on old versions, but the entry files need to parse correctly. * consign /includes/templates/PHP4.php and /includes/templates/NoLocalSettings.php to the fiery pit of hell where they belong. * Prevent loading of any other files for PHP 5. WebStart.php was rendered unparseable in PHP 4 by the introduction of try/catch blocks in r85327. * Die outright with a pretty error message on PHP 5.2.3 as well as PHP 4. All versions of PHP below that throw parse errors of various sorts. * Reimplement wfDie() to provide an entry-point-dependent die-with-readable-error-message function (for instance, we want a pretty human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment block in load.php, etc). * Standardise the appearance of the catastrophic errors thrown at the top of the stack with the ones lower down (exception-within-exception, etc). There isn't really a way to do this without duplication, AFAICT. Comment: I had already looked at wfIndexMain(), I think it should be pieced and moved into MediaWiki class. Also, it is broken for $wgArticle currently. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87232]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87232. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87232#c0 Commit summary: Make a method static per the comment, update the only non static usage (in Parser) itself ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87217]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87217. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87217#c0 Commit summary: Refactor out common code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89707]: New comment added, and revision status changed
User Platonides changed the status of MediaWiki.r89707.
Old Status: fixme
New Status: ok
User Platonides also posted a comment on MediaWiki.r89707.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89707#c17812
Commit summary:
quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is
dangerous subject to change from the require-once-loaded extensions. This is
NOT A FINAL fix, just a small improvement
Comment:
This is prefectly sane. On the next iteration foreach() sets $e again, so the
changed $e would not corrupt it.
A change to $ext looks more suspicious, but it is locked by the foreach, so no
problem there, either.
source lang=php
?php
$a = array( 1, 2, 3 );
foreach( $a as $b ) {
echo $b\n;
$a = array( 'foo', 'bar', 'baz' );
$b = 'Hello World!';
}
/source
outputs
1
2
3
(and leaves $a set to 'foo', 'bar', 'baz')
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added
User Tim Starling posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17819 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the three major entry points (index.php, api.php, load.php) back to PHP 4.4.9. We don't care what happens if you actually try to run these files on old versions, but the entry files need to parse correctly. * consign /includes/templates/PHP4.php and /includes/templates/NoLocalSettings.php to the fiery pit of hell where they belong. * Prevent loading of any other files for PHP 5. WebStart.php was rendered unparseable in PHP 4 by the introduction of try/catch blocks in r85327. * Die outright with a pretty error message on PHP 5.2.3 as well as PHP 4. All versions of PHP below that throw parse errors of various sorts. * Reimplement wfDie() to provide an entry-point-dependent die-with-readable-error-message function (for instance, we want a pretty human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment block in load.php, etc). * Standardise the appearance of the catastrophic errors thrown at the top of the stack with the ones lower down (exception-within-exception, etc). There isn't really a way to do this without duplication, AFAICT. Comment: Sounds good. Can you also rename the MediaWiki class to MainEntry or something while you're at it? It's always been a helper for index.php, and has very little to do with the rest of MediaWiki. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87212]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r87212. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87212#c17820 Commit summary: Added wgIsMainPage (Title-isMainPage) to mw.config * Instead of ugly javascript construction to compare href-attributes or re-constructing proper pagenames, let's use Title-isMainPage which does this much better * Kept function for compatibility. mw.util.isMainPage() was never released, should probably be removed before 1.18 branch point. Comment: Honestly, exposing 'wgIsMainPage' seems kinda lame and pollutes the global var space. How about if only the page that *is* the main page actually bothers to export information saying 'by the way I AM the main page'? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87243]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87243. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r87243. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87243#c17821 Commit summary: Make jquery.tablesorter more resilient by checking multiple cells before assuming a type. Fixes Bug 28775 Comment: Going ahead and marking this a fixme since regression testing is a) very wise and b) it shouldn't be hard for one of us to stuff it in sometime in the next few days. :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87176]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87176. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87176. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87176#c17822 Commit summary: Add --include-files option to dumpBackup.php to include the uploaded files in the XML stream. Uses new backend features from r85911. Comment: Does this also require specifying --uploads? I see nothing much extra in output passing just --include-files; if a requirement, needs documenting. Otherwise perhaps it should imply --uploads? Marking todo rather than fixme as this is an experimental feature, not used by default. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86131]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r86131. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86131#c17823 Commit summary: * Pass around parser options instead of users and made some parser options consistency fixes * Moved makeParserOptions to Article.php * Renamed currentIncludeVersions - getRevIncludes * Renamed updatePageCache - setPageCache * Moved FlaggedRevs::getCacheKey up Comment: I'd rather dependency inject the User rather than always using $wgUser. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85911]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r85911. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r85911. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85911#c17824 Commit summary: Add support for importing/exporting files. This can be done by embedding the image as base64 in the XML stream or by copying the images directory manually and pointing the importer to the base images directory. Currently only backend code available and a few member variables need to be modified to enable the functionality. Export.php: * Add rel and sha1base36 elememnts to the XML output * Add optional archivename and contents elements to the XML output. contents contains an encoding attribute, which is currently only set to base64. Import.php: * Add Import::$mImageBasePath which should point to the images/ directory to import from * Add methods to WikiRevision (terrible name btw) to set the rel, hash, archivename and filesrc. * Cleanup and made WikiRevision::importUpload working. It's still quite a mess though OldLocalFiel.php: * Fix a few timestamp related things from r85635 Comment: This output format has some potential problems with very large files; videos can be hundreds of megabytes quite easily, and multi-gigabyte files (eg feature-length high-resolution movies) are not unthinkable. While it should be possible in principle to handle a really huge incoming data file in the stream, currently it'll be buffered up into memory, requiring *at least* ~2.5x the size of the original file for the base64 string, and the decoded binary string before it's written out to a file. This doesn't block working on it as a non-default experimental feature, but it's worth looking out for... especially if it turns out that XMLReader will try to batch up an entire multi-hundred-megabyte string into one node's 'value' property or something, it may be hard to actually read the value in a streaming way. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88148]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r88148. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88148#c0 Commit summary: Follow-up r87176 use wfLocalFile instead of wfFindFile ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81536]: New comment added
User RobLa-WMF posted a comment on MediaWiki.r81536. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81536#c17825 Commit summary: (bug 19751) Filesystem is now checked during image undeletion * FSRepo::storeBatch() now does an sha1 check unless SKIP_VALIDATION flag is set * Introduced Status::$success in addition to Status::$successcount ** FSRepo::storeBatch() now logs success/failure in this variable * LocalFileRestoreBatch now aborts on failure in FSRepo::storeBatch() and cleans up the already copied files ** Introduced FSRepo::cleanupBatch() for this purpose * SpecialUndelete now aborts if LocalFile::restore() gives a fatal Comment: This is a fix for a two year old bug, and doesn't appear to be running in production. Doesn't seem like a 1.17 tarball blocker to me. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added
User Happy-melon posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17826 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the three major entry points (index.php, api.php, load.php) back to PHP 4.4.9. We don't care what happens if you actually try to run these files on old versions, but the entry files need to parse correctly. * consign /includes/templates/PHP4.php and /includes/templates/NoLocalSettings.php to the fiery pit of hell where they belong. * Prevent loading of any other files for PHP 5. WebStart.php was rendered unparseable in PHP 4 by the introduction of try/catch blocks in r85327. * Die outright with a pretty error message on PHP 5.2.3 as well as PHP 4. All versions of PHP below that throw parse errors of various sorts. * Reimplement wfDie() to provide an entry-point-dependent die-with-readable-error-message function (for instance, we want a pretty human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment block in load.php, etc). * Standardise the appearance of the catastrophic errors thrown at the top of the stack with the ones lower down (exception-within-exception, etc). There isn't really a way to do this without duplication, AFAICT. Comment: That's exactly what I did! But as Tim's pointed out elsewhere, most uses of require() breaks HipHop unless it's run through MWInit::compiledPath(), and you can't get that without loading WebStart, which is not PHP4-compatible... tt:(/tt So you can't really move very much of what's in index.php deeper into the callstack, because you still have to leave enough infrastructure to be able to correctly find the deeper file. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88145]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r88145. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r88145. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88145#c17827 Commit summary: Follow-up r87176: Make importDump.php import files * Fixes for Import.php: Check sha1 of the file; only delete source files if they are temporary * importDump.php now imports embedded files if --uploads is set; if they are not present it will try to get them from --image-base-path Comment: If we have a SHA-1 mismatch, does the temp file get deleted? Hmm, looks like the sequence for a mismatched file is: * extract and save to temp file / download and save to temp file / find permanent source file in an alt directory * set $flags for File::upload / File::uploadOld to remove the source file if it was our temporary file * calc the sha1 sum of the file ** if mismatch, exit * call File::upload / File::uploadFile to import the file ** removes the temporary file if needed (For files retrieved via URL, mismatches due to the source file having been updated since the export is possible.) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17828 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the three major entry points (index.php, api.php, load.php) back to PHP 4.4.9. We don't care what happens if you actually try to run these files on old versions, but the entry files need to parse correctly. * consign /includes/templates/PHP4.php and /includes/templates/NoLocalSettings.php to the fiery pit of hell where they belong. * Prevent loading of any other files for PHP 5. WebStart.php was rendered unparseable in PHP 4 by the introduction of try/catch blocks in r85327. * Die outright with a pretty error message on PHP 5.2.3 as well as PHP 4. All versions of PHP below that throw parse errors of various sorts. * Reimplement wfDie() to provide an entry-point-dependent die-with-readable-error-message function (for instance, we want a pretty human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment block in load.php, etc). * Standardise the appearance of the catastrophic errors thrown at the top of the stack with the ones lower down (exception-within-exception, etc). There isn't really a way to do this without duplication, AFAICT. Comment: Poop. My vote then goes towards just killing all the PHP 4 stuff and documenting 'if you get parse errors, it's cause you're running year-2000 tech still, upgrade silly' :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87173]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87173. Old Status: new New Status: reverted User Brion VIBBER also posted a comment on MediaWiki.r87173. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87173#c17829 Commit summary: Bug 27047: Nicer design for pre elements in Vector Comment: Reverted in r89712; the word wrapping looks like not what we would want on pre areas, which are meant to exactly preserve the formatting of even very long lines. Expected 'make it pretty' handling on these is to do things like use overflow scrollbar settings. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89712]: Revision status changed
User ^demon changed the status of MediaWiki.r89712. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89712#c0 Commit summary: Revert r87173: adds 'wrap: break-word' which seems opposite to what pre blocks are meant to do. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?
Platonides platoni...@gmail.com wrote in message news:isjjo3$dmq$1...@dough.gmane.org... Ashar Voultoiz wrote: On 06/06/11 00:56, K. Peachey wrote: snip Since it skips cache, can not we disable that stub highlighter once for all? Logged in users don't get cached versions of the page... I am well aware of that. The root cause being the various options available to users, my proposal is merely to get ride of one of the options :-) I think you would find opposition from wikipedians when you tried to ditch the stub threshold option. We find opposition from some subset of Wikipedians when we try to do just about anything. The presence of a small group of extremely vocal users should certainly be noted, but shouldn't be an automatic blocker, or we'd never get anything done. If we proceeded to remove the feature, they could fairly easily add it into Popups or one of the other JS citadels. --HM ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r87165]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87165. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87165#c0 Commit summary: Properly escape the ouput in action=credits (and in page footer), using wfMessage() to be able to replace some parameters before and some after ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87166]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87166. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87166#c0 Commit summary: I have no idea where that count() pass in r87165 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87212]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r87212. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87212#c17831 Commit summary: Added wgIsMainPage (Title-isMainPage) to mw.config * Instead of ugly javascript construction to compare href-attributes or re-constructing proper pagenames, let's use Title-isMainPage which does this much better * Kept function for compatibility. mw.util.isMainPage() was never released, should probably be removed before 1.18 branch point. Comment: (I'd rather keep the function and not the variable. If the variable's needed to feed the function, the variable should be private or hidden.) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87212]: New comment added
User Krinkle posted a comment on MediaWiki.r87212.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87212#c17832
Commit summary:
Added wgIsMainPage (Title-isMainPage) to mw.config
* Instead of ugly javascript construction to compare href-attributes or
re-constructing proper pagenames, let's use Title-isMainPage which does this
much better
* Kept function for compatibility. mw.util.isMainPage() was never released,
should probably be removed before 1.18 branch point.
Comment:
The global space is only legacy name. It's deprecated as of 1.17 since we're
exporting everything as a Map in mw.config, which, for now, stashes it's
key/value pairs onto codewindow/code but there's a configuration option for
this already and I guess we're gonna flip it some time soon in trunk (1.20?).
Anyway, mw.config defaults to null if the key is unknown (and throw
ReferenceErrors exceptions about undefined variables), so in a way it's already
a function that uses a private variable that is only defined on the main
page. mw.config either returns that variable or null.
preif ( mw.config.get( 'isMainPage' ) { .. /pre
If you think that's good enough I'll go ahead and make the change.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87212]: New comment added
User Krinkle posted a comment on MediaWiki.r87212. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87212#c17833 Commit summary: Added wgIsMainPage (Title-isMainPage) to mw.config * Instead of ugly javascript construction to compare href-attributes or re-constructing proper pagenames, let's use Title-isMainPage which does this much better * Kept function for compatibility. mw.util.isMainPage() was never released, should probably be removed before 1.18 branch point. Comment: that should be and '''never''' throws ReferenceErrors exceptions about undefined variables (in contrary to normal global variables) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87164]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r87164. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87164#c17834 Commit summary: Recommit r87129 and follow-ups but with a fix for the bug Brion found (sorry) Comment: Does all this stuff for partial rows have anything to do with the PostgreSQL query failure in bug 21196? Or is it an attempt at optimizing the later loop over the output by avoiding later loads from the db? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87163]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87163. Old Status: fixme New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87163. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87163#c17830 Commit summary: Use a reversed magnify image for framed image thumbnails when on a RTL wiki. Comment: Nothing looks like a fixme in here. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87145]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87145. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r87145. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87145#c17835 Commit summary: (bug 28752) XCache doesn't work in CLI mode Comment: This doesn't seem to fix the issue that xcache doesn't work in CLI mode; it just seems to ... avoid using it? Being unable to overwrite items in cache from background maintenance operations in command-line scripts means that your cache can become inconsistent, so this just hides problems rather than fixing them. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87143]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87143. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r87143. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87143#c17836 Commit summary: Followup to r85907, correctly quote table names. Followup to r87129, add handling of arrayed GROUP BY/ORDER BY options to match core class so that this will indeed work. Comment: Rather than calling $db-tableName( $foo, false ) with an opaque parameter and then calling $db-addQuotes() explicitly... consider simply calling $db-tableName( $foo ) and not double-escaping it. :) This will make things simpler and less confusing for future maintainers. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87143]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87143. Old Status: fixme New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87143. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87143#c17837 Commit summary: Followup to r85907, correctly quote table names. Followup to r87129, add handling of arrayed GROUP BY/ORDER BY options to match core class so that this will indeed work. Comment: Hmm.. actually it makes sense, as identifier and *string* escaping may be different here, and you're tossing them into queries. Proper thing to do is probably to have a clearer constant to use on the second parameter to tableName, as the 'false' is totally unclear. :) Marking OK with a todo. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87144]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87144. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87144#c0 Commit summary: Fix group by for Special:MostLinkedTemplates ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87145]: Revision status changed
User ^demon changed the status of MediaWiki.r87145. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87145#c0 Commit summary: (bug 28752) XCache doesn't work in CLI mode ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87000]: Revision status changed
User ^demon changed the status of MediaWiki.r87000. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87000#c0 Commit summary: changing cookie expiry to 90 days as per request, will be backported to trunk later ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87162]: Revision status changed
User ^demon changed the status of MediaWiki.r87162. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87162#c0 Commit summary: 1.17wmf1: Fix bug in auprop=blockinfo, presumably caused by a botched merge. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87234]: Revision status changed
User ^demon changed the status of MediaWiki.r87234. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87234#c0 Commit summary: Re-adding the logging hack from r83994 since bug 27891 has been reopened ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87353]: Revision status changed
User ^demon changed the status of MediaWiki.r87353. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87353#c0 Commit summary: 1.17wmf1: MFT r85546, r86409, r86450, r86625, r86788, r86805, r86841, r86904, r87030, r87153 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87448]: Revision status changed
User ^demon changed the status of MediaWiki.r87448. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87448#c0 Commit summary: 1.17wmf1: Partially revert r87353, which per CR messed up GNSM ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r68904]: New comment added
User Peachey88 posted a comment on MediaWiki.r68904. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/68904#c17838 Commit summary: (bug 24212) Added MediaWiki:ImagePage.css which is also included on foreign client wikis. Comment: There is a tad of a difference between oh hey, lets use commons so we don't need to to dup file uploads and oh hey, lets give a remote wiki the ability to style content on our wiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r68904]: New comment added
User Peachey88 posted a comment on MediaWiki.r68904. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/68904#c17839 Commit summary: (bug 24212) Added MediaWiki:ImagePage.css which is also included on foreign client wikis. Comment: We should probably have a switch to enable this, this feature doesn't exactly win my heart and I can see opposition to it as well in these comments. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87867]: Revision status changed
User ^demon changed the status of MediaWiki.r87867. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87867#c0 Commit summary: fix bug 28918 -- errant commas caused undefined regexes, which cause match() to return empty array in IE, which == true!! believe it or not. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88057]: New comment added
User Helder.wiki posted a comment on MediaWiki.r88057. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88057#c17840 Commit summary: Reorganizing directories Comment: For some reason the page [[Special:Version]] is showing bookmanager-desc instead of the correct text which is in the localization files. I wasn't able to investigate the cause, but maybe it is caused by this or some other reorganization of the directories structure? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88294]: Revision status changed
User ^demon changed the status of MediaWiki.r88294. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88294#c0 Commit summary: * (bug 29022) Link to disable email notifications should be in the email notification Adds a line linking to Special:Preferences to enotif_body message that formats watchlist-based email notifications. This allows the receiving user to immediately go adjust their settings if they decide they don't want them. Only changed the English message; needs to be duplicated in localizations. (Long-term, this message should be broken up so the header lines can be handled independently.) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89025]: Revision status changed
User ^demon changed the status of MediaWiki.r89025. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89025#c0 Commit summary: Fix silly bug covered up by using newer PHP than the cluster ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89026]: Revision status changed
User ^demon changed the status of MediaWiki.r89026. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89026#c0 Commit summary: MFT r89025 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89710]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r89710. Old Status: new New Status: fixme User ^demon also posted a comment on MediaWiki.r89710. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89710#c17841 Commit summary: add back json support Comment: * Please do not use $_GET or $_POST directly, use WebRequest (a global instance of which exists as $wgRequest). * Same thing with ttheader()/tt, do tt$wgRequest-response()-header()/tt instead. * Don't use json_encode/decode() directly, use our FormatJson wrapper class. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89707]: New comment added
User ^demon posted a comment on MediaWiki.r89707. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89707#c17843 Commit summary: quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is dangerous subject to change from the require-once-loaded extensions. This is NOT A FINAL fix, just a small improvement Comment: I could rename it to $pleaseDontNameYourVariableThis ;-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89619]: Revision status changed
User ^demon changed the status of MediaWiki.r89619. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89619#c0 Commit summary: Current version of CommonSettings.php that lives in /home/wikipedia/common/php-1.17/wmf-config. This may get out of sync but will provide a good start for the changes to the configs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89377]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r89377. Old Status: deferred New Status: new User ^demon also posted a comment on MediaWiki.r89377. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89377#c17844 Commit summary: * Rewrite optionToTable to be like a modern maintenance script ** Since we rely on pref rewrite per r89371, don't check for user_options, just user_properties Comment: Please don't defer OpenID. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88550]: Revision status changed
User ^demon changed the status of MediaWiki.r88550. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88550#c0 Commit summary: * (bug 29033) Filter is lost when I'm submitting the search form ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88550]: New comment added
User ^demon posted a comment on MediaWiki.r88550. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88550#c17845 Commit summary: * (bug 29033) Filter is lost when I'm submitting the search form Comment: Have I mentioned how much Pager sucks? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88575]: Revision status changed
User ^demon changed the status of MediaWiki.r88575. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88575#c0 Commit summary: Code tweaks, show filtering by tag Improve comments ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] [Foundation-l] YouTube and Creative Commons
On 06/04/2011 06:43 PM, David Gerard wrote: A question that wasn't clear from reading the bug: why is reading a file format (WebM) blocked on the entire Timed Media Handler? It would be complicated to support WebM without an improved player and transcoding support. All the IE users for example can only decode ogg with cortado, if we don't use TMH WebM files when embed in articles would not play for those users. Likewise older versions of firefox only playback ogg. Additionally, issues around HD files embedded into articles is already an issue with users uploading variable bit-rate HD oggs, giving a far from ideal experience on most Internet connections and most in-browser playback engines. This would be an issue for variable bitrate webm files as well ( without the transcoding support of TMH ) Other features that have been living in the mwEmbed gadget for a long time like timed text, remote embedding / video sharing, and temporal media references / embeds are all better supported in TMH as an extension, so we would be good to move those features over. --michael ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r88929]: New comment added
User Tim Starling posted a comment on MediaWiki.r88929. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88929#c17846 Commit summary: Commiting here, because other problems exist on trunk. This needs to be forward-ported to trunk. * Make Pg installation work for lesser privileged role in Postgres (i.e. not super user, but can create users and databases) for Bug #28845. * Switch to Pg's new “role” tables to replace the old “user” nes * Give DatabaseInstaller::openConnection() the ability to select a db since there isn't any working selectDB method for Pg yet. * If the installing role is the same as the one that the wiki will use, make sure it can see the tables in the MW schema * Remove addition of user_hidden field to the mwtable in Pg installation since it isn't referred to anywhere and breaks the installation. * Remove the word “below” from the config-connection-error message since sometimes the message is displayed where there is no login information shown at the same time. Comment: In future, please add a RELEASE-NOTES entry when you fix a bug in a release branch. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89717]: New comment added
User MZMcBride posted a comment on MediaWiki.r89717. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89717#c17847 Commit summary: Fix Bug #18831 (“Wikibugs should use real name instead of e-mail prefix when reporting on IRC“) with a patch adapted from MZ's patch to fix. Comment: bug 22094 (-; ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88929]: New comment added, and revision status changed
User Tim Starling changed the status of MediaWiki.r88929.
Old Status: new
New Status: fixme
User Tim Starling also posted a comment on MediaWiki.r88929.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88929#c17848
Commit summary:
Commiting here, because other problems exist on trunk. This needs to
be forward-ported to trunk.
* Make Pg installation work for lesser privileged role in Postgres (i.e. not
super user, but can create users and databases) for Bug #28845.
* Switch to Pg's new “role” tables to replace the old “user” nes
* Give DatabaseInstaller::openConnection() the ability to select a db since
there isn't any working selectDB method for Pg yet.
* If the installing role is the same as the one that the wiki will use, make
sure it can see the tables in the MW schema
* Remove addition of user_hidden field to the mwtable in Pg installation since
it isn't referred to anywhere and breaks the installation.
* Remove the word “below” from the config-connection-error message since
sometimes the message is displayed where there is no login information shown at
the same time.
Comment:
There are some style problems here: single line if statements, comment style,
attempted vertical alignment in DatabaseInstaller::getConnection().
pre
+ if( $db === null ) throw new DBConnectionError(Unknown
problem while connecting.);
/pre
How could this possibly happen? You just unconditionally assigned $db to an
object.
pre
- $rights = $conn-selectField( 'pg_catalog.pg_user',
- 'CASE WHEN usesuper IS TRUE THEN
- CASE WHEN usecreatedb IS TRUE THEN 3 ELSE 1 END
- ELSE CASE WHEN usecreatedb IS TRUE THEN 2 ELSE
0 END
- END AS rights',
- array( 'usename' = $superuser ), __METHOD__
+ $rights = $conn-selectField( 'pg_catalog.pg_roles',
+ 'CASE WHEN rolsuper then 1
+ WHEN rolcreatedb then 2
+ ELSE 3
+END as rights',
+ array( 'rolname' = $superuser ), __METHOD__
);
/pre
By criticising this query on bug 28845 I was trying to hint that it would be
better to get rid of the CASE and the integer literals altogether, and to put
the logic in PHP instead.
pre
- public function getConnection() {
+ public function getConnection( $dbName = null ) {
/pre
You broke the caching in getConnection(). Now if someone calls getConnection()
with $dbName non-null, it will pollute $this-db and cause subsequent calls
with $dbName=null to return a connection to the wrong database. It was already
broken by r81440 (which was backported), but now it's broken even more. See the
way this was dealt with in Oracle in r81084 and r83017.
Also there is the problem that the $dbName parameter is undocumented and is
ignored for most of the DBMSes.
pre
- $this-db-query(ALTER USER $safeuser SET
search_path = $safeschema);
+ $this-db-query(ALTER ROLE $safeuser LOGIN);
}
}
+ $this-db-query(ALTER ROLE $safeuser SET search_path =
$safeschema, public);
/pre
By making the ALTER ROLE SET search_path unconditional, instead of only being
done for new users, this will have the effect of destroying any existing
account, breaking any wiki that uses it other than the one that is being
installed. It's probably better to let the new wiki be broken rather than break
unrelated wikis and apps. Is there a bug report for the issue that this is
trying to fix?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88936]: New comment added, and revision status changed
User Tim Starling changed the status of MediaWiki.r88936. Old Status: new New Status: fixme User Tim Starling also posted a comment on MediaWiki.r88936. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88936#c17849 Commit summary: This needs to be forward-ported to trunk. Fix for Bug #28172 - wfGetDB called when it shouldn't be Avoid an ominous error (“Mediawiki tried to access the database via wfGetDB(). This is not allowed.”) by passing db handles to user methods that would otherwise have to use wfGetDB(). Comment: I think this should be reverted. Regular operations on the new database should be done after DatabaseInstaller::enableLB() is called. It certainly shouldn't be necessary to add database connection parameters to every function. Maybe the bug that you are trying to fix here is due to PostgresInstaller::createTables() not calling enableLB() when it is done. If that's the case, then it should have other symptoms apart from failure of createSysop(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89374]: New comment added, and revision status changed
User Tim Starling changed the status of MediaWiki.r89374. Old Status: new New Status: fixme User Tim Starling also posted a comment on MediaWiki.r89374. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89374#c17850 Commit summary: Finish fix for bug #28172 (“wfGetDB called when it shouldn't be”). Will now forward port to trunk Comment: Needs revert as per CR r88936. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88936]: New comment added
User MarkAHershberger posted a comment on MediaWiki.r88936. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88936#c17851 Commit summary: This needs to be forward-ported to trunk. Fix for Bug #28172 - wfGetDB called when it shouldn't be Avoid an ominous error (“Mediawiki tried to access the database via wfGetDB(). This is not allowed.”) by passing db handles to user methods that would otherwise have to use wfGetDB(). Comment: Thanks for looking at this. I wasn't sure about the change, but it was the fix that someone more experienced than me suggested. I'll try enableLB() tomorrow. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89637]: New comment added
User Patrick Nagel posted a comment on MediaWiki.r89637. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89637#c17852 Commit summary: Initial commit of new extension Notificator Comment: Thanks for your advice, Nikerabbit. I gave it some more work now: * r89714: Removed wfLoadExtensionMessages() call, backwards-compatibility not needed, since this extension does not work with 1.17b1 anyway. Btw.: wfLoadExtensionMessages() is mentioned in http://www.mediawiki.org/wiki/Manual:Special_pages#The_Special_Page_File - maybe it should be mentioned there, that this call is no longer needed for extensions that don't need to be compatible with $old MW versions? * r89715: Changed $ngFromAddress init. Using $wgPasswordSenderName and $wgPasswordSender as default for $ngFromAddress. That fixes the register_globals vulnerability. * r89716: Replaced Notificator::checkEmailAddress() with MW's Sanitizer::validateEmail() * r89719: Switched to Notificator::checkEmailAddress() again, after discovering that Sanitizer::validateEmail() is not available in any released MW version; Lots of whitespace changes (ran stylize.php and limited line length to 100). [Should have done that in two commits, but it would have been a big hassle] About the You need to do a lot more escaping of things you output into html part - I think I had already escaped all user-provided input with htmlspecialchars(), what else needs to be done? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88946]: New comment added, and revision status changed
User Tim Starling changed the status of MediaWiki.r88946. Old Status: ok New Status: fixme User Tim Starling also posted a comment on MediaWiki.r88946. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88946#c17853 Commit summary: Fix Bug #28829 - “Failure to subscribe to mediawiki-announce is not reported to the user” Wasn't able to test an actual subscription failure, so I faked it. Error message showed. Tried double-subscribing an address and only got an emailed “privacy alert” from mailman. Doing a double-subscription manually didn't get any web-based error. Comment: The message needs to be updated to include $1. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88201]: Revision status changed
User Tim Starling changed the status of MediaWiki.r88201. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88201#c0 Commit summary: MFT r87512 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89586]: Revision status changed
User MaxSem changed the status of MediaWiki.r89586. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89586#c0 Commit summary: Revert r89263, r89297, r89347: unclear whether this is needed; DatabaseUpdater actions list is already extensible and it might just need some rearrangement? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89037]: Revision status changed
User MaxSem changed the status of MediaWiki.r89037. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89037#c0 Commit summary: More parameter documentation!! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88475]: Revision status changed
User MaxSem changed the status of MediaWiki.r88475. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88475#c0 Commit summary: Patch for Bug #28669, “Scream bloody murder when user chooses MyISAM and InnoDB is available” From William Demchick ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87870]: Revision status changed
User MaxSem changed the status of MediaWiki.r87870. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87870#c0 Commit summary: readding generic public domain option per comments at r87862 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89252]: New comment added, and revision status changed
User Tim Starling changed the status of MediaWiki.r89252. Old Status: ok New Status: fixme User Tim Starling also posted a comment on MediaWiki.r89252. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89252#c17854 Commit summary: * MFT r89250. only the tableExists function ad 1.17 already supports user-dbname difference Comment: Lacks proper string escaping in SQL construction. I'm not sure what to write for this in the release notes, is it fixing a bug? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
