[MediaWiki-CodeReview] [MediaWiki r113534]: Revision status changed
^demon changed the status of MediaWiki.r113534 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113534 Old status: new New status: ok Commit summary for MediaWiki.r113534: Fix PostgreSQL updater broken by r113487 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113955]: New comment added, and revision status changed
Robmoen changed the status of MediaWiki.r113955 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113955#c32399 Old Status: new New Status: ok Commit summary for MediaWiki.r113955: followup to -r113953 - clean up javascript code Robmoen's comment: fixed in r114018, marking ok ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113955]: Revision status changed
Robmoen changed the status of MediaWiki.r113955 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113955 Old status: ok New status: resolved Commit summary for MediaWiki.r113955: followup to -r113953 - clean up javascript code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114271]: New comment added, and revision status changed
Rsterbin changed the status of MediaWiki.r114271 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114271#c32400 Old Status: fixme New Status: new Commit summary for MediaWiki.r114271: Added a pipe separator, as requested in bug #34406 Rsterbin's comment: Fixed in r114328; marking new. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113953]: New comment added
Robmoen posted a comment on MediaWiki.r113953. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113953#c32401 Commit summary for MediaWiki.r113953: fix for bug 35245 - add rate limiter and spam filter check Robmoen's comment: JS looks good to me. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] API Bug Triage on Friday
What: API Bug Triage Where: #wikimedia-dev http://webchat.freenode.net/?channels=#wikimedia-dev When: 20:00UTC on Friday, March 23, 2012 Based on a few bug reports and discussion here, I think the time has come for an API bug triage. I've started a thread here: https://www.mediawiki.org/wiki/Project_talk:WikiProject_Bug_Squad Hope to see you there! Mark ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r114274]: Revision status changed
Robmoen changed the status of MediaWiki.r114274 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114274 Old status: new New status: ok Commit summary for MediaWiki.r114274: Added a comment, follow up to r114273. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Setting $wgCategoryCollation to 'uca-default' on WMF wikis
So, how could we check whether Portuguese wikis would break by doing this change? According to Wikipedia, Portuguese sorting is as follows: In addition [to letters that are used in english], the following characters with diacritics are used: Áá, Ââ, Ãã, Àà, Çç, Éé, Êê, Íí, Óó, Ôô, Õõ, Úú. These are not, however, treated as independent letters in collation, nor do they have entries of their own in Portuguese dictionaries. When two words differ only in the presence or absence of a diacritic, the one without it is collated first I just tested on my personal wiki, and can confirm that the ordering when using this setting is as wikipedia describes they should be. I didn't test super-exhaustively, but I feel very confident that this setting would work fine for Portuguese without any further tailorings needed. Here's a screenshot of how uca-default sorts various letters used in Portuguese: http://imgbin.org/images/7280.png . The sort order used is consistent with http://www.evertype.com/alphabets/portuguese.pdf (As far as I can tell, assuming i'm reading that pdf correctly) [from a different email] So, how could we check whether Portuguese wikis would break by doing this change? As Tim said: * Set one of the test wikis (Testwiki, Testwiki2) to Portuguese * change to said collation * do some editing * see if it breaks Note, setting the language to Portuguese is unnecessary as we currently do not support per-language tailoring of the collation. All languages get sorted the same at the moment (there are bugs in bugzilla to change this, and really it should be changed, but such per-language support has yet to be implemented. However even if it was fixed, its unclear if such a setting would be based on wiki content language or not) -bawolff ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Topic Maps
Adding Topic Maps to MW base software could be a winner -- it can generate a wiki-site map (some think WP needs one!); it can be used to corelate the contents of documents loaded into a wiki (like conference proceedings) with a wiki's topic map; and would make a cool tool for any page in a wiki, most clearly on a user page. It's perhaps a smart strategic move - ISO 82250 Topic Maps are the fruit of SGML/Hytime n-ary models that 'lost' to RDF triples back when. Being a superset of RDF, TMs can type associations between articles while capturing all infobox data. Topic maps may be a compelling FUNCTIONAL upgrade for MW as it captures subjects of an article for the first time. Given topic-map to RDF transforms amid continuing W3 research, this could be enough for the semantic world. By adopting say the Lib of Congress' Subject Headings, a wiki like Wikipedia could play an important role in the semantic web. The current situation with Wikipedia is that it's hard to have a large library of information without a subject catalogue... right now, wikis have an author catalogue sort of, fine for smaller hadcrafted wikis but doesn't scale well for many. Since other platforms now have maturing topic map extensions I'm worried the impact on wikis not to have that technology. John McClure ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113195]: Revision status changed
Catrope changed the status of MediaWiki.r113195 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113195 Old status: new New status: ok Commit summary for MediaWiki.r113195: Fixed FileOp::attemptBatch() behavior when unexpected failures occur with the 'force' option. It can't continue on since the ops assumed that $predicates was correct, which it won't be. It now simply halts operations. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114064]: New comment added, and revision status changed
Rsterbin changed the status of MediaWiki.r114064 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114064#c32402 Old Status: fixme New Status: new Commit summary for MediaWiki.r114064: Brought trigger links into the plugin itself; styled flyover panel: - modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js: * Brought in trigger links, standardized them, and added the disable flyover. - New property selectedLinks - New template disableFlyover - Added object triggerLinks (like buckets and ctas) - Added selecting and insertion of trigger links to init() - New methods selectTriggerLinks(), addTriggerLinks(), buildDisableFlyover(), and clickTriggerLink() - Updated buildLink() to handle a flexible number of replacements, and to handle tags other than links - modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css: - Updated flyover styles to match latest mockup and to work with both link E and link A - Added trigger link styles from ext.articleFeedbackv5.css - modules/ext.articleFeedbackv5/ext.articleFeedbackv5.css: - Removed trigger link styles - modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js: - Removed building of trigger links - Plugin is now attached after it's been added to the page, so that trigger links can be inserted relative to it - ArticleFeedbackv5.i18n.php: - Changed messages and wording to match latest mockup - Put in real doc lines - ArticleFeedbackv5.hooks.php: - Updated to match new messages Rsterbin's comment: Fixed in followups; marking back to new. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114333]: Revision status changed
Catrope changed the status of MediaWiki.r114333 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114333 Old status: new New status: ok Commit summary for MediaWiki.r114333: Followup to r114328; tipsy apparently dislikes tooltips without a height ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114328]: Revision status changed
Catrope changed the status of MediaWiki.r114328 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114328 Old status: new New status: resolved Commit summary for MediaWiki.r114328: Followup to r114271 and r114064: - Fixed up the disable flyover message to be less stupid (and now without line breaks) - Added prefixes to the tipsy css rules; however, this caused the whole thing to shift ~200px upward -- passing to Yoni for help - Made the regex in $.articleFeedbackv5.buildLink() global -- stil working on solution to other issues - Updated Link A to use the pipe-selector message rather than a literal pipe character ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114064]: Revision status changed
Catrope changed the status of MediaWiki.r114064 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114064 Old status: new New status: resolved Commit summary for MediaWiki.r114064: Brought trigger links into the plugin itself; styled flyover panel: - modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js: * Brought in trigger links, standardized them, and added the disable flyover. - New property selectedLinks - New template disableFlyover - Added object triggerLinks (like buckets and ctas) - Added selecting and insertion of trigger links to init() - New methods selectTriggerLinks(), addTriggerLinks(), buildDisableFlyover(), and clickTriggerLink() - Updated buildLink() to handle a flexible number of replacements, and to handle tags other than links - modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css: - Updated flyover styles to match latest mockup and to work with both link E and link A - Added trigger link styles from ext.articleFeedbackv5.css - modules/ext.articleFeedbackv5/ext.articleFeedbackv5.css: - Removed trigger link styles - modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js: - Removed building of trigger links - Plugin is now attached after it's been added to the page, so that trigger links can be inserted relative to it - ArticleFeedbackv5.i18n.php: - Changed messages and wording to match latest mockup - Put in real doc lines - ArticleFeedbackv5.hooks.php: - Updated to match new messages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114329]: Revision status changed
Catrope changed the status of MediaWiki.r114329 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114329 Old status: new New status: ok Commit summary for MediaWiki.r114329: Followup to r114064 -- fixed scope leakage ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113540]: Revision status changed
Catrope changed the status of MediaWiki.r113540 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113540 Old status: new New status: ok Commit summary for MediaWiki.r113540: Make sure ForkController nukes any connection resources that backends might have before forking ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114335]: Revision status changed
Robmoen changed the status of MediaWiki.r114335 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114335 Old status: new New status: ok Commit summary for MediaWiki.r114335: Revert r107309, r113601, r113704, r113742, r113792, r113838, r113859, r113893, r113894, r113952, r114047, r114252, r114256, r114257. This reverts the remaining 'new' revisions in core. All of these revisions are tagged with 'gerritmigration' and will be resubmitted into Gerrit after the Gerrit switchover. See also http://lists.wikimedia.org/pipermail/wikitech-l/2012-March/059124.html ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113412]: Revision status changed
Catrope changed the status of MediaWiki.r113412 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113412 Old status: new New status: ok Commit summary for MediaWiki.r113412: [FileBackend] Made doOperations() Status handling align with documentation as well as what FileRepo is essentially expecting when using the 'force' option (it assumes fatals are for total batch failures, not just partial ones). The relevant documentation was also improved. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114332]: Revision status changed
Awjrichards changed the status of MediaWiki.r114332 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114332 Old status: new New status: ok Commit summary for MediaWiki.r114332: remove index from array ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114336]: Revision status changed
Awjrichards changed the status of MediaWiki.r114336 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114336 Old status: new New status: ok Commit summary for MediaWiki.r114336: fix beta logo ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114339]: Revision status changed
Preilly changed the status of MediaWiki.r114339 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114339 Old status: new New status: ok Commit summary for MediaWiki.r114339: Followup r114332, r114336 - updating in MobileFrontend.php to reflect changes to custom logo handling in ExtMobileFrontend::setDefaultLogo() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114295]: Revision status changed
Catrope changed the status of MediaWiki.r114295 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114295 Old status: new New status: ok Commit summary for MediaWiki.r114295: Follow-up r113741: sentence case ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114341]: Revision status changed
Preilly changed the status of MediaWiki.r114341 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114341 Old status: new New status: ok Commit summary for MediaWiki.r114341: Making sure that useformat=mobile-wap is honored ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Video codecs and mobile
On Tuesday, March 20, 2012, David Gerard dger...@gmail.com wrote: On 20 March 2012 19:06, Ian Baker i...@wikimedia.org wrote: * WebM (aka VP8) is really not bad, but is technically inferior to h.264 Main and High Profiles[1]. This comparison appears specious in the context of this thread, which is the iPhone - the iPhone (which is the context of this thread) doesn't support Main or High, only Baseline. How does VP8 compare to H.264 Baseline profile? (Up to 640x480, 'cos the iPhone doesn't go any higher of course. Is the proposal to limit Wikimedia video to 640x480 as well, for the mobile market?) The iPhone 4s can play 1080p videos according to specs (scaled down to fit 960x640 of course). Several high-end phones now have 720p screens, and are happy to play matching media. Tablets running related operating systems have screen resolutions running from 1024x600 to 2048x1536. Other phones with smaller screens, or on slow networks, might prefer to consume smaller files. TimedMediaHandler provides us the ability to generate transcodes at several suitable sizes/bit rates. This is par for the course for video upload sites, and simply brings us into line with standard industry practice. We would already, per plan, be producing both smaller SD and larger HD files. We can also produce Theora, WebM, *and* h.264 versions, or some subset thereof, though additional formats mean more disk space and more transcode time on upload. But on a lot of devices, h.264 is the only realistic playback option. Java's not available, JavaScript's not fast enough on little ARM CPUs. A dedicated app might work (using more battery due to limited acceleration) but would require additional installation with no benefit to the end-user, who has already paid the patent license for the h.264 decoder in their device as part of its price. Our commitment to user freedom means we need to use patent-unencumbered formats so *anyone* can use our stuff, including those on free platforms who may not have a licensed h.264 decoder. The idea isn't actually to *limit* our users to only free platforms. I think we do need to consider reach and user experience here. -- brion - d. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Setting $wgCategoryCollation to 'uca-default' on WMF wikis
On 21/03/12 10:48, bawolff wrote: Here's a screenshot of how uca-default sorts various letters used in Portuguese: http://imgbin.org/images/7280.png . The sort order used is consistent with http://www.evertype.com/alphabets/portuguese.pdf (As far as I can tell, assuming i'm reading that pdf correctly) Good enough for me. If pt.wp is happy being a guinea pig, then let's open a separate shell bug for it. Then we can work out the scheduling. -- Tim Starling ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113221]: New comment added
Bawolff posted a comment on MediaWiki.r113221. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113221#c32403 Commit summary for MediaWiki.r113221: (bug 34302) Add CSS classes to email fields in user preferences Patch by Nischay Nahata whom I have mentored earlier this week. Bawolff's comment: I'm not a fan how this highlights your email red for not-authenticated, even if $wgEmailAuthentication is false. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113451]: New comment added
Kaldari posted a comment on MediaWiki.r113451. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113451#c32404 Commit summary for MediaWiki.r113451: PageTriage new tables, getMetaData API and database access file Kaldari's comment: Is there any reason that pagetriage_page needs its own id? It seems to me that we could just use the page id as the primary id for that table. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Gadget copy script
In the past few months, I've needed to test gadgets that are used on WMF sites, but didn't have an easy way to copy them from, say, Commons to Beta in Labs. I hacked something together and then forgot about it until Chris McMahon (the WMF's new QA guy) wanted something similar for one of his test wikis a couple of weeks ago. I couldn't find it, so last night I rewrote the script from scratch. The script is pretty ugly and, normally, I might commit it to SVN and work on it there, but we're in the process of moving to Git, so I've gone ahead and created a gitorious repository: https://gitorious.org/wiki-gadgets Lots of hard-coding that could be cleaned up, and it could use the API to copy from one wiki to another, but its a start. I'm sharing it here so that other people can begin to use it. It just blats the import-able file out on standard output for now, and it only copies from Commons, so it should be used in the following way: $ php dupe-gadgets.php import-this-file.xml [ Go to Special:Import on your wiki and import. ] I hope that it helps someone! -- Mark A. Hershberger Bugmeister Wikimedia Foundation m...@wikimedia.org ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r111668]: Revision status changed
^demon changed the status of MediaWiki.r111668 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111668 Old status: new New status: ok Commit summary for MediaWiki.r111668: Seeing as just including a maintenance script to be subclassed means the original one is just executed, move the class into it's own file, and require it back into it's old maintenance script home Then have the subclassed maintenance script include the file without the maintenance wrappers itself ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113583]: Revision status changed
^demon changed the status of MediaWiki.r113583 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113583 Old status: new New status: ok Commit summary for MediaWiki.r113583: Bug 35156 - Harmonise spelling of getArticleID() and getArticleId() Mass change -getArticleId() to -getArticleID() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114183]: Revision status changed
^demon changed the status of MediaWiki.r114183 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114183 Old status: new New status: ok Commit summary for MediaWiki.r114183: r114156: Update keys. 1 to ignore, 1 optional ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114059]: New comment added, and revision status changed
^demon changed the status of MediaWiki.r114059 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114059#c32405 Old Status: deferred New Status: fixme Commit summary for MediaWiki.r114059: work on special:studentactivity ^demon's comment: Rather than using $_GET directly, you can use WebRequest's getQueryValues(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113669]: New comment added, and revision status changed
^demon changed the status of MediaWiki.r113669 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113669#c32406 Old Status: fixme New Status: new Commit summary for MediaWiki.r113669: Completing the form fields. ^demon's comment: Not true, see line 62. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114128]: New comment added
^demon posted a comment on MediaWiki.r114128. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114128#c32407 Commit summary for MediaWiki.r114128: Added TranslationNotificationsHooks and a callback for logging. Added very basic logging. Renamed form fields variables and function name to something more meaningful. Added loading of autocomplete module. ^demon's comment: Public static variables are just global variables in disguise--regular members with accessors is much better. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98081]: Revision status changed
^demon changed the status of MediaWiki.r98081 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98081 Old status: fixme New status: new Commit summary for MediaWiki.r98081: New extension that adds a checkbox to Special:UserLogin/signup and requires users to check it in order for their account to be created (ping bug #28107). This extension is required if you have a wiki with SocialProfile extension and you want to give out points to users for referring new users to the wiki. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] [Mediawiki-l] Gadget copy script
Why are we importing gadgets to new sites, I thought that the whole purpose of ResourceLoader was to stop the proliferation of gadgets and especially versions of gadgets. In fact we have been trying to look to standardise and align the gadgets to a master copy in a number of places. Regards, Andrew On Tue, 20 Mar 2012 22:15:05 -0400, m...@wikimedia.org (Mark A. Hershberger) wrote: In the past few months, I've needed to test gadgets that are used on WMF sites, but didn't have an easy way to copy them from, say, Commons to Beta in Labs. I hacked something together and then forgot about it until Chris McMahon (the WMF's new QA guy) wanted something similar for one of his test wikis a couple of weeks ago. I couldn't find it, so last night I rewrote the script from scratch. The script is pretty ugly and, normally, I might commit it to SVN and work on it there, but we're in the process of moving to Git, so I've gone ahead and created a gitorious repository: https://gitorious.org/wiki-gadgets Lots of hard-coding that could be cleaned up, and it could use the API to copy from one wiki to another, but its a start. I'm sharing it here so that other people can begin to use it. It just blats the import-able file out on standard output for now, and it only copies from Commons, so it should be used in the following way: $ php dupe-gadgets.php import-this-file.xml [ Go to Special:Import on your wiki and import. ] I hope that it helps someone! ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r109666]: Revision status changed
^demon changed the status of MediaWiki.r109666 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109666 Old status: fixme New status: resolved Commit summary for MediaWiki.r109666: added checkoutResult() for generating more informative user-facing errors ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Topic Maps
Hi John! Could you provide some links on how the Topic Maps are used in modern wikis and information systems? There is a big family of Semantic Extensions [1] that allow to export wikipages to RDF, isn't this enough? [1] http://semantic-mediawiki.org/wiki/Help:SMW_extensions - Yury Katkov On Wed, Mar 21, 2012 at 6:53 AM, John McClure jmccl...@hypergrove.com wrote: Adding Topic Maps to MW base software could be a winner -- it can generate a wiki-site map (some think WP needs one!); it can be used to corelate the contents of documents loaded into a wiki (like conference proceedings) with a wiki's topic map; and would make a cool tool for any page in a wiki, most clearly on a user page. It's perhaps a smart strategic move - ISO 82250 Topic Maps are the fruit of SGML/Hytime n-ary models that 'lost' to RDF triples back when. Being a superset of RDF, TMs can type associations between articles while capturing all infobox data. Topic maps may be a compelling FUNCTIONAL upgrade for MW as it captures subjects of an article for the first time. Given topic-map to RDF transforms amid continuing W3 research, this could be enough for the semantic world. By adopting say the Lib of Congress' Subject Headings, a wiki like Wikipedia could play an important role in the semantic web. The current situation with Wikipedia is that it's hard to have a large library of information without a subject catalogue... right now, wikis have an author catalogue sort of, fine for smaller hadcrafted wikis but doesn't scale well for many. Since other platforms now have maturing topic map extensions I'm worried the impact on wikis not to have that technology. John McClure ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r114273]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r114273 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114273 Old status: new New status: ok Commit summary for MediaWiki.r114273: Added the ability to test extended keyboard layouts. Added tests for Hebrew extended keys. Made mr string more consistent. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113669]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r113669 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113669 Old status: new New status: ok Commit summary for MediaWiki.r113669: Completing the form fields. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] WURFL licensing concerns and Git migration
Our MobileFrontend extension, which is currently deployed on Wikimedia sites, uses WURFL to detect the mobile devices it targets. However, I recently became aware the version of the WURFL data files we use has a rather restrictive license. http://tech.groups.yahoo.com/group/wmlprogramming/message/34311 The license seems to suggest we are not even supposed to redistribute verbatim copies or install the data files on multiple servers rather than only making [...] one copy [...], if not merely fail to grant such permission. Currently, the files are in our Subversion repository and are going to end up in Git soon. I am not a lawyer, and I realize this is probably a matter for the Wikimedia Foundation to handle, albeit one of urgent importance to us. If I am not mistaken, proper removal of infringing material from Git repositories is somewhat painful in that it causes all child SHA-1 hashes to change, so I feel resolution of the above licensing concern blocks Git migration of at least the MobileFrontend extension. -- Wikipedia user PleaseStand http://en.wikipedia.org/wiki/User:PleaseStand ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] GSOC Proposal: Watchlist Improvements
Hello, My name is Aaron Pramana and I am a prospective student for GSOC with Mediawiki. A week ago, I posted a brief explanation of my idea on a bug fix page, but I haven't had time to elaborate on the Wikitech list, as Sumana suggested I do. This proposal is an amalgamation of several small improvements which will make the watchlist more accessible. My goal for this project is to retrofit the watchlist with an emphasis on improving the workflow for current and potential power-users. Objectives: *add a way to group similar pages into subdirectories (e.g. Special:Watchlist/GroupName) *allow bulk watchlist modifications (rollback/unwatch) with checkboxes *unify the watched changes, view/edit sections *incorporate ajax for actions that don't require a page reload (if time allows) Does anyone have additional features/bugs that they'd like to see added/fixed on the watchlist? Please provide links to bug requests if they exist. Over the next week or so, I should be more responsive to replies as my school will be on Spring Break. I am about halfway finished with a proposal, so it should be available for review then. Please let me know if my ideas have potential for a successful proposal and if there is anything I can add. Thanks! ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] GSOC Proposal: Watchlist Improvements
On Tue, Mar 20, 2012 at 9:26 PM, Aaron Pramana aa...@sociotopia.com wrote: Hello, My name is Aaron Pramana and I am a prospective student for GSOC with Mediawiki. A week ago, I posted a brief explanation of my idea on a bug fix page, but I haven't had time to elaborate on the Wikitech list, as Sumana suggested I do. This proposal is an amalgamation of several small improvements which will make the watchlist more accessible. My goal for this project is to retrofit the watchlist with an emphasis on improving the workflow for current and potential power-users. Objectives: *add a way to group similar pages into subdirectories (e.g. Special:Watchlist/GroupName) *allow bulk watchlist modifications (rollback/unwatch) with checkboxes *unify the watched changes, view/edit sections *incorporate ajax for actions that don't require a page reload (if time allows) Does anyone have additional features/bugs that they'd like to see added/fixed on the watchlist? Please provide links to bug requests if they exist. Over the next week or so, I should be more responsive to replies as my school will be on Spring Break. I am about halfway finished with a proposal, so it should be available for review then. Please let me know if my ideas have potential for a successful proposal and if there is anything I can add. Thanks! ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l Aaron, I like all the features you proposed, but can we start a MediaWiki.org page to list ideas? Watchlists are one of the core parts of our experience as editors, so lots more Wikipedians than the ones on this list will have good suggestions for you. (Apologies if I'm contradicting any process that's been advocated for GSOC proposals.) Regards, Steven Walling ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Head's up: Fwd: WURFL licensing concerns and Git migration
Forwarded to legal. -- Forwarded message -- From: Kevin Israel Date: Tuesday, March 20, 2012 Subject: [Wikitech-l] WURFL licensing concerns and Git migration To: wikitech-l@lists.wikimedia.org Our MobileFrontend extension, which is currently deployed on Wikimedia sites, uses WURFL to detect the mobile devices it targets. However, I recently became aware the version of the WURFL data files we use has a rather restrictive license. http://tech.groups.yahoo.com/group/wmlprogramming/message/34311 The license seems to suggest we are not even supposed to redistribute verbatim copies or install the data files on multiple servers rather than only making [...] one copy [...], if not merely fail to grant such permission. Currently, the files are in our Subversion repository and are going to end up in Git soon. I am not a lawyer, and I realize this is probably a matter for the Wikimedia Foundation to handle, albeit one of urgent importance to us. If I am not mistaken, proper removal of infringing material from Git repositories is somewhat painful in that it causes all child SHA-1 hashes to change, so I feel resolution of the above licensing concern blocks Git migration of at least the MobileFrontend extension. -- Wikipedia user PleaseStand http://en.wikipedia.org/wiki/User:PleaseStand ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Sent from my iPad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] WURFL licensing concerns and Git migration
Yes, ScientiaMobile has made some very important changes to the license and it does mean (AFAIK) that you cannot store the wurfl.xml in a repository. This paragraph is particularly important: You are not authorized to create a derivative work of or otherwise modify this WURFL file, and you are further not authorized to use, copy, display, or distribute, in each case, any derivative work of this WURFL file, whether created by you or someone else. I think it's best with waiting to put the file in git and I'll forward this question to the legal team. Best, Diederik On Wed, Mar 21, 2012 at 12:03 AM, Kevin Israel pleasest...@live.com wrote: Our MobileFrontend extension, which is currently deployed on Wikimedia sites, uses WURFL to detect the mobile devices it targets. However, I recently became aware the version of the WURFL data files we use has a rather restrictive license. http://tech.groups.yahoo.com/group/wmlprogramming/message/34311 The license seems to suggest we are not even supposed to redistribute verbatim copies or install the data files on multiple servers rather than only making [...] one copy [...], if not merely fail to grant such permission. Currently, the files are in our Subversion repository and are going to end up in Git soon. I am not a lawyer, and I realize this is probably a matter for the Wikimedia Foundation to handle, albeit one of urgent importance to us. If I am not mistaken, proper removal of infringing material from Git repositories is somewhat painful in that it causes all child SHA-1 hashes to change, so I feel resolution of the above licensing concern blocks Git migration of at least the MobileFrontend extension. -- Wikipedia user PleaseStand http://en.wikipedia.org/wiki/User:PleaseStand ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r102718]: New comment added
^demon posted a comment on MediaWiki.r102718. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102718#c32408 Commit summary for MediaWiki.r102718: Add really basic RT linker Granted, it's not open to everyone, but having RT linking for those who can is rather useful Should probably standardise the format a little, and work out if we need a more complex regex ^demon's comment: While you're here, we should go ahead and do one for gerrit. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102718]: Revision status changed
^demon changed the status of MediaWiki.r102718 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102718 Old status: deferred New status: ok Commit summary for MediaWiki.r102718: Add really basic RT linker Granted, it's not open to everyone, but having RT linking for those who can is rather useful Should probably standardise the format a little, and work out if we need a more complex regex ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113874]: Revision status changed
^demon changed the status of MediaWiki.r113874 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113874 Old status: new New status: ok Commit summary for MediaWiki.r113874: added README and INSTALL files, stubs where the unit tests will someday go ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112251]: Revision status changed
^demon changed the status of MediaWiki.r112251 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112251 Old status: new New status: ok Commit summary for MediaWiki.r112251: increased wgRSSFetchTimeout default from 5 to 15 seconds - many sites are too slow. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112709]: New comment added
^demon posted a comment on MediaWiki.r112709. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112709#c32409 Commit summary for MediaWiki.r112709: function name typo correction. Version number update ^demon's comment: I'm not sure a capitalization fix requires a new version ;-) In any case--you also changed a default setting, what was the rationale for that? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113508]: New comment added
^demon posted a comment on MediaWiki.r113508. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113508#c32410 Commit summary for MediaWiki.r113508: add tracking category feature (enabled by default). Each page using this extensions get automatically the tracking category with MediaWiki:Rss-tracking-category name (= RSS). Tracking-Cat-Feature can be disabled, or a different MediaWiki message text can be assigned. Documentation of the switch is inline and follows on MediaWiki. ^demon's comment: Rather than defaulting to true and having an extra comparison, wouldn't it be simpler to just default to the string? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113524]: Revision status changed
^demon changed the status of MediaWiki.r113524 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113524 Old status: new New status: ok Commit summary for MediaWiki.r113524: beautifying the tracking category name ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113546]: Revision status changed
^demon changed the status of MediaWiki.r113546 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113546 Old status: new New status: ok Commit summary for MediaWiki.r113546: adding casts. better ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114168]: Revision status changed
^demon changed the status of MediaWiki.r114168 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114168 Old status: new New status: ok Commit summary for MediaWiki.r114168: removed the redundant code for handling tracking categories. By using '-' for the message text rss-tracking-category , this can be disabled easily. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113508]: New comment added, and revision status changed
^demon changed the status of MediaWiki.r113508 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113508#c32411 Old Status: new New Status: resolved Commit summary for MediaWiki.r113508: add tracking category feature (enabled by default). Each page using this extensions get automatically the tracking category with MediaWiki:Rss-tracking-category name (= RSS). Tracking-Cat-Feature can be disabled, or a different MediaWiki message text can be assigned. Documentation of the switch is inline and follows on MediaWiki. ^demon's comment: Nevermind, got it in the followup r114168 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111378]: New comment added
^demon posted a comment on MediaWiki.r111378.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111378#c32412
Commit summary for MediaWiki.r111378:
[RL] Comment mod and other minor changes
_ Add comment about why it casts to (object)
- Modify function comment
- Whitespace (start the function body on a new line in debug mode. In
production mode this is trimmed away afterwards)
- Remove the jQuery-$ passage from loader. There is already a global alias for
$ by jQuery, and aside from that every module has it's own (function(){})
wrapper that aliases it from jQuery (not from $), so there is no performance
gain either by having it locally here since it doesn't use that.
^demon's comment:
+1
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113947]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r113947 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113947 Old status: new New status: ok Commit summary for MediaWiki.r113947: Added very basic support for actual emailing. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114093]: Revision status changed
^demon changed the status of MediaWiki.r114093 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114093 Old status: new New status: ok Commit summary for MediaWiki.r114093: * Follow-up r39787: Fix issue with message in case a block will not expire (indefinite block). Mimicked core message 'blockedtext' as much as possible as well as code from Title.php. * Update formatting and a variable name. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113665]: Revision status changed
^demon changed the status of MediaWiki.r113665 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113665 Old status: new New status: ok Commit summary for MediaWiki.r113665: Bug 27812 - Make ExtensionDistributor work with Git Abstract out VCS base stuff, add code to handle based on version control system Used Status objects in refactored code svn-invoker.php isn't quite finished, so will be coming in a followup commit ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113813]: New comment added, and revision status changed
^demon changed the status of MediaWiki.r113813 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113813#c32413 Old Status: new New Status: ok Commit summary for MediaWiki.r113813: Bug 27812 - Make ExtensionDistributor work with Git Added gitGetRev and possibly unneeded isGitDir/isSvnDir from cron.php. Soem refactoring of method names Still need to actually make use of the git code in svn-invoker.php Followup r113665 TODO: Return more useful first 7 chars of SHA1 hash (what github etc do), rather than 40? ^demon's comment: On those todos: For display we'll probably want to use the 7-character version. For actual version comparison, the full sha1 should be used. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113815]: Revision status changed
^demon changed the status of MediaWiki.r113815 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113815 Old status: new New status: ok Commit summary for MediaWiki.r113815: Bug 27812 - Make ExtensionDistributor work with Git Followup r113813, rest of the svn-invoker.php code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113367]: Revision status changed
^demon changed the status of MediaWiki.r113367 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113367 Old status: new New status: ok Commit summary for MediaWiki.r113367: Bug 27246 - Downloading trunk version of ExtensionDistributor gives error Only attempt to include ExtensionFunctions.php if it exists in this extension source tree AND it's used! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111814]: Revision status changed
^demon changed the status of MediaWiki.r111814 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111814 Old status: new New status: ok Commit summary for MediaWiki.r111814: Actually variablise the table/column we're reading user information from - normally, the user table with user_name, but in centralauth, its globaluser and gu_name Yay, no LSB ;) Ping fixme on r106809 I'll check this over post sleep and push when I'm around to babysit it ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113582]: Revision status changed
^demon changed the status of MediaWiki.r113582 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113582 Old status: new New status: deferred Commit summary for MediaWiki.r113582: Remove unused variables Tidy up some older code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113590]: Revision status changed
^demon changed the status of MediaWiki.r113590 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113590 Old status: new New status: ok Commit summary for MediaWiki.r113590: More documentation and fixup of deprecated code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113928]: Revision status changed
^demon changed the status of MediaWiki.r113928 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113928 Old status: new New status: ok Commit summary for MediaWiki.r113928: Followup r104758 Only ever attempt to process a page once, as the synontm is only used for getting a list of articles to edit (ie it doesn't affect the RefreshLinks part), there's no point processing an article more than once ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113929]: Revision status changed
^demon changed the status of MediaWiki.r113929 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113929 Old status: new New status: ok Commit summary for MediaWiki.r113929: MFT r113928 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113964]: Revision status changed
^demon changed the status of MediaWiki.r113964 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113964 Old status: new New status: ok Commit summary for MediaWiki.r113964: Just because we pull a result from the database, doesn't mean it needs fixing. As such, if we pull 50 with nothing to fix, pulling another 50 won't pull anything. And then we're going nowhere Appropriate quote: God gave us offset parameters for a reason. -- Tim Starling ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113965]: Revision status changed
^demon changed the status of MediaWiki.r113965 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113965 Old status: new New status: ok Commit summary for MediaWiki.r113965: MFT r113964 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114138]: Revision status changed
^demon changed the status of MediaWiki.r114138 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114138 Old status: new New status: ok Commit summary for MediaWiki.r114138: Partial revert r114058 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114058]: Revision status changed
^demon changed the status of MediaWiki.r114058 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114058 Old status: ok New status: resolved Commit summary for MediaWiki.r114058: MFT x2 r114057 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114139]: Revision status changed
^demon changed the status of MediaWiki.r114139 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114139 Old status: new New status: ok Commit summary for MediaWiki.r114139: MFT r114138 r114058 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113968]: Revision status changed
^demon changed the status of MediaWiki.r113968 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113968 Old status: new New status: ok Commit summary for MediaWiki.r113968: Fix weighting for pitches in AFTv4, has apparently been broken since its introduction ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114099]: Revision status changed
^demon changed the status of MediaWiki.r114099 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114099 Old status: new New status: ok Commit summary for MediaWiki.r114099: fix 1.19 compat, or at least some of it :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114348]: Revision status changed
^demon changed the status of MediaWiki.r114348 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114348 Old status: new New status: ok Commit summary for MediaWiki.r114348: * fix message key in cleanupSpam script ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114327]: New comment added, and revision status changed
^demon changed the status of MediaWiki.r114327 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114327#c32414 Old Status: new New Status: fixme Commit summary for MediaWiki.r114327: adding our first (mostly bogus) unit test, to test our unit testing ^demon's comment: You should extend MediaWikiTestCase, rather than PHPUnit_Framework_TestCase. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] WURFL licensing concerns and Git migration
On 3/20/2012 11:35 PM, Diederik van Liere wrote: Yes, ScientiaMobile has made some very important changes to the license and it does mean (AFAIK) that you cannot store the wurfl.xml in a repository. ScientiaMobile basically took an open data repository and closed it, the complete opposite of what the WMF is trying to do. I'd strongly suggest looking for real Open solutions like OpenDDR/DeviceMap ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] WURFL licensing concerns and Git migration
On Tue, Mar 20, 2012 at 10:37 PM, Q overlo...@gmail.com wrote: ScientiaMobile basically took an open data repository and closed it, the complete opposite of what the WMF is trying to do. I'd strongly suggest looking for real Open solutions like OpenDDR/DeviceMap And apparently they've been trying to take down legitimate copies, too: http://openddr.org/takedown.html Yikes, that's evil. To the extent we're relying on it today, we should move off it ASAP. -- Erik Möller VP of Engineering and Product Development, Wikimedia Foundation Support Free Knowledge: https://wikimediafoundation.org/wiki/Donate ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
