Problem with editing FAQ and other pages at wiki

[Romanoff Alexei]

Hello!

I've tried editing wine FAQ and several other wiki pages, but failed. When
I click on Preview or Save buttons, I always see error message like

[Errno 31] Too many links:
'/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup'

If you want to report a bug, please save this page and attach it to your
bug report.

A problem occurred in a Python script. Here is the sequence of function
calls leading up to the error, in the order they occurred.

   1.

   /usr/lib/python2.4/site-packages/MoinMoin/request.py in *run*
(self=MoinMoin.request.RequestModPy
   object)
   1. 1170 self.page.send_page(self, msg=msg)
  2. 1171 else:
  3. 1172 handler(self.page.page_name, self)
  4. 1173
  5. 1174 # generate page footer (actions that do not want this footer
  use
   - *handler* = function do_edit
  - *self* = MoinMoin.request.RequestModPy object
  - self.*page* = MoinMoin.Page.Page instance
  - self.page.*page_name* = u'FAQ'
   2.

   /usr/lib/python2.4/site-packages/MoinMoin/wikiaction.py in
*do_edit* (pagename=u'FAQ',
   request=MoinMoin.request.RequestModPy object)
   1. 651 request.form.has_key('button_spellcheck') or
  2. 652 request.form.has_key('button_newwords')):
  3. 653 pg.sendEditor(preview=savetext, comment=comment)
  4. 654
  5. 655 # Preview with mode switch
   - *pg* = MoinMoin.PageEditor.PageEditor instance
  - pg.*sendEditor* = bound method PageEditor.sendEditor of
  MoinMoin.PageEditor.PageEditor instance
  - preview *undefined*
  - *savetext* = u#pragma section-numbers 1\n#language en\n'Tran...,
  it can delete your entire hard drive.\nDeleted/\n
  - *comment* = u'Fixed shell code example with invalid redirection of
  stderr to stdout instead of file'
   3.

   /usr/lib/python2.4/site-packages/MoinMoin/PageEditor.py in
*sendEditor* (self=MoinMoin.PageEditor.PageEditor
   instance, **kw={'comment': u'Fixed shell code example with invalid
   redirection of stderr to stdout instead of file', 'preview': u#pragma
   section-numbers 1\n#language en\n'Tran..., it can delete your entire
   hard drive.\nDeleted/\n})
   1. 284 # Make backup on previews - but not for new empty pages
  2. 285 if preview and raw_body:
  3. 286 self._make_backup(raw_body)
  4. 287
  5. 288 # Generate default content for new pages
   - *self* = MoinMoin.PageEditor.PageEditor instance
  - self.*_make_backup* = bound method PageEditor._make_backup of
  MoinMoin.PageEditor.PageEditor instance
  - *raw_body* = u#pragma section-numbers 1\n#language en\n'Tran...,
  it can delete your entire hard drive.\nDeleted/\n
   4.

   /usr/lib/python2.4/site-packages/MoinMoin/PageEditor.py in
*_make_backup* (self=MoinMoin.PageEditor.PageEditor
   instance, newtext=u#pragma section-numbers 1\n#language en\n'Tran...,
   it can delete your entire hard drive.\nDeleted/\n, **kw={})
   1. 738 intro += _('## backup of page %(pagename)s submitted %(date)s')
  % {
  2. 739 'pagename': pagename, 'date': date,} + u'\n'
  3. 740 backuppage._write_file(intro + newtext)
  4. 741
  5. 742 return backuppage.url(self.request)
   - *backuppage* = MoinMoin.PageEditor.PageEditor instance
  - backuppage.*_write_file* = bound method PageEditor._write_file of
  MoinMoin.PageEditor.PageEditor instance
  - *intro* = u'#acl AlexeiRomanoff:read,write,delete All:\n\n'
  - *newtext* = u#pragma section-numbers 1\n#language en\n'Tran...,
  it can delete your entire hard drive.\nDeleted/\n
   5.

   /usr/lib/python2.4/site-packages/MoinMoin/PageEditor.py in
*_write_file* (self=MoinMoin.PageEditor.PageEditor
   instance, text=u'#acl AlexeiRomanoff:read,write,delete All:\n\n#pra...,
   it can delete your entire hard drive.\nDeleted/\n', action='SAVE',
   comment=u'', extra=u'')
   1. 801 # The local log should be the standard edit log, not the
  2. 802 # underlay copy log!
  3. 803 pagelog = self.getPagePath('edit-log', use_underlay=0,
  isfile=1)
  4. 804 llog = editlog.EditLog(self.request, filename=pagelog,
  5. 805 uid_override=self.uid_override)
   - pagelog *undefined*
  - *self* = MoinMoin.PageEditor.PageEditor instance
  - self.*getPagePath* = bound method PageEditor.getPagePath of
  MoinMoin.PageEditor.PageEditor instance
  - use_underlay *undefined*
  - isfile *undefined*
   6.

   /usr/lib/python2.4/site-packages/MoinMoin/Page.py in *getPagePath*
(self=MoinMoin.PageEditor.PageEditor
   instance, *args=('edit-log',), **kw={'isfile': 1, 'use_underlay': 0})
   1. 348 Return path to the page storage area.
  2. 349
  3. 350 return self.getPageStatus(*args, **kw)[1]
  4. 351
  5. 352 def split_title(self, request, force=0):
   - *self* = MoinMoin.PageEditor.PageEditor instance
  - self.*getPageStatus* = bound method PageEditor.getPageStatus of
  MoinMoin.PageEditor.PageEditor instance
  - *args* = ('edit-log',)
  - *kw* = 

Re: [PATCH 07/17] msvcrt: Added write tests on unicode files

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23835

Your paranoid android.


=== WINEBUILD (build) ===
Patch failed to apply

Re: [PATCH 13/17] msvcrt: Added _setmode tests

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23836

Your paranoid android.


=== WINEBUILD (build) ===
Patch failed to apply

Re: [PATCH 5/5] d3d9/tests: Merge query.c into device.c.

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23841

Your paranoid android.


=== WINEBUILD (build) ===
Patch failed to apply

Re: [PATCH 17/17] msvcrt: Added read tests on unicode files

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23838

Your paranoid android.


=== WINEBUILD (build) ===
Patch failed to apply

Re: [PATCH 4/5] d3d9/tests: Merge buffer.c into device.c.

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23840

Your paranoid android.


=== WINEBUILD (build) ===
Patch failed to apply

Re: [PATCH 05/17] msvcrt: Added fopen_s test with ccs option

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23834

Your paranoid android.


=== WINEBUILD (build) ===
Patch failed to apply

Re: [PATCH] ddraw: Don't discard buffers that haven't been used in draws (try 3)

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23842

Your paranoid android.


=== WINEBUILD (build) ===
Patch failed to apply

Re: Truncate MIDI SysEx messages after termination byte

[Christian Costa]

2013/1/10 Johannes Kroll jkr...@lavabit.com

 On Thu, 10 Jan 2013 01:05:28 +0100
 Johannes Kroll jkr...@lavabit.com wrote:

  On Thu, 10 Jan 2013 00:38:06 +0100
  Christian Costa titan.co...@gmail.com wrote:
 
 
   After a better look the changes seem correct.
   The condition i  lpMidioutHdr-dwBufferLength-1 is not necessary
 tough.
 
  Without the buffer length check, there would be a buffer overflow when
  an application tries to send a SysEx without an F7 byte.

 I meant a read past the end of the buffer of course, not an overflow.



In your code you stop checking F7 just before the last byte (until
position lpMidiOutHdr-dwBufferLength-2);
You can check the last byte as well. This is also valid and simplify the
condition.
The missing F7 byte case is handled by the for loop.

Regarding the single MMDRV_Message call, I was thinking about something
like below.
This also enable printing a WARN when F7 is missing which can be useful for
debug.

DWORD oldBufferLength = lpMidiOutHdr-dwBufferLength;
DWORD ret;

for(i = 0; i  lpMidiOutHdr-dwBufferLength; i++)

   /* SysEx messages are terminated by a 0xF7 byte. If the buffer
contains additional
  bytes, send only the bytes up to the termination byte. */
if((unsigned char)lpMidiOutHdr-lpData[i] == 0xF7)
{
lpMidiOutHdr-dwBufferLength = i+1;

break;

}


if (i == lpMidiOutHdr-dwBufferLength)

WARN(SysEx termination byte 0xF7 missing\n)



ret =  MMDRV_Message(wmld, MODM_LONGDATA, (DWORD_PTR)lpMidiOutHdr,
uSize);

/* restore the midi header to its original state. */
lpMidiOutHdr-dwBufferLength = oldBufferLength;


return ret;

Re: [2/2] comctl32/listview: Use LVM_SETITEMSTATE directly in tests

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23848

Your paranoid android.


=== WINEBUILD (build) ===
Patch failed to apply

Re: [PATCH] d3dx9: Shift only as much as needed.

[Rico Schüller]

Hi,

please don't apply this patch. There are several other occurrences in 
the same file. I'll send an improved version.


Cheers
Rico


On 10.01.2013 13:55, Rico Schüller wrote:

Hi,

this patch removes useless shifts, which may result in wrong data when
the shift is bigger than 24.

Cheers
Rico

---
   dlls/d3dx9_36/texture.c | 15 ---
   1 Datei geändert, 12 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-)

Re: Truncate MIDI SysEx messages after termination byte

[Johannes Kroll]

On Thu, 10 Jan 2013 12:04:02 +0100
Christian Costa titan.co...@gmail.com wrote:

 In your code you stop checking F7 just before the last byte (until
 position lpMidiOutHdr-dwBufferLength-2);
 You can check the last byte as well. This is also valid and simplify the
 condition.
 The missing F7 byte case is handled by the for loop.

Ah, you mean that check. Yes, it's not strictly necessary, it just
decides whether it has to save  restore dwBufferSize or not.


 Regarding the single MMDRV_Message call, I was thinking about something
 like below.
 This also enable printing a WARN when F7 is missing which can be useful for
 debug.
 
 DWORD oldBufferLength = lpMidiOutHdr-dwBufferLength;
 DWORD ret;
 
 for(i = 0; i  lpMidiOutHdr-dwBufferLength; i++)
 
/* SysEx messages are terminated by a 0xF7 byte. If the buffer
 contains additional
   bytes, send only the bytes up to the termination byte. */
 if((unsigned char)lpMidiOutHdr-lpData[i] == 0xF7)
 {
 lpMidiOutHdr-dwBufferLength = i+1;
 
 break;
 
 }
 
 
 if (i == lpMidiOutHdr-dwBufferLength)
 
 WARN(SysEx termination byte 0xF7 missing\n)
 
 
 
 ret =  MMDRV_Message(wmld, MODM_LONGDATA, (DWORD_PTR)lpMidiOutHdr,
 uSize);
 
 /* restore the midi header to its original state. */
 lpMidiOutHdr-dwBufferLength = oldBufferLength;
 
 
 return ret;

I see nothing wrong with that apart from the broken formatting (please
don't use HTML mail). Did you test it?

I don't care which version is used, I would just be very happy if
*something* is included which makes my MIDI device work with Wine.

How does this generally work here, will there be feedback from a
maintainer on whether the patch will be included, or is it usually just
silently included?

Alexandre Julliard (or whoever decides this): Could you comment please?


And Christian, please, configure your mail client. The list mails I get
from you are directed to me, not the list, and they are missing the
List-Id field. 

Re: Truncate MIDI SysEx messages after termination byte

[Christian Costa]

2013/1/10 Johannes Kroll jkr...@lavabit.com

 On Thu, 10 Jan 2013 12:04:02 +0100
 Christian Costa titan.co...@gmail.com wrote:

  In your code you stop checking F7 just before the last byte (until
  position lpMidiOutHdr-dwBufferLength-2);
  You can check the last byte as well. This is also valid and simplify the
  condition.
  The missing F7 byte case is handled by the for loop.

 Ah, you mean that check. Yes, it's not strictly necessary, it just
 decides whether it has to save  restore dwBufferSize or not.


  Regarding the single MMDRV_Message call, I was thinking about something
  like below.
  This also enable printing a WARN when F7 is missing which can be useful
 for
  debug.
 
  DWORD oldBufferLength = lpMidiOutHdr-dwBufferLength;
  DWORD ret;
 
  for(i = 0; i  lpMidiOutHdr-dwBufferLength; i++)
 
 /* SysEx messages are terminated by a 0xF7 byte. If the buffer
  contains additional
bytes, send only the bytes up to the termination byte. */
  if((unsigned char)lpMidiOutHdr-lpData[i] == 0xF7)
  {
  lpMidiOutHdr-dwBufferLength = i+1;
 
  break;
 
  }
 
 
  if (i == lpMidiOutHdr-dwBufferLength)
 
  WARN(SysEx termination byte 0xF7 missing\n)
 
 
 
  ret =  MMDRV_Message(wmld, MODM_LONGDATA, (DWORD_PTR)lpMidiOutHdr,
  uSize);
 
  /* restore the midi header to its original state. */
  lpMidiOutHdr-dwBufferLength = oldBufferLength;
 
 
  return ret;

 I see nothing wrong with that apart from the broken formatting (please
 don't use HTML mail). Did you test it?


It was not intended to be used as is. It's just to show what I had in mind.


 I don't care which version is used, I would just be very happy if
 *something* is included which makes my MIDI device work with Wine.


There is no reason your patch will not get in. Generally, it's just patches
need
to have the quality required to be committed. Sometime it can takes several
iterations.




 How does this generally work here, will there be feedback from a
 maintainer on whether the patch will be included, or is it usually just
 silently included?


 Alexandre Julliard (or whoever decides this): Could you comment please?



For a patch which is ok, it will be committed silently by Alexandre. You
may already
know the patches status page at http://source.winehq.org/patches.
Usually maintainers or skilled people of a specific area look at patches and
give some feedback if something seems wrong or not clear.



 And Christian, please, configure your mail client. The list mails I get
 from you are directed to me, not the list, and they are missing the
 List-Id field.


 When I use gmail web client, I don't have good results sometimes. Maybe
there is a configuration for that.
I'm full open to any hint.
Regarding emails addresses, I write to someone with wine-devel in cc but
I'm ok to use
only wine-devel with you.

Re: [PATCH 3/3] d3dx9: Use all 32 bits as mask.

[Matteo Bruni]

2013/1/10 Rico Schüller kgbric...@web.de:
 ---
  dlls/d3dx9_36/texture.c | 6 +++---
  1 Datei geändert, 3 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-

 -DWORD i, v;
 +DWORD i, v, mask32 = format-bits[c] == 32 ? -1 : ((1  
 format-bits[c]) - 1);

Usually we prefer to use ~0U instead of -1 with unsigned variables.

Nice cleanups and fixes for larger pixel formats. Is this for Alan Wake?

Re: [PATCH 3/3] d3dx9: Use all 32 bits as mask.

[Rico Schüller]

On 10.01.2013 17:13, Matteo Bruni wrote:

2013/1/10 Rico Schüller kgbric...@web.de:

---
  dlls/d3dx9_36/texture.c | 6 +++---
  1 Datei geändert, 3 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-

-DWORD i, v;
+DWORD i, v, mask32 = format-bits[c] == 32 ? -1 : ((1  
format-bits[c]) - 1);


Usually we prefer to use ~0U instead of -1 with unsigned variables.

Nice cleanups and fixes for larger pixel formats. Is this for Alan Wake?

Yes, but alan wake needs only D3DFMT_A16B16G16R16F. I stumbled over the 
tests and I'd like to add later D3DFMT_A32B32G32R32F, thus the 
correction for the mask is needed.


Thanks for the hint, i'll send an improved version.

Cheers
Rico

Re: include: flesh out d3d11.idl

[Nikolay Sivov]

On 1/10/2013 22:35, Austin English wrote:

Some minor things.



+typedef enum D3D11_RESOURCE_DIMENSION
+{
+D3D11_RESOURCE_DIMENSION_UNKNOWN = 0,
+D3D11_RESOURCE_DIMENSION_BUFFER = 1,
+D3D11_RESOURCE_DIMENSION_TEXTURE1D = 2,
+D3D11_RESOURCE_DIMENSION_TEXTURE2D = 3,
+D3D11_RESOURCE_DIMENSION_TEXTURE3D = 4,
+} D3D11_RESOURCE_DIMENSION;
+

You could remove values in cases like that, result will be the same.


+D3D11_BIND_VERTEX_BUFFER = 0x0001L,

I think L suffix could be omitted.


+//FIXME:

...

Re: [2/2] comctl32/listview: Add a special case for deselect all attempt when nothing is selected

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23861

Your paranoid android.


=== WINEBUILD (build) ===
Patch failed to apply

Re: kernel32/tests : try2 added tests for copyfileex

[Dmitry Timoshkov]

Patrick Rudolph s...@das-labor.org wrote:

 try2:
 check the os version in case of PROGRESS_STOP

 +ret = GetFileAttributesEx(dest_name, GetFileExInfoStandard, 
 (void*)fileInfo);
 +
 +/* Windows Vista and newer delete the file, while prior versions don't */
 +ok((!ret  info.dwMajorVersion  5) || (ret  info.dwMajorVersion = 
 5),
 +GetFileAttributesEx return-value wrong, got %u and MajorVersion is 
 %u\n, ret, info.dwMajorVersion);

Then you should mark old behaviour as broken() and don't check Windows
version at all.

-- 
Dmitry.

Re: [PATCH 2/4] kernel32/path : try2 implement copyfileexW progressroutine callback

[Dmitry Timoshkov]

Patrick Rudolph s...@das-labor.org wrote:

 try 2:
 set progress routine pointer to NULL to disable progress reporting
 test osversion and delete destination file on PROGRESS_STOP on vista 
 and newer

This kind of version check is useless in Wine.

-- 
Dmitry.

Re: user32: fix non-BOOL returns in BOOL functions

[Dmitry Timoshkov]

Damjan Jovanovic damjan@gmail.com wrote:

 Changelog:
 * user32: fix non-BOOL returns in BOOL functions

GetClassInfo is special, it actually returns class atom on success,
not just a boolean value. So it's better to leave it as it is now.

-- 
Dmitry.

Re: include: flesh out d3d11.idl (try 2)

[Dmitry Timoshkov]

Austin English austinengl...@gmail.com wrote:

 Try 2:
 Remove L suffixes, C++ comment.

 +/* Forward declarations */

You've copied too much from the PSDK version, better leave it to someone
else, and do it step by step when particular functionality gets implemented.

-- 
Dmitry.

Re: d3dx9: Implement D3DXSHEvalConeLight (resend)

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23862

Your paranoid android.


=== WINEBUILD (build) ===
Patch failed to apply

Re: kernel32/tests : try2 added tests for copyfileex

[siro]

OK, but how do I know that the old behavior is broken ? WindowsXp behaves like msdn quotes while newer windows don't. Do you always assume that the latest implementation is correct ? Should wine just match the latest test-results and ignore osversioninfo at all ?Von: "Dmitry Timoshkov" dmi...@baikal.ruAn: "Patrick Rudolph" s...@das-labor.orgCc: "wine-devel@winehq.org" wine-devel@winehq.orgGesendet: 11. Januar 2013 04:06Betreff: Re: kernel32/tests : try2 added tests for copyfileexPatrick Rudolph  wrote:

 try2:
 check the os version in case of PROGRESS_STOP

 +ret = GetFileAttributesEx(dest_name, GetFileExInfoStandard, (void*)fileInfo);
 +
 +/* Windows Vista and newer delete the file, while prior versions don't */
 +ok((!ret  info.dwMajorVersion  5) || (ret  info.dwMajorVersion = 5),
 +"GetFileAttributesEx return-value wrong, got %u and MajorVersion is %u\n", ret, info.dwMajorVersion);

Then you should mark old behaviour as broken() and don't check Windows
version at all.

-- 
Dmitry.

Re: kernel32/tests : try2 added tests for copyfileex

[Dmitry Timoshkov]

s...@das-labor.org wrote:

 OK, but how do I know that the old behavior is broken ? WindowsXp behaves
 like msdn quotes while newer windows don't. Do you always assume that the
 latest implementation is correct ? Should wine just match the latest
 test-results and ignore osversioninfo at all ?

It's reasonable to assume that a later Windows implementation should be
considered as the one to follow. Changing the reported Windows version in
winecfg doesn't change an API behaviour (there are exceptions, but they
don't apply in this case).

-- 
Dmitry.