[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.3-145-gc302454
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project wmaker-crm.git.
The branch, next has been updated
discards 2cc982fb4bfeef196dd1daaa2d3db98d76e9676c (commit)
This update discarded existing revisions and left the branch pointing at
a previous point in the repository history.
* -- * -- N (c3024542ad3f7c4adf420b437852c50f334a552c)
O -- O -- O (2cc982fb4bfeef196dd1daaa2d3db98d76e9676c)
The removed revisions are not necessarilly gone - if another reference
still refers to them they will stay in the repository.
No new revisions were added by this update.
Summary of changes:
src/appicon.c |3 -
src/defaults.c | 23 +---
src/dock.c |2 -
src/screen.c | 40 +-
src/startup.c |4 --
src/wmspec.c | 160 +++
src/wmspec.h |1 -
7 files changed, 50 insertions(+), 183 deletions(-)
repo.or.cz automatic notification. Contact project admin crma...@gmail.com
if you want to unsubscribe, or site admin ad...@repo.or.cz if you receive
no reply.
--
wmaker-crm.git ("The Window Maker window manager")
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Patch: Partial support for partial struts
Quoth Carlos R. Mafra, wmaker(wScreenUpdateUsableArea(screen.c:762)): warning: usableArea[0]: 0 1920 0 1080 The problem is that there's an infinite loop. wScreenUpdateUsableArea() calls wArrangeIcons(). The icons move so we call wIconUpdateStruts() to set struts and that calls wScreenUpdateUsableArea() again. When you suggested using struts for docks and icons I thought it would be quick and easy to do but it's getting complex in a big hurry and I'm not convinced that we're actually getting any benefit from it. The code to avoid covering the dock and icons worked well and as long as we are still using the existing placement rules we still can't place "under" a vertical stack of icons or "next to" a horizontal stack. If we revamped the placement rules we could fill that empty space without needing struts. I think we should revert commit 2cc982fb4bfeef196dd1daaa2d3db98d76e9676c and I'll look into a new placement method instead further complicating this experiment. The commits leading up to that one could still be useful and should be safe to keep. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Patch: Partial support for partial struts
Quoth Carlos R. Mafra, wmaker(wScreenUpdateUsableArea(screen.c:762)): warning: usableArea[0]: 0 1920 0 1080 I see the problem. The next function in wScreenUpdateUsableArea() is wArrangeIcons(). I have been testing with a vanilla GNUSTEP_USER_ROOT and auto-arrange icons is off by default. If I turn it on I can reproduce your crash. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Patch: Partial support for partial struts
On Tue, 30 Oct 2012 at 15:41:34 -0700, Iain Patterson wrote: > Quoth Carlos R. Mafra, > >This patch makes my wmaker crash when I start any application which > >has an appicon, I tried xcalc and chrome. Starting a xterm with no > >appicon is ok. > > That's no fun. I have icons and they're fine. Can you get a > backtrace? No backtrace, but I've put some wwarning()'s and I got this (I stripped the long file paths that warning() prints before the binary name) wmaker(wIconUpdateStruts(wmspec.c:1766)): warning: I will call setIconStrut now! wmaker(setIconStrut(wmspec.c:1643)): warning: Entered setIconStrut, do_strut=0 wmaker(setIconStrut(wmspec.c:1675)): warning: after do_strut inside setIconStrut wmaker(wIconUpdateStruts(wmspec.c:1768)): warning: I will call updateStrut now wmaker(wIconUpdateStruts(wmspec.c:1771)): warning: I will call wScreenUpdateUsableArea now! wmaker(wScreenUpdateUsableArea(screen.c:762)): warning: usableArea[0]: 0 1920 0 1080 wmaker(MonitorLoop(monitor.c:134)): warning: Window Maker exited due to a crash (signal 11) and will be restarted. X Error of failed request: BadWindow (invalid Window parameter) Major opcode of failed request: 18 (X_ChangeProperty) Resource id in failed request: 0x240005b Serial number of failed request: 911 Current serial number in output stream: 923 wmaker(setIconPosition(defaults.c:2823)): warning: before wIconUpdateStruts wmaker(setIconPosition(defaults.c:2826)): warning: after wIconUpdateStruts -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Patch: Partial support for partial struts
Quoth Rodolfo García Peñas, The patch "Use partial struts to reserve space for icons." do strange behavior. Sounds like they are respecting the struts of other icons. I have an idea how we can solve that... -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Patch: Partial support for partial struts
On Tue, 30 Oct 2012, Carlos R. Mafra escribió: > On Tue, 30 Oct 2012 at 5:29:46 +, Iain Patterson wrote: > > > Subject: [PATCH 3/3] Use partial struts to reserve space for icons. > > > > Calculate the space actually used by app icons and the dock and set > > partial struts on each individual icon where appropriate. Thus the > > screen area reserved by icons is no larger than the space actually > > taken up by those icons. In the, contrived, case that the icons are > > all moved partially offscreen, reserved space will actually shrink. > > --- > > src/appicon.c | 3 ++ > > src/defaults.c | 23 +++-- > > src/dock.c | 2 + > > src/screen.c | 40 +-- > > src/startup.c | 4 ++ > > src/wmspec.c | 160 > > + > > src/wmspec.h | 1 + > > 7 files changed, 183 insertions(+), 50 deletions(-) > > > This patch makes my wmaker crash when I start any application which > has an appicon, I tried xcalc and chrome. Starting a xterm with no > appicon is ok. > > I will try to debug this on the weekend in order to determine > where exactly it goes wrong, unless someone spots the trouble > first :-) > > > -- > To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org. Hi, The patch "Use partial struts to reserve space for icons." do strange behavior. For example, If I launch Xterm, Amarok, and JDownload, the application icons (that in my conf are at bottom-left) should be sometehing like: [amarok][java][XTerm] But with this patch are something like: [amarok] [java][Xterm] or [java][XTerm][Amarok] [64 pixels empty space] Cheers, kix -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Patch: Partial support for partial struts
Quoth Carlos R. Mafra, This patch makes my wmaker crash when I start any application which has an appicon, I tried xcalc and chrome. Starting a xterm with no appicon is ok. That's no fun. I have icons and they're fine. Can you get a backtrace? -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Patch: Partial support for partial struts
On Tue, 30 Oct 2012 at 5:29:46 +, Iain Patterson wrote: > Subject: [PATCH 3/3] Use partial struts to reserve space for icons. > > Calculate the space actually used by app icons and the dock and set > partial struts on each individual icon where appropriate. Thus the > screen area reserved by icons is no larger than the space actually > taken up by those icons. In the, contrived, case that the icons are > all moved partially offscreen, reserved space will actually shrink. > --- > src/appicon.c | 3 ++ > src/defaults.c | 23 +++-- > src/dock.c | 2 + > src/screen.c | 40 +-- > src/startup.c | 4 ++ > src/wmspec.c | 160 > + > src/wmspec.h | 1 + > 7 files changed, 183 insertions(+), 50 deletions(-) This patch makes my wmaker crash when I start any application which has an appicon, I tried xcalc and chrome. Starting a xterm with no appicon is ok. I will try to debug this on the weekend in order to determine where exactly it goes wrong, unless someone spots the trouble first :-) -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
RE: Debian maintainer for wmtime
> Thanks Doug, > > there are more dockapps packages ready for adoption: > > •wmacpi: ACPI battery monitor for WindowMaker (información del > paquete), orphaned since 36 days. > •wmbatppc: Battery monitor for Apple G3/G4 ibooks/powerbooks > (información del paquete), orphaned since 36 days. > •wmbubble: A system-load meter for Window Maker that features a duck > (información del paquete), orphaned since 481 days. > •wmcdplay: A CD player based on ascd designed for WindowMaker > (información del paquete), orphaned since 481 days. > •wmclock: dockable clock applet for Window Maker (información del > paquete), orphaned since 36 days. > •wmhdplop: hard drive activity monitor dockapp (información del > paquete), orphaned since today. > •wmnd: Dockapp monitoring network interfaces (información del paquete), > orphaned since today. > •wmppp.app: PPP dial control and network load monitor with NeXTStep > look (información del paquete), orphaned since 228 days. > •wmrack: Combined CD Player + Mixer designed for WindowMaker > (información del paquete), orphaned since 228 days. > > +info: http://www.debian.org/devel/wnpp/orphaned > > Cheers, > kix > -- > ||// //\\// Rodolfo "kix" Garcia > ||\\// //\\ http://www.kix.es/ Look at all of those! I'll take a look, maybe I'll pick up a couple more. Doug
[PATCH] wmtime bugfixes
I've applied the two patches to wmtime from the Debian bug tracking system. Doug 0001-wmtime-Fixed-Debian-bug-639626.-Applied-a-patch-by-A.patch Description: Binary data 0001-wmtime-Fixed-Debian-bug-661843.-Applied-a-patch-by-M.patch Description: Binary data
[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.3-146-g2cc982f
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project wmaker-crm.git.
The branch, next has been updated
via 2cc982fb4bfeef196dd1daaa2d3db98d76e9676c (commit)
via c3024542ad3f7c4adf420b437852c50f334a552c (commit)
via 700f8cc706e8bdceb4675d7de77c05e35b37f200 (commit)
via 67f73e9d54b37e241a8275803b2bf328d3a740d4 (commit)
from 930e59dd3142a4ceba46826183e13d67b420e3de (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
http://repo.or.cz/w/wmaker-crm.git/commit/2cc982fb4bfeef196dd1daaa2d3db98d76e9676c
commit 2cc982fb4bfeef196dd1daaa2d3db98d76e9676c
Author: Iain Patterson
Date: Mon Oct 29 15:54:12 2012 -0700
Use partial struts to reserve space for icons.
Calculate the space actually used by app icons and the dock and set
partial struts on each individual icon where appropriate. Thus the
screen area reserved by icons is no larger than the space actually
taken up by those icons. In the, contrived, case that the icons are
all moved partially offscreen, reserved space will actually shrink.
diff --git a/src/appicon.c b/src/appicon.c
index 77c5e30..cc2f7d8 100644
--- a/src/appicon.c
+++ b/src/appicon.c
@@ -50,6 +50,7 @@
#ifdef XDND
#include "xdnd.h"
#endif
+#include "wmspec.h"
/*
* icon_file for the dock is got from the preferences file by
@@ -345,6 +346,8 @@ void wAppIconMove(WAppIcon * aicon, int x, int y)
XMoveWindow(dpy, aicon->icon->core->window, x, y);
aicon->x_pos = x;
aicon->y_pos = y;
+ wIconUpdateStruts(aicon->icon->core->screen_ptr,
wPreferences.no_window_over_dock, True);
+ wIconUpdateStruts(aicon->icon->core->screen_ptr,
wPreferences.no_window_over_icons, False);
}
#ifdef WS_INDICATOR
diff --git a/src/defaults.c b/src/defaults.c
index 458093c..79a5b68 100644
--- a/src/defaults.c
+++ b/src/defaults.c
@@ -61,6 +61,7 @@
#include "dock.h"
#include "workspace.h"
#include "properties.h"
+#include "wmspec.h"
#define MAX_SHORTCUT_LENGTH 32
@@ -147,6 +148,7 @@ static int setClipTitleColor();
static int setMenuStyle();
static int setSwPOptions();
static int updateUsableArea();
+static int updateIconStruts();
static int setModifierKeyLabels();
@@ -419,9 +421,9 @@ WDefaultEntry optionList[] = {
{"AutoArrangeIcons", "NO", NULL,
&wPreferences.auto_arrange_icons, getBool, NULL, NULL, NULL},
{"NoWindowOverDock", "NO", NULL,
- &wPreferences.no_window_over_dock, getBool, updateUsableArea, NULL,
NULL},
+ &wPreferences.no_window_over_dock, getBool, updateIconStruts, NULL,
NULL},
{"NoWindowOverIcons", "NO", NULL,
- &wPreferences.no_window_over_icons, getBool, updateUsableArea,
NULL, NULL},
+ &wPreferences.no_window_over_icons, getBool, updateIconStruts,
NULL, NULL},
{"WindowPlaceOrigin", "(0, 0)", NULL,
&wPreferences.window_place_origin, getCoord, NULL, NULL, NULL},
{"ResizeDisplay", "corner", seGeomDisplays,
@@ -2818,7 +2820,8 @@ static int setKeyGrab(WScreen * scr, WDefaultEntry *
entry, WShortKey * shortcut
static int setIconPosition(WScreen * scr, WDefaultEntry * entry, void *bar,
void *foo)
{
- wScreenUpdateUsableArea(scr);
+ /* Disregard struts when rearranging. */
+ wIconUpdateStruts(scr, 0, 0);
wArrangeIcons(scr, True);
return 0;
@@ -2831,6 +2834,20 @@ static int updateUsableArea(WScreen * scr, WDefaultEntry
* entry, void *bar, voi
return 0;
}
+static int updateIconStruts(WScreen * scr, WDefaultEntry * entry, void *value,
void *foo)
+{
+ Bool do_strut = *((Bool *)value);
+ Bool only_docked = 0;
+
+ /* Same function for docked and undocked icons. */
+ if (strcmp(entry->key, "NoWindowOverDock") == 0)
+ only_docked = 1;
+
+ wIconUpdateStruts(scr, do_strut, only_docked);
+
+ return 0;
+}
+
static int setMenuStyle(WScreen * scr, WDefaultEntry * entry, int *value, void
*foo)
{
return REFRESH_MENU_TEXTURE;
diff --git a/src/dock.c b/src/dock.c
index c90ae93..6ba0e76 100644
--- a/src/dock.c
+++ b/src/dock.c
@@ -54,6 +54,7 @@
#include "framewin.h"
#include "superfluous.h"
#include "xinerama.h"
+#include "wmspec.h"
/ Local variables /
#define CLIP_REWIND 1
@@ -2626,6 +2627,7 @@ static void moveDock(WDock *dock, int new_x, int new_y)
XMoveWindow(dpy, btn->icon->core->window, btn->x_pos,
btn->y_pos);
}
}
+ wIconUpdateStruts(dock->screen_ptr, wPreferences.no_window_over_dock,
True);
}
static void swapDock(WDock *dock)
diff --git a/src/screen.c b/src/screen.c
index 2efe7c3..ffa9a8c 100644
--- a/src/screen.c
+++
Re: Patch: Partial support for partial struts
On Tue, 30 Oct 2012 at 9:42:05 -0700, Iain Patterson wrote: > Quoth Carlos R. Mafra, > >The patches are going to be applied, they are very cool and have > >a lot of potential. > > Ironically I have been a little counterproductive to myself > (hopefully not to users in general) with this work. > > I like Window Maker for many reasons but its use of app icons is > not among them. I don't like icons on my desktop and I just find > they get in the way. On my (small screen) laptop I have no dock and > the icons set to 24x24 arranged at the top of the screen. I then > run xfce4-panel set to a height 24 at the top and it covers the > icons. By setting "don't cover icons" I could ensure that > maximisation didn't clash with the panel and I'd never have to see > them again. > > My desktop has normal 64x64 icons down the side of the screen > where I can mostly ignore them. I found that windows would try to > place under the panel, which was annoying. Now with partial strut > support the panel is protected and life is good on the desktop. > Back on the laptop the icons now refuse to hide under the panel > because they respect its strut. > > I can think of two possible solutions. Either add a preference to > make icons ignore struts and go wherever they like or add a > preference to refrain from placing icons at all. Does anyone else > share my dislike of desktop clutter and have an opinion either way? I don't remember what happened to the patch in that thread, but take a look at how to disable appicons here: http://article.gmane.org/gmane.compw.window-managers.windowmaker.devel/1209/match=option+disable+application+icons -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Patch: Partial support for partial struts
Quoth Carlos R. Mafra, The patches are going to be applied, they are very cool and have a lot of potential. Ironically I have been a little counterproductive to myself (hopefully not to users in general) with this work. I like Window Maker for many reasons but its use of app icons is not among them. I don't like icons on my desktop and I just find they get in the way. On my (small screen) laptop I have no dock and the icons set to 24x24 arranged at the top of the screen. I then run xfce4-panel set to a height 24 at the top and it covers the icons. By setting "don't cover icons" I could ensure that maximisation didn't clash with the panel and I'd never have to see them again. My desktop has normal 64x64 icons down the side of the screen where I can mostly ignore them. I found that windows would try to place under the panel, which was annoying. Now with partial strut support the panel is protected and life is good on the desktop. Back on the laptop the icons now refuse to hide under the panel because they respect its strut. I can think of two possible solutions. Either add a preference to make icons ignore struts and go wherever they like or add a preference to refrain from placing icons at all. Does anyone else share my dislike of desktop clutter and have an opinion either way? -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
RE: Debian maintainer for wmtime
On 2012-10-30 16:16, Doug Torrance wrote: On 2012-10-30 12:21, Paul Harris wrote: > Hi guys, > > Im going to step aside as maintainer of wmtime in the debian repo, I > just dont have the time unfortunately. > > Its easy to maintain (since it works). There are two patches pending > in the debian bugs db (that I didnt see until now), so bug fixing is > done for you! > > Who wants to take over this delightful package? > > cheers, > Paul Hi Paul, sorry, I don't have time for more packages. I can help to maintain the package if anyone wants to do it. Is a nice dockapp, please don't orphane it ;-) OTOH this package is not in the dockapps.git. The idea is upload the original file and then upload the debian proposed patches. Can somebody do it? Cheers, kix -- ||// //\// Rodolfo "kix" Garcia ||\// //\ http://www.kix.es/ I can maintain it. I'll also upload it to git. Doug Torrance Thanks Doug, there are more dockapps packages ready for adoption: •wmacpi: ACPI battery monitor for WindowMaker (información del paquete), orphaned since 36 days. •wmbatppc: Battery monitor for Apple G3/G4 ibooks/powerbooks (información del paquete), orphaned since 36 days. •wmbubble: A system-load meter for Window Maker that features a duck (información del paquete), orphaned since 481 days. •wmcdplay: A CD player based on ascd designed for WindowMaker (información del paquete), orphaned since 481 days. •wmclock: dockable clock applet for Window Maker (información del paquete), orphaned since 36 days. •wmhdplop: hard drive activity monitor dockapp (información del paquete), orphaned since today. •wmnd: Dockapp monitoring network interfaces (información del paquete), orphaned since today. •wmppp.app: PPP dial control and network load monitor with NeXTStep look (información del paquete), orphaned since 228 days. •wmrack: Combined CD Player + Mixer designed for WindowMaker (información del paquete), orphaned since 228 days. +info: http://www.debian.org/devel/wnpp/orphaned Cheers, kix -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Patch: Partial support for partial struts
On Tue, 30 Oct 2012 at 9:14:34 -0700, Iain Patterson wrote: > Subject: [PATCH] Brief documentation on wAppIconFor() and wWindowFor(). > > Brief comment on what wAppIconFor() and wWindowFor() do, as it > may not be immediately obvious. > > Given a raw X11 Window they will find the AppIcon (or WWindow, > respectively) associated with that window. Thus they can map an > X11 object to a Window Maker internal object. Lovely. Thanks a lot, Iain! -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Patch: Partial support for partial struts
On Tue, 30 Oct 2012 at 17:05:04 +0100, Rodolfo García Peñas (kix) wrote: > On 2012-10-30 16:42, Carlos R. Mafra wrote: > > > >Perhaps it's just me, but I can't really get what the function does > >from just reading its name: wAppIconFor(). I'm no native speaker, but > >the "For" suffix confuses me. I wonder if wAppIconOf() would be more > >"correct" -- ignoring the CamelCase issue :-) > > This is used in other functions. I don't have wmaker source here, > but the prototype is something like: > > wAppIconFor(WWindow *wwin) > > then you can read it as: > > AppIcon for wwindow :-) Ok. > I am changing the camel case too, we can see the code modified :-) > > CamelCase: "Original" code > no_camel_case: New code :-P Yes, I know. But I want to avoid discussing this here. Iain wrote nices patches and chose those names, so let it be. Who writes the code decides, as a first approximation. Knowing about the non_camel_case preferrence of wmaker.git is a plus, not a condition :-) I just wanted to raise the point that having a comment on top of the function explaining its purpose in life (one or two lines is often enough). The patches are going to be applied, they are very cool and have a lot of potential. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Patch: Partial support for partial struts
Quoth Carlos R. Mafra,
Perhaps it's just me, but I can't really get what the function does
from just reading its name: wAppIconFor(). I'm no native speaker, but
the "For" suffix confuses me. I wonder if wAppIconOf() would be more
"correct" -- ignoring the CamelCase issue :-)
You're probably right. I chose the name to match the existing
function wWindowFor() since it does a similar thing.
I think there is a better name which clearly states its purpose.
I'm bad in choosing names, though.
Function names are all over the place. We have some in Camel case,
some all lowercase and I'm not sure of the logic behind some starting
with the w prefix and others not.
A more general discussion on naming may be worthwhile. I'm happy
to change the name of the new function to something which we can agree
on. If I change it, though, I think I should change wWindowFor() as
well. Or even everything (mwahahaha!)...
I guess that justifies having some comment on top of the function
to state its purpose? I know it's a small function, but I find it
nicer to have an overview of what the function is supposed to do
before reading it.
No problem, and again if wAppIconFor() needs a comment then
wWindowFor() does too.
From 8d696a3776c2b7df4316232ae31cf3be39ec0dc9 Mon Sep 17 00:00:00 2001
From: Iain Patterson
Date: Tue, 30 Oct 2012 09:10:14 -0700
Subject: [PATCH] Brief documentation on wAppIconFor() and wWindowFor().
Brief comment on what wAppIconFor() and wWindowFor() do, as it
may not be immediately obvious.
Given a raw X11 Window they will find the AppIcon (or WWindow,
respectively) associated with that window. Thus they can map an
X11 object to a Window Maker internal object.
---
src/appicon.c | 1 +
src/window.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/appicon.c b/src/appicon.c
index 5d654de..cc2f7d8 100644
--- a/src/appicon.c
+++ b/src/appicon.c
@@ -1021,6 +1021,7 @@ static void remove_from_appicon_list(WScreen *scr,
WAppIcon *appicon)
appicon->next = NULL;
}
+/* Return the AppIcon associated with a given (Xlib) Window. */
WAppIcon *wAppIconFor(Window window)
{
WObjDescriptor *desc;
diff --git a/src/window.c b/src/window.c
index 4691021..199613c 100644
--- a/src/window.c
+++ b/src/window.c
@@ -141,6 +141,7 @@ static void appearanceObserver(void *self, WMNotification *
notif)
}
+/* Return the WWindow associated with a given (Xlib) Window. */
WWindow *wWindowFor(Window window)
{
WObjDescriptor *desc;
--
1.7.11.4
Re: [PATCH] adding wmtime to dockapps repository
> Here's a patch to add wmtime to the dockapps repository. I hope it > works -- this is my first time doing anything like this, so please let > me know if I messed up! Thanks, I've already pushed it to dockapps.git. I didn't find anything unusual with the patch from a quick look. It would have been better to have a clear statement in the commit log where the tarball came from though. But since it's comming with a debian/ folder that should not be difficult to guess... -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Patch: Partial support for partial struts
On 2012-10-30 16:42, Carlos R. Mafra wrote:
First of all: thanks for doing this, Iain!
On Tue, 30 Oct 2012 at 5:29:46 +, Iain Patterson wrote:
Subject: [PATCH 1/3] AppIcon helper functions.
Create wAppIconFor() and wAppIconTouchesHead() to match wWindowFor()
and wWindowTouchesHead(). These functions will allow us to locate
the
window and head associated with a particular app icon or dock icon.
+WAppIcon *wAppIconFor(Window window)
+{
+ WObjDescriptor *desc;
+
+ if (window == None)
+ return NULL;
+
+ if (XFindContext(dpy, window, wWinContext, (XPointer *) & desc) ==
XCNOENT)
+ return NULL;
+
+ if (desc->parent_type == WCLASS_APPICON || desc->parent_type ==
WCLASS_DOCK_ICON)
+ return desc->parent;
+
+ return NULL;
+}
Perhaps it's just me, but I can't really get what the function does
from just reading its name: wAppIconFor(). I'm no native speaker, but
the "For" suffix confuses me. I wonder if wAppIconOf() would be more
"correct" -- ignoring the CamelCase issue :-)
This is used in other functions. I don't have wmaker source here, but
the prototype is something like:
wAppIconFor(WWindow *wwin)
then you can read it as:
AppIcon for wwindow :-)
I don't like these function names!
I am changing the camel case too, we can see the code modified :-)
CamelCase: "Original" code
no_camel_case: New code :-P
I think there is a better name which clearly states its purpose.
I'm bad in choosing names, though.
I have a lot of monkeys typing here ;-)
I guess that justifies having some comment on top of the function
to state its purpose? I know it's a small function, but I find it
nicer to have an overview of what the function is supposed to do
before reading it.
Cheers,
kix
--
||// //\\// Rodolfo "kix" Garcia
||\\// //\\ http://www.kix.es/
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Patch: Partial support for partial struts
First of all: thanks for doing this, Iain!
On Tue, 30 Oct 2012 at 5:29:46 +, Iain Patterson wrote:
> Subject: [PATCH 1/3] AppIcon helper functions.
>
> Create wAppIconFor() and wAppIconTouchesHead() to match wWindowFor()
> and wWindowTouchesHead(). These functions will allow us to locate the
> window and head associated with a particular app icon or dock icon.
> +WAppIcon *wAppIconFor(Window window)
> +{
> + WObjDescriptor *desc;
> +
> + if (window == None)
> + return NULL;
> +
> + if (XFindContext(dpy, window, wWinContext, (XPointer *) & desc) ==
> XCNOENT)
> + return NULL;
> +
> + if (desc->parent_type == WCLASS_APPICON || desc->parent_type ==
> WCLASS_DOCK_ICON)
> + return desc->parent;
> +
> + return NULL;
> +}
Perhaps it's just me, but I can't really get what the function does
from just reading its name: wAppIconFor(). I'm no native speaker, but
the "For" suffix confuses me. I wonder if wAppIconOf() would be more
"correct" -- ignoring the CamelCase issue :-)
I think there is a better name which clearly states its purpose.
I'm bad in choosing names, though.
I guess that justifies having some comment on top of the function
to state its purpose? I know it's a small function, but I find it
nicer to have an overview of what the function is supposed to do
before reading it.
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
RE: Debian maintainer for wmtime
> On 2012-10-30 12:21, Paul Harris wrote: > > Hi guys, > > > > Im going to step aside as maintainer of wmtime in the debian repo, I > > just dont have the time unfortunately. > > > > Its easy to maintain (since it works). There are two patches pending > > in the debian bugs db (that I didnt see until now), so bug fixing is > > done for you! > > > > Who wants to take over this delightful package? > > > > cheers, > > Paul > > Hi Paul, > > sorry, I don't have time for more packages. I can help to maintain the > package if anyone wants to do it. Is a nice dockapp, please don't > orphane it ;-) > > OTOH this package is not in the dockapps.git. The idea is upload the > original file and then upload the debian proposed patches. Can somebody > do it? > > Cheers, > kix > -- > ||// //\\// Rodolfo "kix" Garcia > ||\\// //\\ http://www.kix.es/ I can maintain it. I'll also upload it to git. Doug Torrance
Re: Debian maintainer for wmtime
On 2012-10-30 12:21, Paul Harris wrote: Hi guys, Im going to step aside as maintainer of wmtime in the debian repo, I just dont have the time unfortunately. Its easy to maintain (since it works). There are two patches pending in the debian bugs db (that I didnt see until now), so bug fixing is done for you! Who wants to take over this delightful package? cheers, Paul Hi Paul, sorry, I don't have time for more packages. I can help to maintain the package if anyone wants to do it. Is a nice dockapp, please don't orphane it ;-) OTOH this package is not in the dockapps.git. The idea is upload the original file and then upload the debian proposed patches. Can somebody do it? Cheers, kix -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Debian maintainer for wmtime
Hi guys, I'm going to step aside as maintainer of wmtime in the debian repo, I just don't have the time unfortunately. Its easy to maintain (since it works). There are two patches pending in the debian bugs db (that I didn't see until now), so bug fixing is done for you! Who wants to take over this delightful package? cheers, Paul
