Re: Compile problem
- Josip Deanovic djosip+n...@linuxpages.net a écrit : [...] [...] wraster.h:182: error: wrong number of arguments specified for 'deprecated' attribute Could you please provide the answer for both commands: gcc --version $ gcc --version gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11) Copyright (C) 2010 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Thanks, I have checked and sent a patch that fixes the detection of gcc, so now the compilation will not break. After that I can continue compiling the source until I get to the next problem: [...] /usr/bin/ld: cannot open linker script file libwraster.map: No such file or directory There are 2 things that would help understanding what's going on: - the file 'config.log' I have attached the config.log file (~102KiB). - fgrep libwraster.map wrlib/Makefile $ fgrep libwraster.map wrlib/Makefile am__append_1 = -Wl,--version-script=libwraster.map EXTRA_libwraster_la_DEPENDENCIES = libwraster.map CLEANFILES = libwraster.map libwraster.map: $(include_HEADERS) $(top_srcdir)/script/generate-mapfile-from-header.sh -n LIBWRASTER -v $(WRASTER_VERSION) $(srcdir)/$(include_HEADERS) libwraster.map Thanks again, I managed to isolate the cause! I have also sent a patch for this, although for this one it will take you some extra work, sorry for that... [...] Obviously libwraster.map file doesn't get created and I don't see why. If I copy libwraster.map from older windowmaker source directories then the source would compile but I prefer to get it created during compile time as it probably should be. Otherwise I cannot be sure that some bugs regarding widget elements drawing I would like to report are actually bugs and not the result of an invalid compile. That was basically because the rule that tells make it is a dependency was not recognised by Automake, then the generated Makefile.in did not include it at all on your side, so Make did not even try to create the file... -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.6-319-g84284e6
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project wmaker-crm.git. The branch, next has been updated via 84284e604e72fc4e54f01eaef1caf70a97c6065f (commit) via 325dc85891519757a046a82aca45703962343c4e (commit) from eb1c06d704ce77e4223b4905241a9df6255bad47 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://repo.or.cz/w/wmaker-crm.git/commit/84284e604e72fc4e54f01eaef1caf70a97c6065f commit 84284e604e72fc4e54f01eaef1caf70a97c6065f Author: Christophe CURIS christophe.cu...@free.fr Date: Fri Jun 19 21:57:09 2015 +0200 Configure: increased the version of Automake requested The compilation of the WRaster library needs the keyword EXTRA_*_DEPENDENCIES in its Makefile so the configure.ac have been updated to require at least the version of automake in which it is added. Reported-by: Josip Deanovic djosip+n...@linuxpages.net Signed-off-by: Christophe CURIS christophe.cu...@free.fr diff --git a/configure.ac b/configure.ac index c5d3167..2b01108 100644 --- a/configure.ac +++ b/configure.ac @@ -37,7 +37,11 @@ dnl === AC_INIT([WindowMaker],[0.95.6],[wmaker-dev@lists.windowmaker.org],[WindowMaker],[http://www.windowmaker.org/]) AC_CONFIG_MACRO_DIR([m4]) AC_CONFIG_HEADERS([config.h]) -AM_INIT_AUTOMAKE([1.11 silent-rules]) + +dnl We need the EXTRA_xxx_DEPENDENCIES keyword in Makefiles which have been +dnl introduced in the version 1.11.3; because the 1.12 was realeased shortly +dnl after, we just ask for it +AM_INIT_AUTOMAKE([1.12 silent-rules]) dnl Reference file used by 'configure' to make sure the path to sources is valid AC_CONFIG_SRCDIR([src/WindowMaker.h]) http://repo.or.cz/w/wmaker-crm.git/commit/325dc85891519757a046a82aca45703962343c4e commit 325dc85891519757a046a82aca45703962343c4e Author: Christophe CURIS christophe.cu...@free.fr Date: Fri Jun 19 21:56:47 2015 +0200 wrlib: fixed gcc version needed for deprecated attribute support The support for a custom message in the attribute 'deprecated' have been added only from gcc 4.5.0 and not 4.0, so the check was updated accordingly to avoid compilation error with version 4.0 to 4.4. Reported-by: Josip Deanovic djosip+n...@linuxpages.net Signed-off-by: Christophe CURIS christophe.cu...@free.fr diff --git a/wrlib/wraster.h b/wrlib/wraster.h index 479f975..ab187bf 100644 --- a/wrlib/wraster.h +++ b/wrlib/wraster.h @@ -61,7 +61,7 @@ * mechanism and define an internal macro appropriately. Please note that the macro are not considered being * part of the public API. */ -#if __GNUC__ = 4 +#if __GNUC__ 4 || (__GNUC__ == 4 __GNUC_MINOR__ = 5) #define __wrlib_deprecated(msg) __attribute__ ((deprecated(msg))) #elif __GNUC__ = 3 #define __wrlib_deprecated(msg) __attribute__ ((deprecated)) --- Summary of changes: configure.ac| 6 +- wrlib/wraster.h | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) repo.or.cz automatic notification. Contact project admin crma...@gmail.com if you want to unsubscribe, or site admin ad...@repo.or.cz if you receive no reply. -- wmaker-crm.git (The Window Maker window manager) -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: About to release wmaker-0.95.7
Quoting message written on Friday 2015-06-19 15:15:58: Quoting message written on Saturday 2015-06-13 08:49:05: I'm planning to release wmaker-0.95.7 by the end of the next week, with the current state of the #master branch. This is a good time to test it to report any new problems or even old ones in case they were forgotten. Hi Carlos, I would kindly suggest that you postpone the new release for few more weeks in order to give some more time for some bugs to eventually get solved. I am currently trying to resurrect an old thread I have started few months ago (which is probably not about a bug but a feature lost by mistake at some point). I have two new bugs but they could be related to some compile problems I am experiencing so I'll wait with it until that is resolved. Another suggestion, this time about workspace pager. If I understood correctly workspace pager could not be seen unless a user sets some keyboard shortcut and then use it in order to open/close the workspace pager. That's fine but since such shortcut is not configured by default there is no way for user to open the workspace pager by accident thus this feature is effectively disabled by default. This feature also makes a huge impact on Windowmaker's workspace switching performance which is not visible if the feature is disabled by using DisableWorkspacePager = YES or via WPrefs tool (requires restart). I would suggest to set workspace pager feature to disable by default and change the option from DisableWorkspacePager to EnableWorkspacePager and to replace the description in the WPrefs from Disable workspace pager. to Enable workspace pager (requires restart, will produce impact on workspace switching performance). Otherwise we will have Windowmaker which is slow by default because of the feature most people will never know that exists. I wonder if workspace pager feature really need to make it that slow. There are other issues with it: - it grabs the mouse and doesn't let it out of the pager area so one cannot normally work with windows while pager is opened. - one cannot select workspace in the pager area by using LEFT/RIGHT keyboard keys and this is the most intuitive thing one would expect especially because the keyboard seems to be grabbed as well and one cannot use other keyboard shortcuts while workspace pager is opened - pager cannot show images of the workspaces user didn't switched to yet, and they are shown completely white. - pager also doesn't doesn't correctly show window inside a workspace in case window has been sent to the workspace via Move To window menu. I do not expect to see any of this issues solved any time soon (if ever) but we could at least disable it by default until it stops making impact on workspace switching performance. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Compile problem
Quoting message written on Friday 2015-06-19 22:02:24: Thanks again, I managed to isolate the cause! Thank you for your time. I have also sent a patch for this, although for this one it will take you some extra work, sorry for that... Now when I run ./autogen.sh I get this at the end: ... configure.ac:101: the top level configure.ac:44: require Automake 1.12, but have 1.11.1 autoreconf: automake failed with exit status: 1 I have upgraded my automake to 1.13 and build procedure is now working. Is the update of automake that extra work you are referring to? :-) Thank you for helping me to solve this. Automake 1.12 should be added into the requirements list if it is going to stay like that. Further more, one cannot read the list of prerequisites as the file INSTALL-WMAKER gets built only after you already have some of them met e.g. autoconf, automake, possibly more. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: About to release wmaker-0.95.7
Quoting message written on Saturday 2015-06-13 08:49:05: I'm planning to release wmaker-0.95.7 by the end of the next week, with the current state of the #master branch. This is a good time to test it to report any new problems or even old ones in case they were forgotten. Hi Carlos, I would kindly suggest that you postpone the new release for few more weeks in order to give some more time for some bugs to eventually get solved. I am currently trying to resurrect an old thread I have started few months ago (which is probably not about a bug but a feature lost by mistake at some point). I have two new bugs but they could be related to some compile problems I am experiencing so I'll wait with it until that is resolved. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Double-click on application in wmdock does not launch the application if one instance is already running
Quoting message written on Saturday 2014-06-14 00:06:14: Quoting message written on Monday 2014-06-09 11:13:14 by Carlos R. Mafra: It would be great if you could 'git bisect' the issue to a particular patch. That would speed up the fix greatly since there is even a confusion about the issue itself. Hello, I am done with git bisect. Let me know if the following output helps: bc0700e016c67791d3e3eab855543d849f4ce786 is the first bad commit commit bc0700e016c67791d3e3eab855543d849f4ce786 Author: Rodolfo GarcÃa Peñas (kix) k...@kix.es Date: Mon Jun 18 11:15:19 2012 +0200 Create WAppIcon always When the application is created, the WAppIcon now is created always, but it is only painted if the flag is not set. The icon initialization to NULL can be done now at app_icon_create_from_docks because it is always called. :04 04 7c58877ad5af211acaddac5288848c2ade7b04cb 33d52affb385d22fbf04ebad3c628b714008785d M src Regards Hi everyone Since we are not far away from the releasing of the Windowmaker 0.95.7 I would like to remind everyone about the issue in this thread since I can see that it has not been resolved in current next branch and it would be nice to solve it before the 0.95.7. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH 1/2] wrlib: fixed gcc version needed for deprecated attribute support
The support for a custom message in the attribute 'deprecated' have been added only from gcc 4.5.0 and not 4.0, so the check was updated accordingly to avoid compilation error with version 4.0 to 4.4. Reported-by: Josip Deanovic djosip+n...@linuxpages.net Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- wrlib/wraster.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wrlib/wraster.h b/wrlib/wraster.h index 479f975..ab187bf 100644 --- a/wrlib/wraster.h +++ b/wrlib/wraster.h @@ -61,7 +61,7 @@ * mechanism and define an internal macro appropriately. Please note that the macro are not considered being * part of the public API. */ -#if __GNUC__ = 4 +#if __GNUC__ 4 || (__GNUC__ == 4 __GNUC_MINOR__ = 5) #define __wrlib_deprecated(msg) __attribute__ ((deprecated(msg))) #elif __GNUC__ = 3 #define __wrlib_deprecated(msg) __attribute__ ((deprecated)) -- 2.1.4 -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH 2/2] Configure: increased the version of Automake requested
The compilation of the WRaster library needs the keyword EXTRA_*_DEPENDENCIES in its Makefile so the configure.ac have been updated to require at least the version of automake in which it is added. Reported-by: Josip Deanovic djosip+n...@linuxpages.net Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- configure.ac | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index c5d3167..2b01108 100644 --- a/configure.ac +++ b/configure.ac @@ -37,7 +37,11 @@ dnl === AC_INIT([WindowMaker],[0.95.6],[wmaker-dev@lists.windowmaker.org],[WindowMaker],[http://www.windowmaker.org/]) AC_CONFIG_MACRO_DIR([m4]) AC_CONFIG_HEADERS([config.h]) -AM_INIT_AUTOMAKE([1.11 silent-rules]) + +dnl We need the EXTRA_xxx_DEPENDENCIES keyword in Makefiles which have been +dnl introduced in the version 1.11.3; because the 1.12 was realeased shortly +dnl after, we just ask for it +AM_INIT_AUTOMAKE([1.12 silent-rules]) dnl Reference file used by 'configure' to make sure the path to sources is valid AC_CONFIG_SRCDIR([src/WindowMaker.h]) -- 2.1.4 -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
