configure.ac_libdir.patch
Hi!
I would like to propose this simple patch:
diff -Nru wmaker-crm.next/configure.ac wmaker-crm.next.patched/configure.ac
--- wmaker-crm.next/configure.ac2015-06-20 08:53:05.0 +0200
+++ wmaker-crm.next.patched/configure.ac2015-06-20 08:53:41.0
+0200
@@ -281,6 +281,8 @@
_bindir=`eval echo $bindir`
_bindir=`eval echo $_bindir`
+_libdir=`eval echo $libdir`
+_libdir=`eval echo $_libdir`
lib_search_path='-L${libdir}'
@@ -937,7 +939,7 @@
echo
echo "Installation path prefix: $prefix"
echo "Installation path for binaries : $_bindir"
-echo "Installation path for libraries : $libdir"
+echo "Installation path for libraries : $_libdir"
echo "Installation path for WPrefs.app: $wprefs_base_dir" | sed -e
's|\${prefix}|'"$prefix|"
echo "Supported core features::$supported_core"
echo "Supported X extensions: :$supported_xext"
It would fix the output status of the configure script which
currently gives output such as this:
Window Maker was configured as follows:
Installation path prefix: /usr/local/windowmaker-0.95.7.next
Installation path for binaries : /usr/local/windowmaker-0.95.7.next/bin
Installation path for libraries : ${exec_prefix}/lib
Installation path for WPrefs.app: /usr/local/windowmaker-0.95.7.next
Supported core features:: Animations MWMHints XDnD
Supported X extensions: : XShape XShm Xinerama RandR
Supported graphic format libraries : XPM PNG JPEG GIF TIFF WebP Magick
builtin-PPM
Unsupported features:
Antialiased text support in WINGs : yes
Pango text layout support in WINGs : no
Translated languages to support : disabled
instead of something like this:
Window Maker was configured as follows:
Installation path prefix: /usr/local/windowmaker-0.95.7.next
Installation path for binaries : /usr/local/windowmaker-0.95.7.next/bin
Installation path for libraries : /usr/local/windowmaker-0.95.7.next/lib
Installation path for WPrefs.app: /usr/local/windowmaker-0.95.7.next
Supported core features:: Animations MWMHints XDnD
Supported X extensions: : XShape XShm Xinerama RandR
Supported graphic format libraries : XPM PNG JPEG GIF TIFF WebP Magick
builtin-PPM
Unsupported features:
Antialiased text support in WINGs : yes
Pango text layout support in WINGs : no
Translated languages to support : disabled
--
Josip Deanovic
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: configure.ac_libdir.patch
On Sat, 20 Jun 2015 at 9:14:45 +0200, Josip Deanovic wrote:
> Hi!
>
> I would like to propose this simple patch:
>
>
> diff -Nru wmaker-crm.next/configure.ac wmaker-crm.next.patched/configure.ac
> --- wmaker-crm.next/configure.ac2015-06-20 08:53:05.0 +0200
> +++ wmaker-crm.next.patched/configure.ac2015-06-20 08:53:41.0
> +0200
> @@ -281,6 +281,8 @@
>
> _bindir=`eval echo $bindir`
> _bindir=`eval echo $_bindir`
> +_libdir=`eval echo $libdir`
> +_libdir=`eval echo $_libdir`
>
> lib_search_path='-L${libdir}'
>
> @@ -937,7 +939,7 @@
> echo
> echo "Installation path prefix: $prefix"
> echo "Installation path for binaries : $_bindir"
> -echo "Installation path for libraries : $libdir"
> +echo "Installation path for libraries : $_libdir"
> echo "Installation path for WPrefs.app: $wprefs_base_dir" | sed -e
> 's|\${prefix}|'"$prefix|"
> echo "Supported core features::$supported_core"
> echo "Supported X extensions: :$supported_xext"
>
>
>
> It would fix the output status of the configure script which
> currently gives output such as this:
>
>
> Window Maker was configured as follows:
>
> Installation path prefix: /usr/local/windowmaker-0.95.7.next
> Installation path for binaries : /usr/local/windowmaker-0.95.7.next/bin
> Installation path for libraries : ${exec_prefix}/lib
> Installation path for WPrefs.app: /usr/local/windowmaker-0.95.7.next
> Supported core features:: Animations MWMHints XDnD
> Supported X extensions: : XShape XShm Xinerama RandR
> Supported graphic format libraries : XPM PNG JPEG GIF TIFF WebP Magick
> builtin-PPM
> Unsupported features:
> Antialiased text support in WINGs : yes
> Pango text layout support in WINGs : no
> Translated languages to support : disabled
>
>
>
> instead of something like this:
>
>
> Window Maker was configured as follows:
>
> Installation path prefix: /usr/local/windowmaker-0.95.7.next
> Installation path for binaries : /usr/local/windowmaker-0.95.7.next/bin
> Installation path for libraries : /usr/local/windowmaker-0.95.7.next/lib
> Installation path for WPrefs.app: /usr/local/windowmaker-0.95.7.next
> Supported core features:: Animations MWMHints XDnD
> Supported X extensions: : XShape XShm Xinerama RandR
> Supported graphic format libraries : XPM PNG JPEG GIF TIFF WebP Magick
> builtin-PPM
> Unsupported features:
> Antialiased text support in WINGs : yes
> Pango text layout support in WINGs : no
> Translated languages to support : disabled
>
Thank you, applied!
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Malformed checkboxes in Window Attributes window
Hi, Josip Deanovic schreef: Hi! Did anybody else notice the malformed look of checkboxes in "Window Attributes" window? Yes, but it's not malformed. The first (read-only) box indicates the window hint requested by the program. The second one is a tristate check box, that can be changed to override it. Some programs (GNOME/GTK?) might need it to run correctly under Window Maker. (See also the Help balloon, when hovering the first check box. It can also be used to remove the resize bar on some Window Maker panels, as they can't be resized currently. To turn the resize bar off in those panels by default, would look better imho: WPrefs panel, Color panel, and the panels for opening images/directories/programs. I have attached the screenshot (~189KiB, PNG) which shows how it looks on my setup. Regards -- [alwin] -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH v3] NEWS: Add note about window snapping.
Quoting message written on Monday 2014-09-22 14:29:36: > Hi Doug, > > Great Feature ! > > Just one comment which I think that it can be improved: > > Apparently right now it just does windo snapping in the right/left > sides. It would be great if top/bottom maximization could be done too. > In particular, since my current monitor is huge, I would also love > having more options: topLeft, topRight, bottomLeft, bottomRight :) But > at least bottom/top I think that are important. I am a bit late but maybe not too late :-) Really nice feature. Doug, would it be to hard to not completely disable the feature in case DontLinkWorkspaces is set to "NO" but to disable just the left/right and corner snapping instead? That way someone who is using workspace linking feature could still snap a window top/bottom which is still more than nothing (actually I feel I would really like that feature while still being able to use workspace linking). Regards -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Malformed checkboxes in Window Attributes window
Quoting message written on Saturday 2015-06-20 10:41:37: > Hi, > > Josip Deanovic schreef: > > Hi! > > > > Did anybody else notice the malformed look of checkboxes in "Window > > Attributes" window? > > Yes, but it's not malformed. The first (read-only) box indicates the > window hint requested by the program. The second one is a tristate check > box, that can be changed to override it. Some programs (GNOME/GTK?) > might need it to run correctly under Window Maker. (See also the Help > balloon, when hovering the first check box. > > It can also be used to remove the resize bar on some Window Maker > panels, as they can't be resized currently. To turn the resize bar off > in those panels by default, would look better imho: WPrefs panel, Color > panel, and the panels for opening images/directories/programs. > Thank you for the response. This is probably some new feature as I don't remember seeing this before. I have just turned on balloons for "internal help". Without this I couldn't see the help balloon for check boxes. The appearance of the check boxes immediately reminded me to the look of an incorrectly drawn area i X, that's why I thought it was a malformed check box. :-) -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH 1/1] fixup! Configure: increased the version of Automake requested
---
debian/control | 2 +-
doc/build/Compilation.texi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/debian/control b/debian/control
index ce41a77..b761636 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: x11
Priority: optional
Maintainer: Rodolfo García Peñas (kix)
Standards-Version: 3.9.6
-Build-Depends: debhelper (>= 9), automake (>= 1:1.11), gettext,
+Build-Depends: debhelper (>= 9), automake (>= 1:1.12), gettext,
libfontconfig1-dev, libjpeg-dev, libpng-dev, libsm-dev, libtiff5-dev,
libtool, libgif-dev, libx11-dev, libxext-dev, libxft-dev, libxinerama-dev,
libxkbfile-dev, libxpm-dev, libxt-dev, libxrender-dev, sharutils, libxmu-dev,
diff --git a/doc/build/Compilation.texi b/doc/build/Compilation.texi
index 2ab7598..00e5862 100644
--- a/doc/build/Compilation.texi
+++ b/doc/build/Compilation.texi
@@ -164,7 +164,7 @@ package, you will also need:
@itemize
@item @emph{git}
@item @emph{autoconf} 2.69
-@item @emph{automake} 1.11
+@item @emph{automake} 1.12
@item @emph{libtool} 1.4.2
@end itemize
--
2.1.4
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH 0/1] Update doc on automake version needed
As pointed by Josip, I missed the update of the documentation about the requirement for the Automake version, so this patch can be merged with the other one to fix that. Took opportunity to update the Debian file too because it costs nothing. Regards, Christophe. debian/control | 2 +- doc/build/Compilation.texi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.1.4 -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Compile problem
- Josip Deanovic a écrit : > Quoting message written on Friday 2015-06-19 22:02:24: > > Thanks again, I managed to isolate the cause! > > Thank you for your time. > > > I have also sent a patch for this, although for this one it will take > > you some extra work, sorry for that... > > Now when I run "./autogen.sh" I get this at the end: > > ... > configure.ac:101: the top level > configure.ac:44: require Automake 1.12, but have 1.11.1 > autoreconf: automake failed with exit status: 1 > > > I have upgraded my automake to 1.13 and build procedure is now working. > Is the update of automake that extra work you are referring to? :-) Yes, that's what I meant... I'm sorry about it, but it is the only way to fix this yet keeping a maintainable Makefile, the workaround would have been ugly and too error prone. > Thank you for helping me to solve this. > Automake 1.12 should be added into the requirements list if it is > going to stay like that. I missed that also, but it should be fixed soon! > Further more, one cannot read the list of prerequisites as the file > INSTALL-WMAKER gets built only after you already have some of them > met e.g. autoconf, automake, possibly more. Yes, that is a known limit of the procedure in place. Actually this file is more meant for people compiling from the official package, which do not have these problems. The goal is for people compiling from Git to find this information online on the Website, which is an ongoing task. Regards, Christophe. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH 3/3] Renamed "Apercu" to "MiniPreview" in the configuration database
Quoting message written on Wednesday 2014-12-31 01:09:53: > The name of the 2 settings have been changed: > - enable: MiniwindowApercuBalloons -> MiniwindowPreviewBalloons > - size: ApercuSize -> MiniPreviewSize > > The old name is still supported to avoid breaking user's configuration, > but WPrefs will update the setting to the new names when updating the > configuration. Hi Christophe, I finally got some time to check some new Windowmaker features so I tried to use that MiniPreview a.k.a. apercu feature but it doesn't work out of the box and there are some inconsistencies. Problem 1: - exit windowmaker - in the console manually edit GNUstep/Defaults/WindowMaker file in order to remove all occurance of MiniwindowApercuBalloons and ApercuSize variables - MiniwindowPreviewBalloons is set to YES - MiniPreviewSize is set to let's say 256 - start windowmaker - tail -f .xsession-errors says: /usr/local/windowmaker-0.95.7.next/bin/wmaker(wReadDefaults(defaults.c:1227)): warning: your configuration is using old syntax for Mini-Preview settings; consider running WPrefs.app to update But it doesn't. Let's check using wdread: $ wdread WindowMaker MiniwindowApercuBalloons $ wdread WindowMaker ApercuSize $ wdread WindowMaker MiniwindowPreviewBalloons YES $ wdread WindowMaker MiniPreviewSize 256 Problem 2: And at that moment miniwindows doesn't show any kind of mini preview while balloons still work (I have tried it with balloons turned off but without change). So I started the WPrefs changed MiniPreviewSize to 264, saved the change and closed WPrefs. wdread confirms it: $ wdread WindowMaker MiniPreviewSize 264 Mini window preview for miniwindows still doesn't show up. Then I have tried to use the old variables: $ wdwrite WindowMaker MiniwindowApercuBalloons YES $ wdread WindowMaker MiniwindowApercuBalloons YES At that moment I can see miniwindow preview for the first time but they look more like the original default (twice the size of the miniwindow). Then I start the WPrefs and change the size of the MiniPreviewSize to something else, let's say to 256, save and close WPrefs. Current state: $ wdread WindowMaker MiniwindowApercuBalloons YES $ wdread WindowMaker ApercuSize $ wdread WindowMaker MiniwindowPreviewBalloons YES $ wdread WindowMaker MiniPreviewSize 256 At that moment miniwindow preview shows up as expected, with the size of 256px. - exit Windowmaker - start windowmaker Miniwindow preview shows up in size as twice the size of the miniwindow again. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] wmaker: add miniwindow apercu
Quoting message written on Thursday 2014-08-14 15:43:57: > This patch is adding miniwindow apercu when the mouse > is over the miniwindows. > > I added this feature about one month ago and was successfully testing > it since then. > To enable it you have to run WPref, in Miscellaneous Ergonomic > Preferences, check miniwindow apercus. > Then, you will be able to see a screenshot of the app when the mouse > is over the miniwindow (I also enclosed a screenshot to show you what > it looks like). Hi David, I have just tested this feature and this is how it looks on my setup. Please check the attached image (~57KiB, PNG). Could you (or maybe some volunteer) modify the titlebar of the preview area so that it reflects either the color/texture of the minimized window or the color of the miniwindow titlebar (variable IconTitleBack)? Next logical step would be to add a minimized window title bar to the title bar of the miniwindow preview area similar to what miniwindows already do. Also notice how miniwindow preview area covers the miniwindows below and the wmdock. Could the position of the miniwindow preview area be recalculated so that it doesn't cover the other miniwindows or the wmdock? Regards -- Josip Deanovic
Re: Compile problem
On Sat, 20 Jun 2015 at 12:05:42 +0200, Christophe wrote: > - Josip Deanovic a écrit : > > > Further more, one cannot read the list of prerequisites as the file > > INSTALL-WMAKER gets built only after you already have some of them > > met e.g. autoconf, automake, possibly more. > > Yes, that is a known limit of the procedure in place. Actually this > file is more meant for people compiling from the official package, > which do not have these problems. The goal is for people compiling from > Git to find this information online on the Website, which is an ongoing > task. Sorry, this makes no sense. The INSTALL-WMAKER file should be a plain text for people to read without any hassle. It should contain information to help people install wmaker. Its existence cannot depend on things that the file is meant to warn about in the first place. Can we get the file back like it was? -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.6-320-gf3ac6bb
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project wmaker-crm.git.
The branch, next has been updated
via f3ac6bb9233a0be20c2c6f0b8c09c6419410cb0f (commit)
from 84284e604e72fc4e54f01eaef1caf70a97c6065f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
http://repo.or.cz/w/wmaker-crm.git/commit/f3ac6bb9233a0be20c2c6f0b8c09c6419410cb0f
commit f3ac6bb9233a0be20c2c6f0b8c09c6419410cb0f
Author: Josip Deanovic
Date: Sat Jun 20 09:14:45 2015 +0200
configure: Fix output of libdir directory in summary
This patch fixes the output status of the configure script which
currently gives output such as this:
Window Maker was configured as follows:
Installation path prefix: /usr/local/windowmaker-0.95.7.next
Installation path for binaries : /usr/local/windowmaker-0.95.7.next/bin
Installation path for libraries : ${exec_prefix}/lib
Installation path for WPrefs.app: /usr/local/windowmaker-0.95.7.next
...
diff --git a/configure.ac b/configure.ac
index 2b01108..589c7c9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -281,6 +281,8 @@ test "x$exec_prefix" = xNONE && exec_prefix='${prefix}'
_bindir=`eval echo $bindir`
_bindir=`eval echo $_bindir`
+_libdir=`eval echo $libdir`
+_libdir=`eval echo $_libdir`
lib_search_path='-L${libdir}'
@@ -937,7 +939,7 @@ echo "Window Maker was configured as follows:"
echo
echo "Installation path prefix: $prefix"
echo "Installation path for binaries : $_bindir"
-echo "Installation path for libraries : $libdir"
+echo "Installation path for libraries : $_libdir"
echo "Installation path for WPrefs.app: $wprefs_base_dir" | sed -e
's|\${prefix}|'"$prefix|"
echo "Supported core features::$supported_core"
echo "Supported X extensions: :$supported_xext"
---
Summary of changes:
configure.ac | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
repo.or.cz automatic notification. Contact project admin crma...@gmail.com
if you want to unsubscribe, or site admin ad...@repo.or.cz if you receive
no reply.
--
wmaker-crm.git ("The Window Maker window manager")
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.6-321-g9dd875b
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project wmaker-crm.git.
The branch, next has been updated
via 9dd875b1cfc6ab48bf82250781b5001f080019d0 (commit)
from f3ac6bb9233a0be20c2c6f0b8c09c6419410cb0f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
http://repo.or.cz/w/wmaker-crm.git/commit/9dd875b1cfc6ab48bf82250781b5001f080019d0
commit 9dd875b1cfc6ab48bf82250781b5001f080019d0
Author: Christophe CURIS
Date: Sat Jun 20 12:00:23 2015 +0200
fixup! Configure: increased the version of Automake requested
diff --git a/debian/control b/debian/control
index ce41a77..b761636 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: x11
Priority: optional
Maintainer: Rodolfo García Peñas (kix)
Standards-Version: 3.9.6
-Build-Depends: debhelper (>= 9), automake (>= 1:1.11), gettext,
+Build-Depends: debhelper (>= 9), automake (>= 1:1.12), gettext,
libfontconfig1-dev, libjpeg-dev, libpng-dev, libsm-dev, libtiff5-dev,
libtool, libgif-dev, libx11-dev, libxext-dev, libxft-dev, libxinerama-dev,
libxkbfile-dev, libxpm-dev, libxt-dev, libxrender-dev, sharutils, libxmu-dev,
diff --git a/doc/build/Compilation.texi b/doc/build/Compilation.texi
index 2ab7598..00e5862 100644
--- a/doc/build/Compilation.texi
+++ b/doc/build/Compilation.texi
@@ -164,7 +164,7 @@ package, you will also need:
@itemize
@item @emph{git}
@item @emph{autoconf} 2.69
-@item @emph{automake} 1.11
+@item @emph{automake} 1.12
@item @emph{libtool} 1.4.2
@end itemize
---
Summary of changes:
debian/control | 2 +-
doc/build/Compilation.texi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
repo.or.cz automatic notification. Contact project admin crma...@gmail.com
if you want to unsubscribe, or site admin ad...@repo.or.cz if you receive
no reply.
--
wmaker-crm.git ("The Window Maker window manager")
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Compile problem
Quoting message written on Saturday 2015-06-20 14:22:55: > > Yes, that is a known limit of the procedure in place. Actually this > > file is more meant for people compiling from the official package, > > which do not have these problems. The goal is for people compiling > > from > > Git to find this information online on the Website, which is an > > ongoing > > task. > > Sorry, this makes no sense. > > The INSTALL-WMAKER file should be a plain text for people to read > without any hassle. It should contain information to help people > install wmaker. Its existence cannot depend on things that the file is > meant to warn about in the first place. > > Can we get the file back like it was? I remember that there was some talk about it in the past: http://thread.gmane.org/gmane.comp.window-managers.windowmaker.devel/8990/focus=9017 I think that in order to keep INSTALL-WMAKER file in textual form, the source of the documentation could still be kept in texinfo but it should be manually generated every time someone changes the relevant texinfo. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH 0/3] Fixes...
Hello, The first 2 patchs will fix the Apercu/Minipreview problems reported by Josip recently. The 3rd patch is including the generated INSTALL-WMAKER into the repository as suggested by Carlos. Carlos, I would also suggest to run this (before or after, it does not matter): git rebase -i HEAD~7 --autosquash as there's a patch meant to be merged in the branch... Regards, Christophe. .gitignore | 1 - INSTALL-WMAKER | 717 + WPrefs.app/Icons.c | 18 +- autogen.sh | 3 +- src/defaults.c | 10 +- 5 files changed, 738 insertions(+), 11 deletions(-) create mode 100644 INSTALL-WMAKER -- 2.1.4 -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH 1/3] wmaker: fix detection of legacy Apercu configuration keywords
As reported by Josip, the code in Window Maker to detect the use of the
legacy keyword "MiniwindowApercuBalloons" and "ApercuSize" was broken,
which means they were always seen as used even when not present.
This patch fixes the detection to only use them if they were effectively
used.
Reported-by: Josip Deanovic
Signed-off-by: Christophe CURIS
---
src/defaults.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/src/defaults.c b/src/defaults.c
index 70fbeb5..c5a94c6 100644
--- a/src/defaults.c
+++ b/src/defaults.c
@@ -529,7 +529,7 @@ WDefaultEntry optionList[] = {
*/
{"MiniwindowApercuBalloons", "NO", NULL,
&legacy_minipreview_config.enable, getBool, NULL, NULL, NULL},
- {"ApercuSize", "128", NULL,
+ {"ApercuSize", "0", NULL,
&legacy_minipreview_config.size, getInt, NULL, NULL, NULL},
/* style options */
@@ -1155,10 +1155,6 @@ void wReadDefaults(WScreen * scr, WMPropList * new_dict)
void *tdata;
WMPropList *old_dict = (w_global.domain.wmaker->dictionary != new_dict
? w_global.domain.wmaker->dictionary : NULL);
- /* Backward Compatibility: init array to special value to detect if
they changed */
- legacy_minipreview_config.enable = 99;
- legacy_minipreview_config.size = -1;
-
needs_refresh = 0;
for (i = 0; i < wlengthof(optionList); i++) {
@@ -1223,11 +1219,11 @@ void wReadDefaults(WScreen * scr, WMPropList * new_dict)
* This code should probably stay for at least 2 years, you should not
consider removing
* it before year 2017
*/
- if (legacy_minipreview_config.enable != 99) {
+ if (legacy_minipreview_config.enable) {
wwarning(_("your configuration is using old syntax for
Mini-Preview settings; consider running WPrefs.app to update"));
wPreferences.miniwin_preview_balloon =
legacy_minipreview_config.enable;
- if (legacy_minipreview_config.size >= 0) {
+ if (legacy_minipreview_config.size > 0) {
/*
* the option 'ApercuSize' used to be coded as a
multiple of the icon size in v0.95.6
* it is now expressed directly in pixels, but to avoid
breaking user's setting we check
--
2.1.4
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH 2/3] WPrefs: fix conversion of old "Apercu" setting to the new keywords
As pointed by Josip, the code for loading the legacy setting keywords for
the Minipreview feature did not update correctly the configuration:
- if the setting used a size as a multiple of icon size, this was
understood as the minimum pixel size, which meant here disabling the
feature. The code is now consistent with what Window Maker does;
- if the old keyword were found, they were loaded but not removed from the
database after creating the new ones, which is a source of problem as
Window Maker assumes that the presence of the legacy keywords means they
are to be taken in consideration.
Reported-by: Josip Deanovic
Signed-off-by: Christophe CURIS
---
WPrefs.app/Icons.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/WPrefs.app/Icons.c b/WPrefs.app/Icons.c
index 4e7f237..e68da56 100644
--- a/WPrefs.app/Icons.c
+++ b/WPrefs.app/Icons.c
@@ -60,6 +60,8 @@ typedef struct _Panel {
CallbackRec callbacks;
+ Bool have_legacy_apercu;
+
WMWidget *parent;
WMFrame *posF;
@@ -206,6 +208,7 @@ static void showData(_Panel * panel)
* new settings
* This hack should be kept for at least 2 years, that means >= 2017.
*/
+ panel->have_legacy_apercu = False;
str = GetStringForKey("MiniwindowPreviewBalloons");
if (str != NULL) {
/* New names found, use them in priority */
@@ -221,9 +224,18 @@ static void showData(_Panel * panel)
/* No new names, try the legacy names */
b = GetBoolForKey("MiniwindowApercuBalloons");
if (b) {
+ panel->have_legacy_apercu = True;
i = GetIntegerForKey("ApercuSize");
+
+ /*
+* In the beginning, the option was coded as a multiple
of the icon
+* size; then it was converted to pixel size
+*/
+ if (i < 24)
+ i *= GetIntegerForKey("IconSize");
+
if (i <= minipreview_minimum_size)
- i = minipreview_minimum_size;
+ i = minipreview_minimum_size + 1; /* +1
to not display as "off" */
} else {
i = minipreview_minimum_size;
}
@@ -466,6 +478,10 @@ static void storeData(_Panel * panel)
}
SetIntegerForKey(i, "MiniPreviewSize");
}
+ if (panel->have_legacy_apercu) {
+ RemoveObjectForKey("MiniwindowApercuBalloons");
+ RemoveObjectForKey("ApercuSize");
+ }
for (i = 0; i < wlengthof(icon_animation); i++) {
if (WMGetButtonSelected(panel->animB[i])) {
--
2.1.4
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH 3/3] doc: include the "INSTALL-WMAKER" documentation in the repository
As suggested by Carlos, the instruction to compile from the repository are
included in this document, so it is a good idea to have it in the
repository, even if it is a generated file.
In addition, "autogen.sh" will not generate it anymore as it would create
an incorrect version of it (the reference to the version number would be
wrong).
When the source file is modified, "make" will re-generate accordingly the
file, so there should be no problem.
Suggested-by: Carlos R. Mafra
Signed-off-by: Christophe CURIS
---
.gitignore | 1 -
INSTALL-WMAKER | 717 +
autogen.sh | 3 +-
3 files changed, 718 insertions(+), 3 deletions(-)
create mode 100644 INSTALL-WMAKER
diff --git a/.gitignore b/.gitignore
index e50a2b7..0e94104 100644
--- a/.gitignore
+++ b/.gitignore
@@ -32,7 +32,6 @@ m4/lt~obsolete.m4
src/wconfig.h
# These files are generated by scripts
-INSTALL-WMAKER
README.i18n
# These files are compilation stuff
diff --git a/INSTALL-WMAKER b/INSTALL-WMAKER
new file mode 100644
index 000..64e07e4
--- /dev/null
+++ b/INSTALL-WMAKER
@@ -0,0 +1,717 @@
+
+
+
+
+
+ Window Maker Compilation and Installation
+
+
+ ~ A guide to configure, compile and install ~
+ ~ Window Maker from sources. ~
+
+ -- The Window Maker Team --
+
+
+
+
+This manual is for Window Maker window manager, version 0.95.6.
+
+Copyright (c) 2015 The Window Maker Team.
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program, see file COPYING for details.
+
+
+ Published by The Window Maker team on 20 June 2015.
+
+
+
+
+
+1 Prerequisites . . . . . . . . . . . . . . . . . . . . . . . . 73
+ 1.1 Supported Platforms . . . . . . . . . . . . . . . . . . . 77
+ 1.2 Software Dependencies . . . . . . . . . . . . . . . . . . 88
+ 1.3 Special Dependencies . . . . . . . . . . . . . . . . . . 122
+ 1.4 Optional Dependencies . . . . . . . . . . . . . . . . . . 134
+
+2 Building Window Maker . . . . . . . . . . . . . . . . . . . . 223
+ 2.1 Getting the Sources . . . . . . . . . . . . . . . . . . . 227
+ 2.2 Build and Install . . . . . . . . . . . . . . . . . . . . 248
+ 2.3 User specific configuration . . . . . . . . . . . . . . . 298
+ 2.4 Locales/Internationalisation . . . . . . . . . . . . . . 324
+ 2.5 Configure Options . . . . . . . . . . . . . . . . . . . . 332
+2.5.1 Installation Directory . . . . . . . . . . . . . . . 346
+2.5.2 External Libraries . . . . . . . . . . . . . . . . . 391
+2.5.3 X11 and Extensions . . . . . . . . . . . . . . . . . 452
+2.5.4 Feature Selection . . . . . . . . . . . . . . . . . . 500
+2.5.5 Developer Stuff . . . . . . . . . . . . . . . . . . . 549
+
+3 Miscellaneous . . . . . . . . . . . . . . . . . . . . . . . . 577
+ 3.1 Platform Specific Notes . . . . . . . . . . . . . . . . . 581
+ 3.2 I don't have the root password :( . . . . . . . . . . . . 626
+ 3.3 Upgrading . . . . . . . . . . . . . . . . . . . . . . . . 645
+
+4 Troubleshooting . . . . . . . . . . . . . . . . . . . . . . . 655
+ 4.1 Error with loading fonts, even if they exist . . . . . . 663
+ 4.2 configure doesn't detect libtiff, or other graphic librari 673
+ 4.3 configure doesn't detect libXpm . . . . . . . . . . . . . 687
+ 4.4 Segmentation fault on startup . . . . . . . . . . . . . . 693
+ 4.5 "...: your machine is misconfigured. gethostname() returne 705
+ 4.6 The root menu contains only 2 entries. ("XTerm" and "Exit. 712
+
+
+1 Prerequisites
+***
+
+
+1.1 Supported Platforms
+===
+
+ - Intel GNU/Linux Systems in general, ix86 and x86_64 but other
+ architectures should work
+ - BSD systems
+ - Solaris, at least on release 10 and 11
+
+ Patches to make it work on other platforms are welcome.
+
+
+1.2 Software Dependencies
+=
+
+The following software is required to use Window Maker:
+
+ - X11R6.x
+
+ Window Maker can be compiled in older versions of X, like X11R5
+ (Solaris) or X11R4 (OpenWindows) but it will n
Re: [PATCH 3/3] Renamed "Apercu" to "MiniPreview" in the configuration database
- Josip Deanovic a écrit : > Quoting message written on Wednesday 2014-12-31 01:09:53: > > The name of the 2 settings have been changed: > > - enable: MiniwindowApercuBalloons -> MiniwindowPreviewBalloons > > - size: ApercuSize -> MiniPreviewSize > > > > The old name is still supported to avoid breaking user's configuration, > > but WPrefs will update the setting to the new names when updating the > > configuration. > > Hi Christophe, > > I finally got some time to check some new Windowmaker features so I > tried to use that MiniPreview a.k.a. apercu feature but it doesn't > work out of the box and there are some inconsistencies. > > > Problem 1: > > - exit windowmaker > - in the console manually edit GNUstep/Defaults/WindowMaker file in > order to remove all occurance of MiniwindowApercuBalloons and > ApercuSize variables > - MiniwindowPreviewBalloons is set to YES > - MiniPreviewSize is set to let's say 256 > - start windowmaker > - tail -f .xsession-errors says: > /usr/local/windowmaker-0.95.7.next/bin/wmaker(wReadDefaults(defaults.c:1227)): > > warning: your configuration is using old syntax for Mini-Preview settings; > consider running WPrefs.app to update > > But it doesn't. > Let's check using wdread: > $ wdread WindowMaker MiniwindowApercuBalloons > $ wdread WindowMaker ApercuSize > $ wdread WindowMaker MiniwindowPreviewBalloons > YES > $ wdread WindowMaker MiniPreviewSize > 256 > > > Problem 2: > > And at that moment miniwindows doesn't show any kind of mini preview > while balloons still work (I have tried it with balloons turned off > but without change). > > So I started the WPrefs changed MiniPreviewSize to 264, saved the > change and closed WPrefs. > wdread confirms it: > $ wdread WindowMaker MiniPreviewSize > 264 > > Mini window preview for miniwindows still doesn't show up. > > Then I have tried to use the old variables: > $ wdwrite WindowMaker MiniwindowApercuBalloons YES > $ wdread WindowMaker MiniwindowApercuBalloons > YES > > At that moment I can see miniwindow preview for the first time but > they look more like the original default (twice the size of the > miniwindow). > > Then I start the WPrefs and change the size of the MiniPreviewSize > to something else, let's say to 256, save and close WPrefs. > > Current state: > $ wdread WindowMaker MiniwindowApercuBalloons > YES > $ wdread WindowMaker ApercuSize > $ wdread WindowMaker MiniwindowPreviewBalloons > YES > $ wdread WindowMaker MiniPreviewSize > 256 > > At that moment miniwindow preview shows up as expected, with the size > of 256px. > > - exit Windowmaker > - start windowmaker > > Miniwindow preview shows up in size as twice the size of the miniwindow > again. Hi, Thanks for all the details, it helped reproduce and fix. It should be better soon! -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Compile problem
- Carlos R. Mafra a écrit : > On Sat, 20 Jun 2015 at 12:05:42 +0200, Christophe wrote: > > - Josip Deanovic a écrit : > > > > > Further more, one cannot read the list of prerequisites as the file > > > INSTALL-WMAKER gets built only after you already have some of them > > > met e.g. autoconf, automake, possibly more. > > > > Yes, that is a known limit of the procedure in place. Actually this > > file is more meant for people compiling from the official package, > > which do not have these problems. The goal is for people compiling from > > Git to find this information online on the Website, which is an ongoing > > task. > > Sorry, this makes no sense. > > The INSTALL-WMAKER file should be a plain text for people to read without > any hassle. It should contain information to help people install > wmaker. Its existence cannot depend on things that the file is meant to > warn about in the first place. > > Can we get the file back like it was? It is not exactly "like it was", if you see what I mean ;-) Please note that when you change the version number for the next release, 'make' will regenerate the file for you with updated version information that you will probably want to include in the same version-change commit... -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.6-323-g71809a2
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project wmaker-crm.git. The branch, next has been updated discards 9dd875b1cfc6ab48bf82250781b5001f080019d0 (commit) discards f3ac6bb9233a0be20c2c6f0b8c09c6419410cb0f (commit) discards 84284e604e72fc4e54f01eaef1caf70a97c6065f (commit) via 71809a2011b126a984bbbe2ed230673c62a26eeb (commit) via e666cfc6a57248c8db8e51100a9bb019f33a8284 (commit) via ae7e228aa400edf0beb0f61499eaf41cc95af3fc (commit) via 0dfb42caae93e37f31a2e0c600e321cd18cb8bbe (commit) via 6691a653a73449b785c9d819eb7f4f3e95e32a55 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (9dd875b1cfc6ab48bf82250781b5001f080019d0) \ N -- N -- N (71809a2011b126a984bbbe2ed230673c62a26eeb) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://repo.or.cz/w/wmaker-crm.git/commit/71809a2011b126a984bbbe2ed230673c62a26eeb commit 71809a2011b126a984bbbe2ed230673c62a26eeb Author: Christophe CURIS Date: Sat Jun 20 18:24:00 2015 +0200 doc: include the "INSTALL-WMAKER" documentation in the repository As suggested by Carlos, the instruction to compile from the repository are included in this document, so it is a good idea to have it in the repository, even if it is a generated file. In addition, "autogen.sh" will not generate it anymore as it would create an incorrect version of it (the reference to the version number would be wrong). When the source file is modified, "make" will re-generate accordingly the file, so there should be no problem. Suggested-by: Carlos R. Mafra Signed-off-by: Christophe CURIS diff --git a/.gitignore b/.gitignore index e50a2b7..0e94104 100644 --- a/.gitignore +++ b/.gitignore @@ -32,7 +32,6 @@ m4/lt~obsolete.m4 src/wconfig.h # These files are generated by scripts -INSTALL-WMAKER README.i18n # These files are compilation stuff diff --git a/INSTALL-WMAKER b/INSTALL-WMAKER new file mode 100644 index 000..64e07e4 --- /dev/null +++ b/INSTALL-WMAKER @@ -0,0 +1,717 @@ + + + + + + Window Maker Compilation and Installation + + + ~ A guide to configure, compile and install ~ + ~ Window Maker from sources. ~ + + -- The Window Maker Team -- + + + + +This manual is for Window Maker window manager, version 0.95.6. + +Copyright (c) 2015 The Window Maker Team. + +This program is free software; you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software Foundation; either version 2 of the License, or +(at your option) any later version. + +This program is distributed in the hope that it will be useful, but +WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +General Public License for more details. + +You should have received a copy of the GNU General Public License +along with this program, see file COPYING for details. + + + Published by The Window Maker team on 20 June 2015. + + + + + +1 Prerequisites . . . . . . . . . . . . . . . . . . . . . . . . 73 + 1.1 Supported Platforms . . . . . . . . . . . . . . . . . . . 77 + 1.2 Software Dependencies . . . . . . . . . . . . . . . . . . 88 + 1.3 Special Dependencies . . . . . . . . . . . . . . . . . . 122 + 1.4 Optional Dependencies . . . . . . . . . . . . . . . . . . 134 + +2 Building Window Maker . . . . . . . . . . . . . . . . . . . . 223 + 2.1 Getting the Sources . . . . . . . . . . . . . . . . . . . 227 + 2.2 Build and Install . . . . . . . . . . . . . . . . . . . . 248 + 2.3 User specific configuration . . . . . . . . . . . . . . . 298 + 2.4 Locales/Internationalisation . . . . . . . . . . . . . . 324 + 2.5 Configure Options . . . . . . . . . . . . . . . . . . . . 332 +2.5.1 Installation Directory . . . . . . . . . . . . . . . 346 +2.5.2 External Libraries . . . . . . . . . . . . . . . . . 391 +2
Re: Compile problem
The git repository is not the distribution tarball. As long as the INSTALL-WMAKER file is generated at make time, and is included in the make dist-*, then it’s fine. Based upon my latest build of the master branch, that is indeed the case. If it really is auto-generated there is no need for it to be in the repository whatsoever. It’s merely a build artifact. A person going to the actual git repository is expected to be a developer, or someone who is interested in opening the doors and peeking inside the sausage factory, as it were. We can assume they know how to run autogen.sh, since there isn’t even a ./configure script. [jhriv@chao:/tmp/wmaker.next] (:e666cfc|…)± ./autogen.sh && ./configure && make dist-gzip && tar tf WindowMaker-0.95.6.tar.gz|grep INSTALL-WMAKER WindowMaker-0.95.6/INSTALL-WMAKER That’s from next, right before the commit that restored the auto generated INSTALL-WMAKER -john > On Jun 20, 2015, at 6:22 AM, Carlos R. Mafra wrote: > > On Sat, 20 Jun 2015 at 12:05:42 +0200, Christophe wrote: >> - Josip Deanovic a écrit : >> >>> Further more, one cannot read the list of prerequisites as the file >>> INSTALL-WMAKER gets built only after you already have some of them >>> met e.g. autoconf, automake, possibly more. >> >> Yes, that is a known limit of the procedure in place. Actually this >> file is more meant for people compiling from the official package, >> which do not have these problems. The goal is for people compiling from >> Git to find this information online on the Website, which is an ongoing >> task. > > Sorry, this makes no sense. > > The INSTALL-WMAKER file should be a plain text for people to read without > any hassle. It should contain information to help people install > wmaker. Its existence cannot depend on things that the file is meant to > warn about in the first place. > > Can we get the file back like it was? > > > -- > To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH] wmaker: Allow window snapping and linked workspaces simultaneously.
If workspaces are linked, then windows will only snap to the top or bottom
of the screen.
Suggested-by: Josip Deanovic
---
NEWS | 8
src/moveres.c | 7 +--
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/NEWS b/NEWS
index 023ceb1..fb96dbb 100644
--- a/NEWS
+++ b/NEWS
@@ -12,10 +12,10 @@ screen, by dragging it to that side or corner. It is
enabled by setting
"WindowSnapping = YES" in ~/GNUstep/Defaults/WindowMaker or selecting "Enable
window snapping" under "Expert User Preferences" in WPrefs.app.
-Note that window snapping is automatically disabled if "Switch workspaces while
-dragging windows" is selected under "Workspace Preferences" in WPrefs.app, or
-if "DontLinkWorkspaces = NO" in ~/GNUstep/Defaults/WindowMaker, as this
feature
-also involves dragging a window to one side of the screen.
+Note that if "Switch workspaces while dragging windows" is selected under
+"Workspace Preferences" in WPrefs.app, or if "DontLinkWorkspaces = NO" in
+~/GNUstep/Defaults/WindowMaker, then you may only snap a window to the top or
+bottom of the screen.
Dragging maximized windows
diff --git a/src/moveres.c b/src/moveres.c
index b271f32..4f10a18 100644
--- a/src/moveres.c
+++ b/src/moveres.c
@@ -1766,12 +1766,15 @@ int wMouseMoveWindow(WWindow * wwin, XEvent * ev)
break;
case MotionNotify:
- if (IS_RESIZABLE(wwin) && wPreferences.window_snapping
&& wPreferences.no_autowrap) {
+ if (IS_RESIZABLE(wwin) && wPreferences.window_snapping)
{
int snap_direction;
snap_direction = get_snap_direction(scr,
moveData.mouseX, moveData.mouseY);
- if (moveData.snap != snap_direction) {
+ if ((wPreferences.no_autowrap ||
+snap_direction == SNAP_TOP ||
+snap_direction == SNAP_BOTTOM) &&
+ moveData.snap != snap_direction) {
/* erase old frame */
if (moveData.snap)
draw_snap_frame(wwin,
moveData.snap);
--
2.1.4
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH v3] NEWS: Add note about window snapping.
On 06/20/2015 03:41 AM, Josip Deanovic wrote: Doug, would it be to hard to not completely disable the feature in case DontLinkWorkspaces is set to "NO" but to disable just the left/right and corner snapping instead? That way someone who is using workspace linking feature could still snap a window top/bottom which is still more than nothing (actually I feel I would really like that feature while still being able to use workspace linking). Thanks for the suggestion! I just submitted a patch with this change. Doug -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH v3] NEWS: Add note about window snapping.
Quoting message written on Saturday 2015-06-20 12:35:33: > On 06/20/2015 03:41 AM, Josip Deanovic wrote: > > Doug, would it be to hard to not completely disable the feature in > > case > > DontLinkWorkspaces is set to "NO" but to disable just the left/right > > and corner snapping instead? > > > > That way someone who is using workspace linking feature could still > > snap a window top/bottom which is still more than nothing (actually I > > feel I would really like that feature while still being able to use > > workspace linking). > > Thanks for the suggestion! > > I just submitted a patch with this change. > > Doug Thank you very much. I'll test it as soon as I get some time. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH v3] NEWS: Add note about window snapping.
Quoting message written on Saturday 2015-06-20 12:35:33: > On 06/20/2015 03:41 AM, Josip Deanovic wrote: > > Doug, would it be to hard to not completely disable the feature in > > case > > DontLinkWorkspaces is set to "NO" but to disable just the left/right > > and corner snapping instead? > > > > That way someone who is using workspace linking feature could still > > snap a window top/bottom which is still more than nothing (actually I > > feel I would really like that feature while still being able to use > > workspace linking). > > Thanks for the suggestion! > > I just submitted a patch with this change. > > Doug I have just applied the patch and tested it and something is not right. Without workspace linking the feature is still working as usual. With workspace linking enabled I get the window frame created UP/DOWN, depending on the window position but if I decide to stop the snapping action (move the window from the upper/lower border) the window frame would stay and when I release the window it would snap to the border and change its size. So once the window gets near the upper/lower border and its new frame gets drawn, the only thing I can do is to move the window to the opposite border where window would act just the same. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH v3] NEWS: Add note about window snapping.
On 06/20/2015 05:11 PM, Josip Deanovic wrote: I have just applied the patch and tested it and something is not right. Without workspace linking the feature is still working as usual. With workspace linking enabled I get the window frame created UP/DOWN, depending on the window position but if I decide to stop the snapping action (move the window from the upper/lower border) the window frame would stay and when I release the window it would snap to the border and change its size. So once the window gets near the upper/lower border and its new frame gets drawn, the only thing I can do is to move the window to the opposite border where window would act just the same. Oops, must have tested it too quickly. I'll give it another shot and submit a new version soon. Doug -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH v2] wmaker: Allow window snapping and linked workspaces simultaneously.
If workspaces are linked, then windows will only snap to the top or bottom
of the screen.
Suggested-by: Josip Deanovic
---
NEWS | 8
src/moveres.c | 7 ++-
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/NEWS b/NEWS
index 023ceb1..fb96dbb 100644
--- a/NEWS
+++ b/NEWS
@@ -12,10 +12,10 @@ screen, by dragging it to that side or corner. It is
enabled by setting
"WindowSnapping = YES" in ~/GNUstep/Defaults/WindowMaker or selecting "Enable
window snapping" under "Expert User Preferences" in WPrefs.app.
-Note that window snapping is automatically disabled if "Switch workspaces while
-dragging windows" is selected under "Workspace Preferences" in WPrefs.app, or
-if "DontLinkWorkspaces = NO" in ~/GNUstep/Defaults/WindowMaker, as this
feature
-also involves dragging a window to one side of the screen.
+Note that if "Switch workspaces while dragging windows" is selected under
+"Workspace Preferences" in WPrefs.app, or if "DontLinkWorkspaces = NO" in
+~/GNUstep/Defaults/WindowMaker, then you may only snap a window to the top or
+bottom of the screen.
Dragging maximized windows
diff --git a/src/moveres.c b/src/moveres.c
index b271f32..cded064 100644
--- a/src/moveres.c
+++ b/src/moveres.c
@@ -1766,11 +1766,16 @@ int wMouseMoveWindow(WWindow * wwin, XEvent * ev)
break;
case MotionNotify:
- if (IS_RESIZABLE(wwin) && wPreferences.window_snapping
&& wPreferences.no_autowrap) {
+ if (IS_RESIZABLE(wwin) && wPreferences.window_snapping)
{
int snap_direction;
snap_direction = get_snap_direction(scr,
moveData.mouseX, moveData.mouseY);
+ if (!wPreferences.no_autowrap &&
+ snap_direction != SNAP_TOP &&
+ snap_direction != SNAP_BOTTOM)
+ snap_direction = SNAP_NONE;
+
if (moveData.snap != snap_direction) {
/* erase old frame */
if (moveData.snap)
--
2.1.4
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH v3] NEWS: Add note about window snapping.
On 06/20/2015 05:11 PM, Josip Deanovic wrote: I have just applied the patch and tested it and something is not right. Without workspace linking the feature is still working as usual. With workspace linking enabled I get the window frame created UP/DOWN, depending on the window position but if I decide to stop the snapping action (move the window from the upper/lower border) the window frame would stay and when I release the window it would snap to the border and change its size. So once the window gets near the upper/lower border and its new frame gets drawn, the only thing I can do is to move the window to the opposite border where window would act just the same. I think I've fixed this. I've just sent a revised patch. Doug -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
