Re: [OpenJDK 2D-Dev] [9] RFR: Test closed/javax/print/attribute/Services_getDocFl.java fails with NullpointerException (8040139)

I had to hunt for this since you did not include the bug number in the subject line. The fix is fine although you really should explain to people why this approach is taken rather than ignoring the printer. i.e it is prohibitively expensive to use "lpstat -p" when simply enumerating available p

Re: [OpenJDK 2D-Dev] Question regarding the integration of harfbuzz (JEP 258)

Volker, 0. I’d like to see what the crashing stack frame is when NOT on harfbuzz, because there should be no change. 1. Phil addressed this one 2. I will take a look on AIX. I’ll see if I can build Harfbuzz itself on AIX at first. 3. Yes, I’ll work on putting some docs together for that te

Re: [OpenJDK 2D-Dev] RFR 8144446: Automate the Marlin crash test

Ignore that first paragraph - a thought train that didn't go anywhere and I forgot to delete it... ...jim On 12/9/15 4:27 PM, Jim Graham wrote: Hi Laurent, I did some more reading about jtreg and discovered that an @run is supposed to be assumed if none are present, bu

Re: [OpenJDK 2D-Dev] RFR 8144446: Automate the Marlin crash test

Hi Laurent, I did some more reading about jtreg and discovered that an @run is supposed to be assumed if none are present, but The fix looks correct, but one thing I would tend to do for robustness is that in an error case, rather than duplicate the logic that was skipped (which can get out

Re: [OpenJDK 2D-Dev] RFR 8144446: Automate the Marlin crash test

Jim, My last chance for tonight ! Here is another webrev that disables two long tests (dasher) in CrashTest but fixes a state cleanup bug in Renderer (doChecks=true): http://cr.openjdk.java.net/~lbourges/marlin/marlin-816.2/ Note: the modified CrashTest detected this bug in Renderer (happeni

Re: [OpenJDK 2D-Dev] RFR: 8137106: EUDC (End User Defined Characters) are not displayed on Windows with Java 8u60+

Looks good. Jennifer On 12/07/2015 10:03 AM, Phil Race wrote: Fixed : http://cr.openjdk.java.net/~prr/8137106.1/ -phil. On 12/07/2015 09:21 AM, Philip Race wrote: Yeah .. that should have been true. I'll upload a fixed patch. -phil. On 12/7/15, 8:14 AM, Sergey Bylokhov wrote: Hi, Phil. It

Re: [OpenJDK 2D-Dev] RFR 8144446: Automate the Marlin crash test

Hi Laurent, That sounds good. I'm all for fast tests! ;) We might want to fix them in separate bugs, though. If the new mods to the test case lead to failures, then we should integrate them after we fix the underlying problems, though, to prevent testing failures that might block an integr

Re: [OpenJDK 2D-Dev] RFR 8144446: Automate the Marlin crash test

Jim, Thanks for explaining me the different jtreg modes (newbie) ! I tried disabling few long tests (using dashes) that are less critical (no failure expected, just insane rendering work): test(0.1f, false, 0); test(0.1f, true, 7f); Doing so, I detected a new issue in the

Re: [OpenJDK 2D-Dev] RFR 8144445: Maximum size checking in Marlin ArrayCache utility methods is not optimal

Looks good. And verified that the test fails before the fix and passes after... ...jim On 12/9/15 1:38 PM, Laurent Bourgès wrote: Hi Jim, I took me some time to understand your detailled analysis and make a new webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin

Re: [OpenJDK 2D-Dev] RFR 8144445: Maximum size checking in Marlin ArrayCache utility methods is not optimal

Hi Jim, I took me some time to understand your detailled analysis and make a new webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-815.2/ I think I adopted all your change proposals, see below: In looking this over again I notice that really the exceptions are only > thrown on "out

Re: [OpenJDK 2D-Dev] RFR 8144828: Marlin renderer causes unaligned write accesses

I noticed that too, but they are equivalent. I think it is much more common to use ~3, but I didn't wan to hold this up for a syntax nit... ...jim On 12/9/15 10:34 AM, Philip Race wrote: looks fine although I wonder why you use & -4 instead of & ~3 ? -phil. On 12/8/

Re: [OpenJDK 2D-Dev] RFR 8144446: Automate the Marlin crash test

Hi Laurent, One clarification - there are levels of automation. On 12/9/15 6:35 AM, Laurent Bourgès wrote: Agreed it is possible but then the bug JDK-816 becomes invalid. Prior to this fix, jtreg wouldn't even see the test since it did no

Re: [OpenJDK 2D-Dev] RFR 8144828: Marlin renderer causes unaligned write accesses

Phil, To be short: ~3= -4. You are right, javac could have done that computation for me ! Laurent Le 9 déc. 2015 19:34, "Philip Race" a écrit : > > looks fine although I wonder why you use & -4 instead of & ~3 ? > > -phil. > > > > On 12/8/15, 3:17 PM, Jim Graham wrote: >> >> With the submissio

Re: [OpenJDK 2D-Dev] Question regarding the integration of harfbuzz (JEP 258)

Hmm. Should JEP 254 really have " removed the handling of empty strings from jni_GetStringCritical()." without tracking down uses and updating them ? I didn't mean IBM already ship harfbuzz in their JDK but I thought they were already using it in some other IBM products. -phil. On 12/9/15, 10:

Re: [OpenJDK 2D-Dev] Question regarding the integration of harfbuzz (JEP 258)

Hi Phil, thanks a lot for your answer. Please find my comments inline: On Wed, Dec 9, 2015 at 6:02 PM, Philip Race wrote: > Hi Volker, > > Running with ICU should stop harfbuzz use completely so if > you are still seeing a crash, perhaps it is due to something else entirely. Yes, it was indeed

Re: [OpenJDK 2D-Dev] RFR 8144828: Marlin renderer causes unaligned write accesses

looks fine although I wonder why you use & -4 instead of & ~3 ? -phil. On 12/8/15, 3:17 PM, Jim Graham wrote: With the submission of JDK-8144938 as a follow-on bug, this fix looks fine now... ...jim On 12/7/15 5:13 PM, Jim Graham wrote: Do we make sure that the subpixel coords

Re: [OpenJDK 2D-Dev] Question regarding the integration of harfbuzz (JEP 258)

Hi Volker, Running with ICU should stop harfbuzz use completely so if you are still seeing a crash, perhaps it is due to something else entirely. Especially since a "simple AWT program" should not load layout anyway. There was a fair amount of new and changed code pushed recently ... Yes, we nee

Re: [OpenJDK 2D-Dev] RFR 8144446: Automate the Marlin crash test

Jim & Sergey, Here are my comments: 2015-12-09 13:57 GMT+01:00 Sergey Bylokhov : > On 09/12/15 02:12, Jim Graham wrote: > >> Hi Laurent, >> >> If this were testing a bug that crossed a number of implementation >> boundaries such that any number of engineers might make a change that >> could caus

Re: [OpenJDK 2D-Dev] RFR 6488522: PNG writer should permit setting compression level and iDAT chunk maximum size

Hi Sergey, Thanks for your comments, did you review the PNGImageWriter changes too ? 2015-12-09 14:19 GMT+01:00 Sergey Bylokhov : > Hi, Laurent. > Should the test check the resulted image in the file? At least it can > check that the CompressionMode is not ignored and the saved files have > diff

Re: [OpenJDK 2D-Dev] RFR 6488522: PNG writer should permit setting compression level and iDAT chunk maximum size

Hi, Laurent. Should the test check the resulted image in the file? At least it can check that the CompressionMode is not ignored and the saved files have different size/content for different modes? Also I think in the test we can cover all plugins which canWriteCompressed=true? On 09/12/15 15

Re: [OpenJDK 2D-Dev] RFR 8144446: Automate the Marlin crash test

On 09/12/15 02:12, Jim Graham wrote: Hi Laurent, If this were testing a bug that crossed a number of implementation boundaries such that any number of engineers might make a change that could cause it to fail, then I might agree with the need to run it whenever any automated run of tests occurs.

Re: [OpenJDK 2D-Dev] RFR :

Sorry I forgot to fill the mail subject ! I have sent another email. Laurent

[OpenJDK 2D-Dev] RFR 6488522: PNG writer should permit setting compression level and iDAT chunk maximum size

Hi, Please review this webrev fixing the long-standing bug in imageio PNGImageWriter to support compression levels: bug: https://bugs.openjdk.java.net/browse/JDK-6488522 webrev: http://cr.openjdk.java.net/~lbourges/png/PNGWriter-6488522.0/ Changes: - default Deflater level changed from 9 (best) t

[OpenJDK 2D-Dev] RFR :

Hi, Please review this webrev fixing the long-standing bug in imageio PNGImageWriter to support compression levels: bug: https://bugs.openjdk.java.net/browse/JDK-6488522 webrev: http://cr.openjdk.java.net/~lbourges/png/PNGWriter-6488522.0/ Changes: - default Deflater level changed from 9 (best) t