On Fri, 16 Jun 2023 11:41:14 GMT, Axel Boldt-Christmas
wrote:
>> The current implementation for testing generational ZGC with jtreg is
>> implemented with a filter on the mode flag `ZGenerational`. Because of this
>> only environments which set this flag explicitly will run most of the tests.
On Fri, 16 Jun 2023 11:41:14 GMT, Axel Boldt-Christmas
wrote:
>> The current implementation for testing generational ZGC with jtreg is
>> implemented with a filter on the mode flag `ZGenerational`. Because of this
>> only environments which set this flag explicitly will run most of the tests.
Generational ZGC changed the location where the heap object iterator called the
visit function. It used to be called when the objects were popped and then
followed, but it was changed so that the function where called immediately when
the objects are marked. This gave the benefit that the
On Fri, 16 Jun 2023 11:52:51 GMT, Stefan Karlsson wrote:
> Generational ZGC changed the location where the heap object iterator called
> the visit function. It used to be called when the objects were popped and
> then followed, but it was changed so that the function whe
On Fri, 16 Jun 2023 11:41:14 GMT, Axel Boldt-Christmas
wrote:
>> The current implementation for testing generational ZGC with jtreg is
>> implemented with a filter on the mode flag `ZGenerational`. Because of this
>> only environments which set this flag explicitly will run most of the tests.
On Fri, 9 Jun 2023 10:07:31 GMT, Viktor Klang wrote:
>> The test used a too-small heap for generic testing, and coupled with looking
>> at `freeMemory()` it led to a less-than-ideal determinism of execution of
>> the test.
>
> Viktor Klang has updated the pull request incrementally with one
On Sun, 4 Jun 2023 11:28:33 GMT, Alan Bateman wrote:
> Thread.sleep has had quite a bit of churn recently to support virtual
> threads, add sleep(Duration), a JFR event, and the change the underlying
> implementation to support sub-millis precision. I think the changes have
> settled down now
On Sun, 4 Jun 2023 11:28:33 GMT, Alan Bateman wrote:
> Thread.sleep has had quite a bit of churn recently to support virtual
> threads, add sleep(Duration), a JFR event, and the change the underlying
> implementation to support sub-millis precision. I think the changes have
> settled down now
On Fri, 2 Jun 2023 02:49:25 GMT, Kelvin Nilsen wrote:
>> OpenJDK Colleagues:
>>
>> Please review this proposed integration of Generational mode for Shenandoah
>> GC under https://bugs.openjdk.org/browse/JDK-8307314.
>>
>> Generational mode of Shenandoah is enabled by adding
>>
On Fri, 2 Jun 2023 02:49:25 GMT, Kelvin Nilsen wrote:
>> OpenJDK Colleagues:
>>
>> Please review this proposed integration of Generational mode for Shenandoah
>> GC under https://bugs.openjdk.org/browse/JDK-8307314.
>>
>> Generational mode of Shenandoah is enabled by adding
>>
On Fri, 26 May 2023 20:46:29 GMT, Kelvin Nilsen wrote:
> OpenJDK Colleagues:
>
> Please review this proposed integration of Generational mode for Shenandoah
> GC under https://bugs.openjdk.org/browse/JDK-8307314.
>
> Generational mode of Shenandoah is enabled by adding
>
On Fri, 26 May 2023 20:46:29 GMT, Kelvin Nilsen wrote:
> OpenJDK Colleagues:
>
> Please review this proposed integration of Generational mode for Shenandoah
> GC under https://bugs.openjdk.org/browse/JDK-8307314.
>
> Generational mode of Shenandoah is enabled by adding
>
On Mon, 29 May 2023 10:09:15 GMT, Johan Sjölen wrote:
> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
> I'd appreciate if this was considered trivial.
Looks good. Though, I'd prefer if we could slightly tweak the following two
print lines.
On Thu, 19 Jan 2023 17:23:19 GMT, Justin King wrote:
>> Remove abstraction that is a holdover from Solaris. Direct usages of
>> `MmapArrayAllocator` have been switched to normal `malloc`. The
>> justification is that none of the code paths are called from signal
>> handlers, so using `mmap`
On Tue, 16 May 2023 18:07:16 GMT, Leonid Mesnik wrote:
> Trivial fix that added missed useful command.
> Tested by running make of failure handler and verifying results.
Marked as reviewed by stefank (Reviewer).
-
PR Review:
On Tue, 16 May 2023 18:07:16 GMT, Leonid Mesnik wrote:
> Trivial fix that added missed useful command.
> Tested by running make of failure handler and verifying results.
This looks good and "trivial". Thanks for fixing this.
-
PR Comment:
On Thu, 11 May 2023 12:12:56 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of th
On Wed, 3 May 2023 09:04:50 GMT, Stefan Karlsson wrote:
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generatio
On Thu, 11 May 2023 12:12:56 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of th
On Wed, 3 May 2023 09:04:50 GMT, Stefan Karlsson wrote:
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generatio
to
> mash the two implementations together and sprinkle the GC code with
> conditional statements or dynamic dispatches. We have done similar
> experiments before. When ZGC was first born, we started an experiment where
> we converted G1 into getting the same features as the evolving ZG
to
> mash the two implementations together and sprinkle the GC code with
> conditional statements or dynamic dispatches. We have done similar
> experiments before. When ZGC was first born, we started an experiment where
> we converted G1 into getting the same features as the evolving ZG
to
> mash the two implementations together and sprinkle the GC code with
> conditional statements or dynamic dispatches. We have done similar
> experiments before. When ZGC was first born, we started an experiment where
> we converted G1 into getting the same features as the evolving ZG
to
> mash the two implementations together and sprinkle the GC code with
> conditional statements or dynamic dispatches. We have done similar
> experiments before. When ZGC was first born, we started an experiment where
> we converted G1 into getting the same features as the evolving ZG
On Wed, 10 May 2023 13:43:41 GMT, Martin Doerr wrote:
>> You are reasoning about implementation details. By using the provided
>> abstraction you and other maintainers (who might be unfamiliar with them)
>> would not have to do that. Also the assumptions you make introduce a hidden
>>
On Tue, 9 May 2023 12:55:42 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of th
On Tue, 9 May 2023 12:55:42 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of th
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Ora
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Ora
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&g
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&g
On Tue, 9 May 2023 00:50:56 GMT, Fei Yang wrote:
>> That's unfortunate. Could you try this patch, which probes the address range
>> to see if it can reserve the memory somewhere else within
>> `[ZAddressHeapBase, ZAddressHeapBase+ZAddressOffsetMax)`:
>>
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&
On Tue, 9 May 2023 00:50:56 GMT, Fei Yang wrote:
>> That's unfortunate. Could you try this patch, which probes the address range
>> to see if it can reserve the memory somewhere else within
>> `[ZAddressHeapBase, ZAddressHeapBase+ZAddressOffsetMax)`:
>>
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&g
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&g
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&g
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&g
On Mon, 8 May 2023 10:19:44 GMT, Fei Yang wrote:
>> Could you provide the values for `reserved`, `ZAddressHeapBase`, and
>> `ZAddressOffsetMax`, when this test is failing. I'd like to know if we can
>> make a workaround for you, or if we have to turn off the test for riscv.
>
> @stefank : I
On Mon, 8 May 2023 10:19:44 GMT, Fei Yang wrote:
>> Could you provide the values for `reserved`, `ZAddressHeapBase`, and
>> `ZAddressOffsetMax`, when this test is failing. I'd like to know if we can
>> make a workaround for you, or if we have to turn off the test for riscv.
>
> @stefank : I
On Thu, 4 May 2023 09:33:49 GMT, Stefan Karlsson wrote:
> When running jstat tests like the following:
> test/jdk/sun/tools/jstatd/TestJstatdServer.java
>
> with Generational ZGC we get a failure because the O (old generation
> percentage) is reported as `-` and not a number.
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&g
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&g
On Fri, 5 May 2023 06:28:59 GMT, Yadong Wang wrote:
>> Thanks for reporting. It would be interesting to see what address you get
>> and compare it to the range [ZAddressHeapBase,
>> ZAddressHeapBase+ZAddressOffsetMax).
>
> We emailed to erik to discuss this issue two months ago, and maybe he
On Fri, 5 May 2023 06:28:59 GMT, Yadong Wang wrote:
>> Thanks for reporting. It would be interesting to see what address you get
>> and compare it to the range [ZAddressHeapBase,
>> ZAddressHeapBase+ZAddressOffsetMax).
>
> We emailed to erik to discuss this issue two months ago, and maybe he
On Fri, 5 May 2023 01:54:48 GMT, Fei Yang wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> undefine glibc major/minor macros
>
> test/hotspot/gtest/gc/z/test_zForwarding.cpp line
On Fri, 5 May 2023 01:54:48 GMT, Fei Yang wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> undefine glibc major/minor macros
>
> test/hotspot/gtest/gc/z/test_zForwarding.cpp line
On Thu, 4 May 2023 20:21:12 GMT, Andrey Turbanov wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> undefine glibc major/minor macros
>
> test/hotspot/jtreg/runtime/stringtable/Str
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC throug
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC throug
On Thu, 4 May 2023 20:21:12 GMT, Andrey Turbanov wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> undefine glibc major/minor macros
>
> test/hotspot/jtreg/runtime/stringtable/Str
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
On Thu, 4 May 2023 09:52:25 GMT, Thomas Schatzl wrote:
> Is it possible to remove the G1 hack in this change too? Because since now a
> zero value is supported in the output, there does not seem to be a reason to
> keep it for G1.
I prefer if that is done and tested as a separate PR.
When running jstat tests like the following:
test/jdk/sun/tools/jstatd/TestJstatdServer.java
with Generational ZGC we get a failure because the O (old generation
percentage) is reported as `-` and not a number. The reason why it is reported
as `-` is that the current capacity of the old
On Wed, 3 May 2023 21:08:39 GMT, Stefan Karlsson wrote:
>> test/jdk/ProblemList-generational-zgc.txt line 27:
>>
>>> 25: #
>>> 26: # List of quarantined tests for testing with Generational ZGC.
>>> 27: #
>>
>> Are the tests in `test/j
On Wed, 3 May 2023 21:08:39 GMT, Stefan Karlsson wrote:
>> test/jdk/ProblemList-generational-zgc.txt line 27:
>>
>>> 25: #
>>> 26: # List of quarantined tests for testing with Generational ZGC.
>>> 27: #
>>
>> Are the tests in `test/j
On Wed, 3 May 2023 21:32:54 GMT, Martin Doerr wrote:
> I'm getting build warnings on all linux platforms with gcc-11.3.0:
>
> ```
> src/hotspot/share/gc/z/zDriver.cpp:84:13: error: In the GNU C Library,
> "minor" is defined
> by . For historical compatibility, it is
> currently defined by
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle'
On Wed, 3 May 2023 21:32:54 GMT, Martin Doerr wrote:
> I'm getting build warnings on all linux platforms with gcc-11.3.0:
>
> ```
> src/hotspot/share/gc/z/zDriver.cpp:84:13: error: In the GNU C Library,
> "minor" is defined
> by . For historical compatibility, it is
> currently defined by
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle'
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle
On Wed, 3 May 2023 20:00:42 GMT, Chris Plummer wrote:
>> Yes, the test was finicky with the heap size. Given that the leak it tries
>> to provoke would be provoked by other GCs as well, we didn't think it was
>> that important to run this particular test with Generational ZGC. If you
>> still
On Wed, 3 May 2023 20:00:42 GMT, Chris Plummer wrote:
>> Yes, the test was finicky with the heap size. Given that the leak it tries
>> to provoke would be provoked by other GCs as well, we didn't think it was
>> that important to run this particular test with Generational ZGC. If you
>> still
On Wed, 3 May 2023 18:54:24 GMT, Chris Plummer wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix PPC build after 8305668
>
> test/jdk/ProblemList-generational-zgc.txt line
On Wed, 3 May 2023 18:54:24 GMT, Chris Plummer wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix PPC build after 8305668
>
> test/jdk/ProblemList-generational-zgc.txt line
On Wed, 3 May 2023 18:57:22 GMT, Chris Plummer wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix PPC build after 8305668
>
> test/jdk/com/sun/jdi/ThreadMemoryLeakTest.ja
On Wed, 3 May 2023 18:57:22 GMT, Chris Plummer wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix PPC build after 8305668
>
> test/jdk/com/sun/jdi/ThreadMemoryLeakTest.ja
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
>
On Wed, 3 May 2023 18:52:19 GMT, Chris Plummer wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix PPC build after 8305668
>
> test/hotspot/jtreg/ProblemList-generational-zgc.txt
On Wed, 3 May 2023 18:52:19 GMT, Chris Plummer wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix PPC build after 8305668
>
> test/hotspot/jtreg/ProblemList-generational-zgc.txt
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
>
On Wed, 3 May 2023 12:29:15 GMT, Martin Doerr wrote:
> Thanks for fixing PPC64! With this, the VM compiles and the
> `test/hotspot/jtreg/gc` tests are passing on linux PPC64le.
>
> I'm glad to see this PR for JDK 21 LTS. It's a big step forward for ZGC.
> Congratulations!
Thanks for porting
On Wed, 3 May 2023 12:29:15 GMT, Martin Doerr wrote:
> Thanks for fixing PPC64! With this, the VM compiles and the
> `test/hotspot/jtreg/gc` tests are passing on linux PPC64le.
>
> I'm glad to see this PR for JDK 21 LTS. It's a big step forward for ZGC.
> Congratulations!
Thanks for porting
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&
Hi all,
Please review the implementation of Generational ZGC, which can be turned on by
adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational ZGC is
a major rewrite of the non-generational ZGC version that exists in the
openjdk/jdk repository. It splits the heap into two
Hi all,
Please review the implementation of Generational ZGC, which can be turned on by
adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational ZGC is
a major rewrite of the non-generational ZGC version that exists in the
openjdk/jdk repository. It splits the heap into two
On Mon, 24 Apr 2023 08:24:53 GMT, Kim Barrett wrote:
> Please review this change to the string deduplication thread to make it a kind
> of JavaThread rather than a ConcurrentGCThread. There are several pieces to
> this change:
>
> (1) New class StringDedupThread (derived from JavaThread),
On Wed, 12 Apr 2023 02:08:08 GMT, David Holmes wrote:
>> That seems fine to me, as long as we don't crash. But my understanding is
>> that Generational ZGC will crash if it sees a stale oop. Isn't it possible
>> that the racing read sees junk that looks to Generational ZGC like a stale
>>
On Tue, 11 Apr 2023 13:48:15 GMT, Roman Kennke wrote:
>> It looks to me like the code could read racingly read the element just above
>> `_top`, which could contain a stale oop. If the address of the stale oop
>> matches the address of `o` then `contains` would incorrectly return true.
>>
>>
On Tue, 11 Apr 2023 11:47:46 GMT, Roman Kennke wrote:
>> src/hotspot/share/runtime/lockStack.inline.hpp line 111:
>>
>>> 109: int end = to_index(_top);
>>> 110: for (int i = end - 1; i >= 0; i--) {
>>> 111: if (NativeAccess<>::oop_load(&_base[i]) == o) {
>>
>> The use of NativeAccess
On Thu, 6 Apr 2023 11:59:45 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Tue, 7 Feb 2023 17:25:02 GMT, Justin King wrote:
>> - Rename `MEMFLAGS` to `MemoryType`. `MEMFLAGS` is highly misleading as
>> flags typically can be combined.
>> - Update `MemoryType` to have enumeration names that follow the style guide,
>> no `mt` prefix.
>> - Create aliases for old
On Wed, 25 Jan 2023 11:45:47 GMT, Johan Sjölen wrote:
> Do the conversion in the share/memory/ sub-directory and all of its files.
Marked as reviewed by stefank (Reviewer).
src/hotspot/share/memory/guardedMemory.hpp line 196:
> 194:*/
> 195: void* wrap_with_guards(void* base_ptr, size_t
On Wed, 11 Jan 2023 20:53:38 GMT, Justin King wrote:
>> Remove abstraction that is a holdover from Solaris. Direct usages of
>> `MmapArrayAllocator` have been switched to normal `malloc`. The
>> justification is that none of the code paths are called from signal
>> handlers, so using `mmap`
On Wed, 11 Jan 2023 14:27:44 GMT, Justin King wrote:
> ArrayAllocator with ArrayAllocatorMallocLimit removed is effectively
> MallocArrayAllocator. Are you suggesting leaving MallocArrayAllocator and
> MmapArrayAllocator thus update references to ArrayAllocator to be
> MallocArrayAllocator?
On Tue, 10 Jan 2023 22:50:11 GMT, Justin King wrote:
>> Remove abstraction that is a holdover from Solaris. Direct usages of
>> `MmapArrayAllocator` have been switched to normal `malloc`. The
>> justification is that none of the code paths are called from signal
>> handlers, so using `mmap`
On Tue, 10 Jan 2023 10:51:14 GMT, Albert Mingkun Yang wrote:
> Simple change of using the actual type for a field.
>
> Test: hotspot_gc
Looks good. Some nits:
src/hotspot/share/gc/serial/tenuredGeneration.hpp line 68:
> 66: void assert_correct_size_change_locking();
> 67:
> 68:
On Wed, 14 Dec 2022 22:22:48 GMT, David Holmes wrote:
> This is a simple cleanup RFE to get rid of old-style C casts in relation to
> JavaThread.
>
> In many cases involving NULL/nullptr the cast could just be dropped.
> Sometimes a static cast is needed to disambiguate overloads.
>
> A
On Wed, 7 Dec 2022 11:16:03 GMT, Albert Mingkun Yang wrote:
> Small change of merging two classes to reduce inheritance chain length.
>
> Test: hotspot_gc
Marked as reviewed by stefank (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11556
On Fri, 11 Nov 2022 14:26:20 GMT, Stefan Karlsson wrote:
> The sorted blocks of includes have deteriorated to the point that I felt
> compelled to clean up some of the issues.
>
> *EDIT*: The below discussion has been deferred out of this PR. Now this only
> deals with fixin
On Fri, 11 Nov 2022 14:26:20 GMT, Stefan Karlsson wrote:
> The sorted blocks of includes have deteriorated to the point that I felt
> compelled to clean up some of the issues.
>
> *EDIT*: The below discussion has been deferred out of this PR. Now this only
> deals with fixin
On Wed, 16 Nov 2022 16:17:48 GMT, Stefan Karlsson wrote:
>> The sorted blocks of includes have deteriorated to the point that I felt
>> compelled to clean up some of the issues.
>>
>> *EDIT*: The below discussion has been deferred out of this PR. Now this on
r the include headers I've also cleaned up surrounding
> whitespaces and incorrect include guards.
Stefan Karlsson has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains four commits:
- Merge remote-tracking branch 'upstream/master' into
On Wed, 16 Nov 2022 16:17:48 GMT, Stefan Karlsson wrote:
>> The sorted blocks of includes have deteriorated to the point that I felt
>> compelled to clean up some of the issues.
>>
>> *EDIT*: The below discussion has been deferred out of this PR. Now this on
r the include headers I've also cleaned up surrounding
> whitespaces and incorrect include guards.
Stefan Karlsson has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains four commits:
- Merge remote-tracking branch 'upstream/master' into
On Fri, 11 Nov 2022 21:01:31 GMT, Kim Barrett wrote:
>> Stefan Karlsson has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Cleanups
>> - Merge remote-tr
201 - 300 of 668 matches
Mail list logo