This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
from bcadbb69be6 [SPARK-42917][SQL] Correct getUpdateColumnNullabilityQuery
for DerbyDialect
add acf3065cc9e
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new c3716c4ec68 [SPARK-42631][CONNECT][FOLLOW-UP
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch branch-3.4
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.4 by this push:
new ce36692 [SPARK-42631][CONNECT
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new c9878a21295 [MINOR][CONNECT] Adding Proto
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 10fd918754a [SPARK-42953][CONNECT] Typed
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
from afea2a91ee2 [SPARK-43044][CONNECT][BUILD] Upgrade buf to v1.17.0
add 4d726a9bbc0 [SPARK-42999][CONNECT
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 445a4f5f8ab [SPARK-42656][FOLLOWUP] Add
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new c8030d191e3 [SPARK-43019][SQL] Move Ordering
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new fa6e55bba4d [SPARK-43023][CONNECT][TESTS
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 3941369d13a [SPARK-42657][CONNECT] Support
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new db2625c70a8 [SPARK-43168][SQL] Remove get
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 0e6446ac62d [SPARK-43285] Fix ReplE2ESuite
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
from 0e6446ac62d [SPARK-43285] Fix ReplE2ESuite consistently failing with
JDK 17
add b26844ce879 [SPARK-43136
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 5e17b07b88e [SPARK-42953][CONNECT][FOLLOWUP
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 49581b35a07 [SPARK-43198][CONNECT] Fix
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 885e9c111d2 [SPARK-43265] Move Error
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 9445fd0f9cc [SPARK-43143][SS][CONNECT] Scala
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 18c578d4f7b [SPARK-43206][SS][CONNECT
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 45f25dce182 [SPARK-43331][CONNECT] Add Spark
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new e7a466ebce7 [SPARK-41532][CONNECT][CLIENT
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 14868355b86 [SPARK-43292][CORE][CONNECT
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new c17c77e8cd9 [SPARK-43418][CONNECT] Add
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new f43ecd017ee [SPARK-43428] Move some class
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
from 4def99d54fc [SPARK-40912][CORE] Overhead of Exceptions in
KryoDeserializationStream
add 38c41cce585 [SPARK
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 4c4b53c85a1 [SPARK-43430][CONNECT][PROTO
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new ba8cae2031f [SPARK-43223][CONNECT] Typed agg
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 56cfd40e74d [SPARK-42958][CONNECT] Refactor
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
from fead25ac4d6 [SPARK-43775][SQL] DataSource V2: Allow representing
updates as deletes and inserts
add
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch branch-3.4
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.4 by this push:
new 0e1401dc71b [SPARK-43894][PYTHON
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 62338ed6cd9 [SPARK-42626][CONNECT] Add
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
from ae8aaec9cde [SPARK-43977][CONNECT] Fix unexpected check result of
`dev/connect-jvm-client-mima-check`
add
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 15202e53195 [SPARK-43920][SQL][CONNECT
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 2d250085f0a [SPARK-43888][CONNECT][FOLLOW-UP
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
from a02275ac16c [SPARK-43380][SQL] Fix conversion of Avro logical
timestamp type to Long
add dfd40a40946 [SPARK
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
from fb1ee25a89e [SPARK-43290][SQL] Adds support for aes_encrypt IVs and AAD
add 01d068b06d5 [SPARK-43474][SS
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19181#discussion_r143770192
--- Diff:
core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorterSuite.java
---
@@ -503,6 +504,41 @@ public void
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19181#discussion_r143770712
--- Diff:
core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorterSuite.java
---
@@ -503,6 +504,41 @@ public void
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19181#discussion_r143771458
--- Diff:
core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorterSuite.java
---
@@ -139,4 +139,49 @@ public int compare
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19181#discussion_r143771647
--- Diff:
core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorterSuite.java
---
@@ -139,4 +139,49 @@ public int compare
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19181#discussion_r143773051
--- Diff:
core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorterSuite.java
---
@@ -503,6 +504,41 @@ public void
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19181
I will merge this when it passes tests.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19181
Merging to master. Thanks!
Can you create a backport for Spark-2.2?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19473
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19473
Could you add [SQL] to the title? That makes it easier for others to scan
PRs.
---
-
To unsubscribe, e-mail: reviews
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19478#discussion_r144230724
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -79,7 +79,9 @@ abstract class Expression
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19478
@gengliangwang do you have any benchmark that shows that this is a
performance bottleneck?
---
-
To unsubscribe, e-mail
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19481
add to whitelist
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19481
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19481
LGTM pending jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19481
Merged to 2.2. Thanks!
Can you close the PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19473
Merging to master. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18805
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19481
@eyalfa can you close the PR? The github infra does not this automatically
for backports.
---
-
To unsubscribe, e-mail
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18805
This seems to be caused by a issue in the `zstd-jni` library. It probably
uses the wrong `ClassLoader` to load the native library, and as a result it
cannot find the library & loa
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19559#discussion_r146309332
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -585,6 +584,7 @@ primaryExpression
| identifier
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19559
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19426
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19578
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19559#discussion_r147067888
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -783,6 +783,25 @@ class Analyzer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19559#discussion_r147068227
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -844,7 +863,12 @@ class Analyzer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19578#discussion_r147380192
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParserUtils.scala
---
@@ -32,7 +32,7 @@ object ParserUtils {
/** Get
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19578#discussion_r147381885
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParseDriver.scala
---
@@ -151,9 +152,30 @@ object CatalystSqlParser extends
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18805
Merging to master. Thanks for seeing this through!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19635
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19635
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19635
@mgaido91 Can you update the PR and describe there what you exactly changed?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19649#discussion_r148781384
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/events.scala
---
@@ -110,7 +122,27 @@ case class RenameTableEvent
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19649
Looks good, one small question.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19653
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20023
In am generally in favor of following the SQL standard. How about we do
this. Let's make the standard behavior the default, and add a flag to revert to
the old behavior. This allows us to
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20023
I don't fully agree :)...
1. You can use `SQLConf.get` for this. Or you can wire up the rules using
the `SessionStateBuilder`.
2. I am reluctant to change this for a minor versi
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20133#discussion_r159164626
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -408,9 +417,17 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19764
@caneGuy adding the second ordering makes the sort much more fine grained,
this means that the range partitioner is probably going to use different range
boundaries using all the ordering
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20200#discussion_r160390893
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -985,7 +985,7 @@ abstract class RDD[T: ClassTag](
def subtract
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20200#discussion_r160391487
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1345,13 +1346,12 @@ abstract class RDD[T: ClassTag](
if (buf.isEmpty
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20277
@cloud-fan did you do some benchmarks? I'd like to make sure that the
abstract class to interface change does not negatively impact perfor
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20302
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20350#discussion_r162957968
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -237,14 +238,26 @@ final class Decimal extends Ordered[Decimal
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20350#discussion_r163007885
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -237,14 +238,26 @@ final class Decimal extends Ordered[Decimal
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20350#discussion_r163013386
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -237,14 +238,26 @@ final class Decimal extends Ordered[Decimal
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20391
cc @cloud-fan @kiszk @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/20391
[SPARK-23208][SQL] Fix code generation for complex create array (related)
expressions
## What changes were proposed in this pull request?
The `GenArrayData.genCodeToCreateArrayData
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11209#discussion_r72902008
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/HashBenchmark.scala ---
@@ -119,11 +146,12 @@ object HashBenchmark {
.add(&quo
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14411
Ok, this looks pretty good. One overall comment: We are basically
blacklisting operators here (which is fine IMO), should we check if there any
other operators we should about? If there are we
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14397
@dongjoon-hyun I think this has merit. I do have one question, what do
other databases do? Like postgresql, mysql, sqlserver and others?
---
If your project is set up for it, you can reply to
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14397#discussion_r72912387
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -131,17 +131,17 @@ class Analyzer(
def
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14355#discussion_r72912491
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -280,6 +267,32 @@ trait CheckAnalysis extends
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14355
LGTM - merging to master. Thanks for working on this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14397
@dongjoon-hyun
New behavior versus existing systems
I was not talking about recursive CTE's (which can be very useful in some
cases). We are changing the behavior of the Ana
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14411
@nsyca We do not rewrite the subquery into a join during analysis. We
rewrite subqueries into joins during optimization. We do two things during
analysis:
1. We check if the subquery
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14434
LGTM - why did we have these?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/14442
[SPARK-16836][SQL] Add support for CURRENT_DATE/CURRENT_TIMESTAMP literals
## What changes were proposed in this pull request?
In Spark 1.6 (with Hive support) we could use `CURRENT_DATE
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14411
@nsyca No problem. We actually support `NOT IN` queries. We set the the
`PredicateSubquery.nullAware` flag to true if we encounter an `IN` subquery
expression. `NOT IN` is planned using a `NULL
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14241
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73387263
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -349,6 +384,27 @@ trait CheckAnalysis extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73387447
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -349,6 +384,27 @@ trait CheckAnalysis extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73387761
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -112,6 +111,8 @@ case class BucketSpec(
* Note
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73388435
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -367,15 +368,16 @@ final class DataFrameWriter[T] private[sql](ds
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73389058
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -420,45 +420,40 @@ private[sql] abstract class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73390262
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -420,45 +420,40 @@ private[sql] abstract class
901 - 1000 of 1088 matches
Mail list logo
