[PATCH v3 2/3] target/hexagon: fix some occurrences of -Wshadow=local

ino Signed-off-by: Brian Cain --- target/hexagon/imported/alu.idef | 6 +++--- target/hexagon/mmvec/macros.h| 2 +- target/hexagon/op_helper.c | 9 +++-- target/hexagon/translate.c | 10 +- 4 files changed, 12 insertions(+), 15 deletions(-) diff --git a/target/hexa

[PATCH v3 0/3] hexagon: GETPC() fixes, shadowing fixes

Changes since v2: - rebased, suggested by Markus - s/cpu_env/tcg_env/ - For local shadows: s/tcg_env/tcg_env_/ Brian Cain (2): target/hexagon: fix some occurrences of -Wshadow=local target/hexagon: avoid shadowing globals Matheus Tavares Bernardino (1): target/hexagon

[PATCH v3 1/3] target/hexagon: move GETPC() calls to top level helpers

: <2c74c3696946edba7cc5b2942cf296a5af532052.1689070412.git.quic_mathb...@quicinc.com>-ne Reviewed-by: Brian Cain Signed-off-by: Brian Cain --- target/hexagon/macros.h| 19 +- target/hexagon/op_helper.c | 75 +++--- target/hexagon/op_helper.h | 9 - 3

RE: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

> -Original Message- > From: ltaylorsimp...@gmail.com > Sent: Friday, October 6, 2023 11:01 AM > To: Brian Cain ; qemu-devel@nongnu.org > Cc: arm...@redhat.com; richard.hender...@linaro.org; phi...@linaro.org; > peter.mayd...@linaro.org; Matheus Bernardino (QUIC) >

[PATCH v2 2/3] target/hexagon: fix some occurrences of -Wshadow=local

ino Signed-off-by: Brian Cain --- target/hexagon/imported/alu.idef | 6 +++--- target/hexagon/mmvec/macros.h| 6 +++--- target/hexagon/op_helper.c | 9 +++-- target/hexagon/translate.c | 9 - 4 files changed, 13 insertions(+), 17 deletions(-) diff --git a/target/hexa

[PATCH v2 1/3] target/hexagon: move GETPC() calls to top level helpers

: <2c74c3696946edba7cc5b2942cf296a5af532052.1689070412.git.quic_mathb...@quicinc.com>-ne Reviewed-by: Brian Cain Signed-off-by: Brian Cain --- target/hexagon/macros.h| 19 +- target/hexagon/op_helper.c | 75 +++--- target/hexagon/op_helper.h | 9 - 3

[PATCH v2 3/3] target/hexagon: avoid shadowing globals

The typedef `vaddr` is shadowed by `vaddr` identifiers, so we rename the identifiers to avoid shadowing the type name. The global `cpu_env` is shadowed by local `cpu_env` arguments, so we rename the function arguments to avoid shadowing the global. Signed-off-by: Brian Cain --- target/hexagon

[PATCH v2 0/3] hexagon: GETPC() and shadowing fixes

In v2: reworked with suggestions from Philippe and added a new patch to cover -Wshadow=global. Brian Cain (2): target/hexagon: fix some occurrences of -Wshadow=local target/hexagon: avoid shadowing globals Matheus Tavares Bernardino (1): target/hexagon: move GETPC() calls to top level

RE: [PULL 0/2] hex queue

> -Original Message- > From: Markus Armbruster > Sent: Wednesday, October 4, 2023 2:38 AM > To: Brian Cain > Cc: qemu-devel@nongnu.org; richard.hender...@linaro.org; > phi...@linaro.org; peter.mayd...@linaro.org; Matheus Bernardino (QUIC) > ; stefa...@re

[PATCH 2/2] target/hexagon: fix some occurrences of -Wshadow=local

ino Signed-off-by: Brian Cain --- target/hexagon/imported/alu.idef | 6 +++--- target/hexagon/mmvec/macros.h| 2 +- target/hexagon/op_helper.c | 9 +++-- target/hexagon/translate.c | 10 +- 4 files changed, 12 insertions(+), 15 deletions(-) diff --git a/target/hexa

[PATCH 0/2] Fix usage of GETPC(), variable shadowing

Matheus' patch has previously been reviewed, but I based my -Wshadow patch on his. So I'm submitting the series for review. Brian Cain (1): target/hexagon: fix some occurrences of -Wshadow=local Matheus Tavares Bernardino (1): target/hexagon: move GETPC() calls to top level helpers target

[PATCH 1/2] target/hexagon: move GETPC() calls to top level helpers

: <2c74c3696946edba7cc5b2942cf296a5af532052.1689070412.git.quic_mathb...@quicinc.com>-ne Reviewed-by: Brian Cain --- target/hexagon/macros.h| 19 +- target/hexagon/op_helper.c | 75 +++--- target/hexagon/op_helper.h | 9 - 3 files changed, 38 insertions(

[PULL 1/2] target/hexagon: move GETPC() calls to top level helpers

: <2c74c3696946edba7cc5b2942cf296a5af532052.1689070412.git.quic_mathb...@quicinc.com>-ne Reviewed-by: Brian Cain Signed-off-by: Brian Cain --- target/hexagon/macros.h| 19 +- target/hexagon/op_helper.c | 75 +++--- target/hexagon/op_helper.h | 9 - 3

[PULL 2/2] target/hexagon: fix some occurrences of -Wshadow=local

ino Signed-off-by: Brian Cain --- target/hexagon/imported/alu.idef | 6 +++--- target/hexagon/mmvec/macros.h| 2 +- target/hexagon/op_helper.c | 9 +++-- target/hexagon/translate.c | 10 +- 4 files changed, 12 insertions(+), 15 deletions(-) diff --git a/target/hexa

[PULL 0/2] hex queue

Brian Cain (1): target/hexagon: fix some occurrences of -Wshadow=local Matheus Tavares Bernardino (1): target/hexagon: move GETPC() calls to top level helpers target/hexagon/imported/alu.idef | 6 +-- target/hexagon/macros.h | 19 + target/hexagon/mmvec/macros.h| 2

RE: [PATCH 11/24] hexagon: spelling fixes

quot;Replicates scalar across bytes in vector", VdV.ub[i] = RtV) > > > diff --git a/tests/tcg/hexagon/fpstuff.c b/tests/tcg/hexagon/fpstuff.c > index 344b9f7772..6aadaccabd 100644 > --- a/tests/tcg/hexagon/fpstuff.c > +++ b/tests/tcg/hexagon/fpstuff.c > @@ -53,5 +53,5 @@ static void check_compare_exception(void) > uint32_t usr; > > -/* Check that FP compares are quiet (don't raise any execptions) */ > +/* Check that FP compares are quiet (don't raise any exceptions) */ > asm (CLEAR_FPSTATUS > "p0 = sfcmp.eq(%2, %3)\n\t" > diff --git a/tests/tcg/hexagon/test_clobber.S > b/tests/tcg/hexagon/test_clobber.S > index a7aeb2b60c..10046c30d2 100644 > --- a/tests/tcg/hexagon/test_clobber.S > +++ b/tests/tcg/hexagon/test_clobber.S > @@ -1,4 +1,4 @@ > /* > - * Purpose: demonstrate the succesful operation of the register save > mechanism, > + * Purpose: demonstrate the successful operation of the register save > mechanism, > * in which the caller saves the registers that will be clobbered, and > restores > * them after the call. > -- > 2.39.2 > Reviewed-by: Brian Cain

[PATCH] D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX

bcain added inline comments. Comment at: clang/CMakeLists.txt:179-183 +if(DEFAULT_SYSROOT) + message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use " +"configuration files (https://clang.llvm.org/docs/UsersManual.html#configuration-files)" +"to specify

[PATCH] D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX

bcain added inline comments. Comment at: clang/CMakeLists.txt:179-183 +if(DEFAULT_SYSROOT) + message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use " +"configuration files (https://clang.llvm.org/docs/UsersManual.html#configuration-files)" +"to specify

[PATCH] D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX

bcain added inline comments. Comment at: clang/CMakeLists.txt:179-183 +if(DEFAULT_SYSROOT) + message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use " +"configuration files (https://clang.llvm.org/docs/UsersManual.html#configuration-files)" +"to specify

[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5bc4b34a3aa9: [clang][hexagon] Handle library path arguments earlier (authored by androm3da). Repository: rG LLVM

[clang] 5bc4b34 - [clang][hexagon] Handle library path arguments earlier

Author: Brian Cain Date: 2023-08-07T18:18:59-07:00 New Revision: 5bc4b34a3aa9c6ea10663a252ac46d20862b38d5 URL: https://github.com/llvm/llvm-project/commit/5bc4b34a3aa9c6ea10663a252ac46d20862b38d5 DIFF: https://github.com/llvm/llvm-project/commit/5bc4b34a3aa9c6ea10663a252ac46d20862b38d5.diff

[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

bcain added a comment. ping? any concerns about this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156771/new/ https://reviews.llvm.org/D156771 ___ cfe-commits mailing list

[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

bcain updated this revision to Diff 546314. bcain added a comment. Changed test to use `-Werror -###` instead of `-fdriver-only -v -Werror`. Fixed indentation / `clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156771/new/

[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

bcain created this revision. bcain added reviewers: kparzysz, sidneym, MaskRay. Herald added a project: All. bcain requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The removal of the early return in 96832a6bf7e0e7f1e8d634d38c44a1b32d512923

[PATCH] D156330: [hexagon] restore library path arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96832a6bf7e0: [hexagon] restore library path arguments (authored by androm3da). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 96832a6 - [hexagon] restore library path arguments

Author: Brian Cain Date: 2023-07-27T13:26:28-07:00 New Revision: 96832a6bf7e0e7f1e8d634d38c44a1b32d512923 URL: https://github.com/llvm/llvm-project/commit/96832a6bf7e0e7f1e8d634d38c44a1b32d512923 DIFF: https://github.com/llvm/llvm-project/commit/96832a6bf7e0e7f1e8d634d38c44a1b32d512923.diff

[PATCH] D156330: [hexagon] restore library path arguments

bcain updated this revision to Diff 544533. bcain added a comment. Too hasty w/the last update - forgot to remove the `-###`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156330/new/ https://reviews.llvm.org/D156330 Files:

[PATCH] D156330: [hexagon] restore library path arguments

bcain updated this revision to Diff 544532. bcain added a comment. I misunderstood the previous suggestion about `-fdriver-only -Werror -v` and thought I needed to separate the test into two invocations. Combined these back into a single RUN now. Repository: rG LLVM Github Monorepo

[PATCH] D156330: [hexagon] restore library path arguments

bcain updated this revision to Diff 544527. bcain added a comment. Fixed target: `--target=hexagon-unknown-linux` was not correct for testing this bug, it should have been `--target=hexagon-unknown-linux-musl`. Used `-fdriver-only -Werror` as suggested but it did require separating the tests.

[PATCH] D156330: [hexagon] restore library path arguments

bcain added a comment. In D156330#4535974 , @MaskRay wrote: > Tip: use `%clang -fdriver-only -Werror -v` to test that a command produces no > warning or error and has an exit code of 0. Without it your > `Args.ClaimAllArgs(options::OPT_L);` change is

[PATCH] D156330: [hexagon] restore library path arguments

bcain created this revision. bcain added reviewers: sidneym, kparzysz, MaskRay. Herald added a project: All. bcain requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before applying this fix, clang would not include the specified library path

RE: [PATCH] target/hexagon/idef-parser: Remove self-assignment

> -Original Message- > From: Anton Johansson > Sent: Thursday, July 13, 2023 7:09 AM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; peter.mayd...@linaro.org > Subject: [PATCH] target/hexagon/idef-parser: Remove self-assignment > > WARNING: This email

RE: [PATCH] Hexagon: move GETPC() calls to top level helpers

> -Original Message- > From: Matheus Tavares Bernardino > Sent: Monday, July 3, 2023 4:50 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Marco Liebel (QUIC) > ; ltaylorsimp...@gmail.com > Subject: [PATCH] Hexagon: move GETPC() calls to top level helpers >

RE: How do you represent a host gcc and a cross gcc in lcitool?

> -Original Message- > From: Alex Bennée > Sent: Wednesday, May 31, 2023 6:24 AM > To: Daniel P.Berrangé > Cc: qemu-devel ; Michael Tokarev > ; Erik Skultety ; Brian Cain > ; Palmer Dabbelt ; Alistair Francis > ; Bin Meng > Subject: How do you represent

RE: Help finding Coverity defects for generated Hexagon code

> -Original Message- > From: qemu-devel-bounces+bcain=quicinc@nongnu.org bounces+bcain=quicinc@nongnu.org> On Behalf Of Richard Henderson > Sent: Tuesday, May 23, 2023 10:32 AM > To: a...@rev.ng; Paolo Bonzini ; Peter Maydell > > Cc: qemu-devel@nongnu.org > Subject: Re: Help

RE: [PATCH v2] Hexagon (target/hexagon) Fix assignment to tmp registers

> -Original Message- > From: Marco Liebel (QUIC) > Sent: Monday, May 22, 2023 12:47 PM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson ; Brian Cain ; > Marco Liebel (QUIC) > Subject: [PATCH v2] Hexagon (target/hexagon) Fix assignment to tmp registers &g

RE: [PATCH v3 5/6] Hexagon (gdbstub): add HVX support

> -Original Message- > From: Matheus Tavares Bernardino > Sent: Thursday, May 4, 2023 10:38 AM > To: qemu-devel@nongnu.org > Cc: alex.ben...@linaro.org; Brian Cain ; > f4...@amsat.org; peter.mayd...@linaro.org; Taylor Simpson > ; phi...@linaro.org; richard.hender...@

RE: [PATCH] Remove test_vshuff from hvx_misc tests

> -Original Message- > From: Taylor Simpson > Sent: Tuesday, May 9, 2023 2:28 PM > To: Marco Liebel (QUIC) ; qemu- > de...@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > > Subject: RE: [PATCH] Remove test_vshuff from hvx_misc tests > >

RE: [PATCH] Remove test_vshuff from hvx_misc tests

> -Original Message- > From: Marco Liebel (QUIC) > Sent: Tuesday, May 9, 2023 1:43 PM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson ; Brian Cain ; > Matheus Bernardino (QUIC) ; Marco Liebel > (QUIC) > Subject: [PATCH] Remove test_vshuff from hvx_misc tests

RE: [PATCH v2 11/21] Hexagon (target/hexagon) Short-circuit packet register writes

> -Original Message- > From: Taylor Simpson > Sent: Thursday, April 27, 2023 6:00 PM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng; a...@rev.ng; Brian Cain > ; Matheus Bernardino (QUIC) > &g

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

bcain added a comment. Can you depend on `cstdio` in an LLVM toolchain test case like this? `clang` doesn't install `cstdio` -- does it? This is a c or c++ library file, so I think it should be out of scope for a clang test, right? AFAICT no other clang test uses this header file.

RE: [PATCH] Use hexagon toolchain version 16.0.0

CHAIN_RELEASE}-cross- > hexagon-unknown-linux-musl" > ENV TOOLCHAIN_URL https://codelinaro.jfrog.io/artifactory/codelinaro- > toolchain-for- > hexagon/v${TOOLCHAIN_RELEASE}/${TOOLCHAIN_BASENAME}.tar.xz > > -- > 2.25.1 > Reviewed-by: Brian Cain

[clang] cd97675 - [hexagon] add a -mcabac flag

Author: Brian Cain Date: 2023-01-31T16:30:35-08:00 New Revision: cd97675e02368f31d56bd8f143c5987649d162d8 URL: https://github.com/llvm/llvm-project/commit/cd97675e02368f31d56bd8f143c5987649d162d8 DIFF: https://github.com/llvm/llvm-project/commit/cd97675e02368f31d56bd8f143c5987649d162d8.diff

[PATCH] D142947: [hexagon] add a -mcabac flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd97675e0236: [hexagon] add a -mcabac flag (authored by androm3da). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142947: [hexagon] add a -mcabac flag

bcain added a subscriber: ldionne. bcain added a comment. It seems extremely unlikely that this change to target-dependent flags caused this libc++ test failure w/an error referring to partial specialization. @ldionne is it possible that

[PATCH] D142947: [hexagon] add a -mcabac flag

bcain created this revision. bcain added a reviewer: kparzysz. bcain added a project: clang. Herald added a project: All. bcain requested review of this revision. Herald added a subscriber: cfe-commits. For v73 and later, clang users who wish to use the cabac instructions need a way to add the

RE: [PATCH] linux-test.c: Remove unused but set variable

> -Original Message- > From: Taylor Simpson > Sent: Thursday, January 5, 2023 10:24 AM > To: qemu-devel@nongnu.org; alex.ben...@linaro.org > Cc: Taylor Simpson ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng; a...@rev.ng; Brian Cain > ; Mat

RE: [PATCH] linux-test.c: Remove unused but set variable

> -Original Message- > From: Brian Cain > Sent: Thursday, January 5, 2023 11:10 AM > To: Taylor Simpson ; qemu-devel@nongnu.org; > alex.ben...@linaro.org > Cc: Taylor Simpson ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng; a...@rev.ng; Mat

RE: [RFC PATCH v2] gdbstub: only send stop-reply packets when allowed to

> -Original Message- > From: Qemu-devel > On Behalf Of Matheus Tavares Bernardino ... > On Wed, 24 Aug 2022 at 14:51, Matheus Tavares Bernardino > wrote: > > > > Instead, let's change gdb_set_stop_cpu() to send stop messages only as a > > response to a previous GDB command, also making

RE: [PATCH] Hexagon (target/hexagon) implement mutability mask for GPRs

. > > Some registers are defined to have immutable bits, this commit > > will implement that behavior. > > > > Signed-off-by: Brian Cain > > --- > > target/hexagon/gen_masked.c | 44 > > target/hexagon/gen_masked.h

RE: [PATCH] Hexagon (target/hexagon) implement mutability mask for GPRs

> -Original Message- > From: Richard Henderson ... > It might be clearer, and easier to initialize, if you invert the sense of the > mask: Ok -- thanks for the suggestions! I'll give 'em all a try. -Brian

[PATCH] Hexagon (target/hexagon) implement mutability mask for GPRs

Some registers are defined to have immutable bits, this commit will implement that behavior. Signed-off-by: Brian Cain --- target/hexagon/gen_masked.c | 44 target/hexagon/gen_masked.h | 26 target/hexagon/genptr.c | 33 - target/hexagon

RE: [PATCH] kernel: exit: cleanup release_thread()

> -Original Message- > From: Kefeng Wang ... > Only x86 has own release_thread(), introduce a new weak > release_thread() function to clean empty definitions in > other ARCHs. > > Signed-off-by: Kefeng Wang > --- Acked-by: Brian Cain

RE: [PATCH] kernel: exit: cleanup release_thread()

> -Original Message- > From: Kefeng Wang ... > Only x86 has own release_thread(), introduce a new weak > release_thread() function to clean empty definitions in > other ARCHs. > > Signed-off-by: Kefeng Wang > -

RE: [PATCH] kernel: exit: cleanup release_thread()

> -Original Message- > From: Kefeng Wang ... > Only x86 has own release_thread(), introduce a new weak > release_thread() function to clean empty definitions in > other ARCHs. > > Signed-off-by: Kefeng Wang > -

RE: hexagon docker test failure

> -Original Message- > From: Qemu-devel > On Behalf Of Richard Henderson > Sent: Tuesday, July 26, 2022 12:42 PM > To: Taylor Simpson > Cc: qemu-devel > Subject: Re: hexagon docker test failure > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links

RE: [PATCH V5 12/26] hexagon/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT

rd > vm_get_page_prot() implementation via DECLARE_VM_GET_PAGE_PROT, > which looks > up a private and static protection_map[] array. Subsequently all __SXXX and > __PXXX macros can be dropped which are no longer needed. > > Cc: Brian Cain > Cc: linux-hexa...@vger.kernel.org >

RE: [PATCH V5 12/26] hexagon/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT

rd > vm_get_page_prot() implementation via DECLARE_VM_GET_PAGE_PROT, > which looks > up a private and static protection_map[] array. Subsequently all __SXXX and > __PXXX macros can be dropped which are no longer needed. > > Cc: Brian Cain > Cc: linux-hexa...@vger.kernel.org >

RE: [PATCH V5 12/26] hexagon/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT

rd > vm_get_page_prot() implementation via DECLARE_VM_GET_PAGE_PROT, > which looks > up a private and static protection_map[] array. Subsequently all __SXXX and > __PXXX macros can be dropped which are no longer needed. > > Cc: Brian Cain > Cc: linux-hexa...@vger.kernel.org >

RE: [PATCH] tests: Remove unused "wcount" from linux-test.c

> -Original Message- > From: Peter Maydell > Sent: Friday, May 20, 2022 8:21 AM > To: Brian Cain > Cc: Daniel P. Berrangé ; qemu-devel@nongnu.org; > Alex Bennée > Subject: Re: [PATCH] tests: Remove unused "wcount" from linux-test.c > > WARNIN

[PATCH] tests: Remove unused "wcount" from linux-test.c

clang reports this variable as 'set but not used'. Signed-off-by: Brian Cain --- tests/tcg/multiarch/linux/linux-test.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/tcg/multiarch/linux/linux-test.c b/tests/tcg/multiarch/linux/linux-test.c index 019d8175ca

[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

bcain added a comment. Herald added a project: All. In D97625#3337018 , @dmgreen wrote: > Hello. I noticed this was applied to the base /test directory in the llvm > repo: https://github.com/llvm/llvm-project/tree/main/test > Was it intended be in

[ Job Ad ] Qualcomm hiring developers to work on QEMU

/* moderators - this is a job ad, please discard if it's not permitted by the community */ Qualcomm has openings for developers to help work on QEMU for the Hexagon DSP. If you like QEMU and are interested in challenging work, please apply!

RE: hexagon container update

> -Original Message- > From: Brian Cain > Sent: Tuesday, January 18, 2022 9:25 AM > To: Alex Bennée > Cc: Richard Henderson ; qemu- > de...@nongnu.org; Taylor Simpson > Subject: RE: hexagon container update > > > -Original Message- > > Fr

RE: hexagon container update

> -Original Message- > From: Alex Bennée .. > Brian Cain writes: > ... > > We had some issues with the previous attempt to update the container. > > The linux-user "signals" test failed. Richard pointed out that the > > archive of the C library

RE: hexagon container update

> -Original Message- > From: Brian Cain > Sent: Friday, October 1, 2021 7:23 PM > To: Richard Henderson ; Alex Bennée > ; qemu-devel@nongnu.org > Cc: Taylor Simpson > Subject: RE: hexagon container update > > > -Original Message- > > From:

[clang] ab28cb1 - Revert "[xray] add support for hexagon"

Author: Brian Cain Date: 2021-12-09T07:30:40-08:00 New Revision: ab28cb1c5c4dc7181fae3d47f0601982996739db URL: https://github.com/llvm/llvm-project/commit/ab28cb1c5c4dc7181fae3d47f0601982996739db DIFF: https://github.com/llvm/llvm-project/commit/ab28cb1c5c4dc7181fae3d47f0601982996739db.diff

[PATCH] D113638: [xray] Add support for hexagon architecture

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG543a9ad7c460: [xray] add support for hexagon (authored by androm3da). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 543a9ad - [xray] add support for hexagon

Author: Brian Cain Date: 2021-12-09T05:47:53-08:00 New Revision: 543a9ad7c460bb8d641b1b7c67bbc032c9bfdb45 URL: https://github.com/llvm/llvm-project/commit/543a9ad7c460bb8d641b1b7c67bbc032c9bfdb45 DIFF: https://github.com/llvm/llvm-project/commit/543a9ad7c460bb8d641b1b7c67bbc032c9bfdb45.diff

RE: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation

> -Original Message- > From: Peter Maydell ... > On Tue, 7 Dec 2021 at 15:18, Brian Cain wrote: > > Peter Maydell wrote: > > > I won't try to put this into 6.2 unless you have a common guest > > > that runs into this bug. > > > I know th

RE: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation

> -Original Message- > From: Qemu-devel > On Behalf Of Peter Maydell ... > On Tue, 7 Dec 2021 at 09:44, Damien Hedde > wrote: > > > > According to the "Arm Generic Interrupt Controller Architecture > > Specification GIC architecture version 3 and 4" (version G: page 345 > > for aarch64

[PATCH] D113638: [xray] Add support for hexagon architecture

androm3da added a comment. Ping - any thoughts/concerns? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113638/new/ https://reviews.llvm.org/D113638 ___ cfe-commits mailing list

[PATCH] D113638: [xray] Add support for hexagon architecture

androm3da added a comment. This patch spans several areas, so I would be happy to decompose it into smaller parts if it made it easier for reviewers. Comment at: compiler-rt/lib/xray/xray_hexagon.cpp:76-84 +static void WriteInstFlushCache(void *Addr, uint32_t NewInstruction)

[PATCH] D113638: [xray] Add support for hexagon architecture

androm3da created this revision. androm3da added reviewers: dberris, kparzysz. Herald added subscribers: hiraditya, mgorny. androm3da requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Adds x-ray

RE: hexagon container update

> -Original Message- > From: Brian Cain ... > > -Original Message- > > From: Richard Henderson > ... > > On 10/1/21 12:59 PM, Brian Cain wrote: > > > Alex, > > > > > > We need to update the docker container used for hexago

RE: hexagon container update

> -Original Message- > From: Richard Henderson ... > On 10/1/21 12:59 PM, Brian Cain wrote: > > Alex, > > > > We need to update the docker container used for hexagon for new test cases > proposed in Taylor's recent patch series under review. Thankfully, Code

hexagon container update

Alex, We need to update the docker container used for hexagon for new test cases proposed in Taylor's recent patch series under review. Thankfully, CodeLinaro has provided a binary of the hexagon cross toolchain so now I think we can simplify the hexagon docker file to something like the

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Thu, Sep 30, 2021, 6:04 PM Brian Cain wrote: > Does something like Rust's "bors" bot satisfy the herald rules need? > sorry, maybe I was thinking of the high-five bot. And it looks like that's not quite a match for herald. > re: #2 I have done this on GHE and

Re: [llvm-dev] Phabricator Creator Pulling the Plug

flow. > > What remains unknown to me is the current state of GitHub management > of comments across `git commit --amend` and force push to update a > branch. > > Others may have other items to add! > > -- > Mehdi > > On Thu, Sep 30, 2021 at 3:39 PM Brian Cain

Re: [llvm-dev] Phabricator Creator Pulling the Plug

How far are we from a workflow that leverages Github's Pull Requests? Is there some consensus that it's a desired end goal, but some features are missing? Or do we prefer to use a workflow like this for the long term? On Thu, Sep 30, 2021, 4:54 PM Chris Tetreault via llvm-dev <

Re: [lldb-dev] [Openmp-dev] [Release-testers] 13.0.0-rc3 has been tagged

On Mon, Sep 20, 2021 at 1:14 PM Andrzej Warzynski wrote: > Hi Brian, > > Thank you for helping with the release! > > On 20/09/2021 18:40, Brian Cain via Openmp-dev wrote: > > I also disabled flang (-no-flang) because of > > memory exhaustion while trying to build

Re: [lldb-dev] [Release-testers] 13.0.0-rc3 has been tagged

Ubuntu 20 binary uploaded. I also disabled flang (-no-flang) because of memory exhaustion while trying to build. Is this increased memory consumption expected or could it be a bug? $ cat clang+llvm-13.0.0-rc3-x86_64-linux-gnu-ubuntu-20.04.tar.xz.sha256

RE: [qemu-hexagon] Error mapping file: Invalid argument

> -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Monday, September 13, 2021 3:19 PM > To: Waksmanski, Lukasz ; qemu- > de...@nongnu.org > Cc: Taylor Simpson ; Brian Cain > > Subject: Re: [qemu-hexagon] Error map

[clang] 59dfde7 - [clang] enable sanitizers for hexagon

Author: Brian Cain Date: 2021-08-17T19:59:24-07:00 New Revision: 59dfde7d9460242e75d4fe9b62d77ea0f1e8d7dc URL: https://github.com/llvm/llvm-project/commit/59dfde7d9460242e75d4fe9b62d77ea0f1e8d7dc DIFF: https://github.com/llvm/llvm-project/commit/59dfde7d9460242e75d4fe9b62d77ea0f1e8d7dc.diff

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_hexagon.inc:124 + +bool internal_iserror(uptr retval, int *rverrno) { + if (retval == (uptr)-1) { vitalybuka wrote: > sidneym wrote: > > bcain wrote: > > >

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain updated this revision to Diff 367027. bcain added a comment. fixed iserror() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 Files: compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain updated this revision to Diff 367020. bcain added a comment. Herald added a subscriber: krytarowski. applied `clang-format-diff`, s/long/u32/ for syscall funcs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_hexagon.inc:88 +{ + register long r6 __asm__("r6") = n; + register long r0 __asm__("r0") = a; vitalybuka wrote: > should this use u64 like other

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain updated this revision to Diff 367008. bcain added a comment. added context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 Files: compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain updated this revision to Diff 366995. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 Files: compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake

[PATCH] D108083: [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common

bcain added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.cpp:25 return pc + 8; -#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) +#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) \ + ||

[PATCH] D108083: [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common

bcain added a comment. In D108083#2949815 , @vitalybuka wrote: >> We can help create a bot for hexagon-unknown-linux-musl. What's the process? > > Thank you. https://llvm.org/docs/HowToAddABuilder.html Oh I think I misunderstood: > Volunteers can

[PATCH] D108178: [PATCH 8/8] [clang] enable sanitizers for hexagon

bcain created this revision. bcain added reviewers: sidneym, kparzysz. bcain added a project: clang. Herald added subscribers: s.egerton, simoncook. bcain requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108178 Files:

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common (1/8)

bcain updated this revision to Diff 366766. bcain retitled this revision from "add sanitizer support to hexagon" to "[sanitizer] Add hexagon support to sanitizer-common (1/8)". bcain edited the summary of this revision. bcain added a comment. Decomposed to just the sanitizer-common portion. Now

[PATCH] D108083: add sanitizer support to hexagon

bcain added a comment. In D108083#2947914 , @vitalybuka wrote: > Do we have public bot for hexagon? I think we have one intended to for checking hexagon-unknown-elf and perhaps not one for hexagon-unknown-linux-musl. I believe that only the Linux

[PATCH] D108083: add sanitizer support to hexagon

bcain added a comment. In D108083#2947907 , @vitalybuka wrote: > Can you cut this into separate peaces, at least patch per sanitizer for "asan > lsan ubsan scudo scudo_standalone cfi safestack"? Sure, that's no problem. While I'm breaking it up, us

[PATCH] D108083: add sanitizer support to hexagon

bcain added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:297-298 +linkSanitizerRuntimeDeps(HTC, CmdArgs); +// FIXME: sanitizer_common or only some require unwind? +CmdArgs.push_back("-lunwind"); + } I will try

[PATCH] D108083: [DRAFT] add sanitizer support to hexagon

bcain created this revision. bcain added a reviewer: sidneym. Herald added subscribers: s.egerton, cryptoad, simoncook, fedor.sergeev, mgorny. bcain requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This patch will need

RE: [PATCH 7/7] hexagon: use the generic global coherent pool

> -Original Message- > From: Christoph Hellwig ... > Switch hexagon to use the generic code for dma_alloc_coherent from > a global pre-filled pool. > > Signed-off-by: Christoph Hellwig Reviewed-by: Brian Cain ___ iommu

[clang] 888876b - [clang] [hexagon] Add resource include dir

Author: Brian Cain Date: 2021-08-10T08:37:58-05:00 New Revision: 76ba272baf68ff38fcfc36c15ac2510bdea7 URL: https://github.com/llvm/llvm-project/commit/76ba272baf68ff38fcfc36c15ac2510bdea7 DIFF: https://github.com/llvm/llvm-project/commit/76ba272baf68ff38fcfc36c15ac2510bdea7.diff

<    1   2   3   4   5   6   >