Re: [VOTE] Release Apache Sling JCR Resource 3.3.0
On Mon, 2024-05-06 at 16:19 +, Radu Cotescu wrote: > Please vote to approve this release: +1 FWIW, you probably did not want to tag https://issues.apache.org/jira/browse/SLING-12094 as being fixed for this release. Thanks, Robert signature.asc Description: This is a digitally signed message part
Re: [VOTE] Release Content Distribution Journal Core 0.3.0 , Content Distribution API 0.7.2, Content Distribution Journal Messages 0.5.10
On Fri, 2024-05-03 at 09:51 +0200, Christian Schneider wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
Raspberry Pi 3B no longer starts after reboot
Hi, I have a RPi 3B running Leap 15.5. I have recently replaced the failing SD card about three weeks ago and all was well. After a zypper patch + reboot cycle it failed to connect to the network. Connecting via a serial cable shows that it hangs at 'Reached basic system'. The early boot messages don't tell me that much, there seem to be some errors, pasted at the end of the message. I mounted the SD card in another machine, looks to mount just fine NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINTS sda 8:01 59.4G 0 disk ├─sda1 8:1164M 0 part /run/media/robert/EFI ├─sda2 8:21 500M 0 part └─sda3 8:31 6.8G 0 part /run/media/robert/ROOT dmesg complains about 'not properly unmounted', but that should not be a big issue [229713.544212] scsi 0:0:0:0: Direct-Access Generic STORAGE DEVICE 1402 PQ: 0 ANSI: 6 [229713.544584] sd 0:0:0:0: Attached scsi generic sg0 type 0 [229713.788123] sd 0:0:0:0: [sda] 124669952 512-byte logical blocks: (63.8 GB/59.4 GiB) [229713.789352] sd 0:0:0:0: [sda] Write Protect is off [229713.789357] sd 0:0:0:0: [sda] Mode Sense: 21 00 00 00 [229713.790605] sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA [229713.800319] sda: sda1 sda2 sda3 [229713.800711] sd 0:0:0:0: [sda] Attached SCSI removable disk [229714.844629] FAT-fs (sda1): Volume was not properly unmounted. Some data may be corrupt. Please run fsck. [229715.016300] EXT4-fs (sda3): mounted filesystem f9dbd32e-e10c-4b7c- b75e-1e0dfabdca45 r/w with ordered data mode. Quota mode: none. I ran fsck, the only thing that it did was clear the dirty bit $ sudo fsck /dev/sda1 fsck from util-linux 2.39.3 fsck.fat 4.2 (2021-01-31) Dirty bit is set. Fs was not properly unmounted and some data may be corrupt. 1) Remove dirty bit 2) No action [12?q]? 1 *** Filesystem was changed *** The changes have not yet been written, you can still choose to leave the filesystem unmodified: 1) Write changes 2) Leave filesystem unchanged [12?q]? 1 /dev/sda1: 292 files, 4395/32695 clusters How can I further check for problems? Thanks, Robert Full early boot message below: U-Boot 2021.10 (Aug 04 2022 - 12:00:00 +) DRAM: 992 MiB RPI 3 Model B (0xa02082) MMC: mmc@7e202000: 0, mmcnr@7e30: 1 Loading Environment from FAT... Unable to read "uboot.env" from mmc0:1... In:serial Out: vidconsole Err: vidconsole Net: No ethernet found. starting USB... Bus usb@7e98: USB DWC2 scanning bus usb@7e98 for devices... 3 USB Device(s) found scanning usb for storage devices... 0 Storage Device(s) found Hit any key to stop autoboot: 0 switch to partitions #0, OK mmc0 is current device Scanning mmc 0:3... libfdt fdt_check_header(): FDT_ERR_BADMAGIC Scanning disk m...@7e202000.blk... No valid Btrfs found Card did not respond to voltage select! : -110 Scanning disk mm...@7e30.blk... Disk mm...@7e30.blk not ready Found 4 disks Missing RNG device for EFI_RNG_PROTOCOL No EFI system partition BootOrder not defined EFI boot manager: Cannot load any image ** Invalid partition 4 ** Couldn't find partition mmc 0:4 No valid Btrfs found Scanning mmc 0:1... libfdt fdt_check_header(): FDT_ERR_BADMAGIC BootOrder not defined EFI boot manager: Cannot load any image Found EFI removable media binary efi/boot/bootaa64.efi 1509376 bytes read in 67 ms (21.5 MiB/s) libfdt fdt_check_header(): FDT_ERR_BADMAGIC Booting /efi\boot\bootaa64.ef
Re: [VOTE] Release Apache Sling Rewriter 1.4.4
On Tue, 2024-04-30 at 11:27 +0200, Carsten Ziegeler wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[jira] [Closed] (SLING-12304) Broken backwards compatibility: out of order json object
[ https://issues.apache.org/jira/browse/SLING-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-12304. --- > Broken backwards compatibility: out of order json object > > > Key: SLING-12304 > URL: https://issues.apache.org/jira/browse/SLING-12304 > Project: Sling > Issue Type: Bug >Affects Versions: Commons JSON 2.0.26 >Reporter: Remo Liechti >Assignee: Remo Liechti >Priority: Critical > Fix For: Commons JSON 2.0.28 > > > The fix of CVE-2022-47937 introduced an invalid backwards compatibility for > the order in jsonobject. > New behaviour: has the keys unordered, as JsonObject uses a HashMap. > Old behaviour: Kept insertion order of keys as JsonObject used LinkedHashMap. > To no break existing users of the library, reestablish the old behaviour. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling Commons JSON 2.0.28
Hi, The vote has passed with the following result: +1 (binding): Stefan Seifert, Carsten Ziegeler, Joerg Hoh +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu
[jira] [Commented] (SLING-12197) cpconverter: Sling-Initial-Content directories created as nt:folder instead of sling:Folder
[
https://issues.apache.org/jira/browse/SLING-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841882#comment-17841882
]
Robert Munteanu commented on SLING-12197:
-
[~Sc0rpic0m] [~sseifert] - any concerns with closing this and tracking the fix
on the AEM Analyser side?
> cpconverter: Sling-Initial-Content directories created as nt:folder instead
> of sling:Folder
> ---
>
> Key: SLING-12197
> URL: https://issues.apache.org/jira/browse/SLING-12197
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.4
>Reporter: Stefan Seifert
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.8
>
> Attachments: io.wcm.handler.link-apps-1.10.2-cp2fm-converted.zip
>
>
> the cpconverter extracts Sling-Initial-Content from OSGi bundles and creates
> FileVault packages with the transformed content.
> this works well, but there is one difference when the resulting content
> package is installed compared when uploading the OSGi bundle with the
> Sling-Initial-Content directly:
> * the JCR Content Loader by defaults creates a {{sling:Folder}} node type for
> each directory found in the Sling-Initial-Content (see also
> [docs|https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#initial-content-loading-1])
> * the cpconverter process creates no {{.content.xml}} file for the folders,
> but only for the actual JSON files found in the process. as a result, the
> folders are created as {{nt:folder}} when uploading the transformed package
> * this difference becomes relevant, when a JSON file in Sling-Initial-Content
> defines a primary type of {{nt:unstructured}} - it is not allowed to created
> such a node directly below a {{nt:folder}} node - but it is allowed to do so
> below a {{sling:Folder}} node
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-12173) Configuration errors in Eclipse for projects using the slingfeature-maven-plugin
[
https://issues.apache.org/jira/browse/SLING-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-12173.
---
> Configuration errors in Eclipse for projects using the
> slingfeature-maven-plugin
>
>
> Key: SLING-12173
> URL: https://issues.apache.org/jira/browse/SLING-12173
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
> Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.2
>
>
> The slingfeature-maven-plugin currently uses the Jakarta JSON implementation
> of the Apache Johnzon parser.
> I have noticed problems in the Eclipse IDE, where projects fail to update
> with hard to isolate errors (see below).
> {noformat}java.util.ServiceConfigurationError: jakarta.json.spi.JsonProvider:
> org.apache.johnzon.core.JsonProviderImpl not a subtype
> at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:593)
> at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1244)
> at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273)
> at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309)
> at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393)
> at jakarta.json.spi.JsonProvider.provider(JsonProvider.java:69)
> at jakarta.json.Json.createReader(Json.java:189)
> at
> org.apache.sling.feature.maven.JSONFeatures.read(JSONFeatures.java:64)
> at
> org.apache.sling.feature.maven.ProjectHelper.readFeatureFile(ProjectHelper.java:622)
> at
> org.apache.sling.feature.maven.Preprocessor.readProjectFeatures(Preprocessor.java:304)
> at
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:145)
> at
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:110)
> at
> org.apache.sling.feature.maven.extensions.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:87)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.executeParticipants(ProjectRegistryManager.java:824)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$15(ProjectRegistryManager.java:791)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$14(ProjectRegistryManager.java:790)
> at java.base/java.util.HashMap$Values.forEach(HashMap.java:1065)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$11(ProjectRegistryManager.java:788)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.readMavenProjectFacades(ProjectRegistryManager.java:760)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:392)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:366)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:318)
> at
> org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.getProjectFacade(MavenBuilder.java:146)
> at
> org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.lambda$0(MavenBuilder.java:84)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
> at
> org.eclipse.m2e.core.inter
[jira] [Closed] (SLING-12153) Update maven-archiver and maven-filtering
[
https://issues.apache.org/jira/browse/SLING-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-12153.
---
> Update maven-archiver and maven-filtering
> -
>
> Key: SLING-12153
> URL: https://issues.apache.org/jira/browse/SLING-12153
> Project: Sling
> Issue Type: Improvement
> Components: Maven Plugins and Archetypes
> Reporter: Robert Munteanu
> Assignee: Robert Munteanu
>Priority: Minor
> Fix For: OSGi Feature Maven Plugin 1.8.2
>
>
> [~jsedding] noticed that the plug-in brings in older versions of the
> maven-archiver and maven-filtering. Those dependencies
> {quote}drag an ancient guava version into the classpath via a transitive
> dependency that was moved into "test" scope in newer versions of these two
> libraries{quote}
> This causes various problems with IntelliJ and Eclipse integration. And
> upgrading dependencies is always a good idea :-)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-12159) Add report to list package imports of jsp scripts
[ https://issues.apache.org/jira/browse/SLING-12159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-12159. --- > Add report to list package imports of jsp scripts > - > > Key: SLING-12159 > URL: https://issues.apache.org/jira/browse/SLING-12159 > Project: Sling > Issue Type: New Feature > Components: Maven Plugins and Archetypes >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: OSGi Feature Maven Plugin 1.8.2 > > > In addition to the reports about bundle package imports, we should generate > info about package imports from scripts (jsps) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12174) Parameter 'defaultMetadata' is unknown for plugin
[ https://issues.apache.org/jira/browse/SLING-12174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-12174. --- > Parameter 'defaultMetadata' is unknown for plugin > - > > Key: SLING-12174 > URL: https://issues.apache.org/jira/browse/SLING-12174 > Project: Sling > Issue Type: Bug > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: OSGi Feature Maven Plugin 1.8.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: OSGi Feature Maven Plugin 1.8.2 > > > When running the slingfeature maven plugin with latest Apache Maven, the > warning "Parameter 'defaultMetadata' is unknown for plugin" appears for all > goals. > This is due to the fact that this parameter is evaluated in the preprocessor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling OSGi Feature Maven Plugin 1.8.2
Hi, The vote has passed with the following result: +1 (binding): Stefan Seifert, Carsten Ziegeler, Robert Munteanu +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu
Re: [VOTE] Release Apache Sling OSGi Feature Maven Plugin 1.8.2
On Thu, 2024-04-25 at 08:42 +, Robert Munteanu wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[jira] [Commented] (SLING-12197) cpconverter: Sling-Initial-Content directories created as nt:folder instead of sling:Folder
[
https://issues.apache.org/jira/browse/SLING-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840821#comment-17840821
]
Robert Munteanu commented on SLING-12197:
-
Sure, if Niek has the time to look at it I'm all for it :-) I looked the
initial PR from SLING-10931 and it's a lot of code, not easy to figure out
where to insert what.
As for the test case, it would be very helpful if you could create a simple
package with Sling initial content that install on the latest Sling Starter but
fails when passed through the CP Converter. The bundle you linked above
requires AEM-specific APIs and I can't use it for testing.
> cpconverter: Sling-Initial-Content directories created as nt:folder instead
> of sling:Folder
> ---
>
> Key: SLING-12197
> URL: https://issues.apache.org/jira/browse/SLING-12197
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.4
>Reporter: Stefan Seifert
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.8
>
> Attachments: io.wcm.handler.link-apps-1.10.2-cp2fm-converted.zip
>
>
> the cpconverter extracts Sling-Initial-Content from OSGi bundles and creates
> FileVault packages with the transformed content.
> this works well, but there is one difference when the resulting content
> package is installed compared when uploading the OSGi bundle with the
> Sling-Initial-Content directly:
> * the JCR Content Loader by defaults creates a {{sling:Folder}} node type for
> each directory found in the Sling-Initial-Content (see also
> [docs|https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#initial-content-loading-1])
> * the cpconverter process creates no {{.content.xml}} file for the folders,
> but only for the actual JSON files found in the process. as a result, the
> folders are created as {{nt:folder}} when uploading the transformed package
> * this difference becomes relevant, when a JSON file in Sling-Initial-Content
> defines a primary type of {{nt:unstructured}} - it is not allowed to created
> such a node directly below a {{nt:folder}} node - but it is allowed to do so
> below a {{sling:Folder}} node
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[VOTE] Release Apache Sling Commons JSON 2.0.28
Hi, We solved 1 issue in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354549=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2856/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2856 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
[jira] [Assigned] (SLING-12304) Broken backwards compatibility: out of order json object
[ https://issues.apache.org/jira/browse/SLING-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-12304: --- Assignee: Remo Liechti > Broken backwards compatibility: out of order json object > > > Key: SLING-12304 > URL: https://issues.apache.org/jira/browse/SLING-12304 > Project: Sling > Issue Type: Bug >Affects Versions: Commons JSON 2.0.26 >Reporter: Remo Liechti >Assignee: Remo Liechti >Priority: Critical > Fix For: Commons JSON 2.0.28 > > > The fix of CVE-2022-47937 introduced an invalid backwards compatibility for > the order in jsonobject. > New behaviour: has the keys unordered, as JsonObject uses a HashMap. > Old behaviour: Kept insertion order of keys as JsonObject used LinkedHashMap. > To no break existing users of the library, reestablish the old behaviour. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12304) Broken backwards compatibility: out of order json object
[ https://issues.apache.org/jira/browse/SLING-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12304. - Resolution: Fixed PR applied, thanks [~rliechti]! > Broken backwards compatibility: out of order json object > > > Key: SLING-12304 > URL: https://issues.apache.org/jira/browse/SLING-12304 > Project: Sling > Issue Type: Bug >Affects Versions: Commons JSON 2.0.26 >Reporter: Remo Liechti >Assignee: Remo Liechti >Priority: Critical > Fix For: Commons JSON 2.0.28 > > > The fix of CVE-2022-47937 introduced an invalid backwards compatibility for > the order in jsonobject. > New behaviour: has the keys unordered, as JsonObject uses a HashMap. > Old behaviour: Kept insertion order of keys as JsonObject used LinkedHashMap. > To no break existing users of the library, reestablish the old behaviour. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11633) ClientSideTeleporter throwing illegal argument when target byte code is > 1.8
[ https://issues.apache.org/jira/browse/SLING-11633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-11633. --- > ClientSideTeleporter throwing illegal argument when target byte code is > 1.8 > - > > Key: SLING-11633 > URL: https://issues.apache.org/jira/browse/SLING-11633 > Project: Sling > Issue Type: Improvement > Components: Testing > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Maven home: C:\aem-tools\utils\apache-maven-3.8.5 > Java version: 11.0.15.1, vendor: Oracle Corporation, runtime: > C:\aem-tools\utils\jdk-11.0.15.1 > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" >Reporter: Scott Yuan >Assignee: Scott Yuan >Priority: Trivial > Fix For: JUnit Tests Teleporter 1.0.26 > > Attachments: mylab.zip > > Original Estimate: 2h > Time Spent: 0.5h > Remaining Estimate: 1.5h > > When attempted to use the latest 1.0.22 to build test cases using > TeleporterRule with Java 11+ code, illegal arguments error occurred. > It can be reproduce with the attached Maven project by change following > properites to 11. > * maven.compiler.source > * maven.compiler.target -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-9327) Teleporter not working with jdk11 due to missing xml bind classes
[
https://issues.apache.org/jira/browse/SLING-9327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-9327.
--
> Teleporter not working with jdk11 due to missing xml bind classes
> -
>
> Key: SLING-9327
> URL: https://issues.apache.org/jira/browse/SLING-9327
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Affects Versions: JUnit Tests Teleporter 1.0.10
>Reporter: Thierry Ygé
>Assignee: Robert Munteanu
>Priority: Blocker
> Fix For: JUnit Tests Teleporter 1.0.26
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently when using teleporter on jdk11 based environment, the teleporter is
> failing due to missing class.
> {quote}java.lang.NoClassDefFoundError: javax/xml/bind/DatatypeConverter at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.setConnectionCredentials(TeleporterHttpClient.java:63)
> at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.getHttpGetStatus(TeleporterHttpClient.java:136)
> at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.waitForStatus(TeleporterHttpClient.java:75)
> at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.installBundle(TeleporterHttpClient.java:94)
> at
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.installTestBundle(ClientSideTeleporter.java:173)
> at
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.access$000(ClientSideTeleporter.java:45)
> at
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter$2.evaluate(ClientSideTeleporter.java:207)
> at
> com.adobe.granite.testing.serverside.rules.GraniteSSTRule$1.evaluate(GraniteSSTRule.java:104)
> {quote}
> This is due to jdk not containing this package anymore since jdk 9.
> Teleporter used is 1.0.10 and with 1.0.20 I couldn't use it as it fails with
> missing osgi core dependency, unless I would then add it manually in the test
> module pom.
> Note from [~bdelacretaz]
> As per
> [https://stackoverflow.com/questions/52502189/java-11-package-javax-xml-bind-does-not-exist]
> it looks like using {{jakarta.xml.bind}} as an additional dependency might
> fix this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling JUnit Tests Teleporter 1.0.26
Hi, The vote has passed with the following result: +1 (binding): Robert Munteanu, Stefan Seifert, Joerg Hoh, Radu Cotescu +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu
Re: [VOTE] Release Apache Sling Rewriter 1.4.2
On Wed, 2024-04-24 at 14:35 +0200, Carsten Ziegeler wrote: > Please vote to approve this release: +1 Note: the build fails for me in various forms on anything but Java 8, it would be good to clean this up. Robert signature.asc Description: This is a digitally signed message part
[VOTE] Release Apache Sling OSGi Feature Maven Plugin 1.8.2
Hi, We solved 4 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353863=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2855/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2855 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
[jira] [Resolved] (SLING-12173) Configuration errors in Eclipse for projects using the slingfeature-maven-plugin
[
https://issues.apache.org/jira/browse/SLING-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-12173.
-
Fix Version/s: OSGi Feature Maven Plugin 1.8.2
(was: OSGi Feature Maven Plugin 1.8.4)
Resolution: Fixed
> Configuration errors in Eclipse for projects using the
> slingfeature-maven-plugin
>
>
> Key: SLING-12173
> URL: https://issues.apache.org/jira/browse/SLING-12173
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
> Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.2
>
>
> The slingfeature-maven-plugin currently uses the Jakarta JSON implementation
> of the Apache Johnzon parser.
> I have noticed problems in the Eclipse IDE, where projects fail to update
> with hard to isolate errors (see below).
> {noformat}java.util.ServiceConfigurationError: jakarta.json.spi.JsonProvider:
> org.apache.johnzon.core.JsonProviderImpl not a subtype
> at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:593)
> at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1244)
> at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273)
> at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309)
> at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393)
> at jakarta.json.spi.JsonProvider.provider(JsonProvider.java:69)
> at jakarta.json.Json.createReader(Json.java:189)
> at
> org.apache.sling.feature.maven.JSONFeatures.read(JSONFeatures.java:64)
> at
> org.apache.sling.feature.maven.ProjectHelper.readFeatureFile(ProjectHelper.java:622)
> at
> org.apache.sling.feature.maven.Preprocessor.readProjectFeatures(Preprocessor.java:304)
> at
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:145)
> at
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:110)
> at
> org.apache.sling.feature.maven.extensions.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:87)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.executeParticipants(ProjectRegistryManager.java:824)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$15(ProjectRegistryManager.java:791)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$14(ProjectRegistryManager.java:790)
> at java.base/java.util.HashMap$Values.forEach(HashMap.java:1065)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$11(ProjectRegistryManager.java:788)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.readMavenProjectFacades(ProjectRegistryManager.java:760)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:392)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:366)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:318)
> at
> org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.getProjectFacade(MavenBuilder.java:146)
> at
> org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.lambda$0(MavenBuilder.java:84)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionC
[jira] [Updated] (SLING-12305) Build fails on Java 21 due to invoker plug-in: Unsupported class file major version 65
[
https://issues.apache.org/jira/browse/SLING-12305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-12305:
Fix Version/s: OSGi Feature Maven Plugin 1.8.4
(was: OSGi Feature Maven Plugin 1.8.2)
> Build fails on Java 21 due to invoker plug-in: Unsupported class file major
> version 65
> --
>
> Key: SLING-12305
> URL: https://issues.apache.org/jira/browse/SLING-12305
> Project: Sling
> Issue Type: Bug
>Affects Versions: OSGi Feature Maven Plugin 1.8.0
> Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.4
>
>
> The invoker plugin-ins runs groovy scripts in the {{verify}} goal, and this
> fails on Java 21 with
> {noformat}
> [INFO] --- invoker:3.5.1:integration-test (integration-test) @
> slingfeature-maven-plugin ---
> [INFO] Building: analyzer-apiregions-errors-detected/pom.xml
> [INFO] run post-build script verify.groovy
> [INFO] BUG! exception in phase 'semantic analysis' in source unit
> 'Script1.groovy' Unsupported class file major version 65
> [INFO] analyzer-apiregions-errors-detected/pom.xml .. FAILED
> (3.0 s)
> {noformat}
> The stack trace seems to indicate that Groovy tries to parse Java 21 bytecode
> and fails.
> {noformat}
> Caused by: java.lang.IllegalArgumentException: Unsupported class file major
> version 65
> at groovyjarjarasm.asm.ClassReader.(ClassReader.java:199)
> at groovyjarjarasm.asm.ClassReader.(ClassReader.java:180)
> at groovyjarjarasm.asm.ClassReader.(ClassReader.java:166)
> at groovyjarjarasm.asm.ClassReader.(ClassReader.java:287)
> at
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-12305) Build fails on Java 21 due to invoker plug-in: Unsupported class file major version 65
[
https://issues.apache.org/jira/browse/SLING-12305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-12305.
-
Resolution: Fixed
> Build fails on Java 21 due to invoker plug-in: Unsupported class file major
> version 65
> --
>
> Key: SLING-12305
> URL: https://issues.apache.org/jira/browse/SLING-12305
> Project: Sling
> Issue Type: Bug
>Affects Versions: OSGi Feature Maven Plugin 1.8.0
> Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.4
>
>
> The invoker plugin-ins runs groovy scripts in the {{verify}} goal, and this
> fails on Java 21 with
> {noformat}
> [INFO] --- invoker:3.5.1:integration-test (integration-test) @
> slingfeature-maven-plugin ---
> [INFO] Building: analyzer-apiregions-errors-detected/pom.xml
> [INFO] run post-build script verify.groovy
> [INFO] BUG! exception in phase 'semantic analysis' in source unit
> 'Script1.groovy' Unsupported class file major version 65
> [INFO] analyzer-apiregions-errors-detected/pom.xml .. FAILED
> (3.0 s)
> {noformat}
> The stack trace seems to indicate that Groovy tries to parse Java 21 bytecode
> and fails.
> {noformat}
> Caused by: java.lang.IllegalArgumentException: Unsupported class file major
> version 65
> at groovyjarjarasm.asm.ClassReader.(ClassReader.java:199)
> at groovyjarjarasm.asm.ClassReader.(ClassReader.java:180)
> at groovyjarjarasm.asm.ClassReader.(ClassReader.java:166)
> at groovyjarjarasm.asm.ClassReader.(ClassReader.java:287)
> at
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12173) Configuration errors in Eclipse for projects using the slingfeature-maven-plugin
[
https://issues.apache.org/jira/browse/SLING-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-12173:
Fix Version/s: OSGi Feature Maven Plugin 1.8.4
(was: OSGi Feature Maven Plugin 1.8.2)
> Configuration errors in Eclipse for projects using the
> slingfeature-maven-plugin
>
>
> Key: SLING-12173
> URL: https://issues.apache.org/jira/browse/SLING-12173
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
> Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.4
>
>
> The slingfeature-maven-plugin currently uses the Jakarta JSON implementation
> of the Apache Johnzon parser.
> I have noticed problems in the Eclipse IDE, where projects fail to update
> with hard to isolate errors (see below).
> {noformat}java.util.ServiceConfigurationError: jakarta.json.spi.JsonProvider:
> org.apache.johnzon.core.JsonProviderImpl not a subtype
> at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:593)
> at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1244)
> at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273)
> at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309)
> at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393)
> at jakarta.json.spi.JsonProvider.provider(JsonProvider.java:69)
> at jakarta.json.Json.createReader(Json.java:189)
> at
> org.apache.sling.feature.maven.JSONFeatures.read(JSONFeatures.java:64)
> at
> org.apache.sling.feature.maven.ProjectHelper.readFeatureFile(ProjectHelper.java:622)
> at
> org.apache.sling.feature.maven.Preprocessor.readProjectFeatures(Preprocessor.java:304)
> at
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:145)
> at
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:110)
> at
> org.apache.sling.feature.maven.extensions.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:87)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.executeParticipants(ProjectRegistryManager.java:824)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$15(ProjectRegistryManager.java:791)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$14(ProjectRegistryManager.java:790)
> at java.base/java.util.HashMap$Values.forEach(HashMap.java:1065)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$11(ProjectRegistryManager.java:788)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.readMavenProjectFacades(ProjectRegistryManager.java:760)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:392)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:366)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:318)
> at
> org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.getProjectFacade(MavenBuilder.java:146)
> at
> org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.lambda$0(MavenBuilder.java:84)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
> at
> org.eclipse.m2e.core.internal.embed
[jira] [Updated] (SLING-12305) Build fails on Java 21 due to invoker plug-in: Unsupported class file major version 65
[
https://issues.apache.org/jira/browse/SLING-12305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-12305:
Issue Type: Bug (was: Task)
> Build fails on Java 21 due to invoker plug-in: Unsupported class file major
> version 65
> --
>
> Key: SLING-12305
> URL: https://issues.apache.org/jira/browse/SLING-12305
> Project: Sling
> Issue Type: Bug
>Affects Versions: OSGi Feature Maven Plugin 1.8.0
> Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.2
>
>
> The invoker plugin-ins runs groovy scripts in the {{verify}} goal, and this
> fails on Java 21 with
> {noformat}
> [INFO] --- invoker:3.5.1:integration-test (integration-test) @
> slingfeature-maven-plugin ---
> [INFO] Building: analyzer-apiregions-errors-detected/pom.xml
> [INFO] run post-build script verify.groovy
> [INFO] BUG! exception in phase 'semantic analysis' in source unit
> 'Script1.groovy' Unsupported class file major version 65
> [INFO] analyzer-apiregions-errors-detected/pom.xml .. FAILED
> (3.0 s)
> {noformat}
> The stack trace seems to indicate that Groovy tries to parse Java 21 bytecode
> and fails.
> {noformat}
> Caused by: java.lang.IllegalArgumentException: Unsupported class file major
> version 65
> at groovyjarjarasm.asm.ClassReader.(ClassReader.java:199)
> at groovyjarjarasm.asm.ClassReader.(ClassReader.java:180)
> at groovyjarjarasm.asm.ClassReader.(ClassReader.java:166)
> at groovyjarjarasm.asm.ClassReader.(ClassReader.java:287)
> at
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12305) Build fails on Java 21 due to invoker plug-in: Unsupported class file major version 65
Robert Munteanu created SLING-12305:
---
Summary: Build fails on Java 21 due to invoker plug-in:
Unsupported class file major version 65
Key: SLING-12305
URL: https://issues.apache.org/jira/browse/SLING-12305
Project: Sling
Issue Type: Task
Affects Versions: OSGi Feature Maven Plugin 1.8.0
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Fix For: OSGi Feature Maven Plugin 1.8.2
The invoker plugin-ins runs groovy scripts in the {{verify}} goal, and this
fails on Java 21 with
{noformat}
[INFO] --- invoker:3.5.1:integration-test (integration-test) @
slingfeature-maven-plugin ---
[INFO] Building: analyzer-apiregions-errors-detected/pom.xml
[INFO] run post-build script verify.groovy
[INFO] BUG! exception in phase 'semantic analysis' in source unit
'Script1.groovy' Unsupported class file major version 65
[INFO] analyzer-apiregions-errors-detected/pom.xml .. FAILED (3.0
s)
{noformat}
The stack trace seems to indicate that Groovy tries to parse Java 21 bytecode
and fails.
{noformat}
Caused by: java.lang.IllegalArgumentException: Unsupported class file major
version 65
at groovyjarjarasm.asm.ClassReader.(ClassReader.java:199)
at groovyjarjarasm.asm.ClassReader.(ClassReader.java:180)
at groovyjarjarasm.asm.ClassReader.(ClassReader.java:166)
at groovyjarjarasm.asm.ClassReader.(ClassReader.java:287)
at
org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12197) cpconverter: Sling-Initial-Content directories created as nt:folder instead of sling:Folder
[
https://issues.apache.org/jira/browse/SLING-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840675#comment-17840675
]
Robert Munteanu commented on SLING-12197:
-
[~sseifert] - I did not have time to look into it in depth, but reading through
the description it seems like a clear incompatibility between the CP Converter
and Initial Content behaviour that we need to address. I don't know the
codebase that well either, so a fix is not immediate for me either,
unfortunately.
> cpconverter: Sling-Initial-Content directories created as nt:folder instead
> of sling:Folder
> ---
>
> Key: SLING-12197
> URL: https://issues.apache.org/jira/browse/SLING-12197
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.4
>Reporter: Stefan Seifert
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.8
>
> Attachments: io.wcm.handler.link-apps-1.10.2-cp2fm-converted.zip
>
>
> the cpconverter extracts Sling-Initial-Content from OSGi bundles and creates
> FileVault packages with the transformed content.
> this works well, but there is one difference when the resulting content
> package is installed compared when uploading the OSGi bundle with the
> Sling-Initial-Content directly:
> * the JCR Content Loader by defaults creates a {{sling:Folder}} node type for
> each directory found in the Sling-Initial-Content (see also
> [docs|https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#initial-content-loading-1])
> * the cpconverter process creates no {{.content.xml}} file for the folders,
> but only for the actual JSON files found in the process. as a result, the
> folders are created as {{nt:folder}} when uploading the transformed package
> * this difference becomes relevant, when a JSON file in Sling-Initial-Content
> defines a primary type of {{nt:unstructured}} - it is not allowed to created
> such a node directly below a {{nt:folder}} node - but it is allowed to do so
> below a {{sling:Folder}} node
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12304) Broken backwards compatibility: out of order json object
[ https://issues.apache.org/jira/browse/SLING-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12304: Fix Version/s: Commons JSON 2.0.28 > Broken backwards compatibility: out of order json object > > > Key: SLING-12304 > URL: https://issues.apache.org/jira/browse/SLING-12304 > Project: Sling > Issue Type: Bug >Affects Versions: Commons JSON 2.0.26 >Reporter: Remo Liechti >Priority: Critical > Fix For: Commons JSON 2.0.28 > > > The fix of CVE-2022-47937 introduced an invalid backwards compatibility for > the order in jsonobject. > New behaviour: has the keys unordered, as JsonObject uses a HashMap. > Old behaviour: Kept insertion order of keys as JsonObject used LinkedHashMap. > To no break existing users of the library, reestablish the old behaviour. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12173) Configuration errors in Eclipse for projects using the slingfeature-maven-plugin
[
https://issues.apache.org/jira/browse/SLING-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840540#comment-17840540
]
Robert Munteanu commented on SLING-12173:
-
[~cziegeler] - that was my attempt to try out and see if the older plug-in
version has the same problem. It does have it, so both the jakarta.json and
javax.json implementations are problematic - in Eclipse, for me.
I suspect this is a classloader interaction between
- Maven/Plexus
- the OSGi runtime from Eclipse (Equinox)
- the ServiceLoader framework
- m2e
I _could_ try and chase this down across these projects but it seems like a lot
of work. Instead, I am experimenting with using our commons.johnzon dependency
instead the official JSON artifacts, and for now it seems to work fine.
IIUC this would avoid any such classloading issues, and hopefully will not
bring any problems with Maven executions. I'll try to run some tests over the
coming days, but wanted to check what you think of this approach.
> Configuration errors in Eclipse for projects using the
> slingfeature-maven-plugin
>
>
> Key: SLING-12173
> URL: https://issues.apache.org/jira/browse/SLING-12173
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
> Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.2
>
>
> The slingfeature-maven-plugin currently uses the Jakarta JSON implementation
> of the Apache Johnzon parser.
> I have noticed problems in the Eclipse IDE, where projects fail to update
> with hard to isolate errors (see below).
> {noformat}java.util.ServiceConfigurationError: jakarta.json.spi.JsonProvider:
> org.apache.johnzon.core.JsonProviderImpl not a subtype
> at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:593)
> at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1244)
> at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273)
> at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309)
> at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393)
> at jakarta.json.spi.JsonProvider.provider(JsonProvider.java:69)
> at jakarta.json.Json.createReader(Json.java:189)
> at
> org.apache.sling.feature.maven.JSONFeatures.read(JSONFeatures.java:64)
> at
> org.apache.sling.feature.maven.ProjectHelper.readFeatureFile(ProjectHelper.java:622)
> at
> org.apache.sling.feature.maven.Preprocessor.readProjectFeatures(Preprocessor.java:304)
> at
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:145)
> at
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:110)
> at
> org.apache.sling.feature.maven.extensions.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:87)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.executeParticipants(ProjectRegistryManager.java:824)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$15(ProjectRegistryManager.java:791)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$14(ProjectRegistryManager.java:790)
> at java.base/java.util.HashMap$Values.forEach(HashMap.java:1065)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$11(ProjectRegistryManager.java:788)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.readMavenProjectFacades(ProjectRegistryManager.java:760)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:392)
> at
> org.eclipse.m2e.core.intern
Re: [VOTE] Release Apache Sling Testing Sling Mock Oak 3.2.0-1.22.15
On Wed, 2024-04-17 at 18:32 +, Stefan Seifert wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
Re: [VOTE] Release Apache Sling Testing Sling Mock 3.5.0, Sling Mock Oak 4.0.0-1.62.0
On Wed, 2024-04-17 at 18:32 +, Stefan Seifert wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[jira] [Closed] (SLING-12290) Update tenant module to use parent pom 52
[ https://issues.apache.org/jira/browse/SLING-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-12290. --- > Update tenant module to use parent pom 52 > - > > Key: SLING-12290 > URL: https://issues.apache.org/jira/browse/SLING-12290 > Project: Sling > Issue Type: Task > Components: Extensions > Reporter: Robert Munteanu > Assignee: Robert Munteanu >Priority: Major > Fix For: Tenant 1.1.8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12285) adding bind & unbind methods mapping in reference annotation
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-12285. --- > adding bind & unbind methods mapping in reference annotation > > > Key: SLING-12285 > URL: https://issues.apache.org/jira/browse/SLING-12285 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Gagan Malpani >Assignee: Gagan Malpani >Priority: Major > Fix For: Tenant 1.1.8 > > > adding bind & unbind methods mapping in reference annotation for > tenantproviderimpl -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12286) Tenant build fails with Java 17 or newer
[ https://issues.apache.org/jira/browse/SLING-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-12286. --- > Tenant build fails with Java 17 or newer > > > Key: SLING-12286 > URL: https://issues.apache.org/jira/browse/SLING-12286 > Project: Sling > Issue Type: Bug > Components: Extensions > Reporter: Robert Munteanu > Assignee: Robert Munteanu >Priority: Major > Fix For: Tenant 1.1.8 > > > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.038 > s <<< FAILURE! - in org.apache.sling.tenant.internal.TenantProviderImplTest > [ERROR] > org.apache.sling.tenant.internal.TenantProviderImplTest.testListTenantsWithoutTenantRoot > Time elapsed: 0.036 s <<< ERROR! > java.lang.ExceptionInInitializerError > at > org.mockito.cglib.core.KeyFactory$Generator.generateClass(KeyFactory.java:167) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling Tenant 1.1.8
Hi, The vote has passed with the following result: +1 (binding): Stefan Seifert, Robert Munteanu, Joerg Hoh, Radu Cotescu +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu
Re: [VOTE] Release Apache Sling Rewriter 1.4.0
On Thu, 2024-04-18 at 18:36 +0200, Carsten Ziegeler wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
Re: [VOTE] Release Apache Sling Tenant 1.1.8
We need one more binding vote. Thanks, Robert
Re: [VOTE] Release Apache Sling Tenant 1.1.8
On Thu, 2024-04-11 at 13:33 +, Robert Munteanu wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[jira] [Closed] (SLING-12291) Broken backwards compatibility for duplicated keys
[ https://issues.apache.org/jira/browse/SLING-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-12291. --- > Broken backwards compatibility for duplicated keys > -- > > Key: SLING-12291 > URL: https://issues.apache.org/jira/browse/SLING-12291 > Project: Sling > Issue Type: Bug >Affects Versions: Commons JSON 2.0.24 >Reporter: Remo Liechti >Assignee: Remo Liechti >Priority: Major > Fix For: Commons JSON 2.0.26 > > > The fix of CVE-2022-47937 introduced an invalid backwards compatibility for > duplicated keys in a json. > New behaviour: throws an exception on duplicated keys > Old behaviour: ignores the fact and is able to process json with duplicated > keys. > To no break existing users of the library, reestablish the old behaviour. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling Commons JSON 2.0.26
Hi, The vote has passed with the following result: +1 (binding): Stefan Seifert, Carsten Ziegeler, Robert Munteanu +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu
Re: [VOTE] Release Apache Sling Commons JSON 2.0.26
On Fri, 2024-04-12 at 07:49 +, Robert Munteanu wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
Re: [VOTE] Release Apache Sling JUnit Tests Teleporter 1.0.26
Please disregard this thread, I accidentally sent the email twice. Thanks, Robert On Wed, 2024-04-17 at 11:52 +0200, Robert Munteanu wrote: > Hi, > > We solved 2 issues in this release: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12348597=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2847/ > > You can use this UNIX script to download the release and verify the > signatures: > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2847 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu signature.asc Description: This is a digitally signed message part
[VOTE] Release Apache Sling JUnit Tests Teleporter 1.0.26
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12348597=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2847/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2847 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
[jira] [Assigned] (SLING-11633) ClientSideTeleporter throwing illegal argument when target byte code is > 1.8
[ https://issues.apache.org/jira/browse/SLING-11633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-11633: --- Assignee: Scott Yuan > ClientSideTeleporter throwing illegal argument when target byte code is > 1.8 > - > > Key: SLING-11633 > URL: https://issues.apache.org/jira/browse/SLING-11633 > Project: Sling > Issue Type: Improvement > Components: Testing > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Maven home: C:\aem-tools\utils\apache-maven-3.8.5 > Java version: 11.0.15.1, vendor: Oracle Corporation, runtime: > C:\aem-tools\utils\jdk-11.0.15.1 > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" >Reporter: Scott Yuan >Assignee: Scott Yuan >Priority: Trivial > Fix For: JUnit Tests Teleporter 1.0.26 > > Attachments: mylab.zip > > Original Estimate: 2h > Time Spent: 0.5h > Remaining Estimate: 1.5h > > When attempted to use the latest 1.0.22 to build test cases using > TeleporterRule with Java 11+ code, illegal arguments error occurred. > It can be reproduce with the attached Maven project by change following > properites to 11. > * maven.compiler.source > * maven.compiler.target -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-6773) Convert oak-store-composite to OSGi R7 annotations
[ https://issues.apache.org/jira/browse/OAK-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838076#comment-17838076 ] Robert Munteanu commented on OAK-6773: -- Thanks for the heads-up [~baedke]. I think the descriptions are valuable to developers, so keeping them as comments would be good. > Convert oak-store-composite to OSGi R7 annotations > -- > > Key: OAK-6773 > URL: https://issues.apache.org/jira/browse/OAK-6773 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: composite > Reporter: Robert Munteanu >Assignee: Manfred Baedke >Priority: Major > Fix For: 1.64.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[VOTE] Release Apache Sling JUnit Tests Teleporter 1.0.26
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12348597=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2847/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2847 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
[jira] [Resolved] (SLING-9327) Teleporter not working with jdk11 due to missing xml bind classes
[
https://issues.apache.org/jira/browse/SLING-9327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-9327.
Resolution: Fixed
Merged
https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/6, I
think we can close this now.
> Teleporter not working with jdk11 due to missing xml bind classes
> -
>
> Key: SLING-9327
> URL: https://issues.apache.org/jira/browse/SLING-9327
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Affects Versions: JUnit Tests Teleporter 1.0.10
>Reporter: Thierry Ygé
>Assignee: Robert Munteanu
>Priority: Blocker
> Fix For: JUnit Tests Teleporter 1.0.24
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently when using teleporter on jdk11 based environment, the teleporter is
> failing due to missing class.
> {quote}java.lang.NoClassDefFoundError: javax/xml/bind/DatatypeConverter at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.setConnectionCredentials(TeleporterHttpClient.java:63)
> at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.getHttpGetStatus(TeleporterHttpClient.java:136)
> at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.waitForStatus(TeleporterHttpClient.java:75)
> at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.installBundle(TeleporterHttpClient.java:94)
> at
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.installTestBundle(ClientSideTeleporter.java:173)
> at
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.access$000(ClientSideTeleporter.java:45)
> at
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter$2.evaluate(ClientSideTeleporter.java:207)
> at
> com.adobe.granite.testing.serverside.rules.GraniteSSTRule$1.evaluate(GraniteSSTRule.java:104)
> {quote}
> This is due to jdk not containing this package anymore since jdk 9.
> Teleporter used is 1.0.10 and with 1.0.20 I couldn't use it as it fails with
> missing osgi core dependency, unless I would then add it manually in the test
> module pom.
> Note from [~bdelacretaz]
> As per
> [https://stackoverflow.com/questions/52502189/java-11-package-javax-xml-bind-does-not-exist]
> it looks like using {{jakarta.xml.bind}} as an additional dependency might
> fix this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-12276) Update to java-html-sanitizer 20240325.1
[ https://issues.apache.org/jira/browse/SLING-12276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12276. - Resolution: Fixed > Update to java-html-sanitizer 20240325.1 > > > Key: SLING-12276 > URL: https://issues.apache.org/jira/browse/SLING-12276 > Project: Sling > Issue Type: Improvement > Components: XSS Protection API > Reporter: Robert Munteanu > Assignee: Robert Munteanu >Priority: Major > Fix For: XSS Protection API 2.4.2 > > > A new Java HTML Sanitizer version is out, notably removing the dependency on > Guava ( > https://github.com/OWASP/java-html-sanitizer/releases/tag/release-20240325.1 > ). > This will allow us to remove: > - the embedding of Guava classes, cutting down on bundle size > - the shading of the Guava classes, reducing the complexity of the pom -- This message was sent by Atlassian Jira (v8.20.10#820010)
[VOTE] Release Apache Sling Commons JSON 2.0.26
Hi, We solved 1 issue in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354548=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2846/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2846 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
[jira] [Updated] (SLING-12291) Broken backwards compatibility for duplicated keys
[ https://issues.apache.org/jira/browse/SLING-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12291: Fix Version/s: Commons JSON 2.0.26 (was: Commons JSON 2.0.24) > Broken backwards compatibility for duplicated keys > -- > > Key: SLING-12291 > URL: https://issues.apache.org/jira/browse/SLING-12291 > Project: Sling > Issue Type: Bug >Affects Versions: Commons JSON 2.0.24 >Reporter: Remo Liechti >Assignee: Remo Liechti >Priority: Major > Fix For: Commons JSON 2.0.26 > > > The fix of CVE-2022-47937 introduced an invalid backwards compatibility for > duplicated keys in a json. > New behaviour: throws an exception on duplicated keys > Old behaviour: ignores the fact and is able to process json with duplicated > keys. > To no break existing users of the library, reestablish the old behaviour. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12291) Broken backwards compatibility for duplicated keys
[ https://issues.apache.org/jira/browse/SLING-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12291. - Resolution: Fixed PR applied, thanks [~rliechti]! > Broken backwards compatibility for duplicated keys > -- > > Key: SLING-12291 > URL: https://issues.apache.org/jira/browse/SLING-12291 > Project: Sling > Issue Type: Bug >Affects Versions: Commons JSON 2.0.24 >Reporter: Remo Liechti >Assignee: Remo Liechti >Priority: Major > Fix For: Commons JSON 2.0.24 > > > The fix of CVE-2022-47937 introduced an invalid backwards compatibility for > duplicated keys in a json. > New behaviour: throws an exception on duplicated keys > Old behaviour: ignores the fact and is able to process json with duplicated > keys. > To no break existing users of the library, reestablish the old behaviour. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12291) Broken backwards compatibility for duplicated keys
[ https://issues.apache.org/jira/browse/SLING-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-12291: --- Assignee: Remo Liechti > Broken backwards compatibility for duplicated keys > -- > > Key: SLING-12291 > URL: https://issues.apache.org/jira/browse/SLING-12291 > Project: Sling > Issue Type: Bug >Affects Versions: Commons JSON 2.0.24 >Reporter: Remo Liechti >Assignee: Remo Liechti >Priority: Major > Fix For: Commons JSON 2.0.24 > > > The fix of CVE-2022-47937 introduced an invalid backwards compatibility for > duplicated keys in a json. > New behaviour: throws an exception on duplicated keys > Old behaviour: ignores the fact and is able to process json with duplicated > keys. > To no break existing users of the library, reestablish the old behaviour. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12291) Broken backwards compatibility for duplicated keys
[ https://issues.apache.org/jira/browse/SLING-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12291: Fix Version/s: Commons JSON 2.0.24 > Broken backwards compatibility for duplicated keys > -- > > Key: SLING-12291 > URL: https://issues.apache.org/jira/browse/SLING-12291 > Project: Sling > Issue Type: Bug >Affects Versions: Commons JSON 2.0.24 >Reporter: Remo Liechti >Priority: Major > Fix For: Commons JSON 2.0.24 > > > The fix of CVE-2022-47937 introduced an invalid backwards compatibility for > duplicated keys in a json. > New behaviour: throws an exception on duplicated keys > Old behaviour: ignores the fact and is able to process json with duplicated > keys. > To no break existing users of the library, reestablish the old behaviour. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[VOTE] Release Apache Sling Tenant 1.1.8
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354544=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2845/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2845 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
[jira] [Resolved] (SLING-12290) Update tenant module to use parent pom 52
[ https://issues.apache.org/jira/browse/SLING-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12290. - Resolution: Fixed > Update tenant module to use parent pom 52 > - > > Key: SLING-12290 > URL: https://issues.apache.org/jira/browse/SLING-12290 > Project: Sling > Issue Type: Task > Components: Extensions > Reporter: Robert Munteanu > Assignee: Robert Munteanu >Priority: Major > Fix For: Tenant 1.1.8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12290) Update tenant module to use parent pom 52
Robert Munteanu created SLING-12290: --- Summary: Update tenant module to use parent pom 52 Key: SLING-12290 URL: https://issues.apache.org/jira/browse/SLING-12290 Project: Sling Issue Type: Task Components: Extensions Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Tenant 1.1.8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12285) adding bind & unbind methods mapping in reference annotation
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12285. - Resolution: Fixed > adding bind & unbind methods mapping in reference annotation > > > Key: SLING-12285 > URL: https://issues.apache.org/jira/browse/SLING-12285 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Gagan Malpani >Assignee: Gagan Malpani >Priority: Major > Fix For: Tenant 1.1.8 > > > adding bind & unbind methods mapping in reference annotation for > tenantproviderimpl -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12285) adding bind & unbind methods mapping in reference annotation
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-12285: --- Assignee: Gagan Malpani > adding bind & unbind methods mapping in reference annotation > > > Key: SLING-12285 > URL: https://issues.apache.org/jira/browse/SLING-12285 > Project: Sling > Issue Type: Bug > Components: General >Reporter: Gagan Malpani >Assignee: Gagan Malpani >Priority: Major > Fix For: Tenant 1.1.8 > > > adding bind & unbind methods mapping in reference annotation for > tenantproviderimpl -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12285) adding bind & unbind methods mapping in reference annotation
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12285: Component/s: Extensions (was: General) > adding bind & unbind methods mapping in reference annotation > > > Key: SLING-12285 > URL: https://issues.apache.org/jira/browse/SLING-12285 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Gagan Malpani >Assignee: Gagan Malpani >Priority: Major > Fix For: Tenant 1.1.8 > > > adding bind & unbind methods mapping in reference annotation for > tenantproviderimpl -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12285) adding bind & unbind methods mapping in reference annotation
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12285: Issue Type: Bug (was: Improvement) > adding bind & unbind methods mapping in reference annotation > > > Key: SLING-12285 > URL: https://issues.apache.org/jira/browse/SLING-12285 > Project: Sling > Issue Type: Bug > Components: General >Reporter: Gagan Malpani >Priority: Major > Fix For: Tenant 1.1.8 > > > adding bind & unbind methods mapping in reference annotation for > tenantproviderimpl -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12286) Tenant build fails with Java 17 or newer
[ https://issues.apache.org/jira/browse/SLING-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12286. - Resolution: Fixed > Tenant build fails with Java 17 or newer > > > Key: SLING-12286 > URL: https://issues.apache.org/jira/browse/SLING-12286 > Project: Sling > Issue Type: Bug > Components: Extensions > Reporter: Robert Munteanu > Assignee: Robert Munteanu >Priority: Major > Fix For: Tenant 1.1.8 > > > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.038 > s <<< FAILURE! - in org.apache.sling.tenant.internal.TenantProviderImplTest > [ERROR] > org.apache.sling.tenant.internal.TenantProviderImplTest.testListTenantsWithoutTenantRoot > Time elapsed: 0.036 s <<< ERROR! > java.lang.ExceptionInInitializerError > at > org.mockito.cglib.core.KeyFactory$Generator.generateClass(KeyFactory.java:167) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12286) Tenant build fails with Java 17 or newer
[ https://issues.apache.org/jira/browse/SLING-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12286: Summary: Tenant build fails with Java 17 or newer (was: Tenat build fails with Java 17 or newer) > Tenant build fails with Java 17 or newer > > > Key: SLING-12286 > URL: https://issues.apache.org/jira/browse/SLING-12286 > Project: Sling > Issue Type: Bug > Components: Extensions > Reporter: Robert Munteanu > Assignee: Robert Munteanu >Priority: Major > Fix For: Tenant 1.1.8 > > > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.038 > s <<< FAILURE! - in org.apache.sling.tenant.internal.TenantProviderImplTest > [ERROR] > org.apache.sling.tenant.internal.TenantProviderImplTest.testListTenantsWithoutTenantRoot > Time elapsed: 0.036 s <<< ERROR! > java.lang.ExceptionInInitializerError > at > org.mockito.cglib.core.KeyFactory$Generator.generateClass(KeyFactory.java:167) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12286) Tenat build fails with Java 17 or newer
Robert Munteanu created SLING-12286: --- Summary: Tenat build fails with Java 17 or newer Key: SLING-12286 URL: https://issues.apache.org/jira/browse/SLING-12286 Project: Sling Issue Type: Bug Components: Extensions Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Tenant 1.1.8 [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.038 s <<< FAILURE! - in org.apache.sling.tenant.internal.TenantProviderImplTest [ERROR] org.apache.sling.tenant.internal.TenantProviderImplTest.testListTenantsWithoutTenantRoot Time elapsed: 0.036 s <<< ERROR! java.lang.ExceptionInInitializerError at org.mockito.cglib.core.KeyFactory$Generator.generateClass(KeyFactory.java:167) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12285) adding bind & unbind methods mapping in reference annotation
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12285: Fix Version/s: Tenant 1.1.8 > adding bind & unbind methods mapping in reference annotation > > > Key: SLING-12285 > URL: https://issues.apache.org/jira/browse/SLING-12285 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Gagan Malpani >Priority: Major > Fix For: Tenant 1.1.8 > > > adding bind & unbind methods mapping in reference annotation for > tenantproviderimpl -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12285) adding bind & unbind methods mapping in reference annotation
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835704#comment-17835704 ] Robert Munteanu commented on SLING-12285: - Thanks for the report [~malp...@adobe.com]. Is this an actual bug? How does this manifest (log entries, etc)? > adding bind & unbind methods mapping in reference annotation > > > Key: SLING-12285 > URL: https://issues.apache.org/jira/browse/SLING-12285 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Gagan Malpani >Priority: Major > > adding bind & unbind methods mapping in reference annotation for > tenantproviderimpl -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: How to use structured logging in sling?
Hi Christian, On Wed, 2024-04-10 at 10:14 +0200, Christian Schneider wrote: > I would like to add an appender like below to sling. > The idea is to use structured logging for simpler ingestion and the > ability > to easily add markers and MDC key/value pairs. > > Did anyone try this before? The issue here is that I need special > classes > for encoder and decorator that are not part of logback core. > I did not try this. The docs indicate though that you can register Appenders as OSGi services [1], perhaps you can create a small bundle that has a such a service and register it? Thanks, Robert [1]: https://sling.apache.org/documentation/development/logging.html#appenders-as-osgi-services-1
Re: [VOTE] Release Apache Sling Content Parser JSON 2.1.0
On Tue, 2024-04-09 at 10:15 +, Stefan Seifert wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[jira] [Commented] (SLING-9327) Teleporter not working with jdk11 due to missing xml bind classes
[
https://issues.apache.org/jira/browse/SLING-9327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834913#comment-17834913
]
Robert Munteanu commented on SLING-9327:
I've created a PR to remove the commons-codec dependency, I don't see how that
can be needed. I'll try to get some proper tests running before merging.
> Teleporter not working with jdk11 due to missing xml bind classes
> -
>
> Key: SLING-9327
> URL: https://issues.apache.org/jira/browse/SLING-9327
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Affects Versions: JUnit Tests Teleporter 1.0.10
>Reporter: Thierry Ygé
>Assignee: Robert Munteanu
>Priority: Blocker
> Fix For: JUnit Tests Teleporter 1.0.24
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently when using teleporter on jdk11 based environment, the teleporter is
> failing due to missing class.
> {quote}java.lang.NoClassDefFoundError: javax/xml/bind/DatatypeConverter at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.setConnectionCredentials(TeleporterHttpClient.java:63)
> at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.getHttpGetStatus(TeleporterHttpClient.java:136)
> at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.waitForStatus(TeleporterHttpClient.java:75)
> at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.installBundle(TeleporterHttpClient.java:94)
> at
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.installTestBundle(ClientSideTeleporter.java:173)
> at
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.access$000(ClientSideTeleporter.java:45)
> at
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter$2.evaluate(ClientSideTeleporter.java:207)
> at
> com.adobe.granite.testing.serverside.rules.GraniteSSTRule$1.evaluate(GraniteSSTRule.java:104)
> {quote}
> This is due to jdk not containing this package anymore since jdk 9.
> Teleporter used is 1.0.10 and with 1.0.20 I couldn't use it as it fails with
> missing osgi core dependency, unless I would then add it manually in the test
> module pom.
> Note from [~bdelacretaz]
> As per
> [https://stackoverflow.com/questions/52502189/java-11-package-javax-xml-bind-does-not-exist]
> it looks like using {{jakarta.xml.bind}} as an additional dependency might
> fix this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-9327) Teleporter not working with jdk11 due to missing xml bind classes
[
https://issues.apache.org/jira/browse/SLING-9327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu reassigned SLING-9327:
--
Assignee: Robert Munteanu
> Teleporter not working with jdk11 due to missing xml bind classes
> -
>
> Key: SLING-9327
> URL: https://issues.apache.org/jira/browse/SLING-9327
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Affects Versions: JUnit Tests Teleporter 1.0.10
>Reporter: Thierry Ygé
>Assignee: Robert Munteanu
>Priority: Blocker
> Fix For: JUnit Tests Teleporter 1.0.24
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently when using teleporter on jdk11 based environment, the teleporter is
> failing due to missing class.
> {quote}java.lang.NoClassDefFoundError: javax/xml/bind/DatatypeConverter at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.setConnectionCredentials(TeleporterHttpClient.java:63)
> at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.getHttpGetStatus(TeleporterHttpClient.java:136)
> at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.waitForStatus(TeleporterHttpClient.java:75)
> at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.installBundle(TeleporterHttpClient.java:94)
> at
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.installTestBundle(ClientSideTeleporter.java:173)
> at
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.access$000(ClientSideTeleporter.java:45)
> at
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter$2.evaluate(ClientSideTeleporter.java:207)
> at
> com.adobe.granite.testing.serverside.rules.GraniteSSTRule$1.evaluate(GraniteSSTRule.java:104)
> {quote}
> This is due to jdk not containing this package anymore since jdk 9.
> Teleporter used is 1.0.10 and with 1.0.20 I couldn't use it as it fails with
> missing osgi core dependency, unless I would then add it manually in the test
> module pom.
> Note from [~bdelacretaz]
> As per
> [https://stackoverflow.com/questions/52502189/java-11-package-javax-xml-bind-does-not-exist]
> it looks like using {{jakarta.xml.bind}} as an additional dependency might
> fix this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: Improving unit testing performance for JCR_OAK (SLING-12265 and SLING-12266)
Hello Csaba, On Thu, 2024-04-04 at 11:54 +, Csaba Varga wrote: > Hello, > > I would like to ask about two issues I opened last month. SLING-12265 > is about decreasing the number of commits done while setting up a new > repository during unit testing. SLING-12266 proposes going a bit > further, caching and re-using the complete repository state, > requiring just one initialization from scratch regardless of the > number of tests using a JCR_OAK context. > > I haven't heard any feedback about either ticket, even though I have > added a PR for the first one. Am I missing something? Are there > issues with this approach? I have some numbers for both proposals, > and they are speeding things up significantly as far as I can tell, > so I think everyone could benefit from this. (I only did a quick and > dirty test for SLING-12266, not clean enough to make a PR out of it, > but I can polish it into a PR if there is interest.) > > If this is not the right channel to discuss it, please feel free to > let me know. Writing to the dev list is the right thing in case your does not get attention. The PR looks good overall to me but someone closer to the topic should review it. Maybe you got their attention and you'll get a review next week. Otherwise, we can do an optimistic merge and revert if we find problems down the road. Thanks for your patience, Robert
[RESULT] [VOTE] Release Apache Sling Commons JSON 2.0.24
Hi, The vote has passed with the following result: +1 (binding): Robert Munteanu, Dan Klco, Stefan Egli +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu
Re: [VOTE] Release Apache Sling Commons JSON 2.0.24
Hi, We need two more binding votes for the release to pass. Thanks, Robert
Re: [VOTE] Release Apache Sling Commons JSON 2.0.24
On Wed, 2024-03-20 at 12:16 +, Robert Munteanu wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[jira] [Assigned] (SLING-12276) Update to java-html-sanitizer 20240325.1
[ https://issues.apache.org/jira/browse/SLING-12276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-12276: --- Assignee: Robert Munteanu > Update to java-html-sanitizer 20240325.1 > > > Key: SLING-12276 > URL: https://issues.apache.org/jira/browse/SLING-12276 > Project: Sling > Issue Type: Improvement > Components: XSS Protection API > Reporter: Robert Munteanu > Assignee: Robert Munteanu >Priority: Major > Fix For: XSS Protection API 2.4.2 > > > A new Java HTML Sanitizer version is out, notably removing the dependency on > Guava ( > https://github.com/OWASP/java-html-sanitizer/releases/tag/release-20240325.1 > ). > This will allow us to remove: > - the embedding of Guava classes, cutting down on bundle size > - the shading of the Guava classes, reducing the complexity of the pom -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12276) Update to java-html-sanitizer 20240325.1
Robert Munteanu created SLING-12276: --- Summary: Update to java-html-sanitizer 20240325.1 Key: SLING-12276 URL: https://issues.apache.org/jira/browse/SLING-12276 Project: Sling Issue Type: Improvement Components: XSS Protection API Reporter: Robert Munteanu Fix For: XSS Protection API 2.4.2 A new Java HTML Sanitizer version is out, notably removing the dependency on Guava ( https://github.com/OWASP/java-html-sanitizer/releases/tag/release-20240325.1 ). This will allow us to remove: - the embedding of Guava classes, cutting down on bundle size - the shading of the Guava classes, reducing the complexity of the pom -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12272) Document org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor
[
https://issues.apache.org/jira/browse/SLING-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-12272:
Component/s: Sling Models
> Document org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor
> --
>
> Key: SLING-12272
> URL: https://issues.apache.org/jira/browse/SLING-12272
> Project: Sling
> Issue Type: Improvement
> Components: Documentation, Sling Models
>Reporter: Konrad Windszus
>Priority: Major
>
> With JDK 22 annotation processors will no longer be automatically executed by
> javac (https://bugs.openjdk.org/browse/JDK-8306819). Instead they need to be
> explicitly enabled with
> {code}
> -processor
> {code}
> (https://docs.oracle.com/en/java/javase/17/docs/specs/man/javac.html#option-processor)
> That and a minimum description of what it does should be added to
> https://sling.apache.org/documentation/bundles/models.html.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12272) Document org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor
[
https://issues.apache.org/jira/browse/SLING-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-12272:
Component/s: Documentation
> Document org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor
> --
>
> Key: SLING-12272
> URL: https://issues.apache.org/jira/browse/SLING-12272
> Project: Sling
> Issue Type: Improvement
> Components: Documentation
>Reporter: Konrad Windszus
>Priority: Major
>
> With JDK 22 annotation processors will no longer be automatically executed by
> javac (https://bugs.openjdk.org/browse/JDK-8306819). Instead they need to be
> explicitly enabled with
> {code}
> -processor
> {code}
> (https://docs.oracle.com/en/java/javase/17/docs/specs/man/javac.html#option-processor)
> That and a minimum description of what it does should be added to
> https://sling.apache.org/documentation/bundles/models.html.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[CANCELLED] [VOTE] Release Apache Sling Commons JSON version 2.0.22
I am cancelling this release because a regressions has crept up. https://issues.apache.org/jira/browse/SLING-12269 Will create a follow-up release for it. Thanks, Robert On Tue, 2024-03-19 at 14:11 +0100, Robert Munteanu wrote: > Hi, > > Time to cut a release of the (still deprecated) commons.json module. > We > only include the already-known CVE fix, cut from the maintenance > branch. > > We solved 1 issues in this release: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710= > 12354425=Text > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2842 > > You can use this UNIX script to download the release and verify the > signatures: > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2842 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. >
[VOTE] Release Apache Sling Commons JSON 2.0.24
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354429=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2843/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2843 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
[jira] [Assigned] (SLING-12269) Changed behaviour in commons json when used as a dependency
[
https://issues.apache.org/jira/browse/SLING-12269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu reassigned SLING-12269:
---
Assignee: Remo Liechti
> Changed behaviour in commons json when used as a dependency
> ---
>
> Key: SLING-12269
> URL: https://issues.apache.org/jira/browse/SLING-12269
> Project: Sling
> Issue Type: Bug
> Components: Commons
>Reporter: Remo Liechti
>Assignee: Remo Liechti
>Priority: Blocker
> Attachments: SLING-12269.patch
>
>
> With the new internal release 2.0.22, there seems to be a different behaviour
> when it comes to get values from JSONObject.
> The new version checks for types and throws an exception, as of the old
> version simply called toString() on any object found.
> *Old:*
> {code:java}
> public String getString(String key) throws JSONException {
> return get(key).toString();
> }{code}
> *New:*
> {{}}
> {code:java}
> public String getString(String key) throws JSONException {
> Objectobject=this.get(key);
> if (objectinstanceofString) {
> return (String) object;
> }
> throwwrongValueFormatException(key, "string", object, null);
> }{code}
>
> Same is true for all other types, such as getInt, getLong etc.
> There might be more such small differences in behaviour.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[VOTE] Release Apache Sling Commons JSON 2.0.24
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354429=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2843/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2843 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
[jira] [Resolved] (SLING-12269) Restore previous behaviour of JSONObject and JSONArray getString methods
[
https://issues.apache.org/jira/browse/SLING-12269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-12269.
-
Resolution: Fixed
Thanks for the PR [~rliechti], I have merged it.
> Restore previous behaviour of JSONObject and JSONArray getString methods
>
>
> Key: SLING-12269
> URL: https://issues.apache.org/jira/browse/SLING-12269
> Project: Sling
> Issue Type: Bug
> Components: Commons
>Reporter: Remo Liechti
>Assignee: Remo Liechti
>Priority: Blocker
> Fix For: Commons JSON 2.0.24
>
> Attachments: SLING-12269.patch
>
>
> With the new internal release 2.0.22, there seems to be a different behaviour
> when it comes to get values from JSONObject.
> The new version checks for types and throws an exception, as of the old
> version simply called toString() on any object found.
> *Old:*
> {code:java}
> public String getString(String key) throws JSONException {
> return get(key).toString();
> }{code}
> *New:*
> {{}}
> {code:java}
> public String getString(String key) throws JSONException {
> Objectobject=this.get(key);
> if (objectinstanceofString) {
> return (String) object;
> }
> throwwrongValueFormatException(key, "string", object, null);
> }{code}
>
> Same is true for all other types, such as getInt, getLong etc.
> There might be more such small differences in behaviour.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12269) Restore previous behaviour of JSONObject and JSONArray getString methods
[
https://issues.apache.org/jira/browse/SLING-12269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-12269:
Summary: Restore previous behaviour of JSONObject and JSONArray getString
methods (was: Changed behaviour in commons json when used as a dependency)
> Restore previous behaviour of JSONObject and JSONArray getString methods
>
>
> Key: SLING-12269
> URL: https://issues.apache.org/jira/browse/SLING-12269
> Project: Sling
> Issue Type: Bug
> Components: Commons
>Reporter: Remo Liechti
>Assignee: Remo Liechti
>Priority: Blocker
> Attachments: SLING-12269.patch
>
>
> With the new internal release 2.0.22, there seems to be a different behaviour
> when it comes to get values from JSONObject.
> The new version checks for types and throws an exception, as of the old
> version simply called toString() on any object found.
> *Old:*
> {code:java}
> public String getString(String key) throws JSONException {
> return get(key).toString();
> }{code}
> *New:*
> {{}}
> {code:java}
> public String getString(String key) throws JSONException {
> Objectobject=this.get(key);
> if (objectinstanceofString) {
> return (String) object;
> }
> throwwrongValueFormatException(key, "string", object, null);
> }{code}
>
> Same is true for all other types, such as getInt, getLong etc.
> There might be more such small differences in behaviour.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12268) Fix CVE-2022-47937
[ https://issues.apache.org/jira/browse/SLING-12268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12268: Fix Version/s: Commons JSON 2.0.24 (was: Commons JSON 2.0.22) > Fix CVE-2022-47937 > -- > > Key: SLING-12268 > URL: https://issues.apache.org/jira/browse/SLING-12268 > Project: Sling > Issue Type: Bug > Components: Commons >Reporter: Remo Liechti >Assignee: Remo Liechti >Priority: Major > Fix For: Commons JSON 2.0.24 > > > Current version of apache commons json is affected by > [https://nvd.nist.gov/vuln/detail/CVE-2022-47937] > Due to the relicenced base library ([https://github.com/stleary/JSON-java)], > that now uses the 'public domain', the fix of that CVE is as simple as > migrating to the latest codebase of said library. > Along this, it would be beneficial to perform some side activities, such as > the upgrade to the latest parent pom and junit5. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12269) Restore previous behaviour of JSONObject and JSONArray getString methods
[
https://issues.apache.org/jira/browse/SLING-12269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-12269:
Fix Version/s: Commons JSON 2.0.24
> Restore previous behaviour of JSONObject and JSONArray getString methods
>
>
> Key: SLING-12269
> URL: https://issues.apache.org/jira/browse/SLING-12269
> Project: Sling
> Issue Type: Bug
> Components: Commons
>Reporter: Remo Liechti
>Assignee: Remo Liechti
>Priority: Blocker
> Fix For: Commons JSON 2.0.24
>
> Attachments: SLING-12269.patch
>
>
> With the new internal release 2.0.22, there seems to be a different behaviour
> when it comes to get values from JSONObject.
> The new version checks for types and throws an exception, as of the old
> version simply called toString() on any object found.
> *Old:*
> {code:java}
> public String getString(String key) throws JSONException {
> return get(key).toString();
> }{code}
> *New:*
> {{}}
> {code:java}
> public String getString(String key) throws JSONException {
> Objectobject=this.get(key);
> if (objectinstanceofString) {
> return (String) object;
> }
> throwwrongValueFormatException(key, "string", object, null);
> }{code}
>
> Same is true for all other types, such as getInt, getLong etc.
> There might be more such small differences in behaviour.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12269) Changed behaviour in commons json when used as a dependency
[
https://issues.apache.org/jira/browse/SLING-12269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828429#comment-17828429
]
Robert Munteanu commented on SLING-12269:
-
Right, in this case the new version is more lenient and uses {{toString()}}
instead of conditionally downcasting. That is a behaviour change indeed, but I
am personally not very concerned about that as it will not break consumers
relying on the old behaviour.
> Changed behaviour in commons json when used as a dependency
> ---
>
> Key: SLING-12269
> URL: https://issues.apache.org/jira/browse/SLING-12269
> Project: Sling
> Issue Type: Bug
> Components: Commons
>Reporter: Remo Liechti
>Priority: Blocker
>
> With the new internal release 2.0.22, there seems to be a different behaviour
> when it comes to get values from JSONObject.
> The new version checks for types and throws an exception, as of the old
> version simply called toString() on any object found.
> *Old:*
> {{public String getString(String key) throws JSONException {}}
> {{ return get(key).toString();}}
> {{}}}
> *New:*
> {{public String getString(String key) throws JSONException {}}
> {{ Objectobject=this.get(key);}}
> {{ if (objectinstanceofString) {}}
> {{ return (String) object;}}
> }
> {{ throwwrongValueFormatException(key, "string", object, null);}}
> {{}}}
>
> Same is true for all other types, such as getInt, getLong etc.
> There might be more such small differences in behaviour.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12269) Changed behaviour in commons json when used as a dependency
[
https://issues.apache.org/jira/browse/SLING-12269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-12269:
Component/s: Commons
> Changed behaviour in commons json when used as a dependency
> ---
>
> Key: SLING-12269
> URL: https://issues.apache.org/jira/browse/SLING-12269
> Project: Sling
> Issue Type: Bug
> Components: Commons
>Reporter: Remo Liechti
>Priority: Blocker
>
> With the new internal release 2.0.22, there seems to be a different behaviour
> when it comes to get values from JSONObject.
> The new version checks for types and throws an exception, as of the old
> version simply called toString() on any object found.
> *Old:*
> {{public String getString(String key) throws JSONException {}}
> {{ return get(key).toString();}}
> {{}}}
> *New:*
> {{public String getString(String key) throws JSONException {}}
> {{ Objectobject=this.get(key);}}
> {{ if (objectinstanceofString) {}}
> {{ return (String) object;}}
> }
> {{ throwwrongValueFormatException(key, "string", object, null);}}
> {{}}}
>
> Same is true for all other types, such as getInt, getLong etc.
> There might be more such small differences in behaviour.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12269) Changed behaviour in commons json when used as a dependency
[
https://issues.apache.org/jira/browse/SLING-12269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828419#comment-17828419
]
Robert Munteanu commented on SLING-12269:
-
Thanks for the report [~rliechti]. I would like to understand what methods are
affected, so here's a comparison table:
||Method||Version 2.0.20|| Version 2.0.22|| Change? ||
|JSONObject.getString|
https://github.com/apache/sling-org-apache-sling-commons-json/blob/43d3030dbb967232d129ed19f79d0b89b82f4965/src/main/java/org/apache/sling/commons/json/JSONObject.java#L487-L489|
https://github.com/apache/sling-org-apache-sling-commons-json/blob/7a15fe774b6892c770af4d7ad12aa1d1bd7f976c/src/main/java/org/apache/sling/commons/json/JSONObject.java#L913-L919
| (!) Yes, 2.0.22 fails if value is not string |
| JSONObject.getBoolean |
https://github.com/apache/sling-org-apache-sling-commons-json/blob/43d3030dbb967232d129ed19f79d0b89b82f4965/src/main/java/org/apache/sling/commons/json/JSONObject.java#L375-L388
|
https://github.com/apache/sling-org-apache-sling-commons-json/blob/7a15fe774b6892c770af4d7ad12aa1d1bd7f976c/src/main/java/org/apache/sling/commons/json/JSONObject.java#L663-L675
| No, both versions need either "true" or "false", case insensitive |
| JSonObject.getDouble |
https://github.com/apache/sling-org-apache-sling-commons-json/blob/43d3030dbb967232d129ed19f79d0b89b82f4965/src/main/java/org/apache/sling/commons/json/JSONObject.java#L398-L408
|
https://github.com/apache/sling-org-apache-sling-commons-json/blob/43d3030dbb967232d129ed19f79d0b89b82f4965/src/main/java/org/apache/sling/commons/json/JSONObject.java#L398-L408
| No, both versions check for {{Number}} and try to parse if needed |
| JSonObject.getInt |
https://github.com/apache/sling-org-apache-sling-commons-json/blob/43d3030dbb967232d129ed19f79d0b89b82f4965/src/main/java/org/apache/sling/commons/json/JSONObject.java#L420-L424
|
https://github.com/apache/sling-org-apache-sling-commons-json/blob/7a15fe774b6892c770af4d7ad12aa1d1bd7f976c/src/main/java/org/apache/sling/commons/json/JSONObject.java#L795-L805
| No, both versions check for {{Number}} and try to parse if needed |
| JSONObject.getJSONArray |
https://github.com/apache/sling-org-apache-sling-commons-json/blob/43d3030dbb967232d129ed19f79d0b89b82f4965/src/main/java/org/apache/sling/commons/json/JSONObject.java#L435-L442
|
https://github.com/apache/sling-org-apache-sling-commons-json/blob/7a15fe774b6892c770af4d7ad12aa1d1bd7f976c/src/main/java/org/apache/sling/commons/json/JSONObject.java#L817-L823
| No, both versions throw exceptions if the instanceof check fails |
| JSONObject.getJSONObject |
https://github.com/apache/sling-org-apache-sling-commons-json/blob/43d3030dbb967232d129ed19f79d0b89b82f4965/src/main/java/org/apache/sling/commons/json/JSONObject.java#L453-L460
|
https://github.com/apache/sling-org-apache-sling-commons-json/blob/7a15fe774b6892c770af4d7ad12aa1d1bd7f976c/src/main/java/org/apache/sling/commons/json/JSONObject.java#L835-L841
| No, both versions throw exceptions if the instanceof check fails |
| JSONObject.getLong |
https://github.com/apache/sling-org-apache-sling-commons-json/blob/43d3030dbb967232d129ed19f79d0b89b82f4965/src/main/java/org/apache/sling/commons/json/JSONObject.java#L472-L477
|
https://github.com/apache/sling-org-apache-sling-commons-json/blob/7a15fe774b6892c770af4d7ad12aa1d1bd7f976c/src/main/java/org/apache/sling/commons/json/JSONObject.java#L854-L864
| No, both versions check for {{Number}} and try to parse if needed |
It looks to me like {{getString}} is the only problematic change. Do you see
anything else?
> Changed behaviour in commons json when used as a dependency
> ---
>
> Key: SLING-12269
> URL: https://issues.apache.org/jira/browse/SLING-12269
> Project: Sling
> Issue Type: Bug
>Reporter: Remo Liechti
>Priority: Blocker
>
> With the new internal release 2.0.22, there seems to be a different behaviour
> when it comes to get values from JSONObject.
> The new version checks for types and throws an exception, as of the old
> version simply called toString() on any object found.
> *Old:*
> {{public String getString(String key) throws JSONException {}}
> {{ return get(key).toString();}}
> {{}}}
> *New:*
> {{public String getString(String key) throws JSONException {}}
> {{ Objectobject=this.get(key);}}
> {{ if (objectinstanceofString) {}}
> {{ return (String) object;}}
> }
> {{ throwwrongValueFormatException(key, "string", object, null);}}
> {{}}}
>
> Same is true for all other types, such as getInt, getLong etc.
> There might be more such small differences in behaviour.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[VOTE] Release Apache Sling Commons JSON version 2.0.22
Hi, Time to cut a release of the (still deprecated) commons.json module. We only include the already-known CVE fix, cut from the maintenance branch. We solved 1 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710= 12354425=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2842 You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2842 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
[jira] [Updated] (SLING-12268) Fix CVE-2022-47937
[ https://issues.apache.org/jira/browse/SLING-12268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12268: Fix Version/s: Commons JSON 2.0.22 > Fix CVE-2022-47937 > -- > > Key: SLING-12268 > URL: https://issues.apache.org/jira/browse/SLING-12268 > Project: Sling > Issue Type: Bug > Components: Commons >Reporter: Remo Liechti >Assignee: Remo Liechti >Priority: Major > Fix For: Commons JSON 2.0.22 > > > Current version of apache commons json is affected by > [https://nvd.nist.gov/vuln/detail/CVE-2022-47937] > Due to the relicenced base library ([https://github.com/stleary/JSON-java)], > that now uses the 'public domain', the fix of that CVE is as simple as > migrating to the latest codebase of said library. > Along this, it would be beneficial to perform some side activities, such as > the upgrade to the latest parent pom and junit5. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12268) Fix CVE-2022-47937
[ https://issues.apache.org/jira/browse/SLING-12268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12268. - Resolution: Fixed Thanks for the contribution [~rliechti]! > Fix CVE-2022-47937 > -- > > Key: SLING-12268 > URL: https://issues.apache.org/jira/browse/SLING-12268 > Project: Sling > Issue Type: Bug > Components: Commons >Reporter: Remo Liechti >Assignee: Remo Liechti >Priority: Major > Fix For: Commons JSON 2.0.22 > > > Current version of apache commons json is affected by > [https://nvd.nist.gov/vuln/detail/CVE-2022-47937] > Due to the relicenced base library ([https://github.com/stleary/JSON-java)], > that now uses the 'public domain', the fix of that CVE is as simple as > migrating to the latest codebase of said library. > Along this, it would be beneficial to perform some side activities, such as > the upgrade to the latest parent pom and junit5. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12268) Fix CVE-2022-47937
[ https://issues.apache.org/jira/browse/SLING-12268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-12268: --- Assignee: Remo Liechti > Fix CVE-2022-47937 > -- > > Key: SLING-12268 > URL: https://issues.apache.org/jira/browse/SLING-12268 > Project: Sling > Issue Type: Bug > Components: Commons >Reporter: Remo Liechti >Assignee: Remo Liechti >Priority: Major > > Current version of apache commons json is affected by > [https://nvd.nist.gov/vuln/detail/CVE-2022-47937] > Due to the relicenced base library ([https://github.com/stleary/JSON-java)], > that now uses the 'public domain', the fix of that CVE is as simple as > migrating to the latest codebase of said library. > Along this, it would be beneficial to perform some side activities, such as > the upgrade to the latest parent pom and junit5. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [git] New git repository for retired module - sling-org-apache-sling-commons-json
On Tue, 2024-03-05 at 10:22 +0100, Robert Munteanu wrote: > Given no other comments came in, I will create the git repository as > already 'deprecated' and we'll figure out the release process > changes, > if needed, at the time of the potential release. > > I kicked off a `git svn clone` for commons.json since we don't have > it > mirrorred as part of > https://github.com/apache/sling-old-svn-mirror/tree/trunk . I hope it > will finish today. This was more fun than expected. The repository is at https://github.com/apache/sling-org-apache-sling-commons-json and it's already marked as deprecated. I was unable to create a git svn clone, so I extracted the code from https://github.com/apache/sling-old-svn-mirror/commits using the 'bundles/commons/json' path, before the move to attic. Thanks, Robert > > Thanks, > Robert > > On Thu, 2024-02-29 at 13:12 +0100, Robert Munteanu wrote: > > On Wed, 2024-02-28 at 11:22 +0100, Carsten Ziegeler wrote: > > > Can we do this without creating a new git repo? Creating a > > > separate > > > new > > > repo gives a different message than what we intend it to be. > > > > > > It would be great if we could do this directly in SVN :) > > > > I think that would be pretty complex; the SVN repo is read-only and > > we > > haven't done a release from SVN for years - not sure if the plug-in > > / > > SVN versions we used back then still work with the current Maven > > versions. > > > > I also am not very concerned about people misintepreting Sling git > > repo > > number 347 :-) But if we want to be extra careful, we could create > > it > > a > > and immediately deprecate it [1]. Any potential contributions would > > land in the 'maintenance' branch and any potential releases would > > be > > created from the same place. > > > > Robert > > > > [1]: > > https://sling.apache.org/documentation/development/deprecating-sling-modules.html > > > > > > > > Regards > > > Carsten > > > > > > On 28.02.2024 10:52, Robert Munteanu wrote: > > > > Hi Jörg > > > > > > > > On Tue, 2024-02-27 at 11:06 +0100, Jörg Hoh wrote: > > > > > Hi Robert, > > > > > > > > > > makes sense. > > > > > > > > > > To clarify: We just provide this final version of > > > > > commons.json > > > > > as > > > > > a > > > > > convenience for all users who are still depending on > > > > > commons.json; > > > > > but > > > > > there is no intention to continue development of commons.json > > > > > or > > > > > to > > > > > re-introducing this dependency again into other areas of > > > > > Sling. > > > > > > > > > > > > There is no intention to use this again in any other modules, > > > > add > > > > it to > > > > the Starter, etc. We will keep the code deprecated. At the same > > > > time, > > > > we may choose to apply fixes for the reported CVEs, if those > > > > are > > > > already available upstream, and cut a new release. > > > > > > > > Thanks, > > > > Robert > > > > > > > > > > > > > > Correct? > > > > > > > > > > Jörg > > > > > > > > > > > > > > > Am Mo., 26. Feb. 2024 um 16:30 Uhr schrieb Robert Munteanu < > > > > > romb...@apache.org>: > > > > > > > > > > > Hi, > > > > > > > > > > > > A long time ago we retired the commons.json module for > > > > > > legal > > > > > > reasons > > > > > > [1], leaving it only in the SVN attic [2]. > > > > > > > > > > > > After some time a CVE was reported against this module [3] > > > > > > which we > > > > > > could not fix as we could not release new versions. > > > > > > > > > > > > In the meantime, the JSON library we have been using has > > > > > > changed > > > > > > its > > > > > > license to 'Public domain', which makes it acceptable for > > > > > > use > > > > > > at > > > > > > the > > > > > > ASF. [4] > > > > > > > > > > > > I would like to create a GitHub repository for this module > > > > > > and > > > > > > include > > > > > > the current state from the attic. This opens up the way for > > > > > > creating a > > > > > > final service release, allowing consumers of this bundle > > > > > > that > > > > > > have > > > > > > not > > > > > > cleaned up their usages to use non-vulnerable versions. > > > > > > > > > > > > I will leave this thread open for comments for 72 hours. > > > > > > > > > > > > Thanks, > > > > > > Robert > > > > > > > > > > > > > > > > > > [1]: > > > > > > https://lists.apache.org/thread/p9rmd9dvgk04h36dtm6vn0bj6dkx0hkk > > > > > > [2]: > > > > > > https://svn.apache.org/repos/asf/sling/attic/commons.json/ > > > > > > [3]: https://www.cve.org/CVERecord?id=CVE-2022-47937 > > > > > > [4]: https://issues.apache.org/jira/browse/LEGAL-666 > > > > > > > > > > > > > > > > > > > > > > > > > >
[jira] [Commented] (SLING-12262) Repoinit: report failures via metrics
[ https://issues.apache.org/jira/browse/SLING-12262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824395#comment-17824395 ] Robert Munteanu commented on SLING-12262: - Right, I was just expecting that the window of opportunity when these metrics are available to be quite short, as the instance would be taken down. Not opposing the implementation, just asking :-) > Repoinit: report failures via metrics > - > > Key: SLING-12262 > URL: https://issues.apache.org/jira/browse/SLING-12262 > Project: Sling > Issue Type: Task > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.46 >Reporter: Joerg Hoh >Priority: Major > > When a repoinit statement fails (and for that reason the SlingRepository > service cannot be started, repoinit should expose this as a metric. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12262) Repoinit: report failures via metrics
[ https://issues.apache.org/jira/browse/SLING-12262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823664#comment-17823664 ] Robert Munteanu commented on SLING-12262: - With the repository being unavailable, is there any point to the metrics with regards to repoinit failure being exposed/scraped? The instance is presumably unhealthy and should not be around for long. > Repoinit: report failures via metrics > - > > Key: SLING-12262 > URL: https://issues.apache.org/jira/browse/SLING-12262 > Project: Sling > Issue Type: Task > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.46 >Reporter: Joerg Hoh >Priority: Major > > When a repoinit statement fails (and for that reason the SlingRepository > service cannot be started, repoinit should expose this as a metric. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [git] New git repository for retired module - sling-org-apache-sling-commons-json
Given no other comments came in, I will create the git repository as already 'deprecated' and we'll figure out the release process changes, if needed, at the time of the potential release. I kicked off a `git svn clone` for commons.json since we don't have it mirrorred as part of https://github.com/apache/sling-old-svn-mirror/tree/trunk . I hope it will finish today. Thanks, Robert On Thu, 2024-02-29 at 13:12 +0100, Robert Munteanu wrote: > On Wed, 2024-02-28 at 11:22 +0100, Carsten Ziegeler wrote: > > Can we do this without creating a new git repo? Creating a separate > > new > > repo gives a different message than what we intend it to be. > > > > It would be great if we could do this directly in SVN :) > > I think that would be pretty complex; the SVN repo is read-only and > we > haven't done a release from SVN for years - not sure if the plug-in / > SVN versions we used back then still work with the current Maven > versions. > > I also am not very concerned about people misintepreting Sling git > repo > number 347 :-) But if we want to be extra careful, we could create it > a > and immediately deprecate it [1]. Any potential contributions would > land in the 'maintenance' branch and any potential releases would be > created from the same place. > > Robert > > [1]: > https://sling.apache.org/documentation/development/deprecating-sling-modules.html > > > > > Regards > > Carsten > > > > On 28.02.2024 10:52, Robert Munteanu wrote: > > > Hi Jörg > > > > > > On Tue, 2024-02-27 at 11:06 +0100, Jörg Hoh wrote: > > > > Hi Robert, > > > > > > > > makes sense. > > > > > > > > To clarify: We just provide this final version of commons.json > > > > as > > > > a > > > > convenience for all users who are still depending on > > > > commons.json; > > > > but > > > > there is no intention to continue development of commons.json > > > > or > > > > to > > > > re-introducing this dependency again into other areas of Sling. > > > > > > > > > There is no intention to use this again in any other modules, add > > > it to > > > the Starter, etc. We will keep the code deprecated. At the same > > > time, > > > we may choose to apply fixes for the reported CVEs, if those are > > > already available upstream, and cut a new release. > > > > > > Thanks, > > > Robert > > > > > > > > > > > Correct? > > > > > > > > Jörg > > > > > > > > > > > > Am Mo., 26. Feb. 2024 um 16:30 Uhr schrieb Robert Munteanu < > > > > romb...@apache.org>: > > > > > > > > > Hi, > > > > > > > > > > A long time ago we retired the commons.json module for legal > > > > > reasons > > > > > [1], leaving it only in the SVN attic [2]. > > > > > > > > > > After some time a CVE was reported against this module [3] > > > > > which we > > > > > could not fix as we could not release new versions. > > > > > > > > > > In the meantime, the JSON library we have been using has > > > > > changed > > > > > its > > > > > license to 'Public domain', which makes it acceptable for use > > > > > at > > > > > the > > > > > ASF. [4] > > > > > > > > > > I would like to create a GitHub repository for this module > > > > > and > > > > > include > > > > > the current state from the attic. This opens up the way for > > > > > creating a > > > > > final service release, allowing consumers of this bundle that > > > > > have > > > > > not > > > > > cleaned up their usages to use non-vulnerable versions. > > > > > > > > > > I will leave this thread open for comments for 72 hours. > > > > > > > > > > Thanks, > > > > > Robert > > > > > > > > > > > > > > > [1]: > > > > > https://lists.apache.org/thread/p9rmd9dvgk04h36dtm6vn0bj6dkx0hkk > > > > > [2]: > > > > > https://svn.apache.org/repos/asf/sling/attic/commons.json/ > > > > > [3]: https://www.cve.org/CVERecord?id=CVE-2022-47937 > > > > > [4]: https://issues.apache.org/jira/browse/LEGAL-666 > > > > > > > > > > > > > > > > > > >
[jira] [Closed] (SLING-12113) CPConverter: Improve error message "File being unzipped is too big" for Sling-Initial-Content
[
https://issues.apache.org/jira/browse/SLING-12113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-12113.
---
> CPConverter: Improve error message "File being unzipped is too big" for
> Sling-Initial-Content
> -
>
> Key: SLING-12113
> URL: https://issues.apache.org/jira/browse/SLING-12113
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model
>Affects Versions: Content-Package to Feature Model Converter 1.3.4
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.6
>
>
> if you use an OSGi bundle with Sling-Initial-Content, and the size of the
> unzipped content exceeds 100MB, currently an error messages without any
> context (out of a complex build) is issued:
> {noformat}
> Caused by: java.lang.IllegalStateException: File being unzipped is too big.
> at
> org.apache.sling.feature.cpconverter.handlers.slinginitialcontent.SlingInitialContentBundleEntryMetaDataCollector.collectFromContextAndWriteTmpFiles
> (SlingInitialContentBundleEntryMetaDataCollector.java:105)
> at
> org.apache.sling.feature.cpconverter.handlers.slinginitialcontent.BundleSlingInitialContentExtractor.extract
> (BundleSlingInitialContentExtractor.java:80)
> at
> org.apache.sling.feature.cpconverter.handlers.SlingInitialContentBundleHandler.processBundleInputStream
> (SlingInitialContentBundleHandler.java:53)
> at
> org.apache.sling.feature.cpconverter.handlers.BundleEntryHandler.handle
> (BundleEntryHandler.java:141)
> ...
> {noformat}
> this error messages should be improved to include the actual file name, and
> the actual limit that was hit (it's hard-coded 100MB in this case).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-12254) jcr:data node missing for file resources generated in binaries index defintions
[
https://issues.apache.org/jira/browse/SLING-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-12254.
---
> jcr:data node missing for file resources generated in binaries index
> defintions
> ---
>
> Key: SLING-12254
> URL: https://issues.apache.org/jira/browse/SLING-12254
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.4
>Reporter: Abhishek Garg
>Assignee: Abhishek Garg
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.6
>
>
> The index definition files generated by the cpcconvertor are missing
> mandatory jcr:data nodes.
> How the resource should look:
> {code:java}
> "tika": {
> "jcr:primaryType": "nam:nt:unstructured",
> "config.xml": {
> "jcr:primaryType": "nam:nt:file",
> "jcr:content": {
> "jcr:primaryType": "nam:nt:unstructured",
> "jcr:mimeType": "text/xml"
> }
> }
> }
> {code}
>
> How it looks like now:
> {code:java}
> "tika": {
> "jcr:primaryType": "nam:nt:unstructured",
> "config.xml": {
> "jcr:primaryType": "nam:nt:file",
>
> "jcr:content": {
> "jcr:primaryType": "nam:nt:unstructured",
> "jcr:mimeType": "text/xml",
> "jcr:data": ""
> }
> }
> } {code}
> There is no `jcr:data` node present
> This happens when node structure is like:
> {code:java}
>
>
> jcr:primaryType="nt:unstructured"
> jcr:mimeType="text/xml"/>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
