Re: New taglib v1.10

(Resending because of my failure to “reply all”) Hi, This has been fixed in Amarok master: https://quickgit.kde.org/?p=amarok.git&a=commit&h=fec8817c530ce42b6485fdabff6051784b8d9904 Cheers, Konrad > O

Re: New taglib v1.10

Hi, This has been fixed in Amarok master: https://quickgit.kde.org/?p=amarok.git&a=commit&h=fec8817c530ce42b6485fdabff6051784b8d9904 Cheers, Konrad > On 16 Apr 2016, at 19:18, Michael Palimaka wrote:

Re: Review Request 124639: Build script incorrectly detects Taglib version 1.10.0 as lower than 1.7

> On Aug. 6, 2015, 9:59 a.m., Konrad Zemek wrote: > > Actually, there is a bug here. We require at least TagLib 1.7, but after > > your commit that will change to 1.7.1 . `taglib-config --version` returns > > `1.7.0` for TagLib 1.7, and while `"1.7"

Re: Review Request 124639: Build script incorrectly detects Taglib version 1.10.0 as lower than 1.7

> On Aug. 6, 2015, 9:59 a.m., Konrad Zemek wrote: > > Actually, there is a bug here. We require at least TagLib 1.7, but after > > your commit that will change to 1.7.1 . `taglib-config --version` returns > > `1.7.0` for TagLib 1.7, and while `"1.7"

Re: Review Request 124639: Build script incorrectly detects Taglib version 1.10.0 as lower than 1.7

, but after your commit that will change to 1.7.1 . `taglib-config --version` returns `1.7.0` for TagLib 1.7, and while `"1.7" STRLESS "1.7.0"` is true, `"1.7" VERSION_LESS "1.7.0"` is false. - Konrad Zemek On Aug.

Re: Review Request 124639: Build script incorrectly detects Taglib version 1.10.0 as lower than 1.7

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124639/#review83479 --- Ship it! Ship It! - Konrad Zemek On Aug. 6, 2015, 12:57

Re: Review Request 121564: Add git submodules referencing gtest and gmock.

824 Diff: https://git.reviewboard.kde.org/r/121564/diff/ Testing --- Compilation with and without testing enabled, with and without git available. Release build done with help of releaseme.git:amarok2.rb script. Thanks, Konrad Zemek ___ Am

Re: Review Request 121564: Add git submodules referencing gtest and gmock.

eLists.txt 9f0a5ddbcb0318b2f348fed2e0a15e726834e332 Diff: https://git.reviewboard.kde.org/r/121564/diff/ Testing --- Compilation with and without testing enabled, with and without git available. Release build done with help of releaseme.git:amarok2.rb script. Thanks, Ko

Review Request 121565: Fetch git submodules before Amarok2 release.

--- Runs `git submodule update --init` in the Amarok's source tree and removes git-related files from gmock and gtest repos. Diffs - amarok2.rb e2be25e Diff: https://git.reviewboard.kde.org/r/121565/diff/ Testing --- Created a release and verified its contents. Thanks, Konrad

Review Request 121564: Add git submodules referencing gtest and gmock.

iff: https://git.reviewboard.kde.org/r/121564/diff/ Testing --- Compilation with and without testing enabled, with and without git available. Release build done with help of releaseme.git:amarok2.rb script. Thanks, Konrad Zemek ___ Amarok-dev

Re: Fetching googlemock

2014-12-14 16:07 GMT+01:00 Matěj Laitl : > On 14. 12. 2014 Konrad Zemek wrote: >> Matěj Laitl wrote: >> > How big is tarballed gtest + gmock? Can we just embed them in our release >> > tarballs? Else we can create something like >> > amarok-testlibs-$version.

Re: Fetching googlemock

2014-12-14 13:38 GMT+01:00 Matěj Laitl : > On 14. 12. 2014 Konrad Zemek wrote: >> >> Git submodule approach looks promising, however I have some concerns: >> >> a) this makes test depend on 'your' github repositories; we cannot >> >> guarantee the

Re: Fetching googlemock

Hey, 2014-12-14 13:02 GMT+01:00 Myriam Schweingruber : > Hi all, > > > On Sat, Dec 13, 2014 at 11:07 PM, Matěj Laitl wrote: >> >> On 13. 12. 2014 Konrad Zemek wrote: >> > gmock sources are still not packaged by distributions, and compiling >> > Amarok w

Fetching googlemock

Hey everyone, gmock sources are still not packaged by distributions, and compiling Amarok with tests on is still troublesome (I still use a cmake-gui based approach where I manually set paths to my pre-compiled gmock lib, as I outlined in an email some months ago). I solved the problem through th

Re: [GUI] When do notifications make sense?

Thomas, Celeste, 2014-05-29 21:45 GMT+02:00 Celeste Lyn Paul : > Thomas, > > I agree with your recommendation that a track change notification should not > be shown when the control (Amarok, Media player popup) is the current focus > of the user and the user clicks the track change button. In my n

Re: GMock

Hey, Sorry, I'm really busy lately. On 27.02.2014 18:43, Anmol Ahuja wrote: I'm having trouble getting gmock to build. Could you please update the wiki with instructions on how you got it to work? I don't think this belongs to the wiki as it's basically a workaround/hack. 1. Fetch and com

Re: Review Request 113272: GSoC 2013 - Advanced Importers - 1/4: Changes in StatSyncing framework

://git.reviewboard.kde.org/r/113272/diff/ Testing --- Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 113277: GSoC 2013 - Advanced Importers - 3/4: Tests for importers framework and concrete importers

le.mp3 PRE-CREATION tests/importers/files/testcollection/yearUnset.mp3 PRE-CREATION tests/mocks/MetaMock.h 37a50ce Diff: https://git.reviewboard.kde.org/r/113277/diff/ Testing --- Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-dev

Re: Review Request 113275: GSoC 2013 - Advanced Importers - 2/4: Importers framework and concrete importers

/RhythmboxProvider.cpp PRE-CREATION src/importers/rhythmbox/RhythmboxTrack.h PRE-CREATION src/importers/rhythmbox/RhythmboxTrack.cpp PRE-CREATION src/importers/rhythmbox/amarok_importer-rhythmbox.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/113275/diff/ Testing --- Thanks, Konrad

Re: Review Request 113278: GSoC 2013 - Advanced Importers - 4/4: Other changes in the repository

183c3c2 tests/mocks/MetaMock.h 37a50ce Diff: https://git.reviewboard.kde.org/r/113278/diff/ Testing --- Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 113278: GSoC 2013 - Advanced Importers - 4/4: Other changes in the repository

ot; - Konrad --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113278/#review43694 --- On Dec. 10, 2013, 9:32 p.m., Konrad Zemek wrote:

Re: Review Request 113278: GSoC 2013 - Advanced Importers - 4/4: Other changes in the repository

://git.reviewboard.kde.org/r/113278/diff/ Testing --- Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 113278: GSoC 2013 - Advanced Importers - 4/4: Other changes in the repository

ack.h d6fb593 src/services/lastfm/SynchronizationTrack.cpp 39c51d4 tests/CMakeLists.txt e18aaa1 tests/CollectionTestImpl.h 183c3c2 tests/mocks/MetaMock.h 37a50ce Diff: http://git.reviewboard.kde.org/r/113278/diff/ Testing --- Thanks, Konrad

Re: Review Request 113277: GSoC 2013 - Advanced Importers - 3/4: Tests for importers framework and concrete importers

nerated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113277/#review43696 --- On Dec. 10, 2013, 9:14 p.m., Konrad Zemek wrote: > > --- > This is an automatically gene

Re: Review Request 113277: GSoC 2013 - Advanced Importers - 3/4: Tests for importers framework and concrete importers

collection/yearUnset.mp3 PRE-CREATION tests/mocks/MetaMock.h 37a50ce Diff: http://git.reviewboard.kde.org/r/113277/diff/ Testing --- Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 113272: GSoC 2013 - Advanced Importers - 1/4: Changes in StatSyncing framework

--- Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 113278: GSoC 2013 - Advanced Importers - 4/4: Other changes in the repository

/CMakeLists.txt e18aaa1 tests/CollectionTestImpl.h 183c3c2 tests/mocks/MetaMock.h 37a50ce Diff: http://git.reviewboard.kde.org/r/113278/diff/ Testing --- Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https

Re: Review Request 113275: GSoC 2013 - Advanced Importers - 2/4: Importers framework and concrete importers

-CREATION src/importers/rhythmbox/RhythmboxTrack.h PRE-CREATION src/importers/rhythmbox/RhythmboxTrack.cpp PRE-CREATION src/importers/rhythmbox/amarok_importer-rhythmbox.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113275/diff/ Testing --- Thanks, Konrad Zemek

Re: Review Request 113277: GSoC 2013 - Advanced Importers - 3/4: Tests for importers framework and concrete importers

Diff: http://git.reviewboard.kde.org/r/113277/diff/ Testing --- Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 113272: GSoC 2013 - Advanced Importers - 1/4: Changes in StatSyncing framework

mail. To reply, visit: http://git.reviewboard.kde.org/r/113272/#review43128 ------- On Nov. 6, 2013, 7:19 p.m., Konrad Zemek wrote: > > --- > This is an automa

Re: Review Request 113272: GSoC 2013 - Advanced Importers - 1/4: Changes in StatSyncing framework

://git.reviewboard.kde.org/r/113272/diff/ Testing --- Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 113277: GSoC 2013 - Advanced Importers - 3/4: Tests for importers framework and concrete importers

- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113277/#review41889 ------- On Oct. 21, 2013, 4:37 p.m., Konrad Zemek wrote: > > -

Re: Review Request 113278: GSoC 2013 - Advanced Importers - 4/4: Other changes in the repository

src/core/support/PluginFactory.h 8acd354 Diff: http://git.reviewboard.kde.org/r/113278/diff/ Testing --- Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 113272: GSoC 2013 - Advanced Importers - 1/4: Changes in StatSyncing framework

> > > > Hmm, do you subclass Controller? Or why the need to make these virtual? I mock Controller in tests. > On Oct. 18, 2013, 10 a.m., Matěj Laitl wrote: > > src/statsyncing/Provider.cpp, line 21 > > <http://git.reviewboard.kde.org/r/113272/diff/1/?file=201964#

Re: Review Request 113277: GSoC 2013 - Advanced Importers - 3/4: Tests for importers framework and concrete importers

ready for the common tests. Diffs (updated) - tests/importers/ImporterMocks.h PRE-CREATION tests/importers/TestImporterManager.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113277/diff/ Testing --- Thanks, Konrad Zemek

Re: Review Request 113275: GSoC 2013 - Advanced Importers - 2/4: Importers framework and concrete importers

--- Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 113272: GSoC 2013 - Advanced Importers - 1/4: Changes in StatSyncing framework

, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request 113278: GSoC 2013 - Advanced Importers - 4/4: Other changes in the repository

/ Testing --- Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request 113277: GSoC 2013 - Advanced Importers - 3/4: Tests for importers framework and concrete importers

N tests/importers/files/testcollection/utfComposer.mp3 PRE-CREATION tests/importers/files/testcollection/utfTitle.mp3 PRE-CREATION tests/importers/files/testcollection/yearUnset.mp3 PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113277/diff/ Testing --- Thanks, Ko

Review Request 113275: GSoC 2013 - Advanced Importers - 2/4: Importers framework and concrete importers

/rhythmbox/RhythmboxTrack.cpp PRE-CREATION src/importers/rhythmbox/amarok_importer-rhythmbox.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113275/diff/ Testing --- Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel

Review Request 113272: GSoC 2013 - Advanced Importers - 1/4: Changes in StatSyncing framework

b789aa32314b345270c07b34823e82b2a74ed6dd Diff: http://git.reviewboard.kde.org/r/113272/diff/ Testing --- Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Acquiring Google Mock libraries for tests

On 02.10.2013 00:41, Sebastian Kügler wrote: I was having a hard time searching for examples of Google Mock usage on projects.kde.org, so my question is: how do other KDE projects deal with acquiring Google Mock? What is Google Mock and what's the deal about it? Your email describe a concrete is

Acquiring Google Mock libraries for tests

Hey, Recent changes of Google Mock package in Kubuntu (precompiled libraries are no longer shipped) have sparked a discussion on amarok-devel mailing list [1] on how should we proceed without readily available libraries to link to. Simply compiling sources from distro-provided package is not a

Re: Changes in GMock

1 paź 2013 13:22 "Matěj Laitl" napisał(a): > > On 1. 10. 2013 Konrad Zemek wrote: > > The way I see it, possible solutions are: > > > > * go the way of Mir: find sources installed by Kubuntu's package in > > "FindGmock.cmake" (in Mir it&#x

Re: Changes in GMock

2013/10/1 Mark Kretschmann : > > While this is a convenient solution, distro packagers generally frown > on bundling libraries with applications. With "frown" I mean the > package won't be accepted at all if they learn about it. (For security > reasons mostly, and generally because it's a packager'

Re: Changes in GMock

Hey, 2013/10/1 Mark Kretschmann > > So essentially GMock is no longer provided as a binary package, but > instead it has to be compiled from source. While that's not an > insurmountable problem, I think it would be beneficial to discuss it. > Also because we could still influence the packaging to

Re: Added support for Visualizations using VSXu

On 15.09.2013 14:15, Konrad Zemek wrote: On 12.09.2013 19:14, Dinesh wrote: Hey Konrad, We have merged the Amarok Fixes branch into VSXu master. And the patch for the problem with the FindVSXu.cmake is in VSXu master now. (It was a broken libvsxu.pc file). As for the blank visualizer

Re: Added support for Visualizations using VSXu

On 12.09.2013 19:14, Dinesh wrote: Hey Konrad, We have merged the Amarok Fixes branch into VSXu master. And the patch for the problem with the FindVSXu.cmake is in VSXu master now. (It was a broken libvsxu.pc file). As for the blank visualizer applet, I still cannot reproduce the problem o

Re: Added support for Visualizations using VSXu

On 11.09.2013 13:34, Mark Kretschmann wrote: On Tue, Sep 10, 2013 at 7:50 PM, Konrad Zemek wrote: On 10.09.2013 13:22, Mark Kretschmann wrote: On Sun, Sep 8, 2013 at 9:04 PM, Dinesh wrote: Hi Folks, Finally done adding support for Visualizations using VSXu.(!!!) In order to test this out

Re: Added support for Visualizations using VSXu

On 10.09.2013 13:22, Mark Kretschmann wrote: On Sun, Sep 8, 2013 at 9:04 PM, Dinesh wrote: Hi Folks, Finally done adding support for Visualizations using VSXu.(!!!) In order to test this out, first install a patched version of VSXu from the branch amarok-fixes from: https://github.com/vovoid/

Re: Review Request 109369: Bug #254404: Copy files to USB storage devices in display order by sorting tracks in CollectionLocation.cpp

> On Aug. 25, 2013, 8:49 a.m., Mark Kretschmann wrote: > > What's the current status of this patch? > > Matěj Laitl wrote: > Well, the question is whether we want such big complication of code for > little gain. I fear that not, at not least in the current for of the patch. > I'd be also a

Re: Review Request 111991: Better handling of non-writeable UMS collections

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111991/#review37509 --- Ship it! Ship It! - Konrad Zemek On Aug. 11, 2013, 11:17

Re: Review Request 111991: Better handling of non-writeable UMS collections

> On Aug. 10, 2013, 7:26 p.m., Mark Kretschmann wrote: > > I'm not so sure about the warning that is shown when an unwritable UMS > > collection is loaded. First of all it seems to me this would belong on a > > higher level, as other collections could be read-only as well. Second, I'm > > not

Re: Review Request 111804: Fix a crash on startup

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111804/#review36868 --- Ship it! Ship It! - Konrad Zemek On July 31, 2013, 11:59

Re: Review Request 111804: Fix a crash on startup

ttp://git.reviewboard.kde.org/r/111804/#comment27190> This "if" needs to be an "else if", otherwise a warning will be issued for invalid level, and then Amarok will crash regardless. - Konrad Zemek On July 31, 2013, 9:47

Re: Review Request 111804: Fix a crash on startup

> On July 31, 2013, 1:14 a.m., Konrad Zemek wrote: > > src/playlist/PlaylistSortWidget.cpp, line 73 > > <http://git.reviewboard.kde.org/r/111804/diff/1/?file=175527#file175527line73> > > > > There will still be a crash if the sort level is saved as, say, >

Re: Review Request 111804: Fix a crash on startup

> On July 30, 2013, 10:04 p.m., Edward Hades Toroshchin wrote: > > src/playlist/PlaylistSortWidget.cpp, line 73 > > > > > > If the sort token has neither "asc" nor "des" suffix, it won't be added > > to the sort a

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

6d1f3c6d src/context/widgets/RecentlyPlayedListWidget.cpp 6ea501affcf6e61d237002e15f7ed4e26989b91b Diff: http://git.reviewboard.kde.org/r/111655/diff/ Testing --- Manual. Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

c6d src/context/widgets/RecentlyPlayedListWidget.cpp 6ea501affcf6e61d237002e15f7ed4e26989b91b Diff: http://git.reviewboard.kde.org/r/111655/diff/ Testing --- Manual. Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

94b06 src/context/widgets/RecentlyPlayedListWidget.h caa78039b891511ca36ada8f61cd4f776d1f3c6d src/context/widgets/RecentlyPlayedListWidget.cpp 6ea501affcf6e61d237002e15f7ed4e26989b91b Diff: http://git.reviewboard.kde.org/r/111655/diff/ Testing --- Manual. Thanks, Konrad Zemek

Re: Review Request 110187: Don't communicate with mysql by env vars and autogenerated files

/MySqlEmbeddedStorage.cpp <http://git.reviewboard.kde.org/r/110187/#comment26927> The defaultsFile variable is not used anymore, so this line and defaultsFile instantiation should both probably be removed. - Konrad Zemek On July 19, 2013, 8:35 a.m., Patrick von Reth

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

6330e7a612db59052a50eef053294b06 src/context/widgets/RecentlyPlayedListWidget.h caa78039b891511ca36ada8f61cd4f776d1f3c6d src/context/widgets/RecentlyPlayedListWidget.cpp 6ea501affcf6e61d237002e15f7ed4e26989b91b Diff: http://git.reviewboard.kde.org/r/111655/d

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

b891511ca36ada8f61cd4f776d1f3c6d src/context/widgets/RecentlyPlayedListWidget.cpp 6ea501affcf6e61d237002e15f7ed4e26989b91b Diff: http://git.reviewboard.kde.org/r/111655/diff/ Testing --- Manual. Thanks, Konrad Zemek ___ Amarok-devel mailing

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

c6d src/context/widgets/RecentlyPlayedListWidget.cpp 6ea501affcf6e61d237002e15f7ed4e26989b91b Diff: http://git.reviewboard.kde.org/r/111655/diff/ Testing --- Manual. Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

as it also gets rid of the .moc file include. - Konrad --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/#review36412 --------

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

tWidget.cpp 6ea501affcf6e61d237002e15f7ed4e26989b91b src/playlist/PlaylistController.cpp 60c99e5a10459b84b9839f07aad0d1e2bfa5d259 Diff: http://git.reviewboard.kde.org/r/111655/diff/ Testing --- Manual. Thanks, Konrad Zemek ___ Amarok-devel ma

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

caa78039b891511ca36ada8f61cd4f776d1f3c6d src/context/widgets/RecentlyPlayedListWidget.cpp 6ea501affcf6e61d237002e15f7ed4e26989b91b Diff: http://git.reviewboard.kde.org/r/111655/diff/ Testing --- Manual. Thanks, Konrad Zemek ___ Amarok-dev

Review Request 111655: Reimplement RecentlyPlayedListWidget

6ea501affcf6e61d237002e15f7ed4e26989b91b Diff: http://git.reviewboard.kde.org/r/111655/diff/ Testing --- Manual. Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Missing QStringList includes

On 09.07.2013 17:46, Mark Kretschmann wrote: Heya, here's a mystery: Every other day some user comes with a compile error. The error is always about a missing QStringList include in an Amarok header file. The weird part is, as I keep fixing those, it works for User A, but the next day User B com

Week 2 report. Reimplementing importers.

Hey everyone, For the past week I had scheduled "implementing the initial test suite for importers", and I'm happy to report that everything went smoothly. Here's a shortlog of commits for the past week (from the most recent): * Implement FastForwardImporter tests: TestFastForwardImporter. *

Week 1 report. Reimplementing importers.

Hey, I'm in the middle of final exams, and I took it into account when writing my proposal: what I had scheduled for the first week was "Drafting up test cases for FastForward and iTunes importers." The short version is: the tests are drafted, and the effects will be visible after this week (

Re: [amarok] /: Cleaned up playlist multilevel sorting algorithm. Added album artist special case to playlist sorting.

22 cze 2013 21:07, "Matěj Laitl" napisał(a): > > On 20. 6. 2013 Myriam Schweingruber wrote: > > On Sat, Apr 27, 2013 at 11:11 AM, Matěj Laitl wrote: > > > Git commit 583158f4c4d25098aa1f0bb6b683813488580d52 by Matěj Laitl, on > > > behalf of Konrad

Re: [amarok] /: Make playlist-related actions consistent throughout Amarok code (behaviour change)

On 15.06.2013 22:37, Wyatt Epp wrote: On Sat, Jun 15, 2013 at 9:28 AM, Matěj Laitl wrote: On 15. 6. 2013 Myriam Schweingruber wrote: * When using a double click I want a track to be added to the playlists, but it should not start automatically, as this causes every track I add to start automat

Re: Splash Screen

2013/6/13 Mark Kretschmann : > Heya, > > it appears that the splash screen is no longer working. Noone seems to > have noticed except for Myriam, who noticed it by coincidence. As I > was about to start debugging this, I was asking myself if we shouldn't > remove it entirely. Splash screens are a b

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

GUI tested manually. Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

;normal" sorting > > items correctly reset the Album sorting) > > Konrad Zemek wrote: > Actually, this is not a bug; that's how I designed it. > > This is my very use-case: I have my playlist sorted by album at all > times, yet I like to shuffle track

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

xymodels/SortScheme.cpp > d29f9dec6b1c2ae555146853782819328ae192f0 > tests/playlist/TestPlaylistModels.h > 3751e6a2c3d56be1a6abcea742eec088e2a1123b > tests/playlist/TestPlaylistModels.cpp > ec8adb8f2c5bbb141f291989499e361d5a73381d > > Diff: http://git.reviewboard.kde.o

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

9328ae192f0 tests/playlist/TestPlaylistModels.h 3751e6a2c3d56be1a6abcea742eec088e2a1123b tests/playlist/TestPlaylistModels.cpp ec8adb8f2c5bbb141f291989499e361d5a73381d Diff: http://git.reviewboard.kde.org/r/110658/diff/ Testing --- Test added for the shuffle action. GUI tested manuall

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

ttp://git.reviewboard.kde.org/r/110658/#comment24664> I have no idea how did those changes end in my review. I guess I'm not yet skilled enough with post-review tool. - Konrad Zemek On May 28, 2013, 9:01 p.m., Konrad Zemek wrote: > > ---

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110658/#review33315 --- On May 27, 2013, 6:21 p.m., Konrad Zemek wrote: &g

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

TestPlaylistModels.h 3751e6a2c3d56be1a6abcea742eec088e2a1123b tests/playlist/TestPlaylistModels.cpp ec8adb8f2c5bbb141f291989499e361d5a73381d Diff: http://git.reviewboard.kde.org/r/110658/diff/ Testing --- Test added for the shuffle action. GUI tested manually. T

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

s surprisingly tricky, since the rightmost arrow is a separate entity from other elements (that's why 'Shuffle' was displayed only under this arrow). - Konrad --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110658/#review33227 ---

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

nd. - Konrad --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110658/#review33227 --- On May 27, 2013, 6:04 p.m.,

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

1989499e361d5a73381d Diff: http://git.reviewboard.kde.org/r/110658/diff/ Testing --- Test added for the shuffle action. GUI tested manually. Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

dded for the shuffle action. GUI tested manually. Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

GSoC application: Reimplement Amarok importers on top of StatSyncing framework, add Amarok 2.x and Rhythmbox as synchronization targets.

link: http://mail.kde.org/pipermail/amarok-devel/2013-April/011946.html (also listed as reference 7 in the application). *Name:* Konrad Zemek *Email Address:* konrad.ze...@gmail.com *Freenode IRC Nick:* kzemek *IM Servic

Re: GSoC application review - reimplementing personal metadata importers

On 01.05.2013 08:52, Matěj Laitl wrote: On 1. 5. 2013 Konrad Zemek wrote: Amarok 2.x importer should support importing data from both a full mysql server and mysql-embedded file. To make reading from both sources simpler, existing MySqlStorage and MySqlEmbeddedStorage classes will be used. The

Re: GSoC application review - reimplementing personal metadata importers

On 01.05.2013 00:42, Matěj Laitl wrote: My bet that support code for actually using SqlCollection would be much heavier than implementing the A 2.x importer without it. Technical reasons not to use SqlCollection: 1. you'll be instantiating the beast just to use 2% of its functionality. SqlColl

Re: GSoC application review - reimplementing personal metadata importers

On 30.04.2013 23:12, Matěj Laitl wrote: On 30. 4. 2013 Konrad Zemek wrote: Amarok 2.x importer should support importing data from both a full mysql server and mysql-embedded file. To ensure that metadata from current version of Amarok can always be synchronized, Collections::SqlCollection class

Re: GSoC application review - reimplementing personal metadata importers

Thank you for your tireless work! I outlined the changes below. I'm not posting the whole proposal this time since only two points were added in the text. On 29.04.2013 23:12, Matěj Laitl wrote Some more things to iron out about StatSyncing::Amarok2Provider: * would you support both a) conne

Re: GSoC application review - reimplementing personal metadata importers

lication deadline and the "coding start" date. So below is the current incarnation of my proposal. I hope you'll forgive me HTML - I'm pasting it exactly as it is on Google Melange. I tried to keep as basic as possible, while still being correct and nicely formatted. *Name:*

Re: GSoC application review - reimplementing personal metadata importers

On 29.04.2013 00:58, Matěj Laitl wrote: On 24. 4. 2013 Konrad Zemek wrote: September 09 - 15: Implementing two-way synchronization for remaining importers. September 16 - 22: Ironing out bugs, writing remaining tests. Cushion period in case of delays

Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

hy) this is not necessarily an universal approach, though. - Konrad --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110139/#review31543 -------

Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

. Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: GSoC application review - reimplementing personal metadata importers

On 25.04.2013 12:34, Matěj Laitl wrote: Oh, nice! Do mention it. I may be stating the obvious, but I felt it needs to be said: Please note that "ideal" code for a typical FLOSS project may be very different from "ideal" code for a programming contest. In Amarok, we try to keep code as simple (t

Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

ify it to list enums explicitly. :-) - Konrad --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110139/#review31541 ------- On

Re: GSoC application review - reimplementing personal metadata importers

didn't add that before, but that's the highlight of my career so far; it is quite an important contest in Poland. Please let me know if you feel something is off, and again - many thanks for your help! Cheers, Matěj Konrad Name: Konrad Zemek Email Address: konrad.ze..

Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

all relevant enum values, so default: break tells the compiler that we're sure nothing else should be handled. - Konrad --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/11

Re: GSoC application review - reimplementing personal metadata importers

On 22.04.2013 14:56, Matěj Laitl wrote: On 21. 4. 2013 Konrad Zemek wrote: 2013/4/20 Matěj Laitl : On 20. 4. 2013 Konrad Zemek wrote: I think there are no importer tests, please check it and then be more certain in the proposal. I did actually check that, but the lack of tests is a bit

Review Request 110139: Small bugfixes. Fixes clang warnings.

src/dialogs/EditFilterDialog.cpp ac26497dcc5e5cf7cb9e2ea1a821dbce83276d34 Diff: http://git.reviewboard.kde.org/r/110139/diff/ Testing --- Changed lines no longer generate warnings. Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-

  1   2   >