Re: [asterisk-dev] [Code Review] 4588: IAX make calltoken expiration time configurable

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4588/#review15152 --- Ship it! Other than having this get documented in the CHANGES

Re: [asterisk-dev] [Code Review] 4587: pjsip_options: Add qualify_timeout processing and eventing

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4587/#review15151 --- branches/13/configs/samples/pjsip.conf.sample

[asterisk-dev] Change in testsuite[master]: Testsuite: Caller callee initiated local attended transfer...

Matt Jordan has posted comments on this change. Change subject: Testsuite: Caller callee initiated local attended transfers to application. .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/34 To

Re: [asterisk-dev] [Code Review] 4391: Add blank line between headers and output for Command action response

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4391/#review15168 --- /trunk/main/cli.c

[asterisk-dev] Change in testsuite[master]: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk.

Matt Jordan has posted comments on this change. Change subject: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk. .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/35 To unsubscribe,

[asterisk-dev] Change in testsuite[master]: pjsip: Add test for OPTIONS requests received in-dialog.

Joshua Colp has uploaded a new change for review. https://gerrit.asterisk.org/37 Change subject: pjsip: Add test for OPTIONS requests received in-dialog. .. pjsip: Add test for OPTIONS requests received in-dialog. This test

[asterisk-dev] Change in testsuite[master]: rest_api/applications/stasisstatus: Make run-test executable

Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/36 Change subject: rest_api/applications/stasisstatus: Make run-test executable .. rest_api/applications/stasisstatus: Make run-test executable If

Re: [asterisk-dev] [Code Review] 4604: loader/main: Don't set ast_fully_booted until deferred reloads are processed

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4604/#review15153 --- Ship it! Ship It! - Mark Michelson On April 9, 2015, 2:57

Re: [asterisk-dev] [Code Review] 4608: res_pjsip_phoneprov_provider: Fix reference leak on unload

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4608/ --- (Updated April 9, 2015, 1:57 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4391: Add blank line between headers and output for Command action response

On April 3, 2015, 5:37 a.m., Corey Farrell wrote: /trunk/main/manager.c, line 4873 https://reviewboard.asterisk.org/r/4391/diff/3/?file=72904#file72904line4873 If we successfully ran the command, it seems unsafe to claim failure. We have to assume the the caller doesn't actually

Re: [asterisk-dev] [Code Review] 4550: clang compiler warning: --dev-mode and -Wparentheses-equality

On March 31, 2015, 7:14 p.m., Mark Michelson wrote: I don't understand the purpose of this warning. I tried searching for details about this warning flag on the internet and came up empty, so I can't find any documentation that explains what type of error this check is supposed to

Re: [asterisk-dev] [Code Review] 4604: loader/main: Don't set ast_fully_booted until deferred reloads are processed

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4604/#review15146 --- branches/13/main/loader.c

[asterisk-dev] Change in testsuite[master]: Testsuite: Caller callee initiated local attended transfer...

John Bigelow has uploaded a new patch set (#2). Change subject: Testsuite: Caller callee initiated local attended transfers to application. .. Testsuite: Caller callee initiated local attended transfers to application. This

Re: [asterisk-dev] [Code Review] 4391: Add blank line between headers and output for Command action response

On April 3, 2015, 6:37 a.m., Corey Farrell wrote: /trunk/main/manager.c, line 4873 https://reviewboard.asterisk.org/r/4391/diff/3/?file=72904#file72904line4873 If we successfully ran the command, it seems unsafe to claim failure. We have to assume the the caller doesn't actually

Re: [asterisk-dev] [Code Review] 4499: Support in dialog OPTIONS

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4499/ --- (Updated April 9, 2015, 10:44 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4596: res_pjsip_phoneprov_provider: Fix leaked OBJ_MULTIPLE iterator (2nd try)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4596/ --- (Updated April 9, 2015, 11:52 a.m.) Status -- This change has been

[asterisk-dev] Change in testsuite[master]: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk.

Matt Jordan has posted comments on this change. Change subject: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk. .. Patch Set 2: (1 comment)

Re: [asterisk-dev] [Code Review] 4606: chan_sip: make progressinband default to no

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4606/#review15160 --- Ship it! Ship It! - Joshua Colp On April 9, 2015, 5:05

[asterisk-dev] [Code Review] 4609: chan_pjsip/res_pjsip/bridge_softmix/core: Improve translation path choices.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4609/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24841

[asterisk-dev] [Code Review] 4608: res_pjsip_phoneprov_provider: Fix reference leak on unload

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4608/ --- Review request for Asterisk Developers and Corey Farrell. Bugs:

[asterisk-dev] Change in testsuite[master]: rest_api/applications/stasisstatus: Make run-test executable

Mark Michelson has posted comments on this change. Change subject: rest_api/applications/stasisstatus: Make run-test executable .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/36 To

[asterisk-dev] Change in testsuite[master]: rest_api/applications/stasisstatus: Make run-test executable

Ashley Sanders has posted comments on this change. Change subject: rest_api/applications/stasisstatus: Make run-test executable .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/36 To unsubscribe,

Re: [asterisk-dev] [Code Review] 4605: translate.c: Only select audio codecs to determine the best translation choice.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4605/ --- (Updated April 9, 2015, 11:50 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4608: res_pjsip_phoneprov_provider: Fix reference leak on unload

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4608/#review15167 --- Ship it! Ship It! - Corey Farrell On April 9, 2015, 3:57

[asterisk-dev] [Code Review] 4607: bridge_softmix.c, channel.c: Minor code simplification and cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4607/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4606: chan_sip: make progressinband default to no

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4606/ --- (Updated April 9, 2015, 12:05 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4603: pjsip: Add external PJSIP resolver implementation using core DNS API

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4603/#review15162 --- This review can be summed up in 2 words: NAPTR ARGH

Re: [asterisk-dev] [Code Review] 4606: chan_sip: make progressinband default to no

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4606/#review15159 --- branches/13/CHANGES

[asterisk-dev] Change in testsuite[master]: rest_api/applications/stasisstatus: Make run-test executable

Mark Michelson has submitted this change and it was merged. Change subject: rest_api/applications/stasisstatus: Make run-test executable .. rest_api/applications/stasisstatus: Make run-test executable If it isn't executable,

Re: [asterisk-dev] [Code Review] 4608: res_pjsip_phoneprov_provider: Fix reference leak on unload

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4608/#review15164 --- I think I still prefer ao2_callback over ao2_iterator for

[asterisk-dev] Change in testsuite[master]: Testsuite: Caller callee initiated local attended transfer...

Matt Jordan has posted comments on this change. Change subject: Testsuite: Caller callee initiated local attended transfers to application. .. Patch Set 1: (7 comments) https://gerrit.asterisk.org/#/c/34/1//COMMIT_MSG

[asterisk-dev] Change in testsuite[master]: pjsip: Add basic resolver tests covering A/AAAA, SRV, and NA...

Matt Jordan has posted comments on this change. Change subject: pjsip: Add basic resolver tests covering A/, SRV, and NAPTR. .. Patch Set 1: (1 comment)

Re: [asterisk-dev] [Code Review] 4604: loader/main: Don't set ast_fully_booted until deferred reloads are processed

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4604/#review15154 --- Ship it! Ship It! - Corey Farrell On April 9, 2015, 10:57

Re: [asterisk-dev] [Code Review] 4588: IAX make calltoken expiration time configurable

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4588/ --- (Updated April 9, 2015, 2:21 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4585: res_pjsip: Refactor endpt_send_request to include transaction timeout

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4585/#review15149 --- I've also sent an email to Teluu for their thoughts on this.

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI command to show global and system configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4597/#review15148 --- Ship it! Ran the command, format looks good - all the

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated April 9, 2015, 7:47 a.m.) Status -- This change has been

[asterisk-dev] Change in testsuite[master]: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk.

Hello Anonymous Coward #119, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/35 to look at the new patch set (#3). Change subject: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk.

Re: [asterisk-dev] [Code Review] 4547: clang compiler warning: braces-around-scalar-initializer

On March 28, 2015, 3:59 p.m., Matt Jordan wrote: /branches/13/channels/chan_iax2.c, lines 7674-7676 https://reviewboard.asterisk.org/r/4547/diff/1/?file=73110#file73110line7674 I really dislike this warning. In C, it has always been perfectly valid to initialize all

Re: [asterisk-dev] progressinband in chan_sip default value

Hi, I submitted that change, as we have need for not the 'no' and the 'never' cases on different devices/trunks etc, and before the patch they were almost the same. I completely agree with the above suggestion from Kevin. I always set progressinband manually for all of my device definitions, so

Re: [asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

On March 29, 2015, 5:01 a.m., Diederik de Groot wrote: /branches/13/configure.ac, line 389 https://reviewboard.asterisk.org/r/4543/diff/6/?file=73280#file73280line389 move the raii compiler checks to their own m4 file and called the checking function a little earlier in the

Re: [asterisk-dev] [Code Review] 4499: Support in dialog OPTIONS

On March 23, 2015, 8:01 p.m., Matt Jordan wrote: Thanks for the patch! I've clicked the Ship It button, although the same statement about requiring tests for things going into Asterisk 13 that I made on the DTMF review applies here as well. In this particular case, a test for this

Re: [asterisk-dev] [Code Review] 4604: loader/main: Don't set ast_fully_booted until deferred reloads are processed

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4604/ --- (Updated April 9, 2015, 8:57 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4608: res_pjsip_phoneprov_provider: Fix reference leak on unload

On April 9, 2015, 1:49 p.m., Corey Farrell wrote: branches/13/res/res_pjsip_phoneprov_provider.c, lines 358-363 https://reviewboard.asterisk.org/r/4608/diff/1/?file=73836#file73836line358 To record our brief discussion about this change: coreyfarrell gtjoseph: so one thing I

Re: [asterisk-dev] [Code Review] 4596: res_pjsip_phoneprov_provider: Fix leaked OBJ_MULTIPLE iterator (2nd try)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4596/#review15144 --- Can you update the description with the current analysis of

Re: [asterisk-dev] [Code Review] 4601: Two simple patches for the price of one.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4601/ --- (Updated April 9, 2015, 10:54 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4590: Optional API does not work for sources that are both provider and user of optional API's.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4590/#review15143 --- Ship it! Ship It! - Joshua Colp On April 8, 2015, 6:21

Re: [asterisk-dev] [Code Review] 4476: new res_pjsip module to identify endpoint for an incoming call with a trunk that has outbound registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4476/ --- (Updated April 9, 2015, 1:02 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4483: Separate QoS settings for trunk packets

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4483/ --- (Updated April 9, 2015, 7:27 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4605: translate.c: Only select audio codecs to determine the best translation choice.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4605/#review15161 --- Ship it! Ship It! - Mark Michelson On April 9, 2015, 4:50

[asterisk-dev] [Code Review] 4606: chan_sip: make progressinband default to no

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4606/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24835

Re: [asterisk-dev] [Code Review] 4598: Refactor duplicated DNS routines into common sections

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4598/ --- (Updated April 9, 2015, 10:50 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4607: bridge_softmix.c, channel.c: Minor code simplification and cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4607/#review15165 --- Ship it! Ship It! - Joshua Colp On April 9, 2015, 5:04

Re: [asterisk-dev] [Code Review] 4499: Support in dialog OPTIONS

On March 23, 2015, 3:01 p.m., Matt Jordan wrote: Thanks for the patch! I've clicked the Ship It button, although the same statement about requiring tests for things going into Asterisk 13 that I made on the DTMF review applies here as well. In this particular case, a test for this

Re: [asterisk-dev] [Code Review] 4536: iax2_poke_noanswer expiration timer too short

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4536/#review15145 --- Ship it! Ship It! - Matt Jordan On April 7, 2015, 3:38