Corey Farrell has posted comments on this change.
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
..
Patch Set 3: Code-Review-1
(9 comments)
https://gerrit.asterisk.org/#/c/54/3//COMMIT_MSG
Commit Messa
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4108/
---
(Updated April 12, 2015, 5:24 a.m.)
Review request for Asterisk Developers
> On April 10, 2015, 7:05 p.m., rmudgett wrote:
> >
I'm posting my next diff here, then I will discard this review then post the
same change to gerrit. This way you can look at reviewboard to see the changes
between patches.
> On April 10, 2015, 7:05 p.m., rmudgett wrote:
> > /trunk/main/as
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/56
Change subject: astobj2: Add support for weakproxy objects.
..
astobj2: Add support for weakproxy objects.
This implements "weak" references.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4108/
---
(Updated April 12, 2015, 5:29 a.m.)
Status
--
This change has been di
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/57
Change subject: main/editline: Add .gitignore.
..
main/editline: Add .gitignore.
This patch adds a .gitignore for main/editline to ignore all
Tzafrir Cohen has posted comments on this change.
Change subject: main/editline: Add .gitignore.
..
Patch Set 1:
Why is it not included in the main .ignore?
main/editline/Makefile
etc.
--
To view, visit https://gerrit.aster
Matt Jordan has posted comments on this change.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
Patch Set 2: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/55
To unsubscribe, visit https://gerrit.
Matt Jordan has submitted this change and it was merged.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
.gitignore: Ignore tarballs (*.gz)
This patch updates the root .gitignore file to ignore files with a .gz
extension.
Hello Corey Farrell,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/54
to look at the new patch set (#4).
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
..
git migrat
Matt Jordan has posted comments on this change.
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
..
Patch Set 3:
(3 comments)
https://gerrit.asterisk.org/#/c/54/3/include/asterisk.h
File include/asterisk
Hello Corey Farrell,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/54
to look at the new patch set (#5).
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
..
git migrat
George Joseph has posted comments on this change.
Change subject: main/editline: Add .gitignore.
..
Patch Set 1: Code-Review+1
Good catch. I always use the external editline so the internal one never gets
built.
--
To view,
George Joseph has posted comments on this change.
Change subject: main/editline: Add .gitignore.
..
Patch Set 1:
> Why is it not included in the main .ignore?
>
> main/editline/Makefile
>
> etc.
We decided that the ignor
El 11/04/15 a las 22:59, Matthew Jordan escribió:
On Sat, Apr 11, 2015 at 4:31 PM, Alex Villacís Lasso
wrote:
El 10/04/15 a las 14:16, Alex Villacís Lasso escribió:
El 08/04/15 a las 08:22, Vinicius Fontes escribió:
Have you tried Asterisk 13? The bridging mechanism has been completely
rewri
Hello Corey Farrell,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/54
to look at the new patch set (#6).
Change subject: git migration: Remove support for file versions
..
git migration: Rem
Matt Jordan has abandoned this change.
Change subject: git migration: Remove support for file versions
..
Abandoned
Blech. This patch kind of got messed up in the process of trying to put up the
Asterisk 13 version. I'm going
Matt Jordan has uploaded a new change for review.
https://gerrit.asterisk.org/59
Change subject: git migration: Remove support for file versions
..
git migration: Remove support for file versions
Git does not support the abil
Matt Jordan has abandoned this change.
Change subject: git migration: Remove support for file versions
..
Abandoned
--
To view, visit https://gerrit.asterisk.org/59
To unsubscribe, visit https://gerrit.asterisk.org/settings
G
Matt Jordan has uploaded a new change for review.
https://gerrit.asterisk.org/60
Change subject: git migration: Remove support for file versions
..
git migration: Remove support for file versions
Git does not support the abil
Matt Jordan has uploaded a new change for review.
https://gerrit.asterisk.org/61
Change subject: git migration: Remove support for file versions
..
git migration: Remove support for file versions
Git does not support the abil
Matt Jordan has uploaded a new change for review.
https://gerrit.asterisk.org/63
Change subject: .gitignore: Ignore tarballs (*.gz)
..
.gitignore: Ignore tarballs (*.gz)
This patch updates the root .gitignore file to ignore f
Hello George Joseph,
I'd like you to do a code review. Please visit
https://gerrit.asterisk.org/62
to review the following change.
Change subject: Add .gitignore and .gitreview files
..
Add .gitignore and .gitreview files
Hello George Joseph,
I'd like you to do a code review. Please visit
https://gerrit.asterisk.org/64
to review the following change.
Change subject: Add .gitignore and .gitreview files
..
Add .gitignore and .gitreview files
Matt Jordan has uploaded a new change for review.
https://gerrit.asterisk.org/65
Change subject: .gitignore: Ignore tarballs (*.gz)
..
.gitignore: Ignore tarballs (*.gz)
This patch updates the root .gitignore file to ignore f
Matt Jordan has submitted this change and it was merged.
Change subject: main/editline: Add .gitignore.
..
main/editline: Add .gitignore.
This patch adds a .gitignore for main/editline to ignore all build results.
Change-Id: I
Matt Jordan has posted comments on this change.
Change subject: main/editline: Add .gitignore.
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/57
To unsubscribe, visit https://gerrit.aste
Matt Jordan has uploaded a new change for review.
https://gerrit.asterisk.org/66
Change subject: main/editline: Add .gitignore.
..
main/editline: Add .gitignore.
This patch adds a .gitignore for main/editline to ignore all bu
Matt Jordan has uploaded a new change for review.
https://gerrit.asterisk.org/67
Change subject: main/editline: Add .gitignore.
..
main/editline: Add .gitignore.
This patch adds a .gitignore for main/editline to ignore all bu
Matt Jordan has posted comments on this change.
Change subject: PEP8 fixes
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/40
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-Messa
George Joseph has posted comments on this change.
Change subject: main/editline: Add .gitignore.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/67
To unsubscribe, visit https://gerrit.asterisk.org/
George Joseph has posted comments on this change.
Change subject: Add .gitignore and .gitreview files
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/62
To unsubscribe, visit https://gerrit.asterisk
George Joseph has posted comments on this change.
Change subject: main/editline: Add .gitignore.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/66
To unsubscribe, visit https://gerrit.asterisk.org/
George Joseph has posted comments on this change.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/65
To unsubscribe, visit https://gerrit.asterisk.
George Joseph has posted comments on this change.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/63
To unsubscribe, visit https://gerrit.asterisk.
George Joseph has posted comments on this change.
Change subject: Add .gitignore and .gitreview files
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/64
To unsubscribe, visit https://gerrit.asterisk
Matt Jordan has posted comments on this change.
Change subject: main/editline: Add .gitignore.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.asterisk.org/67
To unsubscribe, visit https://gerrit.asterisk.org/setti
Matt Jordan has posted comments on this change.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/65
To unsubscribe, visit https://gerrit.
Matt Jordan has posted comments on this change.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/63
To unsubscribe, visit https://gerrit.
Matt Jordan has submitted this change and it was merged.
Change subject: Add .gitignore and .gitreview files
..
Add .gitignore and .gitreview files
Add the .gitignore and .gitreview files to the asterisk repo.
NB: You can add
Matt Jordan has submitted this change and it was merged.
Change subject: main/editline: Add .gitignore.
..
main/editline: Add .gitignore.
This patch adds a .gitignore for main/editline to ignore all build results.
Change-Id: I
Matt Jordan has submitted this change and it was merged.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
.gitignore: Ignore tarballs (*.gz)
This patch updates the root .gitignore file to ignore files with a .gz
extension.
Matt Jordan has submitted this change and it was merged.
Change subject: main/editline: Add .gitignore.
..
main/editline: Add .gitignore.
This patch adds a .gitignore for main/editline to ignore all build results.
Change-Id: I
Matt Jordan has posted comments on this change.
Change subject: Add .gitignore and .gitreview files
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/62
To unsubscribe, visit https://gerrit
Matt Jordan has posted comments on this change.
Change subject: main/editline: Add .gitignore.
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/66
To unsubscribe, visit https://gerrit.aste
Matt Jordan has posted comments on this change.
Change subject: Add .gitignore and .gitreview files
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/64
To unsubscribe, visit https://gerrit
Matt Jordan has posted comments on this change.
Change subject: main/editline: Add .gitignore.
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.asterisk.org/67
To unsubscribe, visit https://gerrit.asterisk.org/se
Matt Jordan has submitted this change and it was merged.
Change subject: Add .gitignore and .gitreview files
..
Add .gitignore and .gitreview files
Add the .gitignore and .gitreview files to the asterisk repo.
NB: You can add
Matt Jordan has submitted this change and it was merged.
Change subject: .gitignore: Ignore tarballs (*.gz)
..
.gitignore: Ignore tarballs (*.gz)
This patch updates the root .gitignore file to ignore files with a .gz
extension.
Matt Jordan has uploaded a new change for review.
https://gerrit.asterisk.org/68
Change subject: mapmantis: Remove dependency on digium_jira
..
mapmantis: Remove dependency on digium_jira
This patch removes the dependency of
Matt Jordan has uploaded a new patch set (#2).
Change subject: mapmantis: Remove dependency on digium_jira
..
mapmantis: Remove dependency on digium_jira
This patch removes the dependency of mapmantis from the digium_jira
module
Matt Jordan has uploaded a new change for review.
https://gerrit.asterisk.org/69
Change subject: digium_jira: Refactor module to wrap the Atlassian JIRA REST
client
..
digium_jira: Refactor module to wrap the Atlassian JIRA R
Corey Farrell has posted comments on this change.
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/58
To unsubscribe, visit htt
Corey Farrell has posted comments on this change.
Change subject: git migration: Remove support for file versions
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/60
To unsubscribe, visit https://ger
Corey Farrell has posted comments on this change.
Change subject: git migration: Remove support for file versions
..
Patch Set 1: Code-Review+1
(1 comment)
So I'm a bit indifferent about the finding against main/asterisk.c, up
Matt Jordan has posted comments on this change.
Change subject: git migration: Remove support for file versions
..
Patch Set 1:
(1 comment)
https://gerrit.asterisk.org/#/c/61/1/main/asterisk.c
File main/asterisk.c:
Line 390:
Corey Farrell has posted comments on this change.
Change subject: git migration: Remove support for file versions
..
Patch Set 1:
(1 comment)
https://gerrit.asterisk.org/#/c/61/1/main/asterisk.c
File main/asterisk.c:
Line 390
Matt Jordan has posted comments on this change.
Change subject: git migration: Remove support for file versions
..
Patch Set 1:
(1 comment)
https://gerrit.asterisk.org/#/c/61/1/main/asterisk.c
File main/asterisk.c:
Line 390:
On Sun, Apr 12, 2015 at 11:26 AM, Alex Villacís Lasso
wrote:
> El 11/04/15 a las 22:59, Matthew Jordan escribió:
>>
>> On Sat, Apr 11, 2015 at 4:31 PM, Alex Villacís Lasso
>> wrote:
>> I'd recommend doing the following:
>>
>> * Re-open ASTERISK-20347 and attach the patch to the issue after
>>
Corey Farrell has posted comments on this change.
Change subject: git migration: Remove support for file versions
..
Patch Set 1: -Code-Review
(1 comment)
https://gerrit.asterisk.org/#/c/61/1/main/asterisk.c
File main/asterisk
menuextender: Allows the creation of additional menu items. I'd suggest
using this for adding links to various wiki pages, git.asterisk.org, etc.
reviewers-by-blame: This might be a little too much but it automatically
adds reviewers to a change based on who last changed the affected lines.
wi
George Joseph has posted comments on this change.
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
..
Patch Set 1: Code-Review-1
(1 comment)
Compile fails.
https://gerrit.asterisk.org/#/c/58/1/cel/cel_r
Matt Jordan has uploaded a new patch set (#2).
Change subject: git migration: Remove support for file versions
..
git migration: Remove support for file versions
Git does not support the ability to replace a token with a version
Matt Jordan has uploaded a new patch set (#3).
Change subject: git migration: Remove support for file versions
..
git migration: Remove support for file versions
Git does not support the ability to replace a token with a version
George Joseph has posted comments on this change.
Change subject: PEP8 fixes
..
Patch Set 1: Code-Review-1
Ran the first 10 pjsip tests and all failed but 1. They all pass in master.
--
To view, visit https://gerrit.asterisk
Hello Corey Farrell,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/60
to look at the new patch set (#2).
Change subject: git migration: Remove support for file versions
..
git migration: Rem
Matt Jordan has posted comments on this change.
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
..
Patch Set 1:
(1 comment)
https://gerrit.asterisk.org/#/c/58/1/cel/cel_radius.c
File cel/cel_radius.c:
Hello George Joseph, Corey Farrell,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/58
to look at the new patch set (#2).
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
...
Hello George Joseph, Corey Farrell,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/58
to look at the new patch set (#3).
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
...
Hello Corey Farrell,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/58
to look at the new patch set (#4).
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
..
git migrat
George Joseph has posted comments on this change.
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
..
Patch Set 4: Code-Review+1
Compile succeeded.
--
To view, visit https://gerrit.asterisk.org/58
To un
On Sun, Apr 12, 2015 at 7:04 PM, George Joseph
wrote:
>
> menuextender: Allows the creation of additional menu items. I'd suggest
> using this for adding links to various wiki pages, git.asterisk.org, etc.
Added. Right now I've just got it linking to the issue tracker and the
wiki. I'll add git
On Sun, Apr 12, 2015 at 8:01 PM, Matthew Jordan wrote:
> On Sun, Apr 12, 2015 at 7:04 PM, George Joseph
> wrote:
> >
> > menuextender: Allows the creation of additional menu items. I'd suggest
> > using this for adding links to various wiki pages, git.asterisk.org,
> etc.
>
> Added. Right now
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4391/
---
(Updated April 13, 2015, 5 p.m.)
Review request for Asterisk Developers.
Hello Matt Jordan, George Joseph,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/40
to look at the new patch set (#2).
Change subject: PEP8 fixes
..
PEP8 fixes
* Add tox.ini for pep8 to set
Corey Farrell has posted comments on this change.
Change subject: PEP8 fixes
..
Patch Set 2:
(2 comments)
The PJSIP tests no longer fail. I have a full run of the testsuite going now,
so far no issues.
https://gerrit.asteri
76 matches
Mail list logo
