Coverity: CID 114932
Signed-off-by: John W. Linville
---
I'm guessing this is OK, since it seems to work?
drivers/net/wireless/ath/ath5k/pcu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/ath5k/pcu.c
b/drivers/net/wireless/ath/ath5k/pcu.c
index c60d36a
On Tue, Oct 28, 2014 at 11:08:04AM +0400, Sergey Ryazanov wrote:
> 2014-10-27 21:04 GMT+03:00 John W. Linville :
> > On Wed, Oct 22, 2014 at 03:03:49AM +0400, Sergey Ryazanov wrote:
> >> This reverts commit 093ec3c5337434f40d77c1af06c139da3e5ba6dc.
> >>
> >> AHB
t; Cc: ath5k-devel@lists.ath5k.org
Acked-by: John W. Linville
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
___
ath5k-devel mailing list
ath5k-d
ort WiSoC chips added we can restore functionality back.
>
> Singed-off-by: Sergey Ryazanov
> Cc: Jiri Slaby
> Cc: Nick Kossifidis
> Cc: "Luis R. Rodriguez"
> Cc: linux-wirel...@vger.kernel.org
> Cc: ath5k-devel@lists.ath5k.org
Acked-by: John W. Linville
--
Joh
On Wed, Oct 01, 2014 at 06:41:34PM +0400, Sergey Ryazanov wrote:
> 2014-09-30 21:20 GMT+04:00 John W. Linville :
> > This patch does not seem to apply to wireless-next. What tree is it
> > based upon?
> >
> > John
> >
> Its based on linux-mips. I thought th
ndif
> char name[ATH5K_LED_MAX_NAME_LEN + 1];
> @@ -171,7 +171,7 @@ int ath5k_init_leds(struct ath5k_hw *ah)
> if (!ah->pdev)
> return 0;
>
> -#ifdef CONFIG_ATHEROS_AR231X
> +#ifdef CONFIG_ATH5K_AHB
> match = NULL;
> #else
> m
AR5K_SREV_AR5418 },
> { "2425", AR5K_VERSION_MAC, AR5K_SREV_AR2425 },
> { "2417", AR5K_VERSION_MAC, AR5K_SREV_AR2417 },
> -#endif
> { "x", AR5K_VERSION_MAC, AR5K_SREV_UNKNOWN },
> { "5110",
On Tue, Sep 16, 2014 at 10:26:59PM +0200, Paul Bolle wrote:
> On Mon, 2014-09-15 at 14:45 -0400, John W. Linville wrote:
> > FYI -- Sergey posted a series to linux-mips on 14 September 2014 that
> > touches the symbol in question. For whatever reason, it is posted
> > ther
On Thu, Sep 11, 2014 at 03:21:46PM -0400, John W. Linville wrote:
> On Wed, Sep 10, 2014 at 04:19:21PM +0400, Sergey Ryazanov wrote:
> > 2014-09-10 15:36 GMT+04:00, Jiri Slaby :
> > > On 09/10/2014, 12:33 PM, Sergey Ryazanov wrote:
> > >> 2014-09-09 22:27 GMT+04:00,
On Wed, Sep 10, 2014 at 04:19:21PM +0400, Sergey Ryazanov wrote:
> 2014-09-10 15:36 GMT+04:00, Jiri Slaby :
> > On 09/10/2014, 12:33 PM, Sergey Ryazanov wrote:
> >> 2014-09-09 22:27 GMT+04:00, John W. Linville :
> >>> On Fri, Sep 05, 2014 at 04:02:10PM +0400, Sergey
On Tue, Sep 09, 2014 at 03:32:38PM -0400, John W. Linville wrote:
> The original patch was already merged. To make a change, you need
> to post a new patch based on the new head of the tree. This one just
> conflicts with what is already there now.
>
> Also, I think all you r
eprom,
> + .owner = THIS_MODULE,
> +};
> +
>
> void
> ath5k_debug_init_device(struct ath5k_hw *ah)
> @@ -921,6 +1015,8 @@ ath5k_debug_init_device(struct ath5k_hw *ah)
>
> debugfs_create_file("misc", S_IRUSR, phydir, ah, &fops_misc);
>
&g
d be better approach.
> >>
> >> 1. https://dev.openwrt.org/log/trunk/target/linux/atheros
> >
> > And where can the related PULL requests or patch submissions be found?
> >
> I have not sent patches yet, since I thought that it would be easier
> to cleanup
the style
guidelines and/or checkpatch should change instead?
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
___
ath5k-devel mailing list
at
So it would be nice to have it included!
It would also be nice if you could repost it properly, instead
of expecting me to dig through email threads to piece together a
mergeable patch...
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com
can be used
> >> for something. BTW I sent a few devices to Jonathan, not sure if he
> >> ever got those...
> >>
> >>>
> >>>> I hope Jonathan do kernel part. If not, i can provide some work, since i
> >>>> have testing boards and
On Tue, Mar 20, 2012 at 10:48:40AM -0400, Bob Copeland wrote:
> I simply don't have any hobby hacking time after family time
> and non-kernel-related job time, so I resume status as part-time
> mailing list lurker.
>
> Signed-off-by: Bob Copeland
I'm sorry to see
the patch, tested both on
> wireless-testing and linux-next.
I already merged a version that incorporated Sedat's change on top
of your. If that isn't what you want, please post your change as a
patch on top.
Thanks,
JOhn
--
John W. LinvilleSomeday the w
> >> + ret = ath5k_hw_rf511x_iq_calibrate(ah);
> >> +
> >> + if ((ah->ah_radio == AR5K_RF5112 || ah->ah_radio == AR5K_RF5112)&&
> >
> >You probably mean
> >ah->ah_radio == AR5K_RF5111 || ah->ah_radio == AR5K_RF5112
>
d that
> forcing fast to false at the top of ath5k_hw_reset() fixes the issue.
> I'm not sure what the connection is between this commit and the
> timeouts. Any suggestions?
Have you tried reverting that commit on top of 2.6.38? Can you
recreate the issue with 2.6.39-rc6 (or later)?
mment the use of local variables to reduce the number of load/store
operations on uncached memory, in hopes of not losing this optimization
accidentally in the future.
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com
The ath5k driver does kmalloc allocations for pcal info in a loop.
But, if one fails it was simply returning -ENOMEM without freeing
already allocated memory. This patch corrects that oversight.
Reported-by: Eugene A. Shatokhin
Signed-off-by: John W. Linville
---
The move of
Signed-off-by: John W. Linville
---
drivers/net/wireless/ath/ath.h|1 +
drivers/net/wireless/ath/ath5k/base.c |3 ++-
drivers/net/wireless/ath/ath5k/mac80211-ops.c |3 +--
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath
Signed-off-by: John W. Linville
---
drivers/net/wireless/ath/ath9k/htc.h |1 -
drivers/net/wireless/ath/ath9k/htc_drv_init.c |5 +++--
drivers/net/wireless/ath/ath9k/htc_drv_main.c |2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath
I believe I would prefer the version I just sent, that moves nohwcrypt to
ath_common...
John
On Wed, Jan 05, 2011 at 09:39:59AM -0500, John W. Linville wrote:
> Signed-off-by: John W. Linville
> ---
> drivers/net/wireless/ath/ath5k/base.c |4 ++--
> drivers/net/wirele
Signed-off-by: John W. Linville
---
drivers/net/wireless/ath/ath9k/ath9k.h |1 -
drivers/net/wireless/ath/ath9k/init.c |5 +++--
drivers/net/wireless/ath/ath9k/main.c |2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h
b
Signed-off-by: John W. Linville
---
drivers/net/wireless/ath/ath5k/base.c |4 ++--
drivers/net/wireless/ath/ath5k/mac80211-ops.c |4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/base.c
b/drivers/net/wireless/ath/ath5k/base.c
; --
> > Bob Copeland %% www.bobcopeland.com
> >
>
> Found the patch:
>
> https://patchwork.kernel.org/patch/359722/
Are you posting that for merging? Or just for testing?
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdri
Convert ath_print(.., ATH_DBG_FATAL to ath_err
> ath: Convert ath_print to ath_dbg
> ath: Fix ath_dbg access beyond array bound
Is the Atheros crew happy with this series? They didn't seem to like
the original patches very much...
John
--
John W. LinvilleSomeday
On Tue, Dec 07, 2010 at 04:57:08PM +0100, Sedat Dilek wrote:
> On Tue, Dec 7, 2010 at 3:26 PM, John W. Linville
> wrote:
> > On Tue, Dec 07, 2010 at 12:24:14PM +0100, Sedat Dilek wrote:
> >
> >> I have already reported on linux-wireless (short: l-w) ML that after
&
e problems?
Or does it still "stabilize"?
That patch converts the driver to the generic DMA API. It seems
OK at first glance, but I suspect it is the only one likely to be
effecting your situation.
John
--
John W. LinvilleSomeday the world will need a hero, and you
es to set up.
>
> Signed-off-by: Bruno Randolf
>
> --
>
> resend, seems like it got lost somewhere in a queue ;)
Did you originally post with a different subject? The MARC archive
doesn't seem to see any prior posting.
John
--
John W. LinvilleSomeday the wo
; > or something. Also remove "EXPERIMENTAL", we aren't experimental any
> > more I think ;-)
> >
> > Signed-off-by: Nick Kossifidis
>
> > +MODULE_VERSION("0.7.0");
>
> How about just remove this all together, the version should go
Nick -- just a process note...
All your patches have " Signed-off-by..." (notice the leading space),
which looks a bit funny. Could you figure-out why this is happening
and change it to remove the leading space?
Thanks,
John
--
John W. LinvilleSomeday the world will n
you a nastygram, but instead I discovered the problem and spent
time manually reordering the files in my mbox for application in git.
This is why anyone who tells you not to chain patches as replies to
their preceding patches are clueless whiners who should be ignored.
John
--
John W. Li
don't appear to be getting sent
> >> back. I'm using ath5k as the underlying driver.
> >
> > are you missing this patch?
> >
> > "ath5k: Add channel time to survey data"
> > https://patchwork.kernel.org/patch/264831/
>
> commit
ending hunk is 2500 lines or so...
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https:
merge issues and i'll resend
> the whole series.
You will need to resend this one -- Bob's no longer applies. I have
your 8-patch series applied (with one small fixup from where Felix
removed some capability flags.
John
--
John W. LinvilleSomeday the world will n
Not everyone agrees about LED behaviour...give them an escape hatch that
will at least stop the lights from annoying them.
Signed-off-by: John W. Linville
---
drivers/net/wireless/ath/ath5k/led.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless
L0s actually have the 'PCI_EXP_DEVCAP_RBER' disabled (this bit causes
> pcie device be marked as legacy, and ASPM is disabled on it)
http://marc.info/?l=linux-wireless&m=127507083106814&w=2
"Sorry, I meant to this to be RFC patch."
So, I dropped it.
John
--
John W.
thread, that isn't clearly resolved IMHO. So, I
haven't merged it, or the other patches that follow it in this series.
Am I mistaken? Did this get resolved? If not, are some of the later
patches still interesting?
Unless I hear otherwise, I'll be dropping the rest of
or self-contained
bug fixes. As for linux-next, Stephen usually asks not to merge
anything into linux-next feeder trees during the merge window unless
they are intended to go to the current release. So, non-bugfix patches
probably won't be going to linux-next either for another week or so.
th5k: Minor EEPROM documentation updates
>
> others may be slightly updated.
Thank you for posting the clean series! I'll try to get to them soon...
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com mi
On Tue, Feb 23, 2010 at 03:17:42PM -0500, Pavel Roskin wrote:
> On Sat, 2010-02-20 at 10:30 -0500, Bob Copeland wrote:
> > On Fri, Feb 19, 2010 at 6:15 PM, Pavel Roskin wrote:
> > > On Fri, 2010-02-19 at 08:44 -0500, John W. Linville wrote:
> > >> On Thu, Feb 18, 2
ath5k_pm_ops static.
Any reason not to just remove those functions instead of commenting
them out?
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
_
On Tue, Dec 08, 2009 at 08:01:52AM -0800, Luis R. Rodriguez wrote:
> On Tue, Dec 8, 2009 at 6:57 AM, Bob Copeland wrote:
> > On Mon, Dec 7, 2009 at 4:59 PM, John W. Linville
> > wrote:
> >> On Mon, Dec 07, 2009 at 12:05:54PM +0200, Shahar Or wrote:
> >>> Ad
{ }
> };
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
John W. LinvilleSomeday th
iwlagn module).
> > The first Cell ist the correct access point the second cell with the same
> > ESSID doesn't exist. I don't know why iwlist scan finds this AP.
>
> Please consider burrying iwlist and iwconfig under some ditch and use iw.
Someone sugges
subscribe linux-wireless" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we
PCI PM core to do the
> PCI-specific suspend/resume handling.
>
> Tested with Atheros Communications Inc. AR2413 802.11bg NIC (rev 01)
> D-Link CardBus.adapter.
>
> Signed-off-by: Rafael J. Wysocki
This is already queued for -next.
John
--
John W. LinvilleS
. His position sounds similar to
that expressed to me by Felix and some others that it would be nice
if we could more easily accomodate some of the features of madwifi
that have made it attractive to researchers and experimenters.
Perhaps NL80211_CMD_TESTMODE relates to this desire?
Just a thou
Tested-by, etc)? Also, in the future
I think it would be good for you to take some of the comments from
Luis to heart -- explain the 'why' not the 'what' in the changelogs,
do one thing per patch, etc.
I'm going to drop the original 1-4 now and wait for a clean repost.
Thanks
>
> but they arrive after
>
> iwconfig wlan0 channel 2
>
> Signed-off-by: Joerg Albert
patching file drivers/net/wireless/ath/ath5k/base.c
Hunk #1 FAILED at 1071.
Hunk #2 FAILED at 1083.
Hunk #3 FAILED at 2804.
3 out of 3 hunks FAILED -- saving rejects to file
drivers/n
are pretty small. If
> you want, I can take care of the above and resubmit it with your s-o-b
> so you don't have to go through another respin.
If that is your offer, maybe you could just do your own patch on top?
John
--
John W. LinvilleSomeday the world will need a hero
c80211, you should
> > just use that?
>
> Hmm, yeah, I didn't know that. I'll check it out.
I'll take this one for now, and you can send a better one on top when
you're ready.
Thanks,
John
--
John W. LinvilleSomeday the worl
Reported-by: Johannes Berg
Signed-off-by: John W. Linville
---
I lost track of the related bug report -- Johannes, do you recall?
drivers/net/wireless/ath/ath5k/base.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/base.c
b/drivers
a backport of this patch if
> you like (usual path change).
That's fine. But what about this last bit?
http://bugzilla.kernel.org/show_bug.cgi?id=13077#c6
Is that not needed?
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi.
sure am tired of reading bug reports about
that...
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
but I was waiting for a repost with the
narrower changelogs...?
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
___
ath5k-devel mailing
moved few (4) columns to the right. So
> > something little less than 76 is usually preferred :).
>
> I think in usenet 72 characters was the recommended width, right? That
> way quoting was also easier.
72 is my vote...thanks!
John
--
John W. Lin
d the (HT40-related) patch series that last touched that line.
Hopefully that resolves that warning.
> Um, also the new "ath" module taints the kernel
>
> ath: module 'unspecified' taints kernel.
>
> and I get a new BUG in freq_reg_info_regd. I'll send t
the patch in a separate
email with it's own subject so that I will see it even if I'm buried
(at least most of the time).
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
__
sc->led_on = 0;
> + }
> if (!test_bit(ATH_STAT_LEDSOFT, sc->status))
> goto out;
Any comment on this from the ath5k guys? That 0x105b subvendor ID
would seem to correspond to "Foxconn International, Inc.", which
doesn't sound much like &qu
he whole series along with the next one ?
There has been a ton of discussion in this thread. It would make
things more clear in my inbox if you reposted the whole revised series.
Thanks!
John
--
John W. LinvilleSomeday the world will need a
et_rx" for 2.6.29?
Hmmm...well it is a little big, but I guess it is OK. Do you have
an example of the stack trace? Or a link to a bugzilla or somesuch
would be even better...
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com
On Wed, Dec 17, 2008 at 12:40:56PM -0500, Bob Copeland wrote:
> On Wed, Dec 17, 2008 at 10:55 AM, John W. Linville
> wrote:
> > On Tue, Dec 16, 2008 at 10:22:39AM -0500, Bob Copeland wrote:
> >> Well, anyway John already picked up your earlier (better, IMHO) patch.
> &g
t which the padding occurs, so proper "header" length is
> > required.
>
> Well, anyway John already picked up your earlier (better, IMHO) patch.
> Now we just need to fix the tx descriptors :)
Based on that comment, I'm dropping this version of the patch.
Feel free
atic struct ieee80211_ops ath5k_hw_ops = {
> .tx = ath5k_tx,
This patch defines ath5k_bss_info_changed, but doesn't use it.
Is that really what you meant to do?
John
--
John W. LinvilleLinux should be at the core
[EMAIL PROTECTED] of
On Wed, Oct 29, 2008 at 08:30:53AM -0400, Bob Copeland wrote:
> Change "mamagement" to "management"
>
> Signed-off-by: Bob Copeland <[EMAIL PROTECTED]>
"mamagement" -- there must be a joke in there somewhere... :-)
John
--
John W. Linville
ngly with the
> community on advancing support of all our Atheros chipsets under Linux.
Awesome...simply, awesome!
I hereby nominate Atheros for this year's "Most Improved Open Source
Corporate Citizen" award! :-)
Great job, Luis!
John
--
John W. Linville
urse, looking in include/linux/delay.h, mdelay(3) may still
translate to __bad_udelay on arm. It would be nice if the ARM guys
and delay.h could at least agree on the maximum value allowed to be
passed to udelay...
John
--
John W. Linville
[EMAIL PROTECTED]
__
n simply split
this into a patch that adds new definitions and one that deletes
older definitions? The latter could then be applied at the end of
the series.
Thanks,
John
--
John W. Linville
[EMAIL PROTECTED]
___
ath5k-devel mailing list
ath5k-d
upstream in the Linux kernel.
This sounds like excellent news! I am hopeful that it signifies a
new stance on fully open source drivers for Atheros.
Best of luck at your new position!
John
--
John W. Linville
[EMAIL PROTECTED]
___
ath5k-devel mailin
eature, thanx ;-)
>
> The point is that if there is already a variable we can use to detect
> if a device is pci-e then we shouldn't introduce any other new ones.
ACK for Luis's point.
--
John W. Linville
[EMAIL PROTECTED]
___
ath5k-devel
Sorry, I beat you to it on Friday... :-)
John
--
John W. Linville
[EMAIL PROTECTED]
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
On Sat, Oct 27, 2007 at 02:58:58AM +0300, Nick Kossifidis wrote:
> Do you mind if i also send the rest of them on the same series (not
> only cleanups but code changes also) ?
That seems fine to me.
Thanks,
John
--
John W. Linville
[EMAIL PRO
at are still
used.
Would you mind re-diffing and trying again?
Thanks,
John
--
John W. Linville
[EMAIL PROTECTED]
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
77 matches
Mail list logo
