Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-08-13 Thread Roman Yepishev
On Thu, 2010-08-05 at 11:19 -0700, Luis R. Rodriguez wrote: On Thu, Aug 5, 2010 at 8:33 AM, Maxim Levitsky maximlevit...@gmail.com wrote: Atheros PCIe wireless cards handled by ath5k, don't work well with PCIe ASPM L0s enabled. [...] Acked-by: Luis R. Rodriguez lrodrig...@atheros.com

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-08-13 Thread Luis R. Rodriguez
On Fri, Aug 13, 2010 at 07:21:28AM -0700, Roman Yepishev wrote: On Thu, 2010-08-05 at 11:19 -0700, Luis R. Rodriguez wrote: On Thu, Aug 5, 2010 at 8:33 AM, Maxim Levitsky maximlevit...@gmail.com wrote: Atheros PCIe wireless cards handled by ath5k, don't work well with PCIe ASPM L0s

[ath5k-devel] [PATCH] ath5k: disable ASPM L0s for all cards

2010-08-13 Thread Luis R. Rodriguez
From: Maxim Levitsky maximlevit...@gmail.com Atheros PCIe wireless cards handled by ath5k do require L0s disabled. For distributions shipping with CONFIG_PCIEASPM (this will be enabled by default in the future in 2.6.36) this will also mean both L1 and L0s will be disabled when a pre 1.1 PCIe

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-08-13 Thread Maxim Levitsky
On Fri, 2010-08-13 at 07:51 -0700, Luis R. Rodriguez wrote: On Fri, Aug 13, 2010 at 07:21:28AM -0700, Roman Yepishev wrote: On Thu, 2010-08-05 at 11:19 -0700, Luis R. Rodriguez wrote: On Thu, Aug 5, 2010 at 8:33 AM, Maxim Levitsky maximlevit...@gmail.com wrote: Atheros PCIe wireless

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM L0s for all cards

2010-08-13 Thread Maxim Levitsky
On Fri, 2010-08-13 at 11:27 -0400, Luis R. Rodriguez wrote: From: Maxim Levitsky maximlevit...@gmail.com Atheros PCIe wireless cards handled by ath5k do require L0s disabled. For distributions shipping with CONFIG_PCIEASPM (this will be enabled by default in the future in 2.6.36) this will

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-08-13 Thread Luis R. Rodriguez
On Fri, Aug 13, 2010 at 8:40 AM, Maxim Levitsky maximlevit...@gmail.com wrote: On Fri, 2010-08-13 at 07:51 -0700, Luis R. Rodriguez wrote: On Fri, Aug 13, 2010 at 07:21:28AM -0700, Roman Yepishev wrote: On Thu, 2010-08-05 at 11:19 -0700, Luis R. Rodriguez wrote: On Thu, Aug 5, 2010 at 8:33

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-08-13 Thread Maxim Levitsky
On Fri, 2010-08-13 at 11:30 -0700, Luis R. Rodriguez wrote: On Fri, Aug 13, 2010 at 8:40 AM, Maxim Levitsky maximlevit...@gmail.com wrote: On Fri, 2010-08-13 at 07:51 -0700, Luis R. Rodriguez wrote: On Fri, Aug 13, 2010 at 07:21:28AM -0700, Roman Yepishev wrote: On Thu, 2010-08-05 at

[ath5k-devel] [PATCH] ath5k: disable ASPM

2010-08-05 Thread Maxim Levitsky
Atheros PCIe wireless cards handled by ath5k, don't work well with PCIe ASPM L0s enabled. For example, Acer Aspire One (AOA150, Atheros Communications Inc. AR5001 Wireless Network Adapter [168c:001c] (rev 01)) doesn't work well with ASPM enabled. With ASPM ath5k will eventually stall on heavy

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-08-05 Thread Luis R. Rodriguez
On Thu, Aug 5, 2010 at 8:33 AM, Maxim Levitsky maximlevit...@gmail.com wrote: Atheros PCIe wireless cards handled by ath5k, don't work well with PCIe ASPM L0s enabled. For example,  Acer Aspire One (AOA150, Atheros Communications Inc. AR5001 Wireless Network Adapter [168c:001c] (rev 01))

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-07-26 Thread Maxim Levitsky
Hi, Just want to summarize and finally put that problem to rest. Was the patch that removes sets on CONFIG_PCIEASPM? accepted? Is it possible to check that all ath5k pcie devices that must not use L0s actually have the 'PCI_EXP_DEVCAP_RBER' disabled (this bit causes pcie device be marked as

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-07-26 Thread Luis R. Rodriguez
On Mon, Jul 26, 2010 at 9:34 AM, Maxim Levitsky maximlevit...@gmail.com wrote: Hi, Just want to summarize and finally put that problem to rest. Was the patch that removes sets on CONFIG_PCIEASPM? accepted? Is it possible to check that all ath5k pcie devices that must not use L0s actually

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-07-26 Thread John W. Linville
On Mon, Jul 26, 2010 at 07:34:04PM +0300, Maxim Levitsky wrote: Just want to summarize and finally put that problem to rest. Was the patch that removes sets on CONFIG_PCIEASPM? accepted? Is it possible to check that all ath5k pcie devices that must not use L0s actually have the

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-06-18 Thread RHS Linux User
Hi All, Let's hear it for chips without available specs! Does anyone remember the days when paper specs arrived in plain envelopes with no return address when you asked the manufacturer for some real support? And lets hope they are REAL low in price! wiz On Fri, 18 Jun 2010,

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-06-18 Thread Maxim Levitsky
On Fri, 2010-06-18 at 11:20 +0300, Jussi Kivilinna wrote: Quoting Maxim Levitsky maximlevit...@gmail.com: On Fri, 2010-05-28 at 13:09 +0300, Jussi Kivilinna wrote: Atheros card on Acer Aspire One (AOA150, Atheros Communications Inc. AR5001 Wireless Network Adapter [168c:001c] (rev 01))

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-06-18 Thread Jussi Kivilinna
Quoting Maxim Levitsky maximlevit...@gmail.com: (ok, I might switch back ath5k to work on this, but opening AAO is pain.. on the other hand, I'm just user in this case and pretty unwilling to work with dual-license) What do you mean? Patch I made uses GPL code from e1000e, but since ath5k is

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-06-18 Thread Maxim Levitsky
On Fri, 2010-06-18 at 13:49 +0300, Jussi Kivilinna wrote: Quoting Maxim Levitsky maximlevit...@gmail.com: (ok, I might switch back ath5k to work on this, but opening AAO is pain.. on the other hand, I'm just user in this case and pretty unwilling to work with dual-license) What do you

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-06-18 Thread Bob Copeland
On Fri, Jun 18, 2010 at 7:05 AM, Maxim Levitsky maximlevit...@gmail.com wrote: Patch I made uses GPL code from e1000e, but since ath5k is dual-licensed so patch can't be accepted. So if I got it right, patch has to be remade from scratch by someone who really knows about pci registers etc. I

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-06-18 Thread Maxim Levitsky
On Fri, 2010-06-18 at 09:59 -0400, Bob Copeland wrote: On Fri, Jun 18, 2010 at 7:05 AM, Maxim Levitsky maximlevit...@gmail.com wrote: Patch I made uses GPL code from e1000e, but since ath5k is dual-licensed so patch can't be accepted. So if I got it right, patch has to be remade from

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-06-17 Thread Maxim Levitsky
On Fri, 2010-05-28 at 13:09 +0300, Jussi Kivilinna wrote: Atheros card on Acer Aspire One (AOA150, Atheros Communications Inc. AR5001 Wireless Network Adapter [168c:001c] (rev 01)) doesn't work well with ASPM enabled. With ASPM ath5k will eventually stall on heavy traffic with often

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-06-01 Thread Luis R. Rodriguez
Note: this e-mail thread is on a public mailing list. Adding a few folks just for their information or in case they have anything to add and It is also good to remind ourselves about best practices for this stuff. On Sun, May 30, 2010 at 6:06 PM, Bruno Randolf b...@einfach.org wrote: On

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-05-30 Thread Bruno Randolf
On Saturday 29 May 2010 05:27:56 Pavel Roskin wrote: If we need to add GPL code to ath5k, it could go to a separate file. But if that separation becomes inconvenient, we could drop BSD compatibility from ath5k. I don't see any benefit from dual licensing, unless some existing ath5k

[ath5k-devel] [PATCH] ath5k: disable ASPM

2010-05-28 Thread Jussi Kivilinna
Atheros card on Acer Aspire One (AOA150, Atheros Communications Inc. AR5001 Wireless Network Adapter [168c:001c] (rev 01)) doesn't work well with ASPM enabled. With ASPM ath5k will eventually stall on heavy traffic with often 'unsupported jumbo' warnings appearing. Disabling ASPM L0s/L1 in ath5k

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-05-28 Thread Pavel Roskin
On Fri, 2010-05-28 at 13:09 +0300, Jussi Kivilinna wrote: +static void __ath5k_disable_aspm(struct pci_dev *pdev, u16 state); +static void ath5k_disable_aspm(struct pci_dev *pdev, u16 state); Forward declarations should not be needed unless the functions are called before

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-05-28 Thread Luis R. Rodriguez
On Fri, May 28, 2010 at 3:09 AM, Jussi Kivilinna jussi.kivili...@mbnet.fi wrote: Atheros card on Acer Aspire One (AOA150, Atheros Communications Inc. AR5001 Wireless Network Adapter [168c:001c] (rev 01)) doesn't work well with ASPM enabled. With ASPM ath5k will eventually stall on heavy traffic

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-05-28 Thread Jussi Kivilinna
Quoting Luis R. Rodriguez mcg...@gmail.com: On Fri, May 28, 2010 at 3:09 AM, Jussi Kivilinna jussi.kivili...@mbnet.fi wrote: Atheros card on Acer Aspire One (AOA150, Atheros Communications Inc. AR5001 Wireless Network Adapter [168c:001c] (rev 01)) doesn't work well with ASPM enabled. With

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-05-28 Thread Jussi Kivilinna
Quoting Pavel Roskin pro...@gnu.org: On Fri, 2010-05-28 at 13:09 +0300, Jussi Kivilinna wrote: +static void __ath5k_disable_aspm(struct pci_dev *pdev, u16 state); +static void ath5k_disable_aspm(struct pci_dev *pdev, u16 state); Forward declarations should not be needed

Re: [ath5k-devel] [PATCH] ath5k: disable ASPM

2010-05-28 Thread Pavel Roskin
On Fri, 2010-05-28 at 21:25 +0300, Jussi Kivilinna wrote: I used code from e1000e which does this same way, which now suddenly reminds me of that ath5k is dual lisenced, right? Can I even reuse code from GPL driver in ath5k? That's another reason why we don't want this code to be all over