Re: RFR: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions [v2]

2021-08-14 Thread Pankaj Bansal
On Sat, 14 Aug 2021 01:15:45 GMT, rajat mahajan wrote: >> Removed try catch block so the test can function as expected and fail >> when it ought to, rather than passing all the time because of catch >> block catching all exceptions and Passing test even there is a failure. > > rajat mahajan has

Re: RFR: 8270331: [TESTBUG] Error: Not a test or directory containing tests: java/awt/print/PrinterJob/InitToBlack.java

2021-08-09 Thread Pankaj Bansal
On Fri, 6 Aug 2021 17:35:22 GMT, lawrence.andrews wrote: > 1) Removed Testcase depending on InitToBlack.html file which makes the > testcase to executed independently. > 2) Removed Applet class dependent. > 3) Moved applet/manual=yesno to main/manual InitToBlack > > @shurymury There is no In

Re: RFR: 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility [v9]

2021-08-04 Thread Pankaj Bansal
On Mon, 2 Aug 2021 09:00:14 GMT, Artem Semenov wrote: >> 8267385: Create NSAccessibilityElement implementation for >> JavaComponentAccessibility >> This pull request contains solutions for the following tickets: >> * JDK-8267385 Create NSAccessibilityElement implementation for >> JavaComponent

Re: RFR: 8270058: Use Objects.check{Index, FromIndexSize} for java.desktop [v3]

2021-07-30 Thread Pankaj Bansal
On Thu, 22 Jul 2021 06:29:13 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. >> >> As Mandy suggested, I create this PR for change

Re: RFR: 8270058: Use Objects.check{Index, FromIndexSize} for java.desktop [v3]

2021-07-30 Thread Pankaj Bansal
On Fri, 30 Jul 2021 08:17:29 GMT, Jayathirth D V wrote: >> Yi Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> typo > > src/java.desktop/share/classes/javax/swing/JTabbedPane.java line 1793: > >> 1791: >> 1792: private void che

Re: [jdk17] RFR: 8270858: Problem List java/awt/Window/MultiWindowApp/MultiWindowAppTest.java on Linux

2021-07-16 Thread Pankaj Bansal
On Fri, 16 Jul 2021 19:35:44 GMT, Phil Race wrote: > Failing too often on Ubuntu 21.04 so creating noise in the system. > We need to look at whether there's a product issue or a system config issue > but it still needs to be problem listed. > Per the RDP 2 rules no approval is needed to problem

Re: RFR: 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility [v2]

2021-07-08 Thread Pankaj Bansal
On Fri, 2 Jul 2021 12:45:25 GMT, Artem Semenov wrote: >> 8267385: Create NSAccessibilityElement implementation for >> JavaComponentAccessibility >> This pull request contains solutions for the following tickets: >> * JDK-8267385 Create NSAccessibilityElement implementation for >> JavaComponent

Re: RFR: 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility [v2]

2021-07-07 Thread Pankaj Bansal
On Tue, 29 Jun 2021 15:00:41 GMT, Artem Semenov wrote: >> src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m >> line 372: >> >>> 370: if ([javaRole isEqualToString:@"pagetablist"]) { >>> 371: newChild = [TabGroupLegacyAccessibility alloc]; >>> 372: } e

Re: RFR: 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility [v2]

2021-07-06 Thread Pankaj Bansal
On Fri, 2 Jul 2021 12:45:25 GMT, Artem Semenov wrote: >> 8267385: Create NSAccessibilityElement implementation for >> JavaComponentAccessibility >> This pull request contains solutions for the following tickets: >> * JDK-8267385 Create NSAccessibilityElement implementation for >> JavaComponent

Re: RFR: 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility [v2]

2021-07-04 Thread Pankaj Bansal
On Fri, 2 Jul 2021 12:45:25 GMT, Artem Semenov wrote: >> 8267385: Create NSAccessibilityElement implementation for >> JavaComponentAccessibility >> This pull request contains solutions for the following tickets: >> * JDK-8267385 Create NSAccessibilityElement implementation for >> JavaComponent

Re: RFR: 8268481: Delete JAWT test files for mac

2021-06-09 Thread Pankaj Bansal
On Wed, 9 Jun 2021 19:49:28 GMT, Sergey Bylokhov wrote: > Due to some issues, we need to delete these files. Later this test case will > be updated and reintegrated. Marked as reviewed by pbansal (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4440

Integrated: 8264305: Create implementation for native accessibility peer for Statusbar java role

2021-06-03 Thread Pankaj Bansal
On Wed, 2 Jun 2021 13:58:24 GMT, Pankaj Bansal wrote: > Create implementation for native accessibility peer for Statusbar java role. > I do not see any Swing component with StatusBar accessibility role, so I have > created a component with the StatusBar role to test this. I have t

RFR: 8264305: Create implementation for native accessibility peer for Statusbar java role

2021-06-02 Thread Pankaj Bansal
Create implementation for native accessibility peer for Statusbar java role. I do not see any Swing component with StatusBar accessibility role, so I have created a component with the StatusBar role to test this. I have tested the implementation with the following example and a few more similar

Integrated: 8264302: Create implementation for Accessibility native peer for Splitpane java role

2021-05-26 Thread Pankaj Bansal
On Tue, 25 May 2021 08:24:21 GMT, Pankaj Bansal wrote: > Create implementation for Accessibility native peer for Splitpane java role. > I have tested it using the SwingSet2 and splitpane demo from > https://docs.oracle.com/javase/tutorial/uiswing/examples/components/index.html#Spli

Re: RFR: 8264302: Create implementation for Accessibility native peer for Splitpane java role [v2]

2021-05-25 Thread Pankaj Bansal
On Wed, 26 May 2021 03:10:22 GMT, Alexander Zuev wrote: >> Pankaj Bansal has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct small issue > > src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/Split

Re: RFR: 8264302: Create implementation for Accessibility native peer for Splitpane java role [v2]

2021-05-25 Thread Pankaj Bansal
viour before and after the changes. Pankaj Bansal has updated the pull request incrementally with one additional commit since the last revision: Correct small issue - Changes: - all: https://git.openjdk.java.net/jdk/pull/4181/files - new: https://git.openjdk.java.net/jdk/pul

RFR: 8264302: Create implementation for Accessibility native peer for Splitpane java role

2021-05-25 Thread Pankaj Bansal
Create implementation for Accessibility native peer for Splitpane java role. I have tested it using the SwingSet2 and splitpane demo from https://docs.oracle.com/javase/tutorial/uiswing/examples/components/index.html#SplitPaneDemo. The do not see any inconsistency in Vo behaviour before and after

Re: RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v2]

2021-05-24 Thread Pankaj Bansal
On Tue, 25 May 2021 06:36:27 GMT, Alexander Zuev wrote: >> Made all implementing classes return their roles directly. >> Change nullability attributes to the singular style across new classes. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the la

Re: RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly

2021-05-24 Thread Pankaj Bansal
On Mon, 24 May 2021 11:03:35 GMT, Alexander Zuev wrote: > Made all implementing classes return their roles directly. > Change nullability attributes to the singular style across new classes. src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/StaticTextAccessibility.h line 39: > 37: - (NSAcce

Re: RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly

2021-05-24 Thread Pankaj Bansal
On Mon, 24 May 2021 11:03:35 GMT, Alexander Zuev wrote: > Made all implementing classes return their roles directly. > Change nullability attributes to the singular style across new classes. src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.h line 32: > 30: }; > 31:

Re: RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly

2021-05-24 Thread Pankaj Bansal
On Mon, 24 May 2021 11:03:35 GMT, Alexander Zuev wrote: > Made all implementing classes return their roles directly. > Change nullability attributes to the singular style across new classes. src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CheckboxAccessibility.h line 32: > 30: }; > 31: -

Re: RFR: 8208747: [a11y] [macos] In Optionpane Demo, inside ComponentDialog Example, unable to navigate to all items, with VO on

2021-05-24 Thread Pankaj Bansal
On Tue, 18 May 2021 09:05:10 GMT, Alexander Zuev wrote: > Added accessibilityIndex function that correctly returns the index of a > child in parent container Marked as reviewed by pbansal (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4084

Integrated: 8264304: Create implementation for NSAccessibilityToolbar protocol peer

2021-05-22 Thread Pankaj Bansal
On Sat, 15 May 2021 10:57:15 GMT, Pankaj Bansal wrote: > Create implementation for accessibility native peer for Toolbar component. > There is no direct protocol for this role and there is no protocol in list of > role based protocols defined by Apple Accessibility API, which can be us

Re: RFR: 8208747: [a11y] [macos] In Optionpane Demo, inside ComponentDialog Example, unable to navigate to all items, with VO on

2021-05-20 Thread Pankaj Bansal
On Thu, 20 May 2021 10:44:05 GMT, Alexander Zuev wrote: > > Is there a reason it is not causing an issue in case if JList? JList also > > has elements inside a container, but I see that we can navigate the > > elements in JList though there is also one issue that the VO always says "1 > > on n

Re: RFR: 8264304: Create implementation for NSAccessibilityToolbar protocol peer [v2]

2021-05-20 Thread Pankaj Bansal
I have tested this implementation by using the SwingSet2 demo and Toolbar > samples present here > https://docs.oracle.com/javase/tutorial/uiswing/components/toolbar.html. The > Voice Over works fine and consistent with the old implementation. Pankaj Bansal has updated the pull request w

Re: RFR: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer

2021-05-20 Thread Pankaj Bansal
On Mon, 17 May 2021 08:22:59 GMT, Alexander Zuev wrote: > Initial implementation. Looks fine to me. src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/GroupAccessibility.m line 27: > 25: > 26: #import "GroupAccessibility.h" > 27: #import "JNIUtilities.h" The header JNIUtilities.h is not u

Re: RFR: 8208747: [a11y] [macos] In Optionpane Demo, inside ComponentDialog Example, unable to navigate to all items, with VO on

2021-05-20 Thread Pankaj Bansal
On Tue, 18 May 2021 09:05:10 GMT, Alexander Zuev wrote: > Added accessibilityIndex function that correctly returns the index of a > child in parent container Is there a reason it is not causing an issue in case if JList? JList also has elements inside a container, but I see that we can navigate

Re: RFR: 8208747: [a11y] [macos] In Optionpane Demo, inside ComponentDialog Example, unable to navigate to all items, with VO on

2021-05-18 Thread Pankaj Bansal
On Tue, 18 May 2021 14:50:23 GMT, Alexander Zuev wrote: > > The bug is a confidential issue. Either the bug should not be confidential > > or this review should not be done here. > > I do not see any potential reason why this issue might be confidential. It is > not security related, can be re

Re: RFR: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer

2021-05-18 Thread Pankaj Bansal
On Mon, 17 May 2021 08:22:59 GMT, Alexander Zuev wrote: > Initial implementation. Could you please give some details about how you have tested this? - PR: https://git.openjdk.java.net/jdk/pull/4046

Re: RFR: 8208747: [a11y] [macos] In Optionpane Demo, inside ComponentDialog Example, unable to navigate to all items, with VO on

2021-05-18 Thread Pankaj Bansal
On Tue, 18 May 2021 09:05:10 GMT, Alexander Zuev wrote: > Added accessibilityIndex function that correctly returns the index of a > child in parent container The bug is a confidential issue. Either the bug should not be confidential or this review should not be done here. - PR: ht

RFR: 8264304: Create implementation for NSAccessibilityToolbar protocol peer

2021-05-15 Thread Pankaj Bansal
Create implementation for accessibility native peer for Toolbar component. There is no direct protocol for this role and there is no protocol in list of role based protocols defined by Apple Accessibility API, which can be used for this role directly. https://developer.apple.com/library/archive/

Integrated: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles

2021-05-13 Thread Pankaj Bansal
On Thu, 29 Apr 2021 11:46:25 GMT, Pankaj Bansal wrote: > Create implementation of native accessibility peer for ScrollPane and > ScrollBar Java Accessibility roles. > > There are no direct protocols for these two roles and there is no protocol in > list of role based proto

Re: RFR: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles [v3]

2021-05-12 Thread Pankaj Bansal
On Wed, 12 May 2021 16:33:22 GMT, Alexander Zuev wrote: >> Pankaj Bansal has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request conta

Re: RFR: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles [v5]

2021-05-12 Thread Pankaj Bansal
ScrollAreaAccessibility_Old as this was causing compiler errors > and we are not deleting old implementations as of now. Please let me know if > there is a better way to handle this. > Also, some constants defined in JavaComponentAccessibility.m have been moved > to JavaComponentAcce

Re: RFR: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles [v4]

2021-05-12 Thread Pankaj Bansal
On Wed, 12 May 2021 16:32:31 GMT, Alexander Zuev wrote: >> Pankaj Bansal has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Incorporate review comments > > src/java.desktop/macosx/native/libawt_lwawt/aw

Re: RFR: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles [v4]

2021-05-12 Thread Pankaj Bansal
ScrollAreaAccessibility_Old as this was causing compiler errors > and we are not deleting old implementations as of now. Please let me know if > there is a better way to handle this. > Also, some constants defined in JavaComponentAccessibility.m have been moved > to JavaComponentAcce

Re: RFR: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles [v3]

2021-05-10 Thread Pankaj Bansal
ScrollAreaAccessibility_Old as this was causing compiler errors > and we are not deleting old implementations as of now. Please let me know if > there is a better way to handle this. > Also, some constants defined in JavaComponentAccessibility.m have been moved > to JavaComponentAcce

Re: RFR: 8047218: [TEST_BUG] java/awt/FullScreen/AltTabCrashTest/AltTabCrashTest.java fails with exception

2021-05-10 Thread Pankaj Bansal
On Mon, 10 May 2021 21:38:37 GMT, Sergey Bylokhov wrote: > An exception occurs when the main thread disposes of the frame while the > other thread still renders to it. The fix joins the main thread to other > threads, so we will dispose of the frame at the end only. Marked as reviewed by pbans

Re: RFR: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles [v2]

2021-05-09 Thread Pankaj Bansal
ScrollAreaAccessibility_Old as this was causing compiler errors > and we are not deleting old implementations as of now. Please let me know if > there is a better way to handle this. > Also, some constants defined in JavaComponentAccessibility.m have been moved > to JavaComponentAcce

RFR: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles

2021-05-01 Thread Pankaj Bansal
Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles. There are no direct protocols for these two roles and there is no protocol in list of role based protocols defined by Apple Accessibility API, which can be used for these roles directly. So

Integrated: 8136517: [macosx]Test java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX

2021-04-27 Thread Pankaj Bansal
On Thu, 22 Apr 2021 13:05:09 GMT, Pankaj Bansal wrote: > The tests java/awt/Focus/8073453/AWTFocusTransitionTest.java and > java/awt/Focus/8073453/SwingFocusTransitionTest.java fail on MacOS > intermittently and are problem listed. The test needs lot of Robot actions. > It does

Re: RFR: 8136517: [macosx]Test java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX [v2]

2021-04-27 Thread Pankaj Bansal
On Wed, 28 Apr 2021 03:07:15 GMT, Pankaj Bansal wrote: >> The tests java/awt/Focus/8073453/AWTFocusTransitionTest.java and >> java/awt/Focus/8073453/SwingFocusTransitionTest.java fail on MacOS >> intermittently and are problem listed. The test needs lot of Robot actions. &

Re: RFR: 8136517: [macosx]Test java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX [v2]

2021-04-27 Thread Pankaj Bansal
> The changes fix this issue. Also, the frame is moved to centre of screen and > set to be at top always. Some more cleanup is done. The test is passing for > multiple iterations on all platforms on CI. Link in JBS. Pankaj Bansal has updated the pull request incrementally with one addi

RFR: 8136517: [macosx]Test java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX

2021-04-22 Thread Pankaj Bansal
The tests java/awt/Focus/8073453/AWTFocusTransitionTest.java and java/awt/Focus/8073453/SwingFocusTransitionTest.java fail on MacOS intermittently and are problem listed. The test needs lot of Robot actions. It does not test if the components are visible on the screen. The changes fix this issu

Integrated: 8262981: Create implementation for NSAccessibilitySlider protocol

2021-04-15 Thread Pankaj Bansal
On Mon, 8 Mar 2021 12:51:56 GMT, Pankaj Bansal wrote: > Create implementation of NSAccessibilitySlider protocol > https://developer.apple.com/documentation/appkit/nsaccessibilityslider > > The implementation has the function performIncrement and performDecrement to > increa

Re: RFR: 8039261: [TEST_BUG]: There is not a minimal security level in Java Preferences and the TestApplet.html is blocked. [v2]

2021-04-13 Thread Pankaj Bansal
On Tue, 13 Apr 2021 01:34:17 GMT, Alexander Zvegintsev wrote: >> This fix simply removes tests mentioned in the bug with for unsupported >> scenarios(applets in browser). > > Alexander Zvegintsev has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8233567: [TESTBUG] FocusSubRequestTest.java fails on macos

2021-04-12 Thread Pankaj Bansal
On Mon, 12 Apr 2021 04:37:31 GMT, Prasanta Sadhukhan wrote: > This test was problemlisted during nightly testing of jdk on macos which > seems to be caused by the fact that proper waiting was not done to make sure > frame is visible before commencing the test, which can be problematic in some

Re: RFR: 8262981: Create implementation for NSAccessibilitySlider protocol

2021-04-05 Thread Pankaj Bansal
On Wed, 31 Mar 2021 19:56:24 GMT, Sergey Bylokhov wrote: >>> > It looks like the Dialog must have handled the keys as there are no >>> > special keys mentioned for JAWS to interact with the component like the VO >>> >>> Did you check this list of hotkeys? >>> https://www.freedomscientific.com/t

Re: RFR: 8262981: Create implementation for NSAccessibilitySlider protocol

2021-04-01 Thread Pankaj Bansal
On Wed, 31 Mar 2021 19:56:24 GMT, Sergey Bylokhov wrote: > Ok, please file a similar bug for the windows platform. I have created the bug for windows here https://bugs.openjdk.java.net/browse/JDK-8264598. I have also created the CSR for the current issue. - PR: https://git.openjdk

Re: RFR: 8262981: Create implementation for NSAccessibilitySlider protocol [v3]

2021-04-01 Thread Pankaj Bansal
gt; jframe.add(new JSlider()); > > jframe.setLocationRelativeTo(null); > jframe.pack(); > jframe.setVisible(true); > } > } Pankaj Bansal has updated the pull request with a new target base due to a merge

Re: RFR: 8262981: Create implementation for NSAccessibilitySlider protocol

2021-03-30 Thread Pankaj Bansal
On Wed, 17 Mar 2021 01:48:40 GMT, Sergey Bylokhov wrote: > > It looks like the Dialog must have handled the keys as there are no special > > keys mentioned for JAWS to interact with the component like the VO > > Did you check this list of hotkeys? > https://www.freedomscientific.com/training/ja

Re: RFR: 8264344: Outdated links in JavaComponentAccessibility.m

2021-03-29 Thread Pankaj Bansal
On Mon, 29 Mar 2021 08:31:48 GMT, Alexander Zuev wrote: > 8264344: Outdated links in JavaComponentAccessibility.m Marked as reviewed by pbansal (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3240

Integrated: 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation

2021-03-15 Thread Pankaj Bansal
On Thu, 11 Mar 2021 07:57:23 GMT, Pankaj Bansal wrote: > The implementation of NSAccessibilityStaticText protocol > (https://developer.apple.com/documentation/appkit/nsaccessibilitystatictext) > has an incorrect function name which results in the function not being called > by Voi

Re: RFR: 8262981: Create implementation for NSAccessibilitySlider protocol [v2]

2021-03-14 Thread Pankaj Bansal
On Wed, 10 Mar 2021 14:47:38 GMT, Pankaj Bansal wrote: >> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m >> line 59: >> >>> 57: [rolesMap setObject:@"RadiobuttonAccessibility" >>> forKey:@&

Re: RFR: 8262981: Create implementation for NSAccessibilitySlider protocol [v2]

2021-03-14 Thread Pankaj Bansal
gt; jframe.add(new JSlider()); > > jframe.setLocationRelativeTo(null); > jframe.pack(); > jframe.setVisible(true); > } > } Pankaj Bansal has updated the pull request incrementally with one addi

Re: RFR: 8262981: Create implementation for NSAccessibilitySlider protocol

2021-03-14 Thread Pankaj Bansal
On Fri, 12 Mar 2021 03:26:10 GMT, Sergey Bylokhov wrote: > > If you happen to have some idea about how can a user interact with Sliders > > or Spinners using JAWS, please let me know. I will definitely verify if the > > changes would be helpful for Windows. > > How the native applications work

Re: RFR: 8262981: Create implementation for NSAccessibilitySlider protocol

2021-03-11 Thread Pankaj Bansal
On Wed, 10 Mar 2021 23:09:31 GMT, Sergey Bylokhov wrote: > If it does not work on Windows then I suggest checking that the new > functionality requested via CSR will help it as well. I could not find any key shortcuts where JAWS will consume the key pressed and will be used to interact with th

RFR: 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation

2021-03-11 Thread Pankaj Bansal
The implementation of NSAccessibilityStaticText protocol (https://developer.apple.com/documentation/appkit/nsaccessibilitystatictext) has an incorrect function name which results in the function not being called by Voice Over. The Voice Over output is not getting affected by this bug as the acc

Re: RFR: 8262981: Create implementation for NSAccessibilitySlider protocol

2021-03-10 Thread Pankaj Bansal
On Tue, 9 Mar 2021 21:27:39 GMT, Alexander Zuev wrote: > Shouldn't you also increase the rolesMap initial capacity? ok, I will do that in next commit. - PR: https://git.openjdk.java.net/jdk/pull/2874

Re: RFR: 8262981: Create implementation for NSAccessibilitySlider protocol

2021-03-10 Thread Pankaj Bansal
On Wed, 10 Mar 2021 13:32:01 GMT, Alexander Zuev wrote: > > If you need a new functionality and CSR I wonder how it currently works on > > Windows and macOS, or it does not work? > > Haven't tested this functionality on Windows, on macOS with current JDK it > does not work at all. After enteri

Re: RFR: 8262981: Create implementation for NSAccessibilitySlider protocol

2021-03-10 Thread Pankaj Bansal
On Wed, 10 Mar 2021 13:32:01 GMT, Alexander Zuev wrote: > If you need a new functionality and CSR I wonder how it currently works on > Windows and macOS, or it does not work? - PR: https://git.openjdk.java.net/jdk/pull/2874

RFR: 8262981: Create implementation for NSAccessibilitySlider protocol

2021-03-09 Thread Pankaj Bansal
Create implementation of NSAccessibilitySlider protocol https://developer.apple.com/documentation/appkit/nsaccessibilityslider The implementation has the function performIncrement and performDecrement to increase/decrease the value of slider using the VoiceOver. To implement this functionality,

Re: RFR: 8250804: Can't set the application icon image for Unity WM on Linux.

2021-03-05 Thread Pankaj Bansal
On Fri, 5 Mar 2021 00:55:04 GMT, Alexander Zvegintsev wrote: > As of now we can have two icons: on the side dock and on the top bar. > But this test was written for an old time Unity with an icon in the side dock > only. > > Icon at the top by default is displayed as grayscale(the actual reas

Re: RFR: 8261350: Create implementation for NSAccessibilityCheckBox protocol peer

2021-02-19 Thread Pankaj Bansal
On Wed, 17 Feb 2021 18:31:01 GMT, Alexander Zuev wrote: > 8261350: Create implementation for NSAccessibilityCheckBox protocol peer Marked as reviewed by pbansal (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2613

Re: RFR: 8261351: Create implementation for NSAccessibilityRadioButton protocol [v2]

2021-02-13 Thread Pankaj Bansal
On Sat, 13 Feb 2021 05:55:02 GMT, Alexander Zuev wrote: >> 8261351: Create implementation for NSAccessibilityRadioButton protocol > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Internal variable eliminated. src/java.des

Re: RFR: 8261351: Create implementation for NSAccessibilityRadioButton protocol [v2]

2021-02-12 Thread Pankaj Bansal
On Sat, 13 Feb 2021 05:55:02 GMT, Alexander Zuev wrote: >> 8261351: Create implementation for NSAccessibilityRadioButton protocol > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Internal variable eliminated. Marked as re

Re: RFR: 8261351: Create implementation for NSAccessibilityRadioButton protocol

2021-02-12 Thread Pankaj Bansal
On Sat, 13 Feb 2021 05:01:17 GMT, Alexander Zuev wrote: > 8261351: Create implementation for NSAccessibilityRadioButton protocol src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.h line 35: > 33: > 34: }; > 35: - (id)accessibilityValue; The NSAccessibilityRadioBut

Re: RFR: 8261351: Create implementation for NSAccessibilityRadioButton protocol

2021-02-12 Thread Pankaj Bansal
On Sat, 13 Feb 2021 05:01:17 GMT, Alexander Zuev wrote: > 8261351: Create implementation for NSAccessibilityRadioButton protocol src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.m line 39: > 37: AWT_ASSERT_APPKIT_THREAD; > 38: id value = [self accessibility

Re: RFR: 8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes" [v4]

2021-02-04 Thread Pankaj Bansal
On Fri, 5 Feb 2021 05:12:00 GMT, Alexander Zuev wrote: >> 8216358: [accessibility] [macos] The focus is invisible when tab to "Image >> Radio Buttons" and "Image CheckBoxes" > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8260867: ProblemList java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java on linux

2021-02-01 Thread Pankaj Bansal
On Mon, 1 Feb 2021 23:16:18 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java on linux > in order to reduce the noise in the JDK17 CI. Marked as reviewed by pbansal (Reviewer). - PR: https://git.openjdk.ja

Re: RFR: 8260315: Typo "focul" instead of "focus" in FocusSpec.html

2021-01-23 Thread Pankaj Bansal
On Sat, 23 Jan 2021 12:15:04 GMT, Alexey Ivanov wrote: > A trivial fix for the typo in AWT Focus Spec, it replaces “focul” with > “focus”. Marked as reviewed by pbansal (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2209

Integrated: 8256111: Create implementation for NSAccessibilityStaticText protocol

2021-01-22 Thread Pankaj Bansal
On Tue, 19 Jan 2021 15:19:03 GMT, Pankaj Bansal wrote: > Create implementation for NSAccessibilityStaticText protocol > > For testing that Label accessibility works fine, I have used something like > https://docs.oracle.com/javase/tutorial/uiswing/examples/components/LabelDem

Re: RFR: 8256111: Create implementation for NSAccessibilityStaticText protocol [v2]

2021-01-21 Thread Pankaj Bansal
role being used > anywhere. As we are reworking the implementation, I have included both roles > "label" and "hyperlink" as of now. Pankaj Bansal has updated the pull request incrementally with one additional commit since the last revision: Add nullable flag in Com

Re: RFR: 8256111: Create implementation for NSAccessibilityStaticText protocol

2021-01-21 Thread Pankaj Bansal
On Thu, 21 Jan 2021 09:33:25 GMT, Alexander Zuev wrote: >> Create implementation for NSAccessibilityStaticText protocol >> >> For testing that Label accessibility works fine, I have used something like >> https://docs.oracle.com/javase/tutorial/uiswing/examples/components/LabelDemoProject/src/c

RFR: 8256111: Create implementation for NSAccessibilityStaticText protocol

2021-01-19 Thread Pankaj Bansal
Create implementation for NSAccessibilityStaticText protocol For testing that Label accessibility works fine, I have used something like https://docs.oracle.com/javase/tutorial/uiswing/examples/components/LabelDemoProject/src/components/LabelDemo.java. I also tried few other labels with html tex

Integrated: 8256126: Create implementation for NSAccessibilityImage protocol peer

2021-01-15 Thread Pankaj Bansal
On Fri, 15 Jan 2021 08:29:44 GMT, Pankaj Bansal wrote: > Create implementation for NSAccessibilityImage protocol peer This pull request has now been integrated. Changeset: bbb93ca3 Author: Pankaj Bansal URL: https://git.openjdk.java.net/jdk/commit/bbb93ca3 Stats: 42 lines i

Re: RFR: 8256126: Create implementation for NSAccessibilityImage protocol peer

2021-01-15 Thread Pankaj Bansal
On Sat, 16 Jan 2021 01:33:00 GMT, Alexander Zuev wrote: >> Create implementation for NSAccessibilityImage protocol peer > >> @pankaj-bansal please provide some steps to test that a11y for the image >> works. > > I use the simple code snippet like this: > &g

RFR: 8256126: Create implementation for NSAccessibilityImage protocol peer

2021-01-15 Thread Pankaj Bansal
Create implementation for NSAccessibilityImage protocol peer - Commit messages: - 8256126: Create implementation for NSAccessibilityImage protocol peer Changes: https://git.openjdk.java.net/jdk/pull/2096/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2096&range=00 Is

Re: RFR: 8256110: Create implementation for NSAccessibilityStepper protocol

2021-01-14 Thread Pankaj Bansal
On Fri, 15 Jan 2021 06:34:22 GMT, Alexander Zuev wrote: > 8256110: Create implementation for NSAccessibilityStepper protocol Marked as reviewed by pbansal (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2092

Withdrawn: 8259779: Create implementation for NSAccessibilityStepper protocol

2021-01-14 Thread Pankaj Bansal
On Thu, 14 Jan 2021 13:46:17 GMT, Pankaj Bansal wrote: > Creating a native peer for stepper/spinner accessibility role on Max OS X. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/2081

RFR: 8259779: Create implementation for NSAccessibilityStepper protocol

2021-01-14 Thread Pankaj Bansal
Creating a native peer for stepper/spinner accessibility role on Max OS X. - Commit messages: - Resolve some whitespaces issues - 8259779: Create implementation for NSAccessibilityStepper protocol Changes: https://git.openjdk.java.net/jdk/pull/2081/files Webrev: https://webrevs.op

Re: [jdk16] RFR: 8259720: ProblemList java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java on Windows

2021-01-13 Thread Pankaj Bansal
On Wed, 13 Jan 2021 17:29:09 GMT, Daniel D. Daugherty wrote: > This is a trivial fix to ProblemList > java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java > on Windows in order to reduce the noise in the JDK16 CI. Marked as reviewed by pbansal (Reviewer). - PR: http

Re: [jdk16] RFR: 8259237: Demo selection changes with left/right arrow key. No need to press space for selection. [v2]

2021-01-11 Thread Pankaj Bansal
On Mon, 11 Jan 2021 11:16:02 GMT, Alexander Zuev wrote: > Quick question: why we special casing JRadioButton case? Is there any reason > we should call the action on them? This was the behaviour which was there before JDK-8249548 for JRadioButton and I am just reverting to it. As explained in

Re: [jdk16] RFR: 8259237: Demo selection changes with left/right arrow key. No need to press space for selection. [v2]

2021-01-11 Thread Pankaj Bansal
ame. User can > navigate/select the buttons added to ButtonGroups and set Action is performed > without pressing "space" > > I have run mach5 jobs with full jtreg/jck and all looks good. Links in JBS. > The test TestButtonGroupFocusTraversal.java is modified such that it

Re: [jdk16] RFR: 8259237: Demo selection changes with left/right arrow key. No need to press space for selection.

2021-01-11 Thread Pankaj Bansal
On Mon, 11 Jan 2021 08:05:21 GMT, Prasanta Sadhukhan wrote: >> Please review a fix for jdk16 >> >> Issue: In SwingSet2, if the user navigates through the demos, the demo gets >> selected/starts on pressing left/right key only. There is no need to press >> the "space" key. Earlier, on pressing

Re: RFR: 8259439: Apply java.io.Serial annotations in java.datatransfer

2021-01-10 Thread Pankaj Bansal
On Fri, 8 Jan 2021 04:51:50 GMT, Sergey Bylokhov wrote: > Please review the application of `@java.io.Serial` annotation (JDK-8202385) > to types in the datatransfer module to enable stricter compile-time checking > of serialization-related declarations. > > This annotation can be applied to t

[jdk16] RFR: 8259237: Demo selection changes with left/right arrow key. No need to press space for selection.

2021-01-09 Thread Pankaj Bansal
Please review a fix for jdk16 Issue: In SwingSet2, if the user navigates through the demos, the demo gets selected/starts on pressing left/right key only. There is no need to press the "space" key. Earlier, on pressing the left/right key, only demo icon used to get focused and user needed to pr

Re: RFR: 8225116: Test OwnedWindowsLeak.java intermittently fails

2020-12-30 Thread Pankaj Bansal
On Sat, 7 Nov 2020 06:55:09 GMT, Sergey Bylokhov wrote: > This test rarely fails in the past on some configurations but was never a > problem listed, and according to the history of CI, it fails 2 times on its > own this year. > > There are two possible reasons for the failure: > 1. At that ti

Re: RFR: 8256109: Create implementation for NSAccessibilityButton protocol

2020-12-17 Thread Pankaj Bansal
On Tue, 1 Dec 2020 22:49:08 GMT, Alexander Zuev wrote: > Creating a native peer for pushbutton accessibility role on Max OS X. > The process of choosing of what peer to initialize is clunky so > might be addressed in the future. @azuev-java I think you need to rebase this PR as you started worki

Re: RFR: 8256109: Create implementation for NSAccessibilityButton protocol [v2]

2020-12-17 Thread Pankaj Bansal
On Wed, 16 Dec 2020 18:03:19 GMT, Alexander Zuev wrote: >> Creating a native peer for pushbutton accessibility role on Max OS X. >> The process of choosing of what peer to initialize is clunky so >> might be addressed in the future. > > Alexander Zuev has updated the pull request incrementally wi

Re: RFR: 8256109: Create implementation for NSAccessibilityButton protocol [v2]

2020-12-16 Thread Pankaj Bansal
On Wed, 16 Dec 2020 18:03:19 GMT, Alexander Zuev wrote: >> Creating a native peer for pushbutton accessibility role on Max OS X. >> The process of choosing of what peer to initialize is clunky so >> might be addressed in the future. > > Alexander Zuev has updated the pull request incrementally wi

[jdk16] Integrated: 8258427: Problem List some tests related to FileDialog for MacOS

2020-12-15 Thread Pankaj Bansal
On Tue, 15 Dec 2020 21:08:14 GMT, Pankaj Bansal wrote: > A few tests related to FileDialog have been failing frequency in our CI build > for MacOS. It is better to problem list those tests before they are fixed. > > Following open repository test will be problem listed. > java

[jdk16] RFR: 8258427: Problem List some tests related to FileDialog for MacOS

2020-12-15 Thread Pankaj Bansal
A few tests related to FileDialog have been failing frequency in our CI build for MacOS. It is better to problem list those tests before they are fixed. Following open repository test will be problem listed. java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java - Commit mes

Integrated: 8225790: Two NestedDialogs tests fail on Ubuntu

2020-10-20 Thread Pankaj Bansal
On Sat, 17 Oct 2020 14:55:39 GMT, Pankaj Bansal wrote: > Two NestedDialog tests are failing on Ubuntu 20.04 intermittently. I am able > to reproduce the issue locally also > sometime. > Tests are creating a frame and then create multiple dialogs. These tests are >

RFR: 8225790: Two NestedDialogs tests fail on Ubuntu

2020-10-17 Thread Pankaj Bansal
Two NestedDialog tests are failing on Ubuntu 20.04 intermittently. I am able to reproduce the issue locally also sometime. Tests are creating a frame and then create multiple dialogs. These tests are using classes VisibilityValidator and Waypoint (present in test/jdk/java/awt/regtesthelpers) for

Re: RFR: 8254349: The TestNoScreenMenuBar test should be updated

2020-10-16 Thread Pankaj Bansal
On Sat, 10 Oct 2020 11:19:05 GMT, Sergey Bylokhov wrote: > This test tries to run an external application to make itself non-active and > then sets and checks the global menu. > > But it has a few issues: > - As an external app, the "System Settings" app is used, but it looks like > in macOS

Withdrawn: 8238436: java/awt/Frame/FrameLocationTest/FrameLocationTest.java fails

2020-10-13 Thread Pankaj Bansal
On Tue, 6 Oct 2020 15:28:45 GMT, Pankaj Bansal wrote: > The test fail intermittently on all platforms, though issue is filled for > only Ubuntu. > The test generated random numbers and sets the frame location to those > random numbers. There are two issues in the > test. 1. The

Withdrawn: 8227077: Test java/awt/Modal/ZOrderTest6271792/ZOrderTest.java fails

2020-10-12 Thread Pankaj Bansal
On Mon, 12 Oct 2020 20:29:18 GMT, Pankaj Bansal wrote: > Test java/awt/Modal/ZOrderTest6271792/ZOrderTest.java fails on Ubuntu 19.04 > and Ubuntu 20.04. The test always fail on > mach5 and locally. > Issue: The test create frames and then does robot mouse clicks on frame > ti

RFR: 8227077: Test java/awt/Modal/ZOrderTest6271792/ZOrderTest.java fails

2020-10-12 Thread Pankaj Bansal
Test java/awt/Modal/ZOrderTest6271792/ZOrderTest.java fails on Ubuntu 19.04 and Ubuntu 20.04. The test always fail on mach5 and locally. Issue: The test create frames and then does robot mouse clicks on frame title. The frames are of less width and on some systems, the robot clicks the minimize

Re: RFR: 8238436: java/awt/Frame/FrameLocationTest/FrameLocationTest.java fails

2020-10-06 Thread Pankaj Bansal
On Tue, 6 Oct 2020 18:13:44 GMT, Sergey Bylokhov wrote: > > The test is setting the frame location and then verifying the location in a > > loop, but there is no wait/delay added to > > let the >frame.setLocation complete. It is intentionally was implemented > > that way, the setLocation sets t

  1   2   >