+1
-phil.
On 07/19/2018 05:33 AM, Mario Torre wrote:
On Wed, Jul 18, 2018 at 11:28 PM, Phil Race wrote:
The review for the original fix was actually on awt-dev which probably was
correct
and so this should be there too.
Hi Phil,
Thanks for the review, and I apologise for posting it to 2d-de
On Wed, Jul 18, 2018 at 11:28 PM, Phil Race wrote:
> The review for the original fix was actually on awt-dev which probably was
> correct
> and so this should be there too.
Hi Phil,
Thanks for the review, and I apologise for posting it to 2d-dev, that
was out of habit :)
> I hadn't seen the thr
The review for the original fix was actually on awt-dev which probably
was correct
and so this should be there too.
I hadn't seen the thread so had to go read it .. but it was so long ago I'd
probably have had to re-read it anyway. But it was not so easy to find
since it did not have the bug ID i
+1
--Semyon
On 7/11/2016 8:10 PM, Alexandr Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 7/11/2016 6:02 PM, Mario Torre wrote:
On Fri, Jul 8, 2016 at 10:05 AM, Alexandr Scherbatiy
wrote:
On 7/4/2016 3:14 PM, Mario Torre wrote:
On Wed, Jun 29, 2016 at 12:40 PM, Mario Tor
On Mon, Jul 11, 2016 at 7:10 PM, Alexandr Scherbatiy
wrote:
> The fix looks good to me.
Great, I just updated my local repository, I'll push as soon as it's
done compiling.
Thanks!
Cheers,
Mario
The fix looks good to me.
Thanks,
Alexandr.
On 7/11/2016 6:02 PM, Mario Torre wrote:
On Fri, Jul 8, 2016 at 10:05 AM, Alexandr Scherbatiy
wrote:
On 7/4/2016 3:14 PM, Mario Torre wrote:
On Wed, Jun 29, 2016 at 12:40 PM, Mario Torre wrote:
Ping?
Ping Ping?
Just a question. The isGtkSup
On Fri, Jul 8, 2016 at 10:05 AM, Alexandr Scherbatiy
wrote:
> On 7/4/2016 3:14 PM, Mario Torre wrote:
>>
>> On Wed, Jun 29, 2016 at 12:40 PM, Mario Torre wrote:
>>>
>>> Ping?
>>
>> Ping Ping?
>
>
> Just a question. The isGtkSupported is moved to be a local variable. It
> seems its value can't b
On 7/4/2016 3:14 PM, Mario Torre wrote:
On Wed, Jun 29, 2016 at 12:40 PM, Mario Torre wrote:
Ping?
Ping Ping?
Just a question. The isGtkSupported is moved to be a local variable.
It seems its value can't be changed in the 'if' condition on the line 60.
Thanks,
Alexandr.
Cheers,
Hi Mario,
The JPRT build was successful. The fix looks good.
I just noticed that there ending space symbols on some lines. It may
cause issues during the push.
--Semyon
On 7/4/2016 5:09 PM, Mario Torre wrote:
On Mon, Jul 4, 2016 at 4:07 PM, Semyon Sadetsky
wrote:
Hello Mario,
I will arr
On Mon, Jul 4, 2016 at 4:07 PM, Semyon Sadetsky
wrote:
> Hello Mario,
>
> I will arrange a new JPRT run this week.
Thanks!
Cheers,
Mario
Hello Mario,
I will arrange a new JPRT run this week.
--Semyon
On 04.07.2016 15:14, Mario Torre wrote:
On Wed, Jun 29, 2016 at 12:40 PM, Mario Torre wrote:
Ping?
Ping Ping?
Cheers,
Mario
On Thu, Jun 16, 2016 at 6:47 PM, Mario Torre wrote:
On Wed, Jun 1, 2016 at 1:52 PM, Semyon Sadetsky
On Wed, Jun 29, 2016 at 12:40 PM, Mario Torre wrote:
> Ping?
Ping Ping?
> Cheers,
> Mario
>
> On Thu, Jun 16, 2016 at 6:47 PM, Mario Torre wrote:
>> On Wed, Jun 1, 2016 at 1:52 PM, Semyon Sadetsky
>> wrote:
>>>
>>>
>>> On 6/1/2016 2:39 PM, Mario Torre wrote:
On Wed, Jun 1, 2016 at 1:
Ping?
Cheers,
Mario
On Thu, Jun 16, 2016 at 6:47 PM, Mario Torre wrote:
> On Wed, Jun 1, 2016 at 1:52 PM, Semyon Sadetsky
> wrote:
>>
>>
>> On 6/1/2016 2:39 PM, Mario Torre wrote:
>>>
>>> On Wed, Jun 1, 2016 at 1:23 PM, Semyon Sadetsky
>>> wrote:
I ran JPRT build. It seems that the b
On Wed, Jun 1, 2016 at 1:52 PM, Semyon Sadetsky
wrote:
>
>
> On 6/1/2016 2:39 PM, Mario Torre wrote:
>>
>> On Wed, Jun 1, 2016 at 1:23 PM, Semyon Sadetsky
>> wrote:
>>>
>>> I ran JPRT build. It seems that the build server does not have the
>>> requested
>>> header:
>>>
>>>
>>> /opt/jprt/T/P1/1022
On 6/1/2016 2:39 PM, Mario Torre wrote:
On Wed, Jun 1, 2016 at 1:23 PM, Semyon Sadetsky
wrote:
I ran JPRT build. It seems that the build server does not have the requested
header:
/opt/jprt/T/P1/102200.ssadetsk/s/jdk/src/java.desktop/unix/native/libawt_xawt/awt/awt_Robot.c:40:39:
fatal error
On Wed, Jun 1, 2016 at 1:23 PM, Semyon Sadetsky
wrote:
> I ran JPRT build. It seems that the build server does not have the requested
> header:
>
> /opt/jprt/T/P1/102200.ssadetsk/s/jdk/src/java.desktop/unix/native/libawt_xawt/awt/awt_Robot.c:40:39:
> fatal error: X11/extensions/Xcomposite.h: No su
I ran JPRT build. It seems that the build server does not have the
requested header:
/opt/jprt/T/P1/102200.ssadetsk/s/jdk/src/java.desktop/unix/native/libawt_xawt/awt/awt_Robot.c:40:39:
fatal error: X11/extensions/Xcomposite.h: No such file or directory
#include
someone need to install Xcomp
Looks fine to me.
Thanks,
Alexander.
On 31/05/16 17:29, Sergey Bylokhov wrote:
Hi, Mario.
Thanks for your contribution! there is tiny typo in the native:
isGtkSupported should be useGtk. It will be good if someone run jprt
job to confirm that the build is ok, since make file was changed.
On
Hi, Mario.
Thanks for your contribution! there is tiny typo in the native:
isGtkSupported should be useGtk. It will be good if someone run jprt job
to confirm that the build is ok, since make file was changed.
On 31.05.16 13:45, Semyon Sadetsky wrote:
On 5/31/2016 1:36 PM, Mario Torre wrote
On 5/31/2016 1:36 PM, Mario Torre wrote:
2016-05-30 17:53 GMT+02:00 Semyon Sadetsky :
The rest is OK to me.
Great, thanks!
This is the final webrev:
http://cr.openjdk.java.net/~neugens/8150954/webrev.04/
Thanks a lot!
Assuming it's still OK for you, I believe I need another reviewer's O
2016-05-30 17:53 GMT+02:00 Semyon Sadetsky :
> The rest is OK to me.
Great, thanks!
This is the final webrev:
http://cr.openjdk.java.net/~neugens/8150954/webrev.04/
Assuming it's still OK for you, I believe I need another reviewer's OK to push?
Cheers,
Mario
--
pgp key: http://subkeys.pgp.ne
On 5/30/2016 1:02 PM, Mario Torre wrote:
2016-04-06 14:02 GMT+02:00 Semyon Sadetsky :
On 4/6/2016 2:19 PM, Mario Torre wrote:
On Wed, Apr 6, 2016 at 12:50 PM, Semyon Sadetsky
wrote:
Hello Mario,
Seems X11 call would be the best solution for AWT Robot screenshots under
Linux. I'm ready to
2016-04-06 14:02 GMT+02:00 Semyon Sadetsky :
>
>
> On 4/6/2016 2:19 PM, Mario Torre wrote:
>>
>> On Wed, Apr 6, 2016 at 12:50 PM, Semyon Sadetsky
>> wrote:
>>>
>>> Hello Mario,
>>>
>>> Seems X11 call would be the best solution for AWT Robot screenshots under
>>> Linux. I'm ready to approve it as a
On Wed, Apr 6, 2016 at 2:02 PM, Semyon Sadetsky
wrote:
> Not compile time switch but run-time. I would introduce a new system
> property, for example "-Dawt.robot.gtk=true". Just in case if your solution
> will stop to work on some platforms or WMs. GTK may be the working
> alternative there.
Al
On 4/6/2016 2:19 PM, Mario Torre wrote:
On Wed, Apr 6, 2016 at 12:50 PM, Semyon Sadetsky
wrote:
Hello Mario,
Seems X11 call would be the best solution for AWT Robot screenshots under
Linux. I'm ready to approve it as a default solution.
But it seems to me better to preserve the current GTK d
On Wed, Apr 6, 2016 at 12:50 PM, Semyon Sadetsky
wrote:
> Hello Mario,
>
> Seems X11 call would be the best solution for AWT Robot screenshots under
> Linux. I'm ready to approve it as a default solution.
> But it seems to me better to preserve the current GTK dependent code as a
> kind of alterna
Hello Mario,
Seems X11 call would be the best solution for AWT Robot screenshots
under Linux. I'm ready to approve it as a default solution.
But it seems to me better to preserve the current GTK dependent code as
a kind of alternative solution for platforms where GTK is better
supported. Is it
On Tue, Mar 8, 2016 at 1:21 PM, Mario Torre wrote:
> Hi Sergey,
>
> Here is a proposed fix for JDK9, it removes the dependencies on GTK
> and use only X11 calls:
>
> http://cr.openjdk.java.net/~neugens/8150954/webrev.02/
>
> I only tried this on a RHEL 7.2 so far but it seems to compile and
> work
This looks preferable to the Gtk+ version. The Gtk+2 version will hit issues
when loading Gtk+2 in Java code where the native code is using Gtk+3 (e.g.
Eclipse, LibreOffice). At the moment, loading Gtk+2 is confined to loading the
look and
feel, but the current changes in 9 would expand its use t
- Original Message -
> Hi Sergey,
>
> Here is a proposed fix for JDK9, it removes the dependencies on GTK
> and use only X11 calls:
>
> http://cr.openjdk.java.net/~neugens/8150954/webrev.02/
>
> I only tried this on a RHEL 7.2 so far but it seems to compile and
> work as expected, and
Hi Sergey,
Here is a proposed fix for JDK9, it removes the dependencies on GTK
and use only X11 calls:
http://cr.openjdk.java.net/~neugens/8150954/webrev.02/
I only tried this on a RHEL 7.2 so far but it seems to compile and
work as expected, and doesn't require to regenerate the configure
machi
On Wed, Mar 2, 2016 at 5:24 PM, Sergey Bylokhov
wrote:
> Hi, Mario.
> I assume that it works exactly the same as gtk version? if yes then it will
> be good to change the code in jdk9 as well and remove this dependency?
You mean to remove the dependency on GTK and use the X11 code?
It would make
Hi, Mario.
I assume that it works exactly the same as gtk version? if yes then it
will be good to change the code in jdk9 as well and remove this dependency?
On 01.03.16 16:23, Mario Torre wrote:
Hi all,
I have a fix for the issue detailed in the following bug report:
https://bugs.openjdk.ja
- Original Message -
> Hi all,
>
> I have a fix for the issue detailed in the following bug report:
>
> https://bugs.openjdk.java.net/browse/JDK-8150954
>
> The issue is does not affect JDK9 so I guess my primary target for the
> bug is jdk8u-dev and the backports will go into 7 and 6 as
Hi all,
I have a fix for the issue detailed in the following bug report:
https://bugs.openjdk.java.net/browse/JDK-8150954
The issue is does not affect JDK9 so I guess my primary target for the
bug is jdk8u-dev and the backports will go into 7 and 6 as needed.
The fix basically checks the _NET_W
35 matches
Mail list logo
