Re: bbdb-mode-map should inherit from special-mode-map

2011-04-19 Thread Ted Zlatanov
On Tue, 19 Apr 2011 08:52:21 +0200 David Engster wrote: DE> Ted Zlatanov writes: >> On Thu, 14 Apr 2011 21:34:15 +0200 David Engster >> wrote: DE> XEmacs is another matter, though. I attached the current logs for XEmacs DE> 21.4 and 21.5. Note that your 'PUSHPATH' eval doesn't work for XEmacs

Re: bbdb-mode-map should inherit from special-mode-map

2011-04-18 Thread David Engster
Ted Zlatanov writes: > On Thu, 14 Apr 2011 21:34:15 +0200 David Engster > wrote: > DE> XEmacs is another matter, though. I attached the current logs for XEmacs > DE> 21.4 and 21.5. Note that your 'PUSHPATH' eval doesn't work for XEmacs; > DE> just use "-L .". > > DE> I can set up a buildbot, but

Re: bbdb-mode-map should inherit from special-mode-map

2011-04-15 Thread Ted Zlatanov
(David, I sent you a courtesy CC but posted to the list through Gmane to avoid the moderator delay) On Thu, 14 Apr 2011 21:34:15 +0200 David Engster wrote: DE> Ted Zlatanov writes: >> On Thu, 14 Apr 2011 12:16:58 -0500 "Roland Winkler" wrote: RW> My main concern is XEmacs support. While I am

Re: bbdb-mode-map should inherit from special-mode-map

2011-04-14 Thread David Engster
Ted Zlatanov writes: > On Thu, 14 Apr 2011 12:16:58 -0500 "Roland Winkler" wrote: > RW> My main concern is XEmacs support. While I am not at all opposed to > RW> having this (re)added to BBDB, it is simply something where I do not > RW> know about and it ranks low on my personal agenda. > > David

Re: bbdb-mode-map should inherit from special-mode-map

2011-04-14 Thread Roland Winkler
On Thu Apr 14 2011 Ted Zlatanov wrote: > On Wed, 13 Apr 2011 14:47:11 -0500 "Roland Winkler" wrote: > > RW> On Wed Apr 13 2011 Ted Zlatanov wrote: > >> It should be possible to support at least Emacs 23.x and XEmacs. Gnus > >> does it so we can look there for potential problems and solutions. >

Re: bbdb-mode-map should inherit from special-mode-map

2011-04-14 Thread Ted Zlatanov
On Wed, 13 Apr 2011 14:47:11 -0500 "Roland Winkler" wrote: RW> On Wed Apr 13 2011 Ted Zlatanov wrote: >> It should be possible to support at least Emacs 23.x and XEmacs. Gnus >> does it so we can look there for potential problems and solutions. >> >> You could ask David Engster , who's setting

Re: bbdb-mode-map should inherit from special-mode-map

2011-04-13 Thread Roland Winkler
On Wed Apr 13 2011 Ted Zlatanov wrote: > It should be possible to support at least Emacs 23.x and XEmacs. Gnus > does it so we can look there for potential problems and solutions. > > You could ask David Engster , who's setting up a > Gnus buildbot, to do the same for BBDB. > > Also you should c

Re: bbdb-mode-map should inherit from special-mode-map

2011-04-13 Thread Ted Zlatanov
On Wed, 13 Apr 2011 11:05:30 -0500 "Roland Winkler" wrote: RW> I do not want to exclude any other dialects of emacs here. But they RW> would most likely require a more systematic overhaul of all code. RW> In that sense, I am a bit hesitant to add support for something that RW> is not spelled out

Re: bbdb-mode-map should inherit from special-mode-map

2011-04-13 Thread Sam Steingold
> * Stefan Monnier [2011-04-13 13:10:15 -0300]: > > As for whether you need `boundp' to set a variable, I think that's not > the case: if your Emacs doesn't obey this variable, setting it > shouldn't do any harm (it'll just be ignored). of course. I just don't want to create a useless variable, t

Re: bbdb-mode-map should inherit from special-mode-map

2011-04-13 Thread Sam Steingold
> * Roland Winkler [2011-04-13 11:05:30 -0500]: > > Just curious: which dialect of emacs do you have in mind here? your predecessor removed my cvs write permissions because he thought I was not careful enough with support of ancient emacsen. this is the only reason for the checks. if you do not c

Re: bbdb-mode-map should inherit from special-mode-map

2011-04-13 Thread Stefan Monnier
>>> + (when (boundp 'revert-buffer-function) >>> +(setq revert-buffer-function 'bbdb-revert-buffer)) >> >> I recommend to use (set (make-local-variable ) ) when setting >> a buffer-local variable, even if you know that the variable is >> automatically buffer-local. One of the benefits is tha

Re: bbdb-mode-map should inherit from special-mode-map

2011-04-13 Thread Roland Winkler
On Wed Apr 13 2011 Sam Steingold wrote: > > * Stefan Monnier [2011-04-13 12:32:42 -0300]: > > > >> + (when (boundp 'revert-buffer-function) > >> +(setq revert-buffer-function 'bbdb-revert-buffer)) > > > > I recommend to use (set (make-local-variable ) ) when setting > > a buffer-local variabl

Re: bbdb-mode-map should inherit from special-mode-map

2011-04-13 Thread Sam Steingold
> * Stefan Monnier [2011-04-13 12:32:42 -0300]: > >> + (when (boundp 'revert-buffer-function) >> +(setq revert-buffer-function 'bbdb-revert-buffer)) > > I recommend to use (set (make-local-variable ) ) when setting > a buffer-local variable, even if you know that the variable is > automatical

Re: bbdb-mode-map should inherit from special-mode-map

2011-04-13 Thread Stefan Monnier
> + (when (boundp 'revert-buffer-function) > +(setq revert-buffer-function 'bbdb-revert-buffer)) I recommend to use (set (make-local-variable ) ) when setting a buffer-local variable, even if you know that the variable is automatically buffer-local. One of the benefits is that you don't need