Re: [Bf-committers] patch #21750: Vectorscope and luma/color waveform for image view

2010-03-28 Thread Xavier Thomas
Hello, I posted a new version of the patch with some of the feature request I recieved, and cleaner code. There is some update problem which apply also to histogram. I will try to track it down and send a separate patch just for it. 2010/3/27 James Ruan : > Great! You've just did what i want and

Re: [Bf-committers] patch #21750: Vectorscope and luma/color waveform for image view

2010-03-27 Thread James Ruan
Great! You've just did what i want and tried to do and you did it even better. I can't wait to use it. One suggestion only: could the calculation be done in another thread as part of prefetch stage in sequencer? 2010/3/26, Xavier Thomas : > 2010/3/25 Paolo Ciccone : >> Xavier, that looks very prom

Re: [Bf-committers] patch #21750: Vectorscope and luma/color waveform for image view

2010-03-25 Thread Xavier Thomas
2010/3/25 Paolo Ciccone : > Xavier, that looks very promising. For the VScope, would it be possible to > to have more clear demarcation of each color area? It would be also helpful > to have the standard line for the skin tone, the single most important > feature of a VScope. For now I reproduce t

Re: [Bf-committers] patch #21750: Vectorscope and luma/color waveform for image view

2010-03-25 Thread Paolo Ciccone
Xavier, that looks very promising. For the VScope, would it be possible to to have more clear demarcation of each color area? It would be also helpful to have the standard line for the skin tone, the single most important feature of a VScope. Lastly, VScopes usually have a marker of some sort, like

Re: [Bf-committers] patch #21750: Vectorscope and luma/color waveform for image view

2010-03-25 Thread Xavier Thomas
2010/3/25 Reuben Martin : > For the WaveForm, would it also be possible to have an option to scope the > YCrCb levels? That would be very beneficial for final output when trying to > keep the levels clamped to CCIR 610 / 709 levels. (The levels allowed for > Luminance are slightly different for

Re: [Bf-committers] patch #21750: Vectorscope and luma/color waveform for image view

2010-03-25 Thread Reuben Martin
Yo, back on Wednesday 24 March 2010 Xavier Thomas was all like: > Test and feedback much appreciated :) > > Screenshot: http://www.pasteall.org/pic/show.php?id=2102 Wow, that looks beautiful. :) For the WaveForm, would it also be possible to have an option to scope the YCrCb levels? That would

Re: [Bf-committers] patch #21750: Vectorscope and luma/color waveform for image view

2010-03-24 Thread Xavier Thomas
Sorry for the bad english, I really should have rested a little before writing. I hope you still understand it :-/ 2010/3/25 Xavier Thomas : > Test and feedback much appreciated :) > > Screenshot: http://www.pasteall.org/pic/show.php?id=2102 > > It works by sampling (number of samples configurable

[Bf-committers] patch #21750: Vectorscope and luma/color waveform for image view

2010-03-24 Thread Xavier Thomas
Test and feedback much appreciated :) Screenshot: http://www.pasteall.org/pic/show.php?id=2102 It works by sampling (number of samples configurable) the image and drawing a point cloud of those sampled data. An option to use full resolution is available but is slow with high res image and both wa