Re: [blink-dev] Developer pain as a result of "introducing blink_wpt_tests"

2022-06-02 Thread 'Weizhong Xia' via blink-dev
Previously you don't need to specify anything in BUILD.gn is because we are downloading the whole "web_tests" folder. Now we want to run legacy tests and wpt in different steps. Under "web_tests/virtual" we have baselines for wpt and pure virtual legacy tests, we can list the folders under

Re: [blink-dev] Intent to Ship: Default SVG cursor size set from OS settings

2022-06-02 Thread Daniel Bratell
LGTM1. It would be better if it was more cross-platform, but I accept that this is the best we can do right now. And I agree that this is close to a bug fix. /Daniel On 2022-06-01 19:00, Sahir Vellani wrote: On Tuesday, May 31, 2022 at 9:31:01 AM UTC-7 mike...@chromium.org wrote: Hi

Re: [blink-dev] Developer pain as a result of "introducing blink_wpt_tests"

2022-06-02 Thread Domenic Denicola
On Thu, Jun 2, 2022 at 3:21 PM Weizhong Xia wrote: > Folks > > I'm sorry to see this has caused inconvenience, and sorry for being late > in response to this, due to the same reason Dom had. > Thanks for responding and listening to our concerns! > > The reason to move baselines to one central

Re: [blink-dev] Developer pain as a result of "introducing blink_wpt_tests"

2022-06-02 Thread 'Weizhong Xia' via blink-dev
Folks I'm sorry to see this has caused inconvenience, and sorry for being late in response to this, due to the same reason Dom had. The reason to move baselines to one central place at this point is to make it possible to specify dependency in BUILD.gn. This is part of the work to use

[blink-dev] PSA: Event.path has been disabled in pre-Beta channels

2022-06-02 Thread Xiaocheng Hu
Hi, As part of the deprecation process, we have disabled the non-standard API Event.path by default on Canary and Dev channels, as well as developer builds. It will remain enabled by default in Beta and Stable channels until the final removal (in M109 as currently planned). The change is made in

Re: [blink-dev] Intent to Deprecate and Remove: navigation to filesystem: URLs in iframes

2022-06-02 Thread Daniel Bratell
Well below our customary threshold level, and unlikely to be used in our blind spots (WebView, enterprise). I think it's safe to remove directly. LGTM1 /Daniel On 2022-06-02 19:40, Mike Taylor wrote: ** *Contact emails* * miketa...@chromium.org, m...@chromium.org

[blink-dev] Intent to Deprecate and Remove: navigation to filesystem: URLs in iframes

2022-06-02 Thread Mike Taylor
** *Contact emails* * miketa...@chromium.org, m...@chromium.org Summary We propose to remove support for navigating to filesystem:// URLs in iframes. Blink component Blink>Storage>FileSystem

[blink-dev] PSA: pylint changes in depot_tools, affecting some presubmit checks

2022-06-02 Thread 'Josip Sokcevic' via infra-announce
TL;DR We are officially deprecating pylint 1.5 in depot_tools. pylint-2.7 will be the new default pylint version. You can opt-in to use pylint 1.5 until its full removal on 2022-07-11. Hi all, The last release of pylint 1.5 was in 2016 and it's not compatible with python3. In the past several

Re: [blink-dev] Intent to Ship : :has() pseudo class

2022-06-02 Thread Chris Harrelson
LGTM3, once the implementation aligns with the WG decisions, there are tests, and the corresponding spec PRs have landed. Congratulations to all who worked on this feature! I think it's a great addition to the platform that developers will really like. On Thu, Jun 2, 2022 at 1:25 AM Daniel

Re: [blink-dev] Intent to Ship : :has() pseudo class

2022-06-02 Thread Byungwoo Lee
There is an update! 1. All the :has() related issues have been resolved in CSSWG . (Thanks to everyone who arranged and discussed!) #6399 Remove the :scope

Re: [blink-dev] Re: Intent to Ship: DisplayMediaStreamConstraints.systemAudio

2022-06-02 Thread 'Harald Alvestrand' via blink-dev
re webrtc trying to skip TAG review ... we were told at one point (a few years back, I think) that we were sending too many TAG reviews; I believe that at that point, something like 1/3 of the outstanding TAG reviews were on relatively small WebRTC features. I guess we scaled back too forcefully

Re: [blink-dev] Re: Intent to Ship: DisplayMediaStreamConstraints.systemAudio

2022-06-02 Thread 'Elad Alon' via blink-dev
> > Is that accurate? Yes. I think one TAG review would be ok. One TAG review requested . I personally thought your explainers were quite readable and nice > Thanks! On Wed, Jun 1, 2022 at 7:15 PM Chris Harrelson wrote: > > > On Wed,

Re: [blink-dev] Intent to Ship : :has() pseudo class

2022-06-02 Thread Daniel Bratell
LGTM2 /Daniel On 2022-06-02 10:05, Yoav Weiss wrote: Thanks for the update! LGTM1 to ship, once we're aligned with the spec and WG decisions. On Thu, Jun 2, 2022 at 9:25 AM Byungwoo Lee wrote: There is an update! 1. All the :has() related issues have been resolved in CSSWG

Re: [blink-dev] Intent to Ship : :has() pseudo class

2022-06-02 Thread Yoav Weiss
Thanks for the update! LGTM1 to ship, once we're aligned with the spec and WG decisions. On Thu, Jun 2, 2022 at 9:25 AM Byungwoo Lee wrote: > There is an update! > >1. All the :has() related issues have been resolved in CSSWG >

Re: [blink-dev] Intent to Ship : :has() pseudo class

2022-06-02 Thread Byungwoo Lee
There is an update! 1. All the :has() related issues have been resolved in CSSWG . (Thanks to everyone who arranged and discussed!) #6399  Remove the :scope dependency