Re: [blink-dev] Re: Intent to Ship: Document picture-in-picture: allow Window's focus() API to focus opener

2024-02-14 Thread Yoav Weiss (@Shopify)
LGTM2 On Wed, Feb 14, 2024 at 9:28 PM Chris Harrelson wrote: > Thanks! > > LGTM1 > > On Wed, Feb 14, 2024 at 11:07 AM 'Tommy Steimel' via blink-dev < > blink-dev@chromium.org> wrote: > >> Landed the PR and added a comment to the TAG thread. Thanks! >> >> On Wed, Feb 14, 2024 at 6:24 AM Yoav

Re: [blink-dev] Intent to Ship: Zstd Content-Encoding

2024-02-14 Thread Nidhi Jaju
On Thu, Feb 15, 2024 at 12:50 AM David Benjamin wrote: > On Wed, Feb 14, 2024 at 9:20 AM Yoav Weiss (@Shopify) < > yoavwe...@chromium.org> wrote: > >> LGTM1 >> >> On Wednesday, February 14, 2024 at 2:36:10 AM UTC+1 Nidhi Jaju wrote: >> >> On Wed, Feb 14, 2024 at 2:48 AM James Hartig >> wrote:

Re: [blink-dev] Re: Intent to Ship: setHTMLUnsafe and parseHTMLUnsafe

2024-02-14 Thread Luke
Hi, In it's current form Chromium's implementation of these functions bypasses trusted types protection. The below WPT tests cover this behaviour: https://wpt.fyi/results/trusted-types/block-string-assignment-to-ShadowRoot-setHTMLUnsafe.html?label=experimental=master

Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-14 Thread Brad Triebwasser
*tl;dr:* We expect at most 200 origins could break, and only ~30 of those may be legitimately using the API. We do track UMA/UKM for the primary API entrypoint function ( GetScreenDetails ) which we expect nearly all

Re: [blink-dev] Re: Intent to Ship: setHTMLUnsafe and parseHTMLUnsafe

2024-02-14 Thread 'Vladimir Levin' via blink-dev
On Wed, Feb 14, 2024 at 1:53 PM Jeffrey Yasskin wrote: > Non-API-owner opinions inline: > > On Wed, Feb 14, 2024 at 1:42 PM 'Vladimir Levin' via blink-dev < > blink-dev@chromium.org> wrote: > >> I just had some clarifying questions >> >> On Wed, Feb 14, 2024 at 1:13 PM Joey Arhar wrote: >> >>>

Re: [blink-dev] Re: Intent to Ship: setHTMLUnsafe and parseHTMLUnsafe

2024-02-14 Thread Jeffrey Yasskin
Non-API-owner opinions inline: On Wed, Feb 14, 2024 at 1:42 PM 'Vladimir Levin' via blink-dev < blink-dev@chromium.org> wrote: > I just had some clarifying questions > > On Wed, Feb 14, 2024 at 1:13 PM Joey Arhar wrote: > >> Some additional notes: >> - This API is tested in the declarative

Re: [blink-dev] Re: Intent to Ship: setHTMLUnsafe and parseHTMLUnsafe

2024-02-14 Thread 'Vladimir Levin' via blink-dev
I just had some clarifying questions On Wed, Feb 14, 2024 at 1:13 PM Joey Arhar wrote: > Some additional notes: > - This API is tested in the declarative ShadowDOM tests in interop2024, > and it is counting against us to not have it enabled by default. > - The future sanitization options will

[blink-dev] Re: Intent to Ship: setHTMLUnsafe and parseHTMLUnsafe

2024-02-14 Thread Joey Arhar
Some additional notes: - This API is tested in the declarative ShadowDOM tests in interop2024, and it is counting against us to not have it enabled by default. - The future sanitization options will be added as an optional second parameter to both methods, so there will not be any compat issues

[blink-dev] Intent to Ship: setHTMLUnsafe and parseHTMLUnsafe

2024-02-14 Thread Joey Arhar
Contact emailsjar...@chromium.org ExplainerNone Specificationhttps://html.spec.whatwg.org/C/#unsafe-html-parsing-methods https://github.com/whatwg/html/pull/9538 Summary The setHTMLUnsafe and parseHTMLUnsafe methods allow Declarative ShadowDOM to be used from javascript. In the future, they

Re: [blink-dev] Re: Intent to Ship: Document picture-in-picture: allow Window's focus() API to focus opener

2024-02-14 Thread Chris Harrelson
Thanks! LGTM1 On Wed, Feb 14, 2024 at 11:07 AM 'Tommy Steimel' via blink-dev < blink-dev@chromium.org> wrote: > Landed the PR and added a comment to the TAG thread. Thanks! > > On Wed, Feb 14, 2024 at 6:24 AM Yoav Weiss (@Shopify) < > yoavwe...@chromium.org> wrote: > >> >> >> On Monday,

[blink-dev] Re: Intent to Ship: Document picture-in-picture: allow Window's focus() API to focus opener

2024-02-14 Thread 'Tommy Steimel' via blink-dev
Landed the PR and added a comment to the TAG thread. Thanks! On Wed, Feb 14, 2024 at 6:24 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > > > On Monday, February 12, 2024 at 10:31:12 PM UTC+1 Tommy Steimel wrote: > > Contact emailsstei...@chromium.org, liber...@chromium.org > >

[blink-dev] Re: Intent to Ship: RTCIceCandidate url and relayProtocol attributes

2024-02-14 Thread 'Philipp Hancke' via blink-dev
Am Mi., 14. Feb. 2024 um 16:09 Uhr schrieb Yoav Weiss (@Shopify) < yoavwe...@chromium.org>: > > > On Monday, February 12, 2024 at 7:52:17 PM UTC+1 philipp...@googlemail.com > wrote: > > Contact emails > > phan...@microsoft.com > > Explainer > > None > > > I think it would be useful to write a few

[blink-dev] Intent to implement and ship: WebAuthn WebDriver backup flags settings

2024-02-14 Thread Nina Satragno
Contact emails nsatra...@chromium.org, chrome-webau...@google.com Specification https://w3c.github.io/webauthn/#sctn-automation, look for backupState and backupEligibility Or, if you prefer, see the merged PR . Summary A set of new attributes for

Re: [blink-dev] Intent to Ship: jitterBufferTarget

2024-02-14 Thread Chris Harrelson
LGTM2 On Wed, Feb 14, 2024 at 9:03 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > LGTM1 > > Thanks for aligning us on an interoperable name!! > > On Wednesday, February 14, 2024 at 4:37:25 PM UTC+1 Henrik Boström wrote: > >> From a code owner and W3C participant's perspective, I'm

Re: [blink-dev] Intent to Prototype and Ship: Standardized CSS zoom

2024-02-14 Thread Yoav Weiss (@Shopify)
Just wanted to say that it's exciting to see this standardized after all these years. Given the manual inspection, it seems like shipping this to 100% with a killswitch is (hopefully) safe enough! On Wed, Feb 14, 2024 at 6:11 PM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > LGTM3 > >

Re: [blink-dev] Intent to Prototype and Ship: Standardized CSS zoom

2024-02-14 Thread Yoav Weiss (@Shopify)
LGTM3 On Wed, Feb 14, 2024 at 6:00 PM Philip Jägenstedt wrote: > LGTM2 > > On Wed, Feb 14, 2024 at 11:53 PM Daniel Bratell > wrote: > > > > LGTM1 > > > > /Daniel > > > > On 2024-02-09 20:24, 'Yotam Hacohen' via blink-dev wrote: > > > > > > > > On Thursday, February 8, 2024 at 6:46:00 PM UTC-8

Re: [blink-dev] Intent to Ship: jitterBufferTarget

2024-02-14 Thread Yoav Weiss (@Shopify)
LGTM1 Thanks for aligning us on an interoperable name!! On Wednesday, February 14, 2024 at 4:37:25 PM UTC+1 Henrik Boström wrote: > From a code owner and W3C participant's perspective, I'm very happy that > we're finally aligning our attribute name with the spec + Firefox' > implementation.

Re: [blink-dev] Intent to Prototype and Ship: Standardized CSS zoom

2024-02-14 Thread Philip Jägenstedt
LGTM2 On Wed, Feb 14, 2024 at 11:53 PM Daniel Bratell wrote: > > LGTM1 > > /Daniel > > On 2024-02-09 20:24, 'Yotam Hacohen' via blink-dev wrote: > > > > On Thursday, February 8, 2024 at 6:46:00 PM UTC-8 Domenic Denicola wrote: > > On Fri, Feb 9, 2024 at 10:55 AM Yotam Hacohen wrote: > > Hey

Re: [blink-dev] Intent to Ship: Support in Chrome for the VoiceIsolation getUserMedia constraint

2024-02-14 Thread Mike Taylor
LGTM3 On 2/14/24 11:49 AM, Chris Harrelson wrote: LGTM2 On Wed, Feb 14, 2024 at 8:46 AM Philip Jägenstedt wrote: LGTM1, some comments inline. On Sat, Feb 3, 2024 at 6:15 AM Per Åhgren wrote: >> >> >> TAG review status >> >> Issues addressed >> This is

Re: [blink-dev] Intent to Prototype and Ship: Standardized CSS zoom

2024-02-14 Thread Daniel Bratell
LGTM1 /Daniel On 2024-02-09 20:24, 'Yotam Hacohen' via blink-dev wrote: On Thursday, February 8, 2024 at 6:46:00 PM UTC-8 Domenic Denicola wrote: On Fri, Feb 9, 2024 at 10:55 AM Yotam Hacohen wrote: Hey Dominic and thanks for the input! On Sunday, February 4, 2024

Re: [blink-dev] Intent to Ship: Cross App and Web Attribution Measurement

2024-02-14 Thread Chris Harrelson
LGTM3 On Wed, Feb 14, 2024 at 7:48 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > LGTM2 > > On Tuesday, February 13, 2024 at 1:42:39 PM UTC+1 Nan Lin wrote: > > On Tue, Feb 13, 2024 at 7:35 AM Yoav Weiss (@Shopify) < > yoavwe...@chromium.org> wrote: > > > > On Tue, Feb 13, 2024 at

Re: [blink-dev] Intent to Ship: Support in Chrome for the VoiceIsolation getUserMedia constraint

2024-02-14 Thread Chris Harrelson
LGTM2 On Wed, Feb 14, 2024 at 8:46 AM Philip Jägenstedt wrote: > LGTM1, some comments inline. > > On Sat, Feb 3, 2024 at 6:15 AM Per Åhgren wrote: > >> > >> > >> TAG review status > >> > >> Issues addressed > >> This is somewhat at odds with the previous response. :) Did you intend > to link a

Re: [blink-dev] Intent to Ship: Support in Chrome for the VoiceIsolation getUserMedia constraint

2024-02-14 Thread Philip Jägenstedt
LGTM1, some comments inline. On Sat, Feb 3, 2024 at 6:15 AM Per Åhgren wrote: >> >> >> TAG review status >> >> Issues addressed >> This is somewhat at odds with the previous response. :) Did you intend to >> link a TAG review and forget? > > Sorry, my bad. I did not remove this from the

Re: [blink-dev] Re: Intent to Ship: WebSocketStream

2024-02-14 Thread Mike Taylor
Hi Adam, Would you mind requesting approvals in the chromestatus entry for the various review gates? On 2/8/24 1:30 AM, Adam Rice wrote: Unfortunately, no partners were ready when we did the OT, so there was no feedback at all. However, we have subsequently received private feedback that

Re: [blink-dev] Intent to Ship: Zstd Content-Encoding

2024-02-14 Thread David Benjamin
On Wed, Feb 14, 2024 at 9:20 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > LGTM1 > > On Wednesday, February 14, 2024 at 2:36:10 AM UTC+1 Nidhi Jaju wrote: > > On Wed, Feb 14, 2024 at 2:48 AM James Hartig wrote: > > My employer ran into the window size during our pre-production

Re: [blink-dev] Intent to Ship: Cross App and Web Attribution Measurement

2024-02-14 Thread Yoav Weiss (@Shopify)
LGTM2 On Tuesday, February 13, 2024 at 1:42:39 PM UTC+1 Nan Lin wrote: On Tue, Feb 13, 2024 at 7:35 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: On Tue, Feb 13, 2024 at 12:10 PM Nan Lin wrote: Hi Yoav, On Tue, Feb 13, 2024 at 3:10 AM Yoav Weiss (@Shopify) <

Re: [blink-dev] Intent to Ship: jitterBufferTarget

2024-02-14 Thread Henrik Boström
>From a code owner and W3C participant's perspective, I'm very happy that we're finally aligning our attribute name with the spec + Firefox' implementation. Thank you Eldar! (Ultimately we should deprecate and remove the old attribute name, but not until this has been shipped for a long time.)

[blink-dev] Re: Intent to Ship: RTCIceCandidate url and relayProtocol attributes

2024-02-14 Thread Yoav Weiss (@Shopify)
On Monday, February 12, 2024 at 7:52:17 PM UTC+1 philipp...@googlemail.com wrote: Contact emails phan...@microsoft.com Explainer None I think it would be useful to write a few sentences on what you want to ship, what's the motivation for shipping it and how we expect web developers to

[blink-dev] Re: Intent to Ship: Document picture-in-picture: allow Window's focus() API to focus opener

2024-02-14 Thread Yoav Weiss (@Shopify)
On Monday, February 12, 2024 at 10:31:12 PM UTC+1 Tommy Steimel wrote: Contact emailsstei...@chromium.org, liber...@chromium.org ExplainerNone Specificationhttps://github.com/WICG/document-picture-in-picture/pull/109 What's preventing the PR from landing? Summary This enables

Re: [blink-dev] Intent to Ship: Zstd Content-Encoding

2024-02-14 Thread Yoav Weiss (@Shopify)
LGTM1 On Wednesday, February 14, 2024 at 2:36:10 AM UTC+1 Nidhi Jaju wrote: On Wed, Feb 14, 2024 at 2:48 AM James Hartig wrote: My employer ran into the window size during our pre-production validation and it was difficult to debug since it was working in cURL, the zstd CLI, and only

Re: [blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-14 Thread 'François Beaufort' via blink-dev
On Wed, Feb 14, 2024 at 10:48 AM Manuel Rego Casasnovas wrote: > > > On 14/02/2024 10:46, François Beaufort wrote: > > > > > > On Wed, Feb 14, 2024 at 10:43 AM Manuel Rego Casasnovas > > wrote: > > > > Hi, > > > > On 13/02/2024 11:13, 'François Beaufort' via

Re: [blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-14 Thread Manuel Rego Casasnovas
On 14/02/2024 10:46, François Beaufort wrote: On Wed, Feb 14, 2024 at 10:43 AM Manuel Rego Casasnovas > wrote: Hi, On 13/02/2024 11:13, 'François Beaufort' via blink-dev wrote: > >         Is this feature fully tested by web-platform-tests >

Re: [blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-14 Thread 'François Beaufort' via blink-dev
On Wed, Feb 14, 2024 at 10:43 AM Manuel Rego Casasnovas wrote: > Hi, > > On 13/02/2024 11:13, 'François Beaufort' via blink-dev wrote: > > > > Is this feature fully tested by web-platform-tests > > < >

Re: [blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-14 Thread Manuel Rego Casasnovas
Hi, On 13/02/2024 11:13, 'François Beaufort' via blink-dev wrote: Is this feature fully tested by web-platform-tests ? Yes https://wpt.fyi/results/css/mediaqueries/display-mode.html

Re: [blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-14 Thread 'François Beaufort' via blink-dev
On Wed, Feb 14, 2024 at 9:36 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > LGTM1 > > This seems like a small and useful extension to Document > picture-in-picture. > > On Tue, Feb 13, 2024 at 11:13 AM 'François Beaufort' via blink-dev < > blink-dev@chromium.org> wrote: > >> Contact

Re: [blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-14 Thread Yoav Weiss (@Shopify)
LGTM1 This seems like a small and useful extension to Document picture-in-picture. On Tue, Feb 13, 2024 at 11:13 AM 'François Beaufort' via blink-dev < blink-dev@chromium.org> wrote: > Contact emailsfbeauf...@google.com > > ExplainerNone > > Specification >