RE: [blink-dev] Intent to Ship: Custom Highlight API

; Sanket Joshi (EDGE) ; Fernando Fiori ; Bo Cupp ; Luis Juan Sanchez Padilla ; rby...@chromium.org ; flo...@rivoal.net Subject: RE: [blink-dev] Intent to Ship: Custom Highlight API Thanks for following through with that fix and reland! Highlight API has shipped: https://chromium

RE: [blink-dev] Intent to Ship: Custom Highlight API

...@chromium.org ; blink-dev ; Manuel Rego ; Sanket Joshi (EDGE) ; Fernando Fiori ; Bo Cupp ; Luis Juan Sanchez Padilla ; rby...@chromium.org ; flo...@rivoal.net ; Daniel Clark Subject: Re: [blink-dev] Intent to Ship: Custom Highlight API You don't often get email from de...@azabani.com<mailto

Re: [blink-dev] Intent to Ship: Custom Highlight API

On Friday, 24 June 2022 at 3:42:07 pm UTC+8 Delan Azabani wrote: > I think all of the blocking spec issues are now resolved or at consensus, > so the only thing left is the Chromium OS performance regression in bug > 1335762 . It’s hard to give a time estimate on >

RE: [blink-dev] Intent to Ship: Custom Highlight API

Cobos Álvarez ; Rick Byers ; Florian Rivoal Subject: Re: [blink-dev] Intent to Ship: Custom Highlight API One comment about this feature and legacy layout. It seems ::highlight customization is only supported in LayoutNG for most properties (only background-color works in legacy). I'm

Re: [blink-dev] Intent to Ship: Custom Highlight API

One comment about this feature and legacy layout. It seems ::highlight customization is only supported in LayoutNG for most properties (only background-color works in legacy). I'm wondering if we should add some kind of console warning message, like for Container Queries [*], so if people see

Re: [blink-dev] Intent to Ship: Custom Highlight API

On 2022-06-22 19:36, Daniel Clark wrote: > Shipping in 105 seems like a good target (branch date Thu, Jul 21, 2022). We > still need HighlightOverlayPainting > (https://chromium-review.googlesource.com/c/chromium/src/+/3640642) to reland > first. I believe @Delan Azabani/@Manuel Rego

RE: [blink-dev] Intent to Ship: Custom Highlight API

Daniel Clark ; Manuel Rego ; Sanket Joshi (EDGE) ; Fernando Fiori ; Bo Cupp ; Luis Juan Sanchez Padilla ; Delan Azabani ; Rick Byers ; flo...@rivoal.net Subject: Re: [blink-dev] Intent to Ship: Custom Highlight API When do you hope to ship? Joe Medley | Technical Writer, Chrome DevRel | jmed..

Re: [blink-dev] Intent to Ship: Custom Highlight API

ew Highlight(new Range()); >> >> return true; >> >> } catch(ex) { >> >> return false; >> >> }; >> >> } >> >> >> >> -- Dan >> >> >> >> *From:* Yoav Weiss >> *Sent:* Wednesday

Re: [blink-dev] Intent to Ship: Custom Highlight API

Cupp ; Luis Juan Sanchez Padilla ; Delan Azabani ; Emilio Cobos Alvarez ; Rick Byers ; flo...@rivoal.net ; Daniel Clark *Subject:* Re: [blink-dev] Intent to Ship: Custom Highlight API On Thursday, June 9, 2022 at 6:55:06 AM UTC+2 Manuel Rego wrote: I'm biase

Re: [blink-dev] Intent to Ship: Custom Highlight API

new Highlight(new Range()); >> >> return true; >> >> } catch(ex) { >> >> return false; >> >> }; >> >> } >> >> >> >> -- Dan >> >> >> >> *From:* Yoav Weiss >> *Sent:* W

Re: [blink-dev] Intent to Ship: Custom Highlight API

Range()); > > return true; > > } catch(ex) { > > return false; > > }; > > } > > > > -- Dan > > > > *From:* Yoav Weiss > *Sent:* Wednesday, June 15, 2022 1:32 AM > *To:* blink-dev > *Cc:* Manuel Rego ; Sanket Joshi (EDGE) <

Re: [blink-dev] Intent to Ship: Custom Highlight API

t Joshi (EDGE) < > sa...@microsoft.com>; Fernando Fiori ; Bo Cupp < > pc...@microsoft.com>; Luis Juan Sanchez Padilla ; > Delan Azabani ; Emilio Cobos Alvarez < > emi...@mozilla.com>; Rick Byers ; flo...@rivoal.net < > flor...@rivoal.net>; Daniel Clark &

RE: [blink-dev] Intent to Ship: Custom Highlight API

; }; } -- Dan From: Yoav Weiss Sent: Wednesday, June 15, 2022 1:32 AM To: blink-dev Cc: Manuel Rego ; Sanket Joshi (EDGE) ; Fernando Fiori ; Bo Cupp ; Luis Juan Sanchez Padilla ; Delan Azabani ; Emilio Cobos Alvarez ; Rick Byers ; flo...@rivoal.net ; Daniel Clark Subject: Re: [blink-d

Re: [blink-dev] Intent to Ship: Custom Highlight API

On Thursday, June 9, 2022 at 6:55:06 AM UTC+2 Manuel Rego wrote: > I'm biased here as I've been working on this feature myself, so I cannot > give an official LGTM. > > Thanks for all the work since the previous intent thread, I believe this > is now in a way better status to ship. > > I'd

Re: [blink-dev] Intent to Ship: Custom Highlight API

I'm biased here as I've been working on this feature myself, so I cannot give an official LGTM. Thanks for all the work since the previous intent thread, I believe this is now in a way better status to ship. I'd be fine giving a LGTM with the following caveats: * As mentioned at the end of the

Re: [blink-dev] Intent to Ship: Custom Highlight API

Thanks for all the additional discussion and context. I wasn't aware of what a shaky ground we were on here today. I agree with the conclusion that we should firm it up somewhat before shipping this new API. So consider my LGTM rescinded for now. But please come back once you feel the highlighting

Re: [blink-dev] Intent to Ship: Custom Highlight API

On 18/08/2021 18:15, Delan Azabani wrote: > I think it was a mistake for Blink to ship ::target-text in this kind of > state, and given the wider range of use cases that ::highlight aims to > solve, I think it would be at least as much of a mistake here. I agree with this. ::target-text has a

Re: [blink-dev] Intent to Ship: Custom Highlight API

> On Aug 19, 2021, at 1:15, Delan Azabani wrote: > > I’m also excited to see this feature ship, as it’s pretty relevant to our > work at Igalia, but I feel I must share and expand on Florian’s concerns > about our current behaviour. > > On Wednesday, August 18, 2021 at 12:27:04 AM UTC+8

Re: [blink-dev] Intent to Ship: Custom Highlight API

I’m also excited to see this feature ship, as it’s pretty relevant to our work at Igalia, but I feel I must share and expand on Florian’s concerns about our current behaviour. On Wednesday, August 18, 2021 at 12:27:04 AM UTC+8 Daniel Clark wrote: > Our thinking on this is that this first

RE: [blink-dev] Intent to Ship: Custom Highlight API

> Cc: Fernando Fiori mailto:ffi...@microsoft.com>>; Bo Cupp mailto:pc...@microsoft.com>>; Sanket Joshi (EDGE) mailto:sa...@microsoft.com>> Subject: Re: [blink-dev] Intent to Ship: Custom Highlight API Is Safari actually shipping it? What I see is that they implement it as a (de