Re: [OpenJDK 2D-Dev] Add optional support for using the system libicu

2013-07-24 Thread Omair Majid
Hi Steven, On 07/03/2013 03:19 PM, Steven R. Loomis wrote: > Omair, > I didn't hear back from you on this list, but I will reply here with > more details. Sorry about the delay, I got busy with unrelated work. > See diffs below. I would be very suspicious of how this > could run without cras

Re: [OpenJDK 2D-Dev] Add optional support for using the system libicu

2013-07-03 Thread Steven R. Loomis
Omair, I didn't hear back from you on this list, but I will reply here with more details. See diffs below. I would be very suspicious of how this could run without crashing, if the tests I mentioned were run (anything with 'kerning' in its name, using a font that actually uses kerning pairs

Re: [OpenJDK 2D-Dev] Add optional support for using the system libicu

2013-06-24 Thread Steven R. Loomis
Omair, I'm sorry I did not see this before. I probably would not have noticed it except I happened to notice this reply. I'm responsible for maintaining the version of ICU in JDK, and also (read: main day job) IBM's lead for ICU for C/C++. ( But I speak for myself here, of course. ) I t

Re: Add optional support for using the system libicu

2013-06-24 Thread Omair Majid
Hi Phil, Updated webrev: http://cr.openjdk.java.net/~omajid/webrevs/system-icu/01/ It's still against jdk8/build and missing support for the old build system. On 06/05/2013 02:02 PM, Phil Race wrote: > Since this entirely affects a 2D component, please include 2d-dev in > this discussion. > I wo

Re: Add optional support for using the system libicu

2013-06-24 Thread Omair Majid
Hi Erik, Thanks for your comments. Sorry I couldn't get back to you earlier, I was busy with a conference. Here's an updated webrev: http://cr.openjdk.java.net/~omajid/webrevs/system-icu/01/ On 06/05/2013 05:21 AM, Erik Joelsson wrote: > Is it required to remove the font/layout dir to use the sy

Re: Add optional support for using the system libicu

2013-06-05 Thread Jonathan Gibbons
On 06/05/2013 02:50 PM, Joe Darcy wrote: I don't think it is tenable to have long-term maintenance of two build systems. Any remaining blockers in the new build should be addressed so the old build can be put out to pasture. -Joe ... implying that we should make sure that blockers are filed

Re: Add optional support for using the system libicu

2013-06-05 Thread Joe Darcy
I don't think it is tenable to have long-term maintenance of two build systems. Any remaining blockers in the new build should be addressed so the old build can be put out to pasture. -Joe On 6/5/2013 1:50 PM, Phil Race wrote: Heavens no. Its a blessing. I sometimes do development work in 7 b

Re: Add optional support for using the system libicu

2013-06-05 Thread Phil Race
Heavens no. Its a blessing. I sometimes do development work in 7 because I can't get the new build to work, or to work the way I want. I don't think I've ever gotten it to build on Windows. The old build saves me time, disk space and repo maintenance headaches. -phil. On 6/5/2013 1:40 PM, Alan B

Re: Add optional support for using the system libicu

2013-06-05 Thread Alan Bateman
On 05/06/2013 19:02, Phil Race wrote: Yes, please support the old build system. Is this really necessary? The old build is a tax and we really need it to die. In this case, it's a new feature and I don't see any point in anyone spending time adding this support to the old build. -Alan

Re: Add optional support for using the system libicu

2013-06-05 Thread Phil Race
Omair, Since this entirely affects a 2D component, please include 2d-dev in this discussion. I would have been 'surprised' to see this change if I hadn't just spotted this thread. And I believe this change should be integrated via the 2D forest. Yes, please support the old build system. I am no

Re: Add optional support for using the system libicu

2013-06-05 Thread Erik Joelsson
Hello, Is it required to remove the font/layout dir to use the system version? I would expect USE_EXTERNAL_ICU_LE=true would add an exclude for that directory to SetupNativeCompilation,BUILD_LIBFONTMANAGER. If you expect to delete the source tree on your side, why not have configure check fo

Add optional support for using the system libicu

2013-06-04 Thread Omair Majid
Hi, webrev: http://cr.openjdk.java.net/~omajid/webrevs/system-icu/00/ This implements support for linking against the system-installed ICU instead of building and linking against the bundled copy of ICU in OpenJDK8. Now someone building OpenJDK can delete the .../font/layout directory and use con