Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Jayathirth D V
On Mon, 27 Feb 2023 22:58:55 GMT, Phil Race wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comment > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 126: > >> 124: # about initializing a declared

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v3]

2023-02-27 Thread Jayathirth D V
> Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of > gcc optimizations from -O1 level for libawt build. This improved our J2DBench > performance numbers in some options considerably. > > Recent changes done under https://bugs.openjdk.org/browse/JDK-8299337 causes > dif

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Jayathirth D V
On Mon, 27 Feb 2023 23:02:15 GMT, Phil Race wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comment > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 130: > >> 128: BUILD_LIBAWT_debug_mem.c_CFLA

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Phil Race
On Mon, 27 Feb 2023 16:16:50 GMT, Jayathirth D V wrote: >> Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of >> gcc optimizations from -O1 level for libawt build. This improved our >> J2DBench performance numbers in some options considerably. >> >> Recent changes done

Re: RFR: 8303130: Document required Accessibility permissions on macOS

2023-02-27 Thread Alexey Ivanov
On Mon, 27 Feb 2023 20:54:08 GMT, Sergey Bylokhov wrote: >> Added the section devoted to client UI test which use Robot API > > doc/testing.html line 621: > >> 619: the following apps are allowed to control your computer: >> 620: Java and Terminal. If the tests are run from >> 621: an IDE, the I

Re: RFR: 8303130: Document required Accessibility permissions on macOS

2023-02-27 Thread Sergey Bylokhov
On Mon, 27 Feb 2023 15:54:28 GMT, Dmitry Markov wrote: > Added the section devoted to client UI test which use Robot API doc/testing.html line 621: > 619: the following apps are allowed to control your computer: > 620: Java and Terminal. If the tests are run from > 621: an IDE, the IDE should b

Re: RFR: 8303130: Document required Accessibility permissions on macOS

2023-02-27 Thread Alexey Ivanov
On Mon, 27 Feb 2023 15:54:28 GMT, Dmitry Markov wrote: > Added the section devoted to client UI test which use Robot API doc/testing.md line 616: > 614: system key shortcuts for various platforms are provided below. > 615: > 616: # MacOS Suggestion: # macOS Shall we spell _macOS_ wi

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Erik Joelsson
On Mon, 27 Feb 2023 16:16:50 GMT, Jayathirth D V wrote: >> Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of >> gcc optimizations from -O1 level for libawt build. This improved our >> J2DBench performance numbers in some options considerably. >> >> Recent changes done

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Patrick Chen
lgtm Le lun. 27 févr. 2023 à 17:17, Jayathirth D V a écrit : > > Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level > of gcc optimizations from -O1 level for libawt build. This improved our > J2DBench performance numbers in some options considerably. > > > > Recent changes

Integrated: 8301119: Support for GB18030-2022

2023-02-27 Thread Naoto Sato
On Fri, 10 Feb 2023 20:35:58 GMT, Naoto Sato wrote: > Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since > this is not a compatible upgrade to the existing mapping, a new system > property `jdk.charset.GB18030` is introduced. If it is set to "2000", the > mapping falls

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Jayathirth D V
On Mon, 27 Feb 2023 15:14:22 GMT, Erik Joelsson wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comment > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 132: > >> 130: # that any cleanup of cod

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Jayathirth D V
> Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of > gcc optimizations from -O1 level for libawt build. This improved our J2DBench > performance numbers in some options considerably. > > Recent changes done under https://bugs.openjdk.org/browse/JDK-8299337 causes > dif

RFR: 8303130: Document required Accessibility permissions on macOS

2023-02-27 Thread Dmitry Markov
Added the section devoted to client UI test which use Robot API - Commit messages: - 8303130: Document required Accessibility permissions on macOS Changes: https://git.openjdk.org/jdk/pull/12772/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12772&range=00 Issue: https://

Re: RFR: 8302659: Modernize Windows native code for NetworkInterface [v3]

2023-02-27 Thread Rich DiCroce
On Mon, 27 Feb 2023 15:25:16 GMT, Alan Bateman wrote: >> Rich DiCroce has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Forgot to add file >> - Resolve review comments > > src/java.base/windows/native/libnet/NetworkInterface.h line 39:

Re: RFR: 8302659: Modernize Windows native code for NetworkInterface [v3]

2023-02-27 Thread Alan Bateman
On Wed, 22 Feb 2023 17:40:31 GMT, Rich DiCroce wrote: >> Improves performance and correctness, as discussed on the net-dev mailing >> list. > > Rich DiCroce has updated the pull request incrementally with two additional > commits since the last revision: > > - Forgot to add file > - Resolve

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64

2023-02-27 Thread Erik Joelsson
On Mon, 27 Feb 2023 11:49:27 GMT, Jayathirth D V wrote: > Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of > gcc optimizations from -O1 level for libawt build. This improved our J2DBench > performance numbers in some options considerably. > > Recent changes done under

Re: RFR: 8295884: Implement IDE support for Eclipse [v31]

2023-02-27 Thread Julian Waters
> Eclipse is a popular and very well-known IDE in the world of Java > development, utilized widely in many contexts, by beginners and experienced > teams alike. Although a relatively lightweight IDE, it features surprisingly > powerful indexing and code analysis capabilities, as well as useful t

Re: RFR: 8302659: Modernize Windows native code for NetworkInterface [v3]

2023-02-27 Thread Rich DiCroce
On Wed, 22 Feb 2023 17:40:31 GMT, Rich DiCroce wrote: >> Improves performance and correctness, as discussed on the net-dev mailing >> list. > > Rich DiCroce has updated the pull request incrementally with two additional > commits since the last revision: > > - Forgot to add file > - Resolve

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Thu, 16 Feb 2023 11:29:51 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/jdk/internal/classfile/components/CodeStackTracker.java >> line 43: >> >>> 41: >>> 42: /** >>> 43: * CodeStackTracker is a {@link jdk.internal.classfile.CodeTransform} >>> synchronously tracking >>

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Thu, 16 Feb 2023 11:21:29 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/components/Cod

Re: RFR: 8294982: Implementation of Classfile API [v27]

2023-02-27 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one. >

Re: RFR: 8294982: Implementation of Classfile API [v26]

2023-02-27 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one. >

Re: RFR: 8294982: Implementation of Classfile API [v25]

2023-02-27 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one. >

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Mon, 27 Feb 2023 11:54:53 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/components/ClassRemapper.java >> line 168: >> >>> 166: public void accept(ClassBuilder clb, ClassElement cle) { >>> 167: switch (cle) { >>> 168: case Fi

RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64

2023-02-27 Thread Jayathirth D V
Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of gcc optimizations from -O1 level for libawt build. This improved our J2DBench performance numbers in some options considerably. Recent changes done under https://bugs.openjdk.org/browse/JDK-8299337 causes difference in g

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Thu, 16 Feb 2023 11:09:30 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/components/Cla

Re: RFR: 8294982: Implementation of Classfile API [v24]

2023-02-27 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one. >

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Thu, 16 Feb 2023 10:54:00 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/components/Cla

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Thu, 16 Feb 2023 10:51:10 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/components/Cla

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Fri, 17 Feb 2023 17:09:51 GMT, Maurizio Cimadamore wrote: >> Yes, the print structure does not exactly correspond to the Classfile API >> architecture, but rather to the classfile physical structure and it is >> partly similar to `javap` output. >> The common tree structure has been reverse