On Fri, 10 Mar 2023 05:09:49 GMT, Mandy Chung wrote:
>> Don't we have a conditional compilation ability with these template files
>> such that we can just generate true or false depending on the OS?
>
> Good point. `OperatingSystemProps.java` can be a OS-specific class like:
>
> src/java.base
On Fri, 10 Mar 2023 02:51:43 GMT, David Holmes wrote:
>> Using the naming from the build makes it clearer that there is a dependency
>> between the build names and those in the template.
>
> Don't we have a conditional compilation ability with these template files
> such that we can just genera
On Thu, 9 Mar 2023 17:18:35 GMT, Roger Riggs wrote:
>> That would not yield a compile time constant.
>> The TARGET_IS_XXX values must evaluate to compile time constants as
>> evaluated by javac.
>
> Using the naming from the build makes it clearer that there is a dependency
> between the build
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Thu, 9 Mar 2023 16:12:26 GMT, Roger Riggs wrote:
On Thu, 9 Mar 2023 17:12:53 GMT, Roger Riggs wrote:
>>> I would argue that we should keep the replacement string matching the make
>>> variable its getting the value from. It makes it easier to trace the origin
>>> of the value.
>>
>> Then we can define a new make variable that will also allow
On Thu, 9 Mar 2023 16:01:21 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/jdk/internal/misc/OperatingSystem.java line 74:
>>
>>> 72: * The Mac OS X Operating system.
>>> 73: */
>>> 74: Mac("Mac OS X"),
>>
>> The current spelling used by Apple is "macOS", probably to align
On Thu, 9 Mar 2023 16:11:19 GMT, Roger Riggs wrote:
> > Has this totally killed of BSD support on the JDK side? I thought building
> > non-macOS BSD was still viable, but perhaps not - certainly not after this
> > change.
>
> I haven't found any use of BSD and I don't think the build supports
On Mon, 6 Mar 2023 20:28:22 GMT, Christoph Langer wrote:
> When building Fedora based Linux devkits, rpm packages are downloaded from
> locations at the Fedora project.
> The latest/active versions reside under https://dl.fedoraproject.org while
> older, archived versions live at https://archiv
On Mon, 6 Mar 2023 20:28:22 GMT, Christoph Langer wrote:
> When building Fedora based Linux devkits, rpm packages are downloaded from
> locations at the Fedora project.
> The latest/active versions reside under https://dl.fedoraproject.org while
> older, archived versions live at https://archiv
Thanks Erik!
For the record, I found this while working on a micro benchmark experiment
which was using some code from the test lib. Probably not something people
do very often :-)
Eirik.
On Thu, Mar 9, 2023 at 3:50 PM wrote:
> Hello Eirik,
>
> While this target isn't often used (as can be see
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Wed, 8 Mar 2023 23:23:38 GMT, Mandy Chung wrote:
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote:
> Improvements to support OS specific customization for JDK internal use:
> - To select values and code; allowing elimination of unused code and values
> - Optionally evaluated by build processes, compilation, or archiving (i.e.
> CDS)
> - S
The Make target 'build-test-lib-target' is broken in a few ways:
- make/test/BuildTestLib.gmk references the directory
$(TEST_LIB_SOURCE_DIR)/sun which does not seem to exist. This can be fixed by
removing the reference.
- Some test-lib sources use preview-features which is not enabled by
make/
On Thu, 9 Mar 2023 19:24:37 GMT, Daniel D. Daugherty wrote:
> > Unfortunately standard tier1 - 3 tests execution does not involve javadoc
> > generation...
>
> I'm not sure what this sentence means since this build failure was caught
> with a standard Mach5 Tier1 job set, i.e., mach5 -j tier1
On Thu, 9 Mar 2023 19:16:21 GMT, Adam Sotona wrote:
> Unfortunately standard tier1 - 3 tests execution does not involve javadoc
> generation...
I'm not sure what this sentence means since this build failure was caught with
a standard Mach5 Tier1 job set, i.e., mach5 -j tier1 ...
-
On Thu, 9 Mar 2023 19:16:21 GMT, Adam Sotona wrote:
> Newly added Classfile API is based on pattern matching preview feature.
> Unfortunately standard tier1 - 3 tests execution does not involve javadoc
> generation and so it didn't discover missing preview option.
>
> Please review this patch e
On Thu, 9 Mar 2023 19:16:21 GMT, Adam Sotona wrote:
> Newly added Classfile API is based on pattern matching preview feature.
> Unfortunately standard tier1 - 3 tests execution does not involve javadoc
> generation and so it didn't discover missing preview option.
>
> Please review this patch e
Newly added Classfile API is based on pattern matching preview feature.
Unfortunately standard tier1 - 3 tests execution does not involve javadoc
generation and so it didn't discover missing preview option.
Please review this patch enabling preview for javadoc generation, until pattern
matching
> Eclipse is a popular and very well-known IDE in the world of Java
> development, utilized widely in many contexts, by beginners and experienced
> teams alike. Although a relatively lightweight IDE, it features surprisingly
> powerful indexing and code analysis capabilities, as well as useful t
On Thu, 9 Mar 2023 16:05:56 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/jdk/internal/misc/OperatingSystem.java line 98:
>>
>>> 96: @ForceInline
>>> 97: public static boolean isLinux() {
>>> 98: return OperatingSystemProps.TARGET_OS_IS_LINUX;
>>
>> Suggestion:
>>
>>
On Thu, 9 Mar 2023 17:07:28 GMT, Mandy Chung wrote:
>> The one in the template file is independent to the build variables.
>
>> I would argue that we should keep the replacement string matching the make
>> variable its getting the value from. It makes it easier to trace the origin
>> of the val
On Thu, 9 Mar 2023 17:03:05 GMT, Mandy Chung wrote:
>> The symbol has to match the build usage of OPENJDK_TARGET_OS, not the name.
>
> The one in the template file is independent to the build variables.
> I would argue that we should keep the replacement string matching the make
> variable its
Hi Justin,
How would I go about building one of those? Or knowing what the
dependencies are?
Thanks, Roger
On 3/8/23 11:02 PM, Justin King wrote:
Let's please not kill generic BSD support if at all possible. There is
NetBSD, OpenBSD, FreeBSD, and DragonflyBSD. I know FreeBSD and NetBSD
hav
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Thu, 9 Mar 2023 16:03:37 GMT, Roger Riggs wrote:
On Wed, 8 Mar 2023 23:09:06 GMT, Mandy Chung wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archiving (i.e.
>> CDS)
>>
On Thu, 9 Mar 2023 00:45:02 GMT, Naoto Sato wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archiving (i.e.
>> CDS)
>>
On Thu, 9 Mar 2023 15:24:04 GMT, Erik Joelsson wrote:
>> src/java.base/share/classes/jdk/internal/misc/OperatingSystemProps.java.template
>> line 39:
>>
>>> 37:
>>> 38: // Index/ordinal of the current OperatingSystem enum as substituted
>>> by the build
>>> 39: static final int TARGET
On Wed, 8 Mar 2023 23:11:34 GMT, Mandy Chung wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archiving (i.e.
>> CDS)
>>
On Wed, 8 Mar 2023 22:49:05 GMT, Raffaello Giulietti
wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archiving (i.e.
>
On Thu, 9 Mar 2023 02:51:24 GMT, David Holmes wrote:
> Has this totally killed of BSD support on the JDK side? I thought building
> non-macOS BSD was still viable, but perhaps not - certainly not after this
> change.
I haven't found any use of BSD and I don't think the build supports a BSD bui
On Tue, 7 Mar 2023 16:42:55 GMT, Julian Waters wrote:
> Currently support for Visual Studio development always assumes server as the
> variant to use. More accurately this should instead be set to the primary
> variant instead
This pull request has now been integrated.
Changeset: 3227b49a
Aut
On Thu, 9 Mar 2023 11:35:12 GMT, Julian Waters wrote:
>> Currently support for Visual Studio development always assumes server as the
>> variant to use. More accurately this should instead be set to the primary
>> variant instead
>
> Julian Waters has updated the pull request with a new target
On Thu, 9 Mar 2023 11:35:12 GMT, Julian Waters wrote:
>> Currently support for Visual Studio development always assumes server as the
>> variant to use. More accurately this should instead be set to the primary
>> variant instead
>
> Julian Waters has updated the pull request with a new target
On Tue, 7 Mar 2023 16:44:26 GMT, Julian Waters wrote:
>> Eclipse is a popular and very well-known IDE in the world of Java
>> development, utilized widely in many contexts, by beginners and experienced
>> teams alike. Although a relatively lightweight IDE, it features surprisingly
>> powerful
On Thu, 9 Mar 2023 06:12:26 GMT, Harshitha Onkar wrote:
>> HarfBuzz library updated from v4.4.1 to v7.0.1
>>
>> - harfbuzz.md file updated
>> - Added -DHB_NO_VISIBILITY to HARFBUZZ_CFLAGS in Awt2DLibraries.gmk to avoid
>> build issues on linux and macos targets.
>> - GPOS.hh moved to Layout to
On Fri, 4 Nov 2022 12:38:04 GMT, Adam Sotona wrote:
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk
On Wed, 8 Mar 2023 22:21:08 GMT, Mandy Chung wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archiving (i.e.
>> CDS)
>>
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote:
On Mon, 6 Mar 2023 20:28:22 GMT, Christoph Langer wrote:
> When building Fedora based Linux devkits, rpm packages are downloaded from
> locations at the Fedora project.
> The latest/active versions reside under https://dl.fedoraproject.org while
> older, archived versions live at https://archiv
Hello Eirik,
While this target isn't often used (as can be seen from how far it's bit
rotted without anyone noticing), I think it's worth fixing it now that
you have identified the issues. There is some value in being able to
explicitly build these classes even if they are usually built by jtr
> Was: sunmscapi.dll cannot compile with Visual C++
>
> `-Zc:wchar_t-` has, until now, been passed to switch off wchar_t as a
> distinct C++ type when compiling with Visual C++ so jchar and wchar_t are
> typedef'd to shorts on Windows. After some examination it appears this flag
> is not actual
On Thu, 9 Mar 2023 12:00:55 GMT, Daniel Jeliński wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> comm
On Thu, 9 Mar 2023 11:35:22 GMT, Julian Waters wrote:
>> Was: sunmscapi.dll cannot compile with Visual C++
>>
>> `-Zc:wchar_t-` has, until now, been passed to switch off wchar_t as a
>> distinct C++ type when compiling with Visual C++ so jchar and wchar_t are
>> typedef'd to shorts on Windows.
> Was: sunmscapi.dll cannot compile with Visual C++
>
> `-Zc:wchar_t-` has, until now, been passed to switch off wchar_t as a
> distinct C++ type when compiling with Visual C++ so jchar and wchar_t are
> typedef'd to shorts on Windows. After some examination it appears this flag
> is not actual
> Currently support for Visual Studio development always assumes server as the
> variant to use. More accurately this should instead be set to the primary
> variant instead
Julian Waters has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev exclu
> security.cpp contains a few invalid implicit conversions between pointer
> types that will not fly when the permissive- compiler option is active. Given
> that permissive- will become the Visual C++ compiler's default mode of
> operation in the future, it is better to handle this now so future
On Tue, 7 Mar 2023 16:44:26 GMT, Julian Waters wrote:
>> Eclipse is a popular and very well-known IDE in the world of Java
>> development, utilized widely in many contexts, by beginners and experienced
>> teams alike. Although a relatively lightweight IDE, it features surprisingly
>> powerful
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Tue, 7 Mar 2023 16:42:55 GMT, Julian Waters wrot
48 matches
Mail list logo
