Re: RFR: 8306543: GHA: MSVC installation is failing when component is already installed

2023-04-20 Thread Christoph Langer
On Thu, 20 Apr 2023 11:56:37 GMT, Aleksey Shipilev wrote: > Currrent GHA fails on MSVC installation. Looks like the required versions are > already installed in the runner image, and this is why the command fails. Our > configure scripts look for the specific minor version, and the builds

Re: RFR: 8303703: Add support of execution tests using virtual thread factory jtreg plugin [v4]

2023-04-20 Thread Jaikiran Pai
On Fri, 21 Apr 2023 02:05:39 GMT, Leonid Mesnik wrote: >> The plugin which support execution of test's main method in separate virtual >> thread is added. >> The plugin is built as a part of test image and might be used in testing by >> adding JTREG_TEST_THREAD_FACTORY=Virtual option. > >

Re: RFR: 8303703: Add support of execution tests using virtual thread factory jtreg plugin [v3]

2023-04-20 Thread Leonid Mesnik
On Fri, 21 Apr 2023 01:50:48 GMT, Jaikiran Pai wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed doc > > doc/testing.md line 385: > >> 383: Sets the `-testThreadFactory` for JTReg. Is should be the name of

Re: RFR: 8303703: Add support of execution tests using virtual thread factory jtreg plugin [v4]

2023-04-20 Thread Leonid Mesnik
> The plugin which support execution of test's main method in separate virtual > thread is added. > The plugin is built as a part of test image and might be used in testing by > adding JTREG_TEST_THREAD_FACTORY=Virtual option. Leonid Mesnik has updated the pull request incrementally with one

Re: RFR: 8303703: Add support of execution tests using virtual thread factory jtreg plugin

2023-04-20 Thread Jaikiran Pai
On Tue, 18 Apr 2023 05:58:08 GMT, Jaikiran Pai wrote: >> The plugin which support execution of test's main method in separate virtual >> thread is added. >> The plugin is built as a part of test image and might be used in testing by >> adding JTREG_TEST_THREAD_FACTORY=Virtual option. > > I use

Re: RFR: 8303703: Add support of execution tests using virtual thread factory jtreg plugin [v3]

2023-04-20 Thread Jaikiran Pai
On Tue, 18 Apr 2023 15:19:29 GMT, Leonid Mesnik wrote: >> The plugin which support execution of test's main method in separate virtual >> thread is added. >> The plugin is built as a part of test image and might be used in testing by >> adding JTREG_TEST_THREAD_FACTORY=Virtual option. > >

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

2023-04-20 Thread Chen Liang
On Thu, 20 Apr 2023 18:39:59 GMT, Jorn Vernee wrote: > Simpler reproducer: > > ``` > bash -x ./make/scripts/fixpath.sh print '-Djava.library.path=/mnt/h/xyz > --add-exports=java.base/jdk.internal.org.objectweb.asm=ALL-UNNAMED' > ``` > > Shows: > > ``` > + print_command_line

Re: RFR: 8304434: [AIX] Update minimum xlclang version

2023-04-20 Thread Tyler Steele
On Thu, 23 Mar 2023 18:42:41 GMT, Martin Doerr wrote: >> Minor changes to the build system to recognize and warn that an incompatible >> toolchain is detected. > > Yes, I think it's better to define the minimum version to a compiler which > will work at the point of time at which we integrate

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

2023-04-20 Thread Jorn Vernee
On Thu, 20 Apr 2023 02:32:37 GMT, Chen Liang wrote: > This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. > The root cause might be that JMH requires passing VM args to benchmarks in > quotes, which might have triggered incorrect detections in `FIXPATH` (as in >

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

2023-04-20 Thread Jorn Vernee
On Thu, 20 Apr 2023 02:32:37 GMT, Chen Liang wrote: > This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. > The root cause might be that JMH requires passing VM args to benchmarks in > quotes, which might have triggered incorrect detections in `FIXPATH` (as in >

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v2]

2023-04-20 Thread Coleen Phillimore
On Thu, 20 Apr 2023 08:36:53 GMT, Afshin Zafari wrote: >> JVMTI does not abort on OOM it reports an error, so we definitely do not >> want a terminating allocator! >> >> jvmtiError >> JvmtiEnv::CreateRawMonitor(const char* name, jrawMonitorID* monitor_ptr) { >> JvmtiRawMonitor* rmonitor =

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v3]

2023-04-20 Thread Coleen Phillimore
On Thu, 20 Apr 2023 08:41:58 GMT, Afshin Zafari wrote: >> - The `throw()` (i.e., no throw) specifications are removed from the >> instances of `operator new` where _do not_ return `nullptr`. >> >> - The `-fcheck-new` is removed from the gcc compile flags. >> >> - The `operator new` and

Re: RFR: 8306543: GHA: MSVC installation is failing when component is already installed

2023-04-20 Thread Aleksey Shipilev
On Thu, 20 Apr 2023 16:23:26 GMT, Christoph Langer wrote: >> Currrent GHA fails on MSVC installation. Looks like the required versions >> are already installed in the runner image, and this is why the command >> fails. Our configure scripts look for the specific minor version, and the >>

Re: RFR: 8306543: GHA: MSVC installation is failing when component is already installed

2023-04-20 Thread Christoph Langer
On Thu, 20 Apr 2023 11:56:37 GMT, Aleksey Shipilev wrote: > Currrent GHA fails on MSVC installation. Looks like the required versions are > already installed in the runner image, and this is why the command fails. Our > configure scripts look for the specific minor version, and the builds

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

2023-04-20 Thread Jorn Vernee
On Thu, 20 Apr 2023 02:32:37 GMT, Chen Liang wrote: > This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. > The root cause might be that JMH requires passing VM args to benchmarks in > quotes, which might have triggered incorrect detections in `FIXPATH` (as in >

Re: RFR: 8306543: GHA: MSVC installation is failing when component is already installed

2023-04-20 Thread Aleksey Shipilev
On Thu, 20 Apr 2023 16:23:26 GMT, Christoph Langer wrote: > Looks good. Too bad that the Windows installer is not showing any sensible > output. We will want to backport this to 11u and 17u soon, too. Yes, that would be my plan. GHA rolls out the new image right now, and so lots of backports

Re: RFR: 8306543: GHA: MSVC installation is failing when component is already installed

2023-04-20 Thread Christoph Langer
On Thu, 20 Apr 2023 11:56:37 GMT, Aleksey Shipilev wrote: > Currrent GHA fails on MSVC installation. Looks like the required versions are > already installed in the runner image, and this is why the command fails. Our > configure scripts look for the specific minor version, and the builds

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

2023-04-20 Thread Chen Liang
On Thu, 20 Apr 2023 02:32:37 GMT, Chen Liang wrote: > This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. > The root cause might be that JMH requires passing VM args to benchmarks in > quotes, which might have triggered incorrect detections in `FIXPATH` (as in >

Re: RFR: 8306543: GHA: MSVC installation is failing when component is already installed

2023-04-20 Thread Aleksey Shipilev
On Thu, 20 Apr 2023 11:56:37 GMT, Aleksey Shipilev wrote: > Currrent GHA fails on MSVC installation. Looks like the required versions are > already installed in the runner image, and this is why the command fails. Our > configure scripts look for the specific minor version, and the builds

Re: RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

2023-04-20 Thread Jorn Vernee
On Thu, 20 Apr 2023 02:32:37 GMT, Chen Liang wrote: > This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. > The root cause might be that JMH requires passing VM args to benchmarks in > quotes, which might have triggered incorrect detections in `FIXPATH` (as in >

Re: RFR: 8306408: Fix the format of several tables in building.md

2023-04-20 Thread Dingli Zhang
On Wed, 19 Apr 2023 18:34:33 GMT, Erik Joelsson wrote: >> I see we have this style of tables already present in building.md, so it >> should be fine. Generating building.html from this does cause a diff to the >> html file, so those still need to go in together. Please find a regenerated >>

Re: RFR: 8303703: Add support of execution tests using virtual thread factory jtreg plugin

2023-04-20 Thread Leonid Mesnik
On Tue, 18 Apr 2023 05:58:08 GMT, Jaikiran Pai wrote: >> The plugin which support execution of test's main method in separate virtual >> thread is added. >> The plugin is built as a part of test image and might be used in testing by >> adding JTREG_TEST_THREAD_FACTORY=Virtual option. > > I use

Re: RFR: 8306408: Fix the format of several tables in building.md [v4]

2023-04-20 Thread Erik Joelsson
On Thu, 20 Apr 2023 00:23:34 GMT, Dingli Zhang wrote: >> Hi all, >> >> Currently, the format of several tables in building.md looks a little >> problematic and will incorrectly display the split line. In contrast, the >> corresponding building.html will display the tables correctly. >> >>

RFR: 8306543: GHA: MSVC installation is failing when component is already installed

2023-04-20 Thread Aleksey Shipilev
Currrent GHA fails on MSVC installation. Looks like the required versions are already installed in the runner image, and this is why the command fails. Our configure scripts look for the specific minor version, and the builds still pass if I drop the VC installation block completely. This tells

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v3]

2023-04-20 Thread Kim Barrett
On Thu, 20 Apr 2023 08:41:58 GMT, Afshin Zafari wrote: >> - The `throw()` (i.e., no throw) specifications are removed from the >> instances of `operator new` where _do not_ return `nullptr`. >> >> - The `-fcheck-new` is removed from the gcc compile flags. >> >> - The `operator new` and

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v2]

2023-04-20 Thread Afshin Zafari
On Thu, 20 Apr 2023 06:58:20 GMT, David Holmes wrote: >> A possible reason for keeping this `operator new` is to force the use of >> null return for oom for this class. >> If it's removed then we have the option of (perhaps unintentionally) using >> the terminating allocator. >> That doesn't

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v3]

2023-04-20 Thread Afshin Zafari
On Tue, 18 Apr 2023 18:25:55 GMT, Kim Barrett wrote: >> Afshin Zafari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8305590: Remove nothrow exception specifications from operator new > >

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v3]

2023-04-20 Thread Afshin Zafari
> - The `throw()` (i.e., no throw) specifications are removed from the > instances of `operator new` where _do not_ return `nullptr`. > > - The `-fcheck-new` is removed from the gcc compile flags. > > - The `operator new` and `operator delete` are deleted from `StackObj`. > > - The

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v2]

2023-04-20 Thread Afshin Zafari
On Wed, 19 Apr 2023 11:49:49 GMT, David Holmes wrote: >> Afshin Zafari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8305590: Remove nothrow exception specifications from operator new > >

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v2]

2023-04-20 Thread David Holmes
On Thu, 20 Apr 2023 05:05:17 GMT, Kim Barrett wrote: >> This `operator new` just calls the `CHeapObj::operator new` with nothrow >> argument. So changing the caller will call the right one in `CHeapObj`. This >> object is deleted in >>