On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up
On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up
On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up
On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up
On Wed, 22 Nov 2023 00:05:26 GMT, Paul Sandoz wrote:
> Have you considered the possibility of copying the sleef source to the
> OpenJDK repository and thereby it becomes part of the build process? I don't
> know how straightforward that is technically and IANAL but I think it's worth
>
On Tue, 21 Nov 2023 18:14:41 GMT, Paul Sandoz wrote:
> > This looks good. As far as I can tell the choice you've made of accuracy
> > matches what we need to meet the spec.
>
> Same here . Sinh/cosh/tanh/expm1 are specified to be within 2.5 ulps of the
> exact result, but i believe sleef does
On Wed, 15 Nov 2023 01:32:00 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Tue, 21 Nov 2023 14:47:39 GMT, Matthew Donovan wrote:
>> Hello,
>>
>> In this PR I removed NSS tests from the ProblemList and updated NssTest to
>> use Sqlite databases. I also removed code in PKCS11Test.java that falls back
>> to NSS libraries installed on the test system. The tests can
On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up
On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up
> The math library in AIX specifically, is a static archive. Doing a -lm wont
> suffice, because when the symbols are looked up using dlsym or accessing
> native code through Java, it will lead to failures.
> Hence we had to come up with a list of symbols to allow math library symbols
> to be
On Tue, 21 Nov 2023 18:16:35 GMT, Erik Joelsson wrote:
> > I don't think we need to match a `/`, so I recommend either:
> >
> > 1. A single rule excluding `jdk*`, as in the current PR
> > 2. A single rule excluding `jdk[0-9]*`
> > 3. Two rules, one excluding `jdk[0-9]*` and a second excluding
On Tue, 21 Nov 2023 16:15:43 GMT, Kevin Rushforth wrote:
> I don't think we need to match a `/`, so I recommend either:
>
> 1. A single rule excluding `jdk*`, as in the current PR
> 2. A single rule excluding `jdk[0-9]*`
> 3. Two rules, one excluding `jdk[0-9]*` and a second excluding `jdk-*`
>
On Mon, 23 Oct 2023 09:02:35 GMT, Xiaohong Gong wrote:
> This looks good. As far as I can tell the choice you've made of accuracy
> matches what we need to meet the spec.
Same here . Sinh/cosh/tanh/expm1 are specified to be within 2.5 ulps of the
exact result, but i believe sleef does not
On Tue, 21 Nov 2023 17:49:43 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up
On Tue, 21 Nov 2023 17:54:08 GMT, suchismith1993 wrote:
>> src/java.base/aix/native/libsyslookup/syslookup.c line 30:
>>
>>> 28: #include
>>> 29: #include
>>> 30: #include
>>
>> Are string.h and stdlib.h needed? I can't see them in the comments below.
>
> string.h is needed for strlen. Let
On Tue, 21 Nov 2023 17:50:04 GMT, Martin Doerr wrote:
>> suchismith1993 has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Comments
>> - Change comments
>
> src/java.base/aix/native/libsyslookup/syslookup.c line 30:
>
>> 28: #include
> The math library in AIX specifically, is a static archive. Doing a -lm wont
> suffice, because when the symbols are looked up using dlsym or accessing
> native code through Java, it will lead to failures.
> Hence we had to come up with a list of symbols to allow math library symbols
> to be
On Tue, 21 Nov 2023 15:58:06 GMT, Magnus Ihse Bursie wrote:
> We should use title case consistently in building.md.
>
> I thought I was done with fixing up the build README, but then I noticed this
> and I couldn't unsee it...
Marked as reviewed by iris (Reviewer).
-
PR Review:
On Tue, 21 Nov 2023 14:42:07 GMT, Kevin Rushforth wrote:
> At some point we are likely to use stabilization branches in the mainline jdk
> repo rather than a separate repo. In preparation, this PR excludes branches
> matching `jdk*`, like we currently do for `master` and `pr/*`.
>
> A
On Tue, 21 Nov 2023 15:58:06 GMT, Magnus Ihse Bursie wrote:
> We should use title case consistently in building.md.
>
> I thought I was done with fixing up the build README, but then I noticed this
> and I couldn't unsee it...
This pull request has now been integrated.
Changeset: 9311749e
On Tue, 21 Nov 2023 14:42:07 GMT, Kevin Rushforth wrote:
> At some point we are likely to use stabilization branches in the mainline jdk
> repo rather than a separate repo. In preparation, this PR excludes branches
> matching `jdk*`, like we currently do for `master` and `pr/*`.
>
> A
On Tue, 21 Nov 2023 14:42:07 GMT, Kevin Rushforth wrote:
> At some point we are likely to use stabilization branches in the mainline jdk
> repo rather than a separate repo. In preparation, this PR excludes branches
> matching `jdk*`, like we currently do for `master` and `pr/*`.
>
> A
On Tue, 21 Nov 2023 15:58:58 GMT, Kevin Rushforth wrote:
> However, that's an interesting point about it excluding a username that
> begins with `jdk` given how the bot creates the branch name for the
> `/backport` command.
I note that this would be easy to fix by changing the bot to use
On Tue, 21 Nov 2023 14:42:07 GMT, Kevin Rushforth wrote:
> At some point we are likely to use stabilization branches in the mainline jdk
> repo rather than a separate repo. In preparation, this PR excludes branches
> matching `jdk*`, like we currently do for `master` and `pr/*`.
>
> A
On Tue, 21 Nov 2023 16:02:16 GMT, Kevin Rushforth wrote:
> I note that this would be easy to fix by changing the bot to use
> backport-USERNAME-SHORTHASH instead of the current where USERNAME is first.
It also have the benefit of being more logical. :-)
-
PR Comment:
We should use title case consistently in building.md.
I thought I was done with fixing up the build README, but then I noticed this
and I couldn't unsee it...
-
Commit messages:
- 8320526: Use title case in building.md
Changes: https://git.openjdk.org/jdk/pull/16765/files
On Tue, 21 Nov 2023 14:42:07 GMT, Kevin Rushforth wrote:
> At some point we are likely to use stabilization branches in the mainline jdk
> repo rather than a separate repo. In preparation, this PR excludes branches
> matching `jdk*`, like we currently do for `master` and `pr/*`.
>
> A
On Tue, 21 Nov 2023 14:42:07 GMT, Kevin Rushforth wrote:
> At some point we are likely to use stabilization branches in the mainline jdk
> repo rather than a separate repo. In preparation, this PR excludes branches
> matching `jdk*`, like we currently do for `master` and `pr/*`.
>
> A
On Tue, 21 Nov 2023 14:42:07 GMT, Kevin Rushforth wrote:
> At some point we are likely to use stabilization branches in the mainline jdk
> repo rather than a separate repo. In preparation, this PR excludes branches
> matching `jdk*`, like we currently do for `master` and `pr/*`.
>
> A
On Tue, 21 Nov 2023 15:13:52 GMT, Magnus Ihse Bursie wrote:
> ... or the bots should name the branches `backport-${username}-${hash}`
> instead ..?
Yes, but the fact I can come up with an _easy_ example where it breaks serves
as signal there are _likely_ less obvious broken cases :)
> I
On Tue, 21 Nov 2023 14:42:07 GMT, Kevin Rushforth wrote:
> At some point we are likely to use stabilization branches in the mainline jdk
> repo rather than a separate repo. In preparation, this PR excludes branches
> matching `jdk*`, like we currently do for `master` and `pr/*`.
>
> A
On Thu, 16 Nov 2023 07:09:31 GMT, David Holmes wrote:
>> Srinivas Vamsi Parasa has updated the pull request with a new target base
>> due to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains 11
>> additional
On Tue, 21 Nov 2023 14:42:07 GMT, Kevin Rushforth wrote:
> At some point we are likely to use stabilization branches in the mainline jdk
> repo rather than a separate repo. In preparation, this PR excludes branches
> matching `jdk*`, like we currently do for `master` and `pr/*`.
>
> A
On Tue, 21 Nov 2023 14:47:39 GMT, Matthew Donovan wrote:
>> Hello,
>>
>> In this PR I removed NSS tests from the ProblemList and updated NssTest to
>> use Sqlite databases. I also removed code in PKCS11Test.java that falls back
>> to NSS libraries installed on the test system. The tests can
On Tue, 21 Nov 2023 14:42:07 GMT, Kevin Rushforth wrote:
> At some point we are likely to use stabilization branches in the mainline jdk
> repo rather than a separate repo. In preparation, this PR excludes branches
> matching `jdk*`, like we currently do for `master` and `pr/*`.
>
> A
At some point we are likely to use stabilization branches in the mainline jdk
repo rather than a separate repo. In preparation, this PR excludes branches
matching `jdk*`, like we currently do for `master` and `pr/*`.
A potential drawback of doing this is that it will exclude developer branches
> Hello,
>
> In this PR I removed NSS tests from the ProblemList and updated NssTest to
> use Sqlite databases. I also removed code in PKCS11Test.java that falls back
> to NSS libraries installed on the test system. The tests can still be run
> with different NSS libraries but they have to be
On Tue, 21 Nov 2023 13:55:29 GMT, Matthew Donovan wrote:
>> Hello,
>>
>> In this PR I removed NSS tests from the ProblemList and updated NssTest to
>> use Sqlite databases. I also removed code in PKCS11Test.java that falls back
>> to NSS libraries installed on the test system. The tests can
On Mon, 20 Nov 2023 01:47:34 GMT, Xiaohong Gong wrote:
>> make/autoconf/lib-vmath.m4 line 92:
>>
>>> 90: []
>>> 91: )
>>> 92: AC_MSG_RESULT([${SVE_FEATURE_SUPPORT}])
>>
>> What is this test even for? I can't see any usage of SVE_FEATURE_SUPPORT
>> outside this
On Tue, 21 Nov 2023 13:01:50 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up
> Hello,
>
> In this PR I removed NSS tests from the ProblemList and updated NssTest to
> use Sqlite databases. I also removed code in PKCS11Test.java that falls back
> to NSS libraries installed on the test system. The tests can still be run
> with different NSS libraries but they have to be
On Tue, 21 Nov 2023 13:01:50 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up
On Tue, 21 Nov 2023 12:36:24 GMT, Matthew Donovan wrote:
>> Hello,
>>
>> In this PR I removed NSS tests from the ProblemList and updated NssTest to
>> use Sqlite databases. I also removed code in PKCS11Test.java that falls back
>> to NSS libraries installed on the test system. The tests can
On Tue, 21 Nov 2023 13:01:50 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up
> The math library in AIX specifically, is a static archive. Doing a -lm wont
> suffice, because when the symbols are looked up using dlsym or accessing
> native code through Java, it will lead to failures.
> Hence we had to come up with a list of symbols to allow math library symbols
> to be
> Hello,
>
> In this PR I removed NSS tests from the ProblemList and updated NssTest to
> use Sqlite databases. I also removed code in PKCS11Test.java that falls back
> to NSS libraries installed on the test system. The tests can still be run
> with different NSS libraries but they have to be
On Tue, 21 Nov 2023 00:43:36 GMT, Valerie Peng wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed whitespace errors
>
> test/jdk/sun/security/pkcs11/README line 14:
>
>> 12:
>> 13: 2. Pre-built NSS
> The math library in AIX specifically, is a static archive. Doing a -lm wont
> suffice, because when the symbols are looked up using dlsym or accessing
> native code through Java, it will lead to failures.
> Hence we had to come up with a list of symbols to allow math library symbols
> to be
On Tue, 21 Nov 2023 11:52:23 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up
> The math library in AIX specifically, is a static archive. Doing a -lm wont
> suffice, because when the symbols are looked up using dlsym or accessing
> native code through Java, it will lead to failures.
> Hence we had to come up with a list of symbols to allow math library symbols
> to be
On Tue, 21 Nov 2023 11:21:40 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up
> The math library in AIX specifically, is a static archive. Doing a -lm wont
> suffice, because when the symbols are looked up using dlsym or accessing
> native code through Java, it will lead to failures.
> Hence we had to come up with a list of symbols to allow math library symbols
> to be
> Classfile API is an internal library under package `jdk.internal.classfile`
> in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it
> into `java.lang.classfile`.
> It repackages all uses across JDK and tests and adds lots of missing Javadoc.
>
> This PR
On Mon, 20 Nov 2023 17:20:50 GMT, Jan Lahoda wrote:
>> Consider a simple module, like:
>>
>> module test {}
>>
>>
>> And compile it with JDK 22 and JDK 21 using:
>> javac --release 21
>>
>> The results of the compilations will differ: when compiling with JDK 21, the
>> mandated java.base
On Thu, 16 Nov 2023 16:41:05 GMT, Magnus Ihse Bursie wrote:
> Update the build documentation to reflect the fact that non-English locales
> are only supported on a "best effort" principle, and add instructions how to
> install the necessary language pack to Visual Studio.
This pull request
> Update the build documentation to reflect the fact that non-English locales
> are only supported on a "best effort" principle, and add instructions how to
> install the necessary language pack to Visual Studio.
Magnus Ihse Bursie has updated the pull request with a new target base due to a
57 matches
Mail list logo
