On Mon, 3 Jul 2023 06:47:04 GMT, Daniel Jeliński wrote:
>> src/hotspot/cpu/aarch64/aarch64.ad line 2288:
>>
>>> 2286:
>>> //=
>>> 2287:
>>> 2288: const bool Matcher
On Mon, 3 Jul 2023 00:19:56 GMT, David Holmes wrote:
>> Please review this attempt to fix ignored-qualifiers warning.
>>
>> Example warnings:
>>
>> src/hotspot/share/oops/method.hpp:413:19: warning: 'volatile' type qualifier
>> on return type has no effect [-Wignored-qualifiers]
>>
On Tue, 27 Jun 2023 12:22:43 GMT, Daniel Jeliński wrote:
> Please review this attempt to fix ignored-qualifiers warning.
>
> Example warnings:
>
> src/hotspot/share/oops/method.hpp:413:19: warning: 'volatile' type qualifier
> on return type has no effect [-W
On Tue, 27 Jun 2023 12:22:43 GMT, Daniel Jeliński wrote:
> Please review this attempt to fix ignored-qualifiers warning.
>
> Example warnings:
>
> src/hotspot/share/oops/method.hpp:413:19: warning: 'volatile' type qualifier
> on return type has no effect [-W
On Tue, 27 Jun 2023 12:22:43 GMT, Daniel Jeliński wrote:
> Please review this attempt to fix ignored-qualifiers warning.
>
> Example warnings:
>
> src/hotspot/share/oops/method.hpp:413:19: warning: 'volatile' type qualifier
> on return type has no effect [-W
On Mon, 26 Jun 2023 12:36:38 GMT, Daniel Jeliński wrote:
> Enabling `Zc:inline` flag improves C++11 standard compliance, reduces the
> size of obj files produced by the build by 200+MB, and might also improve
> build speed.
>
> 2 files failed to compile with the flag
Please review this attempt to fix ignored-qualifiers warning.
Example warnings:
src/hotspot/share/oops/method.hpp:413:19: warning: 'volatile' type qualifier on
return type has no effect [-Wignored-qualifiers]
CompiledMethod* volatile code() const;
^
Enabling `Zc:inline` flag improves C++11 standard compliance, reduces the size
of obj files produced by the build by 200+MB, and might also improve build
speed.
2 files failed to compile with the flag added; see JBS for details if you're
interested. This PR fixes the compilation issues.
On Fri, 23 Jun 2023 08:03:45 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request incrementally with one additional
> commit
On Thu, 22 Jun 2023 09:58:19 GMT, Daniel Jeliński wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update
>
> make/modules/java.desktop/lib/Awt2dLib
On Thu, 22 Jun 2023 09:13:21 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request incrementally with one additional
> commit
On Sun, 11 Jun 2023 16:38:31 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request with a new target base due to a
> merge or a
On Tue, 9 May 2023 10:38:54 GMT, Johannes Bechberger
wrote:
> Fixes the issue by adding `--add-exports` for the required modules and making
> the `HttpHeaderParser` final (fixing an issue with calling overridable
> methods in a constructor).
Just making sure everyone had a chance to take a
On Tue, 9 May 2023 10:38:54 GMT, Johannes Bechberger
wrote:
> Fixes the issue by adding `--add-exports` for the required modules and making
> the `HttpHeaderParser` final (fixing an issue with calling overridable
> methods in a constructor).
Marked as reviewed by djelinski (Reviewer).
On Tue, 9 May 2023 10:38:54 GMT, Johannes Bechberger
wrote:
> Fixes the issue by adding `--add-exports` for the required modules and making
> the `HttpHeaderParser` final (fixing an issue with calling overridable
> methods in a constructor).
That's interesting. How did you find this? Is the
On Sat, 6 May 2023 10:00:10 GMT, George Adams wrote:
>> Deprecate the Windows x86-32 port, with the intent to remove it in a future
>> release.
>
> George Adams has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix wording
doc/building.md
On Tue, 18 Apr 2023 11:59:44 GMT, Daniel Jeliński wrote:
> Please review this patch that disables a warning that appeared on linux
> builds in slowdebug configuration after
> [JDK-8299592](https://bugs.openjdk.org/browse/JDK-8299592).
>
> I plan to investigate why this failu
On Tue, 18 Apr 2023 11:59:44 GMT, Daniel Jeliński wrote:
> Please review this patch that disables a warning that appeared on linux
> builds in slowdebug configuration after
> [JDK-8299592](https://bugs.openjdk.org/browse/JDK-8299592).
>
> I plan to investigate why this failu
On Tue, 18 Apr 2023 11:59:44 GMT, Daniel Jeliński wrote:
> Please review this patch that disables a warning that appeared on linux
> builds in slowdebug configuration after
> [JDK-8299592](https://bugs.openjdk.org/browse/JDK-8299592).
>
> I plan to investigate why this failu
Please review this patch that disables a warning that appeared on linux builds
in slowdebug configuration after
[JDK-8299592](https://bugs.openjdk.org/browse/JDK-8299592).
I plan to investigate why this failure appears only in slowdebug mode; this
patch is intended to unblock the CI.
Verified
On Wed, 4 Jan 2023 12:44:39 GMT, Daniel Jeliński wrote:
> Please review this patch that fixes and re-enables a few warnings in libawt
> compilation.
>
> Verified that debug and release builds finish successfully on Win, Mac and
> Linux. Also verified that client libs t
On Thu, 13 Apr 2023 07:13:39 GMT, Daniel Jeliński wrote:
>> Please review this patch that fixes and re-enables a few warnings in libawt
>> compilation.
>>
>> Verified that debug and release builds finish successfully on Win, Mac and
>> Linux. Also verified tha
On Fri, 14 Apr 2023 07:59:49 GMT, Varada M wrote:
>> Breaking this into two parts :
>>
>> 1. Implementing socket options for AIX
>> 2. DontFragmentTest failure
>>
>> - Implementing socket options for AIX :
>>
>> Unlike the linux, windows and macOS, AIX uses the default implementation for
> Please review this patch that fixes and re-enables a few warnings in libawt
> compilation.
>
> Verified that debug and release builds finish successfully on Win, Mac and
> Linux. Also verified that client libs tests still pass.
Daniel Jeliński has updated the pull reques
On Wed, 12 Apr 2023 20:29:19 GMT, Alexey Ivanov wrote:
>> Daniel Jeliński has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 10 commits:
>>
>> - Merge remote-tracking branch 'origin' into awt-warning-cl
> Please review this patch that fixes and re-enables a few warnings in libawt
> compilation.
>
> Verified that debug and release builds finish successfully on Win, Mac and
> Linux. Also verified that client libs tests still pass.
Daniel Jeliński has updated the pull request wi
On Wed, 5 Apr 2023 12:23:10 GMT, Varada M wrote:
>> Breaking this into two parts :
>>
>> 1. Implementing socket options for AIX
>> 2. DontFragmentTest failure
>>
>> - Implementing socket options for AIX :
>>
>> Unlike the linux, windows and macOS, AIX uses the default implementation for
On Wed, 1 Mar 2023 14:37:34 GMT, Rich DiCroce wrote:
>> Rich DiCroce has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Forgot to add file
>> - Resolve review comments
>
> I've updated the PR to address all of the various comments.
>
>
On Thu, 9 Mar 2023 11:35:22 GMT, Julian Waters wrote:
>> Was: sunmscapi.dll cannot compile with Visual C++
>>
>> `-Zc:wchar_t-` has, until now, been passed to switch off wchar_t as a
>> distinct C++ type when compiling with Visual C++ so jchar and wchar_t are
>> typedef'd to shorts on
On Fri, 3 Mar 2023 09:56:35 GMT, David Holmes wrote:
>> We can replace `gethostbyname`, which is deprecated on Windows and Linux,
>> with `getaddrinfo`. This API is available on all supported platforms and so
>> can be placed in shared code. @djelinski pointed out that `getaddrinfo` can
>>
On Wed, 1 Mar 2023 13:06:35 GMT, Daniel Jeliński wrote:
> Please review this PR that upgrades winsock lib from version 1 (wsock32) to
> version 2 (ws2_32) and removes unnecessary libs from the build.
>
> With the winsock upgrade we should be able to avoid loading wsock32.dll a
On Wed, 1 Mar 2023 18:55:05 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert flag change in
On Wed, 1 Mar 2023 18:55:05 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert flag change in
On Wed, 1 Mar 2023 18:31:41 GMT, Rich DiCroce wrote:
>> src/java.base/windows/native/libnet/ResolverConfigurationImpl.c line 190:
>>
>>> 188: flags |= GAA_FLAG_SKIP_MULTICAST;
>>> 189: flags |= GAA_FLAG_SKIP_FRIENDLY_NAME;
>>> 190: flags |= GAA_FLAG_INCLUDE_ALL_INTERFACES;
>>
>> Is
On Wed, 1 Mar 2023 14:37:53 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Changes as per review comments
Please review this PR that upgrades winsock lib from version 1 (wsock32) to
version 2 (ws2_32) and removes unnecessary libs from the build.
With the winsock upgrade we should be able to avoid loading wsock32.dll at
runtime. Winsock is only needed for `htonl` function, and wsock32.dll forwards
On Wed, 22 Feb 2023 17:40:31 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Forgot to add file
> - Resolve
On Wed, 22 Feb 2023 17:40:31 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Forgot to add file
> - Resolve
On Wed, 22 Feb 2023 17:40:31 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Forgot to add file
> - Resolve
On Thu, 16 Feb 2023 17:56:58 GMT, Rich DiCroce wrote:
>> src/java.base/windows/native/libnet/NetworkInterface.c line 72:
>>
>>> 70: return FALSE;
>>> 71: }
>>> 72: if (GetAnycastIpAddressTable(addrFamily, anyAddrs) != NO_ERROR) {
>>
>> Were the anycast addresses covered by the
On Thu, 16 Feb 2023 21:48:19 GMT, Daniel Fuchs wrote:
>> Note that the new code doesn't attempt to sort anything. If it happens to be
>> sorted by LUID, that's the underlying API at work. The MS docs don't say
>> anything about ordering, so this is probably an implementation detail and I
>>
On Thu, 16 Feb 2023 18:59:06 GMT, Rich DiCroce wrote:
>> Ha! Apparently I have a machine where the implementation of
>> `supportsMulticast` implementation makes a difference. On my machine the
>> test `jdk/java/net/SocketOption/OptionsTest.java` is failing with:
>>
>>
On Thu, 16 Feb 2023 18:05:05 GMT, Rich DiCroce wrote:
>> src/java.base/windows/native/libnet/NetworkInterface.c line 523:
>>
>>> 521: * Signature: (Ljava/lang/String;I)Z
>>> 522: */
>>> 523: JNIEXPORT jboolean JNICALL
>>> Java_java_net_NetworkInterface_supportsMulticast0(JNIEnv *env, jclass
On Thu, 16 Feb 2023 16:49:09 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Limit line length to 80-ish
On Fri, 20 Jan 2023 12:01:06 GMT, Daniel Jeliński wrote:
>> Please review this patch that fixes and re-enables a few warnings in libawt
>> compilation.
>>
>> Verified that debug and release builds finish successfully on Win, Mac and
>> Linux. Also verified tha
On Fri, 27 Jan 2023 21:11:00 GMT, Erik Joelsson wrote:
> After JDK-8300805, config.guess has changed output when running on WSL. This
> is caused by the autoconf-config.guess now reporting it as
> `x86_64-pc-linux-gnu` instead of `x86_64-unknown-linux-gnu`, and our wrapper
> script is
> Please review this patch that fixes and re-enables a few warnings in libawt
> compilation.
>
> Verified that debug and release builds finish successfully on Win, Mac and
> Linux. Also verified that client libs tests still pass.
Daniel Jeliński has updated the pull request wi
On Wed, 4 Jan 2023 12:44:39 GMT, Daniel Jeliński wrote:
> Please review this patch that fixes and re-enables a few warnings in libawt
> compilation.
>
> Verified that debug and release builds finish successfully on Win, Mac and
> Linux. Also verified that client libs t
On Wed, 4 Jan 2023 09:15:18 GMT, Aleksey Shipilev wrote:
>> This should help to speed up tests significantly. Currently, if we run "make
>> test" with a subset of tests, JTReg would still read the entirety of test
>> root to report on tests that were not run. Even with current suite of tests
Please review this patch that fixes and re-enables a few warnings in libawt
compilation.
Verified that debug and release builds finish successfully on Win, Mac and
Linux. Also verified that client libs tests still pass.
-
Commit messages:
- Copyright
- snprintf
- cl analyze
-
On Tue, 20 Dec 2022 18:59:18 GMT, Daniel Jeliński wrote:
> Please review this patch that removes unnecessary exports from libawt and
> libfreetype.
>
> Verified that:
> - mach5 client libs tests pass
> - both release and debug builds finish successfully
This pull re
On Tue, 20 Dec 2022 18:59:18 GMT, Daniel Jeliński wrote:
> Please review this patch that removes unnecessary exports from libawt and
> libfreetype.
>
> Verified that:
> - mach5 client libs tests pass
> - both release and debug builds finish successfully
>
> Did not
On Tue, 20 Dec 2022 18:59:18 GMT, Daniel Jeliński wrote:
> Please review this patch that removes unnecessary exports from libawt and
> libfreetype.
>
> Verified that:
> - mach5 client libs tests pass
> - both release and debug builds finish successfully
>
> Did not
Please review this patch that removes unnecessary exports from libawt and
libfreetype.
Verified that:
- mach5 client libs tests pass
- both release and debug builds finish successfully
Did not verify the other issues reported in the linked JBS ticket.
-
Commit messages:
- Export
On Wed, 9 Nov 2022 12:15:28 GMT, Magnus Ihse Bursie wrote:
>> FWIW, `-permissive-` is getting less permissive with every compiler
>> iteration; with MSVC2022 (` C Compiler: Version 19.33.31629`) even
>> hotspot doesn't build.
>
> @djelinski That's a bit alarming. :-/ Do you have any idea
On Wed, 2 Nov 2022 16:45:35 GMT, Julian Waters wrote:
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499) proposes to set
>> the -permissive- flag for the Microsoft Visual C++ compiler, to enforce
>> strict standards conformance during compilation, making native code behave
>> more
On Fri, 21 Oct 2022 14:28:02 GMT, Daniel Jeliński wrote:
> Please review this PR that removes the remains of old fdTable-based socket
> close synchronization.
>
> Verified that tier1-3 tests continue to pass on Linux, MacOS and Windows. Did
> not verify AIX.
>
> Also
On Fri, 21 Oct 2022 16:04:24 GMT, Alan Bateman wrote:
>> Please review this PR that removes the remains of old fdTable-based socket
>> close synchronization.
>>
>> Verified that tier1-3 tests continue to pass on Linux, MacOS and Windows.
>> Did not verify AIX.
>>
>> Also removed one slow
Please review this PR that removes the remains of old fdTable-based socket
close synchronization.
Verified that tier1-3 tests continue to pass on Linux, MacOS and Windows. Did
not verify AIX.
Also removed one slow test for an issue in fdtable implementation; as far as I
could tell, it is no
On Thu, 20 Oct 2022 21:49:41 GMT, Erik Joelsson wrote:
> For Oracle internal builds we control the version of GNU Make (currently
> fixed at 4.0). In Cygwin this is causing problems as the now rather dated GNU
> Make binary we use isn't compatible with Cygwin.dll version 3.3 or later. To
>
Hi,
Fixpath does not work with WSL paths; historically it was hard to map them
to Windows paths.
This article suggests that it should be easier now:
https://www.howtogeek.com/426749/how-to-access-your-linux-wsl-files-in-windows-10/
I suppose you could give it a try if you're interested.
Regards,
This patch rewrites some BigInteger and curve point operations used in EC
calculations:
- coefficient * 2^power is equivalent to coefficient << power
- number mod 2^n is equivalent to number & (2^n-1)
- pair of IntegerModuloP operations:
t2 = t1+t1
t1 = t1+t2
is equivalent to t1=t1*3, which is
On Sun, 9 Oct 2022 06:53:19 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed? With this update, the result will be always
> reduced in EC limbs addition and subtraction operations in the JDK
> implementation.
>
> In the current implementation, the EC limbs addition
On Tue, 4 Oct 2022 16:19:24 GMT, Jorn Vernee wrote:
> This patch fixes incremental builds on Windows.
>
> There are 2 parts to this:
> 1. the build system needs to run the paths in the modified file list through
> fixpath. I've added a `convert` mode to `fixpath.sh` for that. There's an
>
On Fri, 23 Sep 2022 11:01:13 GMT, Aleksey Shipilev wrote:
> This should help to speed up tests significantly. Currently, if we run "make
> test" with a subset of tests, JTReg would still read the entirety of test
> root to report on tests that were not run. Even with current suite of tests
>
On Fri, 23 Sep 2022 10:44:40 GMT, Aleksey Shipilev wrote:
> [JDK-8230067](https://bugs.openjdk.org/browse/JDK-8230067) added jtreg
> retries, but it does so awkwardly: it sets `export
> JTREG_STATUS="-status:error,fail";` on retry, and then uses it as
> `-status:{JTREG_STATUS}`.
>
>
On Fri, 23 Sep 2022 07:39:07 GMT, Xue-Lei Andrew Fan wrote:
> Limb values will always fit within a long, so inputs to multiplication must
> be less than 32 bits. *All IntegerPolynomial implementations allow at most
> one addition before multiplication*. Additions after that will result in an
On Thu, 22 Sep 2022 20:40:08 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> Please review this performance improvement for Secp256R1 implementation in
> OpenJDK. With this update, there is an about 20% performance improvement for
> Secp256R1 key generation and signature.
>
> Basically, 256 bits
On Mon, 5 Sep 2022 13:11:57 GMT, Magnus Ihse Bursie wrote:
>> The new conformant preprocessor has been feature complete since Visual
>> Studio 2019.
>>
>> We should start to use it instead of the traditional preprocessor (which is
>> well known to be non-conforming in various ways). This
On Thu, 11 Aug 2022 09:56:29 GMT, Daniel Jeliński wrote:
> Remove `java.base:include` from `EXTRA_HEADER_DIRS`.
>
> The directory contains base versions of the files present in
> `/support/modules_include/java.base`; the latter is automatically
> [included in every JDK library
Remove `java.base:include` from `EXTRA_HEADER_DIRS`.
The directory contains base versions of the files present in
`/support/modules_include/java.base`; the latter is automatically
[included in every JDK library
On Wed, 22 Jun 2022 14:24:05 GMT, Daniel Jeliński wrote:
> This PR improves the performance of deduplication done by
> ResourceBundleGenerator.
>
> The original implementation compared every pair of values, requiring O(n^2)
> time. The new implementation uses a HashMap to
On Thu, 23 Jun 2022 08:56:08 GMT, Daniel Jeliński wrote:
>> BTW, this can utilize the new `HashMap.newHashMap()`, although I don't think
>> resizing would be occurring in this case.
>
>> once this fix makes it to the repository, the build will be reproducible
>
On Wed, 22 Jun 2022 21:45:25 GMT, Naoto Sato wrote:
>> IIUC, once this fix makes it to the repository, the build will be
>> reproducible. Making it to be sorted is a welcome enhancement (I compare the
>> generated bundles manually from time to time), but it may be costly so it
>> could defy
er depends on the insertion order,
> and the insertion order of the new implementation is different from the
> original.
> The files generated before and after this change have the same size.
Daniel Jeliński has updated the pull request incrementally with one additional
commit since the last revisi
er depends on the insertion order,
> and the insertion order of the new implementation is different from the
> original.
> The files generated before and after this change have the same size.
Daniel Jeliński has updated the pull request incrementally with one additional
commit since the last re
On Wed, 22 Jun 2022 16:11:33 GMT, Roger Riggs wrote:
>> This PR improves the performance of deduplication done by
>> ResourceBundleGenerator.
>>
>> The original implementation compared every pair of values, requiring O(n^2)
>> time. The new implementation uses a HashMap to find duplicates,
This PR improves the performance of deduplication done by
ResourceBundleGenerator.
The original implementation compared every pair of values, requiring O(n^2)
time. The new implementation uses a HashMap to find duplicates, trading off
some extra memory consumption for O(n) computational
101 - 178 of 178 matches
Mail list logo
