On Sat, 16 Mar 2024 22:20:53 GMT, Julian Waters wrote:
>> Eclipse Shared Workspaces share the same directory as the JDK itself, which
>> does not make much sense since there can be multiple different
>> configurations of the JDK which Eclipse does depend on (as minimalistic as
>> it is), and t
On Mon, 18 Mar 2024 12:45:27 GMT, Julian Waters wrote:
>> Ok, it's fine for integration then.
>>
>> As for other IDEs: there is very little coordination on this; most IDE
>> integrations are like barely kept alive by some enthusiast. I would really
>> love to see some better grip on this, unif
On Sat, 16 Mar 2024 22:20:53 GMT, Julian Waters wrote:
>> Eclipse Shared Workspaces share the same directory as the JDK itself, which
>> does not make much sense since there can be multiple different
>> configurations of the JDK which Eclipse does depend on (as minimalistic as
>> it is), and t
On Mon, 18 Mar 2024 10:06:26 GMT, Magnus Ihse Bursie wrote:
>> Side tangent: How are the Workspaces for the other IDEs set up? Are they
>> contained entirely in the ide subdirectory in the build directory or do they
>> end up leaving their metadata in the top level directory like the Shared
>>
On Mon, 18 Mar 2024 09:21:47 GMT, Julian Waters wrote:
>> With the Shared Workspaces removed, the Workspace created no longer exists
>> in the JDK's top level source directory. This means the .gitignore entries
>> are now obsolete, and can be removed, since they only ignore .cproject and
>> .c
On Mon, 18 Mar 2024 09:18:40 GMT, Julian Waters wrote:
>> .gitignore line 22:
>>
>>> 20: /.settings/
>>> 21: /.project
>>> 22: /.classpath
>>
>> `.project` is repeated so that is fine to remove, but why are you removing
>> the other two? `.cproject` sounds like it could come from CDT.
>
> With
On Mon, 18 Mar 2024 09:07:26 GMT, Magnus Ihse Bursie wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove SHARED definition in Main.gmk
>
> .gitignore line 22:
>
>> 20: /.settings/
>> 21: /.project
>> 22: /.cla
On Sat, 16 Mar 2024 22:20:53 GMT, Julian Waters wrote:
>> Eclipse Shared Workspaces share the same directory as the JDK itself, which
>> does not make much sense since there can be multiple different
>> configurations of the JDK which Eclipse does depend on (as minimalistic as
>> it is), and t
On Fri, 15 Mar 2024 15:44:48 GMT, Erik Joelsson wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments in CreateWorkspace.gmk
>
> Marked as reviewed by erikj (Reviewer).
@erikj79 Sorry it seems I
> Eclipse Shared Workspaces share the same directory as the JDK itself, which
> does not make much sense since there can be multiple different configurations
> of the JDK which Eclipse does depend on (as minimalistic as it is), and there
> is no one true JDK configuration, unlike what this setti
On Fri, 15 Mar 2024 13:17:24 GMT, Julian Waters wrote:
>> Eclipse Shared Workspaces share the same directory as the JDK itself, which
>> does not make much sense since there can be multiple different
>> configurations of the JDK which Eclipse does depend on (as minimalistic as
>> it is), and t
On Fri, 15 Mar 2024 12:42:17 GMT, Erik Joelsson wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commi
> Eclipse Shared Workspaces share the same directory as the JDK itself, which
> does not make much sense since there can be multiple different configurations
> of the JDK which Eclipse does depend on (as minimalistic as it is), and there
> is no one true JDK configuration, unlike what this setti
On Fri, 15 Mar 2024 07:15:55 GMT, Julian Waters wrote:
>> Eclipse Shared Workspaces share the same directory as the JDK itself, which
>> does not make much sense since there can be multiple different
>> configurations of the JDK which Eclipse does depend on (as minimalistic as
>> it is), and t
On Wed, 28 Feb 2024 15:19:58 GMT, Julian Waters wrote:
>> Eclipse Shared Workspaces share the same directory as the JDK itself, which
>> does not make much sense since there can be multiple different
>> configurations of the JDK which Eclipse does depend on (as minimalistic as
>> it is), and t
> Eclipse Shared Workspaces share the same directory as the JDK itself, which
> does not make much sense since there can be multiple different configurations
> of the JDK which Eclipse does depend on (as minimalistic as it is), and there
> is no one true JDK configuration, unlike what this setti
> WIP
Julian Waters has updated the pull request incrementally with one additional
commit since the last revision:
Remove shared targets
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18046/files
- new: https://git.openjdk.org/jdk/pull/18046/files/aefff3e8..0d29a355
Webr
WIP
-
Commit messages:
- 8326964
Changes: https://git.openjdk.org/jdk/pull/18046/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18046&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8326964
Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod
Patch: https://git.o
18 matches
Mail list logo
