Re: RFR: 8329704: Implement framework for proper handling of JDK_LIBS [v2]

2024-04-10 Thread Erik Joelsson
On Wed, 10 Apr 2024 13:41:53 GMT, Magnus Ihse Bursie wrote: >> make/common/JdkNativeCompilation.gmk line 206: >> >>> 204: $$(eval $$(call ResolveLibPath,$1,$2)) >>> 205: >>> 206: $1_EXTRA_HEADER_DIRS += $$($1_$2_MODULE):lib$$($1_$2_NAME) >> >> I think the top level comment need to be clear

Re: RFR: 8329704: Implement framework for proper handling of JDK_LIBS [v2]

2024-04-10 Thread Magnus Ihse Bursie
On Fri, 5 Apr 2024 18:32:54 GMT, Erik Joelsson wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix libfallbackLinker > > make/common/JdkNativeCompilation.gmk line 206: > >> 204: $$(eval $$(call ResolveLibP

Re: RFR: 8329704: Implement framework for proper handling of JDK_LIBS [v2]

2024-04-05 Thread Erik Joelsson
On Fri, 5 Apr 2024 14:14:35 GMT, Magnus Ihse Bursie wrote: >> This is the pinnacle of the recent stream of refactorings in the build >> system. This patch introduces a more abstract concept of "JDK_LIBS", where >> only the library name (e.g. "java" or "java.desktop:jawt") is specified, and >>

Re: RFR: 8329704: Implement framework for proper handling of JDK_LIBS [v2]

2024-04-05 Thread Magnus Ihse Bursie
On Fri, 5 Apr 2024 14:14:35 GMT, Magnus Ihse Bursie wrote: >> This is the pinnacle of the recent stream of refactorings in the build >> system. This patch introduces a more abstract concept of "JDK_LIBS", where >> only the library name (e.g. "java" or "java.desktop:jawt") is specified, and >>

Re: RFR: 8329704: Implement framework for proper handling of JDK_LIBS [v2]

2024-04-05 Thread Magnus Ihse Bursie
> This is the pinnacle of the recent stream of refactorings in the build > system. This patch introduces a more abstract concept of "JDK_LIBS", where > only the library name (e.g. "java" or "java.desktop:jawt") is specified, and > the build system turns this into suitable linker flags: `-ljawt -