idlecode added a comment.
Oh, sorry about this - I forgot. I will send patch during this weekend
https://reviews.llvm.org/D30748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
In https://reviews.llvm.org/D32437#750622, @zaks.anna wrote:
> > That wouldn't work this way because we'd have the completely redundant
> > "calling property accessor" piece before that, and "returning..." after
> > that.
>
> I think we should not print "calling" and "retur
zaks.anna added a comment.
> That wouldn't work this way because we'd have the completely redundant
> "calling property accessor" piece before that, and "returning..." after that.
I think we should not print "calling" and "returning" for calling into and
returning from autogenerated code, If we
NoQ added a comment.
> What are these? Is there a PR?
The best explanation we currently have, with examples, is
https://reviews.llvm.org/D24278
> It would be great if we could place a note on a parent that has location.
That's actually the best approach in my opinion, if achievable.
> For exa
zaks.anna added a comment.
Sorry for the delay!!!
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:180
+ inline const llvm::APSInt &getZeroWithTypeSize(QualType T,
+ bool isUnsigned = true) {
+
ahatanak created this revision.
r276215 made a change to annotate _Unwind_Exception with
"__attribute__((__aligned__))" so that exception objects are double-word
aligned. This fix hasn't been incorporated to unwind.h on Darwin yet and, since
it is an ABI breaking change, I'm not sure it will e
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
> These new "extra notes" of mine might be useful (we could put them at
> property declaration), i could add them if everybody likes this idea.
What are these? Is there a PR?
It would b
djasper added a comment.
Please read and address:
https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options
https://reviews.llvm.org/D33029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
stringham created this revision.
stringham added a project: clang-tools-extra.
Herald added a subscriber: klimek.
This adds an option to clang-format to support dangling parenthesis.
If you have a parameter list like
Foo(
param1,
param2,
param3,
);
clang-format currently only supports p
iris added a comment.
How can I make z3constraintmanager.cpp work in the command line?Or how to make
z3 work?
Repository:
rL LLVM
https://reviews.llvm.org/D28952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
2017-05-10 3:46 GMT+07:00 Richard Smith :
> On 1 March 2017 at 02:50, Serge Pavlov via Phabricator <
> revi...@reviews.llvm.org> wrote:
>
>>
>> Format of configuration file is similar to file used in the construct
>> `@file`, it is a set of options. Configuration file have advantage over
>> this c
sepavloff updated this revision to Diff 98395.
sepavloff added a comment.
Addressed reviewer's notes.
https://reviews.llvm.org/D33013
Files:
lib/Driver/Driver.cpp
test/Driver/aarch64-cpus.c
test/Driver/amdgpu-features.c
test/Driver/arm-darwin-builtin.c
test/Driver/arm-default-build-at
vlad.tsyrklevich updated this revision to Diff 98390.
vlad.tsyrklevich marked 3 inline comments as done.
vlad.tsyrklevich added a comment.
Herald added a subscriber: xazax.hun.
- Update the logic to move the LCV symbol logic into
ProgramState::addTaint(SVal) out of the GenericTaintChecker. This a
Author: ericwf
Date: Tue May 9 21:43:02 2017
New Revision: 302619
URL: http://llvm.org/viewvc/llvm-project?rev=302619&view=rev
Log:
Rename Appveyor install helper script.
I'm really lazy and the old name for the helper script
killed 2 letter tab completion for the include directory.
This patch r
Author: ericwf
Date: Tue May 9 21:36:48 2017
New Revision: 302617
URL: http://llvm.org/viewvc/llvm-project?rev=302617&view=rev
Log:
Support using MinGW POSIX threads on Windows
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
http://llvm.org/viewvc/llvm-
hfinkel added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:388
+
+ // add paths specified in LIBRARY_PATH environment variable as -L options.
+ addDirectoryList(Args, CmdArgs, "-L", "LIBRARY_PATH");
Comment sentences should start with a capital l
Author: ericwf
Date: Tue May 9 21:34:56 2017
New Revision: 302616
URL: http://llvm.org/viewvc/llvm-project?rev=302616&view=rev
Log:
attempt to fix appveyor syntax error
Modified:
libcxx/trunk/appveyor.yml
Modified: libcxx/trunk/appveyor.yml
URL:
http://llvm.org/viewvc/llvm-project/libcxx/t
Author: rsmith
Date: Tue May 9 21:30:28 2017
New Revision: 302615
URL: http://llvm.org/viewvc/llvm-project?rev=302615&view=rev
Log:
When we see a '<' operator, check whether it's a probable typo for a
template-id.
The heuristic that we use here is:
* the left-hand side must be a simple identif
Author: ericwf
Date: Tue May 9 21:30:16 2017
New Revision: 302614
URL: http://llvm.org/viewvc/llvm-project?rev=302614&view=rev
Log:
Add MinGW64 builder to Appveyor.
With the amount of work happening on Windows we should
have a MinGW bot to make sure we don't regress that functionality.
Currently
Author: ericwf
Date: Tue May 9 19:23:58 2017
New Revision: 302607
URL: http://llvm.org/viewvc/llvm-project?rev=302607&view=rev
Log:
Improve how LIT reports the added environment variables
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/config.py
U
EricWF added inline comments.
Comment at: include/__config:232-235
+#ifndef NOMINMAX
+#define NOMINMAX
+#endif
+
compnerd wrote:
> bcraig wrote:
> > I can see this helping when we are build libc++, but I don't think it helps
> > client apps. They could have inc
BillyONeal updated this revision to Diff 98376.
BillyONeal added a comment.
Bill got confused.
https://reviews.llvm.org/D33021
Files:
test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_copyable.pass.cpp
Index:
test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_co
Author: ericwf
Date: Tue May 9 19:05:04 2017
New Revision: 302604
URL: http://llvm.org/viewvc/llvm-project?rev=302604&view=rev
Log:
Attempt to unbreak Libc++ test configuration
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/config.py
URL:
http:/
Author: rsmith
Date: Tue May 9 19:01:13 2017
New Revision: 302603
URL: http://llvm.org/viewvc/llvm-project?rev=302603&view=rev
Log:
When instantiating a friend function template, don't forget to inherit default
template arguments from other declarations.
Modified:
cfe/trunk/lib/Sema/SemaTem
Author: ericwf
Date: Tue May 9 18:57:22 2017
New Revision: 302602
URL: http://llvm.org/viewvc/llvm-project?rev=302602&view=rev
Log:
Fix test runtime environment on Windows
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/config.py
URL:
http://llvm
vsk updated this revision to Diff 98371.
vsk marked 2 inline comments as done.
vsk added a comment.
Address comments from Adrian. (I settled on renaming 'getModularSanitizers' to
'getPPTransparentSanitizers'.)
https://reviews.llvm.org/D32724
Files:
include/clang/Basic/Sanitizers.h
lib/Basi
Author: ericwf
Date: Tue May 9 18:47:20 2017
New Revision: 302600
URL: http://llvm.org/viewvc/llvm-project?rev=302600&view=rev
Log:
Fix misspelling of environment throughout libc++
Modified:
libcxx/trunk/docs/TestingLibcxx.rst
libcxx/trunk/test/support/filesystem_dynamic_test_helper.py
BillyONeal updated this revision to Diff 98370.
BillyONeal edited the summary of this revision.
BillyONeal added a comment.
Eric asked to just nuke the offending lines.
https://reviews.llvm.org/D33021
Files:
test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_copyable.pass.cpp
aprantl added inline comments.
Comment at: include/clang/Basic/Sanitizers.h:64
- /// \brief Disable all sanitizers.
- void clear() { Mask = 0; }
+ /// \brief Disable the sanitizers specified in \p K (by default, disable
+ /// all sanitizers).
Might as well
BillyONeal added inline comments.
Comment at:
test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_copyable.pass.cpp:25
+ #define IMPLEMENTS_CWG_2094 false
+ #endif /* defined(_MSC_VER) && _MSC_VER >= 1911 */
+#endif
Whoops, I fat fingered the closin
majnemer added inline comments.
Comment at: include/support/win32/msvc_builtin_support.h:33
+
+_LIBCPP_ALWAYS_INLINE int __builtin_popcount(unsigned int x)
+{
compnerd wrote:
> I think I prefer the following implementation:
>
> _LIBCPP_ALWAYS_INLINE int __bu
BillyONeal created this revision.
Update is_trivially_copyable tests with CWG 2094
Clang 5.0 implements this here:
https://github.com/llvm-mirror/clang/commit/87cd035326a39523eeb1b295ad36cff337141ef9
MSVC++ will implement it in the first toolset update for VS 2017.
https://reviews.llvm.org/D33
Author: vedantk
Date: Tue May 9 18:34:49 2017
New Revision: 302598
URL: http://llvm.org/viewvc/llvm-project?rev=302598&view=rev
Log:
[ubsan] Mark overflow checks with !nosanitize
Sanitizer instrumentation generally needs to be marked with !nosanitize,
but we're not doing this properly for ubsan'
waltl updated this revision to Diff 98369.
https://reviews.llvm.org/D33020
Files:
lib/Driver/ToolChains/Myriad.cpp
test/Driver/myriad-toolchain.c
Index: test/Driver/myriad-toolchain.c
===
--- test/Driver/myriad-toolchain.c
+++
waltl created this revision.
https://reviews.llvm.org/D33020
Files:
lib/Driver/ToolChains/Myriad.cpp
test/Driver/myriad-toolchain.c
Index: test/Driver/myriad-toolchain.c
===
--- test/Driver/myriad-toolchain.c
+++ test/Driver/my
compnerd requested changes to this revision.
compnerd added inline comments.
Comment at: include/__config:232-235
+#ifndef NOMINMAX
+#define NOMINMAX
+#endif
+
bcraig wrote:
> I can see this helping when we are build libc++, but I don't think it helps
> client a
Author: rsmith
Date: Tue May 9 18:02:10 2017
New Revision: 302596
URL: http://llvm.org/viewvc/llvm-project?rev=302596&view=rev
Log:
Don't mark a member as a member specialization until we know we're keeping the
specialization.
This improves our behavior in a few ways:
* We now guarantee that
vsk updated this revision to Diff 98363.
vsk added a comment.
I've uploaded the correct diff this time, sorry for the confusion.
https://reviews.llvm.org/D32724
Files:
include/clang/Basic/Sanitizers.h
lib/Basic/LangOptions.cpp
lib/Frontend/CompilerInvocation.cpp
lib/Serialization/ASTRea
Author: eugenis
Date: Tue May 9 17:28:57 2017
New Revision: 302594
URL: http://llvm.org/viewvc/llvm-project?rev=302594&view=rev
Log:
Fix clang_cl argument in fsanitize.c driver test.
Modified:
cfe/trunk/test/Driver/fsanitize.c
Modified: cfe/trunk/test/Driver/fsanitize.c
URL:
http://llvm.or
Author: ericwf
Date: Tue May 9 17:21:24 2017
New Revision: 302593
URL: http://llvm.org/viewvc/llvm-project?rev=302593&view=rev
Log:
[Sema] Implement Core 2094: Trivial copy/move constructor for class with
volatile member
Summary: This patch implements
http://www.open-std.org/jtc1/sc22/wg21/doc
EricWF updated this revision to Diff 98359.
EricWF added a comment.
- Remove unrelated issues list changes.
https://reviews.llvm.org/D32984
Files:
lib/AST/Type.cpp
test/CXX/drs/dr20xx.cpp
test/CXX/drs/dr4xx.cpp
test/SemaCXX/type-traits.cpp
www/cxx_dr_status.html
Index: www/cxx_dr_sta
Author: ericwf
Date: Tue May 9 17:17:23 2017
New Revision: 302592
URL: http://llvm.org/viewvc/llvm-project?rev=302592&view=rev
Log:
Update Clang C++ DR documentation for new issue list
Modified:
cfe/trunk/www/cxx_dr_status.html
Modified: cfe/trunk/www/cxx_dr_status.html
URL:
http://llvm.or
rjmccall added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:7129
+NewVD->getType().getAddressSpace() != LangAS::opencl_constant) ||
NewVD->hasExternalStorage()) {
if (!T->isSamplerT() &&
Seeing criteria like this, and a lot of the ot
eugenis closed this revision.
eugenis added a comment.
r302591, thanks for the review!
Repository:
rL LLVM
https://reviews.llvm.org/D32886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: eugenis
Date: Tue May 9 16:57:39 2017
New Revision: 302590
URL: http://llvm.org/viewvc/llvm-project?rev=302590&view=rev
Log:
Remove unnecessary calls to MakeArgString.
Modified:
cfe/trunk/lib/Driver/SanitizerArgs.cpp
cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp
Modified: cfe/tr
Author: eugenis
Date: Tue May 9 16:57:43 2017
New Revision: 302591
URL: http://llvm.org/viewvc/llvm-project?rev=302591&view=rev
Log:
[asan] A clang flag to enable ELF globals-gc.
This feature is subtly broken when the linker is gold 2.26 or
earlier. See the following bug for details:
https://s
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
In https://reviews.llvm.org/D16171#540261, @phabricss wrote:
> ../include/sys/stat.h:16:15: error: cannot apply asm label to function
> after its first use
> hidden_proto (__fxst
rsmith added a comment.
Er, please ignore the inline review comments; those predated the realisation
that this doesn't actually fix the glibc build problem.
https://reviews.llvm.org/D16171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
eugenis added a comment.
I'll fix the other unnecessary MakeArgString calls in a separate commit
Repository:
rL LLVM
https://reviews.llvm.org/D32886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
eugenis updated this revision to Diff 98354.
eugenis marked an inline comment as done.
Repository:
rL LLVM
https://reviews.llvm.org/D32886
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cpp
rsmith added a comment.
Thank you, some of these test typos are ... alarming. =)
A couple of the test updates don't look quite right, but this mostly looks
great.
Comment at: test/Driver/amdgpu-features.c:1
-// RUN: %clang -### -target amdgcn -x cl -S -emit-llvm -mcpu=kaveri
Author: serge_sans_paille
Date: Tue May 9 16:19:44 2017
New Revision: 302588
URL: http://llvm.org/viewvc/llvm-project?rev=302588&view=rev
Log:
Fix CGObjCGNU::init bug introduced by r302572
Modified:
cfe/trunk/lib/CodeGen/CGObjCGNU.cpp
Modified: cfe/trunk/lib/CodeGen/CGObjCGNU.cpp
URL:
http
On 1 March 2017 at 02:50, Serge Pavlov via Phabricator <
revi...@reviews.llvm.org> wrote:
> sepavloff added a comment.
>
> Glad to know that someone is interested in this feature!
> Below is actual proposal.
>
> **Adding named configuration files to clang driver**
>
> A configuration file is a col
vsk updated this revision to Diff 98349.
vsk marked 7 inline comments as done.
vsk added a comment.
Add a comment explaining how and why ASTReader checks for sanitizer feature
mismatches.
https://reviews.llvm.org/D32724
Files:
include/clang/Basic/Sanitizers.h
lib/Basic/LangOptions.cpp
li
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D32743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302580: clang-format: [JS] Don't indent JavaScript IIFEs.
(authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D32989?vs=98332&id=98344#toc
Repository:
rL LLVM
https://reviews.ll
Author: mprobst
Date: Tue May 9 15:04:09 2017
New Revision: 302580
URL: http://llvm.org/viewvc/llvm-project?rev=302580&view=rev
Log:
clang-format: [JS] Don't indent JavaScript IIFEs.
Because IIFEs[1] are often used like an anonymous namespace around large
sections of JavaScript code, it's useful
gtbercea added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D29654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst accepted this revision.
mprobst added inline comments.
This revision is now accepted and ready to land.
Comment at: unittests/Format/FormatTestJS.cpp:371
+TEST_F(FormatTestJS, IIFE) {
+ verifyFormat("(function() {\n"
+ "var a = 1;\n"
danbea
yaxunl added inline comments.
Comment at: lib/Headers/opencl-c.h:16020
+// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID.
+#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t))
bool __ovld is_valid_reserve_id(reserve_id_t reserve_id);
--
Author: adrian
Date: Tue May 9 14:47:41 2017
New Revision: 302577
URL: http://llvm.org/viewvc/llvm-project?rev=302577&view=rev
Log:
Update testcase for upstream LLVM changes (r302469).
Modified:
cfe/trunk/test/CodeGenCXX/linetable-virtual-variadic.cpp
Modified: cfe/trunk/test/CodeGenCXX/lin
vsk updated this revision to Diff 98343.
vsk retitled this revision from "[Modules] Include the enabled sanitizers in
the module hash" to "[Modules] Handle sanitizer feature mismatches when
importing modules".
vsk edited the summary of this revision.
vsk added a comment.
If compatible difference
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Please first check in a change that just regenerates cxx_dr_status without your
changes, to separate out the changes due to the new issues list from the
changes due to this patch. (You can go
Author: serge_sans_paille
Date: Tue May 9 14:31:30 2017
New Revision: 302572
URL: http://llvm.org/viewvc/llvm-project?rev=302572&view=rev
Log:
Suppress all uses of LLVM_END_WITH_NULL. NFC.
Use variadic templates instead of relying on + sentinel.
This enforces better type checking and makes cod
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302572: Suppress all uses of LLVM_END_WITH_NULL. NFC.
(authored by serge_sans_paille).
Changed prior to commit:
https://reviews.llvm.org/D32550?vs=96798&id=98339#toc
Repository:
rL LLVM
https://revi
dexonsmith added a comment.
In https://reviews.llvm.org/D32724#750074, @vsk wrote:
> In https://reviews.llvm.org/D32724#749868, @dexonsmith wrote:
>
> > In https://reviews.llvm.org/D32724#747728, @aprantl wrote:
> >
> > > Is it the right solution to use the module hash for correctness, or
> > >
rsmith added inline comments.
Comment at: include/clang/Sema/Sema.h:1464
+ /// Determine if \p D abd \p Suggested have a structurally compatibale
+ /// layout as described in C11 6.2.7/1.
rsmith wrote:
> Typo 'abd'
Typo 'compatibale' =)
Com
vsk added a comment.
In https://reviews.llvm.org/D32724#749868, @dexonsmith wrote:
> In https://reviews.llvm.org/D32724#747728, @aprantl wrote:
>
> > Is it the right solution to use the module hash for correctness, or should
> > the mismatch of the serialized langopts trigger a module rebuild an
rsmith added inline comments.
Comment at: lib/Sema/SemaLookup.cpp:4971-4972
assert(Owner && "definition of hidden declaration is not in a module");
+ assert((!isVisible(Decl) || VisibleModules.isVisible(Owner)) &&
+ "missing import for non-hidden decl?");
--
Author: sbc
Date: Tue May 9 13:44:23 2017
New Revision: 302569
URL: http://llvm.org/viewvc/llvm-project?rev=302569&view=rev
Log:
[WebAssembly] Fix failing wasm-toolchain test
This test was broken in r302558.
Differential Revision: https://reviews.llvm.org/D33015
Modified:
cfe/trunk/test/Dr
rsmith added inline comments.
Comment at: lib/Serialization/ASTReaderDecl.cpp:213-215
+ assert(isa(D) ||
+ isa(D) &&
+ "Decl doesn't have specializations.");
Can this ever fail at runtime? I'd expect the below code to not compile if `
v.g.vassilev updated this revision to Diff 98333.
v.g.vassilev marked an inline comment as done.
v.g.vassilev added a comment.
Reduce code duplication. Use llvm_unreachable.
https://reviews.llvm.org/D29951
Files:
lib/Serialization/ASTReaderDecl.cpp
Index: lib/Serialization/ASTReaderDecl.cpp
danbeam added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:2353
+ // expressions?
+ if (Line->Tokens.size() < 5)
+return false;
mprobst wrote:
> There's a `startsSequenceInternal` on `Line` that might come in handy here?
it wasn't on `Lin
danbeam updated this revision to Diff 98332.
danbeam marked 4 inline comments as done.
danbeam added a comment.
mprobst@ review
https://reviews.llvm.org/D32989
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
sepavloff updated this revision to Diff 98330.
sepavloff added a comment.
Herald added subscribers: krytarowski, rengolin.
Updated patch
https://reviews.llvm.org/D24933
Files:
docs/UsersManual.rst
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Config/config.h.cmake
include/c
sepavloff created this revision.
Herald added subscribers: krytarowski, javed.absar, nhaehnle, rengolin,
aemerson.
Now if clang driver is given wrong arguments, in some cases it
continues execution and returns zero code. This change fixes this
behavior.
The fix revealed some errors in clang test
aprantl added inline comments.
Comment at: lib/Serialization/ASTReaderDecl.cpp:3814
+ } else // TypeAliasTemplateDecl
+assert(0 && "TypeAliasTemplateDecl doesn't have specs!");
+}
llvm_unreachable()
Repository:
rL LLVM
https://reviews.llvm.o
Anastasia accepted this revision.
Anastasia added inline comments.
This revision is now accepted and ready to land.
Comment at: test/SemaOpenCL/array-init.cl:4
+
+__kernel void k2(queue_t q1, queue_t q2) {
+ queue_t q[] = {q1, q2};
Minor thing - I would use sequ
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! It's a pity we are not testing anything here.
https://reviews.llvm.org/D32897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Anastasia added inline comments.
Comment at: lib/Headers/opencl-c.h:16020
+// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID.
+#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t))
bool __ovld is_valid_reserve_id(reserve_id_t reserve_id);
---
Author: rksimon
Date: Tue May 9 12:50:16 2017
New Revision: 302559
URL: http://llvm.org/viewvc/llvm-project?rev=302559&view=rev
Log:
[X86][LWP] Remove MSVC LWP intrinsics stubs.
Now provided in lwpintrin.h
Modified:
cfe/trunk/lib/Headers/intrin.h
Modified: cfe/trunk/lib/Headers/intrin.h
UR
Author: sbc
Date: Tue May 9 12:47:50 2017
New Revision: 302558
URL: http://llvm.org/viewvc/llvm-project?rev=302558&view=rev
Log:
[WebAssembly] Fix location and -flavor when running lld
Add the toolchain installation directory to the program
path so that lld can be found.
Change -flavor to wasm.
Author: rksimon
Date: Tue May 9 12:43:16 2017
New Revision: 302557
URL: http://llvm.org/viewvc/llvm-project?rev=302557&view=rev
Log:
[X86][LWP] Removing LWP todo comment. NFCI.
LWP / lwpintrin.h is now supported
Modified:
cfe/trunk/lib/Headers/x86intrin.h
Modified: cfe/trunk/lib/Headers/x8
Author: adrian
Date: Tue May 9 12:27:03 2017
New Revision: 302556
URL: http://llvm.org/viewvc/llvm-project?rev=302556&view=rev
Log:
Build the Apple-style stage2 with modules
Green dragon had a green stage2 modules bot for a long time now[1] and
it is time to retire it and make a modules build th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302556: Build the Apple-style stage2 with modules (authored
by adrian).
Changed prior to commit:
https://reviews.llvm.org/D32603?vs=96952&id=98320#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3
Reverted in r302555.
From: hwennb...@google.com [hwennb...@google.com] on behalf of Hans Wennborg
[h...@chromium.org]
Sent: Tuesday, May 09, 2017 7:18 PM
To: Petar Jovanovic
Cc: cfe-commits
Subject: Re: r302547 - [mips] Impose a threshold for coercion of ag
Author: petarj
Date: Tue May 9 12:20:06 2017
New Revision: 302555
URL: http://llvm.org/viewvc/llvm-project?rev=302555&view=rev
Log:
Revert r302547 ([mips] Impose a threshold for coercion of aggregates)
Reverting
Modified MipsABIInfo::classifyArgumentType so that it now coerces
aggregate stru
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
This makes a lot of sense to me. See also r302463: I think we probably want
three levels of shadowing here: the main input shadows -fmodule-map-file, which
shadows module maps loaded implicitl
On Tue, May 9, 2017 at 9:24 AM, Petar Jovanovic via cfe-commits
wrote:
> Author: petarj
> Date: Tue May 9 11:24:03 2017
> New Revision: 302547
>
> URL: http://llvm.org/viewvc/llvm-project?rev=302547&view=rev
> Log:
> [mips] Impose a threshold for coercion of aggregates
>
> Modified MipsABIInfo::c
dexonsmith added a comment.
In https://reviews.llvm.org/D32724#747728, @aprantl wrote:
> Is it the right solution to use the module hash for correctness, or should
> the mismatch of the serialized langopts trigger a module rebuild and the
> module hash is only there to tune the performance/disk
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Let's go ahead with this. I've been unable to find a testcase that triggers the
problem, but we shouldn't keep a known latent bug around just because we don't
know how to expose it yet.
http
yaxunl updated this revision to Diff 98314.
yaxunl added a comment.
Revised by reviewers' comments.
https://reviews.llvm.org/D32248
Files:
include/clang/AST/Type.h
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CodeGenTypes.cpp
lib/CodeGen/TargetInfo.cpp
lib/CodeGen/TargetInfo.h
test/CodeGen/ad
nlewycky added a comment.
Ping!
https://reviews.llvm.org/D31839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: petarj
Date: Tue May 9 11:24:03 2017
New Revision: 302547
URL: http://llvm.org/viewvc/llvm-project?rev=302547&view=rev
Log:
[mips] Impose a threshold for coercion of aggregates
Modified MipsABIInfo::classifyArgumentType so that it now coerces aggregate
structures only if the size of said
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302547: [mips] Impose a threshold for coercion of aggregates
(authored by petarj).
Changed prior to commit:
https://reviews.llvm.org/D32900?vs=98269&id=98304#toc
Repository:
rL LLVM
https://reviews.
erik.pilkington added a comment.
Ping! @mclow.lists: Do you have any thoughts here?
https://reviews.llvm.org/D30837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
A couple of minor comments, but otherwise LGTM.
Comment at: include/clang/AST/DeclCXX.h:1569
+ bool lookupInBases(BaseMatchesCallback BaseMatches, CXXBasePaths &Pa
Author: arphaman
Date: Tue May 9 11:05:04 2017
New Revision: 302545
URL: http://llvm.org/viewvc/llvm-project?rev=302545&view=rev
Log:
[CodeCompletion] Complete platform names in @available expressions
rdar://32074504
Added:
cfe/trunk/test/Index/complete-available.m
Modified:
cfe/trunk/i
bcraig added inline comments.
Comment at: include/__config:232-235
+#ifndef NOMINMAX
+#define NOMINMAX
+#endif
+
I can see this helping when we are build libc++, but I don't think it helps
client apps. They could have included windows.h before including our hea
Author: hans
Date: Tue May 9 10:55:39 2017
New Revision: 302542
URL: http://llvm.org/viewvc/llvm-project?rev=302542&view=rev
Log:
Revert r302476 "Update testcase for upstream LLVM changes."
That test update was for r302469, which was reverted in r302533 due to PR32977.
Modified:
cfe/trunk/t
1 - 100 of 135 matches
Mail list logo
