yvvan added a comment.
ping 3
https://reviews.llvm.org/D36390
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sylvestre
Date: Thu Sep 28 01:00:18 2017
New Revision: 314387
URL: http://llvm.org/viewvc/llvm-project?rev=314387&view=rev
Log:
Add the new -Wnull-pointer-arithmetic warnings to the release notes
Differential Revision: https://reviews.llvm.org/D38186
Modified:
cfe/trunk/docs/Release
sylvestre.ledru accepted this revision.
sylvestre.ledru added a comment.
This revision is now accepted and ready to land.
Thanks, it makes sense!
Landed in r314387
https://reviews.llvm.org/D38186
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
Author: d0k
Date: Thu Sep 28 01:50:30 2017
New Revision: 314391
URL: http://llvm.org/viewvc/llvm-project?rev=314391&view=rev
Log:
Use std::is_trivial instead of is_trivially_copyable.
The oldest versions of GCC we support (before 5) didn't support that
trait. is_trivial is stronger superset that
lebedev.ri added a comment.
Ping.
In https://reviews.llvm.org/D36836#877642, @lebedev.ri wrote:
> In https://reviews.llvm.org/D36836#877636, @alexfh wrote:
>
> > > The metric is implemented as per COGNITIVE COMPLEXITY by SonarSource
> > > specification version 1.2 (19 April 2017),
> >
> > Err,
Thanks for the ack Daniel. Hopefully others will eventually have a
chance to review.
On 27/09/17 19:00, Daniel Berlin wrote:
(As i mentioned to hal offline, i'm too slammed to help here)
On Wed, Sep 27, 2017 at 8:47 AM, Ivan A. Kosarev via Phabricator
mailto:revi...@reviews.llvm.org>> wrote:
filcab created this revision.
If LLVM_DEFAULT_TARGET_TRIPLE is a non-darwin triple, the file might
fail. This might allow us to take out the FIXME and REQUIRES lines, but I'd
rather let the bots double-check that the test is ok first.
https://reviews.llvm.org/D38354
Files:
test/Index/pch-from
Nebiroth added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:20
#include
+#include
malaperle wrote:
> William, did you perhaps miss this comment? I don't think unistd.h makes
> sense here.
I indeed missed it.
https://reviews.llvm.org/D37150
_
Hahnfeld marked 2 inline comments as done.
Hahnfeld added a comment.
The error with `-DLLVM_USE_SANITIZER=Address` is
-- Check if the system is big endian
-- Searching 16 bit integer
-- Looking for stddef.h
-- Looking for stddef.h - not found
-- Check size of unsigned short
-- Check s
Hahnfeld updated this revision to Diff 116977.
Hahnfeld retitled this revision from "[compiler-rt}[CMake] Fix configuration on
PowerPC with sanitizers" to "[compiler-rt][CMake] Fix configuration on PowerPC
with sanitizers".
Hahnfeld added a subscriber: gtbercea.
https://reviews.llvm.org/D38277
comicfans44 created this revision.
comicfans44 added a project: clang.
clang will drop user supplied include path if it's already in system include
paths to emulate gcc. if two files with same name both exist in user path and
system path, and user set system path first in arguments, this leads d
curdeius created this revision.
This patch is motivated by bug #34739
(https://bugs.llvm.org/show_bug.cgi?id=34739).
Clang-format misbehaves because escape sequence '\t' in regex is treated as
literal 't'.
This patch handles escaped characters inside square brackets as well (so that
somebody ca
NoQ created this revision.
In `ProgramState::getSVal(Loc, QualType)`, the `QualType` parameter, which
represents the type of the expected value, is optional. If it is not supplied,
it is auto-detected by looking at the memory region in `Loc`. For typed-value
regions such autodetection is trivia
NoQ updated this revision to Diff 116986.
NoQ added a comment.
Add a forgotten comment.
https://reviews.llvm.org/D38358
Files:
lib/StaticAnalyzer/Core/RegionStore.cpp
test/Analysis/ctor.mm
test/Analysis/gtest.cpp
Index: test/Analysis/gtest.cpp
===
rogfer01 created this revision.
https://reviews.llvm.org/D38362
Files:
test/std/re/re.alg/re.alg.match/exponential.pass.cpp
Index: test/std/re/re.alg/re.alg.match/exponential.pass.cpp
===
--- test/std/re/re.alg/re.alg.match/expon
NoQ updated this revision to Diff 116992.
NoQ added a subscriber: alexfh.
NoQ added a comment.
Add @alexfh's small reproducer test case. It was so small i never noticed it
until now!
https://reviews.llvm.org/D38358
Files:
lib/StaticAnalyzer/Core/RegionStore.cpp
test/Analysis/ctor.mm
test
ilya-biryukov added a comment.
Sorry for delays
@malaperle, thanks for submitting the patch.
Repository:
rL LLVM
https://reviews.llvm.org/D36150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
filcab created this revision.
Also makes it pass on Darwin, if the default target triple is a Linux triple.
https://reviews.llvm.org/D38364
Files:
test/Modules/builtin-import.mm
Index: test/Modules/builtin-import.mm
===
--- tes
alexfh added a comment.
Thank you for the fix! It seems to be the largest source of SA crashes on our
code at the moment.
https://reviews.llvm.org/D38358
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
ilya-biryukov added a comment.
Sorry for late response.
Comment at: clangd/ClangdUnit.cpp:610
+ParameterInformation Info;
+OptionalParameterLabel = getOptionalString(*Chunk.Optional);
+Result.label += OptionalParameterLabel;
Are we first
Author: nico
Date: Thu Sep 28 08:44:46 2017
New Revision: 314424
URL: http://llvm.org/viewvc/llvm-project?rev=314424&view=rev
Log:
Fix -Wcast-qual warning after r314336.
Modified:
cfe/trunk/lib/AST/ExternalASTMerger.cpp
Modified: cfe/trunk/lib/AST/ExternalASTMerger.cpp
URL:
http://llvm.org/
filcab updated this revision to Diff 117002.
filcab added a comment.
Add umbrella-header-include-builtin.mm too
https://reviews.llvm.org/D38364
Files:
test/Modules/builtin-import.mm
test/Modules/umbrella-header-include-builtin.mm
Index: test/Modules/umbrella-header-include-builtin.mm
n.bozhenov created this revision.
https://reviews.llvm.org/rL314336 introduced a new compile time warning about
casting a const pointer to void*. Because of that the compiler fails to be
built with `-Werror` flag. The suggested patch fixes the issue.
https://reviews.llvm.org/D38366
Files:
c
ilya-biryukov added inline comments.
Comment at: clangd/GlobalCompilationDatabase.cpp:82
// FIXME(ibiryukov): Invalidate cached compilation databases on changes
+return Result;
Why remove this `FIXME`?
Comment at: clangd/tool/ClangdM
yaxunl marked 5 inline comments as done.
yaxunl added inline comments.
Comment at: lib/Sema/SemaType.cpp:6810
+ QualType &T, TypeAttrLocation TAL) {
+ if (!State.getSema().getLangOpts().OpenCL ||
+ T.getAddressSpace() != LangAS::Defa
n.bozhenov abandoned this revision.
n.bozhenov added a comment.
Seems that it has been just fixed by https://reviews.llvm.org/rL314424 :-)
Abandoning this review.
https://reviews.llvm.org/D38366
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Author: nico
Date: Thu Sep 28 09:16:39 2017
New Revision: 314427
URL: http://llvm.org/viewvc/llvm-project?rev=314427&view=rev
Log:
Consolidate std::move() detection code. No behavior change.
Modified:
cfe/trunk/include/clang/AST/Expr.h
cfe/trunk/lib/Analysis/Consumed.cpp
cfe/trunk/lib
Any news on this?
Aaand the patch itself...
-K
On 9/8/2017 10:32 AM, Krzysztof Parzyszek via cfe-commits wrote:
This should to to cfe-commits. Redirecting.
-Krzysztof
On 9/8/2017 10:25 AM, Antoni Boucher via llvm-commits wrote:
Hello.
I've fixed the bug 27628:
https://bugs.llvm.org/show_b
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks Filipe, LGTM
https://reviews.llvm.org/D38364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
frutiger added inline comments.
Comment at: bindings/python/clang/cindex.py:320
+return self._get_spelling()['offset']
def __eq__(self, other):
compnerd wrote:
> Does it make sense to introduce two new properties `expansion` and `spelling`
> and h
yaxunl marked an inline comment as done.
yaxunl added a comment.
Ping.
Brian, Stas,
Can you review this since Matt is on vacation? Thanks.
https://reviews.llvm.org/D37568
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D38202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
yaxunl updated this revision to Diff 117020.
yaxunl marked 3 inline comments as done.
yaxunl added a comment.
Revised by Anastasia's comments.
https://reviews.llvm.org/D35082
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
include/clang/Basic/AddressSpaces.h
lib/AST/ASTCo
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
This is somewhat complicated in that noexcept, throw(), and
__attribute__(())/__declspec no throw are all synonyms for one another except
for the type system effect differences b
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D38205#882737, @erichkeane wrote:
> changes that were suggested by @aaron.ballman
>
> It DOES warn on the template correctly, however I'm not thrilled
probinson added a comment.
I think I will go ahead and commit this; it doesn't change the status quo for
CodeView and if something is warranted we can do that in a follow-up.
https://reviews.llvm.org/D14358
___
cfe-commits mailing list
cfe-commits@
b-sumner accepted this revision.
b-sumner added a comment.
This revision is now accepted and ready to land.
LGTM. I think we can leave immediates to another patch.
https://reviews.llvm.org/D37568
___
cfe-commits mailing list
cfe-commits@lists.llvm.
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
https://reviews.llvm.org/D38371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Hahnfeld created this revision.
The recent fix in https://reviews.llvm.org/D38258 was wrong: getAuxTriple()
only returns
non-null values for the CUDA toolchain. That is why the now added
test for PPC and X86 failed.
https://reviews.llvm.org/D38372
Files:
include/clang/Driver/ToolChain.h
li
Author: probinson
Date: Thu Sep 28 11:37:02 2017
New Revision: 31
URL: http://llvm.org/viewvc/llvm-project?rev=31&view=rev
Log:
[DWARF] Allow forward declarations of a class template instantiation
to have child entries describing the template parameters. This will
be on by default for SCE
This revision was automatically updated to reflect the committed changes.
Closed by commit rL31: [DWARF] Allow forward declarations of a class
template instantiation (authored by probinson).
Changed prior to commit:
https://reviews.llvm.org/D14358?vs=116862&id=117030#toc
Repository:
rL L
Author: ibiryukov
Date: Thu Sep 28 11:39:59 2017
New Revision: 314445
URL: http://llvm.org/viewvc/llvm-project?rev=314445&view=rev
Log:
[clangd] Skip informative qualifier chunks.
Summary:
Completion results look much nicer without them.
Informative qualifiers are stored for every method from a b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314445: [clangd] Skip informative qualifier chunks.
(authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D38083
Files:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
clang-tools-ex
When you're submitting a patch, please make sure you're sending it to
the right list, and the "subject" line actually describes what the patch
changes; otherwise, reviewers won't notice the patch. Optionally, you
can submit a patch using Phabricator, a tool which which makes patch
reviews a li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314452: [AMDGPU] Allow flexible register names in inline asm
constraints (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D37568?vs=116383&id=117037#toc
Repository:
rL LLVM
ht
Author: yaxunl
Date: Thu Sep 28 12:07:59 2017
New Revision: 314452
URL: http://llvm.org/viewvc/llvm-project?rev=314452&view=rev
Log:
[AMDGPU] Allow flexible register names in inline asm constraints
Currently AMDGPU inline asm only allow v and s as register names in constraints.
This patch allows
aaron.ballman added inline comments.
Comment at: test/FixIt/format.m:256
+ // see the comment in PrintfSpecifier::fixType in PrintfFormatString.cpp.
+}
+
Can you add some positive tests that show "%t" and "%tu" working properly
without warnings?
Repository:
frutiger updated this revision to Diff 117041.
frutiger added a comment.
Updated as per review.
https://reviews.llvm.org/D37905
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_location.py
tools/libclang/CXSourceLocation.cpp
Index: tools/libclang/CXSourceLocation.
Isn't this a C++11 feature though?
I'm not sure what to make of the fact that I haven't gotten any
complaints from the bots in over 12 hrs i think?
Should I just turn it into a comment?
Thanks!
Faisal Vali
On Wed, Sep 27, 2017 at 9:54 PM, James Y Knight wrote:
> This still doesn't work on s
aaron.ballman added inline comments.
Comment at: test/CXX/expr/expr.post/expr.sub/p1.cpp:3-6
+void pr34273() {
+ char Normal = "clang"[true]; // expected-no-diagnostics
+ char Special = true["clang"]; // expected-no-diagnostics
+}
I think this test should be ad
aaron.ballman added a comment.
In https://reviews.llvm.org/D36836#883214, @lebedev.ri wrote:
> @alexfh please specify, is that enough or not?
I think it's sufficient, but we should put that information somewhere pertinent
rather than just the review. In the past, we've put something into LICEN
Author: erichkeane
Date: Thu Sep 28 13:08:03 2017
New Revision: 314456
URL: http://llvm.org/viewvc/llvm-project?rev=314456&view=rev
Log:
Add Documentation to attribute-nothrow. Additionally, limit to functions.
Attribute nothrow is only allowed on functions, so I added that. Additionally,
it lack
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314456: Add Documentation to attribute-nothrow.
Additionally, limit to functions. (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D38202?vs=116705&id=117044#toc
Repository:
Hi,
Please find attached a diff to fix the issue 12176. Let me know if there
is anything any improvements you can think of.
Best regards,
Oscar
Index: lib/Sema/DepthAndIndex.h
===
--- lib/Sema/DepthAndIndex.h (nonexistent)
+++ l
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/NamespaceCommentCheck.cpp:86
+ SourceLocation LBracketLocation = ND->getLocation();
+ auto NestedNamespaceBegin = LBracketLocation;
+
Do not use `auto` here (the type is not spelled out in
Author: caseycarter
Date: Thu Sep 28 13:23:43 2017
New Revision: 314459
URL: http://llvm.org/viewvc/llvm-project?rev=314459&view=rev
Log:
[test] forwardlist.cons/move_noexcept.pass.cpp
* Don't forbid non-libc++ implementations from strengthening noexcept on
forward_list's move constructor.
Modi
Author: erichkeane
Date: Thu Sep 28 13:23:43 2017
New Revision: 314460
URL: http://llvm.org/viewvc/llvm-project?rev=314460&view=rev
Log:
Fix test change missed in r314456
Modified:
cfe/trunk/test/Misc/pragma-attribute-supported-attributes-list.test
Modified: cfe/trunk/test/Misc/pragma-attrib
+silvas
On 9/28/17 2:19 PM, Oscar Forner Martinez via cfe-commits wrote:
Hi,
Please find attached a diff to fix the issue 12176.
Link for the lazy: llvm.org/PR12176
Let me know if there
is anything any improvements you can think of.
Best regards,
Oscar
Extract-getDepthAndIndex-issue-1
mstorsjo created this revision.
Herald added a subscriber: mgorny.
This is the cmake specific parts of https://reviews.llvm.org/D33601 (by Martell
Malone) split out into a separate patch, to ease getting this part reviewed
indendent of the rest of that patch.
https://reviews.llvm.org/D38380
F
mstorsjo created this revision.
Herald added subscribers: kristof.beyls, aemerson.
This extends SVN r314197 (https://reviews.llvm.org/D38249) from the arm parts
to the whole file (the x86 parts as well).
https://reviews.llvm.org/D38381
Files:
src/UnwindRegistersRestore.S
src/UnwindRegister
Author: erichkeane
Date: Thu Sep 28 13:36:53 2017
New Revision: 314461
URL: http://llvm.org/viewvc/llvm-project?rev=314461&view=rev
Log:
[Sema] Warn on attribute nothrow conflicting with language specifiers
I discovered it was possible to create a 'nothrow' noexcept(false)
function, which is both
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314461: [Sema] Warn on attribute nothrow conflicting with
language specifiers (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D38205?vs=116892&id=117050#toc
Repository:
rL
Hi Jonathan,
Thanks for the input. I will amend it and update it. I created an entry
in Phabricator too (https://reviews.llvm.org/D38382).
Best regards,
Oscar
On 28/09/17 21:28, Jonathan Roelofs wrote:
+silvas
On 9/28/17 2:19 PM, Oscar Forner Martinez via cfe-commits wrote:
Hi,
Please f
Author: erichkeane
Date: Thu Sep 28 13:47:10 2017
New Revision: 314462
URL: http://llvm.org/viewvc/llvm-project?rev=314462&view=rev
Log:
[Sema] Correct nothrow inherited by noexcept
As reported in https://bugs.llvm.org/show_bug.cgi?id=33235,
a noexcept function was unable to inherit from a nothro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314462: [Sema] Correct nothrow inherited by noexcept
(authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D38209?vs=116840&id=117053#toc
Repository:
rL LLVM
https://reviews.ll
Rakete updated this revision to Diff 117051.
Rakete added a comment.
- Moved test to test/CXX/
Do I actually need to -verify the test if no diagnostics are expected?
Thanks @aaron.ballman
https://reviews.llvm.org/D38342
Files:
lib/Parse/ParseExpr.cpp
test/Parser/cxx-bool.cpp
Ind
aaron.ballman added a comment.
In https://reviews.llvm.org/D38342#883872, @Rakete wrote:
> - Moved test to test/CXX/
>
> Do I actually need to -verify the test if no diagnostics are expected?
>
> Thanks @aaron.ballman
Yes, you need to make sure that verify is on the RUN line. The existi
Rakete updated this revision to Diff 117054.
Rakete added a comment.
- Fixed test case for bools
Ah got it! Thanks!!
https://reviews.llvm.org/D38342
Files:
lib/Parse/ParseExpr.cpp
test/Parser/cxx-bool.cpp
Index: test/Parser/cxx-bool.cpp
===
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! Do you need me to commit on your behalf?
https://reviews.llvm.org/D38342
___
cfe-commits mailing list
cfe-commits@lists.llvm.
Rakete added a comment.
Yes please :) Thanks @aaron.ballman
https://reviews.llvm.org/D38342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Thu Sep 28 14:29:18 2017
New Revision: 314463
URL: http://llvm.org/viewvc/llvm-project?rev=314463&view=rev
Log:
Properly parse a postfix expression following a Boolean literal. Fixes PR34273.
Patch by Nicolas Lesser.
Modified:
cfe/trunk/lib/Parse/ParseExpr.cpp
aaron.ballman closed this revision.
aaron.ballman added a comment.
Committed in r314463.
Btw, if you're not in the IRC channel (#llvm on OFTC), you should hang out in
there to make sure no build bots break due to the commit.
https://reviews.llvm.org/D38342
__
Yeah, I hang out there :) Will do for sure
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexshap updated this revision to Diff 117061.
alexshap added a comment.
Add positive tests
Repository:
rL LLVM
https://reviews.llvm.org/D38270
Files:
include/clang/AST/ASTContext.h
include/clang/Basic/TargetInfo.h
lib/AST/ASTContext.cpp
lib/Analysis/PrintfFormatString.cpp
lib/Anal
It was fixed in r314391, to use is_trivial instead of is_trivially_copyable.
On Thu, Sep 28, 2017 at 3:57 PM, Faisal Vali wrote:
> Isn't this a C++11 feature though?
>
> I'm not sure what to make of the fact that I haven't gotten any
> complaints from the bots in over 12 hrs i think?
>
> Should
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D38270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: alexshap
Date: Thu Sep 28 16:11:31 2017
New Revision: 314470
URL: http://llvm.org/viewvc/llvm-project?rev=314470&view=rev
Log:
[clang] Add getUnsignedPointerDiffType method
C11 standard refers to the unsigned counterpart of the type ptrdiff_t
in the paragraph 7.21.6.1p7 where it defines
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314470: [clang] Add getUnsignedPointerDiffType method
(authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D38270?vs=117061&id=117075#toc
Repository:
rL LLVM
https://reviews.llv
Author: vsapsai
Date: Thu Sep 28 16:18:49 2017
New Revision: 314473
URL: http://llvm.org/viewvc/llvm-project?rev=314473&view=rev
Log:
[Sema] Put nullability fix-it after the end of the pointer.
Fixes nullability fix-it for `id`. With this change
nullability specifier is inserted after ">" instead
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314473: [Sema] Put nullability fix-it after the end of the
pointer. (authored by vsapsai).
Changed prior to commit:
https://reviews.llvm.org/D38327?vs=116861&id=117076#toc
Repository:
rL LLVM
https:
vsapsai added a comment.
In https://reviews.llvm.org/D38327#882540, @jordan_rose wrote:
> Nice catch, Volodymyr! Looks good to me.
Thanks for the quick review, Jordan.
Repository:
rL LLVM
https://reviews.llvm.org/D38327
___
cfe-commits mailing
dcoughlin added a comment.
This is such a nasty bug! It is great to see a fix. I have two comments inline,
one of which is just a nit.
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1404
+ // When trying to dereference a void pointer, read the first byte.
+
dcoughlin added a comment.
Artem: Sorry it too me so long to review this! For CXXStdInitializerListExpr
this looks great. However, I don't think we want ObjCBoxedExprs to escape their
arguments. It looks to me like these expressions copy their argument values and
don't hold on to them.
=
Lekensteyn added a comment.
Any objection for merging these patches? I rebased today (no changes needed)
and it still passes clang-tests.
https://reviews.llvm.org/D37954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Author: faisalv
Date: Thu Sep 28 19:17:31 2017
New Revision: 314483
URL: http://llvm.org/viewvc/llvm-project?rev=314483&view=rev
Log:
[NFC] Rename variable 'Arguments' to 'Parameters' when lexing the Macro
Definition.
Modified:
cfe/trunk/lib/Lex/PPDirectives.cpp
Modified: cfe/trunk/lib/Lex/
Author: faisalv
Date: Thu Sep 28 19:43:22 2017
New Revision: 314484
URL: http://llvm.org/viewvc/llvm-project?rev=314484&view=rev
Log:
[NFC] Replace 'arguments' with 'parameters' in comments relating to lexing a
macro definition.
Modified:
cfe/trunk/lib/Lex/PPDirectives.cpp
Modified: cfe/tru
compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
Comment at: bindings/python/clang/cindex.py:320
+return self._get_spelling()['offset']
def __eq__(self, other):
frutiger wrote:
> comp
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
I really wish that there was a way to handle this in the build system instead.
https://reviews.llvm.org/D38381
___
cfe-commits mailing list
c
compnerd added a comment.
With an explanation of the `gcc_s` vs `gcc`, I think this LG.
Comment at: cmake/config-ix.cmake:38
+else ()
+ set(MINGW_RUNTIME gcc_s gcc)
+endif()
This seems really weird. `gcc_s` and `gcc` are the same library, the form
compnerd added a comment.
Ugh, I was mixing up `_Unwind_SjLj_Register` with this function.
Comment at: src/Unwind-sjlj.c:468
+#ifndef __APPLE__
+__thread struct _Unwind_FunctionContext *stack = NULL;
I would prefer:
#if !defined(__APPLE__)
mstorsjo added inline comments.
Comment at: src/Unwind-sjlj.c:468
+#ifndef __APPLE__
+__thread struct _Unwind_FunctionContext *stack = NULL;
compnerd wrote:
> I would prefer:
>
> #if !defined(__APPLE__)
Sure, I can change that.
Comment a
mstorsjo updated this revision to Diff 117089.
mstorsjo edited the summary of this revision.
mstorsjo added a comment.
Made the tls variable static, changed ifndef into !defined().
https://reviews.llvm.org/D38250
Files:
src/Unwind-sjlj.c
Index: src/Unwind-sjlj.c
mstorsjo added inline comments.
Comment at: cmake/config-ix.cmake:38
+else ()
+ set(MINGW_RUNTIME gcc_s gcc)
+endif()
compnerd wrote:
> This seems really weird. `gcc_s` and `gcc` are the same library, the former
> is the shared version of the latte
Author: mstorsjo
Date: Thu Sep 28 23:09:09 2017
New Revision: 314492
URL: http://llvm.org/viewvc/llvm-project?rev=314492&view=rev
Log:
Skip building x86 parts of UnwindRegisters*.S when targeting SjLj
This extends SVN r314197 from the arm parts to the whole file.
Differential Revision: https://r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314492: Skip building x86 parts of UnwindRegisters*.S when
targeting SjLj (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D38381?vs=117047&id=117092#toc
Repository:
rL LLVM
95 matches
Mail list logo
