NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs, baloghadamsoftware.
Herald added subscribers: cfe-commits, Szelethus, jfb, mikhail.ramalho.
A test introduced in https://reviews.llvm.org/rC329780 was disabled in
phosek created this revision.
phosek added reviewers: mcgrathr, jakehehrlich.
Herald added subscribers: cfe-commits, mgorny.
This ensures that whether the user uses short or cannonical version
of the triple, Clang will still find the runtimes under the cannonical
triple name.
Repository:
rC
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342316: [analyzer] Further printing improvements: use
declarations, (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
Author: george.karpenkov
Date: Fri Sep 14 19:35:06 2018
New Revision: 342317
URL: http://llvm.org/viewvc/llvm-project?rev=342317=rev
Log:
[analyzer] Temporary disabling svalbuilder-rearrange-comparisons test
As debug printing has changed, and format was not guaranteed to be
stable.
Artem is
Author: george.karpenkov
Date: Fri Sep 14 19:34:45 2018
New Revision: 342316
URL: http://llvm.org/viewvc/llvm-project?rev=342316=rev
Log:
[analyzer] Further printing improvements: use declarations,
skip pointers whenever redundant, use unique prefixes.
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342315: Generate unique identifiers for Decl objects
(authored by george.karpenkov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52113?vs=165564=165631#toc
Repository:
rC Clang
Author: george.karpenkov
Date: Fri Sep 14 19:03:58 2018
New Revision: 342315
URL: http://llvm.org/viewvc/llvm-project?rev=342315=rev
Log:
Generate unique identifiers for Decl objects
The generated identifier is stable across multiple runs,
and can be a great visualization or debugging aide.
Author: george.karpenkov
Date: Fri Sep 14 19:03:36 2018
New Revision: 342314
URL: http://llvm.org/viewvc/llvm-project?rev=342314=rev
Log:
[analyzer] Generate and use stable identifiers for LocationContext
Those are not created in the allocator.
Since they are created fairly rarely, a counter
Author: george.karpenkov
Date: Fri Sep 14 19:03:17 2018
New Revision: 342313
URL: http://llvm.org/viewvc/llvm-project?rev=342313=rev
Log:
[analyzer] Dump reproducible identifiers for statements in exploded graph in
store
Differential Revision: https://reviews.llvm.org/D51826
Modified:
Author: george.karpenkov
Date: Fri Sep 14 19:02:56 2018
New Revision: 342312
URL: http://llvm.org/viewvc/llvm-project?rev=342312=rev
Log:
[analyzer] Use correct end-of-line character when printing statements for
exploded graph
Prevents bad centering.
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342311: StmtPrinter: allow customizing the end-of-line
character (authored by george.karpenkov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: george.karpenkov
Date: Fri Sep 14 19:02:31 2018
New Revision: 342311
URL: http://llvm.org/viewvc/llvm-project?rev=342311=rev
Log:
StmtPrinter: allow customizing the end-of-line character
Differential Revision: https://reviews.llvm.org/D51824
Modified:
Author: george.karpenkov
Date: Fri Sep 14 19:01:47 2018
New Revision: 342309
URL: http://llvm.org/viewvc/llvm-project?rev=342309=rev
Log:
Support generating unique identifiers for Stmt objects
The generated identifiers are stable across multiple runs, and can be a
great debug or visualization
Author: george.karpenkov
Date: Fri Sep 14 19:02:09 2018
New Revision: 342310
URL: http://llvm.org/viewvc/llvm-project?rev=342310=rev
Log:
[analyzer] Dump unique identifiers for statements in exploded graph
Differential Revision: https://reviews.llvm.org/D51823
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342309: Support generating unique identifiers for Stmt
objects (authored by george.karpenkov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51822?vs=164547=165625#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342308: [analyzer] Skip printing duplicate nodes, even if
nodes have multiple… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
Author: george.karpenkov
Date: Fri Sep 14 19:01:26 2018
New Revision: 342308
URL: http://llvm.org/viewvc/llvm-project?rev=342308=rev
Log:
[analyzer] Skip printing duplicate nodes, even if nodes have multiple
predecessors/successors
Still generate a node, but leave the redundant field empty.
Author: rsmith
Date: Fri Sep 14 18:59:39 2018
New Revision: 342307
URL: http://llvm.org/viewvc/llvm-project?rev=342307=rev
Log:
[modules] Don't bother creating a global module fragment when building a
header module.
Modified:
cfe/trunk/lib/Sema/Sema.cpp
Modified: cfe/trunk/lib/Sema/Sema.cpp
malaperle added a comment.
why?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Fri Sep 14 18:21:16 2018
New Revision: 342305
URL: http://llvm.org/viewvc/llvm-project?rev=342305=rev
Log:
[modules] Driver support for precompiling a collection of files as a single
action.
Added:
cfe/trunk/test/Driver/header-module.cpp
Modified:
Author: rsmith
Date: Fri Sep 14 18:21:18 2018
New Revision: 342306
URL: http://llvm.org/viewvc/llvm-project?rev=342306=rev
Log:
[modules] Support use of -E on modules built from the command line.
Modified:
cfe/trunk/lib/Frontend/FrontendAction.cpp
Author: rsmith
Date: Fri Sep 14 18:21:15 2018
New Revision: 342304
URL: http://llvm.org/viewvc/llvm-project?rev=342304=rev
Log:
[modules] Frontend support for building a header module from a list of
headaer files.
Added:
cfe/trunk/test/Modules/Inputs/no-module-map/
rsmith added a comment.
Looks good other than the warning, which I don't yet understand.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:4683-4686
+ "Member '%0' marked with 'exclude_from_explicit_instantiation' attribute is "
+ "not defined but an explicit
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
We're getting pretty good at it ^^
https://reviews.llvm.org/D52113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rsmith accepted this revision.
rsmith added inline comments.
Comment at: clang/lib/Frontend/DependencyFile.cpp:340
+return;
+ StringRef Filename = File->getName();
+ if (!FileMatchesDepCriteria(Filename.data(), FileType))
vsapsai wrote:
> rsmith wrote:
> >
vsapsai added inline comments.
Comment at: clang/lib/Frontend/DependencyFile.cpp:300-304
StringRef Filename = FE->getName();
if (!FileMatchesDepCriteria(Filename.data(), FileType))
return;
AddFilename(llvm::sys::path::remove_leading_dotslash(Filename));
rsmith added inline comments.
Comment at: docs/Modules.rst:476-477
+
+*platform-environment*
+ A platform-environment variant (e.g. ``linux-gnueabi``, ``windows-msvc``) is
available.
What is the reason to allow these to be combined into a single feature name
aprantl added inline comments.
Comment at: lib/Basic/Module.cpp:101
+ // variant (2), the simulator is hardcoded as part of the platform name. Both
+ // forms above should match "iossimulator" and "ios-simulator" features.
+ if (Target.getTriple().isOSDarwin() &&
rsmith added inline comments.
Comment at: clang/lib/Frontend/DependencyFile.cpp:340
+return;
+ StringRef Filename = File->getName();
+ if (!FileMatchesDepCriteria(Filename.data(), FileType))
Should we really be using the (arbitrary) name of the file from
aprantl added inline comments.
Comment at: docs/Modules.rst:470
+*platform variant*
+ A specific os/platform variant (e.g. ``ios``, ``macos``, ``android``,
``win32``, ``linux``, etc) is available.
aprantl wrote:
> Does this work with platforms+environment
rsmith added inline comments.
Comment at: lib/Frontend/DependencyFile.cpp:325
+void DFGImpl::HasInclude(SourceLocation Loc, const FileEntry *File) {
+ if (!File)
+return;
vsapsai wrote:
> rsmith wrote:
> > Have you thought about whether we should add a
bruno updated this revision to Diff 165612.
bruno added a comment.
Addressed Adrian's review. Added support to consider the environment and well
the combination platform-environment. @aprantl also handled multiple variants
of simulator combinations.
https://reviews.llvm.org/D51910
Files:
vsapsai marked 2 inline comments as done.
vsapsai added inline comments.
Comment at: lib/Frontend/DependencyFile.cpp:325
+void DFGImpl::HasInclude(SourceLocation Loc, const FileEntry *File) {
+ if (!File)
+return;
rsmith wrote:
> Have you thought about
vsapsai marked 3 inline comments as done.
vsapsai added inline comments.
Comment at: include/clang/Lex/PPCallbacks.h:263
+ /// \brief Callback invoked when a has_include directive is read.
+ virtual void HasInclude(SourceLocation Loc, const FileEntry *File) {
+ }
rsmith added inline comments.
Comment at:
clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:551
if (Decl->isMain() || !Decl->isUserProvided() ||
-Decl->isUsualDeallocationFunction() ||
-Decl->isCopyAssignmentOperator() ||
vsapsai updated this revision to Diff 165610.
vsapsai added a comment.
- Improve tests, fix -MMD, address comments.
https://reviews.llvm.org/D30882
Files:
clang/include/clang/Lex/PPCallbacks.h
clang/lib/Frontend/DependencyFile.cpp
clang/lib/Lex/PPMacroExpansion.cpp
vsapsai commandeered this revision.
vsapsai added a reviewer: pete.
vsapsai added a comment.
Taking over the change, I'll address the reviewers' comments.
https://reviews.llvm.org/D30882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
This is definitely the right thing to do, thanks for finding it!
I've got a long comment about how everything used to be simpler in the good old
days :-) I'm itching to refactor a bit,
devnexen updated this revision to Diff 165604.
https://reviews.llvm.org/D49722
Files:
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
test/Analysis/cstring-syntax.c
Index: test/Analysis/cstring-syntax.c
===
---
MaskRay added inline comments.
Comment at: test/Analysis/cstring-syntax.c:49
+ strlcat(dest, "0123456789", badlen / 2);
+ strlcat(dest, "0123456789", badlen); // expected-warning {{The third
argument allows to potentially copy more bytes than it should. Replace with the
Author: maskray
Date: Fri Sep 14 14:36:35 2018
New Revision: 342290
URL: http://llvm.org/viewvc/llvm-project?rev=342290=rev
Log:
test/Driver/output-file-cleanup.c: delete non-readable temporary file
%t-dir/2.c made tools (rsync, ripgrep, ...) sad (EACCES warning).
Modified:
sammccall added a comment.
Addressed the comments I was sure about.
A couple of open questions in SemaCodeComplete about the formatting of the
completions, but want to know what you think.
Comment at: lib/Sema/SemaCodeComplete.cpp:8046
+ !EC && It !=
sammccall updated this revision to Diff 165593.
sammccall marked 9 inline comments as done.
sammccall added a comment.
Unify common completion code from angled/quoted strings in Lexer.
Handle #include paths with \ on windows (normalize them to /)
Document why we picked particular extensions for
Oh, I see. Thank you very much for fixing it!
I had concerns about platform dependence, but I’ve seen seen some tests in
libcxx which use `if […]` so I thought it should be alright (because there was
no REQUIRES there). I can see now, that it is a Darwin test, my bad.
Again, thank you very
vlad.tsyrklevich added a comment.
In https://reviews.llvm.org/D51905#1234308, @zhaomo wrote:
> In https://reviews.llvm.org/D51905#1231383, @vlad.tsyrklevich wrote:
>
> > This change causes all compiler-rt cfi tests to be UNSUPPORTED for me
> > locally, do you have any idea why that might be?
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
Thank you for working on this!
In https://reviews.llvm.org/D52120#1235480, @lebedev.ri wrote:
> In https://reviews.llvm.org/D52120#1235479, @shuaiwang wrote:
>
> > @lebedev.ri could
devnexen added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:199
+if (Append)
+ RemainingBufferLen -= 1;
+if (RemainingBufferLen < ILRawVal)
MaskRay wrote:
> `RemainingBufferLen` is `uint64_t`. Can the
That construct does not work on Windows, where we don't use bash. We use
the lit internal shell, which doesn't support 'if [ ...]'. I marked it
REQUIRES: shell in r342282.
On Wed, Sep 12, 2018 at 2:29 AM Kirill Bobyrev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: omtcyfz
>
Author: rnk
Date: Fri Sep 14 13:51:07 2018
New Revision: 342282
URL: http://llvm.org/viewvc/llvm-project?rev=342282=rev
Log:
Mark index-tools.test as REQUIRES: shell so that it does not run with the
internal lit shell which does not support "if"
Modified:
Author: rnk
Date: Fri Sep 14 13:50:39 2018
New Revision: 342281
URL: http://llvm.org/viewvc/llvm-project?rev=342281=rev
Log:
Relax assumption about default method calling convention in new test
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-lambda.cpp
Modified:
MaskRay added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:164
+ // - sizeof(dst)
+ if (Append && isSizeof(LenArg, DstArg))
+return true;
george.karpenkov wrote:
> george.karpenkov wrote:
> > george.karpenkov wrote:
> >
tks2103 added a comment.
ping @GorNishanov
Repository:
rC Clang
https://reviews.llvm.org/D51741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added a comment.
In https://reviews.llvm.org/D52120#1235479, @shuaiwang wrote:
> @lebedev.ri could you help test whether this fully resolves PR38891? Thanks!
That is what i'm trying to do here :)
Still waiting for the build to finish...
Repository:
rC Clang
shuaiwang added a comment.
@lebedev.ri could you help test whether this fully resolves PR38891? Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D52120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
shuaiwang created this revision.
shuaiwang added reviewers: lebedev.ri, JonasToth.
Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, a.sidorin,
szepet, xazax.hun.
Herald added a reviewer: george.karpenkov.
This is a follow up of https://reviews.llvm.org/D52008 and should make
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342271: [analyzer] Handle forwarding reference better in
ExprMutationAnalyzer. (authored by shuaiwang, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
Author: shuaiwang
Date: Fri Sep 14 13:07:18 2018
New Revision: 342271
URL: http://llvm.org/viewvc/llvm-project?rev=342271=rev
Log:
[analyzer] Handle forwarding reference better in ExprMutationAnalyzer.
Summary:
We used to treat an `Expr` mutated whenever it's passed as non-const
reference
Meinersbur created this revision.
Meinersbur added reviewers: hfinkel, jdoerfert.
getLoopID has different control flow for two cases: If there is a single loop
latch and for any other number of loop latches (0 and more than one). The
latter case should return the same result if there is a
Author: jonastoth
Date: Fri Sep 14 12:42:37 2018
New Revision: 342267
URL: http://llvm.org/viewvc/llvm-project?rev=342267=rev
Log:
[NFC][clangd] silence pedantic extra ';' warning
Modified:
clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp
Modified:
ldionne updated this revision to Diff 165569.
ldionne added a comment.
Change no_extern_template to exclude_from_explicit_instantiation
Repository:
rC Clang
https://reviews.llvm.org/D51789
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/AttrDocs.td
JonasToth updated this revision to Diff 165568.
JonasToth added a comment.
- fix actually use clang-analyses correctly
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45444
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
JonasToth accepted this revision.
JonasToth added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:381
+FunctionParmMutationAnalyzer::findMutation(const ParmVarDecl *Parm) {
+ const auto Memoized =
Hello everyone,
LLVM buildmaster will be updated and restarted after 6PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth added a comment.
Soonish it might be able to do so ;)
Am 14.09.2018 um 17:13 schrieb Dávid Bolvanský via Phabricator:
> xbolva00 added a comment.
>
> Yeah, it would be super useful if Clang can add const to all places where
> possible :) love this work, great!
>
> Repository:
>
>
Meinersbur created this revision.
Meinersbur added reviewers: hfinkel, amusman, ABataev, tyler.nowicki.
Meinersbur added a dependency: D52116: Introduce llvm.loop.parallel_accesses
and llvm.access.group metadata..
Instead of generating llvm.mem.parallel_loop_access metadata, generate
george.karpenkov created this revision.
george.karpenkov added reviewers: NoQ, rsmith, aprantl.
https://reviews.llvm.org/D52113
Files:
clang/include/clang/AST/DeclBase.h
clang/lib/AST/DeclBase.cpp
Index: clang/lib/AST/DeclBase.cpp
Author: sammccall
Date: Fri Sep 14 11:49:16 2018
New Revision: 342261
URL: http://llvm.org/viewvc/llvm-project?rev=342261=rev
Log:
[clangd] Work around compiler macro expansion bugs(?) in completion tests
Modified:
clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp
Modified:
shuaiwang added a comment.
In https://reviews.llvm.org/D52008#1234828, @JonasToth wrote:
> The `std::move` as cast is a follow up patch?
Yes I'll send a follow up patch.
Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:381
+FunctionParmMutationAnalyzer::findMutation(const
shuaiwang updated this revision to Diff 165552.
shuaiwang marked 8 inline comments as done.
shuaiwang added a comment.
Addressed review comments.
Repository:
rC Clang
https://reviews.llvm.org/D52008
Files:
include/clang/Analysis/Analyses/ExprMutationAnalyzer.h
Author: d0k
Date: Fri Sep 14 11:05:30 2018
New Revision: 342252
URL: http://llvm.org/viewvc/llvm-project?rev=342252=rev
Log:
[modernize-use-transparent-functors] TypeLocs can be implicitly created, don't
crash when encountering those.
Modified:
ldionne added a comment.
In https://reviews.llvm.org/D51789#1235113, @rsmith wrote:
> In https://reviews.llvm.org/D51789#1235100, @ldionne wrote:
>
> > In https://reviews.llvm.org/D51789#1235096, @rsmith wrote:
> >
> > > OK, so the semantics of this attribute are "explicit instantiation
> > >
yaxunl added a comment.
In https://reviews.llvm.org/D43783#1235090, @Anastasia wrote:
> Ping! Do you still plan to do this? :)
Sorry I caught up in something else. Since there are some subsequent commits,
it may take some efforts to revert it.
Repository:
rC Clang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342246: Remove PseudoConstantAnalysis (authored by
shuaiwang, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51946
Files:
Author: shuaiwang
Date: Fri Sep 14 10:27:27 2018
New Revision: 342246
URL: http://llvm.org/viewvc/llvm-project?rev=342246=rev
Log:
Remove PseudoConstantAnalysis
Summary: It's not used anywhere for years. The last usage is removed in
https://reviews.llvm.org/rL198476 in 2014.
Subscribers:
george.karpenkov added a comment.
This looks very useful!
Repository:
rC Clang
https://reviews.llvm.org/D52008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
Great, thanks! Seems that your code is a better version of this check.
Repository:
rC Clang
https://reviews.llvm.org/D51946
rsmith added a comment.
In https://reviews.llvm.org/D51789#1235100, @ldionne wrote:
> In https://reviews.llvm.org/D51789#1235096, @rsmith wrote:
>
> > OK, so the semantics of this attribute are "explicit instantiation
> > declarations or definitions applied to the enclosing class do not apply
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
Thanks!
A substitution would probably need to be defined in a different file though.
https://reviews.llvm.org/D52036
___
ldionne added a comment.
In https://reviews.llvm.org/D51789#1235096, @rsmith wrote:
> In https://reviews.llvm.org/D51789#1234903, @ldionne wrote:
>
> > I think now's a good time to bikeshed the name of the attribute if you have
> > other suggestions.
>
>
> OK, so the semantics of this attribute
rsmith added a comment.
In https://reviews.llvm.org/D51789#1234903, @ldionne wrote:
> I think now's a good time to bikeshed the name of the attribute if you have
> other suggestions.
OK, so the semantics of this attribute are "explicit instantiation declarations
or definitions applied to the
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D51411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Anastasia added a comment.
Ping! Do you still plan to do this? :)
Repository:
rC Clang
https://reviews.llvm.org/D43783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ormris added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3126
+ } else {
+templateParameters = nullptr;//llvm::DINodeArray().get();
+ }
JDevlieghere wrote:
> What's the meaning of this comment?
Hmm... That should be removed.
ioeric added a comment.
In https://reviews.llvm.org/D52078#1234667, @ilya-biryukov wrote:
> ~1% increase in memory usage seems totally fine. Actually surprised it's that
> small.
Tested on a larger file: it's ~5% for `ClangdServer.cpp`. I think it's still
worth it for the speedup.
ioeric updated this revision to Diff 165517.
ioeric added a comment.
- Move macro collection to indexTopLevelDecls.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52078
Files:
clangd/ClangdServer.cpp
clangd/FindSymbols.cpp
clangd/XRefs.cpp
clangd/index/FileIndex.cpp
Author: hans
Date: Fri Sep 14 08:18:30 2018
New Revision: 342240
URL: http://llvm.org/viewvc/llvm-project?rev=342240=rev
Log:
[clang-cl] Fix PR38934: failing to dllexport class template member w/ explicit
instantiation and PCH
The code in ASTContext::DeclMustBeEmitted was supposed to handle
ioeric updated this revision to Diff 165516.
ioeric added a comment.
- another cleanup...
Repository:
rC Clang
https://reviews.llvm.org/D52098
Files:
include/clang/Index/IndexingAction.h
lib/Index/IndexingAction.cpp
unittests/CMakeLists.txt
unittests/Index/CMakeLists.txt
xbolva00 added a comment.
Yeah, it would be super useful if Clang can add const to all places where
possible :) love this work, great!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45444
___
cfe-commits mailing list
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D52097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ioeric updated this revision to Diff 165514.
ioeric added a comment.
- remove debug message.
Repository:
rC Clang
https://reviews.llvm.org/D52098
Files:
include/clang/Index/IndexingAction.h
lib/Index/IndexingAction.cpp
unittests/CMakeLists.txt
unittests/Index/CMakeLists.txt
ioeric created this revision.
ioeric added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, mgorny.
Also added unit tests for the index library; lit+c-index-test is painful...
Repository:
rC Clang
https://reviews.llvm.org/D52098
Files:
include/clang/Index/IndexingAction.h
patricklyster created this revision.
patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice,
kkwli0, hfinkel, gtbercea.
patricklyster added projects: OpenMP, clang.
Herald added subscribers: cfe-commits, jfb, guansong.
Move declarations for `OMPClauseReader`,
ldionne added a comment.
I think now's a good time to bikeshed the name of the attribute if you have
other suggestions.
Repository:
rC Clang
https://reviews.llvm.org/D51789
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ldionne updated this revision to Diff 165507.
ldionne added a comment.
Fix the tests and remove some warnings that I wasn't able to generate properly
(to avoid false positives).
Repository:
rC Clang
https://reviews.llvm.org/D51789
Files:
clang/include/clang/Basic/Attr.td
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342238: [clang] Make sure attributes on member classes are
applied properly (authored by ldionne, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51997?vs=165375=165502#toc
Author: ldionne
Date: Fri Sep 14 07:07:16 2018
New Revision: 342238
URL: http://llvm.org/viewvc/llvm-project?rev=342238=rev
Log:
[clang] Make sure attributes on member classes are applied properly
Summary:
Attributes on member classes of class templates and member class templates
of class
JonasToth updated this revision to Diff 165497.
JonasToth added a comment.
- update to ExprMutAnalyzer living in clang now
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45444
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
JonasToth marked 9 inline comments as done.
JonasToth added a comment.
I do consider the diagnostic thing as resolved given the lack of further
comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48714
___
cfe-commits mailing
JonasToth added a comment.
LG from my side, please rebase that patch on top of master. Currently the
Release Notes would conflict (and please sort the release note alphabetically).
If the other reviewers do not say anything within a reasonable time it can be
committed. Do you have commit
JonasToth added a comment.
And i forgot: Could you please run this over a real code base, if you know one
that actually uses these types?
I assume not so many code bases actually use these.
https://reviews.llvm.org/D51332
___
cfe-commits mailing
1 - 100 of 170 matches
Mail list logo
