[PATCH] D58397: [analyzer] MIGChecker: Pour more data into the checker.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Aah, MIG_NO_REPLY. LGTM. Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:42 + std::vector> Deallocators = { +#define CALL(required_args, deallocated_arg,

[PATCH] D58392: [analyzer] MIGChecker: Fix false negatives for releases in automatic destructors.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Oh, interesting. I'm glad you thought of this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58392/new/ https://reviews.llvm.org/D58392 __

r354435 - Limit new PM tests to X86 registered targets.

Author: leonardchan Date: Tue Feb 19 21:07:14 2019 New Revision: 354435 URL: http://llvm.org/viewvc/llvm-project?rev=354435&view=rev Log: Limit new PM tests to X86 registered targets. Modified: cfe/trunk/test/Driver/msan.c cfe/trunk/test/Driver/tsan.c Modified: cfe/trunk/test/Driver/msan

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Looks good to me. I have some a minor diagnostic wording suggestion in line. Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:109 +llvm::raw_svector_ost

[PATCH] D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈

stephanemoore marked 4 inline comments as done. stephanemoore added inline comments. Comment at: clang-tools-extra/test/clang-tidy/Inputs/Headers/stdio.h:1 +#ifndef _STDIO_H_ +#define _STDIO_H_ aaron.ballman wrote: > aaron.ballman wrote: > > stephanemoore wrote:

[PATCH] D58366: [analyzer] MIGChecker: Make use of the server routine annotation.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Analysis/mig.mm:2 +// RUN: %clang_analyze_cc1 -w -analyzer-checker=core,alpha.osx.MIG\ +// RUN:-fblocks -verify %s --

[PATCH] D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈

stephanemoore updated this revision to Diff 187512. stephanemoore added a comment. Added licensing preamble to stdio.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58095/new/ https://reviews.llvm.org/D58095 Files: clang-tools-extra/clang-tidy/g

r354432 - Remove test on incompatible mpis target.

Author: leonardchan Date: Tue Feb 19 20:35:28 2019 New Revision: 354432 URL: http://llvm.org/viewvc/llvm-project?rev=354432&view=rev Log: Remove test on incompatible mpis target. Modified: cfe/trunk/test/Driver/msan.c Modified: cfe/trunk/test/Driver/msan.c URL: http://llvm.org/viewvc/llvm-p

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. This looks good to me as long as Aaron is happy with it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58365/new/ https://reviews.llvm.org/D58365

[PATCH] D58424: [NewPM] Add other sanitizers at O0

This revision was automatically updated to reflect the committed changes. Closed by commit rL354431: [NewPM] Add other sanitizers at O0 (authored by leonardchan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

r354431 - [NewPM] Add other sanitizers at O0

Author: leonardchan Date: Tue Feb 19 19:50:11 2019 New Revision: 354431 URL: http://llvm.org/viewvc/llvm-project?rev=354431&view=rev Log: [NewPM] Add other sanitizers at O0 This allows for MSan and TSan to be used without optimizations required. Differential Revision: https://reviews.llvm.org/D5

[PATCH] D58397: [analyzer] MIGChecker: Pour more data into the checker.

NoQ updated this revision to Diff 187505. NoQ added a comment. Rebase. Fix behavior when the return code is not constrained enough. Test the C++11 attribute syntax (just in case). Update comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58397/new/ https://reviews.llvm.org/D58397

[PATCH] D58392: [analyzer] MIGChecker: Fix false negatives for releases in automatic destructors.

NoQ updated this revision to Diff 187503. NoQ added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58392/new/ https://reviews.llvm.org/D58392 Files: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp clang/test/Analysis/mig.mm Index: clang/test/Analysis/mig.mm ===

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

phosek added a comment. In D58375#1403144 , @efriedma wrote: > I can understand why tests that use -O1 or -O2 would produce different > results with the new pass manager, but it looks like not all the tests are > like that. Do you know why those tests a

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

NoQ updated this revision to Diff 187502. NoQ added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58368/new/ https://reviews.llvm.org/D58368 Files: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp clang/test/Analysis/mig.mm Index: clang/test/Analysis/mig.mm

[PATCH] D58366: [analyzer] MIGChecker: Make use of the server routine annotation.

NoQ updated this revision to Diff 187501. NoQ added a comment. Whoops - make sure that the Objective-C test does actually test something. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58366/new/ https://reviews.llvm.org/D58366 Files: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp

[PATCH] D58366: [analyzer] MIGChecker: Make use of the server routine annotation.

NoQ updated this revision to Diff 187498. NoQ added a comment. Rebase due to an update in D58365 - namely, add support for Objective-C messages and blocks that are now allowed to wear the attribute. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58366/n

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

NoQ added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1310 +def MIGServerRoutine : InheritableAttr { + let Spellings = [Clang<"mig_server_routine">]; aaron.ballman wrote: > Should this be limited to specific targets, or is this a general con

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

NoQ updated this revision to Diff 187497. NoQ marked 13 inline comments as done. NoQ added a comment. Fxd, thx! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58365/new/ https://reviews.llvm.org/D58365 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

phosek updated this revision to Diff 187493. Herald added a subscriber: mstorsjo. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58375/new/ https://reviews.llvm.org/D58375 Files: clang/test/CMakeLists.txt clang/test/CodeGen/aarch64-neon-across.c clang/test/Co

[PATCH] D58424: [NewPM] Add other sanitizers at O0

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58424/new/ https://reviews.llvm.org/D58424 _

[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

NoQ added a comment. I'll take a closer look in a few days, sorry for the delays! The progress you're making is fantastic and i really appreciate your work, but i have an urgent piece of work of my own to deal with this week. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53076/new/ ht

[PATCH] D58424: [NewPM] Add other sanitizers at O0

leonardchan created this revision. leonardchan added reviewers: chandlerc, philip.pfaffe, fedor.sergeev. leonardchan added a project: clang. This allows for MSan and TSan to be used without optimizations required. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58424 Files: c

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 added a comment. In D57497#1394137 , @efriedma wrote: > > Did you mean declare as a target feature in RISCV.td or I misunderstanding > > something? > > That's sort of the right idea, but I don't think it works in this context > because we aren'

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

chandlerc added a comment. In D58375#1403144 , @efriedma wrote: > I can understand why tests that use -O1 or -O2 would produce different > results with the new pass manager, but it looks like not all the tests are > like that. Do you know why those test

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. Based on the -dev discussion, update once the target machine differences are addressed by mimicing the way the legacy PM works, which will hopefully restrict this similarly to

[PATCH] D58204: CMake: Fix stand-alone clang builds since r353268

This revision was automatically updated to reflect the committed changes. Closed by commit rL354417: CMake: Fix stand-alone clang builds since r353268 (authored by tstellar, committed by ). Changed prior to commit: https://reviews.llvm.org/D58204?vs=186769&id=187473#toc Repository: rL LLVM

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous created this revision. jkorous added reviewers: arphaman, dexonsmith, akyrtzi, nathawes, yvvan. Herald added subscribers: cfe-commits, jdoerfert, jfb, mgorny. Herald added a project: clang. This patch contains implementation of DirectoryWatcher from github.com/apple/swift-clang We are st

r354417 - CMake: Fix stand-alone clang builds since r353268

Author: tstellar Date: Tue Feb 19 17:11:05 2019 New Revision: 354417 URL: http://llvm.org/viewvc/llvm-project?rev=354417&view=rev Log: CMake: Fix stand-alone clang builds since r353268 Summary: Handle the case where LLVM_MAIN_SRC_DIR is not set and also use LLVM_CMAKE_DIR for locating installed c

[PATCH] D58320: [Darwin] Introduce a new flag, -flink-builtins-rt that forces linking of the builtins library.

aemerson added a comment. In D58320#1402254 , @peter.smith wrote: > The implementation changes in the Darwin toolchain look fine to me, although > with respect to the command line option I think Petr Hosek's message on > cfe-dev is interesting: > > > GCC

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. > There is a revision to solve this problem here: D58065 > . I guess your input, as someone who didn't > participate in the checker dependency related patch reviews would be > invaluable, in terms of whether my description is understandab

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. Also I don't see the helptext for PointerSorting when I run: clang -cc1 -analyzer-checker-help | grep Pointer alpha.core.PointerArithmCheck for pointer arithmetic on locations other than array elements alpha.core.PointerSub Check for pointer

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. > It's because it invokes CodeChecker, which by default enables > valist.Uninitialized, but not ValistBase. Do you have assert failures after > my hotfix? @Szelethus Thanks. I run into this assert when run through CodeChecker: Assertion `CheckerTags.count(tag) != 0 &&

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang updated this revision to Diff 187466. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50488/new/ https://reviews.llvm.org/D50488 Files: docs/analyzer/checkers.rst include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/

[PATCH] D58065: [analyzer] Document the frontend library

mgrang added inline comments. Comment at: docs/analyzer/developer-docs/FrontendLibrary.rst:12 +This document will describe the frontend of the Static Analyzer, basically +everything from compiling the analyzer from source, through it's invocation up +to the beginning of the analy

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

efriedma added a comment. I can understand why tests that use -O1 or -O2 would produce different results with the new pass manager, but it looks like not all the tests are like that. Do you know why those tests are failing? For the tests that do use -O, instead of marking them unsupported, cou

[PATCH] D42593: GCC compatibility: Ignore -fstack-clash-protection

tstellar abandoned this revision. tstellar added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. I agree with Joerg, I don't think we should be ignoring these kinds of security flags (even though we already ignore -fstack-check). Repository: rC Clang CHANGES S

[PATCH] D54880: Ignore gcc's stack-clash-protection flag

tstellar added a comment. Herald added a project: clang. See D42593 , I don't think it's good to ignore security flags like this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54880/new/ https://reviews.llvm.org/D54880 ___

[PATCH] D58243: [OPENMP] Delay emission of the asm target-specific error messages.

kkwli0 added a comment. The change looks okay to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58243/new/ https://reviews.llvm.org/D58243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: djasper, klimek, krasimir, benhamilton, JonasToth. MyDeveloperDay added a project: clang. Herald added subscribers: jdoerfert, mgorny. This revision adds basic support for formatting C# files with clang-format, I know the barr

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

NoQ added a reviewer: Charusso. NoQ marked an inline comment as done. NoQ added a subscriber: Charusso. NoQ added a comment. In D58367#1402796 , @Szelethus wrote: > 2. I guess most of the visitors could be changed to this format, do you have > plans to co

[PATCH] D58243: [OPENMP] Delay emission of the asm target-specific error messages.

tra added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:256-263 // If we're compiling CUDA file and function attributes indicate that it's not // for this compilation side, skip all the checks. if (!DeclAttrsMatchCUDAMode(getLangOpts(), getCurFunctionDecl())) {

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

aaron.ballman added a comment. > @aaron.ballman, are you actually interested in reviewing these attributes? > 'Cause George added you on his reviews but i totally understand that these > are fairly exotic. Yeah, I'd like to review these attributes -- thanks for double-checking with me! =

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

Szelethus added a comment. In D50488#1402699 , @mgrang wrote: > In D50488#1400823 , @whisperity > wrote: > > > Yeah, it seems upstream has moved away due to @Szelethus' implementation of > > a much more manageable

[PATCH] D58243: [OPENMP] Delay emission of the asm target-specific error messages.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:256-263 // If we're compiling CUDA file and function attributes indicate that it's not // for this compilation side, skip all the checks. if (!DeclAttrsMatchCUD

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

Szelethus added a comment. I love the idea! It looks way cleaner, tbh how messy visitors are have kept me away from implementing one for my own checker. Couple thoughts: 1. It would be great to have unit tests for this. Side note, I have already managed to make CSA unit tests tun under check-cl

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. This is a series of patches, which I believe should merged altogether. Currently the following patches are relevant: - https://reviews.llvm.org/D49754 - https://reviews.llvm.org/D54409 - https://reviews.llvm.org/D54583 - https://reviews.llvm.org/D56703 The patches are i

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno marked an inline comment as done. riccibruno added a comment. Looks mostly fine to me. I have added a few inline comments but they are all little nits. Comment at: include/clang/Basic/Sanitizers.h:39 +struct SanitizerMask { +private: + // Number of array elements.

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

ashi1 added a comment. This was submitted again with the fix. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

zinovy.nis updated this revision to Diff 187421. zinovy.nis added a comment. - `-j` is `1` by default; - fixed minor remarks; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57662/new/ https://reviews.llvm.org/D57662 Files: clang-tidy/tool/clang-tidy-diff.py Index: clang-tidy/tool/cla

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4047-4048 +that have their return value of type ``kern_return_t`` unconditionally returned +from the routine. The attribute can be applied to C++ methods, and in thi

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. In D50488#1400823 , @whisperity wrote: > Yeah, it seems upstream has moved away due to @Szelethus' implementation of a > much more manageable "checker dependency" system. You most likely will have > to rebase your patch first, the

[PATCH] D58397: [analyzer] MIGChecker: Pour more data into the checker.

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, jdoerfert, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Previous patches were about the infrastructure of the chec

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang updated this revision to Diff 187418. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50488/new/ https://reviews.llvm.org/D50488 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/PointerSortingChecke

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

tra added a subscriber: rsmith. tra added a comment. In D56411#1400300 , @rjmccall wrote: > Okay, but it's not great design to have a kind of overloading that can't be > resolved to an exact intended declaration even by an explicit cast. That's > why I

[PATCH] D58392: [analyzer] MIGChecker: Fix false negatives for releases in automatic destructors.

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. The problem that was fixed in D25326

[PATCH] D58243: [OPENMP] Delay emission of the asm target-specific error messages.

tra added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:256-263 // If we're compiling CUDA file and function attributes indicate that it's not // for this compilation side, skip all the checks. if (!DeclAttrsMatchCUDAMode(getLangOpts(), getCurFunctionDecl())) {

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

I see. You're right the name sounds slow indeed. Thank you for the explanation! > On Feb 19, 2019, at 6:43 AM, Nico Weber wrote: > > I didn't realize it just copied a string. I just saw a call to > "fillRealPathName" and the "RealPath" bit sounded slow. From clicking around > in http://llvm-cs

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

nemanjai added a comment. There is a long series of comments in this patch and I am not clear at this point on whether this patch breaks anything or it is fine. Could you please `Request Changes` if this patch is broken or approve if it is fine? Repository: rC Clang CHANGES SINCE LAST ACTIO

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

jyknight added inline comments. Comment at: lib/Basic/Targets/RISCV.h:94 +if (HasA) + MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 32; + } MaxAtomicPromoteWidth is an incompatible ABI-change kind of thing. We should set that to the maximum atomic siz

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 187400. pgousseau added a comment. Updated to use an array as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 Files: include/clang/Basic/Attr.td include/clang/Basic/Sanitizers.def include/

[PATCH] D58388: [OpenCL] Simplify LLVM IR generated for OpenCL blocks

AlexeySotkin updated this revision to Diff 187399. AlexeySotkin added a comment. Fix ObjC lit tests failure CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58388/new/ https://reviews.llvm.org/D58388 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGOpenCLRuntime.cpp lib/CodeGen/CGOpenC

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 187393. tmroeder marked 6 inline comments as done. tmroeder added a comment. Thanks for the review and the suggestions for improving the tests. This update cleans up the tests as suggested. Repository: rC Clang CHANGES SINCE LAST ACTION https://review

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder added inline comments. Comment at: test/ASTMerge/choose-expr/Inputs/choose1.c:1 +#define abs_int(x) __builtin_choose_expr( \ +__builtin_types_compatible_p(__typeof(x), unsigned int), \ a_sidorin wrote: > This test duplicates unit

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, but see the comment about avoiding code duplication Comment at: lib/Index/IndexDecl.cpp:678 IndexCtx.indexTypeSourceInfo(TTP->getDefaultArgum

[PATCH] D58343: Enablement for AMD znver2 architecture - skeleton patch

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58343/new/ https://reviews.llvm.org/D58343 ___ cfe

[PATCH] D58343: Enablement for AMD znver2 architecture - skeleton patch

GGanesh updated this revision to Diff 187389. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58343/new/ https://reviews.llvm.org/D58343 Files: include/llvm/Support/X86TargetParser.def lib/Support/Host.cpp lib/Target/X86/X86.td test/CodeGen/X86/cpus-amd.ll

[PATCH] D58377: Remove extraneous space in MSVC-style diagnostic output

This revision was automatically updated to reflect the committed changes. Closed by commit rC354351: Remove extraneous space in MSVC-style diagnostic output (authored by hans, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D58377?vs=187320&id=18

[PATCH] D58343: Enablement for AMD znver2 architecture - skeleton patch

GGanesh updated this revision to Diff 187386. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58343/new/ https://reviews.llvm.org/D58343 Files: include/llvm/Support/X86TargetParser.def lib/Support/Host.cpp lib/Target/X86/X86.td test/CodeGen/X86/cpus-amd.ll

[PATCH] D58344: Enablement for AMD znver2 architecture - skeleton

GGanesh updated this revision to Diff 187387. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58344/new/ https://reviews.llvm.org/D58344 Files: include/clang/Basic/X86Target.def lib/Basic/Targets/X86.cpp test/CodeGen/target-builtin-noerror.c test/Driver/x86-

r354351 - Remove extraneous space in MSVC-style diagnostic output

Author: hans Date: Tue Feb 19 08:58:25 2019 New Revision: 354351 URL: http://llvm.org/viewvc/llvm-project?rev=354351&view=rev Log: Remove extraneous space in MSVC-style diagnostic output There was an extra space between the file location and the diagnostic message: /tmp/a.c(1,12): warning: un

[PATCH] D58387: [clangd] Add an option in the code to not display number of fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL354349: [clangd] Add an option in the code to not display number of fixes (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[clang-tools-extra] r354349 - [clangd] Add an option in the code to not display number of fixes

Author: ibiryukov Date: Tue Feb 19 08:50:37 2019 New Revision: 354349 URL: http://llvm.org/viewvc/llvm-project?rev=354349&view=rev Log: [clangd] Add an option in the code to not display number of fixes Summary: Only to the APIs, which are used by our embedders. We do not plan to add a user-facing

[PATCH] D58343: Enablement for AMD znver2 architecture - skeleton patch

craig.topper added a comment. I think you uploaded the clang patch into the llvm review? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58343/new/ https://reviews.llvm.org/D58343 ___ cfe-commits mailing list cfe-commi

[PATCH] D58388: [OpenCL] Simplify LLVM IR generated for OpenCL blocks

AlexeySotkin created this revision. AlexeySotkin added reviewers: Anastasia, yaxunl, svenvh. AlexeySotkin added a project: clang. Emit direct call of block invoke functions when possible, i.e. in case the block is not passed as a function argument. Also doing some refactoring of `CodeGenFunction::

[PATCH] D57660: [Sema] SequenceChecker: Handle references and members

riccibruno planned changes to this revision. riccibruno added a comment. This needs more work. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 ___ cfe-commits mailing list cfe

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/SemaCast.cpp:2309 +auto DestPointeeTypeWithoutAS = Self.Context.removeAddrSpaceQualType( +DestPointeeType.getCanonicalType()); +return Self.Context.hasSameType(SrcPoi

[PATCH] D58387: [clangd] Add an option in the code to not display number of fixes

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, ioeric. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Only to the APIs, which are used by our embedders. We do not plan to add a user-facing option for this. Repository

[PATCH] D58341: [clangd] Index UsingDecls

kadircet updated this revision to Diff 187376. kadircet marked an inline comment as done. kadircet added a comment. - Revert last change Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58341/new/ https://reviews.llvm.org/D58341 Files: unittests/cla

[PATCH] D58314: [Driver] Sync ARM behavior between clang-as and gas.

peter.smith added a comment. My main concern is that this changes the default behaviour for arm-linux-gnueabi and arm-linux-gnueabihf targets. I've put some suggestions on what I think the behaviour should be. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:277 + } + r

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

kadircet added inline comments. Comment at: lib/Index/IndexingContext.cpp:51 + bool IndexingContext::handleDecl(const Decl *D, SymbolRoleSet Roles, ilya-biryukov wrote: > kadircet wrote: > > ilya-biryukov wrote: > > > Do we call

[PATCH] D58294: [clangd] Enable indexing of template type parameters

kadircet updated this revision to Diff 187371. kadircet marked an inline comment as done. kadircet added a comment. - Option's name has changed Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58294/new/ https://reviews.llvm.org/D58294 Files: clangd

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

kadircet updated this revision to Diff 187370. kadircet marked 2 inline comments as done. kadircet added a comment. - Change options name - Also index decls Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58293/new/ https://reviews.llvm.org/D58293 Files: include

[PATCH] D58341: [clangd] Index UsingDecls

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM from my side, with a few NITs. But let's wait for an LGTM from Haojian too, to make sure his concerns are addressed. Comment at: unittests/clangd/SymbolCo

[PATCH] D58341: [clangd] Index UsingDecls

kadircet updated this revision to Diff 187367. kadircet added a comment. - Add tests for code completion Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58341/new/ https://reviews.llvm.org/D58341 Files: unittests/clangd/SymbolCollectorTests.cpp u

[PATCH] D58277: [OpenCL] Change type of block pointer for OpenCL

This revision was automatically updated to reflect the committed changes. Closed by commit rL354337: [OpenCL] Change type of block pointer for OpenCL (authored by bader, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

r354337 - [OpenCL] Change type of block pointer for OpenCL

Author: bader Date: Tue Feb 19 07:19:06 2019 New Revision: 354337 URL: http://llvm.org/viewvc/llvm-project?rev=354337&view=rev Log: [OpenCL] Change type of block pointer for OpenCL Summary: For some reason OpenCL blocks in LLVM IR are represented as function pointers. These pointers do not point

[PATCH] D57896: Variable names rule

zturner requested changes to this revision. zturner added a comment. This revision now requires changes to proceed. Since someone already accepted this, I suppose I should mark require changes to formalize my dissent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D57896: Variable names rule

zturner added a comment. In D57896#1402194 , @lattner wrote: > > Changed recommendation for acronyms from lower case to upper case, as > > suggested by several responses to the RFC. > > I haven't been following the discussion closely - why is this the pre

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

ilya-biryukov added inline comments. Comment at: include/clang/Index/IndexingAction.h:49 bool IndexParametersInDeclarations = false; + bool IndexTemplateParmDecls = false; }; NIT: maybe rename to `IndexTemplateParameters`? The `ParmDecl` is a somewhat weird

[PATCH] D58377: Remove extraneous space in MSVC-style diagnostic output

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. wht CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58377/new/ https://reviews.llvm.org/D58377 ___ cfe-commits mailing list cfe-commit

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

I didn't realize it just copied a string. I just saw a call to "fillRealPathName" and the "RealPath" bit sounded slow. From clicking around in http://llvm-cs.pcc.me.uk/tools/clang/lib/Basic/FileManager.cpp#361 it looks like it's not really computing a realpath (for symlinks). It still does quite a

[PATCH] D58320: [Darwin] Introduce a new flag, -flink-builtins-rt that forces linking of the builtins library.

peter.smith added a comment. The implementation changes in the Darwin toolchain look fine to me, although with respect to the command line option I think Petr Hosek's message on cfe-dev is interesting: > GCC implements -nolibc which could be used to achieve the same effect when > combined with

[PATCH] D58185: [clangd] Handle unresolved scope specifier when fixing includes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354330: [clangd] Handle unresolved scope specifier when fixing includes. (authored by ioeric, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[clang-tools-extra] r354330 - [clangd] Handle unresolved scope specifier when fixing includes.

Author: ioeric Date: Tue Feb 19 06:32:22 2019 New Revision: 354330 URL: http://llvm.org/viewvc/llvm-project?rev=354330&view=rev Log: [clangd] Handle unresolved scope specifier when fixing includes. Summary: In the following examples, "clangd" is unresolved, and the fixer will try to fix include f

[PATCH] D58185: [clangd] Handle unresolved scope specifier when fixing includes.

ioeric updated this revision to Diff 187359. ioeric added a comment. - minor cleanup Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58185/new/ https://reviews.llvm.org/D58185 Files: clangd/IncludeFixer.cpp unittests/clangd/DiagnosticsTests.cpp

[PATCH] D57896: Variable names rule

michaelplatings added a comment. In D57896#1402194 , @lattner wrote: > > Changed recommendation for acronyms from lower case to upper case, as > > suggested by several responses to the RFC. > > I haven't been following the discussion closely - why is this

[PATCH] D58306: [AArch64] Change size suffix for FP16FML intrinsics.

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. LGTM The ACLE has been updated and a new version with change included will be released soon. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58306/n

[PATCH] D57896: Variable names rule

lattner added a comment. > Changed recommendation for acronyms from lower case to upper case, as > suggested by several responses to the RFC. I haven't been following the discussion closely - why is this the preferred direction? I don't think that things like "Basicblock *bb" or "MachineInstr

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:823 + (*H)->contents.value = + llvm::formatv("```C++\n{0}\n```", (*H)->contents.value); +} The contents of the hover is not strictly C++ code, so

  1   2   >