[PATCH] D78443: [Local] Update getOrEnforceKnownAlignment/getKnownAlignment to use Align/MaybeAlign.

This revision was automatically updated to reflect the committed changes. Closed by commit rG68b2e507e4fd: [Local] Update getOrEnforceKnownAlignment/getKnownAlignment to use… (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

zhuhan0 created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78534 Files: clang/cmake/modules/AddClang.cmake Index: clang/cmake/modules/AddClang.cmake

[clang] 68b2e50 - [Local] Update getOrEnforceKnownAlignment/getKnownAlignment to use Align/MaybeAlign.

Author: Craig Topper Date: 2020-04-20T21:31:44-07:00 New Revision: 68b2e507e4fdf2776e568e95d27ce1ff54097476 URL: https://github.com/llvm/llvm-project/commit/68b2e507e4fdf2776e568e95d27ce1ff54097476 DIFF: https://github.com/llvm/llvm-project/commit/68b2e507e4fdf2776e568e95d27ce1ff54097476.diff

[clang] 4b03dd7 - PR45534: don't ignore unmodeled side-effects when constant-evaluating a call to __builtin_constant_p.

Author: Richard Smith Date: 2020-04-20T21:23:35-07:00 New Revision: 4b03dd7b849e8f5068dc8d72c6eab724c22a2805 URL: https://github.com/llvm/llvm-project/commit/4b03dd7b849e8f5068dc8d72c6eab724c22a2805 DIFF: https://github.com/llvm/llvm-project/commit/4b03dd7b849e8f5068dc8d72c6eab724c22a2805.diff

[clang] e128f71 - PR45535: Check for variables with non-trivial destruction when

Author: Richard Smith Date: 2020-04-20T21:23:35-07:00 New Revision: e128f710ea871bab5ed14b1944caa935ed61b003 URL: https://github.com/llvm/llvm-project/commit/e128f710ea871bab5ed14b1944caa935ed61b003 DIFF: https://github.com/llvm/llvm-project/commit/e128f710ea871bab5ed14b1944caa935ed61b003.diff

[PATCH] D78443: [Local] Update getOrEnforceKnownAlignment/getKnownAlignment to use Align/MaybeAlign.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78443/new/ https://reviews.llvm.org/D78443

[PATCH] D78443: [Local] Update getOrEnforceKnownAlignment/getKnownAlignment to use Align/MaybeAlign.

craig.topper updated this revision to Diff 258876. craig.topper added a comment. Use getAsAlign Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78443/new/ https://reviews.llvm.org/D78443 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv updated this revision to Diff 258865. ilinpv added a comment. Patterns corrected, vector_extract tests added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78252/new/ https://reviews.llvm.org/D78252 Files:

[PATCH] D77168: Add a flag to debug automatic variable initialization

phosek added a comment. We've rolled out `-ftrivial-auto-var-init=pattern` to all of Fuchsia several months ago. In my experience, having the `pragma` would have been really valuable during the rollout stage when we've often commented out portion of code while narrowing down the issue, which

[PATCH] D78443: [Local] Update getOrEnforceKnownAlignment/getKnownAlignment to use Align/MaybeAlign.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4181 +llvm::getOrEnforceKnownAlignment(V, + llvm::Align(Align.getQuantity()), + *TD) <

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev marked 5 inline comments as done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:14 +#include "Index.grpc.pb.h" #include "SourceCode.h" sammccall wrote: > this include and the stuff depending on it needs

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

arichardson marked an inline comment as done. arichardson added a comment. In D78491#1992618 , @aykevl wrote: > I can't give an LGTM but at least from my perspective I very much welcome > this change. I am still hitting problems with non-zero address

[PATCH] D78521: [clangd] Extend dexp to support remote index

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:14 +#include "Index.grpc.pb.h" #include "SourceCode.h" this include and the stuff depending on it needs to be ifdef'd Comment at:

[PATCH] D78443: [Local] Update getOrEnforceKnownAlignment/getKnownAlignment to use Align/MaybeAlign.

craig.topper updated this revision to Diff 258859. craig.topper added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix for clang usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78443/new/

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 258861. kbobyrev added a comment. Fix build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

dblaikie added a comment. In D76801#1991904 , @labath wrote: > David's example does work with gdb without -Wl,--gdb-index (the member > variable is shown), presumably due to the aforementioned fuzzy matching. > However, it does not work if gdb-index is

[PATCH] D68049: Propeller: Clang options for basic block sections

rsmith added a comment. Please add documentation for the new flags. Comment at: clang/include/clang/Driver/Options.td:1974 def fno_function_sections : Flag<["-"], "fno-function-sections">, Group; +def fbasicblock_sections_EQ : Joined<["-"], "fbasicblock-sections=">, Group,

[PATCH] D78495: [nfc] Accept addrspacecast allocas in InitTempAlloca

JonChesterfield abandoned this revision. JonChesterfield added a comment. No problem. This isn't on the live path - the function is mostly called from openmp codegen and clang doesn't target openmp/amdgcn just yet. I'll roll this change into the codegen patch to enable that. Repository: rG

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. - Make it possible for dexp to use remote server - Remove clangd-index-client (since

[PATCH] D77392: [WIP][clangd] Make signatureHelp work with stale preambles

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Keep missing the "ship it" button... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77392/new/ https://reviews.llvm.org/D77392

[PATCH] D77392: [WIP][clangd] Make signatureHelp work with stale preambles

sammccall marked an inline comment as done. sammccall added a comment. Great stuff! Comment at: clang-tools-extra/clangd/Preamble.cpp:281 + // We are only interested in newly added includes. + llvm::StringSet<> ExistingIncludes; + for (const auto : Preamble.LexedIncludes)

[PATCH] D78513: [hip] Claim builtin type `__float128` supported if the host target supports it.

hliao added a comment. In D78513#1993115 , @yaxunl wrote: > Currently if instructions of float128 get to amdgpu backend, are we going to > crash? As `Float128Format` is re-defined as `double`, there won't be any issue in the backend. But, it won't

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

arichardson added a comment. I don't like the fact that this only changes one of the users of `getTriple().getOSMajorVersion()`. Could you add a new member function such as void FreeBSD::getMajorVersion() const { unsigned Major = getTriple().getOSMajorVersion(); if (Major == 0)

[PATCH] D67052: Add reference type transformation builtins

zoecarver updated this revision to Diff 258834. zoecarver marked 2 inline comments as done. zoecarver added a comment. - Rebase - Fix based on review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67052/new/ https://reviews.llvm.org/D67052

[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

kadircet added a comment. In D77456#1991484 , @sammccall wrote: > No, I'm complaining about the space before the period in > > Tests primality of `p` . > > > and the plaintext rendering too > > Tests primality of p . > Ah I see, yes this looks

[PATCH] D67052: Add reference type transformation builtins

zoecarver updated this revision to Diff 258836. zoecarver added a comment. - Format using clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67052/new/ https://reviews.llvm.org/D67052 Files: clang/include/clang/AST/Type.h

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77954/new/ https://reviews.llvm.org/D77954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77392: [WIP][clangd] Make signatureHelp work with stale preambles

kadircet updated this revision to Diff 258833. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments - Don't store LexedInclude in PreambleData, expose the contents in PrecompiledPreamble instead. - Introduce DenseMapInfo for PPKeywordKind Repository: rG

[PATCH] D77392: [WIP][clangd] Make signatureHelp work with stale preambles

kadircet marked 15 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:278 + // This shouldn't coincide with any real file name. + PP.PatchFileName = llvm::formatv("{0}_preamble_patch.h", FileName); +

[PATCH] D67052: Add reference type transformation builtins

zoecarver marked 6 inline comments as done. zoecarver added a comment. @EricWF and @miscco thanks for the review comments. Sorry for the delay, I forgot about this patch. All your comments have been addressed/fixed. Comment at: clang/lib/AST/TypePrinter.cpp:1020 switch

[PATCH] D78513: [hip] Claim builtin type `__float128` supported if the host target supports it.

yaxunl added a comment. Currently if instructions of float128 get to amdgpu backend, are we going to crash? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78513/new/ https://reviews.llvm.org/D78513

[PATCH] D78441: Delete NaCl support

dschuff added a comment. @jfb thanks for the heads-up. I replied on the mailing list thread. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78441/new/ https://reviews.llvm.org/D78441 ___ cfe-commits

[PATCH] D78511: [Driver][doc] Document option -mtune as a no-op. NFC.

SjoerdMeijer updated this revision to Diff 258823. SjoerdMeijer added a comment. Cheers, that's probably what I wanted to say. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78511/new/ https://reviews.llvm.org/D78511 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D78513: [hip] Claim builtin type `__float128` supported if the host target supports it.

hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added subscribers: cfe-commits, kerbowa, nhaehnle, jvesely. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78513 Files: clang/lib/Basic/Targets/AMDGPU.cpp

[PATCH] D78511: [Driver][doc] Document option -mtune as a no-op. NFC.

Quuxplusone added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2738 +Accepts any value for compatability reasons with GCC, thus not performing any CPU type specific tuning. + "Accepts any value, for compatibility with GCC. Does not

[PATCH] D78066: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber

This revision was automatically updated to reflect the committed changes. Closed by commit rG85cca945b4c9: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D78511: [Driver][doc] Document option -mtune as a no-op. NFC.

SjoerdMeijer created this revision. SjoerdMeijer added a reviewer: dblaikie. This is a doc change documenting that option -mtune does not perform any CPU type specific tuning but exists for compatability reasons with GCC. https://reviews.llvm.org/D78511 Files:

[PATCH] D78338: [clangd] Enable diagnostic fixes within macro argument expansions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6529b0c48aab: [clangd] Enable diagnostic fixes within macro argument expansions. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D78338?vs=258202=258812#toc Repository: rG

[PATCH] D78495: [nfc] Accept addrspacecast allocas in InitTempAlloca

rjmccall added a comment. You're not testing an assertion, you're testing that code is generated correctly for some file on amdgcn. Just write an ordinary IR-generation test that currently crashes and this test fixes. This is not an NFC change. Repository: rG LLVM Github Monorepo CHANGES

[clang] 85cca94 - [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber

Author: Erik Pilkington Date: 2020-04-20T15:22:51-04:00 New Revision: 85cca945b4c93ecfd3f3bb7a7b2d5fa4104c3560 URL: https://github.com/llvm/llvm-project/commit/85cca945b4c93ecfd3f3bb7a7b2d5fa4104c3560 DIFF:

[clang-tools-extra] 6529b0c - [clangd] Enable diagnostic fixes within macro argument expansions.

Author: Sam McCall Date: 2020-04-20T21:18:31+02:00 New Revision: 6529b0c48aab83bdada1d21a79da13b0971d1aec URL: https://github.com/llvm/llvm-project/commit/6529b0c48aab83bdada1d21a79da13b0971d1aec DIFF: https://github.com/llvm/llvm-project/commit/6529b0c48aab83bdada1d21a79da13b0971d1aec.diff

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

VojtechStep updated this revision to Diff 258805. VojtechStep edited the summary of this revision. VojtechStep added a comment. @sammccall I think I fixed all raised issues. Let me know if there is anything else I can do, otherwise feel free to commit it. Also Note to self: Once this is pushed

[PATCH] D78509: [AArch64][SVE] Add addressing mode for contiguous loads & stores

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. I think I made a mess with the Actions for this review! I mean to accept it, not to enforce the nit comments! Francesco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. Looks ok to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

emaste added a comment. In D6#1981271 , @jbeich wrote: > - Limit the scope to `-stdlib` > > In D6#1972543 , @dim wrote: > > > the lowest supported version, which is currently 10 > > > Where is this defined?

[PATCH] D77156: [CMAKE] Plumb include_directories() into tablegen()

beanz added a comment. Herald added a subscriber: frgossen. I'm not sure this is actually the right approach. Adding the directory's `INCLUDE_DIRECTORIES` option also adds any path added with `include_directories`, which includes system paths and other locations that shouldn't ever have

[PATCH] D78509: [AArch64][SVE] Add addressing mode for contiguous loads & stores

fpetrogalli requested changes to this revision. fpetrogalli added a comment. This revision now requires changes to proceed. Hi @kmclaughlin , thank you for working on this! The patch LGTM, but please consider renaming the multiclass for the non faulting loads like I suggested. The rest of the

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 258798. baloghadamsoftware added a comment. I commented out lines which prevent creation of `StackFrameContext` for non-inlined functions. Now everything works regarding the iterator checkers. I also simplified things and created new methods for

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f12480bd13a: [dfsan] Add DataFlow option to LLVM_USE_SANITIZER (authored by zbrid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/

[PATCH] D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms.

jacek created this revision. jacek added a reviewer: clang. Herald added subscribers: cfe-commits, mstorsjo. Herald added a project: clang. On 32-bit Windows platform, int and long is mixed all over the place in platform headers. The most notable example is SIZE_T, which is unsigned long,

[PATCH] D78509: [AArch64][SVE] Add addressing mode for contiguous loads & stores

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, fpetrogalli, efriedma. Herald added subscribers: danielkiss, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. This patch adds the register + register

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid added a comment. Bug: https://bugs.llvm.org/show_bug.cgi?id=45621 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 ___ cfe-commits mailing list

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid updated this revision to Diff 258789. zbrid added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 Files: clang/docs/DataFlowSanitizer.rst libcxx/CMakeLists.txt

[clang] 9b2ab41 - Revert "[MS] Fix assert handling enum forward decls in hasVisibleDefinition"

Author: Rumeet Dhindsa Date: 2020-04-20T10:40:27-07:00 New Revision: 9b2ab41037f45ad92ab4e850591093ffc45d3e10 URL: https://github.com/llvm/llvm-project/commit/9b2ab41037f45ad92ab4e850591093ffc45d3e10 DIFF:

[clang] 0f12480 - [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

Author: Zola Bridges Date: 2020-04-20T10:30:52-07:00 New Revision: 0f12480bd13ad2d08b6ef3d64388dd8a12e1a503 URL: https://github.com/llvm/llvm-project/commit/0f12480bd13ad2d08b6ef3d64388dd8a12e1a503 DIFF: https://github.com/llvm/llvm-project/commit/0f12480bd13ad2d08b6ef3d64388dd8a12e1a503.diff

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid added a comment. Gonna land this and file a bug for the failing tests. The tests shouldn't block anyone upstream since I'm only adding a build mode. I'll do some more digging into those failures in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78506: [NFC] Common up TargetCodeGenInfo for all PowerPC target.

jasonliu added a comment. To reviewers: Although the patch is showing changes on various ABIInfo classes. But those classes are actually untouched. This patch only touches PowerPC TargetCodeGenInfo related classes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78506/new/

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:198 + // 'self' variable of the current class method. + if (ReceiverSVal == Message.getSelfSVal()) { +// In this case, we should return the type of the enclosing

[PATCH] D73290: [PowerPC] Add clang -msvr4-struct-return for 32-bit ELF

nemanjai accepted this revision. nemanjai added a comment. Aside from a couple of minor nits that shouldn't require another review, LGTM. Comment at: clang/docs/ClangCommandLineReference.rst:2631 + +Override the default ABI for 32-bit targets to return small structs in

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added a comment. Okay, seems like OpenMP needs unsupported types diagnosing as well. I'm trying to adapt this patch for OpenMP, but it doesn't work out of the box because it diagnoses memcpy like operations, so with the current patch the code like this will cause diagnostics:

[PATCH] D78506: [NFC] Common up TargetCodeGenInfo for all PowerPC target.

jasonliu created this revision. jasonliu added reviewers: sfertile, nemanjai, hubert.reinterpretcast, cebowleratibm. Herald added subscribers: steven.zhang, shchenz. jasonliu added a reviewer: PowerPC. jasonliu added a comment. To reviewers: Although the patch is showing changes on various

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

aykevl added a comment. I can't give an LGTM but at least from my perspective I very much welcome this change. I am still hitting problems with non-zero address spaces on AVR. One nit in an inline comment. Do you plan on eventually removing `LLVM_NO_IMPLICIT_ADDRESS_SPACE` when the transition

[PATCH] D77221: [AVR] Rework MCU family detection to support more AVR MCUs

rjmccall added a comment. Patch generally looks good, but I agree that it could use some basic tests. You don't need to do specifically test all 20 million releases, but make sure you cover the first and last in the array as well as something in the middle, just to make sure your scans are

[PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

teemperor added a comment. Beside Gabors comment I think I'm happy with this. Thanks! Comment at: clang/unittests/AST/ASTImporterTest.cpp:5939 + +/// An ExternalASTSource that keeps track of the tags is completed. +struct SourceWithCompletedTagList : clang::ExternalASTSource {

[PATCH] D77735: [SveEmitter] Implement builtins for gathers/scatters

sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7451 + } + llvm_unreachable("Unknown MemEltType"); +} SjoerdMeijer wrote: > nit: to be consistent, do this in the default clause? Doing that would lead to warning: default label

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Looks good with a few nits. Once you're done, let me know if I should land this for you (after a few patches landed this way you can apply for commit access:

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

VojtechStep created this revision. VojtechStep added reviewers: sammccall, chandlerc, Bigcheese. VojtechStep added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, ormris, kadircet, arphaman, dexonsmith, jkorous, MaskRay, ilya-biryukov, hiraditya. Herald added a

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

sammccall added a comment. OK LG without changes Comment at: clang/lib/Sema/SemaDecl.cpp:12565 + auto RecoveryExpr = + CreateRecoveryExpr(Var->getLocation(), Var->getEndLoc(), {}); + if (RecoveryExpr.get()) hokein wrote: > sammccall wrote: >

[PATCH] D78366: [Preamble] Allow recursive inclusion of header-guarded mainfile.

This revision was automatically updated to reflect the committed changes. Closed by commit rGee12edcb7642: [Preamble] Allow recursive inclusion of header-guarded mainfile. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78338: [clangd] Enable diagnostic fixes within macro argument expansions.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:563 +for (auto : FixIts) { + // Allow fixits within a single macro-arg expansion to be applied. + if

[PATCH] D77591: [SveEmitter] Explicitly merge with zero/undef

This revision was automatically updated to reflect the committed changes. Closed by commit rG9986b3de26d3: [SveEmitter] Explicitly merge with zero/undef (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D77591?vs=255501=258760#toc Repository: rG LLVM Github Monorepo

[PATCH] D78495: [nfc] Accept addrspacecast allocas in InitTempAlloca

JonChesterfield added a comment. In D78495#1992404 , @arsenm wrote: > Needs test? I'm not sure how to write said test. How do we normally hit asserts from the clang test suite? This fires a lot in the openmp on amdgcn downstream branch, but I'm happy

[PATCH] D78495: [nfc] Accept addrspacecast allocas in InitTempAlloca

arsenm added a comment. Needs test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78495/new/ https://reviews.llvm.org/D78495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77735: [SveEmitter] Implement builtins for gathers/scatters

sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7601 + llvm::Type *SrcDataTy = getSVEType(TypeFlags); + llvm::Type *OverloadedTy = llvm::VectorType::get( + SVEBuiltinMemEltTy(TypeFlags), SrcDataTy->getVectorElementCount());

[clang] ee12edc - [Preamble] Allow recursive inclusion of header-guarded mainfile.

Author: Sam McCall Date: 2020-04-20T17:28:42+02:00 New Revision: ee12edcb76423c78b55cdddae2edfe45cbb2ccd6 URL: https://github.com/llvm/llvm-project/commit/ee12edcb76423c78b55cdddae2edfe45cbb2ccd6 DIFF: https://github.com/llvm/llvm-project/commit/ee12edcb76423c78b55cdddae2edfe45cbb2ccd6.diff

[clang] 9986b3d - [SveEmitter] Explicitly merge with zero/undef

Author: Sander de Smalen Date: 2020-04-20T16:26:20+01:00 New Revision: 9986b3de26d31be26d978194333c44e82873f3ff URL: https://github.com/llvm/llvm-project/commit/9986b3de26d31be26d978194333c44e82873f3ff DIFF:

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

steakhal marked 2 inline comments as done. steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:113 const CheckerContext ) { - const FunctionDecl *FDecl = C.getCalleeDecl(CE); +

[PATCH] D78495: [nfc] Accept addrspacecast allocas in InitTempAlloca

JonChesterfield created this revision. JonChesterfield added reviewers: rjmccall, aaron.ballman, ABataev, jdoerfert, arsenm. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. [nfc] Accept addrspacecast allocas in InitTempAlloca Changes the precondition to be slightly

[PATCH] D77594: [SveEmitter] Add support for _n form builtins

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Looks reasonable to me Comment at: clang/utils/TableGen/SveEmitter.cpp:212 + bool hasSplat() const { +return Proto.find_first_of("ajfrKLR") !=

[PATCH] D76680: [SveEmitter] Add immediate checks for lanes and complex imms

This revision was automatically updated to reflect the committed changes. sdesmalen marked an inline comment as done. Closed by commit rGfc6453974980: [SveEmitter] Add immediate checks for lanes and complex imms (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 258732. DiggerLin marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/ https://reviews.llvm.org/D76932 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:198 + // 'self' variable of the current class method. + if (ReceiverSVal == Message.getSelfSVal()) { +// In this case, we should return the type of the enclosing

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

arichardson created this revision. arichardson added reviewers: aykevl, dylanmckay, arsenm, bjope, theraven, jrtc27. Herald added subscribers: cfe-commits, hiraditya, mgorny, wdng. Herald added a reviewer: ctetreau. Herald added a project: clang. APIs such as

[clang] fc64539 - [SveEmitter] Add immediate checks for lanes and complex imms

Author: Sander de Smalen Date: 2020-04-20T15:10:54+01:00 New Revision: fc645397498037ccb7df230a07e9a8762aaf8c8f URL: https://github.com/llvm/llvm-project/commit/fc645397498037ccb7df230a07e9a8762aaf8c8f DIFF:

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12565 + auto RecoveryExpr = + CreateRecoveryExpr(Var->getLocation(), Var->getEndLoc(), {}); + if (RecoveryExpr.get()) sammccall

[PATCH] D77594: [SveEmitter] Add support for _n form builtins

sdesmalen added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77594/new/ https://reviews.llvm.org/D77594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76679: [SveEmitter] Add more immediate operand checks.

This revision was automatically updated to reflect the committed changes. Closed by commit rG515020c091e7: [SveEmitter] Add more immediate operand checks. (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D76679?vs=252246=258724#toc Repository: rG LLVM Github

[PATCH] D78280: [Analyzer][StreamChecker] Track streams that were not found to be opened.

Szelethus added a comment. The high level idea seems great after surveying the analyzer for similar issues, but I might need to think about this a bit longer. @baloghadamsoftware, IteratorChecker needs to solve similar problems, right? Do you have any input on this? Repository: rG LLVM

[PATCH] D78401: [SveEmitter] IsInsertOp1SVALL and builtins for svqdec[bhwd] and svqinc[bhwd]

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Looks reasonable Comment at: clang/include/clang/Basic/arm_sve.td:530 +class sat_type { string U = u; string T = t; } +def SIGNED_BYTE : sat_type<"",

[PATCH] D78338: [clangd] Enable diagnostic fixes within macro argument expansions.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:563 +for (auto : FixIts) { + // Allow fixits within a single macro-arg expansion to be applied. + if (FixIt.RemoveRange.getBegin().isMacroID() && sammccall wrote: >

[clang] 515020c - [SveEmitter] Add more immediate operand checks.

Author: Sander de Smalen Date: 2020-04-20T14:41:58+01:00 New Revision: 515020c091e74723ee0876229890d71a8aa79702 URL: https://github.com/llvm/llvm-project/commit/515020c091e74723ee0876229890d71a8aa79702 DIFF:

[PATCH] D76929: [AArch64][SVE] Add SVE intrinsic for LD1RQ

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:11622 + if (VT.isFloatingPoint()) +Load = DAG.getNode(ISD::BITCAST, DL, VT, Load); + kmclaughlin wrote: > sdesmalen wrote: > > I'd expect this to then use

[PATCH] D78487: Explicitly move from llvm::json Array/Object to Value

This revision was automatically updated to reflect the committed changes. Closed by commit rGb36b889a3b81: Explicitly move from llvm::json Array/Object to Value (authored by MForster, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

NoQ added inline comments. Herald added a subscriber: ASDenysPetrov. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:113 const CheckerContext ) { - const FunctionDecl *FDecl = C.getCalleeDecl(CE); +

[PATCH] D78487: Explicitly move from llvm::json Array/Object to Value

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78487/new/ https://reviews.llvm.org/D78487

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

ostannard added a reviewer: kristof.beyls. ostannard added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76291/new/ https://reviews.llvm.org/D76291 ___ cfe-commits mailing list

[PATCH] D77845: [analyzer][CallAndMessage][NFC] Change old callbacks to rely on CallEvent

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:113-114 const CheckerContext ) { - assert(Call.getDecl()); + if

[PATCH] D77735: [SveEmitter] Implement builtins for gathers/scatters

SjoerdMeijer accepted this revision. SjoerdMeijer added a reviewer: efriedma. SjoerdMeijer added a comment. This revision is now accepted and ready to land. This is a big patch, but looks reasonable to me. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7451 + } +

[clang-tools-extra] b36b889 - Explicitly move from llvm::json Array/Object to Value

Author: Michael Forster Date: 2020-04-20T15:18:52+02:00 New Revision: b36b889a3b81b893c220c1858d16493152b36852 URL: https://github.com/llvm/llvm-project/commit/b36b889a3b81b893c220c1858d16493152b36852 DIFF:

[PATCH] D78487: Explicitly move from llvm::json Array/Object to Value

MForster created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. MForster retitled this revision from "Explicitly move from llvm::json Array to Value" to "Explicitly move from llvm::json Array/Object to Value". MForster

  1   2   >