[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6416 + if (D->hasAttr()) +return true; + I don't think we can just unconditionally check for the attribute. The rule for `trivial_abi` is that it overrides direct sources of non-tri

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu added inline comments. Comment at: clang/include/clang/Driver/Options.td:3125 +foreach i = {0-4} in + def m680#i#0 : Flag<["-"], "m680"#i#"0">, Group; bruno wrote: > rengolin wrote: > > Same question as @RKSimon had below: Shouldn't this cover all models

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu updated this revision to Diff 308551. myhsu marked 11 inline comments as done. myhsu added a comment. - Rebased to latest changes - Addressed some of the feedbacks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 Files: clang/include/clan

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 308550. myhsu marked 5 inline comments as done. myhsu added a comment. - Rebased to latest changes - Addressed some of the feedbacks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files: clang/include/clang

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93dc1b5b8cb2: [Remarks][2/2] Expand remarks hotness threshold option support in more tools (authored by weiwang). Repository: rG LLVM Github Monor

[clang] 93dc1b5 - [Remarks][2/2] Expand remarks hotness threshold option support in more tools

Author: Wei Wang Date: 2020-11-30T21:55:50-08:00 New Revision: 93dc1b5b8cb2f85d0d347f39e49a7150accd4e70 URL: https://github.com/llvm/llvm-project/commit/93dc1b5b8cb2f85d0d347f39e49a7150accd4e70 DIFF: https://github.com/llvm/llvm-project/commit/93dc1b5b8cb2f85d0d347f39e49a7150accd4e70.diff LOG:

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang added a comment. In D85808#2424588 , @tejohnson wrote: > lgtm with a couple of minor nits noted below that you can fix before > submitting Thanks for pointing them out. Really appreciate it! Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang updated this revision to Diff 308536. weiwang added a comment. 1. Fix typo. 2. Minor order adjustment in testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 Files: clang/include/clang/Basic/

[PATCH] D92016: [ASTImporter] Make the Import() return value consistent with the map of imported decls when merging ClassTemplateSpecializationDecls

shafik added a comment. Great catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92016/new/ https://reviews.llvm.org/D92016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D92363: [HIP] Warn no --offload-arch option

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. This patch let clang emit a warning when no --offload-arch option is specified, which usually indicates that users forget to specify this option. https://reviews.llvm.org/D92363 Files: clang

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver updated this revision to Diff 308526. zoecarver added a comment. - Update wording in AttrDocs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.org/D92361 Files: clang/include/clang/Basic/AttrDocs.td clang

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2986 purpose of calls. -A class annotated with ``trivial_abi`` can have non-trivial destructors or -copy/move constructors without automatically becoming non-trivial for the -purposes of calls. Fo

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2986 purpose of calls. -A class annotated with ``trivial_abi`` can have non-trivial destructors or -copy/move constructors without automatically becoming non-trivial for the -purposes of calls. For

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

jasonliu added a comment. In D91455#2424584 , @hubert.reinterpretcast wrote: >> 2. AIX uses a new personality routine, named __xlcxx_personality_v1. It >> doesn't use the GCC personality rountine, because the intractability is not >> there yet on AIX. >

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

jasonliu added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:889 + CompactUnwindSection = + Ctx->getXCOFFSection(".eh_info_table", XCOFF::StorageMappingClass::XMC_RW, + XCOFF::XTY_SD, SectionKind::getData()); dalte

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver updated this revision to Diff 308523. zoecarver edited the summary of this revision. zoecarver added a comment. - Fix wording in AttrDocs - Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.org/D

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2986 purpose of calls. -A class annotated with ``trivial_abi`` can have non-trivial destructors or -copy/move constructors without automatically becoming non-trivial for the -purposes of calls. Fo

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added a comment. This seems like a good change, but we should make sure we test cases that may previously have been covered by the implicit deletion of all copy/move constructors. That may just be a matter of auditing tests. Comment at: clang/include/clang/Basic/Att

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm with a couple of minor nits noted below that you can fix before submitting Comment at: clang/include/clang/Basic/CodeGenOptions.h:353 + /// The threshold is an Op

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

hubert.reinterpretcast added a comment. > 2. AIX uses a new personality routine, named __xlcxx_personality_v1. It > doesn't use the GCC personality rountine, because the intractability is not > there yet on AIX. @jasonliu, is "intractability" a typo/autocorrect problem? CHANGES SINCE LAST ACT

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2986 purpose of calls. -A class annotated with ``trivial_abi`` can have non-trivial destructors or -copy/move constructors without automatically becoming non-trivial for the -purposes of calls. Fo

[PATCH] D91088: [CUDA][HIP] Fix capturing reference to host variable

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1944 + // host variable in a device or host device lambda. + auto IsCapturingReferenceToHostVarInCUDADeviceLambda = [&](VarDecl *VD) { +if (!getLangOpts().CUDA ||

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. zoecarver requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92361 Files: clang/include/clang/Basic/At

[PATCH] D91088: [CUDA][HIP] Fix capturing reference to host variable

yaxunl updated this revision to Diff 308519. yaxunl marked an inline comment as done. yaxunl added a comment. extract lambda as a function CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91088/new/ https://reviews.llvm.org/D91088 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/Sema/Sem

[PATCH] D91884: clang+lld: Improve clang+ld.darwinnew.lld interaction, pass -demangle

gkm added a comment. Thank you for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91884/new/ https://reviews.llvm.org/D91884 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song updated this revision to Diff 308517. yonghong-song edited the summary of this revision. yonghong-song added a comment. - remove atomic_fetch_sub which can be implemented with neg + atomic_fetch_add - add support for xand, xor, xxor (xadd already been supported) - for any given __syn

[PATCH] D92339: Add help text for -nogpuinc

This revision was automatically updated to reflect the committed changes. Closed by commit rG011bf4f55630: Add help text for -nogpuinc (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92339/new/ http

[clang] 011bf4f - Add help text for -nogpuinc

Author: Yaxun (Sam) Liu Date: 2020-11-30T22:31:16-05:00 New Revision: 011bf4f55630858111e5f0504b3f7390eaf41e09 URL: https://github.com/llvm/llvm-project/commit/011bf4f55630858111e5f0504b3f7390eaf41e09 DIFF: https://github.com/llvm/llvm-project/commit/011bf4f55630858111e5f0504b3f7390eaf41e09.dif

[clang] 7bc944c - Revert "[clang][Fuchsia] Add relative-vtables multilib"

Author: Leonard Chan Date: 2020-11-30T19:21:35-08:00 New Revision: 7bc944c102c2bdb009da4fe7d53dda15ea19ee71 URL: https://github.com/llvm/llvm-project/commit/7bc944c102c2bdb009da4fe7d53dda15ea19ee71 DIFF: https://github.com/llvm/llvm-project/commit/7bc944c102c2bdb009da4fe7d53dda15ea19ee71.diff

[PATCH] D80450: [CUDA][HIP] Fix HD function resolution

yaxunl updated this revision to Diff 308515. yaxunl edited the summary of this revision. yaxunl added a comment. Herald added subscribers: dexonsmith, dang. Add -ffix-overload-resolution and fix a regression. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80450/new/ https://reviews.llvm.

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

thakis added a comment. In D92357#2424484 , @keith wrote: > It looks like at least in the `-Wl` case clang passes the file through > directly, Right, that's my point: We see crashes around response files even if we let clang write it. > I _don't_ actua

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

daltenty added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:889 + CompactUnwindSection = + Ctx->getXCOFFSection(".eh_info_table", XCOFF::StorageMappingClass::XMC_RW, + XCOFF::XTY_SD, SectionKind::getData()); jason

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

This revision was automatically updated to reflect the committed changes. Closed by commit rGfdbd84c6c819: [clang][Fuchsia] Add relative-vtables multilib (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85576/new/ https://rev

[clang] fdbd84c - [clang][Fuchsia] Add relative-vtables multilib

Author: Leonard Chan Date: 2020-11-30T18:21:10-08:00 New Revision: fdbd84c6c819d4462546961f6086c1524d5d5ae8 URL: https://github.com/llvm/llvm-project/commit/fdbd84c6c819d4462546961f6086c1524d5d5ae8 DIFF: https://github.com/llvm/llvm-project/commit/fdbd84c6c819d4462546961f6086c1524d5d5ae8.diff

[clang] a160189 - Revert "[clang][Fuchsia] Add relative-vtables multilib"

Author: Leonard Chan Date: 2020-11-30T18:20:01-08:00 New Revision: a160189c5dfaa6b3d7c3db71991e50eebea9a63d URL: https://github.com/llvm/llvm-project/commit/a160189c5dfaa6b3d7c3db71991e50eebea9a63d DIFF: https://github.com/llvm/llvm-project/commit/a160189c5dfaa6b3d7c3db71991e50eebea9a63d.diff

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

keith added a comment. It looks like at least in the `-Wl` case clang passes the file through directly, so I'm not surprises that it repros there: % clang -Wl,@shell_dialogs_unittests.rsp -v Apple clang version 12.0.0 (clang-1200.0.32.27) Target: x86_64-apple-darwin19.6.0 Thread model: p

[clang] 7c2bc3b - [clang][Fuchsia] Add relative-vtables multilib

Author: Leonard Chan Date: 2020-11-30T18:17:38-08:00 New Revision: 7c2bc3b71dc072987d43a2a86609871bd01f981f URL: https://github.com/llvm/llvm-project/commit/7c2bc3b71dc072987d43a2a86609871bd01f981f DIFF: https://github.com/llvm/llvm-project/commit/7c2bc3b71dc072987d43a2a86609871bd01f981f.diff

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

thakis added a comment. In D92357#2424422 , @keith wrote: > Note in your repro case the issue is that the response file doesn't end in a > trailing newline Hm, we also see crashes if we let clang write the response file that's passed to ld64 though. (ie

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

dmajor added a comment. To connect the dots for posterity: the followup was landed in D92349 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91747/new/ https://reviews.llvm.org/D91747 _

[PATCH] D83940: [clang][cli] Port HeaderSearch option flags to new option parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM with one nit. Comment at: clang/include/clang/Driver/Options.td:1514 + MarshallingInfoFlag<"HeaderSearchOpts->ModulesValidateDiagnosticOptions", "true">, IsNeg

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. When are you planning to refactor `OptInFFlag` to support the use cases called out in this patch? If it's right away / soon, I think it'd be a bit cleaner for to land the ref

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

keith added a comment. Note in your repro case the issue is that the response file doesn't end in a trailing newline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92357/new/ https://reviews.llvm.org/D92357 ___ cfe-commits mailing list cfe-co

[PATCH] D90485: Lex: Update Module::findHeader to return FileEntryRef, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGf85db7f7ba68: Lex: Update Module::findHeader to return FileEntryRef, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[clang] f85db7f - Lex: Update Module::findHeader to return FileEntryRef, NFC

Author: Duncan P. N. Exon Smith Date: 2020-11-30T17:13:03-08:00 New Revision: f85db7f7ba683b2450892fde247311d7a48adbd0 URL: https://github.com/llvm/llvm-project/commit/f85db7f7ba683b2450892fde247311d7a48adbd0 DIFF: https://github.com/llvm/llvm-project/commit/f85db7f7ba683b2450892fde247311d7a48a

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

thakis created this revision. thakis added a reviewer: jyknight. thakis requested review of this revision. This morally reverts D82777 -- turns out that ld64 crashes with many response files, so we must stop passing them to it until the crash is fixed. On the ot

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

dexonsmith added a comment. In D83892#2417903 , @jansvoboda11 wrote: > This is now ready to be reviewed. If you see a deleted option in the diff, > it's either because it was moved closer to its counterpart, or because it's > now generated by a multicla

[PATCH] D92291: clang/test: Remove platform-linker feature

This revision was automatically updated to reflect the committed changes. Closed by commit rG61da501b6a1b: clang/test: Remove platform-linker feature (authored by thakis). Herald added a subscriber: jrtc27. Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 61da501 - clang/test: Remove platform-linker feature

Author: Nico Weber Date: 2020-11-30T20:00:46-05:00 New Revision: 61da501b6a1bf845c3da9a7e761a3c6a3b6cf21a URL: https://github.com/llvm/llvm-project/commit/61da501b6a1bf845c3da9a7e761a3c6a3b6cf21a DIFF: https://github.com/llvm/llvm-project/commit/61da501b6a1bf845c3da9a7e761a3c6a3b6cf21a.diff LO

[PATCH] D92109: [ASTImporter] Support import of CXXDeductionGuideDecl

rnk added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3336 +if (Fun->getExplicitSpecifier().getExpr()) { + ExplicitExpr = importChecked(Err, Fun->getExplicitSpecifier().getExpr()); + if (Err) GCC 5.3 complained about this, so I rewrot

[PATCH] D92291: clang/test: Remove platform-linker feature

vvereschaka accepted this revision. vvereschaka added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92291/new/ https://reviews.llvm.org/D92291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] 43b5b48 - Fix GCC 5.3 compile error in ASTImporter code

Author: Reid Kleckner Date: 2020-11-30T16:29:29-08:00 New Revision: 43b5b485a203f190ee4d5d3cab19c44ca865d316 URL: https://github.com/llvm/llvm-project/commit/43b5b485a203f190ee4d5d3cab19c44ca865d316 DIFF: https://github.com/llvm/llvm-project/commit/43b5b485a203f190ee4d5d3cab19c44ca865d316.diff

[PATCH] D92355: [clang] add a `swift_async_name` attribute

arphaman created this revision. arphaman added reviewers: erik.pilkington, aaron.ballman. Herald added subscribers: ributzka, jkorous. Herald added a project: clang. arphaman requested review of this revision. The `swift_async_name` attribute provides a name for a function/method that can be used

[PATCH] D92354: [clang] add a new `swift_attr` attribute

arphaman created this revision. arphaman added reviewers: erik.pilkington, aaron.ballman. Herald added subscribers: ributzka, jkorous. Herald added a project: clang. arphaman requested review of this revision. The `swift_attr` attribute is a generic annotation attribute that's not used by clang,

[PATCH] D83812: [clang][RelativeVTablesABI] Use dso_local_equivalent rather than emitting stubs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf8ff75bade7: [clang][RelativeVTablesABI] Use dso_local_equivalent rather than emitting stubs (authored by leonardchan). Repository: rG LLVM Githu

[clang] cf8ff75 - [clang][RelativeVTablesABI] Use dso_local_equivalent rather than emitting stubs

Author: Leonard Chan Date: 2020-11-30T16:02:35-08:00 New Revision: cf8ff75bade763b054476321dcb82dcb2e7744c7 URL: https://github.com/llvm/llvm-project/commit/cf8ff75bade763b054476321dcb82dcb2e7744c7 DIFF: https://github.com/llvm/llvm-project/commit/cf8ff75bade763b054476321dcb82dcb2e7744c7.diff

[PATCH] D91840: OpaquePtr: Require byval on x86_intrcc parameter 0

dblaikie added a comment. (generally I'd suggest splitting the clangc and llvm patches if at all possible - in this case I'm guessing the clang patch could go first (adding the attribute which would be redundant/unused initially), then the LLVM one?) CHANGES SINCE LAST ACTION https://reviews

[PATCH] D91270: [Clang][CodeGen][RISCV] Fix hard float ABI test cases with empty struct

jrtc27 added a comment. Seems good other than additional comments regarding code clarity. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10577 NeededArgGPRs++; - return IsCandidate; + return true; } This NFC hunk definitely makes this clearer :) ===

[PATCH] D91270: [Clang][CodeGen][RISCV] Fix hard float ABI test cases with empty struct

lenary added a reviewer: jrtc27. lenary added a comment. I *think* this is looking good, but I'd like a second pair of eyes from @jrtc27 as I know she's fixed bugs around this area recently too. We would like to have this ready for 11.0.1 if possible. Comment at: clang/lib/Co

[PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

shafik added inline comments. Comment at: lldb/test/API/commands/expression/import-std-module/deque-basic/TestDequeFromStdModule.py:25 -deque_type = "std::deque >" size_type = deque_type + "::size_type" Why do the default arguments not show up

[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

dexonsmith added a comment. Thanks again for the review, landed in 1b042de5b29af4869a77ecbc632029fba0313dec . Comment at: clang/unittests/Basic/FileEntryTest.cpp:95 OptionalFileEntryRefDegradesToFileEntr

[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b042de5b29a: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 94f537c - Remove dead code added in ac49500cd0484e1b2dcf37fa4c0dade6f113c2c9, NFC

Author: Duncan P. N. Exon Smith Date: 2020-11-30T14:50:46-08:00 New Revision: 94f537c6b2bb55c8e058a9989d02ab0d68a0c61a URL: https://github.com/llvm/llvm-project/commit/94f537c6b2bb55c8e058a9989d02ab0d68a0c61a DIFF: https://github.com/llvm/llvm-project/commit/94f537c6b2bb55c8e058a9989d02ab0d68a0

[clang] 1b042de - FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

Author: Duncan P. N. Exon Smith Date: 2020-11-30T14:50:46-08:00 New Revision: 1b042de5b29af4869a77ecbc632029fba0313dec URL: https://github.com/llvm/llvm-project/commit/1b042de5b29af4869a77ecbc632029fba0313dec DIFF: https://github.com/llvm/llvm-project/commit/1b042de5b29af4869a77ecbc632029fba031

[PATCH] D91997: APINotes: add bitcode format schema definitions

compnerd added a comment. Gentle post-holiday reminder :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91997/new/ https://reviews.llvm.org/D91997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91278: [Clang][CodeGen][RISCV] Fix hard float ABI for struct with empty struct and complex

lenary added a comment. LGTM - the big hint is that the new test is handled the same as `f_empty_double2` as required by the ABI. Comment at: clang/test/CodeGen/riscv32-ilp32d-abi.cpp:36 + +struct empty_complex { struct {}; double _Complex fc; }; + Please can

[PATCH] D91673: [PGO] Enable preinline and cleanup when optimize for size

zequanwu added a comment. In D91673#2401578 , @xur wrote: > This is probably OK for -Os (SizeLevel == 1), but we need to be careful with > Oz (SizeLevel == 2). > We already know that enabling preinliner in general will reduce size -- as > the preinliner

[PATCH] D92106: [ASTImporter] Import the default argument of NonTypeTemplateParmDecl

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:965 +TEST_P(ASTImporterOptionSpecificTestBase, NonTypeTemplateParmDeclDefaultArg) { + Decl *FromTU = getTuDecl("template struct X {};", Lang_CXX03); + auto From = FirstDeclMatcher().match( ---

[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

dexonsmith added inline comments. Comment at: clang/unittests/Basic/FileEntryTest.cpp:95 OptionalFileEntryRefDegradesToFileEntryPtr M0; OptionalFileEntryRefDegradesToFileEntryPtr M1 = R1; jansvoboda11 wrote: > Dead variable, do we need it? Thanks, nice ca

[clang] ac40a2d - Serialization: Change InputFile to use FileEntryRef and add getVirtualFileRef, NFC

Author: Duncan P. N. Exon Smith Date: 2020-11-30T14:04:48-08:00 New Revision: ac40a2d8f16b8a8c68fc811d67f647740e965cb8 URL: https://github.com/llvm/llvm-project/commit/ac40a2d8f16b8a8c68fc811d67f647740e965cb8 DIFF: https://github.com/llvm/llvm-project/commit/ac40a2d8f16b8a8c68fc811d67f647740e96

[PATCH] D90053: Serialization: Change InputFile to use FileEntryRef and add getVirtualFileRef, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGac40a2d8f16b: Serialization: Change InputFile to use FileEntryRef and add getVirtualFileRef… (authored by dexonsmith). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D9

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

jasonliu added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:889 + CompactUnwindSection = + Ctx->getXCOFFSection(".eh_info_table", XCOFF::StorageMappingClass::XMC_RW, + XCOFF::XTY_SD, SectionKind::getData()); dalte

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

rnk added a comment. In D91747#2423987 , @zequanwu wrote: > So, we could remove the checking for if `__STDCPP_THREADS__` and > `_LIBCPP_HAS_NO_THREADS` are both set. And let libcxx adds flag > `-mthread-model single` to use single thread (but this is com

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

zequanwu added a comment. In D91747#2423960 , @rnk wrote: > If we believe the standard says that the compiler is supposed to set > `__STDCPP_THREADS__`, then I think the libc++ #error needs to be adjusted. > libcxxabi, or any other client, should be able

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

rnk added a comment. Windows has effectively always had stack clash protection: we've always emitted those little chkstk probe calls for stack frames larger than a page. Would it make more sense to ignore this flag on Windows, since it opts into always-on behavior? If so, this doesn't seem like

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

rnk added a comment. If we believe the standard says that the compiler is supposed to set `__STDCPP_THREADS__`, then I think the libc++ #error needs to be adjusted. libcxxabi, or any other client, should be able to define `_LIBCPP_HAS_NO_THREADS`, and it should work, even if the compiler thinks

[PATCH] D91088: [CUDA][HIP] Fix capturing reference to host variable

tra added a comment. LGTM in general. Comment at: clang/lib/Sema/SemaExpr.cpp:1944 + // host variable in a device or host device lambda. + auto IsCapturingReferenceToHostVarInCUDADeviceLambda = [&](VarDecl *VD) { +if (!getLangOpts().CUDA || !VD->hasInit()) ---

[PATCH] D91840: OpaquePtr: Require byval on x86_intrcc parameter 0

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Thanks for removing that special case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91840/new/ https://reviews.llvm.org/D91840 ___ cfe-co

[PATCH] D80450: [CUDA][HIP] Fix HD function resolution

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/test/SemaCUDA/function-overload.cu:616 +// HDs have type mismatch whereas H has type match. +// In device compilation, H wins when -fgpu-defer-diag is off and two HD win +// when -fgpu-defer-

[PATCH] D91861: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. This LGTM. Thanks again for the cleanup, I think the new syntax is more intuitive. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4027-4031 + if (((FLAGS)&op

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2077 QualType TransformTypedefType(TypeLocBuilder &TLB, TypedefTypeLoc TL) { ASTContext &Context = SemaRef.getASTContext(); The check to see if we should clone a typedef or not sh

[PATCH] D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. This LGTM, with one more nit to consider. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:163 +static constexpr bool is_int_convertible() { + return sizeof(T)

[PATCH] D92291: clang/test: Remove platform-linker feature

phosek added a comment. In D92291#2423417 , @leonardchan wrote: > @phosek This shouldn't affect supporting riscv with our toolchain, right? Yes, it shouldn't have any impact. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92291/new/ https://revi

[PATCH] D92342: [HIP] Fix HIP test on windows due to lld suffix

This revision was automatically updated to reflect the committed changes. Closed by commit rGf89e9c8201ea: [HIP] Fix HIP test on windows due to lld suffix (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] f89e9c8 - [HIP] Fix HIP test on windows due to lld suffix

Author: Aaron En Ye Shi Date: 2020-11-30T21:05:26Z New Revision: f89e9c8201ea5a5b63af854c92ed26bc7ab4b8db URL: https://github.com/llvm/llvm-project/commit/f89e9c8201ea5a5b63af854c92ed26bc7ab4b8db DIFF: https://github.com/llvm/llvm-project/commit/f89e9c8201ea5a5b63af854c92ed26bc7ab4b8db.diff LO

[PATCH] D80450: [CUDA][HIP] Fix HD function resolution

tra added inline comments. Comment at: clang/test/SemaCUDA/function-overload.cu:616 +// HDs have type mismatch whereas H has type match. +// In device compilation, H wins when -fgpu-defer-diag is off and two HD win +// when -fgpu-defer-diags is on. In both cases the diagnostic sh

[PATCH] D83697: [clang][cli] Port Frontend option flags to new option parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83697/new/ https://reviews.llvm.org/D83697

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

ravikandhadai added inline comments. Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:889 + + /// Return true if th analyzed function is actually a default implementation + /// of the method that has to be overriden. typo: th -> the Repository: rG LLVM Gi

[PATCH] D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG164410324d8b: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to… (authored by MaskRay). Repository: rG LLVM Github Monorepo CH

[clang] 1644103 - [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null

Author: Fangrui Song Date: 2020-11-30T12:44:35-08:00 New Revision: 164410324d8bf3b5a99e39f7dfe3c6d6972dab30 URL: https://github.com/llvm/llvm-project/commit/164410324d8bf3b5a99e39f7dfe3c6d6972dab30 DIFF: https://github.com/llvm/llvm-project/commit/164410324d8bf3b5a99e39f7dfe3c6d6972dab30.diff

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith added a comment. In D91311#2418881 , @ldionne wrote: > In D91311#2417293 , @rsmith wrote: > >> In D91311#2416940 , @ldionne wrote: >> >>> LGTM from the libc++ point of

[PATCH] D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null

MaskRay updated this revision to Diff 308454. MaskRay marked an inline comment as done. MaskRay edited the summary of this revision. MaskRay added a comment. Fix a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92297/new/ https://reviews.llv

[PATCH] D80450: [CUDA][HIP] Fix HD function resolution

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/SemaCUDA/function-overload.cu:616 +// HDs have type mismatch whereas H has type match. +// In device compilation, H wins when -fgpu-defer-diag is off and two HD win +// when -fgpu-defer-

[PATCH] D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null

rsmith accepted this revision. rsmith added a comment. Looks good. There are a few other places where we unconditionally insert `dereferenceable` attributes (for reference parameters / return types, and for C99's `T [static]` array parameters). We should presumably apply the same workaround eve

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:790 + (Style.Language != FormatStyle::LK_TextProto || + OriginalPrefix[i].substr(0, 2) != "##")) { +Prefix[i] = IndentPrefix.str(); HazardyKnusper

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. In D92257#2422381 , @MyDeveloperDay wrote: > I think fundamentally from my perspective this seem ok, out of interest can I > ask what drove you to require it? > > My

[PATCH] D91874: [GNU ObjC] Fix a regression listing methods twice.

rjmccall added a comment. Functionally LGTM. I don't know if 11 is still taking changes, but if it is, you have code-owner approval. Comment at: clang/test/CodeGenObjC/gnu-method-only-once.m:8 +// merging happened was missed in the move and so we ended up emitting two +// cop

[PATCH] D92340: [libTooling][NFC] Remove deprecated Clang Transformer declarations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfdff677a9557: [libTooling] Remove deprecated Clang Transformer declarations (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added a comment. > I didn't sense any agreement or any sort of a conclusion on the RFC. > Moreover, I didn't feel at all that the existing address space attribute was > a good fit. I was suggesting to add a different attribute that isn't an > address space attribute from Embedded C. I don

[clang] fdff677 - [libTooling] Remove deprecated Clang Transformer declarations

Author: Yitzhak Mandelbaum Date: 2020-11-30T20:15:26Z New Revision: fdff677a955730b3e85b870ff1b30d7f8ea5719c URL: https://github.com/llvm/llvm-project/commit/fdff677a955730b3e85b870ff1b30d7f8ea5719c DIFF: https://github.com/llvm/llvm-project/commit/fdff677a955730b3e85b870ff1b30d7f8ea5719c.diff

[PATCH] D71124: [RISCV] support clang driver to select cpu

jrtc27 added a comment. In D71124#2423633 , @oceanfish81 wrote: > @khchen , > how should I obtain available (v)CPU features? > Any sample code, that should work on RISC-V? Probably `getauxval(AT_HWCAP)`; both Linux and FreeBSD put the ISA string in the l

  1   2   3   >