[PATCH] D77811: [clangd] Implement semanticTokens modifiers

nridge added a comment. Thanks a lot for working on this! I agree this is well aligned with the goals of D77702 (and in fact goes even further and meets the goals of D66990 via the `declaration` modifier). The other modifiers

[PATCH] D95670: [clangd] Don't rely on builtin headers for document-link.test.

kadircet accepted this revision. kadircet added a subscriber: sammccall. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! but I would wait for a while to see if someone(that remembers why this test was specifically asserting for built-in headers) will

[PATCH] D95759: [clangd] Rename: merge index/AST refs path-insensitively where needed

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95759/new/ https://reviews.llvm.org/D95759

[PATCH] D95725: clang-extra: fix incorrect use of std::lock_guard by adding variable name (identified by MSVC [[nodiscard]] error)

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/support/Function.h:54 if (Parent) { -std::lock_guard(Parent->ListenersMu); +std::lock_guard

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek added a comment. @MaskRay I saw on https://sourceware.org/bugzilla/show_bug.cgi?id=27259 that the infinite loop fix has been cherry picked into 2.36 branch so I updated the condition to `-fbinutils-version=2.36`. Is this OK to land? CHANGES SINCE LAST ACTION

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek updated this revision to Diff 320398. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76802/new/ https://reviews.llvm.org/D76802 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/test/profile/instrprof-gc-sections.c llvm/include/llvm/Transforms/Instrumentation.h

[PATCH] D95772: [DebugInfo] Normalize paths by removing unnecessary dots

phosek created this revision. phosek added reviewers: dblaikie, jhenderson. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was suggested in https://reviews.llvm.org/D87657 as a better alternative which doesn't require having

[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

poelmanc created this revision. poelmanc added reviewers: sammccall, hokein. poelmanc added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. poelmanc requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

poelmanc updated this revision to Diff 320393. poelmanc added a comment. Thanks @steveire, that suggestion worked perfectly! I added the additional test case and shortened the mimicked `strong_ordering` code to a version from `clang/unittests.ASTMatchers/ASTMatchersTraversalTest.cpp`, but also

[clang] e94a35a - [OpenMP] Fix comment and assertion strings (NFC).

Author: Mike Rice Date: 2021-01-31T17:17:33-08:00 New Revision: e94a35a744b780fcbe18e8bc6a4f774191588d45 URL: https://github.com/llvm/llvm-project/commit/e94a35a744b780fcbe18e8bc6a4f774191588d45 DIFF: https://github.com/llvm/llvm-project/commit/e94a35a744b780fcbe18e8bc6a4f774191588d45.diff

[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

steveire added a comment. In D95714#2532957 , @poelmanc wrote: > Thoughts on which option seems like the best path forward? I think you should be able to correctly match everything. Try a matcher like (can probably be cleaned up a bit): auto

[clang] 20b1c13 - Fix test in "CFG: Create scope for non-compound range-for body."

Author: James Y Knight Date: 2021-01-31T19:56:26-05:00 New Revision: 20b1c1300c8f00d85e1292158f865c1bd0d1e12c URL: https://github.com/llvm/llvm-project/commit/20b1c1300c8f00d85e1292158f865c1bd0d1e12c DIFF:

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

0x8000- added a comment. In D69764#2532952 , @sammccall wrote: > In D69764#2532666 , @MyDeveloperDay > wrote: > >>> What can be done to move this change along? >> >> I feel there has to be a fundamental

[clang] 8f670d5 - CFG: Create scope for non-compound range-for body.

Author: James Y Knight Date: 2021-01-31T18:43:00-05:00 New Revision: 8f670d5b6d8f39bf9bf1d142dacef3afaed6d70b URL: https://github.com/llvm/llvm-project/commit/8f670d5b6d8f39bf9bf1d142dacef3afaed6d70b DIFF:

[PATCH] D92403: [LSan][RISCV] Enable LSan for RISCV64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2de4f19ecdb2: [LSan][RISCV] Enable LSan for RISCV64 (authored by luismarques). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2de4f19 - [LSan][RISCV] Enable LSan for RISCV64

Author: Luís Marques Date: 2021-01-31T21:53:25Z New Revision: 2de4f19ecdb275bcbc6e7ee8368c19a63f99db88 URL: https://github.com/llvm/llvm-project/commit/2de4f19ecdb275bcbc6e7ee8368c19a63f99db88 DIFF: https://github.com/llvm/llvm-project/commit/2de4f19ecdb275bcbc6e7ee8368c19a63f99db88.diff LOG:

[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

poelmanc added a comment. In D95714#2532565 , @njames93 wrote: > This does highlight an issue where the mimicked std library stubs used for > tests don't correspond exactly to what the stdlib actually looks like and can > result in subtly different ASTs

[PATCH] D92403: [LSan][RISCV] Enable LSan for RISCV64

luismarques updated this revision to Diff 320375. luismarques added a comment. Herald added a subscriber: vkmr. Rebase and address formatting issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92403/new/ https://reviews.llvm.org/D92403 Files:

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

sammccall added a comment. In D69764#2532666 , @MyDeveloperDay wrote: >> What can be done to move this change along? > > I feel there has to be a fundamental acceptance that it is ok for > clang-format to alter code (something it already does with

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

jdoerfert added a comment. In D95764#2532927 , @JonChesterfield wrote: > I would have expected a nested match statement to hit on a subset of those > that matched in the parent. > > If (match x64) > If (match Intel) > > - expect x64 and intel to be true

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

JonChesterfield added a comment. I would have expected a nested match statement to hit on a subset of those that matched in the parent. If (match x64) If (match Intel) - expect x64 and intel to be true here I think that's how the normal openmp variant match works. Why do we want to diverge

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

jdoerfert added a comment. In D95764#2532908 , @tianshilei1992 wrote: > In D95764#2532877 , @jdoerfert wrote: > >> In D95764#2532875 , @tianshilei1992 >> wrote: >> >>> So

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

jdoerfert updated this revision to Diff 320371. jdoerfert added a comment. Herald added a reviewer: aaron.ballman. Update docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95764/new/ https://reviews.llvm.org/D95764 Files:

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

tianshilei1992 added a comment. In D95764#2532877 , @jdoerfert wrote: > In D95764#2532875 , @tianshilei1992 > wrote: > >> So I suppose D95765 can replace this >> patch, right? >

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

jdoerfert added a comment. In D95764#2532875 , @tianshilei1992 wrote: > So I suppose D95765 can replace this patch, > right? I think we want both. Propagating match clauses doesn't make sense to me so we should never

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

tianshilei1992 added a comment. So I suppose D95765 can replace this patch, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95764/new/ https://reviews.llvm.org/D95764

[PATCH] D95765: [OpenMP] Introduce the `disable_selector_propagation` variant selector trait

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, tianshilei1992. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: bollu. Herald added a reviewer: aaron.ballman. jdoerfert requested review of this revision. Herald added subscribers: llvm-commits,

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, tianshilei1992. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: bollu. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. If

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks added a comment. In D92257#2532077 , @MyDeveloperDay wrote: > I have a script that runs clang-format -n on various directories in clang > that are clang format clean, polly is one of them because they have clang > format as a unit test

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

HazardyKnusperkeks added a comment. In D69764#2532666 , @MyDeveloperDay wrote: >> What can be done to move this change along? > > I feel there has to be a fundamental acceptance that it is ok for > clang-format to alter code (something it already does

[clang-tools-extra] 7de711e - Reland [clangd] Quote/escape argv included in log messages.

Author: Sam McCall Date: 2021-01-31T16:39:47+01:00 New Revision: 7de711ecca99f81da3c2ae1705cefe0b4bda70b3 URL: https://github.com/llvm/llvm-project/commit/7de711ecca99f81da3c2ae1705cefe0b4bda70b3 DIFF: https://github.com/llvm/llvm-project/commit/7de711ecca99f81da3c2ae1705cefe0b4bda70b3.diff

[clang-tools-extra] 7a8008d - Revert "[clangd] Quote/escape argv included in log messages."

Author: Sam McCall Date: 2021-01-31T16:22:00+01:00 New Revision: 7a8008d0e8885d22ff9a1fa7f9965c7b2ad2569a URL: https://github.com/llvm/llvm-project/commit/7a8008d0e8885d22ff9a1fa7f9965c7b2ad2569a DIFF: https://github.com/llvm/llvm-project/commit/7a8008d0e8885d22ff9a1fa7f9965c7b2ad2569a.diff

[PATCH] D95759: [clangd] Rename: merge index/AST refs path-insensitively where needed

sammccall updated this revision to Diff 320353. sammccall added a comment. revert unintended formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95759/new/ https://reviews.llvm.org/D95759 Files:

[PATCH] D95759: [clangd] Rename: merge index/AST refs path-insensitively where needed

sammccall updated this revision to Diff 320352. sammccall added a comment. remove debug printfs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95759/new/ https://reviews.llvm.org/D95759 Files:

[PATCH] D95759: [clangd] Rename: merge index/AST refs path-insensitively where needed

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. If you have c:\foo open,

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

RedDocMD abandoned this revision. RedDocMD added a comment. I clearly am taking the wrong approach to this problem. I will need to reconsider how PointerToMember is actually modelled before solving this problem Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added a comment. > If it's a drop in replacement (does everything clang-format does and more), > what's the benefit for that cost? I'm in agreement here, It was a suggestion just to appease those who don't like clang-format doing such things, but still allowing us to add code

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. > What can be done to move this change along? I feel there has to be a fundamental acceptance that it is ok for clang-format to alter code (something it already does with sorting of includes, namespace comments). There were fairly strong opinions that

[clang-tools-extra] 60053a9 - [clangd] Remove references to old future-based API. NFC

Author: Sam McCall Date: 2021-01-31T12:13:20+01:00 New Revision: 60053a9ce28655fc6f635567c62599fa3aad57d2 URL: https://github.com/llvm/llvm-project/commit/60053a9ce28655fc6f635567c62599fa3aad57d2 DIFF: https://github.com/llvm/llvm-project/commit/60053a9ce28655fc6f635567c62599fa3aad57d2.diff

[clang-tools-extra] 0962f1d - [clangd] Quote/escape argv included in log messages.

Author: Sam McCall Date: 2021-01-31T12:00:08+01:00 New Revision: 0962f1d72b1606f3224a14434c7b4500a23f8728 URL: https://github.com/llvm/llvm-project/commit/0962f1d72b1606f3224a14434c7b4500a23f8728 DIFF: https://github.com/llvm/llvm-project/commit/0962f1d72b1606f3224a14434c7b4500a23f8728.diff

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

DaanDeMeyer added a comment. CI failures seem unrelated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95746/new/ https://reviews.llvm.org/D95746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 095f086 - [docs] Clarify compile_flags.txt subtleties

Author: Sam McCall Date: 2021-01-31T11:16:59+01:00 New Revision: 095f08653f3ab0917a474888abac95c4fa99697d URL: https://github.com/llvm/llvm-project/commit/095f08653f3ab0917a474888abac95c4fa99697d DIFF: https://github.com/llvm/llvm-project/commit/095f08653f3ab0917a474888abac95c4fa99697d.diff

[PATCH] D95366: [clang][cli] Generate and round-trip preprocessor options

jansvoboda11 updated this revision to Diff 320344. jansvoboda11 added a comment. Rebase, rename parse function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95366/new/ https://reviews.llvm.org/D95366 Files: clang/include/clang/Driver/Options.td

[PATCH] D95369: [clang][cli] Generate and round-trip analyzer options

jansvoboda11 updated this revision to Diff 320343. jansvoboda11 added a comment. Rebase, rename original parse function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95369/new/ https://reviews.llvm.org/D95369 Files:

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 updated this revision to Diff 320342. jansvoboda11 added a comment. Fix formatting and comment wording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94472/new/ https://reviews.llvm.org/D94472 Files: